Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
Quoting Diego Biurrun (2016-10-19 10:52:30) > On Tue, Oct 18, 2016 at 09:31:15PM +0200, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-10-14 01:15:32) > > > On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote: > > > > On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > > > > > --- /dev/null > > > > > +++ b/tests/fate/mov.mak > > > > > @@ -0,0 +1,12 @@ > > > > > +FATE_MOV += fate-mov-display-matrix > > > > > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry > > > > > matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > > + > > > > > +FATE_MOV += fate-mov-rotation > > > > > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry > > > > > rotation $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > > + > > > > > +FATE_MOV += fate-mov-ar > > > > > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > > + > > > > > +$(FATE_MOV): avprobe$(EXESUF) > > > > > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) > > > > > > > > ALLYES does not work this way, the second ',' is wrong. > > > > > > > > IMO this should go in probe.mak. That would also fix the deps, you are > > > > missing at least a dependency on the avprobe program. > > > > > > I'm blind today, you have the dependency of course. probe.mak still looks > > > like a better place to me. > > > > It really is not. Do not be confused by similar-sounding names, > > probe.mak is for testing avformat file type probing. This is for testing > > correct decoding of some mov feature, it has nothing to do with file > > type probing. > > I know the contents of probe.mak. I consider its contents tests for > demuxer-level properties that can be determined by avprobe, not just > for file type detection. "stuff that we test using avprobe" does not strike me as a good criterium for grouping tests. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Tue, Oct 18, 2016 at 09:31:15PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-10-14 01:15:32) > > On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote: > > > On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > > > > --- /dev/null > > > > +++ b/tests/fate/mov.mak > > > > @@ -0,0 +1,12 @@ > > > > +FATE_MOV += fate-mov-display-matrix > > > > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry > > > > matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > + > > > > +FATE_MOV += fate-mov-rotation > > > > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > > > > $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > + > > > > +FATE_MOV += fate-mov-ar > > > > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > + > > > > +$(FATE_MOV): avprobe$(EXESUF) > > > > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) > > > > > > ALLYES does not work this way, the second ',' is wrong. > > > > > > IMO this should go in probe.mak. That would also fix the deps, you are > > > missing at least a dependency on the avprobe program. > > > > I'm blind today, you have the dependency of course. probe.mak still looks > > like a better place to me. > > It really is not. Do not be confused by similar-sounding names, > probe.mak is for testing avformat file type probing. This is for testing > correct decoding of some mov feature, it has nothing to do with file > type probing. I know the contents of probe.mak. I consider its contents tests for demuxer-level properties that can be determined by avprobe, not just for file type detection. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
Quoting Diego Biurrun (2016-10-14 01:15:32) > On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote: > > On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > > > --- /dev/null > > > +++ b/tests/fate/mov.mak > > > @@ -0,0 +1,12 @@ > > > +FATE_MOV += fate-mov-display-matrix > > > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry > > > matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > + > > > +FATE_MOV += fate-mov-rotation > > > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > > > $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > + > > > +FATE_MOV += fate-mov-ar > > > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > + > > > +$(FATE_MOV): avprobe$(EXESUF) > > > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) > > > > ALLYES does not work this way, the second ',' is wrong. > > > > IMO this should go in probe.mak. That would also fix the deps, you are > > missing at least a dependency on the avprobe program. > > I'm blind today, you have the dependency of course. probe.mak still looks > like a better place to me. It really is not. Do not be confused by similar-sounding names, probe.mak is for testing avformat file type probing. This is for testing correct decoding of some mov feature, it has nothing to do with file type probing. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Mon, Oct 17, 2016 at 05:57:24PM -0400, Vittorio Giovara wrote: > Rotation, aspect ratio and pure matrix export. > > Signed-off-by: Vittorio Giovara > --- > Updated according to Diego's review. > I haven't split the AR tests, I think it makes sense to have it in a single > one, but if people strongly prefer the split version, I'll change it. > Vittorio Please split it. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] fate: Add tests for mov display matrix
Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- Updated according to Diego's review. I haven't split the AR tests, I think it makes sense to have it in a single one, but if people strongly prefer the split version, I'll change it. Vittorio tests/fate-run.sh | 4 tests/fate/probe.mak | 14 +- tests/ref/fate/mov-ar | 2 ++ tests/ref/fate/mov-display-matrix | 9 + tests/ref/fate/mov-rotation | 1 + 5 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mov-ar create mode 100644 tests/ref/fate/mov-display-matrix create mode 100644 tests/ref/fate/mov-rotation diff --git a/tests/fate-run.sh b/tests/fate-run.sh index d11ca3c..b1b299a 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -76,6 +76,10 @@ probefmt(){ run avprobe -show_format_entry format_name -v 0 "$@" } +probestream(){ +run avprobe -show_stream_entry "$1" -v 0 "$2" +} + avconv(){ dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type" avconv_args="-nostats -cpuflags $cpuflags" diff --git a/tests/fate/probe.mak b/tests/fate/probe.mak index 376dfdd..8b9b5dd 100644 --- a/tests/fate/probe.mak +++ b/tests/fate/probe.mak @@ -13,6 +13,18 @@ fate-probe-format-roundup2015: REF = dv FATE_SAMPLES-$(CONFIG_AVPROBE) += $(FATE_PROBE_FORMAT) fate-probe-format: $(FATE_PROBE_FORMAT) -$(FATE_PROBE_FORMAT): avprobe$(EXESUF) +FATE_MOV += fate-mov-display-matrix +fate-mov-display-matrix: CMD = probestream matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-rotation +fate-mov-rotation: CMD = probestream rotation $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-ar +fate-mov-ar: CMD = probestream sample_aspect_ratio $(TARGET_SAMPLES)/mov/displaymatrix.mov && probestream display_aspect_ratio $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_SAMPLES-$(call ALLYES, AVPROBE MOV_DEMUXER) += $(FATE_MOV) +fate-mov: $(FATE_MOV) + +$(FATE_PROBE_FORMAT) $(FATE_MOV): avprobe$(EXESUF) $(FATE_PROBE_FORMAT): CMP = oneline fate-probe-format-%: CMD = probefmt $(TARGET_SAMPLES)/probe-format/$(@:fate-probe-format-%=%) diff --git a/tests/ref/fate/mov-ar b/tests/ref/fate/mov-ar new file mode 100644 index 000..13cbd9c --- /dev/null +++ b/tests/ref/fate/mov-ar @@ -0,0 +1,2 @@ +9:2 +3:1 diff --git a/tests/ref/fate/mov-display-matrix b/tests/ref/fate/mov-display-matrix new file mode 100644 index 000..64c9599 --- /dev/null +++ b/tests/ref/fate/mov-display-matrix @@ -0,0 +1,9 @@ +0 +65536 +0 +-65536 +0 +0 +47185920 +0 +1073741824 diff --git a/tests/ref/fate/mov-rotation b/tests/ref/fate/mov-rotation new file mode 100644 index 000..64ded27 --- /dev/null +++ b/tests/ref/fate/mov-rotation @@ -0,0 +1 @@ +-90 -- 2.10.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Mon, Oct 17, 2016 at 01:47:32PM -0400, Vittorio Giovara wrote: > On Mon, Oct 17, 2016 at 1:30 PM, Diego Biurrun wrote: > > Looking at this in more detail now that the first round of review is over. > > > > On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: > >> --- a/tests/fate-run.sh > >> +++ b/tests/fate-run.sh > >> @@ -76,6 +76,11 @@ probefmt(){ > >> > >> +probear(){ > >> +run avprobe -show_stream_entry sample_aspect_ratio -v 0 "$@" > >> +run avprobe -show_stream_entry display_aspect_ratio -v 0 "$@" > >> +} > >> + > >> --- a/tests/fate/probe.mak > >> +++ b/tests/fate/probe.mak > >> @@ -16,3 +16,16 @@ fate-probe-format: $(FATE_PROBE_FORMAT) > >> $(FATE_PROBE_FORMAT): avprobe$(EXESUF) > >> +$(FATE_MOV): avprobe$(EXESUF) > > > > You are duplicating the dependency list, don't. > > How do you mean? Is it enough to do > $(FATE_PROBE_FORMAT) += $(FATE _MOV) $(FATE_PROBE_FORMAT) $(FATE_MOV): avprobe$(EXESUF) > >> +FATE_MOV += fate-mov-display-matrix > >> +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix > >> $(TARGET_SAMPLES)/mov/displaymatrix.mov > >> + > >> +FATE_MOV += fate-mov-rotation > >> +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > >> $(TARGET_SAMPLES)/mov/displaymatrix.mov > >> + > >> +FATE_MOV += fate-mov-ar > >> +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > > > This is inconsistent. You added a convenience function for the last > > test, but not for the first two. You could simply run the last test > > "manually" and then separate the tests for sar and dar - and separating > > tests is always a good thing IMO. Or you could add a convenience > > function that can be used in all tests. > > I know it's inconsistent, but I moved the AR tests in a separate > function because I thought it might usable in other tests, while > rotation and displaymatrix are something that are meaningful only for > mov. Just create one helper function for -show_stream_entry. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Mon, Oct 17, 2016 at 1:30 PM, Diego Biurrun wrote: > Looking at this in more detail now that the first round of review is over. > > On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: >> --- a/tests/fate-run.sh >> +++ b/tests/fate-run.sh >> @@ -76,6 +76,11 @@ probefmt(){ >> >> +probear(){ >> +run avprobe -show_stream_entry sample_aspect_ratio -v 0 "$@" >> +run avprobe -show_stream_entry display_aspect_ratio -v 0 "$@" >> +} >> + >> --- a/tests/fate/probe.mak >> +++ b/tests/fate/probe.mak >> @@ -16,3 +16,16 @@ fate-probe-format: $(FATE_PROBE_FORMAT) >> $(FATE_PROBE_FORMAT): avprobe$(EXESUF) >> +$(FATE_MOV): avprobe$(EXESUF) > > You are duplicating the dependency list, don't. How do you mean? Is it enough to do $(FATE_PROBE_FORMAT) += $(FATE _MOV) >> +FATE_MOV += fate-mov-display-matrix >> +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix >> $(TARGET_SAMPLES)/mov/displaymatrix.mov >> + >> +FATE_MOV += fate-mov-rotation >> +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation >> $(TARGET_SAMPLES)/mov/displaymatrix.mov >> + >> +FATE_MOV += fate-mov-ar >> +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > This is inconsistent. You added a convenience function for the last > test, but not for the first two. You could simply run the last test > "manually" and then separate the tests for sar and dar - and separating > tests is always a good thing IMO. Or you could add a convenience > function that can be used in all tests. I know it's inconsistent, but I moved the AR tests in a separate function because I thought it might usable in other tests, while rotation and displaymatrix are something that are meaningful only for mov. -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
Looking at this in more detail now that the first round of review is over. On Mon, Oct 17, 2016 at 11:54:04AM -0400, Vittorio Giovara wrote: > --- a/tests/fate-run.sh > +++ b/tests/fate-run.sh > @@ -76,6 +76,11 @@ probefmt(){ > > +probear(){ > +run avprobe -show_stream_entry sample_aspect_ratio -v 0 "$@" > +run avprobe -show_stream_entry display_aspect_ratio -v 0 "$@" > +} > + > --- a/tests/fate/probe.mak > +++ b/tests/fate/probe.mak > @@ -16,3 +16,16 @@ fate-probe-format: $(FATE_PROBE_FORMAT) > $(FATE_PROBE_FORMAT): avprobe$(EXESUF) > +$(FATE_MOV): avprobe$(EXESUF) You are duplicating the dependency list, don't. > +FATE_MOV += fate-mov-display-matrix > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix > $(TARGET_SAMPLES)/mov/displaymatrix.mov > + > +FATE_MOV += fate-mov-rotation > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > $(TARGET_SAMPLES)/mov/displaymatrix.mov > + > +FATE_MOV += fate-mov-ar > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov This is inconsistent. You added a convenience function for the last test, but not for the first two. You could simply run the last test "manually" and then separate the tests for sar and dar - and separating tests is always a good thing IMO. Or you could add a convenience function that can be used in all tests. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] fate: Add tests for mov display matrix
Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- tests/fate-run.sh | 5 + tests/fate/probe.mak | 13 + tests/ref/fate/mov-ar | 2 ++ tests/ref/fate/mov-display-matrix | 9 + tests/ref/fate/mov-rotation | 1 + 5 files changed, 30 insertions(+) create mode 100644 tests/ref/fate/mov-ar create mode 100644 tests/ref/fate/mov-display-matrix create mode 100644 tests/ref/fate/mov-rotation diff --git a/tests/fate-run.sh b/tests/fate-run.sh index d11ca3c..d1b4aef 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -76,6 +76,11 @@ probefmt(){ run avprobe -show_format_entry format_name -v 0 "$@" } +probear(){ +run avprobe -show_stream_entry sample_aspect_ratio -v 0 "$@" +run avprobe -show_stream_entry display_aspect_ratio -v 0 "$@" +} + avconv(){ dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type" avconv_args="-nostats -cpuflags $cpuflags" diff --git a/tests/fate/probe.mak b/tests/fate/probe.mak index 376dfdd..4659a9a 100644 --- a/tests/fate/probe.mak +++ b/tests/fate/probe.mak @@ -16,3 +16,16 @@ fate-probe-format: $(FATE_PROBE_FORMAT) $(FATE_PROBE_FORMAT): avprobe$(EXESUF) $(FATE_PROBE_FORMAT): CMP = oneline fate-probe-format-%: CMD = probefmt $(TARGET_SAMPLES)/probe-format/$(@:fate-probe-format-%=%) + +FATE_MOV += fate-mov-display-matrix +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-rotation +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-ar +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov + +$(FATE_MOV): avprobe$(EXESUF) +FATE_SAMPLES-$(call ALLYES, AVPROBE MOV_DEMUXER) += $(FATE_MOV) +fate-mov: $(FATE_MOV) diff --git a/tests/ref/fate/mov-ar b/tests/ref/fate/mov-ar new file mode 100644 index 000..13cbd9c --- /dev/null +++ b/tests/ref/fate/mov-ar @@ -0,0 +1,2 @@ +9:2 +3:1 diff --git a/tests/ref/fate/mov-display-matrix b/tests/ref/fate/mov-display-matrix new file mode 100644 index 000..64c9599 --- /dev/null +++ b/tests/ref/fate/mov-display-matrix @@ -0,0 +1,9 @@ +0 +65536 +0 +-65536 +0 +0 +47185920 +0 +1073741824 diff --git a/tests/ref/fate/mov-rotation b/tests/ref/fate/mov-rotation new file mode 100644 index 000..64ded27 --- /dev/null +++ b/tests/ref/fate/mov-rotation @@ -0,0 +1 @@ +-90 -- 2.10.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote: > On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > > --- /dev/null > > +++ b/tests/fate/mov.mak > > @@ -0,0 +1,12 @@ > > +FATE_MOV += fate-mov-display-matrix > > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix > > $(TARGET_SAMPLES)/mov/displaymatrix.mov > > + > > +FATE_MOV += fate-mov-rotation > > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > > $(TARGET_SAMPLES)/mov/displaymatrix.mov > > + > > +FATE_MOV += fate-mov-ar > > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > > + > > +$(FATE_MOV): avprobe$(EXESUF) > > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) > > ALLYES does not work this way, the second ',' is wrong. > > IMO this should go in probe.mak. That would also fix the deps, you are > missing at least a dependency on the avprobe program. I'm blind today, you have the dependency of course. probe.mak still looks like a better place to me. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix
On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > --- /dev/null > +++ b/tests/fate/mov.mak > @@ -0,0 +1,12 @@ > +FATE_MOV += fate-mov-display-matrix > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix > $(TARGET_SAMPLES)/mov/displaymatrix.mov > + > +FATE_MOV += fate-mov-rotation > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation > $(TARGET_SAMPLES)/mov/displaymatrix.mov > + > +FATE_MOV += fate-mov-ar > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov > + > +$(FATE_MOV): avprobe$(EXESUF) > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) ALLYES does not work this way, the second ',' is wrong. IMO this should go in probe.mak. That would also fix the deps, you are missing at least a dependency on the avprobe program. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] fate: Add tests for mov display matrix
Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- tests/Makefile| 1 + tests/fate-run.sh | 5 + tests/fate/mov.mak| 12 tests/ref/fate/mov-ar | 2 ++ tests/ref/fate/mov-display-matrix | 9 + tests/ref/fate/mov-rotation | 1 + 6 files changed, 30 insertions(+) create mode 100644 tests/fate/mov.mak create mode 100644 tests/ref/fate/mov-ar create mode 100644 tests/ref/fate/mov-display-matrix create mode 100644 tests/ref/fate/mov-rotation diff --git a/tests/Makefile b/tests/Makefile index 36a3a72..0e475a2 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -97,6 +97,7 @@ include $(SRC_PATH)/tests/fate/lossless-audio.mak include $(SRC_PATH)/tests/fate/lossless-video.mak include $(SRC_PATH)/tests/fate/microsoft.mak include $(SRC_PATH)/tests/fate/monkeysaudio.mak +include $(SRC_PATH)/tests/fate/mov.mak include $(SRC_PATH)/tests/fate/mp3.mak include $(SRC_PATH)/tests/fate/mpc.mak include $(SRC_PATH)/tests/fate/mpeg4.mak diff --git a/tests/fate-run.sh b/tests/fate-run.sh index d11ca3c..d1b4aef 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -76,6 +76,11 @@ probefmt(){ run avprobe -show_format_entry format_name -v 0 "$@" } +probear(){ +run avprobe -show_stream_entry sample_aspect_ratio -v 0 "$@" +run avprobe -show_stream_entry display_aspect_ratio -v 0 "$@" +} + avconv(){ dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type" avconv_args="-nostats -cpuflags $cpuflags" diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak new file mode 100644 index 000..cbe34c2 --- /dev/null +++ b/tests/fate/mov.mak @@ -0,0 +1,12 @@ +FATE_MOV += fate-mov-display-matrix +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-rotation +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation $(TARGET_SAMPLES)/mov/displaymatrix.mov + +FATE_MOV += fate-mov-ar +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov + +$(FATE_MOV): avprobe$(EXESUF) +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV) +fate-mov: $(FATE_MOV) diff --git a/tests/ref/fate/mov-ar b/tests/ref/fate/mov-ar new file mode 100644 index 000..13cbd9c --- /dev/null +++ b/tests/ref/fate/mov-ar @@ -0,0 +1,2 @@ +9:2 +3:1 diff --git a/tests/ref/fate/mov-display-matrix b/tests/ref/fate/mov-display-matrix new file mode 100644 index 000..64c9599 --- /dev/null +++ b/tests/ref/fate/mov-display-matrix @@ -0,0 +1,9 @@ +0 +65536 +0 +-65536 +0 +0 +47185920 +0 +1073741824 diff --git a/tests/ref/fate/mov-rotation b/tests/ref/fate/mov-rotation new file mode 100644 index 000..64ded27 --- /dev/null +++ b/tests/ref/fate/mov-rotation @@ -0,0 +1 @@ +-90 -- 2.10.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel