Re: [libav-devel] [PATCH] h264: namespace the decode function

2013-12-28 Thread Anton Khirnov 

On Sat, 28 Dec 2013 16:28:36 +0100, Hendrik Leppkes  wrote:
> Am 28.12.2013 14:58 schrieb "Luca Barbato" :
> >
> > Make much easier debugging.
> > ---
> 
> Didn't I see patches before removing unnecessary prefixes like this?
> 

Not that I can remember.

patch fine with me FWIW

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] h264: namespace the decode function

2013-12-28 Thread Hendrik Leppkes 
Am 28.12.2013 14:58 schrieb "Luca Barbato" :
>
> Make much easier debugging.
> ---

Didn't I see patches before removing unnecessary prefixes like this?

- Hendrik
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] h264: namespace the decode function

2013-12-28 Thread Tim W. 
Sent from my iPhone

> On Dec 28, 2013, at 2:58 PM, Luca Barbato  wrote:
> 
> Make much easier debugging.
> ---
> libavcodec/h264.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavcodec/h264.c b/libavcodec/h264.c
> index 07a93cf..f610d71 100644
> --- a/libavcodec/h264.c
> +++ b/libavcodec/h264.c
> @@ -4853,8 +4853,8 @@ static int output_frame(H264Context *h, AVFrame *dst, 
> AVFrame *src)
> return 0;
> }
> 
> -static int decode_frame(AVCodecContext *avctx, void *data,
> -int *got_frame, AVPacket *avpkt)
> +static int h264_decode_frame(AVCodecContext *avctx, void *data,
> + int *got_frame, AVPacket *avpkt)
> {
> const uint8_t *buf = avpkt->data;
> int buf_size   = avpkt->size;
> @@ -4989,7 +4989,7 @@ AVCodec ff_h264_decoder = {
> .priv_data_size= sizeof(H264Context),
> .init  = ff_h264_decode_init,
> .close = h264_decode_end,
> -.decode= decode_frame,
> +.decode= h264_decode_frame,
> .capabilities  = /*CODEC_CAP_DRAW_HORIZ_BAND |*/ CODEC_CAP_DR1 |
>  CODEC_CAP_DELAY | CODEC_CAP_SLICE_THREADS

LGTM.

Tim
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] h264: namespace the decode function

2013-12-28 Thread Luca Barbato 
Make much easier debugging.
---
 libavcodec/h264.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 07a93cf..f610d71 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -4853,8 +4853,8 @@ static int output_frame(H264Context *h, AVFrame *dst, 
AVFrame *src)
 return 0;
 }

-static int decode_frame(AVCodecContext *avctx, void *data,
-int *got_frame, AVPacket *avpkt)
+static int h264_decode_frame(AVCodecContext *avctx, void *data,
+ int *got_frame, AVPacket *avpkt)
 {
 const uint8_t *buf = avpkt->data;
 int buf_size   = avpkt->size;
@@ -4989,7 +4989,7 @@ AVCodec ff_h264_decoder = {
 .priv_data_size= sizeof(H264Context),
 .init  = ff_h264_decode_init,
 .close = h264_decode_end,
-.decode= decode_frame,
+.decode= h264_decode_frame,
 .capabilities  = /*CODEC_CAP_DRAW_HORIZ_BAND |*/ CODEC_CAP_DR1 |
  CODEC_CAP_DELAY | CODEC_CAP_SLICE_THREADS |
  CODEC_CAP_FRAME_THREADS,
--
1.8.5.1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel