Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Vittorio Giovara 
On Wed, Apr 5, 2017 at 5:40 PM, wm4  wrote:
> On Wed, 5 Apr 2017 17:22:53 +0200
> Diego Biurrun  wrote:
>
>> On Wed, Apr 05, 2017 at 05:16:24PM +0200, wm4 wrote:
>> > On Wed, 5 Apr 2017 16:27:48 +0200
>> > Vittorio Giovara  wrote:
>> > > On Wed, Apr 5, 2017 at 4:11 PM, wm4  wrote:
>> > > > On Wed,  5 Apr 2017 15:35:26 +0200
>> > > > Vittorio Giovara  wrote:
>> > > >> --- a/libavfilter/avfiltergraph.h
>> > > >> +++ /dev/null
>> > > >> @@ -1,29 +0,0 @@
>> > > >> -#ifndef AVFILTER_AVFILTERGRAPH_H
>> > > >> -#define AVFILTER_AVFILTERGRAPH_H
>> > > >> -
>> > > >> -#include "avfilter.h"
>> > > >> -#include "libavutil/log.h"
>> > > >> -
>> > > >> -
>> > > >> -#endif /* AVFILTER_AVFILTERGRAPH_H */
>> > > >
>> > > > I guess I should remove it from my code?
>> > >
>> > > I suppose so, it was well advertised in the APIchange document and
>> > > this is breaking season :)
>> >
>> > How is anyone supposed to notice/remember that? Maybe put a "#warning"
>> > into the header when it's deprecated? (Not sure how standard that is,
>> > but it could be put under gcc/clang guards.)
>>
>> It's not standard. That's why we removed all #warning directives from the
>> codebase a long time ago.
>
> You could put in a declaration that uses a deprecated symbol, and thus
> causes a deprecation warning. No idea whether that would work either.

I'd be ok with that, if you think delaying removal of an empty header
is important for downstream, do you think you could send a patch that
implements what you propose?
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread wm4 
On Wed, 5 Apr 2017 17:22:53 +0200
Diego Biurrun  wrote:

> On Wed, Apr 05, 2017 at 05:16:24PM +0200, wm4 wrote:
> > On Wed, 5 Apr 2017 16:27:48 +0200
> > Vittorio Giovara  wrote:  
> > > On Wed, Apr 5, 2017 at 4:11 PM, wm4  wrote:  
> > > > On Wed,  5 Apr 2017 15:35:26 +0200
> > > > Vittorio Giovara  wrote:  
> > > >> --- a/libavfilter/avfiltergraph.h
> > > >> +++ /dev/null
> > > >> @@ -1,29 +0,0 @@
> > > >> -#ifndef AVFILTER_AVFILTERGRAPH_H
> > > >> -#define AVFILTER_AVFILTERGRAPH_H
> > > >> -
> > > >> -#include "avfilter.h"
> > > >> -#include "libavutil/log.h"
> > > >> -
> > > >> -
> > > >> -#endif /* AVFILTER_AVFILTERGRAPH_H */
> > > >
> > > > I guess I should remove it from my code?
> > > 
> > > I suppose so, it was well advertised in the APIchange document and
> > > this is breaking season :)  
> > 
> > How is anyone supposed to notice/remember that? Maybe put a "#warning"
> > into the header when it's deprecated? (Not sure how standard that is,
> > but it could be put under gcc/clang guards.)  
> 
> It's not standard. That's why we removed all #warning directives from the
> codebase a long time ago.

You could put in a declaration that uses a deprecated symbol, and thus
causes a deprecation warning. No idea whether that would work either.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Diego Biurrun 
On Wed, Apr 05, 2017 at 03:35:26PM +0200, Vittorio Giovara wrote:
> This header was public but deprecated on 2013-04-11 (lavfi 3.8.0).
> ---
>  libavfilter/Makefile|  1 -
>  libavfilter/avfiltergraph.h | 29 -
>  2 files changed, 30 deletions(-)
>  delete mode 100644 libavfilter/avfiltergraph.h

OK

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Diego Biurrun 
On Wed, Apr 05, 2017 at 05:16:24PM +0200, wm4 wrote:
> On Wed, 5 Apr 2017 16:27:48 +0200
> Vittorio Giovara  wrote:
> > On Wed, Apr 5, 2017 at 4:11 PM, wm4  wrote:
> > > On Wed,  5 Apr 2017 15:35:26 +0200
> > > Vittorio Giovara  wrote:
> > >> --- a/libavfilter/avfiltergraph.h
> > >> +++ /dev/null
> > >> @@ -1,29 +0,0 @@
> > >> -#ifndef AVFILTER_AVFILTERGRAPH_H
> > >> -#define AVFILTER_AVFILTERGRAPH_H
> > >> -
> > >> -#include "avfilter.h"
> > >> -#include "libavutil/log.h"
> > >> -
> > >> -
> > >> -#endif /* AVFILTER_AVFILTERGRAPH_H */  
> > >
> > > I guess I should remove it from my code?  
> > 
> > I suppose so, it was well advertised in the APIchange document and
> > this is breaking season :)
> 
> How is anyone supposed to notice/remember that? Maybe put a "#warning"
> into the header when it's deprecated? (Not sure how standard that is,
> but it could be put under gcc/clang guards.)

It's not standard. That's why we removed all #warning directives from the
codebase a long time ago.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread wm4 
On Wed, 5 Apr 2017 16:27:48 +0200
Vittorio Giovara  wrote:

> On Wed, Apr 5, 2017 at 4:11 PM, wm4  wrote:
> > On Wed,  5 Apr 2017 15:35:26 +0200
> > Vittorio Giovara  wrote:
> >  
> >> This header was public but deprecated on 2013-04-11 (lavfi 3.8.0).
> >> ---
> >>  libavfilter/Makefile|  1 -
> >>  libavfilter/avfiltergraph.h | 29 -
> >>  2 files changed, 30 deletions(-)
> >>  delete mode 100644 libavfilter/avfiltergraph.h
> >>
> >> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> >> index c8d1515d2c..348ad92116 100644
> >> --- a/libavfilter/Makefile
> >> +++ b/libavfilter/Makefile
> >> @@ -2,7 +2,6 @@ NAME = avfilter
> >>  DESC = Libav video filtering library
> >>
> >>  HEADERS = avfilter.h\
> >> -  avfiltergraph.h   \
> >>buffersink.h  \
> >>buffersrc.h   \
> >>version.h \
> >> diff --git a/libavfilter/avfiltergraph.h b/libavfilter/avfiltergraph.h
> >> deleted file mode 100644
> >> index 47174efc6c..00
> >> --- a/libavfilter/avfiltergraph.h
> >> +++ /dev/null
> >> @@ -1,29 +0,0 @@
> >> -/*
> >> - * Filter graphs
> >> - * copyright (c) 2007 Bobby Bingham
> >> - *
> >> - * This file is part of Libav.
> >> - *
> >> - * Libav is free software; you can redistribute it and/or
> >> - * modify it under the terms of the GNU Lesser General Public
> >> - * License as published by the Free Software Foundation; either
> >> - * version 2.1 of the License, or (at your option) any later version.
> >> - *
> >> - * Libav is distributed in the hope that it will be useful,
> >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> >> - * Lesser General Public License for more details.
> >> - *
> >> - * You should have received a copy of the GNU Lesser General Public
> >> - * License along with Libav; if not, write to the Free Software
> >> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
> >> 02110-1301 USA
> >> - */
> >> -
> >> -#ifndef AVFILTER_AVFILTERGRAPH_H
> >> -#define AVFILTER_AVFILTERGRAPH_H
> >> -
> >> -#include "avfilter.h"
> >> -#include "libavutil/log.h"
> >> -
> >> -
> >> -#endif /* AVFILTER_AVFILTERGRAPH_H */  
> >
> > I guess I should remove it from my code?  
> 
> I suppose so, it was well advertised in the APIchange document and
> this is breaking season :)

How is anyone supposed to notice/remember that? Maybe put a "#warning"
into the header when it's deprecated? (Not sure how standard that is,
but it could be put under gcc/clang guards.)
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Vittorio Giovara 
On Wed, Apr 5, 2017 at 4:11 PM, wm4  wrote:
> On Wed,  5 Apr 2017 15:35:26 +0200
> Vittorio Giovara  wrote:
>
>> This header was public but deprecated on 2013-04-11 (lavfi 3.8.0).
>> ---
>>  libavfilter/Makefile|  1 -
>>  libavfilter/avfiltergraph.h | 29 -
>>  2 files changed, 30 deletions(-)
>>  delete mode 100644 libavfilter/avfiltergraph.h
>>
>> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
>> index c8d1515d2c..348ad92116 100644
>> --- a/libavfilter/Makefile
>> +++ b/libavfilter/Makefile
>> @@ -2,7 +2,6 @@ NAME = avfilter
>>  DESC = Libav video filtering library
>>
>>  HEADERS = avfilter.h\
>> -  avfiltergraph.h   \
>>buffersink.h  \
>>buffersrc.h   \
>>version.h \
>> diff --git a/libavfilter/avfiltergraph.h b/libavfilter/avfiltergraph.h
>> deleted file mode 100644
>> index 47174efc6c..00
>> --- a/libavfilter/avfiltergraph.h
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -/*
>> - * Filter graphs
>> - * copyright (c) 2007 Bobby Bingham
>> - *
>> - * This file is part of Libav.
>> - *
>> - * Libav is free software; you can redistribute it and/or
>> - * modify it under the terms of the GNU Lesser General Public
>> - * License as published by the Free Software Foundation; either
>> - * version 2.1 of the License, or (at your option) any later version.
>> - *
>> - * Libav is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> - * Lesser General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU Lesser General Public
>> - * License along with Libav; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
>> USA
>> - */
>> -
>> -#ifndef AVFILTER_AVFILTERGRAPH_H
>> -#define AVFILTER_AVFILTERGRAPH_H
>> -
>> -#include "avfilter.h"
>> -#include "libavutil/log.h"
>> -
>> -
>> -#endif /* AVFILTER_AVFILTERGRAPH_H */
>
> I guess I should remove it from my code?

I suppose so, it was well advertised in the APIchange document and
this is breaking season :)
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread wm4 
On Wed,  5 Apr 2017 15:35:26 +0200
Vittorio Giovara  wrote:

> This header was public but deprecated on 2013-04-11 (lavfi 3.8.0).
> ---
>  libavfilter/Makefile|  1 -
>  libavfilter/avfiltergraph.h | 29 -
>  2 files changed, 30 deletions(-)
>  delete mode 100644 libavfilter/avfiltergraph.h
> 
> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> index c8d1515d2c..348ad92116 100644
> --- a/libavfilter/Makefile
> +++ b/libavfilter/Makefile
> @@ -2,7 +2,6 @@ NAME = avfilter
>  DESC = Libav video filtering library
>  
>  HEADERS = avfilter.h\
> -  avfiltergraph.h   \
>buffersink.h  \
>buffersrc.h   \
>version.h \
> diff --git a/libavfilter/avfiltergraph.h b/libavfilter/avfiltergraph.h
> deleted file mode 100644
> index 47174efc6c..00
> --- a/libavfilter/avfiltergraph.h
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/*
> - * Filter graphs
> - * copyright (c) 2007 Bobby Bingham
> - *
> - * This file is part of Libav.
> - *
> - * Libav is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU Lesser General Public
> - * License as published by the Free Software Foundation; either
> - * version 2.1 of the License, or (at your option) any later version.
> - *
> - * Libav is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> - * Lesser General Public License for more details.
> - *
> - * You should have received a copy of the GNU Lesser General Public
> - * License along with Libav; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
> - */
> -
> -#ifndef AVFILTER_AVFILTERGRAPH_H
> -#define AVFILTER_AVFILTERGRAPH_H
> -
> -#include "avfilter.h"
> -#include "libavutil/log.h"
> -
> -
> -#endif /* AVFILTER_AVFILTERGRAPH_H */

I guess I should remove it from my code?
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] lavfi: Drop unused and empty header file

2017-04-05 Thread Vittorio Giovara 
This header was public but deprecated on 2013-04-11 (lavfi 3.8.0).
---
 libavfilter/Makefile|  1 -
 libavfilter/avfiltergraph.h | 29 -
 2 files changed, 30 deletions(-)
 delete mode 100644 libavfilter/avfiltergraph.h

diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index c8d1515d2c..348ad92116 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -2,7 +2,6 @@ NAME = avfilter
 DESC = Libav video filtering library
 
 HEADERS = avfilter.h\
-  avfiltergraph.h   \
   buffersink.h  \
   buffersrc.h   \
   version.h \
diff --git a/libavfilter/avfiltergraph.h b/libavfilter/avfiltergraph.h
deleted file mode 100644
index 47174efc6c..00
--- a/libavfilter/avfiltergraph.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Filter graphs
- * copyright (c) 2007 Bobby Bingham
- *
- * This file is part of Libav.
- *
- * Libav is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * Libav is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with Libav; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-#ifndef AVFILTER_AVFILTERGRAPH_H
-#define AVFILTER_AVFILTERGRAPH_H
-
-#include "avfilter.h"
-#include "libavutil/log.h"
-
-
-#endif /* AVFILTER_AVFILTERGRAPH_H */
-- 
2.12.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel