Re: [libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Aℓex Converse
On Mon, Apr 11, 2011 at 2:24 PM, Luca Barbato  wrote:
> On 04/11/2011 11:14 PM, Manjunath Siddaiah wrote:
>> Hi,
>>
>> When we do "-acodec  copy" if input is "mpegts" and output is non-mpegts
>> ( MOV, MP4, 3GP, FLV, ISM) ADTS header also got copied.
>> AAC audio do not need ADTS header in MOV, MP4, 3GP, FLV, ISM containers.
>> This patch skips the ADTS header copying to non-mpegts formats.
>
> Does forcing the global header solve it ? The proposed patch looks
> wrong, the reported bug is real though.
>

-absf aac_adtstoasc

Once upon a time there was a patch pending to automatically insert
BSFs when needed.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Luca Barbato
On 04/11/2011 11:14 PM, Manjunath Siddaiah wrote:
> Hi,
> 
> When we do "-acodec  copy" if input is "mpegts" and output is non-mpegts
> ( MOV, MP4, 3GP, FLV, ISM) ADTS header also got copied.
> AAC audio do not need ADTS header in MOV, MP4, 3GP, FLV, ISM containers.
> This patch skips the ADTS header copying to non-mpegts formats.

Does forcing the global header solve it ? The proposed patch looks
wrong, the reported bug is real though.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


[libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Manjunath Siddaiah
Hi,

When we do "-acodec  copy" if input is "mpegts" and output is non-mpegts ( MOV, 
MP4, 3GP, FLV, ISM) ADTS header also got copied. AAC audio do not need ADTS 
header in MOV, MP4, 3GP, FLV, ISM containers. This patch skips the ADTS header 
copying to non-mpegts formats.

-Manjunath H Siddaiah


Skip_ADTS_header_forAAC_CoipedFrom_mpegts_to_non-mpegts.patch
Description: Skip_ADTS_header_forAAC_CoipedFrom_mpegts_to_non-mpegts.patch
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel