[libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Luca Barbato
It is used only for x86 so it will be moved once the code is moved in
the arch dir

Question: should we build an accurate BGR2YV12 variant?
---
 libswscale/rgb2rgb.c  |2 --
 libswscale/swscale.c  |2 --
 libswscale/swscale_internal.h |2 ++
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c
index 32cc00b..9f9ae70 100644
--- a/libswscale/rgb2rgb.c
+++ b/libswscale/rgb2rgb.c
@@ -30,8 +30,6 @@
 #include swscale.h
 #include swscale_internal.h
 
-#define FAST_BGR2YV12 // use 7-bit instead of 15-bit coefficients
-
 #if ARCH_X86
 DECLARE_ASM_CONST(8, uint64_t, mmx_ff)   = 0x00FFULL;
 DECLARE_ASM_CONST(8, uint64_t, mmx_null) = 0xULL;
diff --git a/libswscale/swscale.c b/libswscale/swscale.c
index ed6db72..565743a 100644
--- a/libswscale/swscale.c
+++ b/libswscale/swscale.c
@@ -76,8 +76,6 @@ untested special converters
 //#undef ARCH_X86
 #define DITHER1XBPP
 
-#define FAST_BGR2YV12 // use 7 bit coefficients instead of 15 bit
-
 #define isPacked(x) (   \
(x)==PIX_FMT_PAL8\
 || (x)==PIX_FMT_YUYV422 \
diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h
index 631f1e0..4c6ad2a 100644
--- a/libswscale/swscale_internal.h
+++ b/libswscale/swscale_internal.h
@@ -31,6 +31,8 @@
 
 #define STR(s) AV_TOSTRING(s) //AV_STRINGIFY is too long
 
+#define FAST_BGR2YV12 //use 7-bit instead of 15-bit coefficients
+
 #define MAX_FILTER_SIZE 256
 
 #if ARCH_X86
-- 
1.7.4.1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:35AM +0200, Luca Barbato wrote:
 It is used only for x86 so it will be moved once the code is moved in
 the arch dir
 
 Question: should we build an accurate BGR2YV12 variant?

maybe when we have optimisations for it
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:13:29AM +0200, Kostya wrote:
 On Mon, Apr 11, 2011 at 11:07:35AM +0200, Luca Barbato wrote:
  It is used only for x86 so it will be moved once the code is moved in
  the arch dir
  
  Question: should we build an accurate BGR2YV12 variant?
 
 maybe when we have optimisations for it

meanwhile it looks ok
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel