Re: [libav-devel] [PATCH 1/2] vf_showinfo: Simplify reporting stereo3d information

[Luca Barbato]

On 15/03/2017 22:55, Vittorio Giovara wrote:
> ---
>  libavfilter/vf_showinfo.c | 14 +-
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
> index 204ff7a857..b44f3d2bf2 100644
> --- a/libavfilter/vf_showinfo.c
> +++ b/libavfilter/vf_showinfo.c
> @@ -51,19 +51,7 @@ static void dump_stereo3d(AVFilterContext *ctx, 
> AVFrameSideData *sd)
>  
>  stereo = (AVStereo3D *)sd->data;
>  
> -av_log(ctx, AV_LOG_INFO, "type - ");
> -switch (stereo->type) {
> -case AV_STEREO3D_2D:  av_log(ctx, AV_LOG_INFO, "2D");
>  break;
> -case AV_STEREO3D_SIDEBYSIDE:  av_log(ctx, AV_LOG_INFO, "side by 
> side");   break;
> -case AV_STEREO3D_TOPBOTTOM:   av_log(ctx, AV_LOG_INFO, "top and 
> bottom"); break;
> -case AV_STEREO3D_FRAMESEQUENCE:   av_log(ctx, AV_LOG_INFO, "frame 
> alternate");break;
> -case AV_STEREO3D_CHECKERBOARD:av_log(ctx, AV_LOG_INFO, 
> "checkerboard");   break;
> -case AV_STEREO3D_LINES:   av_log(ctx, AV_LOG_INFO, 
> "interleaved lines");  break;
> -case AV_STEREO3D_COLUMNS: av_log(ctx, AV_LOG_INFO, 
> "interleaved columns");break;
> -case AV_STEREO3D_SIDEBYSIDE_QUINCUNX: av_log(ctx, AV_LOG_INFO, "side by 
> side "
> -   
> "(quincunx subsampling)"); break;
> -default:  av_log(ctx, AV_LOG_WARNING, 
> "unknown"); break;
> -}
> +av_log(ctx, AV_LOG_INFO, "type - %s", 
> av_stereo3d_type_name(stereo->type));
>  
>  if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
>  av_log(ctx, AV_LOG_INFO, " (inverted)");
> 

Ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/2] vf_showinfo: Simplify reporting stereo3d information

[Vittorio Giovara]

---
 libavfilter/vf_showinfo.c | 14 +-
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 204ff7a857..b44f3d2bf2 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -51,19 +51,7 @@ static void dump_stereo3d(AVFilterContext *ctx, 
AVFrameSideData *sd)
 
 stereo = (AVStereo3D *)sd->data;
 
-av_log(ctx, AV_LOG_INFO, "type - ");
-switch (stereo->type) {
-case AV_STEREO3D_2D:  av_log(ctx, AV_LOG_INFO, "2D");  
   break;
-case AV_STEREO3D_SIDEBYSIDE:  av_log(ctx, AV_LOG_INFO, "side by 
side");   break;
-case AV_STEREO3D_TOPBOTTOM:   av_log(ctx, AV_LOG_INFO, "top and 
bottom"); break;
-case AV_STEREO3D_FRAMESEQUENCE:   av_log(ctx, AV_LOG_INFO, "frame 
alternate");break;
-case AV_STEREO3D_CHECKERBOARD:av_log(ctx, AV_LOG_INFO, 
"checkerboard");   break;
-case AV_STEREO3D_LINES:   av_log(ctx, AV_LOG_INFO, 
"interleaved lines");  break;
-case AV_STEREO3D_COLUMNS: av_log(ctx, AV_LOG_INFO, 
"interleaved columns");break;
-case AV_STEREO3D_SIDEBYSIDE_QUINCUNX: av_log(ctx, AV_LOG_INFO, "side by 
side "
-   "(quincunx 
subsampling)"); break;
-default:  av_log(ctx, AV_LOG_WARNING, 
"unknown"); break;
-}
+av_log(ctx, AV_LOG_INFO, "type - %s", av_stereo3d_type_name(stereo->type));
 
 if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
 av_log(ctx, AV_LOG_INFO, " (inverted)");
-- 
2.12.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel