Re: [libav-devel] [PATCH 1/4] h264: mark the currently active SPS as const

[Vittorio Giovara]

On Wed, Feb 1, 2017 at 10:25 AM, Anton Khirnov  wrote:
> It is never modified anymore.
> ---
>  libavcodec/h264_ps.h| 3 +--
>  libavcodec/h264_slice.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/h264_ps.h b/libavcodec/h264_ps.h
> index 9a32d93..1b482f3 100644
> --- a/libavcodec/h264_ps.h
> +++ b/libavcodec/h264_ps.h
> @@ -136,8 +136,7 @@ typedef struct H264ParamSets {
>
>  /* currently active parameters sets */
>  const PPS *pps;
> -// FIXME this should properly be const
> -SPS *sps;
> +const SPS *sps;
>  } H264ParamSets;
>
>  /**
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index f1f5fc0..aa6d951 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -799,7 +799,7 @@ static enum AVPixelFormat get_pixel_format(H264Context *h)
>  /* export coded and cropped frame dimensions to AVCodecContext */
>  static int init_dimensions(H264Context *h)
>  {
> -SPS *sps = h->ps.sps;
> +const SPS *sps = h->ps.sps;
>  int cr = sps->crop_right;
>  int cl = sps->crop_left;
>  int ct = sps->crop_top;
> --

ok
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/4] h264: mark the currently active SPS as const

[Anton Khirnov]

It is never modified anymore.
---
 libavcodec/h264_ps.h| 3 +--
 libavcodec/h264_slice.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/libavcodec/h264_ps.h b/libavcodec/h264_ps.h
index 9a32d93..1b482f3 100644
--- a/libavcodec/h264_ps.h
+++ b/libavcodec/h264_ps.h
@@ -136,8 +136,7 @@ typedef struct H264ParamSets {
 
 /* currently active parameters sets */
 const PPS *pps;
-// FIXME this should properly be const
-SPS *sps;
+const SPS *sps;
 } H264ParamSets;
 
 /**
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index f1f5fc0..aa6d951 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -799,7 +799,7 @@ static enum AVPixelFormat get_pixel_format(H264Context *h)
 /* export coded and cropped frame dimensions to AVCodecContext */
 static int init_dimensions(H264Context *h)
 {
-SPS *sps = h->ps.sps;
+const SPS *sps = h->ps.sps;
 int cr = sps->crop_right;
 int cl = sps->crop_left;
 int ct = sps->crop_top;
-- 
2.0.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel