Re: [libav-devel] [PATCH 3/4] h264dec: replace a pointless ref+unref with move_ref

2017-02-01 Thread Vittorio Giovara 
On Wed, Feb 1, 2017 at 10:25 AM, Anton Khirnov  wrote:
> ---
>  libavcodec/h264dec.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c
> index b92795d..6ce0287 100644
> --- a/libavcodec/h264dec.c
> +++ b/libavcodec/h264dec.c
> @@ -699,10 +699,7 @@ static int h264_decode_frame(AVCodecContext *avctx, void 
> *data,
>
>  *got_frame = 0;
>  if (h->output_frame->buf[0]) {
> -ret = av_frame_ref(pict, h->output_frame);
> -av_frame_unref(h->output_frame);
> -if (ret < 0)
> -return ret;
> +av_frame_move_ref(pict, h->output_frame);
>  *got_frame = 1;
>  }
>  }
> --

ok
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 3/4] h264dec: replace a pointless ref+unref with move_ref

2017-02-01 Thread Anton Khirnov 
---
 libavcodec/h264dec.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c
index b92795d..6ce0287 100644
--- a/libavcodec/h264dec.c
+++ b/libavcodec/h264dec.c
@@ -699,10 +699,7 @@ static int h264_decode_frame(AVCodecContext *avctx, void 
*data,
 
 *got_frame = 0;
 if (h->output_frame->buf[0]) {
-ret = av_frame_ref(pict, h->output_frame);
-av_frame_unref(h->output_frame);
-if (ret < 0)
-return ret;
+av_frame_move_ref(pict, h->output_frame);
 *got_frame = 1;
 }
 }
-- 
2.0.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel