Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Tue, 3 Dec 2013, Martin Storsjö wrote: On Mon, 2 Dec 2013, Diego Biurrun wrote: This is more robust and does not interfere with host libc separation. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Why does check_header interfere with host libc separation? Just because we doesn't want to add a version of that test, to limit the size of the final patch in the series? I guess the issue is that check_header does enable/disable flags. We could do something similar to check_header without the flag side effects by doing check_cpp_condition _mingw.h 1 as well. That is - I don't see that big benefit in handling mingw32 and -64 separately with respect to the libc tests right now, but perhaps it might be useful for something later? My point mainly is that I'm not too keen on complicating this when the current test can be kept in a different form. OTOH the current mingw libc code here is pretty ugly actually and I could agree that the new form (in the latest version of the patch) is better (regardless of the host libc detection set). // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Wed, Dec 04, 2013 at 03:28:10PM +0200, Martin Storsjö wrote: On Tue, 3 Dec 2013, Martin Storsjö wrote: On Mon, 2 Dec 2013, Diego Biurrun wrote: This is more robust and does not interfere with host libc separation. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Why does check_header interfere with host libc separation? Just because we doesn't want to add a version of that test, to limit the size of the final patch in the series? I guess the issue is that check_header does enable/disable flags. We could do something similar to check_header without the flag side effects by doing check_cpp_condition _mingw.h 1 as well. Yes. That is - I don't see that big benefit in handling mingw32 and -64 separately with respect to the libc tests right now, but perhaps it might be useful for something later? My point mainly is that I'm not too keen on complicating this when the current test can be kept in a different form. OTOH the current mingw libc code here is pretty ugly actually and I could agree that the new form (in the latest version of the patch) is better (regardless of the host libc detection set). The latter is the goal here. Even though we currently add the same set of flags for both MinGW32 and MinGW64, this might not be the case forever. Besides the end result is cleaner IMO. I have two printf/stdio CPPFLAGS patches for mingw libc pending that could never be done properly w/o host and target libc splitting. I will revisit those patches once this set is in. Possibly (not necessarily) the flags needed for both mingw variants will already be different then. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Tue, Dec 3, 2013 at 12:08 AM, Diego Biurrun di...@biurrun.de wrote: what MinGW version/variant was that? MinGW64? Did you also test MinGW32? I tested both i686-w64-mingw32 and x86_64-w64-mingw32, both had the same result. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Tue, Dec 03, 2013 at 09:33:18AM -0500, Alex Smith wrote: On Tue, Dec 3, 2013 at 12:08 AM, Diego Biurrun di...@biurrun.de wrote: what MinGW version/variant was that? MinGW64? Did you also test MinGW32? I tested both i686-w64-mingw32 and x86_64-w64-mingw32, both had the same result. How do these two identifiers match to MinGW32 and MinGW64? Anyway, this patch has just been superseded by my other patch that splits mingw32 and mingw64 libc detection. If you could test that one on mingw64, that would be very appreciated. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Tue, Dec 3, 2013 at 3:48 PM, Diego Biurrun di...@biurrun.de wrote: On Tue, Dec 03, 2013 at 09:33:18AM -0500, Alex Smith wrote: On Tue, Dec 3, 2013 at 12:08 AM, Diego Biurrun di...@biurrun.de wrote: what MinGW version/variant was that? MinGW64? Did you also test MinGW32? I tested both i686-w64-mingw32 and x86_64-w64-mingw32, both had the same result. How do these two identifiers match to MinGW32 and MinGW64? They do not, the -w64- in the middle indicates that both are MinGW-w64 - Hendrik ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Mon, 2 Dec 2013, Diego Biurrun wrote: This is more robust and does not interfere with host libc separation. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Why does check_header interfere with host libc separation? Just because we doesn't want to add a version of that test, to limit the size of the final patch in the series? // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
This is more robust and does not interfere with host libc separation. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 129b340..58a7e45 100755 --- a/configure +++ b/configure @@ -3386,7 +3386,7 @@ elif check_cpp_condition features.h defined __GLIBC__; then elif check_cpp_condition newlib.h defined _NEWLIB_VERSION; then libc_type=newlib add_cppflags -U__STRICT_ANSI__ -elif check_header _mingw.h; then +elif check_cpp_condition _mingw.h defined __MINGW32_VERSION; then libc_type=mingw check_cpp_condition _mingw.h \ defined (__MINGW64_VERSION_MAJOR) || (__MINGW32_MAJOR_VERSION 3) || \ -- 1.8.3.2 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On Mon, Dec 2, 2013 at 4:19 PM, Diego Biurrun di...@biurrun.de wrote: +elif check_cpp_condition _mingw.h defined __MINGW32_VERSION; then libc_type=mingw check_cpp_condition _mingw.h \ defined (__MINGW64_VERSION_MAJOR) || (__MINGW32_MAJOR_VERSION 3) || \ From config.log: check_cpp_condition _mingw.h defined __MINGW32_VERSION check_cpp BEGIN /msystmp/ffconf.cOtycERm.c 1 #include _mingw.h 2 #if !(defined __MINGW32_VERSION) 3 #error unsatisfied condition: defined __MINGW32_VERSION 4 #endif END /msystmp/ffconf.cOtycERm.c gcc -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -march=i686 -std=c99 -E -o /msystmp/ffconf.PlYxyFKS.o /msystmp/ffconf.cOtycERm.c f:/msys/tmp/ffconf.cOtycERm.c:3:2: error: #error unsatisfied condition: defined __MINGW32_VERSION #error unsatisfied condition: defined __MINGW32_VERSION ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] configure: Check for a definition instead of a header for mingw libc
On 02.12.2013 18:49, Alex Smith wrote: On Mon, Dec 2, 2013 at 4:19 PM, Diego Biurrun di...@biurrun.de wrote: +elif check_cpp_condition _mingw.h defined __MINGW32_VERSION; then libc_type=mingw check_cpp_condition _mingw.h \ defined (__MINGW64_VERSION_MAJOR) || (__MINGW32_MAJOR_VERSION 3) || \ From config.log: check_cpp_condition _mingw.h defined __MINGW32_VERSION check_cpp BEGIN /msystmp/ffconf.cOtycERm.c 1 #include _mingw.h 2 #if !(defined __MINGW32_VERSION) 3 #error unsatisfied condition: defined __MINGW32_VERSION 4 #endif END /msystmp/ffconf.cOtycERm.c gcc -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -march=i686 -std=c99 -E -o /msystmp/ffconf.PlYxyFKS.o /msystmp/ffconf.cOtycERm.c f:/msys/tmp/ffconf.cOtycERm.c:3:2: error: #error unsatisfied condition: defined __MINGW32_VERSION #error unsatisfied condition: defined __MINGW32_VERSION what MinGW version/variant was that? MinGW64? Did you also test MinGW32? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
