[libav-devel] [PATCH v2] configure: Add additional optimization for icl 14.x
It worked on 12.x, was broken on 13.x, and now it works again on 14.x. It is the icl equivalent of -fstrict-aliasing. --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 928e5f4..0fc9192 100755 --- a/configure +++ b/configure @@ -4022,7 +4022,8 @@ elif enabled_any msvc icl; then enable pragma_deprecated if enabled icl; then # basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags -Qansi-alias +check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags -Qansi-alias +check_cpp_condition "windows.h" "__ICL >= 1400" && add_cflags -Qansi-alias # icl will pass the inline asm tests but inline asm is currently # not supported (build will fail) disable inline_asm -- 1.8.4.msysgit.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH v2] configure: Add additional optimization for icl 14.x
On Sun, Sep 22, 2013 at 09:47:44AM -0400, Alex Smith wrote: > It worked on 12.x, was broken on 13.x, and now it works again on 14.x. > It is the icl equivalent of -fstrict-aliasing. > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 928e5f4..0fc9192 100755 > --- a/configure > +++ b/configure > @@ -4022,7 +4022,8 @@ elif enabled_any msvc icl; then > enable pragma_deprecated > if enabled icl; then > # basically -fstrict-aliasing that does not work (correctly) on icl > 13.x > -check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags > -Qansi-alias > +check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags > -Qansi-alias Why the extra space between 1300" && ? -- Johan Andersson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH v2] configure: Add additional optimization for icl 14.x
On Sun, Sep 22, 2013 at 11:31 AM, Johan Andersson wrote: > On Sun, Sep 22, 2013 at 09:47:44AM -0400, Alex Smith wrote: > > Why the extra space between 1300" && ? > > -- > Johan Andersson Cosmetic. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH v2] configure: Add additional optimization for icl 14.x
On Sun, Sep 22, 2013 at 6:40 PM, Alex Smith wrote: > On Sun, Sep 22, 2013 at 11:31 AM, Johan Andersson wrote: >> On Sun, Sep 22, 2013 at 09:47:44AM -0400, Alex Smith wrote: >> >> Why the extra space between 1300" && ? >> >> -- >> Johan Andersson > > Cosmetic. Although tbh it probably makes more sense to put the extra space before "<" and not where it currently is. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH v2] configure: Add additional optimization for icl 14.x
On Sun, Sep 22, 2013 at 09:47:44AM -0400, Alex Smith wrote: > It worked on 12.x, was broken on 13.x, and now it works again on 14.x. > It is the icl equivalent of -fstrict-aliasing. > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) The log message does not explain what "it" is. > --- a/configure > +++ b/configure > @@ -4022,7 +4022,8 @@ elif enabled_any msvc icl; then > enable pragma_deprecated > if enabled icl; then > # basically -fstrict-aliasing that does not work (correctly) on icl > 13.x > -check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags > -Qansi-alias > +check_cpp_condition "windows.h" "__ICL < 1300" && add_cflags > -Qansi-alias > +check_cpp_condition "windows.h" "__ICL >= 1400" && add_cflags > -Qansi-alias How common are icl versions before 12? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
