Re: [libav-devel] [libav-commits] build: Use pkg-config for openjpeg

2014-03-14 Thread Reinhard Tartler
On Mon, Mar 10, 2014 at 5:47 AM, Anton Khirnov an...@khirnov.net wrote:

 On Sat,  8 Mar 2014 19:54:23 +0100 (CET), Pierre Lejeune  g...@libav.org 
 wrote:
 Module: libav
 Branch: master
 Commit: 0e0cefb22216a4b6684a30a50cb5973400dc59f2

 Author:Pierre Lejeune superhe...@gmail.com
 Committer: Tim Walker tdskywal...@gmail.com
 Date:  Sat Mar  8 12:19:17 2014 +

 build: Use pkg-config for openjpeg

 Bug-Id: 387
 CC: libav-sta...@libav.org

 ---

  configure |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/configure b/configure
 index 4d7382a..0ac7328 100755
 --- a/configure
 +++ b/configure
 @@ -3957,7 +3957,7 @@ enabled libmp3lame require libmp3lame = 
 3.98.3 lame/lame.h lame_set
  enabled libopencore_amrnb  require libopencore_amrnb 
 opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb
  enabled libopencore_amrwb  require libopencore_amrwb 
 opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb
  enabled libopencv  require_pkg_config opencv opencv/cv.h 
 cvCreateImageHeader
 -enabled libopenjpegrequire libopenjpeg openjpeg.h opj_version 
 -lopenjpeg
 +enabled libopenjpegrequire_pkg_config libopenjpeg openjpeg.h 
 opj_version
  enabled libopusrequire_pkg_config opus opus_multistream.h 
 opus_multistream_decoder_create
  enabled libpulse   require_pkg_config libpulse-simple 
 pulse/simple.h pa_simple_new
  enabled librtmprequire_pkg_config librtmp librtmp/rtmp.h 
 RTMP_Socket


 This broke openjpeg on Debian for me, the package is named libopenjpeg1 there.

I think it is even worse: In debian stable, and all released versions
of ubuntu, there is no pkg-config file for libopenjpeg at all. I'm
therefore inclined to revert to non-pkg-config detection for
release/10.

What do you think?

Reinhard
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [libav-commits] build: Use pkg-config for openjpeg

2014-03-14 Thread Tim Walker
On 14 Mar 2014, at 13:08, Reinhard Tartler siret...@gmail.com wrote:

 
 I think it is even worse: In debian stable, and all released versions
 of ubuntu, there is no pkg-config file for libopenjpeg at all. I'm
 therefore inclined to revert to non-pkg-config detection for
 release/10.
 
 What do you think?
 
 Reinhard

There were two follow-up patches from Luca, including one which does 
non-pkgconfig detection before doing pkg-config based detection. Not sure 
whether it got pushed or backported yet.

Tim
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [libav-commits] build: Use pkg-config for openjpeg

2014-03-14 Thread Luca Barbato
On 14/03/14 13:10, Tim Walker wrote:
 On 14 Mar 2014, at 13:08, Reinhard Tartler siret...@gmail.com
 wrote:
 
 
 I think it is even worse: In debian stable, and all released
 versions of ubuntu, there is no pkg-config file for libopenjpeg at
 all. I'm therefore inclined to revert to non-pkg-config detection
 for release/10.
 
 What do you think?
 
 Reinhard
 
 There were two follow-up patches from Luca, including one which does
 non-pkgconfig detection before doing pkg-config based detection. Not
 sure whether it got pushed or backported yet.
 

to be backported. we need to support both since we have both situations
in currently packaged versions of openjpeg.

lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [libav-commits] build: Use pkg-config for openjpeg

2014-03-10 Thread Anton Khirnov

On Sat,  8 Mar 2014 19:54:23 +0100 (CET), Pierre Lejeune  g...@libav.org 
wrote:
 Module: libav
 Branch: master
 Commit: 0e0cefb22216a4b6684a30a50cb5973400dc59f2
 
 Author:Pierre Lejeune superhe...@gmail.com
 Committer: Tim Walker tdskywal...@gmail.com
 Date:  Sat Mar  8 12:19:17 2014 +
 
 build: Use pkg-config for openjpeg
 
 Bug-Id: 387
 CC: libav-sta...@libav.org
 
 ---
 
  configure |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/configure b/configure
 index 4d7382a..0ac7328 100755
 --- a/configure
 +++ b/configure
 @@ -3957,7 +3957,7 @@ enabled libmp3lame require libmp3lame = 
 3.98.3 lame/lame.h lame_set
  enabled libopencore_amrnb  require libopencore_amrnb 
 opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb
  enabled libopencore_amrwb  require libopencore_amrwb 
 opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb
  enabled libopencv  require_pkg_config opencv opencv/cv.h 
 cvCreateImageHeader
 -enabled libopenjpegrequire libopenjpeg openjpeg.h opj_version 
 -lopenjpeg
 +enabled libopenjpegrequire_pkg_config libopenjpeg openjpeg.h 
 opj_version
  enabled libopusrequire_pkg_config opus opus_multistream.h 
 opus_multistream_decoder_create
  enabled libpulse   require_pkg_config libpulse-simple 
 pulse/simple.h pa_simple_new
  enabled librtmprequire_pkg_config librtmp librtmp/rtmp.h 
 RTMP_Socket
 

This broke openjpeg on Debian for me, the package is named libopenjpeg1 there.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [libav-commits] build: Use pkg-config for openjpeg

2014-03-10 Thread Luca Barbato
On 10/03/14 10:47, Anton Khirnov wrote:
 
 On Sat,  8 Mar 2014 19:54:23 +0100 (CET), Pierre Lejeune  g...@libav.org 
 wrote:
 Module: libav
 Branch: master
 Commit: 0e0cefb22216a4b6684a30a50cb5973400dc59f2

 Author:Pierre Lejeune superhe...@gmail.com
 Committer: Tim Walker tdskywal...@gmail.com
 Date:  Sat Mar  8 12:19:17 2014 +

 build: Use pkg-config for openjpeg

 Bug-Id: 387
 CC: libav-sta...@libav.org

 ---

  configure |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/configure b/configure
 index 4d7382a..0ac7328 100755
 --- a/configure
 +++ b/configure
 @@ -3957,7 +3957,7 @@ enabled libmp3lame require libmp3lame = 
 3.98.3 lame/lame.h lame_set
  enabled libopencore_amrnb  require libopencore_amrnb 
 opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb
  enabled libopencore_amrwb  require libopencore_amrwb 
 opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb
  enabled libopencv  require_pkg_config opencv opencv/cv.h 
 cvCreateImageHeader
 -enabled libopenjpegrequire libopenjpeg openjpeg.h opj_version 
 -lopenjpeg
 +enabled libopenjpegrequire_pkg_config libopenjpeg openjpeg.h 
 opj_version
  enabled libopusrequire_pkg_config opus opus_multistream.h 
 opus_multistream_decoder_create
  enabled libpulse   require_pkg_config libpulse-simple 
 pulse/simple.h pa_simple_new
  enabled librtmprequire_pkg_config librtmp librtmp/rtmp.h 
 RTMP_Socket

 
 This broke openjpeg on Debian for me, the package is named libopenjpeg1 there.
 

grrr. the system I can access have both so I didn't consider some do
not, I'll send a patch to switch to the libopenjpeg1 soon, is it ok for
everybody?


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel