Re: [libav-devel] Swscale cleanup part I
On Mon, Apr 11, 2011 at 01:48:04PM +0200, Luca Barbato wrote: > On 04/11/2011 12:16 PM, Diego Biurrun wrote: > > On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: > >> Hi this patchset does still apply today. > >> Even if not complete I'm considering to merge it since seems not > >> introduce changes and already moves most of the x86 code in its > >> directory. > > > > A general remark: I find the log messages a bit short and many lack an > > explanation why you are making changes as opposed to just describing > > what the change consists of. > > I'm thinking about squashing them. The whole rationale is to move x86 > specific code out the plain C code and then clean it up. > > Do you think would make sense squashing everything in a single huge > patch or not? Not exactly. I'd split it into 3-4 big patches - splitting x86-specific part, factoring out initialisation stuff and other fixes. But having the whole development history is certainly an overkill to me (git log libavcodec/vorbis_enc.c should serve you an example of how not to do it) ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] Swscale cleanup part I
On 04/11/2011 12:16 PM, Diego Biurrun wrote: > On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: >> Hi this patchset does still apply today. >> Even if not complete I'm considering to merge it since seems not >> introduce changes and already moves most of the x86 code in its >> directory. > > A general remark: I find the log messages a bit short and many lack an > explanation why you are making changes as opposed to just describing > what the change consists of. I'm thinking about squashing them. The whole rationale is to move x86 specific code out the plain C code and then clean it up. Do you think would make sense squashing everything in a single huge patch or not? lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] Swscale cleanup part I
On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: > Hi this patchset does still apply today. > Even if not complete I'm considering to merge it since seems not > introduce changes and already moves most of the x86 code in its > directory. A general remark: I find the log messages a bit short and many lack an explanation why you are making changes as opposed to just describing what the change consists of. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] Swscale cleanup part I
Hi this patchset does still apply today. Even if not complete I'm considering to merge it since seems not introduce changes and already moves most of the x86 code in its directory. You can fork it from my libav repo on github https://github.com/lu-zero/libav/tree/swscale-cleanup Many thanks to Josh for the help =) ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
