Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description
On Sat, Dec 08, 2012 at 10:08:14AM +0100, Anton Khirnov wrote: > On Fri, 07 Dec 2012 16:01:40 +0100, Diego Biurrun wrote: > > On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: > > > --- > > > libavcodec/options_table.h |2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I suggest to hold off on this spelling fix and collect more typo fixes > > into a larger batch so as to not clutter up the git log too much with > > trivial commits. I have a commit locally that collects typo fixes and > > I have folded your patch into it. I'll send it when it has reached > > a size that it feels worth publishing. > > I disagree. > > What you said might make sense for purely internal invisible stuff like > variable names or comments, but this is an option description that will > be shown to a user. We should fix such things immediately IMO. If you see such urgency, why don't you go ahead and fix all the typos in that file? There surely is no shortage ... :) I'll send a patch tomorrow. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description
On Fri, 07 Dec 2012 16:01:40 +0100, Diego Biurrun wrote: > On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: > > --- > > libavcodec/options_table.h |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I suggest to hold off on this spelling fix and collect more typo fixes > into a larger batch so as to not clutter up the git log too much with > trivial commits. I have a commit locally that collects typo fixes and > I have folded your patch into it. I'll send it when it has reached > a size that it feels worth publishing. > I disagree. What you said might make sense for purely internal invisible stuff like variable names or comments, but this is an option description that will be shown to a user. We should fix such things immediately IMO. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description
On Fri, Dec 07, 2012 at 03:50:49PM +0200, Martin Storsjö wrote: > --- > libavcodec/options_table.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I suggest to hold off on this spelling fix and collect more typo fixes into a larger batch so as to not clutter up the git log too much with trivial commits. I have a commit locally that collects typo fixes and I have folded your patch into it. I'll send it when it has reached a size that it feels worth publishing. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] avcodec: Fix a typo in an option description
Martin Storsjö writes: > --- > libavcodec/options_table.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
