Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. Please separate those, patch LGTM otherwise. .. ping .. This conflicts with and thus holds up hpeldsp. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On 28/01/13 20:00, Diego Biurrun wrote: On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. Please separate those, patch LGTM otherwise. .. ping .. This conflicts with and thus holds up hpeldsp. I'll split it now, first memsets then the rest, ok? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
Hi, On Mon, Jan 28, 2013 at 11:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 28/01/13 20:00, Diego Biurrun wrote: On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. Please separate those, patch LGTM otherwise. .. ping .. This conflicts with and thus holds up hpeldsp. I'll split it now, first memsets then the rest, ok? No, just commit it. I'm really bright enough to do a trivial rebase. Please review each patch on its own merits. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. Please separate those, patch LGTM otherwise. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
Hi, On Wed, Jan 23, 2013 at 7:45 AM, Luca Barbato lu_z...@gentoo.org wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. libavcodec/bfin/Makefile | 4 ++-- libavcodec/bfin/dsputil_bfin.c | 8 +--- libavcodec/bfin/vp3_bfin.c | 13 - libavcodec/vp3dsp.c| 2 ++ libavcodec/vp3dsp.h| 1 + 5 files changed, 18 insertions(+), 10 deletions(-) TY, should be good now. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code from general dsputil code
Hi, On Mon, Jan 21, 2013 at 1:01 AM, Diego Biurrun di...@biurrun.de wrote: --- This is untested due to lack of a bfin cross-compilation environment. libavcodec/bfin/Makefile |4 ++-- libavcodec/bfin/dsputil_bfin.c |8 +--- libavcodec/bfin/vp3_bfin.c |6 ++ libavcodec/vp3dsp.c|2 ++ libavcodec/vp3dsp.h|1 + 5 files changed, 12 insertions(+), 9 deletions(-) OK. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On 21/01/13 20:38, Luca Barbato wrote:
+void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags)
+{
+c-idct_add = ff_bfin_vp3_idct_add;
+c-idct_put = ff_bfin_vp3_idct_put;
c-idct missing.
qemu-user is not really working for us sadly =\
lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On 21/01/13 22:13, Luca Barbato wrote:
On 21/01/13 20:38, Luca Barbato wrote:
+void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags)
+{
+c-idct_add = ff_bfin_vp3_idct_add;
+c-idct_put = ff_bfin_vp3_idct_put;
c-idct missing.
Actually the idct_dc_add not sure if we can safely mix and match them,
probably we can.
lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
On 21/01/13 22:43, Luca Barbato wrote: Actually the idct_dc_add not sure if we can safely mix and match them, probably we can. I'd push tomorrow the updated patch, idct_dc_add is compatible from what I can see. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
Hi,
On Mon, Jan 21, 2013 at 1:13 PM, Luca Barbato lu_z...@gentoo.org wrote:
On 21/01/13 20:38, Luca Barbato wrote:
+void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags)
+{
+c-idct_add = ff_bfin_vp3_idct_add;
+c-idct_put = ff_bfin_vp3_idct_put;
c-idct missing.
vp3dsp has no idct.
Ronald
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code
Hi, On Mon, Jan 21, 2013 at 2:31 PM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 22:43, Luca Barbato wrote: Actually the idct_dc_add not sure if we can safely mix and match them, probably we can. I'd push tomorrow the updated patch, idct_dc_add is compatible from what I can see. Please make sure that they set their coefficients to zero after the idct, that was a recent modification in the API (like VP8) which the asm previously (when this was written) didn't do. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
