Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
On Wed, Sep 26, 2012 at 07:59:36PM +0200, Diego Biurrun wrote: > On Tue, Sep 11, 2012 at 10:30:44AM +0200, Diego Biurrun wrote: > > On Fri, Sep 07, 2012 at 11:17:38AM +0200, Diego Biurrun wrote: > > > On Fri, Aug 24, 2012 at 07:06:26PM +0200, Diego Biurrun wrote: > > > > A new hidden config variable is added for the codecs that depend on the > > > > mpegaudio parts. > > > > --- > > > > configure | 22 -- > > > > libavcodec/Makefile | 34 -- > > > > 2 files changed, 24 insertions(+), 32 deletions(-) > > > > > > .. ping .. > > > > *ping* > > This still needs a review... OKed by Luca on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
On Tue, Sep 11, 2012 at 10:30:44AM +0200, Diego Biurrun wrote: > On Fri, Sep 07, 2012 at 11:17:38AM +0200, Diego Biurrun wrote: > > On Fri, Aug 24, 2012 at 07:06:26PM +0200, Diego Biurrun wrote: > > > A new hidden config variable is added for the codecs that depend on the > > > mpegaudio parts. > > > --- > > > configure | 22 -- > > > libavcodec/Makefile | 34 -- > > > 2 files changed, 24 insertions(+), 32 deletions(-) > > > > .. ping .. > > *ping* This still needs a review... Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
On Fri, Sep 07, 2012 at 11:17:38AM +0200, Diego Biurrun wrote: > On Fri, Aug 24, 2012 at 07:06:26PM +0200, Diego Biurrun wrote: > > A new hidden config variable is added for the codecs that depend on the > > mpegaudio parts. > > --- > > configure | 22 -- > > libavcodec/Makefile | 34 -- > > 2 files changed, 24 insertions(+), 32 deletions(-) > > .. ping .. *ping* Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
On Fri, Aug 24, 2012 at 07:06:26PM +0200, Diego Biurrun wrote: > A new hidden config variable is added for the codecs that depend on the > mpegaudio parts. > --- > configure | 22 -- > libavcodec/Makefile | 34 -- > 2 files changed, 24 insertions(+), 32 deletions(-) .. ping .. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
On Fri, Aug 24, 2012 at 05:32:04PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > A new hidden config variable is added for the codecs that depend on the > > mpegaudio parts. Since all codecs depending on the new variable also > > depend on mpegaudiodsp, the new config variable subsumes that variable. > > Description is wrong. > > > OBJS-$(CONFIG_MP2_ENCODER) += mpegaudioenc.o mpegaudio.o \ > > - mpegaudiodata.o > > mpegaudiodsp_data.o > > + mpegaudiodata.o > > This change is wrong. Good catches, thanks, I rebased too sloppily. Fixed patch coming up. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: Factor out mpegaudio dependencies to CONFIG_MPEGAUDIO
Diego Biurrun writes: > A new hidden config variable is added for the codecs that depend on the > mpegaudio parts. Since all codecs depending on the new variable also > depend on mpegaudiodsp, the new config variable subsumes that variable. Description is wrong. > OBJS-$(CONFIG_MP2_ENCODER) += mpegaudioenc.o mpegaudio.o \ > - mpegaudiodata.o mpegaudiodsp_data.o > + mpegaudiodata.o This change is wrong. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
