Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc/uclibc

2012-11-18 Thread Diego Biurrun
On Sat, Nov 17, 2012 at 06:10:00PM +, Mans Rullgard wrote:
 From: Diego Biurrun di...@biurrun.de
 
 Signed-off-by: Mans Rullgard m...@mansr.com
 ---
  configure | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks for testing and fixing my initial stab.  Push anytime.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc/uclibc

2012-11-17 Thread Luca Barbato
On 11/17/2012 07:10 PM, Mans Rullgard wrote:
 From: Diego Biurrun di...@biurrun.de
 
 Signed-off-by: Mans Rullgard m...@mansr.com
 ---
  configure | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Looks fine, remind me to play with musl and add stuff if required.

lu

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc

2012-11-12 Thread Diego Biurrun
On Sat, Oct 13, 2012 at 07:20:17PM +0100, Måns Rullgård wrote:
 Diego Biurrun di...@biurrun.de writes:
  On Sat, Oct 13, 2012 at 06:27:57PM +0100, Måns Rullgård wrote:
  Diego Biurrun di...@biurrun.de writes:
   --- a/configure
   +++ b/configure
   @@ -2819,7 +2819,6 @@ case $target_os in
add_cppflags -U__STRICT_ANSI__
;;
linux)
   -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
enable dv1394
;;
   @@ -2850,10 +2849,9 @@ case $target_os in
enable dos_paths
;;
gnu/kfreebsd)
   -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 
   -D_BSD_SOURCE
   +add_cppflags -D_BSD_SOURCE
;;
gnu)
   -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
;;
qnx)
   @@ -2890,6 +2888,7 @@ if check_cpp_condition features.h defined 
   __UCLIBC__; then
libc_type=uclibc
elif check_cpp_condition features.h defined __GLIBC__; then
libc_type=glibc
   +add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
elif check_header _mingw.h; then
libc_type=mingw
check_cpp_condition _mingw.h \
  
  This might need adjusting for linux/uclibc to work.
 
  Do you have a system at hand to test?  Or do you suggest just adding
  the flags to the uclibc section as well?
 
 I have more than one.  I'll test it and report back.

.. ping ..

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc

2012-10-13 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes:

 ---
  configure |5 ++---
  1 files changed, 2 insertions(+), 3 deletions(-)

 diff --git a/configure b/configure
 index 534c80d..dda752d 100755
 --- a/configure
 +++ b/configure
 @@ -2819,7 +2819,6 @@ case $target_os in
  add_cppflags -U__STRICT_ANSI__
  ;;
  linux)
 -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
  enable dv1394
  ;;
  irix*)
 @@ -2850,10 +2849,9 @@ case $target_os in
  enable dos_paths
  ;;
  gnu/kfreebsd)
 -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 
 -D_BSD_SOURCE
 +add_cppflags -D_BSD_SOURCE
  ;;
  gnu)
 -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
  ;;
  qnx)
  add_cppflags -D_QNX_SOURCE
 @@ -2890,6 +2888,7 @@ if check_cpp_condition features.h defined __UCLIBC__; 
 then
  libc_type=uclibc
  elif check_cpp_condition features.h defined __GLIBC__; then
  libc_type=glibc
 +add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
  elif check_header _mingw.h; then
  libc_type=mingw
  check_cpp_condition _mingw.h \
 -- 

This might need adjusting for linux/uclibc to work.

-- 
Måns Rullgård
m...@mansr.com
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc

2012-10-13 Thread Diego Biurrun
On Sat, Oct 13, 2012 at 06:27:57PM +0100, Måns Rullgård wrote:
 Diego Biurrun di...@biurrun.de writes:
  --- a/configure
  +++ b/configure
  @@ -2819,7 +2819,6 @@ case $target_os in
   add_cppflags -U__STRICT_ANSI__
   ;;
   linux)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   enable dv1394
   ;;
  @@ -2850,10 +2849,9 @@ case $target_os in
   enable dos_paths
   ;;
   gnu/kfreebsd)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 
  -D_BSD_SOURCE
  +add_cppflags -D_BSD_SOURCE
   ;;
   gnu)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   ;;
   qnx)
  @@ -2890,6 +2888,7 @@ if check_cpp_condition features.h defined 
  __UCLIBC__; then
   libc_type=uclibc
   elif check_cpp_condition features.h defined __GLIBC__; then
   libc_type=glibc
  +add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   elif check_header _mingw.h; then
   libc_type=mingw
   check_cpp_condition _mingw.h \
 
 This might need adjusting for linux/uclibc to work.

Do you have a system at hand to test?  Or do you suggest just adding
the flags to the uclibc section as well?

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] configure: Refactor CPPFLAGS settings for glibc

2012-10-13 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes:

 On Sat, Oct 13, 2012 at 06:27:57PM +0100, Måns Rullgård wrote:
 Diego Biurrun di...@biurrun.de writes:
  --- a/configure
  +++ b/configure
  @@ -2819,7 +2819,6 @@ case $target_os in
   add_cppflags -U__STRICT_ANSI__
   ;;
   linux)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   enable dv1394
   ;;
  @@ -2850,10 +2849,9 @@ case $target_os in
   enable dos_paths
   ;;
   gnu/kfreebsd)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 
  -D_BSD_SOURCE
  +add_cppflags -D_BSD_SOURCE
   ;;
   gnu)
  -add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   ;;
   qnx)
  @@ -2890,6 +2888,7 @@ if check_cpp_condition features.h defined 
  __UCLIBC__; then
   libc_type=uclibc
   elif check_cpp_condition features.h defined __GLIBC__; then
   libc_type=glibc
  +add_cppflags -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
   elif check_header _mingw.h; then
   libc_type=mingw
   check_cpp_condition _mingw.h \
 
 This might need adjusting for linux/uclibc to work.

 Do you have a system at hand to test?  Or do you suggest just adding
 the flags to the uclibc section as well?

I have more than one.  I'll test it and report back.

-- 
Måns Rullgård
m...@mansr.com
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel