Re: [libav-devel] [PATCH] indeo4: Rework stream analysis report
On Tue, Mar 22, 2016 at 8:43 AM, Diego Biurrun wrote: > On Sat, Mar 19, 2016 at 05:07:37PM -0400, Vittorio Giovara wrote: >> * Change log level from error to debug >> * Print report after the first decoded frame, not at the end of decoding >> * Drop macro guard and use a context variable instead >> >> Signed-off-by: Vittorio Giovara >> --- >> libavcodec/indeo4.c | 11 +-- >> libavcodec/ivi.c| 33 - >> libavcodec/ivi.h| 4 +--- >> 3 files changed, 18 insertions(+), 30 deletions(-) > > Did you benchmark this? I haven't but the log is done only once (and only at debug level), so it should not have noticeable effect. -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] indeo4: Rework stream analysis report
On 19/03/16 22:07, Vittorio Giovara wrote: > * Change log level from error to debug > * Print report after the first decoded frame, not at the end of decoding > * Drop macro guard and use a context variable instead > > Signed-off-by: Vittorio Giovara > --- > libavcodec/indeo4.c | 11 +-- > libavcodec/ivi.c| 33 - > libavcodec/ivi.h| 4 +--- > 3 files changed, 18 insertions(+), 30 deletions(-) > Seems Ok to me. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] indeo4: Rework stream analysis report
On Sat, Mar 19, 2016 at 05:07:37PM -0400, Vittorio Giovara wrote: > * Change log level from error to debug > * Print report after the first decoded frame, not at the end of decoding > * Drop macro guard and use a context variable instead > > Signed-off-by: Vittorio Giovara > --- > libavcodec/indeo4.c | 11 +-- > libavcodec/ivi.c| 33 - > libavcodec/ivi.h| 4 +--- > 3 files changed, 18 insertions(+), 30 deletions(-) Did you benchmark this? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
