Re: [libav-devel] [PATCH 04/11] avconv: merge output_opts into output_files.

2011-08-17 Thread Kostya
On Wed, Aug 17, 2011 at 05:04:45PM +0200, Anton Khirnov wrote:
 ---
  avconv.c |   11 +--
  1 files changed, 5 insertions(+), 6 deletions(-)

You'd better merge it with previous patch, I have a mild allergy on word
wrapper (and patches doing nothing useful). And uniting two related things in
one structure has some sense indeed.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH 04/11] avconv: merge output_opts into output_files.

2011-08-17 Thread Anton Khirnov

On Wed, 17 Aug 2011 17:58:04 +0200, Kostya kostya.shish...@gmail.com wrote:
 On Wed, Aug 17, 2011 at 05:04:45PM +0200, Anton Khirnov wrote:
  ---
   avconv.c |   11 +--
   1 files changed, 5 insertions(+), 6 deletions(-)
 
 You'd better merge it with previous patch, I have a mild allergy on word
 wrapper (and patches doing nothing useful). And uniting two related things in
 one structure has some sense indeed.

The idea was that smaller patches are generally easier to review.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel