Re: [libav-devel] [PATCH 1/3] lavf: add a raw HEVC demuxer
On Fri, Sep 27, 2013 at 03:26:10PM +0200, Anton Khirnov wrote: > --- > libavformat/Makefile |1 + > libavformat/allformats.c |1 + > libavformat/hevcdec.c| 64 > ++ > 3 files changed, 66 insertions(+) > create mode 100644 libavformat/hevcdec.c Changelog, docs, version bump? > --- /dev/null > +++ b/libavformat/hevcdec.c > @@ -0,0 +1,64 @@ > + > +#include "avformat.h" > +#include "rawdec.h" > + > +#include "libavcodec/hevc.h" I think we agreed to order this #include "libavcodec/hevc.h" #include "avformat.h" #include "rawdec.h" in the header cleanup patchset discussion. > +switch (type) { > +case NAL_VPS:vps++; break; > +case NAL_SPS:sps++; break; > +case NAL_PPS:pps++; break; > +case NAL_BLA_N_LP: > +case NAL_BLA_W_LP: > +case NAL_BLA_W_RADL: > +case NAL_CRA_NUT: > +case NAL_IDR_N_LP: > +case NAL_IDR_W_RADL: irap++; break; Please break the lines. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/3] lavf: add a raw HEVC demuxer
On 27/09/13 15:37, Diego Biurrun wrote: > On Fri, Sep 27, 2013 at 03:26:10PM +0200, Anton Khirnov wrote: >> --- >> libavformat/Makefile |1 + >> libavformat/allformats.c |1 + >> libavformat/hevcdec.c| 64 >> ++ >> 3 files changed, 66 insertions(+) >> create mode 100644 libavformat/hevcdec.c > > Changelog, docs, version bump? > >> --- /dev/null >> +++ b/libavformat/hevcdec.c >> @@ -0,0 +1,64 @@ >> + >> +#include "avformat.h" >> +#include "rawdec.h" >> + >> +#include "libavcodec/hevc.h" > > I think we agreed to order this My proposal got two +1, nobody put it in the documentation. If there is agreement we should go forward and spend a weekend cleaning up everything (and then I'll spend a week rebasing my trees) lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/3] lavf: add a raw HEVC demuxer
On Fri, Sep 27, 2013 at 3:51 PM, Luca Barbato wrote: >>> + >>> +#include "avformat.h" >>> +#include "rawdec.h" >>> + >>> +#include "libavcodec/hevc.h" >> >> I think we agreed to order this > > My proposal got two +1, nobody put it in the documentation. > I can add that in the next iteration of the cleanup patchset. Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel