Re: [libav-devel] [PATCH 24/25] intrax8: Drop MB emulation coder

2016-03-22 Thread Vittorio Giovara
On Tue, Mar 22, 2016 at 2:22 PM, Diego Biurrun  wrote:
> On Sat, Mar 19, 2016 at 05:42:55PM -0400, Vittorio Giovara wrote:
>> This is already performed in init_context_frame().
>>
>> --- a/libavcodec/intrax8.c
>> +++ b/libavcodec/intrax8.c
>> @@ -828,8 +828,6 @@ int ff_intrax8_decode_picture(IntraX8Context *const w, 
>> Picture *pict,
>>
>>  /* emulate MB info in the relevant tables */
>> -s->mbskip_table[mb_xy] = 0;
>> -s->mbintra_table[mb_xy]= 1;
>>  pict->qscale_table[mb_xy] = w->quant;
>>  mb_xy++;
>
> So why are you keeping the comment?

I thought it applied to qscale_table too, but on second read it's ok
to drop the comment
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH 24/25] intrax8: Drop MB emulation coder

2016-03-22 Thread Diego Biurrun
On Sat, Mar 19, 2016 at 05:42:55PM -0400, Vittorio Giovara wrote:
> This is already performed in init_context_frame().
> 
> --- a/libavcodec/intrax8.c
> +++ b/libavcodec/intrax8.c
> @@ -828,8 +828,6 @@ int ff_intrax8_decode_picture(IntraX8Context *const w, 
> Picture *pict,
>  
>  /* emulate MB info in the relevant tables */
> -s->mbskip_table[mb_xy] = 0;
> -s->mbintra_table[mb_xy]= 1;
>  pict->qscale_table[mb_xy] = w->quant;
>  mb_xy++;

So why are you keeping the comment?

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel