Re: [libav-devel] [PATCH 3/4] avcodec: split avpicture from imgconvert
On 11/12/2012 08:11 PM, Luca Barbato wrote: > On 11/12/2012 02:13 AM, Kieran Kunhya wrote: >> On Mon, Nov 12, 2012 at 1:09 AM, Kieran Kunhya >> wrote: >>> On Mon, Nov 12, 2012 at 12:25 AM, Luca Barbato wrote: All the non deprecated functions are in avpicture.c now. --- libavcodec/Makefile | 1 + libavcodec/avpicture.c | 123 libavcodec/imgconvert.c | 85 - >>> >>> These functions are now lavc internal? av_image_alloc and similar were >>> quite useful for custom get_buffer functions amongst >>> other things. >> >> Oh ignore me, imgconvert.h is still there. > > It doesn't exist. The functions you are referring to are part of avutil > already. > > The whole thing aims to remove > > av_picture_pad and av_picture_crop since they won't work on quite used > pixel formats and are superceeded by swscale. > > avpicture_deinterlace since it is superceeded by yadif > > > avcodec_find_best_pix_fmt* got a bit pointless since we aren't using > pixel formats to describe the color model, so it is at best provides an > hint. > > I have a patch to simplify it, but I doubt it is of any use so we might > just remove it if nobody is using it. What is libavfilter using for automatic pixel format negotiation? or does it even do any kind of smart selection at all currently? -Justin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/4] avcodec: split avpicture from imgconvert
On 11/12/2012 01:25 AM, Luca Barbato wrote: > All the non deprecated functions are in avpicture.c now. > --- > libavcodec/Makefile | 1 + > libavcodec/avpicture.c | 123 > > libavcodec/imgconvert.c | 85 - > 3 files changed, 124 insertions(+), 85 deletions(-) > create mode 100644 libavcodec/avpicture.c > Ping. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/4] avcodec: split avpicture from imgconvert
On 11/12/2012 02:13 AM, Kieran Kunhya wrote: > On Mon, Nov 12, 2012 at 1:09 AM, Kieran Kunhya wrote: >> On Mon, Nov 12, 2012 at 12:25 AM, Luca Barbato wrote: >>> All the non deprecated functions are in avpicture.c now. >>> --- >>> libavcodec/Makefile | 1 + >>> libavcodec/avpicture.c | 123 >>> >>> libavcodec/imgconvert.c | 85 - >> >> These functions are now lavc internal? av_image_alloc and similar were >> quite useful for custom get_buffer functions amongst >> other things. > > Oh ignore me, imgconvert.h is still there. It doesn't exist. The functions you are referring to are part of avutil already. The whole thing aims to remove av_picture_pad and av_picture_crop since they won't work on quite used pixel formats and are superceeded by swscale. avpicture_deinterlace since it is superceeded by yadif avcodec_find_best_pix_fmt* got a bit pointless since we aren't using pixel formats to describe the color model, so it is at best provides an hint. I have a patch to simplify it, but I doubt it is of any use so we might just remove it if nobody is using it. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/4] avcodec: split avpicture from imgconvert
On Mon, Nov 12, 2012 at 1:09 AM, Kieran Kunhya wrote: > On Mon, Nov 12, 2012 at 12:25 AM, Luca Barbato wrote: >> All the non deprecated functions are in avpicture.c now. >> --- >> libavcodec/Makefile | 1 + >> libavcodec/avpicture.c | 123 >> >> libavcodec/imgconvert.c | 85 - > > These functions are now lavc internal? av_image_alloc and similar were > quite useful for custom get_buffer functions amongst > other things. Oh ignore me, imgconvert.h is still there. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/4] avcodec: split avpicture from imgconvert
On Mon, Nov 12, 2012 at 12:25 AM, Luca Barbato wrote: > All the non deprecated functions are in avpicture.c now. > --- > libavcodec/Makefile | 1 + > libavcodec/avpicture.c | 123 > > libavcodec/imgconvert.c | 85 - These functions are now lavc internal? av_image_alloc and similar were quite useful for custom get_buffer functions amongst other things. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
