On 02/20/2018 12:56 PM, Yegor Yefremov wrote: > You're right ftdi_eeprom should be enabled by default. Python bindings > have more dependencies so I would let it OFF by default.
ok, sounds like a good compromise for now. I've committed a change for this. >> What about having libconfuse / boost library detection >> in CMakeOptions.txt to set the default values? > > I'm using libftdi in the Buildroot context. In this case it is > important/desired to have predictable, reproducible builds. If I > configure the option FTDI_EEPROM as OFF, then I expect that I get no > ftdi_eeprom binary even if I have libconfuse. > > Another approach would be NOT to define FTDI_EEPROM as an option, but > just as a variable, that depends on whether libconfuse could be found > or not. In this case the behavior is controlled externally through the > development environment. > > But I'm more for the first variant. yes, the first variant is more obvious. Your patch has landed on master :) Cheers, Thomas -- libftdi - see http://www.intra2net.com/en/developer/libftdi for details. To unsubscribe send a mail to libftdi+unsubscr...@developer.intra2net.com
