Re: [PATCH] CMake: reorder Python detection

2020-01-15 Thread Thomas Jarosch
Hi Yegor,

You wrote on Mon, Jan 13, 2020 at 03:08:44PM +0100:
> From: Yegor Yefremov 
> 
> PythonInterp should be detected before PythonLibs otherwise
> CMake exits with the following message:
> 
> Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS)
> 
> Signed-off-by: Yegor Yefremov 
> ---
>  python/CMakeLists.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
> index fc1c3d1..5b6f420 100644
> --- a/python/CMakeLists.txt
> +++ b/python/CMakeLists.txt
> @@ -14,8 +14,8 @@ else ()
>  set ( SWIG_FOUND TRUE )
>endif ()
>  endif ()
> -find_package ( PythonLibs REQUIRED )
>  find_package ( PythonInterp REQUIRED )
> +find_package ( PythonLibs REQUIRED )
>  
>  include ( UseSWIG )
>  include_directories ( BEFORE ${CMAKE_SOURCE_DIR}/src )

applied, thanks :)

Cheers,
Thomas

--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscr...@developer.intra2net.com   



[PATCH] CMake: reorder Python detection

2020-01-13 Thread yegorslists
From: Yegor Yefremov 

PythonInterp should be detected before PythonLibs otherwise
CMake exits with the following message:

Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS)

Signed-off-by: Yegor Yefremov 
---
 python/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index fc1c3d1..5b6f420 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -14,8 +14,8 @@ else ()
 set ( SWIG_FOUND TRUE )
   endif ()
 endif ()
-find_package ( PythonLibs REQUIRED )
 find_package ( PythonInterp REQUIRED )
+find_package ( PythonLibs REQUIRED )
 
 include ( UseSWIG )
 include_directories ( BEFORE ${CMAKE_SOURCE_DIR}/src )
-- 
2.17.0


--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to libftdi+unsubscr...@developer.intra2net.com