Re: [Libreoffice] New credits page up (and linked from TDF)
On Mon, 8 Nov 2010 17:20:25 +0100, Thorsten Behrens wrote: > Ah sorry, my backlog is building up - I actually added that feature > - now we only need a nice credits .odt. ;) Mmh, I tried to import the .html into LibreOffice, but it looks pretty crappy. If someone can come up with a nice template page in .odt format, I can copy in the data table easily. Sebastian pgp39t2pETWzB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Perl Installer: Remove commented out code.
On Mon, 8 Nov 2010 22:23:07 -0600, Jordan Ayers wrote: > Some more cleanup for the perl installer. Thanks, pushed as 4e7555bf001050752e7380c54dd804fa9566d7ad Removing nearly 500 lines of commented out code. I just left one hunk that seemed remotely usefull for future improvements. Sebastian pgpQEqNDfTSzG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Preventivo di stampa
TIPOGRAFIA e STAMPA DIGITALE www.tipoprint.com Tel: 02 89 92 67 50 Gentile Cliente, Crediamo sia cosa gradita farvi pervenire questa nostra offerta relativa ai nostri stampati. E' una occasione da non perdere anche perche' potrete sfruttare questa offerta per tutto il 2010 a sola condizione che rispondiate allegando questa email, o chiamiate subito questo numero: 02 89.92.67.50 Alcuni esempi: 100 Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro15,00 500 Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro29,00 1000 Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro35,00 1000 Biglietti da visita a colori f.to 85x55 mm fronte e retro 4+4 Euro60,00 250 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro60,00 500 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro88,00 5000 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro150,00 1 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro250,00 15000 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro320,00 2 Volantini stampati su carta patinata 15x21 cm (A5) atampa a colori Euro400,00 250 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro100,00 1000 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro189,00 2500 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro265,00 5000 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro312,00 1 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro490,00 15000 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro670,00 2 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro890,00 50 Opuscoli 8 pagine A5 chiuso stampa a colori cucitura punto metallico Euro120,00 100 Opuscoli 8 pagine A5 chiuso stampa a colori cucitura punto metallico Euro170,00 50 Opuscoli 8 pagine A4 chiuso stampa a colori cucitura punto metallico Euro140,00 100 Opuscoli 8 pagine A4 chiuso stampa a colori cucitura punto metallico Euro200,00 50 Opuscoli 16 pagine A4 chiuso stampa a colori cucitura punto metallico Euro200,00 100 Opuscoli 16 pagine A4 chiuso stampa a colori cucitura punto metallico Euro300,00 1 Spesa di corriere espresso in 24 ore su tutto il territorio nazionale Euro12,00 Tutti i prezzi in questa mail sono riferiti alla sola stampa da vostri file di stampa in alta risoluzione nei formati .pdf o eps , inoltre i prezzi si intendono al netto di IVA. Visitate il nostro sito dove troverete tutti i prezzi e le offerte del periodo. clicca qui: www.tipoprint.com --- This e-mail was sent to libreoffice@lists.freedesktop.org because you are subscribed to at least one of our mailing lists. If at any time you would like to remove yourself from our mailing list, please feel free to do so by visiting: http://www.tipomi.com/list/public/unsubscribe.php?g=27&addr=libreoff...@lists.freedesktop.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] build.pl dead code, spelling fixes
Miscellaneous cleanup to build.pl. Mostly removal of dead code, with
a few spelling / German->English fixes.
LGPLv3+/MPL
Jordan Ayers
From bcebd3c5cf9c62aa3321dca253a7d61bded6cde9 Mon Sep 17 00:00:00 2001
From: Jordan Ayers
Date: Wed, 3 Nov 2010 23:35:04 -0500
Subject: [PATCH] Cleanup build.pl
Remove commented out code.
Remove $html_last_updated (unused).
Correct a few spelling mistakes.
Translate a few bits of German.
---
solenv/bin/build.pl | 124 +++---
1 files changed, 18 insertions(+), 106 deletions(-)
diff --git a/solenv/bin/build.pl b/solenv/bin/build.pl
index 0769862..f83aa4a 100755
--- a/solenv/bin/build.pl
+++ b/solenv/bin/build.pl
@@ -87,7 +87,7 @@
#
# #
-# Globale Variablen #
+# Global Variables#
# #
#
@@ -151,7 +151,6 @@
%platforms = (); # platforms available or being working with
%platforms_to_copy = (); # copy output trees for the platforms when --prepare
$tmp_dir = get_tmp_dir(); # temp directory for checkout and other actions
-#$dmake_batch = undef; #
@possible_build_lists = ('build.lst', 'build.xlist'); # build lists names
%build_list_paths = (); # build lists names
%build_lists_hash = (); # hash of arrays $build_lists_hash{$module} = \($path, $xml_list_object)
@@ -168,15 +167,13 @@
%build_in_progress_shown = (); # hash of modules being built,
# and shown last time (to keep order)
$build_time = time;
-$html_last_updated = 0;
%jobs_hash = ();
$html_path = undef;
$build_finished = 0;
$html_file = '';
-%had_error = (); # hack for misteriuos windows problems - try run dmake 2 times if first time there was an error
+%had_error = (); # hack for mysterious windows problems - try run dmake 2 times if first time there was an error
$mkout = CorrectPath("$ENV{SOLARENV}/bin/mkout.pl");
%weights_hash = (); # hash contains info about how many modules are dependent from one module
-#%weight_stored = ();
$grab_output = 1;
$stop_build_on_error = 0; # for multiprocessing mode: do not build further module if there is an error
$interactive = 0; # for interactive mode... (for testing purpose enabled by default)
@@ -204,7 +201,7 @@
my %add_to_config = ();
my %remove_from_config = ();
my $clear_config = 0;
-my $finisched_children = 0;
+my $finished_children = 0;
my $debug = 0;
%module_deps_hash_pids = ();
my @argv = @ARGV;
@@ -220,7 +217,6 @@
zenity_open();
zenity_tooltip("Starting build.");
-#my $temp_html_file = CorrectPath($tmp_dir. '/' . $ENV{INPATH}. '.build.html');
get_build_modes();
%deliver_env = ();
if ($prepare) {
@@ -265,7 +261,6 @@
%prj_platform = ();
$check_error_string = '';
$dmake = '';
-#$dmake_bin = '';
$dmake_args = '';
$echo = '';
$new_line = "\n";
@@ -285,8 +280,6 @@
} else {
print_error ("Cannot open file $cmd_file");
};
-#} elsif ($show) {
-#select STDOUT;
};
print $new_line;
@@ -300,8 +293,6 @@
}
if (scalar keys %broken_build) {
cancel_build();
-#} elsif (!$custom_job && $post_custom_job) {
-#do_post_custom_job(CorrectPath($StandDir.$initial_module));
};
print_warnings();
if (scalar keys %active_modules) {
@@ -420,7 +411,6 @@ sub start_html_message_trigger {
if ($child_id) {
# parent
-# print "started listener trigger\n";
} else {
my $buffer_size = 1024;
my $buffer;
@@ -437,7 +427,6 @@ sub start_html_message_trigger {
if (connect(SOCKET, $paddr)) {
$full_buffer .= "\n";
syswrite SOCKET, $full_buffer, length $full_buffer;
-#close SOCKET or die "Child close socket: $!";
} else {
die "Child connect: $!";
};
@@ -447,7 +436,6 @@ sub start_html_message_trigger {
};
sub get_html_orders {
-#print "Parent gonna read\n";
return if (!$interactive);
my $buffer_size = 1024;
my $buffer;
@@ -455,10 +443,9 @@ sub get_html_orders {
my $full_buffer = '';
my %modules_to_rebuild = ();
my %modules_to_delete = ();
-while ($rv = sysread(HTML_PIPE, $buffer, $buffer_size)) {
-$full_buffer .= $buffer;
-};
-#};
+while ($rv = sysread(HTML_PIPE, $buffer, $buffer_size)) {
+$full_buffer .= $buffer;
+};
my @html_messages = split(/\n/, $full_buffer);
foreach (@html_messages) {
if (/^html_port:(\d+)/) {
@@ -491,7 +478,6 @@ sub get_html_orders {
schedule_rebuild(\%modules_to_rebuild);
generate_html_file();
};
-#print "Parent got nothing to read\n";
};
sub schedule_delete {
@@ -643,7 +629,7 @@ sub expand_dependencies {
# This procedure fi
[Libreoffice] [PATCH] Remove wrapcmd from perl installer
Minor cleanup item I saw when preparing my last patches.
LGPLv3+/MPL
Jordan Ayers
From c2c5af35636a6f1bfd9f69b39e9baddc7da2f894 Mon Sep 17 00:00:00 2001
From: Jordan Ayers
Date: Mon, 8 Nov 2010 19:56:49 -0600
Subject: [PATCH] Remove unused global from perl installer
Per comments in globals.pm, remove wrapcmd and all references to it.
---
solenv/bin/modules/installer/globals.pm |3 ---
solenv/bin/modules/installer/servicesfile.pm | 10 +-
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/solenv/bin/modules/installer/globals.pm b/solenv/bin/modules/installer/globals.pm
index 7d85f73..3665367 100644
--- a/solenv/bin/modules/installer/globals.pm
+++ b/solenv/bin/modules/installer/globals.pm
@@ -531,9 +531,6 @@ BEGIN
$isunix = 1;
$iswin = 0;
}
-# WRAPCMD is gone - remove this and all related
-# $installer::globals::wrapcmd entries
-$wrapcmd = "";
if ( $plat =~ /linux/i ) { $islinux = 1; }
if ( $plat =~ /kfreebsd/i ) { $islinux = 1; }
diff --git a/solenv/bin/modules/installer/servicesfile.pm b/solenv/bin/modules/installer/servicesfile.pm
index c74073e..8dba6a9 100644
--- a/solenv/bin/modules/installer/servicesfile.pm
+++ b/solenv/bin/modules/installer/servicesfile.pm
@@ -167,7 +167,7 @@ sub call_regcomp
my $error_occured = 0;
-my $systemcall = "$installer::globals::wrapcmd $$regcompfileref -register -r ".fix_cygwin_path($servicesfile)." -c " . $installer::globals::quote . $filestring . $installer::globals::quote . " -wop=" . $installer::globals::quote . $urlprefix . $installer::globals::quote . " 2\>\&1 |";
+my $systemcall = "$$regcompfileref -register -r ".fix_cygwin_path($servicesfile)." -c " . $installer::globals::quote . $filestring . $installer::globals::quote . " -wop=" . $installer::globals::quote . $urlprefix . $installer::globals::quote . " 2\>\&1 |";
open (REG, "$systemcall");
while () {push(@regcompoutput, $_); }
@@ -229,7 +229,7 @@ sub register_javacomponents
{
my @regcompoutput = ();
-my $systemcall = "$installer::globals::wrapcmd $$regcompfileref -register -br ".fix_cygwin_path($regcomprdb)." -r ".fix_cygwin_path($servicesfile)." -c " . $installer::globals::quote . $filestring . $installer::globals::quote . " -l com.sun.star.loader.Java2 -wop=" . $installer::globals::quote . $javaservicesurlprefix . $installer::globals::quote ." -env:URE_INTERNAL_JAVA_DIR=" . $installer::globals::quote . make_file_url($$ure_internal_java_dir_ref) . $installer::globals::quote . " 2\>\&1 |";
+my $systemcall = "$$regcompfileref -register -br ".fix_cygwin_path($regcomprdb)." -r ".fix_cygwin_path($servicesfile)." -c " . $installer::globals::quote . $filestring . $installer::globals::quote . " -l com.sun.star.loader.Java2 -wop=" . $installer::globals::quote . $javaservicesurlprefix . $installer::globals::quote ." -env:URE_INTERNAL_JAVA_DIR=" . $installer::globals::quote . make_file_url($$ure_internal_java_dir_ref) . $installer::globals::quote . " 2\>\&1 |";
open (REG, "$systemcall");
while () {push(@regcompoutput, $_); }
@@ -276,7 +276,7 @@ sub fix_cygwin_path
{
my ( $path ) = @_;
-if ( $installer::globals::iswin eq 1 && $installer::globals::wrapcmd eq "" )
+if ( $installer::globals::iswin eq 1 )
{
$path = qx{cygpath -m "$path"};
chomp($path);
@@ -365,7 +365,7 @@ sub register_pythoncomponents
my @regcompoutput = ();
-$systemcall = "$installer::globals::wrapcmd $$regcompfileref -register"
+$systemcall = "$$regcompfileref -register"
. " -br " . fix_cygwin_path($$typesrdbref)
. " -br " . fix_cygwin_path($$pyunoservicesrdbref)
. " -r " . fix_cygwin_path($servicesfile)
@@ -715,7 +715,7 @@ sub prepare_regcomp_rdb
chdir($to);
-my $systemcall = "$installer::globals::wrapcmd $regcompfile -register -s -r " . fix_cygwin_path($regcomprdb) . " -c $libfilename";
+my $systemcall = "$regcompfile -register -s -r " . fix_cygwin_path($regcomprdb) . " -c $libfilename";
my $returnvalue = system($systemcall);
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] HM2自動手指洗手器(Auto Hand-Wa sher)+ 淨手液，超值特價組，清潔、衛生、健 康!(Adv)
Contact Prowol or Unsubscribe? 聯絡我們 或 不要收到 本電子報？ Infrared Sensor Auto Hand-Washer +++我們是一家以"協助教會、廣傳福音、幫助大家、省時省金"為宗旨的基督徒公司+++ 普洛瓦創意資訊有限公司Prowol Co., Ltd. Tel : 886-2-87706959 Fax : 886-2-87706917 E-mail : c...@prowol.com URL : www.prowol.com 統一編號 : 80680991 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 保證低價，投影機、布幕、音響； 5000流明投影機出租(福音用途每小時500元)(Ad v)
Contact Prowol or Unsubscribe? 聯絡我們 或 不要收到 本電子報？ 保證低價，投影機、布幕、音響、影音工程設計規劃 5000流明投影機出租，租金超便宜，(福音用途每小時500元「以實 際使用小時收費，自取價」)。歡迎來電洽詢! +++我們是一家以"協助教會、廣傳福音、幫助大家、省時省金"為宗旨的基督徒公司+++ 普洛瓦創意資訊有限公司 Tel : (02)87706959 Fax : (02)87706917 E-mail : c...@prowol.com 網址 : www.prowol.com 統一編號 : 80680991 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] large swathes of commented/#if 0 code removed
Hi Caolan, Caolán McNamara píše v Po 08. 11. 2010 v 21:14 +: > caolanm->kendy: What's the story with the conversion of leading tabs > to space and the whitespace checkin rules. e.g. We can't checking in > trailing whitespace, but nearly every file has trailing whitespace on > line 4 :-) I'm guessing we can't just automate the removal of trailing > whitespace ? Oh well, my mistake when I did the svn -> git conversion tool initially was that I was changing just the leading tabs, but not removing the trailing whitespace :-( - that would save us some burden these days. It is not that easy to change now, unfortunately. A week or 2 ago, I've extended the pre-commit git hook (git-hooks/pre-commit) so that whenever you introduce trailing whitespace in code (\.\(c\|cpp\|cxx\|h\|hrc\|hxx\|idl\|java\)), it runs 'git stripspace' on the files you are about to commit that have whitespace errors, and fixes them silently. This is probably too intrusive - it fixes whitespace even on the lines you did not touch. If it is not desirable, I'll update the hook so that it fixes just the lines where the committer introduces the trailing whitespace, and won't touch the rest of the whitespace errors - should I? Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Export OLE objects as PDF / graphics
Hi, Following the hints of Michael Meeks in : 'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in writer. It's 'raw code' : just wondering if it satisfies the required functionality. Regards. export_4.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] RTL patches for canvas and chart2
Hello again list, My last contribution of the day, with two RTL patches for canvas/ and chart2/ . Cheers, Kevin canvas_rtl_easy_hack.tbz Description: application/bzip-compressed-tar chart2_rtl_easy_hack.tbz Description: application/bzip-compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: large swathes of commented/#if 0 code removed
I am not a perl expert, but I have figured out this command: perl -i.bak -wpl -e 's/ +$//g;' *.cxx The original files are save as *.bak and can be removed if the revoval of taling spaces was correct. Joost 2010/11/8 Caolán McNamara > On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote: > > At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote: > > > Subject says it all. Patch against three files under > > > > > > automation/source/ > > Pushed the substantial hacking out of the commented-out code in > automation. Thanks. I'm holding back on the end of line whitespace stuff > because all of our files have it, at least in line 4 :-). Maybe we can > resolve all of those in one fell swoop somehow. > > C. > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] large swathes of commented/#if 0 code removed
On Mon, 2010-11-08 at 21:14 +, Caolán McNamara wrote: > caolanm->kendy: What's the story with the conversion of leading tabs to > space and the whitespace checkin rules. e.g. We can't checking in > trailing whitespace, but nearly every file has trailing whitespace on > line 4 :-) I'm guessing we can't just automate the removal of trailing > whitespace ? Riight - was the idea of the no-trailing-whitespace thing to make it easier to read diffs, where we changed this by mistake ? If so - surely, we can check that we didn't change a file to add whitespace on a line where it was not before ? Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] More easy hack RTL goodness
Hullo again, Some more easy hack RTL code. bridges/ Kevin bridges_rtl_easy_hack.tbz Description: application/bzip-compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: large swathes of commented/#if 0 code removed
At 4:23pm -0500 Mon, 08 Nov 2010, Caolán McNamara wrote: Pushed the substantial hacking out of the commented-out code in automation. Thanks. I'm holding back on the end of line whitespace stuff because all of our files have it, at least in line 4 :-). Maybe we can resolve all of those in one fell swoop somehow. Sweet. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix linking the hyphen library
On Mon, 2010-11-08 at 17:42 +0100, Robert Nagy wrote: > Making:libhyphen.so Ah, this is in lingucomponent/source/hyphenator/altlinuxhyph/hyphen right ? Then this is a duplicate of the other problem you had with the build breakage in i18npool. It should be making libhyphen$(DLLPOSTFIX).so and that itself should be linked against the entirely different libhyphen.a in solver/../lib Is this problem now gone after adding that DLLPOSTFIX=ob into solenv/inc/unxobsd.mk that I see is there now ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: large swathes of commented/#if 0 code removed
On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote: > At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote: > > Subject says it all. Patch against three files under > > > > automation/source/ Pushed the substantial hacking out of the commented-out code in automation. Thanks. I'm holding back on the end of line whitespace stuff because all of our files have it, at least in line 4 :-). Maybe we can resolve all of those in one fell swoop somehow. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] large swathes of commented/#if 0 code removed
On Mon, 2010-11-08 at 02:36 -0500, Kevin Hunter wrote: > At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote: > > Subject says it all. Patch against three files under > > > > automation/source/ caolanm->kendy: What's the story with the conversion of leading tabs to space and the whitespace checkin rules. e.g. We can't checking in trailing whitespace, but nearly every file has trailing whitespace on line 4 :-) I'm guessing we can't just automate the removal of trailing whitespace ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED, partial] Re: more comment removal, rtl easy hack
At 4:06pm -0500 Mon, 08 Nov 2010, Caolán McNamara wrote: I only pushed a few hunks of the comment removal stuff though. I'm no fan of the line separators or particularly in love with the commenting format, but there is potentially useful info in having the service name that each block implements mentioned and while your style is my style I don't know if we want to force it on every existing line of code right now :-) No prob. I'll stop removing those, until those more-in-the-know can come up with a code style for the project. Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED, partial] Re: more comment removal, rtl easy hack
On Mon, 2010-11-08 at 01:33 -0500, Kevin Hunter wrote: > Hullo Committers, > > Another patch set, this time against > > accessibility/source/standard/ I pushed all the RTL_macro foo, all good, thanks. I only pushed a few hunks of the comment removal stuff though. I'm no fan of the line separators or particularly in love with the commenting format, but there is potentially useful info in having the service name that each block implements mentioned and while your style is my style I don't know if we want to force it on every existing line of code right now :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: comment removal, rtl easy hack
On Mon, 2010-11-08 at 01:11 -0500, Kevin Hunter wrote: > Hullo Committers, > > A patch set against directory: > > accessibility/source/helper RTL_foo macro looks good, thanks for this :-) and I added in the comment stuff as well while I was at it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] How to build for 3.3
Hi,
I read the wiki page
http://wiki.documentfoundation.org/Development/How_to_build
and noticed we do not mention anything about how to build the
libreoffice-3.3 branch.
Here is what works for me:
git clone /path/to/build.git libreoffice-3-3
cd libreoffice-3-3
git checkout --track origin/libreoffice-3-3 *
./autogen.sh
./download
bin/g checkout --track origin/libreoffice-3-3 *
make unpack **
cd rawbuild
*: additional command that could be mentioned on the wiki page
**: I get a warning called:
Checking for current branch of
/home/vmiklos/git/libreoffice/libreoffice-3-3/clone/sdk ... warning, current
branch is libreoffice-3-3
when that make target is executed.
Two questions:
1) Is there a better approach to do this, or this is the way to go? If
the later is the case, then I want to document this on the above wiki
page.
2) I'm attaching two patches:
a) Avoid the usage of git-branch (usual problem: git-branch is a git
porcelain command so its output may change any time without notice).
b) Don't check if master is checkout out, check if the branch is the
same as the branch of build.git, so that people won't get a warning
during proper libreoffice-3-3 build.
Is it OK to push these patches to libreoffice-3-3? (I would push them to
master, but make unpack is broken there for me, saying:
make: /home/vmiklos/git/libreoffice/bin/transform: Command not found)
Thanks.
From adc319cbd1e9436b9606329f3abb7b607c040984 Mon Sep 17 00:00:00 2001
From: Miklos Vajna
Date: Mon, 8 Nov 2010 21:34:08 +0100
Subject: [PATCH 1/2] unpack: avoid using git-branch
git-branch is porcelain, use plumbing commands instead.
---
bin/unpack |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/bin/unpack b/bin/unpack
index 135a33a..933191b 100755
--- a/bin/unpack
+++ b/bin/unpack
@@ -43,12 +43,11 @@ check_git_repo()
tree="$CLONEDIR/$1"
$echo_n "Checking for current branch of $tree ... $echo_c";
if cd "$tree" >/dev/null 2>&1 ; then
- IS_MASTER=`git branch | grep '^\* master$'`
-if test -n "$IS_MASTER" ; then
+CURRENT_BRANCH=`git symbolic-ref HEAD|sed 's|.*/||'`
+if test "$CURRENT_BRANCH" = "master"; then
echo "ok"
else
-$echo_n "warning, current branch is "
- git branch | grep '^\*' | sed 's/^.//'
+echo "warning, current branch is $CURRENT_BRANCH"
fi
else
echo "missing the $tree clone; run './download'"
--
1.7.3.2
From c3dd03f2627ef9f3faea7e10b3aac3eda2f09d51 Mon Sep 17 00:00:00 2001
From: Miklos Vajna
Date: Mon, 8 Nov 2010 21:36:10 +0100
Subject: [PATCH 2/2] unpack: don't warn on master branch
Don't check if the 'master' branch of the repos is checked out, check if
the branch is the same as the branch of the parent repo.
---
bin/unpack |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/bin/unpack b/bin/unpack
index 933191b..553180d 100755
--- a/bin/unpack
+++ b/bin/unpack
@@ -42,9 +42,10 @@ check_git_repo()
{
tree="$CLONEDIR/$1"
$echo_n "Checking for current branch of $tree ... $echo_c";
+BUILD_BRANCH=`git symbolic-ref HEAD|sed 's|.*/||'`
if cd "$tree" >/dev/null 2>&1 ; then
CURRENT_BRANCH=`git symbolic-ref HEAD|sed 's|.*/||'`
-if test "$CURRENT_BRANCH" = "master"; then
+if test "$CURRENT_BRANCH" = "$BUILD_BRANCH"; then
echo "ok"
else
echo "warning, current branch is $CURRENT_BRANCH"
--
1.7.3.2
pgpa9nJtW11ZA.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] A typo in svx/source/gallery2/galtheme.src etc.
Hi Kohei, On Mon, 08 Nov 2010 12:40:03 -0500, Kohei Yoshida wrote: (snip) >> Excellent! The change looks good, and I build-tested on master. >> >> Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre >> to make sure if we are still before the string freeze.. Andre? :-) > > Just FYI, > > I talked to Andre on IRC, and since luckily we haven't announced string > freeze yet I was able to squeeze this piece into the 3.3 branch. sounds great, thanks for your mention! -- Takeshi Abe > > Kohei > > -- > Kohei Yoshida, LibreOffice hacker, Calc > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
Le 08/11/2010 14:33, Caolán McNamara a écrit : On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you log a bug against cppcheck itself with this example, including the operator overload information. The cppcheck guys aim for no false positives so that would be helpful for both them and us. C. Hello, It's done now, ticket 2180 on the sourceforge of cpppcheck. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] touch up work on the previous patch
On Mon, 2010-11-08 at 20:51 +0100, René Kjellerup wrote: > hi', > > cleaned some coments > and killed an unused function Looks good. Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] touch up work on the previous patch
hi', cleaned some coments and killed an unused function fun and all René -- -- as life grows older, I gain experience. 0001-comment-crean-up-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] easyhack: remove blocks of commented code
Hi List, A patch to remove large blocks of already commented code. basic/ Cheers, Kevin basic_commented_removed.tgz Description: application/compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] easy hack, rtl against basebmp/
Hi List, Here's an RTL patch against basebmp/ . Kevin basebmp_rtl_easy_hack.tgz Description: application/compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] accessibility easy hack, RTL
Hullo List, Another RTL_CONST patch, also against accessibility/ . Cheers, Kevin 0001-EasyHack-createAsciiFrom-RTL_CONST.patch.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] easyhacks - simplify download of Windows dependencies
Hi Peter, On 2010-11-02 at 21:19 -0300, Peter Burtt wrote: > The cygwin SETUP.EXE accepts a comma-delimited list of packages to > install. To install cygwin and the packages listed as prerequisites on > http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide/Building_on_Windows#setting_up_cygwin > > use this syntax: > > setup.exe -P > unzip,zip,autoconf,bison,flex,gcc-gcc++,gperf,make,openssl-devel,mercurial,readline,openssl,openssh,perl,mintty,patch,gnupg,wget Cool, thank you! I have added pointer to your mail to the wiki, so that it can be part of the simplification of the Windows environment setup. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] easy hacks, commented code removal
Hello List, Here's another set of patches. Caolán, I think I've done a little better on the comments this time, but probably not yet perfect. accessibility/ Cheers, Kevin comment_removals.tbz Description: application/bzip-compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] A typo in svx/source/gallery2/galtheme.src etc.
On Mon, 2010-11-08 at 09:57 -0500, Kohei Yoshida wrote: > On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote: > > Hi, > > > > translating lo-build.pot to the Japanese .po, I found a typo in libs-core > > which affects a msgid (numbered as 277) in the .pot. > > It would be nice if we can apply the attached patch before the string > > freeze. > > Excellent! The change looks good, and I build-tested on master. > > Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre > to make sure if we are still before the string freeze.. Andre? :-) Just FYI, I talked to Andre on IRC, and since luckily we haven't announced string freeze yet I was able to squeeze this piece into the 3.3 branch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Presentation Wizard
Hi Christoph, On 2010-11-03 at 00:29 +0100, Christoph Noack wrote: > I'm answering here since - if there is some dev interest - there are > some more ideas on different lists that might be worth considering. Even > "Easy / Medium Hacks" that turn out to be very visible ... Oh - it seems it works best just to add those to the Easy Hacks page [1], so that everything is on one place. Do you think you could add them there, please? :-) Thank you, Kendy [1] http://wiki.documentfoundation.org/Development/Easy_Hacks ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] (no subject)
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] simple comment removal
At 11:46am -0500 Mon, 08 Nov 2010, Caolán McNamara wrote: Hum, the comments like... [ good comments ] [ aren't in the same category as ] /*->start removed 2010.10.10 <-end removed 2010.10.10*/ Noted. I'm just learning the ropes of what's important in this code base. I tend to think that folks have more sophisticated tools and IDEs with which to work, but perhaps should stick with the simplest common denominator. Thanks for the pointer. Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice] [PATCH] Commented-out code for the day
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote: > here is more commented code removal. Ok. Just pushed the remaining chart2 part of the patch. All looks good. Thanks much. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] simple comment removal
On Sun, 2010-11-07 at 23:53 -0500, Kevin Hunter wrote: > Hullo Committers, > > A simple patch set to remove some unnecessary comments. As always, LGPLv3. Hum, the comments like... // XServiceInfo // XAccessible are being used to indicate in this multiply inherited class for which parent class the following block APIs are being implemented for, so they do have some utility. I'm a little unwilling to bin them into the same category as the more clear-cut /*->start removed 2010.10.10 <-end removed 2010.10.10*/ kind of distraction. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'
On Mon, 2010-11-08 at 15:18 +0100, Gert Faller wrote: > yes, I checked that too. > Do you think that can be left untouched ? They can probably be left untouched without much harm at first glance, but removing the three duplicated and apparently dead ones is probably the right thing to do if you want to cook up a patch to do that for us. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix linking the hyphen library
On (2010-11-08 16:29), Caolán McNamara wrote: > On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote: > > If the internal hyphen library is used which does not > > build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a, > > instead of using -lhyphen on UNX + GCC. > > How come, the -L options should place solarlibdir before the system > ones, so -Lhyphen should link against libhyphen.a first before going > looking for anything else ? > > Have you placed /usr/local/lib or /usr/lib or something into your linker > flags before SOLARLIBDIR and have another libhyphen in there ? > > C. > No we don't have a libhyphen on the system, we are using the internal one, and /usr/local/lib is after SOLARLIBDIR. Making:libhyphen.so g++ -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-zdynsort -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -Wl,-O1 -Wl,--version-script ../../../../unxobsd.pro/misc/component_hyphen.map -L../../../../unxobsd.pro/lib -L../lib -L/home/robert/build.HEAD/build/libreoffice-3.2.99.2/solenv/unxobsd/lib -L/home/robert/build.HEAD/build/libreoffice-3.2.99.2/solver/330/unxobsd.pro/lib -L/home/robert/build.HEAD/build/libreoffice-3.2.99.2/solenv/unxobsd/lib -L/usr/local/lib -L/usr/local/jdk-1.5.0/lib -L/usr/local/jdk-1.5.0/jre/lib/amd64 -L/usr/local/jdk-1.5.0/jre/lib/amd64/server -L/usr/local/jdk-1.5.0/jre/lib/amd64/native_threads -L/usr/X11R6/lib ../../../../unxobsd.pro/slo/hyphen_version.o -o ../../../../unxobsd.pro/lib/libhyphen.so ../../../../unxobsd.pro/slo/hreg.o ../../../../unxobsd.pro/slo/hyphenimp.o ../../../../unxobsd.pro/slo/lingutil.o -luno_cppu -luno_cppuhelpergcc3 -li18nisolang1gcc3 -ltl -lsvl -luno_sal -lutl -llng /home/robert/build.HEAD/build/libreoffice-3.2.99.2/solver/330/unxobsd.pro/lib/libhyphen.a -lulingu -L/usr/local/lib -lhunspell-1.2 -Wl,--as-needed -pthread -lm -Wl,--no-as-needed rm -f ../../../../unxobsd.pro/lib/check_libhyphen.so mv ../../../../unxobsd.pro/lib/libhyphen.so ../../../../unxobsd.pro/lib/check_libhyphen.so /home/robert/build.HEAD/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh -L../../../../unxobsd.pro/lib -L/home/robert/build.HEAD/build/libreoffice-3.2.99.2/solver/330/unxobsd.pro/lib ../../../../unxobsd.pro/lib/check_libhyphen.so Checking DLL ../../../../unxobsd.pro/lib/check_libhyphen.so ...: ok -rwxrwxr-x 1 robert users 134737 Nov 8 17:41 ../../../../unxobsd.pro/lib/libhyphen.so Making:all_hyphen_lib.dpslo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote: > here is more commented code removal. Reviewed and pushed the part against the 'base' module. Thanks a lot! One thing to note: you added a blank line between the else if blocks, but I didn't add that change, as I consider that to be unnecessary and we don't normally do it in this code base. Other than that, all looks good. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix linking the hyphen library
On Sun, 2010-11-07 at 20:42 +0100, Robert Nagy wrote: > If the internal hyphen library is used which does not > build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a, > instead of using -lhyphen on UNX + GCC. How come, the -L options should place solarlibdir before the system ones, so -Lhyphen should link against libhyphen.a first before going looking for anything else ? Have you placed /usr/local/lib or /usr/lib or something into your linker flags before SOLARLIBDIR and have another libhyphen in there ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
On Mon, 2010-11-08 at 10:57 -0500, Norbert Thiebaud wrote:
> On 11/8/10, Noel Power wrote:
> > returns true if it was able to successfully extract the value from the
> > 'theAny' into 'something' so there is a possibility of a runtime divide
> > by zero ( and probably should be defensively coded around )
> >
>
> humm... yes you are right.
*cough*, yeah that's true isn't it :-).
-if (asd >>= nMapWidth)
+if (asd >>= nMapWidth && nMapWidth)
{
...
}
should be a good fix if someone wants to lamp that in.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] New credits page up (and linked from TDF)
Sebastian Spaeth wrote: > > What would be super-nice, would be if we could have a patch a little > > like the Help->License info one - cf. sfx2/source/appl/appserv.cxx - > > that would load a nice ODF document containing the output of your work - > > so that we cna ship that with the binaries, and make it available > > off-line too, as a snapshot of that version. > > That would be nice, but it won't be me that creates that patch :). > Ah sorry, my backlog is building up - I actually added that feature - now we only need a nice credits .odt. ;) Cheers, -- Thorsten pgp2JSUmDqsSn.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [Patch] ure: Remove bogus WITH_CORE debug code which core dumps
On Mon, 08 Nov 2010 14:59:37 +0100, Sebastian Spaeth wrote: > > There was #ifdef'd test code depending on WITH_CORE being defined (which > is never set in our build system). It is described as test code that > will core dump for sure. So let's remove this and write proper cppunit > tests instead. All this concerns two files in 'qa' and not "real source > code". This has been pushed now. Sebastian pgpfqcCSbJLNS.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day
On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote: > here is more commented code removal. Reviewed and applied the part against the 'sc' module. Thanks a lot! I removed everything except for the one in sc/inc/compiler.hxx (below). @@ -101,13 +101,6 @@ class ScTokenArray; // constants and data types internal to compiler -/* -OpCode eOp; // OpCode -formula::StackVar eType; // type of data -USHORT nRefCnt; // reference count -BOOL bRaw; // not cloned yet and trimmed to real size - */ - #define SC_TOKEN_FIX_MEMBERS\ OpCode eOp; \ formula::StackVar eType;\ That comment there was clearly used to annotate the defined macros immediately below it, so I considered it'd be better to keep that one. The other parts of your patch have not been reviewed yet. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
On 11/8/10, Noel Power wrote: > On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: >> On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > >> Ahh, welcome to the wonderful world of operator overload. >> >>= is not a right shift but instead, here, nMapWith get populated with >> >> the property (uno) value, converted to a int32. >> >> and the if() can only be true if that value is not 0 >> so here you have a false positive. > > > Are you sure? iirc > bool operator >>= ( Any& theAny, SomeType& something ) // probably the > wrong signature but you know what I mean > > returns true if it was able to successfully extract the value from the > 'theAny' into 'something' so there is a possibility of a runtime divide > by zero ( and probably should be defensively coded around ) > humm... yes you are right. Norbert > > Noel > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] remove -d from gunzip flags
On Sat, 2010-11-06 at 19:50 +0100, Robert Nagy wrote: > Hey > > I don't really care which one goes in. I think gzip -d might > be a better idea then. Any other comments? I say go ahead with "gzip -d", should be fine for everyone. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 6th week development summary
Hi,
this time a brief summary of what happened the 6th week on LibreOffice
repos and two living branches:
bugfixes-master-week-44.txt lists all commits that reference a proper
bug id (from a variety of trackers - #i... referring to the OpenOffice
issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the
master branch
commit-log-master-week-44.txt lists all relevant commits on the actual
source repos in the master branch
commit-log-libreoffice-3-3-week-44.txt,
bugfixes-libreoffice-3-3-week-44.txt lists the same summary for the
libreoffice-3-3 branch.
Many thanks to all contributors - you make all the difference!
Best Regards,
Petr
+ artwork:
+ Update BROffice branding (fdo#31089) [Olivier Hallot]
+ bootstrap:
+ create the installation dir when defined (fdo#30837) [Petr Mladek]
+ fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek]
+ use versioned path in download tarballs (fdo#30837) [Petr Mladek]
+ components:
+ rhbz#648475# crash in scanner dialog, reset link in dtor [Caolán McNamara]
+ Update BROffice branding for Windows and MAC installer (fdo#31089) [Petr
Mladek]
+ libs-core:
+ #i113803# Add label specification for Tower manufacturer [Dwayne Bailey]
+ OO Basic Million-to-One bug (#i76852#) fixed [John LeMoyne Castle]
+ rhbz#649824# this key name is wrong [Caolán McNamara]
+ writer:
+ setup xml namespaces also for footers and headers (bnc#581954) [Luboš
Luňák]
+ common:
+ High-Contrast Cleanup Phase #1 [Joseph Powers]
+ bootstrap:
+ create the installation dir when defined (fdo#30837) [Petr Mladek]
+ fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek]
+ use versioned path in download tarballs (fdo#30837) [Petr Mladek]
+ components:
+ rhbz#648475# crash in scanner dialog, reset link in dtor [Caolán McNamara]
+ Update BROffice branding for Windows installer (fdo#31089) [Petr Mladek]
+ libs-core:
+ #i113803# Add label specification for Tower manufacturer [Dwayne Bailey]
+ OO Basic Million-to-One bug (#i76852#) fixed [John LeMoyne Castle]
+ rhbz#649824# this key name is wrong [Caolán McNamara]
+ ure:
+ #i112929# unused s_semi [Caolán McNamara]
+ writer:
+ First fix for i#82680 [Cédric Bosdonnat]
+ setup xml namespaces also for footers and headers (bnc#581954) [Luboš
Luňák]
+ common:
+ Adding Barcode extension [Kalman Szalai - KAMI]
+ Adding Validator extension [Kalman Szalai - KAMI]
+ add OPENBSD ifdefs where needed [Robert Nagy]
+ Changing a few more strings to read "LibreOffice" [Thorsten Behrens]
+ make LibreOffice boostrap on OpenBSD [Robert Nagy]
+ Merge commit 'ooo/OOO330_m13' [Jan Holesovsky]
+ Save 1MB on wizards per language [Kalman Szalai - KAMI]
+ Use org.libreoffice.script for Mac preferences [Thorsten Behrens]
+ artwork:
+ Changed some remaining OOo icons to LO icons [Cédric Bosdonnat]
+ Changed the printeradmin icons to use LO symbol [Cédric Bosdonnat]
+ Update BROffice branding (fdo#31089) [Olivier Hallot]
+ bootstrap:
+ better name directory with download tarballs [Petr Mladek]
+ Cleaning and organizing of configure.in [Niko Rönkkö]
+ correctly check Template Pack and Lightproof with --with-lang=ALL
[Bernhard Rosenkraenzer]
+ create the installation dir when defined (fdo#30837) [Petr Mladek]
+ -DBOOST_NO_EXCEPTIONS for OpenBSD [Robert Nagy]
+ Don't add an explicit -L/usr/lib or -L/usr/lib64. [Jan Holesovsky]
+ extra optimization unsafe for earlier gccs [Caolán McNamara]
+ Fix a typo [Kalman Szalai - KAMI]
+ Fix bootstrap's configure [Kalman Szalai - KAMI]
+ fix ooinstall to create the installation dir [Petr Mladek]
+ fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek]
+ Install and register the oo3 migration code [Michael Meeks]
+ Merge branch 'master' of
ssh://git.freedesktop.org/git/libreoffice/bootstrap [Jan Holesovsky]
+ move undefined(!) $setup_vars{'X'} to $ENV{'X'} in solenv/bin/ooinstall
[Rene Engelhard]
+ OpenBSD needs /usr/local/lib in SOLARLIB [Robert Nagy]
+ pick up system jpeg on openbsd [Robert Nagy]
+ Removed deprecated option [Niko Rönkkö]
+ return early if source doesn't exist on symlink [Caolán McNamara]
+ set correct $outfile for OpenBSD [Robert Nagy]
+ set SHORT_PRODUCTEXTENSION to beta3 [Petr Mladek]
+ strcpy cannot be used with overlapping src and dest [Caolán McNamara]
+ sync with the generic linux makefile [Robert Nagy]
+ use system jpeg on OpenBSD [Robert Nagy]
+ use versioned path in download tarballs (fdo#30837) [Petr Mladek]
+ Wrong option name in help bootstrap [Niko Rönkkö]
+ build:
+ better fix impressmedia-features.diff to apply [Petr Mladek]
+ Breton lang files [Korvigelloù an Drouizig]
+ Do not pack presets/config/standard.soc.orig [Petr Mladek]
+ do not try to move intro.bmp; is not longer installed [Petr Mladek]
+ ema
[Libreoffice] [PUSHED] Re: one final (for tonight) rtl patch
On Mon, 2010-11-08 at 02:42 -0500, Kevin Hunter wrote: > Hullo Committers, > > One more RTL easy hack commit against: Also looks good, pushed now as well, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Some more rtl easy hack goodness
On Mon, 2010-11-08 at 00:59 -0500, Kevin Hunter wrote: > Hullo List, > > Some accessibility tabbar RTL_CONST conversion goodness. Looks good, pushed. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] use LIBTARGET=NO to avoid multiple definition of target recipe
On Sun, 2010-11-07 at 19:53 +0100, Robert Nagy wrote: > The diff makes i18npool/source/paper/makefile.mk define > LIBTARGET=NO just like other makefiles in the i18npool/source/ directory. > Without this patch I always get: > > dmake: /home/robert/build/build/libreoffice-3.2.99.2/solenv/inc/_tg_lib.mk: > line 1020: Error: -- Multiply defined recipe for target > ../../unxobsd.pro/slb/i18npaper.lib > > Okay to push? That shouldn't happen, what's happening there is a side-effect of the "DLLPOSTFIX" being empty for your platform. See step 3 of http://wiki.services.openoffice.org/wiki/Lazy_Hackers_Guide_To_Porting I imagine your platform .mk is unxobsd.mk ? That one needs a DLLPOSTFIX of some value. Set one there instead and that should fix that among other problems. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 3
On Sun, 2010-11-07 at 19:29 +0100, Gert Faller wrote: > HI, > > here are some more in libs-core > All good, except BACKEND_SERVICE_NAME isn't a define or a [] so that one would have resolved to ... sizeof(char*) which is always 4 on 32bit machines and 8 on 64bit machines, i.e. not what we need here. To keep things simple I changed it to a define instead :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] A typo in svx/source/gallery2/galtheme.src etc.
On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote: > Hi, > > translating lo-build.pot to the Japanese .po, I found a typo in libs-core > which affects a msgid (numbered as 277) in the .pot. > It would be nice if we can apply the attached patch before the string freeze. Excellent! The change looks good, and I build-tested on master. Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre to make sure if we are still before the string freeze.. Andre? :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH to test on Windows env] memory leak htags.cpp according to cppcheck
On Sun, 2010-11-07 at 14:16 +0100, julien wrote: > Hello, > > I can't test this patch since this part of code is for Windows but i > think it's a true positive Yes, I agree, its a potential memory leak > Is this ok or am I wrong ? Yeah, this is ok, and I've pushed this fix, thanks :-) Though, if you look at the rest of the early returns in that function, most of the rest of them also leak that data too, e.g. if the ReadBlock fails it also leaks, and if the StgOpenStorage fails it also leaks as well. I fixed up those additional ones myself with some more delete[] at the right places, though something like a std::vector would make it all easier to read I guess. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'
Selon Caolán McNamara : > Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to > opengrok) unused the FN_PAGE_STYLE_SET_LR_MARGIN and > FN_PAGE_STYLE_SET_UL_MARGIN i.e. one version of the + 130 and + 131 are > only mentioned in basesh.cxx as "false not implemented". > > So I reckon those three should go entirely to avoid the duplicate ids. Hi, yes, I checked that too. Do you think that can be left untouched ? Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] ure: Fix some typos in documentation
On Sun, 2010-11-07 at 12:53 +0200, Aurimas Fišeras wrote: > Fixes more typos in documentation. > > Patch is contributed under the LGPLv3+. Looks good, all pushed. Thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] dev-install build improvement
On Fri, 2010-11-05 at 20:19 +0530, surensp...@gmail.com wrote: > Updated the second patch and tested it. Looks good to me, pushed this now. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] smoketest
On Sat, 2010-11-06 at 10:13 -0500, Norbert Thiebaud wrote: > There is some improvement on the smoketest front > > It run pass many more tests.. but still do not finish: The smoketest passes every time for me. FWIW > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x7f0a3aab45ce, pid=31378, tid=139682275239680 There's clearly a problem, and we should find out what it is. So... What's your distro and version. Versions of java and versions of gcc and glibc ? As an aside, is accessibility enabled or disabled in your desktop ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: > On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > >the if() can only be true if that value is not 0 so here you have a false > >positive. Julien, could you log a bug against cppcheck itself with this example, including the operator overload information. The cppcheck guys aim for no false positives so that would be helpful for both them and us. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Adapt LibreOffice branding in LibO-SDK user installation script.
On Fri, 2010-11-05 at 15:30 +0100, Giuseppe Castagno wrote: > Hi all, > > I tried to install the LibO-SDK as generated in my build from master, > and I noted that has some link/mingling with OOo. Looks good, pushed to head and I cherrypicked it for Libo 3.3 as well C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Removal of some more bogus comments and commented code
On Fri, 2010-11-05 at 09:14 +0200, Robert Roth wrote: > Some more comments and commented code removed, code co- licensed under > LGPLv3+, GPLv3+ and MPL. Looks good to me, modulo one type (reloaed) which I fixed, committed and pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building problem, OpenSuse 10.3, 64bits, javac
2010/11/8 Joost Eekhoorn > I have switched from Ubuntu to OpenSuse. > This OpenSuse is a bare system with the latest update, thus OpenSuse 10.3. > I removed the OpenOffice. > > Then I tried: > sudo zypper si -d OpenOffice_org-bootstrap > but that did not work. I say that 10.3 was not yet defined, thus I did the > required installations manually, following the list of 10.2. > With jre/jvm I had problems. I finally installed java-1.6.0-openjdk-1.6.0. > Then it passed the first part of "make" and started building, til: > > Entering /home/joost/work/build/build/libreoffice-3.2.99.2/ridljar/com > > Making:com.dpj > > /usr/lib64/jvm/jre/bin/javac -source 1.5 -target 1.5 -classpath ".:../ > unxlngx6.pro/class:/usr/lib64/jvm/jre/jre/lib/rt.jar:." -d ../ > unxlngx6.pro/class @/tmp/mkq2jhLz > Exception in thread "main" java.lang.NoClassDefFoundError: > com/sun/tools/javac/Main > Caused by: java.lang.ClassNotFoundException: com.sun.tools.javac.Main > at java.net.URLClassLoader$1.run(URLClassLoader.java:217) > at java.security.AccessController.doPrivileged(Native Method) > at java.net.URLClassLoader.findClass(URLClassLoader.java:205) > at java.lang.ClassLoader.loadClass(ClassLoader.java:321) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294) > at java.lang.ClassLoader.loadClass(ClassLoader.java:266) > at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:334) > Could not find the main class: com.sun.tools.javac.Main. Program will exit. > dmake: Error code 1, while making '../unxlngx6.pro/misc/com_dummy.java' > > Must I install another jre/jvm/jdk ? > > Joost > I did remove java-1.6.0-openjdk-1.6.0 and insalled java-1.6.0-sun and java-1.6.0-sun-devel but then it could not the java using $JAVA_HOME. With "env" I saw: JAVA_HOME=/usr/lib64/jvm/jre I changed that to JAVA_HOME=/usr/lib64/jvm/java (export JAVA_HOME=/usr/lib64/jvm/java) This solved my problem. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] patches as attachments or mails? (Poll included)
On Mon, 08 Nov 2010 09:37:34 +0100, Sebastian Spaeth wrote: > wiki, as that causes lots of confusion. Is there consensus by committers > whether we want to have patches attached to a mail or sent inline with > "git send-email"? Depending on the outcome, I'll write up the > recommendation accordingly. I'll leave the poll up a bit longer, but we already have a trend of 10:2 for attachments rather then inlined 'git send-email'. So attaching patches (or offering trees to pull from?) it is. Thanks S ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] patches as attachments or mails? (Poll included)
On Mon, 08 Nov 2010 14:11:23 +0200, Jani Monoses wrote: > On 11/08/2010 10:37 AM, Sebastian Spaeth wrote: > > I think, I'll add a "how to prepare and send patches" section to the > > wiki, as that causes lots of confusion. Is there consensus by committers > > whether we want to have patches attached to a mail or sent inline with > > "git send-email"? Depending on the outcome, I'll write up the > > recommendation accordingly. > > Could pulling from repos/branches be considered as a way of contributing? >From my personal point of view - absolutely. But I guess this depends on the preferences of the person who would do the pulling and should be discussed on an individual basis? (Note that I don't have any say or clout in the community of committers) But it's a good point, I'll include that in the help section as an alternative to "preparing patches". Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] patches as attachments or mails? (Poll included)
On 11/08/2010 10:37 AM, Sebastian Spaeth wrote: I think, I'll add a "how to prepare and send patches" section to the wiki, as that causes lots of confusion. Is there consensus by committers whether we want to have patches attached to a mail or sent inline with "git send-email"? Depending on the outcome, I'll write up the recommendation accordingly. Could pulling from repos/branches be considered as a way of contributing? Jani ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix linking the hyphen library
If the internal hyphen library is used which does not build a shared object, then link to $(SOLARLIBDIR)/libhyphen.a, instead of using -lhyphen on UNX + GCC. --- .../hyphenator/altlinuxhyph/hyphen/makefile.mk |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lingucomponent/source/hyphenator/altlinuxhyph/hyphen/makefile.mk b/lingucomponent/source/hyphenator/altlinuxhyph/hyphen/makefile.mk index f3626c7..3e002a4 100644 --- a/lingucomponent/source/hyphenator/altlinuxhyph/hyphen/makefile.mk +++ b/lingucomponent/source/hyphenator/altlinuxhyph/hyphen/makefile.mk @@ -32,10 +32,12 @@ TARGET = hyphen_lib ENABLE_EXCEPTIONS=TRUE USE_DEFFILE=TRUE -.IF "$(GUI)"=="OS2" -HNJLIB=hyphen.lib -.ELIF "$(GUI)"=="UNX" || "$(COM)"=="GCC" +.IF "$(GUI)"=="UNX" || "$(COM)"=="GCC" +.IF "$(SYSTEM_HYPH)"=="NO" +HNJLIB=$(SOLARLIBDIR)/libhyphen.a +.ELSE HNJLIB=-lhyphen +.ENDIF .ELSE HNJLIB=hyphen.lib .ENDIF -- 1.7.3.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Separate option descriptions
On Mon, 08 Nov 2010 11:09:36 +0200, Niko Rönkkö wrote: > > With the dependency tracking like this for example, it is not clear > > from the output of configure --help what the default is, on or off? > > Perhaps we should state that in the help text (default is enabled, or > > whatever fits) > > In this case The Default is somewhere between those options. As I said on IRC, if that is so, I rest my case. Please have someone push it in :) pgpJQyug6xsLj.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] A typo in svx/source/gallery2/galtheme.src etc.
Hi,
translating lo-build.pot to the Japanese .po, I found a typo in libs-core
which affects a msgid (numbered as 277) in the .pot.
It would be nice if we can apply the attached patch before the string freeze.
Cheers,
-- Takeshi Abe
diff --git a/svx/inc/gallery.hxx b/svx/inc/gallery.hxx
index 3656147..27fd7ee 100644
--- a/svx/inc/gallery.hxx
+++ b/svx/inc/gallery.hxx
@@ -175,7 +175,7 @@
#define GALLERY_THEME_MAPS_MIDDLE_AGES120
#define GALLERY_THEME_MAPS_MEXICO121
#define GALLERY_THEME_MAPS_ANCIENT_TIMES122
-#define GALLERY_THEME_MAPS_SIMBOLS123
+#define GALLERY_THEME_MAPS_SYMBOLS123
#define GALLERY_THEME_MAPS_HISTORY_1900124
#define GALLERY_THEME_MAPS_WORLD125
#define GALLERY_THEME_CROPS126
diff --git a/svx/inc/galtheme.hrc b/svx/inc/galtheme.hrc
index 820dec0..adf0837 100644
--- a/svx/inc/galtheme.hrc
+++ b/svx/inc/galtheme.hrc
@@ -156,7 +156,7 @@
#define RID_GALLERYSTR_THEME_MAPS_MIDDLE_AGES(RID_GALLERYSTR_THEME_START + 120)
#define RID_GALLERYSTR_THEME_MAPS_MEXICO(RID_GALLERYSTR_THEME_START + 121)
#define RID_GALLERYSTR_THEME_MAPS_ANCIENT_TIMES(RID_GALLERYSTR_THEME_START + 122)
-#define RID_GALLERYSTR_THEME_MAPS_SIMBOLS(RID_GALLERYSTR_THEME_START + 123)
+#define RID_GALLERYSTR_THEME_MAPS_SYMBOLS(RID_GALLERYSTR_THEME_START + 123)
#define RID_GALLERYSTR_THEME_MAPS_HISTORY_1900(RID_GALLERYSTR_THEME_START + 124)
#define RID_GALLERYSTR_THEME_MAPS_WORLD(RID_GALLERYSTR_THEME_START + 125)
#define RID_GALLERYSTR_THEME_CROPS(RID_GALLERYSTR_THEME_START + 126)
diff --git a/svx/source/gallery2/galtheme.src b/svx/source/gallery2/galtheme.src
index 381255b..99de47a 100644
--- a/svx/source/gallery2/galtheme.src
+++ b/svx/source/gallery2/galtheme.src
@@ -890,9 +890,9 @@ Text [ en-US ] = "Maps - Ancient times";
// ---
-String RID_GALLERYSTR_THEME_MAPS_SIMBOLS
+String RID_GALLERYSTR_THEME_MAPS_SYMBOLS
{
-Text [ en-US ] = "Maps - simbols";
+Text [ en-US ] = "Maps - symbols";
};
// ---
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: > On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > Ahh, welcome to the wonderful world of operator overload. > >>= is not a right shift but instead, here, nMapWith get populated with the > >>property (uno) value, converted to a int32. > > and the if() can only be true if that value is not 0 > so here you have a false positive. Are you sure? iirc bool operator >>= ( Any& theAny, SomeType& something ) // probably the wrong signature but you know what I mean returns true if it was able to successfully extract the value from the 'theAny' into 'something' so there is a possibility of a runtime divide by zero ( and probably should be defensively coded around ) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Building problem, OpenSuse 10.3, 64bits, javac
I have switched from Ubuntu to OpenSuse. This OpenSuse is a bare system with the latest update, thus OpenSuse 10.3. I removed the OpenOffice. Then I tried: sudo zypper si -d OpenOffice_org-bootstrap but that did not work. I say that 10.3 was not yet defined, thus I did the required installations manually, following the list of 10.2. With jre/jvm I had problems. I finally installed java-1.6.0-openjdk-1.6.0. Then it passed the first part of "make" and started building, til: Entering /home/joost/work/build/build/libreoffice-3.2.99.2/ridljar/com Making:com.dpj /usr/lib64/jvm/jre/bin/javac -source 1.5 -target 1.5 -classpath ".:../ unxlngx6.pro/class:/usr/lib64/jvm/jre/jre/lib/rt.jar:." -d ../ unxlngx6.pro/class @/tmp/mkq2jhLz Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/tools/javac/Main Caused by: java.lang.ClassNotFoundException: com.sun.tools.javac.Main at java.net.URLClassLoader$1.run(URLClassLoader.java:217) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:205) at java.lang.ClassLoader.loadClass(ClassLoader.java:321) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294) at java.lang.ClassLoader.loadClass(ClassLoader.java:266) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:334) Could not find the main class: com.sun.tools.javac.Main. Program will exit. dmake: Error code 1, while making '../unxlngx6.pro/misc/com_dummy.java' Must I install another jre/jvm/jdk ? Joost ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word
On Fri, 2010-11-05 at 18:13 -0700, John LeMoyne Castle wrote: > Hi all, [...] > Still new to git but I am sure I saw and built and ran the old txtedt.cxx > and still no LSQEW. Feelin' a bit lost ... I can think of some other > options for trying to find what fixed the LSQEW but I feel like I'm chasing > ghosts where they aren't. Maybe I have a magic bug eating build setup. I > hope not -- that would make troubleshooting impossible ;-) I wonder if the recent rebase to OOO330m13 is the culprit, would be interesting if you could test against the corresponding oracle dev build ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Separate option descriptions
> With the dependency tracking like this for example, it is not clear > from the output of configure --help what the default is, on or off? > Perhaps we should state that in the help text (default is enabled, or > whatever fits) In this case The Default is somewhere between those options. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] patches as attachments or mails? (Poll included)
I think, I'll add a "how to prepare and send patches" section to the wiki, as that causes lots of confusion. Is there consensus by committers whether we want to have patches attached to a mail or sent inline with "git send-email"? Depending on the outcome, I'll write up the recommendation accordingly. If you are a committer, please note your opinion on this simple 2-choice online poll with a single click: http://host1.easypolls.net/poll.html?p=29601 More elaborate options as reply to this thread :). Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Separate option descriptions
On Mon, 08 Nov 2010 09:05:41 +0200, Niko Rönkkö wrote: > It's not good to use option descriptions like --enable/disable-*. > > Also: If we want to replace default option descriptions with our owns, > then we shall describe them both (dependency-tracking). I am not opposed to the patch, but what I like about things like just having --disable-java is that it is clear that we default to enable. With the dependency tracking like this for example, it is not clear from the output of configure --help what the default is, on or off? Perhaps we should state that in the help text (default is enabled, or whatever fits) Opinions? Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
