Re: [Libreoffice] git via http ...
This works now, thanks! On 11/19/10 18:34, Michael Meeks wrote: Hi Marc, On Wed, 2010-11-03 at 10:16 +0100, Thorsten Behrens wrote: sorry, freedesktop git is only available via native git protocol - So - we now have a public http version (thanks to Tollef) - and it is here: git clone http://anongit.freedesktop.org/git/libreoffice/build.git/ Unfortunately, it still will not work with download ... we should add some code to download.in such that it will fallback to http: if git: is not available. I added this as an easy hack: http://wiki.documentfoundation.org/Development/Easy_Hacks#Make_download_fall-back_to_http It would be wonderful if you, or someone else, could help out with that. Thanks, Michael. __ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email __ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git via http ...
I would appreciate this step... On 11/20/10 00:20, Miklos Vajna wrote: On Fri, Nov 19, 2010 at 05:34:34PM +, Michael Meeksmichael.me...@novell.com wrote: not available. I added this as an easy hack: http://wiki.documentfoundation.org/Development/Easy_Hacks#Make_download_fall-back_to_http It would be wonderful if you, or someone else, could help out with that. Hmm, I don't want to question you, but maybe that's not really necessary. If we are going to get rid of the build repo for development, then we'll get rid of the download script as well, I guess. And then bin/g clone will be used for download, which will just use the same repo base url which was used to clone bootstrap.git, ie. no fall-back will be needed. Please correct me if I missed something. :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice __ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email _ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Are ISC/BSD-licensed contributions acceptable?
Hello, in bug #31633 I proposed a patch to one of the export filters. It looks like my contribution has been positively received but I have been asked to explicitly state that my contribution is licensed under the usual MPL 1.1 / GPLv3 / LGPLv3 and to add the standard LibreOffice license header to my file. While I have no problems with the usual LibO license, I prefer releasing my contributions under the ISC/OpenBSD license [1]. While it is legally possible to integrate ISC-licensed code in existing MPL/GPL/LGPL code bases [2], I would like to have an explicit assurance that using such licensed code is OK in LibreOffice. So, the question is: are ISC/BSD-licensed contributions acceptable? Regards, [1] The ISC license is a BSD-like license. It is very short; without the usual warranty disclaimer it is just: Copyright (c) 20YY John Doe Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies. [2] http://www.softwarefreedom.org/resources/2007/gpl-non-gpl collaboration.html -- Gioele Barabucci gio...@svario.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: 1) one would just run build -- dbglevel=2 in the desired module similarly as one runs build -- debug=true today. 2) As an alternative, we could add optional level argument to --enable-debug or add another option, say, --enable-assertions, that would do the same thing as --enable-debug and export dbglevel=1 in addition. 2) is more complicated, but also more discoverable and explicitely documented. I dislike secret ENVVARIABLE incarnations that enable things and not easily discoverable without trawling through READMEs. But you'd need the variable anyway, because, as I have said, full dbglevel=2 build is hardly a sensible thing to do. You'd be drowned in the output :-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 5 times LGPL installed
On Fri, 19 Nov 2010 15:45:08 +, Michael Meeks michael.me...@novell.com wrote: Hi there, On Fri, 2010-11-19 at 13:53 +0100, Sebastian Spaeth wrote: - Module readlicense_oo needs to be modified to not produce them. Patch is in git (and reverted again). oh - shame - why reverted ? Because my build was failing left and right, but as you said, a reboot (or clean shell) might have been all that was needed. I'll investigate this and if it works out this time, I'll push. So I had to revert this. If someone tackles it, can we put the README and LICENSE in the existing directories please? Currently 8 out of 13 topdir entries in our installation refer to some readme or license. Right - this is really silly. Still trying to understand what scp2 does and how it decides where to put stuff. I'll investigate and do that at some point. Sebastian pgpL7pyP5Ptvu.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Issues Wiki
A place where users can report bugs, That is bugs.freedesktop.org as has been mentioned. talk about new features, etc This mailing list? For more theoretical or political discussion about product vision etc, perhaps the discuss list at the document foundation? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 5 times LGPL installed
Hi! Still trying to understand what scp2 does and how it decides where to put stuff. I'll investigate and do that at some point. Sebastian If you pont the problem, cgit link, I might can help. KAMI -- Szalai Kálmán Best regards, Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com My favorite projects: OxygenOffice Professional - office suite - for everybody | Magyarul - In Hungarian Blog | Support Follow me, if you can signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] quickstarter causes crash on end of desktop session
Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see https://bugzilla.redhat.com/show_bug.cgi?id=650170, comments 5-14). The fix lets quickstarter shutdown the process when it gets destroy signal and avoids recursive call of Desktop::terminate. I've pushed the fix to libs-core, changeset 5dfa2bcf6f4a7699c2acae87caa96de739f82636 . Question: do we want that in 3.3? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] quickstarter causes crash on end of desktop session
On Mon, 2010-11-22 at 10:33 +0100, David Tardon wrote: Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see https://bugzilla.redhat.com/show_bug.cgi?id=650170, comments 5-14). The fix lets quickstarter shutdown the process when it gets destroy signal and avoids recursive call of Desktop::terminate. I've pushed the fix to libs-core, changeset 5dfa2bcf6f4a7699c2acae87caa96de739f82636 . Question: do we want that in 3.3? And of course, most people won't be aware of the crash seeing as it takes place during/after the shutdown of the desktop session, we get the reports because abrt captures it and reports it the next time you log in. *I* think we should try and fix it in LibreOffice 3.3 seeing as we're flooded with these over in RH land. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error
On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: hello, rm -rf * ./download Oh - that is going to waste a -lot- of time ;-) Just remove the build output, not the ( pristine ) git repos. 'make clean' should do that in the top-level. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Patches to review in IssueZilla
On Thu, 2010-11-18 at 08:57 +0100, Kálmán „KAMI” Szalai wrote: Hi, I searched across OOo issues. Do we have interesting item to review and/or integrate? http://tools.openoffice.org/issues/buglist.cgi?issue_type=PATCH;issue_status=UNCONFIRMED;issue_status=NEW;issue_status=STARTED;issue_status=REOPENED;email1=;emailtype1=exact;email2=;emailtype2=exact;issueidtype=include;issue_id=;changedin=;votes=;chfieldfrom=;chfieldto=;chfieldvalue=;short_desc=;short_desc_type=allwords;long_desc=;long_desc_type=allwords;issue_f ile_loc=;issue_file_loc_type=fulltext;status_whiteboard=;status_whiteboard_type=fulltext;keywords=;keywords_type=anytokens;field0-0-0=noop;type0-0-0=noop;value0-0-0=;Submit%20query=Submit%20queryorder=issues.issue_id We've got a lot of those in LibreOffice already, Cedric has a greasemonkey script thingy to indicate which are already fixed/integrated FWIW http://userscripts.org/scripts/show/87923 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [LO 3.3.0b3] Enable experimental (unstable) features?
Hi there, On Sun, 2010-11-21 at 20:43 -0800, NoOp wrote: No answers for this on the user list, so I'll ask here: .. Tools|Options|LibreOffice|General: - Enable experimental (unstable) features Does anyone know what this enables? Certainly ! :-) It enables in-line formula editing (so you can type inside the formula and navigate around it with cursor keys). It also enables macro recording (a perennially broken feature). HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Issues Wiki
Thank you all, i'll see the links. It's my first time with Bugzilla too. Regards, Júlio. 2010/11/22 Tor Lillqvist tlillqv...@novell.com A place where users can report bugs, That is bugs.freedesktop.org as has been mentioned. talk about new features, etc This mailing list? For more theoretical or political discussion about product vision etc, perhaps the discuss list at the document foundation? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Location of SfxPoolItem.Type() method
Hi Mattias, On Sun, 2010-11-21 at 00:21 +1100, Mattias Johnsson wrote: I've been trying to fix a bug in the search and replace code, and after a bit of hacking have discovered that in findattr.cxx there's a function Nice work :-) If I'm understanding things correctly, and I may not be, since the search and replace code is quite convoluted, in this case these SfxPoolItems are lists of attributes that one can search and replace for Right ... in this case I'm searching for a specific font size and replacing it with another. Interesting indeed :-) a new feature for search / replace ? So some of these pool items for things like font size are defined in: editeng/inc/editeng/fhgtitem.hxx as SvxFontHeightItem (I think). but for the life of me I can't find out where the Type() method is defined. I imagine this is the pre-RTTI type info ;-) I -guess- that it is generated by the 'TYPEINFO()' macro you see in the SfxPoolItem impl. cf. tools/inc/tools/rtti.hxx HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice Beta 3
Hi David, On Fri, 2010-11-19 at 18:54 -0500, David Burleigh wrote: I am running LibreOffice Beta 3 under Ubuntu 10.10 (64-bit) and it seems to gradually bog down with use, so that I have to exit and restart it several times a day. It gets so that cursor movement is very slow. This was also a problem with Beta 2, and I was hoping that Beta 3 would fix it, but not so... First thing to do is - file a bug :-) secondly - it would be great to know if this is a regression from OO.o :-) thirdly - it would be wonderful to know what kind of use pattern you're using - if it is load/edit/save/close in a loop - then - there are some known memory leaks that cause serious grief (sadly) and chasing these is a matter of time and effort and extreme slowness using: valgrind --leak-check=full ./soffice.bin /tmp/val-log and filing the log after a set of user interactions. An easier way to prod this is to use: pmap `pidof soffice.bin` | grep writable and watch that as you do various operations; particularly looking for jumps, or any slow increment while you're doing things. Anyhow - would be great to have help with this ! :-) All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Clean code at writer, last patch.
On Fri, 2010-11-19 at 09:21 -0800, Kayo Hamid wrote:
It covers source/core/{except, fields, frmedt, graphic,
objectpositioning, ole, para, sw3io}, sending for review.
Looks basically good to me, removal of commented out code, etc.
Pushed, thanks for this.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Discuss Easy_Hacks: Remove Sheet From File?
Hi Joe, On Sat, 2010-11-20 at 03:53 +, Joe Smith wrote: Is this the place to discuss this proposal? I don't see any discussion on the wiki page itself. Yes - sounds reasonable. I, for one, find Insert Sheet From File a useful shortcut for importing data from a text file, and would hate to see it removed. Okay ? :-) Yes, the same function is available through Insert Sheet, but importing data is a common operation and the two extra clicks are a noticeable bit of hassle. Hmm; Kohei - did you add this one ? Christoph - do you have a thought or two ? :-) If Calc had a clean way to import data from a text file, then I'd love to see this go, but right now, it would be missed. So - can you expand on what such a clean way might look like ? :-) Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git via http ...
On Sat, 2010-11-20 at 00:20 +0100, Miklos Vajna wrote: Hmm, I don't want to question you You should ! ;-) but maybe that's not really necessary. Quite right; configure will 'guess' this from the build/ clone as you say - it is already there. Thanks; removed, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] remove unused SvXMLNumFmtDefaults methods
On Fri, 2010-11-19 at 19:28 +0100, Joachim Trémouroux wrote: Hi Everybody, My first mail on this liste :-) I was grepping for some dead code using 'grep #if 0' and I have found a bunch of unused method in xmloff package. Yup, agreed, unused code alright. Pushed this change now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Clean code at writer [source/filter/{ascii, basflt, html}]
On Fri, 2010-11-19 at 12:09 -0800, Kayo Hamid wrote: Sending for review. It covers source/filter/ dirs. I kept stuff like // 0.01mm = 0.57twip as that's a useful comment IMO and I kept stuff like void SwHTMLParser::EndNumBulListItem( int nToken, sal_Bool bSetColl, - sal_Bool /*bLastPara*/ ) + sal_Bool ) as that's a common enough pattern which I don't have a problem with where the argument is commented out to avoid a compiler warning when someone has to override a method but doesn't need a particular argument in the overridden method, and it helps comment what that other argument is for. Otherwise, happy with the rest of it and pushed it now. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] binfilter/ : remove dead code
On Fri, 2010-11-19 at 19:14 -0500, Kevin Hunter wrote: Hullo List, Removing some dead/non-compiled code in binfilter. Did some drive by comment translation, and minor tab removals. Looks good, thanks for this. Pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] quickstarter causes crash on end of desktop session
On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: *I* think we should try and fix it in LibreOffice 3.3 seeing as we're flooded with these over in RH land. Agreed, if I never see the crash recovery dialog on re-start again, it will be too soon :-) I'm assuming that we should merge obvious crasher fixes until RC1 is out. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] binfilter/ : #if 0 removals
On Sat, 2010-11-20 at 17:23 -0500, Kevin Hunter wrote: Hullo List, Some #if 0 removals in binfilter. Looks good to me. Pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi there, On Mon, 2010-11-22 at 10:50 +0530, surensp...@gmail.com wrote: Here are the few alternatives I can think of : 1) register an event Listener to listen to any change of that temporary file. And update the graphic in the call-back function of that event listener. Remove the event listener after graphic update is done ( Not sure if file based even listeners are available) That's quite a nice approach; so the document should live update as you save in the new editor. Unfortunately I don't believe that we have a good system abstraction for this currently - so, we would probably want a thread / idle handler that sits there polling the file every second (on the second to save power). To be honest, I didn't anticipate these many issues when I chose to work on it, but I am getting to learn a lot about Libreoffice code base this way. This really is a good beginner bug :) And you're a good beginner - persisting with it :-) Thanks ! Great stuff, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Use sal_Unicode or RTL_CONSTASCII_USTRINGPARAM for single unicode character?
Hi Joost, On Sun, 2010-11-21 at 10:59 +0100, Joost Eekhoorn wrote: So if there is SAuthor += OUString::createFromAscii( ); which is the correct replacement: * sAuthor += OUString( RTL_CONSTASCII_USTRINGPARAM(sal_Unicode( ); * sAuthor += OUString( sal_Unicode( ' ' ); * sAuthor += sal_Unicode( ' ' ); I suppose the last of these can at least be made more efficient later if this is found to be a problem - by adding a new overloaded operator for this case. It is also shorter and easier to read IMHO. But efficiency-wise, they are equivalent. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Pushed] calc: some code deletion and comments translation
Hi Pierre, On Sun, 2010-11-21 at 12:13 +0100, Pierre-André Jacquod wrote: have done as well some small comment translations. Thanks - pushed :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Pushed] further removing of dead code
Hi Pierre, On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: here in components some other pieces to delete. Again some small parts in case I was to generous in deleting. Thanks ! :-) I pushed this; I also went back and cleaned up some related comments that were not removed: nfuncs.cxx: /* provisional code should there ever be NPNVariables that we actually want to query from the PluginContext */ - followed by removal of the chunk of code this comment referred to - so I removed the comment too ;-) - xplugin.cxx, securityenvironment + similar issues here. Anyhow - all pushed now; thanks ! :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] C2U 61 time defined and with 2 differed meanings
Hi Joost, On Sun, 2010-11-21 at 16:36 +0100, Joost Eekhoorn wrote: I like short naming, thus I find RTL_CONSTASCII_USTRINGPARAM far too long. Me too - makes the code horribly ugly, and so on. I'd prefer: RTL_USTRP(foo) or somesuch; but Caolan is busy cleaning all this up. However - some vast sed across the codebase for all uses of this would prolly do more harm than good to our ability to merge changes from our side-stream project :-) So - I agree with you. It would be great to add a suitable macro alias, so we can use this in new code though. But the there is C2U. That is defined 61 times and sometimes as: Sure - the problem is that this is not namespaced, and may well collide horribly with third-party code we want to integrate with. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] quickstarter causes crash on end of desktop session
On Mon, Nov 22, 2010 at 11:45:16AM +, Michael Meeks wrote: On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: *I* think we should try and fix it in LibreOffice 3.3 seeing as we're flooded with these over in RH land. Agreed, if I never see the crash recovery dialog on re-start again, it will be too soon :-) I'm assuming that we should merge obvious crasher fixes until RC1 is out. Okay, pushed this to 3.3. Thanks for your comments! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.
Hi,
I have fixed some compilation warnings in binfilter and some unnecessary
comments. Patch is attached for review.
I have two questions:
- /*N*/ . Should I fix them massively? I have currently left them unchanged
to avoid a big cleanup patch.
- Unused parameters in some methods are triggering compilation warnings.
Should I fix them by removing the parameter name ?
Regards,
Joachim.
diff --git a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
index d26ff12..e1d828c 100644
--- a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
+++ b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
@@ -67,8 +67,8 @@ using namespace ::com::sun::star;
/*N*/ ScChartListener::ScChartListener( const String rName, ScDocument* pDocP,
/*N*/ const ScRange rRange ) :
/*N*/ StrData( rName ),
-/*N*/ pDoc( pDocP ),
/*N*/ pUnoData( NULL ),
+/*N*/ pDoc( pDocP ),
/*N*/ bUsed( FALSE ),
/*N*/ bDirty( FALSE ),
/*N*/ bSeriesRangesScheduled( FALSE )
@@ -80,8 +80,8 @@ using namespace ::com::sun::star;
/*N*/ const ScRangeListRef rRangeList ) :
/*N*/ StrData( rName ),
/*N*/ aRangeListRef( rRangeList ),
-/*N*/ pDoc( pDocP ),
/*N*/ pUnoData( NULL ),
+/*N*/ pDoc( pDocP ),
/*N*/ bUsed( FALSE ),
/*N*/ bDirty( FALSE ),
/*N*/ bSeriesRangesScheduled( FALSE )
@@ -90,8 +90,9 @@ using namespace ::com::sun::star;
/*N*/ ScChartListener::ScChartListener( const ScChartListener r ) :
/*N*/ StrData( r ),
-/*N*/ pDoc( r.pDoc ),
+ SfxListener( r ),
/*N*/ pUnoData( NULL ),
+/*N*/ pDoc( r.pDoc ),
/*N*/ bUsed( FALSE ),
/*N*/ bDirty( r.bDirty ),
/*N*/ bSeriesRangesScheduled( r.bSeriesRangesScheduled )
@@ -111,14 +112,13 @@ using namespace ::com::sun::star;
/*N*/ DataObject* ScChartListener::Clone() const
/*N*/ {
-DBG_BF_ASSERT(0, STRIP);return NULL; //STRIP001 return new ScChartListener( *this );
+DBG_BF_ASSERT(0, STRIP);return NULL;
/*N*/ }
/*N*/ void ScChartListener::SetUno(
/*N*/ const uno::Reference chart::XChartDataChangeEventListener rListener,
/*N*/ const uno::Reference chart::XChartData rSource )
/*N*/ {
-/*N*/ // DBG_ASSERT( rListener.is() rSource.is(), Nullpointer bei SetUno );
/*N*/ delete pUnoData;
/*N*/ pUnoData = new ScChartUnoData( rListener, rSource );
/*N*/ }
@@ -236,14 +236,14 @@ using namespace ::com::sun::star;
/*N*/ DataObject* ScChartListenerCollection::Clone() const
/*N*/ {
-DBG_BF_ASSERT(0, STRIP);return NULL;//STRIP001 return new ScChartListenerCollection( *this );
+DBG_BF_ASSERT(0, STRIP);return NULL;
/*N*/ }
/*N*/ void ScChartListenerCollection::ChangeListening( const String rName,
/*N*/ const ScRangeListRef rRangeListRef, BOOL bDirty )
/*N*/ {
-/*?*/ DBG_BF_ASSERT(0, STRIP); //STRIP001 ScChartListener aCLSearcher( rName, pDoc, rRangeListRef );
+/*?*/ DBG_BF_ASSERT(0, STRIP);
/*N*/ }
/*N*/ void ScChartListenerCollection::FreeUnused()
@@ -330,7 +330,7 @@ using namespace ::com::sun::star;
/*N*/ {
/*N*/ for ( USHORT nIndex = 0; nIndex nCount; nIndex++ )
/*N*/ {
-/*?*/ DBG_BF_ASSERT(0, STRIP); //STRIP001 ScChartListener* pCL = (ScChartListener*) pItems[ nIndex ];
+/*?*/ DBG_BF_ASSERT(0, STRIP);
/*N*/ }
/*N*/ }
@@ -340,7 +340,7 @@ using namespace ::com::sun::star;
/*N*/ ScRange aRange( 0, 0, nTab, MAXCOL, MAXROW, nTab );
/*N*/ for ( USHORT nIndex = 0; nIndex nCount; nIndex++ )
/*N*/ {
-/*?*/ DBG_BF_ASSERT(0, STRIP); //STRIP001 ScChartListener* pCL = (ScChartListener*) pItems[ nIndex ];
+/*?*/ DBG_BF_ASSERT(0, STRIP);
/*N*/ }
/*N*/ }
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 8th week development summary
Hi, this time a brief summary of what happened the 8th week on LibreOffice repos and two living branches: bugfixes-master-week-46.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the master branch commit-log-master-week-46.txt lists all relevant commits on the actual source repos in the master branch commit-log-libreoffice-3-3-week-46.txt, bugfixes-libreoffice-3-3-week-46.txt lists the same summary for the libreoffice-3-3 branch. Many thanks to all contributors - you make all the difference! Best Regards, Petr + common: + sb136: #i114155# partially revert fix for i108776 to avoid ABI incompatibility of jvmaccess library [sb] + bootstrap: + Revert fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek] + build: + fix n#654039 empty toolbar [Noel Power] + Remove OOo from the Frech translation of the dekstop files (fdo#31531) [Petr Mladek] + calc: + Make VLOOKUP work with an external reference once again. (fdo#31718) [Kohei Yoshida] + No automatic width adjustment of the dropdown popups. (fdo#31710) [Kohei Yoshida] + extensions: + masterfix OOO330: #i114049# Presentation minimizer 1.0.1 does not install on OOO330m15, #i113990# presenter console does not work with multiple screens [obo] + libs-core: + sb132: #i114155# use en as additional fallback locale after en-US [sb] + sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate existing extensions with bad .xcu content [sb] + libs-gui: + Allow the dropdown list of a combo box to be scrollable. (fdo#31710) [Kohei Yoshida] + Resolves: rhbz#654203# crash after unhandled exception [Caolán McNamara] + writer: + Made the My AutoText string localizable, #i66304# [Andras Timar] + bootstrap: + Revert fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek] + build: + altrnative fix for n#654039 empty toolbar [Noel Power] + remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene Engelhard] + Remove OOo from the Frech translation of the dekstop files (fdo#31531) [Petr Mladek] + filters: + #i112890# LateInitThread thread never deleted [Caolán McNamara] + libs-gui: + Resolves: rhbz#654203# crash after unhandled exception [Caolán McNamara] + writer: + implement w:tabs in w:lvl in numbering.xml (bnc#513567) [Luboš Luňák] + use wp:anchor or wp:inline appropriately (bnc#513579) [Luboš Luňák] + common: + Merge commit 'ooo/OOO330_m15' into libreoffice-3-3 [Jan Holesovsky] + Merge commit 'ooo/OOO330_m16' into libreoffice-3-3 [Rene Engelhard] + sb136: #i114155# partially revert fix for i108776 to avoid ABI incompatibility of jvmaccess library [sb] + Use the new stable libwp* releases as default [Fridrich Štrba] + bootstrap: + Add missing names and descriptions for some language packs [Tor Lillqvist] + CWS-TOOLING: integrate CWS sb136 [obo] + Do not mention date in the downlaod tarball name [Petr Mladek] + fallback to the old install dirname if ooodownloadfilename is not defined [Petr Mladek] + libGLU needs libm so make sure it gets linked [Robert Nagy] + need -lpthread as PTHREAD_LIBS on Linux [Caolán McNamara] + OOO330 [Release Engineering] + Revert fix smoketest with the improved download tarball (fdo#30837) [Petr Mladek] + several openbsd changes to find libs and binaries [Robert Nagy] + Use a generic unxgcc.mk [Robert Nagy] + Use the new stable libwp* releases as default [Fridrich Štrba] + build: + Adapt the unstable libwp* patches to the new stable libwpd/s/g releses [Fridrich Štrba] + Added My AutoText string to po files [Andras Timar] + Added My AutoText string to sdf template and to pot [Andras Timar] + Don't use system libwp* now that we require fresh versions of them [Tor Lillqvist] + enable opengl [Robert Nagy] + Estonian (et) translation update [Mihkel Tõnnov] + Finnish (fi) translation update [Harri Pitkänen] + fix a merge conflict separately [Fridrich Strba] + fix a merge conflict separately [Fridrich Štrba] + fix bin/stat-localizations to work again [Rene Engelhard] + fix n#654039 empty toolbar [Noel Power] + fix version in sdbc-postgresql.diff (now 0.7.6b) [Rene Engelhard] + Help bin/install-artwork find the bin/setup file [Tor Lillqvist] + Hungarian (hu) translation update [Andras Timar] + Install to the correct directory based on PREFIX [Robert Nagy] + Japanese (ja) translation update [Takeshi Abe] + lo-set-version: new helper script to increment version in the sources [Petr Mladek] + Make link-as-needed.diff apply again [Tor Lillqvist] + Make ooo86080.unopkg.bodge.diff apply again [Tor Lillqvist] + Make speed-hash-style.diff apply again [Tor Lillqvist] + Norwegian Bokmål (nb) translation update [Olav Dahlum] + Removal
[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper
On Sun, 2010-11-21 at 21:35 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/vbahelper Julien. Reviewed the vbahelper patch, looks good. Pushed this, thanks for you efforts. btw, when you're sending these patches, you're including the content of previous patches in there as well, rather than just the extra new bit. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.
Hi Joachim, On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote: I have fixed some compilation warnings in binfilter and some unnecessary comments. Patch is attached for review. Hokay - the binfilter is of course un-loved and under-maintained. I have two questions: - /*N*/ . Should I fix them massively? I have currently left them unchanged to avoid a big cleanup patch. I guess this should be done by some large-scale sed at some point centrally. Certainly not a useful patch for the list ;-) - Unused parameters in some methods are triggering compilation warnings. Should I fix them by removing the parameter name ? Sounds reasonable. Really though - the binfilter is not the best place to focus cleanups (though I appreciate it is fugly old code ;-) Most people will not want it (only useful for decade-old binary StarOffice file formats). Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Impress
Please disregard my Friday patch for Impress. Removing the Global High Contrast flag is going to require more work then the simple remove HC icons project is going to allow. We hard code too many UI items (text fonts, background color, border color, ...) which have to be modified when in HC mode. The correct fix for this would be: 1. Find all colors 2. Sort and standardize use. 3. Fix the Color Editor to include all the codes. 4. Replace all the hard coded entries to take values from the color chart. 5. Ship a HC and Normal color theme 6. Bonus points for getting the above to work with all the system color themes... I'm going to revert most of the Impress patch and then resubmit with only the Icon related changes. Joe P. PS: Removing the global flag did find a few odd cases of where Icon related code was hiding so it wasn't a complete loss. PS: In master, the text labels for the HC colors are missing. I'm going to see if I did that and see about getting the labels back in. I may end up asking someone with better GIT skills then me to help find the patch and see about getting it fixed. If I can't find it in GIT, I'll check the 3.3 branch and see if it has the labels and then just copy the code back into master. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] i18npool/ : minor memory leak
Hullo List, Minor memory leak (but a leak nonetheless), found thanks to cppcheck and Jesse's appreciated webpage. Kevin 0001-Fix-a-memory-leak.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?
Michael Meeks 22/11/2010 12:10: Well - as I say; there are problems with lots of scattered licenses. In particular, people can do this to get their personal name / credit into the LICENSES file, which then grows substantially, requires more maintenance, and gives extra credit to those who chose this route etc. (?) :-) Actually, I think that those names are going to end up in many similar places anyway. :) Currently the LibO code base is quite liberal wrt copyright statements and tracing code authors. For example, copyright years and other little (?) details are way out-of-date. Some projects require script like http://0pointer.de/blog/projects/copyright.html to be run after each commit to check that copyright statements have been updated correctly. I think LibO should take a similar approach, also to save itself from inevitable future license FUD. (A little side note: the current layout of the license text makes it very hard to extend the copyright statement after the first year of publication.) So, the question is: are ISC/BSD-licensed contributions acceptable? In the abstract, yes - I have no problem. Concretely though - are you really trying to give people extra freedoms to the code ? or is there some other aim ? My aim is to make my code easy to share. I think the three-line ISC license is, in most cases, the best license to accomplish that. If you want others to be able to get that code under a more liberal licensing; embedding a link to your site in the XSLT where it can be obtained under different terms might be a simpler way - while leaving this copy under the LGPLv3+/MPL. If you're concerned about web-hosting, we could host it for you somewhere permanant perhaps. What about adding a text such as the following after the license header (as suggested by the SFLC)? * This file incorporates work covered by the following copyright and * permission notice: * * Copyright (c) YEARS_LIST, Permissive Contributor1 * Copyright (c) YEARS_LIST, Permissive Contributor2 * * Permission to use, copy, modify, and/or distribute this software * for any purpose with or without fee is hereby granted, provided * that the above copyright notice and this permission notice appear * in all copies. In this way it the whole file would be MIT1.1/GPLv3/LGPLv3 + the original contribution (the first commit) would be ISC licensed. This would spare everybody from setting up hosting facilities that may pose maintenance problems in the future. Anyway, in this very case, for such a little contribution, I do not mind releasing it as MPL1.1/GPLv3/LGPLv3. The purpose of this email is just to create a precedent for a problem that is going to be faced sooner or later. Regards, PS: Isn't there a libreoffice-legal mailing list? -- Gioele Barabucci gio...@svario.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] i18npool/ : minor memory leak
On Mon, 2010-11-22 at 10:30 -0500, Kevin Hunter wrote: Hullo List, Minor memory leak (but a leak nonetheless), found thanks to cppcheck and Jesse's appreciated webpage. Emm, I'm unconvinced its a memory leak. Its given to maLookupTable and in lcl_LookupTableHelper::~lcl_LookupTableHelper its always released, no ? Specifically I think cppcheck is confused by maLookupTable.push_back(pNewItem = new LocaleDataLookupTableItem(aLibTable[i].pLib, module, aLibTable[i].pLocale )); and that LocaleDataLookupTableItem* pNewItem = new LocaleDataLookupTableItem(aLibTable[i].pLib, module, aLibTable[i].pLocale ); maLookupTable.push_back( pNewItem ); is sufficient to un-confuse it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.
2010/11/22 Michael Meeks michael.me...@novell.com: Hi Joachim, On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote: I have fixed some compilation warnings in binfilter and some unnecessary comments. Patch is attached for review. Hokay - the binfilter is of course un-loved and under-maintained. I have two questions: - /*N*/ . Should I fix them massively? I have currently left them unchanged to avoid a big cleanup patch. I guess this should be done by some large-scale sed at some point centrally. Certainly not a useful patch for the list ;-) - Unused parameters in some methods are triggering compilation warnings. Should I fix them by removing the parameter name ? Sounds reasonable. To be consistent, I rather see them commented out i.e foo(int bar) - foo(int /*bar*/) rather than foo(int) Really though - the binfilter is not the best place to focus cleanups (though I appreciate it is fugly old code ;-) Most people will not want it (only useful for decade-old binary StarOffice file formats). as unloved as it maybe. as long as it _IS_ in the build, it has to build and, especially in // build, having the build.log flooded with thousands of warning kind of defeat the point of having warning in the first place. Maybe you could draw the outline of what need to be accomplish to make binfilter a separate stand-alone project ? Norbert Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion
On Sun, 2010-11-21 at 10:35 +0100, David Tardon wrote: On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: Hello, was just tired to try reading code like: #if 0 read a lot here #else cool I will be compiled #endif So I started to track it down systematically. Just hope I was not to much aggressive. So I submit for review / proposal this first pack in little chunk. Will be easier to reject some part... regards ps : really boring to do this #if 1 ps2: never though there are so many places like this #endif I left out a couple of hunks that removed (potentially) useful comments and a couple of others that removed TODO code. Someone with detailed knowledge of calc (hi, Kohei :) should look at these and decide if they can still be useful. What you've skipped look good to me. FYI I use this #if 0 //FIXME: Reason for temporary disablement. .. #else .. #endif #if 0 // TODO: Enable this when (so and so) #else .. #endif style of temporary disablement of code blocks quite frequently. Some get forgotten are safe for removal, while others I'd still like to keep. Especially the one disabled in the externalrefmgr.cxx is going to be re-enabled soon, which you correctly skipped. ;-) Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removed some commented out code
Check attachment and comments please. (so i know can i search more these)
From 382e3715abb3f8ee718192f6974a50b862b2a1f0 Mon Sep 17 00:00:00 2001
From: Timo Heino era...@gmail.com
Date: Mon, 22 Nov 2010 18:32:45 +0200
Subject: [PATCH] Removed commented out code
Removed code that was commented out from some files inside
calc/chart2/source/controller/accessibility/ folder.
Signed-off-by: Timo Heino era...@gmail.com
---
.../controller/accessibility/AccessibleBase.cxx|1 -
.../accessibility/AccessibleChartElement.cxx | 31 --
.../accessibility/AccessibleChartView.cxx |3 -
.../accessibility/ChartElementFactory.cxx | 64
4 files changed, 0 insertions(+), 99 deletions(-)
diff --git a/chart2/source/controller/accessibility/AccessibleBase.cxx b/chart2/source/controller/accessibility/AccessibleBase.cxx
index 2b7eaec..1bc5425 100644
--- a/chart2/source/controller/accessibility/AccessibleBase.cxx
+++ b/chart2/source/controller/accessibility/AccessibleBase.cxx
@@ -779,7 +779,6 @@ awt::Rectangle SAL_CALL AccessibleBase::getBounds()
if( xParent.is() )
aParentLocOnScreen = xParent-getLocationOnScreen();
-// aOffset = aParentLocOnScreen - GetUpperLeftOnScreen()
awt::Point aULOnScreen = GetUpperLeftOnScreen();
awt::Point aOffset( aParentLocOnScreen.X - aULOnScreen.X,
aParentLocOnScreen.Y - aULOnScreen.Y );
diff --git a/chart2/source/controller/accessibility/AccessibleChartElement.cxx b/chart2/source/controller/accessibility/AccessibleChartElement.cxx
index dd00d7e..f0cee9c 100644
--- a/chart2/source/controller/accessibility/AccessibleChartElement.cxx
+++ b/chart2/source/controller/accessibility/AccessibleChartElement.cxx
@@ -130,30 +130,6 @@ void AccessibleChartElement::InitTextEdit()
ASSERT_EXCEPTION( ex );
}
}
-// OSL_ASSERT( m_pTextHelper == 0 );
-
-// // /-- solar
-// SolarMutexGuard aSolarGuard;
-// Window* pWindow( VCLUnoHelper::GetWindow( GetInfo().m_xWindow ));
-// if( pWindow )
-// {
-// // we need ChartController::m_pDrawViewWrapper here
-// SdrView * pView = 0;
-// if( pView )
-// {
-// SdrObject * pTextObj = m_pDrawViewWrapper-getTextEditObject();
-// if( pTextObj )
-// {
-// SvxEditSource * pEditSource = new SvxEditSource( pTextObj, pView, pWindow );
-// m_pTextHelper = new ::accessibility::AccessibleTextHelper(
-// ::std::auto_ptr SvxEditSource ( pEditSource ));
-// if( m_pTextHelper )
-// m_pTextHelper-SetEventSource( this );
-// }
-// }
-// }
-// // \-- solar
-// }
//
//
@@ -169,14 +145,7 @@ Reference XAccessible AccessibleChartElement::ImplGetAccessibleChildById( sal
Reference XAccessible xResult;
if( m_bHasText )
-{
xResult.set( m_xTextHelper-getAccessibleChild( i ));
-// /-- solar
-// SolarMutexGuard aSolarGuard;
-// if( m_pTextHelper )
-// xResult.set( m_pTextHelper-GetChild( i ) );
-// \-- solar
-}
else
xResult.set( AccessibleBase::ImplGetAccessibleChildById( i ));
diff --git a/chart2/source/controller/accessibility/AccessibleChartView.cxx b/chart2/source/controller/accessibility/AccessibleChartView.cxx
index b816204..1b3280f 100644
--- a/chart2/source/controller/accessibility/AccessibleChartView.cxx
+++ b/chart2/source/controller/accessibility/AccessibleChartView.cxx
@@ -93,9 +93,6 @@ awt::Rectangle AccessibleChartView::GetWindowPosSize() const
if( ! xWindow.is())
return awt::Rectangle();
-// this should do, but it doesn't = HACK
-// return xWindow-getPosSize();
-
awt::Rectangle aBBox( xWindow-getPosSize() );
Window* pWindow( VCLUnoHelper::GetWindow( GetInfo().m_xWindow ));
diff --git a/chart2/source/controller/accessibility/ChartElementFactory.cxx b/chart2/source/controller/accessibility/ChartElementFactory.cxx
index c630ff9..3fff9b7 100644
--- a/chart2/source/controller/accessibility/ChartElementFactory.cxx
+++ b/chart2/source/controller/accessibility/ChartElementFactory.cxx
@@ -77,70 +77,6 @@ AccessibleBase* ChartElementFactory::CreateChartElement( const AccessibleElement
}
return 0;
-
-/*
-sal_uInt16 nObjId = rId.GetObjectId();
-switch( nObjId )
-{
-case CHOBJID_LEGEND:
-return new AccLegend( pParent );
-case AccLegendEntry::ObjectId:
-return new AccLegendEntry( pParent, rId.GetIndex1() );
-
-case CHOBJID_TITLE_MAIN:
-return new AccTitle( pParent, Title::MAIN );
-case CHOBJID_TITLE_SUB:
-return new AccTitle( pParent, Title::SUB );
-case CHOBJID_DIAGRAM_TITLE_X_AXIS:
-
Re: [Libreoffice] Discuss quot;Easy_Hacks: Remove Sheet From Filequot;?
Michael Meeks michael.me...@... writes: Hmm; Kohei - did you add this one ? Christoph - do you have a thought or two ? Kohei added this one, if I read the wiki page history right. If Calc had a clean way to import data from a text file, then I'd love to see this go, but right now, it would be missed. So - can you expand on what such a clean way might look like ? Yikes! Don't get me started ;-) The current file handling strategy makes it trivially easy--likely, even--for File Open/Save to lose data and/or work, even for expert users. That includes working with text file data in Calc, and that's why I use/recommend Insert Sheet From File instead of File Open. Ideally, File Open/Save would guarantee that the user's data and work are saved faithfully. For other modes of data access, something like File Import/Export, or Save Copy As, could be used. There are a couple of open issues for this, but nothing beyond some discussion: http://qa.openoffice.org/issues/show_bug.cgi?id=11393 http://qa.openoffice.org/issues/show_bug.cgi?id=74415 Anyway, that's a much, much larger and longer-term issue than what menu items are included. I suppose it's fair to say there's no clear consensus on what the right way would look like either. Joe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Removed some commented out code
On Mon, Nov 22, 2010 at 06:52:47PM +0200, Timo Heino wrote: Check attachment and comments please. (so i know can i search more these) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Impress
On 22/11/10 15:11, Joseph Powers wrote: Please disregard my Friday patch for Impress. Removing the Global High Contrast flag is going to require more work then the simple remove HC icons project is going to allow. We hard code too many UI items (text fonts, background color, border color, ...) which have to be modified when in HC mode. The correct fix for this would be: 1. Find all colors 2. Sort and standardize use. 3. Fix the Color Editor to include all the codes. 4. Replace all the hard coded entries to take values from the color chart. 5. Ship a HC and Normal color theme 6. Bonus points for getting the above to work with all the system color themes... I'm going to revert most of the Impress patch and then resubmit with only the Icon related changes. Joe P. PS: Removing the global flag did find a few odd cases of where Icon related code was hiding so it wasn't a complete loss. PS: In master, the text labels for the HC colors are missing. I'm going to see if I did that and see about getting the labels back in. I may end up asking someone with better GIT skills then me to help find the patch and see about getting it fixed. If I can't find it in GIT, I'll check the 3.3 branch and see if it has the labels and then just copy the code back into master. Is this the patch header? With commit number etc? From e24ca90c227d74300f6b168cbe601404d37ab850 Mon Sep 17 00:00:00 2001 From: Joseph Powers jpower...@cox.net Date: Fri, 19 Nov 2010 19:17:37 -0800 Subject: [PATCH] Removing GetHighContrast() from Impress Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [LO 3.3.0b3] Enable experimental (unstable) features?
On 11/22/2010 01:52 AM, Michael Meeks wrote: Hi there, On Sun, 2010-11-21 at 20:43 -0800, NoOp wrote: No answers for this on the user list, so I'll ask here: .. Tools|Options|LibreOffice|General: - Enable experimental (unstable) features Does anyone know what this enables? Certainly ! :-) It enables in-line formula editing (so you can type inside the formula and navigate around it with cursor keys). It also enables macro recording (a perennially broken feature). HTH, Michael. Ah, cool! Thank you. Gary ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] More cleanup in calc
Removed more commented out code From 508c82de834dc890a2b00702147a55c4603c4bb1 Mon Sep 17 00:00:00 2001 From: Timo Heino era...@gmail.com Date: Mon, 22 Nov 2010 20:14:43 +0200 Subject: [PATCH] More commented out code removed in calc Signed-off-by: Timo Heino era...@gmail.com --- .../controller/chartapiwrapper/AreaWrapper.cxx |1 - .../controller/chartapiwrapper/AxisWrapper.cxx |3 --- .../chartapiwrapper/ChartDocumentWrapper.cxx | 13 - .../chartapiwrapper/DataSeriesPointWrapper.cxx |6 -- .../controller/chartapiwrapper/DiagramWrapper.cxx |6 -- .../controller/chartapiwrapper/DiagramWrapper.hxx |5 - .../controller/chartapiwrapper/GridWrapper.cxx |1 - .../controller/chartapiwrapper/LegendWrapper.cxx |4 .../chartapiwrapper/MinMaxLineWrapper.cxx |3 --- .../chartapiwrapper/MinMaxLineWrapper.hxx |3 --- 10 files changed, 0 insertions(+), 45 deletions(-) diff --git a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx index ba7cbd4..cb92ec6 100644 --- a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx +++ b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx @@ -70,7 +70,6 @@ const Sequence Property lcl_GetPropertySequence() ::std::vector ::com::sun::star::beans::Property aProperties; ::chart::LineProperties::AddPropertiesToVector( aProperties ); ::chart::FillProperties::AddPropertiesToVector( aProperties ); -// ::chart::NamedProperties::AddPropertiesToVector( aProperties ); ::chart::UserDefinedProperties::AddPropertiesToVector( aProperties ); // and sort them for access via bsearch diff --git a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx index 3498f8c..26c8357 100644 --- a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx +++ b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx @@ -337,7 +337,6 @@ const Sequence Property lcl_GetPropertySequence() lcl_AddPropertiesToVector( aProperties ); ::chart::CharacterProperties::AddPropertiesToVector( aProperties ); ::chart::LineProperties::AddPropertiesToVector( aProperties ); -// ::chart::NamedLineProperties::AddPropertiesToVector( aProperties ); ::chart::UserDefinedProperties::AddPropertiesToVector( aProperties ); ::chart::wrapper::WrappedScaleTextProperties::addProperties( aProperties ); @@ -584,8 +583,6 @@ Sequence OUString AxisWrapper::getSupportedServiceNames_Static() aServices[ 0 ] = C2U( com.sun.star.chart.ChartAxis ); aServices[ 1 ] = C2U( com.sun.star.xml.UserDefinedAttributeSupplier ); aServices[ 2 ] = C2U( com.sun.star.style.CharacterProperties ); -// aServices[ 3 ] = C2U( com.sun.star.beans.PropertySet ); -// aServices[ 4 ] = C2U( com.sun.star.drawing.LineProperties ); return aServices; } diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx index e123340..d7d24fc 100644 --- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx +++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx @@ -1498,19 +1498,6 @@ uno::Sequence ::rtl::OUString SAL_CALL ChartDocumentWrapper::getAvailableServ return aResult; -// // shapes -// // uno::Sequence OUString aDrawServices( SvxUnoDrawMSFactory::getAvailableServiceNames() ); -// // const OUString * pArr = aDrawServices.getConstArray(); -// // aServices.insert( aServices.end(), pArr, pArr + aDrawServices.getLength() ); -// } - - -// add-ins - //uno::Sequence OUString aAddIns( GetAddInCollection().GetAddInNames() ); -// pArr = aAddIns.getConstArray(); -// aServices.insert( aServices.end(), pArr, pArr + aAddIns.getLength() ); - -// return ContainerToSequence( aServices ); } // XAggregation diff --git a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx index 7cbdb4b..1b46b17 100644 --- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx +++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx @@ -730,13 +730,7 @@ const std::vector WrappedProperty* DataSeriesPointWrapper::createWrappedPrope WrappedDataCaptionProperties::addWrappedPropertiesForSeries( aWrappedProperties, m_spChart2ModelContact ); WrappedScaleTextProperties::addWrappedProperties( aWrappedProperties, m_spChart2ModelContact ); -//add unnamed fill properties (different inner names here) -// aWrappedProperties.push_back( new WrappedUnnamedProperty( C2U( FillGradient ), C2U( GradientName ) ) ); -// aWrappedProperties.push_back( new WrappedUnnamedProperty( C2U( FillHatch ), C2U( HatchName ) ) ); -//
Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error
Hi, I know...but I had exactly this problem once, and the make clean did not solved the issue. At the end, I did this an evening, and all went well the next day. I would be interested to know if the make clean works for you. Thanks Pierre-André On 11/22/2010 10:48 AM, Michael Meeks wrote: On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: hello, rm -rf * ./download Oh - that is going to waste a -lot- of time ;-) Just remove the build output, not the ( pristine ) git repos. 'make clean' should do that in the top-level. HTH, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] further removing of dead code
Hi, thanks. Left it back, if someone would have needed to know something was there. regards On 11/22/2010 01:14 PM, Michael Meeks wrote: Hi Pierre, On Sun, 2010-11-21 at 15:28 +0100, Pierre-André Jacquod wrote: here in components some other pieces to delete. Again some small parts in case I was to generous in deleting. Thanks ! :-) I pushed this; I also went back and cleaned up some related comments that were not removed: nfuncs.cxx: /* provisional code should there ever be NPNVariables that we actually want to query from the PluginContext */ - followed by removal of the chunk of code this comment referred to - so I removed the comment too ;-) - xplugin.cxx, securityenvironment + similar issues here. Anyhow - all pushed now; thanks ! :-) ATB, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Discuss quot;Easy_Hacks: Remove Sheet From Filequot;?
Kohei Yoshida kyosh...@... writes: ... I'd really really like to see it implemented in a less confusing fashion. The current implementation just re-uses the same dialog from the Insert - Sheet... menu, with some default values filled. But you can still switch back to New Sheet radio button which inserts sheets from the internal document. I am not an UX expert (obviously) but to me that doesn't look like a proper way of interaction. If the user has already indicated that she wants to include a sheet from an external file, why still provide an option to include from the same document? No argument from me that the current state is a confusing hack--it just happens to be a useful hack ;-) Surely, having to go through more clicks to get the same job done will not be any less confusing, right? There is some further nastiness in the current Insert Sheet dialog when used to import text data. Once you've chosen the file and configured the import options, you come back to the Insert Sheet dialog, where it looks like you can perhaps enter a name for the new sheet. However, the New Sheet and From File paths are in fact mutually exclusive and if you select New Sheet to enter a sheet name, you lose the text import you just configured. Oops ;-) There is an RFE open for this: http://qa.openoffice.org/issues/show_bug.cgi?id=77953 I'm sure most people use File Open to get at their text data because that's what they know already; this option presents a safer approach, which deserves to be as easy as possible to use. There should be some data from the Improvement Program on how often this item is used, no? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?
On Mon, 2010-11-22 at 18:45 +, Joe Smith wrote: There should be some data from the Improvement Program on how often this item is used, no? Sure. But such data was not available to us mere mortals (or hackers as we might like to call ourselves). But hopefully Christoph can fill us in on that. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.
Hi,
- Unused parameters in some methods are triggering compilation
warnings. Should I fix them by removing the parameter name ?
Sounds reasonable.
Really though - the binfilter is not the best place to focus cleanups
(though I appreciate it is fugly old code ;-) Most people will not want
it (only useful for decade-old binary StarOffice file formats).
Okay, but at compile time, there is really a flow of warning. So I
wanted also to work a bit on it. That's just cleaning, not really
improving.
But when I see:
clone/filters/binfilter/bf_sc/source/core/tool/sc_token.cxx:1573:28:
warning: comparison is always false due to limited range of data type
and the source code is (it starts form line 1573..
if( n MAXSTRLEN-1 )
/*N*/ {
/*?*/ DBG_ERRORFILE( bad string array boundary );
/*?*/ USHORT nDiff = n - (MAXSTRLEN-1);
/*?*/ n = MAXSTRLEN-1;
/*?*/ rStream.Read( c, n );
/*?*/ rStream.SeekRel( nDiff );
/*N*/ }
/*N*/ else
/*N*/ rStream.Read( c, n );
/*N*/ cStr[ n ] = 0;
would as cleaning be acceptable to change the code to:
/*N*/ rStream.Read( c, n );
/*N*/ cStr[ n ] = 0;
??? I wonder...
If yes, a lot of code can be removed (between 40 and 60 comparisons are
generating this warning). So I would prefer not starting and beeing told
not to touch it afterward.
Thanks
Pierre-André
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.
Hi Pierre, On Mon, 2010-11-22 at 21:06 +0100, Pierre-André Jacquod wrote: Okay, but at compile time, there is really a flow of warning. So I wanted also to work a bit on it. That's just cleaning, not really improving. Sure sure :-) fair enough. clone/filters/binfilter/bf_sc/source/core/tool/sc_token.cxx:1573:28: warning: comparison is always false due to limited range of data type Right - so we can chop that code out with prejudice as you say :-) would as cleaning be acceptable to change the code to: /*N*/ rStream.Read( c, n ); /*N*/ cStr[ n ] = 0; Of course ! no point in keeping dead code around. If yes, a lot of code can be removed (between 40 and 60 comparisons are generating this warning). So I would prefer not starting and beeing told not to touch it afterward. Go for it :-) of course, this is the sort of patch that scares patch reviewers, so I would pair up the compile messages of this form, with the diff (if you can) ? Really, of course - I'd love to have someone working on eg. http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons Which should be mind-numblingly simple and yet yield a real image-size (and hence performance) win :-) Any chance of a small detour on the way ? :-) Thanks anyhow, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error
I did make clean make The make clean removed the the complete build/libreoffice-3.2.99.2 directory. It is now building 2 hours and I will see tomorrow-morning what the result is. Tomorrow-evening (after my work and helping my son with mail-delivering) I will report if it works. Joost 2010/11/22 Pierre-André Jacquod pjacq...@alumni.ethz.ch Hi, I know...but I had exactly this problem once, and the make clean did not solved the issue. At the end, I did this an evening, and all went well the next day. I would be interested to know if the make clean works for you. Thanks Pierre-André On 11/22/2010 10:48 AM, Michael Meeks wrote: On Mon, 2010-11-22 at 07:57 +0100, Pierre-André Jacquod wrote: hello, rm -rf * ./download Oh - that is going to waste a -lot- of time ;-) Just remove the build output, not the ( pristine ) git repos. 'make clean' should do that in the top-level. HTH, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx
Hello, Perhaps a simple table in the wiki to assign oneself a task which is available and its planned deadline could be useful. Julien. Le 22/11/2010 21:59, Joost Eekhoorn a écrit : Hi, I did send my patch to the list and Julien did send his patch just after that. It was pushed this morning by David. It surprises me that it does not happen oftener, because I see no coordination between the people working on RTL_CONSTASCII_USTRINGPARAM. Joost 2010/11/22 Michael Meeks michael.me...@novell.com mailto:michael.me...@novell.com Hi there, On Sun, 2010-11-21 at 17:20 +0100, Julien Nabet wrote: Here's a patch for libs-core/svx It seems someone merged it without replying 'Pushed' ;-) Thanks, Michael. -- michael.me...@novell.com mailto:michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org mailto:LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OSL_DEBUG_LEVEL question
On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna vmik...@frugalware.org wrote: Does anyone have an idea when (and why) this changed, and what's the new way of getting the OSL_TRACE() output? Oh, I guess this is related to David's recent 47d0946 in bootstrap.git. The attached patch fixes the problem for me - David, OK to push? Thanks. From ada7e2409a039284e0f9f5c08da4b97e5bee0012 Mon Sep 17 00:00:00 2001 From: Miklos Vajna vmik...@frugalware.org Date: Mon, 22 Nov 2010 23:22:40 +0100 Subject: [PATCH] Enable OSL_TRACE() with OSL_DEBUG_LEVEl 0 Previously it was enabled with OSL_DEBUG_LEVEL 1 only, while other OSL macros like OSL_ENSURE were already enabled with OSL_DEBUG_LEVEL 0. --- sal/inc/osl/diagnose.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sal/inc/osl/diagnose.h b/sal/inc/osl/diagnose.h index 59f921c..60f818b 100644 --- a/sal/inc/osl/diagnose.h +++ b/sal/inc/osl/diagnose.h @@ -154,7 +154,7 @@ pfunc_osl_printDetailedDebugMessage SAL_CALL osl_setDetailedDebugMessageFunc( pf #endif /* OSL_DEBUG_LEVEL */ -#if OSL_DEBUG_LEVEL 1 +#if OSL_DEBUG_LEVEL 0 #define _OSL_TRACE _OSL_GLOBAL osl_trace -- 1.7.3.2 pgpUaZkYpl369.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?
On Mon, 2010-11-22 at 14:27 -0500, Kohei Yoshida wrote: On Mon, 2010-11-22 at 18:45 +, Joe Smith wrote: There should be some data from the Improvement Program on how often this item is used, no? Sure. But such data was not available to us mere mortals (or hackers as we might like to call ourselves). But hopefully Christoph can fill us in on that. Just thinking out load. LibreOffice has a quick insert sheet button in the sheet tab. Maybe exploring that area to add a nice quick way to add sheets from file would be a better approach than sticking with the menus... Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] HC Cleanup
While creating the HC Icon set, could you look into the following? default_images/svx/source/svdraw cropmarkers.png - 2d icons for cropping cropmarkers2.png- 3d icons for cropping cropmarkersACC.png - HC icons for cropping markers.png - 2d icons for markers markers2.png- 3d icons for markers markersACC.png - HC icons for markers The ACC versions will need to be copied in the 2d 3d version in the HC set. I've removed the code referring to the ACC versions. -- Just to confuse people, I changed the Auto-Detect HC mode option to change the default theme to the High Contrast one. Yes, I know that when changing the OS back to a normal theme, I don't change LibO back to the old theme (we currently don't have a place to store the option). I changed the Windows Only code to match this behavior; however, I don't have access to a Windows build system so the change is 1) un-tested 2) theoretically correct. Any testing would be great. -- It should now be save to remove all the HC versions of the icons from all sets and start packaging the HC set as it's own theme. -- Joe P. PS: I believe I've removed all the code dealing with loading HC version of Icons. If no-one objects, I'll remove the task from the Easy-Hacks page. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Location of SfxPoolItem.Type() method
On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: On a semi-related note, I'm doing a lot of stepping through the search and replace code trying to track the problem down. Because LO seems to be compiled using -O2 and -O3, there's a lot of optimization which means the way the code gets stepped through is often bizarre, and the values of useful variables have been optimized out by the compiler. Is there a simple option for building the LO project using a lower optimization level? I can't seem to find one... You can either do nopt=true make or reconfigure with --enable-debug (debug build only enables assertions by default since yesterday, so the amount of output is quite manageable). D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OSL_DEBUG_LEVEL question
On Mon, Nov 22, 2010 at 11:33:42PM +0100, Miklos Vajna wrote: On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna vmik...@frugalware.org wrote: Does anyone have an idea when (and why) this changed, and what's the new way of getting the OSL_TRACE() output? Oh, I guess this is related to David's recent 47d0946 in bootstrap.git. The attached patch fixes the problem for me - David, OK to push? Thanks. Please, don't! The whole purpose of the change was to get more manageable debugging output by default, i.e., only assertions. You can see my reasoning in message I sent to the ML last week: http://lists.freedesktop.org/archives/libreoffice/2010-November/002894.html (for some reason I only see a half of the message there...). The new way to do a full debug build in a module is build -- debug=t dbglevel=2 or, if you've configured with --enable-debug, build -- dbglevel=2 D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments
On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote: Hi, Easy Hacks on base, some of indentions are left unchanged for clarity. Thanks! I pushed it except one hunk containing the magical word TODO :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] YILIN ŞOK KAMPANYASI !
KARTASİS Araç Takip Sistemleri Listeden Çıkmak için b...@listedencikar.com adresine quot;Çıkarquot; başlıklı Boş bir e-posta gönderiniz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo
On Mon, Nov 22, 2010 at 8:48 PM, Kohei Yoshida kyosh...@novell.com wrote: On Sat, 2010-11-20 at 18:40 -0500, Norbert Thiebaud wrote: On Thu, Nov 18, 2010 at 10:18 PM, Jan Holesovsky ke...@suse.cz wrote: Hi, In case you are interested to try to build without the 'build' repo (the rawbuild/ way), you can try to get the feature/rip-build-repo branch which I hope is going to become the 'official' way of building soon ;-) btw, I got it working on MacOS I built it on Windows too. The only issue I've encountered is that the initial autogen.sh run checks for presence of certain dll files in the external module, and it fails because the external module was not there. The solution was to run g clone first, then run autogen.sh. Argh, that is annoying. I managed to hide the git clone and the ./download step into the make but you can't make before autogen... chicken and egg thing... Any possibility to postpone these check or only do them if the autogen option says --with-system for these dll (i'm guessing here), with the understanding that if you are using the 'built-in' ones they will pulled in ? -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [stephan.bergm...@oracle.com: Re: [releases] Minutes for release status meeting from 2010-11-15]
Hi, :-) On Tue, Nov 16, 2010 at 21:03, Rene Engelhard r...@debian.org wrote: The effect is that an office installation based on OOo before 3.3 cannot share a URE installation with an office installation based on OOo 3.3 or later. Sharing URE installations is only relevant on Linux and Solaris, not on Windows and Mac OS X, and is probably more of theoretical than practical concern. Do you happen to have any more information about this? Could you maybe explain what the implications are, please? Thanks if so. :-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
