[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)
regards
>From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Mon, 29 Nov 2010 08:20:37 +0100
Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)
---
.../source/core/unocore/sw_SwXTextDefaults.cxx |8 ++--
binfilter/bf_sw/source/core/unocore/sw_unobkm.cxx | 17 ---
binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx |9 ++-
.../bf_sw/source/core/unocore/sw_unofield.cxx | 24 ++---
.../bf_sw/source/core/unocore/sw_unoframe.cxx | 16 +++---
binfilter/bf_sw/source/core/unocore/sw_unoftn.cxx | 16 +++---
binfilter/bf_sw/source/core/unocore/sw_unoidx.cxx | 32 +---
binfilter/bf_sw/source/core/unocore/sw_unoobj.cxx | 16 +--
.../bf_sw/source/core/unocore/sw_unorefmk.cxx | 12 ++--
binfilter/bf_sw/source/core/unocore/sw_unosect.cxx | 22 +
binfilter/bf_sw/source/core/unocore/sw_unosett.cxx | 50 +++-
11 files changed, 133 insertions(+), 89 deletions(-)
diff --git a/binfilter/bf_sw/source/core/unocore/sw_SwXTextDefaults.cxx b/binfilter/bf_sw/source/core/unocore/sw_SwXTextDefaults.cxx
index 14e8028..c1acdb5 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_SwXTextDefaults.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_SwXTextDefaults.cxx
@@ -166,28 +166,28 @@ Any SAL_CALL SwXTextDefaults::getPropertyValue( const OUString& rPropertyName )
}
-void SAL_CALL SwXTextDefaults::addPropertyChangeListener( const OUString& rPropertyName, const Reference< XPropertyChangeListener >& xListener )
+void SAL_CALL SwXTextDefaults::addPropertyChangeListener( const OUString& /*rPropertyName*/, const Reference< XPropertyChangeListener >& /*xListener*/ )
throw(UnknownPropertyException, WrappedTargetException, RuntimeException)
{
DBG_WARNING ( "not implemented" );
}
-void SAL_CALL SwXTextDefaults::removePropertyChangeListener( const OUString& rPropertyName, const Reference< XPropertyChangeListener >& aListener )
+void SAL_CALL SwXTextDefaults::removePropertyChangeListener( const OUString& /*rPropertyName*/, const Reference< XPropertyChangeListener >& /*aListener*/ )
throw(UnknownPropertyException, WrappedTargetException, RuntimeException)
{
DBG_WARNING ( "not implemented" );
}
-void SAL_CALL SwXTextDefaults::addVetoableChangeListener( const OUString& rPropertyName, const Reference< XVetoableChangeListener >& aListener )
+void SAL_CALL SwXTextDefaults::addVetoableChangeListener( const OUString& /*rPropertyName*/, const Reference< XVetoableChangeListener >& /*aListener*/ )
throw(UnknownPropertyException, WrappedTargetException, RuntimeException)
{
DBG_WARNING ( "not implemented" );
}
-void SAL_CALL SwXTextDefaults::removeVetoableChangeListener( const OUString& rPropertyName, const Reference< XVetoableChangeListener >& aListener )
+void SAL_CALL SwXTextDefaults::removeVetoableChangeListener( const OUString& /*rPropertyName*/, const Reference< XVetoableChangeListener >& /*aListener*/ )
throw(UnknownPropertyException, WrappedTargetException, RuntimeException)
{
DBG_WARNING ( "not implemented" );
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unobkm.cxx b/binfilter/bf_sw/source/core/unocore/sw_unobkm.cxx
index 98d174d..fead095 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unobkm.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unobkm.cxx
@@ -275,7 +275,7 @@ uno::Reference< beans::XPropertySetInfo > SwXBookmark::getPropertySetInfo(void)
return aRef;
}
-void SwXBookmark::setPropertyValue(const OUString& PropertyName, const uno::Any& aValue)
+void SwXBookmark::setPropertyValue(const OUString& PropertyName, const uno::Any& /*aValue*/)
throw( beans::UnknownPropertyException, beans::PropertyVetoException,
lang::IllegalArgumentException, lang::WrappedTargetException, uno::RuntimeException )
{
@@ -294,25 +294,26 @@ uno::Any SwXBookmark::getPropertyValue(const OUString& rPropertyName) throw( bea
return aRet;
}
-void SwXBookmark::addPropertyChangeListener(const OUString& PropertyName,
-const uno::Reference< beans::XPropertyChangeListener > & aListener)
+void SwXBookmark::addPropertyChangeListener(const OUString& /*PropertyName*/,
+const uno::Reference< beans::XPropertyChangeListener > & /*aListener*/)
throw( beans::UnknownPropertyException, lang::WrappedTargetException, uno::RuntimeException )
{
}
-void SwXBookmark::removePropertyChangeListener(const OUString& PropertyName,
-const uno::Reference< beans::XPropertyChangeListener > & aListener)
+void SwXBookmark::removePropertyChangeListener(const OUString& /*PropertyName*/,
+const uno::Reference< beans::XPropertyChangeListener > & /*aListener*/)
throw( beans::UnknownPropertyException, lang::WrappedTargetException, uno::RuntimeException )
{
}
-void SwXBookmark::addVetoableChangeListener(const OUString& PropertyName,
-const uno::Reference< beans::X
[Libreoffice] [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)
regards
>From 09642903881c193ff01f2801461dcddeae0931ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Mon, 29 Nov 2010 22:13:22 +0100
Subject: [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)
---
binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx | 12 ++-
binfilter/bf_sw/source/core/unocore/sw_unomap.cxx | 11 +--
binfilter/bf_sw/source/core/unocore/sw_unoobj2.cxx |8 +-
.../bf_sw/source/core/unocore/sw_unoparagraph.cxx | 27 ---
binfilter/bf_sw/source/core/unocore/sw_unoport.cxx | 32 ---
.../bf_sw/source/core/unocore/sw_unoredline.cxx| 12 ++--
.../bf_sw/source/core/unocore/sw_unoredlines.cxx |4 +-
binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx | 16 +++-
.../bf_sw/source/core/unocore/sw_unostyle.cxx | 26 +++---
binfilter/bf_sw/source/core/unocore/sw_unotbl.cxx | 90 ++--
binfilter/bf_sw/source/core/unocore/sw_unotext.cxx | 18 ++--
11 files changed, 155 insertions(+), 101 deletions(-)
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx b/binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx
index 5533ee5..37cb25e 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unodraw.cxx
@@ -1285,27 +1285,29 @@ Any SwXShape::getPropertyDefault( const OUString& rPropertyName )
return aRet;
}
-void SwXShape::addPropertyChangeListener(const OUString& /*PropertyName*/, const Reference< XPropertyChangeListener > & /*aListener*/)
+void SwXShape::addPropertyChangeListener(const OUString& /*PropertyName*/,
+const Reference< XPropertyChangeListener > & /*aListener*/)
throw( UnknownPropertyException, WrappedTargetException, RuntimeException )
{
DBG_WARNING("not implemented");
}
void SwXShape::removePropertyChangeListener(
-const OUString& PropertyName,
-const Reference< XPropertyChangeListener > & aListener)
+const OUString& /*PropertyName*/,const Reference< XPropertyChangeListener > & /*aListener*/)
throw( UnknownPropertyException, WrappedTargetException, RuntimeException )
{
DBG_WARNING("not implemented");
}
-void SwXShape::addVetoableChangeListener(const OUString& /*PropertyName*/, const Reference< XVetoableChangeListener > & /*aListener*/)
+void SwXShape::addVetoableChangeListener(
+const OUString& /*PropertyName*/, const Reference< XVetoableChangeListener > & /*aListener*/)
throw( UnknownPropertyException, WrappedTargetException, RuntimeException )
{
DBG_WARNING("not implemented");
}
-void SwXShape::removeVetoableChangeListener(const OUString& /*PropertyName*/, const Reference< XVetoableChangeListener > & /*aListener*/)
+void SwXShape::removeVetoableChangeListener(const OUString& /*PropertyName*/,
+const Reference< XVetoableChangeListener > & /*aListener*/)
throw( UnknownPropertyException, WrappedTargetException, RuntimeException )
{
DBG_WARNING("not implemented");
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unomap.cxx b/binfilter/bf_sw/source/core/unocore/sw_unomap.cxx
index 0d0fd71..1a46a94 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unomap.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unomap.cxx
@@ -2321,17 +2321,10 @@ const SfxItemPropertyMap* SwUnoPropertyMapProvider::GetPropertyMap(sal_uInt16 nP
}
return aMapArr[nPropertyId];
}
-/* -04.07.98 11:42---
- *
- * --*/
-sal_Bool SwItemPropertySet::FillItem(SfxItemSet& rSet, sal_uInt16 nWhich, sal_Bool bGetProperty) const
+
+sal_Bool SwItemPropertySet::FillItem(SfxItemSet& /*rSet*/, sal_uInt16 /*nWhich*/, sal_Bool /*bGetProperty*/) const
{
sal_Bool bRet = sal_False;
-/* if(nWhich == SID_ATTR_PAGE_PAPERBIN)
-{
-rSet.Put(SvxPaperBinItem(SID_ATTR_PAGE_PAPERBIN, 0));
-bRet = sal_True;
-}*/
return bRet;
}
}
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unoobj2.cxx b/binfilter/bf_sw/source/core/unocore/sw_unoobj2.cxx
index 81ba642..4a88ebc 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unoobj2.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unoobj2.cxx
@@ -1934,7 +1934,7 @@ Any SAL_CALL SwXTextRange::getPropertyValue( const OUString& rPropertyName )
---*/
void SAL_CALL SwXTextRange::addPropertyChangeListener(
-const OUString& aPropertyName, const Reference< XPropertyChangeListener >& xListener )
+const OUString& /*aPropertyName*/, const Reference< XPropertyChangeListener >& /*xListener*/ )
throw(UnknownPropertyException, WrappedTargetException, RuntimeException)
{
DBG_WARNING("not implemented");
@@ -1943,7 +1943,7 @@ void SAL_CALL SwXTextRange::addPropertyChangeListener(
---*/
void SAL_CALL SwXTextRange::removePropertyChangeListener(
-const OUString& aPropertyName, co
[Libreoffice] [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc
regards
>From 94ae830669bfc1df7b4235c45d0a6a72def30be2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Sun, 28 Nov 2010 21:09:30 +0100
Subject: [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc
---
.../bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_doc.cxx |8 ++--
binfilter/bf_sw/source/core/doc/sw_docbm.cxx |6 +-
binfilter/bf_sw/source/core/doc/sw_docchart.cxx|2 +-
binfilter/bf_sw/source/core/doc/sw_docdde.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_docdesc.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_docdraw.cxx | 18 ---
binfilter/bf_sw/source/core/doc/sw_docedt.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_docfld.cxx |4 +-
binfilter/bf_sw/source/core/doc/sw_docfly.cxx |4 +-
binfilter/bf_sw/source/core/doc/sw_docfmt.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_docftn.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_doclay.cxx | 14 +++---
binfilter/bf_sw/source/core/doc/sw_docnum.cxx | 10 ++--
binfilter/bf_sw/source/core/doc/sw_docredln.cxx| 49
binfilter/bf_sw/source/core/doc/sw_docsort.cxx |4 +-
binfilter/bf_sw/source/core/doc/sw_doctxm.cxx |8 ++--
binfilter/bf_sw/source/core/doc/sw_fmtcol.cxx |4 +-
binfilter/bf_sw/source/core/doc/sw_notxtfrm.cxx|8 ++--
binfilter/bf_sw/source/core/doc/sw_number.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_poolfmt.cxx |2 +-
binfilter/bf_sw/source/core/doc/sw_swtable.cxx |6 +-
binfilter/bf_sw/source/core/doc/sw_tblrwcl.cxx |4 +-
binfilter/bf_sw/source/core/doc/sw_visiturl.cxx|2 +-
24 files changed, 70 insertions(+), 97 deletions(-)
diff --git a/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx b/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx
index 159c82a..9a4b51c 100644
--- a/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx
+++ b/binfilter/bf_sw/source/core/doc/sw_SwStyleNameMapper.cxx
@@ -709,7 +709,7 @@ const struct SwTableEntry NumRuleProgNameTable [] =
/*N*/ }
// Get the programmatic Name from the pool ID
-/*N*/ void SwStyleNameMapper::FillProgName ( sal_uInt16 nId, String& rFillName )
+/*N*/ void SwStyleNameMapper::FillProgName ( sal_uInt16 /*nId*/, String& /*rFillName*/ )
/*N*/ {DBG_BF_ASSERT(0, "STRIP"); //STRIP001
/*N*/ }
// Get the programmatic Name from the pool ID
diff --git a/binfilter/bf_sw/source/core/doc/sw_doc.cxx b/binfilter/bf_sw/source/core/doc/sw_doc.cxx
index 3c5811c..c5bfcc0 100644
--- a/binfilter/bf_sw/source/core/doc/sw_doc.cxx
+++ b/binfilter/bf_sw/source/core/doc/sw_doc.cxx
@@ -487,7 +487,7 @@ void SwDoc::SetGlobalMacro( USHORT nEvent, const SvxMacro& rMacro )
//JP 24.06.96: Ist der ArrayPointer 0 dann returne nur, ob im Doc. eine
//RefMark gesetzt ist
// OS 25.06.96: ab jetzt wird immer die Anzahl der Referenzen returnt
-/*N*/ USHORT SwDoc::GetRefMarks( SvStringsDtor* pNames ) const
+/*N*/ USHORT SwDoc::GetRefMarks( SvStringsDtor* /*pNames*/ ) const
/*N*/ {
/*N*/ DBG_BF_ASSERT(0, "STRIP"); return 0;//STRIP001 const SfxPoolItem* pItem;
/*N*/ }
@@ -524,9 +524,9 @@ void SwDoc::SetGlobalMacro( USHORT nEvent, const SvxMacro& rMacro )
/*N*/ }
-/*N*/ void SwDoc::ReRead( SwPaM& rPam, const String& rGrfName,
-/*N*/ const String& rFltName, const Graphic* pGraphic,
-/*N*/ const BfGraphicObject* pGrafObj )
+/*N*/ void SwDoc::ReRead( SwPaM& /*rPam*/, const String& /*rGrfName*/,
+/*N*/ const String& /*rFltName*/, const Graphic* /*pGraphic*/,
+/*N*/ const BfGraphicObject* /*pGrafObj*/ )
/*N*/ {
DBG_BF_ASSERT(0, "STRIP"); //STRIP001 SwGrfNode *pGrfNd;
/*N*/ }
diff --git a/binfilter/bf_sw/source/core/doc/sw_docbm.cxx b/binfilter/bf_sw/source/core/doc/sw_docbm.cxx
index ca32fb5..f0ce7bb 100644
--- a/binfilter/bf_sw/source/core/doc/sw_docbm.cxx
+++ b/binfilter/bf_sw/source/core/doc/sw_docbm.cxx
@@ -181,7 +181,7 @@ namespace binfilter {
// erzeugt einen eindeutigen Namen. Der Name selbst muss vorgegeben
// werden, es wird dann bei gleichen Namen nur durchnumeriert.
-/*N*/ void SwDoc::MakeUniqueBookmarkName( String& rNm )
+/*N*/ void SwDoc::MakeUniqueBookmarkName( String& /*rNm*/ )
/*N*/ {
/*?*/ DBG_BF_ASSERT(0, "STRIP"); //STRIP001 ASSERT( rNm.Len(), "es sollte ein Name vorgegeben werden!" );
/*N*/ }
@@ -189,8 +189,8 @@ namespace binfilter {
/* */
/*N*/ SaveBookmark::SaveBookmark( int eType, const SwBookmark& rBkmk,
-/*N*/ const SwNodeIndex & rMvPos,
-/*N*/ const SwIndex* pIdx )
+/*N*/ const SwNodeIndex& /*rMvPos*/,
+/*N*/ const SwIndex* /*pIdx*/ )
/*N*/ : aName( rBkmk.GetName() ), aShortName( rBkmk.GetShortName() ),
/*N*/ aCode( rBkmk.GetKeyCode() ), eBkmkType( (SaveBookmarkType)eType ),
/*N*/ eOrigBkmType(rBkmk.GetType())
diff --git a/binfilter/bf_sw/source/core/doc/sw_docchart.cxx b/binfilter/bf_sw/sourc
[Libreoffice] [PATCH 2/5] trivial warning fixes in binfilter
regards
>From 29737dab0202b18c1326841e449e1640b9bd5561 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Sun, 28 Nov 2010 19:40:04 +0100
Subject: [PATCH 2/5] trivial warning fixes in binfilter
---
binfilter/bf_sw/source/core/attr/sw_calbck.cxx |2 +-
binfilter/bf_sw/source/core/docnode/sw_ndsect.cxx |2 +-
binfilter/bf_sw/source/core/docnode/sw_ndtbl.cxx |6 ++--
binfilter/bf_sw/source/core/docnode/sw_nodes.cxx |2 +-
binfilter/bf_sw/source/core/docnode/sw_section.cxx |7 +---
binfilter/bf_sw/source/core/graphic/sw_grfatr.cxx | 34 ++--
binfilter/bf_sw/source/core/graphic/sw_ndgrf.cxx |2 +-
binfilter/bf_sw/source/core/view/sw_viewimp.cxx| 14
binfilter/bf_sw/source/ui/app/sw_docsh2.cxx|6 ++--
binfilter/bf_sw/source/ui/app/sw_docstyle.cxx |8 ++--
binfilter/bf_sw/source/ui/app/sw_swmodul1.cxx |4 +-
binfilter/inc/bf_sw/fmthbsh.hxx|6 ++--
12 files changed, 45 insertions(+), 48 deletions(-)
diff --git a/binfilter/bf_sw/source/core/attr/sw_calbck.cxx b/binfilter/bf_sw/source/core/attr/sw_calbck.cxx
index 3c0377c..a948fab 100644
--- a/binfilter/bf_sw/source/core/attr/sw_calbck.cxx
+++ b/binfilter/bf_sw/source/core/attr/sw_calbck.cxx
@@ -72,7 +72,7 @@ static SwClientIter* pClientIters = 0;
*/
-/*N*/ void SwClient::Modify( SfxPoolItem *pOld, SfxPoolItem *pNew )
+/*N*/ void SwClient::Modify( SfxPoolItem *pOld, SfxPoolItem * /*pNew*/ )
/*N*/ {
/*N*/ if( (!pOld || pOld->Which() != RES_OBJECTDYING) )
/*N*/ return;
diff --git a/binfilter/bf_sw/source/core/docnode/sw_ndsect.cxx b/binfilter/bf_sw/source/core/docnode/sw_ndsect.cxx
index 2dcdeb6..9612c0d 100644
--- a/binfilter/bf_sw/source/core/docnode/sw_ndsect.cxx
+++ b/binfilter/bf_sw/source/core/docnode/sw_ndsect.cxx
@@ -58,7 +58,7 @@
#include
namespace binfilter {
-/*N*/ int lcl_IsInSameTblBox( SwNodes& rNds, const SwNode& rNd,
+/*N*/ int lcl_IsInSameTblBox( SwNodes& /*rNds*/, const SwNode& rNd,
/*N*/ const SwNodeIndex& rIdx2 )
/*N*/ {
/*N*/ const SwTableNode* pTblNd = rNd.FindTableNode();
diff --git a/binfilter/bf_sw/source/core/docnode/sw_ndtbl.cxx b/binfilter/bf_sw/source/core/docnode/sw_ndtbl.cxx
index a4a40b5..62293df 100644
--- a/binfilter/bf_sw/source/core/docnode/sw_ndtbl.cxx
+++ b/binfilter/bf_sw/source/core/docnode/sw_ndtbl.cxx
@@ -533,8 +533,8 @@ static bool lcl_IsItemSet(const SwCntntNode & rNode, USHORT which)
// -- teilen / zusammenfassen von Boxen in der Tabelle
-/*N*/ BOOL SwDoc::SplitTbl( const SwSelBoxes& rBoxes, sal_Bool bVert, USHORT nCnt,
-/*N*/ sal_Bool bSameHeight )
+/*N*/ BOOL SwDoc::SplitTbl( const SwSelBoxes& /*rBoxes*/, sal_Bool /*bVert*/, USHORT /*nCnt*/,
+/*N*/ sal_Bool /*bSameHeight*/ )
/*N*/ {DBG_BF_ASSERT(0, "STRIP"); return FALSE;//STRIP001
/*N*/ }
@@ -625,7 +625,7 @@ static bool lcl_IsItemSet(const SwCntntNode & rNode, USHORT which)
/*N*/ }
-/*N*/ void SwTableNode::SetNewTable( SwTable* pNewTable, BOOL bNewFrames )
+/*N*/ void SwTableNode::SetNewTable( SwTable* /*pNewTable*/, BOOL /*bNewFrames*/ )
/*N*/ {
DBG_BF_ASSERT(0, "STRIP"); //STRIP001 //STRIP001 DelFrms();
/*N*/ }
diff --git a/binfilter/bf_sw/source/core/docnode/sw_nodes.cxx b/binfilter/bf_sw/source/core/docnode/sw_nodes.cxx
index 3a28d68..28ba75f 100644
--- a/binfilter/bf_sw/source/core/docnode/sw_nodes.cxx
+++ b/binfilter/bf_sw/source/core/docnode/sw_nodes.cxx
@@ -560,7 +560,7 @@ namespace binfilter {
|*
***/
-/*N*/ void SwNodes::GoStartOfSection(SwNodeIndex *pIdx) const
+/*N*/ void SwNodes::GoStartOfSection(SwNodeIndex* /*pIdx*/) const
/*N*/ {DBG_BF_ASSERT(0, "STRIP"); //STRIP001
/*N*/ }
diff --git a/binfilter/bf_sw/source/core/docnode/sw_section.cxx b/binfilter/bf_sw/source/core/docnode/sw_section.cxx
index 1108fef..30052bf 100644
--- a/binfilter/bf_sw/source/core/docnode/sw_section.cxx
+++ b/binfilter/bf_sw/source/core/docnode/sw_section.cxx
@@ -659,9 +659,7 @@ void SwSectionFmt::MakeFrms()
// alle Sections, die von dieser abgeleitet sind
-/*N*/ USHORT SwSectionFmt::GetChildSections( SwSections& rArr,
-/*N*/ SectionSort eSort,
-/*N*/ int bAllSections ) const
+/*N*/ USHORT SwSectionFmt::GetChildSections( SwSections& rArr,SectionSort /*eSort*/,int bAllSections ) const
/*N*/ {
/*N*/ rArr.Remove( 0, rArr.Count() );
/*N*/
@@ -1134,8 +1132,7 @@ void SwSectionFmt::MakeFrms()
-/*N*/ BOOL SwIntrnlSectRefLink::IsInRange( ULONG nSttNd, ULONG nEndNd,
-/*N*/ xub_StrLen nStt, xub_StrLen nEnd ) const
+/*N*/ BOOL SwIntrnlSectRefLink::IsInRange( ULONG nSttNd, ULONG nEndNd, xub_StrLen nStt, xub_StrLen /*nEnd */) const
/*N*/ {
/*N*/ SwStartNode* pSttNd = rSectFmt.GetSectionNode( FALSE );
/*N*/ return pSttNd &&
diff --git a/binfilter/bf_s
[Libreoffice] [PATCH 1/5] more shadowing fixed sw3io
Hello,
here some patches trying to make the compiler less verbose within
binfilter.
Currently, I catch only warning produced without debugging
regards
>From a36afe0088b28590dc07e8da7a8d380810640ad0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Sun, 28 Nov 2010 18:34:28 +0100
Subject: [PATCH 1/5] more shadowing fixed sw3io
e with '#' will be ignored, and an empty message aborts the commit.
---
binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx | 70 +++---
1 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx b/binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx
index 085997a..20403b4 100644
--- a/binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx
+++ b/binfilter/bf_sw/source/core/sw3io/sw_sw3attr.cxx
@@ -78,7 +78,7 @@ namespace binfilter {
/*N*/ SfxPoolItem* SwFmtSurround::Create( SvStream& rStrm, USHORT nVrs ) const
/*N*/ {
-/*N*/ BYTE nType, bGold = 0, bAnch=0, bCont=0, bOutside = 0;
+/*N*/ BYTE nType, bGold = 0, bAnch=0, bCont=0, bOutside1 = 0;
/*N*/ rStrm >> nType;
/*N*/ if ( nVrs < 5 )
/*N*/ rStrm >> bGold;
@@ -87,7 +87,7 @@ namespace binfilter {
/*N*/ if ( nVrs > 2 )
/*N*/ rStrm >> bCont;
/*N*/ if ( nVrs > 3 )
-/*N*/ rStrm >> bOutside;
+/*N*/ rStrm >> bOutside1;
/*N*/
/*N*/ SwFmtSurround *pRet = new SwFmtSurround( (SwSurround) nType );
/*N*/ if( bGold && SURROUND_NONE != (SwSurround)nType &&
@@ -95,7 +95,7 @@ namespace binfilter {
/*N*/ pRet->SetSurround( SURROUND_IDEAL );
/*N*/ pRet->SetAnchorOnly( BOOL(bAnch) );
/*N*/ pRet->SetContour( BOOL(bCont) );
-/*N*/ pRet->SetOutside( BOOL(bOutside) );
+/*N*/ pRet->SetOutside( BOOL(bOutside1) );
/*N*/ return pRet;
/*N*/ }
@@ -189,7 +189,7 @@ namespace binfilter {
/*N*/ SfxPoolItem* SwFmtHoriOrient::Create( SvStream& rStrm, USHORT nIVer ) const
/*N*/ {
/*N*/ long nPos;
-/*N*/ BYTE nOrient, nRelation, bToggle = 0, bGrf = 0;
+/*N*/ BYTE nOrient, nRelation, bToggle = 0;
/*N*/ rStrm >> nPos >> nOrient >> nRelation;
/*N*/
/*N*/ if( nIVer >= IVER_HORIORIENT_TOGGLE )
@@ -272,16 +272,16 @@ namespace binfilter {
/*N*/ SfxPoolItem* SwFmtFrmSize::Create( SvStream& rStrm, USHORT nVersion ) const
/*N*/ {
-/*N*/ BYTE nSizeType, nWidthPercent = 0, nHeightPercent = 0;
+/*N*/ BYTE nSizeType, nWidthPercent1 = 0, nHeightPercent1 = 0;
/*N*/ INT32 nWidth, nHeight;
/*N*/ rStrm >> nSizeType >> nWidth >> nHeight;
/*N*/
/*N*/ if ( nVersion > 1 )
-/*N*/ rStrm >> nWidthPercent >> nHeightPercent;
+/*N*/ rStrm >> nWidthPercent1 >> nHeightPercent1;
/*N*/
/*N*/ SwFmtFrmSize *pRet = new SwFmtFrmSize( (SwFrmSize) nSizeType, nWidth, nHeight );
-/*N*/ pRet->SetWidthPercent ( nWidthPercent );
-/*N*/ pRet->SetHeightPercent( nHeightPercent );
+/*N*/ pRet->SetWidthPercent ( nWidthPercent1 );
+/*N*/ pRet->SetHeightPercent( nHeightPercent1 );
/*N*/ return pRet;
/*N*/ }
@@ -337,12 +337,12 @@ namespace binfilter {
/*N*/ SfxPoolItem* SwFmtCol::Create( SvStream& rStrm, USHORT ) const
/*N*/ {
/*N*/ // Die Longs muessen runtergerechnet werden
-/*N*/ BYTE nLineAdj, bOrtho, nLineHeight, nPenStyle;
+/*N*/ BYTE nLineAdj, bOrtho1, nLineHeight1, nPenStyle;
/*N*/ INT16 nGutterWidth, nPenWidth;
/*N*/ UINT16 nWishWidth, nPenRed, nPenGreen, nPenBlue;
/*N*/ rStrm >> nLineAdj
-/*N*/ >> bOrtho
-/*N*/ >> nLineHeight
+/*N*/ >> bOrtho1
+/*N*/ >> nLineHeight1
/*N*/ >> nGutterWidth
/*N*/ >> nWishWidth
/*N*/ >> nPenStyle
@@ -366,10 +366,10 @@ namespace binfilter {
/*N*/ {
/*N*/ for( short i = 0; i < nCol; i++ )
/*N*/ {
-/*N*/ UINT16 nWidth, nLeft, nUpper, nRight, nLower;
-/*N*/ rStrm >> nWidth >> nLeft >> nUpper >> nRight >> nLower;
+/*N*/ UINT16 nWidth1, nLeft, nUpper, nRight, nLower;
+/*N*/ rStrm >> nWidth1 >> nLeft >> nUpper >> nRight >> nLower;
/*N*/ SwColumn* pCol = new SwColumn;
-/*N*/ pCol->SetWishWidth( nWidth );
+/*N*/ pCol->SetWishWidth( nWidth1 );
/*N*/ pCol->SetLeft( nLeft );
/*N*/ pCol->SetUpper( nUpper );
/*N*/ pCol->SetRight( nRight );
@@ -385,7 +385,7 @@ namespace binfilter {
/*N*/ // temporaerer Bug Fix
/*N*/ if( nCol )
/*N*/ // Wert direkt mit dem Silberhammer einschlagen.
-/*N*/ p->_SetOrtho( (BOOL) bOrtho );
+/*N*/ p->_SetOrtho( (BOOL) bOrtho1 );
/*N*/ return p;
/*N*/ }
@@ -424,22 +424,22 @@ namespace binfilter {
/*N*/ Sw3IoImp* pIo = Sw3IoImp::GetCurrentIo();
/*N*/ ASSERT( pIo, "Reader/Writer not found" );
/*N*/
-/*N*/ String sURL, sTargetFrameName, sName;
+/*N*/ String sURL1, sTargetFrameName1, sName1;
/*N*/ BOOL bServerMap = FALSE;
/*N*/
/*N*/ SwFmtURL *pNew = new SwFmtURL;
/*N*/
/*N*/ if( pIo )
-/*N*/ pNew->SetMap( pIo->InImageMap( sURL, sTargetFrameName, bServerMap ) );
+/*N*/ pNew->SetMap( pIo->InImageMap( sURL1, sTargetFrameName1, bServerMap ) );
/*N*/ if( nIVer>=1 )
-/*N*/ rStrm.ReadByteString( sName, rStrm.GetStreamCharSet() );
+/*N*/ rStrm.ReadByteString( sName1, rStrm.G
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 tbehr...@novell.com changed: What|Removed |Added CC||libreoff...@lists.freedeskt ||op.org -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Attention: New build structure is coming!
This is a heads-up about a change in the way we build the product that is about to be pushed. Current Situation = Right know there are 2 main way to build the product. Both of them rely on pulling the 'build' repo and using ./download in that repo to pull the 19 others git repos. The first method, the 'build-repo build' or 'distro-build' method consist of doing ./autogen.sh --with-distro && ./download && make in the 'build' git repo. This method involve a rsync step that copy the content of a directory called 'rawbuild' that contain - among other thing, a bunch of link pointing back to the git repos contained in ./clone/* This method also allow for the application of selected patch contained in ./patches and the use of --with-distro autogen parameter that simplify the definition of a bunch of ./configure parameters, specifics to different distributions. The rsync step in this method make it not developer friendly, since any manual changes in the git repos require to re-trigger the rsync, or some manual and error-prone patching trickery to build one's changes. The second method, the so-called 'rawbuild build' consist in cd-ing into the rawbuild directory, and running the autogen.sh that is there, and then 'make' there. This method does not involve any patching, and unless you specify all the autogen.sh parameters manually, build only the somewhat equivalent of --with-distro=[Linux/MacOS/Window]LibreOffice On the other hand, this method build directly from the git repos and therefore any change in the source is picked-up right away. this make hacking much easier and partial build much less problematic. Yet the second method still is coupled with the 'build-repo'. That is you still need to pull the 'build' git-repo to prime the setup. Goal The core goal of the upcoming changes is to allow for a slightly modified 'rawbuild build' so that pulling of the 'build' git repo is not necessary, while maintaining the ability, for now, to build using the 'distro-build' method if one choose to. I will refer to this modified rawbuild as a 'bootstrap-build' for reasons that will soon be clear. Bootstrap build === After the changes are pushed in, the preferred way for hacker and developers to build the product will be the one documented here: http://wiki.documentfoundation.org/Development/Native_Build (the note at the top will be removed when the changes are pushed) The short version is: git clone git://anongit.freedesktop.org/libreoffice/bootstrap libo cd libo ./autogen.sh # add your favorite autogen parameters, just like in the rawbuild method make Note that make take care automatically of doing ./download for you, but you still will have to run ./g pull -r (no, not ./bin/g :-) ) to pull new changes after the initial clone. Impact on the 'distro-build' These changes impact the distro-build, but only with regards to the directory structure of the intermediary layout used to rsync. namely: in the 'build' git-repository: * the 'rawbuild' directory disappear * a 'bootstrap' directory appear. it is what used to be ./clone/bootstrap. * all the others ./clone/* are now in ./bootsrap/clone/* * rsync is done using ./bootstrap as a base instead of rawbuild for all intents and purpose this should not change anything in the commands you type to build. So if you start fresh, the instruction to do a 'distro-build' remain unchanged. Attention *** If you have an existing setup, _when_ the changes are pushed to master and you pull them for the first time, you _HAVE_ to re-do your autogen.sh and ./download step. These have been modified to detect the situation where you still have the old directory setup and convert it automatically during the ./download step. Failure to do so will use outdated version of ./configure ./download and other support scripts, which is guarantee to end poorly. Be aware that there is no automated way to revert back to the old setup: this is especially a concern if you try to check-out a tag or a branch to a point _before_ these changes are merge. A tag will be placed just before the merge of these changes, named 'LIBREOFFICE_PRE_BOOTSTRAP_BUILD' to allow, if needed, to setup a fresh pull at a point before these change. It is still possible to do a 'rawbuild' with this new setup, except that instead of cd-ing to rawbuild you cd to bootstrap, and follow the method described in the 'bootstrap build' section above. (except the pull which is obviously already done). Review == The planned changes are stagged in a branch called feature/bootstrap-build. The changes are confined in the 'build' repo and in the 'bootstrap' repo. You can test either the distro-build method or the bootstrap method: To test the bootstrap method: just follow the instructions described in the 'Bootstrap build' section above, add a 'git branch -b feature/bootstrap-build origin/feature/bootstrap-build' just after the pull To test the 'distro-b
Re: [Libreoffice] [Crazy Ideas] Discuss
On Tue, 2010-11-30 at 11:48 +1100, Mattias Johnsson wrote: > On 30 November 2010 11:34, Joe Smith wrote: > > I was also having a lot of trouble learning anything from running OOo under > > gdb. Gdb was acting weird and I couldn't step through the code and poke > > around. I ended up trying to do it by adding a printf, rebuild, run, rinse, > > repeat. No fun; less progress. > > Did you turn off compiler optimisations? I had the same problem (gdb > hopping around in a non-intuitive way, and the values of some useful > variables were optimised out) until I turned them off. Yup, this is a good advice. Also, gdb at one point had issues with setting break points in class constructors. I don't know if this has been resolved yet in the more recent releases, but something to keep in mind in case you still use a version of gdb with this issue unresolvedd. gdb also tends to quit when you try to step through parts of code where no debug symbols are available. This may happen when you've rebuilt module only partially with debug symbols, and/or step into code of other modules that have not been re-built with debug symbols. > If that's the problem, you can do it by configuring with > --enable-debug, or if you're just building a single module you can do > "build -- debug=t dbglevel=2" "build debug=t" alone should turn off compiler optimization, before the '--' not after. I wouldn't recommend dbglevel=2 unless you know what you are getting with dbglevel=2. > I think "dbglevel=1" also turns them off, and will give less noise, > but I haven't checked. It's the debug=t part that turns off compiler optimization. dbglevel=# controls the amount of debug messages that other devs have put in (if I understand David's mail correctly, that is). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Crazy Ideas] Discuss
On 30 November 2010 11:34, Joe Smith wrote: > I was also having a lot of trouble learning anything from running OOo under > gdb. Gdb was acting weird and I couldn't step through the code and poke > around. I ended up trying to do it by adding a printf, rebuild, run, rinse, > repeat. No fun; less progress. Did you turn off compiler optimisations? I had the same problem (gdb hopping around in a non-intuitive way, and the values of some useful variables were optimised out) until I turned them off. If that's the problem, you can do it by configuring with --enable-debug, or if you're just building a single module you can do "build -- debug=t dbglevel=2" I think "dbglevel=1" also turns them off, and will give less noise, but I haven't checked. Cheers, Mattias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Crazy Ideas] Discuss
On 11/29/2010 06:39 PM, John LeMoyne Castle wrote: ... However, looking at textsearch.cxx in Open Grok -- http://opengrok.go-oo.org/xref/libs-gui/i18npool/source/search/textsearch.cxx#165 -- can see this comment before the various types of calls to a search routine: // use transliteration here, but only if not RegEx, which does it different One can also see other exclusion of the regexp search algorithm from the transliteration search prep and search result code in textsearch.cxx around the calls to the search routines, but I'm not absolutely sure that exclusion is complete. If the regexp search truly *never* uses transliteration then the swap out will be simpler and the change-over may actually enable transliteration. I haven't looked at the internal code of the regexp - perhaps it 'does it's own thing' internally for transliteration... Right. I have only a vague idea what "transliteration" means here. From a web search I can see that it must be an attempt to deal with things like accented characters (Is "a" the same as "ä", or not? Is "ss" the same as "ß"?), but I couldn't find any clear description of exactly what the transliteration was doing. There is a letter-case filter applied to the text before a regex search, changing all characters to one single case, lower case for English text. If the user indicates that case is significant, the filter is not applied. The actual searches get a text buffer and a pair of indices (first, last) indicating the region to search. The results are returned as a list of matches, also with indices into the text buffer. The code does a lot of adjusting of the indices, I suppose to account for character-level changes due to the transliteration, but again, I can't really tell what the adjustment code is supposed to do. I was also having a lot of trouble learning anything from running OOo under gdb. Gdb was acting weird and I couldn't step through the code and poke around. I ended up trying to do it by adding a printf, rebuild, run, rinse, repeat. No fun; less progress. My thought was maybe to just avoid all that and start out with an extension testbed that uses the Boost regexp. I'm sure I can get access to paragraphs of text without any transliteration or filtering, and see how well the Boost functions work. If that goes well, then move on to replacing code. I think Boost looks like the way to go, since it has a lot of functionality, supports Unicode (16- or 32-bit chars), and OOo already uses it. Performance could be a problem. I saw a comment in the code somewhere saying that performance is critical for some spreadsheets--I assume because Calc's lookups default to using regular expression matching. As far as I can see, that's a faulty design, the lookups should not use regexp matching unless it is specifically requested, but it may be too late to change that now. I've seen benchmarks indicating that the Boost regexp is fairly fast compared to other regexp engines, but I'm guessing that it's still slower than the current primitive engine. http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Updated artwork for RC
Hi Chris, you wrote: > Just to be sure - did you also update the position of the progress bars? > Yep. > And, looking at the files list below, it seems that the original > filenames (picked from the OOo UI project) changed a bit. Would it be > helpful to rename the icons within the artwork package? If yes, then I'd > add this to my todo stack or maybe asking for help on the design list. > I *kinda* hoped you would ask - yes, that would make things easier, going forward. ;) Additionally, there's currently quite a bit of duplication, e.g. we do not have any _hc images whatsoever, also the _rtl_ ones are just copied. Also the default_images..framework and ..brand images are currently duplicated, Michael, can we consolidate that? At finally, there's a big icon cleanup in progress currently, I hope I did not interfere too much with that. Cheers, -- Thorsten pgpZGRh0EmCJl.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Updated artwork for RC
Hi Thorsten! Thanks for that!!! Today, we got some guests (we are the new neighbors...), so I was unable to come up with a dedicated issue in the bug tracker. Just to be sure - did you also update the position of the progress bars? And, looking at the files list below, it seems that the original filenames (picked from the OOo UI project) changed a bit. Would it be helpful to rename the icons within the artwork package? If yes, then I'd add this to my todo stack or maybe asking for help on the design list. Cheers, Christoph PS: Cross-posting to des...@libreoffice.org to spread the news ... Am Dienstag, den 30.11.2010, 00:31 +0100 schrieb Thorsten Behrens: > Hi, > > since we decided to label the next release RC1 > (http://lists.freedesktop.org/archives/libreoffice/2010-November/003452.html), > just updated our artwork from > http://wiki.documentfoundation.org/File:LibreOffice-Initial-Artwork-Package.zip > > (differences: removed "beta" text, text / paper is visually more > polished) > > For later reference, this is the list of files touched: > > default_images/framework/res/backing.png > default_images/framework/res/backing_hc.png > default_images/framework/res/backing_right.png > default_images/framework/res/backing_right_hc.png > default_images/framework/res/backing_rtl_left.png > default_images/framework/res/backing_rtl_left_hc.png > default_images/framework/res/backing_rtl_right.png > default_images/framework/res/backing_rtl_right_hc.png > default_images/framework/res/backing_space.png > default_images/framework/res/backing_space_hc.png > > default_images/brand/shell/backing.png > default_images/brand/shell/backing_hc.png > default_images/brand/shell/backing_right.png > default_images/brand/shell/backing_right_hc.png > default_images/brand/shell/backing_rtl_left.png > default_images/brand/shell/backing_rtl_left_hc.png > default_images/brand/shell/backing_rtl_right.png > default_images/brand/shell/backing_rtl_right_hc.png > default_images/brand/shell/backing_space.png > default_images/brand/shell/backing_space_hc.png > default_images/brand/shell/backing-pt_BR.png > default_images/brand/shell/backing_hc-pt_BR.png > default_images/brand/shell/backing_right-pt_BR.png > default_images/brand/shell/backing_right_hc-pt_BR.png > default_images/brand/shell/backing_rtl_left-pt_BR.png > default_images/brand/shell/backing_rtl_left_hc-pt_BR.png > default_images/brand/shell/backing_rtl_right-pt_BR.png > default_images/brand/shell/backing_rtl_right_hc-pt_BR.png > > default_images/introabout/about.png > default_images/introabout/about.bmp > default_images/introabout/intro.png > default_images/introabout/intro.bmp > > default_images/brand/introabout/about.png > default_images/brand/introabout/about-pt_BR.png > default_images/brand/introabout/intro.png > default_images/brand/introabout/intro-pt_BR.png > > instsetoo_native/inc_ooolangpack/windows/msi_templates/Binary/Banner.bmp > instsetoo_native/inc_ooolangpack/windows/msi_templates/Binary/Image.bmp > instsetoo_native/inc_openoffice/windows/msi_templates/Binary/Banner.bmp > instsetoo_native/inc_openoffice/windows/msi_templates/Binary/Image.bmp > instsetoo_native/inc_broffice/windows/msi_templates/Binary/Banner.bmp > instsetoo_native/inc_broffice/windows/msi_templates/Binary/Image.bmp > instsetoo_native/res/nologoinstall.bmp > > setup_native/source/win32/nsis/ooosdkbanner.bmp > setup_native/source/win32/nsis/brosdkbanner.bmp > setup_native/source/win32/nsis/ooosdkbitmap.bmp > setup_native/source/win32/nsis/urebanner.bmp > setup_native/source/win32/nsis/urebitmap.bmp > setup_native/source/win32/nsis/ooosetup.ico > setup_native/source/win32/nsis/ooobanner.bmp > setup_native/source/win32/nsis/brobanner.bmp > setup_native/source/win32/nsis/ooobitmap.bmp > setup_native/source/win32/nsis/brobitmap.bmp > setup_native/source/mac/ooo/osxdndinstall.png > setup_native/source/mac/ooo/osxdndinstall_nologo.png > setup_native/source/mac/broffice/osxdndinstall.png > setup_native/source/mac/broffice/osxdndinstall_nologo.png > > Cheers, > > -- Thorsten > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Crazy Ideas] Discuss
I like the idea of replacing the internal regexp in favor of a more fully developed regexp evaluator. The goal should be to get rid of the weaker regexp module. A question I don't know how to answer is which is the best replacement. As Thorsten points out, ideally the replacement should be enabled for localization and transliteration - again more stuff I don't understand well at all. However, looking at textsearch.cxx in Open Grok -- http://opengrok.go-oo.org/xref/libs-gui/i18npool/source/search/textsearch.cxx#165 -- can see this comment before the various types of calls to a search routine: // use transliteration here, but only if not RegEx, which does it different One can also see other exclusion of the regexp search algorithm from the transliteration search prep and search result code in textsearch.cxx around the calls to the search routines, but I'm not absolutely sure that exclusion is complete. If the regexp search truly *never* uses transliteration then the swap out will be simpler and the change-over may actually enable transliteration. I haven't looked at the internal code of the regexp - perhaps it 'does it's own thing' internally for transliteration... -- View this message in context: http://nabble.documentfoundation.org/Crazy-Ideas-Discuss-Replace-regexp-parser-with-std-library-tp1974632p1989646.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Updated artwork for RC
Hi, since we decided to label the next release RC1 (http://lists.freedesktop.org/archives/libreoffice/2010-November/003452.html), just updated our artwork from http://wiki.documentfoundation.org/File:LibreOffice-Initial-Artwork-Package.zip (differences: removed "beta" text, text / paper is visually more polished) For later reference, this is the list of files touched: default_images/framework/res/backing.png default_images/framework/res/backing_hc.png default_images/framework/res/backing_right.png default_images/framework/res/backing_right_hc.png default_images/framework/res/backing_rtl_left.png default_images/framework/res/backing_rtl_left_hc.png default_images/framework/res/backing_rtl_right.png default_images/framework/res/backing_rtl_right_hc.png default_images/framework/res/backing_space.png default_images/framework/res/backing_space_hc.png default_images/brand/shell/backing.png default_images/brand/shell/backing_hc.png default_images/brand/shell/backing_right.png default_images/brand/shell/backing_right_hc.png default_images/brand/shell/backing_rtl_left.png default_images/brand/shell/backing_rtl_left_hc.png default_images/brand/shell/backing_rtl_right.png default_images/brand/shell/backing_rtl_right_hc.png default_images/brand/shell/backing_space.png default_images/brand/shell/backing_space_hc.png default_images/brand/shell/backing-pt_BR.png default_images/brand/shell/backing_hc-pt_BR.png default_images/brand/shell/backing_right-pt_BR.png default_images/brand/shell/backing_right_hc-pt_BR.png default_images/brand/shell/backing_rtl_left-pt_BR.png default_images/brand/shell/backing_rtl_left_hc-pt_BR.png default_images/brand/shell/backing_rtl_right-pt_BR.png default_images/brand/shell/backing_rtl_right_hc-pt_BR.png default_images/introabout/about.png default_images/introabout/about.bmp default_images/introabout/intro.png default_images/introabout/intro.bmp default_images/brand/introabout/about.png default_images/brand/introabout/about-pt_BR.png default_images/brand/introabout/intro.png default_images/brand/introabout/intro-pt_BR.png instsetoo_native/inc_ooolangpack/windows/msi_templates/Binary/Banner.bmp instsetoo_native/inc_ooolangpack/windows/msi_templates/Binary/Image.bmp instsetoo_native/inc_openoffice/windows/msi_templates/Binary/Banner.bmp instsetoo_native/inc_openoffice/windows/msi_templates/Binary/Image.bmp instsetoo_native/inc_broffice/windows/msi_templates/Binary/Banner.bmp instsetoo_native/inc_broffice/windows/msi_templates/Binary/Image.bmp instsetoo_native/res/nologoinstall.bmp setup_native/source/win32/nsis/ooosdkbanner.bmp setup_native/source/win32/nsis/brosdkbanner.bmp setup_native/source/win32/nsis/ooosdkbitmap.bmp setup_native/source/win32/nsis/urebanner.bmp setup_native/source/win32/nsis/urebitmap.bmp setup_native/source/win32/nsis/ooosetup.ico setup_native/source/win32/nsis/ooobanner.bmp setup_native/source/win32/nsis/brobanner.bmp setup_native/source/win32/nsis/ooobitmap.bmp setup_native/source/win32/nsis/brobitmap.bmp setup_native/source/mac/ooo/osxdndinstall.png setup_native/source/mac/ooo/osxdndinstall_nologo.png setup_native/source/mac/broffice/osxdndinstall.png setup_native/source/mac/broffice/osxdndinstall_nologo.png Cheers, -- Thorsten pgpqQzHaKeAhr.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Language selection
I find the language selector on the bottom of the writer UI not so efficient. I have installed just a few languages, but still "all the wrong" languages show up. Could it be an idea to show the -last used languages first or -installed languages first in that box? Also, I don't see the logic behind the "Set language for paragraph" submenu. It looks very redundant at least for me. See attached. best Arno <> signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] opening oxt from command line
Hi I have LibreOffice 3.3.0 OOO330m9 (Build:1) libreoffice-build 3.2.99.2 It hangs when I do "libreoffice extension.oxt" from the command line. No error messages on stdout. Adding the extension from the menu Tools | Extension manager works fine. Arno signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Last patch to clean code at writer [source/ui]
So, I'm happy, this patch finish my work to clean code around writer, everything inside sw. Sending for review (large patch). revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OxygenOffice stuffs in LibreOfice git tree
Hi Kami, On Sun, 2010-11-28 at 20:30 +0100, KAMI911 KAMI911 wrote: > I would like to put OxygenOffice extras as a configurable content to > LibreOffice git tree. Currently it is enabled only when the one > selects OxygenOffice as distro conf. Okay. > My plan is to add --with-extra-gallery --with-extra-font --with > -extra-template --with-extra-sample to configure in. Of course all > extra contents are optional hence all are disabled. Sounds good to me :-) > Can I do it for libreoffice-3-3? I could send patch for review before > I submit it. The contents are in separated, downloadable zip files, so > they are not overloading the git tree. Of course; but for 3-3 it needs to get in really soon now - ie. tomorrow early I hope. Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Integration of patches/dev300/apply's patches and release schedule
Hi Kami, On Sun, 2010-11-28 at 20:34 +0100, KAMI911 KAMI911 wrote: > Can you explain me what patches will got to git tree in the timeframe > of libreoffice-3-3 release and int the future? When rawbuild will take > over the simple build? How patches will added from apply file? Well - we should be dropping the 'build' module shortly for most people (but probably not distributors) wrt. migrating patches from there - we are really trying to get them all merged into the code flat - this is by far the easiest, and most preferred option. We want fewer and fewer patches in the 'apply' file, and to drop that infrastructure - that is the goal at least. Of course, to avoid regression, we will continue to ship with some of the patches in apply until 3.4 (I suspect). > Also let me know the release status and schedule fro 3.3. Oh - we are about to go into deep code freeze, and only-with-co-review thing for RC1 of 3.3 so - if you need things in, they need to go in fast :-) HTH, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one
On Mon, 2010-11-29 at 20:04 +, Caolán McNamara wrote: > There's another, (in my opinion more interesting), class of dead-code > and that's the stuff that's compiled in but isn't called by anything. Ah yes. > I've yet to get in gear and get up-to-date runs for LibreOffice, but see > http://people.redhat.com/caolanm/callcatcher/DEV300_m87/ for my last OOo > callcatcher run. e.g. approx 170 apparently juicy unused methods in > calc. We had an Easy Hack for that: http://wiki.documentfoundation.org/Development/Easy_Hacks#call-catcher_.2F_bloat_removal Though it clearly needed more detail: I've added a bit more, and a link to your reports, as well as shifting it up the running order: perhaps we'll get some interested people :-) > Though caveats apply and manual double checking is required to see why > nothing calls them. They might be called only under some ifdefs, or by > some tricky means like dlopen/dlsym (which is only likely to happen for > C symbols and not C++ symbols, noone in their right mind dlsyms Sure :-) ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] MacOSX release build configure line
Hi Norbert, got the mac booted & configure line (for the "build" repo) extracted: ./configure --with-distro=LibreOfficeMacOSX --with-lang="en-US af ar be-BY bg br ca cs cy da de el en-GB en-ZA es et fi fr ga gl gu he hi-IN hu hr it ja ka km ko lt mk nb nl nn nr pa-IN pl pt pt-BR ru rw sh sk sl sr ss st sv tg th tr ts uk ve vi xh zh-TW zh-CN zu" --with-poor-help-localizations="af bg be-BY br ca cy el fi ga he hr ka lt mk nb nn nr rw sh sr sk ss st tg th tr th ts uk ve vi xh zu" (or use --with-lang=ALL for extra-long build experience. And the machine-specific --with-num-cpus=X --with-max-jobs=Y of course). Everything else is by now rolled into the LibreOfficeMacOSX distro config. Cheers, -- Thorsten pgp8ggrBfUDjq.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one
On Mon, 2010-11-29 at 16:56 +, Wols Lists wrote: > That's all of base scanned. Unless I've missed something (and I've > deliberately skipped a few bits, eg that marked with TODO), there > shouldn't be any dead code or end-of-if/end-of-switch type comments left > there. Nice :-) is it worth noting that in the wiki ? Thanks, Michael (who likes 'complete' solutions :-) -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one
On Mon, 2010-11-29 at 16:56 +, Wols Lists wrote: > That's all of base scanned. Unless I've missed something (and I've > deliberately skipped a few bits, eg that marked with TODO), there > shouldn't be any dead code or end-of-if/end-of-switch type comments left There's another, (in my opinion more interesting), class of dead-code and that's the stuff that's compiled in but isn't called by anything. I've yet to get in gear and get up-to-date runs for LibreOffice, but see http://people.redhat.com/caolanm/callcatcher/DEV300_m87/ for my last OOo callcatcher run. e.g. approx 170 apparently juicy unused methods in calc. Though caveats apply and manual double checking is required to see why nothing calls them. They might be called only under some ifdefs, or by some tricky means like dlopen/dlsym (which is only likely to happen for C symbols and not C++ symbols, noone in their right mind dlsyms C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] And another one
On 29/11/10 16:14, Caolán McNamara wrote: > On Mon, 2010-11-29 at 15:48 +, Wols Lists wrote: >> Cheers, > Looks good, pushed, thanks for that. > > C. > That's all of base scanned. Unless I've missed something (and I've deliberately skipped a few bits, eg that marked with TODO), there shouldn't be any dead code or end-of-if/end-of-switch type comments left there. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes
On Wed, 2010-11-24 at 20:34 +, Caolán McNamara wrote: > I've been struggling a little bit with converting tests from > testautomation/math/required/includes/m_002_.inc e.g. tmEditMarker into > a build-time cppunit test Figured this out now. Can test SmEditWindow standalone now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] And another one
On Mon, 2010-11-29 at 15:48 +, Wols Lists wrote: > Cheers, Looks good, pushed, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Another one for Base
On Mon, 2010-11-29 at 15:14 +, Wols Lists wrote: > Cheers, Looks good to me. Pushed this. Thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: More commented our code removed in calc
On Mon, 2010-11-29 at 16:34 +0200, timo wrote: > Hopefully works for you! Yes, all looks good. Now pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove undesirable comments
On Mon, 2010-11-29 at 23:33 +0900, Takeshi Abe wrote: > Hi, > > Another cleanup on base. Looks good, pushed this. Thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] And another one
Cheers,
Wol
>From fa312399900437d13fabc456c851be6f971ab3d1 Mon Sep 17 00:00:00 2001
From: Wol
Date: Mon, 29 Nov 2010 15:47:37 +
Subject: [PATCH 2/2] More comment deletions
---
reportdesign/source/ui/report/DesignView.cxx |4
reportdesign/source/ui/report/ReportController.cxx |4 ++--
reportdesign/source/ui/report/dlgedfunc.cxx|2 --
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/reportdesign/source/ui/report/DesignView.cxx
b/reportdesign/source/ui/report/DesignView.cxx
index c404c53..968154d 100644
--- a/reportdesign/source/ui/report/DesignView.cxx
+++ b/reportdesign/source/ui/report/DesignView.cxx
@@ -466,11 +466,7 @@ void ODesignView::GetFocus()
//
-
void ODesignView::ImplInitSettings()
{
-//#if OSL_DEBUG_LEVEL > 0
-//SetBackground( Wallpaper( COL_RED ));
-//#else
SetBackground( Wallpaper(
Application::GetSettings().GetStyleSettings().GetFaceColor() ));
-//#endif
SetFillColor( Application::GetSettings().GetStyleSettings().GetFaceColor()
);
SetTextFillColor(
Application::GetSettings().GetStyleSettings().GetFaceColor() );
}
diff --git a/reportdesign/source/ui/report/ReportController.cxx
b/reportdesign/source/ui/report/ReportController.cxx
index 584ac3e..e2db54f 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -1481,7 +1481,7 @@ void OReportController::Execute(sal_uInt16 _nId, const
Sequence< PropertyValue >
{
const String
sUndoAction(ModuleRes(RID_STR_UNDO_CHANGEFONT));
pListAction.reset(new
UndoManagerListAction(m_aUndoManager,sUndoAction));
-} // if ( !pListAction.get() )
+}
uno::Reference< report::XReportControlFormat>
xReportControlFormat(*aIter,uno::UNO_QUERY);
lcl_setFontWPU_nothrow(xReportControlFormat,_nId);
}
@@ -3749,7 +3749,7 @@ void OReportController::listen(const bool _bAdd)
xGroups->addContainerListener(static_cast(this));
m_xReportDefinition->addModifyListener(static_cast(this));
}
-else /* ! _bAdd */
+else
{
rObserver.RemoveSection(m_xReportDefinition->getDetail());
xGroups->removeContainerListener(static_cast(this));
diff --git a/reportdesign/source/ui/report/dlgedfunc.cxx
b/reportdesign/source/ui/report/dlgedfunc.cxx
index 6b53a22..221c9b2 100644
--- a/reportdesign/source/ui/report/dlgedfunc.cxx
+++ b/reportdesign/source/ui/report/dlgedfunc.cxx
@@ -680,8 +680,6 @@ BOOL DlgEdFuncInsert::MouseButtonDown( const MouseEvent&
rMEvt )
const SdrHitKind eHit = m_rView.PickAnything(rMEvt, SDRMOUSEBUTTONDOWN,
aVEvt);
-// eHit == SDRHIT_UNMARKEDOBJECT under the mouse cursor is a unmarked object
-
if (eHit == SDRHIT_UNMARKEDOBJECT &&
nId != OBJ_CUSTOMSHAPE)
{
--
1.7.2.2
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Another one for Base
Cheers,
Wol
>From 804f503777bff780d82226f37843f3b614a5d5f7 Mon Sep 17 00:00:00 2001
From: Wol
Date: Mon, 29 Nov 2010 15:10:42 +
Subject: [PATCH] More deleted comments
../../../dbaccess/source/core/misc/0001-More-translations-and-comment-deletion-for-Base.patch
---
reportdesign/source/ui/misc/FunctionHelper.cxx | 11 ++
reportdesign/source/ui/misc/UITools.cxx| 36 ++--
reportdesign/source/ui/misc/Undo.cxx |2 +-
.../source/ui/misc/statusbarcontroller.cxx |4 +-
4 files changed, 17 insertions(+), 36 deletions(-)
diff --git a/reportdesign/source/ui/misc/FunctionHelper.cxx
b/reportdesign/source/ui/misc/FunctionHelper.cxx
index d653ef9..b1535d6 100644
--- a/reportdesign/source/ui/misc/FunctionHelper.cxx
+++ b/reportdesign/source/ui/misc/FunctionHelper.cxx
@@ -58,7 +58,7 @@ sal_Unicode FunctionManager::getSingleToken(const
formula::IFunctionManager::ETo
return sal_Unicode('{');
case eArrayClose:
return sal_Unicode('}');
-} // switch(_eToken)
+}
return 0;
}
//
-
@@ -93,11 +93,6 @@ const formula::IFunctionDescription*
FunctionManager::getFunctionByName(const ::
//
-
void FunctionManager::fillLastRecentlyUsedFunctions(::std::vector< const
formula::IFunctionDescription*>& /*_rLastRUFunctions*/) const
{
-//const sal_uInt32 nCount = getCount();
-//for(sal_uInt32 i = 0 ; i < nCount ; ++i)
-//{
-//const formula::IFunctionCategory* pCategory = getCategory(
-//}
}
//
-
::boost::shared_ptr< FunctionDescription > FunctionManager::get(const
uno::Reference< report::meta::XFunctionDescription>& _xFunctionDescription)
const
@@ -118,9 +113,9 @@ void
FunctionManager::fillLastRecentlyUsedFunctions(::std::vector< const formula
m_aCategoryIndex.push_back( aCategoryFind );
}
aFunctionFind =
m_aFunctions.insert(TFunctionsMap::value_type(sFunctionName,::boost::shared_ptr(new
FunctionDescription(aCategoryFind->second.get(),_xFunctionDescription.first;
-} // if ( aFind == m_aFunctions.end() )
+}
pDesc = aFunctionFind->second;
-} // if ( _xFunctionDescription.is() )
+}
return pDesc;
}
//
-
diff --git a/reportdesign/source/ui/misc/UITools.cxx
b/reportdesign/source/ui/misc/UITools.cxx
index ba963d9..ae81de8 100644
--- a/reportdesign/source/ui/misc/UITools.cxx
+++ b/reportdesign/source/ui/misc/UITools.cxx
@@ -175,14 +175,14 @@ void adjustSectionName(const uno::Reference<
report::XGroup >& _xGroup,sal_Int32
::rtl::OUString sName = String(ModuleRes(RID_STR_GROUPHEADER));
sName += ::rtl::OUString::valueOf(_nPos);
_xGroup->getHeader()->setName(sName);
-} // if ( _xGroup->getHeaderOn() )
+}
if ( _xGroup->getFooterOn() &&
!_xGroup->getFooter()->getName().getLength() )
{
::rtl::OUString sName = String(ModuleRes(RID_STR_GROUPFOOTER));
sName += ::rtl::OUString::valueOf(_nPos);
_xGroup->getFooter()->setName(sName);
-} // if ( _xGroup->getHeaderOn() )
+}
}
//
-
::rtl::Reference< comphelper::OPropertyChangeMultiplexer>
addStyleListener(const uno::Reference< report::XReportDefinition >&
_xReportDefinition,::comphelper::OPropertyChangeListener* _pListener)
@@ -261,7 +261,7 @@ namespace
case COMPLEX:
aLocale = _rxReportControlFormat->getCharLocaleComplex();
break;
-} // switch(_nWhich)
+}
_rItemSet.Put(SvxLanguageItem(MsLangId::convertLocaleToLanguageWithFallback(aLocale),_nLanguage));
@@ -288,7 +288,7 @@ namespace
pClone->PutValue(_xShape->getPropertyValue(aIt->sName),
aIt->nMemberId);
_rItemSet.Put(*pClone, aIt->nWID);
}
-} // if ( xInfo->hasPropertyByName(sPropertyName) )
+}
++aIt;
}
}
@@ -319,11 +319,11 @@ namespace
catch(uno::Exception&)
{ // shapes have a bug so we ignore this one.
}
-} // if ( pItem )
+}
}
}
++aIt;
-} // while ( pPropertyMap->pName )
+}
}
//
-
void lcl_CharPropertiesToItems( const
uno::Reference& _rxReportControlFormat,
@@ -353,7 +353,6 @@ namespace
_rItemSet.Put(aUnderLineItem);
_rItemSet.Put(SvxKerningItem(_rxReportControlFormat->getCharKerning
[Libreoffice] More commented our code removed in calc
Hopefully works for you!
Timo
--
.../controller/drawinglayer/DrawViewWrapper.cxx| 38
.../itemsetwrapper/AxisItemConverter.cxx |2 -
.../CharacterPropertyItemConverter.cxx |9 -
.../itemsetwrapper/DataPointItemConverter.cxx |1 -
.../GraphicPropertyItemConverter.cxx | 17 -
.../RegressionEquationItemConverter.cxx| 18 -
6 files changed, 0 insertions(+), 85 deletions(-)
>From 4e4777c919a4f6d99ed10071e979f889c484d932 Mon Sep 17 00:00:00 2001
From: Timo Heino
Date: Mon, 29 Nov 2010 16:25:02 +0200
Subject: [PATCH] Removed (again) some commented out code.
Hopefully this helps!
Signed-off-by: Timo Heino
---
.../controller/drawinglayer/DrawViewWrapper.cxx| 38
.../itemsetwrapper/AxisItemConverter.cxx |2 -
.../CharacterPropertyItemConverter.cxx |9 -
.../itemsetwrapper/DataPointItemConverter.cxx |1 -
.../GraphicPropertyItemConverter.cxx | 17 -
.../RegressionEquationItemConverter.cxx| 18 -
6 files changed, 0 insertions(+), 85 deletions(-)
diff --git a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
index cd70397..4a6c9f6 100644
--- a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
+++ b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
@@ -118,41 +118,6 @@ OutputDevice * lcl_GetParentRefDevice( const uno::Reference< frame::XModel > & x
}
-/*
-void lcl_initOutliner( SdrOutliner* pTargetOutliner, SdrOutliner* pSourceOutliner )
-{
-//just an unsuccessful try to initialize the text edit outliner correctly
-//if( bInit )
-{
-pTargetOutliner->EraseVirtualDevice();
-pTargetOutliner->SetUpdateMode(FALSE);
-pTargetOutliner->SetEditTextObjectPool( pSourceOutliner->GetEditTextObjectPool() );
-pTargetOutliner->SetDefTab( pSourceOutliner->GetDefTab() );
-}
-
-pTargetOutliner->SetRefDevice( pSourceOutliner->GetRefDevice() );
-pTargetOutliner->SetForbiddenCharsTable( pSourceOutliner->GetForbiddenCharsTable() );
-pTargetOutliner->SetAsianCompressionMode( pSourceOutliner->GetAsianCompressionMode() );
-pTargetOutliner->SetKernAsianPunctuation( pSourceOutliner->IsKernAsianPunctuation() );
-pTargetOutliner->SetStyleSheetPool( pSourceOutliner->GetStyleSheetPool() );
-pTargetOutliner->SetRefMapMode( pSourceOutliner->GetRefMapMode() );
-pTargetOutliner->SetDefaultLanguage( pSourceOutliner->GetDefaultLanguage() );
-pTargetOutliner->SetHyphenator( pSourceOutliner->GetHyphenator() );
-
-USHORT nX, nY;
-pSourceOutliner->GetGlobalCharStretching( nX, nY );
-pTargetOutliner->SetGlobalCharStretching( nX, nY );
-
-*//*
-if ( !GetRefDevice() )
-{
-MapMode aMapMode(eObjUnit, Point(0,0), aObjUnit, aObjUnit);
-pTargetOutliner->SetRefMapMode(aMapMode);
-}
-*//*
-}
-*/
-
DrawViewWrapper::DrawViewWrapper( SdrModel* pSdrModel, OutputDevice* pOut, bool bPaintPageForEditMode)
: E3dView(pSdrModel, pOut)
, m_pMarkHandleProvider(NULL)
@@ -200,7 +165,6 @@ void DrawViewWrapper::ReInit()
bHlplVisible = false;
this->SetNoDragXorPolys(true);//for interactive 3D resize-dragging: paint only a single rectangle (not a simulated 3D object)
-//this->SetResizeAtCenter(true);//for interactive resize-dragging: keep the object center fix
//a correct work area is at least necessary for correct values in the position and size dialog
Rectangle aRect(Point(0,0), aOutputSize);
@@ -233,7 +197,6 @@ void DrawViewWrapper::SetMarkHandles()
SdrObject* DrawViewWrapper::getHitObject( const Point& rPnt ) const
{
SdrObject* pRet = NULL;
-//ULONG nOptions =SDRSEARCH_DEEP|SDRSEARCH_PASS2BOUND|SDRSEARCH_PASS3NEAREST;
ULONG nOptions = SDRSEARCH_DEEP | SDRSEARCH_TESTMARKABLE;
SdrPageView* pSdrPageView = this->GetPageView();
@@ -333,7 +296,6 @@ void DrawViewWrapper::attachParentReferenceDevice( const uno::Reference< frame::
SdrOutliner* DrawViewWrapper::getOutliner() const
{
-//lcl_initOutliner( m_apOutliner.get(), &GetModel()->GetDrawOutliner() );
return m_apOutliner.get();
}
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index 0713cc7..79aab2f 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -368,7 +368,6 @@ void AxisItemConverter::FillSpecialItem( USHORT nWhichId, SfxItemSet & rOutItemS
break;
case SID_ATTR_NUMBERFORMAT_VALUE:
-// case SCHATTR_AXIS_NUMFMT:
{
if( m_pExplicitScale )
{
@@ -758,7 +757,6 @@ bool AxisItemConverter::ApplySpecialItem( USHORT nWhichId, const SfxItemSet & rI
[Libreoffice] [PATCH] Remove undesirable comments
Hi,
Another cleanup on base.
Cheers,
-- Takeshi Abe
>From 63a8fe4b01f142df496219baa85bd64204382bfe Mon Sep 17 00:00:00 2001
From: Takeshi Abe
Date: Mon, 29 Nov 2010 23:29:33 +0900
Subject: [PATCH] Remove undesirable comments
---
.../source/core/dataaccess/databasecontext.cxx |2 +-
dbaccess/source/ui/control/RelationControl.cxx |5 +--
.../source/ui/querydesign/SelectionBrowseBox.cxx |2 +-
.../ui/relationdesign/RTableConnectionData.cxx |2 +-
.../source/ui/tabledesign/FieldDescriptions.cxx|2 +-
dbaccess/source/ui/tabledesign/TableController.cxx |4 +-
reportdesign/source/core/sdr/RptObject.cxx |4 +-
reportdesign/source/ui/dlg/GroupsSorting.cxx |4 +-
reportdesign/source/ui/inc/UITools.hxx |2 +-
reportdesign/source/ui/misc/FunctionHelper.cxx |6 ++--
reportdesign/source/ui/misc/UITools.cxx| 22 ++--
reportdesign/source/ui/misc/Undo.cxx |2 +-
.../source/ui/misc/statusbarcontroller.cxx |4 +-
reportdesign/source/ui/report/ReportController.cxx |2 +-
14 files changed, 31 insertions(+), 32 deletions(-)
diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx b/dbaccess/source/core/dataaccess/databasecontext.cxx
index 6fcf10a..42ce480 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -160,7 +160,7 @@ namespace dbaccess
{
Reference xCloseable(xModel,UNO_QUERY_THROW);
xCloseable->close(sal_False);
-} // if ( !xModel->getControllers()->hasMoreElements() )
+}
}
catch(const CloseVetoException&)
{
diff --git a/dbaccess/source/ui/control/RelationControl.cxx b/dbaccess/source/ui/control/RelationControl.cxx
index d4a7009..85e7cb2 100644
--- a/dbaccess/source/ui/control/RelationControl.cxx
+++ b/dbaccess/source/ui/control/RelationControl.cxx
@@ -134,7 +134,7 @@ namespace dbaui
DBG_NAME(ORelationControl)
//
ORelationControl::ORelationControl( OTableListBoxControl* pParent ,const OJoinTableView::OTableWindowMap* _pTableMap)
-:EditBrowseBox( pParent, EBBF_SMART_TAB_TRAVEL | EBBF_NOROWPICTURE, WB_TABSTOP | /*WB_3DLOOK | */WB_BORDER | BROWSER_AUTOSIZE_LASTCOL)
+:EditBrowseBox( pParent, EBBF_SMART_TAB_TRAVEL | EBBF_NOROWPICTURE, WB_TABSTOP | WB_BORDER | BROWSER_AUTOSIZE_LASTCOL)
,m_pTableMap(_pTableMap)
,m_pBoxControl(pParent)
,m_xSourceDef( NULL )
@@ -518,7 +518,7 @@ OTableListBoxControl::OTableListBoxControl( Window* _pParent
pInitialRight = aIter->second;
m_strCurrentRight = aIter->first;
}
-} // for(;aIter != m_pTableMap->end();++aIter)
+}
if ( !pInitialRight )
{
@@ -668,7 +668,6 @@ OTableListBoxControl::OTableListBoxControl( Window* _pParent
{
_pTableSeparator->SetZOrder(&m_lmbRightTable, WINDOW_ZORDER_BEHIND);
m_pRC_Tables->SetZOrder(_pTableSeparator, WINDOW_ZORDER_BEHIND);
-//aDlgPoint = m_pTableSeparator->GetPosPixel() + Point(0,aSize.Height()) + LogicToPixel( Point(0,6), MAP_APPFONT );
_pTableSeparator->SetPosPixel(Point(0,m_aFL_InvolvedFields.GetPosPixel().Y()));
const Size aSize = _pTableSeparator->GetSizePixel();
aDlgPoint.Y() = _pTableSeparator->GetPosPixel().Y() + aSize.Height();
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 4f02a1f..2a2031c 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -1588,7 +1588,7 @@ void OSelectionBrowseBox::InsertColumn(OTableFieldDescRef pEntry, USHORT& _nColu
getFields()[nOldPosition - 1] = pEntry;
ColumnMoved(pEntry->GetColumnId(),FALSE);
-} // if ( pEntry->GetColumnId() != nColumnId )
+}
if ( pEntry->GetFunctionType() & (FKT_AGGREGATE) )
{
diff --git a/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx b/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
index e31abba..f875bee 100644
--- a/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
+++ b/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
@@ -416,7 +416,7 @@ xKey.clear();
}
}
xKey.clear();
-} // for(sal_Int32 i=0;igetCount();++i)
+}
if ( bDropRelation )
{
DropRelation();
diff --git a/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx b/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
index f4cf446..7f868b1 100644
--- a/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
+++ b/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
@@ -561
Re: [Libreoffice] Current state of the update of the build method
On Mon, Nov 29, 2010 at 02:13:49PM +0100, Miklos Vajna wrote: > On Mon, Nov 29, 2010 at 01:39:22PM +0100, Jan Holesovsky > wrote: > > So you propose to rename rawbuild to bootstrap, when the build-based > > method is used, right? As only the distro maintainers are the potential > > users for this, I am taking this to the ML; but I suppose nobody is > > going to be against that ;-) > > Sure - since distro builds don't use git, thus rawbuild is not used > there, AFAIK. :) This is not true for test-builds between releases. They use git (at least in my case). Of course there're not uploadable to Debian proper, but... Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 9th week development summary
Hi, this time a brief summary of what happened the 9th week on LibreOffice repos and two living branches: bugfixes-master-week-47.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) in the master branch commit-log-master-week-47.txt lists all relevant commits on the actual source repos in the master branch commit-log-libreoffice-3-3-week-47.txt, bugfixes-libreoffice-3-3-week-47.txt lists the same summary for the libreoffice-3-3 branch. Many thanks to all contributors - you make all the difference! Best Regards, Petr + artwork: + Revert "nativeb: #i110796# changed document icons for Classic theme" [Thorsten Behrens] + bootstrap: + find the internal libpython (fdo#31764) [Petr Mladek] + build: + layouted zoom dialog was not localized (bnc#595823) [Petr Mladek] + reduce height of PDF export and recovery dialogs (bnc#623352) [Petr Mladek] + remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene Engelhard] + components: + Resolves: rhbz#656191 Catch bad alloc and convert to ZipIOException [Caolán McNamara] + Resolves: rhbz#657628# divide by zero [Caolán McNamara] + show the control geometric propertis correctly (bnc#610921) [Petr Mladek] + show the really used default icon theme in options (bnc#603169) [Petr Mladek] + filters: + fix for n#648731 imagedata attribute not imported correctly [Noel Power] + Missing call to importDocumentProperties() n#655194 [Muthu Subramanian K] + tentative fix for fdo#30474# [Noel Power] + libs-core: + Fix for i#115681 [Cédric Bosdonnat] + masterfix OOO330: #i115774# crash in FR version when typing / as first character [obo] + Related: rhbz#650170 don't crash when quickstarter is exited by user [David Tardon] + Resolves: fdo#31494# get ownership right [Caolán McNamara] + Resolves: rhbz#610103 exit quickstarter if physically deleted [Caolán McNamara] + rhbz#650170# shutdown quickstarter at end of desktop session [David Tardon] + sb132: #i114155# use "en" as additional fallback locale after "en-US" [sb] + sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate existing extensions with bad .xcu content [sb] + libs-extern-sys: + fixed urllib.urlopen in the internal python (fdo#31466) [Petr Mladek] + libs-gui: + #i108584# workaround unexpected ATSUBreakLine error result [Herbert Duerr [hdu]] + #i115761# Impress freezes opening the attached odp file(s) [obo] + l10n: + Updated Bosnian (bs) translation #i115764# [Vedran Ljubović] + ure: + sb136: #i114155# partially revert fix for i108776 to avoid ABI incompatibility of jvmaccess library [sb] + writer: + Fix n#653526: Some section was added after having written the SEPX [Cédric Bosdonnat] + n#652204: Font color selection didn't effect new text [Cédric Bosdonnat] + n#652364: Fixed a ww8 column break import problem. [Cédric Bosdonnat] + Resolves: rhbz#657541# avoid null ptr. deref. when iterating through empty itemset [David Tardon] + build bits: + install branding for the welcome screen in the split build (bnc#653519) [Petr Mladek] + common: + tentative fix for fdo#30474# [Noel Power] + artwork: + Revert "nativeb: #i110796# changed document icons for Classic theme" [Thorsten Behrens] + bootstrap: + find the internal libpython (fdo#31764) [Petr Mladek] + build: + layouted zoom dialog was not localized (bnc#595823) [Petr Mladek] + reduce height of PDF export and recovery dialogs (bnc#623352) [Petr Mladek] + remove DataAccess.xcu in PostgreSQL SDBC Driver (i#113494) [Rene Engelhard] + components: + Resolves: rhbz#656191 Catch bad alloc and convert to ZipIOException [Caolán McNamara] + Resolves: rhbz#657628# divide by zero [Caolán McNamara] + show the control geometric propertis correctly (bnc#610921) [Petr Mladek] + show the really used default icon theme in options (bnc#603169) [Petr Mladek] + filters: + fix for n#648731 imagedata attribute not imported correctly [Noel Power] + Missing call to importDocumentProperties() n#655194 [Muthu Subramanian K] + libs-core: + Fix for i#115681 [Cédric Bosdonnat] + masterfix OOO330: #i115774# crash in FR version when typing / as first character [obo] + Related: rhbz#650170 don't crash when quickstarter is exited by user [David Tardon] + Resolves: fdo#31494# get ownership right [Caolán McNamara] + Resolves: rhbz#610103 exit quickstarter if physically deleted [Caolán McNamara] + rhbz#650170# shutdown quickstarter at end of desktop session [David Tardon] + sb132: #i114155# use "en" as additional fallback locale after "en-US" [sb] + sb136: #i115386# prefer en[-US] over empty xml:lang value, to accomodate existing extensions with bad .xcu content [sb] + libs-extern-sys: + fixed urllib.urlopen in the internal python (fdo#31466
Re: [Libreoffice] Release criteria
Petr Mladek wrote: > I like the idea about adding libreoffice@lists.freedesktop.org into CC > of the meta bug. IMHO, it is worth to have the discussion about blocker > bugs on the dev mailing list. Others might help to provide more details > if we are in doubts... > > Thorsten, Kendy, others, what do you think about it? > Great idea - I volunteer to setup a dummy account etc. if nobody objects, and Cc us here from that bug. Cheers, -- Thorsten pgpRknXfLUHDL.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report server problem
Hello, I reproduced the segmentation fault with the same file (blibs-gui/vcl/source/helper/canvasbitmap.cxx) by activating "enable=all" for cppcheck. I made a tracker on cppcheck (#2252 http://sourceforge.net/apps/trac/cppcheck/ticket/2252). Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Current state of the update of the build method
Hi Miklos, On 2010-11-29 at 14:13 +0100, Miklos Vajna wrote: > > So you propose to rename rawbuild to bootstrap, when the build-based > > method is used, right? As only the distro maintainers are the potential > > users for this, I am taking this to the ML; but I suppose nobody is > > going to be against that ;-) > > Sure - since distro builds don't use git, thus rawbuild is not used > there, AFAIK. :) Yes - but I'm double-cecking because Rene wanted to have this possibility preserved too, for the debug builds before the release [so that you can just commit (or pull) the stuff to clone/something/*, and do make]. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Crazy Ideas] Discuss "Replace regexp parser with std library"
Joe Smith wrote: > I've looked at the code a bit, and it seems like there is indeed only one > point > of contact with the rest of the suite, textsearch.cxx, which handles all types > of text searches (normal, regexp & fuzzy), and calls Regexpr::re_search(), > which > calls re_match2() to run the actual regexp match. > > So the structure makes it easy to replace the regexp code in one place. > > Unfortunately, the way the functions work does not match well with the Boost > RE > classes, although I'm sure it would be possible with an interface layer. > > For example, the Boost engine handles locale-specific issues internally, > whereas > OOo's engine knows almost nothing about character case or multi-character > sequences. Instead, it preps the text to be searched by running it through a > filter. I don't understand the i18n & character encoding issues well enough to > guess what that filter is actually doing or how it should be handled. > Hi Joe, hm - then I think a combination of those two approaches might be a winning strategy - LibO uses icu for all those nifty transliteration stuff & what not. I notice that newer boost versions also optionally support icu, maybe that already gives us good enough coverage - I'd be tempted to just give it a whirl, and add it as an optional, experimental feature to have people play with it. Cheers, -- Thorsten pgp8DTxCj9okj.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Current state of the update of the build method
On Mon, Nov 29, 2010 at 01:39:22PM +0100, Jan Holesovsky wrote: > So you propose to rename rawbuild to bootstrap, when the build-based > method is used, right? As only the distro maintainers are the potential > users for this, I am taking this to the ML; but I suppose nobody is > going to be against that ;-) Sure - since distro builds don't use git, thus rawbuild is not used there, AFAIK. :) pgpqwK6XmPZ1y.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Current state of the update of the build method
Hi Norbert, On 2010-11-27 at 18:50 -0600, Norbert Thiebaud wrote: > 18:25:23 shm_get kendy: I pushed a new branch: merging the work we did > on your branch + stuff the integrate with the build repo > 18:26:18 shm_get kendy: we I did not feel confident enough to push > directly to master... there are few migration path... not all > tested... and mishap on master would have crippled everybody for good > :-) > 18:26:51 shm_get kendy: branche name: feature/bootstrap-build > 18:27:31 shm_get s/branche/branch/ (forgive my franglish :-) ) :-) Thank you! I did some minor tweaks there, to exit 1 if post_download is not created, or if it fails, but works great :-) > 18:30:45 shm_get kendy: I still have to find a trick to trigger the > display of a message telling people that they HAVE to augogen/download > after the git pull that will bring these changes > 18:34:03 shm_get kendy: the idea is: in the build/download -> if clone > is here but not bootstrap => move clone/bootstrap to bootstrap and > clone to bootstrap/clone, then call a script that create the missing > link in bootstrap. if clone is not there (fresh clone of build) clone > bootstrap in bootstrap and then call bootstrap/g clone. either way > after that rawbuild = bootstrap So you propose to rename rawbuild to bootstrap, when the build-based method is used, right? As only the distro maintainers are the potential users for this, I am taking this to the ML; but I suppose nobody is going to be against that ;-) Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] faster stl prefix iterators ...
On Mon, 2010-11-29 at 10:34 +, Michael Meeks wrote: > Oh nice; not something I had noticed. Can we do a big global hunt & fix > for all these instances ? cppcheck lists these for us, hmm, at least cppcheck *was* listing them for us. Until very recently http://libreoffice.boldandbusted.com/ had a big list of them, they seems to have disappeared though. Doubt we fixed them all in the last two days :-) That's the way to go anyway, grab the entire class from cppcheck output and fix them all in one or two fell swoops. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Yi Fan Jiang píše v So 27. 11. 2010 v 19:07 -0700: > Hi Petr, > > The blocker criteria would be quite useful ;-) Thank you! > > For the process to nominate a blocker, is there a specific reason to > report a nomination > twice (1 in mailing list, 2 in bugzilla)? > > > > > You may nominate blocker bugs using the libreoffice mailing list. > Please use the subject: > > Nominating bug as blocker for LibO-X.Y.Z release > > You should also add a dependency to the meta bug: > > * LibO-3.3 - bug #31865 > > > A potential problem of the twice nominating is reporter may forget to > do another process > after finishing one step. e.g. what if he/she only sends a mail and > forget comment on Bugzilla? > Then more documentation effort will be needed to keep 2 sets of > information 'sync'. > > A uniform reporting path might make it more manageable. Can we just > add libreoffice > mailing list to a CC list of the meta bug or something like that. > Since the release version > is included in the Meta bug title, we would not be likely missing new > blocker information > in the mailing list. For the detailed bug list, we just need to check > the dependency fields > by clicking meta bug URL inside the mail. I like the idea about adding libreoffice@lists.freedesktop.org into CC of the meta bug. IMHO, it is worth to have the discussion about blocker bugs on the dev mailing list. Others might help to provide more details if we are in doubts... Thorsten, Kendy, others, what do you think about it? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] occured occurred
On Sat, 2010-11-27 at 02:20 +0900, Takeshi Abe wrote: > During the Easy Hacking, I have enjoyed ton of "occured" occurred and > some occurrences of "occurance" in the code base. > Why not come and join with `git grep -i occured` if you get tired of > working hard in a miserable world ;) > > Well, seriously, it seems needed to find a systematic way to cope with them. :-) I guess an 'easy hack' ? I guess we should perhaps grok for german variable names too, and rename them in cases like this: sc/source/core/tool/interpr2.cxx:double nErsteAbRate = nWert * nAbRate * nMonate / 12.0; Though, it's not that clear to me how to find them easily. :-) Michael; -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Release criteria
Hi there, On Sat, 2010-11-27 at 06:57 +0100, Jean-Baptiste Faure wrote: > > So - I tend to think that time will tell if we need to change this. The > > seven day period seems long to me. > > Seven days is a not so long period when you have to organize manual testing. > As you can see with OOo 3.3.0 the last stoppers have been found by Sure :-) but what concerns me is the reset of seven days with no bug; so we find one bug, and we then reset the seven days of testing when we have included only a trivial fix ? if so, that seems like wasted time to me. There comes a point when the negatives (of holding back all the improvements and bug fixes in the new release) outweigh the positives of waiting until it is perfect :-) Having a hard rule of no blocker bug for seven days after the last RC seems to ~ignore the other half of that balance. > Perhaps, if micro releases are really only bug fix. > But that need to be clearly explained to the users and sys-admin in > charge of deployment of LibO. True. > It is very important that the user installing the next release of LibO > can say: Oh there is less bug in LibO than in ... Heh - and of course we have to be careful about that. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)
Hi Peter, On Fri, 2010-11-26 at 19:15 +0100, Peter Lairo wrote: > Well, in the English version, unfortunately they are not localized. It's > kinda ironic. We are stuck with A A A (which isn't even an interesting > acronym: "American Automobile Association"). Again; if you can spend the time necessary to make new icons with those B I U symbols in them [ presumably cut/paste of some existing anti-aliased text of the right size into them might do it ], that looks consistent with what was there ... Then we will include them happily :-) Surely that is a task that even a user with only a basic grasp of icon design / gimp usage can take on: it is easy to complain that no-one -else- spent the hour or two necessary to fix it - it is more inspiring to actually fix it & rest assured we will include your work. For extra browny points, writing an arbitrary renderer that can super-pose right-sized characters for other languages, so we get Tor's stuff [ which I suspect is some F K U abomination fallen-back from the 'default_icons' theme ] gets browny points. I attach the source images to work with, Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot icons.tgz Description: application/compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] getting LO into debian
On Sat, 2010-11-27 at 17:29 +, Andrew wrote: > I wouldn't worry about it getting into Ubuntu. At UDS it was confirmed > that LibreOffice would be in the default install, as well as Mark > Shuttleworth saying it would replace OpenOffice. And - I guess more positively; we have high hopes and hopeful signs that Canonical will hire a full-time LibreOffice hacker to do some really positive work; so - if we forget the past quickly ;-) the future looks bright (orange) ? :-) Of course, the fact is, as of now, that the whole Debian' universe' packaging is all Rene's work (built on Chris Halls' and of course a lot of common effort we've put into OO.o packaging over many years collectively). ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] faster stl prefix iterators ...
On Sat, 2010-11-27 at 21:02 +, Caolán McNamara wrote: > As Takeshi pointed out in another mail, the postfix form returns a copy > of the iterator as it was before the increment, while the prefix form > returns a reference to the current value after its increment. So postfix > requires an extra copy which makes it inherently slower. Oh nice; not something I had noticed. Can we do a big global hunt & fix for all these instances ? > I'm not so sure that compilers can optimize STL postfix operators with > the ease they do for basic types. Their implementation differs quite a > bit from one impl to another. Quite; optimising LO's C++ is quite excitingly limited in many ways (often by the low-level C API impls eg.). > Anyway, I reckon its worth tackling the cppcheck warnings about the > postfix operator being used where a prefix would suffice. Yes - would be wonderful to have a "fix this entire class of problem" approach to the code-base; to win the performance & size improvement everywhere - and to make the patch easy to review too I guess ;-) Interesting, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libreoffice3.3-freedesktop-menus-3.3.1.noarch.rpm - what distri is this for
On Sun, 2010-11-28 at 01:36 +0100, Christian Lohmaier wrote: > That is my "baby" :-) - it is for all distros that support the > freedesktop specifications/recommendations. Nice work :-) > Nowadays more or less every distro follows them/supports them, so that > one should be usable on any distro. I wonder if we should deprecate the generic builds' per-distro stuff then ? we have enough confusing legacy baggage to drag around without that :-) > The freedesktop.org specifications/proposal did standardize this to > some well known paths and utilities to update that info. Thoughts ? perhaps we could try it for the 3.4 version and see if anyone screams ? ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] profiling & optimising ...
Hi Jonathan, On Mon, 2010-11-29 at 07:41 +0100, Jonathan Aquilina wrote: > Funny you post this on the list i was asking about optimization of LO in > irc the other day. Great ;-) the more minds we have on the problem the better I think. > Thanks for this interesting read :) My pleasure - we should prolly whack that in the wiki somewhere in some prettier form: much appreciated if you can do it :-) Personally, I think one of the more major perceptual wins we can get is this: http://wiki.documentfoundation.org/Development/Easy_Hacks#Snappier_rendering:_paint_at_idle.2C_not_on_timeout I suspect (not proved of course), that these timeouts can cause unpleasant visual artifacts, and multi-step rendering which looks unpleasant on Linux at least. Strangely people tend to believe something is faster if it appears later, but as one piece :-) It would be great to have someone to experiment with the idle concept there. And/or to track down quite how many paint / resize / etc. timeouts we take when starting up and rendering the screen the first time :-) [ cf. also the appear/change disabling / enabling toolbar icons on first launch that is some silly ordering problem ]. Then again - looking at this just now, perhaps this is less bad than it was (or perhaps my machine just got faster - who knows ;-) Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
