[Libreoffice] A file to show 8192 discontinuities crashes Calc

[r_ouellette]

I often use a file to show that Calc doesn't have the 8192 discontinuities
limit as in Excel (see
http://smurfonspreadsheets.wordpress.com/2007/04/30/1-million-rows/). Until
OOo 3.2.1 I can use my example file, with OOo 3.3RCx and now LibreOffice 3.3
Calc crashes.

As I can't join my example file, here is how to create it:

In A1 put Number;
In B1 put Even or Odd;
>From A2 to A20481 put the numbers from 1 to 20480 (use automatic fill);
>From B2 to B20481 put 1 if the facing number in column A is even, put 2 if
it is
odd (use copy/paste to do it);
Use Automatic filter so that you can select even or odd (2 or 1) from column
2.

This file never crashes OOo Calc before 3.3. You can use the same file in
Excel
and try to select only the even or the odd numbers and do a copy/paste
action.
It won't work, a weird message giving the user the impression that the
problem
comes from him will appear (typical Microsoft message).

Calc 3.3 will freeze forever with this file set to use even or odd numbers
only,
you need to kill the process. I tested this behaviour in Ubuntu Linux
10.04.1 64
bits and in win XP SP3 (at the office). To be honest, I also checked
OpenOffice.org
Calc 3.3RC8 in Ubuntu Linux 10.04.1 64 bits and the same behaviour occurred.
-- 
View this message in context: 
http://nabble.documentfoundation.org/A-file-to-show-8192-discontinuities-crashes-Calc-tp2135015p2135015.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [l10n]Pootle permission request

[Kohei Yoshida]

I'll forward this to the l10n list which I believe is the right list for
this sort of request.

Kohei

On Thu, 2010-12-23 at 00:34 +, Seung Soo, Ha wrote:
> Hello.
> 
> I previously translated and uploaded a .po file for LO before, but found it 
> to 
> be too difficult for me and I did not follow through.
> 
> Recently I learned that LO had configured Pootle and I found it to be 
> quite usable.
> 
> To resume my contribution to LO , I request the necessary 
> Pootle translation privileges.
> 
> My pootle ID is : sungsuha
> 
> 
> Any and all work that I've done, or will do for Libreoffice is under
> LGPLv3+, MPL 
> or any other license that "The Document Foundation" finds appropriate.
> 
> (Am I doing this wrong?)
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Request review for 3.3

[Kohei Yoshida]

Hi there,

Just fixed the following bug on master

https://bugs.freedesktop.org/show_bug.cgi?id=32523

The fix was rather simple, as this commit shows

http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=90c9dcfde572f227eae0760066af5b8a9d5d9218

However, not fixing this may cause some hard to detect bugs somewhere
else especially when the language is not English.  So, I feel *strongly*
that we need to port this to 3.3.

SvNumberFormatter has many methods that take a language as an argument,
with the default value of LANGUAGE_DONTKNOW when the language is not
specified.  All such methods switch the language back to the initial
language when the language is LANGUAGE_DONTKNOW, except for one method.
And calling that method without specifying the language carries the
default language value of DONTKNOW, which internally switches the
language to English!  We don't want this especially in non-English
locales.

This mostly affects csv imports, but a quick scanning of the code shows
that there are several other places where this method is called without
the language specified.  So, this bug may be causing some weird number
recognition bugs somewhere especially in non-English locales.

I would appreciate someone reviewing the change and giving me a
sign-off.

Thanks,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [l10n]Pootle permission request

[Seung Soo , Ha]

Hello.

I previously translated and uploaded a .po file for LO before, but found it to 
be too difficult for me and I did not follow through.

Recently I learned that LO had configured Pootle and I found it to be 
quite usable.

To resume my contribution to LO , I request the necessary 
Pootle translation privileges.

My pootle ID is : sungsuha


Any and all work that I've done, or will do for Libreoffice is under
LGPLv3+, MPL 
or any other license that "The Document Foundation" finds appropriate.

(Am I doing this wrong?)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] format inspector (Was : Re: sw: numbering misbehaviour)

[Wols Lists]

On 23/12/10 00:07, Philipp Weissenbacher wrote:
> May I point you to the crazy idea "Add WordPerfect features like
> RevealCodes and HiddenText" [1]

Actually, it was me that added that to the wiki page :-)

> Also see the therein referenced OOo bug. It's been requested in 2002
> and always dismissed with the answer "learn to use styles" *sigh*.

But I didn't know about that OOo bug. I'll need to learn styles, but
yes, *me* learning styles is totally useless when it's *someone* *else*
who's messed up *their* document (and expects me to fix it for them).

Plus, I expect I may well soon be teaching people to word process. I
shall almost certainly be running WordPerfect under Wine, and making
them use reveal codes. Yep - WordPerfect 6.1 for Win 3.1, but imho the
pre-Corel-rewrite versions of WP are pretty much the best word processor
ever :-)

> Just my 2 cents.

And my tuppence.

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

[Octavio Alvarez]

On Wed, 22 Dec 2010 14:36:57 -0800, Cor Nouws  wrote:


And the contrary:
- user has some data, that is known to be updated,
- opens a file that uses the data and wants to update it immediately.
Isn't that how the dialog is meant to be used?


What is the point of the dialog, if he STILL has to click "yes"?

If he already knows he wants to update immediately and he still has
to take action to manually choose "yes", it is not more difficult
to click on a toolbar button named "Update all links" or to set up
a key combination for that, after the document has loaded.

It is a usability issue, not a functionality issue.

OTOH, the dialog blocks a user from opening a file and forces him to
make a decision he might not know at all at the moment. The document
isn't even displayed before the dialog shows up. It's a decision to
be taken completely in the blind.

The only case where the dialog would be useful is to prevent the user
from forgetting to update links, but there are (or may be) other ways
to accomplish this without obstructing file loading.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Change of the color of the watermark at the pdfexport

[Andrea Pescetti]

Cor Nouws wrote:
> The same applies of course for the default colors of Impress tables, 
> that were changed recently.

This seems a different situation: you can change the color of a table if
the default does not suit your needs, so if you want blue tables
(default in OpenOffice.org) you can perfectly recolor a gray table
(default in LibreOffice) via UI; but, provided I understood Andreas'
remarks correctly, in this case you cannot change the watermark color
via UI or even via command-line, since its value is hardcoded in the
source and cannot be changed by the user.

Regards,
  Andrea.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] format inspector (Was : Re: sw: numbering misbehaviour)

[Philipp Weissenbacher]

May I point you to the crazy idea "Add WordPerfect features like
RevealCodes and HiddenText" [1]

Also see the therein referenced OOo bug. It's been requested in 2002
and always dismissed with the answer "learn to use styles" *sigh*.

Just my 2 cents.

Philipp

[1] 
http://wiki.documentfoundation.org/Development/Crazy_Ideas#Add_WordPerfect_features_like_RevealCodes_and_HiddenText

On 23 December 2010 00:05, Wols Lists  wrote:
> On 22/12/10 22:02, Cor Nouws wrote:
>> I do not so much believe in the old WP-style of 'reveal formatting'
>> since I know OOo.
>> As a style addict, and knowing where to find Ctrl-M, it's easy to
>> tackle most...
>> Said that, indeed a (new style) pop-up to show
>>  - para style
>>  - char. style
>>  - direct (hard) formatting
>> would be useful, at least for many users.
>
> "Since I know OOo".
>
> That is a MAJOR point. One of my biggest problems with Word (and Writer,
> but less so) is "what the hell happened!?"
>
> Given *someone* *else* screwing up, with WordPerfect and Reveal Codes,
> it takes me moments to find out what happened, and not much longer to
> fix it. That's even when they've managed to use WordPerfect in ways I
> know nothing about.
>
> The whole point of Reveal Codes, is it tells me *what* WP is doing,
> *and* *why*. I have major problems doing that in Word. I haven't used
> Writer enough to come to that conclusion, but I find Word and Writer far
> too similar for comfort ... at least Writer is less inclined ime to "do
> its own thing".
>
> Cheers,
> Wol
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] format inspector (Was : Re: sw: numbering misbehaviour)

[Wols Lists]

On 22/12/10 22:02, Cor Nouws wrote:
> I do not so much believe in the old WP-style of 'reveal formatting'
> since I know OOo.
> As a style addict, and knowing where to find Ctrl-M, it's easy to
> tackle most...
> Said that, indeed a (new style) pop-up to show
>  - para style
>  - char. style
>  - direct (hard) formatting
> would be useful, at least for many users. 

"Since I know OOo".

That is a MAJOR point. One of my biggest problems with Word (and Writer,
but less so) is "what the hell happened!?"

Given *someone* *else* screwing up, with WordPerfect and Reveal Codes,
it takes me moments to find out what happened, and not much longer to
fix it. That's even when they've managed to use WordPerfect in ways I
know nothing about.

The whole point of Reveal Codes, is it tells me *what* WP is doing,
*and* *why*. I have major problems doing that in Word. I haven't used
Writer enough to come to that conclusion, but I find Word and Writer far
too similar for comfort ... at least Writer is less inclined ime to "do
its own thing".

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

[Christoph Noack]

Hi Kohei, hi Joe, all!

Am Mittwoch, den 22.12.2010, 15:11 -0500 schrieb Kohei Yoshida:
> On Wed, 2010-12-22 at 13:06 -0500, Joe Smith wrote:
> > On 12/21/2010 12:09 PM, Jan Holesovsky wrote:
> > > Hi,
> > >
> > > https://bugs.freedesktop.org/show_bug.cgi?id=32548
> > >
> > > The bug says: when I open a certain .odp document, I get a pop-up
> > > question asking "Update all links? Yes/No"
> > >
> > > Anybody who knows this functionality, can you please provide a better
> > > wording? ;-)  Just post it here, I'll integrate it.
> > >
> > > Thank you a lot,
> > > Kendy
> > 
> > Believe me, I'm no fan of this cryptic prompt, but I'm afraid this won't 
> > be an improvement. The wording of the prompt is not the primary problem.
> 
> I'm not sure if I agree with that view.  This *will* be an improvement,
> and although the wording alone will not be enough to fix this
> *completely*, improving the wording itself is a step in the right
> direction.

+1

> > Experts already know what "Update links?" means; non-experts will not 
> > understand enough to answer the question correctly even with improved 
> > wording.
> 
> I disagree here.  You tend to polarize the users as either experts or
> non-experts.  There are those in between who want to make an informed
> decision and will understand the verbiage.  The user who reported the
> above bug is one such example.

Let's assume that we do have a so called "non-expert" here - since we
offer a modal dialog, what will he do with the current dialog? There is
no escape, he is forced to make an uninformed decision.

That is (one) reason why the proposed dialog contains a "[Keep]" button
that sounds somehow safe to click at - in any case.

> > All we accomplish by changing the wording is to make everyone 
> > read and deal with a longer and more complicated (and common!) 
> 
> No, making the warning verbose does not "make everyone read and deal
> with it".  Those who ignore such warnings will continue to ignore it
> just as easily even with a longer warning.
> 
> And the new wordings proposed so far are not even that long.

To the initial statement "everyone read and deal with a longer ...".
That is incorrect, as long as you refer to the text only. A dialog
provides some more ways to add information. As I said before, more
advanced users will benefit from the new buttons and the new dialog
title.

Moreover, such dialogs tend to be like words in the end - you don't read
the text, once you've memorized the dialog you guess based on the known
shape and overall appearance.

[...]

> > Would it be possible to have the prompt remain as it is, with a "Help" 
> > or "More" button that leads to some expanded explanation?

Given the fact that the "More" button might only show some few lines of
text - what does that additional click help?

But, you are right, that OOo/LibO has some of the most awkward dialog
concepts we can find today ... but let's first listen to Kohei.

> Relying on help for everything is a recipe for making poor UI.  Help is
> a last resort, and we need to do our best to design UI so that the user
> won't have to rely on Help.  In some situations we do need to rely on
> help to convey some complex scenarios to the user, but I don't think
> updating external links is one such example.
> 
> One thing I may agree is that maybe we need to have a two-level warning
> system that displays a summary of the warning, and the "Detail" button
> to show more information.  But we don't have such dialog implemented yet
> (feel free to correct me here), and until we do I would favor showing a
> more verbose and informative warning message than the current terse
> message that leaves some users confused and clueless.

Please look at "3.4.1 Alert Text" in the Gnome HIG:
http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-text

Since the Gnome guys are known for good usability, let's assume that
this dialog design is well proven. There is:
  * Icon (not important, here)
  * Primary text (large size)
  * Secondary text (small size)
  * Buttons (might use custom caption)

This is a design we might go for - but technically, this hasn't been
possible in the past. There has been a discussion on OOo ux-discuss (but
I don't find the original message), where we added some additional text
within the dialog. A bad solution, but less bad than not addressing the
problem ...

So - if possible - please let's smoothly transition to that kind of
dialog content in the future. Although this will be hard for the
translation, because some of their translation memory won't work (since
there are more individual strings).

But Joe, you talked about the perfect solution - of course we may head
towards an ideal world in several steps. Ideally, Calc would
automatically detect whether the external data resources are available
and if they perform well. If yes, then Calc will automatically update
the data - and the user won't even notice that. If there are problems,
then the

Re: [Libreoffice] Better wording for 'Update links' question

[Cor Nouws]

Octavio Alvarez wrote (22-12-10 23:24)

On Wed, 22 Dec 2010 12:11:29 -0800, Kohei Yoshida 
wrote:

On Wed, 2010-12-22 at 13:06 -0500, Joe Smith wrote:

Experts already know what "Update links?" means; non-experts will not
understand enough to answer the question correctly even with improved
wording.


I disagree here. You tend to polarize the users as either experts or
non-experts. There are those in between who want to make an informed
decision and will understand the verbiage. The user who reported the
above bug is one such example.


Is it possible to remove the dialog? I think I prefer not to have
anything automatically updated and have a menu item to update it.


Doesn't the dialog offer the choice to update or not?


Rationale:
[1] if data is there and it's the same, it doesn't make sense to update.
[2] if data is not there, it doesn't make sense to update.
[3] if data is there and differs, the only way to see the old data is
to hit "no".


And the contrary:
- user has some data, that is known to be updated,
- opens a file that uses the data and wants to update it immediately.
Isn't that how the dialog is meant to be used?


Now, how would users be able to refresh links? Through a menu item.

Of course, users should be notified that there is existing external
resources. If LibO can notify that external resources have changed,
it would be even better.


Best,
Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ixion breakage in sw

[Petr Mladek]

Henrik /KaarPoSoft píše v Út 16. 11. 2010 v 12:23 +0100:
> Dear all,
> 
> I am trying to build libreoffice 3.2.99.3
> 
> In sw/util when making libswli.so I get:
> 
> ../unxlngi6.pro/slo/cellfml.o: In function `lcl_ConvertWWFormula(String 
> const&)':
> cellfml.cxx:(.text+0x29c4): undefined reference to 
> `ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, _STL::allocator >&)'
> cellfml.cxx:(.text+0x2a13): undefined reference to 
> `ixion::formula_parser::formula_parser(boost::ptr_vector  
> boost::heap_clone_allocator, _STL::allocator > const&, 
> boost::ptr_map<_STL::basic_string, 
> _STL::allocator >, ixion::base_cell, 
> _STL::less<_STL::basic_string, 
> _STL::allocator > >, boost::heap_clone_allocator, 
> _STL::allocator<_STL::pair<_STL::basic_string _STL::char_traits, _STL::allocator > const, void*> > >*, bool)'
> 
> Re-building with VERBOSE=true confirms that the ixion library is 
> included in the g++ command: -lixion-0.2
> 
> However:
> nm -C solver/330/unxlngi6.pro/lib/libixion-0.2.a | grep 
> formula_lexer::swap_tokens
> Gives:
> 0ec4 T 
> ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, std::allocator >&)
>   U 
> ixion::formula_lexer::swap_tokens(boost::ptr_vector boost::heap_clone_allocator, std::allocator >&)

I wonder if it might be related to stlport. I see the same problem on
SLED10 where I have the stlport enabled. I do not see it on SLED11 where
I compile without stlport.

The symbol in libixion-0.2.a has "std::allocator".
cellfml.o wants to use _STL::allocator

ixion is compiled without STL; cellfml.o is compiled with STL;

I have tried to compile ixion with STL but I got many error; hmm, it
will need more love.

Cedric, Kohei, do you suggest anything?


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

[Octavio Alvarez]

On Wed, 22 Dec 2010 12:11:29 -0800, Kohei Yoshida   
wrote:

On Wed, 2010-12-22 at 13:06 -0500, Joe Smith wrote:

Experts already know what "Update links?" means; non-experts will not
understand enough to answer the question correctly even with improved
wording.


I disagree here.  You tend to polarize the users as either experts or
non-experts.  There are those in between who want to make an informed
decision and will understand the verbiage.  The user who reported the
above bug is one such example.


Is it possible to remove the dialog? I think I prefer not to have
anything automatically updated and have a menu item to update it.

Rationale:
[1] if data is there and it's the same, it doesn't make sense to update.
[2] if data is not there, it doesn't make sense to update.
[3] if data is there and differs, the only way to see the old data is
to hit "no".

Now, how would users be able to refresh links? Through a menu item.

Of course, users should be notified that there is existing external
resources. If LibO can notify that external resources have changed,
it would be even better.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] format inspector (Was : Re: sw: numbering misbehaviour)

[Cor Nouws]

Caolán McNamara wrote (21-12-10 21:17)

On Tue, 2010-12-21 at 19:59 +, Wols Lists wrote:

Seeing as LO is based on XML as the document format it should be easy -
all "reveal codes" is is a window with text and all the markup visible.


The thing is that, while the file format is XML, the file format doesn't
bear that much relationship to how the application actually
store/applies properties. There aren't actual codes embedded in the
strings whose display can be toggled on or off, so something like that
would require faking it all up.

On the other hand there's definitely a lot to be said for something like
a "format inspector" which describes from where and why something is
formatted like it is.


I do not so much believe in the old WP-style of 'reveal formatting' 
since I know OOo.
As a style addict, and knowing where to find Ctrl-M, it's easy to tackle 
most...

Said that, indeed a (new style) pop-up to show
 - para style
 - char. style
 - direct (hard) formatting
would be useful, at least for many users.

Making this as an extension is not that difficult. (It might even exist 
already?)
Thinking about adding it to the core code (which is way beyond my 
competences) I would say the the format paintbrush will have some 
interesting code to re-use ;-)


Best,
Cor


--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part 3

[Caolán McNamara]

On Wed, 2010-12-22 at 22:22 +0100, Julien Nabet wrote:
> Hello,
> 
> Here is a patch for some files.

Looks good, committed locally and I'll push globally when my build
completes just to double check this.

> 
> there's still this :
> writer/sw/inc/unomid.h:#define C2U(cChar) 
> rtl::OUString::createFromAscii( cChar )
> 
> There a lot of files that use this macro.
> Could you give details about this part of your last message ? (how do 
> you do this)
> 
> after passing a build with the SAL_N_ELEMENTS as compile-time test

If you've got >= gcc 4.5.1 then automatically some C++0x are used to
force a compile error if you do RTL_CONSTASCII_USTRINGPARAM(pPointer)
where pPointer is e.g. char *pPointer="foo"; grep for SAL_N_ELEMENTS in
rtl/inc to see the test.

You could force this on in solenv/inc/unxgcc.mk (see HAVE_CXX0X) for
older gcc versions, all that goes wrong is that there are some false
positives here and there for some special edge cases that don't affect
RTL_CONSTASCII_USTRINGPARAM itself. So you could build everything
normally, hack the unxgcc.mk, tweak the defines in sw to assume its
const and just build and fix the ones that break.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Change of the color of the watermark at the pdfexport

[Cor Nouws]

Hi *,

Andreas Mantke wrote (22-12-10 17:52)

Am Dienstag, 21. Dezember 2010, 23:01:13 schrieb Andrea Pescetti:

(...)

Take this just as a comment and not criticism (I congratulate with
Andreas too for his first patch!), but replacing a hard-coded value by
another hard-coded value on the basis that, more or less, "Green is
nicer and it matches the LibreOffice official color" seems a bit weak to
me.


I did the change because the former color (red) caused problems in reading the
document.
Your point about a configurable color is valuable, but I think that is not an 
easy
hack. I'll think about a way. Maybe someone is faster then I ;-)


The same applies of course for the default colors of Impress tables, 
that were changed recently.
If not via the UI, some xcu file (or sog?) would be at least a start to 
make it configurable (for those 'brave' enough to change those files).



Best - Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Status of PDF export of docs containing EPS graphics

[Jean-Baptiste Faure]

Le 22/12/2010 22:17, Caolán McNamara a écrit :
> On Wed, 2010-12-22 at 21:42 +0100, Jean-Baptiste Faure wrote:
>> Hi,
>>
>> Could someone clarify the status of the PDF export of docs containing
>> EPS graphics. Is there some difference with OOo 3.3.0 regarding issue
>> 14163 : http://www.openoffice.org/issues/show_bug.cgi?id=14163 ?
> The situation is currently unchanged AFAIK. There was at some stage some
> Adobe guys interested in OpenOffice.org who mentioned in passing that it
> would be trivial to do it, but I guess, like all these things, someone
> with an interest in it needs to take it up and actually implement it.
Ok, I see. :-)
> Do you want to have a go at it ?
I am afraid I have to learn C++ before. I doubt my skills in Fortran and
Java are useful here. :-(

Thank you for your answer.

Best regards
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Request for review

[Kohei Yoshida]

On Wed, 2010-12-22 at 20:55 +, Caolán McNamara wrote:
> On Wed, 2010-12-22 at 12:39 -0500, Kohei Yoshida wrote:
> > I feel confident that this change won't introduce any regressions.
> > Could someone review this and give me a sign-off?
> 
> Well, I think this is good anyway. Go for it I reckon, though I'm
> somewhat biased :-)

Thanks!  I've cherry-picked the relevant commits (two of them) to
libreoffice-3-3.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part 3

[Julien Nabet]

Hello,

Here is a patch for some files.

(LGPLv3+ / MPL)

Caolán: there's still this :
writer/sw/inc/unomid.h:#define C2U(cChar) 
rtl::OUString::createFromAscii( cChar )


There a lot of files that use this macro.
Could you give details about this part of your last message ? (how do 
you do this)


after passing a build with the SAL_N_ELEMENTS
as compile-time test

Thank you in advance.

Julien
commit 5576e38145fc8a4f34e3a435986e9b562ac2a49b
Author: serval 
Date:   Wed Dec 22 22:14:03 2010 +0100

RTL_CONSTASCII_USTRINGPARAM

diff --git a/linguistic/inc/misc.hxx b/linguistic/inc/misc.hxx
index e28a4f1..5853e81 100644
--- a/linguistic/inc/misc.hxx
+++ b/linguistic/inc/misc.hxx
@@ -77,7 +77,7 @@ namespace linguistic
 {
 
 // ascii to OUString conversion
-#define A2OU(x) ::rtl::OUString::createFromAscii( x )
+#define A2OU(x) ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( x ))
 
 /// Flags to be used with the multi-path related functions
 /// @see GetDictionaryPaths, GetLinguisticPaths
diff --git a/linguistic/source/iprcache.cxx b/linguistic/source/iprcache.cxx
index f831505..185e1e7 100644
--- a/linguistic/source/iprcache.cxx
+++ b/linguistic/source/iprcache.cxx
@@ -100,7 +100,7 @@ static void lcl_AddAsPropertyChangeListener(
 for (int i = 0;  i < NUM_FLUSH_PROPS;  ++i)
 {
 rPropSet->addPropertyChangeListener( 
-A2OU(aFlushProperties[i].pPropName), xListener );
+
::rtl::OUString::createFromAscii(aFlushProperties[i].pPropName), xListener );
 }
 }
 }
@@ -115,7 +115,7 @@ static void lcl_RemoveAsPropertyChangeListener(
 for (int i = 0;  i < NUM_FLUSH_PROPS;  ++i)
 {
 rPropSet->removePropertyChangeListener( 
-A2OU(aFlushProperties[i].pPropName), xListener );
+
::rtl::OUString::createFromAscii(aFlushProperties[i].pPropName), xListener );
 }
 }
 }
diff --git a/linguistic/source/lngprophelp.cxx 
b/linguistic/source/lngprophelp.cxx
index 5ccd55c..5a81077 100644
--- a/linguistic/source/lngprophelp.cxx
+++ b/linguistic/source/lngprophelp.cxx
@@ -82,7 +82,7 @@ PropertyChgHelper::PropertyChgHelper(
 OUString *pName = aPropNames.getArray();
 for (INT32 i = 0;  i < nCHCount;  ++i)
 {
-pName[i] = A2OU( aCH[i] );
+pName[i] = ::rtl::OUString::createFromAscii( aCH[i] );
 }
 
 SetDefaultValues();
@@ -119,7 +119,8 @@ void PropertyChgHelper::AddPropNames( const char 
*pNewNames[], INT32 nCount )
 OUString *pName = GetPropNames().getArray();
 for (INT32 i = 0;  i < nCount;  ++i)
 {
-pName[ nLen + i ] = A2OU( pNewNames[ i ] );
+pName[ nLen + i ] = ::rtl::OUString::createFromAscii( pNewNames[ i 
] );
+
 }
 }
 }
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 4b32b4d..a46918c 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -1653,7 +1653,7 @@ BOOL LngSvcMgr::SaveCfgSvcs( const String &rServiceName )
 {
 DBG_ASSERT( 0, "node name missing" );
 }
-OUString aNodeName( A2OU(pNodeName) );
+OUString aNodeName( ::rtl::OUString::createFromAscii(pNodeName) );
 
 for (INT32 i = 0;  i < nLen;  ++i)
 {
diff --git a/linguistic/source/misc.cxx b/linguistic/source/misc.cxx
index edfdaac..a107d7f 100644
--- a/linguistic/source/misc.cxx
+++ b/linguistic/source/misc.cxx
@@ -892,7 +892,7 @@ uno::Reference< XInterface > GetOneInstanceService( const 
char *pServiceName )
 {
 try
 {
-xRef = xMgr->createInstance( A2OU( pServiceName ) );
+xRef = xMgr->createInstance( ::rtl::OUString::createFromAscii( 
pServiceName ) );
 }
 catch (uno::Exception &)
 {
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part2

[Caolán McNamara]

On Wed, 2010-12-22 at 21:58 +0100, Julien Nabet wrote:
> Hello,
> 
> Here is a patch for some files

Looks good. Pushed, thanks for this.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Status of PDF export of docs containing EPS graphics

[Caolán McNamara]

On Wed, 2010-12-22 at 21:42 +0100, Jean-Baptiste Faure wrote:
> Hi,
> 
> Could someone clarify the status of the PDF export of docs containing
> EPS graphics. Is there some difference with OOo 3.3.0 regarding issue
> 14163 : http://www.openoffice.org/issues/show_bug.cgi?id=14163 ?

The situation is currently unchanged AFAIK. There was at some stage some
Adobe guys interested in OpenOffice.org who mentioned in passing that it
would be trivial to do it, but I guess, like all these things, someone
with an interest in it needs to take it up and actually implement it.

Do you want to have a go at it ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Suggestion for Windows building

[Caolán McNamara]

On Wed, 2010-12-22 at 20:57 +0100, Julien Nabet wrote:

> 2) mesa headers not found.
> I installed all the packages (bin and sources) except demo proposed by 
> cygwin. I searched on Google, nothing.
> Then I added --without-system-mesa-headers

This one, at least, is really a bug, which we've now fixed as of a few
hours ago. I hope so anyway, assuming we didn't break anything else :-)

> If anybody who knows the whole process for Windows would have some time 
> to give details in the wiki, it would be great !
> If this person has little time, just give some hints please ! :-)

Tor has done loads of earlier work to try and get more stuff
auto-configured, i.e. see the oowintool

I don't really build under windows, but I did have a go recently, and
tried to add some auto-magickery to make it a little easier to get some
of the prerequisites installed, i.e. see the "WNT" section of the
download script.

So, while I haven't actually a clue how to get the bits that aren't
working for you actually configured myself :-), the route to go would be
for someone that does know to try and tweak the build to
find/download/configure them automatically as best as possible.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Easy Hacks] Creating OUString

[Caolán McNamara]

On Wed, 2010-12-22 at 20:14 +0100, Guillaume Poussel wrote:
> Hi all,
> 
> I have had a look on the "Use RTL_CONSTASCII_USTRINGPARAM macro" task.
> Lot of module have his own macro to transform an ASCII string to an
> OUString : CREATE_OUSTRING, OUSTR, UNISTRING, C2U...
> 
> It should be better to use a global macro, isn't it ?

This was asked earlier as well. I guess we probably could put some
centralized macros somewhere.

And have either e.g. a single C2U for
OUString::createFromAscii(RTL_CONSTASCII_USTRINGPARAM(X)) into e.g.
comphelper/inc/comphelper/string.hxx or someplace similar and ditch the
rest of the them and use ::createFromAscii() directly for the non-const
string cases. 

Or have two of them, e.g. CC2U/NC2U for const/non-const. I think I'd
prefer a single one for const strings, and have no macro for the
non-consts. But I'm not really exercised one way or the other.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [Patch] Remove bogus macro...

[Caolán McNamara]

On Wed, 2010-12-22 at 19:02 +0100, Guillaume Poussel wrote:
> Hi,
> 
> You will find attached 2 patches to complete the easy task "Remove bogus 
> macro..".
> 
> When you will be OK, i'll be able to edit the wiki.

Looks good to me, all pushed. Thanks for this, and go ahead and move
that easy hack to the completed section.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part2

[Julien Nabet]

Hello,

Here is a patch for some files

(LGPLv3+ / MPL)

Julien
commit 12ed8ec48418ac20a50e8a097e1a5e78f0c99cbb
Author: serval 
Date:   Sun Dec 19 14:46:27 2010 +0100

RTL_CONSTASCII_USTRINGPARAM

diff --git a/forms/source/inc/FormComponent.hxx 
b/forms/source/inc/FormComponent.hxx
index 0beb592..8fcb31d 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -104,7 +104,7 @@ namespace frm
 // old macro for quickly implementing XServiceInfo::getImplementationName
 #define IMPLEMENTATION_NAME(ImplName)  
\
 virtual ::rtl::OUString SAL_CALL getImplementationName(  ) 
throw(::com::sun::star::uno::RuntimeException) \
-{ return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.comp.forms.") ) + 
::rtl::OUString::createFromAscii(#ImplName); }
+{ return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.comp.forms.") ) + 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#ImplName)); }
 
 class OControlModel;
 
diff --git a/forms/source/misc/services.cxx b/forms/source/misc/services.cxx
index 844180f..e1beaaf 100644
--- a/forms/source/misc/services.cxx
+++ b/forms/source/misc/services.cxx
@@ -134,7 +134,7 @@ void registerClassInfo(
 
//...
 #define REGISTER_CLASS_CORE(classImplName) \
 registerClassInfo( \
-::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.form.") ) + 
::rtl::OUString::createFromAscii(#classImplName), \
+::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.form.") ) + 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#classImplName)), \
 aServices, \
 frm::classImplName##_CreateInstance)
 
@@ -276,7 +276,7 @@ void ensureClassInfos()
 // = XForms core
 #define REGISTER_XFORMS_CLASS(name) \
 aServices.realloc(1); \
-aServices.getArray()[0] = rtl::OUString::createFromAscii( 
"com.sun.star.xforms." #name ); \
+aServices.getArray()[0] = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.xforms." #name )); \
 REGISTER_CLASS_CORE(name)
 
 REGISTER_XFORMS_CLASS(Model);
commit cf2811221528d3c8000951c8a3ecbd92918b58fe
Author: serval 
Date:   Sun Dec 19 15:37:23 2010 +0100

RTL_CONSTASCII_USTRINGPARAM

diff --git a/binfilter/bf_forms/source/component/FormComponent.hxx 
b/binfilter/bf_forms/source/component/FormComponent.hxx
index c6fa47c..599fb06 100644
--- a/binfilter/bf_forms/source/component/FormComponent.hxx
+++ b/binfilter/bf_forms/source/component/FormComponent.hxx
@@ -69,7 +69,7 @@ const sal_Int16 FRM_DEFAULT_TABINDEX = 0;
 // macro for quickly implementing XServiceInfo::getImplementationName
 #define IMPLEMENTATION_NAME(ImplName)  
\
 virtual ::rtl::OUString SAL_CALL getImplementationName(  ) 
throw(::com::sun::star::uno::RuntimeException) \
-{ return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.comp.forms." )) + ::rtl::OUString::createFromAscii(#ImplName); }
+{ return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.comp.forms." )) + 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#ImplName)); }
 
 // macro for overriding the getInfoServive method of 
OAggregationArrayUsageHelper
 #define IMPLEMENT_INFO_SERVICE()   \
diff --git a/binfilter/bf_forms/source/misc/forms_services.cxx 
b/binfilter/bf_forms/source/misc/forms_services.cxx
index 844ee6f..fafc36e 100644
--- a/binfilter/bf_forms/source/misc/forms_services.cxx
+++ b/binfilter/bf_forms/source/misc/forms_services.cxx
@@ -303,7 +303,7 @@ void registerClassInfo(
 
//...
 #define REGISTER_CLASS_CORE(classImplName) \
 registerClassInfo( \
-::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.form." )) 
+ ::rtl::OUString::createFromAscii(#classImplName), \
+::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.form." )) 
+ ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#classImplName)), \
 aServices, \
 frm::classImplName##_CreateInstance)
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Request for review

[Caolán McNamara]

On Wed, 2010-12-22 at 12:39 -0500, Kohei Yoshida wrote:
> I feel confident that this change won't introduce any regressions.
> Could someone review this and give me a sign-off?

Well, I think this is good anyway. Go for it I reckon, though I'm
somewhat biased :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Status of PDF export of docs containing EPS graphics

[Jean-Baptiste Faure]

Hi,

Could someone clarify the status of the PDF export of docs containing
EPS graphics. Is there some difference with OOo 3.3.0 regarding issue
14163 : http://www.openoffice.org/issues/show_bug.cgi?id=14163 ?

Best regards
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

[Kohei Yoshida]

On Wed, 2010-12-22 at 13:06 -0500, Joe Smith wrote:
> On 12/21/2010 12:09 PM, Jan Holesovsky wrote:
> > Hi,
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=32548
> >
> > The bug says: when I open a certain .odp document, I get a pop-up
> > question asking "Update all links? Yes/No"
> >
> > Anybody who knows this functionality, can you please provide a better
> > wording? ;-)  Just post it here, I'll integrate it.
> >
> > Thank you a lot,
> > Kendy
> 
> Believe me, I'm no fan of this cryptic prompt, but I'm afraid this won't 
> be an improvement. The wording of the prompt is not the primary problem.

I'm not sure if I agree with that view.  This *will* be an improvement,
and although the wording alone will not be enough to fix this
*completely*, improving the wording itself is a step in the right
direction.

> Experts already know what "Update links?" means; non-experts will not 
> understand enough to answer the question correctly even with improved 
> wording.

I disagree here.  You tend to polarize the users as either experts or
non-experts.  There are those in between who want to make an informed
decision and will understand the verbiage.  The user who reported the
above bug is one such example.

> All we accomplish by changing the wording is to make everyone 
> read and deal with a longer and more complicated (and common!) 

No, making the warning verbose does not "make everyone read and deal
with it".  Those who ignore such warnings will continue to ignore it
just as easily even with a longer warning.

And the new wordings proposed so far are not even that long.

> prompt--which still does not completely and correctly inform the user.

But it conveys more information to the user than just saying "update all
links?"

> Does the new wording help the user to answer this obvious question:
> "Why would I not want to get all the latest external data?"

Ah, good point!  Let's explain why one would not want to update the
external links.

I can think of two reasons.  Sometimes the external contents are not
available, and trying to access such contents would end up messing up
with the current data cache.  Also, sometimes updating the external
contents may take a long time to complete, depending on the size of the
external data, and the speed of the network connection etc.

> The decision at hand is too complex for an accurate prompt, given the 
> way OOo uses links: links may point not only to external data, but also 
> to internal data, 

Links that point to internal data!?  Can you give us an example of how
the app links to an internal data?  I can't think of any such example,
and it's not supposed to include internal data as external links.

> which if you choose to update, may ruin your document 
> (mail merge output, for example). In this case, the improved wording 
> will be incorrect and misleading. 

But the current wording is even more misleading, terse, and *confusing*.

> In the end, to answer the prompt 
> correctly, OOo requires the user to have knowledge outside of what the 
> prompt text can possibly convey. 

You tend to have a perfectionist view, where unless it's perfect it's
not worth an improvement. ;-)

> The longer text may just make a poor 
> situation worse by forcing the user to deal with more verbiage.

I'm not sure if I agree.

> Would it be possible to have the prompt remain as it is, with a "Help" 
> or "More" button that leads to some expanded explanation?

Relying on help for everything is a recipe for making poor UI.  Help is
a last resort, and we need to do our best to design UI so that the user
won't have to rely on Help.  In some situations we do need to rely on
help to convey some complex scenarios to the user, but I don't think
updating external links is one such example.

One thing I may agree is that maybe we need to have a two-level warning
system that displays a summary of the warning, and the "Detail" button
to show more information.  But we don't have such dialog implemented yet
(feel free to correct me here), and until we do I would favor showing a
more verbose and informative warning message than the current terse
message that leaves some users confused and clueless.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Impress : where is the movie I have inserted in my slideshow ?

[Jean-Baptiste Faure]

Hi,

When you insert a movie in a slideshow by Insert > Movie and Sound there
is a small problem: it is impossible to retrieve the path of the
inserted file. It is not listed in Edit > Links...
That is very annoying: for example if you want to move the slideshow to
another location you need to move such files too. That may be difficult
if you have several files in the directory and if you have forgot which
file you inserted.

Is it very difficult to add somewhere this information ?

I filed this enhancement request :
https://bugs.freedesktop.org/show_bug.cgi?id=32581

Best regards
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Suggestion for Windows building

[Julien Nabet]

Hello,

I compile LO on Linux but I have a notebook in dualboot with Windows 
Vista. I'd like to compile on Windows Vista with all the possible 
modules (Mozilla, NSS, directx, etc.).

I read this :
http://wiki.documentfoundation.org/Development/Native_Build
and of course this :
http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies

my repository is in :
c:\git\libo
Here the problems I had (and still have ! :-) ) :
1) Mozilla : after having put the mozilla zips and the contents of the 
zips in several directories. I read the help in config that talks about 
an installer on ftp.mozilla.org.
I used this after having tried what was in the wiki. Then after having 
put this :

./autogen.sh --with-mozilla-build=/cygdrive/c/mozilla-build I had this :
Building Seamonkey is supported with Mocrisoft Visual Studio 2005 only
I've got only Visual Express 2008.
I changed the configuration file, but i had other errors, i gave up and 
used : --disable-mozilla


2) mesa headers not found.
I installed all the packages (bin and sources) except demo proposed by 
cygwin. I searched on Google, nothing.

Then I added --without-system-mesa-headers

3) directX
DirectX SDK files not found, pleas use --with-direct-home or 
-disable-directx
I installed DirectX and tried by giving the path (/cygdrive/c/program\ 
files/Microsoft\ DirectX\ SDK\ \(June\ 2010\)

or with the short name /cygdrive/c/Progra~1/MI7482~1/
I added with "lib" at the end, nothing
Then I added --disable-directx

4) junit
I installed junit4 on Windows, the test install of Junit works.
I've got this :
cannot find JUnit 4 jar; please install one in the default location 
(/usr/share/java)
So I copied junit.jar of my Windows install in a the new directory I 
created in Cygwin : /usr/share/java


Now it's ok with :
NSIS not found, no self contained installer will be build.

If anybody who knows the whole process for Windows would have some time 
to give details in the wiki, it would be great !

If this person has little time, just give some hints please ! :-)

Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

[Kohei Yoshida]

On Wed, 2010-12-22 at 19:30 +0100, Joost Eekhoorn wrote:
> Hi all,
> 
> If you now give for "Sheet1" a new name, e.g."SheetA" and that name
> exists, the new name will become "SheetA_2" without a question for the
> user.

Sure.  I said I implemented "some aspect" of it, and this is one of
those cases we still need to catch in the dialog.

Kohei

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Easy Hacks] Creating OUString

[Guillaume Poussel]

Hi all,

I have had a look on the "Use RTL_CONSTASCII_USTRINGPARAM macro" 
 
task.
Lot of module have his own macro to transform an ASCII string to an 
OUString : CREATE_OUSTRING, OUSTR, UNISTRING, C2U...


It should be better to use a global macro, isn't it ?

Thanks for your answer :)

Regards,
Guillaume.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] sw: numbering misbehaviour

[Octavio Alvarez]

On Tue, 21 Dec 2010 12:50:07 -0800, Caolán McNamara 
wrote:


Hum, a little bit of a mess I guess. I suppose we need to decide what we
want to happen, and I missed out on the earlier discussions about this.
so here's what we've got at the moment I think ?


My tests on LO 3.3 Beta show otherwise. I'll interpost.


a) Ctrl+shift+x is bound to "Remove Direct Character formatting" and
affects just character formatting.


So *that* is what it does! :-O

See
http://lists.freedesktop.org/archives/ooo-build/2010-February/000542.html

where I didn't know what it did. So, when it is at the end of a
paragraph, it will set character style to "Default" and remove hard
character formatting for new text. Basically it emulates the "move
past the formatting end-markers".

I find its current name to be inaccurate, as it also sets character
formatting to Default. I guess we could rename this to something else
like "Continue with unformatted text".


b) Ctrl+M is bound to "Default Formatting" and affects all formatting,
including paragraph stuff


Not "all". "Default formatting" will remove direct character formatting
and direct paragraph formatting. Styles won't be affected (see same
thread). It will also depend on where the current cursor and selection
is to decide what direct format to remove.

It could be renamed too to something more accurate, like "Clear hard
formatting" or "Clear direct formatting".


c) We don't have a "Remove Character formatting" which would strip off
character formatting + character styles.


Right, except when the cursor is at the end of the line, in which we have
(a).

As a historic note, that's what "Default formatting" did before I changed
it on the before-mentioned patch. Now it is a two-step process: apply
Default style + (b).

This change was made for consistency. Before, "Default formatting" would:
* Not remove paragraph style.
* Remove directly-applied paragraph formatting.
* Remove character style.
* Remove directly-applied character formatting.

... which is inconsistent. There was no way of cleaning hard formatting
from a full document using only one step.


Where "Direct character formatting" is character "formatting that you
applied without using styles" and

"Default Formatting" is documented to be "Remove direct formatting and
formatting by character styles from the selection".


Yes. This documentation supports the previous, inconsistent behavior.


So what I would expect then is that "Remove direct character formatting"
should remove character formatting that is not part of a style. So
something that has a character style applied to it should retain that
character style after "remove direct character formatting" is used.

And what I would expect "Default formatting" to do is to remove the
character style as well.


No, that's precisely what I changed in March (and thus, breaking the
current documentation):

http://cgit.freedesktop.org/libreoffice/writer/commit/?id=985b180a2

Regards.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

[Joost Eekhoorn]

Hi all,

If you now give for "Sheet1" a new name, e.g."SheetA" and that name exists,
the new name will become "SheetA_2" without a question for the user.

Joost

2010/12/22 Kohei Yoshida 

> On Wed, 2010-12-22 at 12:48 +0100, Joost Eekhoorn wrote:
> > Hi all,
> >
> > The proposed layout change of Bernhard looks good to me, but there are
> > some pitfalls.
> >
> > > Christoph wrote:
> > > [...]
> > > * If the user copies a sheet (several sheets) within the same
> > >   file, then the new sheets will be renamed anyway. Right?
> > >   Although the user did not check the "Rename" checkbox ... -->
> > As
> > >   far as I understand, we require unique sheet names. The
> > checkbox
> > >   refers to a user intended name change.
> >
> > That is just the problem for the programmer, that he does know what
> > the user is going to do, and the user can change his mind.
> >
> > + use case mc01: The user copies "SheetA" in the same document. The
> > proposed new name becomes "SheetA_1". Now the user decides to copy the
> > sheet to another document, where "SheetA" does not exist, the proposed
> > new name should be "SheetA",
> > but only if the user did not rename the new name!
> > I do not known if that is possible, with keeping the code transparant.
>
> Well, this is not that big of an issue since we do have access to the
> ScDocument instance of the destination document.  When the user switches
> the destination document, we can ask the new ScDocument instance whether
> there is a name clash.  I already put some code to handle some aspect of
> that.
>
> >
> > > Bernhard wrote:
> > > [...]
> > > |Place to insert
> >|
> > > |
> >  +-+  |
> > > | /\ | Sheet 1
> > |  |
> > > | || |  $sheetname 2
> > |  |
> > > | \/ | Sheet 2
> > |  |
> > > || Sheet 3
> > |  |
> > > |
> >  +-+  |
> >
> > That is an challenge for the programmer, because the content of the
> > list must change on the fly.Thus make the challenge not too big:
> > display "- position -" instand of "$sheetname 2".
>
> Yup, I agree.  Displaying the '- position -' or something like that
> would make more sense, especially when the user is trying to move or
> copy multiple sheets.
>
> Changing the content of the list is, although it requires some code to
> write, can be doable.  This just means we need to re-populate the list
> content every time the insertion point moves, but it can be done.
>
> > What to do when the user clicks "Sheet 3"?
> >
> > Drag-and-drop of "- position -" must be implemented, but not for the
> > existing sheets!
>
> My preferred approach is to create two buttons to move the insertion
> position up or down, instead of relying on the user clicking on the
> sheet name in the list.  To me 1) that makes more sense, and 2) is
> easier to implement than handling mouse click events on the list
> control.
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

[Joe Smith]

On 12/21/2010 12:09 PM, Jan Holesovsky wrote:

Hi,

https://bugs.freedesktop.org/show_bug.cgi?id=32548

The bug says: when I open a certain .odp document, I get a pop-up
question asking "Update all links? Yes/No"

Anybody who knows this functionality, can you please provide a better
wording? ;-)  Just post it here, I'll integrate it.

Thank you a lot,
Kendy


Believe me, I'm no fan of this cryptic prompt, but I'm afraid this won't 
be an improvement. The wording of the prompt is not the primary problem.


Experts already know what "Update links?" means; non-experts will not 
understand enough to answer the question correctly even with improved 
wording. All we accomplish by changing the wording is to make everyone 
read and deal with a longer and more complicated (and common!) 
prompt--which still does not completely and correctly inform the user.


Does the new wording help the user to answer this obvious question:
"Why would I not want to get all the latest external data?"

The decision at hand is too complex for an accurate prompt, given the 
way OOo uses links: links may point not only to external data, but also 
to internal data, which if you choose to update, may ruin your document 
(mail merge output, for example). In this case, the improved wording 
will be incorrect and misleading. In the end, to answer the prompt 
correctly, OOo requires the user to have knowledge outside of what the 
prompt text can possibly convey. The longer text may just make a poor 
situation worse by forcing the user to deal with more verbiage.


Would it be possible to have the prompt remain as it is, with a "Help" 
or "More" button that leads to some expanded explanation?


http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] Remove bogus macro...

[Guillaume Poussel]

Hi,

You will find attached 2 patches to complete the easy task "Remove bogus 
macro..".


When you will be OK, i'll be able to edit the wiki.

Thanks again for your friendly welcome on this maling-list !

Guillaume.

>From cd375808b626d022d6d650e541382d6ba7854e9e Mon Sep 17 00:00:00 2001
From: Guillaume Poussel 
Date: Wed, 22 Dec 2010 18:37:18 +0100
Subject: [PATCH] Remove __READONLY_DATA

---
 tools/inc/tools/solar.h |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
index 8b72805..cc78aa5 100644
--- a/tools/inc/tools/solar.h
+++ b/tools/inc/tools/solar.h
@@ -87,8 +87,6 @@ typedef sal_uInt32			UINT32;	/* typedef unsigned intUINT32; previously "unsi
 
 #define DELETEZ( p )	( delete p,p = 0 )
 
-#define __READONLY_DATA 		const
-
 #ifdef WNT
 #if defined (_MSC_VER) && ( _MSC_VER < 1200 )
 #define __LOADONCALLAPI _cdecl
-- 
1.7.1

>From d6119fae6b3a12cecf8c78cf11e27b2f3d6c7b45 Mon Sep 17 00:00:00 2001
From: Guillaume Poussel 
Date: Wed, 22 Dec 2010 18:38:32 +0100
Subject: [PATCH] Removed __READONLY_DATA (replaced by const)

---
 .../objectpositioning/anchoredobjectposition.cxx   |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
index 61028b5..9368e7f 100644
--- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
@@ -1062,11 +1062,11 @@ bool SwAnchoredObjectPosition::_Minor( sal_Int16 _eRelOrient1,
 
 // draw aside order for left horizontal position
 //! one array entry for each value in text::RelOrientation
-static USHORT __READONLY_DATA aLeft[ 10 ] =
+static USHORT const aLeft[ 10 ] =
 { 5, 6, 0, 1, 8, 4, 7, 2, 3, 9 };
 // draw aside order for right horizontal position
 //! one array entry for each value in text::RelOrientation
-static USHORT __READONLY_DATA aRight[ 10 ] =
+static USHORT const aRight[ 10 ] =
 { 5, 6, 0, 8, 1, 7, 4, 2, 3, 9 };
 
 // decide depending on given order, which frame has to draw aside another frame
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Request for review

[Kohei Yoshida]

On Wed, 2010-12-22 at 12:39 -0500, Kohei Yoshida wrote:
> I just fixed this bug
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=32572
> 
> which originally came from Caolan.
> 
> The fix is committed on master, but I think we can apply this to 3.3
> branch as well.
> 
> I feel confident that this change won't introduce any regressions.
> Could someone review this and give me a sign-off?

Here is the patch (that consists of two commits on master) that I'd like
to port to 3.3.

-- 
Kohei Yoshida, LibreOffice hacker, Calc

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 0d32bae..5481822 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -4298,6 +4298,23 @@ void ScGridWindow::PasteSelection( const Point& rPosPixel )
 SCsROW	nPosY;
 pViewData->GetPosFromPixel( rPosPixel.X(), rPosPixel.Y(), eWhich, nPosX, nPosY );
 
+// If the mouse down was inside a visible note window, ignore it and
+// leave it up to the ScPostIt to handle it
+SdrView* pDrawView = pViewData->GetViewShell()->GetSdrView();
+if (pDrawView)
+{
+ULONG nCount = pDrawView->GetMarkedObjectCount();
+for (ULONG i = 0; i < nCount; ++i)
+{
+SdrObject* pObj = pDrawView->GetMarkedObjectByIndex(i);
+if (pObj && pObj->GetLogicRect().IsInside(aLogicPos))
+{
+// Inside an active drawing object.  Bail out.
+return;
+}
+}
+}
+
 ScSelectionTransferObj* pOwnSelection = SC_MOD()->GetSelectionTransfer();
 if ( pOwnSelection )
 {
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Request for review

[Kohei Yoshida]

I just fixed this bug

https://bugs.freedesktop.org/show_bug.cgi?id=32572

which originally came from Caolan.

The fix is committed on master, but I think we can apply this to 3.3
branch as well.

I feel confident that this change won't introduce any regressions.
Could someone review this and give me a sign-off?

Thanks!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Updates for Lightproof

[Kálmán „KAMI” Szalai]

Hi,

Please review the attached patch that provide updated support for
Ligthproof extension integration for 3.3.x series.

Thank you in advance!


Best regards,

KAMI
From 8c7538f9d61b097ac779f28f36c8f408bce9b6a8 Mon Sep 17 00:00:00 2001
From: Kalman Szalai - KAMI 
Date: Mon, 20 Dec 2010 19:28:42 +0100
Subject: [PATCH 1/3] Update LightProof extensions' packing mechanism

* Install extracted extension files to separated and language dependent
  directory. This is the new way to include extensions to installation
  set.

* Update for Sun Template Pack packing
---
 scp2/source/extensions/directory_extensions.scp|   18 +++---
 scp2/source/extensions/file_extensions.scp |6 +++---
 scp2/source/extensions/module_extensions.scp   |1 +
 .../extensions/module_extensions_lightproof.scp|3 +--
 .../extensions/module_extensions_sun_templates.scp |3 +--
 .../module_langpack_extensions_lightproof.sct  |1 +
 .../module_langpack_extensions_templates.sct   |1 +
 7 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/scp2/source/extensions/directory_extensions.scp b/scp2/source/extensions/directory_extensions.scp
index 124be59..4338bd3 100644
--- a/scp2/source/extensions/directory_extensions.scp
+++ b/scp2/source/extensions/directory_extensions.scp
@@ -96,6 +96,17 @@ End
 
 /* ** Lightproof ** */
 
+#ifdef WITH_EXTENSION_LIGHTPROOF
+
+Directory gid_Brand_Dir_Share_Extensions_LightProof
+ParentID = gid_Brand_Dir_Share_Extensions;
+DosName (en-US) = "lightproof-en-US-0.1";
+DosName (hu) = "lightproof-hu-1.2";
+DosName = "lightproof";
+End
+
+#endif
+
 /* ** Numbertext ** */
 
 #ifdef WITH_EXTENSION_NUMBERTEXT
@@ -245,12 +256,13 @@ End
 
 Directory gid_Brand_Dir_Share_Extensions_Sun_Template_Pack
 ParentID = gid_Brand_Dir_Share_Extensions;
-DosName (en-US)= "Sun_ODF_Template_Pack_en-US";
+DosName (en-US) = "Sun_ODF_Template_Pack_en-US";
 DosName (de) = "Sun_ODF_Template_Pack_de";
-DosName (it) = "Sun_ODF_Template_Pack_it";
-DosName (fr) = "Sun_ODF_Template_Pack_fr";
 DosName (es) = "Sun_ODF_Template_Pack_es";
+DosName (fr) = "Sun_ODF_Template_Pack_fr";
 DosName (hu) = "Sun_ODF_Template_Pack_hu";
+DosName (it) = "Sun_ODF_Template_Pack_it";
+DosName = "Sun_ODF_Template_Pack";
 End
 
 #endif
diff --git a/scp2/source/extensions/file_extensions.scp b/scp2/source/extensions/file_extensions.scp
index 7b5d984..60bba7f 100644
--- a/scp2/source/extensions/file_extensions.scp
+++ b/scp2/source/extensions/file_extensions.scp
@@ -111,9 +111,9 @@ End
 File gid_File_Oxt_LightProof
 TXT_FILE_BODY;
 Styles = (PACKED, ARCHIVE);
-Dir = gid_Brand_Dir_Share_Extensions_Install;
-Name (hu) = "lightproof-hu-1.2.oxt";
+Dir = gid_Brand_Dir_Share_Extensions_LightProof;
 Name (en-US) = "lightproof-en-US-0.1.oxt";
+Name (hu) = "lightproof-hu-1.2.oxt";
 End
 
 #endif
@@ -301,7 +301,7 @@ File gid_File_Optional_Extensions_Sun_Template_Pack
 Name (it) = "Sun_ODF_Template_Pack_it.oxt";
 Name (fr) = "Sun_ODF_Template_Pack_fr.oxt";
 Name (es) = "Sun_ODF_Template_Pack_es.oxt";
-Name (hu) = "Sun_ODF_Template_Pack_hu.oxt";
+Name (hu) = "Sun_ODF_Template_Pack_hu.oxt";
 End
 
 #endif
diff --git a/scp2/source/extensions/module_extensions.scp b/scp2/source/extensions/module_extensions.scp
index 7d9683b..b1c771c 100644
--- a/scp2/source/extensions/module_extensions.scp
+++ b/scp2/source/extensions/module_extensions.scp
@@ -133,6 +133,7 @@ Module gid_Module_Optional_Extensions_LightProof
 Default = YES;
 Styles = ( );
 End
+
 #endif
 
 /* ** Numbertext ** */
diff --git a/scp2/source/extensions/module_extensions_lightproof.scp b/scp2/source/extensions/module_extensions_lightproof.scp
index 7caa601..479437b 100644
--- a/scp2/source/extensions/module_extensions_lightproof.scp
+++ b/scp2/source/extensions/module_extensions_lightproof.scp
@@ -46,8 +46,7 @@ Module gid_Module_Optional_Extensions_LightProof_Template
 Name = "gid_Module_Optional_Extensions_LightProof_Template";
 Description = "gid_Module_Optional_Extensions_LightProof_Template";
 Styles = (TEMPLATEMODULE);
-Files = (
-gid_File_Oxt_LightProof );
+Files = ( gid_File_Oxt_LightProof );
 Minimal = NO;
 Default = YES;
 End
diff --git a/scp2/source/extensions/module_extensions_sun_templates.scp b/scp2/source/extensions/module_extensions_sun_templates.scp
index bd6fe0a..6e5897e 100644
--- a/scp2/source/extensions/module_extensions_sun_templates.scp
+++ b/scp2/source/extensions/module_extensions_sun_templates.scp
@@ -46,8 +46,7 @@ Module gid_Module_Optional_Extensions_Sun_T_Pack_Template
 Name = "gid_Module_Optional_Extensions_Sun_T_Pack_Template";
 Description = "gid_Module_Optional_Extensions_Sun_T_Pack_Template";
 Styles = (TEMPLATEMODULE);
-Files = (
-gid_File_Optional_Extensions_Sun_Template_Pack );
+Files = ( gid_File_Optional_Extensions_Sun_Templat

Re: [Libreoffice] [PATCH] Fix-font-assignation-of-extra-fonts

[Kálmán „KAMI” Szalai]

Sorry, my mistake.

Attached.

KAMI

2010-12-22 11:09 keltezéssel, Radek Doulik írta:
> Hi KAMI,
>
> I don't see the patch attached, maybe you forgot it?
>
> Cheers
> Radek
>
> On Tue, 2010-12-21 at 09:47 +0100, Kálmán „KAMI” Szalai wrote:
>> Fix SCP2/ extra font file assign problem.
>>
>> Please review it.
>>
>> Thank you in advance!
>>
>> KAMI 
>> -- 
>> KAMI911Best regards,
>>
>> Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com
>>
>>
>> My favorite projects:
>>
>> OxygenOffice Professional - office suite - for everybody | Magyarul - In 
>> Hungarian
>>
>> Blog | Support 
>>
>> Follow me, if you can
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

From 23e9887afae577cd145808a05b97561861f8ad20 Mon Sep 17 00:00:00 2001
From: Kalman Szalai - KAMI 
Date: Tue, 21 Dec 2010 09:44:26 +0100
Subject: [PATCH 3/3] Fix font assignation of extra fonts

---
 scp2/source/accessories/file_font_accessories.scp  |2 +-
 .../source/accessories/module_font_accessories.scp |   27 +++-
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/scp2/source/accessories/file_font_accessories.scp b/scp2/source/accessories/file_font_accessories.scp
index 919fe16..69fafe8 100644
--- a/scp2/source/accessories/file_font_accessories.scp
+++ b/scp2/source/accessories/file_font_accessories.scp
@@ -812,7 +812,7 @@ STD_FONT_FILE( gid_File_Fnt_Lets_trace_ruled, letstraceruled.ttf, Lets trace rul
 
 /* Tuffy Bold Italic */ 
 #ifdef WITH_EXTRA_FONT 
-STD_FONT_FILE( gid_File_Fnt_Tuffy_Bold_Italic.ttf, Tuffy_Bold_Italic.ttf, Tuffy Bold Italic ) 
+STD_FONT_FILE( gid_File_Fnt_Tuffy_Bold_Italic, Tuffy_Bold_Italic.ttf, Tuffy Bold Italic ) 
 #endif
 
 /* Tuffy Bold */ 
diff --git a/scp2/source/accessories/module_font_accessories.scp b/scp2/source/accessories/module_font_accessories.scp
index b2e67a7..2a2d679 100644
--- a/scp2/source/accessories/module_font_accessories.scp
+++ b/scp2/source/accessories/module_font_accessories.scp
@@ -196,7 +196,32 @@ Module gid_Module_Optional_Accessories_Fonts
 gid_File_Fnt_MagyarLinLibertineNB,
 gid_File_Fnt_MagyarLinLibertineNBI,
 gid_File_Fnt_MagyarLinLibertineNI,
-gid_File_Fnt_MagyarLinLibertineNC );
+gid_File_Fnt_MagyarLinLibertineNC,
+gid_File_Fnt_Chopin_Script,
+gid_File_Fnt_DTPDingbats,
+gid_File_Fnt_Justus-Bold,
+gid_File_Fnt_Justus-ItalicOldstyle,
+gid_File_Fnt_Justus-Italic,
+gid_File_Fnt_Justus-Oldstyle,
+gid_File_Fnt_Justus-Roman,
+gid_File_Fnt_Justus-Versalitas,
+gid_File_Fnt_Lets_trace_basic,
+gid_File_Fnt_Lets_trace_ruled,
+gid_File_Fnt_Tuffy_Bold_Italic,
+gid_File_Fnt_Tuffy_Bold,
+gid_File_Fnt_Tuffy_Italic,
+gid_File_Fnt_Tuffy,
+gid_File_Fnt_Verina_Sans_Bold_Oblique,
+gid_File_Fnt_Verina_Sans_Bold,
+gid_File_Fnt_Verina_Sans_Mono_Bold_Oblique,
+gid_File_Fnt_Verina_Sans_Mono_Bold,
+gid_File_Fnt_Verina_Sans_Mono_Oblique,
+gid_File_Fnt_Verina_Sans_Mono,
+gid_File_Fnt_Verina_Sans_Oblique,
+gid_File_Fnt_Verina_Sans_Roman,
+gid_File_Fnt_Verina_Serif_Bold,
+gid_File_Fnt_Verina_Serif
+ );
 Minimal = NO;
 Default = YES;
 Styles = ( );
-- 
1.7.1



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Cedric Bosdonnat]

Hello Guillaume,

On Wed, 2010-12-22 at 17:53 +0100, Guillaume Poussel wrote:
> I was not sure about git diff or git format-patch. Next time it would
> be better :)

Don't hesitate to join the IRC channel #libreoffice to raise questions
like this: there are several git experts hanging there (maybe not that
much during the Christmas holidays).

> I'm studying in Sophia-Antipolis, near to Nice, more precisely in
> Polytech'Nice-Sophia.
> I'm not sure to be able to convince my teachers, but i will talk about
> it after the Xmas holidays.

Well... it's worth trying ;)

> Now, i will take other "easy tasks" and try to send my code.

Nice, waiting for your next patches.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Guillaume Poussel]

Thank you for your welcome !

I was not sure about /git diff/ or /git format-patch/. Next time it 
would be better :)


I'm studying in Sophia-Antipolis, near to Nice, more precisely in 
Polytech'Nice-Sophia .
I'm not sure to be able to convince my teachers, but i will talk about 
it after the Xmas holidays.


Now, i will take other "easy tasks" and try to send my code.

Guillaume.

Le 22/12/2010 14:49, Cedric Bosdonnat a écrit :

Bonjour Guillaume,

On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote:

I use LibreOffice almost every day and I'm interested in Open Source
softwares, so I would like to contribute.

Then be welcomed among LibreOffice develers!


I have grabbed the code and compile it. Then, i had a look on the wiki
and found an easy task : "Remove bogus macro that expand to empty
string".
I've attached a text file which contains my diff on 4 files I have
edited.

Many thanks for it, I've just pushed it. For a next time you may want to
create the patch using git format-patch.


Could someone please have a look and tell me if i'm on the right way ?

It's OK for me.


P.S. : I'm a french student (in computer science :) ), so I'm sorry if
my english is not perfect :)

Hey! nice to see students from french schools coming here... Where are
you studying? Would it be possible for you to convince your teachers to
switch some school dev project by a LibreOffice one?

Regards,


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Change of the color of the watermark at the pdfexport

[Andreas Mantke]

Hi Andrea, Thorsten, *,

Am Dienstag, 21. Dezember 2010, 23:01:13 schrieb Andrea Pescetti:

(...)
> Take this just as a comment and not criticism (I congratulate with
> Andreas too for his first patch!), but replacing a hard-coded value by
> another hard-coded value on the basis that, more or less, "Green is
> nicer and it matches the LibreOffice official color" seems a bit weak to
> me.
> 

I did the change because the former color (red) caused problems in reading the 
document.
Your point about a configurable color is valuable, but I think that is not an 
easy 
hack. I'll think about a way. Maybe someone is faster then I ;-)

> Maybe better check with one of the UX people? Or provide a
> UI-configurable choice? I can't help with either at the moment,
> unfortunately.

You can't reach the option currently via UI. The pdf-export-dialog doesn't 
cover the 
option "Watermark". It's available only on the command-line via UNO-API.

Regards,
Andreas
-- 
## Developer LibreOffice
## Freie Office-Suite für Linux, Mac, Windows
## http://LibreOffice.org
## Support the Document Foundation (http://documentfoundation.org)
## Meine Seite: http://www.amantke.de 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Please have a look (possibly redundant 256x256 icons in soffice.bin)

[Clio]

Quoted from here (translated from Russian to English by Google):
http://translate.google.ru/translate?hl=ru&sl=ru&tl=en&u=http%3A%2F%2Fforumooo.ru%2Findex.php%2Ftopic%2C1189.msg9066.html%23msg9066

Resource "icons" file soffice.bin similar resource (copied) "namesake" 
of soffice.exe. Therefore, the ICO-files (except 18.ico and 40.ico) 
contain redundant interface 7 th page size of 256x256 pixels.

--- ---
I attach a file soffice.bin (OOo-330m18), whose pages will not have 
256x256. Work in OOo-3.3.0rs8 Win_HR new errors do not cause. Use may 
surprise a noticeable reduction in memory usage and reduced time to 
launch applications.

* soffice_bin.zip (179.62 KB)


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

[Kohei Yoshida]

On Wed, 2010-12-22 at 12:48 +0100, Joost Eekhoorn wrote:
> Hi all,
> 
> The proposed layout change of Bernhard looks good to me, but there are
> some pitfalls.
> 
> > Christoph wrote:
> > [...]
> > * If the user copies a sheet (several sheets) within the same
> >   file, then the new sheets will be renamed anyway. Right?
> >   Although the user did not check the "Rename" checkbox ... -->
> As
> >   far as I understand, we require unique sheet names. The
> checkbox
> >   refers to a user intended name change.
> 
> That is just the problem for the programmer, that he does know what
> the user is going to do, and the user can change his mind.
> 
> + use case mc01: The user copies "SheetA" in the same document. The
> proposed new name becomes "SheetA_1". Now the user decides to copy the
> sheet to another document, where "SheetA" does not exist, the proposed
> new name should be "SheetA",
> but only if the user did not rename the new name!
> I do not known if that is possible, with keeping the code transparant.

Well, this is not that big of an issue since we do have access to the
ScDocument instance of the destination document.  When the user switches
the destination document, we can ask the new ScDocument instance whether
there is a name clash.  I already put some code to handle some aspect of
that.

> 
> > Bernhard wrote:
> > [...]
> > |Place to insert
>|
> > |
>  +-+  |
> > | /\ | Sheet 1
> |  |
> > | || |  $sheetname 2
> |  |
> > | \/ | Sheet 2
> |  |
> > || Sheet 3
> |  |
> > |
>  +-+  |
> 
> That is an challenge for the programmer, because the content of the
> list must change on the fly.Thus make the challenge not too big:
> display "- position -" instand of "$sheetname 2".

Yup, I agree.  Displaying the '- position -' or something like that
would make more sense, especially when the user is trying to move or
copy multiple sheets.

Changing the content of the list is, although it requires some code to
write, can be doable.  This just means we need to re-populate the list
content every time the insertion point moves, but it can be done.

> What to do when the user clicks "Sheet 3"?
> 
> Drag-and-drop of "- position -" must be implemented, but not for the
> existing sheets!

My preferred approach is to create two buttons to move the insertion
position up or down, instead of relying on the user clicking on the
sheet name in the list.  To me 1) that makes more sense, and 2) is
easier to implement than handling mouse click events on the list
control.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [Patch] RTL_CONSTASCII_USTRINGPARAM for some files

[Caolán McNamara]

On Tue, 2010-12-21 at 22:32 +0100, Julien Nabet wrote:
> Hello,
> 
> Here is a patch for some files

Works for me, pushed now after passing a build with the SAL_N_ELEMENTS
as compile-time test. Thanks for this.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

[Takeshi Abe]

Hi Radek,

On Wed, 22 Dec 2010 12:02:57 +0100, Radek Doulik  wrote:
>> Still loitering on EasyHack 3.7, I encountered dead codes as attached.
>> They seems safely removable because if -psn given, the call of
>> InterpretCommandLineParameter() will catch it and return sal_True, so
>> the lines in question will be never passed through.
>> It looks odd noneththeless. Any thought?
> 
> couldn't be then typo in InterpretCommandLineParameter? maybe it should
> #ifndef it in case of MACOSX, so that the other part makes sense? I
> don't have any OOo CVS tree at hand now, but Thorsten might know.
The lines surrounded by #ifdef/#endif in InterpretCommandLineParameter()
are indeed only for Mac OS X, according to the original issue:
http://qa.openoffice.org/issues/show_bug.cgi?id=84053
You can browse corresponding OOo codes at:
http://svn.services.openoffice.org/opengrok/xref/Current%20(trunk)/desktop/source/app/cmdlineargs.cxx

Cheers,
-- Takeshi Abe
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

[Kohei Yoshida]

Hello Christoph!

On Tue, 2010-12-21 at 23:18 +0100, Christoph Noack wrote:
> Hi Kohei, hi Joost, hi dev list members!
> 
> It seems that I still miss a good way to sort and highlight IMAP
> messages - I did not pay too much attention to this thread and totally
> missed the CC "Christoph". Grrr & sorry at the same time ...
> 
> Thus, I don't know whether this is helpful at the moment (as far as I
> understand, the patch has been already committed), but here are my short
> thoughts ...

Well, usability is always an on-going process.  So this is never too
late. :-)

> Bur first, a basic question: Did the change address a small (but
> important) issue, or is the change part of some broader attempt? I ask,
> because the dialog is rather old and contains some other issues (like
> the old vertical OK/Cancel/Help design).

As Andy already explained, this one is not a part of any broader plan,
but just a one-time improvement.  But I'd love you hear your thoughts on
how it could be improved further.

> 
> Am Freitag, den 10.12.2010, 20:31 -0500 schrieb Kohei Yoshida:
> [...]
> > 
> > About UI
> 
> I'll refer to your (Kohei's) pictures linked in another mail ...
> 
> > And these are the screenshots of the new dialog.
> > 
> > Rename unchecked
> > http://people.freedesktop.org/~kohei/sheet-rename-unchecked.png
> > 
> > Rename checked
> > http://people.freedesktop.org/~kohei/sheet-rename-checked.png
> 
> Two main (and somehow rhetorical) questions / remarks:
>   * If the user copies a sheet (several sheets) within the same
> file, then the new sheets will be renamed anyway. Right?
> Although the user did not check the "Rename" checkbox ... --> As
> far as I understand, we require unique sheet names. The checkbox
> refers to a user intended name change.
>   * If the user copies a sheet, how will he get aware of the name of
> the new sheet? --> Currently, people have to finish the
> operation and then look for the new name.
> 
> > * Let's remove the 'New Name' string as I feel this is redundant.  And 
> >   let' place the rename box either to the immediate right of 'Rename' 
> >   check box, or immediately below it.  I prefer it being to the right 
> >   of the check box since we have a plenty of space there.
> 
> Does that mean the aligned to the caption "Rename"? Would be great.

Yes it is.  The 'Rename' text and the rename box are on the same row
now.

> > * Instead of hiding the rename box, it's better to disable it when the 
> >   Rename check box is not checked.  We generally don't show or hide 
> >   controls but enable or disable it.
> > 
> > * Let's disable the Rename check box as well as the rename input box 
> >   when multiple sheets are selected.  We don't know what we should do 
> >   for multiple sheet copy/move & rename yet, so I would be more 
> >   comfortable disabling it in such cases (at least for now).  
> 
> Yep.
> 
> > * I think it would be more user-friendly if the Rename input box 
> >   showed the default sheet name.  When moving a sheet, this would be 
> >   the original sheet name, while when copying a sheet it would be the 
> >   original name followed by '_' +  (e.g.  Sheet1 -> Sheet1_1).  
> 
> Absolutely.
> 
> > [...] 
> > 
> > All in all, I'm happy with what I see there, so, good work! :-)
> 
> A small additional question (I may have missed that): What happens, if
> the user choses a name that is already used in the document? The current
> (less helpful) reaction within the renaming sheet dialog is another
> dialog window "Invalid sheet name." (Ask any user if he knows what this
> might mean ... *g*).

Good question.  I don't think we currently handle this in the UI, but
let it pass to Calc and Calc will spit "Invalid sheet name" dialog for
now.

However, we could check for the validity of the new name as the user
types, and do something when the name already exists in the document.
Disabling the OK button (or whatever the confirmation button will be)
would be my first thought.  The chart dialog does something cute and
turns the background color of the input box to pink when you enter an
invalid cell range address.  I don't know whether it's possible to do
that here (but I can find out).

> 
> 
> > Let me know if you need any help with any of the above items.
> > 
> > I'll CC Christoph in case he has some comments on this feature as well
> > as on my comments above.  Christoph, please feel free to add your
> > comments as well if you have any. :-)
> 
> Concerning my questions above, I do have a proposal - it is meant to be
> a small iterative step, so please look at it critically ;-)
> 
> Some assumptions:
>   * limit the number of changes
>   * keep the idea of a common move / copy dialog (I still don't know
> why this had been introduced ... but at least, it saves another
> menu item)
> 
> +-+
> |  Move / Copy Sheet: $sheet

Re: [Libreoffice] howto tar or deb package

[Rene Engelhard]

Hi,

On Wed, Dec 22, 2010 at 03:41:33PM +0100, Sebastian Spaeth wrote:
> On Wed, 22 Dec 2010 10:07:31 +0100, Ralf Saalmüller 
>  wrote:
> > Is there a way to make a package or to build a deb package? A howto?  
> > It is a little bit of a mess to tell people it will work but you have  
> > to run the compiler all day long. Offering a community-build would be  
> > great.
> 
> ./configure --help tells me:
> 
> --with-package-format   Specify package format(s) for LibO installsets.
>   Default is the "normal" one of the OS/Distribution.
>   Possible values: aix, bsd, deb, inst, tardist, osx,
>   pkg, rpm, setld, native, portable, archive, dmg,
>   installed, msi. Example: --with-package-format="deb
>   dmg"

And deb is default if one is buildingon a debian (or debian-based) system:

  # if building on Debian, default should be deb...
  if test -e /etc/debian_version; then
 PKGFORMAT=deb
  else
 PKGFORMAT=rpm
  fi

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  r...@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Cedric Bosdonnat]

Bonjour Guillaume,

On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote:
> I use LibreOffice almost every day and I'm interested in Open Source
> softwares, so I would like to contribute.

Then be welcomed among LibreOffice develers!

> 
> I have grabbed the code and compile it. Then, i had a look on the wiki
> and found an easy task : "Remove bogus macro that expand to empty
> string".
> I've attached a text file which contains my diff on 4 files I have
> edited.

Many thanks for it, I've just pushed it. For a next time you may want to
create the patch using git format-patch.

> Could someone please have a look and tell me if i'm on the right way ?

It's OK for me.

> P.S. : I'm a french student (in computer science :) ), so I'm sorry if
> my english is not perfect :)

Hey! nice to see students from french schools coming here... Where are
you studying? Would it be possible for you to convince your teachers to
switch some school dev project by a LibreOffice one?

Regards,
-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] howto tar or deb package

[Sebastian Spaeth]

On Wed, 22 Dec 2010 10:07:31 +0100, Ralf Saalmüller  
wrote:
> Is there a way to make a package or to build a deb package? A howto?  
> It is a little bit of a mess to tell people it will work but you have  
> to run the compiler all day long. Offering a community-build would be  
> great.

./configure --help tells me:

--with-package-format   Specify package format(s) for LibO installsets.
  Default is the "normal" one of the OS/Distribution.
  Possible values: aix, bsd, deb, inst, tardist, osx,
  pkg, rpm, setld, native, portable, archive, dmg,
  installed, msi. Example: --with-package-format="deb
  dmg"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Build errors

[Noel Power]

On 22/12/10 02:23, Balachandran Sivakumar wrote:

call of overloaded 'append(char)' is ambiguous
Hmm I never got that error but happily it seems Joseph Powers commited a 
fix for that, try pull and rebuild.

thanks,
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

[Noel Power]

On 22/12/10 10:13, Tor Lillqvist wrote:

It seems that this patch is now in master, and it causes compilation errors on 
Windows (slightly edited compiler messages for brevity):

sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier
sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member of 'SbxValues'
sbxdec.cxx(749) : error C3861: 'ImpDoubleToUINT64': identifier not found
sbxdec.cxx(756) : error C2039: 'pLong64' : is not a member of 'SbxValues'
sbxdec.cxx(756) : error C3861: 'ImpDoubleToINT64': identifier not found
sbxdec.cxx(759) : error C2196: case value '16390' already used
sbxdec.cxx(763) : error C2039: 'pLong64' : is not a member of 'SbxValues'I
I didn't even realise there was any windows specific code, I think I 
have an old windows build ( maybe I can just update the relevant parts 
)  let me see


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

[Noel Power]

On 15/12/10 10:04, Noel Power wrote:

Hi John,
On 06/12/10 17:58, Noel Power wrote:

 Hi John,

[...]
in  sbxToUnoValueImpl ( convert to uno without known target class ) 
in basic/source/classes/sbunoobj.cxx previously an Double or Float 
basic value ( within the range of an int ) was transfered as a the 
smallest type e.g. sal_Int8, sal_Int16 or sal_Int32 values greater 
were transferred as Float or Double
I removed the '#if MAYBEFUTURE'  I put around the code above. After 
some poking around and also looking at the dev guide it seems this 
code is to handle the case where the expected type ( on the uno side ) 
is unknown, in this case the value is down cast to the smallest ( 
non-internal ) basic type which is then converted to an uno type ( or 
at least that's my current take on the intention )


in basic/source/runtime/methods1.cxx you have added incomplete 
read/write support for types SbxSALINT64 & SbxSALUINT64,  lets not 
add support to persist a new type incompletely ( to easy to forget 
about ) so I've  #ifdefed it out ( with #if IMPLEMENTATION_READY )
I'm not sure it is needed but I enabled this ( and created a new 
stream operator to handle the 64 bit type )


I rewrote the ImpCurrencyToString, I took note of your suggestions 
re. optimizations whilst trying to point you to some existing 
functionality available from the String classes as its better to 
avoid generating even more number to string code. Somewhere between 
trying to write down some explanations and suggestions I'm afraid I 
found myself actually rewriting this and then I found mistakes in my 
'new' implementation... couldn't help myself. Anyway hopefully some 
of the code there shows some other possibilities to achieve the same 
thing reusing some of the existing LO classes. ( I have no doubt that 
there probably is some bugs in my implementation too ). Additionally 
I am still very uncertain about   ImpStringToCurrency() changes to 
use Locale specific separators. Also not sure about the local 
seperator logic, the heuristics used I think might give an undesired 
result under some circumstances. I don't want to rule it out but for 
the moment I would feel happier with the locale specific part being 
#ifdefed out ( so I did that with some more   #if MAYBEFUTURE blocks ).
I also rewrote the ImpStringToCurrency a little, actually more like I 
combined yours and the old implementation a little, mostly I just 
removed the home grown parser in favour of using the existing 
string->number conversions in OUString. Like the ImpCurrencyToString I 
have enclosed the locale specific functionality in a '#if MAYBEFUTURE' 
block. I removed the acceptance of blank characters in the middle of a 
string as VBA regards this as an error and the old implementation just 
truncated the number ( e.g. "12345 6" would end up as 12345 ), I raise 
an error in this case now. Hopefully if this breaks existing macros it 
will only break code already deeply in error ( from mis-interpreting 
the string/number  )  The other reason for removing the parser is 
if/when we do apply some locale specific separator processing I would 
love to reuse/share whatever calc currently uses.



SbxValue::LoadData & SbxValue::SaveData, we need to ensure that a 
Currency val written from the old Currency implementation can be read 
with the new implementation and vice-versa ( looking at the code it 
seems that it should work ). Hmmm but thinking about this more I 
really don't see why this is necessary, I can't think of why a types 
value would be saved with this this code,
I still haven't figured out if this code is really used or not, 
currently erring on the side of caution I created a new stream 
operator for SvStream and additionally tweaked the handling for 
Currency and the SbxSALINT64 and SbxSALUINT64 from you orig patch, it 
seems there were some bugs with the orig patch. Currently I don't see 
an easy way of testing the changes ( so I have coded them untested ) 
so I hope that maybe another set of eyes might help. Please feel free 
to do that ( and I'll try and ask on the list for some help too )
It would be great if you could look over my changes and see if they 
are ok, if you are happy with the change and if we can satisfy 
ourselves that LoadData/SaveData item above is not an issue then we 
could probably commit this to the master, then we can look further 
into some of the ifdefed out stuff, how does that sound?
did you look at the changes I committed to the branch ? ( of course 
there are some more changes to look at now :-) ) I'd be interested in 
your thoughts as I would like to get this stuff into master asap
pushed to master, hmmm I noticed running the test document the results 
are slightly worse than previously, I need to investigate how I seem to 
have broken this. I was sure that I retested ( all but the last changes 
I made ) which I didn't think would affect the results adversely. 
Anyway, not to worry I will fix that.


Noel
___

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

[Joost Eekhoorn]

Hi all,

The proposed layout change of Bernhard looks good to me, but there are some
pitfalls.

> Christoph wrote:
> [...]
> * If the user copies a sheet (several sheets) within the same
>   file, then the new sheets will be renamed anyway. Right?
>   Although the user did not check the "Rename" checkbox ... --> As
>   far as I understand, we require unique sheet names. The checkbox
>   refers to a user intended name change.

That is just the problem for the programmer, that he does know what the user
is going to do, and the user can change his mind.

+ use case mc01: The user copies "SheetA" in the same document. The proposed
new name becomes "SheetA_1". Now the user decides to copy the sheet to
another document, where "SheetA" does not exist, the proposed new name
should be "SheetA",
but only if the user did not rename the new name!
I do not known if that is possible, with keeping the code transparant.

> Bernhard wrote:
> [...]
> |Place to insert  |
> |+-+  |
> | /\ | Sheet 1 |  |
> | || |  $sheetname 2   |  |
> | \/ | Sheet 2 |  |
> || Sheet 3 |  |
> |+-+  |

That is an challenge for the programmer, because the content of the list
must change on the fly. Thus make the challenge not too big: display "-
position -" instand of "$sheetname 2".

What to do when the user clicks "Sheet 3"?

Drag-and-drop of "- position -" must be implemented, but not for the
existing sheets!

I wait for the reaction of Kohei.

Best regards,
Joost


2010/12/22 Dr. Bernhard Dippold 

> Hi all
>
> sorry: once more I didn't "reply all", just "reply" as on the other LibO
> lists...
>
> here is what I sent to Christoph alone:
>
> Hi Christoph, all,
>
> just a very short comment - before I forget it...
>
> Christoph Noack schrieb:
> > [...]
> >* Think about the "Insert Before" thing ... it is not that obvious
> >  what this means. Is there any way to make this more
> >  understandable?
>
> Move the "Insert Before" list below the new name area and move the new
> name by mouse or arrows up and down in the list.
>
> This would allow to place the new sheet where the user wants it without
> thinking about "before" and "after".
>
> Copying your sketch...
>
> +-+
> |  Move / Copy Sheet: $sheetname  |
> +-+
> |  Action --  +
> |(o) Move |
> |( ) Copy |
> | |
> |  Location and Name ---  |
> |To Document  |
> |[ $documentname (Current Document) |\/]  |
> | |
> |New Name |
> |[ $sheetname 2]  |
> | |
> |Place to insert  |
> |+-+  |
> | /\ | Sheet 1 |  |
> | || |  $sheetname 2   |  |
> | \/ | Sheet 2 |  |
> || Sheet 3 |  |
> |+-+  |
> | |
> +-+
> | [ Help ]   [  OK  ]  [ Cancel ] |
> +-+
>
> Best regards
>
> Bernhard
>
>
>
>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove unused code

[Radek Doulik]

On Wed, 2010-12-22 at 12:00 +0100, Radek Doulik wrote:
> On Wed, 2010-12-22 at 11:29 +0100, Radek Doulik wrote:
> > Hi Anders,
> > 
> > thanks for your patch. Looks good to me so I pushed it.
> > 
> > It contains sd/ module changes only though, so maybe you forget the ure
> > part?
> 
> ops, sorry. I managed to miss it when reading your mail, I will review
> it as well.

pushed it too. Thanks once more!

Cheers
Radek

> Cheers
> Radek
> 
> > Cheers
> > Radek
> > 
> > On Wed, 2010-12-22 at 08:31 +0100, Anders Jonsson wrote:
> > > Some more unused code, this time in ure and impress. All code has been
> > > commented out at least since 2005.
> > > 
> > > 
> > > Anders Jonsson
> > > (LGPLv3+,MPL)
> > > ___
> > > LibreOffice mailing list
> > > LibreOffice@lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> > 
> > 
> > ___
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

[Radek Doulik]

Hi Takeshi,

On Wed, 2010-12-22 at 17:21 +0900, Takeshi Abe wrote:
> Hi,
> 
> Still loitering on EasyHack 3.7, I encountered dead codes as attached.
> They seems safely removable because if -psn given, the call of
> InterpretCommandLineParameter() will catch it and return sal_True, so
> the lines in question will be never passed through.
> It looks odd noneththeless. Any thought?

couldn't be then typo in InterpretCommandLineParameter? maybe it should
#ifndef it in case of MACOSX, so that the other part makes sense? I
don't have any OOo CVS tree at hand now, but Thorsten might know.

Cheers
Radek

> Cheers,
> -- Takeshi Abe
> differences between files attachment
> (0001-remove-dead-codes-never-passed-through-even-in-case-.patch)
> >From f06b3e31df80d48a1eb773acfea7563377928dba Mon Sep 17 00:00:00 2001
> From: Takeshi Abe 
> Date: Wed, 22 Dec 2010 16:33:34 +0900
> Subject: [PATCH] remove dead codes never passed through even in case of MACOSX
> 
> ---
>  desktop/source/app/cmdlineargs.cxx |   20 
>  1 files changed, 0 insertions(+), 20 deletions(-)
> 
> diff --git a/desktop/source/app/cmdlineargs.cxx 
> b/desktop/source/app/cmdlineargs.cxx
> index 97a9fb9..f9ac187 100644
> --- a/desktop/source/app/cmdlineargs.cxx
> +++ b/desktop/source/app/cmdlineargs.cxx
> @@ -280,26 +280,6 @@ void CommandLineArgs::ParseCommandLine_Impl( Supplier& 
> supplier )
>  bStartEvent = sal_False;
>  bDisplaySpec = sal_False;
>  }
> -
> -#ifdef MACOSX
> -/* #i84053# ignore -psn on Mac
> -   Platform dependent #ifdef here is ugly, however this 
> is currently
> -   the only platform dependent parameter. Should more 
> appear
> -   we should find a better solution
> -*/
> -else if ( 
> aArg.matchAsciiL(RTL_CONSTASCII_STRINGPARAM("-psn")))
> -{
> -// finder argument from MacOSX
> -bOpenEvent  = sal_False;
> -   bPrintEvent = sal_False;
> -bForceOpenEvent = sal_False;
> -bPrintToEvent   = sal_False;
> -bForceNewEvent  = sal_False;
> -bViewEvent  = sal_False;
> -bStartEvent = sal_False;
> -bDisplaySpec = sal_False;
> -}
> -#endif
>  else if ( 
> aArg.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("-convert-to")))
>  {
>  bOpenEvent = sal_False;
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove unused code

[Radek Doulik]

On Wed, 2010-12-22 at 11:29 +0100, Radek Doulik wrote:
> Hi Anders,
> 
> thanks for your patch. Looks good to me so I pushed it.
> 
> It contains sd/ module changes only though, so maybe you forget the ure
> part?

ops, sorry. I managed to miss it when reading your mail, I will review
it as well.

Cheers
Radek

> Cheers
> Radek
> 
> On Wed, 2010-12-22 at 08:31 +0100, Anders Jonsson wrote:
> > Some more unused code, this time in ure and impress. All code has been
> > commented out at least since 2005.
> > 
> > 
> > Anders Jonsson
> > (LGPLv3+,MPL)
> > ___
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Guillaume Poussel]

Hi everybody,


I use LibreOffice almost every day and I'm interested in Open Source 
softwares, so I would like to contribute.



I have grabbed the code and compile it. Then, i had a look on the wiki 
and found an easy task : "Remove bogus macro that expand to empty 
string" 
.

I've attached a text file which contains my diff on 4 files I have edited.

Could someone please have a look and tell me if i'm on the right way ?

Cheers,
Guillaume.

P.S. : I'm a french student (in computer science :) ), so I'm sorry if 
my english is not perfect :)


diff --git binfilter/inc/bf_sfx2/docfac.hxx binfilter/inc/bf_sfx2/docfac.hxx
index 085d11c..646b87d 100644
--- binfilter/inc/bf_sfx2/docfac.hxx
+++ binfilter/inc/bf_sfx2/docfac.hxx
@@ -635,7 +635,7 @@ extern "C"
 Factory().RegisterInitFactory( &InitFactory);  
  \
 }  
  \
   \
-SfxObjectShell*__EXPORT Class::CreateObject(SfxObjectCreateMode eMode) 
  \
+SfxObjectShell* Class::CreateObject(SfxObjectCreateMode eMode)   \
 {  
  \
 SfxCreateExtern_TYPE fCreate = (SfxCreateExtern_TYPE)  
\
 GetFunc##LibName( "CreateObj" #Class "Dll");\
diff --git svtools/source/contnr/svlbox.cxx svtools/source/contnr/svlbox.cxx
index 6eb2860..989a5b7 100644
--- svtools/source/contnr/svlbox.cxx
+++ svtools/source/contnr/svlbox.cxx
@@ -1696,7 +1696,7 @@ sal_Int8 SvLBox::AcceptDrop( const AcceptDropEvent& rEvt )
 }
 else
 {
-DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0 
(__EXPORT?)" );
+DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0" );
 if( !( pEntry && pDDSource->GetModel() == this->GetModel()
 && DND_ACTION_MOVE == rEvt.mnAction
 && ( pEntry->nEntryFlags & SV_ENTRYFLAG_DISABLE_DROP ) ))
diff --git tools/inc/tools/solar.h tools/inc/tools/solar.h
index 0ecaf58..8b72805 100644
--- tools/inc/tools/solar.h
+++ tools/inc/tools/solar.h
@@ -88,7 +88,6 @@ typedef sal_uInt32UINT32; /* typedef 
unsigned intUINT32; previously "unsi
 #define DELETEZ( p )   ( delete p,p = 0 )
 
 #define __READONLY_DATAconst
-#define __EXPORT
 
 #ifdef WNT
 #if defined (_MSC_VER) && ( _MSC_VER < 1200 )
diff --git sfx2/inc/sfx2/childwin.hxx sfx2/inc/sfx2/childwin.hxx
index f3e058a..5de9fba 100644
--- sfx2/inc/sfx2/childwin.hxx
+++ sfx2/inc/sfx2/childwin.hxx
@@ -313,7 +313,7 @@ public:
 SfxChildWindow *pWin = new Class(pParent, nId, pBindings, 
pInfo);\
 return pWin; \
 } \
-sal_uInt16 __EXPORT Class::GetChildWindowId () \
+sal_uInt16 Class::GetChildWindowId () \
 { return MyID; } \
 void   Class::RegisterChildWindow (sal_Bool bVis, SfxModule *pMod, 
sal_uInt16 nFlags)   \
 {  \
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Defective equation setter in LibreOffice (and OpenOffice)

[Caolán McNamara]

On Tue, 2010-12-21 at 21:40 +, Caolán McNamara wrote:
> On Tue, 2010-12-21 at 16:17 +, RSClymo wrote:
> > To whoever it concerns: greeting.
> > 
> > I wrote the following to Michael Meeks (after his article in Linux Format 
> > promoting LO (which I am trying):
> > 
> > "In its parent OpenOffice there is a long-standing defect (reported over 3 
> > years
> > ago, issue 76587) that makes the equation setter in the Linux version a 
> > total
> > joke (common characters such as ()+ etc. print wrongly or are unprintable) 
> > and
> > the app is consequently useless in Linux for much science work. It is, 
> > though,
> > OK in MS Word. Details attached. I did my bit to try and get this attended 
> > to in
> > OOo but no success. This got OOo a bad reputation. I'd hate that to 
> > continue in LO."
> 
> I *can* reproduce http://qa.openoffice.org/issues/show_bug.cgi?id=76587
> which is not really strictly anything to do with equations. That's to do
> with wmf rendering, and if the comment by r6144 is correct it should be
> an easy enough fix.

So I committed 8e1934afe18a270b0042afc5fdb9cb19e83a28c3 in svtools to
fallback to MS1252 encoding when we get a "DEFAULT" or "OEM" encoding
where we can't actually determine the encoding instead of assuming its
the system encoding. This should mean that things are consistent across
platforms and environment. And has the outcome that the concrete example
now looks like the attached when imported into LibreOffice.

This isn't backported to libreoffice 3.3, but is in the master version
only.

C.
<>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove unused code

[Radek Doulik]

Hi Anders,

thanks for your patch. Looks good to me so I pushed it.

It contains sd/ module changes only though, so maybe you forget the ure
part?

Cheers
Radek

On Wed, 2010-12-22 at 08:31 +0100, Anders Jonsson wrote:
> Some more unused code, this time in ure and impress. All code has been
> commented out at least since 2005.
> 
> 
> Anders Jonsson
> (LGPLv3+,MPL)
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ Libreoffice ] [ UX ] [ PATCH ] EasyHacks 3.27 Change Sheet copy process

[Dr. Bernhard Dippold]

Hi all

sorry: once more I didn't "reply all", just "reply" as on the other LibO 
lists...

here is what I sent to Christoph alone:

Hi Christoph, all,

just a very short comment - before I forget it...

Christoph Noack schrieb:
> [...]
>* Think about the "Insert Before" thing ... it is not that obvious
>  what this means. Is there any way to make this more
>  understandable?

Move the "Insert Before" list below the new name area and move the new 
name by mouse or arrows up and down in the list.

This would allow to place the new sheet where the user wants it without 
thinking about "before" and "after".

Copying your sketch...

+-+
|  Move / Copy Sheet: $sheetname  |
+-+
|  Action --  +
|(o) Move |
|( ) Copy |
| |
|  Location and Name ---  |
|To Document  |
|[ $documentname (Current Document) |\/]  |
| |
|New Name |
|[ $sheetname 2]  |
| |
|Place to insert  |
|+-+  |
| /\ | Sheet 1 |  |
| || |  $sheetname 2   |  |
| \/ | Sheet 2 |  |
|| Sheet 3 |  |
|+-+  |
| |
+-+
| [ Help ]   [  OK  ]  [ Cancel ] |
+-+

Best regards

Bernhard





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

[Tor Lillqvist]

It seems that this patch is now in master, and it causes compilation errors on 
Windows (slightly edited compiler messages for brevity):

sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier
sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member of 'SbxValues'
sbxdec.cxx(749) : error C3861: 'ImpDoubleToUINT64': identifier not found
sbxdec.cxx(756) : error C2039: 'pLong64' : is not a member of 'SbxValues'
sbxdec.cxx(756) : error C3861: 'ImpDoubleToINT64': identifier not found
sbxdec.cxx(759) : error C2196: case value '16390' already used
sbxdec.cxx(763) : error C2039: 'pLong64' : is not a member of 'SbxValues'

--tml

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix Gallery module

[Radek Doulik]

Hi KAMI,

thanks for the patch. Looks good so I pushed it.

Cheers
Radek

On Tue, 2010-12-21 at 02:50 +0100, Kálmán „KAMI” Szalai wrote:
> Trivial patch to fix some gallery file assign problem.
> 
> -- 
> KAMI911Best regards,
> 
> Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com
> 
> 
> My favorite projects:
> 
> OxygenOffice Professional - office suite - for everybody | Magyarul - In 
> Hungarian
> 
> Blog | Support 
> 
> Follow me, if you can
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [UX] Re: Better wording for 'Update links' question

[Christoph Noack]

Hi David, all!

Am Mittwoch, den 22.12.2010, 11:56 +0800 schrieb David Nelson:
> Hi, :-)
> 
> So, re-working Hal's suggeston, we'd have:

???

> "This document contains one or more links to external media or other data.
> Do you want to update all links to get the most recent content?
> 
> Go to Edit - Links... to find out what external data this document
> references."

I think this proposal misses a bit the remaining LibO/OOo menu and
dialog wording. For example, the "external media or other data" is is
"External Data" in Calc. And, as far as I know, LibO/OOo rather uses
"Media and Sound" or "Objects", but doesn't refer to "media". The funny
thing is, that pictures ("the" media content") won't get updated within
this dialog - so it would be somehow incorrect. I assume that it is the
same for videos and sounds.

Then, I miss the reason for asking - it is implicitly contained in "most
recent content", although the external data might not have changed in
the meantime. And what happens if the user does not update all the
links?

Then I'd like to ask whether you plan for different buttons and/or
dialog titles - or is this the default Yes/No behavior? If yes, then the
user would get the important information in the second part. It is
usually recommended to provide it as early as possible. That's e.g. the
reason for the "self-speaking" buttons. (I agree that LibO/OOo still
misses such specific dialog guidelines like the Gnome HIG or stuff
Apple/Microsoft/... provides.)

The last sentence "Go to Edit ..." is I'd like to see in the help
(referring to a sub-section to the , but not in the dialog itself. But
to be honest, I don't know whether there is currently a help topic for
that ...

Until then, I'd stick with the proposal stated below.

Cheers,
Christoph


> On Wed, Dec 22, 2010 at 09:27, Christoph Noack  wrote:
[...]
> > 
> > Update Linked Data
> > 
> > This document links to external data that might have changed. Do you
> > want to update all linked data or keep the current document content?
> > 
> > [Help]  [Update] [Keep]
> > 
[...]

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] howto tar or deb package

[Jonathan Aquilina]

What distro are you using? If you are using ubuntu, on irc.freenode.net 
there is an ubuntu-packaging channel. they might be able to provide you 
some help with packaging of LO.


On 12/22/10 10:07 AM, Ralf Saalmüller wrote:

Hello to LibreOffice

a short introduction: I use StarOffice / OOo / LibreOffice since 
StarOffice 3.1 on Mac OS on the PowerPC. I still have a powerpc with 
Linux in use and I like to have LibreOffice on it.


It was a 24h job but LibreOffice was made and is running on my 
PowerBook G4. I like to share the package to other people using 
powerpcs and Linux. Done that with Firefox and Thunderbird community 
build already.


Is there a way to make a package or to build a deb package? A howto? 
It is a little bit of a mess to tell people it will work but you have 
to run the compiler all day long. Offering a community-build would be 
great.


Thanks for any advice!

Ralf


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] howto tar or deb package

[Ralf Saalmüller]

Hello to LibreOffice

a short introduction: I use StarOffice / OOo / LibreOffice since  
StarOffice 3.1 on Mac OS on the PowerPC. I still have a powerpc with  
Linux in use and I like to have LibreOffice on it.


It was a 24h job but LibreOffice was made and is running on my  
PowerBook G4. I like to share the package to other people using  
powerpcs and Linux. Done that with Firefox and Thunderbird community  
build already.


Is there a way to make a package or to build a deb package? A howto?  
It is a little bit of a mess to tell people it will work but you have  
to run the compiler all day long. Offering a community-build would be  
great.


Thanks for any advice!

Ralf


PGP.sig
Description: Signierter Teil der Nachricht
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

[Takeshi Abe]

Hi,

Still loitering on EasyHack 3.7, I encountered dead codes as attached.
They seems safely removable because if -psn given, the call of
InterpretCommandLineParameter() will catch it and return sal_True, so
the lines in question will be never passed through.
It looks odd noneththeless. Any thought?

Cheers,
-- Takeshi Abe
>From f06b3e31df80d48a1eb773acfea7563377928dba Mon Sep 17 00:00:00 2001
From: Takeshi Abe 
Date: Wed, 22 Dec 2010 16:33:34 +0900
Subject: [PATCH] remove dead codes never passed through even in case of MACOSX

---
 desktop/source/app/cmdlineargs.cxx |   20 
 1 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/desktop/source/app/cmdlineargs.cxx b/desktop/source/app/cmdlineargs.cxx
index 97a9fb9..f9ac187 100644
--- a/desktop/source/app/cmdlineargs.cxx
+++ b/desktop/source/app/cmdlineargs.cxx
@@ -280,26 +280,6 @@ void CommandLineArgs::ParseCommandLine_Impl( Supplier& supplier )
 bStartEvent = sal_False;
 bDisplaySpec	= sal_False;
 }
-
-#ifdef MACOSX
-/* #i84053# ignore -psn on Mac
-   Platform dependent #ifdef here is ugly, however this is currently
-   the only platform dependent parameter. Should more appear
-   we should find a better solution
-*/
-else if ( aArg.matchAsciiL(RTL_CONSTASCII_STRINGPARAM("-psn")))
-{
-// finder argument from MacOSX
-bOpenEvent  = sal_False;
-   bPrintEvent = sal_False;
-bForceOpenEvent = sal_False;
-bPrintToEvent   = sal_False;
-bForceNewEvent  = sal_False;
-bViewEvent  = sal_False;
-bStartEvent = sal_False;
-bDisplaySpec	= sal_False;
-}
-#endif
 else if ( aArg.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("-convert-to")))
 {
 bOpenEvent = sal_False;
-- 
1.7.2.3

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice