[Libreoffice] [PATCH] some changes for better performance, writer.
Please, someone can review this? Thkz. revol_ diff --git a/sw/source/core/access/acccell.cxx b/sw/source/core/access/acccell.cxx index dbd1b51..2479c5c 100644 --- a/sw/source/core/access/acccell.cxx +++ b/sw/source/core/access/acccell.cxx @@ -121,7 +121,7 @@ SwAccessibleCell::SwAccessibleCell( SwAccessibleMap *pInitMap, sal_Bool SwAccessibleCell::_InvalidateMyCursorPos() { sal_Bool bNew = IsSelected(); -sal_Bool bOld; +sal_Bool bOld = sal_False; { osl::MutexGuard aGuard( aMutex ); bOld = bIsSelected; @@ -349,7 +349,7 @@ sal_Bool SwAccessibleCell::setCurrentValue( const uno::Any aNumber ) SolarMutexGuard aGuard; CHECK_FOR_DEFUNC( XAccessibleValue ); -double fValue = 0; +const double fValue = 0; sal_Bool bValid = (aNumber = fValue); if( bValid ) { diff --git a/sw/source/core/access/acccell.cxx b/sw/source/core/access/acccell.cxx index dbd1b51..2479c5c 100644 --- a/sw/source/core/access/acccell.cxx +++ b/sw/source/core/access/acccell.cxx @@ -121,7 +121,7 @@ SwAccessibleCell::SwAccessibleCell( SwAccessibleMap *pInitMap, sal_Bool SwAccessibleCell::_InvalidateMyCursorPos() { sal_Bool bNew = IsSelected(); -sal_Bool bOld; +sal_Bool bOld = sal_False; { osl::MutexGuard aGuard( aMutex ); bOld = bIsSelected; @@ -349,7 +349,7 @@ sal_Bool SwAccessibleCell::setCurrentValue( const uno::Any aNumber ) SolarMutexGuard aGuard; CHECK_FOR_DEFUNC( XAccessibleValue ); -double fValue = 0; +const double fValue = 0; sal_Bool bValid = (aNumber = fValue); if( bValid ) { diff --git a/sw/source/core/access/acccontext.cxx b/sw/source/core/access/acccontext.cxx index 127820f..85a55cd 100644 --- a/sw/source/core/access/acccontext.cxx +++ b/sw/source/core/access/acccontext.cxx @@ -507,7 +507,7 @@ void SwAccessibleContext::FireVisibleDataEvent() } void SwAccessibleContext::FireStateChangedEvent( sal_Int16 nState, - sal_Bool bNewState ) + const sal_Bool bNewState ) { AccessibleEventObject aEvent; @@ -550,7 +550,7 @@ void SwAccessibleContext::GetStates( sal_Bool SwAccessibleContext::IsEditableState() { -sal_Bool bRet; +sal_Bool bRet = sal_False; { osl::MutexGuard aGuard( aMutex ); bRet = bIsEditableState; @@ -601,7 +601,7 @@ sal_Int32 SAL_CALL SwAccessibleContext::getAccessibleChildCount( void ) } uno::Reference XAccessible SAL_CALL -SwAccessibleContext::getAccessibleChild( sal_Int32 nIndex ) +SwAccessibleContext::getAccessibleChild( const sal_Int32 nIndex ) throw (uno::RuntimeException, lang::IndexOutOfBoundsException) { SolarMutexGuard aGuard; diff --git a/sw/source/core/access/acccell.cxx b/sw/source/core/access/acccell.cxx index dbd1b51..2479c5c 100644 --- a/sw/source/core/access/acccell.cxx +++ b/sw/source/core/access/acccell.cxx @@ -121,7 +121,7 @@ SwAccessibleCell::SwAccessibleCell( SwAccessibleMap *pInitMap, sal_Bool SwAccessibleCell::_InvalidateMyCursorPos() { sal_Bool bNew = IsSelected(); -sal_Bool bOld; +sal_Bool bOld = sal_False; { osl::MutexGuard aGuard( aMutex ); bOld = bIsSelected; @@ -349,7 +349,7 @@ sal_Bool SwAccessibleCell::setCurrentValue( const uno::Any aNumber ) SolarMutexGuard aGuard; CHECK_FOR_DEFUNC( XAccessibleValue ); -double fValue = 0; +const double fValue = 0; sal_Bool bValid = (aNumber = fValue); if( bValid ) { diff --git a/sw/source/core/access/acccontext.cxx b/sw/source/core/access/acccontext.cxx index 127820f..978dcad 100644 --- a/sw/source/core/access/acccontext.cxx +++ b/sw/source/core/access/acccontext.cxx @@ -507,7 +507,7 @@ void SwAccessibleContext::FireVisibleDataEvent() } void SwAccessibleContext::FireStateChangedEvent( sal_Int16 nState, - sal_Bool bNewState ) + const sal_Bool bNewState ) { AccessibleEventObject aEvent; @@ -550,7 +550,7 @@ void SwAccessibleContext::GetStates( sal_Bool SwAccessibleContext::IsEditableState() { -sal_Bool bRet; +sal_Bool bRet = sal_False; { osl::MutexGuard aGuard( aMutex ); bRet = bIsEditableState; @@ -601,7 +601,7 @@ sal_Int32 SAL_CALL SwAccessibleContext::getAccessibleChildCount( void ) } uno::Reference XAccessible SAL_CALL -SwAccessibleContext::getAccessibleChild( sal_Int32 nIndex ) +SwAccessibleContext::getAccessibleChild( const sal_Int32 nIndex ) throw (uno::RuntimeException, lang::IndexOutOfBoundsException) { SolarMutexGuard aGuard; @@ -771,7 +771,7 @@ void SAL_CALL SwAccessibleContext::removeEventListener( if (xListener.is()) { SolarMutexGuard aGuard; -sal_Int32 nListenerCount = comphelper::AccessibleEventNotifier::removeEventListener( nClientId, xListener ); +const
Re: [Libreoffice] Bug triaging - bugs in OOo code base
On 07/01/11 18:09, Alexander Thurgood wrote: Hi, A question to the developers, which will inevitably become more important as things push on with LibO and the code base starts to separate : - what is the current approach, with regard to bug triaging, to bugs caused by the OOo code base ? What I mean is that do we consider them to be our own bugs, or not ? From the bug triager's point of view, it is easy to tell someone that this is NOTOURBUG, however, I have my doubts about that Well, if it's in the code we're shipping then it is our bug ... because ultimately, someone who knows nothing about OOo and who has only ever used LibO, is not likely to understand the underpinning between the code bases and therefore not be entirely satisfied with the bug being classified as someone else's when in fact substantially the same code base is used. Of course, there are people who file reports knowing that the bug exists in the OOo codebase and hoping that the LibO devs will sort it out - this is a kind of catch 22 for the bug triager ? - to clear out or not to clear out ? imho it should be classified as UPSTREAM. I would appreciate your thoughts on the matter, as it will help me to better sort through the bug reports. It seems highly likely we are going to diverge from OOo, and that the discrepancies will steadily grow, so this is simply YAI (yet another instance). Then the bug-fixers can decide whether to fix it themselves or wait for OOo to fix it. And your someone who knows nothing about OOo can be assured that we know about the bug, and it will (hopefully) be dealt with. Plus, if we've got a load of bugs marked UPSTREAM it makes it a lot easier for the OOo devs to scan our bug database and find stuff that interests them. (Or our bugfixers can assign the patch to OOo.) Alex But all this is my personal imho, so don't take this as a guideline unless nobody else chips in with a more definitive statement ... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
Hi, See the attached patch. Motivation: 17:51 boobaa kohei: is there a way to bind F13/F15 to previous/next sheet in calc? 17:58 @kohei boobaa, no idea. did you look into View - Toolbars - Customize - Keyboard? 17:58 boobaa kohei: exactly 17:59 @kohei boobaa, if it's not there, then the answer will be 'no'. 18:01 boobaa kohei: ok, let me rephrase. how difficult to implement this? :) 18:02 @kohei boobaa, this is a bit tricky, since ctrl-pageup pagedown have special handling in vcl not tied to key bindings. 18:02 @kohei boobaa, oh wait, I may be talking about shift-pageup/down. 18:03 boobaa kohei: well, from my user point of view all i'm missing is the f13 and f15 from the available keys' list. everything else is there already. 18:05 @kohei boobaa, then it should be fairly simple I think. Just add F13 and up as bindable keys in vcl, and modify the key binding pane in somewhere in svx/svtools/svl is all you'd need to do, I think. 18:05 * kohei forgets exactly how to add new keys. The patch is pretty trivial once it turned out vcl already supports up to F24 (and at some places F26), but what I can test is F13-F16, so I enabled only that. OK to push to master? From 0eaa09f032b71f5ffc7369f8ecf841a8f8c41e99 Mon Sep 17 00:00:00 2001 From: Miklos Vajna vmik...@frugalware.org Date: Sat, 8 Jan 2011 15:44:50 +0100 Subject: [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function --- cui/source/customize/acccfg.cxx | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx index 9460c9d..20a92b0 100644 --- a/cui/source/customize/acccfg.cxx +++ b/cui/source/customize/acccfg.cxx @@ -127,6 +127,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 , KEY_F11 , KEY_F12 , +KEY_F13 , +KEY_F14 , +KEY_F15 , +KEY_F16 , KEY_DOWN , KEY_UP , @@ -167,6 +171,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_SHIFT, KEY_F11 | KEY_SHIFT, KEY_F12 | KEY_SHIFT, +KEY_F13 | KEY_SHIFT, +KEY_F14 | KEY_SHIFT, +KEY_F15 | KEY_SHIFT, +KEY_F16 | KEY_SHIFT, KEY_DOWN | KEY_SHIFT, KEY_UP| KEY_SHIFT, @@ -235,6 +243,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_MOD1 , KEY_F11 | KEY_MOD1 , KEY_F12 | KEY_MOD1 , +KEY_F13 | KEY_MOD1 , +KEY_F14 | KEY_MOD1 , +KEY_F15 | KEY_MOD1 , +KEY_F16 | KEY_MOD1 , KEY_DOWN | KEY_MOD1 , KEY_UP| KEY_MOD1 , @@ -307,6 +319,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_SHIFT | KEY_MOD1, KEY_F11 | KEY_SHIFT | KEY_MOD1, KEY_F12 | KEY_SHIFT | KEY_MOD1, +KEY_F13 | KEY_SHIFT | KEY_MOD1, +KEY_F14 | KEY_SHIFT | KEY_MOD1, +KEY_F15 | KEY_SHIFT | KEY_MOD1, +KEY_F16 | KEY_SHIFT | KEY_MOD1, KEY_DOWN | KEY_SHIFT | KEY_MOD1, KEY_UP| KEY_SHIFT | KEY_MOD1, @@ -374,6 +390,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_MOD2 , KEY_F11 | KEY_MOD2 , KEY_F12 | KEY_MOD2 , +KEY_F13 | KEY_MOD2 , +KEY_F14 | KEY_MOD2 , +KEY_F15 | KEY_MOD2 , +KEY_F16 | KEY_MOD2 , KEY_DOWN | KEY_MOD2 , KEY_UP| KEY_MOD2 , @@ -441,6 +461,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_SHIFT | KEY_MOD2, KEY_F11 | KEY_SHIFT | KEY_MOD2, KEY_F12 | KEY_SHIFT | KEY_MOD2, +KEY_F13 | KEY_SHIFT | KEY_MOD2, +KEY_F14 | KEY_SHIFT | KEY_MOD2, +KEY_F15 | KEY_SHIFT | KEY_MOD2, +KEY_F16 | KEY_SHIFT | KEY_MOD2, KEY_DOWN | KEY_SHIFT | KEY_MOD2, KEY_UP| KEY_SHIFT | KEY_MOD2, @@ -505,6 +529,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_MOD1 | KEY_MOD2 , KEY_F11 | KEY_MOD1 | KEY_MOD2 , KEY_F12 | KEY_MOD1 | KEY_MOD2 , +KEY_F13 | KEY_MOD1 | KEY_MOD2 , +KEY_F14 | KEY_MOD1 | KEY_MOD2 , +KEY_F15 | KEY_MOD1 | KEY_MOD2 , +KEY_F16 | KEY_MOD1 | KEY_MOD2 , KEY_DOWN | KEY_MOD1 | KEY_MOD2 , KEY_UP| KEY_MOD1 | KEY_MOD2 , @@ -572,6 +600,10 @@ static USHORT KEYCODE_ARRAY[] = KEY_F10 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, KEY_F11 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, KEY_F12 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, +KEY_F13 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, +KEY_F14 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, +KEY_F15 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, +KEY_F16 | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, KEY_DOWN | KEY_SHIFT | KEY_MOD1 | KEY_MOD2, KEY_UP| KEY_SHIFT | KEY_MOD1 | KEY_MOD2, -- 1.7.3.4 pgpwWGRiwuVTl.pgp Description: PGP signature ___ LibreOffice mailing list
Re: [Libreoffice] Forwarding cell grid question
Hi Christoph, Ferenc, all Christoph Noack schrieb: Hi Ferenc, all, forwarding to libreoffice@lists.freedesktop.org ... There has been a question on the design team mailing list concerning the cell grid - it seems to be drawn in the background, thus, it vanishes if people apply a background color (see picture link below). I don't know whether this is intentional, a bug, ... so I though it's better to ask you. From my UX point-of-view, the grid should be shown on-top. This has been chosen intentionally for compatibility with other spreadsheet programs ... except OpenOffice.org, I assume ... There have been many requests for this feature from those users who use Calc to design input forms; to remove grid lines in selected areas. When designing forms inside spreadsheet, grid lines look very ugly. With target LibO 3.3.1 this feature should be customizable. Please have a look at https://bugs.freedesktop.org/show_bug.cgi?id=30800 for details. From my personal POV most users add colored backgrounds in order to differ between areas instead of creating input forms, therefore I'd like to see the previous behavior as default and the hidden grid lines as selectable option. But perhaps there might be UX survey data about that question... Best regards Bernhard Thanks in advance! Cheers, Christoph PS: I'll moderate answers to des...@libreoffice... Am Donnerstag, den 06.01.2011, 17:38 +0100 schrieb Ferenc Gyenezs: Hi! My question is, is there any way to turn the default cell border always-on-top / show even, when the cell got a background color? http://dl.dropbox.com/u/2842728/grid.jpg I really want to leave OOCalc alone, but i use a lot of cell coloring, and this feature is annoys me. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Make SVG filter export text color
KUROSAWA, Takeshi wrote: I wrote patches for SVG export filter. These fix a bug that texts in an exported SVG are invisible. The most of codes come from Flash export filter (filters/filter/source/swfwriter1.cxx). Hi Takeshi, wonderful, works like a charm - thanks for your patches, pushed! Cheers, -- Thorsten pgpg9ghlOdmIg.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] some changes for better performance, writer.
Sending for review. revol_ diff --git a/sw/source/core/access/accdoc.cxx b/sw/source/core/access/accdoc.cxx index e7b8e8b..c382486 100644 --- a/sw/source/core/access/accdoc.cxx +++ b/sw/source/core/access/accdoc.cxx @@ -95,7 +95,7 @@ void SwAccessibleDocumentBase::SetVisArea() } } -void SwAccessibleDocumentBase::AddChild( Window *pWin, sal_Bool bFireEvent ) +void SwAccessibleDocumentBase::AddChild( Window *pWin, const sal_Bool bFireEvent ) { SolarMutexGuard aGuard; @@ -145,7 +145,7 @@ sal_Int32 SAL_CALL SwAccessibleDocumentBase::getAccessibleChildCount( void ) } uno::Reference XAccessible SAL_CALL -SwAccessibleDocumentBase::getAccessibleChild( sal_Int32 nIndex ) +SwAccessibleDocumentBase::getAccessibleChild( const sal_Int32 nIndex ) throw (uno::RuntimeException, lang::IndexOutOfBoundsException) { @@ -177,13 +177,16 @@ sal_Int32 SAL_CALL SwAccessibleDocumentBase::getAccessibleIndexInParent (void) uno::Reference XAccessibleContext xAcc( mxParent-getAccessibleContext() ); uno::Reference XAccessible xThis( this ); -sal_Int32 nCount = xAcc-getAccessibleChildCount(); - -for( sal_Int32 i=0; i nCount; i++ ) +const sal_Int32 nCount = xAcc-getAccessibleChildCount(); +sal_Int32 i = 0; + +while(i nCount) { -if( xAcc-getAccessibleChild( i ) == xThis ) -return i; + if( xAcc-getAccessibleChild( i ) == xThis ) + return i; + i++; } + return -1L; } @@ -336,7 +339,7 @@ SwAccessibleDocument::~SwAccessibleDocument() pWin-RemoveChildEventListener( LINK( this, SwAccessibleDocument, WindowChildEventListener )); } -void SwAccessibleDocument::Dispose( sal_Bool bRecursive ) +void SwAccessibleDocument::Dispose( const sal_Bool bRecursive ) { OSL_ENSURE( GetFrm() GetMap(), already disposed ); @@ -471,7 +474,7 @@ void SwAccessibleDocument::selectAccessibleChild( } sal_Bool SwAccessibleDocument::isAccessibleChildSelected( -sal_Int32 nChildIndex ) +const sal_Int32 nChildIndex ) throw ( lang::IndexOutOfBoundsException, uno::RuntimeException ) { @@ -497,7 +500,7 @@ sal_Int32 SwAccessibleDocument::getSelectedAccessibleChildCount( ) } uno::ReferenceXAccessible SwAccessibleDocument::getSelectedAccessibleChild( -sal_Int32 nSelectedChildIndex ) +const sal_Int32 nSelectedChildIndex ) throw ( lang::IndexOutOfBoundsException, uno::RuntimeException) { @@ -506,7 +509,7 @@ uno::ReferenceXAccessible SwAccessibleDocument::getSelectedAccessibleChild( // -- OD 2004-11-16 #111714# - index has to be treated as global child index. void SwAccessibleDocument::deselectAccessibleChild( -sal_Int32 nChildIndex ) +const sal_Int32 nChildIndex ) throw ( lang::IndexOutOfBoundsException, uno::RuntimeException ) { ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout
Hi Khaled, Michael, On 07/01/2011 8:21 PM, Michael Meeks wrote: Drat; we took ages to reply. I suspect Thorsten might be able to help, but failing that the best text expert I'm aware of is Tim (CC'd) who may be able to give some advice. SIL's Graphite integration would undoubtedly have fallen over the same sort of problems, and no doubt he can give some pointers to how to work around it - Tim ? :-) I've been working on the Graphite integration more recently, so I'll try to make a few comments. Anyway, it turned out that the issue is not specific to kerning nor Arabic, but affects all horizontal glyph positioning in the ICU layout path; the problem does not show on Windows nor with Graphite fonts and of course not with con-CTL. It certainly sounds like it is worth fixing. The X adjustment of glyph widths is simply ignored, and glyphs are drawn stacked after each other baased on their original width, which results in kerning being ignored as well as other forms of glyph positioning like cursive anchors, however vertical glyph positions (in the Y access) are OK. It depends on the rendering path, different parts of libo call the layout methods in different ways. In source/glyphs/gcach_layout.cxx, ICU's layoutChars() is called and new glyph indices and positions are returned, which is then fed into SalLayout in the form of GlyphItem's. Though GlyphItem has maLinearPos which holds its absolute position, many places in the code re-calculate glyph position from its mnOrigWidth (original glyph width) and mnNewWidth (width after adjustments), but the ICU path simply sets mnNewWidth to mnOrigWidth since ICU layout engine does not return individual glyph widths, resulting in failure of glyph position re-calculation which manifests in this bug. As a prove of concept, the attached patch trays to set mnNewWidth in a very hackish way by subtracting current glyph position from the of next non-diacritic (+ve) glyph. It does indeed fix the problem (see the attached screenshots), but it looks very unreliable to me. I think subtracting the glyph positions is a reasonable approach, something similar is done in the graphite integration code to get the numbers into a form that works with libo's logic. May be a cleaner solution is to re-implement all the broken virtual methods to eliminate the re-calculation part. Do you mean implement ICU/ServerFontLayout specific versions of the methods that ServerFontLayout is currently using directly from GenericSalLayout? I think that would be quite a lot of work and you may still need something like mnNewWidth calculated in a similar way to your patch. I admit that GraphiteLayout does reimplement those methods so if it turns out there is an assumption in GenericSalLayout which doesn't fit well with ICU then that might still make sense. The recalculations are done in several situations such as for justification, text expansion, text contraction. In writer the text is rendered once with a small font size and once with a large font size. It then does some calculations to try to give a more accurate WYSIWYG positioning of the text on screen which results in small adjustments being applied to the glyph positions (but the request to adjust is based on characters). It is probably the later which is interacting with the incorrect mnNewWidth to give the bad positions. Looking more carefully at the patch, there are a few points that may need more consideration: a) It may be possible for glyphs to be out of order, in which case nNewWidth = pNextPos-fX - pPos-fX; might result in a negative value even when the nominal nNextGlyphWidth is positive, which could cause problems. b) The glyphs are resorted a bit later in IcuLayoutEngine::operator() with a rLayout.SortGlyphItems(); call. This might upset the new width values. However, it seems to only reorder diacritics and those are skipped for the width calculation, so that is probably alright. c) For the last glyph in a run, pNextPos will still be valid (see LayoutEngine::getGlyphPositions docs), so I think it should be used for the nNewWidth calculation. It should be tested with some CTL scripts including reordering and lots of diacritics to check the edge cases are covered. The width will also affect font fallback (calls from MultiSalLayout), so that needs to be tested as well. Best regards, Keith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Reducing chmod spawning by replacing exec by xargs
Hello, I used xargs instead of -exec to reduce chmod spawning. Hope there's no mistake in it. Julien. commit d5a814812d592d36db85575bb80ab73817cd3e78 Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jan 8 02:01:25 2011 +0100 Reducing spawning of chmod with xargs instead of exec diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm index 9e9ef1e..84efc6e 100644 --- a/solenv/bin/modules/installer/epmfile.pm +++ b/solenv/bin/modules/installer/epmfile.pm @@ -2408,7 +2408,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package, # that is saved in temp directory -$systemcall = cd $packagestempdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $packagestempdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); @@ -2471,7 +2471,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package -$systemcall = cd $destinationdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $destinationdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout
On Fri, Jan 07, 2011 at 11:25:33PM +0100, Thorsten Behrens wrote: Khaled Hosny wrote: Anyway, it turned out that the issue is not specific to kerning nor Arabic, but affects all horizontal glyph positioning in the ICU layout path; the problem does not show on Windows nor with Graphite fonts and of course not with con-CTL. The X adjustment of glyph widths is simply ignored, and glyphs are drawn stacked after each other baased on their original width, which results in kerning being ignored as well as other forms of glyph positioning like cursive anchors, however vertical glyph positions (in the Y access) are OK. Hi Khaled, wow, many thanks for your detailed analysis - that's actually usually the hardest part for most of the bugs. :) I'll look into this early next week. Great, glade it helps and hop long standing bug will get fixed :) Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Standard-color-palette-updates
Hi Kami, all, Christoph Noack schrieb: Hi Kami! Am Freitag, den 07.01.2011, 10:54 +0100 schrieb Kálmán „KAMI” Szalai: Hi Christoph, Bernhard, LibO Gurus, Then I provide patch for removing colors from main palette, and create/update a separated palette. Is it okay? That would more than okay, that would be great! :-) Same from my side: This would be the best implementation of the LibO branding colors! Perhaps you can keep the descriptive name Christoph provided: LibreOffice_Initial-Branding-Colors.soc or add the year for a clear distinction from future branding colors: LibreOffice_Initial-Branding-Colors_2010.soc Best regards and thanks again! Bernhard [...] http://wiki.documentfoundation.org/Marketing/Branding#Resources_3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-design] Change application background [was: How to contribute ?]
Hi Rahul, all, Rahul Prasad schrieb: [..] * I was thinking of a nice background instead of a static colour. You can find some of my design here http://rahulprasad.com/public/libreOffice/writer/ Although design is not very appealing, but I am sure people will come come up with better design.* This idea has already been presented some time ago in the OOo UX project, but has not been implemented by now (AFAIK). I can't find the proposal right now, but I'm quite sure, Christoph knows where to find it. As our structure is different from the OOo project, it is much more likely that your ideas might become implemented. What you need is a developer interested in adding a choose background color/image-feature to the product. I'm forwarding this mail to the developer list, CC'ing you, so you should get their replies even if you didn't subscribe to this list via http://lists.freedesktop.org/mailman/listinfo/libreoffice I don't know if this feature is easy or hard to implement, but perhaps it can be added to the list of easy hacks: http://wiki.documentfoundation.org/Development/Easy_Hacks ... where developer can pick it. Best regards Bernhard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Reducing chmod spawning by replacing exec by xargs
Hello, I used xargs instead of -exec to reduce chmod spawning. Hope there's no mistake in it. Julien PS : the first sending seemed not having worked. commit d5a814812d592d36db85575bb80ab73817cd3e78 Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jan 8 02:01:25 2011 +0100 Reducing spawning of chmod with xargs instead of exec diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm index 9e9ef1e..84efc6e 100644 --- a/solenv/bin/modules/installer/epmfile.pm +++ b/solenv/bin/modules/installer/epmfile.pm @@ -2408,7 +2408,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package, # that is saved in temp directory -$systemcall = cd $packagestempdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $packagestempdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); @@ -2471,7 +2471,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package -$systemcall = cd $destinationdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $destinationdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove commented code
These three patches remove large blocks of commented code in sdk, components and libs-gui respectively. All code has been commented out at least since 2005. Anders Jonsson, (LGPLv3+, MPL) From bd135dcc65666baf7317d02ba2ed9eecb35d8b2e Mon Sep 17 00:00:00 2001 From: Anders Jonsson anders.jons...@norsjonet.se Date: Sat, 8 Jan 2011 13:57:29 +0100 Subject: Remove block of commented code --- .../Components/CppComponent/service1_impl.cxx | 64 1 files changed, 0 insertions(+), 64 deletions(-) diff --git a/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx b/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx index a6933ce..1c5e49a 100644 --- a/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx +++ b/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx @@ -244,68 +244,4 @@ Reference XInterface SAL_CALL create_MyService2Impl( } -/* -extern C void SAL_CALL component_getImplementationEnvironment( -sal_Char const ** ppEnvTypeName, uno_Environment ** ) -{ -*ppEnvTypeName = CPPU_CURRENT_LANGUAGE_BINDING_NAME; -} - -extern C sal_Bool SAL_CALL component_writeInfo( -lang::XMultiServiceFactory * xMgr, registry::XRegistryKey * xRegistry ) -{ -if (xRegistry) -{ -try -{ -// implementation of MyService1A -Reference registry::XRegistryKey xKey( -xRegistry-createKey( OUString( RTL_CONSTASCII_USTRINGPARAM( -my_module.my_sc_implementation.MyService1/UNO/SERVICES) ) ) ); -// subkeys denote implemented services of implementation -xKey-createKey( OUString( RTL_CONSTASCII_USTRINGPARAM( -my_module.MyService1) ) ); -// implementation of MyService1B -xKey = xRegistry-createKey( OUString( RTL_CONSTASCII_USTRINGPARAM( -my_module.my_sc_implementation.MyService2/UNO/SERVICES) ) ); -// subkeys denote implemented services of implementation -xKey-createKey( OUString( RTL_CONSTASCII_USTRINGPARAM( -my_module.MyService2) ) ); -return sal_True; // success -} -catch (registry::InvalidRegistryException ) -{ -// function fails if exception caught -} -} -return sal_False; -} -extern C void * SAL_CALL component_getFactory( -sal_Char const * implName, lang::XMultiServiceFactory * xMgr, void * ) -{ -Reference lang::XSingleComponentFactory xFactory; -if (0 == ::rtl_str_compare( implName, my_module.my_sc_implementation.MyService1 )) -{ -// create component factory for MyService1 implementation -OUString serviceName( RTL_CONSTASCII_USTRINGPARAM(my_module.MyService1) ); -xFactory = ::cppu::createSingleComponentFactory( -::my_sc_impl::create_MyService1Impl, -OUString( RTL_CONSTASCII_USTRINGPARAM(my_module.my_sc_implementation.MyService1) ), -Sequence OUString ( serviceName, 1 ) ); -} -else if (0 == ::rtl_str_compare( implName, my_module.my_sc_implementation.MyService2 )) -{ -// create component factory for MyService12 implementation -OUString serviceName( RTL_CONSTASCII_USTRINGPARAM(my_module.MyService2) ); -xFactory = ::cppu::createSingleComponentFactory( -::my_sc_impl::create_MyService2Impl, -OUString( RTL_CONSTASCII_USTRINGPARAM(my_module.my_sc_implementation.MyService2) ), -Sequence OUString ( serviceName, 1 ) ); -} -if (xFactory.is()) -xFactory-acquire(); -return xFactory.get(); // return acquired interface pointer or null -} -*/ - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- 1.7.1 From 16da339cefa87de0f1b5bb25da9e2abc222d9826 Mon Sep 17 00:00:00 2001 From: Anders Jonsson anders.jons...@norsjonet.se Date: Sat, 8 Jan 2011 13:32:08 +0100 Subject: Remove commented code --- basctl/source/basicide/tbxctl.cxx | 79 --- xmlsecurity/source/xmlsec/errorcallback.cxx | 137 --- 2 files changed, 0 insertions(+), 216 deletions(-) diff --git a/basctl/source/basicide/tbxctl.cxx b/basctl/source/basicide/tbxctl.cxx index f7cb3ba..4dba82d 100644 --- a/basctl/source/basicide/tbxctl.cxx +++ b/basctl/source/basicide/tbxctl.cxx @@ -52,68 +52,6 @@ SFX_IMPL_TOOLBOX_CONTROL( TbxControls, SfxAllEnumItem ) /* |* -|* WorkWindow Alignment -|* -\/ -/* -IMPL_LINK( PopupWindowTbx, SelectHdl, void*, EMPTYARG ) -{ -if ( IsInPopupMode() ) -EndPopupMode(); - -aSelectLink.Call( aTbx.GetToolBox() ); - -return 0; -} - -PopupWindowTbx::PopupWindowTbx( USHORT nId, WindowAlign eAlign, -ResId aRIdWin, ResId aRIdTbx, -SfxBindings rBind ) : -
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 32897, which changed state. Bug 32897 Summary: templates have hard-coded language https://bugs.freedesktop.org/show_bug.cgi?id=32897 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Reducing chmod spawning by replacing exec by xargs
Hello, I used xargs instead of -exec to reduce chmod spawning. Hope there's no mistake in it. Julien PS : the 2 sendings with my yahoo.fr address seemed not having worked. commit d5a814812d592d36db85575bb80ab73817cd3e78 Author: Julien Nabet serval2...@yahoo.fr Date: Sat Jan 8 02:01:25 2011 +0100 Reducing spawning of chmod with xargs instead of exec diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm index 9e9ef1e..84efc6e 100644 --- a/solenv/bin/modules/installer/epmfile.pm +++ b/solenv/bin/modules/installer/epmfile.pm @@ -2408,7 +2408,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package, # that is saved in temp directory -$systemcall = cd $packagestempdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $packagestempdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); @@ -2471,7 +2471,7 @@ sub create_packages_without_epm # Setting unix rights to 775 for all created directories inside the package -$systemcall = cd $destinationdir; find $packagename -type d -exec chmod 775 \{\} \\\;; +$systemcall = cd $destinationdir; find $packagename -type d | xargs -i chmod 775 \{\} \;; installer::logger::print_message( ... $systemcall ...\n ); $returnvalue = system($systemcall); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translations of comments in writer/sw/inc
some more translations. From d79d2c0dfcdeb3d134bf6ca5a1f1bc3419aadb38 Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Sat, 8 Jan 2011 02:37:47 +0100 Subject: [PATCH] Translations of comments in writer/sw/inc --- sw/inc/IDocumentLinksAdministration.hxx | 20 +--- sw/inc/IDocumentRedlineAccess.hxx | 77 --- sw/inc/IDocumentState.hxx | 24 ++ sw/inc/IDocumentStatistics.hxx | 10 +--- sw/inc/IDocumentStylePoolAccess.hxx | 20 +++- sw/inc/IDocumentUndoRedo.hxx| 59 6 files changed, 58 insertions(+), 152 deletions(-) diff --git a/sw/inc/IDocumentLinksAdministration.hxx b/sw/inc/IDocumentLinksAdministration.hxx index 2d6b282..46a5ef4 100644 --- a/sw/inc/IDocumentLinksAdministration.hxx +++ b/sw/inc/IDocumentLinksAdministration.hxx @@ -40,20 +40,14 @@ namespace sfx2 { class SvLinkSource; class LinkManager; } class IDocumentLinksAdministration { public:-/** Links un-/sichtbar in LinkManager einfuegen (gelinkte Bereiche) +/** Insert links in-/visibly into LinkManager (linked ranges). */ virtual bool IsVisibleLinks() const = 0; -/** -*/ virtual void SetVisibleLinks(bool bFlag) = 0; -/** -*/ virtual sfx2::LinkManager GetLinkManager() = 0; -/** -*/ virtual const sfx2::LinkManager GetLinkManager() const = 0; /** #i42634# Moved common code of SwReader::Read() and @@ -61,28 +55,20 @@ namespace sfx2 { class SvLinkSource; class LinkManager; } */ virtual void UpdateLinks(BOOL bUI) = 0; -/** SS fuers Linken von Dokumentteilen +/** SS fuers Linken von Dokumentteilen / ?? for linking of parts of documents. */ virtual bool GetData(const String rItem, const String rMimeType, ::com::sun::star::uno::Any rValue) const = 0; -/** -*/ virtual bool SetData(const String rItem, const String rMimeType, const ::com::sun::star::uno::Any rValue) = 0; -/** -*/ virtual ::sfx2::SvLinkSource* CreateLinkSource(const String rItem) = 0; -/** embedded alle lokalen Links (Bereiche/Grafiken) +/** Embed all local links (ranges/graphics). */ virtual bool EmbedAllLinks() = 0; -/** -*/ virtual void SetLinksUpdated(const bool bNewLinksUpdated) = 0; -/** -*/ virtual bool LinksUpdated() const = 0; protected: diff --git a/sw/inc/IDocumentRedlineAccess.hxx b/sw/inc/IDocumentRedlineAccess.hxx index 97f53e8..d3a125c 100644 --- a/sw/inc/IDocumentRedlineAccess.hxx +++ b/sw/inc/IDocumentRedlineAccess.hxx @@ -60,31 +60,31 @@ namespace nsRedlineMode_t const RedlineMode_t REDLINE_SHOW_DELETE = 0x20;// show all delets const RedlineMode_t REDLINE_SHOW_MASK = REDLINE_SHOW_INSERT | REDLINE_SHOW_DELETE; -// fuer die interne Verwaltung: -// die originalen Redlines inclusive des Contents entfernen -// (ClipBoard/Textbausteine) +// For internal management: +// remove the original Redlines together with their content +// (Clipboard/text modules). const RedlineMode_t REDLINE_DELETE_REDLINES = 0x100; -// beim Loeschen innerhalb ein RedlineObjectes, waehrend des Appends, -// das DeleteRedline ignorieren +// When deleting within a RedlineObject +// ignore the DeleteRedline during Append. const RedlineMode_t REDLINE_IGNOREDELETE_REDLINES = 0x200; -// don't combine any readlines. This flags is may only used in the Undo. +// don't combine any readlines. This flag may be only used in Undo. const RedlineMode_t REDLINE_DONTCOMBINE_REDLINES = 0x400; } typedef USHORT RedlineType_t; namespace nsRedlineType_t { -// die RedlineTypen gehen von 0 bis 127 -const RedlineType_t REDLINE_INSERT = 0x0;// Inhalt wurde eingefuegt -const RedlineType_t REDLINE_DELETE = 0x1;// Inhalt wurde geloescht -const RedlineType_t REDLINE_FORMAT = 0x2;// Attributierung wurde angewendet -const RedlineType_t REDLINE_TABLE = 0x3;// TabellenStruktur wurde veraendert -const RedlineType_t REDLINE_FMTCOLL = 0x4;// FormatVorlage wurde veraendert (Autoformat!) - -// ab 128 koennen Flags hineinverodert werden +// Range of RedlineTypes is 0 to 127. +const RedlineType_t REDLINE_INSERT = 0x0;// Content has been inserted. +const RedlineType_t REDLINE_DELETE = 0x1;// Content has been deleted. +const RedlineType_t REDLINE_FORMAT = 0x2;// Attributes have been applied. +const RedlineType_t REDLINE_TABLE = 0x3;// Table structure has been altered. +const RedlineType_t REDLINE_FMTCOLL = 0x4;// Style has been altered (Autoformat!). + +// When larger than 128, flags can be inserted. const RedlineType_t REDLINE_NO_FLAG_MASK = 0x7F; //const RedlineType_t REDLINE_FLAG_MASK = 0xFF80; -const RedlineType_t REDLINE_FORM_AUTOFMT = 0x80;// kann als Flag im RedlineType stehen +const
[Libreoffice] [PATCH] Transl. German comments in sw/inc/IDocumentFieldsAccess.hxx
From c027b32054bd6222aee64757d0e87af373ad421b Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Fri, 7 Jan 2011 23:58:52 +0100 Subject: [PATCH] Transl. German comments in sw/inc/IDocumentFieldsAccess.hxx Only one comment in this file. In case whitespace of the patch in the body of this mail got messed up again (if so, please let me know) I additionally put it in attachment (patch is under the LGPLv2+/MPL). --- sw/inc/IDocumentFieldsAccess.hxx | 55 +++-- 1 files changed, 5 insertions(+), 50 deletions(-) diff --git a/sw/inc/IDocumentFieldsAccess.hxx b/sw/inc/IDocumentFieldsAccess.hxx index 0beafdd..2e4e4b3 100644 --- a/sw/inc/IDocumentFieldsAccess.hxx +++ b/sw/inc/IDocumentFieldsAccess.hxx @@ -54,32 +54,18 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } } class IDocumentFieldsAccess { public: -/** -*/ virtual const SwFldTypes *GetFldTypes() const = 0; -/** -*/ virtual SwFieldType *InsertFldType(const SwFieldType ) = 0; -/** -*/ virtual SwFieldType *GetSysFldType( const sal_uInt16 eWhich ) const = 0; -/** -*/ virtual SwFieldType* GetFldType(sal_uInt16 nResId, const String rName, bool bDbFieldMatching) const = 0; -/** -*/ virtual void RemoveFldType(sal_uInt16 nFld) = 0; -/** -*/ virtual void UpdateFlds( SfxPoolItem* pNewHt, bool bCloseDB) = 0; -/** -*/ virtual void InsDeletedFldType(SwFieldType ) = 0; /** @@ -96,8 +82,6 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } } */ virtual bool PutValueToField(const SwPosition rPos, const com::sun::star::uno::Any rVal, USHORT nWhich) = 0; -// rufe das Update der Expression Felder auf; alle Ausdruecke werden -// neu berechnet. /** Updates a field. @@ -111,39 +95,22 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } } */ virtual bool UpdateFld(SwTxtFld * rDstFmtFld, SwField rSrcFld, SwMsgPoolItem * pMsgHnt, bool bUpdateTblFlds) = 0; -/** -*/ virtual void UpdateRefFlds(SfxPoolItem* pHt) = 0; -/** -*/ virtual void UpdateTblFlds(SfxPoolItem* pHt) = 0; -/** -*/ virtual void UpdateExpFlds(SwTxtFld* pFld, bool bUpdateRefFlds) = 0; -/** -*/ virtual void UpdateUsrFlds() = 0; -/** -*/ virtual void UpdatePageFlds(SfxPoolItem*) = 0; -/** -*/ virtual void LockExpFlds() = 0; -/** -*/ virtual void UnlockExpFlds() = 0; -/** -*/ virtual bool IsExpFldsLocked() const = 0; - virtual SwDocUpdtFld GetUpdtFlds() const = 0; /*@@@MAINTAINABILITY-HORROR@@@ @@ -152,35 +119,23 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } } */ virtual bool SetFieldsDirty(bool b, const SwNode* pChk, ULONG nLen) = 0; -/** -*/ virtual void SetFixFields(bool bOnlyTimeDate, const DateTime* pNewDateTime) = 0; -// Setze im Calculator alle SetExpresion Felder, die bis zur -// angegebenen Position (Node [ + ::com::sun::star::ucb::Content]) gueltig sind. Es kann -// eine erzeugte Liste aller Felder mit uebergegeben werden. -// (ist die Adresse != 0, und der Pointer == 0 wird eine neue -// Liste returnt.) + +// In Calculator set all SetExpression fields that are valid up to the indicated position +// (Node [ + ::com::sun::star::ucb::Content]). +// A generated list of all fields may be passed along too +// (if the addreess != 0 and the pointer == 0 a new list will be returned). virtual void FldsToCalc(SwCalc rCalc, ULONG nLastNd, sal_uInt16 nLastCnt) = 0; -/** -*/ virtual void FldsToCalc(SwCalc rCalc, const _SetGetExpFld rToThisFld) = 0; -/** -*/ virtual void FldsToExpand(SwHash** ppTbl, sal_uInt16 rTblSize, const _SetGetExpFld rToThisFld) = 0; -/** -*/ virtual bool IsNewFldLst() const = 0; -/** -*/ virtual void SetNewFldLst( bool bFlag) = 0; -/** -*/ virtual void InsDelFldInFldLst(bool bIns, const SwTxtFld rFld) = 0; protected: -- 1.7.1 From c027b32054bd6222aee64757d0e87af373ad421b Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Fri, 7 Jan 2011 23:58:52 +0100 Subject: [PATCH] Transl. German comments in sw/inc/IDocumentFieldsAccess.hxx --- sw/inc/IDocumentFieldsAccess.hxx | 55 +++-- 1 files changed, 5 insertions(+), 50 deletions(-) diff --git a/sw/inc/IDocumentFieldsAccess.hxx b/sw/inc/IDocumentFieldsAccess.hxx index 0beafdd..2e4e4b3 100644 --- a/sw/inc/IDocumentFieldsAccess.hxx +++ b/sw/inc/IDocumentFieldsAccess.hxx @@ -54,32 +54,18 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } } class IDocumentFieldsAccess { public: -/** -*/ virtual const SwFldTypes *GetFldTypes()
Re: [Libreoffice] [PUSHED] Re: [PATCH] Again cppcheck cleanliness
Le 08/01/2011 08:39, Julien Nabet a écrit : On Fri, 2011-01-07 at 11:07 +, Caolán McNamara wrote: / On Thu, 2011-01-06 at 20:36 +0100, Guillaume Poussel wrote: //Hi everybody, // // //A new patch which correct cppcheck warnings in base/. // // Looks good, pushed. Thanks for this. / Oops, I see now that cppcheck isn't run with sufficient -I flags to find includes, so it wasn't able to see that pDesc is actually used by some MACRO stuff which was hidden from it, so these were cppcheck false positives, as are probably the missing ctor warnings. I fixed up the pDesc ones again in a way to hide them from cppcheck again. We probably should figure out how to sufficient -I flags to cppcheck to get it to find the includes. This is probably a bit tricky unless we add a make cppcheck or something to libreoffice itself or something. C. Hello, About cppcheck, perhaps it should be useful to use the latest version of cppcheck on the git repository. I attached the git log of what has been done since 14th of December (date of the release of 1.46.1). We can see that a lot of false positives have been corrected. I don't understand too the part about hiding something from cppcheck, wouldn't it be better to declare a new bug to cppcheck tracker ? But perhaps I misunderstood something Julien. commit d27b6a159893d89cefc40d872a16e25290273d14 Author: Daniel Marjamäki daniel...@spray.se Date: Fri Jan 7 20:48:02 2011 +0100 astyle formatting commit 14cbaebfe2bf898d43d20ecfebf90fbf0be08be4 Author: Daniel Marjamäki daniel...@spray.se Date: Fri Jan 7 20:45:33 2011 +0100 Fixed #2428 (false alarm with code containing a throw clause) commit 989e0e7ccb7b77e5d5327d155128404649113e89 Author: Daniel Marjamäki daniel...@spray.se Date: Fri Jan 7 19:48:51 2011 +0100 Preprocessor: fix bug when determining location when there is a missing include. ticket: #2326 commit 5f078da7adcb32385448df351cb7c557b959b780 Author: Robert Reif r...@earthlink.net Date: Fri Jan 7 18:58:14 2011 +0100 Fixed #2425 (segmentation fault of cppcheck) commit 9b66f7a754e53c3118d949320ae29d2d0cd172f7 Author: Ettl Martin ettl.mar...@gmx.de Date: Fri Jan 7 12:27:12 2011 +0100 #ticket 2429: added a test to the mathlib to ensure the used floating point number is recognized correctly commit bfc95e01c115723dee104343984380a73061d621 Author: Robert Reif r...@earthlink.net Date: Fri Jan 7 08:02:47 2011 +0100 Fixed #2426 (### Internal error in Cppcheck. Please report it.) commit 56ffde402f753f331f97f1b652127786acd3d04f Author: Robert Reif r...@earthlink.net Date: Fri Jan 7 07:42:00 2011 +0100 Fixed #2425 (segmentation fault of cppcheck) commit 5eeb18dcd7f0b8e0083e4e20aad900cc87780e81 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 20:53:22 2011 +0100 scripts: update 'comment.pl' so it understand /* commit 1b3a5ed0be34c8a86484a17825f816240448a6be Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 20:16:14 2011 +0100 Tokenizer: simplify NULL to 0 in the normal token list commit a7835c405454e7f18fccb56488f3c661097735c2 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 20:01:09 2011 +0100 Preprocessor: Reverted fix for #2131, it didn't work well so a better fix is needed commit 6e0f6c5aec0302ba939c53ce441b9c0e485996b3 Author: Kimmo Varis kim...@gmail.com Date: Thu Jan 6 20:45:07 2011 +0200 GUI: Add comment about storing paths. commit 2a93aa9fce34e705c034027dd3e74085ad173175 Author: Kimmo Varis kim...@gmail.com Date: Thu Jan 6 18:32:04 2011 +0200 GUI: Convert path to native separators before copying it. Ticket #2424 (Windows GUI: Copy full path doesn't copy the visible full path if it has been changed in preferences) We keep paths internally with / separator and only convert to native separators (for Windows) when showing them. Conversion was missing from path copying function. commit 37b1f7c296cc8594667d334ab071340ddc5cdf5c Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 16:27:22 2011 +0100 memsetZeroBytes: improved error message. ticket: #2421 commit 77ed6ecb5d5c63efc931febc29f64878cc3c7a70 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 13:18:49 2011 +0100 Null pointers: Added comments commit 04a117938d3905ab59e8da5fa134239d47e8b0b0 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 13:02:21 2011 +0100 Buffer overrun: Added comments commit f838f89d01a9a6b2721b8aa47fb6440e12bade00 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 12:42:02 2011 +0100 scripts: reduced false positives given by 'comments.pl'. given when declaring operator= commit ca294544ca655bec82401357904b0ed103b27631 Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 12:20:54 2011 +0100 CheckStl: Added comments commit 616914c1ff9170e38c22a032e41fac4bb373e8cf Author: Daniel Marjamäki daniel...@spray.se Date: Thu Jan 6 12:07:37
[Libreoffice] [PATCH] Remove unused code and fix typos
Hi, Here is a bunch of cleanup on base. Cheers, -- Takeshi Abe From 17a5c538b6e9ed1c13efda786e39986a82163a98 Mon Sep 17 00:00:00 2001 From: Takeshi Abe t...@fixedpoint.jp Date: Sun, 9 Jan 2011 02:04:00 +0900 Subject: [PATCH] Remove unused code and fix typos --- dbaccess/source/core/api/RowSetCache.cxx |1 - dbaccess/source/core/api/tablecontainer.cxx|3 +-- dbaccess/source/core/api/viewcontainer.cxx |1 - .../source/core/dataaccess/definitioncontainer.cxx |2 +- dbaccess/source/ui/dlg/ConnectionHelper.cxx| 10 +++--- dbaccess/source/ui/dlg/ConnectionPageSetup.cxx |1 - dbaccess/source/ui/dlg/ExtensionNotPresent.cxx |1 - dbaccess/source/ui/dlg/adminpages.cxx |2 +- dbaccess/source/ui/inc/ExtensionNotPresent.hxx |4 dbaccess/source/ui/inc/WTabPage.hxx|2 +- dbaccess/source/ui/misc/HtmlReader.cxx |4 dbaccess/source/ui/misc/UITools.cxx|1 - dbaccess/source/ui/misc/WColumnSelect.cxx |2 -- dbaccess/source/ui/querydesign/JoinTableView.cxx |9 - dbaccess/source/ui/uno/dbinteraction.cxx |2 +- reportdesign/inc/reportformula.hxx |2 +- reportdesign/qa/complex/ReportDesignerTest.java|8 reportdesign/source/core/sdr/RptPage.cxx |1 - reportdesign/source/core/sdr/UndoEnv.cxx |2 -- reportdesign/source/ui/inc/DateTime.hxx|1 - reportdesign/source/ui/inc/FixedTextColor.hxx |2 -- .../source/ui/inc/ReportControllerObserver.hxx |8 +--- reportdesign/source/ui/inc/ViewsWindow.hxx |2 -- .../ui/inspection/ReportComponentHandler.cxx |1 - reportdesign/source/ui/report/ReportSection.cxx|2 +- 25 files changed, 15 insertions(+), 59 deletions(-) diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx index bd2f8b8..f795ce7 100644 --- a/dbaccess/source/core/api/RowSetCache.cxx +++ b/dbaccess/source/core/api/RowSetCache.cxx @@ -186,7 +186,6 @@ ORowSetCache::ORowSetCache(const Reference XResultSet _xRs, } catch(const Exception) { -// DBG_UNHANDLED_EXCEPTION(); } m_pCacheSet = NULL; m_xCacheSet.clear(); diff --git a/dbaccess/source/core/api/tablecontainer.cxx b/dbaccess/source/core/api/tablecontainer.cxx index 6aa893e..d139482 100644 --- a/dbaccess/source/core/api/tablecontainer.cxx +++ b/dbaccess/source/core/api/tablecontainer.cxx @@ -130,7 +130,6 @@ OTableContainer::OTableContainer(::cppu::OWeakObject _rParent, OTableContainer::~OTableContainer() { RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, api, ocke.jans...@sun.com, OTableContainer::OTableContainer ); -// dispose(); DBG_DTOR(OTableContainer, NULL); } @@ -480,7 +479,7 @@ void SAL_CALL OTableContainer::disposing() { RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, api, ocke.jans...@sun.com, OTableContainer::disposing ); OFilteredContainer::disposing(); -// say our listeners goobye +// say our listeners goodbye m_xTableDefinitions = NULL; m_pTableMediator = NULL; } diff --git a/dbaccess/source/core/api/viewcontainer.cxx b/dbaccess/source/core/api/viewcontainer.cxx index 4589fb9..3a2d965 100644 --- a/dbaccess/source/core/api/viewcontainer.cxx +++ b/dbaccess/source/core/api/viewcontainer.cxx @@ -89,7 +89,6 @@ OViewContainer::OViewContainer(::cppu::OWeakObject _rParent OViewContainer::~OViewContainer() { -// dispose(); DBG_DTOR(OViewContainer, NULL); } diff --git a/dbaccess/source/core/dataaccess/definitioncontainer.cxx b/dbaccess/source/core/dataaccess/definitioncontainer.cxx index a918726..9638290 100644 --- a/dbaccess/source/core/dataaccess/definitioncontainer.cxx +++ b/dbaccess/source/core/dataaccess/definitioncontainer.cxx @@ -135,7 +135,7 @@ void SAL_CALL ODefinitionContainer::disposing() MutexGuard aGuard(m_aMutex); -// say our listeners goobye +// say our listeners goodbye EventObject aEvt(*this); m_aApproveListeners.disposeAndClear(aEvt); m_aContainerListeners.disposeAndClear(aEvt); diff --git a/dbaccess/source/ui/dlg/ConnectionHelper.cxx b/dbaccess/source/ui/dlg/ConnectionHelper.cxx index 0cf7283..b1d0971 100644 --- a/dbaccess/source/ui/dlg/ConnectionHelper.cxx +++ b/dbaccess/source/ui/dlg/ConnectionHelper.cxx @@ -58,7 +58,6 @@ #include com/sun/star/ui/dialogs/XFolderPicker.hpp #include com/sun/star/sdbc/XRow.hpp #include com/sun/star/awt/XWindow.hpp -// #106016# #include com/sun/star/task/XInteractionHandler.hpp #include com/sun/star/ucb/XProgressHandler.hpp #include UITools.hxx @@ -328,7 +327,6 @@ DBG_NAME(OConnectionHelper) if (RET_OK == aSelector.Execute()) {
[Libreoffice] calling web services
Hi, supposing I would venture in writing a content provider implemented in C++ , to make a CMIS repository accessible to libreoffice, what library should I use for accessing the web services on the server? Best regards, Dan. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix passing distro specific branding via configure
Hi, Thank you for comiting it. I converted the files and updated the distro confs too. http://cgit.freedesktop.org/libreoffice/build/commit/?h=libreoffice-3-3id=06f0119fbc662320da7962a9bb048a1e55a62fa1 KAMI 2011-01-05 19:46 keltezéssel, Petr Mladek írta: Hi, the configure options --with-intro-bitmaps, --with-about-bitmaps did not longer worked. I think that nobody needs more pictures. The attached patches rename the above options to pass only one picture and fix the stuff to work. KAMI, could you sign it off for libreoffice-3-3 branch? Best Regards, Petr -- Best regards, Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com My favorite projects: OxygenOffice Professional http://ooop.sf.net/ - office suite - for everybody | Magyarul http://hun.sf.net/ - In Hungarian Blog http://bit.ly/10ucTR | Support http://bit.ly/eYZO6 Follow me http://bit.ly/gJuJZ, if you can http://bit.ly/kDocB signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Oracle wordbook in LibO
On Sat, Jan 08, 2011 at 12:43:43AM +0100, Andrea Pescetti wrote: Petr Mladek wrote: Andrea Pescetti píše v Pá 07. 01. 2011 v 02:29 +0100: - It removes all the application names: Writer, Calc, Impress... Hmm, I am not sure if these are language independent names. Sophie, what do you think? As far as I know, the application names are typically untranslated and I don't know of any localization using translated names. I can say for sure that they were never translated in the Italian version, in 1.x, 2.x or 3.x. But it's good to check with Sophie, French tend to translate much more technical terms than Italian do! For language not written in Latin script they are likely to get transliterated, we certainly do that in Arabic. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Really use BrOffice in the linux desktop files
Hi Michael, could you please sign off the attached patch? It is needed to create the linux desktop files with Name[pt_BR]=BrOffice 3.3. I am sorry, I havn't managed to verify your original fix before 3.3-rc2 release. I have lated found that it did not work because of: + * dekstop files need pt_BR instead of pt-BR (undescore vs. dash) * %PRODUCTNAME_BR was wrongly substituted to ${PRODUCTNAME} ${PRODUCTVERSION}_BR; it should be ${PRODUCTNAME_BR} ${PRODUCTVERSION} It works fine with the attached patch. Best Regards, Petr From 2977c5dda829890fd73462848469de9da56c1759 Mon Sep 17 00:00:00 2001 From: Petr Mladek pmla...@suse.cz Date: Sat, 8 Jan 2011 20:12:41 +0100 Subject: [PATCH] Really set BrOffice in the linux desktop files * dekstop files need pt_BR instead of pt-BR (undescore vs. dash) * %PRODUCTNAME_BR was wrongly substitured to ${PRODUCTNAME} ${PRODUCTVERSION}_BR; it should be ${PRODUCTNAME_BR} ${PRODUCTVERSION} --- sysui/desktop/menus/base.desktop |2 +- sysui/desktop/menus/calc.desktop |2 +- sysui/desktop/menus/draw.desktop |2 +- sysui/desktop/menus/impress.desktop |2 +- sysui/desktop/menus/javafilter.desktop |2 +- sysui/desktop/menus/math.desktop |2 +- sysui/desktop/menus/printeradmin.desktop |2 +- sysui/desktop/menus/qstart.desktop |2 +- sysui/desktop/menus/startcenter.desktop |2 +- sysui/desktop/menus/writer.desktop |2 +- sysui/desktop/share/brand.pl |8 sysui/desktop/share/makefile.mk |8 sysui/desktop/share/translate.pl |6 ++ 13 files changed, 28 insertions(+), 14 deletions(-) diff --git a/sysui/desktop/menus/base.desktop b/sysui/desktop/menus/base.desktop index a195c89..3cb84f8 100644 --- a/sysui/desktop/menus/base.desktop +++ b/sysui/desktop/menus/base.desktop @@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-MoreApplicat Exec=${UNIXBASISROOTNAME} -base %U MimeType=application/vnd.oasis.opendocument.database;application/vnd.sun.xml.base; Name=%PRODUCTNAME Base -Name[pt-BR]=%PRODUCTNAME_BR Base +Name[pt_BR]=%PRODUCTNAME_BR Base GenericName=Database Development Comment=Manage databases, create queries and reports to track and manage your information by using Base. InitialPreference=5 diff --git a/sysui/desktop/menus/calc.desktop b/sysui/desktop/menus/calc.desktop index 522c179..d885589 100644 --- a/sysui/desktop/menus/calc.desktop +++ b/sysui/desktop/menus/calc.desktop @@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Sprea Exec=${UNIXBASISROOTNAME} -calc %U MimeType=application/vnd.oasis.opendocument.spreadsheet;application/vnd.oasis.opendocument.spreadsheet-template;application/vnd.sun.xml.calc;application/vnd.sun.xml.calc.template;application/vnd.stardivision.calc;application/vnd.stardivision.chart;application/msexcel;application/vnd.ms-excel;application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;application/vnd.ms-excel.sheet.macroenabled.12;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.template.macroenabled.12;application/vnd.ms-excel.sheet.binary.macroenabled.12;text/csv;application/x-dbf; Name=%PRODUCTNAME Calc -Name[pt-BR]=%PRODUCTNAME_BR Calc +Name[pt_BR]=%PRODUCTNAME_BR Calc GenericName=Spreadsheet Comment=Perform calculation, analyze information and manage lists in spreadsheets by using Calc. InitialPreference=5 diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop index 3ea1741..21c31b8 100644 --- a/sysui/desktop/menus/draw.desktop +++ b/sysui/desktop/menus/draw.desktop @@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Drawi Exec=${UNIXBASISROOTNAME} -draw %U MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.stardivision.draw; Name=%PRODUCTNAME Draw -Name[pt-BR]=%PRODUCTNAME_BR Draw +Name[pt_BR]=%PRODUCTNAME_BR Draw GenericName=Drawing Program Comment=Create and edit drawings, flow charts, and logos by using Draw. InitialPreference=5 diff --git a/sysui/desktop/menus/impress.desktop b/sysui/desktop/menus/impress.desktop index dc08e25..33a7d90 100644 --- a/sysui/desktop/menus/impress.desktop +++ b/sysui/desktop/menus/impress.desktop @@ -7,7 +7,7 @@ Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Prese Exec=${UNIXBASISROOTNAME} -impress %U
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
On Sat, Jan 8, 2011 at 8:51 AM, Miklos Vajna vmik...@frugalware.org wrote: Hi, See the attached patch. Motivation: 17:51 boobaa kohei: is there a way to bind F13/F15 to previous/next sheet in calc? 17:58 @kohei boobaa, no idea. did you look into View - Toolbars - Customize - Keyboard? 17:58 boobaa kohei: exactly 17:59 @kohei boobaa, if it's not there, then the answer will be 'no'. 18:01 boobaa kohei: ok, let me rephrase. how difficult to implement this? :) 18:02 @kohei boobaa, this is a bit tricky, since ctrl-pageup pagedown have special handling in vcl not tied to key bindings. 18:02 @kohei boobaa, oh wait, I may be talking about shift-pageup/down. 18:03 boobaa kohei: well, from my user point of view all i'm missing is the f13 and f15 from the available keys' list. everything else is there already. 18:05 @kohei boobaa, then it should be fairly simple I think. Just add F13 and up as bindable keys in vcl, and modify the key binding pane in somewhere in svx/svtools/svl is all you'd need to do, I think. 18:05 * kohei forgets exactly how to add new keys. The patch is pretty trivial once it turned out vcl already supports up to F24 (and at some places F26), but what I can test is F13-F16, so I enabled only that. Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the customization panel) Norbert OK to push to master? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] some changes for better performance, writer.
On Mon, Jan 9, 2006 at 11:09 PM, Kayo Hamid kayo.ha...@gekkolinux.com.br wrote: Sending for review. I' confused: -sal_Int32 nCount = xAcc-getAccessibleChildCount(); - -for( sal_Int32 i=0; i nCount; i++ ) +const sal_Int32 nCount = xAcc-getAccessibleChildCount(); +sal_Int32 i = 0; + +while(i nCount) { -if( xAcc-getAccessibleChild( i ) == xThis ) -return i; + if( xAcc-getAccessibleChild( i ) == xThis ) + return i; + i++; } + Unless I'm really dense: this simply change a for() loop into a while() loop doing exactly the same thing Why is it supposed to improve performance ? as for the rest: Did you really measure that turning a passed-by-value scalar (which caller's value cannot be modified by the callee, by definition) into a const passed by value scalar, has _actually_ any performance impact ? Norbert revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] De-Java-ise flat XML export
Hi Jan, Hi Gioele, here's another patch: split-long-lines.xsl seems to be missing from the list of files in file_xsltfilter.scp. The attached patch should fix that. Bye, Peter From 7657c25214ea4f0f73713b9cc007690c626480fa Mon Sep 17 00:00:00 2001 From: Peter Jentsch pj...@guineapics.de Date: Fri, 7 Jan 2011 22:00:15 +0100 Subject: [PATCH] Added missing split-long-lines.xsl to installation list for xsltfilter.scp --- scp2/source/xsltfilter/file_xsltfilter.scp |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/scp2/source/xsltfilter/file_xsltfilter.scp b/scp2/source/xsltfilter/file_xsltfilter.scp index d40a515..9cabd88 100644 --- a/scp2/source/xsltfilter/file_xsltfilter.scp +++ b/scp2/source/xsltfilter/file_xsltfilter.scp @@ -91,9 +91,17 @@ File gid_File_Xsl_Export_Odfflatxml Name = /xslt/odfflatxml/odfflatxmlexport.xsl; End +File gid_File_Xsl_Export_Odfflatxml_Split_Long_Lines +TXT_FILE_BODY; +Styles = (PACKED, PATCH); +Dir = gid_Dir_Share_Xslt_Odfflatxml; +Name = /xslt/odfflatxml/split-long-lines.xsl; +End + File gid_File_Xsl_Import_Odfflatxml TXT_FILE_BODY; Styles = (PACKED, PATCH); Dir = gid_Dir_Share_Xslt_Odfflatxml; Name = /xslt/odfflatxml/odfflatxmlimport.xsl; End + -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] De-Java-ise flat XML export
Hi Jan, Hi Gioele, here's another patch: split-long-lines.xsl seems to be missing from the list of files in file_xsltfilter.scp. The attached patch should fix that. Bye, Peter From 7657c25214ea4f0f73713b9cc007690c626480fa Mon Sep 17 00:00:00 2001 From: Peter Jentsch pj...@guineapics.de Date: Fri, 7 Jan 2011 22:00:15 +0100 Subject: [PATCH] Added missing split-long-lines.xsl to installation list for xsltfilter.scp --- scp2/source/xsltfilter/file_xsltfilter.scp |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/scp2/source/xsltfilter/file_xsltfilter.scp b/scp2/source/xsltfilter/file_xsltfilter.scp index d40a515..9cabd88 100644 --- a/scp2/source/xsltfilter/file_xsltfilter.scp +++ b/scp2/source/xsltfilter/file_xsltfilter.scp @@ -91,9 +91,17 @@ File gid_File_Xsl_Export_Odfflatxml Name = /xslt/odfflatxml/odfflatxmlexport.xsl; End +File gid_File_Xsl_Export_Odfflatxml_Split_Long_Lines +TXT_FILE_BODY; +Styles = (PACKED, PATCH); +Dir = gid_Dir_Share_Xslt_Odfflatxml; +Name = /xslt/odfflatxml/split-long-lines.xsl; +End + File gid_File_Xsl_Import_Odfflatxml TXT_FILE_BODY; Styles = (PACKED, PATCH); Dir = gid_Dir_Share_Xslt_Odfflatxml; Name = /xslt/odfflatxml/odfflatxmlimport.xsl; End + -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translated comments from German to English
Hi, I started with a fresh clone this evening and reapplied my changes. So this patch is meant for pushing :-) Christina From 897639961ab86d9aa7b50a91acea19c3d47b8106 Mon Sep 17 00:00:00 2001 From: Christina Rossmanith Christina Rossmanith Date: Sat, 8 Jan 2011 23:09:47 +0100 Subject: [PATCH] Translated comments from German to English --- sc/inc/dbcolect.hxx | 18 sc/inc/dociter.hxx | 39 sc/inc/docoptio.hxx | 28 ++-- sc/inc/docpool.hxx |2 +- sc/inc/document.hxx | 120 ++- 5 files changed, 105 insertions(+), 102 deletions(-) diff --git a/sc/inc/dbcolect.hxx b/sc/inc/dbcolect.hxx index 95d2649..8715505 100644 --- a/sc/inc/dbcolect.hxx +++ b/sc/inc/dbcolect.hxx @@ -108,18 +108,18 @@ private: SCCOL nSubTotals[MAXSUBTOTAL]; SCCOL* pSubTotals[MAXSUBTOTAL]; ScSubTotalFunc* pFunctions[MAXSUBTOTAL]; -// Datenbank-Import +// data base import BOOL bDBImport; String aDBName; String aDBStatement; BOOL bDBNative; -BOOL bDBSelection; // nicht im Param: Wenn Selektion, Update sperren -BOOL bDBSql;// aDBStatement ist SQL und kein Name -BYTE nDBType; // enum DBObject (bisher nur dbTable, dbQuery) +BOOL bDBSelection; // not in Param: if selection, block update +BOOL bDBSql;// aDBStatement is SQL not a name +BYTE nDBType; // enum DBObject (up to now only dbTable, dbQuery) -USHORT nIndex; // eindeutiger Index fuer Formeln -BOOL bAutoFilter; // AutoFilter? (nicht gespeichert) -BOOL bModified; // wird bei UpdateReference gesetzt/geloescht +USHORT nIndex; // unique index formulas +BOOL bAutoFilter; // AutoFilter? (not saved) +BOOL bModified; // is set/cleared for/by(?) UpdateReference using ScRefreshTimer::operator==; @@ -201,13 +201,13 @@ class SC_DLLPUBLIC ScDBCollection : public ScSortedCollection private: Link aRefreshHandler; ScDocument* pDoc; -USHORT nEntryIndex; // Zaehler fuer die eindeutigen Indizes +USHORT nEntryIndex; // counter for unique indices public: ScDBCollection(USHORT nLim = 4, USHORT nDel = 4, BOOL bDup = FALSE, ScDocument* pDocument = NULL) : ScSortedCollection ( nLim, nDel, bDup ), pDoc( pDocument ), -nEntryIndex ( SC_START_INDEX_DB_COLL ) // oberhalb der Namen +nEntryIndex ( SC_START_INDEX_DB_COLL ) // above the names {} ScDBCollection(const ScDBCollection rScDBCollection) : ScSortedCollection ( rScDBCollection ), diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx index 0c1b06a..0159357 100644 --- a/sc/inc/dociter.hxx +++ b/sc/inc/dociter.hxx @@ -49,7 +49,7 @@ class ScAttrIterator; class ScRange; class ScFlatBoolRowSegments; -class ScDocumentIterator// alle nichtleeren Zellen durchgehen +class ScDocumentIterator// walk through all non-empty cells { private: ScDocument*pDoc; @@ -83,13 +83,13 @@ public: void GetPos( SCCOL rCol, SCROW rRow, SCTAB rTab ); }; -class ScValueIterator// alle Zahlenwerte in einem Bereich durchgehen +class ScValueIterator// walk through all values in an area { private: double fNextValue; ScDocument* pDoc; const ScAttrArray* pAttrArray; -ULONG nNumFormat; // fuer CalcAsShown +ULONG nNumFormat; // for CalcAsShown ULONG nNumFmtIndex; SCCOL nStartCol; SCROW nStartRow; @@ -218,9 +218,9 @@ public: // -class ScCellIterator// alle Zellen in einem Bereich durchgehen -{// bei SubTotal aber keine ausgeblendeten und -private: // SubTotalZeilen +class ScCellIterator// walk through all cells in an area +{// for SubTotal no hidden and no sub-total lines +private: ScDocument* pDoc; SCCOL nStartCol; SCROW nStartRow; @@ -250,8 +250,8 @@ public: ScAddress GetPos() const { return ScAddress( nCol, nRow, nTab ); } }; -class ScQueryCellIterator // alle nichtleeren Zellen in einem Bereich -{ // durchgehen +class ScQueryCellIterator // walk through all non-empty cells in an area +{ enum StopOnMismatchBits { nStopOnMismatchDisabled = 0x00, @@ -299,15 +299,15 @@ private: public: ScQueryCellIterator(ScDocument* pDocument, SCTAB nTable, const ScQueryParam aParam, BOOL bMod = TRUE); -// fuer bMod = FALSE muss der QueryParam -// weiter aufgefuellt sein (bIsString) +// for bMod = FALSE the QueryParam has to be filled +// (bIsString)
Re: [Libreoffice] [libreoffice-design] Change application background [was: How to contribute ?]
Hi Rahul, hi community! Am Samstag, den 08.01.2011, 02:05 +0100 schrieb Bernhard Dippold: Hi Rahul, all, Rahul Prasad schrieb: [..] * I was thinking of a nice background instead of a static colour. You can find some of my design here http://rahulprasad.com/public/libreOffice/writer/ Although design is not very appealing, but I am sure people will come come up with better design.* This idea has already been presented some time ago in the OOo UX project, but has not been implemented by now (AFAIK). I can't find the proposal right now, but I'm quite sure, Christoph knows where to find it. That's one small step for developer, one giant leap for LibreOffice. Well, maybe ;-) Bernhard, you are right, this idea has been discussed several times - and I also have some ideas how we can bring LibO forward and make a really thrilling community driven branding. But, this requires some developer support ... The very first step is, indeed, to know how much effort it required to show graphics (whatever kind) on / instead of the application background. Here is the mail by Johannes Eva, who collected some information on that (2009-07-31, ux-discuss list): Hi everybody! Some weeks ago I started to write an article about the application background in OOo. I had time to finish it yesterday night, so here it is! http://www.johannes-eva.net/2009-07-new-application-background-ooo (Christoph: Updated link, since blog engine has been changed.) Here are the two related issues: Change the OpenOffice.org Background Color http://qa.openoffice.org/issues/show_bug.cgi?id=75049 Use bitmaps/patterns/pictures as Application Background instead of plain color only: http://www.openoffice.org/issues/show_bug.cgi?id=103915 Best regards, Johannes When we talked about the StartCenter, Ivan (who is currently busy by shaping the visual design for the revised LibreOffice website) brought up the following idea: http://wiki.services.openoffice.org/wiki/File:Ivan_StartCenter_Proposal_wireframe.png In context, it is on our proposal collection page for the StartCenter: http://wiki.services.openoffice.org/wiki/User_Experience/StartCenter#Mockups [... explanation concerning LibreOffice development ...] I don't know if this feature is easy or hard to implement, but perhaps it can be added to the list of easy hacks: http://wiki.documentfoundation.org/Development/Easy_Hacks Ouch! Some time before (2007?), I have been told that changing anything which is beyond the document border is pretty hard. I would be more than happy if anything can prove this to be wrong ;-) This (for example) is the reason for not having shadows on the right side for the Writer comments/notes (instead, we live with 80's style shadow for the pages). [...] Regards, Christoph ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the customization panel) Not really, it's possible to map those crazy multimedia buttons to F13 etc - then you'll even have Shift-F13. :) pgpjLHXl2ZbTV.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Localizations of UI and help - what languages does LibO support?
2010.12.29. 0:21 keltezéssel, Andras Timar írta: Hi, I tested RC2 in regards of localization and I think it needs to be reviewed. 110 languages (including en-US) are selectable as UI language and help packs are provided for those. However, * Asturian (ast), Catalan (Valencian) (ca-XV), and Indonesian (id) are not included. Asturian and Catalan (Valencian) are especially important, because they are actively participating in LibreOffice localization. * Gaelic (Scots) (gd), Kirghiz (ky), Lao (lo), Malay (ms), Papiamento (pap), Pushto (ps), ??? (sc), Tigrinya (ti), and Urdu (ur) are included despite the fact that in the source there are no translations at all in these languages, so you basically package en-US strings. Gaelic (Scots) (gd) translation exists at ftp://ftp.linux.cz/pub/localization/OpenOffice.org/devel/build/Files/OOO330/GSI_gd.sdf.bz2 - maybe it can be added. * It makes no sense to provide help pack for those languages which have 0% of the help translated. See this table for reference: http://wiki.documentfoundation.org/Translation_for_3_3#Language_pack_.2F_Help_pack_coverage This table was made from the RC2 sources. One more issue that I found... * LibreOffice inherited all localizations from OOo hg repository. However, not all locales are maintaned in OOo hg repository. I mentioned Gaelic (gd) that was completely missing. I learned about Slovak (sk) - now it is updated in LibreOffice git. But today I compared SDF files from LibreOffice repository and SDF files from Pavel Janik's OOo build source (ftp://ftp.linux.cz/pub/localization/OpenOffice.org/devel/build/Files/OOO330/). Pavel Janik maintains 42 localizations. af be-BY bg bn cs cy da dz el en-ZA eo et fi ga gd gl id ka km ku lo lt lv mk nb ne nn nr ns ro sk sl ss st tg tn ts uz ve vi xh zu The problem is that we cannot say that he always have more up-to-date translations that OOo hg (or LibreOffice git). I did not check all files, but some seemed to be older then ours, other seemed to be more complete/more up-to-date. It would be the best, if locale owners told us what to use, but unfortunately not all of them showed up in l10n mailing list. So I'm afraid we cannot make sure about all of these locales before 3.3. I CC-ed l10n list, maybe some teams can reply and clarify the situation. For the next release (maybe even for 3.3.1) we need to find and ask all locale maintaners (and ask them to support LibreOffice, too, of course :)). Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] some changes for better performance, writer.
On 08/01/2011 17:00, Norbert Thiebaud wrote: I' confused: -sal_Int32 nCount = xAcc-getAccessibleChildCount(); - -for( sal_Int32 i=0; i nCount; i++ ) +const sal_Int32 nCount = xAcc-getAccessibleChildCount(); +sal_Int32 i = 0; + +while(i nCount) { -if( xAcc-getAccessibleChild( i ) == xThis ) -return i; + if( xAcc-getAccessibleChild( i ) == xThis ) + return i; + i++; } + Unless I'm really dense: this simply change a for() loop into a while() loop doing exactly the same thing Why is it supposed to improve performance ? as for the rest: Did you really measure that turning a passed-by-value scalar (which caller's value cannot be modified by the callee, by definition) into a const passed by value scalar, has _actually_ any performance impact ? Norbert Hello Norbert, first of all i'm new at coding, I really do not know if we have any improve, but after looking a lot for c++ performance tips (and I continue looking and reading tips for that) I have in my mind some things like: for/while - it's better to use while, it's not a huge improve, but you can find tips that say 'use while, it's better'. I just do it. const - my goal is to change the local variable to const is to put it in read-only, wich is better, but in that case that we receive pass-by-value, is my fault. The problem is that i do not known that this method returns reference. It's because all this that I ask for one review, I want to learn with everyone here. I'm in the right way? My goal is to code things that are better, even with minimal improves. revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Bug 32790 fixed - please review
Hi there, I've just fixed and attached a patch to https://bugs.freedesktop.org/show_bug.cgi?id=32790 intended for 3.3. I would appreciate it if someone who is experienced in the writer mail merge code to review and approve this. Thanks a lot! Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
On Sat, Jan 8, 2011 at 4:51 PM, Miklos Vajna vmik...@frugalware.org wrote: On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the customization panel) Not really, it's possible to map those crazy multimedia buttons to F13 etc - then you'll even have Shift-F13. :) then why limit it to F13-F16 on my mac keyboard it goes to f19, and historically you could see up to f24 Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
Hi Miklos, On Sat, Jan 8, 2011 at 9:51 AM, Miklos Vajna vmik...@frugalware.org wrote: OK to push to master? Yeah, looks indeed trivial. Let's push this baby. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] variableScope cppcheck at writer
Sending for review. revol_ diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx index 1436f6e..73ad556 100644 --- a/sw/source/core/doc/doc.cxx +++ b/sw/source/core/doc/doc.cxx @@ -1246,7 +1246,6 @@ void SwDoc::CalculatePagesForPrinting( USHORT nFirstPageNo = 0; USHORT nLastPageNo = 0; -USHORT nPageNo = 1; for( USHORT i = 1; i = (USHORT)aPages.Max(); ++i ) { @@ -1293,7 +1292,7 @@ void SwDoc::CalculatePagesForPrinting( aMulti = aTmpMulti; // Ende des HACKs -nPageNo = nFirstPageNo; +USHORT nPageNo = nFirstPageNo; std::map sal_Int32, sal_Int32 rPrinterPaperTrays = rData.GetPrinterPaperTrays(); std::set sal_Int32 rValidPages = rData.GetValidPagesSet(); diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx index 944d2ff..302af6c 100644 --- a/sw/source/core/docnode/nodes.cxx +++ b/sw/source/core/docnode/nodes.cxx @@ -1629,7 +1629,6 @@ BOOL SwNodes::CheckNodesRange( const SwNodeIndex rStt, const SwNodeIndex rEnd */ void SwNodes::DelNodes( const SwNodeIndex rStart, ULONG nCnt ) { -int bUpdateNum = 0; ULONG nSttIdx = rStart.GetIndex(); if( !nSttIdx nCnt == GetEndOfContent().GetIndex()+1 ) @@ -1657,6 +1656,7 @@ void SwNodes::DelNodes( const SwNodeIndex rStart, ULONG nCnt ) } else { + int bUpdateNum = 0; for( ULONG n = nSttIdx, nEnd = nSttIdx + nCnt; n nEnd; ++n ) { SwNode* pNd = (*this)[ n ]; diff --git a/sw/source/core/unocore/unocoll.cxx b/sw/source/core/unocore/unocoll.cxx index f19d8bf..d1be8ec 100644 --- a/sw/source/core/unocore/unocoll.cxx +++ b/sw/source/core/unocore/unocoll.cxx @@ -1819,12 +1819,12 @@ uno::Any SwXFootnotes::getByIndex(sal_Int32 nIndex) { SolarMutexGuard aGuard; uno::Any aRet; -sal_Int32 nCount = 0; if(IsValid()) { sal_uInt16 n, nFtnCnt = GetDoc()-GetFtnIdxs().Count(); SwTxtFtn* pTxtFtn; uno::Reference XFootnote xRef; + sal_Int32 nCount = 0; for( n = 0; n nFtnCnt; ++n ) { pTxtFtn = GetDoc()-GetFtnIdxs()[ n ]; diff --git a/sw/source/ui/docvw/PostItMgr.cxx b/sw/source/ui/docvw/PostItMgr.cxx index e06d558..700398a 100644 --- a/sw/source/ui/docvw/PostItMgr.cxx +++ b/sw/source/ui/docvw/PostItMgr.cxx @@ -950,9 +950,7 @@ bool SwPostItMgr::LayoutByPage(std::listSwSidebarWin* aVisiblePostItList,cons long lTopBorder = rBorder.Top() + 5; long lBottomBorder = rBorder.Bottom() - 5; const long lVisibleHeight = lBottomBorder - lTopBorder; //rBorder.GetHeight() ; -long lSpaceUsed = 0; long lTranslatePos = 0; -intloop= 0; bool bDone = false; bool bScrollbars = false; @@ -982,6 +980,8 @@ bool SwPostItMgr::LayoutByPage(std::listSwSidebarWin* aVisiblePostItList,cons //start the real layout so nothing overlaps anymore if (aVisiblePostItList.size()1) { + longlSpaceUsed = 0; + int loop= 0; // if no window is moved anymore we are finished while (!bDone) { ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
On Sat, Jan 08, 2011 at 06:28:01PM -0500, Kohei Yoshida kohei.yosh...@gmail.com wrote: Hi Miklos, On Sat, Jan 8, 2011 at 9:51 AM, Miklos Vajna vmik...@frugalware.org wrote: OK to push to master? Yeah, looks indeed trivial. Let's push this baby. Done. :) Thanks. pgp4CTWGdMqPT.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function
On Sat, Jan 08, 2011 at 05:27:08PM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: On Sat, Jan 8, 2011 at 4:51 PM, Miklos Vajna vmik...@frugalware.org wrote: On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the customization panel) Not really, it's possible to map those crazy multimedia buttons to F13 etc - then you'll even have Shift-F13. :) then why limit it to F13-F16 on my mac keyboard it goes to f19, and historically you could see up to f24 That's what I could test on my hardware. Feel free to extend it if you want. :) pgpZVpdvnC4jq.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] variableScope cppcheck at writer
On Sat, Jan 8, 2011 at 9:00 PM, Kayo Hamid kayo.ha...@gekkolinux.com.br wrote: Sending for review. You need to check your editor settings, as you are introducing 'tab' characters as indentation. I fixed that. with that caveat, Pushed, thanks. Norbert revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 ariel cornejo arie...@gmail.com changed: What|Removed |Added Depends on||32929 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=31865 --- Comment #57 from ariel cornejo arie...@gmail.com 2011-01-08 23:20:08 PST --- I'm nominating Bug #32929 (Use system font for user interface ignored) since this feature works fine in RC1 and is broken in RC2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] Re: Localizations of UI and help - what languages does LibO support?
Hi Andras, On 09/01/2011 01:45, Andras Timar wrote: [...] The problem is that we cannot say that he always have more up-to-date translations that OOo hg (or LibreOffice git). I did not check all files, but some seemed to be older then ours, other seemed to be more complete/more up-to-date. It would be the best, if locale owners told us what to use, but unfortunately not all of them showed up in l10n mailing list. So I'm afraid we cannot make sure about all of these locales before 3.3. I CC-ed l10n list, maybe some teams can reply and clarify the situation. For the next release (maybe even for 3.3.1) we need to find and ask all locale maintaners (and ask them to support LibreOffice, too, of course :)). Is it possible that you extract their mail address from the header? If yes, I'll mail them to ask a status of their localization. Thanks for your work :) Kind regards Sophie ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice