Re: [Libreoffice] Need help to debug with Visual C++ 2008
Thanks Tor, I success debug with Attach to process solution but I want to debug the code that execute when LibO start. Attach to process can only debug after LibO already started. How can I debug the startup code in VCL? How can I debug soffice.bin? Any environment variable that I need to set. Tantai. On Mon, Feb 7, 2011 at 2:24 PM, Tor Lillqvist tlillqv...@novell.com wrote: 2. start Visual Studio and open exe with File Open Project/Solution and choose soffice.exe in program folder. It is not soffice.exe that is the actual LibreOffice program, it's soffice.bin. (Which despite its odd .bin suffix is a totally normal .exe file.) Soffice.exe is just a thin wrapper that sets up PATH and then starts soffice.bin. Yes, this can be quite confusing, and especially confusing is that in the LO build directory, when actually built, these programs are not called soffice.exe and soffice.bin, but, if I recall correctly, what gets installed as soffice.exe is called officeloader.exe and what gets installed as soffice.bin is called soffice.exe. (And additionally, there is even a another copy of that soffice.exe (i.e. the eventual soffice.bin) called soffice_oo.exe. I am not kidding, one could not make this stuff up. Of course, this is not our bright idea, but legacy from OpenOffice.org. We should change it at some point to be less confusing. And anyway, typically you shouldn't be starting soffice.bin from the debugger as then the environment setup that the wrapper soffice.exe does are not done and it will not find its DLLs. You should just start it normally from Explorer, just the Start Centre, and then attach it from the debugger, set your breakpoints, and use it so that the breakpoint gets hit. Note that you don't need to quite Visual Studio between different runs of LibreOffice- You can just detach or terminate the debuggee from VS, rebuild more stuff with debugging if you want, copy the this rebuilt DLLs into place, start it again (normally, from Explorer), attach soffice.bin again. The same breakpoints will be remembered. 3. Open a file I want to debug(window.cxx) and set breakpoint at the ImplUpdateGlobalSettings function. That is correct, yes. And as long as you are debugging the right program, soffice.bin, it will work. --tml -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] template missing
On Mon, Feb 07, 2011 at 02:10:13AM -0500, Arno Teigseth wrote: On Mon, 2011-02-07 at 07:44 +0100, David Tardon wrote: ... exists yet, it just points to a nonexistent file. LibO sees the (symlink) file, so it doesn't allow to import a template with the same name, but it cannot open it as a template, so it doesn't list it in the dialog. Elementary, my dear Watson. Yes well it wasn't my meaning to complain on that, that part's quite logic. What I wondered was if it would be a Good Idea or a Bad Idea to be able to just import a template overwriting an existing one with the same name, instead of having to do the double operation of 1) deleting the old template 2) importing the new template? IMHO it is a Good Idea. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments
On Sat, Feb 05, 2011 at 05:20:29PM -0500, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine Hi, Antoine, bug references like #XX# point to private Sun bugtracker, therefore they are of no value to us (as opposite to #iX# ones, that point to openoffice.org issue tracker). I removed the lot of them from your patch. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Review request: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=7bc42b864b22fd8e0b159dfec212abaf989ff9aa
Hi Tor On 04/02/11 15:34, Tor Lillqvist wrote: I would like to cherry-pick that to libreoffice-3-3. (Otherwise it can't be built on Windows with a recent DirectX SDK.) looks ok to me, I would say go for it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] EasyHacks: Make existing tests work (ure/sal)
On Sat, Feb 05, 2011 at 11:45:47PM +0100, Wilhelm Pflüger wrote: Attached please find some changes to make tests in ure/sal work. One test fails and breaks the build though - if this is unwanted you may revert the change to ure/sal/prj/build.lst. (This is not exactly what is intended by tests - i mean to switch it off if it fails, but in the Moment I don't know how to repair the failing method so that it works as intended by the test.) Good enough, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] EasyHacks: Make existing tests work (ure/sal)
Forgot to mark as PUSHED. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks: Make existing tests work
On Sat, Feb 05, 2011 at 11:32:18PM +0100, Wilhelm Pflüger wrote: Find attached changes to lib-gui/comphelper to get some tests working again. These patches are LGPLv3+/MPL. This is my first contribution in this project - so don't hesitate with critics if its not the common procedure. You have done well :) Pushed now. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to debug with Visual C++ 2008
Thanks Tor, It's work. On Mon, Feb 7, 2011 at 3:33 PM, Tor Lillqvist tlillqv...@novell.com wrote: I success debug with Attach to process solution but I want to debug the code that execute when LibO start. Ah. That is always hard for me because 1) I never remember which source file it is that actually contains the main program of soffice.bin. There are half a dozen or so files with promising names and/or promising directory names... of course none of them has any comment giving a short descreiption of its purpose. 2) Once you figure out which file actually is the real main, you then need to build that stuff with debug=t, open the soffice.bin in VS (does VS like that, does it understand that it is a normal executable even if called .bin, don't know), and I guess set in the project's properties PATH so that it includes the URE/bin and Basis/program directories, and then just start it under the debugger. Occasionally I have found it easier to just add a volatile int hang=1; while (hang); loop in the main program or some other low-level enough function, once I find it, and start it normally and just attach soffice.bin in the debugger, break it, set breakpoints, set hang to zero, and continue... --tml -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to debug with Visual C++ 2008
FYI: We simply rename soffice.bin to soffice.bin.exe and open in it Visual C++. Then add those path you mentioned in Project Properties. Thanks. On Mon, Feb 7, 2011 at 4:56 PM, Tantai Tanakanok tan...@osdev.co.th wrote: Thanks Tor, It's work. On Mon, Feb 7, 2011 at 3:33 PM, Tor Lillqvist tlillqv...@novell.comwrote: I success debug with Attach to process solution but I want to debug the code that execute when LibO start. Ah. That is always hard for me because 1) I never remember which source file it is that actually contains the main program of soffice.bin. There are half a dozen or so files with promising names and/or promising directory names... of course none of them has any comment giving a short descreiption of its purpose. 2) Once you figure out which file actually is the real main, you then need to build that stuff with debug=t, open the soffice.bin in VS (does VS like that, does it understand that it is a normal executable even if called .bin, don't know), and I guess set in the project's properties PATH so that it includes the URE/bin and Basis/program directories, and then just start it under the debugger. Occasionally I have found it easier to just add a volatile int hang=1; while (hang); loop in the main program or some other low-level enough function, once I find it, and start it normally and just attach soffice.bin in the debugger, break it, set breakpoints, set hang to zero, and continue... --tml -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice default UI font need to be changed
Christian, I agree completely with you and learn a lot from you detail explanation. Next I'd need a bit of advice to fix the bug I've mentioned. On Sun, Feb 6, 2011 at 1:40 AM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: On Sat, Feb 5, 2011 at 9:59 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: On Sat, Feb 5, 2011 at 6:38 PM, Nguyen Vu Hung vuhung16p...@gmail.com wrote: [VCL.xcu / list of default fonts and fallback] When there are issues cross-locale, then raise them. It is not that the list didn't change since the beginning of the OOo project. If I understand the OP correctly, he wants LibO to 1. Handle different languages on different locales. This is already done. I'd like to explain a bit about our (Thai) situation. Thai users may use en_US or th_TH for UI locale to get English menu and translated menu respectively. Normally, en_US are used for most users. The UI font replacement list based on locale seem to assume that for en_US UI locale, only Western characters will be in the UI. However, UI font isn't only used for static text in menu and dialog box. But also for user text in File Property Description text boxes, File Recent Documents filename list, and Calc formula bar. For user/editable text like these, they could be in any languages - Western, CTL, CJK. So with this (user text) in mind, the higher-priority font in UI font list should have good glyph coverage. For example (I know little about fonts), Tahoma or Microsoft Sans Serif in Windows. So I imagine replacing Andale UI with Tahoma (or better default) in the list. Having default with good glyph coverage is a good thing. However, LibO itself should display any multi-lingual text correctly if glyph fallback work correctly. But as you can see in the bug we've submitted : https://bugs.freedesktop.org/show_bug.cgi?id=33090 Glyph fallback for *CTL* text in *Windows* is currently broken but *only*for UI text rendering, not for text in the document. It used to work in older versions. This is the part that we'd like to fix. Can you give as a clue about where should we look in the VCL source? Thanks. -- _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] ugly diplay of toolbar menus in fontwork toolbar
Hello people, Since I fixed the toolbar menus on the fontwork toolbar, I saw that one of them as pretty badly shaped. The spacing menu was writing the text of the items over the controls that were supposed to be displayed on the left of it. Could anyone review this commit, sign it off and cherry-pick to 3.3 branch? http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=560ee224078b7b153c8acf305d5e3387dc46bcbc Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mac builds / lang-packs ...
Michael Meeks wrote: Would it not be better in 3.4 (when we have solved the size issues) to have a single download (like Windows) that includes all the languages, and have an optional help-pack ? Yep - though I don't really like the installer concept on mac, I guess I'd then prefer to install all those langs unconditionally. If that turns out to cause issues, we can discuss other options. Cheers, -- Thorsten pgphzKScijANG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] A possible future for LO help/lang packs?
Hi, just thinking loud (hope it is not too loud): is it possible to* make help packs into extensions* (oxt files)? Could this also be done with the lang-packs? The benefits: - *smaller file size*: extensions are great, because they are not executables and all the execution/installation code already lies within LO/OOo; - *lower cost of building/hosting*: a help pack would need to be built just once for all supported (and unsupported) operating systems; - *user-friendly*: a help pack can be dropped onto Extension Manager, double-clicked etc. It can also be downloaded at the last phase of the installation process with an installer on Windows and Linux etc. (an installer downloading and running another installer seems not so nice). - *localizer-friendly*: maybe Pootle server could be extended to generate helppacks (langpacks) daily/weekly or by demand - for testing purposes as well as for the release purposes; The drawbacks: - the extension framework maybe needs to be extended a bit to support help installation via extensions (but if needed at all that seems a reasonable investment to me, not knowing how much work that would present :) ); Lp, m. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] A possible future for LO help/lang packs?
Note that we don't want the situation were all UI languages are equal, but one UI language is more equal than the others. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] A possible future for LO help/lang packs?
Hi, Von: Martin Srebotnjak mi...@filmsi.net An: l...@libreoffice.org just thinking loud (hope it is not too loud): is it possible to* make help packs into extensions* (oxt files)? I tried this briefly for one of the LibO beta versions. In theory the mechanism is there but in reality I ended up with a mix of English and German help. Maybe this could be fixed, but the no-go for me was that the activation of the extension took about half an hour (on a Windows7 DualCore AMD PC). ... The drawbacks: - the extension framework maybe needs to be extended a bit to support help It does already, but currently it builds index files on installing / activating the extension what takes a lot of time. I have no idea if we could prebuild the index and put this into the extension. Regards, André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mac builds / lang-packs ...
Yep - though I don't really like the installer concept on mac, I guess I'd then prefer to install all those langs unconditionally. If that turns out to cause issues, we can discuss other options. Thorsten I have seen on mac some installers that allow you to specify which drive to install on. Question becomes is it possible to present a user a list of language packs that they can choose from and only install what is needed. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Does OO/LO have an API?
On Mon, 2011-02-07 at 12:49 +0100, Thorsten Behrens wrote: Kevin Hunter wrote: After about 20 minutes of Googling, and random grepping through the code base, I'm having no luck. Does such a beast exist? At least I'm not aware of any - thing is, higher-level functionality in LibO currently ~always assumes a running installation, mainloop, uno etc. - at least reducing that is one of the things being worked on, since it also makes unit testing a lot easier. Cheers, Hi Thorsten http://wiki.services.openoffice.org/wiki/API This is not an API - it seems to fit the definition I was taught? I'm not saying your wrong, just do not understand your answer here. Is there something about Libo that is changing all this or is it just that right now there is no API work on new features found only in LibO? I have to admit that I've not installed a LibO SDK, something I did always under OO.o, is there a big change? Thanks for your patience on this, Drew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: [tdf-discuss] Problem with linking external sheets in CALC
Hi OP and Kohei-san,
FYI, consider this as a nasty hack or a bug?
-- Forwarded message --
From: OBUTEX/Hladůvka ad...@obutex.com
Date: 2011/2/7
Subject: [tdf-discuss] Problem with linking external sheets in CALC
To: disc...@documentfoundation.org
I have linked to file1.ods another file2.xls sheet named RATES
and have a lot of formulas using the RATES cells.
Now the name RATES in the file2.xls changed to SHEET1 and the links
are broken (caused by exporting data in xls format from some other
application).
There is a way to change the filename but not the sheetname.
I solved it by this complicated way:
1) rename the file file1.ods to file1.zip
2) unzip file1.zip to the folder file1
3) manualy edit the content.xml file in the folder file1: - find the
proper xlink tag and change RATES into SHEET1
4) zip the folder to FILE1.zip
5) rename FILE1.zip to FILE1.ods
When linking the file for the very 1st time and more sheets are found
in the linked file, the system asks which sheet is to be linked.
This should be asked when changing the name of the linked file, too.
Is there any faster way how to update these broken links?
Or could someone to make a sugestion to the developers to fix it - my
English is not good enough to explain the problem better :)
--
OBUTEX spol. s r.o.
Ing. Jiří Hladůvka
Zlatovská 22
911 05 Trenčín
EU Slovakia
--
mailto:ad...@obutex.com
http://www.obutex.com
--
Unsubscribe instructions: E-mail to discuss+h...@documentfoundation.org
Archive: http://listarchives.documentfoundation.org/www/discuss/
*** All posts to this list are publicly archived for eternity ***
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum
Small part of one of tasks in easy tasks list.
This is my first patch to LibreOffice so I'd be grateful for feedback on any
issues.
Released under LGPLv3+/MPL
---
sw/inc/undobj.hxx |4 ++--
sw/source/core/undo/unnum.cxx | 16 ++--
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/sw/inc/undobj.hxx b/sw/inc/undobj.hxx
index 2252de9..e6ea274 100644
--- a/sw/inc/undobj.hxx
+++ b/sw/inc/undobj.hxx
@@ -1371,8 +1371,8 @@ public:
class SwUndoDelNum : public SwUndo, private SwUndRng
{
-SvULongs aNodeIdx;
-SvBytes aLevels;
+typedef std::vector std::pair ULONG, int SvNode;
+SvNode aNodes;
SvBools aRstLRSpaces;
SwHistory* pHistory;
public:
diff --git a/sw/source/core/undo/unnum.cxx b/sw/source/core/undo/unnum.cxx
index bc2be15..d5afd1f 100644
--- a/sw/source/core/undo/unnum.cxx
+++ b/sw/source/core/undo/unnum.cxx
@@ -190,10 +190,9 @@ void SwUndoInsNum::SaveOldNumRule( const SwNumRule rOld )
SwUndoDelNum::SwUndoDelNum( const SwPaM rPam )
-: SwUndo( UNDO_DELNUM ), SwUndRng( rPam ),
-aNodeIdx( BYTE( nEndNode - nSttNode 255 ? 255 : nEndNode - nSttNode )),
-aLevels( BYTE( nEndNode - nSttNode 255 ? 255 : nEndNode - nSttNode ))
+: SwUndo( UNDO_DELNUM ), SwUndRng( rPam )
{
+aNodes.reserve( nEndNode - nSttNode 255 ? 255 : nEndNode - nSttNode );
pHistory = new SwHistory;
}
@@ -215,11 +214,11 @@ void SwUndoDelNum::Undo( SwUndoIter rUndoIter )
pHistory-TmpRollback( rDoc, 0 );
pHistory-SetTmpEnd( pHistory-Count() );
-for( USHORT n = 0; n aNodeIdx.Count(); ++n )
+for( SvNode::const_iterator i = aNodes.begin(); i != aNodes.end(); ++i )
{
-SwTxtNode* pNd = rDoc.GetNodes()[ aNodeIdx[ n ] ]-GetTxtNode();
+SwTxtNode* pNd = rDoc.GetNodes()[ i-first ]-GetTxtNode();
OSL_ENSURE( pNd, wo ist der TextNode geblieben? );
-pNd-SetAttrListLevel(aLevels[ n ] );
+pNd-SetAttrListLevel( i-second );
if( pNd-GetCondFmtColl() )
pNd-ChkCondColl();
@@ -247,10 +246,7 @@ void SwUndoDelNum::AddNode( const SwTxtNode rNd, BOOL )
{
if( rNd.GetNumRule() )
{
-USHORT nIns = aNodeIdx.Count();
-aNodeIdx.Insert( rNd.GetIndex(), nIns );
-
-aLevels.Insert( static_castBYTE(rNd.GetActualListLevel()), nIns );
+aNodes.push_back( SvNode::value_type( rNd.GetIndex(), rNd.GetActualListLevel() ) );
}
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Does OO/LO have an API?
drew wrote: http://wiki.services.openoffice.org/wiki/API This is not an API - it seems to fit the definition I was taught? Yes, this is an api - but please see Kevin's question, which was very specific. Cheers, -- Thorsten pgpiqDCH6MH2A.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum
Hi Andrey, This is my first patch to LibreOffice so I'd be grateful for feedback on any issues. Oddly enough, I was looking at this the other day but didn't get round to submitting a patch because I couldn't get sw to compile (for totally unrelated reasons). My changes were almost identical to yours, though I have one suggestion. Changing to a std::pair means we go from descriptively named items (aNodeIdx and aLevels) to the generic first/second. Which is less clear to the reader. Can I suggest you either: A) Add a comment above the SvNode definition to say (very briefly) what the ULONG and int are used for. or: B) Define a local class/struct instead of the pair with more descriptive names for the elements. Nigel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Sun, Feb 06, 2011 at 05:44:03AM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: humm... what build.git ? :-) on master I do not even clone build.git anymore... Then bootstrap.git, you get it. :) Con: it seriously increase the barrier of entry. git already scare some people... git + submodule at that scale will be much worse Con: it would be using submodule in a way it was certainly not intended to be used. That means that doc and support for that will be scarse and chance of screwing things up rise big time, with very few 'expert' - if any - to sort things out. Con: how well is it going to mesh with the fact that some git repo are 'optional' (l10n) ? Con: that will probably mess with the hg import script. we would need to make sure that import is still feasible - without breaking the current history Note that the main drawback of our current approach is indeed the bisection problem. It would be certainly be convinient to be able to bisect on the entire set of repos... but how much pain/risk do we want to take to improve that aspect of things ? I already thought about this when the first gitdm script was hacked by Cedric to handle all the repos as a single one (and I managed to came up with a solution there), but that does not help bisecting. If it was not clear from my mail, git-submodule is (in its current form) a no-go for us IMHO. Of course svn externals-like behaviour would not really improve the situation, either. What I can imagine as a working solution is that we already have a tinbuild which can detect if a certain set of git heads (of the repos) is buildable or not. Now tinbuild could publish those working sets to a githeads.git repo and a 'g bisect' could work from that data. Of course that will not find the exact commit like tinbuild does not do, either - but at least point out a few possible ones. (I mean tinbuild would push the contents of git-heads.txt to a githeads.git, then 'g bisect' would call 'git bisect' in githeads.git and after the working directory is updated there, it would check out the commits in the repos based on git-heads.txt so that it's possible to do the actual testing. That's not so hard to implement for bisect start/good/bad/reset.) Does this sound reasonable? I'm happy to first implement the tinbuild part if others agree that the idea is sane. Of course you can call the repo bisect.git or whatever, that's a minor detail. pgp3YqWMadZbo.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum
Hi Nigel, On Mon, 2011-02-07 at 14:33 +, Nigel Hawkins wrote: Oddly enough, I was looking at this the other day but didn't get round to submitting a patch because I couldn't get sw to compile (for totally unrelated reasons). My changes were almost identical to yours, though I have one suggestion. Drat; sorry to hear work got duplicated. Changing to a std::pair means we go from descriptively named items (aNodeIdx and aLevels) to the generic first/second. Which is less clear to the reader. Can I suggest you either: Perhaps you can build your patch on top of Andrey's to capture that goodness ? I'm busy adding a few more easy hacks to try to make such conflicts less likely: it can help to add your name and a date vs. an easy hack (with perhaps a sub-portion of what you're working on). ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 7, 2011 at 9:02 AM, Miklos Vajna vmik...@frugalware.org wrote: On Sun, Feb 06, 2011 at 05:44:03AM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: humm... what build.git ? :-) on master I do not even clone build.git anymore... Then bootstrap.git, you get it. :) ;-) (I mean tinbuild would push the contents of git-heads.txt to a githeads.git, then 'g bisect' would call 'git bisect' in githeads.git and after the working directory is updated there, it would check out the commits in the repos based on git-heads.txt so that it's possible to do the actual testing. That's not so hard to implement for bisect start/good/bad/reset.) How about having a after-push git-hook in the master branch in our git.fdi/git/libreoffice/* git repos that generate the list of HEAD-sha1 that was you should be able to almost-completely bisect. sure in some cases the fact that 2 commit in two git are interdependent would throw off the bisection. but that is not that common. Another problem would be merge of feature branches, which would be counted as just one bisect step for the whole branch (but that is true even with the tinderbuild based solution) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] who is who
Hello,
I'd want to know who is the person in charge with modules of LibO
so that I can pin-point a question to the right persons :)
cf. http://wiki.services.openoffice.org/wiki/Architecture
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] A possible future for LO help/lang packs?
On Mon, 2011-02-07 at 13:12 +0100, Andre Schnabel wrote: Von: Martin Srebotnjak mi...@filmsi.net .. just thinking loud (hope it is not too loud): is it possible to* make help packs into extensions* (oxt files)? Sounds (to me) like a really good idea :-) May not work well for Linux - where you want the help installed in the system, but that is different enough anyway. I tried this briefly for one of the LibO beta versions. In theory the mechanism is there but in reality I ended up with a mix of English and German help. Maybe this could be fixed, but the no-go for me was that the activation of the extension took about half an hour (on a Windows7 DualCore AMD PC). Lol :-) that does sound deadly silly. It does already, but currently it builds index files on installing / activating the extension what takes a lot of time. I have no idea if we could prebuild the index and put this into the extension. Oh - we can certainly special case / disable that for our extensions that already come with a pre-built help index. Better, we should speed up the indexing with clucene; but that is all quite do-able. It would help to have a stack trace of quite how the slowness gets called in that case though (if that is possible to get on Windows). Martin - is that something you might be interested in working on ? and/or if not - could you add it as an easy hack - which will need some research doing on it to make it easy [ samples of other code that packs extensions, thoughts on solving path problems on Mac vs. Windows etc. ]. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to debug with Visual C++ 2008
On Mon, 2011-02-07 at 17:05 +0700, Samphan Raruenrom wrote: FYI: We simply rename soffice.bin to soffice.bin.exe and open in it Visual C++. Then add those path you mentioned in Project Properties. Sounds like we need to add this to some how to debug LibreOffice wiki page :-) [ neat tip there ]. Thanks, Michael. PS. I took the time to cut the 100 lines of redundant context ;-) -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Sun, 2011-02-06 at 05:44 -0600, Norbert Thiebaud wrote: Note that the main drawback of our current approach is indeed the bisection problem. It would be certainly be convinient to be able to bisect on the entire set of repos... but how much pain/risk do we want to take to improve that aspect of things ? Could we do some sort of date based bisection ? or does that not work because the patches are not in chronological order really ;-) Hmm, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar
On Wed, Feb 2, 2011 at 12:18 AM, Baptiste Daroussin b...@freebsd.org wrote:
So, to make things simple, let's force user having GNU tar, not BSD tar.
Seriously why not supporting bsdtar?
OK,
I think BSD tar is as good as GNU tar :)
Let's close the topic here so that RMS won't jump into LibO cough-cough :)
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 07, 2011 at 04:29:23PM +, Michael Meeks
michael.me...@novell.com wrote:
Could we do some sort of date based bisection ? or does that not work
because the patches are not in chronological order really ;-)
It's possible to do g checkout @{2011-02-07}, but then we have to
reinvent our own git-bisect, which won't support this.
pgpNwEq6jCVoV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 07, 2011 at 09:38:14AM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: How about having a after-push git-hook in the master branch in our git.fdi/git/libreoffice/* git repos that generate the list of HEAD-sha1 that was you should be able to almost-completely bisect. sure in some cases the fact that 2 commit in two git are interdependent would throw off the bisection. but that is not that common. You mean when g commit g push creates / pushes multiple commits? For example when you rename a function in a repo and fix the build in 3 other ones. It would be really nice not to try to test the 3 ones where the build will obviously fail (and the tinbuild approach provides this). OTOH of course that's possible - provided that those hooks still push the state to a githeads.git? Another problem would be merge of feature branches, which would be counted as just one bisect step for the whole branch (but that is true even with the tinderbuild based solution) Sure - I don't have an idea either how to not count a merge as a single step with split repos. pgpPIPOn65vtw.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] who is who
On Mon, Feb 07, 2011 at 08:53:57AM -0700, Tor Lillqvist tlillqv...@novell.com wrote: so that I can pin-point a question to the right persons :) Don't. Just send questions to this list. Though we have a related page: http://www.freedesktop.org/wiki/Software/LibreOffice/FindTheExpert Should we get rid of that? pgpPLdQHQEgCE.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] who is who
On Tue, Feb 8, 2011 at 12:17 AM, Tor Lillqvist tlillqv...@novell.com wrote:
Though we have a related page:
http://www.freedesktop.org/wiki/Software/LibreOffice/FindTheExpert
Thank you, it is extremely useful when I go to IRC as well.
That page is to help those doing bug triage, I think?
I don't think we want to start getting personally addressed mail asking for
enhancements,
surely? The norm in Open Source is to keep discussion in the open, on
publicly archived
mailing lists.
Thank you for reminding me that; being an open source enthusiast for
more than a decade,
I know the importance of being open - in communication, that's how
open source development
diagram works.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] who is who
On Tue, Feb 8, 2011 at 12:12 AM, Miklos Vajna vmik...@frugalware.org wrote:
Though we have a related page:
http://www.freedesktop.org/wiki/Software/LibreOffice/FindTheExpert
I couldn't find Michael Meeks on the list.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum
On Mon, 2011-02-07 at 15:30 +, Michael Meeks wrote:
Perhaps you can build your patch on top of Andrey's to capture that
goodness ?
OK. Attached.
I'm busy adding a few more easy hacks to try to make such
conflicts less likely: it can help to add your name and a date vs. an
easy hack (with perhaps a sub-portion of what you're working on).
I shall try and remember to do this in future.
Nigel
From 00f1b9804c1f19c1bb7e6c790910f9005f89321b Mon Sep 17 00:00:00 2001
From: Nigel Hawkins n.hawk...@gmx.com
Date: Mon, 7 Feb 2011 16:19:59 +
Subject: [PATCH] Replace std::pair with more descriptive names in SwUndoDelNum
---
sw/inc/undobj.hxx | 10 +++---
sw/source/core/undo/unnum.cxx | 10 +-
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/sw/inc/undobj.hxx b/sw/inc/undobj.hxx
index e6ea274..ae86015 100644
--- a/sw/inc/undobj.hxx
+++ b/sw/inc/undobj.hxx
@@ -1371,9 +1371,13 @@ public:
class SwUndoDelNum : public SwUndo, private SwUndRng
{
-typedef std::vector std::pair ULONG, int SvNode;
-SvNode aNodes;
-SvBools aRstLRSpaces;
+struct NodeLevel
+{
+ULONG index;
+int level;
+inline NodeLevel(ULONG idx, int lvl) : index(idx), level(lvl) {};
+};
+std::vectorNodeLevel aNodes;
SwHistory* pHistory;
public:
SwUndoDelNum( const SwPaM rPam );
diff --git a/sw/source/core/undo/unnum.cxx b/sw/source/core/undo/unnum.cxx
index d5afd1f..f13f94c 100644
--- a/sw/source/core/undo/unnum.cxx
+++ b/sw/source/core/undo/unnum.cxx
@@ -214,11 +214,11 @@ void SwUndoDelNum::Undo( SwUndoIter rUndoIter )
pHistory-TmpRollback( rDoc, 0 );
pHistory-SetTmpEnd( pHistory-Count() );
-for( SvNode::const_iterator i = aNodes.begin(); i != aNodes.end(); ++i )
+for( std::vectorNodeLevel::const_iterator i = aNodes.begin(); i != aNodes.end(); ++i )
{
-SwTxtNode* pNd = rDoc.GetNodes()[ i-first ]-GetTxtNode();
-OSL_ENSURE( pNd, wo ist der TextNode geblieben? );
-pNd-SetAttrListLevel( i-second );
+SwTxtNode* pNd = rDoc.GetNodes()[ i-index ]-GetTxtNode();
+OSL_ENSURE( pNd, Where has the TextNode gone? );
+pNd-SetAttrListLevel( i-level );
if( pNd-GetCondFmtColl() )
pNd-ChkCondColl();
@@ -246,7 +246,7 @@ void SwUndoDelNum::AddNode( const SwTxtNode rNd, BOOL )
{
if( rNd.GetNumRule() )
{
-aNodes.push_back( SvNode::value_type( rNd.GetIndex(), rNd.GetActualListLevel() ) );
+aNodes.push_back( NodeLevel( rNd.GetIndex(), rNd.GetActualListLevel() ) );
}
}
--
1.7.0.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 7, 2011 at 10:29 AM, Michael Meeks michael.me...@novell.com wrote: On Sun, 2011-02-06 at 05:44 -0600, Norbert Thiebaud wrote: Note that the main drawback of our current approach is indeed the bisection problem. It would be certainly be convinient to be able to bisect on the entire set of repos... but how much pain/risk do we want to take to improve that aspect of things ? Could we do some sort of date based bisection ? or does that not work because the patches are not in chronological order really ;-) Even if we could rely on a date (which we can't), that would give you the starting point. the bisection after that is just a bisection of the commit between that point and HEAD (usually) the problem is that we have commit scattered across 20 git repos... so in order to truly bisect, we need an extra layer to 'serialized' all the commit from all the git repos, and then bisect that series of commit Norbert Hmm, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 7, 2011 at 11:10 AM, Miklos Vajna vmik...@frugalware.org wrote: On Mon, Feb 07, 2011 at 09:38:14AM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: How about having a after-push git-hook in the master branch in our git.fdi/git/libreoffice/* git repos that generate the list of HEAD-sha1 that was you should be able to almost-completely bisect. sure in some cases the fact that 2 commit in two git are interdependent would throw off the bisection. but that is not that common. You mean when g commit g push creates / pushes multiple commits? For example when you rename a function in a repo and fix the build in 3 other ones. It would be really nice not to try to test the 3 ones where the build will obviously fail (and the tinbuild approach provides this). The problem of the tinderbox approach is the coarse granularity (it is not uncommon to have 1/2 a dozen or more of independent commit between 2 build, the reliability (tinderbox sometime are down and this is not necessarily detected quickly). furthermore if you only record 'good' tinderbox run, you may have a few days of commit in one interval. if you don't then you are in the same case than the scenario above (it doesn't build because of interdependent commit); One thing that we could do is that the pus-hook could do a commit amend if the committer is the same that the very last one. presumably linked commit on multiple repo are pushed 'together' so if a push on repos A is immediately followed by a push on repo B then the hook would do a git commit --amend instead of creating a new version. that ways you usually fold all theses change into one 'list-head' Of course you could have a race between two committer... but that is _really_ rare. Norbert OTOH of course that's possible - provided that those hooks still push the state to a githeads.git? Another problem would be merge of feature branches, which would be counted as just one bisect step for the whole branch (but that is true even with the tinderbuild based solution) Sure - I don't have an idea either how to not count a merge as a single step with split repos. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] git push / FOSDEM
Hi, I'm 3 commits ahead at home. But I have only the license to push the middle one on my own. How can I do that?!? The opening of FOSDEM was available from the webpage (and I thought it must have been fun to be there). What about the other talks? Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Strange Shared object xxx not found errors
My builds are now crashing in the same way in a few modules; pyuno is one of them. Making:libpyuno.so : ERROR: Shared object libpython2.6.so.1.0 not found, required by check_libpyuno.so dmake: Error code 1, while making '../../unxdflyx3.pro/lib/libpyuno.so' Forcing regeneration of dependency info Compiling: unoxml/source/dom/documentbuilder.cxx Retrying /home/ftigeot/Projects/LibreOffice/bootstrap/pyuno/source/module Making:all_pyuno.dpslo Making:libpyuno.so Compiling: unoxml/source/dom/documentfragment.cxx Compiling: unoxml/source/dom/documenttype.cxx : ERROR: Shared object libpython2.6.so.1.0 not found, required by check_libpyuno.so dmake: Error code 1, while making '../../unxdflyx3.pro/lib/libpyuno.so' dmake is trying to build libpyuno.so in pyuno/unxdflyx3.pro/lib/ The hidden command not visible in the build output is in the file pyuno/unxdflyx3.pro/misc/pyuno.libpyuno_1.cmd : g++ -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-zdynsort -g -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib',--enable-new-dtags -shared -L../../unxdflyx3.pro/lib -L../lib -L/home/ftigeot/Projects/LibreOffice/bootstrap/solenv/unxdflyx3/lib -L/home/ftigeot/Projects/LibreOffice/bootstrap/solver/330/unxdflyx3.pro/lib -L/home/ftigeot/Projects/LibreOffice/bootstrap/solenv/unxdflyx3/lib -LNO_JAVA_HOME/lib -LNO_JAVA_HOME/jre/lib/amd64 -LNO_JAVA_HOME/jre/lib/amd64/client -LNO_JAVA_HOME/jre/lib/amd64/native_threads -L/usr/pkg/lib ../../unxdflyx3.pro/slo/pyuno_version.o -o ../../unxdflyx3.pro/lib/libpyuno.so ../../unxdflyx3.pro/slo/pyuno_runtime.o ../../unxdflyx3.pro/slo/pyuno.o ../../unxdflyx3.pro/slo/pyuno_callable.o ../../unxdflyx3.pro/slo/pyuno_module.o ../../unxdflyx3.pro/slo/pyuno_type.o ../../unxdflyx3.pro/slo/pyuno_util.o ../../unxdflyx3.pro/slo/pyuno_except.o ../../unxdflyx3.pro/slo/pyuno_adapter.o ../../unxdflyx3.pro/slo/pyuno_gc.o -luno_cppu -luno_cppuhelpergcc3 -luno_sal -lpython2. 6 -lutil -Wl,--as-needed -pthread -lm -Wl,--no-as-needed The library is present in /usr/pkg/lib/libpython2.6.so.1.0 When I run the command by hand in a shell, there's no error and the target libpyuno.so is correctly created. I can't figure out why the build keeps stopping with these Shared object not found errors. Is there any way to have dmake print the commands it is trying to run or give more information on what it is actually doing ? -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Review needed - wikihelp always English
Hi Petr,
Jan Holesovsky píše v St 02. 02. 2011 v 09:36 +0100:
Can you please review the patch in the following bug, and push to
libreoffice-3-3?
https://bugs.freedesktop.org/show_bug.cgi?id=33258
It fixes a 3.3.1 blocker.
And the attached patch fixes the problem this patch introduced - sorry
for that :-( Can you please check?
I renamed AppendConfigToken_Impl() to AppendConfigToken(), because it is
used in more .cxx files, so it should be declared in a header, instead
of being extern.
Regards,
Kendy
From a038bd21e136f33ccd3bba465327f16b5803f1a0 Mon Sep 17 00:00:00 2001
From: Jan Holesovsky ke...@suse.cz
Date: Mon, 7 Feb 2011 19:56:28 +0100
Subject: [PATCH] wikihelp: Improve the check for existence of the localized help, fdo#33258.
This fixes commit 44eaa36c4ce25a7c861455e9dbe6c2c959adecb4 that introduced an
infinite recursion.
---
sfx2/source/appl/newhelp.cxx | 10 --
sfx2/source/appl/newhelp.hxx |3 +++
sfx2/source/appl/sfxhelp.cxx | 33 -
3 files changed, 27 insertions(+), 19 deletions(-)
diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx
index 8d8ca17..e55b8f7 100644
--- a/sfx2/source/appl/newhelp.cxx
+++ b/sfx2/source/appl/newhelp.cxx
@@ -132,8 +132,6 @@ using namespace ::com::sun::star::ui;
using namespace ::comphelper;
-extern void AppendConfigToken_Impl( String rURL, sal_Bool bQuestionMark ); // sfxhelp.cxx
-
// defines ---
#define SPLITSET_ID 0
@@ -652,7 +650,7 @@ void IndexTabPage_Impl::InitializeIndex()
aURL += ::rtl::OUString( sFactory );
String aTemp = aURL;
-AppendConfigToken_Impl( aTemp, sal_True );
+AppendConfigToken( aTemp, sal_True );
aURL = aTemp;
Content aCnt( aURL, Reference ::com::sun::star::ucb::XCommandEnvironment () );
@@ -1097,7 +1095,7 @@ IMPL_LINK( SearchTabPage_Impl, SearchHdl, PushButton*, EMPTYARG )
if ( !aFullWordsCB.IsChecked() )
aSearchText = sfx2::PrepareSearchString( aSearchText, xBreakIterator, true );
aSearchURL += aSearchText;
-AppendConfigToken_Impl( aSearchURL, sal_False );
+AppendConfigToken( aSearchURL, sal_False );
if ( aScopeCB.IsChecked() )
aSearchURL += DEFINE_CONST_UNICODE(Scope=Heading);
Sequence ::rtl::OUString aFactories = SfxContentHelper::GetResultSet( aSearchURL );
@@ -1522,7 +1520,7 @@ sal_Bool SfxHelpWindow_Impl::splitHelpURL(const ::rtl::OUString sHelpURL,
sHelpURL.append(sFactory);
sHelpURL.append(sContent);
String sURL = String(sHelpURL.makeStringAndClear());
-AppendConfigToken_Impl(sURL, bUseQuestionMark);
+AppendConfigToken(sURL, bUseQuestionMark);
if (sAnchor.getLength())
sURL += String(sAnchor);
return ::rtl::OUString(sURL);
@@ -1643,7 +1641,7 @@ SfxHelpIndexWindow_Impl::~SfxHelpIndexWindow_Impl()
void SfxHelpIndexWindow_Impl::Initialize()
{
String aHelpURL = HELP_URL;
-AppendConfigToken_Impl( aHelpURL, sal_True );
+AppendConfigToken( aHelpURL, sal_True );
Sequence ::rtl::OUString aFactories = SfxContentHelper::GetResultSet( aHelpURL );
const ::rtl::OUString* pFacs = aFactories.getConstArray();
UINT32 i, nCount = aFactories.getLength();
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index 268ca39..cb3e942 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -611,6 +611,9 @@ public:
inline String GetTitle() const { return aTitleED.GetText(); }
};
+/// Appends ?Language=xySystem=abc to the help URL in rURL
+void AppendConfigToken( String rURL, sal_Bool bQuestionMark, const rtl::OUString rLang = rtl::OUString() );
+
#endif // #ifndef INCLUDED_SFX_NEWHELP_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index 586515c..d425107 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -113,7 +113,7 @@ void NoHelpErrorBox::RequestHelp( const HelpEvent )
#define STARTERLIST 0
-static bool impl_hasHelpInstalled();
+static bool impl_hasHelpInstalled( const rtl::OUString rLang );
/// Return the locale we prefer for displaying help
static rtl::OUString HelpLocaleString()
@@ -121,13 +121,16 @@ static rtl::OUString HelpLocaleString()
static rtl::OUString aLocaleStr;
if (!aLocaleStr.getLength())
{
+const rtl::OUString aEnglish( RTL_CONSTASCII_USTRINGPARAM( en ) );
// detect installed locale
Any aLocale =
::utl::ConfigManager::GetConfigManager().GetDirectConfigProperty(
::utl::ConfigManager::LOCALE );
aLocale = aLocaleStr;
bool bOk = aLocaleStr.getLength() != 0;
-if ( impl_hasHelpInstalled() bOk )
+if ( !bOk )
+aLocaleStr = aEnglish;
+else
{
rtl::OUString aBaseInstallPath;
Re: [Libreoffice] Review needed - wikihelp always English
Jan Holesovsky píše v Po 07. 02. 2011 v 20:17 +0100: Hi Petr, Jan Holesovsky píše v St 02. 02. 2011 v 09:36 +0100: Can you please review the patch in the following bug, and push to libreoffice-3-3? https://bugs.freedesktop.org/show_bug.cgi?id=33258 It fixes a 3.3.1 blocker. And the attached patch fixes the problem this patch introduced - sorry for that :-( Can you please check? I renamed AppendConfigToken_Impl() to AppendConfigToken(), because it is used in more .cxx files, so it should be declared in a header, instead of being extern. It seems that it finally unwinded all the cycles = pushed. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] issue with Borderline structure
I am having an issue with my extension Borderliner written in Java. It works fine with Oracle OOo, but does not with Go-OO and LO. It generates the bug IllegalArgumentException: com.sun.star.lang.IllegalArgumentException: at com.sun.star.bridges.jni_uno.JNI_proxy.dispatch_call(Native Method) at com.sun.star.bridges.jni_uno.JNI_proxy.invoke(JNI_proxy.java:175) at $Proxy6.setPropertyValue(Unknown Source) at name.dhiller.jBorderLiner.Borders.SetBordersSingleCell(Borders.java:400) at name.dhiller.jBorderLiner.Borders.SetBordersCellRange(Borders.java:367) at name.dhiller.jBorderLiner.Borders.SetBordersCell(Borders.java:319) at name.dhiller.jBorderLiner.Borders.DoBorders(Borders.java:70) at name.dhiller.jBorderLiner.BLKeyHandlerImpl.keyPressed(BLKeyHandlerImpl.java:53) so basically at xTableProps.setPropertyValue(BottomBorder, sBorderline); As I learnt form the api.openoffice.org list, [http://api.openoffice.org/servlets/ReadMsg?list=devmsgNo=23175 ] the API using the Borderline Structure is broken in LO. Tested on - Debian OOo 3.2.1 (so Go-oo) - fails (both with OpenJDK 6 and Sun Java 6) - Ubuntu and LO 3.3 - fails - Vista and Oracle OOo 3.3 - works I'd appreciate some help to make this extension work with LO. - What was changed in LO API in der Borderline Structure? - How do I have to address the Borderline now withing LO? - Pointing me to the documentation is sufficient Alternatively, I can provide support for making the Borderline Structure work again. Thanks Dietmar -- http://extensions.services.openoffice.org/en/project/BorderLiner ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Review needed - wikihelp always English
Petr Mladek píše v Po 07. 02. 2011 v 21:14 +0100: It seems that it finally unwinded all the cycles = pushed. Added [PUSHED] :-) K. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Corrected typo in names of four swriter classes
From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001
From: Christoph Herzog rho...@googlemail.com
Date: Mon, 7 Feb 2011 21:20:16 +0100
Subject: [PATCH] Corrected typo in names of four swriter classes
Checked for the misspelled names via ./g grep, built master before and
after the changes and no error occurred. So hopefully it is ok.
patch under LGPLv3+/MPL.
Christoph
From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001
From: Christoph Herzog rho...@googlemail.com
Date: Mon, 7 Feb 2011 21:20:16 +0100
Subject: [PATCH] Corrected typo in names of four swriter classes
Classes
AbstarctSwLabDlg
AbstarctSwLabDlg_Impl
AbstarctSwSelGlossaryDlg
AbstarctSwSelGlossaryDlg_Impl
were changed to:
AbstractSwLabDlg
AbstractSwLabDlg_Impl
AbstrarctSwSelGlossaryDlg
AbstractSwSelGlossaryDlg_Impl
---
sw/inc/swabstdlg.hxx |8
sw/source/ui/app/applab.cxx |2 +-
sw/source/ui/dialog/swdlgfact.cxx | 34 +-
sw/source/ui/dialog/swdlgfact.hxx | 12 ++--
sw/source/ui/dochdl/gloshdl.cxx |2 +-
5 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 57609db..e864213 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -256,14 +256,14 @@ public:
virtual voidSetWindowState( const ByteString rStr ) =0;//this method inherit from SystemWindow
};
-class AbstarctSwLabDlg : public SfxAbstractTabDialog //add for SwLabDlg
+class AbstractSwLabDlg : public SfxAbstractTabDialog //add for SwLabDlg
{
public:
virtual const String GetBusinessCardStr() const = 0;
virtual Printer *GetPrt() =0;
};
-class AbstarctSwSelGlossaryDlg : public VclAbstractDialog //add for SwSelGlossaryDlg
+class AbstractSwSelGlossaryDlg : public VclAbstractDialog //add for SwSelGlossaryDlg
{
public:
virtual void InsertGlos(const String rRegion, const String rGlosName) = 0; // inline
@@ -372,7 +372,7 @@ public:
virtual SfxAbstractTabDialog* CreateSwEnvDlg ( Window* pParent, const SfxItemSet rSet, SwWrtShell* pWrtSh, Printer* pPrt, BOOL bInsert,int nResId ) = 0; //add for SwEnvDlg
-virtual AbstarctSwLabDlg* CreateSwLabDlg ( Window* pParent, const SfxItemSet rSet, //add for SwLabDlg
+virtual AbstractSwLabDlg* CreateSwLabDlg ( Window* pParent, const SfxItemSet rSet, //add for SwLabDlg
SwNewDBMgr* pNewDBMgr, BOOL bLabel,int nResId ) = 0;
virtual SwLabDlgMethod GetSwLabDlgStaticMethod () =0;//add for SwLabDlg
@@ -386,7 +386,7 @@ public:
BOOL bDraw = FALSE,
UINT16 nDefPage = 0) = 0;
-virtual AbstarctSwSelGlossaryDlg * CreateSwSelGlossaryDlg ( Window * pParent, const String rShortName, int nResId ) = 0; //add for SwSelGlossaryDlg
+virtual AbstractSwSelGlossaryDlg * CreateSwSelGlossaryDlg ( Window * pParent, const String rShortName, int nResId ) = 0; //add for SwSelGlossaryDlg
virtual VclAbstractDialog * CreateVclAbstractDialog ( Window * pParent, SwWrtShell rSh, int nResId ) = 0; //add for SwTableHeightDlg SwSortDlg
virtual AbstractSplitTableDialog * CreateSplitTblDialog ( Window * pParent, SwWrtShell rSh ) = 0; //add for SwSplitTblDlg
diff --git a/sw/source/ui/app/applab.cxx b/sw/source/ui/app/applab.cxx
index b86ac51..186d93c 100644
--- a/sw/source/ui/app/applab.cxx
+++ b/sw/source/ui/app/applab.cxx
@@ -189,7 +189,7 @@ void SwModule::InsertLab(SfxRequest rReq, sal_Bool bLabel)
SwAbstractDialogFactory* pDialogFactory = SwAbstractDialogFactory::Create();
OSL_ENSURE(pDialogFactory, SwAbstractDialogFactory fail!);
-AbstarctSwLabDlg* pDlg = pDialogFactory-CreateSwLabDlg( 0, aSet, pNewDBMgr, bLabel, DLG_LAB );
+AbstractSwLabDlg* pDlg = pDialogFactory-CreateSwLabDlg( 0, aSet, pNewDBMgr, bLabel, DLG_LAB );
OSL_ENSURE(pDlg, Dialogdiet fail!);
if ( RET_OK == pDlg-Execute() )
diff --git a/sw/source/ui/dialog/swdlgfact.cxx b/sw/source/ui/dialog/swdlgfact.cxx
index c0b05c8..d943911 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -123,8 +123,8 @@ IMPL_ABSTDLG_BASE(AbstractTabDialog_Impl); //add for SwCharDlg, SwFootNoteOption
IMPL_ABSTDLG_BASE(AbstractSwConvertTableDlg_Impl); //add for SwConvertTableDlg
IMPL_ABSTDLG_BASE(AbstractSwInsertDBColAutoPilot_Impl); //add for SwInsertDBColAutoPilot
IMPL_ABSTDLG_BASE(AbstractDropDownFieldDialog_Impl); //add for DropDownFieldDialog
-IMPL_ABSTDLG_BASE(AbstarctSwLabDlg_Impl);//add for SwLabDlg
-IMPL_ABSTDLG_BASE(AbstarctSwSelGlossaryDlg_Impl);//add for SwSelGlossaryDlg
+IMPL_ABSTDLG_BASE(AbstractSwLabDlg_Impl);//add for SwLabDlg
+IMPL_ABSTDLG_BASE(AbstractSwSelGlossaryDlg_Impl);//add for SwSelGlossaryDlg
IMPL_ABSTDLG_BASE(AbstractSwAutoFormatDlg_Impl); //add for SwAutoFormatDlg
IMPL_ABSTDLG_BASE(AbstractSwFldDlg_Impl); //add for
Re: [Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum
On Monday 07 February 2011 20:50:12 Nigel Hawkins wrote: On Mon, 2011-02-07 at 15:30 +, Michael Meeks wrote: Perhaps you can build your patch on top of Andrey's to capture that goodness ? OK. Attached. So that would be the next step? Should I squash the two patches and resubmit it? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Branch libreoffice-3-3-1 created
Hi all, Similarly to the release of 3.3.0, we have created a branch for the stabilization of the 3.3.1, called 'libreoffice-3-3-1'. It is not based on a tag yet, Petr will tag tomorrow. The following rules apply: + any commit has to be reviewed by 3 people + preferably commit only translation fixes, or blocker fixes + only cherry-pick from the libreoffice-3-3 branch The 'libreoffice-3-3' branch is still active, will be used for the next bugfix release (3.3.2), and has the following rules: + any commit needs review by 1 person + only safe fixes are allowed + changes are regularly merged into master The 'master' branch is used for 3.4 development and has the rules: + free commit; do your best to do not break build and functionality + any development allowed For further information about the roadmap, please check http://wiki.documentfoundation.org/ReleasePlan Now, if you want to switch your clone to the libreoffice-3-3-1 branch, do: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-1 origin/libreoffice-3-3-1 bin/g checkout -b libreoffice-3-3-1 origin/libreoffice-3-3-1 Hopefully it will work for you :-) Most probably, you will also want to do (if you haven't done it yet): git config --global push.default tracking When you do git push with this, git will push only the branch you are on; ie. libreoffice-3-3-1 when you have switched to it. This will save you some git shouting at you. Happy hacking, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git push / FOSDEM
On Mon, Feb 07, 2011 at 07:33:05PM +0100, Christina Roßmanith chrrossman...@web.de wrote: I'm 3 commits ahead at home. But I have only the license to push the middle one on my own. How can I do that?!? Using git rebase -i. See its manpage, you can reorder the commits so that the middle one will be the first, then 'git push origin HEAD~2:master' will push just that one for you. It even has a -n flag if you want to double-check before you do anything. If it gets rejected, use the usual 'git pull -r'. HTH. pgpg8Y2lzhtsS.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] patch lib-core/eventattacher
Hi,
Here is a small patch which translates the comments in the
eventattacher from German to English
--
Greetings,
Rob Sneldersdiff --git a/eventattacher/source/eventattacher.cxx b/eventattacher/source/eventattacher.cxx
index 6cae50e..7599431 100644
--- a/eventattacher/source/eventattacher.cxx
+++ b/eventattacher/source/eventattacher.cxx
@@ -253,7 +253,7 @@ private:
Mutexm_aMutex;
Reference XMultiServiceFactory m_xSMgr;
-// Services merken
+// Save Services
Reference XIntrospection m_xIntrospection;
Reference XIdlReflection m_xReflection;
Reference XTypeConverter m_xConverter;
@@ -374,11 +374,10 @@ void SAL_CALL EventAttacherImpl::initialize(const Sequence Any Arguments) th
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference XIntrospection EventAttacherImpl::getIntrospection() throw( Exception )
{
Guard Mutex aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xIntrospection.is() )
{
Reference XInterface xIFace( m_xSMgr-createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.beans.Introspection)) ) );
@@ -392,7 +391,6 @@ Reference XIntrospection EventAttacherImpl::getIntrospection() throw( Excepti
Reference XIdlReflection EventAttacherImpl::getReflection() throw( Exception )
{
Guard Mutex aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xReflection.is() )
{
Reference XInterface xIFace( m_xSMgr-createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.reflection.CoreReflection)) ) );
@@ -402,11 +400,10 @@ Reference XIdlReflection EventAttacherImpl::getReflection() throw( Exception
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference XInvocationAdapterFactory EventAttacherImpl::getInvocationAdapterService() throw( Exception )
{
Guard Mutex aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xInvocationAdapterFactory.is() )
{
Reference XInterface xIFace( m_xSMgr-createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.script.InvocationAdapterFactory)) ) );
@@ -417,11 +414,10 @@ Reference XInvocationAdapterFactory EventAttacherImpl::getInvocationAdapterSe
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference XTypeConverter EventAttacherImpl::getConverter() throw( Exception )
{
Guard Mutex aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xConverter.is() )
{
Reference XInterface xIFace( m_xSMgr-createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.script.Converter)) ) );
@@ -433,8 +429,8 @@ Reference XTypeConverter EventAttacherImpl::getConverter() throw( Exception )
//
//
//
-// Implementation eines EventAttacher-bezogenen AllListeners, der
-// nur einzelne Events an einen allgemeinen AllListener weiterleitet
+// Implementation of a EventAttacher-related AllListeners, which brings
+// a few Events to a general AllListener
class FilterAllListenerImpl : public WeakImplHelper1 XAllListener
{
public:
@@ -473,7 +469,6 @@ FilterAllListenerImpl::FilterAllListenerImpl( EventAttacherImpl * pEA_, const OU
void SAL_CALL FilterAllListenerImpl::firing(const AllEventObject Event)
throw( RuntimeException )
{
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod m_AllListener.is() )
m_AllListener-firing( Event );
}
@@ -529,7 +524,6 @@ Any SAL_CALL FilterAllListenerImpl::approveFiring( const AllEventObject Event )
{
Any aRet;
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod m_AllListener.is() )
aRet = m_AllListener-approveFiring( Event );
else
@@ -579,35 +573,30 @@ Reference XEventListener EventAttacherImpl::attachListener
Reference XEventListener xRet = NULL;
-// InvocationAdapterService holen
Reference XInvocationAdapterFactory xInvocationAdapterFactory = getInvocationAdapterService();
if( !xInvocationAdapterFactory.is() )
throw ServiceNotRegisteredException();
-// Listener-Klasse per Reflection besorgen
Reference XIdlReflection xReflection = getReflection();
if( !xReflection.is() )
throw ServiceNotRegisteredException();
-// Anmelden, dazu passende addListener-Methode aufrufen
-// Zunaechst ueber Introspection gehen, da die Methoden in der
Re: [Libreoffice] git submodule
On Mon, Feb 07, 2011 at 12:18:39PM -0600, Norbert Thiebaud nthieb...@gmail.com wrote: The problem of the tinderbox approach is the coarse granularity (it is not uncommon to have 1/2 a dozen or more of independent commit between 2 build, the reliability (tinderbox sometime are down and this is not necessarily detected quickly). furthermore if you only record 'good' tinderbox run, you may have a few days of commit in one interval. if you don't then you are in the same case than the scenario above (it doesn't build because of interdependent commit); Hm, OK. One thing that we could do is that the pus-hook could do a commit amend if the committer is the same that the very last one. presumably linked commit on multiple repo are pushed 'together' so if a push on repos A is immediately followed by a push on repo B then the hook would do a git commit --amend instead of creating a new version. that ways you usually fold all theses change into one 'list-head' Of course you could have a race between two committer... but that is _really_ rare. Automatic git commit --amend is really dangerous, I would not do it. It's not an accident non-fastforwards are rejected while pushing. So - in case post-receive hooks on the freedesktop servers are allowed (CIA is not notified from such a hook at the moment), we could create a githeads.git which is updated after every push and git bisect could run there. Given that there is a githeads.txt in that repo, the g wrapper could update the repos accordingly. Does this sound acceptable? (And there could be multiple branches in githeads.git, just like in the repos.) pgpJhHrvup0ci.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Feb 07, 2011 at 10:33:00PM +0100, Miklos Vajna vmik...@frugalware.org wrote: Automatic git commit --amend is really dangerous, I would not do it. It's not an accident non-fastforwards are rejected while pushing. It turns out I misunderstood it, I thought this is about git commit --amend in the repos, not in githeads.git. So here is what we discussed on IRC: The problem of a logical commit may affect multiple repos and you don't want to bisect a state when such a multi-repo change is not fully applied is similar to the one the cvs2something more modern converters do, where cvs does not handle multi-file commits. That means in case one uses the same commit message for commits in different repos, we can assume it does not make sense to try to build when not all affected repos are updated. As a consequence, a post-receive git hook could be written, which would be executed on the freedesktop servers, which would do the followings: for i in repos: for j in commits: update_githeads_txt() if (j.author, j.commitmsg) in githeads: # the same author already pushed something with # the same commit message to an other repo git commit --amend githeads.txt else: # something new git commit githeads.txt In reality 'g push' executes git push for each affected repo, so the hook in fact would do the inner cycle only. Also, we could add one more constraint: when we use --amend, the timestamp of the old commit should not differ too much (say, 5 minutes) from the new commit. The format of githeads.txt could be still what tinbuild has, we can get other properties of the commits anytime from the repos based on the sha1. Does this sound reasonable? That way we would have a githeads.git that could be used for bisecting (the 'g bisect' part if of course missing, but possible to implement - that would update the state of the repos based on githeads.txt) and it would be quite small. pgpH0NCnr4nwg.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Wiki Development/Code Overview
I've made some changes to the hierarchical structure of the page and added an alphabetical list of directoriesrepositories in clone/. Please check whether I'm taking the right direction. Christoph ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Breaking in sw: error: expected template-name before '' token
Hello, I'll try this again: I'm getting, first, warnings about declarations that have been previously defined. warning: this is the location of the previous definition and finally a number of errors about a operators missing. Following is the complete output. Please let me know if this list (LibreOffice) prefers attachments to adding trace messages in-line. Thanks, -Dave rm -Rf /Users/dfdumaresq/git/libo/sw/unxmacxi.pro # optional module 'clean' /bin/sh cd /Users/dfdumaresq/git/libo sh-3.2$ source ./MacOSXX86Env.Set.sh sh-3.2$ cd sw sh-3.2$ build build -- version: 275224 = Building module sw = Entering /Users/dfdumaresq/git/libo/sw/inc mkout -- version: 1.8 Entering /Users/dfdumaresq/git/libo/sw/sdi Making:swslots.don Making:swslots_sid.hid Entering /Users/dfdumaresq/git/libo/sw/source/ui/inc mkdir: ../../../unxmacxi.pro/inc/: File exists mkdir: ../../../unxmacxi.pro/inc/: File exists Entering /Users/dfdumaresq/git/libo/sw/source/ui/smartmenu Making:all_smartmenu.dpslo Making:smartmenu.dpr Making:smartmenu.smartmenu.dprr RscDep 1.0 (c)2000 StarOffice Compiling: sw/source/ui/smartmenu/stmenu.cxx Making:smartmenu.lib Making:smartmenu.srs Compiling: sw/source/ui/smartmenu/stmenu.src Making:smartmenu_srs.hid Entering /Users/dfdumaresq/git/libo/sw/source/ui/uno Making:all_unoidl.dpslo Compiling: sw/source/ui/uno/unodefaults.cxx Compiling: sw/source/ui/uno/unodispatch.cxx Compiling: sw/source/ui/uno/unotxdoc.cxx Compiling: sw/source/ui/uno/unoatxt.cxx Compiling: sw/source/ui/uno/unomailmerge.cxx Compiling: sw/source/ui/uno/unomod.cxx Compiling: sw/source/ui/uno/unotxvw.cxx Compiling: sw/source/ui/uno/dlelstnr.cxx Compiling: sw/source/ui/uno/unofreg.cxx Compiling: sw/source/ui/uno/SwXDocumentSettings.cxx Compiling: sw/source/ui/uno/SwXPrintPreviewSettings.cxx Compiling: sw/source/ui/uno/SwXFilterOptions.cxx Compiling: sw/source/ui/uno/RefreshListenerContainer.cxx Compiling: sw/source/ui/uno/unomodule.cxx Compiling: sw/source/ui/uno/unodoc.cxx Compiling: sw/source/ui/uno/swdetect.cxx Compiling: sw/source/ui/uno/swdet2.cxx Compiling: sw/source/ui/uno/detreg.cxx Making:unoidl.lib Making:all_unoidl.dpslo Entering /Users/dfdumaresq/git/libo/sw/source/ui/config Making:all_config.dpslo Making:config.dpr Making:config.config.dprr RscDep 1.0 (c)2000 StarOffice Compiling: sw/source/ui/config/barcfg.cxx Compiling: sw/source/ui/config/cfgitems.cxx Compiling: sw/source/ui/config/fontcfg.cxx Compiling: sw/source/ui/config/mailconfigpage.cxx Compiling: sw/source/ui/config/modcfg.cxx Compiling: sw/source/ui/config/optcomp.cxx Compiling: sw/source/ui/config/optload.cxx Compiling: sw/source/ui/config/optpage.cxx Compiling: sw/source/ui/config/prtopt.cxx Compiling: sw/source/ui/config/uinums.cxx Compiling: sw/source/ui/config/usrpref.cxx Compiling: sw/source/ui/config/viewopt.cxx Compiling: sw/source/ui/config/caption.cxx Compiling: sw/source/ui/config/dbconfig.cxx Making:config.lib Making:config.srs Compiling: sw/source/ui/config/mailconfigpage.src Compiling: sw/source/ui/config/optdlg.src Compiling: sw/source/ui/config/optload.src Compiling: sw/source/ui/config/optcomp.src Compiling: sw/source/ui/config/redlopt.src Making:config_srs.hid Making:all_config.dpslo Entering /Users/dfdumaresq/git/libo/sw/source/core/SwNumberTree Making:all_SwNumberTree.dpslo Compiling: sw/source/core/SwNumberTree/SwNodeNum.cxx Compiling: sw/source/core/SwNumberTree/SwNumberTree.cxx Making:SwNumberTree.lib Entering /Users/dfdumaresq/git/libo/sw/source/core/frmedt Making:all_frmedt.dpslo Compiling: sw/source/core/frmedt/fecopy.cxx Compiling: sw/source/core/frmedt/fedesc.cxx Compiling: sw/source/core/frmedt/fefly1.cxx Compiling: sw/source/core/frmedt/feflyole.cxx Compiling: sw/source/core/frmedt/feshview.cxx Compiling: sw/source/core/frmedt/fetab.cxx Compiling: sw/source/core/frmedt/fews.cxx Compiling: sw/source/core/frmedt/tblsel.cxx Making:frmedt.lib Making:all_frmedt.dpslo Entering /Users/dfdumaresq/git/libo/sw/source/core/text Making:all_text.dpslo Compiling: sw/source/core/text/EnhancedPDFExportHelper.cxx Compiling: sw/source/core/text/SwGrammarMarkUp.cxx Compiling: sw/source/core/text/atrstck.cxx Compiling: sw/source/core/text/blink.cxx Compiling: sw/source/core/text/frmcrsr.cxx Compiling: sw/source/core/text/frmform.cxx Compiling: sw/source/core/text/frminf.cxx Compiling: sw/source/core/text/frmpaint.cxx Compiling: sw/source/core/text/guess.cxx Compiling: sw/source/core/text/inftxt.cxx Compiling: sw/source/core/text/itradj.cxx Compiling: sw/source/core/text/itratr.cxx Compiling: sw/source/core/text/itrcrsr.cxx Compiling: sw/source/core/text/itrform2.cxx Compiling: sw/source/core/text/itrpaint.cxx Compiling: sw/source/core/text/itrtxt.cxx Compiling: sw/source/core/text/noteurl.cxx Compiling: sw/source/core/text/porexp.cxx Compiling: sw/source/core/text/porfld.cxx Compiling:
Re: [Libreoffice] [PUSHED] Fix cppcheck errors and warnings
On 02/07/11 01:37, David Tardon wrote: On Sun, Feb 06, 2011 at 09:42:46PM +0100, Xisco Faulí wrote: -} section[SECTIONS]; +} section[SECTIONS] = NULL; This is false alarm. The struct has default constructor, so the elements of the array are initialized properly. +delete [] level; This is wrong, because OutlineNumbering deletes the passed level in its destructor. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Hi David, Just a friendly reminder to file a bug with cppcheck's devs if you've found false positives or outright mistakes made by cppcheck. We want to help them help us. :) They have April 9th slated as the next cppcheck release date, so lets be sure to get all the LO-found fixes into their tree and keep false/misleading results out of http://libreoffice.boldandbusted.com/ . If you did this already, sweet! :) Cheers, Jesse Adelman Linux Systems Consultant, ilikelinux Consulting http://www.ilikelinux.com/ Bold and Busted LLC http://www.boldandbusted.com/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] A patch need review Re: Who do I know when a patch will make it to a release
Can someone review the patch to go to libreoffce-3-3, please. On Sat, Feb 5, 2011 at 2:09 AM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2011-02-04 at 09:44 +, Michael Meeks wrote: Caolan - are you happy for this: commit 6c01edfe66d6e350b20178d9ab367806d956cb46 Author: Caolán McNamara caol...@redhat.com Date: Thu Nov 11 13:31:33 2010 + Resolves: #i25247#, #i25561#, #i48064#, #i92341# CTL/Other Default Font to go to libreoffice-3-3 ? if so, I guess that's fine without further review; at least it looks like an Oracle patch to me - 'ftcAsci' eg. ;-) Its my patch, so I'm happy with it by definition, and someone else probably needs to do a quick review of it. ftcAsci is the spelling used in the MS docs for this (IIRC), not mine. C. -- _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour
On Mon, 2011-02-07 at 02:29 +0700, Nguyen Vu Hung wrote: m$ excel allows content in cells a1, a3, a5 to be selected and copied to a7, a9, a11. This is not possible in calc. A feature request please. http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_copy_and_paste_of_multiple_ranges Added to Easy Hacks page. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour
On Tue, Feb 8, 2011 at 11:05 AM, Kohei Yoshida kyosh...@novell.com wrote:
On Mon, 2011-02-07 at 02:29 +0700, Nguyen Vu Hung wrote:
m$ excel allows content in cells a1, a3, a5 to be selected and copied
to a7, a9, a11. This is not possible in calc. A feature request
please.
http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_copy_and_paste_of_multiple_ranges
Added to Easy Hacks page.
Thank you!
# I've added the OP to the CC:
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] BUG: Auto filter
On Fri, 2011-02-04 at 10:46 +0100, Thorsten Behrens wrote: Joel Björkman wrote: I read on www.libreoffice.org that it's best to file bugs to this mailinglist. So here's one. Hi Joel, um, where did you read that on libreoffice.org - we'd need to fix it there, because it's not really accurate - in fact, please file a bug report here: FYI, this is already an easy hack task. http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_one_autofilter_per_sheet.2C_not_per_document Anyone interested? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibO security
Hello all,
1. My apologies if this has been posted
http://www.openoffice.org/security/bulletin.html
Did we get them fixed in 3.3.0?
2. IMO, we need a security team, probably made up from some
QA and dev members.
- http://www.libreoffice.org/get-involved/
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
