Re: [Libreoffice] Strange Shared object xxx not found errors

[Francois Tigeot]

On Tue, Feb 08, 2011 at 09:30:56PM +, Caolán McNamara wrote:
> On Mon, 2011-02-07 at 19:35 +0100, Francois Tigeot wrote:
> > My builds are now crashing in the same way in a few modules; pyuno is one of
> > them.
> 
> > --enable-new-dtags ...
> > 
> > The library is present in /usr/pkg/lib/libpython2.6.so.1.0
> > When I run the command by hand in a shell, there's no error and the target
> > libpyuno.so is correctly created.
> 
> I wonder if in both cases what your LD_LIBRARY_PATH was set to,

It was not set.

The only environment variable I use is CPPFLAGS. If I don't type
export CPPFLAGS="-I/usr/pkg/include" before running autogen.sh, the build
system is unable to find include files for "system" libraries.

> there's
> a possibility that the recent --enable-new-dtags change in solenv, which
> I want to have so that LD_LIBRARY_PATH does the right thing for dlopen
> so that tests test the right .so, might be the trigger for this. 

I don't think --enable-new-dtags was the culprit. I have updated the sources
with g pull since my last mail and I only get these errors now:

/usr/libexec/binutils217/elf/ld: cannot find -luno_sal
/usr/libexec/binutils217/elf/ld: cannot find -lcosv

Seems like the same sort of trouble I had, only directly with ld instead
of g++
libuno_sal is a shared library and libcosv a static one (.a file)

> If LD_DEBUG=libs is supported in your os it might be helpful.

Unfortunately, it has no effect.

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] extending Easy Hacks with bugs ...

[Thorsten Behrens]

Michael Meeks wrote:
>   Is there some standard keyword we could use for this ? of course, I'd
> really only want developers adding that keyword - when they have added
> some suitable code pointers to make it truly 'easy' :-)
> 
Hi Michael, Rainer,

I believe we implicitely already do that - I see a bunch of Summary:
"[EasyHack] ..." or "EasyHack ..." titles in my query. 

(TBH I'd prefer the former).

Added a saved search for others to reuse:

https://bugs.freedesktop.org//buglist.cgi?cmdtype=runnamed&namedcmd=libo-easyhacks

Cheers,

-- Thorsten


pgpQfiho93fZ6.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Improvement LibreOffice

[Viktor Viktor]

Dear Sirs,

I am a user of open source software. I am also a writer and using LibreOffice 
having trouble with layout of books. There are specialized programs: Adobe 
PageMaker, Adobe InDesign, Microsoft Publisher.

Given the above I ask you to consider developing a similar product in the 
LibreOffice it also let free to develop publishing and more will make the world 
free.

Sincerely,
Michael Rohm
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Some help for LibreOffice testing with ODF ?

[Thorsten Behrens]

Cor Nouws wrote:
> Quote:
> "  before the next plugfest it would be really useful if someone
> from the LibreOffice community would set up a copy of LibreOffice
> for Officeshots.org (ideally on multiple platforms and both a trunk
> version and a release, but lets start with the basics). This is not
> a very difficult or timeconsuming thing to do, and it can run on a
> desktop in the background or on a small virtual machine somewhere.
> It would however be very useful for interop testing, because all
> test documents can be automatically pushed to it.
> 
> The manual for installing a factory can be found here:
> http://code.officeshots.org/trac/officeshots/wiki/FactoryManual
> 
> If you find a volunteer, he or she should register at
> http://www.officeshots.org and subsequently contact us and get the
> appropriate rights to set up a factory.
>   "
> 
Hi Cor,

I did that in the past for ooo-build, and have a machine around able
to run that - if they didn't change too much, I can prolly easily
recycle that.

Cheers,

-- Thorsten


pgpaJHu6kwRC7.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Issue in Base

[Thorsten Behrens]

Cor Nouws wrote:
> Bugzilla query returns "zarro boogs" so hence my question: is anyone
> aware of the bug in base wrt tool bars for report building?
> See users list
> http://www.mail-archive.com/users@libreoffice.org/msg02099.html
> 
Hi Cor,

at least I'm not - so better file a bug for it. I'd rather have a
dupe, than this falling through the cracks.

Cheers,

-- Thorsten


pgpQrbrgozqYo.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] which bugids to keep (was: [PUSHED] patch lib-core/eventattacher)

[Thorsten Behrens]

Cedric Bosdonnat wrote:
> On Tue, 2011-02-08 at 21:04 +0100, Christina Roßmanith wrote:
> > there were more patches not yet pushed, so I've applied them. I didn't 
> > touch the files which differed only by whitespace. And I didn't delete 
> > comments containing bugids and text. This I would like to leave for the 
> > experts  :-)
> 
> You were right not to delete those comments entirely... they can be
> useful.
> 
Yep - though in general, these '#123456#' bug ids can be elided -
the usually-followed convention is, that those are bugids of
StarDivision's old internal bugtracking system (and '#b123456#' the
ones from Sun's internal bugtracker) - so they're of no value to the
general public. Public OOo bugs are usually marked as '#i12345#' -
still worth checking though via

http://qa.openoffice.org/issues/show_bug.cgi?id=

whether just by chance someone forgot to add the 'i'.

So in this case, it would have been ok to remove the bugid, but
leave the rest of the (quite useful) comment.

Cheers,

-- Thorsten


pgpPjCCQsasln.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] extending Easy Hacks with bugs ...

[Michael Meeks]

Hi Rainer,

So - I'm concerned that our easy hacks page is getting burned away
rather rapidly; and I wonder - would it be good to have a set of "easy
bugs" - perhaps with a suitable tag, so we can have a generic query that
people can poke at to find things to fix. We have a lot of these (I
suspect) that are fairly trivial, but we have no time to address - and
it'd be great to start focusing more attention on them.

Is there some standard keyword we could use for this ? of course, I'd
really only want developers adding that keyword - when they have added
some suitable code pointers to make it truly 'easy' :-)

Any chance of adding that as a task in the wiki page and standardising
some keyword for it ?

Thanks !

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Wiki Development/Code Overview

[Michael Meeks]

Hi Christoph,

On Mon, 2011-02-07 at 23:32 +0100, Christoph Herzog wrote:
> I've made some changes to the hierarchical structure of the page and 
> added an alphabetical list of directories&repositories in clone/. Please 
> check whether I'm taking the right direction.

Ooh :-) looks nice - if you're talking about:

http://wiki.documentfoundation.org/Development/Code_Overview

I suppose we only want to pull out individual code modules / headers if
they are of particular interest to people in general [ eg. the shell ].

Of course, we want to import as many module-level descriptions as
possible; and (hopefully) also add them to git as module/README files in
each module top-level too [ perhaps with a nice link-back to the wiki ].

But what is there looks like a good foundation to build on some more,
go for it ! :-)

Thanks,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Breaking in sw: error: expected template-name before '<' token

[Michael Meeks]

Hi David,

On Mon, 2011-02-07 at 15:06 -0800, David Dumaresq wrote:
> I'm getting, first, warnings about declarations that have been previously 
> defined.  
>   "warning: this is the location of the previous definition" 

That is fairly normal :-)

> and finally a number of errors about a operators missing. Following is the 
> complete output.

This looks like it may be a side-effect of Fridrich's hash re-work; can
you update to the latest version (g pull -r) and try again ? this has
been in flux the last day or two. Failing that - we need to dig into the
OSX tinderbox output to see if others have this

> Please let me know if this list (LibreOffice) prefers attachments to adding
> trace messages in-line.

Best to cut the trace down so it is smaller IMHO, but here is fine :-)

..
> Compiling: sw/source/core/unocore/unocrsrhelper.cxx
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:76:
>  error: expected template-name before '<' token
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:76:
>  error: expected `{' before '<' token
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:76:
>  error: expected unqualified-id before '<' token
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:84:
>  error: invalid use of undefined type 'struct 
> comphelper::SequenceAsHashMapBase'
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:76:
>  error: forward declaration of 'struct comphelper::SequenceAsHashMapBase'
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:
>  In member function 'TValueType 
> comphelper::SequenceAsHashMap::getUnpackedValueOrDefault(const 
> rtl::OUString&, const TValueType&) const':
> /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/inc/comphelper/sequenceashashmap.hxx:281:
>  error: 'const_iterator' was not declared in this scope

Fridrich ?

ATB,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] adding easy hacks ...

[Michael Meeks]

On Mon, 2011-02-07 at 23:05 -0500, Kohei Yoshida wrote:
> http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_copy_and_paste_of_multiple_ranges
> Added to Easy Hacks page.

So - to make it truly 'Easy' - an easy hack needs more than this -
IMHO. Particularly, for an expert adding the task - it should have at
least one code pointer to where the cut/paste code is inside calc,
and/or which structures are relevant for storing things on the clipboard
and need extending :-)

It'd be great to add that, I'm trying to do the same for the document
gradient / shadow task ;-)

Thanks,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] re-enable icons on Linux for KDE

[Michael Meeks]

On Tue, 2011-02-08 at 20:43 +0100, Lubos Lunak wrote:
> On Sunday 06 of February 2011, Michael Meeks wrote:
> > Right ;-) they should all be built, and delivered into the solver, but
> > only the ones you specify should be bundled
> 
>  Does that mean you have broken KDE integration with that change :) ?

Oh ! yes, quite right - we should revert that for Linux, my fault - I
got over-enthusiastic about shrinking somehow. Do we really need both
CRYSTAL and OXYGEN (for kde3 and kde4 ?). Anyhow - patch to do that
appended for review for the dev branch. At least we dropped the classic
theme.

diff --git a/distro-configs/LibreOfficeLinux.conf.in 
b/distro-configs/LibreOfficeLinux.conf.in
index f55c19b..210ba3e 100644
--- a/distro-configs/LibreOfficeLinux.conf.in
+++ b/distro-configs/LibreOfficeLinux.conf.in
@@ -56,4 +56,4 @@
 --disable-kde4
 --disable-dbus
 --disable-crypt-link
---with-theme=\"default hicontrast tango\"
+--with-theme=\"default hicontrast tango oxygen crystal\"

Review appreciated,

Sorry,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fwd: [tdf-discuss] Problem with linking external sheets in CALC

[Kohei Yoshida]

On Tue, 2011-02-08 at 23:16 -0500, Kohei Yoshida wrote:
> On Mon, 2011-02-07 at 20:19 +0700, Nguyen Vu Hung wrote:
> > Hi OP and Kohei-san,
> > 
> > FYI, consider this as a nasty hack or a bug?
> 
> Well, if the sheet name of an external document changes, of course it
> will break links.  Nothing we can do about that.
> 
> > Is there any faster way how to update these broken links?
> 
> Perhaps you could try search and replace and replace the sheet name
> globally.  After that (or even before the search & replace) you can
> delete the old linkage from the Edit - Links... dialog.  The new link
> gets established as soon as the first cell gets fetched from the
> external doc.

Ah wait.  That's a wrong suggestion.  Try updating the link in the Links
dialog instead of removing it.  Removing the link probably causes all
the associated formulas to become values.

So, first do the search and replace of the sheet names, then update the
link.  That *might* work.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fwd: [tdf-discuss] Problem with linking external sheets in CALC

[Kohei Yoshida]

On Mon, 2011-02-07 at 20:19 +0700, Nguyen Vu Hung wrote:
> Hi OP and Kohei-san,
> 
> FYI, consider this as a nasty hack or a bug?

Well, if the sheet name of an external document changes, of course it
will break links.  Nothing we can do about that.

> Is there any faster way how to update these broken links?

Perhaps you could try search and replace and replace the sheet name
globally.  After that (or even before the search & replace) you can
delete the old linkage from the Edit - Links... dialog.  The new link
gets established as soon as the first cell gets fetched from the
external doc.

> Or could someone to make a sugestion to the developers to fix it

So, what's broken in the current implementation?

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Get rid of SvBytes/SvSvULongs in SwUndoDelNum

[Kohei Yoshida]

On Tue, 2011-02-08 at 09:35 +, Nigel Hawkins wrote:
> On Mon, 2011-02-07 at 23:31 +0300, Andrey Turkin wrote:
> > So that would be the next step? Should I squash the two patches and 
> > resubmit 
> > it?
> 
> Hopefully, Michael or somebody will push the pair of them.

I did push both patches for you guys.

Thanks a lot.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] patch translating comments

[Kohei Yoshida]

Looks like someone has already applied this patch.

Setting [PUSHED] tag in the subject line.

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] translated parts of German comment in svtools/inc/ruler.hxx

[Kohei Yoshida]

On Tue, 2011-02-08 at 23:15 +0100, Tobias Rosenberger wrote:

> this patch is LGPLv3+/MPL.

Thanks!  Pushed.

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Remove obsolete Hyperlink Bar from calc

[Kohei Yoshida]

Hi Alfonso,

On Tue, 2011-02-08 at 21:41 +, Alfonso Eusebio wrote:

> Please find attached patch that removes the Hyperlink Bar from calc (made 
> available under LGPLv3+/MPL).
> Patch has been rebased with origin/master and compiled before submission.

Looks all good. Pushed.

> I've started removing the references to the Hyperlink Bar from the apps. Once 
> that's done I'll remove the implementation and menu entries in core modules.
> After applying this patch the menu entry to activate the bar is still present 
> but greyed out. This should dissapear once core modules are done.
> I'll be making one patch per app/module.

Gotcha.  I like your strategy.  Go for it!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fw: [PATCH] Removed unused functions and classes from calc 3last

[Kohei Yoshida]

On Tue, 2011-02-08 at 10:59 +, Alfonso Eusebio wrote:
> Hi,
> 
> Could somebody advise if the patch below is acceptable or if I should change 
> it 
> somehow?

I've answered your earlier post.  Sorry I was away at FOSDEM in the past
5 days.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [Pushed] refactoring gendict

[Norbert Thiebaud]

On Mon, Jan 31, 2011 at 6:04 AM, Kenneth Venken
 wrote:
>
> I think i've implemented all the suggestions. There's one hard coded limit
> (i < 0x1FFF) i don't get. Why isn't it 0x2000 since existMark has a size of
> 0x1. I changed it to i < 0x2000. This will not have an influence on
> xdictionary since the 0x1FFF limit is hardcoded there too. I'll look into
> xdictionary next to see if i can fix the fixme in gendict. Maybe then this
> will make sence to me too.
> I've also added support to print to standard output, but i don't know how to
> fix the build so it will pipe the output to the file.

Sorry for the tardiness, but I finally pushed it. I squashed all the
change into one commit, mostly because I was too lazy to re-order and
merge the commit 0009-0018 with the earlier commit that they were
fixing...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused functions and classes from calc 3last

[Kohei Yoshida]

Hi Alfonso,

On Sun, 2011-02-06 at 19:08 +, Alfonso Eusebio wrote:

> Please notice that this patch removes three entire classes: 
> ScSummableCompressedArray, ScVbaCharts and ScVbaSeriesCollection.
> For the last two classes the corresponding .cxx and .hxx files have been 
> removed.

Yup, that's the right thing to do.  There is no reason to keep the class
if it's entirely unused.

> This patch has been rebased with origin/master and compiled before submission.
> 
> On a related note:
> Several of the unused functions identified by call-catcher live in the addin 
> "module" within calc (calc/sc/addin). These functions seem to be called 
> indirectly by the function add-in mechanism.

Wow.  I never knew this (sc/addin) existed!  And yes, it's also my
understanding that scaddins is the right home for all the add-in
functions.

> I have not removed these functions, however, it seems that this "addin" 
> module 
> is obsolete now, with the scaddins (calc/scaddins) module replacing it (?).
> In any case, if somebody can confirm that the "addin" module can be removed, 
> I 
> could work on it.

I can't be 100% certain of this.  But if you can build sc and scaddins
without the sc/addin directory, then I'm in favor of removing it.  Looks
like no one has touched this since 2000, so it's probably obsolete.

So, please check if it's buildable, and go for removing it if the answer
is yes.

BTW, I've pushed your patch on master.  Thanks a lot!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Some help for LibreOffice testing with ODF ?

[Cor Nouws]

Hi all,

OpenDoc Society writes us with a request to join in for Officeshots. The 
system that makes it possible to easily test our output against ODF etc.


Since I think the best change to find someone to help with this little 
task is this list, I quote the mail:


Quote:
"  before the next plugfest it would be really useful if someone from 
the LibreOffice community would set up a copy of LibreOffice for 
Officeshots.org (ideally on multiple platforms and both a trunk version 
and a release, but lets start with the basics). This is not a very 
difficult or timeconsuming thing to do, and it can run on a desktop in 
the background or on a small virtual machine somewhere.
It would however be very useful for interop testing, because all test 
documents can be automatically pushed to it.


The manual for installing a factory can be found here:
http://code.officeshots.org/trac/officeshots/wiki/FactoryManual

If you find a volunteer, he or she should register at
http://www.officeshots.org and subsequently contact us and get the
appropriate rights to set up a factory.
  "

Thanks for you attention :-)

Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32894

--- Comment #17 from Cor Nouws  2011-02-08 15:58:50 PST ---
Suggesting bug 33970 . Crash with roaming profiles of course is a no-go for our
business users.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Issue in Base

[Cor Nouws]

Hi Guys&Girls

Bugzilla query returns "zarro boogs" so hence my question: is anyone 
aware of the bug in base wrt tool bars for report building?
See users list 
http://www.mail-archive.com/users@libreoffice.org/msg02099.html


Thanks,
Cor



--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] Re: Mac builds / lang-packs ...

[Martin Srebotnjak]

Hello,

just for the sake of this discussion, how big is the MSO installation for OS
X? Maybe someone can check, I am not using it.

If LO dmg will grow to 350Mb or 400Mb (with help in all languages) probably
that is still not so bad compared to the full dmg of MSO.

I understand not everyone has fast internet access and some people voice
their concern about it but is there really a difference between 150Mb and
250Mb dmg? Do/can people in countries with very slow internet access really
buy MacPros, MacBook Pros, iMacs etc.?

I mean, probably even 150Mb is too much for those using very slow internet
access, they would need an app in the range of 10-50Mb and not 200Mb.

In that case LO should do something about the hard-copy distribution of LO -
DVD's with LO should be available from local shops in those countries with
lower-band internet, I guess. This project could lead the way:
http://web.libreofficebox.org/

I just hope other languages don't get forgotten (as they got with the
Portable LibreOffice which TDF members now claim TDF has nothing to do with
it although it is hosting its files).

Lp, m.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] Re: Mac builds / lang-packs ...

[Christian Lohmaier]

Hi Michael, *,

On Tue, Feb 8, 2011 at 10:33 PM, Michael Meeks  wrote:
> On Tue, 2011-02-08 at 16:46 +0100, Christian Lohmaier wrote:
>> On Sun, Feb 6, 2011 at 3:22 PM, Nguyen Vu Hung  
>> wrote:
>> > On Sun, Feb 6, 2011 at 3:19 PM, Michael Meeks  
>> > wrote:
>[...]
>> The counter-question to that user at fosdem would have been "Would you
>> be OK with downloading more than twice of the current size in order to
>> only having to install one package?"
>
>        So - I guess he would have said "yes", but he is perhaps an outlier;
> then again - why do you think it would be more than twice the current
> size ? [ clearly we would split the help packs as on windows ].

Yes, split the help-pack and then again it is not one single installer anymore.

I still regard help as a core component, and still dislike the rip-out
of the help-packages from the languagepacks.

So count at least 10MB of help for each language, and you cannot hold
your 20% increase in size.

>        So - I agree; if it were double the size it would be bad :-) but are
> you completely opposed to a 20% growth, for much greater convenience for
> the common case ?

Well, there it comes in conflict with the change of installer, I don't
think a package installer is of greater convenience for the common
user, and just installing all languages would increase the required
disk-space quite a bit. So then it is not only about size of the
installer, but also size on disk.

>> And to changing the installer type:
>
>        No idea about that - it sounds bad from your description :-)

yes. I initially tried to use it for the languagepacks and got
frustrated very quickly and resorted to the script that just extracts
a tarball method instead.
(even there with dirty tricks to bypass the artificial limitation of
not allowing user-interaction when creating an applescript/osascript
bundle, wrapping the same stuff in a shell-script that calls osascript
on the very same applescript works just fine)

>> But those technical issues aside, I'm against bundling all languages,
>> for the size reasons. I don't like it on windows, and I also do so on
>> other platforms...
>
>        Heh - so; what I hear here is:
>
>        "if you can fix the size, we should do it"
>
>        is that fair ? if so, it sounds like an issue to fix in 3.4.

Well - if you can do it

Having one big installer would be more favorable for BitTorrent, so
from this POV I'm in favor of getting rid of the small languagepacks
:-) (thankfully help is still included in the langaugepacks for mac)

So I don't veto it, but the size has to go down.
Splitting Mac in installer and seperate languagepack and seperate
helppack would be much, much worse, so having a huge installer is the
lesser of two evils...

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] translated parts of German comment in svtools/inc/ruler.hxx

[Tobias Rosenberger]

Hello,
this patch is LGPLv3+/MPL.
Greetings,

Tobias
>From e38102f749d242152d0ada7e50405d7833b5acb8 Mon Sep 17 00:00:00 2001
From: Tobias Rosenberger 
Date: Tue, 8 Feb 2011 22:51:15 +0100
Subject: [PATCH] translated parts of German comment in svtools/inc/ruler.hxx

---
 svtools/inc/ruler.hxx |  235 +++--
 1 files changed, 110 insertions(+), 125 deletions(-)

diff --git a/svtools/inc/ruler.hxx b/svtools/inc/ruler.hxx
index 079954c..7581443 100644
--- a/svtools/inc/ruler.hxx
+++ b/svtools/inc/ruler.hxx
@@ -124,160 +124,145 @@ the values on the ruler. The following units are accepted:
 
 --
 
-Mit SetMargin1() kann der linke/obere Rand und mit SetMargin2() kann
-der rechte/untere Rand gesetzt werden. Falls diese Methoden ohne Parameter
-aufgerufen werden, werden keine Raender angezeigt. Wenn SetMargin1() bzw.
-SetMargin2() mit Parametern aufgerufen werden, kann bei diesen
-folgendes angegeben werden:
-
-longnPos- Offset zum NullPunkt in Pixel
-USHORT  nStyle  - Bit-Style:
+SetMargin1() sets the upper/left margin and SetMargin2() sets the
+bottom/right margin. If these methods are called whithout arguments,
+no margins are displayed. Otherwise, the following arguments can be passed:
+
+longnPos- offset in pixels relative to the origin
+USHORT  nStyle  - bit style:
 RULER_MARGIN_SIZEABLE
-Rand kann in der Groesse veraendert werden.
+margin size can be changed
 
-Zu diesen Style's koennen folgende Style-
-Bits dazugeodert werden:
-RULER_STYLE_INVISIBLE (fuer nicht sichtbar)
+The following bits can be set in addition
+to these styles:
+RULER_STYLE_INVISIBLE
 
 
-Mit SetBorders() kann ein Array von Raendern gesetzt werden. Dabei muss
-ein Array vom Typ RulerBorder uebergeben werden, wobei folgende Werte
-initialisiert werden muessen:
+SetBorders() sets an array of margins. To do this, an array of type RulerBorder
+has to be passed. In the array, the following values have to be initialized:
 
-longnPos- Offset zum NullPunkt in Pixel
-longnWidth  - Breite des Spaltenabstands in Pixel (kann zum
-  Beispiel fuer Tabellenspalten auch 0 sein)
-USHORT  nStyle  - Bit-Style:
+longnPos- offset in pixels relative to the origin
+longnWidth  - column spacing in pixels (can also be 0, for example,
+  for table columns)
+USHORT  nStyle  - bit style:
 RULER_BORDER_SIZEABLE
-Spaltenabstand kann in der Groesse veraendert
-werden. Dieses Flag sollte nur gesetzt werden,
-wenn ein Abstand in der Groesse geaendert wird
-und nicht die Groesse einer Zelle.
+Column spacing can be changed. This flag should
+only be set if the size of the spacing is changed,
+not that of a cell.
 RULER_BORDER_MOVEABLE
-Spaltenabstand/Begrenzung kann verschoben
-werden. Wenn Tabellenbegrenzungen verschoben
-werden, sollte dieses Flag gesetzt werden und
-nicht Sizeable. Denn Sizeable gibt an, das
-ein Abstand vergroessert werden kann und nicht
-eine einzelne Zelle in der Groesse geaendert
-werden kann.
+Column spacing/border can be moved. Whenever
+table borders are to be moved, this flag should
+be set instead of SIZEABLE (SIZEABLE indicates
+that the size of a spacing, not that of a single
+cell can be changed).
 RULER_BORDER_VARIABLE
-Nicht alle Spaltenabstande sind gleich
+Not all of the column spacings are equal
 RULER_BORDER_TABLE
-Tabellenrahmen. Wenn dieser Style gesetzt
-wird, muss die Spaltenbreite 0 sein.
+Table border. Whenever this style ist set, the column
+width must be 0.
 RULER_BORDER_SNAP
-  

[Libreoffice] [PATCH] Remove obsolete Hyperlink Bar from calc

[Alfonso Eusebio]

Hi,


Please find attached patch that removes the Hyperlink Bar from calc (made 
available under LGPLv3+/MPL).
Patch has been rebased with origin/master and compiled before submission.

I've started removing the references to the Hyperlink Bar from the apps. Once 
that's done I'll remove the implementation and menu entries in core modules.
After applying this patch the menu entry to activate the bar is still present 
but greyed out. This should dissapear once core modules are done.
I'll be making one patch per app/module.

Regards,
Alfonso


  From ed73ec23fa974da110ad5827f06dd313f9cb7cad Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio 
Date: Tue, 8 Feb 2011 21:30:10 +
Subject: [PATCH] Remove obsolete Hyperlink Bar from calc

Removed hyperlink bar references from calc (removing from apps first).
Menu entry appears greyed out until it gets removed from core modules.
---
 sc/source/ui/app/scdll.cxx  |1 -
 sc/source/ui/app/scmod.cxx  |1 -
 sc/source/ui/docshell/docsh.cxx |1 -
 3 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
index a022978..83f3e96 100644
--- a/sc/source/ui/app/scdll.cxx
+++ b/sc/source/ui/app/scdll.cxx
@@ -288,7 +288,6 @@ void ScDLL::Init()
 SvxSearchDialogWrapper  ::RegisterChildWindow(FALSE, pMod);
 SvxHlinkDlgWrapper  ::RegisterChildWindow(FALSE, pMod);
 SvxFontWorkChildWindow		::RegisterChildWindow(FALSE, pMod);
-SvxHyperlinkDlgWrapper		::RegisterChildWindow(FALSE, pMod, SFX_CHILDWIN_FORCEDOCK);
 SvxIMapDlgChildWindow		::RegisterChildWindow(FALSE, pMod);
 GalleryChildWindow			::RegisterChildWindow(FALSE, pMod);
 ScSpellDialogChildWindow::RegisterChildWindow(FALSE, pMod);
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 99b872d..0b603c7 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -128,7 +128,6 @@ SFX_IMPL_INTERFACE( ScModule, SfxShell, ScResId(RID_APPTITLE) )
 SFX_OBJECTBAR_REGISTRATION( SFX_OBJECTBAR_APPLICATION | SFX_VISIBILITY_DESKTOP | SFX_VISIBILITY_STANDARD | SFX_VISIBILITY_CLIENT | SFX_VISIBILITY_VIEWER,
 ScResId(RID_OBJECTBAR_APP) );
 SFX_STATUSBAR_REGISTRATION( ScResId(SCCFG_STATUSBAR) );		// nur ID wichtig
-SFX_CHILDWINDOW_REGISTRATION( SvxHyperlinkDlgWrapper::GetChildWindowId() );
 }
 
 //--
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 674905e..bcfe9d1 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -191,7 +191,6 @@ static const sal_Char pFilterRtf[]		= "Rich Text Format (StarCalc)";
 
 SFX_IMPL_INTERFACE(ScDocShell,SfxObjectShell, ScResId(SCSTR_DOCSHELL))
 {
-SFX_CHILDWINDOW_REGISTRATION( SID_HYPERLINK_INSERT );
 }
 
 //	GlobalName der aktuellen Version:
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Easy hack patch!

[Thomas Arnhold]

Now that easy hack is done :)

On 02/08/2011 10:03 PM, Thomas Arnhold wrote:
> Gna, sorry for this. Didn't update the wiki page, as these clean up was
> incidendental to some other cleaning. I'll update the wiki page.
> 
> Thomas
> 
> On 02/08/2011 09:56 PM, Caolán McNamara wrote:
>> On Sun, 2011-02-06 at 11:59 -0500, spad...@sover.net wrote:
>>> Now with fewer blank lines!
>>
>> Thanks for this, unluckily though someone else got to it just before
>> you :-)
>>
>> C.
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] lots of fallback icons shown in menus

[Michael Meeks]

Hi Caolan,

On Tue, 2011-02-08 at 15:05 +, Caolán McNamara wrote:
> So my GNOME settings are by default to not show icons in menus so I
> didn't notice that we show a placeholder graphic for all missing icons
> in menus.

Oooh ! :-) that is only on master I hope :-)

> Do we think that every entry *should* have an icon and that each missing
> one is a bug and needs to be drawn.

No - that is just silly. On the other hand - if there is a toolbar icon
without an image - then we should indeed have the missing-image image
there - so it is not just a grey rectangle (I think). [ Or should we ? -
there are some text only toolbar pieces in eg. the print preview mode ].
Hmm; perhaps we really don't want the placeholder icons in this location
at all.

> Or do we think that it's ok to have no menu entry icon and should just
> draw no placeholder, e.g. something like the attached patch ? when they
> are missing.

Yep; that's the right fix. Clearly we got a bit over-enthusiastic in
this place.

Thanks !

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] Re: Mac builds / lang-packs ...

[Michael Meeks]

Hi Christian,

On Tue, 2011-02-08 at 16:46 +0100, Christian Lohmaier wrote:
> On Sun, Feb 6, 2011 at 3:22 PM, Nguyen Vu Hung  wrote:
> > On Sun, Feb 6, 2011 at 3:19 PM, Michael Meeks  
> > wrote:
> >>Would it not be better in 3.4 (when we have solved the size issues) 
> >> to
> >> have a single download (like Windows) that includes all the languages,
..
> No, not at all, OOo did *not* include all languages into a single installer.

So - thus far we have:

Norbert, Thorsten and
Nguyen Vu Hung & Martin Srebotnjak

pro this, and you against it. So - looking at your rational:

> The counter-question to that user at fosdem would have been "Would you
> be OK with downloading more than twice of the current size in order to
> only having to install one package?"

So - I guess he would have said "yes", but he is perhaps an outlier;
then again - why do you think it would be more than twice the current
size ? [ clearly we would split the help packs as on windows ].

The Mac OSX no-lang  installer is currently 180Mb
The Windows all-lang installer is currently 215Mb

That looks like 20% larger to me - for all languages; and given the
existing 15Mb lang+help packs on Mac, the difference between
distributing l10n+help together, and bundling all l10n, while splitting
help (assuming most people don't download extra help-packs) is: 10%
[ not a like for like comparison but not a huge growth ;-].

The good news is, that in 3.3.1 we will save another handful of
megabytes from the multi-lang install set[1] - so it is sub 20%, and by
3.4 I hope to be very similar in size to the equivalent OO.o with no
languages bundled.

So - I agree; if it were double the size it would be bad :-) but are
you completely opposed to a 20% growth, for much greater convenience for
the common case ?

> And to changing the installer type:

No idea about that - it sounds bad from your description :-)

> But those technical issues aside, I'm against bundling all languages,
> for the size reasons. I don't like it on windows, and I also do so on
> other platforms...

Heh - so; what I hear here is:

"if you can fix the size, we should do it"

is that fair ? if so, it sounds like an issue to fix in 3.4.

ATB,

Michael.

[1] - unless that is consumed by new languages, lets see.
-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Strange Shared object xxx not found errors

[Caolán McNamara]

On Mon, 2011-02-07 at 19:35 +0100, Francois Tigeot wrote:
> My builds are now crashing in the same way in a few modules; pyuno is one of
> them.

> --enable-new-dtags ...
> 
> The library is present in /usr/pkg/lib/libpython2.6.so.1.0
> When I run the command by hand in a shell, there's no error and the target
> libpyuno.so is correctly created.

I wonder if in both cases what your LD_LIBRARY_PATH was set to, there's
a possibility that the recent --enable-new-dtags change in solenv, which
I want to have so that LD_LIBRARY_PATH does the right thing for dlopen
so that tests test the right .so, might be the trigger for this. 

If LD_DEBUG=libs is supported in your os it might be helpful.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: FreeBSD support round2

[Caolán McNamara]

On Tue, 2011-02-08 at 11:29 +0100, Baptiste Daroussin wrote:
> Hi,
> 
> here is a new set of simple patches for freebsd.
> 
> libs-gui-fix-spadmin set the LD_LIBRARY_PATH so be able to correctly
> launch spadmin

libs-gui: b5eb853f93d79c4204169903aa6d2a420eb6d7ce

> libs-core-fix-unopkg.sh add FreeBSD to the list of BSD OS which needs
> the LD_LIBRARY_PATH to be able to correctly launch it?

libs-core: ecbec07771b518617c188a0a6ef182195214de0e

As per the other email, left out the third patch.

I've no problem with these for 3.3.1 as they affects the BSDs only.
Though, and so cc'ed the other BSDs, it would seem likely that the two
other BSDs need the padmin change as well. Can you guys check if you
need to be in there too and ack/nack if you want it backpushed to 3.3.1

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Reusing the GLib mainloop from GTK/GNOME integration

[Michael Meeks]

Hi Alberto,

On Tue, 2011-02-08 at 17:47 +, Alberto Ruiz wrote:
> I am working on exporting the menubar menu items structure through a
> DBus service, you can check my progress this the bzr branch I am
> working on[0].

Wonderful :-) but why are you doing this as an extension ? :-) surely
we should put this into the core code ? it should be rather easier to do
that, and less problematic.

> My approach is creating a Synchronous Job that gets executed everytime
> a document is opened[1][2].

Hokay, no idea if that makes sense without reading the framework code
personally ;-)

> On the execute method of my job, if I call g_idle_add with a simple
> function doing just a multiply operation before return, I get
> rendering problems, arbitrary elements of the UI ...

Sooo ... we have gtk mainloop integration; but you need to get the
locking right of course; if it is pure gtk code; you should use:

GDK_THREADS_ENTER

as you hit your idle handler, and GDK_THREADS_LEAVE as you exit it.
Hmm ! interestingly I get similar corruption opening the file-selector
over the top of the shell - which might be related - fun. That would be
my first port of call.

> My question is, is there a safe manner or any recommended practice
> while using the glib mainloop from OpenOffice if the GNOME/GTK
> integration is in use?

cf. above I guess. I didn't see any interesting code at the links you
posted though so ... beyond taking the toolkit lock before using the
toolkit, I am not sure :-) There are really two ways to do that - one is
with the GDK_THREADS magic; the other is via
vcl/inc/vcl/solarmutex.hxx's helper.

HTH,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Easy hack patch!

[Thomas Arnhold]

Gna, sorry for this. Didn't update the wiki page, as these clean up was
incidendental to some other cleaning. I'll update the wiki page.

Thomas

On 02/08/2011 09:56 PM, Caolán McNamara wrote:
> On Sun, 2011-02-06 at 11:59 -0500, spad...@sover.net wrote:
>> Now with fewer blank lines!
> 
> Thanks for this, unluckily though someone else got to it just before
> you :-)
> 
> C.
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Easy hack patch!

[Caolán McNamara]

On Sun, 2011-02-06 at 11:59 -0500, spad...@sover.net wrote:
> Now with fewer blank lines!

Thanks for this, unluckily though someone else got to it just before
you :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Who do I know when a patch will make it to a release

[Caolán McNamara]

On Sat, 2011-02-05 at 14:35 +0700, Samphan Raruenrom wrote:

> The intention for my original post is two fold:-
> 1) I'd like to know when/which-version will this fix land in.

Definitely 3.4 anyway. *maybe* a 3.3.X

> 2) I'd like to understand the policy for development vs. release
> branches. For example, which committed patches will be in the 3.3.1 or
> 3.4 release. How things like this are planned/decided (which used to
> be group by child workspaces before).

So, everything will be in 3.4. Changes to the stable branch, which is
for 3.3.1 at the moment, then require sign off by another developer.

When very close to 3.3.1, they require sign offs by extra developers to
avoid last minute panicky cockups.

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

[Luke Dixon]

Hello Jonas, Michael, list,

Sorry for not replying sooner.

On Tue, 2011-02-01 at 19:32 +0100, Jonas Finnemann Jensen wrote:
> I don't think it's critial... None of the commits that removes
> brackets and improves SmNodeToTextVisitor have been applied to
> libreoffice-3-3... The SmNodeToTextVisitor there uses a lot of
> brackets, so there's hopefully no major issues with it...

I guess I'm too late now, so maybe for 3.3.2, but maybe there are a
couple of bugs that could be fixed for libreoffice-3-3.
We could fix two of the bugs, 32759 and 32755 on the freedesktop.org
bugzilla, as they are quite simple and seem to be a fixable by removing
one character and one line (which is how it is now on master now). It
seems so simple I wonder if I'm missing something about these two?

Other than that I think Jonas is right.

Regards,
Luke
>From 37084a642a789a1788783c0a3db708396e16197a Mon Sep 17 00:00:00 2001
From: Luke Dixon <6b8b4...@gmail.com>
Date: Tue, 8 Feb 2011 20:15:21 +
Subject: [PATCH] Fix for bugs 32759 and 32755 on freedesktop bugzilla

---
 starmath/source/visitors.cxx |3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/starmath/source/visitors.cxx b/starmath/source/visitors.cxx
index dc5dd38..7b7dafe 100644
--- a/starmath/source/visitors.cxx
+++ b/starmath/source/visitors.cxx
@@ -2131,7 +2131,7 @@ void SmNodeToTextVisitor::Visit( SmTableNode* pNode )
 LineToText( it.Current( ) );
 if( it.Next( ) ) {
 Separate( );
-Append( "## " );
+Append( "# " );
 }else
 break;
 }
@@ -2447,7 +2447,6 @@ void SmNodeToTextVisitor::Visit( SmTextNode* pNode )
 
 void SmNodeToTextVisitor::Visit( SmSpecialNode* pNode )
 {
-Append( "%" );
 Append( pNode->GetToken( ).aText );
 }
 
-- 
1.7.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] How to make cell with list data validation, a combo box

[Kohei Yoshida]

On Tue, 2011-02-08 at 19:46 +0530, Kishan Bhat wrote:
> Hello,
> 
> I've been trying to make a combobox for a cell with Data Validation >
> List for LibreOffice calc.
> 
> I thought I could add that in the source and try out - so I downloaded
> LO source and started greping for text, all thanks to the excellant LO
> page to do so and the LibreOffice IRC channel.
> 
> Now, for days I've been grepping the source for texts that I could
> think of, with no success. I open loads of *.cxx file and I'm not able
> to make out where this code lies.
> 
> Can anyone help me with a better approach to find this piece of code
> that shows selection list for a cell with "List" data validity?

So, we had a little chat on IRC, and hopefully I gave you a good
pointer.

ScGridWindow::DoAutoFilterMenue (with an 'e') is the one that launches
the popup, both for autofilter and data selection.  The parent call to
this is ScTabView::StartDataSelect(), which I recently modified to fix a
bug wrt autofilter popup launch via key-binding event.

FYI, I have plan to brush up the autofilter popup in not-so-distant
future, to re-use the popup window I developed for datapilot, to allow
multi-string selection and other extra filtering options.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] patch lib-core/eventattacher

[Cedric Bosdonnat]

Hello Christina,

On Tue, 2011-02-08 at 21:04 +0100, Christina Roßmanith wrote:
> there were more patches not yet pushed, so I've applied them. I didn't 
> touch the files which differed only by whitespace. And I didn't delete 
> comments containing bugids and text. This I would like to leave for the 
> experts  :-)

You were right not to delete those comments entirely... they can be
useful.

Regards,
-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibreOffice default UI font need to be changed

[Caolán McNamara]

On Mon, 2011-02-07 at 17:34 +0700, Samphan Raruenrom wrote:
> Glyph fallback for CTL text in Windows is currently broken but "only"
> for UI text rendering, not for text in the document.

Search for WinGlyphFallbackSubstititution in vcl/win for the windows
specific glyph substitution stuff. There a multi level SalMultiLayout
thing which should try and build up a set of fallback fonts to render
the chunks of text that the "base" font wasn't able to do.

I know the fontconfig/unix one fairly well, but unfortunately not the
windows implementation.

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] patch lib-core/eventattacher

[Christina Roßmanith]

Hi,

there were more patches not yet pushed, so I've applied them. I didn't 
touch the files which differed only by whitespace. And I didn't delete 
comments containing bugids and text. This I would like to leave for the 
experts  :-)


The not yet applied patchfile is appended.

Christina
diff --git a/ucb/source/ucp/webdav/NeonSession.cxx b/ucb/source/ucp/webdav/NeonSession.cxx
index 7943d8a..4dbec7d 100644
--- a/ucb/source/ucp/webdav/NeonSession.cxx
+++ b/ucb/source/ucp/webdav/NeonSession.cxx
@@ -214,7 +209,6 @@ extern "C" void NeonSession_ResponseBlockReader(void * inUserData,
 // ResponseBlockWriter
 // A simple Neon response_block_reader for use with an XOutputStream
 // ---
-
 #if NEON_VERSION >= 0x0250
 extern "C" int NeonSession_ResponseBlockWriter( void * inUserData,
 #else
@@ -681,8 +675,6 @@ void NeonSession::Init()
 NeonUri::makeConnectionEndPointString(
 m_aHostName, m_nPort ) );
 
-// #122205# - libxml2 needs to be initialized once if used by
-// multithreaded programs like OOo.
 xmlInitParser();
 #if 0
 // for more debug flags see ne_utils.h; NE_DEBUGGING must be defined
@@ -710,9 +702,6 @@ void NeonSession::Init()
 }
 else
 {
-// #112271# Check whether proxy settings are still valid (They may
-// change at any time). If not, create new Neon session.
-
 const ucbhelper::InternetProxyServer & rProxyCfg = getProxySettings();
 
 if ( ( rProxyCfg.aName != m_aProxyName )
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[NoOp]

On 02/08/2011 10:36 AM, Cor Nouws wrote:
> Hi Gary,
> 
> NoOp wrote (08-02-11 19:24)
>> Thorsten, I've just updated:
>> http://www.openoffice.org/issues/show_bug.cgi?id=107809
>> SeaMonkey address books were working in OOo m97&  m98 but broke again in
>> 3.3.0. I now get the exact same error in LO 3.3.0
> 
> m97 and m98 are from the master, after 330 was branched of.
> 
> Regards,
> Cor
> 

Ah. Got it. Thanks Cor.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] remove old icon themes ...

[Lubos Lunak]

On Sunday 06 of February 2011, Michael Meeks wrote:
> Hi Andreas,
>
> On Sat, 2011-02-05 at 12:58 +0100, Andreas Proschofsky wrote:
> > Just to chime in here: Setting --with-theme does nothing for me, LO
> > builds all icon sets, no matter what I ask it to...
>
>   Right ;-) they should all be built, and delivered into the solver, but
> only the ones you specify should be bundled

 Does that mean you have broken KDE integration with that change :) ?

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: svtools/inc svtools/source

[Lubos Lunak]

On Tuesday 08 of February 2011, Joseph Powers wrote:
> New commits:
> commit 27f2608c5d1deb6cfc8c7e56239563815588e015
> Author: Joseph Powers 
> Date:   Tue Feb 8 06:55:57 2011 -0800
>
> Remove DECLARE_LIST( ValueItemList, ValueSetItem* )
>
> diff --git a/svtools/inc/svtools/valueset.hxx
> b/svtools/inc/svtools/valueset.hxx index 98072c2..be8adf4 100644
> --- a/svtools/inc/svtools/valueset.hxx
> +++ b/svtools/inc/svtools/valueset.hxx
> @@ -234,8 +237,8 @@ gewuenschten WinBits (vor Show) mit SetStyle() gesetzt
> werden. // - ValueSet -
>  // 
>
> -#define VALUESET_APPEND  ((USHORT)0x)
> -#define VALUESET_ITEM_NOTFOUND   ((USHORT)0x)
> +#define VALUESET_APPEND  ((size_t)-1)
> +#define VALUESET_ITEM_NOTFOUND   ((size_t)-1)

 I have reverted this part, it breaks build with:
clone/components/cui/source/tabpages/borderconn.cxx:215:1: error: narrowing 
conversion of '-1u' from 'size_t' to 'short unsigned int' inside { }

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[Cor Nouws]

Hi Gary,

NoOp wrote (08-02-11 19:24)

Thorsten, I've just updated:
http://www.openoffice.org/issues/show_bug.cgi?id=107809
SeaMonkey address books were working in OOo m97&  m98 but broke again in
3.3.0. I now get the exact same error in LO 3.3.0


m97 and m98 are from the master, after 330 was branched of.

Regards,
Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[NoOp]

On 01/26/2011 05:41 AM, Thorsten Behrens wrote:
> Norbert Thiebaud wrote:
>> for info:
>> 
>> http://hg.services.openoffice.org/cws/dba34a/rev/d5b3bb5ca529
>> 
> Cherry-picked on master.
> 
> -- Thorsten
> 

Thorsten, I've just updated:
http://www.openoffice.org/issues/show_bug.cgi?id=107809
SeaMonkey address books were working in OOo m97 & m98 but broke again in
3.3.0. I now get the exact same error in LO 3.3.0

$ cat /opt/libreoffice/program/versionrc
[Version]
AllLanguages=en-US
buildid=330m19(Build:6)
ExtensionUpdateURL=http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update
OOOBaseVersion=3.3
ProductBuildid=6
ProductMajor=330
ProductMinor=19
ProductSource=OOO330
UpdateID=LibreOffice_3_en-US
UpdateURL=
UpdateUserAgent= (${buildid}; ${_OS}; ${_ARCH};
BundledLanguages=${AllLanguages})

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] ure cppcheck, variableScope.

[Cedric Bosdonnat]

On Tue, 2011-02-08 at 18:36 +0100, Cedric Bosdonnat wrote:
> Hello,
> 
> On Sun, 2011-02-06 at 23:48 -0300, Kayo Hamid wrote:
> > Hi guys, it's minor change, sending for review.
> 
> I just pushed the patch. Thanks for the help, even if minor.

Oops, I forgot to tag it as pushed... fixed now.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments + bash line

[Cedric Bosdonnat]

Hi Guillaume,

I just pushed all of them! Many thanks for your cleanup.

Regards,

On Tue, 2011-02-08 at 08:57 +0100, Guillaume Poussel wrote:
> I have edited the wiki to show I'm currently working on it.
> Please find attached again new patches to remove this comments.
> 
> Regards,
> Guillaume Poussel.
> 
> 2011/2/7 Guillaume Poussel :
> > I have removed all of them in impress too (see patch attached). As
> > soon as someone push it, I edit the wiki.
> >
> > (still in LGPLv3/MPL)
> >
> > Regards,
> > Guillaume Poussel
> >
> > 2011/2/7 Guillaume Poussel :
> >> Hi all,
> >>
> >> Again, I send patches to remove bogus comments.
> >>
> >> I have written a pretty (but not optimized) bash line to find them all:
> >> git grep -nE " #[^i][0-9]+#" | ( while read f; do file=$(echo "$f" |
> >> cut -d':' -f1) ; line=$(echo "$f" | cut -d':' -f2) ; emacs "+"$line
> >> -fh "$file"; done )
> >> It opens emacs with every occurences of #xxx#.
> >>
> >> As soon as I have time, I will try to end up by finishing this "Easy Hack".
> >>
> >> Regards,
> >> Guillaume Poussel
> >>
> >
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] FreeBSD support round2

[Baptiste Daroussin]

2011/2/8 Baptiste Daroussin :
> Hi,
>
> here is a new set of simple patches for freebsd.
>
> libs-gui-fix-spadmin set the LD_LIBRARY_PATH so be able to correctly
> launch spadmin
> bootstrap-cleanup-unx-fbsd.mk is inspired by openbsd, it is a huge
> simplification of what was done before + it prevents from having
> different shared library name depending on architecture which easier
> the management a plist.
> libs-core-fix-unopkg.sh add FreeBSD to the list of BSD OS which needs
> the LD_LIBRARY_PATH to be able to correctly launch it?
>
> Hope this could be also committed in the 3.3.1 branch :)
>
> regards,
> Bapt
>

Please forget about the unxfbsd.mk patch currently as it brings some
bugs, the other patches are still ok

sorry for noise.

regards,
Bapt
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ure cppcheck, variableScope.

[Cedric Bosdonnat]

Hello,

On Sun, 2011-02-06 at 23:48 -0300, Kayo Hamid wrote:
> Hi guys, it's minor change, sending for review.

I just pushed the patch. Thanks for the help, even if minor.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibO security

[Thorsten Behrens]

Michael Meeks wrote:
>   We could do worse than cutting / pasting / editing point two of:
> http://people.gnome.org/~michael/blog/2011-02-04.html into the release
> notes (or something).
> 
Added a short notice, and a link to that blog post. Let's work on a
more formal approach to this for the next major release.

Cheers,

-- Thorsten


pgpbMOtv2uSko.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] BorderLine fix

[Thorsten Behrens]

Caolan McNamara wrote:
> > David fixed the BorderLine API problem a while ago with this commit
> > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d
> >  in master.
> > 
> > I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could
> > anybody else review it?
> 
> This is the one that fixes fdo#33397. Yeah +1 from me.
> 
Counting 3 ACKs, cherry-picked for 3.3.1 now.

-- Thorsten


pgpeQBuew4CS1.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][EasyHacks] Remove some use of svarray stuff in SwScriptInfo

[Nigel Hawkins]

This patch removes the last use of SvBytes from SwScriptInfo. And should
be the last usage in sw.

Nigel
>From 3d1e455ca3ede76235e769b65342f0f31d9f44ee Mon Sep 17 00:00:00 2001
From: Nigel Hawkins 
Date: Tue, 8 Feb 2011 16:12:13 +
Subject: [PATCH 5/5] Remove compression svArray usage from SwScriptInfo

---
 sw/source/core/inc/scriptinfo.hxx |   26 --
 sw/source/core/text/porlay.cxx|   15 +++
 2 files changed, 19 insertions(+), 22 deletions(-)

diff --git a/sw/source/core/inc/scriptinfo.hxx b/sw/source/core/inc/scriptinfo.hxx
index f8cf486..4a70226 100644
--- a/sw/source/core/inc/scriptinfo.hxx
+++ b/sw/source/core/inc/scriptinfo.hxx
@@ -121,10 +121,16 @@ private:
 SvXub_StrLens aKashidaInvalid;
 SvXub_StrLens aNoKashidaLine;
 SvXub_StrLens aNoKashidaLineEnd;
-SvXub_StrLens aCompChg;
-SvXub_StrLens aCompLen;
 SvXub_StrLens aHiddenChg;
-SvBytes aCompType;
+//! Records a single change in compression.
+struct CompressionChangeInfo
+{
+xub_StrLen position; //!< Character position where the change occurs.
+xub_StrLen length;   //!< Length of the segment.
+BYTE   type; //!< Type of compression that we change to.
+inline CompressionChangeInfo(xub_StrLen pos, xub_StrLen len, BYTE typ) : position(pos), length(len), type(typ) {};
+};
+std::vector aCompressionChanges;
 xub_StrLen nInvalidityPos;
 BYTE nDefaultDir;
 
@@ -403,22 +409,22 @@ inline xub_StrLen SwScriptInfo::GetKashida( const USHORT nCnt ) const
 return aKashida[ nCnt ];
 }
 
-inline USHORT SwScriptInfo::CountCompChg() const { return aCompChg.Count(); };
+inline USHORT SwScriptInfo::CountCompChg() const { return aCompressionChanges.size(); };
 inline xub_StrLen SwScriptInfo::GetCompStart( const USHORT nCnt ) const
 {
-OSL_ENSURE( nCnt < aCompChg.Count(),"No CompressionStart today!");
-return aCompChg[ nCnt ];
+OSL_ENSURE( nCnt < aCompressionChanges.size(),"No CompressionStart today!");
+return aCompressionChanges[ nCnt ].position;
 }
 inline xub_StrLen SwScriptInfo::GetCompLen( const USHORT nCnt ) const
 {
-OSL_ENSURE( nCnt < aCompChg.Count(),"No CompressionLen today!");
-return aCompLen[ nCnt ];
+OSL_ENSURE( nCnt < aCompressionChanges.size(),"No CompressionLen today!");
+return aCompressionChanges[ nCnt ].length;
 }
 
 inline BYTE SwScriptInfo::GetCompType( const USHORT nCnt ) const
 {
-OSL_ENSURE( nCnt < aCompChg.Count(),"No CompressionType today!");
-return aCompType[ nCnt ];
+OSL_ENSURE( nCnt < aCompressionChanges.size(),"No CompressionType today!");
+return aCompressionChanges[ nCnt ].type;
 }
 
 inline USHORT SwScriptInfo::CountHiddenChg() const { return aHiddenChg.Count(); };
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index b7db718..8ca3535 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -931,10 +931,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 }
 
 // remove invalid entries from compression information arrays
-const USHORT nCompRemove = aCompChg.Count() - nCntComp;
-aCompChg.Remove( nCntComp, nCompRemove );
-aCompLen.Remove( nCntComp, nCompRemove );
-aCompType.Remove( nCntComp, nCompRemove );
+aCompressionChanges.erase(aCompressionChanges.begin() + nCntComp, aCompressionChanges.end() );
 
 // get the start of the last kashida group
 USHORT nLastKashida = nChg;
@@ -1085,10 +1082,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 if ( CHARCOMPRESS_PUNCTUATION_KANA == aCompEnum ||
  ePrevState != KANA )
 {
-aCompChg.Insert( nPrevChg, nCntComp );
-BYTE nTmpType = ePrevState;
-aCompType.Insert( nTmpType, nCntComp );
-aCompLen.Insert( nLastCompression - nPrevChg, nCntComp++ );
+aCompressionChanges.push_back( CompressionChangeInfo(nPrevChg, nLastCompression - nPrevChg, ePrevState) );
 }
 }
 
@@ -1106,10 +1100,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 if ( CHARCOMPRESS_PUNCTUATION_KANA == aCompEnum ||
  ePrevState != KANA )
 {
-aCompChg.Insert( nPrevChg, nCntComp );
-BYTE nTmpType = ePrevState;
-aCompType.Insert( nTmpType, nCntComp );
-aCompLen.Insert( nLastCompression - nPrevChg, nCntComp++ );
+aCompressionChanges.push_back( CompressionChangeInfo(nPrevChg, nLastCompression - nPrevChg, ePrevState) );
 }
 }
 }
-- 
1.7.0.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop

[Libreoffice] [PUSHED] patch lib-core/eventattacher

[Christina Roßmanith]

Hi,

it seems that the translations in ucb/source/sorter/sortresult.cxx 
didn't make their way. I've pushed them.


Thank you for your contribution.

Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] BorderLine fix

[Thorsten Behrens]

Caolan McNamara wrote:
> > David fixed the BorderLine API problem a while ago with this commit
> > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d
> >  in master.
> > 
> > I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could
> > anybody else review it?
> 
> This is the one that fixes fdo#33397. Yeah +1 from me.
> 
Counting 3 ACKs, cherry-picked for 3.3.1 now.

-- Thorsten


pgpvnNTmjIiWa.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] Re: Mac builds / lang-packs ...

[Christian Lohmaier]

Hi *,

On Sun, Feb 6, 2011 at 3:22 PM, Nguyen Vu Hung  wrote:
> On Sun, Feb 6, 2011 at 3:19 PM, Michael Meeks  
> wrote:
>>
>>        Would it not be better in 3.4 (when we have solved the size issues) to
>> have a single download (like Windows) that includes all the languages,
> +1
> It is fine, OOo did it that way.

No, not at all, OOo did *not* include all languages into a single installer.

The counter-question to that user at fosdem would have been "Would you
be OK with downloading more than twice of the current size in order to
only having to install one package?"

And to changing the installer type:
This would have major drawbacks as well.

* You have to build the installer as root/admin user
* Installing multiple versions is more difficult, as is choosing a
destination for the installation
* You cannot install as regular user (you always have to identify as
administrator)
(authentication is done before being able to select a target-directory)

Drag-and-Drop installers are the preferred installation method.

But those technical issues aside, I'm against bundling all languages,
for the size reasons. I don't like it on windows, and I also do so on
other platforms...

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][EasyHacks] Remove some use of svarray stuff in SwScriptInfo

[Nigel Hawkins]

The attached patch removes some more SvBytes and SvXub_StrLens usage
from SwScriptInfo.

Changes under LGPLv3+/MPL

Nigel.
>From bdbe75e3715a5e553c26edcefb09abff7ebf936b Mon Sep 17 00:00:00 2001
From: Nigel Hawkins 
Date: Tue, 8 Feb 2011 15:05:14 +
Subject: [PATCH 4/4] Remove direction svArray usage in SwScriptInfo

---
 sw/source/core/inc/scriptinfo.hxx |   20 +---
 sw/source/core/text/porlay.cxx|   17 -
 2 files changed, 17 insertions(+), 20 deletions(-)

diff --git a/sw/source/core/inc/scriptinfo.hxx b/sw/source/core/inc/scriptinfo.hxx
index ef3a365..f8cf486 100644
--- a/sw/source/core/inc/scriptinfo.hxx
+++ b/sw/source/core/inc/scriptinfo.hxx
@@ -109,8 +109,14 @@ private:
 //TODO - This is sorted, so should probably be a std::set rather than vector.
 //   But we also use random access (probably unnecessarily).
 std::vector aScriptChanges;
-SvXub_StrLens aDirChg;
-SvBytes aDirType;
+//! Records a single change in direction.
+struct DirectionChangeInfo
+{
+xub_StrLen position; //!< Character position at which we change direction.
+BYTE   type; //!< Direction that we change to.
+inline DirectionChangeInfo(xub_StrLen pos, BYTE typ) : position(pos), type(typ) {};
+};
+std::vector aDirectionChanges;
 SvXub_StrLens aKashida;
 SvXub_StrLens aKashidaInvalid;
 SvXub_StrLens aNoKashidaLine;
@@ -378,16 +384,16 @@ inline BYTE SwScriptInfo::GetScriptType( const xub_StrLen nCnt ) const
 return aScriptChanges[nCnt].type;
 }
 
-inline USHORT SwScriptInfo::CountDirChg() const { return aDirChg.Count(); }
+inline USHORT SwScriptInfo::CountDirChg() const { return aDirectionChanges.size(); }
 inline xub_StrLen SwScriptInfo::GetDirChg( const USHORT nCnt ) const
 {
-OSL_ENSURE( nCnt < aDirChg.Count(),"No DirChange today!");
-return aDirChg[ nCnt ];
+OSL_ENSURE( nCnt < aDirectionChanges.size(),"No DirChange today!");
+return aDirectionChanges[ nCnt ].position;
 }
 inline BYTE SwScriptInfo::GetDirType( const xub_StrLen nCnt ) const
 {
-OSL_ENSURE( nCnt < aDirChg.Count(),"No DirType today!");
-return aDirType[ nCnt ];
+OSL_ENSURE( nCnt < aDirectionChanges.size(),"No DirType today!");
+return aDirectionChanges[ nCnt ].type;
 }
 
 inline USHORT SwScriptInfo::CountKashida() const { return aKashida.Count(); }
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 51d6c55..b7db718 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -1304,9 +1304,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 #endif
 
 // remove invalid entries from direction information arrays
-const USHORT nDirRemove = aDirChg.Count();
-aDirChg.Remove( 0, nDirRemove );
-aDirType.Remove( 0, nDirRemove );
+aDirectionChanges.clear();
 
 // Perform Unicode Bidi Algorithm for text direction information
 bool bPerformUBA = UBIDI_LTR != nDefaultDir;
@@ -1326,7 +1324,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 // 1. All text in RTL runs will use the CTL font
 // #i89825# change the script type also to CTL (hennerdrewes)
 // 2. Text in embedded LTR runs that does not have any strong LTR characters (numbers!)
-for ( USHORT nDirIdx = 0; nDirIdx < aDirChg.Count(); ++nDirIdx )
+for ( USHORT nDirIdx = 0; nDirIdx < aDirectionChanges.size(); ++nDirIdx )
 {
 const BYTE nCurrDirType = GetDirType( nDirIdx );
 // nStart ist start of RTL run:
@@ -1395,10 +1393,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 void SwScriptInfo::UpdateBidiInfo( const String& rTxt )
 {
 // remove invalid entries from direction information arrays
-const USHORT nDirRemove = aDirChg.Count();
-aDirChg.Remove( 0, nDirRemove );
-aDirType.Remove( 0, nDirRemove );
-
+aDirectionChanges.clear();
 //
 // Bidi functions from icu 2.0
 //
@@ -1413,14 +1408,10 @@ void SwScriptInfo::UpdateBidiInfo( const String& rTxt )
 int32_t nStart = 0;
 int32_t nEnd;
 UBiDiLevel nCurrDir;
-// counter for direction information arrays
-USHORT nCntDir = 0;
-
 for ( USHORT nIdx = 0; nIdx < nCount; ++nIdx )
 {
 ubidi_getLogicalRun( pBidi, nStart, &nEnd, &nCurrDir );
-aDirChg.Insert( (USHORT)nEnd, nCntDir );
-aDirType.Insert( (BYTE)nCurrDir, nCntDir++ );
+aDirectionChanges.push_back( DirectionChangeInfo(nEnd, nCurrDir) );
 nStart = nEnd;
 }
 
-- 
1.7.0.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32894

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on|32329   |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] lp#696527 enabling Human icons theme in 3.3 branch

[Thorsten Behrens]

Bjoern Michaelsen wrote:
> If this patch gets accepted for 3.3, we likely can get rid of the
> patch in the build repo, which I would consider a Good Thing(tm).
> 
Looks good to me, cherry-picked for 3.3 - actual shipment of icons
is controlled by the distro-config anyways.

Cheers,

-- Thorsten


pgpoHhsn1Lv7P.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Some changes for the "Getting Involved

[Caolán McNamara]

On Sun, 2011-02-06 at 11:30 -0500, spad...@sover.net wrote:
> Hello, all
> 
> I am just getting started with LibreOffice development, and was following
> the instructions at .
>  I noticed that a couple of things should be added:
> 
> On my Ubuntu system (10.04), you need to install libgnomevfs2-dev in
> addition to the openoffice.org build deps

I guess that means that by default Ubuntu, like ourselves, build with
the --enable-gio backend rather than the gnomevfs2 one. So that's
another alternative, add --enable-gio to the autoconf invocation and
avoid pulling down gnomevfs2.

At some stage we'll surely flip over to --enable-gio as the default
instead of --enable-gnomevfs2, but I'm not too sure what we're
considering as base-line Linux at the moment.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] lp#696527 enabling Human icons theme in 3.3 branch

[Cedric Bosdonnat]

Hi Bjoern,

ok for me for 3.3.1

--
Cedric

On Tue, 2011-02-08 at 15:54 +0100, Bjoern Michaelsen wrote:
> Hi all,
> 
> on the master branch I already commited:
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f6a16194d1348cb1c679acec5cd9e014ca3f3104
> http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=00b43fc0d82950e2abc57cca3746d395252bc9e0
> http://cgit.freedesktop.org/libreoffice/components/commit/?id=cfa7e88f5959a8b3b729107d61351410be80f49b
> 
> which integrate the (currently outdated and failing to apply) patch
> human-icons-add.diff from the build repo into the master. The only
> thing it does not do is changing the fallback order of the setting of
> "automatic" theme, which might be disruptive for other distros.
> 
>  
> http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300/human-icons-add.diff
> 
> The attached patch does the same for the 3.3 branch. 
> 
> If this patch gets accepted for 3.3, we likely can get rid of the
> patch in the build repo, which I would consider a Good Thing(tm).
> 
> (Note: In the long run, we should likely get rid of the need to
> hardwire themes in the source).
> 
> So please review the attached patch.
> 
> Best Regards,
> 
> Bjoern Michaelsen
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32894

Bug 32894 depends on bug 32329, which changed state.

Bug 32329 Summary: [MAILMERGE] E-Mail server connection fails
https://bugs.freedesktop.org/show_bug.cgi?id=32329

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Updated Serbian translation for 3.3.1

[Caolán McNamara]

On Wed, 2011-02-02 at 00:30 +0100, Goran Rakic wrote:
> Patch against the libreoffice-3-3 branch attached.

Timar pushed this into 3-3 back on the 2nd. Thanks for these.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Updated Serbian translation

[Andras Timar]

2011.01.23. 16:24 keltezéssel, Andras Timar írta:
> 2011/1/23 Goran Rakic :
>> У нед, 23. 01 2011. у 08:05 +0100, Andras Timar пише:
>>
>>> This patch does not apply cleanly on the current files.
>>
>> I made a patch against master branch, attached is the updated patch
>> against libreoffice-3-3. Do we need to push both?
>>
> Hi Goran,
> 
> I pushed it to libreoffice-3-3 branch. master does not and will not
> use this lo-build-xx.po hack. Your translations will be leveraged, of
> course.
> 
> Best regards,
> Andras
> 
[PUSHED]
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Issues for pivot tables ... where to post

[Kohei Yoshida]

On Tue, 2011-02-08 at 13:23 +0100, Cor Nouws wrote:
> Hi Kohei, *,
> 
> Someone writes about an issue in OOo/Lo 330, that was not present in OOo 
> 321.
> 
> Is it better to post that in Bugzilla or in the OOo IssueTracker?
> (Currently I see one Pivot-issue - 33990 - in Bugzilla)

Let's put it in our bugzilla, and please assign that directly to me.
I'm working on the data pilot code right now to fix several issues I
discovered have been broken since 3.3.  So, it's nice to know any
regressions to data pilot while I'm at it.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] lots of fallback icons shown in menus

[Caolán McNamara]

So my GNOME settings are by default to not show icons in menus so I
didn't notice that we show a placeholder graphic for all missing icons
in menus.

That means though that *all* menu entries have an icon beside them when
icons are turned on, and a load of them are the broken graphic
placeholder.

Where are we on the thinking/plan here...

Do we think that every entry *should* have an icon and that each missing
one is a bug and needs to be drawn.

Or do we think that it's ok to have no menu entry icon and should just
draw no placeholder, e.g. something like the attached patch ? when they
are missing. 

C.
diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx b/framework/source/uiconfiguration/imagemanagerimpl.cxx
index bca1f2d..bdd0347 100644
--- a/framework/source/uiconfiguration/imagemanagerimpl.cxx
+++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx
@@ -363,15 +363,7 @@ GlobalImageList::~GlobalImageList()
 Image GlobalImageList::getImageFromCommandURL( sal_Int16 nImageType, const rtl::OUString& rCommandURL )
 {
 osl::MutexGuard guard( getGlobalImageListMutex() );
-Image aImage = CmdImageList::getImageFromCommandURL( nImageType, rCommandURL );
-if (!aImage)
-{
-BitmapEx rBitmap;
-bool res = ::vcl::ImageRepository::loadDefaultImage(rBitmap);
-if (res)
-aImage = Image(rBitmap);
-}
-return aImage;
+return CmdImageList::getImageFromCommandURL( nImageType, rCommandURL );
 }
 
 bool GlobalImageList::hasImage( sal_Int16 nImageType, const rtl::OUString& rCommandURL )
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibO security

[Michael Meeks]

On Tue, 2011-02-08 at 08:22 +0100, Thorsten Behrens wrote:
> yes, since we've merged all code from OOo 3.3.0 (with the exception
> of one rather broken calc fix).
..
> Well, we have. It's Cc-ed. What we prolly need is to properly
> document this.

We could do worse than cutting / pasting / editing point two of:
http://people.gnome.org/~michael/blog/2011-02-04.html into the release
notes (or something).

ATB,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] lp#696527 enabling Human icons theme in 3.3 branch

[Bjoern Michaelsen]

Hi all,

on the master branch I already commited:
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f6a16194d1348cb1c679acec5cd9e014ca3f3104
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=00b43fc0d82950e2abc57cca3746d395252bc9e0
http://cgit.freedesktop.org/libreoffice/components/commit/?id=cfa7e88f5959a8b3b729107d61351410be80f49b

which integrate the (currently outdated and failing to apply) patch
human-icons-add.diff from the build repo into the master. The only
thing it does not do is changing the fallback order of the setting of
"automatic" theme, which might be disruptive for other distros.

 
http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300/human-icons-add.diff

The attached patch does the same for the 3.3 branch. 

If this patch gets accepted for 3.3, we likely can get rid of the
patch in the build repo, which I would consider a Good Thing(tm).

(Note: In the long run, we should likely get rid of the need to
hardwire themes in the source).

So please review the attached patch.

Best Regards,

Bjoern Michaelsen

-- 
https://launchpad.net/~bjoern-michaelsen
diff --git a/cui/source/options/optgdlg.src b/cui/source/options/optgdlg.src
index 762e025..f2aff18 100644
--- a/cui/source/options/optgdlg.src
+++ b/cui/source/options/optgdlg.src
@@ -270,6 +270,7 @@ TabPage OFA_TP_VIEW
 < "Tango" ; > ;
 < "Oxygen" ; > ;
 < "Classic" ; > ;
+< "Human" ; > ;
 };
 };
 CheckBox CB_SYSTEM_FONT
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 54893bb..c191089 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -5867,6 +5867,11 @@
 			Classic - the OpenOffice.org 2.0 default theme
 		
 	
+	
+		
+			Human - the Gnome default theme for Ubuntu
+		
+	
 
 auto
 			
diff --git a/vcl/inc/vcl/settings.hxx b/vcl/inc/vcl/settings.hxx
index 30308b2..5fa547d 100644
--- a/vcl/inc/vcl/settings.hxx
+++ b/vcl/inc/vcl/settings.hxx
@@ -525,7 +525,8 @@ private:
 #define STYLE_SYMBOLS_TANGO ((ULONG)5)
 #define STYLE_SYMBOLS_OXYGEN((ULONG)6)
 #define STYLE_SYMBOLS_CLASSIC		((ULONG)7)
-#define STYLE_SYMBOLS_THEMES_MAX	((ULONG)8)
+#define STYLE_SYMBOLS_HUMAN		((ULONG)8)
+#define STYLE_SYMBOLS_THEMES_MAX	((ULONG)9)
 
 #define STYLE_MENUIMAGES_OFF  ((USHORT)0)
 #define STYLE_MENUIMAGES_ON   ((USHORT)1)
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
index 20adcc8..2c89429 100644
--- a/vcl/source/app/settings.cxx
+++ b/vcl/source/app/settings.cxx
@@ -712,6 +712,7 @@ void StyleSettings::Set3DColors( const Color& rColor )
 case STYLE_SYMBOLS_TANGO:  return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("tango"));
 case STYLE_SYMBOLS_OXYGEN: return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("oxygen"));
 case STYLE_SYMBOLS_CLASSIC:return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("classic"));
+case STYLE_SYMBOLS_HUMAN:return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("human"));
 }
 
 return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("auto"));
@@ -735,6 +736,8 @@ ULONG StyleSettings::ImplNameToSymbolsStyle( const ::rtl::OUString &rName ) cons
 return STYLE_SYMBOLS_OXYGEN;
 else if ( rName == ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("classic")) )
 return STYLE_SYMBOLS_CLASSIC;
+else if ( rName == ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("human")) )
+return STYLE_SYMBOLS_HUMAN;
 
 return STYLE_SYMBOLS_AUTO;
 }


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] self-introduction Bjoern Michaelsen

[Michael Meeks]

On Tue, 2011-02-08 at 10:32 +0100, Bjoern Michaelsen wrote:
> I am Bjoern Michaelsen and I work on the Ubuntu Desktop Team and will
> take responsibility for the Libreoffice packaging there. I joined
> Canonical starting February, 1st.

And - just to say in public; what is well known in private - this is
awesome ! :-) A very warm welcome to both yourself, and Canonical to the
community, I'm really looking forward to working closely with you over
the years, as no doubt are the rest of the team.

Welcome !

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibO security

[Kevin Hunter]

At 2:22am -0500 Tue, 08 Feb 2011, Thorsten Behrens wrote:

Well, we have. It's Cc-ed. What we prolly need is to properly
document this.


No no!  They're just practicing good security: obscurity!  ;-)

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH][EasyHacks] Remove some use of svarray stuff in SwScriptInfo

[Nigel Hawkins]

Hi,

The attached patch removes one use of SvBytes and SvXub_StrLens from
SwScriptInfo.

There are still other uses in there to be replaced, but the bits don't
interact very much.

Changes under LGPLv3+/MPL

Nigel.
>From 8d92a6e07a576a76b429f98c10ab48975a69768f Mon Sep 17 00:00:00 2001
From: Nigel Hawkins 
Date: Tue, 8 Feb 2011 14:05:29 +
Subject: [PATCH 3/3] Remove some svArray usage in SwScriptInfo

---
 sw/source/core/inc/scriptinfo.hxx |   23 +++-
 sw/source/core/text/porlay.cxx|   52 
 2 files changed, 39 insertions(+), 36 deletions(-)

diff --git a/sw/source/core/inc/scriptinfo.hxx b/sw/source/core/inc/scriptinfo.hxx
index 5b46b8d..ef3a365 100644
--- a/sw/source/core/inc/scriptinfo.hxx
+++ b/sw/source/core/inc/scriptinfo.hxx
@@ -99,8 +99,16 @@ public:
 class SwScriptInfo
 {
 private:
-SvXub_StrLens aScriptChg;
-SvBytes aScriptType;
+//! Records a single change in script type.
+struct ScriptChangeInfo
+{
+xub_StrLen position; //!< Character position at which we change script
+BYTE   type; //!< Script type (Latin/Asian/Complex) that we change to.
+inline ScriptChangeInfo(xub_StrLen pos, BYTE typ) : position(pos), type(typ) {};
+};
+//TODO - This is sorted, so should probably be a std::set rather than vector.
+//   But we also use random access (probably unnecessarily).
+std::vector aScriptChanges;
 SvXub_StrLens aDirChg;
 SvBytes aDirType;
 SvXub_StrLens aKashida;
@@ -357,16 +365,17 @@ inline void SwScriptInfo::SetInvalidity( const xub_StrLen nPos )
 if ( nPos < nInvalidityPos )
 nInvalidityPos = nPos;
 };
-inline USHORT SwScriptInfo::CountScriptChg() const { return aScriptChg.Count(); }
+
+inline USHORT SwScriptInfo::CountScriptChg() const { return aScriptChanges.size(); }
 inline xub_StrLen SwScriptInfo::GetScriptChg( const USHORT nCnt ) const
 {
-OSL_ENSURE( nCnt < aScriptChg.Count(),"No ScriptChange today!");
-return aScriptChg[ nCnt ];
+OSL_ENSURE( nCnt < aScriptChanges.size(),"No ScriptChange today!");
+return aScriptChanges[nCnt].position;
 }
 inline BYTE SwScriptInfo::GetScriptType( const xub_StrLen nCnt ) const
 {
-OSL_ENSURE( nCnt < aScriptChg.Count(),"No ScriptType today!");
-return aScriptType[ nCnt ];
+OSL_ENSURE( nCnt < aScriptChanges.size(),"No ScriptType today!");
+return aScriptChanges[nCnt].type;
 }
 
 inline USHORT SwScriptInfo::CountDirChg() const { return aDirChg.Count(); }
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 7c6a4b3..51d6c55 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -915,9 +915,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 //
 
 // remove invalid entries from script information arrays
-const USHORT nScriptRemove = aScriptChg.Count() - nCnt;
-aScriptChg.Remove( nCnt, nScriptRemove );
-aScriptType.Remove( nCnt, nScriptRemove );
+aScriptChanges.erase( aScriptChanges.begin() + nCnt, aScriptChanges.end() );
 
 // get the start of the last compression group
 USHORT nLastCompression = nChg;
@@ -981,8 +979,8 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 
 if ( nScript != nNextScript )
 {
-aScriptChg.Insert( nEnd, nCnt );
-aScriptType.Insert( nScript, nCnt++ );
+aScriptChanges.push_back( ScriptChangeInfo(nEnd, nScript) );
+nCnt++;
 nScript = nNextScript;
 }
 }
@@ -991,7 +989,7 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 // UPDATE THE SCRIPT INFO ARRAYS:
 //
 
-while ( nChg < rTxt.Len() || ( !aScriptChg.Count() && !rTxt.Len() ) )
+while ( nChg < rTxt.Len() || ( !aScriptChanges.empty() && !rTxt.Len() ) )
 {
 OSL_ENSURE( i18n::ScriptType::WEAK != nScript,
 "Inserting WEAK into SwScriptInfo structure" );
@@ -1032,18 +1030,18 @@ void SwScriptInfo::InitScriptInfo( const SwTxtNode& rNode, sal_Bool bRTL )
 if (nType == U_NON_SPACING_MARK || nType == U_ENCLOSING_MARK ||
 nType == U_COMBINING_SPACING_MARK )
 {
-aScriptChg.Insert( nChg - 1, nCnt );
+aScriptChanges.push_back( ScriptChangeInfo(nChg-1, nScript) );
 }
 else
 {
-aScriptChg.Insert( nChg, nCnt );
+aScriptChanges.push_back( ScriptChangeInfo(nChg, nScript) );
 }
 }
 else
 {
-aScriptChg.Insert( nChg, nCnt );
+aScriptChanges.push_back( ScriptChangeInfo(nChg, nScript) );
 }
-aScriptType.Insert( nScript, nCnt++ );
+++nCnt;
 
 // if current script is asian, we search for compressable characters
 // in this range
@@ -1360,37 +1358,33 @@ void SwScriptInfo::InitScriptInfo( const SwTxtN

[Libreoffice] How to make cell with list data validation, a combo box

[Kishan Bhat]

Hello,

I've been trying to make a combobox for a cell with Data Validation > List
for LibreOffice calc.

I thought I could add that in the source and try out - so I downloaded LO
source and started greping for text, all thanks to the excellant LO page to
do so and the LibreOffice IRC channel.

Now, for days I've been grepping the source for texts that I could think of,
with no success. I open loads of *.cxx file and I'm not able to make out
where this code lies.

Can anyone help me with a better approach to find this piece of code that
shows selection list for a cell with "List" data validity?

Thanks in Advance
Kishan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

[Francois Tigeot]

On Tue, Feb 08, 2011 at 01:47:17PM +, Caolán McNamara wrote:
> On Sun, 2011-02-06 at 15:47 +0100, Francois Tigeot wrote:
> 
> > Oh, and by the way, createRegistryServiceFactory() used in saxparser.cxx
> > is deprecated in OpenOffice:
> 
> A lot of things that are deprecated remain in there, not enough forced
> migration from old apis or deprecated features. If you want to have a
> shot at updating it to the recommended stuff that'd be nifty. 

I may have a shot at it someday, but my top priority for now is to complete
a build. If I have to hack on something before I can do that, it would be
on the dmake replacement stuff.

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32894

--- Comment #16 from Tor Lillqvist  2011-02-08 06:12:07 
PST ---
Nominating bug #31023. And when I say "nominate", I mean "suggest".

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] talk about software deployment

[Florian Effenberger]

Hello,

I was invited to LOADays in Antwerp, Belgium, to deliver a talk on 
LibreOffice software deployment mid of April. However, I don't know if I 
can make it, so I'd like to ask if one of you with expertise in this 
area would be interested to go there?


Travel funding might be possible.

*NOTE* Please ping me offlist, as I'm not subscribed to the 
Freedesktop.org list at the moment.


Thanks,
Florian

--
Florian Effenberger 
Steering Committee and Founding Member of The Document Foundation
Tel: +49 8341 99660880 | Mobile: +49 151 14424108
Skype: floeff | Twitter/Identi.ca: @floeff
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed more blank lines/reordered #include's

[Caolán McNamara]

On Mon, 2011-02-07 at 08:54 +0100, Christina Roßmanith wrote:
> There are at least three different stlpool.hxx in different directories 
> of LO, but 

> it is included just as "#include ". I think that 
> ../../../../inc/bf_sd/stlpool.hxx is the one which is included, but I am 
> not sure. Shouldn't the line be changed to "#include 
> " then?

if you...

export VERBOSE=true
and run dmake in that dir you'll see the exact compiler line used, and
it has -I../../../../inc/bf_sd near the start. So that's the first place
that gets looked so yeah, that's the one that gets included. If you want
to change it for consistently reasons then go ahead, though I wouldn't
expend much energy in binfilter for the usual reasons around binfilter.

No objections to the patch, go ahead and push it IMO.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] self-introduction Bjoern Michaelsen

[Thorsten Behrens]

Bjoern Michaelsen wrote:
> I am Bjoern Michaelsen and I work on the Ubuntu Desktop Team and will
> take responsibility for the Libreoffice packaging there. I joined
> Canonical starting February, 1st.
> 
Hi Björn,

a warm welcome, also here on this list - looking forward to work
with you! Also thanks for your support during FOSDEM - it's been a
great collaboration so far! :)

Cheers,

-- Thorsten


pgp7Z7eIVihH3.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

[Caolán McNamara]

On Sun, 2011-02-06 at 15:47 +0100, Francois Tigeot wrote:
> What was it ?

The specific thing that Fridrich fixed was a dubious
hash_map/unordered_map::erase on the results of a
hash_map/unordered_map::find when find returns the end iterator to
indicate that nothing was found

> Oh, and by the way, createRegistryServiceFactory() used in saxparser.cxx
> is deprecated in OpenOffice:

A lot of things that are deprecated remain in there, not enough forced
migration from old apis or deprecated features. If you want to have a
shot at updating it to the recommended stuff that'd be nifty. 

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] BorderLine fix

[Caolán McNamara]

On Tue, 2011-02-08 at 10:33 +0100, Cedric Bosdonnat wrote:
> Hello fellow hackers,
> 
> David fixed the BorderLine API problem a while ago with this commit
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d
>  in master.
> 
> I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could
> anybody else review it?

This is the one that fixes fdo#33397. Yeah +1 from me.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] EasyHacks: Make existing tests work (ure/sal)

[Caolán McNamara]

On Sat, 2011-02-05 at 23:45 +0100, Wilhelm Pflüger wrote:
> Attached please find some changes to make tests in ure/sal work.
> 
> One test fails and breaks the build though 

I looked back over the history of the code related to that failing test
and I see that some years ago it was tweaked to specifically not do the
thing that the test continues to test for (explicit directives to set
the iso 2022 string state to begin in ascii, new code elides them at the
beginning of strings).

So I've now adjusted the test for the new stuff (stuck a non-ascii char
at the beginning so it *does* have to insert the ascii directive when it
gets to the ascii char after it) and turned it on again. Thanks for
these btw :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] self-introduction Bjoern Michaelsen

[Bjoern Michaelsen]

Hi Miklos,

On Tue, 8 Feb 2011 12:37:58 +0100
Miklos Vajna  wrote:

> Did you accidently swap your real name and email address in your git
> config?

Yes, and it is fixed by now.

Quoth my IRC log from yesterday:
16:13  * Sweetshark searches through the git scm book for "how to not
botch your first git commit" ;)

... I guess I failed ...

Best Regards,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Issues for pivot tables ... where to post

[Cor Nouws]

Hi Kohei, *,

Someone writes about an issue in OOo/Lo 330, that was not present in OOo 
321.


Is it better to post that in Bugzilla or in the OOo IssueTracker?
(Currently I see one Pivot-issue - 33990 - in Bugzilla)

Thanks,
Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] self-introduction Bjoern Michaelsen

[Miklos Vajna]

On Tue, Feb 08, 2011 at 10:32:13AM +0100, Bjoern Michaelsen 
 wrote:
> I would like to shortly introduce myself as new contributor to
> LibreOffice:

Welcome!

From git log:

commit f6a16194d1348cb1c679acec5cd9e014ca3f3104
Author: bjoern.michael...@canonical.com 

Did you accidently swap your real name and email address in your git
config?


pgpv4VZq8goRn.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fw: [PATCH] Removed unused functions and classes from calc 3last

[Alfonso Eusebio]

Hi,

Could somebody advise if the patch below is acceptable or if I should change it 
somehow?


If it can't be committed for some reason, please let me know so that I can 
focus 
on some other area.

Thanks & regards,
Alfonso


- Forwarded Message 
From: Alfonso Eusebio 
To: LibreOffice List 
Sent: Sun, 6 February, 2011 19:08:22
Subject: [PATCH] Removed unused functions and classes from calc 3last

Hi,

Please find attached a new patch that removes several unused functions and 
classes from calc.
Both functions and classes have been found through the call-catcher list.

Please notice that this patch removes three entire classes: 
ScSummableCompressedArray, ScVbaCharts and ScVbaSeriesCollection.
For the last two classes the corresponding .cxx and .hxx files have been 
removed.

This patch has been rebased with origin/master and compiled before submission.

On a related note:
Several of the unused functions identified by call-catcher live in the addin 
"module" within calc (calc/sc/addin). These functions seem to be called 
indirectly by the function add-in mechanism.
I have not removed these functions, however, it seems that this "addin" module 
is obsolete now, with the scaddins (calc/scaddins) module replacing it (?).
In any case, if somebody can confirm that the "addin" module can be removed, I 
could work on it.

Regards,
Alfonso


  From 666869f92707dcfe9ecbbe4f224ac2f3dec1b780 Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio 
Date: Sun, 6 Feb 2011 17:58:59 +
Subject: [PATCH] Removed unused functions and classes form calc 3last

Removed unused function and some entire classes from calc.
The functions removed are some of those identified by call-catcher.
---
 sc/inc/compressedarray.hxx |   45 ---
 sc/inc/tabbgcolor.hxx  |3 -
 sc/inc/validat.hxx |4 -
 sc/source/core/data/compressedarray.cxx|   58 -
 sc/source/core/data/tabbgcolor.cxx |   10 --
 sc/source/core/data/validat.cxx|9 --
 sc/source/filter/excel/xechart.cxx |   10 --
 sc/source/filter/excel/xeformula.cxx   |   12 --
 sc/source/filter/inc/xechart.hxx   |5 -
 .../AccessibleDocumentPagePreview.cxx  |   13 +--
 sc/source/ui/inc/viewdata.hxx  |2 -
 sc/source/ui/vba/makefile.mk   |2 -
 sc/source/ui/vba/vbacharts.cxx |  122 
 sc/source/ui/vba/vbacharts.hxx |   63 --
 sc/source/ui/vba/vbaformatconditions.cxx   |   12 --
 sc/source/ui/vba/vbaformatconditions.hxx   |1 -
 sc/source/ui/vba/vbarange.cxx  |5 -
 sc/source/ui/vba/vbarange.hxx  |1 -
 sc/source/ui/vba/vbaseriescollection.cxx   |   82 -
 sc/source/ui/vba/vbaseriescollection.hxx   |   57 -
 sc/source/ui/vba/vbawindows.cxx|5 -
 sc/source/ui/vba/vbawindows.hxx|2 +-
 sc/source/ui/view/viewdata.cxx |   13 --
 23 files changed, 2 insertions(+), 534 deletions(-)
 delete mode 100644 sc/source/ui/vba/vbacharts.cxx
 delete mode 100644 sc/source/ui/vba/vbacharts.hxx
 delete mode 100644 sc/source/ui/vba/vbaseriescollection.cxx
 delete mode 100644 sc/source/ui/vba/vbaseriescollection.hxx

diff --git a/sc/inc/compressedarray.hxx b/sc/inc/compressedarray.hxx
index 12a5940..d45c0b2 100644
--- a/sc/inc/compressedarray.hxx
+++ b/sc/inc/compressedarray.hxx
@@ -349,51 +349,6 @@ void ScCompressedArrayIterator::Resync( A nPos )
 }
 
 
-// === ScSummableCompressedArray =
-
-/** Data type D must be of a type that is convertable to unsigned long. The
-advantage is that specialized methods exist to act on a region of values
-for performance reasons.
- */
-
-template< typename A, typename D > class ScSummableCompressedArray : public ScCompressedArray
-{
-public:
-ScSummableCompressedArray( A nMaxAccessP,
-const D& rValue,
-size_t nDeltaP = nScCompressedArrayDelta )
-: ScCompressedArray( nMaxAccessP,
-rValue, nDeltaP)
-{}
-ScSummableCompressedArray( A nMaxAccessP,
-const D* pDataArray, size_t nDataCount )
-: ScCompressedArray( nMaxAccessP,
-pDataArray, nDataCount)
-{}
-
-/** Returns the sum of all values for a region. If an overflow would occur,
-::std::numeric_limits::max() is returned. */
-unsigned long   SumValues( A nStart, A

[Libreoffice] FreeBSD support round2

[Baptiste Daroussin]

Hi,

here is a new set of simple patches for freebsd.

libs-gui-fix-spadmin set the LD_LIBRARY_PATH so be able to correctly
launch spadmin
bootstrap-cleanup-unx-fbsd.mk is inspired by openbsd, it is a huge
simplification of what was done before + it prevents from having
different shared library name depending on architecture which easier
the management a plist.
libs-core-fix-unopkg.sh add FreeBSD to the list of BSD OS which needs
the LD_LIBRARY_PATH to be able to correctly launch it?

Hope this could be also committed in the 3.3.1 branch :)

regards,
Bapt


libs-gui-fix-spadmin
Description: Binary data


bootstrap-cleanup-unxfbsd.mk
Description: Binary data


libs-core-fix-unopkg.sh
Description: Bourne shell script
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] self-introduction Bjoern Michaelsen

[Bjoern Michaelsen]

Hi all,

I would like to shortly introduce myself as new contributor to
LibreOffice:

I am Bjoern Michaelsen and I work on the Ubuntu Desktop Team and will
take responsibility for the Libreoffice packaging there. I joined
Canonical starting February, 1st.

Before joining Canonical I have been part of the OpenOffice.org
development team at Sun/Oracle in Hamburg. In the last three
years there, I have implemented features like the Usage Tracking in
OpenOffice.org, did quite a bit of refactoring and bugfixing in Writer
and was one of the main creators of the new build system that
OpenOffice.org has already partly been migrated to and that LibreOffice
will migrate to soon too.

Best Regards,

Bjoern Michaelsen

--
https://launchpad.net/~bjoern-michaelsen


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH][EasyHacks] Get rid of SvBytes and SvULongs in SwLayCacheIoImpl

[Nigel Hawkins]

Hi,

Attached is a patch to remove a couple more uses of svarray stuff from
writer.

Nigel
>From 54529e04dcd47306724c478d3ac177a63ce24a42 Mon Sep 17 00:00:00 2001
From: Nigel Hawkins 
Date: Thu, 3 Feb 2011 16:09:53 +
Subject: [PATCH 2/2] Remove svArrays from SwLayCacheIoImpl

---
 sw/source/core/layout/laycache.cxx |   44 ++--
 sw/source/core/layout/layhelp.hxx  |   10 ++-
 2 files changed, 25 insertions(+), 29 deletions(-)

diff --git a/sw/source/core/layout/laycache.cxx b/sw/source/core/layout/laycache.cxx
index a2ec1d2..89620a9 100644
--- a/sw/source/core/layout/laycache.cxx
+++ b/sw/source/core/layout/laycache.cxx
@@ -1186,13 +1186,10 @@ SwLayCacheIoImpl::SwLayCacheIoImpl( SvStream& rStrm, BOOL bWrtMd ) :
 BOOL SwLayCacheIoImpl::OpenRec( BYTE cType )
 {
 BOOL bRes = TRUE;
-UINT16 nLvl = aRecTypes.Count();
-OSL_ENSURE( nLvl == aRecSizes.Count(), "OpenRec: Level" );
 UINT32 nPos = pStream->Tell();
 if( bWriteMode )
 {
-aRecTypes.Insert( cType, nLvl );
-aRecSizes.Insert( nPos, nLvl );
+aRecords.push_back( RecTypeSize(cType, nPos) );
 *pStream << (UINT32) 0;
 }
 else
@@ -1200,20 +1197,20 @@ BOOL SwLayCacheIoImpl::OpenRec( BYTE cType )
 UINT32 nVal;
 *pStream >> nVal;
 BYTE cRecTyp = (BYTE)nVal;
-aRecTypes.Insert( cRecTyp, nLvl );
-sal_uInt32 nSize = nVal >> 8;
-aRecSizes.Insert( nPos + nSize, nLvl );
 if( !nVal || cRecTyp != cType ||
 pStream->GetErrorCode() != SVSTREAM_OK || pStream->IsEof() )
 {
 OSL_ENSURE( nVal, "OpenRec: Record-Header is 0" );
-OSL_ENSURE( cRecTyp == cType,
-"OpenRec: Wrong Record Type" );
-aRecTypes[nLvl] = 0;
-aRecSizes[nLvl] = pStream->Tell();
+OSL_ENSURE( cRecTyp == cType, "OpenRec: Wrong Record Type" );
+aRecords.push_back( RecTypeSize(0, pStream->Tell()) );
 bRes = sal_False;
 bError = TRUE;
 }
+else
+{
+sal_uInt32 nSize = nVal >> 8;
+aRecords.push_back( RecTypeSize(cRecTyp, nPos+nSize) );
+}
 }
 return bRes;
 }
@@ -1223,19 +1220,16 @@ BOOL SwLayCacheIoImpl::OpenRec( BYTE cType )
 BOOL SwLayCacheIoImpl::CloseRec( BYTE )
 {
 BOOL bRes = TRUE;
-UINT16 nLvl = aRecTypes.Count();
-OSL_ENSURE( nLvl == aRecSizes.Count(), "CloseRec: wrong Level" );
-OSL_ENSURE( nLvl, "CloseRec: no levels" );
-if( nLvl )
+OSL_ENSURE( !aRecords.empty(), "CloseRec: no levels" );
+if( !aRecords.empty() )
 {
-nLvl--;
 UINT32 nPos = pStream->Tell();
 if( bWriteMode )
 {
-UINT32 nBgn = aRecSizes[nLvl];
+UINT32 nBgn = aRecords.back().size;
 pStream->Seek( nBgn );
 UINT32 nSize = nPos - nBgn;
-UINT32 nVal = ( nSize << 8 ) | aRecTypes[nLvl];
+UINT32 nVal = ( nSize << 8 ) | aRecords.back().type;
 *pStream << nVal;
 pStream->Seek( nPos );
 if( pStream->GetError() != SVSTREAM_OK )
@@ -1243,7 +1237,7 @@ BOOL SwLayCacheIoImpl::CloseRec( BYTE )
 }
 else
 {
-UINT32 n = aRecSizes[nLvl];
+UINT32 n = aRecords.back().size;
 OSL_ENSURE( n >= nPos, "CloseRec: to much data read" );
 if( n != nPos )
 {
@@ -1254,9 +1248,7 @@ BOOL SwLayCacheIoImpl::CloseRec( BYTE )
 if( pStream->GetErrorCode() != SVSTREAM_OK )
 bRes = FALSE;
 }
-
-aRecTypes.Remove( nLvl, 1 );
-aRecSizes.Remove( nLvl, 1 );
+aRecords.pop_back();
 }
 
 if( !bRes )
@@ -1267,16 +1259,14 @@ BOOL SwLayCacheIoImpl::CloseRec( BYTE )
 
 UINT32 SwLayCacheIoImpl::BytesLeft()
 {
-UINT16 nLvl = aRecSizes.Count();
 UINT32 n = 0;
-if( !bError && nLvl )
+if( !bError && !aRecords.empty() )
 {
-UINT32 nEndPos = aRecSizes[ nLvl-1 ];
+UINT32 nEndPos = aRecords.back().size;
 UINT32 nPos = pStream->Tell();
 if( nEndPos > nPos )
 n = nEndPos - nPos;
 }
-
 return n;
 }
 
@@ -1301,7 +1291,7 @@ void SwLayCacheIoImpl::SkipRec()
 {
 BYTE c = Peek();
 OpenRec( c );
-pStream->Seek( aRecSizes[aRecSizes.Count()-1] );
+pStream->Seek( aRecords.back().size );
 CloseRec( c );
 }
 
diff --git a/sw/source/core/layout/layhelp.hxx b/sw/source/core/layout/layhelp.hxx
index 71f74a2..009e462 100644
--- a/sw/source/core/layout/layhelp.hxx
+++ b/sw/source/core/layout/layhelp.hxx
@@ -35,6 +35,7 @@
 #include 
 #endif
 #include 
+#include 
 
 class SwDoc;
 class SwFrm;
@@ -167,8 +168,13 @@ public:
 
 class SwLayCacheIoImpl
 {
-SvBytes		   	aRecTypes;
-SvULongs		aRecSizes;
+private:
+struct RecTypeSize {
+BYTE  type;
+ULONG size;
+RecTypeSize(BYTE typ, ULONG siz) : type(typ), size(siz) {}
+};
+std::vector aR

Re: [Libreoffice] [REVIEW] BorderLine fix

[Noel Power]

On 08/02/11 09:33, Cedric Bosdonnat wrote:

Hello fellow hackers,

David fixed the BorderLine API problem a while ago with this commit
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d
 in master.

I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could
anybody else review it?

Regards,


I think it looks good too
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] patch lib-core/eventattacher

[David Tardon]

On Mon, Feb 07, 2011 at 10:20:55PM +0100, Rob Snelders wrote:
> Hi,
> 
> Here is a small patch which translates the comments in the
> eventattacher from German to English
> 

Thanks, pushed!

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum

[Nigel Hawkins]

On Mon, 2011-02-07 at 23:31 +0300, Andrey Turkin wrote:
> So that would be the next step? Should I squash the two patches and resubmit 
> it?

Hopefully, Michael or somebody will push the pair of them.

Since we both seem to be looking at this section of the EasyHacks, can I
suggest we follow Michael's suggestion and add a note on the wiki that
we've started a bit. Then we can avoid duplicating effort.

Nigel.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] BorderLine fix

[Cedric Bosdonnat]

Hello fellow hackers,

David fixed the BorderLine API problem a while ago with this commit
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d
 in master.

I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could
anybody else review it?

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

[Nigel Hawkins]

Hi David,

> 4. Special preprocessor magic is required...
> 
> 5. sal tests are 'special' with regard to cppunit...

Could you summarise this sort of information on the wiki somewhere?

A lot of the code-base seems to have very little testing in place and
dependency issues make it hard enough to add any. Having a reference for
all this background stuff would be very useful. 

Nigel.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Corrected typo in names of four swriter classes

[David Tardon]

On Mon, Feb 07, 2011 at 09:30:47PM +0100, Christoph Herzog wrote:
> From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001
> From: Christoph Herzog 
> Date: Mon, 7 Feb 2011 21:20:16 +0100
> Subject: [PATCH] Corrected typo in names of four swriter classes
> 
> Checked for the misspelled names via ./g grep, built master before
> and after the changes and no error occurred. So hopefully it is ok.
> 

Heh, nice :) Pushed now.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] issue with Borderline structure

[David Tardon]

On Mon, Feb 07, 2011 at 09:22:50PM +0100, Dietmar wrote:
> I am having an issue with my extension Borderliner written in Java. It
> works fine with Oracle OOo, but does not with Go-OO and LO.

Yes, we know already: https://bugs.freedesktop.org/show_bug.cgi?id=33397 .

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

[David Tardon]

On Tue, Feb 08, 2011 at 09:16:54AM +0100, David Tardon wrote:
> On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote:
> > More reanimated tests. The osl/file part is not satisfying. I had to
> > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to
> > keep it.
> > 
> > These patches are LGPLv3+/MPL.
> > 
> 
> Nice work! I have a couple of comments, nevertheless:
 
5. sal tests are 'special' with regard to cppunit in that that
   cppunittester is built in the same module, so one cannot expect it to
   be delivered already. I created a helper file sal/qa/cppunit_local.mk
   that should be included in all sal tests' makefiles instead of
   _cppunit.mk . This helper sets the correct path to cppunittester and
   then proceeds with including _cppunit.mk as usual. Note that one must
   use full path when including it, i.e., $(PRJ)$/qa$/cppunit_local.mk .

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove bogus comments + bash line

[Thomas Arnhold]

Hi Guilaume,

you can request a git account an push the patches by your own:

http://freedesktop.org/wiki/AccountRequests

Thomas

On 02/08/2011 08:57 AM, Guillaume Poussel wrote:
> I have edited the wiki to show I'm currently working on it.
> Please find attached again new patches to remove this comments.
> 
> Regards,
> Guillaume Poussel.
> 
> 2011/2/7 Guillaume Poussel :
>> I have removed all of them in impress too (see patch attached). As
>> soon as someone push it, I edit the wiki.
>>
>> (still in LGPLv3/MPL)
>>
>> Regards,
>> Guillaume Poussel
>>
>> 2011/2/7 Guillaume Poussel :
>>> Hi all,
>>>
>>> Again, I send patches to remove bogus comments.
>>>
>>> I have written a pretty (but not optimized) bash line to find them all:
>>> git grep -nE " #[^i][0-9]+#" | ( while read f; do file=$(echo "$f" |
>>> cut -d':' -f1) ; line=$(echo "$f" | cut -d':' -f2) ; emacs "+"$line
>>> -fh "$file"; done )
>>> It opens emacs with every occurences of #xxx#.
>>>
>>> As soon as I have time, I will try to end up by finishing this "Easy Hack".
>>>
>>> Regards,
>>> Guillaume Poussel
>>>
>>
>>
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

[David Tardon]

On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote:
> More reanimated tests. The osl/file part is not satisfying. I had to
> switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to
> keep it.
> 
> These patches are LGPLv3+/MPL.
> 

Nice work! I have a couple of comments, nevertheless:

1. Try to avoid changing whitespace in unrelated code, as it makes it
   harder to spot the actual changes. If you really feel that you must
   do it, use a separate commit .-) I removed a lot of hunks that
   contained only a whitespace changes this time, but left it in other
   hunks.

2. When re-enabling old code (like in this case), avoid adding new
   functionality (that is not absolutely needed for the code to work).
   Again, it makes it harder for the reviewer. It also complicates
   reverting a change in a test, should it be found that it does not
   work as expected. Of course, your changes in the osl_Directory tests
   are good and I encourage you sincerely to continue in enhancing the
   tests; just commit the enhancements separately, please :-)

3. (a nitpick) bTest == sal_False is customarily written as !bTest .-)

4. (I forgot to note this the last time) Special preprocessor magic is
   required for the case of building with internal STLPort, but external
   CppUnit :-) See commit 5c5e8b76f27f45a660455c236496513201afd911 in
   ure.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice