[Libreoffice] [PATCH] Some build breakage fixes for MSVC2008
Hi all, I was finally able to get a successful build and package to complete on Windows using MSVC2008 Express. I was not able to do this on my windows 7 64 bit machine but this may be due to the diversity of development environments I had previously installed on it. I worked around the problem by using a Windows XP Mode VM to do a fresh install of the tool chain. I had to make the following small patches to get the build to work. sw_compile.patch does a nasty hack to make a member function mutable because it is referenced all over the place using non const iterators. I didn't want to break anything so I took an easy out and made it mutable but I would think it would be better fixed by using const_cast wherever a non-const iterator is created. sw_const_fix.patch addresses a couple of const_iterator issues in unochart.cxx. unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n - my reference says it returns void but the original code was expecting an iterator returned. I imagine it must be an STLport extension, but it is broken with the built in STL and I believe the fix is correct. Regards Steven Butler sw_compile.patch Description: Binary data sw_const_fix.patch Description: Binary data unopkg_app_stl_fix.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Deleting some commented out code
Of course, I make the most classic mistake. Code is contributed under the LGPLv3+ / MPL. Luke On Fri, Feb 11, 2011 at 11:55 PM, L P luke.petrole...@gmail.com wrote: Hi, I'm a CS student at the University of Toronto, Canada. I managed to build LibreOffice this evening, with the intent of helping LibreOffice where I can! Unfortunately I'm a bit new to C++ so I can't do the awesome stuff that you guys do, but I'm learning quite quickly. The patchfile I've attached deletes 3 lines of commented out code (bad!) as per your Easy Hacks page. I know this is trivial in the scope of things, but it's the first time I wanted to contribute to a project that's quite big in scope, so please consider this a trial balloon to make I'm sure that I'm doing this right and helping -- and not hindering -- the project. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] update service
Hello, please Cc me on all replies, as I am not subscribed to this list. For the release of 3.3.1, we should think about enabling an update service mechanism. Right now, the update requests reach our server, without being answered. Anyone has an insight on how the mechanism works and what we have to provide server-side? Thanks, Florian -- Florian Effenberger flo...@documentfoundation.org Steering Committee and Founding Member of The Document Foundation Tel: +49 8341 99660880 | Mobile: +49 151 14424108 Skype: floeff | Twitter/Identi.ca: @floeff ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Deleting some commented out code
Hi, I'm a CS student at the University of Toronto, Canada. I managed to build LibreOffice this evening, with the intent of helping LibreOffice where I can! Unfortunately I'm a bit new to C++ so I can't do the awesome stuff that you guys do, but I'm learning quite quickly. The patchfile I've attached deletes 3 lines of commented out code (bad!) as per your Easy Hacks page. I know this is trivial in the scope of things, but it's the first time I wanted to contribute to a project that's quite big in scope, so please consider this a trial balloon to make I'm sure that I'm doing this right and helping -- and not hindering -- the project. Luke patchfile Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] New feature: print current page
Hi! Wow, thanks for the fast replies. Am 2011-02-11 22:38, schrieb Christoph Noack: Indeed, that would be great. I noticed another issue that seems to be different with regard to the original specification. And, there is a serious usability/utility issue since the dialog doesn't save printer / printing options in certain cases. So if there is a helpful (developer) hand, then I'd like to resolve this ... Anybody? :-) Well, I really would like to help. But as I said, I'm new here and have absolutely no experience in developing LibreOffice/OpenOffice. Although if this is kind of easy work, I could give it a try. Regards, Tobias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Easy Hack
Hy, I have removed some dead code. Regards, Balint Dozsa From e2f04f3f3983d60af2e05f28877c043c5f4aa380 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A1lint=20D=C3=B3zsa?= dozsabal...@gmail.com Date: Sat, 12 Feb 2011 11:30:27 +0100 Subject: [PATCH] Remove dead codes --- writerfilter/source/dmapper/DomainMapper.cxx |8 +- .../source/dmapper/DomainMapperTableHandler.cxx|5 +- .../source/dmapper/DomainMapperTableManager.cxx|2 - writerfilter/source/dmapper/DomainMapper_Impl.hxx |2 - writerfilter/source/dmapper/FontTable.hxx |6 +- writerfilter/source/dmapper/GraphicImport.cxx | 107 ++-- writerfilter/source/dmapper/NumberingManager.cxx |3 +- writerfilter/source/dmapper/PropertyIds.cxx| 15 --- writerfilter/source/dmapper/PropertyMap.cxx| 14 --- writerfilter/source/dmapper/PropertyMap.hxx| 10 -- writerfilter/source/dmapper/SettingsTable.cxx |9 +- writerfilter/source/dmapper/StyleSheetTable.cxx|5 +- writerfilter/source/dmapper/ThemeTable.cxx |7 +- 13 files changed, 19 insertions(+), 174 deletions(-) diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 8584268..3a47121 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -2060,7 +2060,7 @@ void DomainMapper::sprm( Sprm rSprm, PropertyMapPtr rContext, SprmType eSprmTyp nEscapement = -58; else if (nIntValue 0) nEscapement = 58; -else /* (nIntValue == 0) */ +else nProp = 0; rContext-Insert(PROP_CHAR_ESCAPEMENT, true, uno::makeAny( nEscapement ) ); rContext-Insert(PROP_CHAR_ESCAPEMENT_HEIGHT, true, uno::makeAny( nProp ) ); @@ -2146,8 +2146,6 @@ void DomainMapper::sprm( Sprm rSprm, PropertyMapPtr rContext, SprmType eSprmTyp } const FontEntry::Pointer_t pFontEntry(pFontTable-getFontEntry(sal_uInt32(nIntValue))); rContext-Insert(eFontName, true, uno::makeAny( pFontEntry-sFontName )); -//rContext-Insert(eFontStyle, uno::makeAny( pFontEntry- )); -//rContext-Insert(eFontFamily, uno::makeAny( pFontEntry- )); rContext-Insert(eFontCharSet, true, uno::makeAny( (sal_Int16)pFontEntry-nTextEncoding )); rContext-Insert(eFontPitch, true, uno::makeAny( pFontEntry-nPitchRequest )); } @@ -3132,7 +3130,7 @@ void DomainMapper::sprm( Sprm rSprm, PropertyMapPtr rContext, SprmType eSprmTyp /*-- 09.06.2006 09:52:13--- ---*/ -void DomainMapper::entry(int /*pos*/, +void DomainMapper::entry(int, writerfilter::ReferenceProperties::Pointer_t ref) { #ifdef DEBUG_DOMAINMAPPER @@ -3448,8 +3446,6 @@ void DomainMapper::table(Id name, writerfilter::ReferenceTable::Pointer_t ref) dmapper_logger-startElement(table); dmapper_logger-attribute(id, (*QNameToString::Instance())(name)); #endif - -// printf ( DomainMapper::table(0x%.4x)\n, (unsigned int)name); m_pImpl-SetAnyTableImport(true); switch(name) { diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx index dedcd36..d3f8b4c 100644 --- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx @@ -103,7 +103,7 @@ DomainMapperTableHandler::~DomainMapperTableHandler() } void DomainMapperTableHandler::startTable(unsigned int nRows, - unsigned int /*nDepth*/, + unsigned int, TablePropertyMapPtr pProps) { m_aTableProperties = pProps; @@ -801,9 +801,6 @@ void DomainMapperTableHandler::startCell(const Handle_t start, #endif //add a new 'row' of properties -//if( m_pCellProperties.size() = sal::static_int_cast sal_uInt32, sal_Int32(m_nRowIndex) ) -//m_pCellProperties.push_back( RowProperties_t() ); -//m_pCellProperties[m_nRowIndex].push_back( pProps ); m_pCellSeq = CellSequencePointer_t(new CellSequence_t(2)); if (!start.get()) return; diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx b/writerfilter/source/dmapper/DomainMapperTableManager.cxx index b5509e8..1ed6ba6 100644 --- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx @@ -256,7 +256,6 @@ bool DomainMapperTableManager::sprm(Sprm rSprm) { TablePropertyMapPtr pPropMap( new TablePropertyMap ); const sal_Int16 HORI_LEFT_TOP = 0; -
Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour
On Tue, 2011-02-08 at 11:13 +0700, Nguyen Vu Hung wrote: On Tue, Feb 8, 2011 at 11:05 AM, Kohei Yoshida kyosh...@novell.com wrote: On Mon, 2011-02-07 at 02:29 +0700, Nguyen Vu Hung wrote: m$ excel allows content in cells a1, a3, a5 to be selected and copied to a7, a9, a11. This is not possible in calc. A feature request please. Actually in Excel when you copy A1, A3, A5 then paste to A7, it pastes to A7:A9. Calc does the same thing. So, I'm not sure what feature is being requested here. Can you clarify a bit? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build failing in packimages
Hi all, any suggestions about this? = Building module packimages = Entering /Users/dfdumaresq/git/libo/packimages/pack mkout -- version: 1.8 mkdir ../unxmacxi.pro/res/img /usr/bin/perl /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl image-sort.lst /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml ../unxmacxi.pro/res/img/sorted.lst Can't open /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml/uiconfig/modules/scalc/toolbar/standardbar.xml: No such file or directory at /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl line 12. dmake: Error code 2, while making '../unxmacxi.pro/res/img/sorted.lst' dmake: '../unxmacxi.pro/res/img/sorted.lst' removed. Forcing regeneration of dependency info nothing to do here... mkdir ../unxmacxi.pro/res/img mkdir: ../unxmacxi.pro/res/img: File exists /usr/bin/perl /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl image-sort.lst /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml ../unxmacxi.pro/res/img/sorted.lst Can't open /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml/uiconfig/modules/scalc/toolbar/standardbar.xml: No such file or directory at /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl line 12. dmake: Error code 2, while making '../unxmacxi.pro/res/img/sorted.lst' dmake: '../unxmacxi.pro/res/img/sorted.lst' removed. Retrying /Users/dfdumaresq/git/libo/packimages/pack mkdir ../unxmacxi.pro/res/img mkdir: ../unxmacxi.pro/res/img: File exists /usr/bin/perl /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl image-sort.lst /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml ../unxmacxi.pro/res/img/sorted.lst Can't open /Users/dfdumaresq/git/libo/solver/330/unxmacxi.pro/xml/uiconfig/modules/scalc/toolbar/standardbar.xml: No such file or directory at /Users/dfdumaresq/git/libo/solenv/bin/image-sort.pl line 12. dmake: Error code 2, while making '../unxmacxi.pro/res/img/sorted.lst' dmake: '../unxmacxi.pro/res/img/sorted.lst' removed. Thanks! dave ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
Hi Takeshi, On Fri, 2011-02-11 at 20:31 +0900, KUROSAWA, Takeshi wrote: Currently LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2 for POINTER_HAND. As a result, LibreOffice uses GDK_HAND1 for hyperlinks, while many GTK2 applications use GDK_HAND2. # See attached png images. :-) Since there is not much difference between GDK_HAND1 and GDK_HAND2 and GDK_HAND1 is not commonly used, we should use GDK_HAND2 for both POINTER_REFHAND and POINTER_HAND. It would be interesting to know how POINTER_HAND and POINTER_REFHAND are used around the LibreOffice code ? But anyhow - the patch looks fine for what it is :-) It'd be great to push it, but it'd be nice to know if we really use this distinction meaningfully inside vcl and its dependents anyway ... Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Takao font support for 3.3.1.
On Sat, Feb 12, 2011 at 3:22 AM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2011-02-11 at 13:17 -0500, Kohei Yoshida wrote: Hi there, I'd like to have the following change http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?h=libreoffice-3-3id=3b8c4baec540c851ebf97d933e11150192defa87 reviewed for inclusion into the 3.3.1 branch. This change fixes https://bugs.freedesktop.org/show_bug.cgi?id=32810 If I understand correctly Takao font is used by several Linux distros as the default Japanese UI font, so getting that font recognized properly is pretty important. The change is pretty simple and IMO non-intrusive. That whole bunch of methods is deeply disturbing, Nevertheless for this specific issue, sure, agreed that adding a few more in there looks incredibly safe, looks good to me. +1 -- Best Regards, Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng ) vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO 3.3.1 RC1 Calc, Search dialog bug
Some more details: Am Freitag, den 11.02.2011, 23:08 +0100 schrieb Dietmar: Could someone countercheck this please. In Calc use the Search and Replace dialog. Check search in all tables Search for a term that is NOT in the current table, but in anotherone. It is not found, but should be. Looks like the search in all tables just searches the current one. Dietmar The bug only occurs, if the search _toolbar_ has been used before (unsuccessfully). It is probably related to issue https://bugs.freedesktop.org/show_bug.cgi?id=33593#c1 which was fixed in Openoffice.org 3.3.0. This bug fix should also get into LO 3.3.1. Dietmar -- http://extensions.services.openoffice.org/en/project/BorderLiner ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO 3.3.1 RC1 Calc, Search dialog bug
The bug only occurs, if the search _toolbar_ has been used before (unsuccessfully). It is probably related to issue https://bugs.freedesktop.org/show_bug.cgi?id=33593#c1 which was fixed in Openoffice.org 3.3.0. This bug fix should also get into LO 3.3.1. Acording to the bug report it was fixed after and the bug is still present in OOo 3.3.0. -- Jesús Corrius je...@softcatala.org Document Foundation founding member Mobile: +34 661 11 38 26 Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Remove obsolete Hyperlink Bar - final patches
Thanks Jan! I only performed functional tests, i.e. re-built all modules, dev-installed and checked that all apps were opening properly and not providing the option to enable the bar. At the same time I checked that the Insert Hyperlink dialogue (open from the icon in the standard bar) was opening fine. Is there anything that could be done about the help text that still talks about the Hyperlink Bar? I'll be happy to give it a try, but I guess we need somebody with copywriter skills as it is a change of help text. Thanks again and regards, Alfonso - Original Message From: Jan Holesovsky ke...@suse.cz To: Alfonso Eusebio alfonso_euse...@yahoo.co.uk Cc: LibreOffice List libreoffice@lists.freedesktop.org Sent: Fri, 11 February, 2011 18:31:14 Subject: [PUSHED] Re: [Libreoffice] [PATCH] Remove obsolete Hyperlink Bar - final patches Hi Alfonso, On 2011-02-10 at 08:38 +, Alfonso Eusebio wrote: Please find attached a set of patches that remove the Hyperlink Bar from the core modules. Thank you! Pushed :-) Unfortunately I was unable to test the installation, as the unit tests are failing for me (not your fault, even without your patches), but the patches look right, so no reason to hold them back :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008
Hello, Steven, Sorry, I pushed my fixes before reading your e-mail :( On Sat, 2011-02-12 at 20:54 +1000, Steven Butler wrote: I didn't want to break anything so I took an easy out and made it mutable but I would think it would be better fixed by using const_cast wherever a non-const iterator is created. I think I came with a solution that does not need casts. Use const_iterators whenever a non const ones are not needed. It compiles and the unit tests run. unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n - my reference says it returns void but the original code was expecting an iterator returned. I imagine it must be an STLport extension, but it is broken with the built in STL and I believe the fix is correct. I took your fix, because my fix from last night was flawed, thanks for it. Thanks for your precious work. BTW, do the smoketests run for you? Here they run, but there is a crash on exit :( Cheers Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] O(U)StringBuffer::toString()
Hi list, Since the toString() method is mentioned in the O*StringBuffer documentation I thought it was a good idea to actually have it... Patch is splitted in two parts. First adds the toString() methods and second perform some cleanup in OUStringBuffer unit tests (see commit message for details). Regards Sebastien From 2f494284de6acdbb4fdd63dfb7c36854b263c556 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org Date: Sat, 12 Feb 2011 14:48:08 +0100 Subject: [PATCH 1/2] Added toString() method to O(U)StringBuffer. --- sal/inc/rtl/strbuf.hxx |5 + sal/inc/rtl/ustrbuf.hxx |6 ++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/sal/inc/rtl/strbuf.hxx b/sal/inc/rtl/strbuf.hxx index 9a78044..21ff603 100644 --- a/sal/inc/rtl/strbuf.hxx +++ b/sal/inc/rtl/strbuf.hxx @@ -275,6 +275,11 @@ public: */ const sal_Char* getStr() const { return pData-buffer; } +/** +Return a OString instance reflecting the current content +of this OStringBuffer. + */ +const OString toString() const { return OString(pData-buffer); } /** The character at the specified index of this string buffer is set diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx index 4977aac..b6160cc 100644 --- a/sal/inc/rtl/ustrbuf.hxx +++ b/sal/inc/rtl/ustrbuf.hxx @@ -274,6 +274,12 @@ public: */ const sal_Unicode* getStr() const { return pData-buffer; } +/** +Return a OUString instance reflecting the current content +of this OUStringBuffer. + */ +const OUString toString() const { return OUString(pData-buffer); } + /** The character at the specified index of this string buffer is set -- 1.7.2.3 From 1479dccd0ced9093937d50cae06c4abc10404cf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org Date: Sat, 12 Feb 2011 14:48:56 +0100 Subject: [PATCH 2/2] Unit test cleanup for OUStringBuffer. Moved OUStringBuffer related tests from qa/srt/strings to qa/rt/oustringbuffer and reactivated it in project build. It seems that rtl_OUStringBuffer2.cxx was replaced by test_oustringbuffer_utf32.cxx so the later has been removed. Added unit tests for toString. --- sal/prj/build.lst |1 + sal/qa/rtl/oustringbuffer/makefile.mk | 49 +++- sal/qa/rtl/oustringbuffer/rtl_OUStringBuffer2.cxx | 103 --- .../test_oustringbuffer_noadditional.cxx | 36 + .../test_oustringbuffer_tostring.cxx | 64 + .../oustringbuffer/test_oustringbuffer_utf32.cxx | 136 sal/qa/rtl/strings/makefile.mk |1 - sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx | 136 8 files changed, 254 insertions(+), 272 deletions(-) delete mode 100644 sal/qa/rtl/oustringbuffer/rtl_OUStringBuffer2.cxx create mode 100644 sal/qa/rtl/oustringbuffer/test_oustringbuffer_noadditional.cxx create mode 100644 sal/qa/rtl/oustringbuffer/test_oustringbuffer_tostring.cxx create mode 100644 sal/qa/rtl/oustringbuffer/test_oustringbuffer_utf32.cxx delete mode 100644 sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx diff --git a/sal/prj/build.lst b/sal/prj/build.lst index 0d53b82..1b38581 100644 --- a/sal/prj/build.lst +++ b/sal/prj/build.lst @@ -22,3 +22,4 @@ sa sal\qa\osl\file nmake - u sa_qa_osl_file sa_cppunittester sa_util NULL sa sal\qa\osl\module nmake - u sa_qa_osl_module sa_cppunittester sa_util NULL sa sal\qa\osl\condition nmake - all sa_qa_osl_condition sa_cppunittester sa_util NULL sa sal\qa\rtl\strings nmake - all sa_qa_rt_strings sa_cppunittester sa_util NULL +sa sal\qa\rtl\oustringbuffer nmake - all sa_qa_rt_oustringbuffer sa_cppunittester sa_util NULL diff --git a/sal/qa/rtl/oustringbuffer/makefile.mk b/sal/qa/rtl/oustringbuffer/makefile.mk index 544f7b7..9165daa 100644 --- a/sal/qa/rtl/oustringbuffer/makefile.mk +++ b/sal/qa/rtl/oustringbuffer/makefile.mk @@ -25,46 +25,31 @@ # #* -PRJ=..$/..$/.. -INCPRE+= $(PRJ)$/qa$/inc +PRJ := ..$/..$/.. +PRJNAME := sal -PRJNAME=sal -TARGET=rtl_oustringbuffer2 +TARGET := qa_rtl_oustringbuffer -ENABLE_EXCEPTIONS=TRUE +ENABLE_EXCEPTIONS := TRUE -# --- Settings - +.INCLUDE: settings.mk -.INCLUDE : settings.mk CFLAGS+= $(LFS_CFLAGS) CXXFLAGS+= $(LFS_CFLAGS) CFLAGSCXX += $(CPPUNIT_CFLAGS) -# BEGIN -# auto generated Target:joblist by codegen.pl -SHL1OBJS= \ -$(SLO)$/rtl_OUStringBuffer2.obj - -SHL1TARGET= rtl_OUStringBuffer2 -SHL1STDLIBS= $(SALLIB) $(CPPUNITLIB) $(TESTSHL2LIB) - -SHL1IMPLIB= i$(SHL1TARGET) -# SHL1DEF=$(MISC)$/$(SHL1TARGET).def - -DEF1NAME=$(SHL1TARGET) -# DEF1EXPORTFILE= export.exp -SHL1VERSIONMAP=
[Libreoffice] [Patch] Export object's title and description as alternate content
Hi, Here is a patch to make SVG filter export object's title and description as alternate content i.e. title and description element. http://www.w3.org/TR/SVG/struct.html#DescriptionAndTitleElements Currently the filter uses fixed texts such as Drawing and Graphic as alternate content. However they doesn't provide meaningful information. # It is obvious that contents of a SVG file are Drawing or Graphic. LibreOffice stores title and description for each object, we can use it. Actually they are stored as svg:title and svg:description in ODF. Fixed text is information about class of a shape. Thus use them as class attribute. The patch is under LGPLv3/MPL. Cheers, -- Kurosawa Takeshi taken@gmail.com From 11646f45021f9343bd33f11442306de6ce3e8b07 Mon Sep 17 00:00:00 2001 From: Kurosawa Takeshi taken@gmail.com Date: Sat, 12 Feb 2011 13:26:35 +0900 Subject: [PATCH] Export object's title and description as alternate content Actually they are stored as svg:title and svg:description in ODF. Fixed text such as Drawing and Graphic is information about class of a shape. Thus use them as class attribute. --- filter/source/svg/svgexport.cxx | 45 +- filter/source/svg/svgfilter.hxx |2 +- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index bc8bea7..a1e9086 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -510,26 +510,25 @@ sal_Bool SVGFilter::implExportPages( const Reference XDrawPages rxPages, mpSVGExport-AddAttribute( XML_NAMESPACE_NONE, id, implGetValidIDFromInterface( xShapes ) ); { -SvXMLElementExport aExp( *mpSVGExport, XML_NAMESPACE_NONE, g, TRUE, TRUE ); -const Point aNullPt; - { Reference XExtendedDocumentHandler xExtDocHandler( mpSVGExport-GetDocHandler(), UNO_QUERY ); if( xExtDocHandler.is() ) { -SvXMLElementExport aExp2( *mpSVGExport, XML_NAMESPACE_NONE, desc, TRUE, TRUE ); -OUString aDesc; +OUString aDesc; if( bMaster ) -aDesc = B2UCONST( Master slide ); +aDesc = B2UCONST( Master_Slide ); else aDesc = B2UCONST( Slide ); -xExtDocHandler-unknown( aDesc ); +mpSVGExport-AddAttribute( XML_NAMESPACE_NONE, class, aDesc ); } } +SvXMLElementExport aExp( *mpSVGExport, XML_NAMESPACE_NONE, g, TRUE, TRUE ); +const PointaNullPt; + if( bMaster ) { const GDIMetaFile rMtf = (*mpObjects)[ xDrawPage ].GetRepresentation(); @@ -639,15 +638,9 @@ sal_Bool SVGFilter::implExportShape( const Reference XShape rxShape ) if( xShapes.is() ) { +mpSVGExport-AddAttribute( XML_NAMESPACE_NONE, class, B2UCONST( Group ) ); SvXMLElementExport aExp( *mpSVGExport, XML_NAMESPACE_NONE, g, TRUE, TRUE ); -{ -SvXMLElementExport aExp2( *mpSVGExport, XML_NAMESPACE_NONE, desc, TRUE, TRUE ); -Reference XExtendedDocumentHandler xExtDocHandler( mpSVGExport-GetDocHandler(), UNO_QUERY ); - -xExtDocHandler-unknown( B2UCONST( Group ) ); -} - bRet = implExportShapes( xShapes ); } } @@ -663,13 +656,25 @@ sal_Bool SVGFilter::implExportShape( const Reference XShape rxShape ) const Size aSize( aBoundRect.Width, aBoundRect.Height ); { +mpSVGExport-AddAttribute( XML_NAMESPACE_NONE, class, implGetClassFromShape( rxShape ) ); SvXMLElementExport aExp( *mpSVGExport, XML_NAMESPACE_NONE, g, TRUE, TRUE ); +Reference XExtendedDocumentHandler xExtDocHandler( mpSVGExport-GetDocHandler(), UNO_QUERY ); + +OUString aTitle; +xShapePropSet-getPropertyValue( B2UCONST( Title ) ) = aTitle; +if( aTitle.getLength() ) { -SvXMLElementExport aExp2( *mpSVGExport, XML_NAMESPACE_NONE, desc, TRUE, TRUE ); -Reference XExtendedDocumentHandler xExtDocHandler( mpSVGExport-GetDocHandler(), UNO_QUERY ); +SvXMLElementExport aExp2( *mpSVGExport, XML_NAMESPACE_NONE, title, TRUE, TRUE ); +xExtDocHandler-characters( aTitle ); +} -
Re: [Libreoffice] Reusing the GLib mainloop from GTK/GNOME integration
* Alberto Ruiz alberto.r...@codethink.co.uk schrieb: Well, I intend to create a DBus service, as long as I get to that point I'll see how it behaves (the g_idle_add was just a test to check if the glib mainloop was usable). What exactly do you want that utterly complex and conceptionally backwards think, many other people are working at getting rid of ? (just ask the question why kernels use filesystem interfaces instead of those rpc stuff ?) If you just want to access certain objects or send commands remotely, you could use 9P - simple, tiny and very effective. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Improvement LibreOffice
* Andrés Domínguez andres...@gmail.com schrieb: Have you tried Scribus and LaTex? I have never used Scribus, but looks a good publishing program. LaTex is very good at mathematical and technical texts. LaTeX is quite good at typesetting any kind of large or (partially) autogenerated documents, which have to follow certain rules (IOW: not doing individual formattings, positionings, etc by hand but having that computed automatically - so the opposite of typical publisher applications). Both things IMHO would be really fine to have, but probably there're too many infrastructual problems to solve. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy hack: remove obsolete gjc aot compilation
Hi, I've removed gjc aot from the build system. I grep'd for occurances inside other repos, but it doesn't match anything. Looks like this is all. LibO builds an runs fine on Linux. Thomas From a67a2555a34b07babfc809e7d58e9ee6c8f3 Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Sat, 12 Feb 2011 11:58:01 +0100 Subject: [PATCH] Easy hack: remove obsolete gjc aot compilation --- configure.cmd |2 +- configure.in | 39 --- set_soenv.in |1 - 3 files changed, 1 insertions(+), 41 deletions(-) diff --git a/configure.cmd b/configure.cmd index aff7e81..dfdc0b6 100755 --- a/configure.cmd +++ b/configure.cmd @@ -3,5 +3,5 @@ setlocal SET MY_ANT_HOME=e:/java150/apache-ant-1.7.0 SET JAVA_HOME=e:\java150 SET PATH=%JAVA_HOME%\bin;%PATH%;%MY_ANT_HOME%\bin; -sh -c configure --with-system-openssl --with-system-icu --with-system-libxml --with-system-libxslt --disable-werror --with-use-shell=bash --disable-mozilla --disable-epm --disable-odk --disable-qadevooo --with-x=no --disable-fontconfig --disable-gnome-vfs --disable-gtk --with-java=yes --disable-gcjaot --without-nas --without-fonts --with-ant-home=%MY_ANT_HOME% | tee configure.log +sh -c configure --with-system-openssl --with-system-icu --with-system-libxml --with-system-libxslt --disable-werror --with-use-shell=bash --disable-mozilla --disable-epm --disable-odk --disable-qadevooo --with-x=no --disable-fontconfig --disable-gnome-vfs --disable-gtk --with-java=yes --without-nas --without-fonts --with-ant-home=%MY_ANT_HOME% | tee configure.log endlocal diff --git a/configure.in b/configure.in index 0e1df63..45a22cd 100755 --- a/configure.in +++ b/configure.in @@ -397,13 +397,6 @@ AC_ARG_ENABLE(Xaw, [Disables the use of Xaw for the Netscape/Mozilla plugin.]), ,) -AC_ARG_ENABLE(gcjaot, -AS_HELP_STRING([--enable-gcjaot], -[Build with[[out]] using Ahead of Time java compilation support to speed - up buildsi by compiling the jars also to native code.. --enable-gcjaot - is only known to work with bytecode created with gcj or ecj.]), -,) - AC_ARG_ENABLE(check-only, AS_HELP_STRING([--enable-check-only], [Use this option option if you just want to check your environment. @@ -3548,37 +3541,6 @@ if test $SOLAR_JAVA != ; then AC_SUBST(AWTLIB) fi -dnl === -dnl Check for optional gcj for AOT -dnl === -if test $SOLAR_JAVA != ; then - AC_MSG_CHECKING([whether to enable gcj aot compilation]) - if test -n $enable_gcjaot test $enable_gcjaot != no; then - AC_MSG_RESULT([yes]) - if test `echo $WITH_JAVA | grep -c gij` -eq 0; then -gcjaot=gcj - else -gcjaot=`echo $WITH_JAVA | $SED -e s/gij/gcj/g` - fi - AC_MSG_RESULT([$gcjaot]) - if test -n $with_jdk_home; then -_javac_path=$with_jdk_home/bin/$gcjaot -dnl Check if there is a gcj at all. -if test -x $_javac_path; then - JAVAAOTCOMPILER=$_javac_path -fi - fi - if test -z $JAVAAOTCOMPILER; then -AC_PATH_PROG(JAVAAOTCOMPILER, $gcjaot) - fi - if test -z $JAVAAOTCOMPILER; then -AC_MSG_WARN([$gcjaot not found, set with_jdk_home]) - fi - else - AC_MSG_RESULT([no]) - fi -fi - AC_SUBST(JAVA_HOME) AC_SUBST(JDK) AC_SUBST(JAVAFLAGS) @@ -3587,7 +3549,6 @@ AC_SUBST(JAVA_TARGET_VER) AC_SUBST(JAVAINTERPRETER) AC_SUBST(JAVAIFLAGS) AC_SUBST(JAVACOMPILER) -AC_SUBST(JAVAAOTCOMPILER) AC_SUBST(JAVADOC) dnl === diff --git a/set_soenv.in b/set_soenv.in index 450f9fa..c914259 100755 --- a/set_soenv.in +++ b/set_soenv.in @@ -1786,7 +1786,6 @@ if ( '@JDK@' ne '' ) ToFile( JAVAINTERPRETER, PathFormat(@JAVAINTERPRETER@), e ); ToFile( JAVAIFLAGS, @JAVAIFLAGS@,e ); ToFile( JAVACOMPILER,PathFormat(@JAVACOMPILER@), e ); - ToFile( JAVAAOTCOMPILER, PathFormat(@JAVAAOTCOMPILER@), e ); ToFile( JAVADOC, PathFormat(@JAVADOC@), e ); } ToFile( SCPDEFS, '@SCPDEFS@',e ); -- 1.7.3.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-l10n] A possible future for LO help/lang packs?
* Michael Meeks michael.me...@novell.com schrieb: Hi folks, snip don't know how things are handled currently, but but for locale stuff, gettext is a very fine tool. KISS and effective. Help files can be easily put into some proper directory hierachy with the locale identifier as subdir name (eg. on an FHS installation it would be something like $DATADIR/doc/lo/locale/...) cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
* Norbert Thiebaud nthieb...@gmail.com schrieb: big_snip / Just wondering: do you want to bisect the whole bundle of trees at once or just single packages ? cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Segfault in regcomp while creating registry
Hi folks, big_snip / could someone please help me to understand what that registry is all about ? The term reminds me to the Windows registry, which essentially is a poor-man's ldap (w/o schemata) and nothing a simple filesystem can't do ;-o cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] More dead code in xmerge
Deleted some more commented-out code in xmerge. code is contributed under the LGPLv3+ / MPL. Luke patchfile Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Dead Java code
Deleted some more commented-out code in xmerge. Code is contributed under the LGPLv3+ / MPL. Luke patchfile Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy hack: more commented out code
First patch deletes two commented lines out and removes four bogus comments. The second patch deletes some commented out returns. Code is contributed under the LGPLv3+ / MPL. Luke patchfile Description: Binary data patchfile2 Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
Hi, On Sat, Feb 12, 2011 at 7:45 PM, Michael Meeks michael.me...@novell.com wrote: Since there is not much difference between GDK_HAND1 and GDK_HAND2 and GDK_HAND1 is not commonly used, we should use GDK_HAND2 for both POINTER_REFHAND and POINTER_HAND. It would be interesting to know how POINTER_HAND and POINTER_REFHAND are used around the LibreOffice code ? I created an wiki page for that (currently POINTER_HAND only). http://wiki.documentfoundation.org/User:Taken/Cursor_Usage I found 7 code paths which uses POINTER_HAND by OpenGrok. In my opinion they are not related to hyperlinks. Additionally some usage could be replaced by other cursors (e.g. panning and editing control point). Anyway more investigations needed. Cheers, -- Kurosawa Takeshi taken@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Dead Java code
Hi Luke, thanks for that. But could you please use git format-patch for the next patches? Would be easier. Thanks for the patch! Thomas On 02/12/2011 06:15 PM, L P wrote: Deleted some more commented-out code in xmerge. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Easy hack: more commented out code
Hi Luke, I applied patchfile one only partially. These @param and @autor tags are important for javadoc. Thanks! Thomas On 02/12/2011 06:36 PM, Luke Petrolekas wrote: First patch deletes two commented lines out and removes four bogus comments. The second patch deletes some commented out returns. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Easy hack: more commented out code
Pushed. On 02/12/2011 06:57 PM, Thomas Arnhold wrote: Hi Luke, I applied patchfile one only partially. These @param and @autor tags are important for javadoc. Thanks! Thomas On 02/12/2011 06:36 PM, Luke Petrolekas wrote: First patch deletes two commented lines out and removes four bogus comments. The second patch deletes some commented out returns. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] More dead code in xmerge
This one got obsolete by one of your other patches. Thomas On 02/12/2011 05:56 PM, L P wrote: Deleted some more commented-out code in xmerge. code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] cui pre-compiled headers
While removing some extra references to bootstrp/sstring.hxx, I noticed that the precompiled_cui.hxx file is just one big #if 0 ... #endif statement. I see two ways of fixing this: 1) Remove the #if 0 and see what breaks and then look at removing extra #include from the other files. 2) Remove the #include precompiled_cui.hxx from all the other source files. I'm more of the option of doing option #2 since it requires the least amount of work (only about 60 files include the header) and we haven't been using the precompiled header anyways. I just wanted to put this up to a vote before just ripping out the file. Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008
Hi Fridrich, On Sat, 2011-02-12 at 20:54 +1000, Steven Butler wrote: unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n Thanks for your precious work. BTW, do the smoketests run for you? Here they run, but there is a crash on exit :( I had to disable some unit tests to get through the build as cppunittester was crashing on exit. I'm not used to dev on windows so I couldn't figure out how to get any trace out of the crash. It may have been a crash on exit because after I sent off my mail I found my build of libreoffice crashes in every application when you quit, but otherwise appears stable in use - I mainly focused on the areas I had patched in sw with the document list heading and numbering levels and didn't actually quit it until I'd sent off the patches. I didn't run the make check target. My main goal over the past 2 weeks was just to get a windows build to build. Regards Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [tdf-announce] LibreOffice 3.3.1 Release Candidate available
Hi, Thorsten Behrens wrote (11-02-11 11:53) The Document Foundation is happy to announce the release candidate of LibreOffice 3.3.1. This release candidate is the first in a series of Thanks, but as written also by others, there are no debs for x86. Cor -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Segmentation faults in unit tests
LibreOffice builds now run for almost 3 hours before failing on DragonFly. The errors are always of the same sort: some kind of segmentation fault with an unit test : Entering /home/ftigeot/Projects/LibreOffice/bootstrap/cui/source/options Making:all_options.dpslo Making:options.dpr Making:options.options.dprr /usr/pkg/bin/bash: line 1: 40124 Segmentation fault: 11 (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/unxdflyx3.pro/lib:/home/ftigeot/Projects/LibreOffice/bootstrap/solver/330/unxdflyx3.pro/lib /home/ftigeot/Projects/LibreOffice/bootstrap/solver/330/unxdflyx3.pro/bin/cppunittester ../../unxdflyx3.pro/lib/libtest_starmath.so -headless -invisible -env:UNO_SERVICES=file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.pro/misc/qa_cppunit/services.rdb -env:UNO_TYPES=file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.pro/misc/qa_cppunit/types.rdb file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.pro/misc/qa_cppunit/udkapi.rdb -env:OOO_BASE_DIR=file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.p ro/misc/qa_cppunit -env:BRAND_BASE_DIR=file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.pro/misc/qa_cppunit -env:UNO_USER_PACKAGES_CACHE=file:///home/ftigeot/Projects/LibreOffice/bootstrap/clone/writer/starmath/qa/cppunit/../../unxdflyx3.pro/misc/qa_cppunit dmake: Error code 139, while making 'test' When running cppunittester by hand, I also get these messages: terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException' [1]15465 abort (core dumped) LD_LIBRARY_PATH= ../../unxdflyx3.pro/lib/libswdoctest.so -headless -invisibl -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] duplicate code (binfilter)
Hi, I've fixed some wrong spelling menues - menus in binfilter/bf_svtools/source/config/svt_menuoptions.cxx and svtools/source/config/menuoptions.cxx svt_menuoptions.cxx seems to be a subset of menuoptions.cxx (apart from #include itemholder1.hxx and #include itemholder2.hxx). And it looks like development of menuoptions.cxx is going on. Will svt_menuoptions.cxx be replaced by menuoptions.cxx some day? Or is this documented already in the wiki? Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] cui pre-compiled headers
I noticed that the precompiled_cui.hxx file is just one big #if 0 ... #endif statement. That should not matter because even if you drop the #if 0 ane corresponding #endif, it is still surrounded by #ifdef PRECOMPILED_HEADERS ... #endif, and that is not true either. I.e., we don't use pre-compiled headers, and the pre-compiled_cui.hxx header is effectively bypassed completely anyway. Should we use pre-compiled headers? Maybe, in an ideal world, as it is said to speed up compilation on Windows a lot. Did somebody think we were using them? No idea. At least I had never thought that we did, even if I knew that some such mechanism was used by Sun/Oracle, at least at some point, maybe even currently. (Note that there are clear signs in most source files that some mysterious pre-compiled-header related magic can be used: The // MARKER(update_precomp.py): autogen include statement, do not remove comments. Plus of course the */inc/pch/precompiled_*.* files.) Just on Friday there was discussion on this in the IRC channel. I think Windows is the only platform where pre-compiled headers theoretically would be possible and make sense? If I understood correctly, using pre-compiled headers successfully is quite complex and hard, and as we haven't been using them so far, we presumably have in fact been doing changes to the sources without taking the appropriate care one apparently should if using pre-compiled headers. To summarize: No, we don't use pre-compiled headers. Using them would speed up compilation on Windows, but my impression is that using them correctly and effectively would require a much heavier process than we want to be burdened with. Especially as most of our contributors are on Linux or other Unixes and don't want to be delayed by obscure Windows considerations. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...
Jesus - it'd be wonderful if you could do a test of that (?) otherwise, other reviews appreciated. I have tested the patch using the following up-to-date build of the master branch with the patch applied: http://dl.dropbox.com/u/193133/LibO_3.3.0rc4_Win_x86_install_en-US.exe And it works fine for me. So it's a +1 for me. (btw, there's a crash when you play with the fonts menu a bit) -- Jesús Corrius je...@softcatala.org Document Foundation founding member Mobile: +34 661 11 38 26 Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH][PUSHED 4/54] translated comments
Hi, pushed 5 more diffs. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote: what the heck do we do with Tools - Media Player? Do we need this within an office suite? Is anyone using this?! :-) My suspicion is that ~no-one is using it. Without adding too many thoughts, here is the corresponding thread with some answers and the original specification (linked). Maybe this helps The link to the spec. is: http://specs.openoffice.org/appwide/media_player/MediaPlayer.sxw Which (on reading) suggests to me that the only useful uses of this beastie is two fold: a) to allow playback controls to appear / be used when playing + presuambly we can / should do this for embedded media anyway in some suitably tasteful way. b) to allow video files to be previewed from the gallery + cf. the difficulty of building galleries, and the fact that I've never seen any video in one + cf. the fact that I just failed to add an mgp or ogg to a gallery, via the properties dialog. So - I think b) is fairly bogus (or the gallery addition code needs some real work), a) is a real use-case; it seems we throw up the media player for preview sounds in the shipped gallery. So - IMHO the player-let is useful, but I'd be amazed if people really used it in anger; it is rather lame. Removing it from the menus in everything but impress might make some sense (?) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments
Hi, thanks, looks nice! Pushed it! Thomas On 02/12/2011 09:12 PM, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove Xine
Hi, looks nice! I've build and run it without any problems. And I didn't find any references, too. Thomas On 02/12/2011 06:07 PM, Julien Nabet wrote: Hello, Here is a patch to remove xine. I didn't want to push it myself cause perhaps it needs to be reviewed. I just removed unxlng directory from avmedia, then I recompiled, it was ok. I also did a git grep xine, I didn't found anything else. Must I do a full compil ? Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] RC1 PreRelease missing 32bit debs
No response on user, discuss, or mirror lists, so I'll ask here. Where are the 32bit .debs for 3.3.1 RC1? RC1 PreRelease missing 32bit debs http://www.libreoffice.org/download/pre-releases/ 64bit .debs are there, but not the 32bit .debs. Clicking on 'Linux x86 (deb) results in: null Also checking: http://download.documentfoundation.org/libreoffice/testing/3.3.1-rc1/deb/ http://download.documentfoundation.org/libreoffice/testing/3.3.1-rc1/deb/x86/ only shows .asc files. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour
Kohei, The behaviour that I am talking about is... 1. Insert value into A1, select the cell with the mouse so it is highlighted then copy with Ctrl-C 2. Select 3 or more other cells -- NOT in a continuous block (e.g. B2 and C3). 3. Try and paste with Ctrl-V and you will get the error Insert into multiple selection not possible I checked and this functionality has been available since Excel 2000. Cheers Simon Simon Cropper Principal Consultant Botanicus Australia Pty Ltd PO Box 160, Sunshine, VIC W: www.botanicusaustralia.com.au On 12/02/11 18:33, Kohei Yoshida wrote: On Tue, 2011-02-08 at 11:13 +0700, Nguyen Vu Hung wrote: On Tue, Feb 8, 2011 at 11:05 AM, Kohei Yoshidakyosh...@novell.com wrote: On Mon, 2011-02-07 at 02:29 +0700, Nguyen Vu Hung wrote: m$ excel allows content in cells a1, a3, a5 to be selected and copied to a7, a9, a11. This is not possible in calc. A feature request please. Actually in Excel when you copy A1, A3, A5 then paste to A7, it pastes to A7:A9. Calc does the same thing. So, I'm not sure what feature is being requested here. Can you clarify a bit? Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008
Hello, Steven On 12/02/11 23:46, Steven Butler wrote: I had to disable some unit tests to get through the build as cppunittester was crashing on exit. Eh ;) The purpose of unit tests is to catch problems early :) If cppunittester crashes, it means that the unit test is not passing :) But never mind. Here I did not disable them and the from scratch build passed too. Although, I used to have those crashes too in tools. I didn't run the make check target. My main goal over the past 2 weeks was just to get a windows build to build. Fair enough. Here, after a from scratch rebuild, the smoketests hang on exit. As they were since some months. But this is 64-bit Windows Server 2008 R2. Let me try to do the same on a 32-bit system. Thanks for your work. I appreciate, because I know how huge it is to build this thing on windows :) Cheers F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice