[Libreoffice] [EasyHacks] Protocol capitalization
Hi list,
Here are two patch regarding the Easy Hack Improve Autocorrect
capitalize first word in sentence (on the wiki).
First one improves french autocorrection for non breaking space
before : when you enter a protocol. I didn't remove the code
handling the :// case since INETUrlObject does not contains ftps://,
imaps:// and other protocols. I could modify INETUrlObject if needed to
handle these and get ride of this special case.
Second one prevents capitalisation of recognized protocole (e.g. http:
will never be replaced by Http: even at the beginning of a sentence).
Awaiting your comments
Sebastien
From f3b0ae7733ee0229b960c779ab7a381a6ea28755 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org
Date: Mon, 21 Feb 2011 00:38:25 +0100
Subject: [PATCH 1/2] Better protocols handling in french autocorrect
---
editeng/source/misc/svxacorr.cxx | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index ed14c46..0c08373 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -654,8 +654,14 @@ BOOL SvxAutoCorrect::FnAddNonBrkSpace(
{
// Get the last word delimiter position
xub_StrLen nSttWdPos = nEndPos;
-while( nSttWdPos !IsWordDelim( rTxt.GetChar( --nSttWdPos )))
+bool bWasWordDelim = false;
+while( nSttWdPos !(bWasWordDelim = IsWordDelim( rTxt.GetChar( --nSttWdPos
;
+
+if(INetURLObject::CompareProtocolScheme(rTxt.Copy(nSttWdPos + (bWasWordDelim ? 1 : 0), nEndPos - nSttWdPos + 1)) != INET_PROT_NOT_VALID) {
+return FALSE;
+}
+
// Check the presence of :// in the word
xub_StrLen nStrPos = rTxt.Search( String::CreateFromAscii( :// ), nSttWdPos + 1 );
@@ -791,11 +797,11 @@ BOOL SvxAutoCorrect::FnCptlSttSntnc( SvxAutoCorrDoc rDoc,
xub_StrLen nSttPos, xub_StrLen nEndPos,
LanguageType eLang )
{
-// Two capital letters at the beginning of a paragraph?
+
if( !rTxt.Len() || nEndPos = nSttPos )
return FALSE;
- CharClass rCC = GetCharClass( eLang );
+CharClass rCC = GetCharClass( eLang );
String aText( rTxt );
const sal_Unicode *pStart = aText.GetBuffer(),
*pStr = pStart + nEndPos,
--
1.7.2.3
From 8f7798219b3c6e9510cf6672f7eeacd2d4feea2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org
Date: Mon, 21 Feb 2011 08:44:51 +0100
Subject: [PATCH 2/2] Disable protocols capitalization
---
editeng/source/misc/svxacorr.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 0c08373..70c9728 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -836,7 +836,6 @@ BOOL SvxAutoCorrect::FnCptlSttSntnc( SvxAutoCorrDoc rDoc,
}
} while( 0 == ( bAtStart = (pStart == pStr)) );
-
if( !pWordStt ||
rCC.isDigit(
aText, sal::static_int_cast xub_StrLen ( pStr - pStart ) ) ||
@@ -844,6 +843,7 @@ BOOL SvxAutoCorrect::FnCptlSttSntnc( SvxAutoCorrDoc rDoc,
rCC.getCharacterType(
aText,
sal::static_int_cast xub_StrLen ( pWordStt - pStart ) ) ) ||
+INetURLObject::CompareProtocolScheme(rTxt.Copy(pWordStt - pStart, pDelim - pWordStt + 1)) != INET_PROT_NOT_VALID ||
0x1 == *pWordStt || 0x2 == *pWordStt )
return FALSE; // no character to be replaced, or already ok
--
1.7.2.3
signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED] Translate german comments
Am 21.02.2011 00:20, schrieb Martin Kepplinger: This translates the german code-comments of swmodule.cxx to english. Pushed - thank you for your contribution. Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH][PUSHED] Translate german comments
Am 21.02.2011 00:20, schrieb Martin Kepplinger: This translates the german code-comments of file swmodul1.cxx to english. Pushed - thank you for your contribution. Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED] Translate code-comments
Am 21.02.2011 00:20, schrieb Martin Kepplinger: This translates the code-comments of the file docstyle.cxx from german to english. Pushed - thank you for your contribution. Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice very slow at startup on Debian Testing
Hi Rogerio, On Sat, 2011-02-19 at 22:44 -0200, Rogerio Luz Coelho wrote: A while back (RC1) I posted a bug: https://bugs.freedesktop.org/show_bug.cgi?id=32640 Ooh - nice bug report :-) And still haven´t heard any solution. It is still present with 3.3.0 official release. Just commented on it; we get a rash of these dumb reverse DNS problems - which at root are probably a system mis-configuration so you can't reverse lookup the hostname - *but* please don't fix that first - can you get the stack trace I asked for in the bug ? and we can fix it. Then can you do: time dig -x `hostname` Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Windows installer size reduction effort - the compression theory
Hi Kalman, On Sun, 2011-02-20 at 15:15 +0100, Kálmán „KAMI” Szalai wrote: I am sure we can shrink the installer more with better compression Hah - so, of course Fridrich and Tor have looked into this - and naturally you are right :-) there is a lot we can do. Clearly compressing things badly first, and then well later (eg. zip, then lzma) doesn't give the best results. That is particularly so when there are lots of similarities in the eg. un-compressed ODF files we have internally for eg. templates but minor differences that will have hard-to-compress knock-on-effects in the compressed stream. The ideal would be to use only one level of compression - using the best algorithm (LZMA) ie. NSIS, and nothing in the .cab file (which is limited to various lame algorithms, and perhaps per-contained-file compression, rather than per-whole-cab-file). Unfortunately, with the currently level of eg. template duplication, this would give us a vast .cab file that would chew lots of space on the target machine - though it might shrink our download nicely :-) What is your opinion? Can somebody test it on a real Windows build system? The current balance is based on testing; quite possibly there is a better set of compression options - but we need to work out what it is. Our current settings are optimised for a multi-lang install as we ship it. To change that I'd like to see a table: New options Download/kb Install/kb with the relevant sizes of both of these guys. That is just a matter of running lots of long builds and comparing the output I guess, and I suspect we will get something like a trade-off between these two values. Clearly, the 'real' solution is engineering to stop us having so much pointless duplication ;-) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED] [writer/sw/source/ui/app] Translate comments of docshini
Am 21.02.2011 00:20, schrieb Martin Kepplinger: This translates the code-comments of docshini.cxx from german to english. Pushed - thank you for your contribution. Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Old icons back on Mac ?
Hi Alex, On Sat, 2011-02-19 at 14:53 +0100, Alexander Thurgood wrote: Le 18/02/11 14:38, Alexander Thurgood a écrit : Is it just me, or have the new icons disappeared from the install sets and been reverted back to the old ones we had with 3.3.0 ? The download installation set for Mac OSX 3.3.1 RC2 does indeed have the old icons. Screenshots appreciated; and/or specificity around whether you mean the icon theme (ie. what is shown in the toolbars etc.) or the document association icons ? :-) Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] It's not a dev topic, but please read it.
Hi Kayo, On Thu, 2011-02-17 at 23:56 -0200, kayo.ha...@gekkolinux.com.br wrote: We have, in Brazil, one institute without funds that work to .. But after some things happended, $, this guys want to command and conquer the community, us, and not help us anymore. So - whatever the rights and wrongs of this issue - and I suspect poor communication is near the root of it all; there should clearly be no barrier to -anyone- contributing to LibreOffice. ie. we accept code changes, translations, artwork etc. based not on the language, color of skin, creed, odd views of author, corporate affiliation or not etc. etc. - but purely on merit. So :-) hopefully there should be no barrier to your continued concrete contributions getting included, and I look forward to reviewing them. Having said that - this is a developer list; and (given what I write above) this is emphatically not a developer issue - so please use the right list for this: ie. take it elsewhere - the 'discuss' list perhaps. As/when you have code, please bring it here :-) All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED] [writer/sw/source/ui/app] Translate comments of docsh2.cxx
Am 21.02.2011 00:20, schrieb Martin Kepplinger: This translates the code-comments in the file docsh2.cxx from german to english. Pushed - thank you for your contribution. Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] another cairo canvas regression
Radek Doulík wrote: I have fixed another regression in cairo canvas, same area as yesterday. The edge count was miscalculated as # of edges in polygon equals to # of points minus 1 and not to number of points. I would like to push it to libreoffice-3-3 branch - 1 review wanted. Looks good, cherry-picked to -3-3 -- Thorsten pgpuvsejw5PZg.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Help regarding build from source
Hey, I'm a computer science student and want to get into the libre office development. I went on to IRC # libre office channel for sometime and got help regarding the git repository cloning and have fetched the source code. Welcome on board! :-) I already have Libreoffice installed on my ubuntu 10.04 system using PPA; so if I try to buld it libre office from the source which I just fetched will it affect the existing installation of libre office. No, doesn't necessarily have to ... Do I need to remove the pre exesting libre office before I start building from source ? ... and no, not at all. You can have your own (development/debugging) instance of LibO running from the fetched source tree. Issuing 'make dev-install' after building with 'make' will create such instance for you, it will then live in /wherever/libo/source/tree/is/install/program/ B. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] external references with OFFSET function cause a crash
Hi Kohei,
I have encountered a crash of Calc (master branch built on my Debian box)
in a way related with a report at
http://listarchives.libreoffice.org/ja/discuss/msg00306.html
First, assume a simple spreadsheet saved as, say,
/home/tabe/20110221/x.ods
including a sheet 'Sheet1' in which cell $C$3 had value 'C3'.
Second, creating a new spreadsheet and insert
=OFFSET('file:///home/tabe/20110221/x.ods'#$Sheet1.$A$1,2,2)
at cell $A$1. It should looks like 'C3' and actually so.
But, third, inserting one more
=OFFSET('file:///home/tabe/20110221/x.ods'#$Sheet1.$A$1,2,2)
at cell $A$2 ended up with a crash.
gdb shows dereferencing a null pointer caused it as attached,
so I think the following barrier will deserve at least an option:
diff --git a/sc/source/ui/docshell/externalrefmgr.cxx
b/sc/source/ui/docshell/externalrefmgr.cxx
index 3483895..bb5b4d7 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -1636,7 +1636,7 @@ ScExternalRefCache::TokenRef
ScExternalRefManager::getSingleRefToken(
// Now, insert the token into cache table but don't cache empty cells.
if (pToken-GetType() != formula::svEmptyCell)
{
-sal_uInt32 nFmtIndex = pFmt-mbIsSet ? pFmt-mnIndex : 0;
+sal_uInt32 nFmtIndex = (pFmt pFmt-mbIsSet) ? pFmt-mnIndex : 0;
maRefCache.setCellData(nFileId, rTabName, rCell.Col(),
rCell.Row(), pToken, nFmtIndex);
}
Any thought?
Cheers,
-- Takeshi Abe
#0 0xadc3034c in ScExternalRefManager::getSingleRefToken (this=0xad4f4938,
nFileId=0, rTabName=..., rCell=...,
pCurPos=0x0, pTab=0xbfffa0de, pFmt=0x0)
at /home/tabe/libo/clone/calc/sc/source/ui/docshell/externalrefmgr.cxx:1639
#1 0xadfd2321 in lcl_ScAddress_Parse_OOo (p=0xaf68a8fa, pDoc=value optimized
out, rAddr=...,
pExtInfo=0xbfffa9c0, pRange=0x0) at
/home/tabe/libo/clone/calc/sc/source/core/tool/address.cxx:1128
#2 0xadfd338b in lcl_ScAddress_Parse (this=0xbfffa9c8, r=..., pDoc=0x0,
rDetails=..., pExtInfo=0xbfffa9c0,
pExternalLinks=0xbfffcc68) at
/home/tabe/libo/clone/calc/sc/source/core/tool/address.cxx:1198
#3 ScAddress::Parse (this=0xbfffa9c8, r=..., pDoc=0x0, rDetails=...,
pExtInfo=0xbfffa9c0,
pExternalLinks=0xbfffcc68) at
/home/tabe/libo/clone/calc/sc/source/core/tool/address.cxx:1276
#4 0xadffe2fd in ScCompiler::IsSingleReference (this=0xbfffcbf4, rName=...)
at /home/tabe/libo/clone/calc/sc/source/core/tool/compiler.cxx:2719
#5 0xadffe867 in ScCompiler::IsReference (this=0xbfffcbf4, rName=...)
at /home/tabe/libo/clone/calc/sc/source/core/tool/compiler.cxx:2811
#6 0xadfff343 in ScCompiler::NextNewToken (this=0xbfffcbf4, bInArray=false)
at /home/tabe/libo/clone/calc/sc/source/core/tool/compiler.cxx:3585
#7 0xadfffb23 in ScCompiler::CompileString (this=0xbfffcbf4, rFormula=...)
at /home/tabe/libo/clone/calc/sc/source/core/tool/compiler.cxx:3709
#8 0xadfa0a4e in ScFormulaCell::Compile (this=0xad3db0a0, rFormula=...,
bNoListening=1 '\001',
eGrammar=formula::FormulaGrammar::GRAM_NATIVE) at
/home/tabe/libo/clone/calc/sc/source/core/data/cell.cxx:938
#9 0xadfa1adc in ScFormulaCell (this=0xad3db0a0, pDoc=0xb0dd5048, rPos=...,
rFormula=...,
eGrammar=formula::FormulaGrammar::GRAM_NATIVE, cMatInd=0 '\000')
at /home/tabe/libo/clone/calc/sc/source/core/data/cell.cxx:683
#10 0xadfaad7b in ScColumn::SetString (this=0xad8aa020, nRow=0, nTabP=0,
rString=...,
eConv=formula::FormulaGrammar::CONV_OOO, pParam=0x0)
at /home/tabe/libo/clone/calc/sc/source/core/data/column3.cxx:1310
#11 0xadf94450 in ScTable::SetString (this=0xad8aa008, nCol=value optimized
out, nRow=0, nTabP=0, rString=...,
pParam=0x0) at /home/tabe/libo/clone/calc/sc/source/core/data/table2.cxx:997
#12 0xadf1b3e1 in ScDocument::SetString (this=0xb0dd5048, nCol=0, nRow=0,
nTab=8240, rString=..., pParam=0x0)
at /home/tabe/libo/clone/calc/sc/source/core/data/document.cxx:2745
#13 0xadc48580 in ScImportExport::Text2Doc (this=0xbfffe0f4, rStrm=...)
at /home/tabe/libo/clone/calc/sc/source/ui/docshell/impex.cxx:833
#14 0xadc486a6 in ScImportExport::ExtText2Doc (this=0xbfffe0f4, rStrm=...)
at /home/tabe/libo/clone/calc/sc/source/ui/docshell/impex.cxx:1138
#15 0xadc4ae78 in ScImportExport::ImportStream (this=0xbfffe0f4, rStrm=...,
rBaseURL=..., nFmt=1)
at /home/tabe/libo/clone/calc/sc/source/ui/docshell/impex.cxx:413
#16 0xadc4b01d in ScImportExport::ImportString (this=0xbfffe0f4, rText=...,
nFmt=1)
at /home/tabe/libo/clone/calc/sc/source/ui/docshell/impex.cxx:331
#17 0xadd1fd33 in ScViewFunc::PasteDataFormat (this=0xb12e9048, nFormatId=1,
rxTransferable=..., nPosX=1,
nPosY=0, pLogicPos=0x0, bLink=0 '\000', bAllowDialogs=1 '\001')
at /home/tabe/libo/clone/calc/sc/source/ui/view/viewfun5.cxx:367
#18 0xadd197a5 in ScViewFunc::PasteFromSystem (this=0xb12e9048, nFormatId=1,
bApi=0 '\000')
at /home/tabe/libo/clone/calc/sc/source/ui/view/viewfun3.cxx:835
#19 0xadd1a448
Re: [Libreoffice] Branch libreoffice-3-3-1 created
Hi Hanno, On 2011-02-19 at 11:27 +0100, Hanno Meyer-Thurow wrote: it looks like the following rules ... stabilization of the 3.3.1, called 'libreoffice-3-3-1'. It is not based The following rules apply: + any commit has to be reviewed by 3 people The 'libreoffice-3-3' branch is still active, will be used for the next + any commit needs review by 1 person should not be applied for distro-only related hacks in the libreoffice/build branches. Noone really cared about the patch I sent, although it is obviously safe - removing cruft. Sorry for being unclear in the announcement mail. Indeed, the 'build' repo is an exception, and the distro maintainers are free to commit whatever they need for their own distros, you only need to make sure you are not breaking the distros of others. At least Caolan merged it into master. And I want to squeeze out the remaining patches, so that all the Gentoo related patches will be gone or merged into master. Sounds great :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] external references with OFFSET function cause a crash
On Mon, 2011-02-21 at 22:47 +0900, Takeshi Abe wrote: Any thought? Try the latest master. This (the crasher) has already been fixed there. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Old icons back on Mac ?
Michael Meeks wrote: The download installation set for Mac OSX 3.3.1 RC2 does indeed have the old icons. Screenshots appreciated; and/or specificity around whether you mean the icon theme (ie. what is shown in the toolbars etc.) or the document association icons ? :-) Alex, could you please check which icon theme you're running? Preferences-General-View shows automatic for both icon size icon theme - maybe you're running off of an old config? Cheers, -- Thorsten pgpJeOexHckm8.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] external references with OFFSET function cause a crash
Hi Kohei, On Mon, 21 Feb 2011 09:52:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: Try the latest master. This (the crasher) has already been fixed there. hmm, do you mean 39647f4711af6a6d50ff58754004874ec42265ce ? Then we have to pay a bill for damn duplicate code, there seems be still one more around 61 lines above. Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH][PUSHED 4/54] translated comments
Hi, pushed 6 more... Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Old icons back on Mac ?
Le 21/02/11 10:51, Michael Meeks a écrit : Hi Michael, Screenshots appreciated; and/or specificity around whether you mean the icon theme (ie. what is shown in the toolbars etc.) or the document association icons ? :-) Errm, yes, sorry, I should've been clearer, it is the mimetype icons which are wrong, the ones that represent the various application modules and the icon that appears in the dock and during installation. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] external references with OFFSET function cause a crash
On Tue, 2011-02-22 at 00:14 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 21 Feb 2011 09:52:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: Try the latest master. This (the crasher) has already been fixed there. hmm, do you mean 39647f4711af6a6d50ff58754004874ec42265ce ? Then we have to pay a bill for damn duplicate code, there seems be still one more around 61 lines above. Ah, that one. Yes, we need to put the same fix there. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Old icons back on Mac ?
Le 21/02/11 16:06, Thorsten Behrens a écrit : Hi Thorsten, could you please check which icon theme you're running? Preferences-General-View shows automatic for both icon size icon theme - maybe you're running off of an old config? I am currently running Tango, but before I installed RC2, I renamed the Application Support/LibreOffice folder in my user directory. It is not the theme as such that is the problem, and I should've been more precise - it is the application mimetype icons, the ones associated with the various application modules, and even the app itself. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] external references with OFFSET function cause a crash
On Mon, 2011-02-21 at 10:26 -0500, Kohei Yoshida wrote: On Tue, 2011-02-22 at 00:14 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 21 Feb 2011 09:52:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: Try the latest master. This (the crasher) has already been fixed there. hmm, do you mean 39647f4711af6a6d50ff58754004874ec42265ce ? Then we have to pay a bill for damn duplicate code, there seems be still one more around 61 lines above. Ah, that one. Yes, we need to put the same fix there. Fixed on master. Thanks a lot. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] windows dll search order and cppunit
So, my understanding on reading http://msdn.microsoft.com/en-us/library/ms682586%28v=vs.85%29.aspx is that there isn't a way to skip/override searching first in The directory from which the application loaded. which I believe means that... PATH=/local/bin:/path/to/solver/bin /path/to/solver/bin/cppunit something will cause efforts by something to use LoadLibrary to actually search first in /path/to/solver/bin/ seeing as that's where cppunit physically lives, and not first in /local/bin for any .dll something might want to load subsequently. Which I reckon means that cppunit tests the old delivered .dll in those circumstances and not the local, just-built one. Which is where failures windows people see that non-windows people don't see are likely often coming from. Its a bit of a nuisance, anyone know a good workaround/fix. What comes to mind for me is to deliver cppunit not into the normal solver/bin dir, but into e.g. solver/bin/other or something so that it isn't in the same dir as the delivered .dlls and so will have to rely on PATH to find them, and so get the expected ones. Thoughts from the windows people ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Old icons back on Mac ?
Le 21/02/11 16:06, Thorsten Behrens a écrit : Hi all, I added screenshots of what I see when I install a fresh LibO 3.3.1 RC2 Mac to : https://bugs.freedesktop.org/show_bug.cgi?id=33229 Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SAAS, Oracle, SAP, Microsoft( Exchange , Dynamics etc), HR, Healthcare, Technology, Industry, ERP, CRM, VAR customer lists
Hi, This email is to introduce Repharm Technologies and lists we provide. We have a comprehensive business database of B2B records B2C records. Our lists can be used Email Campaigns, Telemarketing, Fax Marketing and Direct Mailing. The list would be for your perpetual use with no restriction on the number of usage. Below are some of our lists that may interest you, let me know if you require any other lists by providing the industry, job titles, etc. Technology Lists# of CompaniesIndustry Specific Lists# of CompaniesExecutive Lists# of Companies Baan2,000Agriculture10,100CEO/President200,000 Epicor3,000Forestry and Fishing8,000CFO/VP Finance175,000 JD Edwards2,800Communications10,000CIO/CTO/Director IT150,000 Lawson 3,100Construction35,000VP/Director HR190,000 Microsoft AX2,000Finance33,000VP/Director Logistics35,000 Microsoft GP 11,000Insurance 12,000VP/Director Manufacturing75,000 Microsoft NAV5,000Real Estate11,000VP/Director Marketing160,000 Microsoft SL 2,200Manufacturing95,000VP/Director Sales175,000 Microsoft NAV3,500Mining4,000VP/Director Purchasing100,000 Microsoft Exchange20,000Public Administration8,000VP/Director Supply Chain40,000 Microsoft SharePoint18,000Retail Trade70,000 Oracle E-Business Suite8,000Services180,000 PeopleSoft3,200Transportation25,000 Primavera2,600Utilities7,000 SAP 12,000Wholesale Trade45,000 Siebel2,400 Fields: Contact Name, Job Title, Email, Main Phone Number, Physical Address, Company, Industry, SIC Code, Website, Company revenue, Employee size, etc. License: The list is provided for perpetual use with no restriction on the number of usage. Accuracy Rate: 85%. Let me know which of the above lists interest you so that I can get back to you with counts, a few samples and other details. Kind Regards, Mike Gordon VP Business Development Repharm Technologies Please consider the environment before printing this e-mail To unsubscribe please reply to this email with remove in the subject line. The information contained in this e-mail message and any attachments are confidential information intended only for the use of individuals or entities named above. If the reader of this message is not the intended recipient you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by e-mail at the originating address. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SAAS, Oracle, SAP, Microsoft( Exchange , Dynamics etc), HR, Healthcare, Technology, Industry, ERP, CRM, VAR customer lists
On 21-02-11 16:52, mike gordon wrote: Hi, This email is to introduce Repharm Technologies and lists we provide. Can this persone be removed from this list? (and denid access) This is SPAM ;( ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SAAS, Oracle, SAP, Microsoft( Exchange , Dynamics etc), HR, Healthcare, Technology, Industry, ERP, CRM, VAR customer lists
On 2/21/11 5:01 PM, Luuk wrote: On 21-02-11 16:52, mike gordon wrote: Hi, This email is to introduce Repharm Technologies and lists we provide. Can this persone be removed from this list? (and denid access) This is SPAM ;( ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice I have requested stricter spam filtering be implemented but it doesn't seem to be an issue as of right now spam wise :(. I am more then willing to work with the person in charge to setup something to mitigate spam before it gets out of control. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove tools/list.hxx in calc
Just some header cleanup patch. Under LGPLv3+/MPL 0001-Remove-tools-list.hxx.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Is testing/testautomation really needed ?
On Fri, 2011-02-18 at 10:28 +0100, Francois Tigeot wrote: The tests somehow emulate the user behavior; this approach has its problems (lots of 'sleep 10' in the code, takes incredibly long to run, UI modifications tend to break lots of tests), but still seems to have some value, from time to time it finds an error or 2 :-) There's some value in that. I've attached a small patch instead ;) Looks like someone has already applied this patch (?) It would be helpful if whoever applies a patch replies to the thread to indicate that the patch has been applied. That would help those who are scanning for old, unmerged patches (like me) from the large pile of emails on the list... Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] DECLARE_LIST() Removal Project
On Mon, Feb 21, 2011 at 12:10 AM, Joseph Powers jpower...@cox.net wrote: Here's a quick update on the project: 1. The only items left are: binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeConnections, DdeConnection* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTransactions, DdeTransaction* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeFormats, long ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( StringList, String * ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeServices, DdeService* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTopics, DdeTopic* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeItems, DdeItem* ) idl/inc/lex.hxx:DECLARE_LIST( SvTokenList, SvToken * ) idl/inc/object.hxx:DECLARE_LIST( SvSlotElementList, SvSlotElement* ) idl/inc/types.hxx:DECLARE_LIST(SvMetaTypeList,SvMetaType *) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeConnections, DdeConnection* ) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeServices, DdeService* ) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeTopics, DdeTopic* ) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeItems, DdeItem* ) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeTransactions, DdeTransaction* ) svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeFormats, long ) svl/inc/svl/svdde.hxx:DECLARE_LIST( StringList, String * ) svl/source/svdde/ddeimp.hxx:DECLARE_LIST( ConvList, Conversation* ); tools/inc/tools/list.hxx:// - DECLARE_LIST - tools/inc/tools/list.hxx:#define DECLARE_LIST( ClassName, Type ) \ tools/inc/tools/ref.hxx:DECLARE_LIST(CN##List,EN)\ 2. We also have a few locations where the List class is used directly with out the DECLARE_LIST() macro. My work order is: 1. Reduce the number of #include tools/list.hxx down to a minimum (it should only be used in areas that use the List class). 2. Convert the binfilter svl items above to a ::std::vector or similar template. These files are only used on MS-Windows which I don't build on, so I'm going to just create the patches and then send them to Fridrich who volunteered to make sure the build ok. 3. Fix the tools/inc/tools/ref.hxx usage of DECLARE_LIST. The issue here is that it's a macro that's used in several locations. Rafael is working on the following areas: 1. Convert the idl items above. 2. Start converting the code that uses the List class. Joe P. PS: Rafeal, I pushed your patch to convert the std::vector to boost::ptr_vector in writer. Sorry I don't know how to preserve your submitter information (my git foo is bad). I had one section that did not apply cleanly so I had to patch that section manually. Can you double check my work and make sure it's what you wanted? I did a make check and also tested the menu item directly and it seems to work. authorJoseph Powers jpower...@cox.net2011-02-21 04:13:57 (GMT)committerJoseph Powers jpower...@cox.net2011-02-21 04:13:57 (GMT)commit 5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1http://cgit.freedesktop.org/libreoffice/writer/commit/?id=5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1 (patchhttp://cgit.freedesktop.org/libreoffice/writer/patch/?id=5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1 ) Yes sorry for that, thanks!!! looks perfect ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] windows dll search order and cppunit
deliver cppunit not into the normal solver/bin dir, but into e.g. solver/bin/other or something That was exactly my thought, too. Will implement next week once I am back from a short vacation, unless somebody beats me to it. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] 386BSD and MACH defines.
Nice. I let those files untouched, thought they came from X. I'll remove hpux and this other stuff soon. Thomas On 02/21/2011 05:19 PM, Francois Tigeot wrote: The attached patch a 386BSD #defined test (the only one ?) If nobody objects, I'll push it in a few hours. I have left the MACH test intact. Does someone know if it is useful to have around or if it corresponds to another dead system ? AFAIK, MacOS X uses a Mach kernel but its associated #define is MACOSX ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build speedup
On 02/17/2011 01:02 PM, Francois Tigeot wrote: On Thu, Feb 17, 2011 at 10:08:58AM +, Caolán McNamara wrote: CSET is probably also complete foo IIRC. Though I don't know to what it referred. I don't know if these cleanups are the reason, but my builds are now faster by a few minutes. I'm down to 2:38 on a 3GHz Core 2. Maybe because binfilter/bf_sw write support is gone ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
On 02/17/2011 10:39 AM, Tor Lillqvist wrote: TCPP seems to be an old compiler. Turbo C++ ? --tml Yes, thanks :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
On 02/17/2011 11:08 AM, Caolán McNamara wrote: On Thu, 2011-02-17 at 10:34 +0100, Thomas Arnhold wrote: Ah, forgot one. All looks good, go for it. CSET is probably also complete foo IIRC. Though I don't know to what it referred. C. IBM CSet C- Compiler - I'll remove this one, too. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: [tdf-discuss] Hyperlinks are not saved on PPT files
FYI
-- Forwarded message --
From: Do Hong Phuc dhongp...@gmail.com
Date: Mon, Feb 21, 2011 at 11:46 AM
Subject: Re: [tdf-discuss] Hyperlinks are not saved on PPT files
To: disc...@documentfoundation.org
I tried with some .ppt files it seems a critical bug?
On Sun, Feb 20, 2011 at 11:03 PM, Jaime R. Garza gar...@gmail.com wrote:
Hello all,
I think this is very important and shouldn't be so difficult to correct.
When I edit a PPT file on LibreOffice and I add a Hyperlink to a text, then
save it in it original fileformat (PPT).
After closing the PPT file and opening it again, the Hyperlinks are all
gone!
I don't know if it's already filed as a bug, but it definitely should be.
Cheers!
Jaime R. Garza
--
Unsubscribe instructions: E-mail to discuss+h...@documentfoundation.org
Archive: http://listarchives.documentfoundation.org/www/discuss/
*** All posts to this list are publicly archived for eternity ***
--
Unsubscribe instructions: E-mail to discuss+h...@documentfoundation.org
Archive: http://listarchives.documentfoundation.org/www/discuss/
*** All posts to this list are publicly archived for eternity ***
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Is testing/testautomation really needed ?
On Mon, Feb 21, 2011 at 11:28:19AM -0500, Kohei Yoshida wrote: On Fri, 2011-02-18 at 10:28 +0100, Francois Tigeot wrote: There's some value in that. I've attached a small patch instead ;) Looks like someone has already applied this patch (?) It would be helpful if whoever applies a patch replies to the thread to indicate that the patch has been applied. That would help those who are scanning for old, unmerged patches (like me) from the large pile of emails on the list... That was me, sorry. I've been granted a developper account a few hours ago and I'm pushing my backlog of patches. I'll try to reply to each thread with uncommitted ones. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove OSF/1 support
On Wed, Feb 16, 2011 at 08:49:47PM +0100, Francois Tigeot wrote: The attached patches remove OSF/1 support from the build system and some application code. Pushed. For the record, these patches and subsequent ones can be considered to be LGPLv3+/MPL unless stated otherwise -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx
Hi, I've recently replaced all ASSERT_ID() macros with OSL_ASSERT(). Therefore errhdl.[hc]xx became obsolete. So I removed these files. There was a line in errhdl.hxx: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? There is one file left in sw/source/core/except/ - dbgloop.cxx. It's header dbgloop.hxx defines the DBG_LOOP macro. Is this still used by anyone for debugging purpose? If not I'm glad to remove this one, as we get rid of this local debug stuff with it ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Branch libreoffice-3-3-1 created
On Mon, 21 Feb 2011 15:45:22 +0100 Jan Holesovsky ke...@suse.cz wrote: Hi Hanno, Hi Jan, hi Andreas, Sorry for being unclear in the announcement mail. Indeed, the 'build' repo is an exception, and the distro maintainers are free to commit whatever they need for their own distros, you only need to make sure you are not breaking the distros of others. ah, okay, so I will commit my patch to branch libreoffice-3-3. @Andreas You may merge it to the subbranches (3-3-1, ...) if you want. And I want to squeeze out the remaining patches, so that all the Gentoo related patches will be gone or merged into master. Sounds great :-) There are four left that may need to be discussed, or not. I will send them to mailing-list and wait a week for answers before committing. Regards, Kendy Regards, Hanno ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] 386BSD and MACH defines.
On Mon, Feb 21, 2011 at 04:25:37PM +, Caolán McNamara wrote: On Mon, 2011-02-21 at 17:19 +0100, Francois Tigeot wrote: The attached patch a 386BSD #defined test (the only one ?) Go for it, Pushed. that mkdepend is derived from some imake mkdepend or something, hence the old platforms inside it. Haha, that makes sense :-( -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx
On Mon, 2011-02-21 at 18:20 +0100, Thomas Arnhold wrote: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? Sure, but only an internal API, the external API, i.e. the bits that extensions link to, are a subset of the ones in the ure clone dir. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx
On 02/21/2011 06:37 PM, Caolán McNamara wrote: On Mon, 2011-02-21 at 18:20 +0100, Thomas Arnhold wrote: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? Sure, but only an internal API, the external API, i.e. the bits that extensions link to, are a subset of the ones in the ure clone dir. Ah, ok. Thanks :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: [tdf-discuss] Hyperlinks are not saved on PPT files
sorry... can wikipedia bref integrate d in to LO?
Dave Johnson
On Feb 21, 2011 11:14 AM, Nguyen Vu Hung vuhung16p...@gmail.com wrote:
FYI
-- Forwarded message --
From: Do Hong Phuc dhongp...@gmail.com
Date: Mon, Feb 21, 2011 at 11:46 AM
Subject: Re: [tdf-discuss] Hyperlinks are not saved on PPT files
To: disc...@documentfoundation.org
I tried with some .ppt files it seems a critical bug?
On Sun, Feb 20, 2011 at 11:03 PM, Jaime R. Garza gar...@gmail.com wrote:
Hello all,
I think this is very important and shouldn't be so difficult to correct.
When I edit a PPT file on LibreOffice and I add a Hyperlink to a text,
then
save it in it original fileformat (PPT).
After closing the PPT file and opening it again, the Hyperlinks are all
gone!
I don't know if it's already filed as a bug, but it definitely should be.
Cheers!
Jaime R. Garza
--
Unsubscribe instructions: E-mail to discuss+h...@documentfoundation.org
Archive: http://listarchives.documentfoundation.org/www/discuss/
*** All posts to this list are publicly archived for eternity ***
--
Unsubscribe instructions: E-mail to discuss+h...@documentfoundation.org
Archive: http://listarchives.documentfoundation.org/www/discuss/
*** All posts to this list are publicly archived for eternity ***
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Patch handling guideline
Hi there, I'm working on authoring this page http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline to help us develop some sort of guideline in order to handle this ever increasing amount of in-coming patches. The page is intended for both those who submit patches, and those who review push them. This page is only 2 hours old, and my hope is to get this page developed further into a full-fledged guideline. However, it's not the intention of this page to inundate potential patch submitters with lots and lots of rules; instead, some minimal best practices that they can follow in order for us to make this process scalable. Also, until now, only a handful of core developers have been reviewing patches. However, this obviously does not scale with this increasing number of patches to review (unless the core devs have nothing else to do than reviewing patches, which unfortunately is not the case). So IMO anyone with commit access with reasonable experience working with the code base should be able to review patches are encouraged to do so. There are still those patches that need to be reviewed by the respective domain experts, but I think at the moment, those patches probably comprise roughly ~30% of all incoming patches. I'd like to know what others think of the current situation, and if there is a good way to handle this. Feedback appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/accessibility/
Hi,
Translated German comments in libs-core/svx/source/accessibility/.
Made a few other fixes (removed out commented code) along the way.
You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+
triple license.
/Albert
diff --git a/svx/source/accessibility/AccessibleFrameSelector.cxx b/svx/source/accessibility/AccessibleFrameSelector.cxx
index dfb7e81..6cbf923 100644
--- a/svx/source/accessibility/AccessibleFrameSelector.cxx
+++ b/svx/source/accessibility/AccessibleFrameSelector.cxx
@@ -625,12 +625,7 @@ voidAccFrameSelector::NotifyFocusListeners(sal_Bool bGetFocus)
aEvent.FocusFlags |= AwtFocusChangeReason::AROUND;
if(nFocusFlagsGETFOCUS_UNIQUEMNEMONIC)
aEvent.FocusFlags |= AwtFocusChangeReason::UNIQUEMNEMONIC;
-//if(nFocusFlagsGETFOCUS_INIT)
-//aEvent.FocusFlags |= AwtFocusChangeReason::
}
-//else
-//how can I find the current focus window?
-//aEvent.NextFocus = ;
aEvent.Temporary = sal_False;
Reference XAccessibleContext xThis( this );
diff --git a/svx/source/accessibility/AccessibleShape.cxx b/svx/source/accessibility/AccessibleShape.cxx
index fc696b5..5682ada 100644
--- a/svx/source/accessibility/AccessibleShape.cxx
+++ b/svx/source/accessibility/AccessibleShape.cxx
@@ -569,27 +569,6 @@ awt::Rectangle SAL_CALL AccessibleShape::getBounds (void)
int x = aPixelPosition.getX() - aParentLocation.X;
int y = aPixelPosition.getY() - aParentLocation.Y;
-/*// The following block is a workarround for bug #99889# (property
-// BoundRect returnes coordinates relative to document window
-// instead of absolute coordinates for shapes in Writer). Has to
-// be removed as soon as bug is fixed.
-
-// Use a non-null anchor position as flag that the shape is in a
-// Writer document.
-if (xSetInfo.is())
-if (xSetInfo-hasPropertyByName (sAnchorPositionName))
-{
-uno::Any aPos = xSet-getPropertyValue (sAnchorPositionName);
-awt::Point aAnchorPosition;
-aPos = aAnchorPosition;
-if (aAnchorPosition.X 0)
-{
-x = aPixelPosition.getX();
-y = aPixelPosition.getY();
-}
-}
-// End of workarround.
-*/
// Clip with parent (with coordinates relative to itself).
::Rectangle aBBox (
x, y, x + aPixelSize.getWidth(), y + aPixelSize.getHeight());
@@ -845,8 +824,6 @@ uno::Sequenceuno::Type SAL_CALL
::getCppuType((const uno::Referencedocument::XEventListener*)0);
const uno::Type aUnoTunnelType =
::getCppuType((const uno::Referencelang::XUnoTunnel*)0);
-//const uno::Type aStateSetType =
-// ::getCppuType((const uno::ReferenceXAccessibleStateSet*)0);
// ... and merge them all into one list.
sal_Int32 nTypeCount (aTypeList.getLength()),
diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx b/svx/source/accessibility/AccessibleTextHelper.cxx
index 1f50794..84a2f08 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++ b/svx/source/accessibility/AccessibleTextHelper.cxx
@@ -683,14 +683,6 @@ namespace accessibility
else if ( maLastSelection.HasRange()
aSelection.HasRange() )
{
-// send event TEXT_SELECTION_CHANGED for difference
-// between last and new selection. (#i27299#)
-//// selection was on, now is different: take union of ranges
-//maParaManager.FireEvent( ::std::min(sortedSelection.first,
-// sortedLastSelection.second),
-// ::std::max(sortedSelection.first,
-// sortedLastSelection.second)+1,
-// nTextSelChgEventId );
// use sorted last and new selection
ESelection aTmpLastSel( maLastSelection );
aTmpLastSel.Adjust();
diff --git a/svx/source/accessibility/GraphCtlAccessibleContext.cxx b/svx/source/accessibility/GraphCtlAccessibleContext.cxx
index 0e60765..1d05ca3 100644
--- a/svx/source/accessibility/GraphCtlAccessibleContext.cxx
+++ b/svx/source/accessibility/GraphCtlAccessibleContext.cxx
@@ -432,8 +432,6 @@ Reference XAccessibleStateSet SAL_CALL SvxGraphCtrlAccessibleContext::getAcce
}
else
{
-// pStateSetHelper-AddState( AccessibleStateType::ENABLED );
-// pStateSetHelper-AddState( AccessibleStateType::SENSITIVE );
[Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/customshapes/
Hi,
Translated German comments in libs-core/svx/source/customshapes.
Made a few other fixes (removed out commented code) along the way.
You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+
triple license.
/Albert
diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 2dfdb50..b36a7ab 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -462,7 +462,6 @@ sal_Bool EnhancedCustomShape2d::ConvertSequenceToEnhancedCustomShape2dHandle(
const rtl::OUString sMirroredY ( RTL_CONSTASCII_USTRINGPARAM( MirroredY ) );
const rtl::OUString sSwitched ( RTL_CONSTASCII_USTRINGPARAM( Switched ) );
const rtl::OUString sPolar( RTL_CONSTASCII_USTRINGPARAM( Polar ) );
-// const rtl::OUString sMap( RTL_CONSTASCII_USTRINGPARAM( Map ) );
const rtl::OUString sRefX( RTL_CONSTASCII_USTRINGPARAM( RefX ) );
const rtl::OUString sRefY( RTL_CONSTASCII_USTRINGPARAM( RefY ) );
const rtl::OUString sRefAngle ( RTL_CONSTASCII_USTRINGPARAM( RefAngle ) );
@@ -2141,7 +2140,6 @@ SdrObject* EnhancedCustomShape2d::CreateObject( sal_Bool bLineGeometryNeededOnly
{
pRet = new SdrRectObj( aLogicRect );
// SJ: not setting model, so we save a lot of broadcasting and the model is not modified any longer
-// pRet-SetModel( pCustomShapeObj-GetModel() );
pRet-SetMergedItemSet( *this );
}
if ( !pRet )
@@ -2161,14 +2159,6 @@ void EnhancedCustomShape2d::ApplyGluePoints( SdrObject* pObj )
aGluePoint.SetPos( GetPoint( seqGluePoints[ i ], sal_True, sal_True ) );
aGluePoint.SetPercent( sal_False );
-
-// const Point rPoint = GetPoint( seqGluePoints[ i ], sal_True, sal_True );
-// double fXRel = rPoint.X();
-// double fYRel = rPoint.Y();
-// fXRel = aLogicRect.GetWidth() == 0 ? 0.0 : fXRel / aLogicRect.GetWidth() * 1;
-// fYRel = aLogicRect.GetHeight() == 0 ? 0.0 : fYRel / aLogicRect.GetHeight() * 1;
-// aGluePoint.SetPos( Point( (sal_Int32)fXRel, (sal_Int32)fYRel ) );
-// aGluePoint.SetPercent( sal_True );
aGluePoint.SetAlign( SDRVERTALIGN_TOP | SDRHORZALIGN_LEFT );
aGluePoint.SetEscDir( SDRESC_SMART );
SdrGluePointList* pList = pObj-ForceGluePointList();
diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index 6593e75..8276e78 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -346,8 +346,7 @@ SdrObject* EnhancedCustomShape3d::Create3DObject( const SdrObject* pShape2d, con
if ( pAny )
*pAny = eProjectionMode;
ProjectionType eProjectionType( eProjectionMode == drawing::ProjectionMode_PARALLEL ? PR_PARALLEL : PR_PERSPECTIVE );
-
-// pShape2d Umwandeln in Szene mit 3D Objekt
+// pShape2d Convert in scenes which include 3D Objects
E3dDefaultAttributes a3DDefaultAttr;
a3DDefaultAttr.SetDefaultLatheCharacterMode( TRUE );
a3DDefaultAttr.SetDefaultExtrudeCharacterMode( TRUE );
@@ -508,7 +507,7 @@ SdrObject* EnhancedCustomShape3d::Create3DObject( const SdrObject* pShape2d, con
// then we can change the return value
pRet = pScene;
-// Kameraeinstellungen, Perspektive ...
+// Camera settings, Perspective ...
Camera3D rCamera = (Camera3D)pScene-GetCamera();
const basegfx::B3DRange rVolume = pScene-GetBoundVolume();
pScene-NbcSetSnapRect( aSnapRect );
@@ -713,14 +712,6 @@ Rectangle EnhancedCustomShape3d::CalculateNewSnapRect( const SdrObject* pCustomS
drawing::Direction3D aRotationCenterDefault( 0, 0, 0 ); // default seems to be wrong, a fractional size of shape has to be used!!
drawing::Direction3D aRotationCenter( GetDirection3D( rGeometryItem, sRotationCenter, aRotationCenterDefault ) );
-// double XCenterInGUnits = rPropSet.GetPropertyValue( DFF_Prop_c3DRotationCenterX, 0 );
-// double YCenterInGUnits = rPropSet.GetPropertyValue( DFF_Prop_c3DRotationCenterY, 0 );
-
-// sal_Int32 nRotationXAxisInProz = rPropSet.GetPropertyValue( DFF_Prop_c3DRotationAxisX, 100 );
-// sal_Int32 nRotationYAxisInProz = rPropSet.GetPropertyValue( DFF_Prop_c3DRotationAxisY, 0 );
-// sal_Int32 nRotationZAxisInProz = rPropSet.GetPropertyValue( DFF_Prop_c3DRotationAxisZ, 0 );
-
-
double fXRotate, fYRotate;
GetRotateAngle( rGeometryItem, fXRotate, fYRotate );
double fZRotate = - ((SdrObjCustomShape*)pCustomShape)-GetObjectRotation() * F_PI180;
diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 23cfd5b..957f24c 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++
Re: [Libreoffice] [PATCH] [PUSHED] Translation of German comment in libs-core/uui
On Fri, 2011-02-18 at 21:09 +0100, Albert Thuswaldner wrote: Hi, Found no German comments in this directory. I however took the opportunity to make a few fixes along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. Thanks a lot. Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove SCO references in ure
On Fri, 2011-02-18 at 11:37 +0100, Francois Tigeot wrote: This patch gets rid of some remaining SCO tests. Go ahead and push this yourself now. What's strange is that there were references in sal/osl/os2/ It seems the os2/ files are a straight copy of the unx/ files Yeah, this is common in the os/2 subdirs. A little like w32, a lot like unix, so I think it was a copy the unix ones and fix it up when that wasn't sufficient. I don't know the status of the OS/2 EComStation port. I'm a little reluctant to just declare it dead and remove it seeing as I think it worked up to 3.1.1 anyway. I suppose we could mark it somewhere as in danger of being removed in x months unless someone steps up to build it on that platform ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Is testing/testautomation really needed ?
On Mon, 2011-02-21 at 18:16 +0100, Francois Tigeot wrote: On Mon, Feb 21, 2011 at 11:28:19AM -0500, Kohei Yoshida wrote: On Fri, 2011-02-18 at 10:28 +0100, Francois Tigeot wrote: There's some value in that. I've attached a small patch instead ;) Looks like someone has already applied this patch (?) It would be helpful if whoever applies a patch replies to the thread to indicate that the patch has been applied. That would help those who are scanning for old, unmerged patches (like me) from the large pile of emails on the list... That was me, sorry. I've been granted a developper account a few hours ago and I'm pushing my backlog of patches. I'll try to reply to each thread with uncommitted ones. Ah, good for you! :-) And yes, if you can help us identify those patches of yours that you have integrated by replying to them, we'd appreciate it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove of deprecated list container in calc. (Rafael Dominguez)[PUSHED]
I pushed this patch for Rafael. Joe P ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Conditional compilation of legacy Addin mechanism in calc
On Sat, 2011-02-19 at 09:33 +, Alfonso Eusebio wrote: Hi, Please find attached patches for the conditional removal of legacy calc addins. As always, these changes are made available under LGPLv3+/MPL. Kohei, I have used a macro definition to conditionally compile the code in/out. In this patch the macro (SC_WITHOUT_LEGACY_ADDIN) is undefined, so the mechanism is left untouched. Defining SC_WITHOUT_LEGACY_ADDIN in global.hxx (both in calc and in binfilter) will remove the legacy addin mechanism. Thanks a lot for this patch. This helps identify those code blocks that can potentially be removed later. One correction is needed however. You've used #ifndef #endif block throughout the code base to conditionally disable code blocks, but the better way is to define in global.hxx #define SC_WITH_LEGACY_ADDIN 1 and use #if SC_WITH_LEGACY_ADDIN code block #endif This way, all you have to do to enable/disable the code is to toggle the value of SC_WITH_LEGACY_ADDIN in the global.hxx and re-compile. Another thing is to associate the value of 1 to enabling, and the value of 0 to disabling, to make it easier for the brain to process this, as it requires a bit of extra work mentally to process 0 for enabling and 1 for disabling. Thanks! Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Comment fix
This fixes a typo that occured during translation. thanks. This is contributed under the terms of the LGPLv3+/MPL dual license. --- sw/source/ui/app/docsh2.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sw/source/ui/app/docsh2.cxx b/sw/source/ui/app/docsh2.cxx index cac1857..e614d89 100644 --- a/sw/source/ui/app/docsh2.cxx +++ b/sw/source/ui/app/docsh2.cxx @@ -393,7 +393,7 @@ BOOL SwDocShell::Insert( SfxObjectShell rSource, // SwDocStyleSheetPool::aStyleSheet that uses same members of // SwDocStyleSheetPool::Find. Therefore a copy has to be used // here. Attention: SfxStylessheetBase::SetFollow calls itself -// a SwDocStyleSheetBase::Find, so that it's not sufficiant to +// a SwDocStyleSheetPool::Find, so that it's not sufficiant to // to eliminate the Find-calls in this method. rtl::Reference SwDocStyleSheet xNewSheet( new SwDocStyleSheet( (SwDocStyleSheet)pMyPool -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove tools/list.hxx in components
Just some header cleaning, patch under the LGPLv3+/MPL 0001-Remove-tools-list.hxx-header.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [EasyHacks] Protocol capitalization
On Mon, 2011-02-21 at 08:59 +0100, Sébastien Le Ray wrote: Hi list, Here are two patch regarding the Easy Hack Improve Autocorrect capitalize first word in sentence (on the wiki). First one improves french autocorrection for non breaking space before : when you enter a protocol. Oh interesting, I didn't know that there was some special fr only code inside the autocorrect. A good catch IMO, so happily pushed. I didn't remove the code handling the :// case since INETUrlObject does not contains ftps://, imaps:// and other protocols. I could modify INETUrlObject if needed to handle these and get ride of this special case. Modifying INETUrlObject to add a new protocol, as I discovered to my cost recently, turns out to be a little bit tricky with some knockon effects where some code far from tools behaves quite differently when a protocol is unknown vs known. For non-autocorrection of ftps:// imaps:/// it ain't worth it. If you want you could just add a local list into that autocorr.cxx of additional things worth auto-non-capitalizing. Second one prevents capitalisation of recognized protocole (e.g. http: will never be replaced by Http: even at the beginning of a sentence). This makes my month, really great :-) I like autocorrect, but that one always drive me wild, just not enough to fix it myself. Move it from the easy-hack list to the completed one and stick your name on it there. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] windows dll search order and cppunit
On Mon, 2011-02-21 at 09:40 -0700, Tor Lillqvist wrote: deliver cppunit not into the normal solver/bin dir, but into e.g. solver/bin/other or something That was exactly my thought, too. Will implement next week once I am back from a short vacation, unless somebody beats me to it. Pushed what I think should do-the-right thing now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translate german comments of writer/sw/source/ui/cctrl
This translates the few german code comments in the cctrl directory to
english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/cctrl/popbox.cxx |2 +-
sw/source/ui/cctrl/swlbox.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sw/source/ui/cctrl/popbox.cxx b/sw/source/ui/cctrl/popbox.cxx
index 9005eb3..c9f8a2b 100644
--- a/sw/source/ui/cctrl/popbox.cxx
+++ b/sw/source/ui/cctrl/popbox.cxx
@@ -44,7 +44,7 @@ SwHelpToolBox::SwHelpToolBox( SwNavigationPI* pParent, const
ResId rResId )
void SwHelpToolBox::MouseButtonDown(const MouseEvent rEvt)
{
-// If doubleclick is detected use doublelick handler
+// If doubleclick is detected use doubleclick handler
if(rEvt.GetButtons() == MOUSE_RIGHT
0 == GetItemId(rEvt.GetPosPixel()))
{
diff --git a/sw/source/ui/cctrl/swlbox.cxx b/sw/source/ui/cctrl/swlbox.cxx
index 908007f..3dd0c00 100644
--- a/sw/source/ui/cctrl/swlbox.cxx
+++ b/sw/source/ui/cctrl/swlbox.cxx
@@ -68,7 +68,7 @@ SwComboBox::SwComboBox(Window* pParent, const ResId rId,
USHORT nStyleBits ):
ComboBox(pParent, rId),
nStyle(nStyleBits)
{
-// Verwaltung fuer die Stringlist aus der Resource aufbauen
+// create administration for the resource's Stringlist
USHORT nSize = GetEntryCount();
for( USHORT i=0; i nSize; ++i )
{
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Corrected EasyHacks: Re-animated tests in sal/qa/osl
So sorry - it was too late Saturday night. I didn't realize that my IDE was set to strip off trailing blanks. So it happened again that I send a patch that contains a lot of whitespace changes. Now I attach a corrected patch (without the whitespace changes). I hope that this doesn't confuse additionaly Wilhelm From 4ca17d617602df40f44d2d04863f28e1533e003c Mon Sep 17 00:00:00 2001 Message-Id: 4ca17d617602df40f44d2d04863f28e1533e003c.1298323174.git.wilhelm.pflue...@web.de From: Wilhelm Pflueger wilhelm.pflue...@web.de Date: Sun, 20 Feb 2011 01:57:37 +0100 Subject: [PATCH] EasyHacks: Re-animate tests in sal/qa/osl Some tests in osl_process are not running: a) the batch file for the batch test is not copied to the execution path b) osl_execProc_exe_name_in_argument_list() throws an assertion. Signed-off-by: Wilhelm Pflueger wilhelm.pflue...@web.de --- sal/prj/build.lst|4 +- sal/qa/osl/process/batch.sh |2 + sal/qa/osl/process/makefile.mk |6 ++- sal/qa/osl/process/osl_Thread.cxx| 106 -- sal/qa/osl/process/osl_process.cxx | 23 +-- sal/qa/osl/process/osl_process_child.cxx | 43 ++-- sal/qa/osl/security/osl_Security.cxx | 49 +- sal/qa/osl/security/osl_Security_Const.h |8 ++- 8 files changed, 144 insertions(+), 97 deletions(-) diff --git a/sal/prj/build.lst b/sal/prj/build.lst index 1b38581..40e5e5c 100644 --- a/sal/prj/build.lst +++ b/sal/prj/build.lst @@ -1,4 +1,4 @@ -sa sal : xml2cmp external BOOST:boost CPPUNIT:cppunit NULL +sa sal : xml2cmp external BOOST:boost CPPUNIT:cppunit NULL sa sal usr1 - all sa_mkout NULL sa sal\inc nmake - all sa_inc NULL sa sal\typesconfig nmake - u sa_tc sa_inc NULL @@ -21,5 +21,7 @@ sa sal\qa\osl\profile nmake - all sa_qa_osl_profile sa_cppunittester sa_util NUL sa sal\qa\osl\file nmake - u sa_qa_osl_file sa_cppunittester sa_util NULL sa sal\qa\osl\module nmake - u sa_qa_osl_module sa_cppunittester sa_util NULL sa sal\qa\osl\condition nmake - all sa_qa_osl_condition sa_cppunittester sa_util NULL +sa sal\qa\osl\security nmake - all sa_qa_osl_security sa_cppunittester sa_util NULL +sa sal\qa\osl\process nmake - all sa_qa_osl_process sa_cppunittester sa_util NULL sa sal\qa\rtl\strings nmake - all sa_qa_rt_strings sa_cppunittester sa_util NULL sa sal\qa\rtl\oustringbuffer nmake - all sa_qa_rt_oustringbuffer sa_cppunittester sa_util NULL diff --git a/sal/qa/osl/process/batch.sh b/sal/qa/osl/process/batch.sh new file mode 100755 index 000..fd3828c --- /dev/null +++ b/sal/qa/osl/process/batch.sh @@ -0,0 +1,2 @@ +#!/bin/sh +echo Hello world \ No newline at end of file diff --git a/sal/qa/osl/process/makefile.mk b/sal/qa/osl/process/makefile.mk index 2bcbe48..e04bebc 100644 --- a/sal/qa/osl/process/makefile.mk +++ b/sal/qa/osl/process/makefile.mk @@ -1,7 +1,7 @@ #* # # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# +# # Copyright 2000, 2010 Oracle and/or its affiliates. # # OpenOffice.org - a multi-platform office productivity suite @@ -77,6 +77,9 @@ APP3TARGET=osl_process_child APP3OBJS=$(OBJ3FILES) APP3STDLIBS=$(SALLIB) +#TODO: The Linux and WinDOS batch file must be copied to $(BIN) directory! +# I dont't know how to do this + #--- All object files --- # do this here, so we get right dependencies @@ -94,3 +97,4 @@ SLOFILES=$(SHL1OBJS) $(SHL2OBJS) .INCLUDE : target.mk .INCLUDE : _cppunit.mk + diff --git a/sal/qa/osl/process/osl_Thread.cxx b/sal/qa/osl/process/osl_Thread.cxx index eb5ec5e..9087978 100644 --- a/sal/qa/osl/process/osl_Thread.cxx +++ b/sal/qa/osl/process/osl_Thread.cxx @@ -2,7 +2,7 @@ /* * * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * + * * Copyright 2000, 2010 Oracle and/or its affiliates. * * OpenOffice.org - a multi-platform office productivity suite @@ -42,7 +42,13 @@ #include osl/mutex.hxx #include osl/time.h -#include testshl/simpleheader.hxx +#include string.h + +#include cppunit/TestFixture.h +#include cppunit/extensions/HelperMacros.h +#include cppunit/plugin/TestPlugIn.h + +#define t_print printf using namespace osl; using namespace rtl; @@ -89,7 +95,7 @@ void StopWatch::start() m_bIsValid = false; m_bIsRunning = true; osl_getSystemTime( t1 ); -t_print(# %d %d nsecs\n, t1.Seconds, t1.Nanosec); +t_print(# %u %u nsecs\n, (unsigned)t1.Seconds, (unsigned)t1.Nanosec); // gettimeofday(t1, 0); } @@ -100,7 +106,7 @@ void StopWatch::stop() // gettimeofday(t2, 0); // Timer ausfragen osl_getSystemTime( t2 ); -t_print(# %d %d nsecs\n, t2.Seconds, t2.Nanosec); +t_print(# %u %u nsecs\n, (unsigned) t2.Seconds, (unsigned) t2.Nanosec);
Re: [Libreoffice] Please review our patch for Bug 33089 – Calc export of non-gregorian date to Excel loses format
On Mon, 2011-02-21 at 12:02 +0700, Samphan Raruenrom wrote: https://bugs.freedesktop.org/show_bug.cgi?id=33089 This is the no.1 most serious bug that effect many Thai users esp. organization users. The patch is our work on fixing the bug. Please review it to see if it could be commit to LibreOffice or is there any change that is needed. As I wrote in the bugzilla, I need a summary and a brief explanation of the change that the patch makes in order to understand the issue. Right now there is only a code change with no explanation, which makes it harder for me to review. Could you provide a little more context to the patch? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove SCO references in ure
On Mon, Feb 21, 2011 at 08:43:20PM +, Caolán McNamara wrote: On Fri, 2011-02-18 at 11:37 +0100, Francois Tigeot wrote: This patch gets rid of some remaining SCO tests. Go ahead and push this yourself now. Done. What's strange is that there were references in sal/osl/os2/ It seems the os2/ files are a straight copy of the unx/ files Yeah, this is common in the os/2 subdirs. A little like w32, a lot like unix, so I think it was a copy the unix ones and fix it up when that wasn't sufficient. More things to clean-up :-) I don't know the status of the OS/2 EComStation port. I'm a little reluctant to just declare it dead and remove it seeing as I think it worked up to 3.1.1 anyway. I suppose we could mark it somewhere as in danger of being removed in x months unless someone steps up to build it on that platform ? Yeah, a public statement on the web site could help getting things clarified. I had a brief look in the archives for random os/2-specific files; it seems there has not been any specific work on that platform since the end of 2009. On the other hand, I've also done a bit of googling, and it seems there were still some users up to OOo 3.2 at least. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
Hi Martin,
I've pushed it. Please could you attach such a diff as patch next time?
Would be easier to commit it :) Thanks!
Thomas
On 02/21/2011 10:28 PM, Martin Kepplinger wrote:
This translates the few german code comments in the cctrl directory to
english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/cctrl/popbox.cxx |2 +-
sw/source/ui/cctrl/swlbox.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sw/source/ui/cctrl/popbox.cxx b/sw/source/ui/cctrl/popbox.cxx
index 9005eb3..c9f8a2b 100644
--- a/sw/source/ui/cctrl/popbox.cxx
+++ b/sw/source/ui/cctrl/popbox.cxx
@@ -44,7 +44,7 @@ SwHelpToolBox::SwHelpToolBox( SwNavigationPI* pParent,
const ResId rResId )
void SwHelpToolBox::MouseButtonDown(const MouseEvent rEvt)
{
-// If doubleclick is detected use doublelick handler
+// If doubleclick is detected use doubleclick handler
if(rEvt.GetButtons() == MOUSE_RIGHT
0 == GetItemId(rEvt.GetPosPixel()))
{
diff --git a/sw/source/ui/cctrl/swlbox.cxx b/sw/source/ui/cctrl/swlbox.cxx
index 908007f..3dd0c00 100644
--- a/sw/source/ui/cctrl/swlbox.cxx
+++ b/sw/source/ui/cctrl/swlbox.cxx
@@ -68,7 +68,7 @@ SwComboBox::SwComboBox(Window* pParent, const ResId rId,
USHORT nStyleBits ):
ComboBox(pParent, rId),
nStyle(nStyleBits)
{
-// Verwaltung fuer die Stringlist aus der Resource aufbauen
+// create administration for the resource's Stringlist
USHORT nSize = GetEntryCount();
for( USHORT i=0; i nSize; ++i )
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Comment fix
I've pushed it. Thanks! Thomas On 02/21/2011 10:03 PM, Martin Kepplinger wrote: This fixes a typo that occured during translation. thanks. This is contributed under the terms of the LGPLv3+/MPL dual license. --- sw/source/ui/app/docsh2.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sw/source/ui/app/docsh2.cxx b/sw/source/ui/app/docsh2.cxx index cac1857..e614d89 100644 --- a/sw/source/ui/app/docsh2.cxx +++ b/sw/source/ui/app/docsh2.cxx @@ -393,7 +393,7 @@ BOOL SwDocShell::Insert( SfxObjectShell rSource, // SwDocStyleSheetPool::aStyleSheet that uses same members of // SwDocStyleSheetPool::Find. Therefore a copy has to be used // here. Attention: SfxStylessheetBase::SetFollow calls itself -// a SwDocStyleSheetBase::Find, so that it's not sufficiant to +// a SwDocStyleSheetPool::Find, so that it's not sufficiant to // to eliminate the Find-calls in this method. rtl::Reference SwDocStyleSheet xNewSheet( new SwDocStyleSheet( (SwDocStyleSheet)pMyPool ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
Am 21.02.2011 23:08, schrieb Thomas Arnhold: Hi Martin, I've pushed it. Please could you attach such a diff as patch next time? Would be easier to commit it :) Thanks! Thomas On 02/21/2011 10:28 PM, Martin Kepplinger wrote: This translates the few german code comments in the cctrl directory to english. This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. --- Hi Thomas, So no git format-patch and send-email anymore? I'm so used to it. I'm not a git pro, but I think you actually don't have to _commit_ any changes. I directly send git-commits here and you can preserve my sha1. I'm not sure if you did that in my case. (strangely, I find my patches two times under 2 different git-commits in master now... well, I'm not a git-Pro :) I would appreciate it if you could check with others (Christina Rossmanith for example pushed earlier patches of mine) about how they apply a finished git-patch and get back to me if I really should change my behaviour. Of course I will happily try to do so if this is consensus here! Since I thought I would make life easier for me _and_ you the git way, I just wanted to check once again here. thanks! Martin -- /***\ | Martin Kepplinger | | | | diaspora handle martinkepplin...@joindiaspora.com | | | | E-Mail IM(jabber) martinkepplin...@eml.cc | | | | GPG Fingerprint 7346 FE02 27C3 3958 813A C351 C100 D7B5 7F2A 1E26 | \***/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Bug 32574 - Patch
Hi, I fixed this bug: https://bugs.freedesktop.org/show_bug.cgi?id=32574 My code is under the LGPLv3+/MPL dual license. Regards, Balint Dozsa From f7c4296687f2e65adbc51598131d3f1c0228f8dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A1lint=20D=C3=B3zsa?= dozsabal...@gmail.com Date: Mon, 21 Feb 2011 23:21:00 +0100 Subject: [PATCH] Bugfix 32574 --- .../data/org/openoffice/Office/Accelerators.xcu|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index f9bc1f1..aa922fe 100755 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -387,7 +387,7 @@ /node node oor:name=BACKSPACE_SHIFT oor:op=replace prop oor:name=Commandvalue xml:lang=x-no-translateI10N SHORTCUTS - NO TRANSLATE/value - value xml:lang=en-US.uno:Deselect/value + value xml:lang=en-US.uno:SwBackspace/value /prop /node node oor:name=B_MOD1 oor:op=replace -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translation of German comment in libs-core/svx/source/customshapes/
Hi Albert, thanks! I've pushed it. But could you please separate your dead code removal and translation? It makes it hard to review this and if some dead looking code should come back later it's harder to do this (with translations in one diff). :) Thanks for your patches! Thomas On 02/21/2011 09:13 PM, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/customshapes. Made a few other fixes (removed out commented code) along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/dialog/
Yeah, thanks! Had some trouble with the diff - at the end of file there were some accidentally redos of some prior changes. I removed them (CSET and tools/list.h). And there were lots of trailing whitespaces. But now it's all fine. Thanks! Thomas On 02/21/2011 09:14 PM, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/dialog. Made a few other fixes (removed out commented code) along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] It's not a dev topic, but please read it.
2011/2/21 Michael Meeks michael.me...@novell.com Hi Kayo, On Thu, 2011-02-17 at 23:56 -0200, kayo.ha...@gekkolinux.com.br wrote: We have, in Brazil, one institute without funds that work to .. But after some things happended, $, this guys want to command and conquer the community, us, and not help us anymore. So - whatever the rights and wrongs of this issue - and I suspect poor communication is near the root of it all; there should clearly be no barrier to -anyone- contributing to LibreOffice. ie. we accept code changes, translations, artwork etc. based not on the language, color of skin, creed, odd views of author, corporate affiliation or not etc. etc. - but purely on merit. So :-) hopefully there should be no barrier to your continued concrete contributions getting included, and I look forward to reviewing them. Having said that - this is a developer list; and (given what I write above) this is emphatically not a developer issue - so please use the right list for this: ie. take it elsewhere - the 'discuss' list perhaps. As/when you have code, please bring it here :-) All the best, Michael. We the Brazilian Community are sorting things out, sory for the rant, it *should* not happen again. Thx Rogerio ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/dialog/
On Mon, 2011-02-21 at 21:14 +0100, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/dialog. Made a few other fixes (removed out commented code) along the way. Albert, @@ -515,9 +501,7 @@ void SvxRectCtl::Paint( const Rectangle ) } } -/* -|* -|* Konvertiert RECT_POINT in Point +// Convert RECT_POINT Point |* \/ FYI the above hunk breaks the build. When replacing the comment with a simple C++ style comment, be sure to remove the lower part of the original commit frame (the part that begins with |* and everything until the */ on the next line). Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
On Tue, 2011-02-22 at 00:06 +0100, Martin Kepplinger wrote: So no git format-patch and send-email anymore? I'm so used to it. No no, git format-patch is still the preferred patch format, so you are fine. For those who integrate patches, you can integrate patches generated by git format-patch simply by running 'git am' command. That's the preferred way because git format-patch preserves the commit message and the committer information as well as it handles changes in binary blobs. These are something the conventional patch format does not handle. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Patch handling guideline
At 2:40pm -0500 Mon, 21 Feb 2011, Kohei Yoshida wrote: http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline to help us develop some sort of guideline in order to handle this ever increasing amount of in-coming patches. The page is intended for both those who submit patches, and those who review push them. This page is only 2 hours old, and my hope is to get this page developed further into a full-fledged guideline. Good work, Kohei! The unfortunate reality is that administration of a project is just as important as the project itself. This page, though unfortunate that it took away time from the fun part of coding, is very important. Kudos. A minor to note: the last section, titled Reply to the thread with [PUSHED] tag, talks about a feature of mail clients that is apparently sometimes lacking. If this is the preferred method for working with these patches, be prepared for some pushback from folks who work with a client that doesn't implement the In-Reply-To header. I personally agree with you, and would not-so-humbly suggest folks change mail clients for that one feature, but just a heads up to be prepared. Also, until now, only a handful of core developers have been reviewing patches. However, this obviously does not scale with this increasing number of patches to review (unless the core devs have nothing else to do than reviewing patches, which unfortunately is not the case). So IMO anyone with commit access with reasonable experience working with the code base should be able to review patches are encouraged to do so. Great idea and thought process. After pointing out that I'm not currently one with commit access (and don't deserve it yet, either), I'll say I concur with your opinion. This has the two-fold effect of freeing up more core-dev time and educating others. Analogous to how one learns a concept much better when teaching it, so too will folks learn the code base better when reviewing other's patches. Some mistakes will be made, but that's what working in a group is for, as well as tests-galore. As the committers for this large project are still yet small in number, any deliberate and conscientious education of a younger crew (like myself!) will be the long-term lifeblood of LO. I'd like to know what others think of the current situation, and if there is a good way to handle this. Feedback appreciated. I don't think it's time yet, as we are still largely in a cleanup phase, but one approach that has worked very well for the Postgres project is the idea of a Commit Fest. http://wiki.postgresql.org/wiki/CommitFest Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Please review our patch for Bug 33089 – Calc export of non-gregorian date to Excel loses format
Thanks! See my long description on the bugzilla. On Tue, Feb 22, 2011 at 4:59 AM, Kohei Yoshida kyosh...@novell.com wrote: On Mon, 2011-02-21 at 12:02 +0700, Samphan Raruenrom wrote: https://bugs.freedesktop.org/show_bug.cgi?id=33089 This is the no.1 most serious bug that effect many Thai users esp. organization users. The patch is our work on fixing the bug. Please review it to see if it could be commit to LibreOffice or is there any change that is needed. As I wrote in the bugzilla, I need a summary and a brief explanation of the change that the patch makes in order to understand the issue. Right now there is only a code change with no explanation, which makes it harder for me to review. Could you provide a little more context to the patch? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com -- _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
