Re: [Libreoffice] toplevel make or partial build after modifications?

[Norbert Thiebaud]

On Wed, Mar 16, 2011 at 5:01 PM, Christina Roßmanith
 wrote:
> Hi,
>
> I've edited parhtml.cxx in ./svtools and now I'd like to test if the
> modification fixes bug 34666. What do I have to do? Is a partial build in
> directory ./svtools enough? Or is there some "install"-step needed? Or do I
> have to do a toplevel make?

If you've just changed a .cxx
AND
the thing that need to be rebuilt is not a static library (most targets are not)

then just doing a module level 'build' (1), followed by a 'deliver'
for good measure should be fine
(I'm assuming that you did a dev-install to test, so you don't even
need to do anything else after the build + deliver;
just re-run.)

Now, if you changed a header that is delivered - that is a header that
is possibly used by other module down the line
then you are better off doing a simple make at the top level. How do I
know it is a delivered header, you ask?
well if it is in /* it very, very likely is,
otherwise it _usually_(2) is not.
In doubt, do a top level make (if you are really curious, check the
prj/d.list file to see what actually get delivered, or
/Package_inc.mk for gnu-make converted modules).

If the module you changed is a static library, also a simple make at
the top level will to the trick - except if there is a
dependencies tracking bug, which cause on module down the line to to
be re-link when it should.
Of course since that would be a bug to start with, there is no 'rules'
as to when that can be a problem... it's just known to have happened
;-)

Once you graduate to the Caolan-style mastery of the intricacy of the
interdependence of modules, then you can probably know which
modules are directly and indirectly impacted with any of your changes
and rebuild them individually, but for mere mortal like you and me, a
top level make is much safer/easier :-D

So in the specific case you mentioned, a module level 'build' followed
by 'deliver' should be all you need.

Norbert

(1): as a, hopefully useful, reminder for all my fellow apprentice
hackers. what I mean by "module level build'  is explained here ->
http://wiki.documentfoundation.org/Development/Native_Build#Partial_build
(2) that rules will become much more strict as modules are converted
to the soon-to-be-in-master gnumake
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] toplevel make or partial build after modifications?

[Christina Roßmanith]

Hi,

I've edited parhtml.cxx in ./svtools and now I'd like to test if the 
modification fixes bug 34666. What do I have to do? Is a partial build 
in directory ./svtools enough? Or is there some "install"-step needed? 
Or do I have to do a toplevel make?


Christina Rossmanith


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fix Bug 32559

[Caolán McNamara]

On Wed, 2011-03-16 at 21:45 +0100, Bálint Dózsa wrote:
> Hi,
> 
> Here is a modification. (Shift+F3 is not hardcoded)

Cool, this looks good stuff on first glance. 

Probably a few open questions around handling the e.g. "annotation"
shell for using it inside those insert->comment things, and whether it
should be a writer only feature and/or in calc/draw too.

Not sure about whether we should e.g. reset the mode when moving from
one place to another in the document or detect the current case mode
based on the selection and shift to the next one rather than hook off a
count.

If noone else gets around to this by Fri I'll have a look at sticking
this in.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fix Bug 32559

[Bálint Dózsa]

Hi,

Here is a modification. (Shift+F3 is not hardcoded)

Balint

2011. március 16. 17:56 Bálint Dózsa írta, :

> Thanks for helping.
> I'm working on it
>
> Balint
>
> 2011. március 15. 17:43 Caolán McNamara írta, :
>
> On Wed, 2011-03-09 at 15:50 +0100, Bálint Dózsa wrote:
>> > Hi,
>> >
>> > Here is the correction patch
>>
>> This looks reasonable so far, though it might be better to avoid
>> hardcoding a "case KEY_F3 | KEY_SHIFT" to run this stuff, and instead
>> move it around a bit to make it configurable, (though that seems like a
>> good default)
>>
>> Doing it the configurable way is a bit[1] involved, but here's the rough
>> guide
>>
>> search for something similar, e.g. SID_TRANSLITERATE_TOGGLE_CASE
>>
>> starting at
>> http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/svxids.hrc
>> add a new one, e.g. SID_TRANSLITERATE_ROTATE_CASE
>>
>> In svx/sdi/svx.sdi copy and paste the
>> SfxVoidItem ChangeCaseToToggleCase SID_TRANSLITERATE_TOGGLE_CASE entry
>> to e.g.
>> SfxVoidItem ChangeCaseRotateCase SID_TRANSLITERATE_ROTATE_CASE
>>
>> Where SID_TRANSLITERATE_TOGGLE_CASE appears in the other .sdi files (use
>> opengrok to find them, e.g. sw/sdi/_textsh.sdi) add an entry for
>> SID_TRANSLITERATE_ROTATE_CASE by copying and pasting the
>> SID_TRANSLITERATE_ROTATE_CASE one except change the impl name e.g.
>> ExecTransliteration -> ExecRotateTransliteration
>>
>> For writer you can then implement ExecRotateTransliteration like you've
>> already done to call TransliterateText with a nMode which advances from
>> the previous one on each attempt.
>>
>> In officecfg/registry grep for ChangeCaseToToggleCase and some cut and
>> paste to give yourself a ChangeCaseRotateCase entry in there
>>
>> To set an accelerator key combo for it then see
>> officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
>> Doing is this involved way allows the feature to appear in
>> tools->customize->keyboard etc.
>>
>> C.
>>
>> [1] understatement of the year
>>
>>
>
From db58c931a99edbf2e027bc52688af02c0eaaa92e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?D=C3=B3zsa=20B=C3=A1lint?= 
Date: Wed, 16 Mar 2011 21:28:44 +0100
Subject: [PATCH] FIX BUG 32559

---
 .../data/org/openoffice/Office/Accelerators.xcu|   30 
 .../org/openoffice/Office/UI/GenericCommands.xcu   |5 +++
 svx/inc/svx/svxids.hrc |3 +-
 svx/sdi/svx.sdi|   25 
 4 files changed, 62 insertions(+), 1 deletions(-)

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 04141b3..de1380a 100755
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -1556,6 +1556,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
@@ -2597,6 +2602,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
@@ -3222,6 +3232,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
@@ -3847,6 +3862,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
@@ -4457,6 +4477,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
@@ -5072,6 +5097,11 @@
   .uno:EditGlossary
  
 
+
+ I10N SHORTCUTS - NO TRANSLATE
+  .uno:ChangeCaseRotateCase
+ 
+
 
  I10N SHORTCUTS - NO TRANSLATE
   .uno:JumpToNextFrame
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index ea2485e..c2ec267 100755
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2160,6 +2160,11 @@
 ~tOGGLE cASE
 
 
+
+
+Rotate case (Title Case, UPPERCASE, lowercase)
+
+
 
 
 H~alf-width
diff --git a/svx/inc/svx/svxids.hrc b/svx/inc/svx/svxids.hrc
index 01323c3..9bf3cb6 100755
--- a/svx/inc/svx/svxids.hrc
+++ b/svx/inc/svx/svxids.hrc
@@ -1260,9 +1260,10 @@
 #define SID_TRANSLITERATE_SENTENCE_CASE (SID_SVX_START+11

[Libreoffice] LibreOffice (hackers) event at Dutch congress March 24

[Cor Nouws]

Hi,

This is to notify you that I just posted to the marketing list about a 
event with LibO hackers at a Dutch Congress, March 24.

 See http://listarchives.libreoffice.org/www/marketing/msg02698.html

When there are more people from The Netherlands able to join (part) of 
that day (I have seen some Dutch names here ;-) ) that would be really 
appreciated :-)


Kind regards,
Cor

--
 - http://nl.libreoffice.org
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] SwItemPropertySet

[Christina Roßmanith]

Hi,

during removal of comments it became obvious that 
SwItemPropertySet::FillItem always returns sal_FALSE. Further searching 
for SwItemPropertySet with grok only finds it in unomap.hxx and 
unomap.cxx, ./g grep additionally finds it in binfilter. Does binfilter 
use the binfilter definition of SwItemPropertySet so that I can remove 
it from writer/sw/inc/unomap.hxx and 
writer/sw/source/core/unocore/unomap.cxx?


Christina




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

[Thomas Arnhold]

On 03/12/2011 11:46 PM, Miklos Vajna wrote:
> So far we have 4 .gitattributes files in the root of 4 repos with the
> same contents. To have them in the rest of the repos and avoid
> duplication, it's better to have a single one in the bootstrap repo and
> configure the rest of the repos to use that one.
> 
> I'm attaching two patches:
> 
> 1) is for bootstrap
> 2) is for extensions/filters/libs-gui/testing
> 
> OK to push?

Nice, thanks for this. I did add those *.sdw and *.doc patterns for some
files in one repo. Maybe the list could be completed with other binary
files git has no idea of. I think excel files and some more could be
good to be on that list (there are some of those files in some test
dirs). Maybe this could be an Easy Hack. So I'll add it to the list. Any
appeals?

Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

[Tor Lillqvist]

> I can't find the exact details since which gcc version this 
> has been the case, but I assume that if msvc and gcc are the only compilers 
> we care about, then we could switch to nullptr and #define it ourselves when 
> not provided by the compiler automatically.

Yep.

As it turned out, we decided to revert the switch to use MSVC2010. There was a 
mysterious crash in climaker with MSVC2010 that didn't seem easy to figure out.

So we are still  using MSVC2008 which does not have nullptr (or at least, where 
just using 0 to initialise pointers works fine in those contexts where MSVC2010 
wanted nullptr or an explicitly cast 0).

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

[Lubos Lunak]

On Monday 14 of March 2011, Caolán McNamara wrote:
> On Mon, 2011-03-14 at 04:07 -0600, Tor Lillqvist wrote:
> > is nullptr supported in the gcc versions used on other platforms? So is
> > it better to just use 0 cast to the appropriate  pointer type instead?
>
> AFAIK nullptr is part of c++0x

 Correct.

> and available on gcc >= 4.6.0 in c++0x as 
> a built-in. It might be available in non c++0x-mode with an extra
> include, but as far as I know its not in earlier gccs, so a
> static_cast(0) is probably the best way to go when it
> arises.

 Even older gcc versions have kind of nullptr, namely NULL. I.e. NULL is not 
just 0 or (void*)0, but an internal type called __null that really represents 
a null pointer. I can't find the exact details since which gcc version this 
has been the case, but I assume that if msvc and gcc are the only compilers 
we care about, then we could switch to nullptr and #define it ourselves when 
not provided by the compiler automatically.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fix Bug 32559

[Bálint Dózsa]

Thanks for helping.
I'm working on it

Balint

2011. március 15. 17:43 Caolán McNamara írta, :

> On Wed, 2011-03-09 at 15:50 +0100, Bálint Dózsa wrote:
> > Hi,
> >
> > Here is the correction patch
>
> This looks reasonable so far, though it might be better to avoid
> hardcoding a "case KEY_F3 | KEY_SHIFT" to run this stuff, and instead
> move it around a bit to make it configurable, (though that seems like a
> good default)
>
> Doing it the configurable way is a bit[1] involved, but here's the rough
> guide
>
> search for something similar, e.g. SID_TRANSLITERATE_TOGGLE_CASE
>
> starting at
> http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/svxids.hrc
> add a new one, e.g. SID_TRANSLITERATE_ROTATE_CASE
>
> In svx/sdi/svx.sdi copy and paste the
> SfxVoidItem ChangeCaseToToggleCase SID_TRANSLITERATE_TOGGLE_CASE entry
> to e.g.
> SfxVoidItem ChangeCaseRotateCase SID_TRANSLITERATE_ROTATE_CASE
>
> Where SID_TRANSLITERATE_TOGGLE_CASE appears in the other .sdi files (use
> opengrok to find them, e.g. sw/sdi/_textsh.sdi) add an entry for
> SID_TRANSLITERATE_ROTATE_CASE by copying and pasting the
> SID_TRANSLITERATE_ROTATE_CASE one except change the impl name e.g.
> ExecTransliteration -> ExecRotateTransliteration
>
> For writer you can then implement ExecRotateTransliteration like you've
> already done to call TransliterateText with a nMode which advances from
> the previous one on each attempt.
>
> In officecfg/registry grep for ChangeCaseToToggleCase and some cut and
> paste to give yourself a ChangeCaseRotateCase entry in there
>
> To set an accelerator key combo for it then see
> officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
> Doing is this involved way allows the feature to appear in
> tools->customize->keyboard etc.
>
> C.
>
> [1] understatement of the year
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

[Michaël Lefèvre]

Damned misunderstanding ;)

I've posted the patches once the compilation succeeds yesterday evening.

Michaël

2011/3/16 Michaël Lefèvre :
> Actually not tested :(
> Just keep compiling.
>
> Solar.h
> #define F_PI 3.14159265358979323846
>
> And ftools.h
> #define F_PI M_PI
>
> M_PI defined in OdgExporter.cxx as
> #define M_PI 3.14159265358979323846
>
> Same values.
>
> The value changed in the other constants F_PI*. In solar.h, these are
> fixed, where in ftools.h, they are compute.
>
> By the way, don't know yet how to test it. Just started to hack on LO.
> Any advice more than welcome.
>
> Michaël
>
> On Wed, Mar 16, 2011 at 10:04 AM, Cedric Bosdonnat
>  wrote:
>> Hi Michael,
>>
>> Did you test that your patches didn't introduce a regression? As the two
>> F_PI constants don't have the same value, some bugs can be introduced by
>> using a more precise value.
>>
>> I'll try to have a look at it before the end of the week, many thanks
>> for your patches!
>>
>> On Tue, 2011-03-15 at 23:43 +0100, Michael Lefevre wrote:
>>> Easy hack, constants already defined in 
>>> libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx
>>> ---
>>>  tools/inc/tools/solar.h |   26 --
>>>  1 files changed, 0 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
>>> index 1c1c6ab..e8034b0 100644
>>> --- a/tools/inc/tools/solar.h
>>> +++ b/tools/inc/tools/solar.h
>>> @@ -177,32 +177,6 @@ inline void      DoubleToSVBT64( double n, SVBT64 p ) 
>>> { p[0] = ((BYTE*)&n)[7];
>>>  #endif
>>>  #endif
>>>
>>> -
>>> -/*** standard floating point definitions ***/
>>> -
>>> -#ifndef F_PI
>>> -#define F_PI         3.14159265358979323846
>>> -#endif
>>> -#ifndef F_PI2
>>> -#define F_PI2                1.57079632679489661923
>>> -#endif
>>> -#ifndef F_PI4
>>> -#define F_PI4                0.785398163397448309616
>>> -#endif
>>> -#ifndef F_PI180
>>> -#define F_PI180      0.01745329251994
>>> -#endif
>>> -#ifndef F_PI1800
>>> -#define F_PI1800     0.001745329251994
>>> -#endif
>>> -#ifndef F_PI18000
>>> -#define F_PI18000    0.0001745329251994
>>> -#endif
>>> -#ifndef F_2PI
>>> -#define F_2PI                6.28318530717958647694
>>> -#endif
>>> -
>>> -
>>>  /*** standard macros */
>>>
>>>  #define SWAPSHORT(x) x) >> 8) & 0x00FF) | (((x) & 0x00FF) << 8))
>>
>> --
>> Cédric Bosdonnat
>> LibreOffice hacker
>> http://documentfoundation.org
>> OOo Eclipse Integration developer
>> http://cedric.bosdonnat.free.fr
>>
>>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

[Thorsten Behrens]

Michaël Lefèvre wrote:
> Just keep compiling.
> 
That's ok in this case. Give us a poke if your build succeeds.

Cheers,

-- Thorsten


pgpidvIb1p5rX.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fwd: Re: ICU Build breakage in master on OSX

[Alexander Thurgood]

Below is Caolan's reply to another message of mine, just so it goes on
list, but strange that my previous reply did not go to the list...

Alex

 Message original 
Sujet:  Re: ICU Build breakage in master on OSX
Date :  Wed, 16 Mar 2011 13:32:56 +






On Wed, 2011-03-16 at 09:11 +0100, Alexander Thurgood wrote:
> 
> 
> Le 15/03/11 22:48, Caolán McNamara a écrit :
> 
> Oh good stuff, I repulled from git this morning and icu built, but
> i18npool now fails with :

I don't have a mac so can't see the error for myself, are you able to
dig out any more info, e.g. export VERBOSE=true and/or find out what
files is it processing and what's the text on the line that's causing it
to crap out ?

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] l10n based on PO files

[Thorsten Behrens]

Caolan McNamara wrote:
> On Wed, 2011-03-16 at 08:42 -0600, Tor Lillqvist wrote:
> > Or, just have LibreOffice set a LANGUAGE environment variable to
> > correspond to its current UI language before invoking the libintl
> > functions.
> 
> There's a hack in the gtk fpicker (source/unx/gnome/SalGtkPicker.cxx) to
> do the above, we should probably move that into vcl anyway and do it
> unconditionally on startup.
> 
That was causing all kinds of subtle bugs with the c runtime, 
therefore many of the locale-dependent functions were re-implemented
(e.g. collating, floating point number parsing etc). I'm not sure if
we can control the env fully, all the time -

Regarding gettext, I have a slight reservation - we'd be strongly 
depending on correct context, otherwise short strings from different
places will all be mixed up. I gather this will be mostly manual
work?

Cheers,

-- Thorsten


pgpRgyNVpSsXJ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] l10n based on PO files

[Caolán McNamara]

On Wed, 2011-03-16 at 08:42 -0600, Tor Lillqvist wrote:
> Or, just have LibreOffice set a LANGUAGE environment variable to
> correspond to its current UI language before invoking the libintl
> functions.

There's a hack in the gtk fpicker (source/unx/gnome/SalGtkPicker.cxx) to
do the above, we should probably move that into vcl anyway and do it
unconditionally on startup.

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] l10n based on PO files

[Tor Lillqvist]

> Thorsten, Tor, Fridrich, do you know if .mo files (pure gettext
> solution) would work on Windows and MAC?

You mean at LibreOffice run-time? Sure, libintl (gettext's 
gettext-runtime/intl) is portable just fine to Windows. After all, all it does 
is open and read files.

Some slight tweaks to the libintl source code might be needed to make sure the 
right language gets selected. Or, just have LibreOffice set a LANGUAGE 
environment variable to correspond to its current UI language before invoking 
the libintl functions.

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] l10n based on PO files

[Petr Mladek]

Thorsten, Tor, Fridrich, please read the question at the end of the
mail.

Christian Lohmaier píše v Po 14. 03. 2011 v 23:06 +0100:
> Hi Andras,
> 
> On Mon, Mar 14, 2011 at 6:28 PM, Andras Timar  wrote:

> > The proposed l10n workflow is the following. I provide en-US.sdf and
> > pot files regularly (let say bi-weekly). en-US.sdf and pot files can
> > be generated with the makefile.mk of the 'translations' module. I also
> > update Pootle. Before release, I get translations from Pootle (or from
> > external sources) and commit them to git.
> 
> OK, so pootle is the tool used, you don't actually commit the po(t)
> files to the repository after each change. If pootle is mediator
> anyway, I don't see the reason why the english string should be part
> of every po file in the sourcetree.

I am not sure if pootle is the mediator for every localization. I think
that some translation teams prefers they own framework and just provide
updated .po files.

BTW: .po files would help us to get rid of the non-standard .sdf
and .res files. It would be nice to use a pure gettext solution.

Kendy has got an idea that a GSoC student would implement the switch
from .res files to .mo files.

Thorsten, Tor, Fridrich, do you know if .mo files (pure gettext
solution) would work on Windows and MAC?


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] remove String with OUString

[Caolán McNamara]

On Wed, 2011-03-16 at 13:55 +0100, Xisco Faulí wrote:
> Hello,
> 
> It's the first time I do it so I searched for previous commits  in
> order to get a referent. i couldn't find any example for
> String.AssignAscii so I replace it with OUStringBuffer.appendAscii.

Yeah, that's probably the best route.

However there's a little bug in the new Dbg_SbxDataType2String impl, the
old one had...

String aRet( RTL_CONSTASCII_USTRINGPARAM("Unknown Sbx-Type!") );
...
aRet = something
...
return aRet;

while the new one has...

::rtl::OUStringBuffer aRet;
aRet.appendAscii("Unknown Sbx-Type!");
...
aRet.appendAscii("something");

i.e. now its "Unknown Sbx-Type!something" instead of "something". so
that one needs fixing.

>  Another doubt i have is how can I replace String.ConvertLineEnd() ?

Hmm, I guess we'd have to add something for that, e.g. create a helper
in comphelper/inc/comphelper/string.hxx

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] development summary: year 2011, week 10

[Petr Mladek]

Hi,

this time a brief summary of what happened during the 10th week in 2011
on LibreOffice repositories and the living branches:

+ master:hot LO-3.4 development
+ libreoffice-3-3:   fixes for next LO-3.3.x bug fix release
+ libreoffice-3-3-2: final stabilization for LO-3.3.2 release

There are two logs for each branch:

+ bugfixes--week--.txt lists all commits that 
reference a proper
  bug id from a variety of trackers, i.e. #i... referring to the 
OpenOffice
  issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla

+ commit-log--week--.txt lists all relevant commits 
on the actual
  source repositories


Many thanks to all contributors - you make all the difference!


Best Regards,
Petr
+ build
+ l10n: en-US fallback strings for incomplete translations (fdo#33189) 
[Andras Timar]
+ calc
+ make sure these values are positive; we use them to resize arrays. 
(fdo#34350) [Kohei Yoshida]
+ properly invalidate cached sheet XML streams during reference update. 
(i#116833) [Kohei Yoshida]
+ filters
+ resolves (fdo#34909) [Noel Power]
+ libs-core
+ some pythonsamples not visible on Mac OS X (fdo#34699) [Christian 
Lohmaier]
+ libs-gui
+ fix for 3.3.2 blocker - change the type of nDrawerHeight to long 
(fdo#34718) [Radek Doulik]
+ build
+ fixed regression of copy-paste of Writer table formulas (bnc#675961) 
[Cédric Bosdonnat]
+ l10n: en-US fallback strings for incomplete translations (fdo#33189) 
[Andras Timar]
+ calc
+ make sure these values are positive; we use them to resize arrays. 
(fdo#34350) [Kohei Yoshida]
+ properly invalidate cached sheet XML streams during reference update. 
(i#116833) [Kohei Yoshida]
+ filters
+ resolves (fdo#34909) [Noel Power]
+ libs-core
+ some pythonsamples not visible on Mac OS X (fdo#34699) [Christian 
Lohmaier]
+ writer
+ fix the positions of imported fields to avoid crashes (bnc#663622) 
[Cédric Bosdonnat]
+ calc
+ properly invalidate cached sheet XML streams during reference update. 
(i#116833) [Kohei Yoshida]
+ components
+ color palette size (8x13), only show scrollbar when needed (fdo#34896) 
[Xavier ALT]
+ filters
+ fix placeholder text style (bnc#650026) [Radek Doulik]
+ libs-core
+ getSelectEntry is far more likely correct (fdo#34635) [Caolán McNamara]
+ make color palette size consistent (8x13) (fdo#34896) [Xavier ALT]
+ make the code easier to understand by using constants (fdo#30917) 
[Sébastien Le Ray]
+ some pythonsamples not visible on Mac OS X (fdo#34699) [Christian 
Lohmaier]
+ storing the hierarchical view of style browser (fdo#30917) [Gert Faller]
+ libs-extern-sys
+ l10n: update de_CH and de_AT dictionaries (fdo#33751) [Andras Timar]
+ libs-gui
+ avoid race condition with multiple window resizing (bnc#674806) [Luboš 
Luňák]
+ better resizing of overtall glyphsubs (rhbz#682621) [Caolán McNamara]
+ break graphemes on new updates, use ICU for script identification 
(uax#29) [Martin Hosken]
+ fix for 3.3.2 blocker - change the type of nDrawerHeight to long 
(fdo#34718) [Radek Doulik]
+ handle tinkering with '-N => (N)' number format - (bnc#659993) [Katarina 
Machalkova]
+ pa-IN isn't handled by fontconfig well (rhbz#682716, fdo#35118) [Caolán 
McNamara]
+ related: make sure this is thread safe (rhbz#684477) [Caolán McNamara]
+ related: reorganize this to make it inheritable (rhbz#680460) [Caolán 
McNamara]
+ revert "Introducing new number format ( -N => (N) ) -" (bnc#659993) 
[Katarina Machalkova]
+ ure
+ using the Linaro gcc 4.5 generated code instead (lp#726529) [Jani Monoses]
+ writer
+ fix the positions of imported fields to avoid crashes (bnc#663622) 
[Cédric Bosdonnat]
+ restore FormatBlock (fdo#34920) [Caolán McNamara]
+ common
+ branch libreoffice-3-3-2 [Petr Mladek]
+ version 3.3.2.1, tag libreoffice-3.3.2.1 (3.3.2-rc1) [Petr Mladek]
+ bootstrap
+ bump product version to 3.3.2rc1, release number to 201 [Petr Mladek]
+ do not create OxygeOffice rpms for LibreOffice build [Petr Mladek]
+ introduce OxygenOffice as a product [Kalman Szalai - KAMI]
+ build
+ delete fallback strings which were translated between rc1 and rc2 [Andras 
Timar]
+ fix buildfix patches - OxygenOffice introduction [Kalman Szalai - KAMI]
+ fix download for all 3.3.x source release [Gökçen Eraslan]
+ l10n: Updated translations from Pootle [Andras Timar]
+ l10n: en-US fallback strings for incomplete translations (fdo#33189) 
[Andras Timar]
+ l10n: update Khmer (km) translation [Khoem Sokhem]
+ l10n: update translations from Pootle [Andras Timar]
+ make vba-container-controls apply again [Noel Power]
+ one more fix to make vba-container-controls.diff apply again [Petr Mladek]
+ calc
+ make sure these values are positive; we use them to resize arrays. 
(fdo#34350) [Kohei Yoshida]
+ properly invalidate cached sheet 

Re: [Libreoffice] Compiled still failed in instsetoo_native after compiling a brand new local repository

[Petr Mladek]

Hi,

I have just come across this mail. It is better to answer it late than
newer,

Julien Nabet píše v Čt 10. 03. 2011 v 00:03 +0100:
> Hello,
> 
> After having removed all my local repository, refetch (from master) and 
> rebuild the whole thing, i still got this in instsetoo_native :
> Package format: archive
> msi templatepath: 
> /home/maryline/compile-libreoffice/libo/instsetoo_native/util/../unxlngi6.pro/misc/openoffice/msi_templates
> msi template path will be ignored for non Windows builds!
> msi languagepath: 
> /home/maryline/compile-libreoffice/libo/instsetoo_native/util/../unxlngi6.pro/misc/win_ulffiles
> msi language path will be ignored for non Windows builds!
> Calling epm
> Stripping files
> Unzip ARCHIVE files
> services.rdb can be created
> Languages:
>  en-US
> 
> ... checking required files ...
> .. searching zip ...
>  Found: /usr/bin/zip
> ... analyzing ../util/openoffice.lst ...
> rmdir: failed to remove 
> `/home/maryline/compile-libreoffice/libo/instsetoo_native/unxlngi6.pro/LibreOffice/archive/logging/':
>  
> Directory not empty
> ... reading include pathes ...
> ... analyzing script: 
> /home/maryline/compile-libreoffice/libo/solver/330/unxlngi6.pro/bin/setup_osl.ins
>  
> ...
> ... analyzing directories ...
> ... analyzing files ...
> ... analyzing scpactions ...
> ... analyzing shortcuts ...
> ... analyzing unix links ...
> ... analyzing profile ...
> ... analyzing profileitems ...
> ... analyzing modules ...
> 
> ... languages en-US ...
> ... analyzing files ...
> ERROR: The following files could not be found:
> ERROR: File not found: accessoriesgallery.zip
> ERROR: File not found: accessoriesgallerydrawspeople.zip
> ERROR: File not found: accessoriesgalleryelementsbullets2.zip
> ERROR: File not found: accessoriesgallerynonfree.zip
> ERROR: File not found: accessoriesgalleryphotosbuildings.zip
> ERROR: File not found: accessoriesgalleryphotoscelebration.zip
> ERROR: File not found: accessoriesgalleryphotoscities.zip
> ERROR: File not found: accessoriesgalleryphotosfauna.zip
> ERROR: File not found: accessoriesgalleryphotosflowers.zip
> ERROR: File not found: accessoriesgalleryphotosfoodsanddrinks.zip
> ERROR: File not found: accessoriesgalleryphotoshumans.zip
> ERROR: File not found: accessoriesgalleryphotoslandscapes.zip

I guess that this is related to --enable-extra-gallery

> ...
> ERROR: File not found: zektonit.ttf
> ERROR: File not found: zorque.ttf

This might be related to --enable-extra-font

I guess that it did not fetch the needed files and the build silently
failed.

KAMI, it is your stuff. Could you please have a look?

> ... cleaning the output tree ...
> ... removing directory /tmp/ooopackaging/i_189121299711529 ...
> 
> **
> ERROR: ERROR: Missing files
> in function: remove_Files_Without_Sourcedirectory
> **
> 
> gcc (Debian 4.4.5-11) (x86)
> autogen.lastrun contains this :
> '--enable-ext-barcode' '--enable-ext-diagram' 
> '--enable-ext-google-docs--enable-ext-hunart' '--enable-ext-lightproof' 
> '--enable-ext-lightproof' '--enable-ext-mysql-connector' 
> '--enable-ext-nlpsolver' '--enable-ext-numbertext' 
> '--enable-ext-oooblogger' '--enable-ext-pdfimport' 
> '--enable-ext-presenter-console' '--enable-ext-presenter-minimizer' 
> '--enable-ext-presenter-ui' '--enable-ext-report-builder' 
> '--enable-ext-scripting-beanshell' '--enable-ext-scripting-javascript' 
> '--enable-ext-scripting-python' '--enable-ext-typo' 
> '--enable-ext-validator' '--enable-ext-watch-window' 
> '--enable-ext-wiki-publisher' '--enable-graphite' '--enable-evolution2' 
> '--enable-epm' '--enable-dbus' '--enable-gio' '--enable-kde4' 
> '--enable-binfilter' '--enable-extra-gallery' '--enable-extra-template' 
> '--enable-extra-sample' '--enable-extra-font' '--with-system-mysql' 
> '--disable-gnome-vfs'

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

[Miklos Vajna]

On Wed, Mar 16, 2011 at 10:31:51AM +0100, Jan Holesovsky  wrote:
> I would say so :-)  Or - we could create links like we do for the hooks?
> It would make it more obvious what is going on...

Sure, done. :)


pgpg7QR54iqzT.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][PUSHED] de_AT and de_CH dictionary update - fdo#33751

[Petr Mladek]

Fridrich Strba píše v Út 15. 03. 2011 v 15:45 +0100:
> As I mentioned in the bug, I sign off for this one :)
> 
> F.
> 
> On 15/03/11 14:40, Michael Meeks wrote:
> >
> > On Sun, 2011-03-13 at 21:49 +0100, Andras Timar wrote:
> >> I ask you to cherry-pick this commit to libreoffice-3-3 and
> >> libreoffice-3-3-2. Let's have all German dictionaries at the same
> >> version.
> >
> > Looks fine to me too :-)

Just for record. This was the third approval, so I have cherry picked it
to the libreoffice-3-3-2 branch yesterday. It will be in 3.3.2-rc2.


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

[Michaël Lefèvre]

Actually not tested :(
Just keep compiling.

Solar.h
#define F_PI 3.14159265358979323846

And ftools.h
#define F_PI M_PI

M_PI defined in OdgExporter.cxx as
#define M_PI 3.14159265358979323846

Same values.

The value changed in the other constants F_PI*. In solar.h, these are
fixed, where in ftools.h, they are compute.

By the way, don't know yet how to test it. Just started to hack on LO.
Any advice more than welcome.

Michaël

On Wed, Mar 16, 2011 at 10:04 AM, Cedric Bosdonnat
 wrote:
> Hi Michael,
>
> Did you test that your patches didn't introduce a regression? As the two
> F_PI constants don't have the same value, some bugs can be introduced by
> using a more precise value.
>
> I'll try to have a look at it before the end of the week, many thanks
> for your patches!
>
> On Tue, 2011-03-15 at 23:43 +0100, Michael Lefevre wrote:
>> Easy hack, constants already defined in 
>> libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx
>> ---
>>  tools/inc/tools/solar.h |   26 --
>>  1 files changed, 0 insertions(+), 26 deletions(-)
>>
>> diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
>> index 1c1c6ab..e8034b0 100644
>> --- a/tools/inc/tools/solar.h
>> +++ b/tools/inc/tools/solar.h
>> @@ -177,32 +177,6 @@ inline void      DoubleToSVBT64( double n, SVBT64 p ) { 
>> p[0] = ((BYTE*)&n)[7];
>>  #endif
>>  #endif
>>
>> -
>> -/*** standard floating point definitions ***/
>> -
>> -#ifndef F_PI
>> -#define F_PI         3.14159265358979323846
>> -#endif
>> -#ifndef F_PI2
>> -#define F_PI2                1.57079632679489661923
>> -#endif
>> -#ifndef F_PI4
>> -#define F_PI4                0.785398163397448309616
>> -#endif
>> -#ifndef F_PI180
>> -#define F_PI180      0.01745329251994
>> -#endif
>> -#ifndef F_PI1800
>> -#define F_PI1800     0.001745329251994
>> -#endif
>> -#ifndef F_PI18000
>> -#define F_PI18000    0.0001745329251994
>> -#endif
>> -#ifndef F_2PI
>> -#define F_2PI                6.28318530717958647694
>> -#endif
>> -
>> -
>>  /*** standard macros */
>>
>>  #define SWAPSHORT(x) x) >> 8) & 0x00FF) | (((x) & 0x00FF) << 8))
>
> --
> Cédric Bosdonnat
> LibreOffice hacker
> http://documentfoundation.org
> OOo Eclipse Integration developer
> http://cedric.bosdonnat.free.fr
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

[Jan Holesovsky]

Hi Miklos,

On 2011-03-12 at 23:46 +0100, Miklos Vajna wrote:

> So far we have 4 .gitattributes files in the root of 4 repos with the
> same contents. To have them in the rest of the repos and avoid
> duplication, it's better to have a single one in the bootstrap repo and
> configure the rest of the repos to use that one.
> 
> I'm attaching two patches:
> 
> 1) is for bootstrap
> 2) is for extensions/filters/libs-gui/testing
> 
> OK to push?

I would say so :-)  Or - we could create links like we do for the hooks?
It would make it more obvious what is going on...

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

[Cedric Bosdonnat]

Hi Michael,

Did you test that your patches didn't introduce a regression? As the two
F_PI constants don't have the same value, some bugs can be introduced by
using a more precise value.

I'll try to have a look at it before the end of the week, many thanks
for your patches!

On Tue, 2011-03-15 at 23:43 +0100, Michael Lefevre wrote:
> Easy hack, constants already defined in 
> libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx
> ---
>  tools/inc/tools/solar.h |   26 --
>  1 files changed, 0 insertions(+), 26 deletions(-)
> 
> diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
> index 1c1c6ab..e8034b0 100644
> --- a/tools/inc/tools/solar.h
> +++ b/tools/inc/tools/solar.h
> @@ -177,32 +177,6 @@ inline void  DoubleToSVBT64( double n, SVBT64 p ) { 
> p[0] = ((BYTE*)&n)[7];
>  #endif
>  #endif
>  
> -
> -/*** standard floating point definitions ***/
> -
> -#ifndef F_PI
> -#define F_PI 3.14159265358979323846
> -#endif
> -#ifndef F_PI2
> -#define F_PI21.57079632679489661923
> -#endif
> -#ifndef F_PI4
> -#define F_PI40.785398163397448309616
> -#endif
> -#ifndef F_PI180
> -#define F_PI180  0.01745329251994
> -#endif
> -#ifndef F_PI1800
> -#define F_PI1800 0.001745329251994
> -#endif
> -#ifndef F_PI18000
> -#define F_PI180000.0001745329251994
> -#endif
> -#ifndef F_2PI
> -#define F_2PI6.28318530717958647694
> -#endif
> -
> -
>  /*** standard macros */
>  
>  #define SWAPSHORT(x) x) >> 8) & 0x00FF) | (((x) & 0x00FF) << 8))

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice