Re: [Libreoffice] GNU cp dependency
Hey Bjoern, On Sun, Mar 20, 2011 at 01:05:07AM +0100, Bjoern Michaelsen wrote: On Sat, 19 Mar 2011 06:09:10 +0100 Francois Tigeot ftig...@wolfpond.org wrote: Well, all my builds of the last few month were run without it. That is luck and you dont want to count on that. Anyone using a variable GNUCOPY in the old build system has every right to expect it to contain a GNU cp. It was not luck, there was some conditional code to use either GNU or straight cp. It may have been a hack though. Neat. Is there a timeframe for that ? As soon as you have migrated all modules to the new system. ;D Okay. Maybe sometime in 2021 then :p I'm runnning DragonFly and the behavior has clearly changed. Should I remove/change the test in configure.in ? You could set GNUCOPY to empty (on BSD as on OSX) if there isnt one available. Likely you will get breakers now on BSD from that and issues might pop up again now and then as long as the old build system is around I have bigger build issues to tackle for now. Since the new code has fixed the gnu cp location issue, I have simply added a --with-gnu-cp knob in my autoconf.sh line. Honestly, I think the time spend on working around the awkwardness of the old build system is better spend on migrating to the new build system though. I completely agree. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] _OLD_FILE_IMPL
Hi Christina, On 03/20/2011 12:47 PM, Christina Roßmanith wrote: the definition of _OLD_FILE_IMPL is commented out in basic/source/inc/runtime.hxx. So I could remove the parts which are #ifdef'ed with _OLD_FILE_IMPL and remove the #ifndef _OLD_FILE_IMPL statements? Or could _OLD_FILE_IMPL get defined during the build process? As I see this it doesn't get defined during the build. So you could remove this! Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Move DBG_ERROR[1-9] to OSL_TRACE
Thomas Arnhold wrote: Has anyone objections about this new behavior? I guess having the old behaviour (i.e. abort or msgbox) restored would be good - though clearly the whole assertion concept (and how we handle their occurence) needs a lot of love ... Cheers, -- Thorsten pgpo173LHiwTb.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] comment unnecessary?
yeah, it's right, the code looks as follow: OSL_ENSURE( aInfo.mpOldBasicPassword, ImplRepository::impl_createManagerForModel: wrong BasicLibraries implementation! ); pBasicManager-SetLibraryContainerInfo( aInfo ); //pBasicCont-setBasicManager( pBasicManager ); // that's not needed anymore today. The containers will retrieve their associated // BasicManager from the BasicManagerRepository, when needed. // initialize the containers impl_initDocLibraryContainers_nothrow( xBasicLibs, xDialogLibs ); So it can be deleted because it refers to //pBasicCont-setBasicManager( pBasicManager ); 2011/3/20 Christina Roßmanith chrrossman...@web.de Hi, I'm reviewing and applying patches removing commented code. What about the following lines from source/basmgr/basicmanagerrepository.cxx? //pBasicCont-setBasicManager( pBasicManager ); // that's not needed anymore today. The containers will retrieve their associated // BasicManager from the BasicManagerRepository, when needed. I have the feeling, that the text-comment belongs to the commented line of code above. Is that true? In that case it can be removed as well (I'll do that if I get an ok for that). Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] problems building basic
Hi, I did a ./g pull -r yesterday (Saturday). After applying patches I'd like to build basic. It fails with /bin/bash: /Amanda/LibreOffice3/libo/solver/300/unxlngi6.pro/bin/rscdep: No such file or directory The error message is correct, but instead there is /Amanda/LibreOffice3/libo/solver/330/unxlngi6.pro/bin/rscdep. Note 330 instead of 300. What has to be changed that the correct directory is used? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments.
Hi Christoph, here are the translations of the terms as they are used in the Styles and Formatting window. German: Textkörper Einrückung - English: Text body indent German: Textkörper Einzug negativ - English: Hanging indent German: Textkörper Einzug - English: First line indent German: Grußformel - English: Complimentary close German: Gegenüberstellung - English: List indent Kind regards Regina Christoph Herzog schrieb: Hi, there are still some problems with the translation of comments in the patch attached. Despite my best efforts I was unable to figure out the meaning of several critical comments: RES_POOLCOLL_TEXT_IDENT: Is that text body indent? RES_POOLCOLL_TEXT_MOVE: Is that hanging? I also failed to see what style RES_POOLCOLL_CONFRONTATION would be and whether RES_POOLCOLL_GREETING would be salutation or rather Complimentary Close (there is style with this name). I have marked those with //TODO in the patch so it can be found and corrected easily by someone more competent than me. Thanks for your patience. Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translate German comments.
Hi Regina,
Thank you very much! I have reworked the patch following your guidelines
and included it below.
Unless there are other problems with it, I will push it tomorrow.
Best
Christoph
On 03/20/2011 11:02 PM, Regina Henschel wrote:
German: Textkörper Einrückung - English: Text body indent
German: Textkörper Einzug negativ - English: Hanging indent
German: Textkörper Einzug - English: First line indent
German: Grußformel - English: Complimentary close
German: Gegenüberstellung - English: List indent
there are still some problems with the translation of comments in the
patch attached. Despite my best efforts I was unable to figure out the
meaning of several critical comments:
RES_POOLCOLL_TEXT_IDENT: Is that text body indent?
RES_POOLCOLL_TEXT_MOVE: Is that hanging?
I also failed to see what style RES_POOLCOLL_CONFRONTATION would be and
whether RES_POOLCOLL_GREETING would be salutation or rather
From 8734ac13a7c6db154dd7e2b31d6f81204080debd Mon Sep 17 00:00:00 2001
From: Christoph Herzog rho...@googlemail.com
Date: Sun, 20 Mar 2011 23:05:15 +0100
Subject: [PATCH] Translate German comments.
---
sw/inc/poolfmt.hxx | 486 ++--
1 files changed, 242 insertions(+), 244 deletions(-)
diff --git a/sw/inc/poolfmt.hxx b/sw/inc/poolfmt.hxx
index 56ef5dd..07a777f 100644
--- a/sw/inc/poolfmt.hxx
+++ b/sw/inc/poolfmt.hxx
@@ -34,45 +34,41 @@
// POOLCOLL-IDs:
// ++---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+
-// !User!Bereich! 0 ! Offset !
+// !User!Range ! 0 ! Offset !
// ++---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+
//
-// Bereich: 1 - Text
-// 2 - Listen
-// 3 - Sonderbereiche
-// 4 - Verzeichnisse
-// 5 - Kapitel / Dokument
-// 6 - HTML-Vorlagen
-
-// Andere IDs:
+// Range: 1 - text
+// 2 - lists
+// 3 - special ranges
+// 4 - indices
+// 5 - chapter / document
+// 6 - HTML-styles.
+
+// Other IDs:
// ++---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+
-// !User!Bereich! 1 ! Offset !
+// !User!Range ! 1 ! Offset !
// ++---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+
-// Bereich: 0 - Zeichenvorlagen
-// 1 - Frame-Vorlagen
-// 2 - Seitenvorlagen
-// 3 - Absatzformate (?)
-// 4 - Grafikformate (?)
+// Range: 0 - character styles
+// 1 - frame styles
+// 2 - page styles
+// 3 - paragraph styles (?)
+// 4 - graphics styles (?)
-// F�r alle IDs gilt:
-// Herkunft: 0 -Pool
-// 1 -Benutzer
-// Offset: innerhalb der Gruppe
+// For all IDs we have:
+// Origin: 0 -pool
+// 1 -user
+// Offset: within the group
-// !!!
-//
-// ACHTUNG: neue ID's koennen nur noch am Ende der jeweiligen Gruppe
-// zugefuegt werden. Diese Id's werden vom Reader/Writer ge-
-// lesen und geschrieben. Diese kennen nur den Offset zum Start
-//
-// !!!
+// Attention: New IDs can only be added to the ends of the groups.
+// These IDs are read and written by the Reader/Writer.
+// They are only aware of the Offset to Start.
-// Maske fuer Erkennung von COLLPOOL-Ids:
+// Mask for recognition of COLLPOOL-IDs:
const sal_uInt16 POOLGRP_NOCOLLID = (1 10);
-// POLLCOLL-Gruppen:
+// POLLCOLL-groups:
const sal_uInt16 USER_FMT = (1 15);
const sal_uInt16 POOL_FMT = (0 15);
@@ -85,14 +81,14 @@ const sal_uInt16 COLL_DOC_BITS = (5 11);
const sal_uInt16 COLL_HTML_BITS = (6 11);
const sal_uInt16 COLL_GET_RANGE_BITS= (15 11);
-// Sonstige Gruppen:
+// Other groups:
const sal_uInt16 POOLGRP_CHARFMT= (0 11) + POOLGRP_NOCOLLID;
const sal_uInt16 POOLGRP_FRAMEFMT = (1 11) + POOLGRP_NOCOLLID;
const sal_uInt16 POOLGRP_PAGEDESC = (2 11) + POOLGRP_NOCOLLID;
const sal_uInt16 POOLGRP_NUMRULE = (3 11) + POOLGRP_NOCOLLID;
-// fuer Erkennung ob Benutzer-Vorlage oder nicht:
+// Recognize whether it's a user defined style or not:
const sal_uInt16 POOL_IDUSER_FMT =
USHRT_MAX ~(COLL_GET_RANGE_BITS + POOLGRP_NOCOLLID);
@@ -104,50 +100,51 @@ inline sal_Bool IsPoolUserFmt( sal_uInt16 nId )
}
-// ID-s fuer die Bereiche
+
+// IDs for the ranges.
enum RES_POOLFMT
{
-RES_POOLFMT_BEGIN = 1, // HIER GEHT'S LOS !!!
+RES_POOLFMT_BEGIN = 1,
RES_POOL_CHRFMT = RES_POOLFMT_BEGIN,
RES_POOL_FRMFMT,
RES_POOL_TXTCOLL,
RES_POOL_PAGEFMT,
-RES_POOL_PARFMT, // ???
[Libreoffice] [BUG 32598] How to access the current document from a MediaWindow?
Hello, all! I am Skyler Hawthorne, and I am a student hoping to work with LibreOffice on this year's Summer of Code. I am working on a BS in Computer Science, currently finishing up my lower division courses at a community college before I transfer to California State University, Northridge. My nickname on the IRC channel is cosmopolitan. Now that introduction is out of the way, I was hoping someone could help me with a bug! As per the LO GSoC Wiki ( http://wiki.documentfoundation.org/Development/GSoc ), I am working on an EasyHack bug. I chose Bug #32598 ( https://bugs.freedesktop.org/show_bug.cgi?id=32598 ). I assume that there is some function called something like setChanged() or something to that effect that just needs to be added to the code that controls the video. Using opengrok, I found that mediawindow.cxx appears to control Mute and Repeat with its setMute() and setPlayBackLoop() functions, respectively. From here, I was just going to add the call to the function that broadcasts the document's modification, but I don't see any getSdDrawDocument() function, or any other that grabs the current document. MediaWindow does not inherit anything, and I've been unable to find the function on opengrok, so I've run out of places to look. Can someone help me find the function that returns the current document? And for those knowledgeable, would my proposed fix be sufficient? Thanks in advance -- Skyler Hawthorne a.k.a. Cosmopolitan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
