Re: [Libreoffice] [libreoffice-l10n] [ANN] Preview builds of 3.4 rc2 available

[Cor Nouws]

Hi Thorsten,

Thorsten Behrens wrote (25-05-11 17:28)

http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes.


None of those found by me in the short testing up until now.

Related question: bug which cause data loss should be included in the 
release notes?

  E.g. #35345, #37584 (that I know of)

Cheers - Cor


--
 - http://nl.libreoffice.org
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoc] Progress report - Visio import filter

[Fridrich Strba]

Hello, Eilidh,

In our private conversation you asked for some guidance about how to
structure the library. Here are my basic thoughts (that are again my
thoughts that come from having contributed to several libraries, but
they are not the God's word):

1) Since you will have to parse quite often compressed chunks of stream,
it would maybe be useful to write some class like the following one:

class VSDInternalStream : public WPXInputStream
{
public:
VSDInternalStream(WPXInputStream *input, size_t dataSize, bool
isCompressed);
~VSDInternalStream();
(...)
private:
std::vectorunsigned char m_buffer;
VSDInternalStream();
VSDInternalStream(const VSDInternalStream)
};

That would be constructed by reading the input of dataSize into the
m_buffer and if needed it would decompress it on the fly if it is
compressed. Like that you would have this task that will be quite
frequent one in one place. The advantage would be that the resulting
stream would be seakable and you would just read it as any other
WPXInputStream.

2) Since in the isSupported function I see that you are distinguishing
two versions of Visio Document, I would suggest that you write a base
parser class something like:

class VSDXParser
{
public:
VSDXParser(WPXInputStream *input);
~VSDXParser();
protected:

private:

};

That would contain common functions for all the formats as long as the
common state that you will need to keep. It could have two derived
classes for the n=11 and n=6 

class VSDnParser : protected VSDXParser
{
public:
VSDnParser(WPXInputStream *input);
~VSDnParser();
parse(libwpg::WPGPaintInterface *iface);
private:

};

Those ones would contain functions specific for the given file-format
version as well as specific state information that cannot be extracted
into the VSDXParser.

Now in the VisioDocument::parse(...) function, one could detect which
file-format we are parsing, construct the corresponding VSDnParser and
call the parse on it.

3) As to the development process, I would suggest to first have some dry
parsing in place, with functions that read the different elements of the
Visio document without processing them really. You can plant several
VSD_DEBUG_MSG((...)); statements inside the functions (include the
libvisio_utils.h and optionally un-comment for the time of heavy
development the #define VERBOSE_DEBUG=1). Doing so, you get maximum of
information on your console without actually the parser calling any of
the interface callbacks. Then you can start from there by actually
processing the useful content.

Myself I would write maybe a VSDElement class that would construct
itself by getting the pointer to the current input stream and would have
some kind of processContent function that will decide whether to call
private _readContent(...) for supported elements and _skipContent(...)
for unsupported elements. But again, this is too much of implementation
details and I can clearly confess that I have a bias from what we did in
libwpd and libwpg.

4) The bottom line of a good FOSS development model is to push often
small changes. It has two big advantages:
a) it is easier to bisect changes when something broke;
b) it gives nice overview of progress.
If atomic changes are committed and pushed (or at least the day's work
at the end of the day), I will be able to look at it often and pat your
back if the things are wonderful, marvelous, beyond the wildedst
immagination; or ask questions, seek clarification and discuss
directions if needed. Communication is the main challenge of any GSoC
endavour and git repository can help us to get it right.
Sometimes, GSoC students are scared that pushing publicly code of
questionable quality would be detrimental for them when a prospective
employer googles for their work. This is largely a myth and the evidence
is that if that was true, I would probably have to have spent all my
life living on social help :)

Happy hacking

Fridrich

On Sun, 2011-05-08 at 17:08 +0100, Tibby Lickle wrote:
 Hi,
 
 Just an update on where I am. So far I've been working on the basics
 of extracting the data from the .vsd file.
 To read Visio files, the steps are roughly:
 1. Get the interesting part (VisioDocument) from the OLE container.
 2. Parse the header to get a pointer to the trailer stream (as well as
 version, length of file, etc.)
 3. Inflate compressed trailer.
 4. Parse out pointers in trailer to the various - potentially
 compressed - streams that hold the actual Visio document content.
 
 I've done 1 - 3. I'm using the WPXStream and its implementation from
 libwpd (WPXStreamImplementation.h here) to read/extract OLE streams.
 The implementation of LZW-esque decompression of the trailer is
 translated from Python to C++ (i.e. shamelessly ripped off) from
 oletoy (thanks frob). 
 I suspect most of what I'll be doing will be stand-alone for now -
 developing and debugging will be too slow if LO integration is
 included at this early stage. Once I've got a very basic parser, the
 callback 

[Libreoffice] Works LO connector with HTTPS ?

[Fernand Vanrie]

I Trye to use the latest Google Tasks API from in LO but now we need to 
connect with HTTPS
please can a developer tell me if my code had a change to work no or in 
the future ?


oConnector = createUnoService(com.sun.star.connection.Connector)
oConnection = 
oConnector.connect(socket,host=www.googleapis.com,port=80)  'or port 
(443)'
oConnection.write( StringToByteArray( GET 
https://www.googleapis.com/tasks/v1/lists/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDow/tasks/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDo4?pp=1key={YOUR_API_KEY};  
+ cCR + cLF ))


Greetz Fernand

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] about fonts embedding error

[Edmund Laugasson]

Hi everyone!

I would like to ask - is there any bug with fonts embedding? I tried to 
embed all fonts but they didn't - still were there misunderstandable 
signs...


I found the following bug - 
https://bugs.freedesktop.org/show_bug.cgi?id=36829 - I added also my 
example there.


Does anybody know - will this bug be fixed in the version 3.4.0 or 3.4.1?


Thank you in Advance,
Edmund Laugasson
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoc] Progress report - Visio import filter

[Cedric Bosdonnat]

Hi Fridrich, Eilidh,

On Thu, 2011-05-26 at 09:39 +0200, Fridrich Strba wrote:
 In our private conversation you asked for some guidance about how to
 structure the library. Here are my basic thoughts (that are again my
 thoughts that come from having contributed to several libraries, but
 they are not the God's word):

Good that you bring that conversation public Fridrich :)

 2) Since in the isSupported function I see that you are distinguishing
 two versions of Visio Document, I would suggest that you write a base
 parser class something like:
 
 class VSDXParser
 {
 public:
 VSDXParser(WPXInputStream *input);
 ~VSDXParser();
 protected:
 
 private:
 
 };
 
 That would contain common functions for all the formats as long as the
 common state that you will need to keep. It could have two derived
 classes for the n=11 and n=6 

Indeed that's more oriented-object way of coding. That's what we already
did in the DOC / DOCX / RTF export in sw, saves a lot of work and keeps
the code much cleaner.

 Now in the VisioDocument::parse(...) function, one could detect which
 file-format we are parsing, construct the corresponding VSDnParser and
 call the parse on it.

Yes!

 3) As to the development process, I would suggest to first have some dry
 parsing in place, with functions that read the different elements of the
 Visio document without processing them really. You can plant several
 VSD_DEBUG_MSG((...)); statements inside the functions (include the
 libvisio_utils.h and optionally un-comment for the time of heavy
 development the #define VERBOSE_DEBUG=1). Doing so, you get maximum of
 information on your console without actually the parser calling any of
 the interface callbacks. Then you can start from there by actually
 processing the useful content.

Don't hesitate to output loads of TODO printfs to help you monitor what
is missing. This way you'll easily see your progress. Ask Miklos about
it, I think he appreciated the idea last year ;)

 Sometimes, GSoC students are scared that pushing publicly code of
 questionable quality would be detrimental for them when a prospective
 employer googles for their work. This is largely a myth and the evidence
 is that if that was true, I would probably have to have spent all my
 life living on social help :)

To go in Fridrich's way, only few code is perfect from the very
beginning we produce it... but push it as long as it works (doesn't
break important things) and fix it after. Nobody will complain against
that as almost every developer does it (or did it at some point of the
time).

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] about fonts embedding error

[Cedric Bosdonnat]

Hi Edmund,

On Thu, 2011-05-26 at 10:54 +0300, Edmund Laugasson wrote:
 I would like to ask - is there any bug with fonts embedding? I tried to 
 embed all fonts but they didn't - still were there misunderstandable 
 signs...

Well, the dev list is not a good place to raise bugs...

 I found the following bug - 
 https://bugs.freedesktop.org/show_bug.cgi?id=36829 - I added also my 
 example there.

Nice move, thanks!

 Does anybody know - will this bug be fixed in the version 3.4.0 or 3.4.1?

Unless someone is working on it, it won't be in 3.4.1 and has possibly
missed the 3.4.0 boat.

Thanks for your report,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Works LO connector with HTTPS ?

[Caolán McNamara]

On Thu, 2011-05-26 at 09:49 +0200, Fernand Vanrie wrote:
 I Trye to use the latest Google Tasks API from in LO but now we need
 to connect with HTTPS
 please can a developer tell me if my code had a change to work no or
 in the future ?
 
 oConnector = createUnoService(com.sun.star.connection.Connector) 

com.sun.star.connection.Connector is for connecting to a running
LibreOffice instance listening on the far side, i.e. connecting to an
UNO interprocess bridge. 

 oConnection =
 oConnector.connect(socket,host=www.googleapis.com,port=80)  'or port
 (443)'
 oConnection.write( StringToByteArray( GET
 https://www.googleapis.com/tasks/v1/lists/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDow/tasks/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDo4?pp=1key={YOUR_API_KEY};
   + cCR + cLF ))

You *might* have more luck with the ucb api, e.g.
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/UCB/Documents

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] gbuild, visibility and map files ?

[Michael Meeks]

On Wed, 2011-05-25 at 09:36 +0100, Caolán McNamara wrote:
 IIRC with the gbuild system the simple map files to restrict exports
 were deprecated in favour of pure visibility markup. On the other hand,
 how does this mesh with the more complicated symbol versioning used in
 the ure map files, e.g. cppu/source/gcc3.map or salhelper's one.

I like that actually :-) although we are starting to get some very big
symbol tables creeping back in; I've asked an Intern that Yifan is
mentoring to look at using:

http://frehberg.wordpress.com/binscan/

To try to get some of the over-exporting more under control. If anyone
else wants to help out with that (generating lists of symbols / classes
etc. - that'd be great).

HTH,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] smoketest fails

[Caolán McNamara]

On Wed, 2011-05-25 at 23:08 +0200, Pim Bollen wrote:
 [Java framework] The JRE specified by the bootstrap variable 
 UNO_JAVA_JFW_JREHOME  or  UNO_JAVA_JFW_ENV_JREHOME  could not be 
 recognized. Check the values and make sure that you use a plug-in library 
 that can recognize that JRE.
 javaldx failed!
...
 - Actual  :  Extensions:services

This should (hopefully) be fixed again now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.0.2 tag created (3.4.0-rc2)

[Michael Meeks]

Hi Andreas,

On Wed, 2011-05-25 at 06:39 +0200, Andreas Radke wrote:
.. [ without snipping redundantly quoted context ;- ] ... 
 Any idea why the bootstrap tarball has a size of 256MB? Is this a
 mistake?

Interesting :-) where is the tar-ball ? It should be 2.5Mb or so I
suppose.

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Templates path, move language independent stuffs to common folder

[Michael Meeks]

Hi Kami,

On Wed, 2011-05-25 at 09:49 +0200, KAMI911 KAMI911 wrote:
 Currently all templates installed by LibreOffice (3.4) are in:
 /opt/libreoffice3.4/basis3.4/share/template

Right.

 If someone adds here subfolders it is appear as empty subfolder while
 create a new document from template.

So in the File-Templates-Organize - we see the bogus 'en_US'
directory that we don't want ? :-) or is this another issue ?

  By the go-oo time we used common
 subfolder for such language independent files. Can we move
 /opt/libreoffice3.4/basis3.4/share/template/layout to
 /opt/libreoffice3.4/basis3.4/share/template/common/layout.

Sounds fine to me - but it'd be great to explain the concrete impact
more clearly. Also, as Andras says, lets get this into master quickly,
and then 

 In master i would like to delete $(insturl)/share/template reference
 and change the scp2 module to follow this change.

It'd be great to better understand the rational ( not everyone is as
expert with templates and their problems as you :-) but in principle it
sounds fine to me !

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Works LO connector with HTTPS ?

[Fernand Vanrie]

Caolán,

Thanks, but with the UCB we are stucked to only GET and no POST etc...
Is it a good idea to ask for a enhancement to make connector a proper 
tool to make http/https requests ?


G.

On Thu, 2011-05-26 at 09:49 +0200, Fernand Vanrie wrote:

I Trye to use the latest Google Tasks API from in LO but now we need
to connect with HTTPS
please can a developer tell me if my code had a change to work no or
in the future ?

oConnector = createUnoService(com.sun.star.connection.Connector)

com.sun.star.connection.Connector is for connecting to a running
LibreOffice instance listening on the far side, i.e. connecting to an
UNO interprocess bridge.


oConnection =
oConnector.connect(socket,host=www.googleapis.com,port=80)  'or port
(443)'
oConnection.write( StringToByteArray( GET
https://www.googleapis.com/tasks/v1/lists/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDow/tasks/MDk5Nzc1MDY0NzQyMTk4NjEyMzM6MDo4?pp=1key={YOUR_API_KEY};
  + cCR + cLF ))

You *might* have more luck with the ucb api, e.g.
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/UCB/Documents

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Works LO connector with HTTPS ?

[Caolán McNamara]

On Thu, 2011-05-26 at 11:30 +0200, Fernand Vanrie wrote:
 Caolán,
 
 Thanks, but with the UCB we are stucked to only GET and no POST etc...

Hmm, definitely ?, 

http://opengrok.libreoffice.org/xref/libs-core/ucb/source/ucp/webdav/webdavcontent.cxx#600

claims to support post, and it backs onto a neon implementation which
*seems* to be implemented.

http://api.openoffice.org/docs/common/ref/com/sun/star/ucb/WebDAVDocumentContent.html

http://opengrok.libreoffice.org/xref/components/forms/source/xforms/submission/submission_post.cxx#70
appears to be an example of a POST that might be worth a shot.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Resolved: fix for twofold suffix stripping + compound in hunspell

[Michael Meeks]

On Wed, 2011-05-25 at 15:09 +0100, Caolán McNamara wrote:
 On Sun, 2011-04-24 at 21:31 -0500, Arno Teigseth wrote:
  I've just hacked the hunspell sources I got from CVS so that I could get
  rid of this hunspell bug:
  https://sourceforge.net/tracker/?func=detailaid=3288562group_id=143754atid=756395
..
 Looks good, I see that nemeth took the patch yesterday in upstream to
 hunspell. We'll pick this up when we re-import the latest released
 hunspell that includes your fix. Which I guess will be hunspell-1.3.3

As an alternative, Arno, if you're really eager to have this in soon
(in 3.4.1) - can you turn it into an additional patch / commit to the
libs-extern-sys/hunspell module inside LibreOffice ? That involves some
build testing, and so on but with some git-format-patch output it'd be
far easier for us to apply there.

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Fix for fdo#37458

[Michael Meeks]

Hi there,

On Thu, 2011-05-26 at 00:09 -0400, Kohei Yoshida wrote:
 Please review the attached patch which fixes
 https://bugs.freedesktop.org/show_bug.cgi?id=37458

Looks golden, I've pushed to -3-4.

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] python / XInvocation snafu ...

[Bjoern Michaelsen]

Hi all,

On Mon, 23 May 2011 12:14:31 +0100
Michael Meeks michael.me...@novell.com
wrote:

   Oh ! as in add a new one, and kill the old one off: I
 guess ... the question is, will we remember to remove the old code if
 we don't kill it day #1 ? :-) [ I think not ]. It'd be great to
 rip/replace now. It seems we only have:
 
   wizards/source/tools/Misc.xba
 and   wizards/com/sun/star/wizards/common/Resource.java
 and   extensions/workben/testresource.cxx
 
   the last of which we can easily kill and/or turn into a
 run-time unit test I guess.

see: https://bugs.freedesktop.org/show_bug.cgi?id=37290
The new service is implemented and pushed to a new branch
feature/gsoc2011_wizards. I have not pushed to master yet, because I
have not changed the clients as given by Michael to use the new service
yet.

@Xisco: Could you try to change the wizards-code to use the new service
instead on the branch and self-assign Bug 37290 to yourself for that (I
could not find you on bugzilla)? Then we could merge this change back to
master.

Best,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.0.2 tag created (3.4.0-rc2)

[Thorsten Behrens]

Michael Meeks wrote:
  Any idea why the bootstrap tarball has a size of 256MB? Is this a
  mistake?
 
   Interesting :-) where is the tar-ball ? It should be 2.5Mb or so I
 suppose.
 
Seems fixed, thanks Petr! :)

-- Thorsten


pgpvZos2wN3zh.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Java error in

[Ben Engbers]

Glen Winters lamouche@... writes:

 
 ERROR: error 65280 occurred while making /home/mouche/LOdev/tail_build/prj

 
 And here's the error log that it references:
 
 http://pastebin.com/QGYBHKmJ


I have the same error when compiling sources that I downloaded yesterday.
Where did you find a link to this file?


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] smoketest fails

[Christian Dywan]

Am Thu, 26 May 2011 09:51:45 +0100 schrieb Caolán McNamara:

 On Wed, 2011-05-25 at 23:08 +0200, Pim Bollen wrote:
  [Java framework] The JRE specified by the bootstrap variable 
  UNO_JAVA_JFW_JREHOME  or  UNO_JAVA_JFW_ENV_JREHOME  could not be 
  recognized. Check the values and make sure that you use a plug-in
  library that can recognize that JRE.
  javaldx failed!
 ...
  - Actual  :  Extensions:services
 
 This should (hopefully) be fixed again now.

Still broken for me. I did remove smoketestoo_native/unxlngx6.pro but no 
difference.

Presumably 6eae40f7a1dfbd5 in bootstrap was the commit supposed to fix it?

-- 
ciao,
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] smoketest fails

[Caolán McNamara]

On Thu, 2011-05-26 at 13:30 +0200, Christian Dywan wrote:
 Am Thu, 26 May 2011 09:51:45 +0100 schrieb Caolán McNamara:

 Still broken for me. I did remove smoketestoo_native/unxlngx6.pro but no 
 difference.
 
 Presumably 6eae40f7a1dfbd5 in bootstrap was the commit supposed to fix it?

That one was to fix the dangling install dir after a make-install

11f7f9c22fba9551adcfce46657e02376962c7bd in ure was basically the bit to
fix the above.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] crash in svtree re-factor ...

[Michael Meeks]

Hi there,

Tools-Options - press arrow down a few times to the print options:
Bang ... valgrind log appended.

Seems to be a result of your conversion to stl types.

Thanks,

Michael.

=15812== Invalid read of size 2
==15812==at 0x4D09A28: SvPtrarr::Count() const (svarray.hxx:455)
==15812==by 0x4D65BAA: SvLBoxEntry::GetFirstItem(unsigned short) 
(svlbox.cxx:647)
==15812==by 0x4D77544: SvTreeListBox::DefaultCompare(SvSortData*) 
(svtreebx.cxx:2267)
==15812==by 0x4D77507: SvTreeListBox::LinkStubDefaultCompare(void*, void*) 
(svtreebx.cxx:2263)
==15812==by 0x4CF2694: Link::Call(void*) const (link.hxx:140)
==15812==by 0x4D8C8D9: SvTreeList::Compare(SvListEntry*, SvListEntry*) 
const (treelist.cxx:1939)
==15812==by 0x4D8CB5D: SvTreeList::GetInsertionPos(SvListEntry*, 
SvListEntry*, unsigned long) (treelist.cxx:1996)
==15812==by 0x4D8CA03: SvTreeList::ResortChilds(SvListEntry*) 
(treelist.cxx:1966)
==15812==by 0x4D8C93C: SvTreeList::Resort() (treelist.cxx:1948)
==15812==by 0x13B2D557: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B2FCAF: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B3FF3E: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==  Address 0xdee29b2 is 6 bytes after a block of size 20 alloc'd
==15812==at 0x402911D: malloc (in 
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==15812==by 0x405FEF4: rtl_allocateMemory (in 
/data/opt/OOInstall/ure/lib/libuno_sal.so.3)
==15812==by 0x8048C53: ??? (in /data/opt/OOInstall/program/soffice.bin)
==15812==by 0x8048D15: operator new(unsigned int) (in 
/data/opt/OOInstall/program/soffice.bin)
==15812==by 0x4D89295: SvTreeEntryList::SvTreeEntryList(SvTreeEntryList) 
(treelist.cxx:129)
==15812==by 0x4D8C9A5: SvTreeList::ResortChilds(SvListEntry*) 
(treelist.cxx:1958)
==15812==by 0x4D8C93C: SvTreeList::Resort() (treelist.cxx:1948)
==15812==by 0x13B2D557: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B2FCAF: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B3FF3E: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x57386AA: Link::Call(void*) const (in 
/data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unxlngi6.pro/lib/libvclli.so)
==15812==by 0x57453AA: Timer::Timeout() (in 
/data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unxlngi6.pro/lib/libvclli.so)
==15812== 
==15812== Invalid read of size 4
==15812==at 0x5487816: String::String(String const) (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libtlli.so)
==15812==by 0x4D473B3: SvLBoxString::GetText() const (svlbitm.hxx:133)
==15812==by 0x4D77555: SvTreeListBox::DefaultCompare(SvSortData*) 
(svtreebx.cxx:2267)
==15812==by 0x4D77507: SvTreeListBox::LinkStubDefaultCompare(void*, void*) 
(svtreebx.cxx:2263)
==15812==by 0x4CF2694: Link::Call(void*) const (link.hxx:140)
==15812==by 0x4D8C8D9: SvTreeList::Compare(SvListEntry*, SvListEntry*) 
const (treelist.cxx:1939)
==15812==by 0x4D8CB5D: SvTreeList::GetInsertionPos(SvListEntry*, 
SvListEntry*, unsigned long) (treelist.cxx:1996)
==15812==by 0x4D8CA03: SvTreeList::ResortChilds(SvListEntry*) 
(treelist.cxx:1966)
==15812==by 0x4D8C93C: SvTreeList::Resort() (treelist.cxx:1948)
==15812==by 0x13B2D557: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B2FCAF: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==by 0x13B3FF3E: ??? (in 
/data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
==15812==  Address 0x4 is not stack'd, malloc'd or (recently) free'd


-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] __cdecl - SAL_CALL (libs-gui)

[Lubos Lunak]

On Monday 23 of May 2011, Chr. Rossmanith wrote:
 Hi,

 the attached patch removes __cdecl and uses SAL_CALL instead.

 Pushed, thanks.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Missing configuration of Writer's page shadow? (Re: LibreOffice 3.4 Release Notes)

[Takashi Nakamoto]

(2011/05/26 4:51), Michael Meeks wrote:

Hi Takashi,

First:

On Thu, 2011-05-26 at 03:45 +0900, Takashi Nakamoto wrote:

I'm thinking of taking some screenshots for better look of the
release note in parallel with translation into Japanese.


cool ! thanks for doing that :-) and the more screenshots the prettier
  better.


I'll upload them after I finish the translation work. Please be patient.


I couldn't find the configuration to change the shadow color of Writer
pages in the option dialog, while the release note says


For me this is Tools-Options-Appearance-Shadows (cf. screenshot).


Thanks, I found it.

Best regards,
 Takashi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] crash in svtree re-factor ...

[Joseph Powers]

I'm showing:

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0004
Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libtlmxi.dylib  0x014eb11a String::String(String 
const) + 10
1   libsvtmxi.dylib 0x00ac1075 
SvTreeListBox::DefaultCompare(SvSortData*) + 53
2   libsvtmxi.dylib 0x00ad3f78 
SvTreeList::Compare(SvListEntry*, SvListEntry*) const + 56
3   libsvtmxi.dylib 0x00ad4bcc 
SvTreeList::GetInsertionPos(SvListEntry*, SvListEntry*, unsigned long) + 188
4   libsvtmxi.dylib 0x00ad5345 
SvTreeList::ResortChilds(SvListEntry*) + 133
5   libsvtmxi.dylib 0x00ad5435 SvTreeList::Resort() + 69
6   libcuimxi.dylib 0x60c07237 
SvxPathTabPage::HeaderSelect_Impl(HeaderBar*) + 135
7   libcuimxi.dylib 0x60c0b72d 
SvxPathTabPage::Reset(SfxItemSet const) + 1181
8   libcuimxi.dylib 0x60c22d58 
OfaTreeOptionsDialog::SelectHdl_Impl(Timer*) + 4840
9   libvclmxi.dylib 0x0176f19c Timer::Timeout() + 28
10  libvclmxi.dylib 0x0176f2b9 
Timer::ImplTimerCallbackProc() + 121
11  libvclmxi.dylib 0x01a7a591 SalGetDesktopEnvironment() + 
24929

And it's in the Options-Path not print...

It does look like something I did... looking into it now.

Joe P.

On May 26, 2011, at 6:02 AM, Michael Meeks wrote:

 Hi there,
 
   Tools-Options - press arrow down a few times to the print options:
 Bang ... valgrind log appended.
 
   Seems to be a result of your conversion to stl types.
 
   Thanks,
 
   Michael.
 
 =15812== Invalid read of size 2
 ==15812==at 0x4D09A28: SvPtrarr::Count() const (svarray.hxx:455)
 ==15812==by 0x4D65BAA: SvLBoxEntry::GetFirstItem(unsigned short) 
 (svlbox.cxx:647)
 ==15812==by 0x4D77544: SvTreeListBox::DefaultCompare(SvSortData*) 
 (svtreebx.cxx:2267)
 ==15812==by 0x4D77507: SvTreeListBox::LinkStubDefaultCompare(void*, 
 void*) (svtreebx.cxx:2263)
 ==15812==by 0x4CF2694: Link::Call(void*) const (link.hxx:140)
 ==15812==by 0x4D8C8D9: SvTreeList::Compare(SvListEntry*, SvListEntry*) 
 const (treelist.cxx:1939)
 ==15812==by 0x4D8CB5D: SvTreeList::GetInsertionPos(SvListEntry*, 
 SvListEntry*, unsigned long) (treelist.cxx:1996)
 ==15812==by 0x4D8CA03: SvTreeList::ResortChilds(SvListEntry*) 
 (treelist.cxx:1966)
 ==15812==by 0x4D8C93C: SvTreeList::Resort() (treelist.cxx:1948)
 ==15812==by 0x13B2D557: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==by 0x13B2FCAF: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==by 0x13B3FF3E: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==  Address 0xdee29b2 is 6 bytes after a block of size 20 alloc'd
 ==15812==at 0x402911D: malloc (in 
 /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
 ==15812==by 0x405FEF4: rtl_allocateMemory (in 
 /data/opt/OOInstall/ure/lib/libuno_sal.so.3)
 ==15812==by 0x8048C53: ??? (in /data/opt/OOInstall/program/soffice.bin)
 ==15812==by 0x8048D15: operator new(unsigned int) (in 
 /data/opt/OOInstall/program/soffice.bin)
 ==15812==by 0x4D89295: SvTreeEntryList::SvTreeEntryList(SvTreeEntryList) 
 (treelist.cxx:129)
 ==15812==by 0x4D8C9A5: SvTreeList::ResortChilds(SvListEntry*) 
 (treelist.cxx:1958)
 ==15812==by 0x4D8C93C: SvTreeList::Resort() (treelist.cxx:1948)
 ==15812==by 0x13B2D557: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==by 0x13B2FCAF: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==by 0x13B3FF3E: ??? (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libcuili.so)
 ==15812==by 0x57386AA: Link::Call(void*) const (in 
 /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unxlngi6.pro/lib/libvclli.so)
 ==15812==by 0x57453AA: Timer::Timeout() (in 
 /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unxlngi6.pro/lib/libvclli.so)
 ==15812== 
 ==15812== Invalid read of size 4
 ==15812==at 0x5487816: String::String(String const) (in 
 /data/opt/libreoffice/bootstrap/solver/340/unxlngi6.pro/lib/libtlli.so)
 ==15812==by 0x4D473B3: SvLBoxString::GetText() const (svlbitm.hxx:133)
 ==15812==by 0x4D77555: SvTreeListBox::DefaultCompare(SvSortData*) 
 (svtreebx.cxx:2267)
 ==15812==by 0x4D77507: SvTreeListBox::LinkStubDefaultCompare(void*, 
 void*) (svtreebx.cxx:2263)
 ==15812==by 0x4CF2694: Link::Call(void*) const (link.hxx:140)
 ==15812==by 0x4D8C8D9: SvTreeList::Compare(SvListEntry*, SvListEntry*) 
 const (treelist.cxx:1939)
 ==15812==by 0x4D8CB5D: SvTreeList::GetInsertionPos(SvListEntry*, 
 SvListEntry*, unsigned long) 

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Alex Thurgood alex.thurg...@gmail.com changed:

   What|Removed |Added

 Depends on||37620

--- Comment #122 from Alex Thurgood alex.thurg...@gmail.com 2011-05-26 
07:15:34 PDT ---
Nominating 37620. Affects multiple OSes. Builtin report wizard made reports no
longer display data, merely ipsem lorum typesetter text. Actual data not 
displayed, making these reports useless.

Alex

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

--- Comment #123 from Alex Thurgood alex.thurg...@gmail.com 2011-05-26 
07:22:11 PDT ---
Re bug 37620 - regression compared to 3.3.2. Looks like the problem occurred
after integration of OOo 3.4 code, since the problem also exists in OOo-dev
3.4m0.

Alex

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove commented out code.

[Luke Petrolekas]

License under LGPLv3+/MPL.

Great to finally get to do this again.

Luke Petrolekas
From e648d350e83f617d0c2f8d7d0693460b38b4 Mon Sep 17 00:00:00 2001
From: Luke Petrolekas luke.petrole...@gmail.com
Date: Thu, 26 May 2011 10:27:54 -0400
Subject: [PATCH] Removes commented out code.

---
 .../source/component/documentdigitalsignatures.cxx |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/xmlsecurity/source/component/documentdigitalsignatures.cxx b/xmlsecurity/source/component/documentdigitalsignatures.cxx
index 8032883..205fe3e 100644
--- a/xmlsecurity/source/component/documentdigitalsignatures.cxx
+++ b/xmlsecurity/source/component/documentdigitalsignatures.cxx
@@ -440,8 +440,6 @@ void DocumentDigitalSignatures::showCertificate(
 ::ucbhelper::ContentBroker* pBroker = NULL;
 
 //warning free code
-//if ( aLocObj.GetProtocol() == INET_PROT_FILE  ( pBroker = ::ucbhelper::ContentBroker::get() ) )
-//	xContentProvider = pBroker-getContentProviderInterface();
 if ( aLocObj.GetProtocol() == INET_PROT_FILE)
 {
 pBroker = ::ucbhelper::ContentBroker::get();
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix bug in CloneList

[Rafael Dominguez]

This patch fix a code i ommited in a previous commit
674c10b068d27d5ebdb25458d31dd8a61b343eb6, also should be included in 3.4.1
From 0db0ac817dd9bcc30d6a60fec93ac58aafdee416 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Wed, 18 May 2011 12:26:13 -0430
Subject: [PATCH 1/6] Fix wrong refactoring of CloneList.

Amending commit 674c10b068d27d5ebdb25458d31dd8a61b343eb6.
---
 svx/source/svdraw/clonelist.cxx |   24 
 1 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/svx/source/svdraw/clonelist.cxx b/svx/source/svdraw/clonelist.cxx
index a39bb2f..a14d469 100644
--- a/svx/source/svdraw/clonelist.cxx
+++ b/svx/source/svdraw/clonelist.cxx
@@ -85,6 +85,8 @@ SdrObject* CloneList::GetClone(sal_uInt32 nIndex) const
 
 void CloneList::CopyConnections() const
 {
+sal_uInt32 cloneCount = maCloneList.size();
+
 for(sal_uInt32 a = 0; a  maOriginalList.size(); a++)
 {
 const SdrEdgeObj* pOriginalEdge = PTR_CAST(SdrEdgeObj, GetOriginal(a));
@@ -101,10 +103,17 @@ void CloneList::CopyConnections() const
  maOriginalList.end(),
  pOriginalNode1);
 
+sal_uInt32 nPos = it - maOriginalList.begin();
+
 if(it != maOriginalList.end())
 {
-if(pOriginalEdge-GetConnectedNode(sal_True) != *it)
-pCloneEdge-ConnectToNode(sal_True, const_castSdrObject*(*it));
+SdrObject *cObj = NULL;
+
+if (nPos  cloneCount)
+cObj = GetClone(nPos);
+
+if(pOriginalEdge-GetConnectedNode(sal_True) != cObj)
+pCloneEdge-ConnectToNode(sal_True, cObj);
 }
 }
 
@@ -114,10 +123,17 @@ void CloneList::CopyConnections() const
  maOriginalList.end(),
  pOriginalNode2);
 
+sal_uInt32 nPos = it - maOriginalList.begin();
+
 if(it != maOriginalList.end())
 {
-if(pOriginalEdge-GetConnectedNode(sal_True) != *it)
-pCloneEdge-ConnectToNode(sal_True, const_castSdrObject*(*it));
+SdrObject *cObj = NULL;
+
+if (nPos  cloneCount)
+cObj = GetClone(nPos);
+
+if(pOriginalEdge-GetConnectedNode(sal_False) != cObj)
+pCloneEdge-ConnectToNode(sal_False, cObj);
 }
 }
 }
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix bug in CloneList

[Rafael Dominguez]

This patch fix a code i ommited in a previos commit
674c10b068d27d5ebdb25458d31dd8a61b343eb6, also should be included in 3.4.1
From 0db0ac817dd9bcc30d6a60fec93ac58aafdee416 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Wed, 18 May 2011 12:26:13 -0430
Subject: [PATCH 1/6] Fix wrong refactoring of CloneList.

Amending commit 674c10b068d27d5ebdb25458d31dd8a61b343eb6.
---
 svx/source/svdraw/clonelist.cxx |   24 
 1 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/svx/source/svdraw/clonelist.cxx b/svx/source/svdraw/clonelist.cxx
index a39bb2f..a14d469 100644
--- a/svx/source/svdraw/clonelist.cxx
+++ b/svx/source/svdraw/clonelist.cxx
@@ -85,6 +85,8 @@ SdrObject* CloneList::GetClone(sal_uInt32 nIndex) const
 
 void CloneList::CopyConnections() const
 {
+sal_uInt32 cloneCount = maCloneList.size();
+
 for(sal_uInt32 a = 0; a  maOriginalList.size(); a++)
 {
 const SdrEdgeObj* pOriginalEdge = PTR_CAST(SdrEdgeObj, GetOriginal(a));
@@ -101,10 +103,17 @@ void CloneList::CopyConnections() const
  maOriginalList.end(),
  pOriginalNode1);
 
+sal_uInt32 nPos = it - maOriginalList.begin();
+
 if(it != maOriginalList.end())
 {
-if(pOriginalEdge-GetConnectedNode(sal_True) != *it)
-pCloneEdge-ConnectToNode(sal_True, const_castSdrObject*(*it));
+SdrObject *cObj = NULL;
+
+if (nPos  cloneCount)
+cObj = GetClone(nPos);
+
+if(pOriginalEdge-GetConnectedNode(sal_True) != cObj)
+pCloneEdge-ConnectToNode(sal_True, cObj);
 }
 }
 
@@ -114,10 +123,17 @@ void CloneList::CopyConnections() const
  maOriginalList.end(),
  pOriginalNode2);
 
+sal_uInt32 nPos = it - maOriginalList.begin();
+
 if(it != maOriginalList.end())
 {
-if(pOriginalEdge-GetConnectedNode(sal_True) != *it)
-pCloneEdge-ConnectToNode(sal_True, const_castSdrObject*(*it));
+SdrObject *cObj = NULL;
+
+if (nPos  cloneCount)
+cObj = GetClone(nPos);
+
+if(pOriginalEdge-GetConnectedNode(sal_False) != cObj)
+pCloneEdge-ConnectToNode(sal_False, cObj);
 }
 }
 }
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove commented out code.

[Luke Petrolekas]

License LGPLv3+/MPL.

Luke
From 5f3418f034190a7f62f2504015cad1fc1fc918e9 Mon Sep 17 00:00:00 2001
From: Luke Petrolekas luke.petrole...@gmail.com
Date: Thu, 26 May 2011 10:37:34 -0400
Subject: [PATCH] Removes commented out code.

---
 xmlsecurity/source/dialogs/certificateviewer.cxx |   13 +
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/xmlsecurity/source/dialogs/certificateviewer.cxx b/xmlsecurity/source/dialogs/certificateviewer.cxx
index 7f9d00a..e39540e 100644
--- a/xmlsecurity/source/dialogs/certificateviewer.cxx
+++ b/xmlsecurity/source/dialogs/certificateviewer.cxx
@@ -299,12 +299,6 @@ CertificateViewerDetailsTP::CertificateViewerDetailsTP( Window* _pParent, Certif
 aLBEntry = pairIssuer.first;
 aDetails = pairIssuer.second; 
 InsertElement( String( XMLSEC_RES( STR_ISSUER ) ), aLBEntry, aDetails );
-/*
-aSeq = xCert-getIssuerUniqueID();
-aLBEntry = XmlSec::GetHexString( aSeq, pHexSep );
-aDetails = XmlSec::GetHexString( aSeq, pHexSep, nLineBreak );
-InsertElement( String( XMLSEC_RES( STR_ISSUER_ID ) ), aLBEntry, aDetails, true );
-*/
 
 DateTime aDateTime;
 utl::typeConvert( xCert-getNotValidBefore(), aDateTime );
@@ -323,12 +317,7 @@ CertificateViewerDetailsTP::CertificateViewerDetailsTP( Window* _pParent, Certif
 aLBEntry = pairSubject.first;
 aDetails = pairSubject.second;
 InsertElement( String( XMLSEC_RES( STR_SUBJECT ) ), aLBEntry, aDetails );
-/*
-aSeq = xCert-getSubjectUniqueID();
-aLBEntry = XmlSec::GetHexString( aSeq, pHexSep );
-aDetails = XmlSec::GetHexString( aSeq, pHexSep, nLineBreak );
-InsertElement( String( XMLSEC_RES( STR_SUBJECT_ID ) ), aLBEntry, aDetails, true );
-*/
+
 aLBEntry = aDetails = xCert-getSubjectPublicKeyAlgorithm();
 InsertElement( String( XMLSEC_RES( STR_SUBJECT_PUBKEY_ALGO ) ), aLBEntry, aDetails );
 aSeq = xCert-getSubjectPublicKeyValue();
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Replace List for std::mapsal_uInt32, ByteString

[Rafael Dominguez]

From e8e1873508e13201689c8ef12eb2b83cefd18fe7 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Tue, 24 May 2011 09:21:40 -0430
Subject: [PATCH] Replace List for std::mapsal_uInt32,ByteString.

---
 filter/inc/filter/msfilter/msdffimp.hxx |6 ++--
 filter/source/msfilter/msdffimp.cxx |   57 +--
 2 files changed, 19 insertions(+), 44 deletions(-)

diff --git a/filter/inc/filter/msfilter/msdffimp.hxx b/filter/inc/filter/msfilter/msdffimp.hxx
index c1a0294..1fee4cb 100644
--- a/filter/inc/filter/msfilter/msdffimp.hxx
+++ b/filter/inc/filter/msfilter/msdffimp.hxx
@@ -503,7 +503,7 @@ protected :
 
 bool ReadGraphic( SvStream rSt, sal_uLong nIndex, Graphic rGraphic ) const;
 SdrObject* ImportFontWork( SvStream, SfxItemSet, Rectangle rBoundRect ) const;
-SdrObject* ImportGraphic( SvStream, SfxItemSet, const DffObjData ) const;
+SdrObject* ImportGraphic( SvStream, SfxItemSet, const DffObjData );
 // #i32596# - pass nCalledByGroup to method
 // Needed in the Writer Microsoft Word import to avoid import of OLE objects
 // inside groups. Instead a graphic object is created.
@@ -560,7 +560,7 @@ public:
 void*pSvxMSDffDummy1;
 void*pSvxMSDffDummy2;
 void*pSvxMSDffDummy3;
-List*pEscherBlipCache;
+std::mapsal_uInt32,ByteString aEscherBlipCache;
 
 DffRecordManager	maShapeRecords;
 ColorData			mnDefaultColor;
@@ -650,7 +650,7 @@ public:
 
 Rueckgabewert: sal_True, im Erfolgsfalls, sal_False bei Fehler
 */
-sal_Bool GetBLIP( sal_uLong nIdx, Graphic rData, Rectangle* pVisArea = NULL ) const;
+sal_Bool GetBLIP( sal_uLong nIdx, Graphic rData, Rectangle* pVisArea = NULL );
 
 /*
 GetBLIPDirect()		-Einlesen eines BLIP aus schon positioniertem Stream
diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 31c8582..279551b 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -1867,7 +1867,7 @@ void DffPropertyReader::ApplyFillAttributes( SvStream rIn, SfxItemSet rSet, co
 {
 Graphic aGraf;
 // first try to get BLIP from cache
-sal_Bool bOK = rManager.GetBLIP( GetPropertyValue( DFF_Prop_fillBlip ), aGraf, NULL );
+sal_Bool bOK = const_castSvxMSDffManager(rManager).GetBLIP( GetPropertyValue( DFF_Prop_fillBlip ), aGraf, NULL );
 // then try directly from stream (i.e. Excel chart hatches/bitmaps)
 if ( !bOK )
 bOK = SeekToContent( DFF_Prop_fillBlip, rIn )  rManager.GetBLIPDirect( rIn, aGraf, NULL );
@@ -3400,16 +3400,6 @@ DffRecordHeader* DffRecordManager::GetRecordHeader( sal_uInt16 nRecId, DffSeekTo
 //  private Methoden
 //---
 
-struct EscherBlipCacheEntry
-{
-ByteString	aUniqueID;
-sal_uInt32  nBlip;
-
-EscherBlipCacheEntry( sal_uInt32 nBlipId, const ByteString rUniqueID ) :
-aUniqueID( rUniqueID ),
-nBlip( nBlipId ) {}
-};
-
 void SvxMSDffManager::Scale( sal_Int32 rVal ) const
 {
 if ( bNeedMap )
@@ -4334,7 +4324,7 @@ static void lcl_ApplyCropping( const DffPropSet rPropSet, SfxItemSet* pSet, Gra
 }
 }
 
-SdrObject* SvxMSDffManager::ImportGraphic( SvStream rSt, SfxItemSet rSet, const DffObjData rObjData ) const
+SdrObject* SvxMSDffManager::ImportGraphic( SvStream rSt, SfxItemSet rSet, const DffObjData rObjData )
 {
 SdrObject*  pRet = NULL;
 String  aFilename;
@@ -6040,7 +6030,6 @@ SvxMSDffManager::SvxMSDffManager(SvStream rStCtrl_,
  pStData2( pStData2_ ),
  nSvxMSDffSettings( 0 ),
  nSvxMSDffOLEConvFlags( 0 ),
- pEscherBlipCache( NULL ),
  mnDefaultColor( mnDefaultColor_),
  mpTracer( pTracer ),
  mbTracing( sal_False )
@@ -6092,7 +6081,6 @@ SvxMSDffManager::SvxMSDffManager( SvStream rStCtrl_, const String rBaseURL, MS
  pStData2( 0 ),
  nSvxMSDffSettings( 0 ),
  nSvxMSDffOLEConvFlags( 0 ),
- pEscherBlipCache( NULL ),
  mnDefaultColor( COL_DEFAULT ),
  mpTracer( pTracer ),
  mbTracing( sal_False )
@@ -6107,13 +6095,6 @@ SvxMSDffManager::SvxMSDffManager( SvStream rStCtrl_, const String rBaseURL, MS
 
 SvxMSDffManager::~SvxMSDffManager()
 {
-if ( pEscherBlipCache )
-{
-void* pPtr;
-for ( pPtr = pEscherBlipCache-First(); pPtr; pPtr = pEscherBlipCache-Next() )
-delete (EscherBlipCacheEntry*)pPtr;
-delete pEscherBlipCache;
-}
 delete pBLIPInfos;
 delete pShapeInfos;
 delete pShapeOrders;
@@ -6716,29 +6697,26 @@ sal_Bool SvxMSDffManager::GetShape(sal_uLong nId, SdrObject* rpShape,
 /*  Zugriff auf ein BLIP zur Laufzeit (bei bereits bekannter Blip-Nr)
 -
 **/
-sal_Bool SvxMSDffManager::GetBLIP( sal_uLong nIdx_, Graphic rData, 

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Alex Thurgood alex.thurg...@gmail.com changed:

   What|Removed |Added

 Depends on||37590

--- Comment #124 from Alex Thurgood alex.thurg...@gmail.com 2011-05-26 
07:46:38 PDT ---
Nominating 37590 - radio buttons in Base forms no longer transmit reference
data to underlying database field. This is a regression over 3.3.2 and causes
data loss when switching between 3.4 and 3.3.2 and earlier. Also, the bug is
not present in OOo 3.4beta.


Alex

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Ubuntu conference foo ...

[Michael Meeks]

Hi there,

Read the notes from UDS in your blog; there are a few things there:

a) themes (icons at least the rest comes from gtk+) are already
   a zip file - we could make that expandable by sniffing theme
   names from .zip files:
+ first file is an un-compressed text file containing
   just the name eg. ;-)
+ extract  render that I guess in the combo.
+ bit of work I suppose

b) gettext for translations
+ actually remarkably easy; we just need to load the
  en_US strings from the default resource file, and
  then - whack them through gettext
+ I -think- there was a floating patch for this in the
  l10n community - that we could fairly easily apply
  with some conditional: dead useful for translators
 (knocks a key-id build dead I think).
+ of course, this will miss some things: help files,
  misc. random XML files and so on but get most of it
  done.

Anyhow - glad the conf went well,

HTH,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Ubuntu conference foo ...

[Andras Timar]

2011/5/26 Michael Meeks michael.me...@novell.com:
 Hi there,

        b) gettext for translations
                + of course, this will miss some things: help files,
                  misc. random XML files and so on but get most of it
                  done.

This will miss
* 4413 strings coming from .xcu files (menus (UNO command names),
filter names etc.)
* 2588 strings coming from .ulf files (Windows installer mainly)
* 123 strings coming from the readme
* help that you mentioned but that will be handled through a different
process anyway (wiki).

Currently there are 28590 strings not counting the help, so not
addressing 25% of them is not ideal. OTOH reducing the footprint of
.res files would definitely be a gain.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] in-lining more UNO foo ...

[Matúš Kukan]

Hello,

On 23 May 2011 15:55, Michael Meeks michael.me...@novell.com wrote:
        The basic problem we have here is this, code like:

    PropertyValue aPath;
    aPath.Name = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(nodepath));
    aPath.Value = rtl::OUString::createFromAscii( foo );
    pArgs[0] = aPath; // This is the problem line ...

        despite us knowing all the information to do this 'right' at compile
 time, ends up loading a huge (and horribly inefficient) types.rdb file,
 and then using that to copy C++ types into an abstract internal
 representation.

        Of course - it'd be nice to have a profile to see if this is actually
 slow first ;-) can you run kcachegrind[1] on a small document load ? and
 look at the call counts of things like:

        _copyConstructAny( pDest, pSource, pType, 0, acquire, 0 );

So _copyConstructAny is called 180 205 times mostly from uno_type_any_construct.
I think inside the function itself are executed 0.26% instructions of all.
There is also Cycle Detection option in KCachegrind but I don't know
what it is doing. I had it enabled.

What specifically should I search for?
Is this enough?
I guess time can't be measured from callgrind's output. Or cycle
estimation is something like that?

Regards,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Remove commented out code.

[Michael Meeks]

On Thu, 2011-05-26 at 10:33 -0400, Luke Petrolekas wrote:
 License under LGPLv3+/MPL.
 Great to finally get to do this again.

Thanks ! ;-) pushed it,

ATB,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Remove commented out code.

[Michael Meeks]

On Thu, 2011-05-26 at 10:40 -0400, Luke Petrolekas wrote:
 License LGPLv3+/MPL.

Pushed likewise - thanks; also - great to have a few bigger chunks to
push, than lots of smaller ones; 10x larger would be a good start :-)

Thanks !

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] in-lining more UNO foo ...

[Michael Meeks]

Hi Matus,

On Thu, 2011-05-26 at 17:47 +0200, Matúš Kukan wrote:
 _copyConstructAny( pDest, pSource, pType, 0, acquire, 0 );

 So _copyConstructAny is called 180 205 times mostly from
 uno_type_any_construct. I think inside the function itself are
 executed 0.26% instructions of all.

I get a cumulative counts (for a writer startup and shutdown) of:

1.4%uno_type_any_construct
1.5%uno_any_destruct
1.1%uno_type_any_assign

which I rather suspect are not overlapping; giving 4% of our startup
doing boxing and un-boxing. I'm not certain that we capture the true
evil of the underlying 'store_' code doing type reads / writes there.

 There is also Cycle Detection option in KCachegrind but I don't know
 what it is doing. I had it enabled.

:-)

 I guess time can't be measured from callgrind's output. Or cycle
 estimation is something like that?

Well - I guess we need to do more; now I look at KCachegrind again - I
am once again irritated by the characterisation sorted by shared library
[ I'd love you to look into fixing that ]: I get:

23 %libuno_sal.so.3
17.5%   libc-2.11.3.so
12.2%   configmgr...
10% ld.so.

And my problem is - I have no idea -who- is using libc too much :-)
what if the 12% of configmr causes 50% of the libc wasteage and 50% of
the libuno_sal wasteage ? :-)

It would be really nice to be able to mark some libraries as
'optimal' (eg. glibc - there are ~no wins possible in there), and then
accounting the cost (and colouring in the map) of their methods calls to
the next library up.

That would let us (eg.) mark configmgr as optimal (though it is not) -
and see which libraries higher up the stack are (perhaps) mis-using it.

Beyond some extra UI, hopefully that is not horribly difficult to
achieve (?). And we should prolly focus on that first [ another first -
sorry - but it is really is the bottom of the stack ;-].

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] Fix for fdo#37356

[Kohei Yoshida]

The attached patch fixes broken transposition during cell range pasting.
It's a simple one liner fix.

I need to have one sign-off to be included in the -3-4 branch.

Here is the link to the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=37356

Thanks!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
From 2c0b112cd3349c596cd5d3a6544a2d5372a145d4 Mon Sep 17 00:00:00 2001
From: Kohei Yoshida kyosh...@novell.com
Date: Thu, 26 May 2011 15:45:05 -0400
Subject: [PATCH] fdo#37356: Fix broken transposition during paste of cell range.

Refactoring of ScRangeList accidentally skipped the first element during
for loop.
---
 sc/source/core/data/clipparam.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sc/source/core/data/clipparam.cxx b/sc/source/core/data/clipparam.cxx
index 7804bcc..bdef09c 100644
--- a/sc/source/core/data/clipparam.cxx
+++ b/sc/source/core/data/clipparam.cxx
@@ -175,7 +175,7 @@ void ScClipParam::transpose()
 SCCOL nColOrigin = p-aStart.Col();
 SCROW nRowOrigin = p-aStart.Row();
 
-for ( size_t i = 1, n = maRanges.size(); i  n; ++i )
+for ( size_t i = 0, n = maRanges.size(); i  n; ++i )
 {
 p = maRanges[ i ];
 SCCOL nColDelta = p-aStart.Col() - nColOrigin;
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Fix for fdo#37356

[Markus Mohrhard]

You've my sign-off. I'll push it to 3-4.

2011/5/26 Kohei Yoshida kyosh...@novell.com

 The attached patch fixes broken transposition during cell range pasting.
 It's a simple one liner fix.

 I need to have one sign-off to be included in the -3-4 branch.

 Here is the link to the bug.
 https://bugs.freedesktop.org/show_bug.cgi?id=37356

 Thanks!

 Kohei

 --
 Kohei Yoshida, LibreOffice hacker, Calc
 kyosh...@novell.com

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix out of bounds access in ImplEntryList

[Rafael Dominguez]

Fix possible oob when trying to erase an element. Please review and signoff
for merging into 3.4.1
From eb95ef34e1e10787e582726bb660b821bdee74b3 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez venccsra...@gmail.com
Date: Thu, 26 May 2011 15:33:07 -0430
Subject: [PATCH] Make sure we dont oob when erasing.

---
 vcl/source/control/ilstbox.cxx |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/vcl/source/control/ilstbox.cxx b/vcl/source/control/ilstbox.cxx
index 340a349..cbe5de3 100644
--- a/vcl/source/control/ilstbox.cxx
+++ b/vcl/source/control/ilstbox.cxx
@@ -274,10 +274,10 @@ sal_uInt16 ImplEntryList::InsertEntry( sal_uInt16 nPos, ImplEntryType* pNewEntry
 
 void ImplEntryList::RemoveEntry( sal_uInt16 nPos )
 {
-boost::ptr_vectorImplEntryType::iterator iter = maEntries.begin()+ nPos;
-
-if (iter != maEntries.end())
+if (nPos  maEntries.size())
 {
+boost::ptr_vectorImplEntryType::iterator iter = maEntries.begin()+ nPos;
+
 if ( !!iter-maImage )
 mnImages--;
 
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [LibreOffice][GSoC 2011][svgexport] build issue: libvcllx.so: undefined symbol: _ZN3utl10ConfigItemC2ERKN3rtl8OUStringEs

[Marco]

On Wed, 25 May 2011 23:21:38 +0200, Thorsten Behrens  
t...@documentfoundation.org wrote:



Marco wrote:

Now after all this work I have still some issue:
when I launch soffice on the standard error I got the following  
messages:



IIRC that was a temp failure, and the changes have been reverted
meanwhile - generally, the thing with the master branch is that, at
any given time, you may be unlucky  get a state that's broken in
various ways. In all cases, doing git pull on your repo should be
followed by make clean  make (unless you know exactly what you're
doing).


Yes, you are right, indeed I'm not used to work on a so big and
complex project as LibreOffice.


My recommendation for a stable setup  the quickest way to a
working, hackable build is to currently use the libreoffice-3-4 (or
even -3-4-0) branch.

Best not to waste time on random other issues just *yet* :)


I find that a sensible idea! All these building issues are really
a waste of time. I'll create a new local branch libreoffice-3-4-0
that will track the origin/libreoffice-3-4-0 remote branch,
so I can execute g pull -r straight from the libreoffice-3-4-0
local branch .
Moreover my feature/svgexport will be attached to that branch
instead of to the master branch.

Thanks for your advise :)

-- Marco




--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove commented out code

[Luke Petrolekas]

License LGPLv3+/MPL

More dead code.

Luke
From 7a003ea22e71462de6d52748c66c5f2dcb0d259f Mon Sep 17 00:00:00 2001
From: Luke Petrolekas luke.petrole...@gmail.com
Date: Thu, 26 May 2011 18:34:08 -0400
Subject: [PATCH] Remove commented out code.

---
 xmlsecurity/source/dialogs/dialogs.hrc |   12 ++--
 xmlsecurity/source/dialogs/macrosecurity.cxx   |2 --
 xmlsecurity/source/dialogs/resourcemanager.cxx |3 ---
 xmlsecurity/source/dialogs/warnings.cxx|6 --
 4 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/xmlsecurity/source/dialogs/dialogs.hrc b/xmlsecurity/source/dialogs/dialogs.hrc
index 9ea22bf..a7c547d 100644
--- a/xmlsecurity/source/dialogs/dialogs.hrc
+++ b/xmlsecurity/source/dialogs/dialogs.hrc
@@ -84,25 +84,19 @@
 #define FI_STATE_NOTVALIDATED   12
 #define FI_STATE_OLDSIGNATURE   16
 
-//#define DS_WIDTH		DLGS_WIDTH
-//#define DS_HEIGHT		DLGS_HEIGHT
 #define DS_BTNWIDTH_1	70
 #define DS_BTNSPACE_X	RSC_SP_CTRL_X
 #define DS_WIDTH		(RSC_SP_DLG_INNERBORDER_LEFT+RSC_SP_DLG_INNERBORDER_RIGHT+2*DS_BTNSPACE_X+3*DS_BTNWIDTH_1)
 #define DS_HEIGHT		(DLGS_WIDTH*2/3)
 
 #define DS_COL_0		RSC_SP_DLG_INNERBORDER_LEFT
-//#define DS_COL_MID		(DS_WIDTH/2)
-//#define DS_COL_3		(DS_COL_MID-(DS_BTNWIDTH_1/2))
-//#define DS_COL_4		(DS_COL_2+DS_BTNWIDTH_1)
-//#define DS_COL_2		(DS_COL_3-DS_BTNSPACE_X)
-//#define DS_COL_1		(DS_COL_2-DS_BTNWIDTH_1)
+
 #define DS_COL_1		DS_COL_0
 #define DS_COL_2		(DS_COL_1+DS_BTNWIDTH_1)
 #define DS_COL_3		(DS_COL_2+DS_BTNSPACE_X)
 #define DS_COL_4		(DS_COL_3+DS_BTNWIDTH_1)
 #define DS_COL_5		(DS_COL_4+DS_BTNSPACE_X)
-//#define	DS_COL_6		(DS_COL_5+DS_BTNWIDTH_1)
+
 #define DS_COL_7		(DS_WIDTH-RSC_SP_DLG_INNERBORDER_RIGHT)
 #define	DS_COL_6		DS_COL_7
 
@@ -242,8 +236,6 @@
 #define CVP_ROW_3   (CVP_ROW_2+RSC_CD_PUSHBUTTON_HEIGHT)
 #define CVP_ROW_4   (CVP_ROW_3+RSC_CD_FIXEDTEXT_HEIGHT+RSC_SP_CTRL_DESC_Y)
 
-//#define CV_ROW_0A  (CV_ROW_0+RSC_SP_CTRL_DESC_Y+RSC_CD_FIXEDTEXT_HEIGHT)
-//#define CV_ROW_2A  (CV_ROW_2+RSC_SP_CTRL_DESC_Y+RSC_CD_FIXEDTEXT_HEIGHT)
 
 // - tab dialog macro security -
 
diff --git a/xmlsecurity/source/dialogs/macrosecurity.cxx b/xmlsecurity/source/dialogs/macrosecurity.cxx
index e65ff88..a05b0a9 100644
--- a/xmlsecurity/source/dialogs/macrosecurity.cxx
+++ b/xmlsecurity/source/dialogs/macrosecurity.cxx
@@ -370,8 +370,6 @@ MacroSecurityTrustedSourcesTP::MacroSecurityTrustedSourcesTP( Window* _pParent,
 mbAuthorsReadonly = mpDlg-maSecOptions.IsReadOnly( SvtSecurityOptions::E_MACRO_TRUSTEDAUTHORS );
 maTrustCertROFI.Show( mbAuthorsReadonly );
 mbAuthorsReadonly ? maTrustCertLB.DisableTable() : maTrustCertLB.EnableTable();
-//  unused button 
-//maAddCertPB.Enable( !mbAuthorsReadonly );
 
 FillCertLB();
 
diff --git a/xmlsecurity/source/dialogs/resourcemanager.cxx b/xmlsecurity/source/dialogs/resourcemanager.cxx
index cecc68e..8e631a4 100644
--- a/xmlsecurity/source/dialogs/resourcemanager.cxx
+++ b/xmlsecurity/source/dialogs/resourcemanager.cxx
@@ -53,9 +53,6 @@ namespace XmlSec
 if( !pResMgr )
 {
 ByteString	aName( xmlsec );
-//		pResMgr = ResMgr::CreateResMgr( aName.GetBuffer(), Application::GetSettings().GetUILanguage() );
-//			LanguageType	aLang( LANGUAGE_ENGLISH_US );
-//			pResMgr = ResMgr::CreateResMgr( aName.GetBuffer(), aLang );
 // MT: Change to Locale
 pResMgr = ResMgr::CreateResMgr( aName.GetBuffer() );
 }
diff --git a/xmlsecurity/source/dialogs/warnings.cxx b/xmlsecurity/source/dialogs/warnings.cxx
index 436eebb..a5cb295 100644
--- a/xmlsecurity/source/dialogs/warnings.cxx
+++ b/xmlsecurity/source/dialogs/warnings.cxx
@@ -77,7 +77,6 @@ MacroWarning::MacroWarning( Window* _pParent, uno::Reference dcss::xml::crypto:
 
 maViewSignsBtn.SetClickHdl( LINK( this, MacroWarning, ViewSignsBtnHdl ) );
 maEnableBtn.SetClickHdl( LINK( this, MacroWarning, EnableBtnHdl ) );
-//	maDisableBtn.SetClickHdl( LINK( this, MacroWarning, DisableBtnHdl ) );
 
 if( mxCert.is() )
 maSignsFI.SetText( XmlSec::GetContentPart( mxCert-getSubjectName() ) );
@@ -139,9 +138,4 @@ IMPL_LINK( MacroWarning, EnableBtnHdl, void*, EMPTYARG )
 return 0;
 }
 
-/*IMPL_LINK( MacroWarning, DisableBtnHdl, void*, EMPTYARG )
-{
-return 0;
-}*/
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Very small code cleanup.

[Luke Petrolekas]

No, this is not more dead code this time :). I noticed this and I'm pretty
confident the code is sloppy. It's my first time deliberately touching the
code, so sorry if it's a bit small.

License LGPLv3+/MPL.

Luke
From ade4b654cba3753b184310fd96c9b38c2fb0507b Mon Sep 17 00:00:00 2001
From: Luke Petrolekas luke.petrole...@gmail.com
Date: Thu, 26 May 2011 18:42:13 -0400
Subject: [PATCH] Simply the code.

---
 xmlsecurity/source/dialogs/stbcontrl.cxx |8 +---
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/xmlsecurity/source/dialogs/stbcontrl.cxx b/xmlsecurity/source/dialogs/stbcontrl.cxx
index 68729ad..f506439 100644
--- a/xmlsecurity/source/dialogs/stbcontrl.cxx
+++ b/xmlsecurity/source/dialogs/stbcontrl.cxx
@@ -95,13 +95,7 @@ void XmlSecStatusBarControl::StateChanged( sal_uInt16 nSID, SfxItemState eState,
 void XmlSecStatusBarControl::Command( const CommandEvent rCEvt )
 {
 // can / has to be done when integrated in Office!
-//	if( rCEvt.GetCommand() ==  )
-if( false )
-{
-//		GetBindings().GetDispatcher()-Execute( SID_PSZ_FUNCTION, SFX_CALLMODE_RECORD, aItem, 0L );
-}
-else
-SfxStatusBarControl::Command( rCEvt );
+SfxStatusBarControl::Command( rCEvt );
 }
 
 void XmlSecStatusBarControl::Paint( const UserDrawEvent rUsrEvt )
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove commented out code.

[Luke Petrolekas]

License LGPLv3+/MPL

Luke
From e327343b79c36f03ccf25b99195cbf7c582dde8e Mon Sep 17 00:00:00 2001
From: Luke Petrolekas luke.petrole...@gmail.com
Date: Thu, 26 May 2011 18:55:51 -0400
Subject: [PATCH] Delete commented out code.

---
 xmlsecurity/source/framework/buffernode.cxx|6 --
 xmlsecurity/source/framework/elementcollector.cxx  |7 ---
 xmlsecurity/source/framework/elementcollector.hxx  |1 -
 xmlsecurity/source/framework/securityengine.hxx|1 -
 .../source/framework/xmlencryptiontemplateimpl.cxx |3 ---
 .../source/framework/xmlsignaturetemplateimpl.cxx  |3 ---
 6 files changed, 0 insertions(+), 21 deletions(-)

diff --git a/xmlsecurity/source/framework/buffernode.cxx b/xmlsecurity/source/framework/buffernode.cxx
index e6f1c63..2ba40f2 100644
--- a/xmlsecurity/source/framework/buffernode.cxx
+++ b/xmlsecurity/source/framework/buffernode.cxx
@@ -286,12 +286,6 @@ rtl::OUString BufferNode::printChildren() const
 }
 
 rc += rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( ( ));
-/*
-if (((ElementCollector*)(*ii))-isInternalNotificationSuppressed())
-{
-rc += rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( *IN-Suppressed*  ));
-}
-*/
 rc += rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SecID= ));
 rc += rtl::OUString::valueOf(((ElementCollector*)(*ii))-getSecurityId());
 rc += rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( ) ));
diff --git a/xmlsecurity/source/framework/elementcollector.cxx b/xmlsecurity/source/framework/elementcollector.cxx
index bff96c6..841900a 100644
--- a/xmlsecurity/source/framework/elementcollector.cxx
+++ b/xmlsecurity/source/framework/elementcollector.cxx
@@ -91,13 +91,6 @@ ElementCollector::ElementCollector(
 m_type = cssxc::sax::ElementMarkType_ELEMENTCOLLECTOR;
 }
 
-/*
-bool ElementCollector::isInternalNotificationSuppressed() const
-{
-return m_bInternalNotificationSuppressed;
-}
-*/
-
 cssxc::sax::ElementMarkPriority ElementCollector::getPriority() const
 {
 return m_nPriority;
diff --git a/xmlsecurity/source/framework/elementcollector.hxx b/xmlsecurity/source/framework/elementcollector.hxx
index 6a6ae55..41bb054 100644
--- a/xmlsecurity/source/framework/elementcollector.hxx
+++ b/xmlsecurity/source/framework/elementcollector.hxx
@@ -86,7 +86,6 @@ public:
 xReferenceResolvedListener);
 virtual ~ElementCollector() {};
 
-//bool isInternalNotificationSuppressed() const;
 com::sun::star::xml::crypto::sax::ElementMarkPriority getPriority() const;
 bool getModify() const;
 void notifyListener();
diff --git a/xmlsecurity/source/framework/securityengine.hxx b/xmlsecurity/source/framework/securityengine.hxx
index 71cc2eb..fb4c3cd 100644
--- a/xmlsecurity/source/framework/securityengine.hxx
+++ b/xmlsecurity/source/framework/securityengine.hxx
@@ -105,7 +105,6 @@ protected:
 /*
  * the status of the operation
  */
-//bool  m_bOperationSucceed;
 com::sun::star::xml::crypto::SecurityOperationStatus m_nStatus;
 
 /*
diff --git a/xmlsecurity/source/framework/xmlencryptiontemplateimpl.cxx b/xmlsecurity/source/framework/xmlencryptiontemplateimpl.cxx
index 73404b2..243d4dc 100644
--- a/xmlsecurity/source/framework/xmlencryptiontemplateimpl.cxx
+++ b/xmlsecurity/source/framework/xmlencryptiontemplateimpl.cxx
@@ -135,9 +135,6 @@ Reference XInterface  SAL_CALL XMLEncryptionTemplateImpl :: impl_createInstanc
 }
 
 Reference XSingleServiceFactory  XMLEncryptionTemplateImpl :: impl_createFactory( const Reference XMultiServiceFactory  aServiceManager ) {
-//Reference XSingleServiceFactory  xFactory ;
-//xFactory = ::cppu::createSingleFactory( aServiceManager , impl_getImplementationName , impl_createInstance , impl_getSupportedServiceNames ) ;
-//return xFactory ;
 return ::cppu::createSingleFactory( aServiceManager , impl_getImplementationName() , impl_createInstance , impl_getSupportedServiceNames() ) ;
 }
 
diff --git a/xmlsecurity/source/framework/xmlsignaturetemplateimpl.cxx b/xmlsecurity/source/framework/xmlsignaturetemplateimpl.cxx
index 30fcd04..c4358d6 100644
--- a/xmlsecurity/source/framework/xmlsignaturetemplateimpl.cxx
+++ b/xmlsecurity/source/framework/xmlsignaturetemplateimpl.cxx
@@ -160,9 +160,6 @@ Reference XInterface  SAL_CALL XMLSignatureTemplateImpl :: impl_createInstance
 }
 
 Reference XSingleServiceFactory  XMLSignatureTemplateImpl :: impl_createFactory( const Reference XMultiServiceFactory  aServiceManager ) {
-//Reference XSingleServiceFactory  xFactory ;
-//xFactory = ::cppu::createSingleFactory( aServiceManager , impl_getImplementationName , impl_createInstance , impl_getSupportedServiceNames ) ;
-//return xFactory ;
 return ::cppu::createSingleFactory( aServiceManager , impl_getImplementationName() , impl_createInstance , impl_getSupportedServiceNames() ) ;
 }
 
-- 
1.7.1

___
LibreOffice 

[Libreoffice] [PATCH] Remove commented out code

[Luke Petrolekas]

License LGPLv3+/MPL

(I'm ramping up my commit size.)

Luke
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 37356, which changed state.

Bug 37356 Summary: Paste Special of copied cells with transposition causes 
LibreOffice to hang
https://bugs.freedesktop.org/show_bug.cgi?id=37356

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

[Jan Holesovsky]

Hi Markus,

On 2011-05-24 at 21:35 +0200, Markus Mohrhard wrote:

 here is a short patch that sets all specified borders during parsing
 instead of only one border. The problem was that nBorderTyp was set
 for every border with the correct value but SetBorderLine was only
 called once after the do while loop. So now every time nBorderType
 will be overriden, I call SetBorderLine.
 
 If this patch is ok I think we should add it to the 3-4 branch.

Cedric already approved the patch, but I am wondering - before, the
nBorderTyp was set only when bTableDef was true; after your patch, it is
set regardless of the bTableDef value.  Is that correct, or should that
be in a block?  If it is correct, can you please also change the
indentation of the nBorderTyp = XYZ; part so that it does not look as if
it is supposed to be part of the if ( bTableDef )?

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] PATCH] Fix bug in CloneList (Rafael Dominguez) [PUSHED]

[Joseph Powers]

This patch fix a code i ommited in a previous commit
674c10b068d27d5ebdb25458d31dd8a61b343eb6, also should be included in 3.4.1


The patch looked ok to me. Also, it looks like he sent the same patch 3 times.

It also allowed mmeeks new tests to get a lot further a long; before the patch 
the tests where dying after the 4th or 5th one.

Joe P.

ps: mmeeks, thanks for the long tests... now to see how many of the errors can 
be fixed...
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice