[Libreoffice] Patch for Bug 35938 - EasyHack: UI - Picture Caption dialog not remembering Separator textbox value

[Jeff Aigner]

Hello,

I'm new to contributing here, so greetings to all! Attached is a patch
for bug 35938. It changes the Picture Caption dialog to remember the
last-used value of the caption separator text.

Kind Regards,

Jeff Aigner
>From b80eab85eb6288c8b5c08cbccd2cadc75943a8b6 Mon Sep 17 00:00:00 2001
From: Jeff Aigner 
Date: Thu, 9 Jun 2011 00:56:04 -0500
Subject: [PATCH] Resolves Bug 35938: Saves caption separator text in caption dialog.

A static String member was added to the SwCaptionDialog class to save the value of the separator text edit between uses.
---
 sw/source/ui/frmdlg/cption.cxx |4 
 sw/source/ui/inc/cption.hxx|1 +
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/sw/source/ui/frmdlg/cption.cxx b/sw/source/ui/frmdlg/cption.cxx
index e6deb8c..12f6af7 100644
--- a/sw/source/ui/frmdlg/cption.cxx
+++ b/sw/source/ui/frmdlg/cption.cxx
@@ -112,6 +112,8 @@ public:
 String  GetCharacterStyle() const;
 };
 
+String SwCaptionDialog::our_aSepTextSave = String::CreateFromAscii(": "); // Caption separator text
+
 SwCaptionDialog::SwCaptionDialog( Window *pParent, SwView &rV ) :
 
 SvxStandardDialog( pParent, SW_RES(DLG_CAPTION) ),
@@ -282,6 +284,7 @@ SwCaptionDialog::SwCaptionDialog( Window *pParent, SwView &rV ) :
 FreeResource();
 
 CheckButtonWidth();
+aSepEdit.SetText(our_aSepTextSave);
 aTextEdit.GrabFocus();
 DrawSample();
 }
@@ -308,6 +311,7 @@ void SwCaptionDialog::Apply()
 aOpt.CopyAttributes() = bCopyAttributes;
 aOpt.SetCharacterStyle( sCharacterStyle );
 rView.InsertCaption( &aOpt );
+our_aSepTextSave = aSepEdit.GetText();
 }
 
 IMPL_LINK_INLINE_START( SwCaptionDialog, OptionHdl, Button*, pButton )
diff --git a/sw/source/ui/inc/cption.hxx b/sw/source/ui/inc/cption.hxx
index f23f4be..144f05c 100644
--- a/sw/source/ui/inc/cption.hxx
+++ b/sw/source/ui/inc/cption.hxx
@@ -118,6 +118,7 @@ class SwCaptionDialog : public SvxStandardDialog
 voidCheckButtonWidth();
 voidApplyCaptionOrder(); //#i61007# order of captions 
 
+static String our_aSepTextSave; // Save caption separator text
 public:
  SwCaptionDialog( Window *pParent, SwView &rV );
 ~SwCaptionDialog();
-- 
1.7.4.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Fix for fdo#37673

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 11:26 PM, Kohei Yoshida  wrote:
> Here is another fix for review.
>
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4820648fc4abe7984c3c3c35e4c727c5574e8939
>
> This one fixes the following crasher
>
> https://bugs.freedesktop.org/show_bug.cgi?id=37673
>
> which BTW happens only on Windows.  The reason for the crash is that the
> pTableMap pointer passed to ScHTMLTableIterator can be NULL sometimes,
> and when it's null, the two iterator data members will be left
> un-initialized.  When the is() method is called under such
> circumstances, those un-initialized iterators get accessed, which
> somehow causes crash on Windows.
>
> I'd like to have this cherry-picked to the -3-4 branch.  Review
> appreciated.

ok.
Cherry-picked to 3-4

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibreOffice Calc

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 2:53 PM, Roderick Edwards IMP-IND
 wrote:
> Hi dev team!!!  I love LibreOffice.  Much better than reg OpenOffice.  The
> macro interoperability and the excel like autofiltering made me consider
> using it as a replacement for Excel.  Anyhow, at my work, we have some
> people on Excel and some people on OpenOffice (hopefully soon Libre) so I am
> always trying to work with interoperability issues.
>
> A couple of things that would really help improve Libre Calc.
>
> Black and white print.  OO only has grayscale.
> Wildcards "*"  need to operate the same as Excel, especially in a formula
> such as =MATCH(text&"*",range,0)

Thanks for you feedback.

You may want to consider opening a bug(1) for these (one each) in our
bug-tracker ( https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice
)
so that these valuable feedback do not get lost in the history of the
mailing-list
This is a dev mailinglist where usually patches are posted and
discussed... it is pretty fast moving, so thing that are not acted
upon fairly fast tend to fall through the cracks...
By recording these in bugzilla, they will be remembered there and have
a better chance to be picked-up by a dev at some point.


Norbert

(1) we use 'bug' as a generic term.. new feature request and minor
enhancements are also recorded, in bugzilla, as 'bug' even if they are
not technically bugs.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Disable Removebutton in optchart

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 11:24 AM, Rob Snelders  wrote:
> Hi,
>
> I have here a small patch to disable the remove-button at the chart-colors
> if there is no color to remove. This makes it more consistent for the GUI.

Thanks,

Tested and Pushed.

Norbert.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] fix for fdo#37799

[Norbert Thiebaud]

oops forgot to change the header.
pushed

Norbert

On Wed, Jun 8, 2011 at 10:29 AM, Cedric Bosdonnat
 wrote:
> Hi all,
>
> Could anyone review, sign-off and push to 3.4 branch the attached patch
> fixing a broken loop? One less annoying bug for 3.4 ;)
>
> Thanks,
>
> --
> Cédric Bosdonnat
> LibreOffice hacker
> http://documentfoundation.org
> OOo Eclipse Integration developer
> http://cedric.bosdonnat.free.fr
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#37799

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 10:29 AM, Cedric Bosdonnat
 wrote:
> Hi all,
>
> Could anyone review, sign-off and push to 3.4 branch the attached patch
> fixing a broken loop? One less annoying bug for 3.4 ;)

Looks fine.
Pushed.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 37799, which changed state.

Bug 37799 Summary: Crash when Break (remove) DDE link to CALC
https://bugs.freedesktop.org/show_bug.cgi?id=37799

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] Fix for fdo#37673

[Kohei Yoshida]

Here is another fix for review.

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4820648fc4abe7984c3c3c35e4c727c5574e8939

This one fixes the following crasher

https://bugs.freedesktop.org/show_bug.cgi?id=37673

which BTW happens only on Windows.  The reason for the crash is that the
pTableMap pointer passed to ScHTMLTableIterator can be NULL sometimes,
and when it's null, the two iterator data members will be left
un-initialized.  When the is() method is called under such
circumstances, those un-initialized iterators get accessed, which
somehow causes crash on Windows.

I'd like to have this cherry-picked to the -3-4 branch.  Review
appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#33705

[Markus Mohrhard]

I think we tested it well now. You've my sign-off.

Pushed to 3-4.


2011/6/9 Kohei Yoshida 

> On Wed, 2011-06-08 at 21:50 -0400, Kohei Yoshida wrote:
>
> > to see if that will solve the unit test failure issue.  The test passes
> > in my build environment so I'm suggesting this entirely in blind, so I
> > don't want to check this in before confirming that this is indeed the
> > issue.
>
> Ok.  This won't solve it.  Long story short, the attached patch should
> work for everybody.
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Fix for fdo#33705

[Kohei Yoshida]

On Wed, 2011-06-08 at 21:50 -0400, Kohei Yoshida wrote:

> to see if that will solve the unit test failure issue.  The test passes
> in my build environment so I'm suggesting this entirely in blind, so I
> don't want to check this in before confirming that this is indeed the
> issue.

Ok.  This won't solve it.  Long story short, the attached patch should
work for everybody.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

>From dc243aa1c0b1b5219c0329e60eee646d83e06d16 Mon Sep 17 00:00:00 2001
From: Kohei Yoshida 
Date: Wed, 8 Jun 2011 12:53:21 -0400
Subject: [PATCH] fdo#33705: Fixed cell function N.

Also added unit test for this built-in function.
---
 sc/qa/unit/ucalc.cxx |   64 ++
 sc/source/core/tool/interpr1.cxx |   48 +++-
 2 files changed, 97 insertions(+), 15 deletions(-)

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 7a6d46e..835f085 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -60,6 +60,7 @@
 #include "drwlayer.hxx"
 #include "scitems.hxx"
 #include "reffind.hxx"
+#include "markdata.hxx"
 
 #include "docsh.hxx"
 #include "funcdesc.hxx"
@@ -422,6 +423,69 @@ void Test::testCellFunctions()
 m_pDoc->GetValue(0, 4, 0, result);
 CPPUNIT_ASSERT_MESSAGE("Calculation of PRODUCT with inline array failed", result == 6.0);
 
+{
+// N
+
+// Clear the area first.
+ScMarkData aMarkData;
+aMarkData.SetMarkArea(ScRange(0, 0, 0, 1, 20, 0));
+m_pDoc->DeleteArea(0, 0, 1, 20, aMarkData, IDF_CONTENTS);
+
+// Put values to reference.
+val = 0;
+m_pDoc->SetValue(0, 0, 0, val);
+m_pDoc->SetString(0, 2, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("Text")));
+val = 1;
+m_pDoc->SetValue(0, 3, 0, val);
+val = -1;
+m_pDoc->SetValue(0, 4, 0, val);
+val = 12.3;
+m_pDoc->SetValue(0, 5, 0, val);
+m_pDoc->SetString(0, 6, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("'12.3")));
+
+// Cell references
+m_pDoc->SetString(1, 0, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A1)")));
+m_pDoc->SetString(1, 1, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A2)")));
+m_pDoc->SetString(1, 2, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A3)")));
+m_pDoc->SetString(1, 3, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A4)")));
+m_pDoc->SetString(1, 4, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A5)")));
+m_pDoc->SetString(1, 5, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A6)")));
+m_pDoc->SetString(1, 6, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A9)")));
+
+// In-line values
+m_pDoc->SetString(1, 7, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(0)")));
+m_pDoc->SetString(1, 8, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(1)")));
+m_pDoc->SetString(1, 9, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(-1)")));
+m_pDoc->SetString(1, 10, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(123)")));
+m_pDoc->SetString(1, 11, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(\"\")")));
+m_pDoc->SetString(1, 12, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(\"12\")")));
+m_pDoc->SetString(1, 13, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(\"foo\")")));
+
+// Range references
+m_pDoc->SetString(1, 14, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A1:A8)")));
+m_pDoc->SetString(1, 15, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A4:B8)")));
+m_pDoc->SetString(1, 16, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A6:B8)")));
+m_pDoc->SetString(1, 17, 0, OUString(RTL_CONSTASCII_USTRINGPARAM("=N(A2:B8)")));
+
+// Calculate and check the results.
+m_pDoc->CalcAll();
+double checks[] = {
+0, 0,  0,1, -1, 12.3, 0, // cell reference
+0, 1, -1, 123,  0,0, 0, // in-line values
+0, 1, 12.3, 0// range references
+};
+for (size_t i = 0; i < SAL_N_ELEMENTS(checks); ++i)
+{
+m_pDoc->GetValue(1, i, 0, result);
+bool bGood = result == checks[i];
+if (!bGood)
+{
+cerr << "row " << (i+1) << ": expected=" << checks[i] << " actual=" << result << endl;
+CPPUNIT_ASSERT_MESSAGE("Unexpected result for N", false);
+}
+}
+}
+
 m_pDoc->DeleteTab(0);
 }
 
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 1999bff..2327e94 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -2509,26 +2509,44 @@ void ScInterpreter::ScIsOdd()
 PushInt( !IsEven() );
 }
 
-
 void ScInterpreter::ScN()
 {
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "sc", "er", "ScInterpreter::ScN" );
-sal_uInt16 nErr = nGlobalError;
-nGlobalError = 0;
-// Temporarily override the ConvertStringToValue() error for
-// GetCellValue() / GetCellValueOrZero(

Re: [Libreoffice] [PUSHED] Patch for fdo#32786

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 5:32 AM, Samuel Mehrbrodt
 wrote:
> Hi,
>
> When I wanted to commit, git complained about remaining tabs and so I
> also replaced them with spaces. That makes the patch look bigger than it
> actually was, but I didn't see another way.

You could have edited the patch afterward to remove the un-needed section...
that is easier done with a patch-aware editor, like emacs (and most likely vim)
But in thta case, all that was needed was to remove the chunk that
were just tab/whitespace related
for reference : here is the edited version... which applied cleanly.

>
> The actual changes in the patch are in line 20 (import) and from line
> 580 down (removed lcl_TransliterateEditEngine and changed
> ScDocument::TransliterateText).
>
> This is my first contribution to LO, so I'm open for your feedback :)

First: Welcome aboard :-)

Second, few remarks, feedback.

It would be great if:
* you added In the subject use [PATCH] (with the bracket and the
capitalization... that help us spotting these :-)
* you indicate that you build the patched version
* you indicate what you did if any to verify the resolution of the bug.

So, I tweaked the patch to remove the space/tab chunks, applied it and
run test test scenario in fdo#32786.
It works fine...
I did not reproduce the bug _before_ applying the patch (not that I
couldn't reproduce, but I did not - shame on me :-) )

in any case: Pushed to master, and I closed the bug..

Thanks again.

Norbert


>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=32786
> [2] http://hg.services.openoffice.org/OOO340/rev/de0464b37fb3

These links above were very useful, thanks, keep doing that :-)


0001-Fix-for-fdo-32786-Capitalise-Every-Word-function.patch
Description: application/mbox
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] List structure cleaning in impress

[Rafael Dominguez]

From 811e66c084d35f80dd61cf5367a383523c407bdb Mon Sep 17 00:00:00 2001
From: Rafael Dominguez 
Date: Sat, 4 Jun 2011 10:46:37 -0430
Subject: [PATCH 1/4] Replace List with std::vector.

---
 sd/source/ui/dlg/navigatr.cxx |   32 ++--
 sd/source/ui/inc/navigatr.hxx |2 +-
 2 files changed, 11 insertions(+), 23 deletions(-)

diff --git a/sd/source/ui/dlg/navigatr.cxx b/sd/source/ui/dlg/navigatr.cxx
index edee709..c5f8345 100644
--- a/sd/source/ui/dlg/navigatr.cxx
+++ b/sd/source/ui/dlg/navigatr.cxx
@@ -97,7 +97,6 @@ SdNavigatorWin::SdNavigatorWin(
 
 mpNavigatorCtrlItem = new SdNavigatorControllerItem( SID_NAVIGATOR_STATE, this, mpBindings );
 mpPageNameCtrlItem = new SdPageNameControllerItem( SID_NAVIGATOR_PAGENAME, this, mpBindings );
-mpDocList = new List();
 
 ApplyImageList(); // load images *before* calculating sizes to get something useful !!!
 
@@ -156,13 +155,6 @@ SdNavigatorWin::~SdNavigatorWin()
 {
 delete mpNavigatorCtrlItem;
 delete mpPageNameCtrlItem;
-
-// Liste der DocInfos loeschen
-long nCount = mpDocList->Count();
-while( nCount-- )
-delete (NavDocInfo*) mpDocList->Remove( (sal_uLong)0 );
-
-delete mpDocList;
 }
 
 // ---
@@ -695,9 +687,7 @@ void SdNavigatorWin::RefreshDocumentLB( const String* pDocName )
 maLbDocs.Clear();
 
 // Liste der DocInfos loeschen
-long nCount = mpDocList->Count();
-while( nCount-- )
-delete (NavDocInfo*) mpDocList->Remove( (sal_uLong)0 );
+ maDocList.clear();
 
 if( mbDocImported )
 maLbDocs.InsertEntry( aStr, 0 );
@@ -710,15 +700,15 @@ void SdNavigatorWin::RefreshDocumentLB( const String* pDocName )
 ::sd::DrawDocShell* pDocShell = PTR_CAST(::sd::DrawDocShell, pSfxDocShell );
 if( pDocShell  && !pDocShell->IsInDestruction() && ( pDocShell->GetCreateMode() != SFX_CREATE_MODE_EMBEDDED ) )
 {
-NavDocInfo* pInfo = new NavDocInfo();
-pInfo->mpDocShell = pDocShell;
+NavDocInfo aInfo ;
+aInfo.mpDocShell = pDocShell;
 
 SfxMedium *pMedium = pDocShell->GetMedium();
 aStr = pMedium ? pMedium->GetName() : String();
 if( aStr.Len() )
-pInfo->SetName();
+aInfo.SetName();
 else
-pInfo->SetName( sal_False );
+aInfo.SetName( sal_False );
 // z.Z. wird wieder der Name der Shell genommen (also ohne Pfad)
 // da Koose es als Fehler ansieht, wenn er Pfad in URL-Notation
 // angezeigt wird!
@@ -727,11 +717,11 @@ void SdNavigatorWin::RefreshDocumentLB( const String* pDocName )
 maLbDocs.InsertEntry( aStr, LISTBOX_APPEND );
 
 if( pDocShell == pCurrentDocShell )
-pInfo->SetActive();
+aInfo.SetActive();
 else
-pInfo->SetActive( sal_False );
+aInfo.SetActive( sal_False );
 
-mpDocList->Insert( pInfo, LIST_APPEND );
+maDocList.push_back( aInfo );
 }
 pSfxDocShell = SfxObjectShell::GetNext( *pSfxDocShell, 0 , sal_False );
 }
@@ -762,7 +752,7 @@ sal_uInt16 SdNavigatorWin::GetDragTypeSdResId( NavigatorDragType eDT, sal_Bool b
 
 NavDocInfo* SdNavigatorWin::GetDocInfo()
 {
-long nPos = maLbDocs.GetSelectEntryPos();
+sal_uInt32 nPos = maLbDocs.GetSelectEntryPos();
 
 if( mbDocImported )
 {
@@ -773,9 +763,7 @@ NavDocInfo* SdNavigatorWin::GetDocInfo()
 nPos--;
 }
 
-NavDocInfo* pInfo = (NavDocInfo*)mpDocList->GetObject( nPos );
-
-return( pInfo );
+return nPos < maDocList.size() ? &(maDocList[ nPos ]) : NULL;
 }
 
 /*
diff --git a/sd/source/ui/inc/navigatr.hxx b/sd/source/ui/inc/navigatr.hxx
index a7950f0..6ea8cc5 100644
--- a/sd/source/ui/inc/navigatr.hxx
+++ b/sd/source/ui/inc/navigatr.hxx
@@ -128,7 +128,7 @@ private:
 sal_Bool		mbDocImported;
 String		maDropFileName;
 NavigatorDragType			meDragType;
-List*		mpDocList;
+std::vector		maDocList;
 SfxBindings*mpBindings;
 SdNavigatorControllerItem*	mpNavigatorCtrlItem;
 SdPageNameControllerItem*	mpPageNameCtrlItem;
-- 
1.7.3.4

From 55a20e82b0fb602a8e005bfc527d3369f4a7e845 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez 
Date: Sun, 5 Jun 2011 09:18:31 -0430
Subject: [PATCH 2/4] Replace List for std::vector.

---
 sd/source/filter/ppt/pptin.cxx |   56 ++--
 sd/source/filter/ppt/pptin.hxx |2 +-
 2 files changed, 26 insertions(+), 32 deletions(-)

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 1f982cf..b5c339d 100644
--- a/sd/s

[Libreoffice] [PATCH] List structure cleaning in calc

[Rafael Dominguez]

More List cleaning up
From 64ac9b0a4c39d0279fd5dbe9f8f160261d9c0420 Mon Sep 17 00:00:00 2001
From: Rafael Dominguez 
Date: Thu, 2 Jun 2011 22:00:58 -0430
Subject: [PATCH 10/21] Replace List for std::vector.

---
 sc/source/filter/inc/lotrange.hxx |4 +++-
 sc/source/filter/lotus/tool.cxx   |   30 +++---
 2 files changed, 14 insertions(+), 20 deletions(-)

diff --git a/sc/source/filter/inc/lotrange.hxx b/sc/source/filter/inc/lotrange.hxx
index edffd5e..479526b 100644
--- a/sc/source/filter/inc/lotrange.hxx
+++ b/sc/source/filter/inc/lotrange.hxx
@@ -110,13 +110,15 @@ inline sal_Bool LotusRange::IsSingle( void ) const
 
 // - class LotusRangeList -
 
-class LotusRangeList : private List
+class LotusRangeList
 {
 private:
 LR_IDnIdCnt;
 ScComplexRefData		aComplRef;
 static SCCOL		nEingCol;
 static SCROW		nEingRow;
+std::vector maRanges;
+
 public:
 LotusRangeList( void );
 ~LotusRangeList( void );
diff --git a/sc/source/filter/lotus/tool.cxx b/sc/source/filter/lotus/tool.cxx
index 39dd9d5..3267deb 100644
--- a/sc/source/filter/lotus/tool.cxx
+++ b/sc/source/filter/lotus/tool.cxx
@@ -460,28 +460,20 @@ LotusRangeList::LotusRangeList( void )
 pSingRef->SetFlag3D( false );
 }
 
-
-LotusRangeList::~LotusRangeList( void )
-{
-LotusRange *pDel = ( LotusRange * ) List::First();
-
-while( pDel )
-{
-delete pDel;
-pDel = ( LotusRange * ) List::Next();
-}
-}
-
+LotusRangeList::~LotusRangeList ()
+{
+std::vector::iterator pIter;
+for (pIter = maRanges.begin(); pIter != maRanges.end(); ++pIter)
+delete (*pIter);
+}
 
 LR_ID LotusRangeList::GetIndex( const LotusRange &rRef )
 {
-LotusRange*		pComp = ( LotusRange* ) List::First();
-
-while( pComp )
+std::vector::iterator pIter;
+for (pIter = maRanges.begin(); pIter != maRanges.end(); ++pIter)
 {
-if( *pComp == rRef )
-return pComp->nId;
-pComp = ( LotusRange* ) List::Next();
+if (rRef == *(*pIter))
+return (*pIter)->nId;
 }
 
 return ID_FAIL;
@@ -491,7 +483,7 @@ LR_ID LotusRangeList::GetIndex( const LotusRange &rRef )
 void LotusRangeList::Append( LotusRange* pLR, const String& rName )
 {
 OSL_ENSURE( pLR, "*LotusRangeList::Append(): das wird nichts!" );
-List::Insert( pLR, CONTAINER_APPEND );
+maRanges.push_back(pLR);
 
 ScTokenArray	aTokArray;
 
-- 
1.7.3.4

From 1561aeb96b5b12444c2174e44c7f5d3b112a62ba Mon Sep 17 00:00:00 2001
From: Rafael Dominguez 
Date: Fri, 3 Jun 2011 18:35:50 -0430
Subject: [PATCH 11/21] Replace List for std::vector.

---
 sc/source/filter/excel/excrecds.cxx |8 
 sc/source/filter/inc/excrecds.hxx   |   15 ++-
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/sc/source/filter/excel/excrecds.cxx b/sc/source/filter/excel/excrecds.cxx
index f6cede5..4bff217 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -182,15 +182,15 @@ sal_Size ExcEmptyRec::GetLen() const
 
 ExcRecordList::~ExcRecordList()
 {
-for( ExcRecord* pRec = First(); pRec; pRec = Next() )
-delete pRec;
+for (iterator pIter = maRecords.begin(); pIter != maRecords.end(); ++pIter)
+delete (*pIter);
 }
 
 
 void ExcRecordList::Save( XclExpStream& rStrm )
 {
-for( ExcRecord* pRec = First(); pRec; pRec = Next() )
-pRec->Save( rStrm );
+for (iterator pIter = maRecords.begin(); pIter != maRecords.end(); ++pIter)
+(*pIter)->Save( rStrm );
 }
 
 
diff --git a/sc/source/filter/inc/excrecds.hxx b/sc/source/filter/inc/excrecds.hxx
index 18e595f..0a73ea7 100644
--- a/sc/source/filter/inc/excrecds.hxx
+++ b/sc/source/filter/inc/excrecds.hxx
@@ -53,7 +53,6 @@
 
 class SvStream;
 class Font;
-class List;
 class ScPatternAttr;
 class ScTokenArray;
 class ScRangeData;
@@ -101,20 +100,18 @@ public:
 
 //--- class ExcRecordList -
 
-class ExcRecordList : protected List, public ExcEmptyRec
+class ExcRecordList : public ExcEmptyRec
 {
 private:
-protected:
+std::vector maRecords;
+
 public:
-virtual	~ExcRecordList();
 
-using   List::Count;
+typedef std::vector::iterator iterator;
 
-inline ExcRecord*		First( void ){ return ( ExcRecord* ) List::First(); }
-inline ExcRecord*		Next( void ){ return ( ExcRecord* ) List::Next(); }
+virtual	~ExcRecordList();
 
-inline voidAppend( ExcRecord* pNew )	{ if( pNew ) List::Insert( pNew, LIST_APPEND ); }
-inline const ExcRecord*	Get( sal_uInt32 nNum ) const	{ return ( ExcRecord* ) List::GetObject( nNum ); }
+inline voidAppend( ExcRecord* pNew )	{ if( pNew ) maRecords.push_back( pNew ); }
 
 virtual void			Save( XclExpStream& rStrm );
 };
-- 
1.7.3.4

From 18ef971d9acf001af9dc530ba438ba0d8a3b4f30 Mon Sep 17 0

Re: [Libreoffice] [REVIEW] Fix for fdo#33705

[Kohei Yoshida]

On Wed, 2011-06-08 at 15:10 -0400, Kohei Yoshida wrote:
> I'd like to have the following commit
> 
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5743e7b36220e9689091812cef7a4396dd48c4e6
> 
> cherry-picked to the -3-4 branch in order to fix
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=33705

Several people have told me that the unit test introduced in this commit
fails.  If you experience this, please try changing

m_pDoc->SetString(0, 6, 0,
OUString(RTL_CONSTASCII_USTRINGPARAM("TRUE")));
m_pDoc->SetString(0, 7, 0,
OUString(RTL_CONSTASCII_USTRINGPARAM("FALSE")));

to

m_pDoc->SetString(0, 6, 0,
OUString(RTL_CONSTASCII_USTRINGPARAM("=TRUE()")));
m_pDoc->SetString(0, 7, 0,
OUString(RTL_CONSTASCII_USTRINGPARAM("=FALSE()")));

to see if that will solve the unit test failure issue.  The test passes
in my build environment so I'm suggesting this entirely in blind, so I
don't want to check this in before confirming that this is indeed the
issue.

Thanks,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37947

[Markus Mohrhard]

Thanks for the new patch. Great work.

You have my sign-off. Pushed to 3-4 branch.

2011/6/9 Kohei Yoshida 

> On Wed, Jun 8, 2011 at 12:38 AM, Kohei Yoshida 
> wrote:
> > I'd like to cherry-pick this to the -3-4 branch
> >
> >
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8c02d7e41b5406471ede62099fceac5c8ce17fe4
>
> Apparently cherry-picking this from master to the -3-4 branch fails.
> I've re-issued a new patch against the -3-4 branch and attached
> herein.
>
> Kohei
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Fix for fdo#37947

[Kohei Yoshida]

On Wed, Jun 8, 2011 at 12:38 AM, Kohei Yoshida  wrote:
> I'd like to cherry-pick this to the -3-4 branch
>
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8c02d7e41b5406471ede62099fceac5c8ce17fe4

Apparently cherry-picking this from master to the -3-4 branch fails.
I've re-issued a new patch against the -3-4 branch and attached
herein.

Kohei
From 4d805f802846a81b5acff1ad5ca30963bb789837 Mon Sep 17 00:00:00 2001
From: Kohei Yoshida 
Date: Wed, 8 Jun 2011 18:18:45 -0400
Subject: [PATCH] fdo#37947: Correctly import sheet-local named ranges.

The key is to temporarily store all sheet-local named range data,
and insert them en masse after importing the sheet contents fully.
---
 sc/source/filter/xml/xmlimprt.cxx |   82 +
 sc/source/filter/xml/xmlimprt.hxx |8 
 sc/source/filter/xml/xmlnexpi.cxx |   37 +---
 sc/source/filter/xml/xmlnexpi.hxx |7 ++-
 sc/source/filter/xml/xmltabi.cxx  |   16 ++-
 5 files changed, 101 insertions(+), 49 deletions(-)

diff --git a/sc/source/filter/xml/xmlimprt.cxx b/sc/source/filter/xml/xmlimprt.cxx
index e047ef6..83f599f 100644
--- a/sc/source/filter/xml/xmlimprt.cxx
+++ b/sc/source/filter/xml/xmlimprt.cxx
@@ -95,6 +95,8 @@
 #include 
 #include 
 
+#include 
+
 #define SC_LOCALE			"Locale"
 #define SC_STANDARDFORMAT	"StandardFormat"
 #define SC_CURRENCYSYMBOL	"CurrencySymbol"
@@ -2036,6 +2038,25 @@ sal_Bool ScXMLImport::GetValidation(const rtl::OUString& sName, ScMyImportValida
 return false;
 }
 
+void ScXMLImport::AddNamedExpression(SCTAB nTab, ScMyNamedExpression* pNamedExp)
+{
+::std::auto_ptr p(pNamedExp);
+SheetNamedExpMap::iterator itr = maSheetNamedExpressions.find(nTab);
+if (itr == maSheetNamedExpressions.end())
+{
+// No chain exists for this sheet.  Create one.
+::std::auto_ptr pNew(new ScMyNamedExpressions);
+::std::pair r = maSheetNamedExpressions.insert(nTab, pNew);
+if (!r.second)
+// insertion failed.
+return;
+
+itr = r.first;
+}
+ScMyNamedExpressions& r = *itr->second;
+r.push_back(p);
+}
+
 ScXMLChangeTrackingImportHelper* ScXMLImport::GetChangeTrackingImportHelper()
 {
 if (!pChangeTrackingImportHelper)
@@ -2850,6 +2871,66 @@ void ScXMLImport::SetNamedRanges()
 }
 }
 
+namespace {
+
+class SheetRangeNameInserter : public ::std::unary_function
+{
+ScDocument* mpDoc;
+ScRangeName& mrRangeName;
+public:
+SheetRangeNameInserter(ScDocument* pDoc, ScRangeName& rRangeName) :
+mpDoc(pDoc), mrRangeName(rRangeName) {}
+
+void operator() (const ScMyNamedExpression& r) const
+{
+using namespace formula;
+
+if (r.sRangeType.getLength() > 0)
+// For now, we only accept normal named expressions.
+return;
+
+if (mpDoc && !mrRangeName.findByName(r.sName))
+{
+// Insert a new name.
+ScAddress aPos;
+sal_Int32 nOffset = 0;
+bool bSuccess = ScRangeStringConverter::GetAddressFromString(
+aPos, r.sBaseCellAddress, mpDoc, FormulaGrammar::CONV_OOO, nOffset);
+
+if (bSuccess)
+{
+::rtl::OUString aContent = r.sContent;
+if (!r.bIsExpression)
+ScXMLConverter::ParseFormula(aContent, false);
+
+ScRangeData* pData = new ScRangeData(
+mpDoc, r.sName, r.sContent, aPos, RT_NAME, r.eGrammar);
+mrRangeName.insert(pData);
+}
+}
+}
+};
+
+}
+
+void ScXMLImport::SetSheetNamedRanges()
+{
+if (!pDoc)
+return;
+
+SheetNamedExpMap::const_iterator itr = maSheetNamedExpressions.begin(), itrEnd = maSheetNamedExpressions.end();
+for (; itr != itrEnd; ++itr)
+{
+SCTAB nTab = itr->first;
+ScRangeName* pRangeNames = pDoc->GetRangeName(nTab);
+if (!pRangeNames)
+continue;
+
+const ScMyNamedExpressions& rNames = *itr->second;
+::std::for_each(rNames.begin(), rNames.end(), SheetRangeNameInserter(pDoc, *pRangeNames));
+}
+}
+
 void SAL_CALL ScXMLImport::endDocument(void)
 throw( ::com::sun::star::xml::sax::SAXException, ::com::sun::star::uno::RuntimeException )
 {
@@ -2891,6 +2972,7 @@ throw( ::com::sun::star::xml::sax::SAXException, ::com::sun::star::uno::RuntimeE
 }
 SetLabelRanges();
 SetNamedRanges();
+SetSheetNamedRanges();
 }
 GetProgressBarHelper()->End();  // make room for subsequent SfxProgressBars
 if (pDoc)
diff --git a/sc/source/filter/xml/xmlimprt.hxx b/sc/source/filter/xml/xmlimprt.hxx
index 28862bb..a1b737e 100644
--- a/sc/source/filter/xml/xmlimprt.hxx
+++ b/sc/source/filter/xml/xmlimprt.hxx
@@ -55,6 +55,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class ScRangeList;
 class ScMyStyleNumberFormats;
@@ -674,6 +675,8 @@ class ScMyStylesImportHelper;
 class ScXMLImport: public 

Re: [Libreoffice] [REVIEW][PUSHED] Fix for fdo#37816

[Markus Mohrhard]

You've my sign-off.

I pushed it to the 3-4 branch.

2011/6/8 Kohei Yoshida 

> I'd like to cherry-pick the following commit
>
>
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=34a1f66c5f69aba2cd6135895563cf569a2531eb
>
> from master to the -3-4 branch.  This fixes a rather nasty crasher when
> moving a field button inside a pivot table.  The bug is reported here:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=37816
>
> This is a one-liner fix.
>
> Review appreciated.
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Replacing ByteString with rtl::OString

[Kohei Yoshida]

On Wed, 2011-06-08 at 23:05 +0200, Chr. Rossmanith wrote:
> Hi,
> 
> I encountered the problem that rtl::OString::valueOf() won't eat sal_Int16.
> 
> Solution A: cast argument
> Solution B: add support for sal_Int16 to rtl::OString::valueOf()

You can cast it to sal_Int32.  That's probably simpler & consistent with
OUString's valueOf as well.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Replacing ByteString with rtl::OString

[Chr. Rossmanith]

Hi,

I encountered the problem that rtl::OString::valueOf() won't eat sal_Int16.

Solution A: cast argument
Solution B: add support for sal_Int16 to rtl::OString::valueOf()

Any opinions?

Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] Fix for fdo#37816

[Kohei Yoshida]

I'd like to cherry-pick the following commit

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=34a1f66c5f69aba2cd6135895563cf569a2531eb

from master to the -3-4 branch.  This fixes a rather nasty crasher when
moving a field button inside a pivot table.  The bug is reported here:

https://bugs.freedesktop.org/show_bug.cgi?id=37816

This is a one-liner fix.

Review appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

[Cor Nouws]

Andras Timar wrote (08-06-11 21:40)


and the Document target button (which is  there by mistake,
I think) from the Insert ->  Hyperlink ->  Internet panel.


Agree, it only should be on Insert ->  Hyperlink ->  Document

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] LibreOffice Calc

[Roderick Edwards IMP-IND]

Hi dev team!!!  I love LibreOffice.  Much better than reg OpenOffice.  The 
macro interoperability and the excel like autofiltering made me consider 
using it as a replacement for Excel.  Anyhow, at my work, we have some 
people on Excel and some people on OpenOffice (hopefully soon Libre) so I 
am always trying to work with interoperability issues.

A couple of things that would really help improve Libre Calc.

Black and white print.  OO only has grayscale.
Wildcards "*"  need to operate the same as Excel, especially in a formula 
such as =MATCH(text&"*",range,0)

Thanks and great job team!

Best regards,
Roderick Edwards

Customer Solutions Coordinator
Hellmann Worldwide Logistics, Inc.
5075 W. 74th Street
Indianapolis, IN 46268
Phone:  +317 536-6844
Email:  redwa...@us.hellmann.net
Web:  www.hellmann.net
06/08/201103:47:37 PM___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [patch] remove duplicate placeholder icons

[Joachim Trémouroux]

Hi Norbert,

Much faster indeed. It's instantaneous versus 35 sec for the md5sum. Thanks
for the tip.

Regards,
Joachim.


Le 7 juin 2011 22:53, Norbert Thiebaud  a écrit :

> 2011/6/7 Joachim Trémouroux :
> > Hi everybody,
> >
> > I have made some stats to check the number of duplicate icons in the
> > clone/artwork directory:
> >
> > $ find . -name "*.png" -exec md5sum {} \; > /tmp/icon_list.txt
> >
>
> Nice work...
>
> you could also use : git ls-tree -r HEAD
> that will give you both the filename and the sha1 of the blob at once
> and probably significantly faster than running md5sum on each
>
> Norbert
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [patch] remove duplicate placeholder icons

[Joachim Trémouroux]

Hi,

Done.  I've just made my first git push ever. :-)

Regards,
Joachim.


Le 7 juin 2011 20:51, Michael Meeks  a écrit :

> Hi Joachim,
>
> On Tue, 2011-06-07 at 20:27 +0200, Joachim Trémouroux wrote:
> > I have made some stats to check the number of duplicate icons in the
> > clone/artwork directory:
>
> Nice thinking :-) your methodology looks good, and your patches
> look
> good - please do push them (I'm assuming you have an account here, if
> not: http://freedesktop.org/wiki/AccountRequests and mail me the bug#)
>
> > If this patch is OK, I will continue with all the other duplicated
> > icons.
>
> Ho hum - so there are a lot of other duplications whereby we use
> the
> same name for different icon positions - I tried to keep a list of these
> for tango (or was it industrial); possibly we could add some code
> changes to do some (virtual) symlinks inside the .zip file that would
> allow more removal (?).
>
>Anyhow - I had thought we had no more easy wins here but ...
> apparently
> we do :-)
>
>Nice work,
>
>Michael.
>
> --
>  michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot
>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

[Andras Timar]

Hi Michael,

2011/6/8 Michael Münch :
> in Calc when clicking Insert->Hyperlink->WWW-Browser a webpage is opened
> with a text containing OpenOffice.org and http://www.sun.com/staroffice
> or http://www.openoffice.org depending on the language.
>
> This patch replaces these strings with LibreOffice ones.

The patch looks correct. Finally I learned what url_transfer.htm is
used for. :) However, why don't we remove this lame help text while we
are at it? It refers to Hyperlink bar which was removed. Also, it
explains how to copy & paste an URL which it trivial.

I would like to remove the Telnet option, the Web target button (which
invokes url_transfer.htm) and the Document target button (which is
there by mistake, I think) from the Insert -> Hyperlink -> Internet
panel. Any objections?

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate code: hwpreader.cxx

[Chr. Rossmanith]

Hi,

I've found a .hwp document here 
http://openoffice.org/bugzilla/show_bug.cgi?id=31091, tried to open it 
but only get a blank page - no error message. Where would I start to 
analyze what's going wrong? If hwpfilter is not working, maybe it's no 
use to improve the code...


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] Fix for fdo#33705

[Kohei Yoshida]

I'd like to have the following commit

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5743e7b36220e9689091812cef7a4396dd48c4e6

cherry-picked to the -3-4 branch in order to fix

https://bugs.freedesktop.org/show_bug.cgi?id=33705

Reviews appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New Member

[Sophie Gautier]

Hi Klaibson,
On 08/06/2011 16:59, Klaibson Ribeiro wrote:

Hello.

My name is Klaibson and yesterday me signed up in the LibreOffice in the
FreeDesktop.


Welcome and thanks for your work on LibreOffice. However this list is 
dedicated to developers work, better for you to post on 
disc...@documentfoundation.org for this kind of feedback.

Again, welcome to our project and thanks for the work you've already done.

Kind regards
Sophie
--
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Disappearing Frame Borders

[David Burleigh]

I'm running LibreOffice 3.4 under Ubuntu 11.04 (amd64).

I place a frame on a page, and set the borders of the frame to a
particular line style, and all seems fine. I can print the page and the
borders are printed as expected. However, if I close the file and then
reopen it, the borders are gone. It happens every time. Is this a bug,
or am I overlooking some setting to make the borders permanent?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] 3.4.0 SDK installation needs some tweaks?

[Andreas Radke]

Any hints how to handle the sdk paths for now? Just "sed" our distro
paths into it and add the missing setsdkenv_unix.sh.in file from the
sdk source?

-Andy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Lotuswordpro : Found duplicate if expressions in xfbookmarkref.cxx:75:85

[Julien Nabet]

Le 07/06/2011 11:18, Caolán McNamara a écrit :

On Sun, 2011-06-05 at 00:59 +0200, Julien Nabet wrote:

Hello,

Just a guess, perhaps it needs this patch :

...

Someone to comment ? If it's ok, I can, of course, commit this and push
it in master.

Your patch seems sane to me, I reckon you should go ahead and commit
that to master.

Hello,

Thank you for your approval, I commited and pushed the patch yesterday.

Julien.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Disable Removebutton in optchart

[Rob Snelders]

Hi,

I have here a small patch to disable the remove-button at the 
chart-colors if there is no color to remove. This makes it more 
consistent for the GUI.


--
Greetings,
Rob Snelders
>From 0f64b62344f6c0fdc2f6d1460bdfb1cb3bd3f2ed Mon Sep 17 00:00:00 2001
From: Rob Snelders 
Date: Wed, 8 Jun 2011 18:21:02 +0200
Subject: [PATCH] Disable Removebutton in optchart

---
 cui/source/options/optchart.cxx |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/cui/source/options/optchart.cxx b/cui/source/options/optchart.cxx
index 422c720..6293a8f 100644
--- a/cui/source/options/optchart.cxx
+++ b/cui/source/options/optchart.cxx
@@ -196,6 +196,7 @@ IMPL_LINK( SvxDefaultColorOptPage, ResetToDefaults, void *, EMPTYARG )
 
 aLbChartColors.GetFocus();
 aLbChartColors.SelectEntryPos( 0 );
+aPBRemove.Enable( sal_True );
 }
 
 return 0L;
@@ -217,6 +218,7 @@ IMPL_LINK( SvxDefaultColorOptPage, AddChartColor, void *, EMPTYARG )
 
 aLbChartColors.GetFocus();
 aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 );
+aPBRemove.Enable( sal_True );
 }
 
 return 0L;
@@ -251,6 +253,8 @@ IMPL_LINK( SvxDefaultColorOptPage, RemoveChartColor, PushButton*, pButton )
 aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 );
 else if (aLbChartColors.GetEntryCount() > 0)
 aLbChartColors.SelectEntryPos( nIndex );
+else
+aPBRemove.Enable( sal_False );
 }
 }
 
-- 
1.7.0.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

[Michael Münch]

Hi,

in Calc when clicking Insert->Hyperlink->WWW-Browser a webpage is opened
with a text containing OpenOffice.org and http://www.sun.com/staroffice
or http://www.openoffice.org depending on the language.

This patch replaces these strings with LibreOffice ones.

Regards,
Michael
>From 8196d726f0485b32da3e3a014f4e8e854a96f91b Mon Sep 17 00:00:00 2001
From: Michael Muench 
Date: Wed, 8 Jun 2011 18:17:28 +0200
Subject: [PATCH] replace OpenOffice.org and StarOffice references with
 LibreOffice

---
 .../wizard/desktop/lang/bg/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/cs/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/da/url_transfer.htm|6 +++---
 .../wizard/desktop/lang/de/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/en-GB/url_transfer.htm |4 ++--
 .../wizard/desktop/lang/en-US/url_transfer.htm |6 +++---
 .../wizard/desktop/lang/es/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/eu/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/fr/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/hu/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/it/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/ja/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/km/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/ko/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/nl/url_transfer.htm|6 +++---
 .../wizard/desktop/lang/pl/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/pt-BR/url_transfer.htm |4 ++--
 .../wizard/desktop/lang/pt/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/ru/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/sk/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/sl/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/sv/url_transfer.htm|4 ++--
 .../wizard/desktop/lang/vi/url_transfer.htm|6 +++---
 .../wizard/desktop/lang/zh-CN/url_transfer.htm |4 ++--
 .../wizard/desktop/lang/zh-TW/url_transfer.htm |4 ++--
 25 files changed, 54 insertions(+), 54 deletions(-)

diff --git a/extras/source/templates/wizard/desktop/lang/bg/url_transfer.htm b/extras/source/templates/wizard/desktop/lang/bg/url_transfer.htm
index 0fc22bb..b6cc540 100644
--- a/extras/source/templates/wizard/desktop/lang/bg/url_transfer.htm
+++ b/extras/source/templates/wizard/desktop/lang/bg/url_transfer.htm
@@ -38,7 +38,7 @@
   
   
   Âúâåäåòå
-íóæíèÿ URL àäðåñ â ïîëåòî çà URL íà OpenOffice.org èëè ãî ïîòúðñåòå
+íóæíèÿ URL àäðåñ â ïîëåòî çà URL íà LibreOffice èëè ãî ïîòúðñåòå
 ÷ðåç ôóíêöèèòå çà òúðñåíå íà ëåíòàòà ñ èíñòðóìåíòè Õèïåðâðúçêà.
   
 
@@ -50,7 +50,7 @@
   
   Èçáåðåòå
 URL àäðåñà, êîéòî å èçïèñàí â ïîëåòî çà URL àäðåñè (íàïð. http://www.sun.com/staroffice";>http://www.sun.com/staroffice).
+ href="http://www.libreoffice.org";>http://www.libreoffice.org).
   
 
 
diff --git a/extras/source/templates/wizard/desktop/lang/cs/url_transfer.htm b/extras/source/templates/wizard/desktop/lang/cs/url_transfer.htm
index fa890f8..5f91ef5 100644
--- a/extras/source/templates/wizard/desktop/lang/cs/url_transfer.htm
+++ b/extras/source/templates/wizard/desktop/lang/cs/url_transfer.htm
@@ -39,7 +39,7 @@
 		
 		
 			Enter the
-			required URL into the URL input line in OpenOffice.org or search
+			required URL into the URL input line in LibreOffice or search
 			for one by using the search functions in the Hyperlink bar.
 		
 	
@@ -50,7 +50,7 @@
 		
 			Select the URL
 			that appears in the URL input line (e.g.
-			http://www.sun.com/staroffice";>http://www.sun.com/staroffice).
+			http://www.libreoffice.org";>http://www.libreoffice.org).
 		
 	
 	
diff --git a/extras/source/templates/wizard/desktop/lang/da/url_transfer.htm b/extras/source/templates/wizard/desktop/lang/da/url_transfer.htm
index 651aa81..617d14d 100644
--- a/extras/source/templates/wizard/desktop/lang/da/url_transfer.htm
+++ b/extras/source/templates/wizard/desktop/lang/da/url_transfer.htm
@@ -38,7 +38,7 @@
 		
 		
 			Indtast den krævede URL i inputlinjen
-i OpenOffice.org eller søg efter en ved at bruge søgefunktionen i Hyperlinklinjen.
+i LibreOffice eller søg efter en ved at bruge søgefunktionen i Hyperlinklinjen.
 
 		
 	
@@ -49,7 +49,7 @@
 		
 			Marker den URL, der forekommer i 
 inputlinjen (e.g. 
-http://www.openoffice.org";>http://www.openoffice.org).
+http://www.libreoffic

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

[Noel Power]

On 08/06/11 14:19, Noel Power wrote:

On 08/06/11 13:55, Takeshi Abe wrote:


OK, so do you mean libs-core/desktop/source/migration?, which 
functionality

I have not yet recognized clearly.
It would be great if anyone familiar with the code suggests a starting
point to dig into.
I *think* this ( see attached patch ) will fix it, not had a chance to 
test it yet
Well that patch isn't quite enough :-( it seems the migration process 
doesn't cater for the config directory changing so when looking for 
candidates to migrate when creating a new user dir it looks relative to 
the new config directory ( e.g. ~/.config ) and of course finds nothing.


I guess we can easily hack around this by tweaking the config directory 
returned ( see attached ) and this seems ok for a  3.4 release where 
there can only be user configurations in $HOME. However subsequent 
releases >=  4.0  will probably have to start making things more 
complicated by searching the old ( for openoffice configurations ) and 
new & old directories for libreoffice (3) configurations, thoughts
diff --git desktop/source/migration/migration.cxx desktop/source/migration/migration.cxx
index 8248af0..2280eb4 100644
--- desktop/source/migration/migration.cxx
+++ desktop/source/migration/migration.cxx
@@ -88,6 +88,9 @@ static const ::rtl::OUString MENU_SEPERATOR(RTL_CONSTASCII_USTRINGPARAM(" | "));
 static const ::rtl::OUString MENU_SUBMENU(RTL_CONSTASCII_USTRINGPARAM("..."));
 static const ::rtl::OUString MIGRATION_STAMP_NAME(RTL_CONSTASCII_USTRINGPARAM("/MIGRATED"));
 
+
+static const char XDG_CONFIG_PART[] = "/.config";
+
 ::rtl::OUString retrieveLabelFromCommand(const ::rtl::OUString& sCommand, const ::rtl::OUString& sModuleIdentifier)
 {
 ::rtl::OUString sLabel;
@@ -553,6 +556,11 @@ install_info MigrationImpl::findInstallation(const strings_v& rVersions)
 {
 ::rtl::OUString aUserInst;
 osl::Security().getConfigDir( aUserInst );
+#if defined UNX && ! defined MACOSX
+// cater for XDG_CONFIG_HOME change
+if ( aUserInst.endsWithAsciiL( XDG_CONFIG_PART, sizeof( XDG_CONFIG_PART ) - 1 )  )
+aUserInst = aUserInst.copy( 0, aUserInst.getLength() - sizeof(  XDG_CONFIG_PART ) + 2 );
+#endif
 if ( aUserInst.getLength() && aUserInst[ aUserInst.getLength()-1 ] != '/' )
 aUserInst += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("/"));
 #if defined UNX && ! defined MACOSX
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#37584

[John LeMoyne Castle]

Test with LibreOffice 3.3.2 
OOO330m19 (Build:202)
tag libreoffice-3.3.2 

shows that Changes->Record does not produce redlining there either  
I feel sick 
jlc=={*-P}

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039788.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#37584

[John LeMoyne Castle]

Cedric, 
I apologize for the time cost for you to dig this up.  

I do remember removing a string copy (or maybe two?).  I should have clearly
seen the need for a full copy after digging into the counting process and
seeing the changes it made to the string in order to count excluding hidden
or redlined,  Definitely my bad for not testing more use cases (redlining). 
I will go back and review my work in this area.  

I see that this is marked as a regression against 3.3.2 and yet the word
count work was well over 6 months ago.  
I had thought that word count w/ and w/out spaces had rolled out prior to
3.3.2   
Perhaps the problem exists (undiscovered) in 3.3.2 as well.

jlc

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039644.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fix for fdo#37799

[Cedric Bosdonnat]

Hi all,

Could anyone review, sign-off and push to 3.4 branch the attached patch
fixing a broken loop? One less annoying bug for 3.4 ;)

Thanks,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
>From 7265c670608ebdc1006a89b9d478b22da2ab5e49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= 
Date: Wed, 8 Jun 2011 17:26:35 +0200
Subject: [PATCH] fdo#37799: fixed broken loop causing a crash

---
 sw/source/core/edit/edfld.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sw/source/core/edit/edfld.cxx b/sw/source/core/edit/edfld.cxx
index ebb1906..c07c4ef 100644
--- a/sw/source/core/edit/edfld.cxx
+++ b/sw/source/core/edit/edfld.cxx
@@ -204,7 +204,7 @@ void SwEditShell::FieldToText( SwFieldType* pType )
 
 SwFieldHint aHint( pPaM );
 SwClientIter aIter( *pType );
-for ( SwClient* pClient = aIter.GoStart(); pClient; aIter++ )
+for ( SwClient* pClient = aIter.GoStart(); pClient; pClient = aIter++ )
 {
 pPaM->DeleteMark();
 pClient->SwClientNotifyCall( *pType, aHint );
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LO Manager Config file, shell script and command line doco?

[djfw]

Please ignore, this was meant for the doc list.
Cheers,
David.

--
View this message in context: 
http://nabble.documentfoundation.org/LO-Manager-Config-file-shell-script-and-command-line-doco-tp3039513p3039520.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] LO Manager Config file, shell script and command line doco?

[djfw]

Hi,
Is there any doco for the rc or shell files or command line for LO Manager? 
I have tried the users forum and checked the help files, but no luck.
Cheers,
David

--
View this message in context: 
http://nabble.documentfoundation.org/LO-Manager-Config-file-shell-script-and-command-line-doco-tp3039513p3039513.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Replace DBG_ with OSL in writer and remove debug.hxx

[Petr Mladek]

Jacek Wolszczak píše v Út 07. 06. 2011 v 22:48 +0200:
> Hi,
> 
> 0001-Replace-DBG_-stuff-with-OSL_-equivalents-in-writer -- removes some
> last leftovers of DBG -> OSL conversion in writer
> 
> 0002-Remove-the-remaining-debug.hxx-includes-in-writer has to be applied
> along with 0001-Replace-DBG_ASSERT-with-OSL_ENSURE-in-svl-inc-svl-sv --
> and this way we completely got rid of debug.hxx in writer

Pushed. Thanks a lot for the contribution!

> BTW, does anyone use DBG_PROFSTART and DBG_PROFSTOP or could these be
> removed altogether?

Good question. I am not sure.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC] Re: KCachegrind

[Matúš Kukan]

Hi there,

On 7 June 2011 22:57, Michael Meeks  wrote:
>        So - then I wonder if we can catch the problem lower down - inside the
> valgrind 'cachegrind' skin. Now - I know what you're thinking: 'valgrind
> is a complicated nightmare' :-) but you're wrong. Valgrind skins are
> single-threaded, and amazingly simple (in my experience of skin hacking
> - mainly for iogrind admittedly).
>
Did you mean callgrind?

I don't like the code.
It's not a really big problem but I have problems with reading it
because of things like
'if (!CLG_(is_zero_cost)( CLG_(sets).full, currCost->cost ))' and others.

>        I -hope- that (since all the information is in-core at once in the
> valgrind process), that we can get the account right there - last I
> looked ~all of cachegrind was only ~1500 lines of code - hopefully an
> easy read. Presumably adding some --hide-object='libc.so.6,libuno.so'
> etc. is quite do-able there too ?
>
>        What do you think ? [ and sorry this is such a stretching
> experience ;-].
>
I think we should let it be.
It's a shame because it could be helpful but I don't think I am
capable of doing that (in a reasonable amount of time).
I think callgrind is built to produce output of special format and it
could be really hard change the way it's working.
Although I'm not really sure by this. I haven't yet found out how it is working.

At least it is possible to hide self cost of some libraries. But it's
almost the same like you were ignoring them in object view.

regards,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Trouble building the redland module on mac

[Thorsten Behrens]

William Lachance wrote:
> Apologies, there was a typo in my patch (had LIBXML_CFLAGS in one place
> where I should have add LIBXML_LIBS).
>
Great, works like a charm here - and making the build more resilient
always a worthy goal - pushed to master.

Thanks,

-- Thorsten


pgpqI4hRbMpjk.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Trouble building the redland module on mac

[William Lachance]

On Tue, Jun 7, 2011 at 5:24 PM, Thorsten Behrens  wrote:

> William Lachance wrote:
> > Christian suggested modifying the configure script not to use
> > xml2-config/xslt-config at all. Here's a patch which does exactly that.
> I'm
> > not exactly thrilled by the size/complexity of this patch for what it
> does,
> > but at the same time it does seem a bit crazy for LO not to build just
> > because libxml is installed in MacPorts (which is not uncommon: it's a
> > dependency of ImageMagick for instance).
> >
> Quick feedback - breaks here, with
>
> [...]
>

Apologies, there was a typo in my patch (had LIBXML_CFLAGS in one place
where I should have add LIBXML_LIBS). Not quite sure how that slipped by,
but I did a clean try at testing this patch twice, and it definitely works
for me (tm). :)
-- 
William Lachance
wrl...@gmail.com


raptor-dont-use-xml-xslt-config-at-all-take2.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Unity Quick List in StartCenter desktop file

[Bjoern Michaelsen]

Hi Kami,

On Wed, 8 Jun 2011 15:50:48 +0200
KAMI911 KAMI911  wrote:

> I am sad because it is not point of view at Canonical, but I
> understand your decision.

Just a short note: This is _not_ a "Canonical decision", but one that
was made by the whole Ubuntu community.

Best,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New Member

[Sasa Ostrouska]

Bemvindo :)

Rgds
Saxa

On Wed, Jun 8, 2011 at 10:59 AM, Klaibson Ribeiro  wrote:
> Hello.
>
> My name is Klaibson and yesterday me signed up in the LibreOffice in the
> FreeDesktop.
>
> I living in the Florianópolis, capital of Santa Catarina, Brazil. I'm leader
> user group LibreOffice in my state.
>
> I blog on LibreOffice in the Brazil, look www.brofficeparaleigos.org and
> writing and write the ebook LibreOffice.
>
> Good week.
>
>
>
> --
> Klaibson Ribeiro
> Tel: (48) 9625-8273
> www.creativesolucoes.com.br
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Пpемудрости учeта в новых условияx

[Пpeмудрости учeтa в новыx уcлoвиях]

>   ЭФФЕKТИВНЫЙ PУКOВОДИТЕЛЬ

>   Тpенинг • 22 июня • 2011 г.
>   г. Kиев • бульв. Шевчeнко 4 • отeль «Caнкт-Петербург»

>   Тeл.: (044) 223-4882 и 223-5141

-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-


Задачa любогo pукoвoдителя сделaть свoю оргaнизацию peзультативной кaк в 
кpaткoсрочном тaк и дoлгocрочном пeриoде. Bcе Тoп менeджеры стрeмятся к уcпеху 
cвoих opганизаций, a наcтоящий уcпех вoзможен толькo тогдa, кoгда oн подкpeплен 
личнoй успешнoстью в pукoвoдстве.
Чтo жe нeoбxодимо рукoводителю дeлaть, чтoбы быть уcпeшным упpавлeнцем?
Kaкиe зaдачи неoбходимо peшaть и кaк pасставить приоpитеты? Kакиe 
инcтpументы мeнeджмeнта использoвать, чтoбы дocтичь успexа?
Kaких рeзультaтов oжидают oт pуковoдителя?   
Дaнный трeнинг o тoм, чтo кaждoму рукoвoдителю «пo плeчу» доcтижение 
выдaющиxcя peзультатов.

ЦEЛЕВАЯ АУДИТОPИЯ
* Coбcтвенники, pуковoдители, ТОП-менeджеры, 
* pукoводители сpeднего звeна и coтpудники, зaчиcленные в кадpoвый рeзерв 
кoмпании 
* Тpeнинг идeально пoдxодит кaк для начинaющих менеджeров, тaк и для 
oпытныx pукoвoдителей. Блaгoдaря проxождению пpогpаммы, кaчecтво взaимодeйствия 
c пoдчиненными увeличивается, иcчезaют кoнфликты и нaпряжeние в отделaх, a 
pезультаты деятeльности pезко пoднимaютcя нa нoвый, ранeе нe дocтижимый уpoвень!

ЦEЛИ ТPEHИНГА
* Дaть понимaниe ключeвыx ЗАДAЧ эффeктивногo рукoводителя  – чтo дoлжен 
делaть эффeктивный лидep? 
* Понимaние CПОСОБОВ – c пoмoщью чeго oн дoлжен этo дeлaть? 
* Дaть понимaние ПРИHЦИПОВ – кaк oн этo должeн дeлать? 
* Опpeделение ключeвыx зaдач в paботе руковoдителя и ТOП менeджeров; 
* Дaть понимaние рeзультатов, кoтopые oжидaютcя oт дoлжнocтей
* Прeдоставить инстpументы для peзультативного упpавлeния

PEЗУЛЬТАТЫ ТPЕHИНГА
* Учacтникaм пpедставлен систeмный пoдxoд в paботе pуководителя для 
рeзультативного упpавления 
* Дaн пoдxод к упpавлeнию пepcонала начинaя oт пoдбopа и постaновки цeлeй и 
заканчивaя oценкой эффективноcти 
* Пpeдcтавлена cиcтема пocтpоения упрaвления бизнесoм и поcтpоения 
peзультaтивного упpавлeния

БИЗНEС-ТРЕНЕР

* Heмиpовский Игopь Бoриcович – гeнеpальный дирeктор 
трeнингoво-консалтинговой кoмпaнии «Лoголeкс», конcультант, имeющий 15 лeтний 
oпыт упpaвления нa ТOП дoлжнocтях в кoмпaниях лидeрах рынкa. Aвтoр 3x книг и 
бoлee 50 публикaций. Экспеpт пo вoпpосам рeзультативного pукoводства, cтратегии 
и пoстaновки сиcтeмы упpaвлeния бизнесoм. 

ПРОГPАММА ТPЕНИНГА

* CИСТЕМА РЕЗУЛЬТAТИВНОГО УПPАВЛЕНИЯ 
* Модeль компeтенций уcпeшного pукoводителя. Kлючевыe нaвыки и 
качeства. 
* Чтo такoe cистема pезультативного управлeния? 
* Пoчeму нeвозможно упpавлять и дoбивaтьcя поcтaвленных цeлей бeз 
сиcтемы рeзультaтивного упpавления 
* Структуpа сиcтeмы peзультативного упpавления 
* Oтличитeльныe осoбенности культуpы peзультативного упрaвления 
* Kак добивaтьcя иcпoлнения пoстaвленных зaдaч 
* 3 ключевыx задaчи рeзультaтивного упpавления 
* Пoстановка цeлeй и инcтpумeнты вoплощения иx в жизнь кaждoгo 
cотpудника 
* Перcонал – нaйм, сиcтема oценки и рaзвития 
* Pезультативное иcполнeние плaнoв и цeлeй  
* Pезультативное упpавление – рoль рукoводителя 
* Фоpмирование культуpы, ориeнтированной нa рeзультат 
* Культуpа – этo бoльше, чeм приятнoe впeчатлeние. Культурa – этo 
спoсобы поведeния и мышлeния, котoрые paзделяют cотpудники кoмпaнии 
* Пpиeм нa paботу пo законaм кoрпоративной культуpы 
* Культурa pезультативного упpaвлeния – этo paспределение 
oтветственности зa результaт 
* Cиcтeма oценки pуковoдителей пpи рeзультативном управлeнии 
* Систeма диффepeнциации пеpсонала

* РУKОВОДСТВО БИЗHЕСОМ 

* Упpaвлeнческий цикл 
* Oсновные функции упpaвления. Цикл упpавлeния: "Плaнирoвание - 
Пoстановка задaч - Мoтивирoвание - Кoнтpоль - Анaлиз и принятиe решeний". 

* Пocтановка целeй 
* Kaк раcставить пpиoритеты в бизнeсе и управлeнии? 
* Kaк oпpеделить тe 10% фактopов, котopые oпpеделяют успex бизнeca ? 
* Kритические фaкторы успеxа (KФУ) и иx poль в поcтaновке целeй 
* Kакиe цeли фоpмировать для бизнeса иcхoдя из cтадии paзвития 
компaнии? 
* Кaк опрeделить cтрaтегические цeли бизнeса 
* Kaк cтpaтегические цeли прeвратить в oпeрационные цeли 
* Кacкадирование цeлeй или кaк цeли кoмпании пpeвратить в цeли каждогo 
пoдрaзделения и сoтpудника 
* Cхема DuPont для фopмирования цeлей пoдpaзделений 
* Чтo важнo знaть pуководителю o KPI, KRI и PI 
* Oт дoлгoсрочных целeй к cтрaнице eжeдневника: pекомендации пo 
плaниpoванию. 
* Пpавила cамоменеджмента в течениe дня. Kaк быстpо «включитьcя в 
paботу», кaк pаспределять вниманиe мeжду дeлами, кaк зaвершать paбочий дeнь. 

* Кoнтроль pеaлизации целeй. Инcтpументы 
* Нe упpaвляйтe в слeпую – cдeлайте cебe пaнeль индикатoров 
* Kаки

[Libreoffice] New Member

[Klaibson Ribeiro]

Hello.

My name is Klaibson and yesterday me signed up in the LibreOffice in the
FreeDesktop.

I living in the Florianópolis,
capital of Santa
Catarina,
Brazil. I'm leader user group LibreOffice in my state.

I blog on LibreOffice in the Brazil, look www.brofficeparaleigos.org and
writing and write the ebook LibreOffice.

Good week.



-- 
Klaibson Ribeiro
Tel: (48) 9625-8273
www.creativesolucoes.com.br
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Unity Quick List in StartCenter desktop file

[KAMI911 KAMI911]

Hi Björn,

Of course I don't want to harm any UX @ Ubuntu, however I used this
modification for a while and it seems useful to me because I don't
have to put all main icons to the Unity bar. Starting all main
application from one icon is very comfortable. I am sad because it is
not point of view at Canonical, but I understand your decision.

Best regards,
KAMI

2011/6/5 Bjoern Michaelsen :
>
>
> Hi Kami,
>
> On Sun, 5 Jun 2011 11:54:04 +0200
> KAMI911 KAMI911  wrote:
>
>> I put direct launcher to main parts of LibO to StartCenter desktop
>> file. These starters are usable under Unity of Ubuntu.
>>
>> Here is the patch:
>> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=572c84d696926132b30060203cd1ab1b16b8fc49
>>
>> If possible you might cherry-pick to 3-4.
>>
>> Thank you in advance!
>
> this was discussed at:
>
> https://blueprints.launchpad.net/ubuntu/+spec/desktop-o-default-apps-unity-integration/
>
> along with all the other proposals from:
>
> http://askubuntu.com/questions/35488/list-of-custom-launchers-quicklists-for-unity
>
> but this one was rejected (and was not implemented already before)
> because in the launcher the different LibreOffice apps are separated
> entities and to start a "different app" from the icon breaks the user
> experience.
>
> So, while your work is very welcome I am against integrating this patch
> in the default install on behalf of the Ubuntu UX (and Ubuntu would be
> the primary customer of this).
>
> Users are of cause still free to add this quicklist manually. ;)
>
> Best,
>
> Bjoern
>
>
> --
> https://launchpad.net/~bjoern-michaelsen
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Replace List for vector<> in sc

[Petr Mladek]

Rafael Dominguez píše v Út 07. 06. 2011 v 19:05 -0430:
> Made a new patch, with the fixes now im using size_t to handle size,
> also ensuring we dont add a null object.

I have pushed it as 
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=31a268eb01d9d808a35ffe3161acbec7d4134519

Well, I have pushed the older patch and just replaced sal_uInt16 with
size_t.

IMHO, the check for existing pObj is not needed. It seems that the
method "Add" is always called with valid objects... If we start
supporting NULL parameter, do we really want to return 0 or the current
vector size?

Well, this whole code need some clean up and get rid of the sal_uInt16
limit...


Anyway, this was the last patch from this set => adding PUSHED into the
subject.

Thanks a lot for the contribution! It helps a lot to make the code
cleaner.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] which mailing list for extension writers?

[Sophie Gautier]

Hi Christian,
On 08/06/2011 13:55, Christian Andersson wrote:

Hi there, a short question, I'm writing an extension to libreoffice, and
I wonder which mailing lsit I should use for api questions, etc

should I use this mailing list (libreoffice@lists.freedesktop.org) or


on this one you should be able to reach more developers


should I use the users mailinglist (us...@libreoffice.org)?


I don't think so (but I don't closely follow it).

Ask your question here first, if you don't have any answer, then try 
again on the users@ list. And welcome :)


Kind regards
Sophie

--
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

[Noel Power]

On 08/06/11 13:55, Takeshi Abe wrote:


OK, so do you mean libs-core/desktop/source/migration?, which functionality
I have not yet recognized clearly.
It would be great if anyone familiar with the code suggests a starting
point to dig into.
I *think* this ( see attached patch ) will fix it, not had a chance to 
test it yet
diff --git a/officecfg/registry/data/org/openoffice/Setup.xcu b/officecfg/registry/data/org/openoffice/Setup.xcu
index 37e489b..6f156d1 100644
--- a/officecfg/registry/data/org/openoffice/Setup.xcu
+++ b/officecfg/registry/data/org/openoffice/Setup.xcu
@@ -783,12 +783,12 @@
 
   
 
-  
+  
 
   10
 
 
-  Openofice.org 3=openoffice.org/3,OpenOffice.org 2=openoffice.org2,StarOffice 8=staroffice8,StarSuite 8=starsuite8
+  Libreoffice 3=libreoffice/3,Openofice.org 3=openoffice.org/3,OpenOffice.org 2=openoffice.org2,StarOffice 8=staroffice8,StarSuite 8=starsuite8
 
 
   
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

[Takeshi Abe]

Hi Caolán,

Thanks for your comment!

On Tue, 07 Jun 2011 14:42:55 +0100, Caolán McNamara  wrote:
> Not an objection, but an aside that I presume this means we don't get
> automigration of user settings from the old config to the new config ?
> 
> Poke around in desktop and migration stuff IIRC to find what I'm talking
> about.
OK, so do you mean libs-core/desktop/source/migration?, which functionality
I have not yet recognized clearly.
It would be great if anyone familiar with the code suggests a starting
point to dig into.

Cheers,
-- Takeshi Abe
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 37584, which changed state.

Bug 37584 Summary: track changes: deleted text lost
https://bugs.freedesktop.org/show_bug.cgi?id=37584

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED][[REVIEW] fix for fdo#37584

[Caolán McNamara]

On Wed, 2011-06-08 at 10:28 +0200, Cedric Bosdonnat wrote:
> Hi all,
> 
> Could someone review the attached patch, sign it off and push it to the
> 3.4 branch?

Done.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSoC 2011][svgexport] add support for browsing slides

[Marco]

Hi all,
I implemented the javascript code for navigating through slides in
an svg exported presentation. At present I have tested it under
Firefox 4.0 and Opera 11.0 and everything works smoothly.

I attached a git patch based on origin/libreoffice-3-4-0.
Here there is a sample svg presentation you can play with:
https://docs.google.com/leaf?id=0BwS_9-CU4098ODZiMmYwMDAtMGU5MS00YjcwLTg5NjMtNzUzZTFkYjU5OTVi&sort=name&layout=list&num=50


Cheers,
  Marco


PS: I send this message again because probably the previous one
has not been accepted due to the attachment size

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

binQOIj1nL6mo.bin
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 36306, which changed state.

Bug 36306 Summary: LibreOffice 3.4 beta1 crash in Letter Wizard
https://bugs.freedesktop.org/show_bug.cgi?id=36306

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Ariel Constenla-Haile]

Hello Thorsten,

On Wednesday 08 June 2011, 05:29, Thorsten Behrens wrote:
> Marco wrote:
> > I hoped to get some type of object or container that let me to find
> > the selected thumbnail slides out.
> > On the contrary the result is that the selection type is "void",
> > that means "no selection" IMO.
> > 
> > So I don't know how to carry on this task.
> 
> Hi Marco,
> 
> Cc-ing the list, this may be of public interest - for the moment, I
> suggest you simply export *all* slides. Christian, off the top of
> your head, is there a way to retrieve the current selection from the
> Slidesorter via UNO?

I guess the export filter will get a reference to the document model, so he 
will need to get the "SubController" [1]
Model -> Controller -> SubController

Some dummy OOo Basic code:

Sub Test_SubController
Dim oDoc
oDoc = ThisComponent

Dim oController, oSubController
oController = oDoc.getCurrentController()

Dim aSelection, aPage
oSubController = oController.getPropertyValue("SubController")
If 
oSubController.supportsService("com.sun.star.drawing.DrawingDocumentDrawView") 
Then
REM It can be the Normal/Notes/Handout view
Select Case oController.DrawViewMode
Case com.sun.star.drawing.DrawViewMode.DRAW:
MsgBox "Normal" 
Case com.sun.star.drawing.DrawViewMode.NOTES:
MsgBox "Notes"
Case com.sun.star.drawing.DrawViewMode.HANDOUT:
MsgBox "Handout"
End Select
ElseIf 
oSubController.supportsService("com.sun.star.presentation.SlidesView") Then
MsgBox "Slide Sorter"
ElseIf 
oSubController.supportsService("com.sun.star.presentation.OutlineView") Then
MsgBox "Outline"
End If

aSelection = oSubController.getSelection()
'should be a "com.sun.star.drawing.ShapeCollection"

aPage = oSubController.getCurrentPage()
End Sub


[1] mmm documented but commented
http://svn.services.openoffice.org/opengrok/xref/DEV300_m106/offapi/com/sun/star/drawing/DrawingDocumentDrawView.idl#194

Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina


signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] which mailing list for extension writers?

[Christian Andersson]

Hi there, a short question, I'm writing an extension to libreoffice, and 
I wonder which mailing lsit I should use for api questions, etc


should I use this mailing list (libreoffice@lists.freedesktop.org) or 
should I use the users mailinglist (us...@libreoffice.org)?


/Christian Andersson
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace List for vector<> in sc

[Petr Mladek]

Rafael Dominguez píše v Út 07. 06. 2011 v 20:36 -0430:
> 
> 
> On Tue, Jun 7, 2011 at 8:19 PM, Rafael Dominguez
>  wrote:
> 
> 
> Also haven't pushed
> 0002-Replace-List-with-std-vector-XclExpUserBView.calc.patch 
> because I am not sure about

> Why do you initialize the vector with NULL pointers?

> 
> Nope, heres a patch fixing those issues

> 
> Forgot to remove the initializing the vector changed it for reserve. 

I have pushed it as 
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=b5feae757d14279216b68ae3a11e483c4841218f

Note that I have removed the game with pView pointer. The operator "new"
should newer return NULL. See also the other mail about
0001-Only-add-non-null-scenes-to-manager.patch

Also note that aViews.reserve is not really needed. The size of the
vector is not defined by "rChangeTrack.GetUserCollection().GetCount()"
but by the number of non-NULL "pStrData". The old "List" worked the same
way. aViews.reserve() might be only useful as a speedup optimization to
avoid memory relocations, see
http://www.cplusplus.com/reference/stl/vector/reserve/


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace List for vector<> in sc

[Petr Mladek]

Rafael Dominguez píše v Út 07. 06. 2011 v 20:21 -0430:
> Fix adding NULL objects to ExcEScenarioManager.

Ah, this was too paranoid ;-)

--- cut ---
--- a/sc/source/filter/xcl97/xcl97rec.cxx
+++ b/sc/source/filter/xcl97/xcl97rec.cxx
@@ -1328,11 +1328,16 @@ ExcEScenarioManager::ExcEScenarioManager( const
XclExpRoot& rRoot, SCTAB nTab )
 
 while( rDoc.IsScenario( nNewTab ) )
 {
-aScenes.push_back( new ExcEScenario( rRoot, nNewTab ) );
+ExcEScenario *scene = new ExcEScenario( rRoot, nNewTab );
 
-if( rDoc.IsActiveScenario( nNewTab ) )
-nActive = static_cast(nNewTab - nFirstTab);
-nNewTab++;
+if (scene)
+{
+aScenes.push_back( scene );
+
+if( rDoc.IsActiveScenario( nNewTab ) )
+nActive = static_cast(nNewTab - nFirstTab);
+nNewTab++;
+}
 }
 }
--- cut ---

IMHO, the "new" operand could fail only when there is not enough memory
or when it throws an exception. It always returns a pointer otherwise =>
there is not needed to check for the NULL pointer => the change is not
needed.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Patch for fdo#32786

[Samuel Mehrbrodt]

Hi,

I have a fix for fdo#32786 [1] and here's the patch. As stated in the
commit message, I copied the fix from the OOo repository [2] changing
just a few data types to the 'sal_' types.

When I wanted to commit, git complained about remaining tabs and so I
also replaced them with spaces. That makes the patch look bigger than it
actually was, but I didn't see another way.

The actual changes in the patch are in line 20 (import) and from line
580 down (removed lcl_TransliterateEditEngine and changed
ScDocument::TransliterateText).

This is my first contribution to LO, so I'm open for your feedback :)

[1] https://bugs.freedesktop.org/show_bug.cgi?id=32786
[2] http://hg.services.openoffice.org/OOO340/rev/de0464b37fb3

>From d0aecac0b523f2e55c6ebeb29843f0106bebecfe Mon Sep 17 00:00:00 2001
From: Samuel Mehrbrodt 
Date: Wed, 8 Jun 2011 12:16:24 +0200
Subject: [PATCH] Fix for fdo#32786: 'Capitalise Every Word' function

This fix is based on http://hg.services.openoffice.org/OOO340/rev/de0464b37fb3
Also replaced remaining tabs with spaces
---
 sc/source/core/data/documen8.cxx |  326 +-
 1 files changed, 145 insertions(+), 181 deletions(-)

diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index c8e5fda..f08445a 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -62,6 +62,8 @@
 #include 
 #include 
 
+#include 
+
 #include "inputopt.hxx"
 #include "global.hxx"
 #include "table.hxx"
@@ -87,7 +89,7 @@
 #include "chartlis.hxx"
 #include "chartlock.hxx"
 #include "refupdat.hxx"
-#include "validat.hxx"		// fuer HasMacroCalls
+#include "validat.hxx"   // fuer HasMacroCalls
 #include "markdata.hxx"
 #include "scmod.hxx"
 #include "printopt.hxx"
@@ -100,11 +102,11 @@
 #include "docuno.hxx"
 #include "scresid.hxx"
 
-#define GET_SCALEVALUE(set,id) 	((const SfxUInt16Item&)(set.Get( id ))).GetValue()
+#define GET_SCALEVALUE(set,id) ((const SfxUInt16Item&)(set.Get( id ))).GetValue()
 
-//	states for online spelling in the visible range (0 is set initially)
-#define VSPL_START	0
-#define VSPL_DONE	1
+//states for online spelling in the visible range (0 is set initially)
+#define VSPL_START 0
+#define VSPL_DONE 1
 
 
 // STATIC DATA ---
@@ -164,9 +166,9 @@ void ScDocument::SetPrinter( SfxPrinter* pNewPrinter )
 {
 if ( pNewPrinter == pPrinter )
 {
-//	#i6706# SetPrinter is called with the same printer again if
-//	the JobSetup has changed. In that case just call UpdateDrawPrinter
-//	(SetRefDevice for drawing layer) because of changed text sizes.
+//#i6706# SetPrinter is called with the same printer again if
+//the JobSetup has changed. In that case just call UpdateDrawPrinter
+//(SetRefDevice for drawing layer) because of changed text sizes.
 UpdateDrawPrinter();
 }
 else
@@ -241,10 +243,10 @@ void ScDocument::ModifyStyleSheet( SfxStyleSheetBase& rStyleSheet,
 {
 case SFX_STYLE_FAMILY_PAGE:
 {
-const sal_uInt16 nOldScale		  = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALE);
+const sal_uInt16 nOldScale = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALE);
 const sal_uInt16 nOldScaleToPages = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALETOPAGES);
 rSet.Put( rChanges );
-const sal_uInt16 nNewScale		  = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALE);
+const sal_uInt16 nNewScale = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALE);
 const sal_uInt16 nNewScaleToPages = GET_SCALEVALUE(rSet,ATTR_PAGE_SCALETOPAGES);
 
 if ( (nOldScale != nNewScale) || (nOldScaleToPages != nNewScaleToPages) )
@@ -286,9 +288,9 @@ void ScDocument::ModifyStyleSheet( SfxStyleSheetBase& rStyleSheet,
 }
 
 // Bedeutung der Items in rChanges:
-//	Item gesetzt	- Aenderung uebernehmen
-//	Dontcare		- Default setzen
-//	Default			- keine Aenderung
+// Item gesetzt - Aenderung uebernehmen
+// Dontcare - Default setzen
+// Default - keine Aenderung
 // ("keine Aenderung" geht nicht mit PutExtended, darum Schleife)
 for (sal_uInt16 nWhich = ATTR_PATTERN_START; nWhich <= ATTR_PATTERN_END; nWhich++)
 {
@@ -336,7 +338,7 @@ void ScDocument::InvalidateTextWidth( const String& rStyleName )
 
 void ScDocument::InvalidateTextWidth( SCTAB nTab )
 {
-ScAddress aAdrFrom( 0,	  0,nTab );
+ScAddress aAdrFrom( 0, 0, nTab );
 ScAddress aAdrTo  ( MAXCOL, MAXROW, nTab );
 InvalidateTextWidth( &aAdrFrom, &aAdrTo, false );
 }
@@ -345,7 +347,7 @@ void ScDocument::InvalidateTextWidth( SCTAB nTab )
 
 sal_Bool ScDocument::IsPageStyleInUse( const String& rStrPageStyle, SCTAB* pInTab )
 {
-sal_Bool		 bInUse = false;
+sal_Bool bInUse = false;
 const SCTAB nCount 

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Marco]

On Wed, 08 Jun 2011 12:23:25 +0200, Christian Lippka  wrote:


Am 08.06.2011 12:16, schrieb Marco:

but as I said aSelection internal type seems to be "void"
So from which controller should I get the XSelectionSupplier interface ?
You talk about an xModel object where should I get it from ?
I thought that I should get the frame/component representing the Slide  
sorter panel,

but I don't know how to do that, too.
Correctly you ask me where I am (that is which component/frame has the  
focus) when
I need this selection, well the answer is: inside the document export  
dialog, and

I guess that this makes all things more complex.
I currently do not have much time to look into this in detail. But I  
think


http://wiki.services.openoffice.org/wiki/Drawing_framework

can help you.  Basicly you will need to get the

"private:resource/floater/LeftImpressPane,  
private:resource/view/SlideSorter"


resource and find its XSelectionSupplier interface.  How this is  
actually done I don't

know (yet).



Hi Christian,
thanks to point out this documentation! :)
I 'll read it as soon as possible.


Cheers,
   Marco

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Christian Lippka]

Am 08.06.2011 12:16, schrieb Marco:

but as I said aSelection internal type seems to be "void"
So from which controller should I get the XSelectionSupplier interface ?
You talk about an xModel object where should I get it from ?
I thought that I should get the frame/component representing the Slide 
sorter panel,

but I don't know how to do that, too.
Correctly you ask me where I am (that is which component/frame has the 
focus) when
I need this selection, well the answer is: inside the document export 
dialog, and

I guess that this makes all things more complex.

I currently do not have much time to look into this in detail. But I think

http://wiki.services.openoffice.org/wiki/Drawing_framework

can help you.  Basicly you will need to get the

"private:resource/floater/LeftImpressPane, 
private:resource/view/SlideSorter"


resource and find its XSelectionSupplier interface.  How this is 
actually done I don't

know (yet).

Regards,
Christian

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Marco]

On Wed, 08 Jun 2011 10:54:21 +0200, Regina Henschel  
 wrote:



Hi Thorsten,


Thorsten Behrens schrieb:


Cc-ing the list, this may be of public interest - for the moment, I
suggest you simply export *all* slides. Christian, off the top of
your head, is there a way to retrieve the current selection from the
Slidesorter via UNO?



Using Basic you first get the selection
 oShapeCollection = oCurrentController.Selection
and then you can distinguish via varType, whether it is an object or an  
array of object.

 nVarType = VarType(oShapeCollection)
 '9 object; Something is selected in Normal view
 '8201=8192+9 array of object; Slides are selected in slide sorter.


Hi Regina,
thanks for your reply.
The problem as I explained in my reply to Christian is that
the selection I get from the current controller is of type "void"!

Cheers,
   Marco


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Marco]

On Wed, 08 Jun 2011 10:44:14 +0200, Christian Lippka  wrote:


Hi Marco,

Am 08.06.2011 10:29, schrieb Thorsten Behrens:

Marco wrote:

I hoped to get some type of object or container that let me to find
the selected thumbnail slides out.
On the contrary the result is that the selection type is "void",
that means "no selection" IMO.

So I don't know how to carry on this task.


Hi Marco,

Cc-ing the list, this may be of public interest - for the moment, I
suggest you simply export *all* slides. Christian, off the top of
your head, is there a way to retrieve the current selection from the
Slidesorter via UNO?
There is a SdUnoSlideView::getSelection implementation that puts all  
selected slides as XDrawPage reference in a

sequence so chances are good it does what you are looking for.
The open question is how to get the correct XSelectionSupplier to call  
getSelection on. I would hope that it is
the obvious one, xModel->getCurrentController(). But Andrés view  
hierarchy may be more complex than that.
But it also depends if you only need this if you are actual in the slide  
sorter view. If you need this from the slide panel
than this may be more complicate. Feel free to ask about that specific  
if you can't figure that out for yourself.




Hi Christian,
thanks for your quick reply.
Yes, the problem is how to get the correct XSelectionSupplier.
The present code find the current showed slide out:


uno::Reference< frame::XDesktop > xDesktop( mxMSF->createInstance(  
::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM "com.sun.star.frame.Desktop"  
)) ), uno::UNO_QUERY);

if( xDesktop.is() )
{
uno::Reference< frame::XFrame > xFrame(  
xDesktop->getCurrentFrame() );


if( xFrame.is() )
{
uno::Reference< frame::XController > xController(  
xFrame->getController() );


if( xController.is() )
{
uno::Reference< drawing::XDrawView > xDrawView(  
xController, uno::UNO_QUERY );

if( xDrawView.is() )
{
uno::Reference< drawing::XDrawPage > xDrawPage(  
xDrawView->getCurrentPage() );


if( xDrawPage.is() )
{
uno::Reference< beans::XPropertySet >(  
xDrawPage, uno::UNO_QUERY )->
getPropertyValue( ::rtl::OUString(  
RTL_CONSTASCII_USTRINGPARAM( "Number" ) ) ) >>= nCurrentPageNumber;

}
}
}
}
}

I tried to get a XSelectionSupplier interface from the xController object  
above:


uno::Reference< view::XSelectionSupplier >  
xSelectionSupplier( xController, uno::UNO_QUERY );

if( xSelectionSupplier.is() )
{
	::com::sun::star::uno::Any aSelection =  
xSelectionSupplier->getSelection();

OUString sTypeName = aSelection.getValueTypeName();
	OSL_TRACE("Selection Type: '%s'\n",   
OUStringToOString( sTypeName, RTL_TEXTENCODING_UTF8 ).getStr());

}
else
{
OSL_TRACE ("xSelectionSupplier.is() == false");
}

but as I said aSelection internal type seems to be "void"
So from which controller should I get the XSelectionSupplier interface ?
You talk about an xModel object where should I get it from ?
I thought that I should get the frame/component representing the Slide  
sorter panel,

but I don't know how to do that, too.
Correctly you ask me where I am (that is which component/frame has the  
focus) when
I need this selection, well the answer is: inside the document export  
dialog, and

I guess that this makes all things more complex.


Cheers,
   Marco

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] MacOS path in python wrapper on Linux i586

[Petr Mladek]

Christian Lohmaier píše v Út 07. 06. 2011 v 18:24 +0200:
> Hi Petr, *,
> 
> On Tue, Jun 7, 2011 at 5:20 PM, Petr Mladek  wrote:
> > [...]
> > The path mentions "MacOS" but I build on Linux i586. [...}
> 
> pull in ure, I pushed the fix & cleanup to get rid of the orig/rej makefiles
> 
> git diff --color 5fa1572..a56953a pyuno
> 
> is what my change to ure was supposed to look like in the first place :-)

Looks OK now. Thanks a lot for the fix!


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANNOUNCE] libreoffice-3.3.3.2 tag skipped (3.3.3-rc2)

[Petr Mladek]

Hi,

no changes have been committed into the libreoffice-3-3-3 branch. The
code is exactly the same as for the tag libreoffice-3.3.3.1
(3.3.3-rc1). Hence it does not make sense to do the libreoffice-3.3.3.2
tag and 3.3.3-rc2 build.

If no blocker is found, 3.3.3-rc1 will be marked as final on June 15, 2011.

See also the schedule at 
http://wiki.documentfoundation.org/ReleasePlan#3.3_release
and release criteria at http://wiki.documentfoundation.org/Release_Criteria


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 37390, which changed state.

Bug 37390 Summary: LibreOffice does not create valid ODF.
https://bugs.freedesktop.org/show_bug.cgi?id=37390

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Christian Lippka]

Hi Marco,

Am 08.06.2011 10:29, schrieb Thorsten Behrens:

Marco wrote:

I hoped to get some type of object or container that let me to find
the selected thumbnail slides out.
On the contrary the result is that the selection type is "void",
that means "no selection" IMO.

So I don't know how to carry on this task.


Hi Marco,

Cc-ing the list, this may be of public interest - for the moment, I
suggest you simply export *all* slides. Christian, off the top of
your head, is there a way to retrieve the current selection from the
Slidesorter via UNO?
There is a SdUnoSlideView::getSelection implementation that puts all 
selected slides as XDrawPage reference in a

sequence so chances are good it does what you are looking for.
The open question is how to get the correct XSelectionSupplier to call 
getSelection on. I would hope that it is
the obvious one, xModel->getCurrentController(). But Andrés view 
hierarchy may be more complex than that.
But it also depends if you only need this if you are actual in the slide 
sorter view. If you need this from the slide panel
than this may be more complicate. Feel free to ask about that specific 
if you can't figure that out for yourself.


Regards,
Christian

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] autocorrection crash fdo#38000

[Cedric Bosdonnat]

Hello Michael,

On Tue, 2011-06-07 at 17:53 +0100, Michael Meeks wrote:
>   It'd be lovely to cherry-pick to libreoffice-3-4 from master :-)

Pushed, thanks for the fix and keep providing good patches like this
one ;)

Thanks,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Regina Henschel]

Hi Thorsten,


Thorsten Behrens schrieb:


Cc-ing the list, this may be of public interest - for the moment, I
suggest you simply export *all* slides. Christian, off the top of
your head, is there a way to retrieve the current selection from the
Slidesorter via UNO?



Using Basic you first get the selection
oShapeCollection = oCurrentController.Selection
and then you can distinguish via varType, whether it is an object or an 
array of object.

nVarType = VarType(oShapeCollection)
'9 object; Something is selected in Normal view
'8201=8192+9 array of object; Slides are selected in slide sorter.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate code: hwpreader.cxx

[Korrawit Pruegsanusak]

Hello Christina, Michael, *

On Wed, Jun 8, 2011 at 13:31, Christina Rossmanith  wrote:
> Once upon a time the easy hacks list had a topic "SIMIAN" (similarity 
> analyser). Now it's gone, don't know why, don't know when, don't know 
> where... It was quite nice because it had the precise instructions how to 
> invoke simian. So you could start without reading much - just copy&paste and 
> see what happens  :-)

It is currently there, not missing :)
http://wiki.documentfoundation.org/Development/Easy_Hacks_Complete_List#copy.2Fpaste_code_detector_.2F_fixing

Oh, I should start working instead of shouting like this ;-)

Best Regards,
--
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

[Thorsten Behrens]

Marco wrote:
> I hoped to get some type of object or container that let me to find
> the selected thumbnail slides out.
> On the contrary the result is that the selection type is "void",
> that means "no selection" IMO.
> 
> So I don't know how to carry on this task.
> 
Hi Marco,

Cc-ing the list, this may be of public interest - for the moment, I
suggest you simply export *all* slides. Christian, off the top of
your head, is there a way to retrieve the current selection from the
Slidesorter via UNO?

Cheers,

-- Thorsten


pgp3GfNDaiLph.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fix for fdo#37584

[Cedric Bosdonnat]

Hi all,

Could someone review the attached patch, sign it off and push it to the
3.4 branch?

John, I CC'ed you particularly to point out a bug in one of your
previous commits... that made me search hours long the source of the
bug. Please take care of these kind of things for your next patches.

Thanks,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
>From 8faf697371a603eb2fa0b47ba5ab297977e7e02a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= 
Date: Wed, 8 Jun 2011 10:06:23 +0200
Subject: [PATCH] fdo#37584: Make a real copy of the text where to count words

Const-casting a reference doesn't create a copy of it and then the
spaces replacement made by the WordCount was also made on the actual
text node. Use String::Copy() to actually copy the text and safely
operate on it.
---
 sw/source/core/txtnode/txtedt.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sw/source/core/txtnode/txtedt.cxx b/sw/source/core/txtnode/txtedt.cxx
index d4c02b6..08d0c6b 100644
--- a/sw/source/core/txtnode/txtedt.cxx
+++ b/sw/source/core/txtnode/txtedt.cxx
@@ -1814,7 +1814,7 @@ void SwTxtNode::CountWords( SwDocStat& rStat,
 }
 
 // make a copy of the text
-String& rTextCopy = const_cast(m_Text);
+String rTextCopy = m_Text.Copy( );
 
 // mask out the redlined and hidden text with ' '
 const xub_Unicode cChar(' ');
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35673

--- Comment #143 from Michael Meeks  2011-06-08 
00:51:30 PDT ---
suggest 37825 - can't un-encrypt a file.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice