Re: [Libreoffice] patch for make to help in gbuild debugging

[Thorsten Behrens]

Lubos Lunak wrote:
> > Also: This does not even have to be done intentionally -- some
> > performance hack might very well also accidentally fix an build
> > breaker.
> 
>  The world is not perfect. I think we all know. What is your point?
> 
That the world is not perfect, and certain setups favour certain
moves.

But I think we're starting to talk past each other. Let's not waste
more time on this, until there's more than just idle thoughts on
either side.
 
Cheers,

-- Thorsten


pgp4cQglh3xCE.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] RTF support

[Miklos Vajna]

On Wed, Jun 29, 2011 at 02:53:28PM -0700, tracey002  wrote:
> I parsed a Libre Office RTF document and found a  number of RTF controls 
> that are not in the Microsoft RTF Specification.
> Is there a list of non-Microsoft RTF controls used by Libre Office?

I don't know about any specification for that, sorry - we all inherited
those from OOo.

From memory, those are:

- pgdsctbl group: for page styles
- updnprop group: for sub/superscript
- hyphen group: for detailed hyphenation properties

If you can write a script that extracts keywords from the exporter and
looks them up in the spec, finally lists the custom ones in the wiki,
that would be great. Otherwise I'll probably do it some day.


pgpUe6qRGUVHM.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] RTF support

[Cedric Bosdonnat]

Hi Tracey,

On Wed, 2011-06-29 at 14:53 -0700, tracey002 wrote:
> I parsed a Libre Office RTF document and found a  number of RTF
> controls 
> that are not in the Microsoft RTF Specification. 
> Is there a list of non-Microsoft RTF controls used by Libre Office? 

Hum, I don't think there is such a list anywhere. These are mostly hacks
for the formatted copy / paste feature. IIRC page formatting has quite
some of these.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build problem on OpenIndiana 148

[Miklos Vajna]

On Wed, Jun 29, 2011 at 12:15:10PM -0700, Gary  wrote:
> I'm using a recent release and configured using './configure
> --with-distro=Solaris' but fails when trying to patch scalc...

See here:

http://wiki.documentfoundation.org/Development/Native_Build

That won't apply patches, so they won't fail. :)


pgp64knoxo7OO.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] extra testing needed for 3.4.2 Linux fullscreen slideshow

[Thorsten Behrens]

Sophie Gautier wrote:
> Thanks! just write it on this thread, I'll upload and format it on Litmus.
> 
Ok -

this affects Linux only. What we'd need is people testing 3.4.2 on
multi-monitor setups, on as many window managers / desktop
environments flavours and versions as possible (the former - compiz,
metacity and kwin at least - the latter: gnome, kde, xfce, lxde,
preferrably)

Steps to perform: 
 * install 3.4.2 and 3.4.1, perform the steps below with both
   version - we're only interested in differences
 * make sure Presenter Screen extension is installed
 * start with a single monitor
   * start slideshow - does the fullscreen window cover the whole
 screen, is it in front of all panels, task bars etc?
   * exit slideshow, change screen resolution
   * repeat step 1
 * keep Impress running, enable 2nd screen
   * perform same steps as the subitems above - this time, the 
 presenter screen has to be on one monitor, the actual slideshow
 on the other
   * go to Slideshow->Slideshow Settings. Play with the multiple
 display settings there. Specifically, does the "show on both"
 option work?

Many thanks,

-- Thorsten


pgp91DSDscqtI.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fw: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and Solaris X86

[Thorsten Behrens]

Hi Karl, let me forward that to our dev list, so others have the
opportunity to chime in -

generally, you'll see that, once initial steps are made, other
people will start to show up & help. IIRC there was previous
interest, at least for building on openindiana.

As for where to start:

http://www.libreoffice.org/get-involved/developers/

(i.e. grab the git repos, install the prerequisites)

You'll hit a few bumps for sure, the best place for ~immediate help
then is irc: #libreoffice-dev

Also, you may find helpful tips here:

http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide/Building_on_Solaris

Please let us know how this works out,

HTH, Thorsten

- Forwarded message from Karl Behler - IPP - E1  
-

Date: Thu, 30 Jun 2011 09:54:27 +0200
From: Karl Behler - IPP - E1 
Subject: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and
Solaris X86

Dear Thorsten,

we at our institute have the platforms required available (SPARC and
X86), we also on a regular basis maintain our Solaris OS and Solaris
compilers, also we do a little software development (mostly in C), but
nobody of us was ever involved in such a huge PD project. In fact we
are mostly occupied with administrative and maintenance stuff. Would
you think, we (in fact I) have a chance to take over the duties you
mentioned? At the beginning I could try to make LO from source and
find out if that works. However, if there will be some problems I
probably would need a lot of help.

Any advice, where to start with???

Regards,

Karl

On 30.06.11 09:14, Thorsten Behrens wrote:
> Karl Behler wrote:
>> I have been redirected from LibreOffice Forum (DE) to this list.
>> My question is: Why is LO 3.3.3 not available for Solaris (any)?
>> Or will it be available at some time?
>> 
> Hi Karl,
> 
> every platform LibreOffice ships on needs a team of motivated
> people, that
> 
>   * regularly build it on that platform
>   * are willing to fix bugs
>   * ultimately provide release builds
> 
> So far, nobody stepped up for Solaris - maybe it can be you?
> 
> If you're interested in helping out, our developer list is the right
> place to go: libreoffice@lists.freedesktop.org
> 
> Cheers,
> 
> -- Thorsten

- End forwarded message -



pgpYpBo96qxuZ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] avoid overwriting stack

[David Tardon]

Hi all,

could someone review commit 01096e7487d9e60fcd24eea8131b650588845f2b in
libs-core for 3.4?

It fixes the following crash scenario:

1. create new presentation
2. press F11 to open stylist
3. right click on a style and click on Modify
4. press Esc (or click Cancel)
5. press F11

It does not happen if the stylist is closed using menu. Neither it
happen in Writer.

It crashes because pbDeleted member of SfxCommonTemplateDialog_Impl is
set to point to a stack variable in SfxCommonTemplateDialog_Impl::Exec_Impl
and is not reset to 0 if the code returns through

if ( !pItem || aDeleted )
return sal_False;

. ~SfxCommonTemplateDialog_Impl writes into pbDeleted->bDead, but at
that point the stack variable no longer exists, so it just overwrites
a couple of bytes somewhere on the stack.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Possibilities of Webdav

[Christian Andersson]

Hi there I hope someone could help me answering a question regarding the 
webdav implementation of Libreoffice.


Now I have tried searching in libreoffice websites for some information, 
with little or no luck at all..  I have also read thsi docuement, but it 
does not give me any clarity either 
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/AppendixC/The_WebDAV_Content_Provider


(some background)

I have plugin that is working with a Document management system which 
provides a webdav interface which I use to load and save documents to.


now this documents management system has an integration with another 
editor in that when the document is saved to the server (via webdav) it 
returns data to the document editor as header properties of the PUT 
request. (like document number, it is later used for different things, 
but not stored in the document itself)


now question, can I with a plugin in openoffice get a hold of these 
headers after the document has been saved?  I fthat is possible somehow, 
then I might be able to replace the other editor with openoffice.org


/Christian Andersson



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA

[vikt...@gmail.com]

On 06/29/2011 07:47 PM, Vik Tara wrote:
>
> On Wed, Jun 29, 2011 at 6:15 PM, Tor Lillqvist  > wrote:
>
> > Can I actually build the windows binaries on linux?
>
> Not yet.
>
>
>
> OK - reviewed the windows build instructions - doesn't look like much
> fun - but will try it ;)
>
> Is there an easier way than building everything for me to debug the issue?
For example, is it possible to build just the module that is causing a
problem with the debug flags set, and replace just
that .dll in LibreOffice, rather than building the whole source?

TIA


Vik
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Building libreoffice on windows

[Stuart Ledwich (Hotmail)]

I am attempting to build libre in debug mode on windows and after quite
some time I have hit the following problem:

cl  -MDd -W3 -nologo -I. -I..  -I. 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/stl 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/external 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc 
-IH:/src/libre/bootstrap/solenv/wntmsci12/inc 
-IH:/src/libre/bootstrap/solenv/inc -IH:/src/libre/bootstrap/res 
-IC:/PROGRA~1/Java/JDK15~1.0_2/include/win32 
-IC:/PROGRA~1/Java/JDK15~1.0_2/include -IH:/winsdk71/include 
-IC:/PROGRA~1/MICROS~1.0/VC/include -IF:/MICROS~1/include 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro\inc\external\glib-2.0 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro\inc\external\cairo -LD 
-Fepangocairolo.dll pangocairo-context.obj  pangocairo-font.obj  
pangocairo-fontmap.obj  pangocairo-render.obj  pangocairo-win32font.obj  
pangocairo-win32fontmap.obj 
H:/src/libre/bootstrap/solver/350/wntmsci12.pro\lib\glib-2.0.lib 
H:/src/libre/bootstrap/solver/350/wntmsci12.pro\lib\gobject-2.0.lib 
H:/src/libre/bootstrap/solver/350/wntmsci12.pro\lib\gmodu
 le-2.0.lib H:/src/libre/bootstrap/solver/350/wntmsci12.pro\lib\intl.lib  
pango-1.0.lib H:/src/libre/bootstrap/solver/350/wntmsci12.pro\lib\cairo.lib  
pangowin32-1.0.lib  user32.lib gdi32.lib advapi32.lib /link /machine:ix86 
/debug /nodefaultlib:msvcrt.lib /implib:pangocairo-1.0.lib /def:pangocairo.def
LINK : fatal error LNK1104: cannot open file 'pango-1.0.lib'
NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~1.0\VC\bin\cl.EXE' : return code 
'0x2'


I have also pulled this which I think is related in build-error.log

log for /cygdrive/h/src/libre/bootstrap/pango
if [ -f ./wntmsci12.pro/misc/build/pango-1.28.3.exists ] ; then mv 
./wntmsci12.pro/misc/build/pango-1.28.3 
./wntmsci12.pro/misc/build/pango-1.28.3_removeme ; fi
make writeable...
patching file pango-1.28.3/configure
patching file pango-1.28.3/pango/makefile.msc
Hunk #3 succeeded at 33 (offset 3 lines).
Hunk #11 succeeded at 270 (offset -7 lines).
patching file pango-1.28.3/pango/module-defs-win32.c
patching file pango-1.28.3/pango/pango-enum-types.c
patching file pango-1.28.3/pango/pango-enum-types.h
patching file pango-1.28.3/pango/pango-language.c
patching file pango-1.28.3/pango/pango-utils.c
patching file pango-1.28.3/pango/pango.def
patching file pango-1.28.3/config.h
patching file pango-1.28.3/msvc_recommended_pragmas.h
sleep 2
mkdir: cannot create directory 
`./wntmsci12.pro/misc/build/pango-1.28.3/./pango': File exists

Microsoft (R) Program Maintenance Utility Version 9.00.30729.01
Copyright (C) Microsoft Corporation.  All rights reserved.

for %d in (pango pangowin32 pangocairo) do nmake -nologo -f 
makefile.msc sub-one-dll THIS=%d

H:\src\libre\bootstrap\clone\libs-extern-sys\pango\wntmsci12.pro\misc\build\pango-1.28.3\pango>nmake
 -nologo -f makefile.msc sub-one-dll THIS=pango 
nmake -nologo -f makefile.msc pangolo.dll PACKAGE=pango OBJS_pango=1
F:/cygwin/bin/perl 
H:/src/libre/bootstrap/solver/350/wntmsci12.pro\bin\glib-mkenums   --fhead 
"#include "  --fprod "\n/* enumerations from \"@filename@\" */"  
--vhead "GType\n@enum_name@_get_type (void)\n{\n  static GType etype = 0;\n  if 
(etype == 0) {\nstatic const G@Type@Value values[] = {"  --vprod "  
{ @VALUENAME@, \"@VALUENAME@\", \"@valuenick@\" },"  --vtail "  { 0, NULL, 
NULL }\n};\netype = g_@type@_register_static (\"@EnumName@\", 
values);\n  }\n  return etype;\n}\n"  pango.h  
pango-attributes.h  pango-break.h   pango-context.h 
pango-coverage.hpango-engine.h  pango-font.hpango-fontmap.h 
pango-fontset.h pango-glyph.h   pango-glyph-item.h  pango-gravity.h 
pango-item.hpango-layout.h  pango-modules.h 
pango-renderer.hpango-script.h  pango-tabs.hpango-types.h   
pango-utils.h   pangofc-font.h  pangofc-fontmap.h > 
pango-enum-types.c
cl  -MDd -W3 -nologo -I. -I..  -I. 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/stl 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/external 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc 
-IH:/src/libre/bootstrap/solenv/wntmsci12/inc 
-IH:/src/libre/bootstrap/solenv/inc -IH:/src/libre/bootstrap/res 
-IC:/PROGRA~1/Java/JDK15~1.0_2/include/win32 
-IC:/PROGRA~1/Java/JDK15~1.0_2/include -IH:/winsdk71/include 
-IC:/PROGRA~1/MICROS~1.0/VC/include -IF:/MICROS~1/include 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro\inc\external\glib-2.0 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro\inc\external\cairo -GD -c 
-FI..\msvc_recommended_pragmas.h -I. -I..  -I. 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/stl 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc/external 
-IH:/src/libre/bootstrap/solver/350/wntmsci12.pro/inc 
-IH:/src/libre/bootstrap/solenv/wntmsci12/inc 
-IH:/src/libre/bootstrap/solenv/inc -I

Re: [Libreoffice] [REVIEW] UPDATE: Swedish spelling dictionary v1.46

[Andras Timar]

Hi,

2011/6/30 Andras Timar :
> Hi Göran,
>
> 2011/6/30 Göran Andersson :
>> I've updated the Swedish spelling dictionary. It is available at
>> http://code.google.com/p/dsso/,
>> the latest version is
>> http://dsso.googlecode.com/files/ooo_swedish_dict_1.46.oxt.
>>
>> It seems LibreOffice currently ships version 1.43; please update it to
>> v1.46.
>>
>
> OK, I'll take care of this.
>
Please sign-off this for 3-4.
http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=eb4cd4086bcac5d120bad9fa35c14bb1c057abfc

Thanks,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA

[Tor Lillqvist]

> For example, is it possible to build just the module that is causing a
> problem with the debug flags set, and replace just
> that .dll in LibreOffice, rather than building the whole source?

You also need to build the modules that it depends on. Depending on how high in 
the dependency hierarchy the module you are interested in is located, that 
might be a large or small part of the code.

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED][PUSHED: 3-4] UPDATE: Swedish spelling dictionary v1.46

[Petr Mladek]

Andras Timar píše v Čt 30. 06. 2011 v 11:14 +0200:
> Hi,
> 
> 2011/6/30 Andras Timar :
> > Hi Göran,
> >
> > 2011/6/30 Göran Andersson :
> >> I've updated the Swedish spelling dictionary. It is available at
> >> http://code.google.com/p/dsso/,
> >> the latest version is
> >> http://dsso.googlecode.com/files/ooo_swedish_dict_1.46.oxt.
> >>
> >> It seems LibreOffice currently ships version 1.43; please update it to
> >> v1.46.
> >>
> >
> > OK, I'll take care of this.
> >
> Please sign-off this for 3-4.
> http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=eb4cd4086bcac5d120bad9fa35c14bb1c057abfc

Looked fine => pushed into libreoffice-3-4 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA

[Stuart Ledwich]

One of the problems I am facing is there is a hang from my app
communcatiing with Libre. Again it always seems to be at the stage of
getting the list of text fields:

xTextFieldsSupplier.getTextFields();

This results in the system hanging and upon inspection of the stack
trace it appears to be waiting for a response from Libre. This test was
performed with a brand new document to try to discount any problems with
a corrupted document. After checking with my debugger attached to libre
office it does not show any exception or crash.
  

Thread [main] (Suspended)   
Object.wait(long) line: not available [native method]   
JobQueue.removeJob(int) line: 221   
JobQueue.enter(int, Object) line: 331   
JobQueue.enter(Object) line: 304
JavaThreadPool.enter(Object, ThreadId) line: 91 
java_remote_bridge.sendRequest(String, Type, String, Object[]) line: 
639
ProxyFactory$Handler.request(String, Object[]) line: 151
ProxyFactory$Handler.invoke(Object, Method, Object[]) line: 133 
$Proxy28.getTextFields() line: not available
TextFieldService.getUserTextFields() line: 279  
OpenOfficeManager$OOViewer.getMergeFields(ITextDocument) line: 580  
OpenOfficeManager$OOViewer.getMergeFields() line: 541   
FieldLookupMailMerge.initQuery() line: 395  
FieldLookupMailMerge.openFieldLookup(Composite) line: 115   
TreeMailMergeNavigator.openNewDocument(Shell) line: 715 
TreeMailMergeNavigator.menuNewDocument(Shell) line: 783 
TreeMailMergeNavigator.startMailMergeOperation(Shell, 
TreeMailMergeNavigator$Operations, TreeItem) line: 386
PropcoUserView.MailMergeMenu(TreeMailMergeNavigator$Operations) line: 
1997  
PropcoUserView$1MailMergeMenuNavigator.widgetSelected(SelectionEvent) 
line: 1581
TypedListener.handleEvent(Event) line: not available
EventTable.sendEvent(Event) line: not available 
Button(Widget).sendEvent(Event) line: not available 
Display.runDeferredEvents() line: not available 
Display.readAndDispatch() line: not available   
PropcoUserView.main(String[]) line: 2408


Any help much appreciated.

  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Two-stage install on Windows

[Andras Timar]

Hi,

I was working on https://bugs.freedesktop.org/show_bug.cgi?id=32335
(Under Traditional Chinese environment, the installation process
showed bizarre characters) which is still unresolved but at least I
learned that the problem was not in LibreOffice source but in the
official build environment. Anyway, I started to think about why we
use two-stage install on Windows. Why don't we simply extract the MSI
installer (e.g. with NSIS silent install) to a temp folder and start
setup.exe without a -lang switch. setup.exe can find out the correct
language itself. We could get rid of NSIS limitations (non-Unicode),
and we would not put installer files to the average user's desktop.
Systems administrators can still extract the MSI installer with the
/EXTRACTONLY=ON switch of NSIS.

Do you have arguments for the current two-stage install method?

Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

[Caolán McNamara]

I've added a "remove" method to the O[U]StringBuffers to make it easy to
remove text from them without painful assembly of a new one by copying
segments out of an old one.

These StringBuffers were originally modelled after the Java equivalents.
Since the sal ones were written Java added "delete" methods to their
string buffers but delete is a reserved c++ keyword, so I called them
"remove" here.

It takes start position and end position in usual half-open [x,y) style,
not start position and length though this is clearly the same for an x
of 0

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Litmus testcase structure improvement.

[Yifan Jiang]

Hi Cor,

That would be great :) Thanks!

I commited some words (untested) here today for Litmus admin:

http://wiki.documentfoundation.org/Litmus#Litmus_for_Libreoffice_Admin_Guide

Please also let me know if something is confusing.

btw. would you do the changes in 'Master Regression TC' branches, where all
the latest test cases should be tracked:) In addition, maybe the step by step
working practice section 'Use case - Adding a new regression test case' would
be helpful:

http://wiki.documentfoundation.org/Litmus#Working_practices

Best wishes,
Yifan

On Thu, Jun 30, 2011 at 08:53:23AM +0200, Cor Nouws wrote:
> Yifan Jiang wrote (30-06-11 06:44)
>> Hi Sophie / all,
>> [...]
>
> (just to let you know that I see the mails etc, and hope to be able to pick 
> up the next days - if not, it will be somewhere next week ..)
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
  Yifan Jiang
  Libreoffice
  Contact: yifan - irc.freenode.net/libreoffice
  =  
  http://www.libreoffice.org/
  http://www.documentfoundation.org/

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Litmus testcase structure improvement.

[Yifan Jiang]

Hi all,

A bit update as follows:

On Wed, Jun 22, 2011 at 02:41:57PM +0800, Yifan Jiang wrote:
> TODO List I could think:
> 
> 1. Litmus issue of test case manager access control (Thanks for Rimas is
> working on that)
> 
> 2. We need to find some place to store test samples attachment of test
> cases (Need help, didn't follow up yet, maybe in git testing repo)?

Thanks for petr's help, we can upload test cases to our git repo now:

http://cgit.freedesktop.org/libreoffice/contrib/test-files/tree

I'll follow up details later on. Any questions, feel free to ping.

If you have any test samples for Litmus test cases to be upload and do not
know how to handle it, please send it to me at this moment. Please make sure
to tell which test cases are covered by the test samples.

> 4. Update wiki

I updated several sections for admin stuff:

http://wiki.documentfoundation.org/Litmus

It would be appreciated if you can have a review to see how clear it is. We
may need more practical use cases:

http://wiki.documentfoundation.org/Litmus#Step_by_Step_Working_practices

Best regards,
Yifan
-- 
  Yifan Jiang
  Libreoffice
  Contact: yifan - irc.freenode.net/libreoffice
  =  
  http://www.libreoffice.org/
  http://www.documentfoundation.org/

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED][REVIEW] avoid overwriting stack

[Caolán McNamara]

On Thu, 2011-06-30 at 10:53 +0200, David Tardon wrote:
> Hi all,
> 
> could someone review commit 01096e7487d9e60fcd24eea8131b650588845f2b in
> libs-core for 3.4?

pushed, despite your fancy-pants bool operator. Was some trivial
conflicts, but looks good.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] RTF support

[tracey002]

How can I obtain this exporter (direct web link)?
I look at the developer pages, but reading the words and understanding 
the meaning are 2 separate issues.
Just FYI, RTF allows customization as long  as they formatted so a 
reader that opens the document: 1) Does not crash. 2) retains 
block/group intact when it saves the document.
Thanks, Tracey
Miklos Vajna [via Document Foundation Mail Archive] wrote:
> On Wed, Jun 29, 2011 at 02:53:28PM -0700, tracey002 <[hidden email] 
> > wrote:
> > I parsed a Libre Office RTF document and found a  number of RTF 
> controls
> > that are not in the Microsoft RTF Specification.
> > Is there a list of non-Microsoft RTF controls used by Libre Office?
>
> I don't know about any specification for that, sorry - we all inherited
> those from OOo.
>
> From memory, those are:
>
> - pgdsctbl group: for page styles
> - updnprop group: for sub/superscript
> - hyphen group: for detailed hyphenation properties
>
> If you can write a script that extracts keywords from the exporter and
> looks them up in the spec, finally lists the custom ones in the wiki,
> that would be great. Otherwise I'll probably do it some day.
>
> ___
> LibreOffice mailing list
> [hidden email] 
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
> *attachment0* (205 bytes) Download Attachment 
> 
>
>
> 
> If you reply to this email, your message will be added to the 
> discussion below:
> http://nabble.documentfoundation.org/RTF-support-tp3114982p3124847.html
> To unsubscribe from RTF support, click here 
> .
>  
>
> 
>
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com 
> Version: 9.0.901 / Virus Database: 271.1.1/3734 - Release Date: 06/29/11 
> 13:34:00
>
>   


No virus found in this outgoing message.
Checked by AVG - www.avg.com
Version: 9.0.901 / Virus Database: 271.1.1/3734 - Release Date: 06/29/11 
13:34:00


--
View this message in context: 
http://nabble.documentfoundation.org/RTF-support-tp3114982p3125414.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

[Lubos Lunak]

On Thursday 30 of June 2011, Caolán McNamara wrote:
> I've added a "remove" method to the O[U]StringBuffers to make it easy to
> remove text from them without painful assembly of a new one by copying
> segments out of an old one.
>
> These StringBuffers were originally modelled after the Java equivalents.
> Since the sal ones were written Java added "delete" methods to their
> string buffers but delete is a reserved c++ keyword, so I called them
> "remove" here.
>
> It takes start position and end position in usual half-open [x,y) style,
> not start position and length though this is clearly the same for an x
> of 0

 Usual style in what way? O[U]StringBuffer don't have any other range 
function, but O[U]String uses start+len for such cases (copy, replaceAt), so 
this seems inconsistent.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Hackfest agenda and participants

[Florian Effenberger]

Hello everyone,

I've started planning some details on the hackfest in September, but as
I am no developer, I need your feedback. ;-)

I would like to compile an agenda of what we plan to do at
http://wiki.documentfoundation.org/Hackfest2011#Agenda and ask you to
provide feedback your favorite topics.

In addition, I'd like to also invite you to add your name to the list of
participants at
http://wiki.documentfoundation.org/Hackfest2011#Participants so we can
take care of the logistics.

So much for the moment,
happy hacking,
Florian

-- 
Florian Effenberger 
Steering Committee and Founding Member of The Document Foundation
Tel: +49 8341 99660880 | Mobile: +49 151 14424108
Skype: floeff | Twitter/Identi.ca: @floeff
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] version to use for dailies/nightlies bug reports

[Petr Mladek]

Rainer Bielefeld píše v St 29. 06. 2011 v 11:54 +0200:
> Petr Mladek schrieb:
> 
> > I suggest "LibO 3.4 Daily", LibO 3.5 Daily", ...
> > The daily builds from master should already use the 3.5 version
> 
> Sounds like a good solution, although I would prefer the variation
> "LibO 3.4 Daily" for release related builds
> "Libo Master" for Builds from Master

Do testers and normal people know what master means? ;-)


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

[Caolán McNamara]

On Thu, 2011-06-30 at 13:46 +0200, Lubos Lunak wrote:
> > It takes start position and end position in usual half-open [x,y) style,
> > not start position and length though this is clearly the same for an x
> > of 0
> 
>  Usual style in what way? 

Well, usual in the "if you're going to use start and end position in the
first place" way, i.e. not [x,y].

> O[U]StringBuffer don't have any other range 
> function, but O[U]String uses start+len for such cases (copy, replaceAt), so 
> this seems inconsistent.

hmm, yeah, that's true. java doesn't have a replaceAt sort of thing, nor
a "copy" method, though its ctors have a startindex +  length option
while it has a "substring" which does take [startindex, endindex)

Do we have a preference ?, I'm easy either way.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Litmus testcase structure improvement.

[Olivier Hallot]

+1
Busy in a big show here...
Kind regards
Olivier

Em 30-06-2011 03:53, Cor Nouws escreveu:

Yifan Jiang wrote (30-06-11 06:44)

Hi Sophie / all,
[...]


(just to let you know that I see the mails etc, and hope to be able to 
pick up the next days - if not, it will be somewhere next week ..)





--
Olivier Hallot
Founder, Steering Commitee Member - The Document Foundation
Voicing the enterprise needs
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [SOLVED] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG

[Nigel Hawkins]

On Wed, 2011-06-29 at 23:26 +0200, Julien Nabet wrote:
> diff --git a/sal/qa/osl/process/osl_process.cxx 
> b/sal/qa/osl/process/osl_process.cxx
> index 2535c4c..8695d79 100644
> --- a/sal/qa/osl/process/osl_process.cxx
> +++ b/sal/qa/osl/process/osl_process.cxx
> @@ -477,6 +477,7 @@ public:
>   );
> 
>   std::string line;
> +   line.reserve(1);
>   while (std::getline(file, line, '\0'))
>   env_container->push_back(line);
>   tidy_container(*env_container);

That change fixes the problem here.

Nigel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] fdo#38457: Crash in DataPilot on moving the fields

[Katarina Machalkova]

Hey guyzz,

> I don't have an environment here where I can verify this, but somehow
> this fix makes me a bit nervous.
> 
> The last time I checked, in the old code bForFile could still be true.

Nope, it's never set to true anymore (checked very recent 3.3.1 sources). And 
afaict (after doing some intensive code archaeology), it's been like that for 
~7 years now.

>  I also assumed that it was always false and removed the if statement,
> but that caused a crasher bug (because it could be true sometimes).

Commit 523a8f41388f6d looked like this: 

-SCCOL nColAdd = 0;
-if ( bForFile )
-{
-// in old file format, columns are within document, not within source 
range
-
-DBG_ASSERT( pSheetDesc, "FillOldParam: bForFile, !pSheetDesc" );
-nColAdd = pSheetDesc->GetSourceRange().aStart.Col();
-}
+SCCOL nColAdd = pSheetDesc->GetSourceRange().aStart.Col();

ie. it removed 'if' statement and replaced it with unconditional querying the 
sheet description. The crasher you mention was then caused by the fact that 
pSheetDesc can be NULL sometimes, more specifically when external db is used  
(commit 45f9a8b3e2f1f4c fixes that)

> Have you guys checked a scenario where the source data range begins
> with a column other than Column A?  That's when the nSrcColOffset can
> become non-zero, and setting it to always zero *might* break it
> especially for that scenario.  

I'm not really sure if I get the point here, but I guess this doc from test 
files repo: http://cgit.freedesktop.org/libreoffice/contrib/test-
files/tree/calc/data-pilot/referenced-field-custom-name.ods
is an example of such scenario. Test data range begins at sheet1, row3, col2. 
It used to crash on field move before, doesn't crash anymore now.

B.
-- 
  \  Katarina Machalkova
  \\\__o  LibO developer
__\\\'/_  & hedgehog painter


signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA

[vikt...@gmail.com]

On 06/30/2011 10:27 AM, Tor Lillqvist wrote:
>> For example, is it possible to build just the module that is causing a
>> problem with the debug flags set, and replace just
>> that .dll in LibreOffice, rather than building the whole source?
>> 
> You also need to build the modules that it depends on. Depending on how high 
> in the dependency hierarchy the module you are interested in is located, that 
> might be a large or small part of the code.
>
>   
OK - I have tried - but I cannot seems to figure how to build single
modules - could anyone give me a pointer on that?

I need to build the URE dll's - particularly urp_uno.dll as I think
that's where the issue seems to be happening.

TIA


Vik
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] version to use for dailies/nightlies bug reports

[Thorsten Behrens]

Petr Mladek wrote:
> Do testers and normal people know what master means? ;-)
> 
I don't know - any other naming suggestion? ;)

Cheers,

-- Thorsten


pgpeYtnO1pt51.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] [PUSHED] patch for fdo#36963: name box always select cell on first sheet

[Katarina Machalkova]

> Hello,
> 
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=58d6a7a6acd32dbf6e5
> 8a0b2cce32080e808ed4e
> 
> this patch fixes the issue that if you type a range in the name box the
> corresponding range in the first sheet gets selected. I initialized the
> range with current table number as a fallback for the parser if no table is
> specified.
> The parser already expected the current position as input but we did not
> initialize it correctly.

Makes lotta sense, signed-off & pushed

B.
-- 
  \  Katarina Machalkova
  \\\__o  LibO developer
__\\\'/_  & hedgehog painter


signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace List with std::vector

[Radek Doulik]

Hi Joseph,

On Thu, 2011-06-23 at 20:41 -0700, Joseph Powers wrote:
> Ok, this patch compiles fine; however, I can't find where it's used.
> Also, I think it's unused; it looks a lot like leftovers of when
> OpenOffice had a web browser. If some can verify, that it's trash, a
> few pointers in to how to remove it would be nice.
> 
> It looks like libs-gui/uui/source/services.cxx registers the component
> and sets up the factory for generating the dialogs. Because it's a
> component system, I'm not sure how to unplug it and/or verify how it
> would be used.

the code looks dead to me as well, but I am also not sure. It was
imported in 2000 and no real changes were done to it later - I mean the
cookiedlg.cxx. You might try to find out places where the component is
instantiated and check whether cookie dialog is still used. I tried
quickly to look it up and found few .java sources, but it will need
closer look I am afraid.

I am Cc-ing Thorsten, maybe he knows more about history of that part.

Looking at your patch I wonder if you should delete pCookies at the end
of _handleCookiesRequest method. It is created in this part:

> @@ -84,7 +72,7 @@ handleCookiesRequest_(
>  rContinuations)
>  SAL_THROW((uno::RuntimeException))
>  {
> -CookieList aCookies;
> +CntHTTPCookieList_impl* pCookies = new CntHTTPCookieList_impl();
>  for (sal_Int32 i = 0; i < rRequest.Cookies.getLength(); ++i)
>  {
>  try

Cheers
Radek


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

[Katarina Machalkova]

> Hi,
> 
> this is a patch to fix fdo#30800.

I'm taking this one for review ... 
Stay tuned :)

B.
-- 
  \  Katarina Machalkova
  \\\__o  LibO developer
__\\\'/_  & hedgehog painter


signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Litmus testcase structure improvement.

[Sophie Gautier]

Hi Yifan,

On Thu, Jun 30, 2011 at 2:05 PM, Yifan Jiang  wrote:
> Hi all,
>
> A bit update as follows:
>
> On Wed, Jun 22, 2011 at 02:41:57PM +0800, Yifan Jiang wrote:
>> TODO List I could think:
>>
>>     1. Litmus issue of test case manager access control (Thanks for Rimas is
>>     working on that)
>>
>>     2. We need to find some place to store test samples attachment of test
>>     cases (Need help, didn't follow up yet, maybe in git testing repo)?
>
> Thanks for petr's help, we can upload test cases to our git repo now:
>
> http://cgit.freedesktop.org/libreoffice/contrib/test-files/tree
>
> I'll follow up details later on. Any questions, feel free to ping.
>
> If you have any test samples for Litmus test cases to be upload and do not
> know how to handle it, please send it to me at this moment. Please make sure
> to tell which test cases are covered by the test samples.
>
>>     4. Update wiki
>
> I updated several sections for admin stuff:
>
> http://wiki.documentfoundation.org/Litmus
>
> It would be appreciated if you can have a review to see how clear it is. We
> may need more practical use cases:
>
> http://wiki.documentfoundation.org/Litmus#Step_by_Step_Working_practices

Ok, thanks a lot for the updates and taking care of this. I'll review
it later today.

Kind regards
Sophie

-- 
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

[Radek Doulik]

Hi Albert,

I think it would be best if Kohei can review your patch. He is on
vacation right know and should be back in the end of next week.

I am Ccing him so that it is not lost. Thanks a lot for your patch!

Cheers
Radek

On Sat, 2011-06-25 at 23:44 +0200, Albert Thuswaldner wrote:
> Hi
> Submitting a patch for review. This one moves the misplaced
> Compatibility options from ScDocOptions to ScAppOptions. Please let me
> know if you want me to improve some parts of it.
> 
> The rational behind this move, see:
> http://lists.freedesktop.org/archives/libreoffice/2011-May/013087.html
> 
> See also:
> http://lists.freedesktop.org/archives/libreoffice/2011-June/thread.html#14140
> 
> Once you are happy with it you can commit the patch under the terms of
> MPL 1.1 / GPLv3+ / LGPLv3+ triple license.
> 
> Then I will do the same for the formula options.
> 
> /Albert
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fw: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and Solaris X86

[Karl Behler]

So you convinced me to give it a trial, but it fails after a few minutes.

First trial from git .
**
What I did so far:

made ~/.../LibreOffice/3331 for my project

cd ~/.../LibreOffice/3331
mkdir startfromgit
cd startfromgit/
git clone git://anongit.freedesktop.org/libreoffice/bootstrap
cd bootstrap/
./autogen.sh --prefix=/opt --with-distro=Solaris --with-max-jobs=3 
--with-num-cpus=2


Can't find distro option set: distro-configs/Solaris.conf
This is not necessarily a problem.
Distros with distro option sets are:
LibreOfficeAndroid
LibreOfficeDragonFly
LibreOfficeLinux
LibreOfficeMacOSX
LibreOfficeOpenBSD
LibreOfficeWin32
LibreOfficeWin64
LibreOfficeiOS
OxygenOfficeLinux
OxygenOfficeWin32
running ./configure with '--prefix=/opt' '--with-max-jobs=3' 
'--with-num-cpus=2'


*
*   Running LibreOffice build configuration.
*


checking build system type... i386-pc-solaris2.10
checking host system type... i386-pc-solaris2.10
checking target system type... i386-pc-solaris2.10
checking for grep that handles long lines and -e... /usr/gnu/bin/grep
checking for egrep... /usr/gnu/bin/grep -E
checking for gawk... gawk
checking for gawk... /usr/gnu/bin/gawk
checking for sed... /bin/sed
checking for bash... /bin/bash
checking for GNU or BSD tar... gtar
checking for gtar... /usr/gnu/bin/gtar
checking the Solaris operating system release... ok (10)
checking the processor type... ok (i386)
checking gcc home... /usr/gnu
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for gcc... /usr/gnu/bin/gcc
checking the GNU C compiler version... checked (gcc 4.5.1)
checking gcc linker... configure: error: failed (not GNU ld). Use GNU ld 
instead of Sun ld on Solaris

2.63user 0.82sys 0:06.86 50.4%

So why is gld not found? (see below!)

Looking for gcc and gld on my system shows both are available but in 
different locations. (In fact I would prefer to build with Solaris 
Compilers and Solaris tools.)


19) where gcc
/usr/gnu/bin/gcc
20) gcc --version
gcc (GCC) 4.5.1
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is 
NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR 
PURPOSE.


21) where gld
/opt/csw/bin/gld
22) gld --version
GNU ld (GNU Binutils) 2.20.1.20100303
Copyright 2009 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later 
version.

This program has absolutely no warranty.

Following files have been created by autogen up to the error.
I include config.log for your information.

-rw-r--r--   1 kcb  e2dv   0 Jun 30 13:19 ChangeLog
-rw-r--r--   1 kcb  e2dv   14807 Jun 30 13:19 aclocal.m4
-rwxr-xr-x   1 kcb  e2dv  920381 Jun 30 13:19 configure*
-rw-r--r--   1 kcb  e2dv  72 Jun 30 13:19 autogen.lastrun
drwxr-xr-x   2 kcb  e2dv2048 Jun 30 13:19 autom4te.cache/
-rw-r--r--   1 kcb  e2dv   0 Jun 30 13:19 warn
-rw-r--r--   1 kcb  e2dv  50 Jun 30 13:19 config.parms
-rw-r--r--   1 kcb  e2dv   20820 Jun 30 13:19 config.log

So this built failed already in configure...
**

Next trial from tar ball ..
**
The next approach was from the tarball libreoffice-build-3.3.3.1.
After unpacking and untar I'm ending with a directory.

cd libreoffice-build-3.3.3.1/

There I did:

23  10:58   ./autogen.sh --with-num-cpus=2
24  11:00   vi autogen.sh
25  11:01   ./autogen.sh --clean
26  11:01   ./autogen.sh --help
27  11:04   ./autogen.sh --help | lp
28  11:12   ./autogen.sh --prefix=/opt --with-distro=Solaris 
--with-max-jobs=3 --with-num-cpus=2


This ends telling me how to go on:


Building LibreOffice
source: libreoffice-3.3.3.1
apply rules:
/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1/patches/dev300/apply
build dir:  
/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1/build/libreoffice-3.3.3.1
tools dir:  
/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1
src package dir:
/afs/ipp/home/k/

Re: [Libreoffice] extra testing needed for 3.4.2 Linux fullscreen slideshow

[Sophie Gautier]

Hi Thorsten,
On Thu, Jun 30, 2011 at 10:47 AM, Thorsten Behrens
 wrote:
> Sophie Gautier wrote:
>> Thanks! just write it on this thread, I'll upload and format it on Litmus.
>>
> Ok -
>
> this affects Linux only. What we'd need is people testing 3.4.2 on
> multi-monitor setups, on as many window managers / desktop
> environments flavours and versions as possible (the former - compiz,
> metacity and kwin at least - the latter: gnome, kde, xfce, lxde,
> preferrably)
>
> Steps to perform:
>  * install 3.4.2 and 3.4.1, perform the steps below with both
>   version - we're only interested in differences
>  * make sure Presenter Screen extension is installed
>  * start with a single monitor
>   * start slideshow - does the fullscreen window cover the whole
>     screen, is it in front of all panels, task bars etc?
>   * exit slideshow, change screen resolution
>   * repeat step 1
>  * keep Impress running, enable 2nd screen
>   * perform same steps as the subitems above - this time, the
>     presenter screen has to be on one monitor, the actual slideshow
>     on the other
>   * go to Slideshow->Slideshow Settings. Play with the multiple
>     display settings there. Specifically, does the "show on both"
>     option work?

Thanks a lot!  I upload it to Litmus.

Kind regards
Sophie
-- 
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Minutes of the tech. steering call

[Jan Holesovsky]

Present: Norbert, Rainer, David, Kendy, Thorsten, Francois, Cedric,
Petr, Caolan, Matus

* Action Items:

+ Easy Hacks - completion / fixing (Bjoern)
+ get SmartArt into master as an experimental feature (Thorsten)
* implement vertical text with Cairo (Caolan)
+ review Norbert's updated C app (Kendy, Tor)
+ manual for nightlies (Rainer)
* split the m5 and filename when downloading (Caolan)
* fall-back to libreoffice server when package unavailable
  (Petr)
* add daily-builds related ideas to wiki (Rainer)
* better cleanup rules on the server
* on-line updates for QA for dailies

* Finished Action Items:

+ remove old non-cairo cases (Caolan)

* linking to cairo always
* need to implement vertical text with cairo

+ contact / discuss with the documentation team to
  find owners for help bugs (Rainer)

* no longer a problem, David and Sophie will handle that

+ communicate more minimal QA requirements for each 3.3.x
  release (Petr)

* discussed with Yifan, he's investigating the
  possibilities

+ check out nightlies, and encourage others to use (Rainer)

* unique build identifier DONE
* new version picker in Bugzilla DONE
* write a manual - contacted several poeple
* Norbert suggests better cleanup rules on the server

+ review Norbert's C app ASAP (Kendy, Tor)

* Norbert has a plan B using git fast-export and
  fast-import, it reduced the time from 36hrs to
  30 minutes! :-)

* Review Action Items
* conference paper submission brainstorming (Michael)
+ http://conference.libreoffice.org/submit-your-paper/
* postponed to the next week

* misc technical / process decisions
* include an internal gmake ? (Michael)

* Norbert did a patch for debugging gmake
* Michael has a performance improvement patch
* should we have a libs-extern version?
* risk of dmake-like result
* Norbert suggests to have it, but outside of the tree,
  and tinderbox _never_ use that
* libreoffice/contrib/dev-tools?
* Petr is in favor of having it in bootstrap, disabled
  by default
* consensus: dev-tools, it should be kept separate

* string fixing in 3.4.1 branch ... (Korrawit)

* keep the string freeze, or can we fix strings if they
  are source of the problem?
* it seems that l10n people do not have a big issue with
  fixing an string when it is really occasional

* consensus: only fixing wrong, misleading strings
  allowed
* no rewording
* no fixing typos

* gettext - should we use it everywhere (Andras)

* no Bjoern - need him for the discussion
* Andras continued evaluating the patch so far
* investigating possibility to translate the binary
  resources using .po files (instead of using .mo files)
* positive: no impact on performance, nor size
* negative: depends on the .res (build
  dependency), custom tool (that parses .res,
  and saves it again)

* enable on-line updates for QA for dailies ... (Kendy)

* Rainer will add it to the daily build testing ideas
* let's shift the decision when we have more experience
  with testing dailies
* problem to identify the exact tinderbox that did the
  build

* central mirroring of source downloads ? (Michael)

* numbertext.org down, etc.
* at the moment the tarballs have to have special name
* we could split the md5 from the filename, and allow
  downloads from sourceforge, debian, etc. directly
* AI Caolan
* we should have a copy of each file that is needed
* fallback to our pages, script downloads our
  version when the original site is unavailable
* AI Petr

* library merging plan / progress (Matus)
* next week

* Releng bits (Petr)
+ 3.4.1 / 3.4.2 release status

* 3.4.1 had a regression
* most Linux users affected
* tagged RC3 on Friday
* minimal change, just disabling a patch
* first time this happened

* 3.4.2
* only following week for f

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

[Caolán McNamara]

On Wed, 2011-06-29 at 23:00 +0200, Chr. Rossmanith wrote:
> Hi,
> 
> I've started to replace ByteString with rtl::OString. You find what I 
> did so far in the attached patches. It would be nice if someone could 
> review the patches and give feedback. Then I'll continue and push.

Patch 2 is good, we can go back when finished and re-implement ReadLine
at the end in terms of rtl::OStringBuffer or whatever when the rest are
all gone.

Patch 1 has
a) various original lines of...

rtl::OUString( UniString( aRequestHost, RTL_TEXTENCODING_UTF8 ) )

we need to retain the encoding information here in the conversion from
OString to OUString

so use

rtl::OStringToOUString(aRequestHost, RTL_TEXTENCODING_UTF8)
instead of
rtl::OUString::createFromAscii(aRequestHost.getStr())
e.g.

aConnectAddr = osl::SocketAddr(rtl::OStringToOUString(aRequestHost,
RTL_TEXTENCODING_UTF8), nRequestPort);

b)
- nResultId = (sal_uInt16)aLine.GetToken( 1, ' ' ).ToInt32();
+ nResultId = (sal_uInt16)aLine.getToken( (sal_Int32)1, ' ',
nIndex ).toInt32();

which is find, but nIndex is an in-out argument in rtl::OString, and
this code is in a loop, so old code always seemed to say 

"get the second (1) token starting from default 0"
new code says
"get the second (1) token starting from nIndex, where nIndex is the
position of the last token got"

so to be the same move sal_Int32 nIndex = 0; inside the loop above
getToken

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #5. Wizards

[Xisco Faulí]

2011/6/29 Cedric Bosdonnat 

> Hi Xisco,
>
> On Wed, 2011-06-29 at 01:23 +0200, Xisco Faulí wrote:
> > Sorry for the delay but I had a visit last weekend and I wasn't able
> > to work on it until yesterday night.
> > What I've done during the week:
> > - Improve the boot speed
> > - Clean a bit the code
> > - Show a message when a file is going to be overwritten
> > - Load the previous configuration
>
> Where is your work available ATM? Could you please start merging it with
> master to get a build with all GSoc projects for midterms?


http://cgit.freedesktop.org/libreoffice/components/?h=feature/gsoc2011_wizards


>

The idea behind that isn't to have something 100% complete and working,
> but to show to the world what you've already done and get feedback.
>
> > Now i'm working on saving the configuration after the wizard is
> > finnished. I think it'll be done tomorrow.
>
> Cool, then it would be nice to have it in master!
>

Ok, i'll merge it next week.

>
> > Furthermore, I've already started to work on the letter wizard. Let's
> > see If I can already commit something by the end of the week.
>
> I would be awesome if you could improve that wizard to get something
> based on localised templates... Letters aren't formatted in the same way
> across the world and that wasn't taken into account by the old wizard.
>

Correct me if i'm wrong but as i've seen in the fax wizard,each kind of
template has its own template so I believe it's the same for the letter
templates and every localize has a different template, right ? In that case,
the templates are the ones that should be changed, right ?

Greetings

>
> --
> Cédric Bosdonnat
> LibreOffice hacker
> http://documentfoundation.org
> OOo Eclipse Integration developer
> http://cedric.bosdonnat.free.fr
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Do not use path that depend on the repo layout!!!

[Norbert Thiebaud]

http://cgit.freedesktop.org/libreoffice/writer/commit/?id=eae3537858e5c96e501ac62d43a0102386e6c295

this commit breaks the build after onegit conversion because
+
+#include "../../../../../libs-core/sfx2/inc/sfx2/childwin.hxx"
+
does not resolve to a valid location anymore.

so use:
#include 


Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] weekly report #5

[Marco]

On Thu, 30 Jun 2011 01:29:10 +0200, Thorsten Behrens  
 wrote:



Hi Marco,

first off - wonderful progress! :)


Hi Thorsten,
thanks, your appreciation rewards me of the time I spent on
this project. :)


Marco wrote:

Now, only targeted master page are exported.


Nice - since people tend to store whole picture galleries there,
this goes a long way avoiding bloat. I like your attention to
detail.


Yep, I completely agree on avoiding bloat.

skip


A slide index based on slide thumbnails has been implemented.
At present I tested it on Firefox 4.x and Chrome 12.x
To toggle between presentation mode and slide index mode you have to
press down the "i" key.


This is just *lovely* !


You can increase/decrease the number of thumbnails per index page
by pressing down the "+" and the "-" key. You can reset the number
of displayed thumbnail per index page by pressing down the "0" key.


So is this! :)


I'm happy to hear that!
I performed some test on more browsers, there was some issues with
IE9 and Safary, but I should have solved them.
Increasing and decreasing the thumbnail grid size looks a bit heavy
on Firefox I'll try to optimize it. Then I want to polish the code.



Looking at the patches in detail, I've committed
0001-svg-export-filter-added-support-for-browsing-filters.patch to
master, but am still holding off for the rest.
0002-Add-support-for-exporting-any-subset-of-slid-filters.patch
needs some cleanup, and I'd like to keep the default of exporting
all slides for the while (with the slide sorter selection code as an
extra patch maybe).
0003-Adding-support-for-exporting-meta-informatio-filters.patch
changes indentation from 0002-*, that should be consolidated (but
see above). 0004-Some-small-improvement-and-bug-fix-filters.patch is
good, but needs removal of those todo/#if 0 code - best split that
into multiple patches, too. Finally, I'd have taken
0005-Implemented-a-slide-index.-Supported-browser-filters.patch
as-is, but it depends on the previous patches.


Ok I'll remove the #if 0. I keep them because I find that the code inside
them could be useful at a later moment, or simply because it includes
some initial implementation as for the left slide pane thumbnail selection,
or the custom background per slide feature.



One thing to note for 0003-* - if there's any js code from JessyInk,
we'd need to retain their copyright notice (GPLv3+). Apart from
that, it would be good to add copyright headers to the js anyway (if
it's from you entirely, LGPLv3+/MPL is perfect, otherwise it's
LGPLv3 currently).


The source code is from me or JessyInk so I'll add a GPLv3+ copyright
header.

I published a log book of the last week here:
https://docs.google.com/document/d/12pIrnHkqcUu9xUbI7qblTofx1P-A4gP6J-4D2oEvphE/edit?hl=en_US&authkey=CPmx59wF


Cheers,
   Marco

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Litmus testcase structure improvement.

[Sophie Gautier]

Hi Yifan,
On 30/06/2011 14:05, Yifan Jiang wrote:

Hi all,

A bit update as follows:

On Wed, Jun 22, 2011 at 02:41:57PM +0800, Yifan Jiang wrote:

TODO List I could think:

 1. Litmus issue of test case manager access control (Thanks for Rimas is
 working on that)

 2. We need to find some place to store test samples attachment of test
 cases (Need help, didn't follow up yet, maybe in git testing repo)?


Thanks for petr's help, we can upload test cases to our git repo now:

http://cgit.freedesktop.org/libreoffice/contrib/test-files/tree

I'll follow up details later on. Any questions, feel free to ping.


oh I forgot in my other, it's great, thanks a lot to Petr :)


If you have any test samples for Litmus test cases to be upload and do not
know how to handle it, please send it to me at this moment. Please make sure
to tell which test cases are covered by the test samples.


 4. Update wiki


I updated several sections for admin stuff:

http://wiki.documentfoundation.org/Litmus

It would be appreciated if you can have a review to see how clear it is. We
may need more practical use cases:


For me it's ok, but I didn't follow the steps, only used my memory. 
Thanks a lot for your work!
May be Cor or Oliver, you can follow the step by step to make sure that 
nothing in missing in the steps.


http://wiki.documentfoundation.org/Litmus#Step_by_Step_Working_practices


I'll add a translation part tomorrow for those who only want to make the 
translation and no admin work.


Kind regards
Sophie

--
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace List with std::vector

[Thorsten Behrens]

Radek Doulík wrote:
> > It looks like libs-gui/uui/source/services.cxx registers the component
> > and sets up the factory for generating the dialogs. Because it's a
> > component system, I'm not sure how to unplug it and/or verify how it
> > would be used.
> 
> the code looks dead to me as well, but I am also not sure. It was
> imported in 2000 and no real changes were done to it later - I mean the
> cookiedlg.cxx.
>
Yep, unused - for those, just follow the implementation backwards.
CookiesDialog only gets inst'ed in iahndl-cookies.cxx's
executeCookieDialog(), which turn is only called in
handleCookiesRequest_(), which only gets called from
UUIInteractionHelper::handleCookiesRequest() - and there, only if
the request has a ucb::HandleCookiesRequest set.

The catch is - this code is part of the published API (look at
offapi/com/sun/star/ucb/HandleCookiesRequest.idl), so strictly
speaking, there may be extensions out there using it (though I doubt
it, for this case).

Tracking down the other cases should work in an equivalent way -
sometimes one is not so lucky as to find a specific type (like
HandleCookiesRequest) to look for - the one needs to search for the
service string names.

Cheers,

-- Thorsten


pgpM31sJ2gPPp.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #5. Wizards

[Michael Meeks]

Hi Xisco,

On Thu, 2011-06-30 at 18:28 +0200, Xisco Faulí wrote:
> Correct me if i'm wrong but as i've seen in the fax wizard,each kind
> of template has its own template so I believe it's the same for the
> letter templates and every localize has a different template, right ?

Um ;-) in theory yes, but in reality no - having a duplicated ODF file
for each and every translation (duplicating all the XML, all embedded
images etc. etc.) bloated our install sets to some huge size for no good
reason :-)

>  In that case, the templates are the ones that should be changed,
> right ?

Weelll - so you're both right; but really we need to grub about inside
the templates themselves to add some improved translation scheme I
think; now we have fast native XSLTs - I guess we could use the native
XSLT filters to allow the templates to be self-standing, and yet adapt
to the locale nicely.

But - your task is primarily the Java -> python conversion I guess :-)

All the best,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fw: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and Solaris X86

[Thorsten Behrens]

Karl Behler wrote:
> [snip]
>
> This lasts a while, but then comes up with an error "`(' unexpected"
> 
> >No file 
> >/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1/src/biblio.tar.bz2
> >Get http://download.go-oo.org//SRC680/biblio.tar.bz2 -> 
> >/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1/src/
> >--2011-06-30 12:49:34--  http://download.go-oo.org//SRC680/biblio.tar.bz2
> >Resolving download.go-oo.org... 195.135.221.70
> >Connecting to download.go-oo.org|195.135.221.70|:80... connected.
> >HTTP request sent, awaiting response... 200 OK
> >Length: 6000 (5.9K) [application/x-bzip]
> >Saving to: `biblio.tar.bz2'
> >
> >100%[==>] 6,000   --.-K/s   in 0s
> >
> >2011-06-30 12:49:34 (264 MB/s) - `biblio.tar.bz2' saved [6000/6000]
> >
> >./download_external_sources.sh: syntax error at line 184: `(' unexpected
> >Done
> >268.64user 115.56sys 1:33:25.94 6.8%
> 
That's line 184 in bin/setup.in instead (that files gets sourced),
and apparently your shell does not like the command substitution
there. Can you try another shebang shell atop
./download_external_sources.sh, or use backticks there instead?

Cheers,

-- Thorsten


pgpkvizJod3BP.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] syntax error in ./configure

[Martijn van Duren]

Michael Meeks  writes:

> 
> 
> On Mon, 2011-05-30 at 13:09 +0200, Regina Henschel wrote:
> > Unfortunately not. I have no knowledge in Perl.
> 
>   Heh - I committed something to autogen.sh that (hopefully) will make
> this at least a tad more intuitive (while no doubt breaking a number of
> platforms .
> 
>   Thanks !
> 
>   Michael.
> 


Hello Michael,

I'm tinkering around, just to see how far I'm getting at the Haiku platform.
Although I have pkg-config installed I get the same error. 
On Haiku the pkg.m4 is located at /boot/common/share/aclocal/pkg.m4.
Do I need to point to that file from anywhere in the source tree?

Sincerely,

Martijn van Duren

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Do not use path that depend on the repo layout!!!

[Thorsten Behrens]

Norbert Thiebaud wrote:
> this commit breaks the build after onegit conversion because
> +
> +#include "../../../../../libs-core/sfx2/inc/sfx2/childwin.hxx"
> +
> does not resolve to a valid location anymore.
> 
> so use:
> #include 
> 
Affirmative. Please never use path names that lead outside your
module.

-- Thorsten


pgpD6DNf7ubh9.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] One Git v2.0

[Norbert Thiebaud]

0. Introduction
===

The fist incarnation of onegit.sh, despite all the tuning effort, was
still taking 36 hours to run. That was within the 'we should be able
to do the conversion over a week-end' criteria, but it was still
painfully long.

So, plan B, I tried to use git fast-export/import instead of git
filter-branch. That plan proved successful and now the conversion
itself takes about 30 _minutes_ (add another 15 for a final git gc of
the resulting core.git and a couple of hours to upload it all)

The core of plan B is lo_git_rewrite, a small C program that massage
the data stream between git fast-export and git-fast-import. It is
available in the dev-tools git repo.

1. Usage Notes


If you want to try it for yourself, here are few things to know:

1.1 Pre-requisites

1.1.1 Platform
This has only been tested on Linux. Other platform may work, but use
at your own risk.

1.1.2 Git
This has been tested with git 1.7.3.4. Any recent git should work, but
lo_git_rewrite makes a lot of implicit assumptions about the data
stream provided by git fast-export, so any version of git that alter
that flow, even in a way compatible with git fast-import
specifications may cause trouble.

1.1.3 source git repos
You need to have a 'source' bootstrap tree, including
clone/translation. make sure that master is checked-out and that you
are up-to-date and clean.

1.1.4 dev-tools
You need to clone the contrib/dev-tools repo and run make in
dev-tools/lo_git_rewrite

1.1.5 temp space
Most of the work is done in a temporary directory. you need 5+GB of
space there (I don't know for sure the exact amount but 5GB should be
enough)

1.1.6 target repos
The ongit.sh script will create a target repository, with clone/*
populated with the remaining separate git repos (help, translation,s,
dictionaries and binfilter).
The core repo is initially not properly compacted, and since you
porbably want to build it, you need enough space... as a rule of
thumb, count the same amount of space you would normally reserve for a
regular bootstrap buid.

1.2 Running

Assuming that your source bootstrap repo is at /lo/libo, that the
target will be /lo/core, that the dev-tools repo is at /lo/dev-tools
and that your temporary workspace is /fast, then run:
cd /lo
time ./dev-tools/onegit/onegit.sh -f -g /lo/libo -n core -t
/fast/gittemp 2>&1 | tee onegit.log

while it is running you can look at /lo/onegit.msgs. it contains a
high-level log of what is going on.
Note that in onegit.msgs lines should start with "===" any line that
start with "***" indicate that something went wrong.

Note: the onegit.sh has been tuned to work optimally on a Intel Xeon
X3360  @ 2.83GHz (quad-core), with 8GB of memory and pretty good
disks.
For optimal result on a different machine you may need to tweak the
number of batch that ran in // and their composition. (see section
2.2.2 for gotcha).

1.3 Known issue
The onegit.sh script, as a final step try to apply a set of patches,
to fix issue related to the migration. unfortunately, since master is
a moving target these patches may fail to apply.
At this stage the conversion is done and core is usable. you can try
to fix the patches that failed to apply (and apply the rest of the
patches)
the patches are in dev-tools/onegit/patches/*

1.4 Testing
once all the patches are applied. you can start using the 'core' repo
as if it was bootstrap.


2. Reviewer Notes
==

Reviews are of course welcomed
In order to help with the review, here are a few pointers.

2.1 Review of lo_git_rewrite

lo_git_rewrite is a fairly small C program that sit between git
fast-export and git fast-import.
Its goal to to fix the trailing spaces, tab issues and to optionally
exclude or filter-out a specific module and/or filter-out files with a
specific extension.

2.1.1 arguments

lo_git_rewrite understand to following command line argument. (note
the syntax is --foo bar and NOT --foo=bar)
all these arguments are optional

--prefix "string"
This is used to prefix output message to stderr with the specified
string. this is used in onegit.sh because more than one instance of
lo_git_rewrite is running in parallel, and this allow to link a
message to a specific lo_git_rewrite instance
the default is an empty string.

--exclude-module "module_name"
This tell lo_git_rewrite to filter-out any files whose name start with
module_name/. This is used in onegit.sh to filter-out a module from a
given repo, like binfilter or dictionaries.

--fitter-module "module_name"
This tell lo_git_rewrite to filter-out any files whose name does _not_
start with module_name/. This is used in onegit.sh to extract a given
module from an existing repo, like binfilter or dictionaries.

--exclude-suffix "string"
This tell lo_git_rewrite to exclude any files whose name end with
"string". This is used in onegit.sh to eliminated obsolete .tar.gz
file out of libs-extern-sys and libs-extern history.

--buffer-size nnn
This tell lo_git_rewrite to allocate a working bu

Re: [Libreoffice] Good hotel

[Arno Teigseth]

Thank you Egor

Are you referring to a web hotel ;)



On Wed, 2011-06-29 at 17:12 +0400, Egor Miliukov wrote:
> Hello! My name is Egor Miliukov, I visited your hotel with my family
> when we were in your town, I really liked it, see how well your team
> is working harmoniously and now I will always stay with you and will
> advise all my friends have I have a request - could send me your
> promotional materials, souvenirs with your logo, that can remind of
> your hotel.

sounds like any linux web hotel. see http://en.wikipedia.org/wiki/LAMP_%
28software_bundle%29

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Copy Header/Footer from one Writer document to another

[Grover Blue]

Does anyone have a Java example of copying header/footer contents between
documents?  I'm able to copy text, but the text format is not retained.
Additionally, images are copied, but not anchored to the page header I'm
insert them to.

Here is what I have:

fromXText = (XText) FileManager.getOOoUnoRuntimeQueryInterface(XText.class,
fromProps.getPropertyValue("FooterText"));

toXText = (XText) FileManager.getOOoUnoRuntimeQueryInterface(XText.class,
toProps.getPropertyValue("FooterText"));

if (xViewCursor != null) {
xViewCursor.gotoRange(toXText, false);
}

toXText.setString(fromXText.getString());
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Writer: Bug 36181 - EasyHack: Replace with "Notes" option doesn't work with text selected

[Benoit Dolives]

Hi,

Please find in attachment the patch for the bug 36181.

Bug:
While using "Replace" in the "Find&Replace" dialog of writer, the selected
text was always replaced even if it does not match the searched string.

Correction:
Check that the selected text is the search string, otherwise select the
first occurence if any.

This is my first contribution to LibreOffice, therefore please feel
confortable to give me advices, remarks, ...


Best Regards,

-- 
Benoit Dolives
From fb6b0340c819202ea3ffd74e47cc1ba17bba8dae Mon Sep 17 00:00:00 2001
From: Dolives Benoit 
Date: Fri, 1 Jul 2011 00:44:49 +0200
Subject: [PATCH] writer: bug correction : selected text was always replaced (bugzilla 36181)

When using "Find&Replace" dialog, the selected text was always replaced.
Correction: check that the selected text is the search string, otherwise select the first occurence if any.
---
 sw/source/ui/uiview/viewsrch.cxx |   78 -
 1 files changed, 67 insertions(+), 11 deletions(-)

diff --git a/sw/source/ui/uiview/viewsrch.cxx b/sw/source/ui/uiview/viewsrch.cxx
index b3e8d6e..488e848 100644
--- a/sw/source/ui/uiview/viewsrch.cxx
+++ b/sw/source/ui/uiview/viewsrch.cxx
@@ -589,18 +591,72 @@ void SwView::Replace()
 {
 if (GetPostItMgr()->HasActiveSidebarWin())
 GetPostItMgr()->Replace(pSrchItem);
-sal_Bool bReplaced = pWrtShell->SwEditShell::Replace( pSrchItem->GetReplaceString(),
-pSrchItem->GetRegExp());
 
-if( bReplaced && pReplList && pReplList->Count() && pWrtShell->HasSelection() )
-{
-SfxItemSet aReplSet( pWrtShell->GetAttrPool(),
-aTxtFmtCollSetRange );
-if( pReplList->Get( aReplSet ).Count() )
-{
-::SfxToSwPageDescAttr( *pWrtShell, aReplSet );
-pWrtShell->SwEditShell::SetAttr( aReplSet );
+sal_Bool bReqReplace = true;
+
+if(pWrtShell->HasSelection()){
+/* check that the selection has the same length as the required string */
+if (pWrtShell->SwCrsrShell::GetSelTxt().Len() != pSrchItem->GetSearchString().Len() ){
+//it differs, therefore do not replace the selection
+bReqReplace = false;
+//next call to replace will find the next matching string
 }
+else{
+/* check that the selection match the search string*/
+//save state
+SwPosition aStartPos = (* pWrtShell->GetSwCrsr()->Start());
+SwPosition aEndPos = (* pWrtShell->GetSwCrsr()->End());
+sal_Bool   bHasSelection = pSrchItem->GetSelection();
+sal_uInt16 nOldCmd = pSrchItem->GetCommand();
+
+//set state for checking if current selection has a match
+pSrchItem->SetCommand( SVX_SEARCHCMD_FIND );
+pSrchItem->SetSelection(true);
+
+//check if it matchs
+SwSearchOptions aOpts( pWrtShell, pSrchItem->GetBackward() );
+if( ! FUNC_Search(aOpts) ){
+
+//no matching therefore should not replace selection
+// => remove selection
+
+if(! pSrchItem->GetBackward() ){
+(* pWrtShell->GetSwCrsr()->Start()) = aStartPos;
+(* pWrtShell->GetSwCrsr()->End()) = aEndPos;
+}
+else{
+(* pWrtShell->GetSwCrsr()->Start()) = aEndPos;
+(* pWrtShell->GetSwCrsr()->End()) = aStartPos;
+}
+bReqReplace = false;
+}
+
+//set back old search state
+pSrchItem->SetCommand( nOldCmd );
+pSrchItem->SetSelection(bHasSelection);
+}
+}
+/*
+ * remove current selection
+ * otherwise it is always replaced
+ * no matter if the search string exists or not in the selection
+ * Now the selection is removed and the next matching string is selected
+ */
+
+if( bReqReplace ){
+
+sal_Bool bReplaced = pWrtShell->SwEditShell::Replace( pSrchItem->GetReplaceString(),
+  pSrchItem->GetRegExp());
+if( bReplaced && pReplList && pReplList->Count() && pWrtShell->HasSelection() )
+{
+SfxItemSet aReplSet( pWrtShell->GetAttrPool(),
+ aTxtFmtCollSetRange );
+if( pReplList->Get( aReplSet ).Count() )
+{
+::SfxToSwPageDescAttr( *pWrtShell, aReplSet );
+pWrtShell->SwEditShell::SetAttr( aReplSet );
+}
+}
 }
 }
 
-- 
1.7.0.4

_

Re: [Libreoffice] [PATCH] Replace List with std::vector

[Francois Tigeot]

On Thu, Jun 30, 2011 at 09:14:02PM +0200, Thorsten Behrens wrote:
> Radek Doulík wrote:
> > > It looks like libs-gui/uui/source/services.cxx registers the component
> > > and sets up the factory for generating the dialogs. Because it's a
> > > component system, I'm not sure how to unplug it and/or verify how it
> > > would be used.
> > 
> > the code looks dead to me as well, but I am also not sure. It was
> > imported in 2000 and no real changes were done to it later - I mean the
> > cookiedlg.cxx.
> >
> Yep, unused - for those, just follow the implementation backwards.
> CookiesDialog only gets inst'ed in iahndl-cookies.cxx's
> executeCookieDialog(), which turn is only called in
> handleCookiesRequest_(), which only gets called from
> UUIInteractionHelper::handleCookiesRequest() - and there, only if
> the request has a ucb::HandleCookiesRequest set.
> 
> The catch is - this code is part of the published API (look at
> offapi/com/sun/star/ucb/HandleCookiesRequest.idl), so strictly
> speaking, there may be extensions out there using it (though I doubt
> it, for this case).

Some related files in this directory also use OS/2-era low-level functions
and a specific implementation of file open dialogs.

So far I've not been able to find proof they are unused but the suspicion
is high.

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice