Re: [Libreoffice] Bug 41883 - MinGW port Most Annoying Bugs

2011-10-18 Thread Jan Holesovsky
Hi Rainer,

Rainer Bielefeld píše v St 19. 10. 2011 v 07:47 +0200:

> to keep Bugzilla understandable for non-developers: can someone please 
> leave a short description on
> 
> what "MinGW" is?

Done, please check if it is enough :-)

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Styles cleanup & removing option page std fonts

2011-10-18 Thread Cedric Bosdonnat
Hi Cor,

On Tue, 2011-10-18 at 18:03 +0200, Cor Nouws wrote:
> Interest caught by your presentation in Paris, I saw your patch in cgit:
>359d0fbd03a68d9131e8fb25e7dac9f19ddf6dcb
> 
> I understand the idea to remove default paragraph styles such as list, 
> list1, list1 cntd, list2 end etc etc
> But I do not understand what the link is with removing the option page 
> std fonts (Tools > Options > Writer > Basic fonts (& CTL, Asian)
> I mean, the option for List fonts indeed can be missed, but what about 
> the other 4?
> Could you pls explain?

This option page does exactly the same than changing the values in the
style directly. In a not-so-far future, I'ld like to have this all
configured through a default template instead of what we have... and
removing that option page is on the way to this goal.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-18 Thread Kristian Rietveld

On 10/18/11 11:17 PM, Stephan Bergmann wrote:

On 10/15/2011 01:25 AM, Kristian Rietveld wrote:

Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will
not complete successfully.


Btw, pushing some clang-related patches, mainly based on abandoned work
I did earlier this year. Your go at this gave me fresh enthusiasm. :)
Hope you don't mind me picking up on this.



Sounds good!  My Clang build actually completed during the final minutes 
of the conference.  I hope to find some time later this week to upload 
the remaining patches for review somewhere.


Of course, having a completed build doesn't mean it runs at the moment 
though :)  After uploading the patches I will continue debugging it.



regards,

-kris.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Bug 41883 - MinGW port Most Annoying Bugs

2011-10-18 Thread Rainer Bielefeld

Hi,

to keep Bugzilla understandable for non-developers: can someone please 
leave a short description on


what "MinGW" is?

Thank you

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Question about Possible null pointer dereference in SpellDialog.cxx (cui one)

2011-10-18 Thread Eike Rathke
Hi,

On Friday, 2011-09-16 16:29:57 -0700, julien2412 wrote:

> cppcheck detected this on core/cui/source/dialogs/SpellDialog.cxx
> 1534  nullPointer error   Possible null pointer dereference: pNewError
> 1538  nullPointer error   Possible null pointer dereference: pNewError
> 1555  nullPointer error   Possible null pointer dereference: pNewError
> 1559  nullPointer error   Possible null pointer dereference: pNewError
> 1570  nullPointer error   Possible null pointer dereference: pNewBack
> 1595  nullPointer error   Possible null pointer dereference: pNewError
> 1751  nullPointer error   Possible null pointer dereference: 
> pNewBackground
> 
> I tried to understand with the first one :
>  1530   TextAttrib* pNewError =  NULL;
> sal_uInt16 nStart = pErrorAttrLeft->GetStart();
> sal_uInt16 nEnd = pErrorAttrLeft->GetEnd();
> pTextEngine->RemoveAttrib( 0, *pErrorAttrLeft );
>   1534  SetAttrib( *pNewError, 0, nStart, ++nEnd );
> 
> [...]
> 
> I found that before the commit  d54c3ad1518e32938117c7e529dda375d4110888,
> most (all?) of these variables were initialized. For example like this :
> TextAttrib* pNewError =  pErrorAttrib->GetAttr().Clone();
> 
> I supposed there was certainly a good reason, but I don't know how can it
> works now. Of course, I wouldn't have noticed this without cppcheck report.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d54c3ad1518e32938117c7e529dda375d4110888&context=6
doesn't look correct, especially with the commit message
"callcatcher: replace Clone() by NULL" it doesn't make sense. I doubt
callcatcher placed this into unused code.

The pointer is dereferenced and the object accessed under SetAttrib().
I reverted the commit.

Thanks for catching.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Allestimenti fieristici ed organizzazione eventi - Exhibit and event organization

2011-10-18 Thread Spazio & Forme


Gentile espositore,siamo una ditta specializzata nella realizzazione e noleggio di stand,  personalizzati o pre-allestiti, in Italia e all'estero.Possiamo seguire ed occuparci di tutte le fasi operative, dalla progettazione all'allestimento come:
realizzazioni su misuragraficanoleggi (arredi, strutture a traliccio, pedane, palchi, impianti elettrici, audio e video)espletamento pratichecateringaddobbi florealimontaggio e smontaggio stand di proprietàmanutenzione e deposito
Siamo a disposizione per formularvi un preventivo gratuito o per ulteriori informazioni.
SPAZIO & FORME srl
Tel.:  02 33.10.47.36   -   Fax:  02 34.92.236
Direzione Commerciale: Cell.: 347 24.87.740
www.spazioeforme.eui...@spazioeforme.eu 
 
Kind exhibitor,We are a company specialized in production and hire of stands, customized and pre-arranged, in Italy and abroad.We can follow and take care of all phases, from design to mounting as:
custom worksgraphicsrentals (furniture, trellis structures, platforms, stages, electrical, audio and video)practical completioncateringfloralassembly and disassembly of property standmaintenance and storage
We are available to formulate a free estimate or for any information.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Mark ecx register as clobbered (in cpp_uno/gcc3_macosx_intel)

2011-10-18 Thread Stephan Bergmann

On 10/15/2011 01:25 AM, Kristian Rietveld wrote:

Without this patch, Cpp bridgetest on a Clang-compiled UNO runtime will
not complete successfully.


Btw, pushing some clang-related patches, mainly based on abandoned work 
I did earlier this year.  Your go at this gave me fresh enthusiasm.  :) 
 Hope you don't mind me picking up on this.


-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Writer : XSLT 2.0 Filters KO in LibreOffice 3.4.3 but OK in 3.3.4

2011-10-18 Thread Peter Jentsch

Hi Arnaud,

Am 04.10.2011 17:11, schrieb arnaud.mal...@arkarell.com:


Hi Michael,

Hi Peter,

Thanks for your answers.

I tried to put the implementation name in the  node as specified 
by Peter, but it doesn't work, my package is not loaded when I put 
"com.sun.star.comp.JAXTHelper" at that place which must contains in 
fact the name of my filter (if I understand well). When reading code 
of XSLTFilter.cxx, I saw that the name of the specific implementation 
is retrieved in msUserData[1] and that stylesheet is retrieved in 
msUserData[5], it's why I assume that each msUserData corresponds to 
the sequence of value in the data node, values separated by semi-colon 
because stylesheet is the sixth entry in this string (ok to 
msUserData[5] found in code).   And also beacuse the second entry is 
empty and a comment in code tell that we use this not used user data 
for specific implementation.


Michael, If I understand you, you tell that XSLT 2 support must be 
redone. But I think that this support is still here, we only have to 
find where to set the java implementation to override the default 
libxslt. Do you confirm Pete ?


Thanks Pete, to have a look on this.


I just pushed 2 commits to LO master that fix the problem you encountered.

The configuration of the custom XML filter packages works a little 
different compared to the built-in filters. The 2nd userdata parameter 
currently is just ignored upon importing a package.


The first patch supports importing (but not exporting) the 2nd userdata 
parameter, so you can use the saxon/j based xslt 2.0 aware 
transformation in your filter (but still requires manually editing 
TypeDetection.xcu).


http://cgit.freedesktop.org/libreoffice/core/commit/?id=960f4bdd71c9de19059279d61abb142ddfdac0ce

The second patch adds a simple entry field that lets you edit the 
transformation service that should be used with your filter. If you 
leave it blank, the built-in service (currently libxslt) will be used, 
but you're free to enter any service, like the 
com.sun.star.comp.JAXTHelper thing that uses to saxon9/j internally.


http://cgit.freedesktop.org/libreoffice/core/commit/?id=11fbde8fed1a866c4ec9565d56f5f5034631d8b2

The ui is really the simplest thing that could possibly work, and it 
doesn't do any input validation or whatever, but at least it's there.


If anyone could tell my how to include a simple help snippet for that 
input fields I'd gratefully write a line or two.


If you're in a hurry those patches should apply cleanly to a checkout of 
the 3.4.3 release branch, otherwise they hopefully make it into one of 
the upcoming releases.


Cheers,

Peter


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW] patch for fdo38286 EDITING: Crash when inserting a constant in a query

2011-10-18 Thread julien2412
Could someone give his/her opinion about this very small patch on dbaccess
part ? The goal is to avoid a crash described on the tracker.
Now I don't know if the getChild(0) should be completely removed but, since
I'm not an expert, I prefer to let it.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-patch-for-fdo38286-EDITING-Crash-when-inserting-a-constant-in-a-query-tp3424026p3432390.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] build error in tail_build

2011-10-18 Thread Michael Meeks

On Tue, 2011-10-18 at 08:43 -0700, night striker wrote:
> Ok, I removed all mentions of adabasui from  dbaccess/Module_dbaccess.mk  and
> from  scp2  and I am no longer getting the first error, but I still get

Hokay :-) sounds good, I suppose we should remove the code they mention
as well, and get a patch to the list (?).

> collect2: ld returned 1 exit status
> make: *** [[...]/workdir/unxlngx6.pro/LinkTarget/Library/libsdbtlo.so] Error
..
> Should I find and remove mentions of sdbt as well, or should that be built?

That sounds like a similar problem in a different form I guess. Is it
possible you have a partial build of some library installed ? can you
give more detail on the actual link error, and the configure flags you
used ?

Thanks :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [REVIEWED] backport NSS build fixes for 3.4

2011-10-18 Thread Michael Meeks
Hi Michael,

On Tue, 2011-10-18 at 17:55 +0200, Michael Stahl wrote:
> i need the following commits to build nss and moz on a linux 3.1 kernel:
..
> please somebody tell me that's ok for 3.4.

Both look fine to me; ideally I'd have time to sign them off and commit
them myself for you :-) [ particularly since they need extracting, and
re-checking into the old repositories ].

> i should add a line Signed-off-by: $REVIEWER to the commit, right?

It'd be wonderful if you could do that :-) good stuff.

Thanks,

Michale.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] String::CompareIngoreCaseToAscii

2011-10-18 Thread August Sodora
Thanks Markus!

I've attached a new patch that includes some tests for the BASIC
scanner. Most of the test cases are just to get an idea of how the
scanner handles certain situations but I tried to make sure I included
ones that specifically trigger where the GetBufferAccess was.

August Sodora
aug...@gmail.com
(201) 280-8138



On Mon, Oct 17, 2011 at 2:23 PM, Markus Mohrhard
 wrote:
> Hello August,
>
> as promised on IRC this patch resolves all linking problems.
>
> If you have any more problems feel free to ask here or on IRC.
>
> Thanks a lot for your work.
>
> Markus
>
From ee07bfa53dde6aa5d44fdafe6bc4755fdc8d08f3 Mon Sep 17 00:00:00 2001
From: August Sodora 
Date: Tue, 18 Oct 2011 14:50:21 -0400
Subject: [PATCH] String->OUString, with accompanying tests

---
 basic/CppunitTest_basic_scanner.mk |   33 ++
 basic/Module_basic.mk  |4 +
 basic/qa/cppunit/test_scanner.cxx  |  578 
 basic/source/comp/parser.cxx   |6 +-
 basic/source/comp/scanner.cxx  |   31 ++-
 basic/source/comp/token.cxx|   40 ++-
 basic/source/inc/expr.hxx  |2 +-
 basic/source/inc/scanner.hxx   |4 +-
 basic/source/inc/token.hxx |2 +-
 sal/inc/rtl/ustring.hxx|7 +-
 10 files changed, 672 insertions(+), 35 deletions(-)
 create mode 100644 basic/CppunitTest_basic_scanner.mk
 create mode 100644 basic/qa/cppunit/test_scanner.cxx

diff --git a/basic/CppunitTest_basic_scanner.mk b/basic/CppunitTest_basic_scanner.mk
new file mode 100644
index 000..bf8237c
--- /dev/null
+++ b/basic/CppunitTest_basic_scanner.mk
@@ -0,0 +1,33 @@
+$(eval $(call gb_CppunitTest_CppunitTest,basic_scanner))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,basic_scanner, \
+basic/qa/cppunit/test_scanner \
+))
+
+$(eval $(call gb_CppunitTest_add_library_objects,basic_scanner,sb))
+
+# add a list of all needed libraries here
+$(eval $(call gb_CppunitTest_add_linked_libs,basic_scanner, \
+comphelper \
+cppu \
+cppuhelper \
+sal \
+salhelper \
+sb \
+sfx \
+sot \
+svl \
+svt \
+tl \
+utl \
+vcl \
+xcr \
+$(gb_STDLIBS) \
+))
+
+$(eval $(call gb_CppunitTest_set_include,basic_scanner,\
+-I$(realpath $(SRCDIR)/basic/source/inc) \
+-I$(realpath $(SRCDIR)/basic/inc) \
+$$(INCLUDE) \
+-I$(OUTDIR)/inc \
+))
diff --git a/basic/Module_basic.mk b/basic/Module_basic.mk
index e7f9393..d1b5dee 100644
--- a/basic/Module_basic.mk
+++ b/basic/Module_basic.mk
@@ -37,4 +37,8 @@ $(eval $(call gb_Module_add_targets,basic,\
 	StaticLibrary_sample \
 ))
 
+$(eval $(call gb_Module_add_check_targets,basic,\
+ CppunitTest_basic_scanner \
+)) 
+
 # vim: set noet sw=4 ts=4:
diff --git a/basic/qa/cppunit/test_scanner.cxx b/basic/qa/cppunit/test_scanner.cxx
new file mode 100644
index 000..f6459a5
--- /dev/null
+++ b/basic/qa/cppunit/test_scanner.cxx
@@ -0,0 +1,578 @@
+#include "sal/config.h"
+#include "sal/precppunit.hxx"
+
+#include "cppunit/TestAssert.h"
+#include "cppunit/TestFixture.h"
+#include "cppunit/extensions/HelperMacros.h"
+#include "cppunit/plugin/TestPlugIn.h"
+
+#include "osl/file.hxx"
+#include "osl/process.h"
+
+#include "scanner.hxx"
+
+namespace
+{
+  struct Symbol
+  {
+sal_uInt16 line;
+sal_uInt16 col1;
+sal_uInt16 col2;
+rtl::OUString text;
+double number;
+SbxDataType type;
+  };
+
+  /**
+   * Perform tests on Scanner.
+   */
+  class ScannerTest : public CppUnit::TestFixture
+  {
+  private:
+void testBlankLines();
+void testOperators();
+void testAlphanum();
+void testComments();
+void testGoto();
+void testExclamation();
+void testNumbers();
+
+// Adds code needed to register the test suite
+CPPUNIT_TEST_SUITE(ScannerTest);
+
+// Declares the method as a test to call
+CPPUNIT_TEST(testBlankLines);
+CPPUNIT_TEST(testOperators);
+CPPUNIT_TEST(testAlphanum);
+CPPUNIT_TEST(testComments);
+CPPUNIT_TEST(testGoto);
+CPPUNIT_TEST(testExclamation);
+CPPUNIT_TEST(testNumbers);
+
+// End of test suite definition
+CPPUNIT_TEST_SUITE_END();
+  public:
+void setUp()
+{
+}
+
+void tearDown()
+{
+}
+  };
+
+  const static rtl::OUString cr(RTL_CONSTASCII_USTRINGPARAM("\n"));
+  const static rtl::OUString rem(RTL_CONSTASCII_USTRINGPARAM("REM"));
+  const static rtl::OUString asdf(RTL_CONSTASCII_USTRINGPARAM("asdf"));
+  const static rtl::OUString dot(RTL_CONSTASCII_USTRINGPARAM("."));
+  const static rtl::OUString goto_(RTL_CONSTASCII_USTRINGPARAM("goto"));
+  const static rtl::OUString excl(RTL_CONSTASCII_USTRINGPARAM("!"));
+
+  std::vector getSymbols(const rtl::OUString& source)
+  {
+std::vector symbols;
+SbiScanner scanner(source);
+while(scanner.NextSym())
+{
+  Symbol symbol;
+  symbol.line = scanner.GetLine();
+  symbol.col1 = scanner.GetCol1();
+  symbol.col2 = scanner.GetCol2();
+  symbol.text = scanner.GetSym();
+  symb

Re: [Libreoffice] Decoupled NSS and Mozilla in the build

2011-10-18 Thread Michael Stahl
On 18.10.2011 12:20, Jan Holesovsky wrote:
> After this, I believe the only use of Mozilla (module moz) in our build
> is the Mozilla address book.  Or do you know of any other use?

for other vague memories of moz usage see also:

http://mail-archives.apache.org/mod_mbox/incubator-ooo-dev/201109.mbox/%3c4e7b9cc9.90...@gmx.net%3E

http://mail-archives.apache.org/mod_mbox/incubator-ooo-dev/201109.mbox/%3c4e7b9ee9.5010...@frank.schoenheits-abc.de%3e



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Styles cleanup & removing option page std fonts

2011-10-18 Thread Cor Nouws

Hi Cédric,

Interest caught by your presentation in Paris, I saw your patch in cgit:
  359d0fbd03a68d9131e8fb25e7dac9f19ddf6dcb

I understand the idea to remove default paragraph styles such as list, 
list1, list1 cntd, list2 end etc etc
But I do not understand what the link is with removing the option page 
std fonts (Tools > Options > Writer > Basic fonts (& CTL, Asian)
I mean, the option for List fonts indeed can be missed, but what about 
the other 4?

Could you pls explain?

Thanks,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [REVIEW] backport NSS build fixes for 3.4

2011-10-18 Thread Michael Stahl


hi all,

i need the following commits to build nss and moz on a linux 3.1 kernel:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3895465a6cf0a8a41c7432ad9a8f77df7ae572

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa70d98e729c0dba44e1c8e25fe1323bad918945

please somebody tell me that's ok for 3.4.

i should add a line Signed-off-by: $REVIEWER to the commit, right?

regards,
 michael

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] build error in tail_build

2011-10-18 Thread night striker
Ok, I removed all mentions of adabasui from  dbaccess/Module_dbaccess.mk  and
from  scp2  and I am no longer getting the first error, but I still get

collect2: ld returned 1 exit status
make: *** [[...]/workdir/unxlngx6.pro/LinkTarget/Library/libsdbtlo.so] Error
1 

Should I find and remove mentions of sdbt as well, or should that be built?

--
View this message in context: 
http://nabble.documentfoundation.org/build-error-in-tail-build-tp3419875p3431606.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] development summary: year 2011, week 40

2011-10-18 Thread Petr Mladek
Hi,

this time a brief summary of what happened during the 40th week in 2011
on LibreOffice repositories and the living branches:

+ master:LO-3.5 development
+ libreoffice-3-3:   fixes for LO-3.3.5 bug fix release
+ no changes on that branch
+ libreoffice-3-4:   fixes for LO-3.4.4 bug fix release

There are two logs for each branch:

+ bugfixes--week--.txt lists all commits that 
reference a proper
  bug id from a variety of trackers, i.e. #i... referring to the 
OpenOffice
  issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla

+ commit-log--week--.txt lists all relevant commits 
on the actual
  source repositories

Many thanks to all contributors - you make all the difference!


Best Regards,
Petr
nothing this week
+ core
+ - "Prind grid" possible only when "Display grid" checked (fdo#41187) [Takeshi Abe]
+ add Pali language (Latin script) (fdo#41599) [Andras Timar]
+ add unit test for (fdo#41381) [Markus Mohrhard]
+ apply control name before control is inserted into Forms container (bnc#705977) [Noel Power]
+ display page background color/image properly. (bnc#722045) [Kohei Yoshida]
+ encode virtual paths to local volume correctly. (bnc#719887) [Kohei Yoshida]
+ fix broken eventattacher. (bnc#718227) [Noel Power]
+ fix for - [UI] Need more room for localized string (IV) (fdo#41408) [Olivier Hallot]
+ fix for bug - Need more room for localized string (fdo#41310) [Olivier Hallot]
+ fix for bug [UI]add "Protect Sheet" command in sheet popup menu (fdo#41478) [Olivier Hallot]
+ fix for local range names don't work with INDIRECT (fdo#41381) [Markus Mohrhard]
+ fix po2lo to support python3 as well (fdo#41380) [Miklos Vajna]
+ follow-up cleanup. (fdo#41478) [Jan Holesovsky]
+ odbc fractional seconds are in billionths (fdo#34309) [Caolán McNamara]
+ reenable sw.DocumentSettings::com::sun::star::text::PrintSettings yet again as it seems to work now (fdo#35660) [Bjoern Michaelsen]
+ undo corrupting the document. (bnc#685123) [Muthu Subramanian]
+ base
+ tweak ambiguities for F-15 gcc 4.6.1-9 [Caolán McNamara]
+ bootstrap
+ add Scottish Gaelic (gd) UI support [Andras Timar]
+ components
+ get this building with gcc 4.6.1 [Caolán McNamara]
+ libs-gui
+ help gcc 4.6.1 out with ambiguity [Caolán McNamara]
+ translations
+ add Scottish Gaelic (gd) translations [Andras Timar]
+ translation update for LibreOffice 3.4.4 [Andras Timar]
+ binfilter
+ callcatcher: newly unused methods [Caolán McNamara]
+ class TypedStrCollection is not really used, so I'm deleting it. [Joseph Powers]
+ cleanup class ScChartListenerCollection [Joseph Powers]
+ cleanup class ScDBDocFunc a little [Joseph Powers]
+ cleanup class SdrMarkView [Joseph Powers]
+ cleanup of classes ScColumn & ScDocument [Joseph Powers]
+ cleanup the #if a little [Joseph Powers]
+ dBG_BF_ASSERT cleanup for bf_sch [Joseph Powers]
+ more DBG_BF_ASSERT cleanup in bf_sc [Joseph Powers]
+ more DBG_BF_ASSERT cleanup in bf_svx [Joseph Powers]
+ remove the rest of the W4W source [Joseph Powers]
+ some DBG_BF_ASSERT cleanup in bf_svx [Joseph Powers]
+ some more warning cleanup. [Stephan Bergmann]
+ svByteStrings can go from here too [Caolán McNamara]
+ the last of the easy DBG_BF_ASSERT from bf_sch [Joseph Powers]
+ the last of the easy DBG_BF_ASSERT() in bf_sc [Joseph Powers]
+ waE: ditch unused args [Caolán McNamara]
+ waE: new warnings [Caolán McNamara]
+ waE: unused arguments [Caolán McNamara]
+ waE: unused parameters [Caolán McNamara]
+ waE: unused variables [Caolán McNamara]
+ we don't have the W4W filters [Caolán McNamara]
+ core
+ - "Prind grid" possible only when "Display grid" checked (fdo#41187) [Takeshi Abe]
+ --strip-component is GNU tar extension [David Tardon]
+ 1st part of Replace WW8Bytes with ww::bytes [Maciej Rumianowski]
+ 2nd part of Replace WW8Bytes with ww::bytes [Maciej Rumianowski]
+ aEmptyByteStr unnecessary [Caolán McNamara]
+ adapt hwpfilter unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt i18npool unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt lotuswordpro unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt sc unittests to separate RdbTarget makefile requirement, also rename sc_test_filters consistent to sc_filters_test [Bjoern Michaelsen]
+ adapt sd unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt starmath unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt sw unittests to separate RdbTarget makefile requirement [Bjoern Michaelsen]
+ adapt to removal of dangerous operators [Fridrich Štrba]
+ adapt to the change in system libwp* flags [Fridrich Štrba]
+ adapt writerfi

Re: [Libreoffice] gdb: catching exceptions...

2011-10-18 Thread Tom Tromey
Third time's the charm.  Apologies if you've seen this a lot.

Mark Wielaard pointed out this note to me.
Feel free to CC 'arc...@sourceware.org' on hacks like this, we're
interested in hearing about them and to find out what developers need
from gdb.

Michael> since my smoketest failed again today, i've distracted myself a bit
Michael> with GDB Python scripting, the result of which is a command that can
Michael> break when an exception is thrown, but only if a certain function
Michael> (which is given as parameter) is on the stack.

Nice.

Michael> seems to work, but it is quite slow: finding the smoketest exception
Michael> in SfxBaseModel::getTitle takes GDB 4 minutes of CPU time.

Michael> now probably somebody will tell me that i'm too stupid to RTFM and
Michael> there is a much simpler way to do this :)

There isn't a simpler way right now.  You could try to do it by having a
breakpoint on the function you care about that keeps a count of entries
and exits and enables the __cxa_throw breakpoint if this is nonzero.
However, this is hard to do reliably right now, because you have to do a
lot of manual management of return breakpoints.  I think this may get
simpler when the "finish breakpoint" feature goes in:

http://sourceware.org/ml/gdb-patches/2011-10/msg00394.html

We're interested in hearing about real-life uses of exceptions and what
better functionality gdb could provide.  Freely file feature requests in
gdb bugzilla; enhancing C++ development is a primary goal of ours these
days.

thanks,
Tom
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gdb: info mutex

2011-10-18 Thread Tom Tromey
> "Michael" == Michael Stahl 
>  writes:

Michael> have just found a great python command for GDB by Tom Tromey called
Michael> "info mutex":
Michael> http://www.cygwin.com/ml/archer/2010-q3/msg00024.html
Michael> looks very helpful for debugging a deadlock:

Just be warned, it is a bit broken.  It has some heuristics to see when
a thread is attempting to acquire a lock, but these do not always yield
the correct answer.  Still, it shouldn't be too misleading, as you can
always dig around manually to verify what it says.

Also I think you need glibc debuginfo installed for it to work at all.

We hope to write a better version, replacing the heuristics with hidden
breakpoints on sdt.h probe points in glibc.  I think the probes might be
there (in Fedora, but probably not anywhere else, as upstream rejected
the probes), but we haven't written the gdb side yet.

Tom
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Decoupled NSS and Mozilla in the build

2011-10-18 Thread Jan Holesovsky
Hi Caolan,

On 2011-10-18 at 11:29 +0100, Caolán McNamara wrote:

> > After this, I believe the only use of Mozilla (module moz) in our build
> > is the Mozilla address book.  Or do you know of any other use?
> 
> There is also some ldap stuff built by default around the moz chain,
> though there is an alternative openldap solution as well, though we
> don't have any "internal-openldap" support for the windows case. Not
> exactly sure how to test that stuff.

Ah, good point, thanks!

Also --disable-nss-module is needed with MinGW cross-compilation for
now.

> I think I mentioned before that some of the mozilla-profile-finding code
> is reused to *find* where your moz certificates are, in order to list
> them for the xml signing.

I also saw this

http://cgit.freedesktop.org/libreoffice/core/tree/xmlsecurity/source/xmlsec/nss/nssinitializer.cxx#n251

when doing the changes, but it looked to me "good enough", but of course
ideas how to actually test it would be great :-)

> IIRC there are two implementations, one when moz is built, and one when
> it isn't. And the second one is a super-minimal version which might be
> "good enough" for the general case, at least it has been the default
> path we use in Fedora for ages anyway, so apparently good-enough.
> connectivity/source/drivers/mozab/bootstrap is that stuff I think, i.e.
> there's a mozilla-profile-finding service in there. Checking that it
> works on MacOSX/Windows (if that's relevant) has always been my blocker
> for defaulting to/improving the minimal one

OK, will check at some stage.

Either way - this all still needs more polishing to be really useful
[ie. to be able to throw away the moz module ;-)], but hopefully should
improve the experience of those building with --disable-mozilla.

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] recent push requires ~fresh rebuild

2011-10-18 Thread Stephan Bergmann
 
"Undo basis/brand split: move program/classes/ from basis to brand." 
requires manual tweaking in a rebuild, as it changes content of 
generated .component files based on changes in the central makefiles.


Short of make clean, what worked for me was, inside .../core,

find */unxlngx6 -name '*.component' -exec rm {} \;

(with "unxlngx6" replaced by your platform ID).

-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] gdb: info mutex

2011-10-18 Thread Michael Stahl


have just found a great python command for GDB by Tom Tromey called 
"info mutex":


http://www.cygwin.com/ml/archer/2010-q3/msg00024.html

looks very helpful for debugging a deadlock:


(gdb) info mutex
Mutex 0x264fbb0:
*  Owned by thread 25481
   Thread 27391

Mutex 0xbd4370:
   Owned by thread 27391
*  Thread 25481

Threads not waiting for a lock:
   Thread 25499
   Thread 25504
   Thread 25505
   Thread 25535
   Thread 25536
   Thread 27620


the original script didn't run for me, but with a trivial tweak it does 
(attached).


regards,
 michael
import gdb

#--
# http://www.cygwin.com/ml/archer/2010-q3/msg00024.html

class ThreadHolder:
"""A class that can be used with the 'with' statement to save and
restore the current thread while operating on some other thread."""
def __init__(self, thread):
self.thread = thread

def __enter__(self):
self.save = gdb.selected_thread()
self.thread.switch()

def __exit__ (self, exc_type, exc_value, traceback):
try:
self.save.switch()
except:
pass
return None

def print_thread (selected_thread, thr, owner):
"A helper function to nicely print a gdb.Thread."
if thr == selected_thread:
print "* ",
else:
print "  ",
if owner:
print "Owned by thread",
else:
print "Thread",
(pid, lwp, tid) = thr.ptid
print "%d  " % lwp
# FIXME - function, file name, etc

class InfoMutex(gdb.Command):
def __init__ (self):
gdb.Command.__init__ (self, "info mutex", gdb.COMMAND_NONE)

def invoke (self, arg, from_tty):
# Map a mutex ID to the LWP owning the mutex.
owner = {}
# Map an LWP id to a thread object.
threads = {}
# Map a mutex ID to a list of thread objects that are waiting
# for the lock.
mutexes = {}

for inf in gdb.inferiors():
for thr in inf.threads():
id = thr.ptid[1]
threads[id] = thr
with ThreadHolder (thr):
frame = gdb.selected_frame()
lock_name = None
for n in range(5):
if frame is None:
break
fn_sym = frame.function()
if fn_sym is not None and (fn_sym.name == 
'__pthread_mutex_lock' or fn_sym.name == '__pthread_mutex_lock_full' or 
fn_sym.name == 'pthread_mutex_timedlock'):
m = frame.read_var ('mutex')
lock_name = long (m)
if lock_name not in owner:
owner[lock_name] = long (m['__data']['__owner'])
break
frame = frame.older()
if lock_name not in mutexes:
mutexes[lock_name] = []
mutexes[lock_name] += [thr]

selected_thread = gdb.selected_thread()

for id in mutexes.keys():
if id is None:
print "Threads not waiting for a lock:"
else:
print "Mutex 0x%x:" % id
print_thread (selected_thread, threads[owner[id]], True)
for thr in mutexes[id]:
print_thread (selected_thread, thr, False)
print

InfoMutex()

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gdb: catching exceptions...

2011-10-18 Thread Michael Stahl

On 18/10/11 12:21, Lubos Lunak wrote:

On Monday 17 of October 2011, Michael Stahl wrote:

since my smoketest failed again today, i've distracted myself a bit with
GDB Python scripting, the result of which is a command that can break
when an exception is thrown, but only if a certain function (which is
given as parameter) is on the stack.

seems to work, but it is quite slow: finding the smoketest exception in
SfxBaseModel::getTitle takes GDB 4 minutes of CPU time.

now probably somebody will tell me that i'm too stupid to RTFM and there
is a much simpler way to do this :)


  Possibly 'help catch' and 'help commands' could make this easier/faster, but
I have not actually tried it.


my idea at first was to add a breakpoint at function entry with a 
command that enables "catch throw" and another breakpoint at function 
exit that disables.  then i thought about things such as recursion and 
multiple threads, and how the heck do you set a breakpoint at function 
exit, and wrote the brute force stack lookup instead :)



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Decoupled NSS and Mozilla in the build

2011-10-18 Thread Caolán McNamara
On Tue, 2011-10-18 at 12:20 +0200, Jan Holesovsky wrote:
> After this, I believe the only use of Mozilla (module moz) in our build
> is the Mozilla address book.  Or do you know of any other use?

There is also some ldap stuff built by default around the moz chain,
though there is an alternative openldap solution as well, though we
don't have any "internal-openldap" support for the windows case. Not
exactly sure how to test that stuff.

I think I mentioned before that some of the mozilla-profile-finding code
is reused to *find* where your moz certificates are, in order to list
them for the xml signing.

IIRC there are two implementations, one when moz is built, and one when
it isn't. And the second one is a super-minimal version which might be
"good enough" for the general case, at least it has been the default
path we use in Fedora for ages anyway, so apparently good-enough.
connectivity/source/drivers/mozab/bootstrap is that stuff I think, i.e.
there's a mozilla-profile-finding service in there. Checking that it
works on MacOSX/Windows (if that's relevant) has always been my blocker
for defaulting to/improving the minimal one

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PUSHING] ... pre patch question

2011-10-18 Thread Michael Meeks
Hi Lior,

First - great to see you in Paris :-) thanks for sitting down to review
this stuff together.

On Mon, 2011-10-17 at 20:53 +0200, Lior Kaplan wrote:
> I'm attaching 3 patches:
> 1. Bulk removal.
> 2. Compact the enumeration.
> 3. Just align a string (no change in content).

I'm just compile testing it now.

> From what I understand, CONTENT_TYPE_LAST gets the value of the last
> member in the enumeration (at inc/svl/inettype.hxx), so the compact
> patch actually makes sure of its new value.

Great.

> I also didn't do the compile test, help will be welcomed (I'll try to
> work on a build environment for next time).

Am testing it now; of course - if you have a build - lots of little
things become quite easy to submit patches for. In fact - many of the
RTL bugs you helpfully highlighted in your talk, are not -so- tricky to
fix with some careful application of
 if( Application::GetSettings().GetLayoutRTL() ) ..'s :-)
and their ilk.

> Let me know for needed fixes/changes in the patches.

Thanks - I'll take it from here.

All the best,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gdb: catching exceptions...

2011-10-18 Thread Lubos Lunak
On Monday 17 of October 2011, Michael Stahl wrote:
> since my smoketest failed again today, i've distracted myself a bit with
> GDB Python scripting, the result of which is a command that can break
> when an exception is thrown, but only if a certain function (which is
> given as parameter) is on the stack.
>
> seems to work, but it is quite slow: finding the smoketest exception in
> SfxBaseModel::getTitle takes GDB 4 minutes of CPU time.
>
> now probably somebody will tell me that i'm too stupid to RTFM and there
> is a much simpler way to do this :)

 Possibly 'help catch' and 'help commands' could make this easier/faster, but 
I have not actually tried it.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] Decoupled NSS and Mozilla in the build

2011-10-18 Thread Jan Holesovsky
Hi,

Markus found out that when you provide --disable-mozilla, you lose the
xml security features provided by NSS.  After:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37209912b44f5accee73e7f774122b195fe2183

it shouldn't be the case any more.  NSS is not built in the moz module
for quite some time already, instead the internal NSS is used, so the
decoupling was a matter of few fixes; hopefully it is OK now.

If you want the previous behavior (ie. no NSS, no XML security), please
specify --disable-nss-module additionally to --disable-mozilla.

After this, I believe the only use of Mozilla (module moz) in our build
is the Mozilla address book.  Or do you know of any other use?

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Trying to diagnose base running extremely slowly

2011-10-18 Thread Michael Meeks

On Tue, 2011-10-18 at 09:03 +0200, Jan Holesovsky wrote:
> the strace output, and see if the reason for hang in
> java.net.PlainSocketimpl.socketAccept is actually something that can be
> worked around.

Of course, it is possible that Java7 adds some security features around
accepting sockets, such as a hostname reverse lookup; it is entirely
possible that this (combined with a pre-existing DNS mess-up) suddenly
causes problems for you.

What does ping `hostname` say for you ?

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] make check fails in i18npool

2011-10-18 Thread Michael Meeks
Hi Regina,

On Mon, 2011-10-17 at 18:10 +0200, Regina Henschel wrote:
> I think, that my last working build has at last commit 
> e024f616934bb78fba8c8101264806d507068d7e
> Author: Christoph Lutz 
> Date:   Tue Sep 6 19:01:19 2011 +0200
>  i#118224: kill O(n^2) complexity of unique bookmark name creation
> 
> But i'm not sure, because I tried a lot in the meantime. How can I clone 
> from that point? Then I would build again to verify it.

Ah - so you want to save your changes: git diff > /tmp/save.diff and
perhaps 'git stash' to double save it ;-) then you can do either:

git checkout e024f616934bb78fba8c8101264806d507068d7e

which will move you to this revision (you can't commit there of course
- and git checkout master will move you back).

I'll try adding a git note to this so others know where to find it. Of
course - if you have a patch, given the state of the Win32 build, please
do just work from that revision, and I'll forward port & test-build any
patches vs. master on Linux (until we can get this sorted out). Sorry
again for the loss of service.

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Trying to diagnose base running extremely slowly

2011-10-18 Thread Jan Holesovsky
Hi John,

On 2011-10-18 at 06:18 +0100, jowyta wrote:
> >> Also, I see Ocke Janssen wrote in
> >> https://issues.apache.org/ooo/show_bug.cgi?id=117203

[...]

> I have done some searching and the bug appears to be filed as:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024514
> So provided the above diagnosis is correct we seem to be heading in the 
> right direction - but that bug was filed in March.

OK, good; so what you can do to help to analyze it more, is to look at
the strace output, and see if the reason for hang in
java.net.PlainSocketimpl.socketAccept is actually something that can be
worked around.

How to get a strace:

http://wiki.documentfoundation.org/BugReport#How_to_get_strace_log_.28on_Linux.29

Other than that, you can try to trace what exactly calls
java.net.PlainSocketimpl.socketAccept (I think it is around
http://opengrok.libreoffice.org/xref/core/jurt/com/sun/star/lib/connections/socket/socketAcceptor.java,
 but can be wrong), and try to fix it to behave correctly.

Unfortunately I have no better advices - sorry :-(

Hope that helps,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice