[Libreoffice-commits] .: scp2/source
scp2/source/ooo/directory_ooo.scp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1af9425e8239d1f7e3a12bf9979d190904f695cd
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Oct 21 09:51:13 2011 +0200
Work around a problem creating symlinks in ooinstall.
It can happen that the ure-link symlink shall be created while its
parent directory has not yet been created. The logic in the Perl code
is so confusing and beyond fixing, that an easy hack out was to flag
the respective directory as always-CREATE, which kind of works around
the problem.
diff --git a/scp2/source/ooo/directory_ooo.scp
b/scp2/source/ooo/directory_ooo.scp
index 015c1dc..10b32fb 100644
--- a/scp2/source/ooo/directory_ooo.scp
+++ b/scp2/source/ooo/directory_ooo.scp
@@ -92,7 +92,7 @@ Directory gid_Dir_Ooo_Basis
#else
HostName = basis${OOOBASEVERSION};
#endif
-Styles = (BASISDIRECTORY);
+Styles = (BASISDIRECTORY, CREATE);
End
#endif
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - basic/CppunitTest_basic_scanner.mk basic/Module_basic.mk basic/qa basic/source sal/inc
basic/CppunitTest_basic_scanner.mk | 33 ++
basic/Module_basic.mk |4
basic/qa/cppunit/test_scanner.cxx | 570 +
basic/source/comp/parser.cxx |6
basic/source/comp/scanner.cxx | 35 +-
basic/source/comp/token.cxx| 40 +-
basic/source/inc/expr.hxx |2
basic/source/inc/scanner.hxx |4
basic/source/inc/token.hxx |2
sal/inc/rtl/ustring.hxx| 27 +
10 files changed, 686 insertions(+), 37 deletions(-)
New commits:
commit e31496c9382ebdaa6ed1c6889c0d6ecde6f57de7
Author: Michael Meeks michael.me...@suse.com
Date: Fri Oct 21 10:08:02 2011 +0100
misc trivial tweaks, and documentation addition
diff --git a/basic/Module_basic.mk b/basic/Module_basic.mk
index d1b5dee..885a0c0 100644
--- a/basic/Module_basic.mk
+++ b/basic/Module_basic.mk
@@ -39,6 +39,6 @@ $(eval $(call gb_Module_add_targets,basic,\
$(eval $(call gb_Module_add_check_targets,basic,\
CppunitTest_basic_scanner \
-))
+))
# vim: set noet sw=4 ts=4:
diff --git a/basic/qa/cppunit/test_scanner.cxx
b/basic/qa/cppunit/test_scanner.cxx
index f6459a5..25f5147 100644
--- a/basic/qa/cppunit/test_scanner.cxx
+++ b/basic/qa/cppunit/test_scanner.cxx
@@ -36,7 +36,7 @@ namespace
void testGoto();
void testExclamation();
void testNumbers();
-
+
// Adds code needed to register the test suite
CPPUNIT_TEST_SUITE(ScannerTest);
@@ -51,14 +51,6 @@ namespace
// End of test suite definition
CPPUNIT_TEST_SUITE_END();
- public:
-void setUp()
-{
-}
-
-void tearDown()
-{
-}
};
const static rtl::OUString cr(RTL_CONSTASCII_USTRINGPARAM(\n));
@@ -309,7 +301,7 @@ namespace
CPPUNIT_ASSERT(symbols[1].type == SbxVARIANT);
CPPUNIT_ASSERT(symbols[2].text == cr);
CPPUNIT_ASSERT(symbols[2].type == SbxVARIANT);
-
+
symbols = getSymbols(source10);
CPPUNIT_ASSERT(symbols.size() == 8);
CPPUNIT_ASSERT(symbols[0].text == cr);
@@ -405,7 +397,7 @@ namespace
CPPUNIT_ASSERT(symbols[0].type == SbxVARIANT);
CPPUNIT_ASSERT(symbols[1].text == rem);
CPPUNIT_ASSERT(symbols[1].type == SbxVARIANT);
-
+
symbols = getSymbols(source7);
CPPUNIT_ASSERT(symbols.size() == 4);
CPPUNIT_ASSERT(symbols[0].text == rem);
@@ -471,7 +463,7 @@ namespace
CPPUNIT_ASSERT(symbols[0].text == asdf);
CPPUNIT_ASSERT(symbols[1].text == excl);
CPPUNIT_ASSERT(symbols[2].text == asdf);
-CPPUNIT_ASSERT(symbols[3].text == cr);
+CPPUNIT_ASSERT(symbols[3].text == cr);
symbols = getSymbols(source2);
CPPUNIT_ASSERT(symbols.size() == 3);
@@ -497,7 +489,7 @@ namespace
CPPUNIT_ASSERT(symbols[0].text == excl);
CPPUNIT_ASSERT(symbols[1].text ==
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(%)));
CPPUNIT_ASSERT(symbols[2].text == cr);
-
+
symbols = getSymbols(source6);
CPPUNIT_ASSERT(symbols.size() == 2);
CPPUNIT_ASSERT(symbols[0].text == excl);
@@ -523,12 +515,12 @@ namespace
CPPUNIT_ASSERT(symbols.size() == 2);
CPPUNIT_ASSERT(symbols[0].number == 12345);
CPPUNIT_ASSERT(symbols[1].text == cr);
-
+
symbols = getSymbols(source2);
CPPUNIT_ASSERT(symbols.size() == 2);
CPPUNIT_ASSERT(symbols[0].number == 1.23);
CPPUNIT_ASSERT(symbols[1].text == cr);
-
+
symbols = getSymbols(source3);
CPPUNIT_ASSERT(symbols.size() == 2);
CPPUNIT_ASSERT(symbols[0].number = 123.4);
diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 998ecbf..0211b75 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -391,7 +391,7 @@ sal_Bool SbiScanner::NextSym()
break;
default :
// treated as an operator
-pLine--; nCol--; nCol1 = nCol-1;
+pLine--; nCol--; nCol1 = nCol-1;
aSym = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM());
return SYMBOL;
}
@@ -459,14 +459,14 @@ sal_Bool SbiScanner::NextSym()
// get out duplicate string delimiters
String s( cSep );
s += cSep;
-sal_uInt16 nIdx = 0;
+sal_Int32 nIdx = 0;
do
{
nIdx = aSym.indexOf( s, nIdx );
-if( nIdx == STRING_NOTFOUND )
+if( nIdx 0 )
break;
-::rtl::OUStringBuffer aSymBuf(aSym);
-aSymBuf.remove(nIdx, 1);
+::rtl::OUStringBuffer aSymBuf( aSym );
+aSymBuf.remove( nIdx, 1 );
aSym = aSymBuf.makeStringAndClear();
nIdx++;
}
diff --git a/basic/source/comp/token.cxx b/basic/source/comp/token.cxx
index d09d539..dc8287f 100644
--- a/basic/source/comp/token.cxx
+++ b/basic/source/comp/token.cxx
@@ -291,10 +291,10 @@ const ::rtl::OUString SbiTokenizer::Symbol( SbiToken t )
}
switch( t )
{
-case NEG :
+case
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - vcl/unx
vcl/unx/kde4/main.cxx | 11 +++
1 file changed, 11 insertions(+)
New commits:
commit 4c2b93d96689f62c24ebdb2d4e87ac08d51ed53a
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Thu Oct 20 14:41:50 2011 +
let Qt call XInitThreads(), so that it knows it's been called (fdo#40298)
Otherwise QPixmap complains when used outside of the main Qt thread
and resets itself to null pixmap, eventually leading to crashes.
Signed-off-by: Tomáš Chvátal tchva...@suse.cz
diff --git a/vcl/unx/kde4/main.cxx b/vcl/unx/kde4/main.cxx
index 32561d9..4365ad6 100644
--- a/vcl/unx/kde4/main.cxx
+++ b/vcl/unx/kde4/main.cxx
@@ -54,7 +54,18 @@ extern C {
established, so protect X against itself
*/
if( ! ( pNoXInitThreads *pNoXInitThreads ) )
+{
+#if QT_VERSION = 0x040800
+// let Qt call XInitThreads(), so that also Qt knows it's been used
+// (otherwise QPixmap may warn about threads not being initialized)
+QApplication::setAttribute( Qt::AA_X11InitThreads );
+#else
XInitThreads();
+// just in case somebody builds with old version and then upgrades
Qt,
+// otherwise this is a no-op
+QApplication::setAttribute( static_cast Qt::ApplicationAttribute
( 10 ));
+#endif
+}
#if QT_VERSION 0x05
// Qt 4.x support needs = 4.1.0
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - filter/source svtools/source svx/inc svx/source
filter/source/svg/svgfilter.component |4 +++-
filter/source/svg/svgfilter.cxx |5 ++---
svtools/source/filter/filter.cxx | 13 +
svx/inc/svx/xmlgrhlp.hxx |3 ++-
svx/source/svdraw/svdograf.cxx|7 +--
svx/source/xml/xmlgrhlp.cxx | 24
6 files changed, 37 insertions(+), 19 deletions(-)
New commits:
commit f3c43171f8e9e04c4a6e6f5833fbe1a0ef098d2b
Author: Thorsten Behrens tbehr...@novell.com
Date: Fri Oct 21 11:10:29 2011 +0200
Fix fdo#41995 fallout - recognize .svg in odf container
Seems the graphic load code is stupid and not using the path name /
file extension to guess file type, but only magic byte detection.
Giving filter framework the path now, so that .svg actually loads.
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index ff24d2a..d1eadd0 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -1286,8 +1286,11 @@ IMPL_LINK( SdrGrafObj, ImpSwapHdl, GraphicObject*, pO )
mbIsPreview = sal_True;
}
-if( !GraphicFilter::GetGraphicFilter().ImportGraphic(
aGraphic, String(), *pStream,
-
GRFILTER_FORMAT_DONTKNOW, NULL, 0, pFilterData ) )
+if( !GraphicFilter::GetGraphicFilter().ImportGraphic(
aGraphic,
+
aStreamInfo.maUserData,
+
*pStream,
+
GRFILTER_FORMAT_DONTKNOW,
+
NULL, 0, pFilterData ) )
{
const String aUserData( pGraphic-GetUserData() );
commit 1d9c6bc38089dbb52931e54493c39e4e33309a90
Author: Thorsten Behrens tbehr...@novell.com
Date: Wed Oct 19 14:12:15 2011 +0200
Fix svg document import
Merge of dev300 broke this - we *do* want import to call this
implImport() actually. Also, the service names were bogus
previously.
diff --git a/filter/source/svg/svgfilter.component
b/filter/source/svg/svgfilter.component
index 82db624..c4d5bff 100644
--- a/filter/source/svg/svgfilter.component
+++ b/filter/source/svg/svgfilter.component
@@ -29,6 +29,8 @@
component loader=com.sun.star.loader.SharedLibrary
xmlns=http://openoffice.org/2010/uno-components;
implementation name=com.sun.star.comp.Draw.SVGFilter
-service name=com.sun.star.document.SVGFilter/
+service name=com.sun.star.document.ImportFilter/
+service name=com.sun.star.document.ExportFilter/
+service name=com.sun.star.document.ExtendedTypeDetection/
/implementation
/component
diff --git a/filter/source/svg/svgfilter.cxx b/filter/source/svg/svgfilter.cxx
index 42f48a2..b5f9b07 100644
--- a/filter/source/svg/svgfilter.cxx
+++ b/filter/source/svg/svgfilter.cxx
@@ -113,9 +113,8 @@ sal_Bool SAL_CALL SVGFilter::filter( const Sequence
PropertyValue rDescripto
pFocusWindow-EnterWait();
if( mxDstDoc.is() )
-bRet = sal_False;//implImport( rDescriptor );
-else
-if( mxSrcDoc.is() )
+bRet = implImport( rDescriptor );
+else if( mxSrcDoc.is() )
{
if( !mbExportAll )
{
commit 716c052a1c62d5acacab202e8f0ee88b4f70d8c2
Author: Thorsten Behrens tbehr...@novell.com
Date: Wed Oct 19 13:25:35 2011 +0200
Fix fdo#41995 - true embedding of svg images.
Previously, svg images were always wrapped as .svm metafiles with
a preview graphic. Sucks for interop - so now, we save true svgs
at least for bleeding edge extended odf1.2
diff --git a/svtools/source/filter/filter.cxx b/svtools/source/filter/filter.cxx
index 5c9edab..226b48d 100644
--- a/svtools/source/filter/filter.cxx
+++ b/svtools/source/filter/filter.cxx
@@ -1501,17 +1501,14 @@ sal_uInt16 GraphicFilter::ImportGraphic( Graphic
rGraphic, const String rPath,
GDIMetaFile aSVGMtf;
if( 0 == aSVGReader.Read( aSVGMtf ).GetActionSize() )
+{
nStatus = GRFILTER_FILTERERROR;
+}
else
+{
rGraphic = Graphic( aSVGMtf );
-
-// Dont set any GfxLink here, since the MetaRenderGraphicAction
-// inside the just read MetaFile contains excatly this native data;
-// setting a Ç´fxLink would also affect other program parts, since
-// GfxLinks are preferably written to the file format in general,
-// which would be a bad idea in case of SVG files, since earlier
-// implementations are not able to handle native SVG data in any
-// case. (KA 01/19/2011)
+eLinkType = GFX_LINK_TYPE_NATIVE_SVG;
+}
}
else if(
[Libreoffice-commits] .: oox/source
oox/source/ole/vbainputstream.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e3ef9bebf69479ead10a10a9a25d866321970edb
Author: Noel Power noel.po...@novell.com
Date: Fri Oct 21 10:51:10 2011 +0100
tweak compressession hack to fix vba module import
it seems that the heuristic to trigger the inflate hack from frob is both
wrong in the code ( my fault ) and additionally doesn't always hold true (
found a document where the heuristic is triggered falsely ) So. removing that
heuristic entirely for now
diff --git a/oox/source/ole/vbainputstream.cxx
b/oox/source/ole/vbainputstream.cxx
index 8b054ea..5299b7e 100644
--- a/oox/source/ole/vbainputstream.cxx
+++ b/oox/source/ole/vbainputstream.cxx
@@ -147,7 +147,7 @@ bool VbaInputStream::updateChunk()
// start of the next chunk we can read those strange broken
// ( I guess from a MSO bug ) commpessed streams 4k
-if ( bIgnoreBrokenSig || ( ! ( mpInStrm-getRemaining() 4096 ) ) )
+if ( bIgnoreBrokenSig )
{
bCompressed = true;
nChunkLen = 4094;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - svx/source
svx/source/svdraw/svdograf.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 1191c474bdf21fda5e8b8ced6b0b50286dea2391
Author: Thorsten Behrens tbehrens-et1tbqhtxzrqt0dzr+a...@public.gmane.org
Date: Fri Oct 21 11:14:32 2011 +0200
Fix fdo#41995 fallout - recognize .svg in odf container
Seems the graphic load code is stupid and not using the path name /
file extension to guess file type, but only magic byte detection.
Giving filter framework the path now, so that .svg actually loads.
Signed-off-by: Michael Stahl mst...@redhat.com
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index e51a268..56d0643 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -1299,8 +1299,11 @@ IMPL_LINK( SdrGrafObj, ImpSwapHdl, GraphicObject*, pO )
mbIsPreview = sal_True;
}
-if( !GraphicFilter::GetGraphicFilter()-ImportGraphic(
aGraphic, String(), *pStream,
-
GRFILTER_FORMAT_DONTKNOW, NULL, 0, pFilterData ) )
+if( !GraphicFilter::GetGraphicFilter()-ImportGraphic(
aGraphic,
+
aStreamInfo.maUserData,
+
*pStream,
+
GRFILTER_FORMAT_DONTKNOW,
+
NULL, 0, pFilterData ) )
{
const String aUserData( pGraphic-GetUserData() );
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 25ae2ab38df3c914e9f836cf08120913bc2c4ba6 Author: Tor Lillqvist tlillqv...@suse.com Date: Fri Oct 21 14:04:58 2011 +0300 Disable Mozilla stuff more effectively in a Windows dbgutil build diff --git a/configure.in b/configure.in index df644ae..c94ad6d 100644 --- a/configure.in +++ b/configure.in @@ -2324,8 +2324,8 @@ if test -n $enable_dbgutil test $enable_dbgutil != no; then with_system_mysql_cppconn=no fi if test $_os = WINNT -a \ -\( $enable_mozilla = yes -o \ - $enable_build_mozilla = yes \); then +\( $enable_mozilla != no -o \ + $enable_build_mozilla != no \); then # We can't build against the Mozilla stuff if using _DEBUG, will get linking errors # See connectivity/drivers/mozab AC_MSG_WARN([Also disabling Mozilla stuff then]) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: binfilter/bf_xmloff
binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx |4
+++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 86db50edeee1d556f993589da73140582789ef42
Author: Caolán McNamara caol...@redhat.com
Date: Fri Oct 21 13:29:59 2011 +0100
Fix regression on rsc/doku examples
Mirror the xmloff code into binfilter, appears to be the original
intention post-95cc316cb6e0c6bee57b78eba15c9e7b26ffe595
diff --git
a/binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx
b/binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx
index 16fad68..dd1c851 100644
--- a/binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx
+++ b/binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx
@@ -36,9 +36,11 @@ using ::com::sun::star::beans::XPropertySet;
using ::com::sun::star::beans::XPropertySetInfo;
sal_Bool SinglePropertySetInfoCache::hasProperty(
-const Reference XPropertySet /*rPropSet*/,
+const Reference XPropertySet rPropSet,
Reference XPropertySetInfo rPropSetInfo )
{
+if( !rPropSetInfo.is() )
+rPropSetInfo = rPropSet-getPropertySetInfo();
iterator aIter = find( rPropSetInfo );
if( aIter != end() )
{
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/Module_sc.mk
sc/Module_sc.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit 160da638dc33a170d071bc80beec57c527756d1d Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Oct 21 15:20:43 2011 +0200 enable sc_macros_test diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk index 1edf646..2aebe1e 100644 --- a/sc/Module_sc.mk +++ b/sc/Module_sc.mk @@ -36,8 +36,10 @@ $(eval $(call gb_Module_add_targets,sc,\ $(eval $(call gb_Module_add_check_targets,sc,\ CppunitTest_sc_filters_test \ + CppunitTest_sc_macros_test \ CppunitTest_sc_ucalc \ RdbTarget_sc_filters_test \ + RdbTarget_sc_macros_test \ RdbTarget_sc_ucalc \ )) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - nlpsolver/makefile.mk
nlpsolver/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 28664eecf3b5af8d850f86d392edf7afba0e4779 Author: Andras Timar ati...@suse.com Date: Thu Oct 20 11:09:24 2011 +0200 fix localization of NLPSolver Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/nlpsolver/makefile.mk b/nlpsolver/makefile.mk index a7d0996..ddbe7aa 100644 --- a/nlpsolver/makefile.mk +++ b/nlpsolver/makefile.mk @@ -46,7 +46,7 @@ PATCH_FILES=nlpsolver-0.9.patch ANT_FLAGS+=-Dplatforms.JDK_1.5.home=$(JAVA_HOME) -Doffice.program.dir=$(SOLARBINDIR) -CONFIGURE_ACTION=(cd ../../../../locale $(GNUTAR) -cf - .) | (cd src/ $(GNUTAR) xf -) +CONFIGURE_ACTION=(cd ../../../../locale $(GNUTAR) -cf - .) | (cd src/locale/ rm *de_DE* $(GNUTAR) xf -) .IF $(JAVACISGCJ)==yes JAVA_HOME= ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/CppunitTest.mk |2 +-
solenv/gbuild/RdbTarget.mk |9 ++---
2 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 71f4a57b2af6c61533176100e39ce8b4276e807b
Author: Michael Meeks michael.me...@suse.com
Date: Fri Oct 21 14:15:48 2011 +0100
Warn if we're missing a RdbTarget from the check_targets
diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk
index 9908b90..3e0af86 100644
--- a/solenv/gbuild/CppunitTest.mk
+++ b/solenv/gbuild/CppunitTest.mk
@@ -33,7 +33,7 @@
DBGSV_ERROR_OUT := shell
export DBGSV_ERROR_OUT
-UNIT_FAILED_MSG := echo; echo Error: a unit test failed, please do one of:;
echo; echo export DEBUGCPPUNIT=TRUE \# for exception catching; echo export
GDBCPPUNITTRACE=gdb \# for interactive debugging; echo export
VALGRIND=memcheck \# for memory checking ; echo and retry.
+UNIT_FAILED_MSG := echo; echo Error: a unit test failed, please do one of:;
echo; echo export DEBUGCPPUNIT=TRUE \# for exception catching; echo
export GDBCPPUNITTRACE=gdb --args \# for interactive debugging; echo export
VALGRIND=memcheck \# for memory checking ; echo and retry.
ifeq ($(strip $(DEBUGCPPUNIT)),TRUE)
gb_CppunitTest_GDBTRACE := gdb -nx
--command=$(SOLARENV)/bin/gdbtrycatchtrace-stdout -return-child-result --args
diff --git a/solenv/gbuild/RdbTarget.mk b/solenv/gbuild/RdbTarget.mk
index fa9ab78..4ce33a1 100644
--- a/solenv/gbuild/RdbTarget.mk
+++ b/solenv/gbuild/RdbTarget.mk
@@ -27,11 +27,16 @@
# instead of those above.
gb_RdbTarget__get_old_component_target = $(OUTDIR)/xml/$(1).component
+gb_RdbTarget__get_rdbs = \
+$(foreach component,$(1),$(call
gb_ComponentTarget_get_target,$(component))) \
+$(foreach component,$(2),$(call
gb_RdbTarget__get_old_component_target,$(component)))
$(call gb_RdbTarget_get_target,%) :
$(call gb_Output_announce,$*,$(true),RDB,1)
$(call gb_Helper_abbreviate_dirs,\
mkdir -p $(dir $@) \
+ $(if $(strip $(call
gb_RdbTarget__get_rdbs,$(COMPONENTS),$(OLD_COMPONENTS))),, \
+ $(error no components to register, check RdbTarget is
included in gb_Module_add_check_targets - no rdb files)) \
echo '?xml version=1.0?components
xmlns=http://openoffice.org/2010/uno-components;' $@ \
$(gb_AWK) -- \
' BEGIN { RS=; } \
@@ -40,9 +45,7 @@ $(call gb_RdbTarget_get_target,%) :
gsub(/vnd.sun.star.expand:\$$OOO_BASE_DIR\/program/,
vnd.sun.star.expand:$$OOO_BASE_DIR,$$0); \
gsub(/vnd.sun.star.expand:\$$BRAND_BASE_DIR\/program/,
vnd.sun.star.expand:$$BRAND_BASE_DIR,$$0); \
print $$0 ; \
- }' \
- $(foreach component,$(COMPONENTS),$(call
gb_ComponentTarget_get_target,$(component))) \
- $(foreach component,$(OLD_COMPONENTS),$(call
gb_RdbTarget__get_old_component_target,$(component))) \
+ }' $(call
gb_RdbTarget__get_rdbs,$(COMPONENTS),$(OLD_COMPONENTS)) \
$@ \
echo '/components' $@)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basic/source
basic/source/runtime/methods1.cxx | 20
basic/source/runtime/rtlproto.hxx |1 +
basic/source/runtime/stdobj.cxx |2 ++
3 files changed, 23 insertions(+)
New commits:
commit 556a61a2f86fef1f828b8352fae7a4c4ed1fdd78
Author: August Sodora aug...@gmail.com
Date: Thu Oct 20 23:08:45 2011 -0400
Added Frac function to calc formulas and BASIC standard library
diff --git a/basic/source/runtime/methods1.cxx
b/basic/source/runtime/methods1.cxx
index f54ff7b..8802245 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -2531,6 +2531,26 @@ RTLFUNC(FormatDateTime)
rPar.Get(0)-PutString( aRetStr );
}
+RTLFUNC(Frac)
+{
+(void)pBasic;
+(void)bWrite;
+
+sal_uInt16 nParCount = rPar.Count();
+if( nParCount != 2)
+{
+StarBASIC::Error( SbERR_BAD_ARGUMENT );
+return;
+}
+
+SbxVariable *pSbxVariable = rPar.Get(1);
+double dVal = pSbxVariable-GetDouble();
+if(dVal = 0)
+rPar.Get(0)-PutDouble(dVal - ::rtl::math::approxFloor(dVal));
+else
+rPar.Get(0)-PutDouble(dVal - ::rtl::math::approxCeil(dVal));
+}
+
RTLFUNC(Round)
{
(void)pBasic;
diff --git a/basic/source/runtime/rtlproto.hxx
b/basic/source/runtime/rtlproto.hxx
index 469cd0f..101c320 100644
--- a/basic/source/runtime/rtlproto.hxx
+++ b/basic/source/runtime/rtlproto.hxx
@@ -250,6 +250,7 @@ extern RTLFUNC(Format);
extern RTLFUNC(GetAttr);
extern RTLFUNC(Randomize); // JSM
extern RTLFUNC(Round);
+extern RTLFUNC(Frac);
extern RTLFUNC(Rnd);
extern RTLFUNC(Shell);
extern RTLFUNC(VarType);
diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx
index 72ec66a..f384784 100644
--- a/basic/source/runtime/stdobj.cxx
+++ b/basic/source/runtime/stdobj.cxx
@@ -295,6 +295,8 @@ static Methods aMethods[] = {
{ FormatDateTime, SbxSTRING,2 | _FUNCTION | _COMPATONLY,
RTLNAME(FormatDateTime),0 },
{ Date, SbxDATE, 0,NULL,0 },
{ NamedFormat, SbxINTEGER,_OPT, NULL,0 },
+{ Frac, SbxDOUBLE,1 | _FUNCTION, RTLNAME(Frac),0},
+ { number, SbxDOUBLE, 0,NULL,0 },
{ FRAMEANCHORCHAR,SbxINTEGER, _CPROP,
RTLNAME(FRAMEANCHORCHAR),0 },
{ FRAMEANCHORPAGE,SbxINTEGER, _CPROP,
RTLNAME(FRAMEANCHORPAGE),0 },
{ FRAMEANCHORPARA,SbxINTEGER, _CPROP,
RTLNAME(FRAMEANCHORPARA),0 },
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/gtk3' - 2 commits - vcl/unx
vcl/unx/gtk/a11y/atkwindow.cxx |2 ++
vcl/unx/gtk/app/gtkdata.cxx |1 +
vcl/unx/gtk/app/gtkinst.cxx | 30 ++
vcl/unx/gtk/window/gtkframe.cxx |2 ++
4 files changed, 27 insertions(+), 8 deletions(-)
New commits:
commit 8cce65b1460582b9275ea0f982a61a9f621868b2
Author: Michael Meeks michael.me...@suse.com
Date: Fri Oct 21 15:47:23 2011 +0100
gtk3: caveats on using g_main_prepare for older glibs; needs re-work
diff --git a/vcl/unx/gtk/app/gtkinst.cxx b/vcl/unx/gtk/app/gtkinst.cxx
index b5b70c0..67b480d 100644
--- a/vcl/unx/gtk/app/gtkinst.cxx
+++ b/vcl/unx/gtk/app/gtkinst.cxx
@@ -585,17 +585,31 @@ void GtkInstance::Yield( bool bWait, bool
bHandleAllCurrentEvents )
bool GtkInstance::IsTimerExpired()
{
gint nPriority;
+bool bRet = false;
GMainContext *pCtx = g_main_context_default();
-// sets time_is_fresh to FALSE
-if( !g_main_context_prepare( pCtx, nPriority ) )
-return false;
-for( std::vectorGtkSalTimer *::iterator it = m_aTimers.begin();
- it != m_aTimers.end(); ++it )
+
+if( !g_main_context_acquire( pCtx ) )
+return false; // some other thread is waiting still ...
+
+// FIXME: we need to re-work this to do our own timeouts to avoid
+// warnings from older glib's about poll_waiting etc.
+
+// sets GMainContext's time_is_fresh to FALSE
+if( g_main_context_prepare( pCtx, nPriority ) )
{
-if( (*it)-Expired() )
-return true;
+for( std::vectorGtkSalTimer *::iterator it = m_aTimers.begin();
+ it != m_aTimers.end(); ++it )
+{
+if( (*it)-Expired() )
+{
+bRet = true;
+break;
+}
+}
}
-return false;
+g_main_context_release( pCtx );
+
+return bRet;
}
bool GtkInstance::AnyInput( sal_uInt16 nType )
commit 23145073c79c1313b20ad21a4bc1e0e39550e666
Author: Michael Meeks michael.me...@suse.com
Date: Fri Oct 21 15:27:17 2011 +0100
gtk3: add some missing SolarMutexGuards (thanks to mst for noticing)
diff --git a/vcl/unx/gtk/a11y/atkwindow.cxx b/vcl/unx/gtk/a11y/atkwindow.cxx
index 2cedf59..6970f0d 100644
--- a/vcl/unx/gtk/a11y/atkwindow.cxx
+++ b/vcl/unx/gtk/a11y/atkwindow.cxx
@@ -30,6 +30,7 @@
#include precompiled_vcl.hxx
#include unx/gtk/gtkframe.hxx
+#include vcl/svapp.hxx
#include vcl/window.hxx
#include vcl/popupmenuwindow.hxx
@@ -131,6 +132,7 @@ init_from_window( AtkObject *accessible, Window *pWindow )
static gint
ooo_window_wrapper_clear_focus(gpointer)
{
+SolarMutexGuard aGuard;
atk_focus_tracker_notify( NULL );
return FALSE;
}
diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index ad417f1..b50f859 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -880,6 +880,7 @@ gboolean GtkData::userEventFn( gpointer data )
extern C {
static gboolean call_userEventFn( void *data )
{
+SolarMutexGuard aGuard;
return GtkData::userEventFn( data );
}
}
diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index 3ab7840..87d1f49 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -3219,6 +3219,8 @@ gboolean GtkSalFrame::signalFocus( GtkWidget*,
GdkEventFocus* pEvent, gpointer f
extern C {
gboolean implDelayedFullScreenHdl (void *pWindow)
{
+SolarMutexGuard aGuard;
+
/* #i110881# workaround a gtk issue (see
https://bugzilla.redhat.com/show_bug.cgi?id=623191#c8)
gtk_window_fullscreen can fail due to a race condition,
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 6 commits - offapi/UnoApi_offapi.mk offapi/UnoApi_types.mk oovbaapi/UnoApi_oovbaapi.mk solenv/gbuild udkapi/UnoApi_udkapi.mk udkapi/UnoApi_uretypes.mk writerfilter/source
offapi/UnoApi_offapi.mk |2 offapi/UnoApi_types.mk|2 oovbaapi/UnoApi_oovbaapi.mk |2 solenv/gbuild/CustomTarget.mk |4 - solenv/gbuild/LinkTarget.mk | 58 +- solenv/gbuild/UnoApiTarget.mk | 17 +-- solenv/gbuild/extensions/final_ObjectOwner.mk | 47 - udkapi/UnoApi_udkapi.mk |2 udkapi/UnoApi_uretypes.mk |2 writerfilter/source/Makefile | 26 +++ 10 files changed, 65 insertions(+), 97 deletions(-) New commits: commit c955cce91f21e6381f9d17b83c73671ad135d791 Author: Michael Stahl mst...@redhat.com Date: Fri Oct 21 20:14:52 2011 +0200 LinkTarget: remove old object owner implementation diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk index f9c9917..345fd4f 100644 --- a/solenv/gbuild/LinkTarget.mk +++ b/solenv/gbuild/LinkTarget.mk @@ -347,8 +347,6 @@ gb_AsmObject_AsmObject = # LinkTarget class gb_LinkTarget_DEFAULTDEFS := $(gb_GLOBALDEFS) -gb_LinkTarget_OBJECTOWNER := -gb_LinkTarget_OBJECTS := # defined by platform # gb_LinkTarget_CXXFLAGS @@ -775,11 +773,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : COBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_CObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_CObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_CObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_cxxobject @@ -798,11 +791,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : CXXOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_CxxObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_CxxObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_CxxObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_objcobject @@ -821,11 +809,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : OBJCOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_ObjCObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_ObjCObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_ObjCObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_objcxxobject @@ -844,11 +827,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : OBJCXXOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_ObjCxxObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_ObjCxxObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_ObjCxxObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_asmobject @@ -866,11 +844,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : ASMOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_AsmObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_AsmObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_AsmObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_generated_c_object @@ -888,11 +861,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : GENCOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_GenCObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_GenCObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_GenCObject_get_target,$(2)) -endif - endef define gb_LinkTarget_add_generated_cxx_object @@ -910,11 +878,6 @@ $(call gb_LinkTarget_get_dep_target,$(1)) : GENCXXOBJECTS += $(2) $(call gb_LinkTarget_get_dep_target,$(1)) : $(call gb_GenCxxObject_get_dep_target,$(2)) endif -ifeq ($(gb_CHECKOBJECTOWNER),$(true)) -gb_LinkTarget_OBJECTOWNER += $(call gb_GenCxxObject_get_target,$(2)):$(1) -gb_LinkTarget_OBJECTS += $(call gb_GenCxxObject_get_target,$(2)) -endif - endef define gb_LinkTarget_yacc_add_cpp_dep diff --git a/solenv/gbuild/extensions/final_ObjectOwner.mk b/solenv/gbuild/extensions/final_ObjectOwner.mk deleted file mode 100644 index f66a7a2..000 --- a/solenv/gbuild/extensions/final_ObjectOwner.mk +++ /dev/null @@ -1,47 +0,0 @@ -# Version: MPL 1.1 / GPLv3+ / LGPLv3+ -# -# The contents of this file are subject to the Mozilla Public License Version -# 1.1 (the License); you may not use this file except in compliance with -# the License or as specified alternatively below. You may obtain a copy of -# the License at http://www.mozilla.org/MPL/ -# -# Software distributed under the License is distributed on an AS IS basis, -# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License -# for the specific language governing rights and limitations under the -# License. -# -# The Initial
[Libreoffice-commits] .: sc/inc
sc/inc/orcus/csv_parser.hpp | 134
1 file changed, 110 insertions(+), 24 deletions(-)
New commits:
commit ea44e5464a487519de84e30a5f299387127c78ea
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Fri Oct 21 13:32:49 2011 -0400
Updated csv parser from the orcus repository.
This change should allow handling double-quation inside quoted cells
correctly.
diff --git a/sc/inc/orcus/csv_parser.hpp b/sc/inc/orcus/csv_parser.hpp
index cc23374..8d119f9 100644
--- a/sc/inc/orcus/csv_parser.hpp
+++ b/sc/inc/orcus/csv_parser.hpp
@@ -1,4 +1,3 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
*
* Copyright (c) 2011 Kohei Yoshida
@@ -76,8 +75,10 @@ public:
private:
bool has_char() const { return m_pos m_length; }
+bool has_next() const { return m_pos + 1 m_length; }
void next();
char cur_char() const;
+char next_char() const;
bool is_delim(char c) const;
bool is_text_qualifier(char c) const;
@@ -87,8 +88,12 @@ private:
void cell();
void quoted_cell();
+void parse_cell_with_quote(const char* p0, size_t len0);
void skip_blanks();
+void init_cell_buf();
+void append_to_cell_buf(const char* p, size_t len);
+
/**
* Push cell value to the handler.
*/
@@ -102,9 +107,11 @@ private:
private:
handler_type m_handler;
const csv_parser_config m_config;
+std::string m_cell_buf;
const char* mp_char;
size_t m_pos;
size_t m_length;
+size_t m_cell_buf_size;
};
templatetypename _Handler
@@ -141,6 +148,12 @@ char csv_parser_Handler::cur_char() const
}
templatetypename _Handler
+char csv_parser_Handler::next_char() const
+{
+return *(mp_char+1);
+}
+
+templatetypename _Handler
bool csv_parser_Handler::is_delim(char c) const
{
return m_config.delimiters.find(c) != std::string::npos;
@@ -210,42 +223,99 @@ void csv_parser_Handler::cell()
templatetypename _Handler
void csv_parser_Handler::quoted_cell()
{
+#if ORCUS_DEBUG_CSV
+using namespace std;
+cout --- quoted cell endl;
+#endif
char c = cur_char();
assert(is_text_qualifier(c));
next(); // Skip the opening quote.
if (!has_char())
return;
-const char* p = mp_char;
-size_t len = 0;
-for (c = cur_char(); !is_text_qualifier(c); c = cur_char())
+const char* p0 = mp_char;
+size_t len = 1;
+for (; has_char(); next(), ++len)
{
-++len;
-next();
-if (!has_char())
+c = cur_char();
+#if ORCUS_DEBUG_CSV
+cout ' c ' endl;
+#endif
+if (!is_text_qualifier(c))
+continue;
+
+// current char is a quote. Check if the next char is also a text
+// qualifier.
+
+if (has_next() is_text_qualifier(next_char()))
{
-// Stream ended prematurely. Handle it gracefully.
-push_cell_value(p, len);
+next();
+parse_cell_with_quote(p0, len);
return;
}
+
+// Closing quote.
+push_cell_value(p0, len-1);
+next();
+skip_blanks();
+return;
}
-assert(is_text_qualifier(c));
-next(); // Skip the closing quote.
+// Stream ended prematurely. Handle it gracefully.
+push_cell_value(p0, len);
+next();
skip_blanks();
-c = cur_char();
-if (!is_delim(c) c != '\n')
+}
+
+templatetypename _Handler
+void csv_parser_Handler::parse_cell_with_quote(const char* p0, size_t len0)
+{
+#if ORCUS_DEBUG_CSV
+using namespace std;
+cout --- parse cell with quote endl;
+#endif
+assert(is_text_qualifier(cur_char()));
+
+// Push the preceding chars to the temp buffer.
+init_cell_buf();
+append_to_cell_buf(p0, len0);
+
+// Parse the rest, until the closing quote.
+next();
+const char* p_cur = mp_char;
+size_t cur_len = 0;
+for (; has_char(); next(), ++cur_len)
{
-std::ostringstream os;
-os A quoted cell value must be immediately followed by a
delimiter. ;
-os ' c ' is found instead.;
-throw csv_parse_error(os.str());
-}
+char c = cur_char();
+#if ORCUS_DEBUG_CSV
+cout ' c ' endl;
+#endif
+if (!is_text_qualifier(c))
+continue;
-if (!len)
-p = NULL;
+if (has_next() is_text_qualifier(next_char()))
+{
+// double quotation. Copy the current segment to the cell buffer.
+append_to_cell_buf(p_cur, cur_len);
-push_cell_value(p, len);
+next(); // to the 2nd quote.
+p_cur = mp_char;
+cur_len = 0;
+continue;
+}
+
+// closing quote. Flush the current segment to the cell
+// buffer, push the value to the handler, and exit normally.
+append_to_cell_buf(p_cur, cur_len);
+
[Libreoffice-commits] .: 2 commits - binfilter/bf_svtools binfilter/bf_svx binfilter/inc
binfilter/bf_svtools/source/filter.vcl/filter/svt_filter.cxx |6 +-
binfilter/bf_svx/source/svdraw/svx_svdomeas.cxx |6 +++---
binfilter/bf_svx/source/svdraw/svx_svdotext.cxx | 10 +-
binfilter/inc/bf_svx/svdomeas.hxx|6 +++---
binfilter/inc/bf_svx/svdotext.hxx|4 ++--
5 files changed, 14 insertions(+), 18 deletions(-)
New commits:
commit a7ba481a04be4c05ea17d6fbdf200a61e04550ab
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Oct 21 21:26:09 2011 +0200
Some more warning cleanup.
diff --git a/binfilter/bf_svx/source/svdraw/svx_svdomeas.cxx
b/binfilter/bf_svx/source/svdraw/svx_svdomeas.cxx
index 674c47e..e55e6ef 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdomeas.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdomeas.cxx
@@ -796,11 +796,11 @@ namespace binfilter {
/*N*/ if (pOutlinerParaObject==NULL) SetTextDirty(); // Text neu berechnen!
/*N*/ }
-/*N*/ void SdrMeasureObj::TakeTextRect( SdrOutliner rOutliner, Rectangle
rTextRect, bool bNoEditText,
-/*N*/ Rectangle* pAnchorRect, BOOL bLineWidth ) const
+/*N*/ void SdrMeasureObj::TakeTextRect( SdrOutliner rOutliner, Rectangle
rTextRect,
+/*N*/ Rectangle* pAnchorRect ) const
/*N*/ {
/*N*/ if (bTextDirty) UndirtyText();
-/*N*/ SdrTextObj::TakeTextRect( rOutliner, rTextRect, bNoEditText,
pAnchorRect, bLineWidth );
+/*N*/ SdrTextObj::TakeTextRect( rOutliner, rTextRect, pAnchorRect );
/*N*/ }
/*N*/ void SdrMeasureObj::TakeTextAnchorRect(Rectangle rAnchorRect) const
diff --git a/binfilter/bf_svx/source/svdraw/svx_svdotext.cxx
b/binfilter/bf_svx/source/svdraw/svx_svdotext.cxx
index baca551..ad5268e 100644
--- a/binfilter/bf_svx/source/svdraw/svx_svdotext.cxx
+++ b/binfilter/bf_svx/source/svdraw/svx_svdotext.cxx
@@ -424,8 +424,8 @@ inline double ImplMMToTwips(double fVal) { return (fVal *
(72.0 / 127.0)); }
/*N*/ rAnchorRect=aAnkRect;
/*N*/ }
-/*N*/ void SdrTextObj::TakeTextRect( SdrOutliner rOutliner, Rectangle
rTextRect, bool bNoEditText,
-/*N*/ Rectangle* pAnchorRect, BOOL /*bLineWidth*/
) const
+/*N*/ void SdrTextObj::TakeTextRect( SdrOutliner rOutliner, Rectangle
rTextRect,
+/*N*/ Rectangle* pAnchorRect ) const
/*N*/ {
/*N*/ Rectangle aAnkRect; // Rect innerhalb dem geankert wird
/*N*/ TakeTextAnchorRect(aAnkRect);
@@ -615,7 +615,7 @@ inline double ImplMMToTwips(double fVal) { return (fVal *
(72.0 / 127.0)); }
/*N*/ SdrOutliner rOutliner=ImpGetDrawOutliner();
/*N*/ Rectangle aTextRect;
/*N*/ Rectangle aAnchorRect;
-/*N*/ TakeTextRect(rOutliner,aTextRect,TRUE,aAnchorRect); //
EditText ignorieren!
+/*N*/ TakeTextRect(rOutliner,aTextRect,aAnchorRect); //
EditText ignorieren!
/*N*/ SdrFitToSizeType eFit=GetFitToSize();
/*N*/ bool bFitToSize=(eFit==SDRTEXTFIT_PROPORTIONAL ||
eFit==SDRTEXTFIT_ALLLINES);
/*N*/ if (bFitToSize) aTextRect=aAnchorRect;
@@ -652,7 +652,7 @@ inline double ImplMMToTwips(double fVal) { return (fVal *
(72.0 / 127.0)); }
/*N*/ }
/*N*/ else
/*N*/ {
-/*N*/ TakeTextRect( *pOutliner, aTextRect, FALSE, aLclAnchor, FALSE );
// EditText nicht mehr ignorieren! TRUE); // EditText ignorieren!
+/*N*/ TakeTextRect( *pOutliner, aTextRect, aLclAnchor ); // EditText
nicht mehr ignorieren! TRUE); // EditText ignorieren!
/*N*/
/*N*/ if (bFitToSize)
/*?*/ aR=aLclAnchor;
@@ -761,7 +761,7 @@ inline double ImplMMToTwips(double fVal) { return (fVal *
(72.0 / 127.0)); }
/*N*/ if (pOutlinerParaObject!=NULL !IsFontwork()
!IsContourTextFrame()) {
/*?*/ Rectangle aLclAnchor;
/*?*/ Rectangle aR;
-/*?*/ TakeTextRect(rOutliner,aR,FALSE,aLclAnchor);
+/*?*/ TakeTextRect(rOutliner,aR,aLclAnchor);
/*?*/ rOutliner.Clear();
/*?*/ SdrFitToSizeType eFit=GetFitToSize();
/*?*/ bool bFitToSize=(eFit==SDRTEXTFIT_PROPORTIONAL ||
eFit==SDRTEXTFIT_ALLLINES);
diff --git a/binfilter/inc/bf_svx/svdomeas.hxx
b/binfilter/inc/bf_svx/svdomeas.hxx
index f40d10e..73798d9 100644
--- a/binfilter/inc/bf_svx/svdomeas.hxx
+++ b/binfilter/inc/bf_svx/svdomeas.hxx
@@ -87,11 +87,11 @@ public:
virtual void NbcSetPoint(const Point rPnt, USHORT i);
-virtual bool BegTextEdit(SdrOutliner rOutl) { return false; } //
DBG_BF_ASSERT
+virtual bool BegTextEdit(SdrOutliner) { return false; } // DBG_BF_ASSERT
virtual void EndTextEdit(SdrOutliner rOutl);
virtual const Size GetTextSize() const;
-virtual void TakeTextRect( SdrOutliner rOutliner, Rectangle rTextRect,
bool bNoEditText=FALSE,
-Rectangle* pAnchorRect=NULL, BOOL bLineWidth=TRUE ) const;
+virtual void TakeTextRect( SdrOutliner rOutliner, Rectangle rTextRect,
+Rectangle* pAnchorRect ) const;
virtual void TakeTextAnchorRect(Rectangle rAnchorRect) const;
[Libreoffice-commits] .: 13 commits - GNUmakefile.mk rsc/Executable_rsc.mk solenv/gbuild
GNUmakefile.mk |2 rsc/Executable_rsc.mk |4 solenv/gbuild/AllLangResTarget.mk | 31 +- solenv/gbuild/BuildDirs.mk | 19 --- solenv/gbuild/ComponentTarget.mk| 23 +--- solenv/gbuild/ExternalLib.mk|6 - solenv/gbuild/LinkTarget.mk | 136 +--- solenv/gbuild/TargetLocations.mk|7 - solenv/gbuild/UnoApiTarget.mk | 12 -- solenv/gbuild/WinResTarget.mk |6 - solenv/gbuild/extensions/post_SetupLocal.mk | 68 -- solenv/gbuild/gbuild.mk |8 + solenv/gbuild/platform/ios.mk |4 solenv/gbuild/platform/macosx.mk|6 - solenv/gbuild/platform/unxgcc.mk|4 solenv/gbuild/platform/windows.mk |4 solenv/gbuild/platform/winmingw.mk |4 17 files changed, 100 insertions(+), 244 deletions(-) New commits: commit 7bf06ba95d6ba0e673f2aff5b4412dbf08702590 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Fri Oct 21 21:08:47 2011 +0200 rename YaccObject to YaccTarget the object is a GenCxxObject just like those from CustomTargets, we only need to get the generation right diff --git a/rsc/Executable_rsc.mk b/rsc/Executable_rsc.mk index 058dfd7..e1ed345 100644 --- a/rsc/Executable_rsc.mk +++ b/rsc/Executable_rsc.mk @@ -34,7 +34,7 @@ $(eval $(call gb_Executable_set_include,rsc,\ $$(INCLUDE) \ -I$(SRCDIR)/rsc/inc \ -I$(SRCDIR)/rsc/inc/pch \ - -I$(WORKDIR)/YaccObject/rsc/source/parser \ + -I$(WORKDIR)/YaccTarget/rsc/source/parser \ )) $(eval $(call gb_Executable_add_api,rsc,\ @@ -58,7 +58,7 @@ $(eval $(call gb_Executable_add_grammars,rsc,\ rsc/source/parser/rscyacc \ )) -$(call gb_YaccObject_get_target,rsc/source/parser/rscyacc): T_CXXFLAGS := $(gb_LinkTarget_EXCEPTIONFLAGS) $(gb_LinkTarget_CXXFLAGS) $(CXXFLAGS) +$(call gb_YaccTarget_get_target,rsc/source/parser/rscyacc): T_CXXFLAGS := $(gb_LinkTarget_EXCEPTIONFLAGS) $(gb_LinkTarget_CXXFLAGS) $(CXXFLAGS) $(eval $(call gb_Executable_add_exception_objects,rsc,\ rsc/source/parser/erscerr \ diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk index bbaa479..271ce81 100644 --- a/solenv/gbuild/LinkTarget.mk +++ b/solenv/gbuild/LinkTarget.mk @@ -224,25 +224,25 @@ endif gb_GenCxxObject_GenCxxObject = -# YaccObject class -gb_YaccObject_get_source = $(1)/$(2).y +# YaccTarget class +gb_YaccTarget_get_source = $(1)/$(2).y -.PHONY : $(call gb_YaccObject_get_clean_target,%) -$(call gb_YaccObject_get_clean_target,%) : +.PHONY : $(call gb_YaccTarget_get_clean_target,%) +$(call gb_YaccTarget_get_clean_target,%) : $(call gb_Output_announce,$(2),$(false),YAC,3) $(call gb_Helper_abbreviate_dirs,\ - rm -f $(call gb_YaccObject_get_header_target,$*) $(call gb_YaccObject_get_target,$*)) + rm -f $(call gb_YaccTarget_get_header_target,$*) $(call gb_YaccTarget_get_target,$*)) -$(call gb_YaccObject_get_target,%) : $(call gb_YaccObject_get_source,$(SRCDIR),%) - $(call gb_YaccObject__command,$,$*,$@,$(call gb_YaccObject_get_header_target,$*)) +$(call gb_YaccTarget_get_target,%) : $(call gb_YaccTarget_get_source,$(SRCDIR),%) + $(call gb_YaccTarget__command,$,$*,$@,$(call gb_YaccTarget_get_header_target,$*)) -gb_YaccObject_YaccObject = +gb_YaccTarget_YaccTarget = gb_YACC := bison -# YaccObject class +# YaccTarget class # defined by platform -# gb_YaccObject__command(grammar-file, stem-for-message, source-target, include-target) +# gb_YaccTarget__command(grammar-file, stem-for-message, source-target, include-target) # ObjCxxObject class # @@ -852,13 +852,13 @@ endef # Add a bison grammar to the build. # gb_LinkTarget_add_grammar(component,grammar file) define gb_LinkTarget_add_grammar -$(call gb_LinkTarget_add_generated_cxx_object,$(1),YaccObject/$(2)) -$(call gb_LinkTarget_get_clean_target,$(1)) : $(call gb_YaccObject_get_clean_target,$(2)) -$(call gb_LinkTarget__add_internal_headers,$(1),$(call gb_YaccObject_get_header_target,$(2))) +$(call gb_LinkTarget_add_generated_cxx_object,$(1),YaccTarget/$(2)) +$(call gb_LinkTarget_get_clean_target,$(1)) : $(call gb_YaccTarget_get_clean_target,$(2)) +$(call gb_LinkTarget__add_internal_headers,$(1),$(call gb_YaccTarget_get_header_target,$(2))) endef -#$(call gb_YaccObject_YaccObject,$(2)) +#$(call gb_YaccTarget_YaccTarget,$(2)) # Add bison grammars to the build. # gb_LinkTarget_add_grammars(component,grammar file [grammar file*]) diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk index e602a37..9205d44 100644 --- a/solenv/gbuild/TargetLocations.mk +++ b/solenv/gbuild/TargetLocations.mk @@ -125,8 +125,8 @@ gb_UnoApiTarget_get_header_target = $(WORKDIR)/UnoApiHeaders/$(1) gb_WinResTarget_get_target =
[Libreoffice-commits] .: editeng/source formula/source sc/source sd/source svtools/source sw/source vcl/aqua vcl/inc vcl/unx vcl/win
editeng/source/editeng/editeng.cxx |2 +-
editeng/source/editeng/impedit3.cxx |2 +-
formula/source/ui/dlg/formula.cxx|4 ++--
sc/source/core/tool/chartlis.cxx |2 +-
sc/source/ui/app/scmod.cxx |2 +-
sd/source/ui/tools/IdleDetection.cxx |2 +-
svtools/source/control/inettbc.cxx |2 +-
svtools/source/edit/textview.cxx |2 +-
sw/source/core/layout/paintfrm.cxx |2 +-
sw/source/core/view/viewsh.cxx |2 +-
sw/source/ui/docvw/edtwin.cxx|2 +-
vcl/aqua/source/app/salinst.cxx |4 ++--
vcl/inc/vcl/apptypes.hxx |6 +++---
vcl/unx/generic/app/salinst.cxx |4 ++--
vcl/win/source/app/salinst.cxx |2 +-
15 files changed, 20 insertions(+), 20 deletions(-)
New commits:
commit b0224f8050373cbdde58c3dee1bbda71976b50b6
Author: Olivier Hallot olivier.hal...@alta.org.br
Date: Fri Oct 21 16:54:35 2011 -0200
Fix for bug fdo#41997, cleanup vcl enumeration
diff --git a/editeng/source/editeng/editeng.cxx
b/editeng/source/editeng/editeng.cxx
index 5d745c0..573b30b 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1195,7 +1195,7 @@ sal_Bool EditEngine::PostKeyEvent( const KeyEvent
rKeyEvent, EditView* pEditVie
DBG_ASSERT( !bReadOnly, ReadOnly but modified??? );
// Idle-Formatter only when AnyInput.
if ( bAllowIdle pImpEditEngine-GetStatus().UseIdleFormatter()
- Application::AnyInput( INPUT_KEYBOARD) )
+ Application::AnyInput( VCL_INPUT_KEYBOARD) )
pImpEditEngine-IdleFormatAndUpdate( pEditView );
else
pImpEditEngine-FormatAndUpdate( pEditView );
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index b4efe14..8f059a3 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -327,7 +327,7 @@ void ImpEditEngine::UpdateViews( EditView* pCurView )
IMPL_LINK( ImpEditEngine, OnlineSpellHdl, Timer *, EMPTYARG )
{
-if ( !Application::AnyInput( INPUT_KEYBOARD ) GetUpdateMode()
IsFormatted() )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) GetUpdateMode()
IsFormatted() )
DoOnlineSpelling();
else
aOnlineSpellTimer.Start();
diff --git a/formula/source/ui/dlg/formula.cxx
b/formula/source/ui/dlg/formula.cxx
index 97ef663..3b7c2ec 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -592,7 +592,7 @@ sal_Bool FormulaDlg_Impl::CalcValue( const String rStrExp,
String rStrResult )
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
bResult = m_pHelper-calculateValue(rStrExp,rStrResult);
}
@@ -630,7 +630,7 @@ sal_Bool FormulaDlg_Impl::CalcStruct( const String rStrExp)
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
pStructPage-ClearStruct();
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 8c52fe4..6f9129d 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -567,7 +567,7 @@ void ScChartListenerCollection::StartTimer()
IMPL_LINK( ScChartListenerCollection, TimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aTimer.Start();
return 0;
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 7932fca..b4284e7 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1877,7 +1877,7 @@ IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aSpellTimer.Start();
return 0; // dann spaeter wieder...
diff --git a/sd/source/ui/tools/IdleDetection.cxx
b/sd/source/ui/tools/IdleDetection.cxx
index 4ba6163..e0fba1a 100644
--- a/sd/source/ui/tools/IdleDetection.cxx
+++ b/sd/source/ui/tools/IdleDetection.cxx
@@ -59,7 +59,7 @@ sal_Int32 IdleDetection::GetIdleState (const ::Window*
pWindow)
sal_Int32 IdleDetection::CheckInputPending (void)
{
-if (GetpApp()-AnyInput(INPUT_MOUSE | INPUT_KEYBOARD | INPUT_PAINT))
+if (GetpApp()-AnyInput(VCL_INPUT_MOUSE | VCL_INPUT_KEYBOARD |
INPUT_PAINT))
return IDET_SYSTEM_EVENT_PENDING;
else
return IDET_IDLE;
diff --git a/svtools/source/control/inettbc.cxx
b/svtools/source/control/inettbc.cxx
index 50739d8..097a8ad 100644
--- a/svtools/source/control/inettbc.cxx
+++
[Libreoffice-commits] .: basic/CppunitTest_basic_scanner.mk
basic/CppunitTest_basic_scanner.mk |1 - 1 file changed, 1 deletion(-) New commits: commit fa2c0b7a647bbc3465cfd0daed82b855284b4791 Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 21 21:14:48 2011 +0100 remove erroneous sfx dependency (thank you Stefan) diff --git a/basic/CppunitTest_basic_scanner.mk b/basic/CppunitTest_basic_scanner.mk index 0e18e51..0c9e657 100644 --- a/basic/CppunitTest_basic_scanner.mk +++ b/basic/CppunitTest_basic_scanner.mk @@ -14,7 +14,6 @@ $(eval $(call gb_CppunitTest_add_linked_libs,basic_scanner, \ sal \ salhelper \ sb \ -sfx \ sot \ svl \ svt \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: binfilter/bf_sc
binfilter/bf_sc/source/core/tool/sc_chartlis.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 910838ecc9e64e89ebc0519dc3524824a687a3a6
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Oct 21 22:47:36 2011 +0200
Adapted to renamed VCL_INPUT_KEYBOARD.
diff --git a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
index f6186d7..a2f33eb 100644
--- a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
+++ b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
@@ -274,7 +274,7 @@ using namespace ::com::sun::star;
/*N*/ IMPL_LINK( ScChartListenerCollection, TimerHdl, Timer*, EMPTYARG )
/*N*/ {
-/*N*/ if ( Application::AnyInput( INPUT_KEYBOARD ) )
+/*N*/ if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
/*N*/ {
/*?*/ aTimer.Start();
/*?*/ return 0;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/LinkTarget.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 8c86c64f22b0dfef3cc502f59f509e20c1f5643c Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Fri Oct 21 23:44:20 2011 +0200 restore accidentally removed line diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk index 271ce81..fc58e4d 100644 --- a/solenv/gbuild/LinkTarget.mk +++ b/solenv/gbuild/LinkTarget.mk @@ -247,6 +247,7 @@ gb_YACC := bison # ObjCxxObject class # +gb_ObjCxxObject_get_source = $(1)/$(2).mm # defined by platform # gb_ObjCxxObject__command ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: extensions/CppunitTest_extensions_test_update.mk extensions/qa Repository.mk
Repository.mk|1
extensions/CppunitTest_extensions_test_update.mk |9 +++
extensions/qa/update/test_update.cxx | 53 +++
3 files changed, 54 insertions(+), 9 deletions(-)
New commits:
commit 44d5b6c595f5f3bdf4eb923289da1bb0195e29d0
Author: Jan Holesovsky ke...@suse.cz
Date: Sat Oct 22 01:11:01 2011 +0200
Make the update unit test compile.
It is not useful yet, so disabled.
diff --git a/Repository.mk b/Repository.mk
index 01a93d9..a723436 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -266,6 +266,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \
avmediagst \
avmediawin \
collator_data \
+ curl \
deployment \
deploymentgui \
dict_ja \
diff --git a/extensions/CppunitTest_extensions_test_update.mk
b/extensions/CppunitTest_extensions_test_update.mk
index b5703c0..54f72ce 100644
--- a/extensions/CppunitTest_extensions_test_update.mk
+++ b/extensions/CppunitTest_extensions_test_update.mk
@@ -28,18 +28,27 @@
$(eval $(call gb_CppunitTest_CppunitTest,extensions_test_update))
$(eval $(call gb_CppunitTest_add_exception_objects,extensions_test_update, \
+ extensions/source/update/check/download \
+ extensions/source/update/check/updatecheck \
+ extensions/source/update/check/updatecheckconfig \
+ extensions/source/update/check/updatehdl \
+ extensions/source/update/check/updateprotocol \
+ \
extensions/qa/update/test_update \
))
$(eval $(call gb_CppunitTest_add_linked_libs,extensions_test_update, \
cppu \
cppuhelper \
+ curl \
sal \
$(gb_STDLIBS) \
))
$(eval $(call gb_CppunitTest_set_include,extensions_test_update,\
$$(INCLUDE) \
+ -I$(realpath $(SRCDIR)/extensions/inc) \
+ -I$(realpath $(SRCDIR)/extensions/inc/pch) \
-I$(OUTDIR)/inc \
))
diff --git a/extensions/qa/update/test_update.cxx
b/extensions/qa/update/test_update.cxx
index d60e59e..cf44093 100644
--- a/extensions/qa/update/test_update.cxx
+++ b/extensions/qa/update/test_update.cxx
@@ -33,28 +33,63 @@
#include cppunit/extensions/HelperMacros.h
#include cppunit/plugin/TestPlugIn.h
+#include cppuhelper/bootstrap.hxx
+
+#include com/sun/star/deployment/UpdateInformationProvider.hpp
+#include com/sun/star/lang/XComponent.hpp
+#include com/sun/star/uno/XComponentContext.hpp
+
+#include ../../source/update/check/updatecheck.hxx
+#include ../../source/update/check/updateprotocol.hxx
+
+using namespace com::sun::star;
+
namespace testupdate {
-class test : public CppUnit::TestFixture
+class Test : public CppUnit::TestFixture
{
public:
-void setUp() {}
+void setUp()
+{
+if (!m_xContext.is())
+m_xContext = cppu::defaultBootstrap_InitialComponentContext();
+}
-void tearDown() {}
+void tearDown()
+{
+uno::Reference lang::XComponent ( m_xContext,
uno::UNO_QUERY_THROW)-dispose();
+}
protected:
-// setup test checkForUpdates() method
-void testUpdateCheck()
+// test the checkForUpdates() method
+void testCheckForUpdates()
{
-//CPPUNIT_FAIL( This has to be populated with the real test... );
+UpdateState eUIState = UPDATESTATE_NO_UPDATE_AVAIL;
+
+UpdateInfo aInfo;
+rtl::Reference UpdateCheck aController( UpdateCheck::get() );
+uno::Reference deployment::XUpdateInformationProvider m_xProvider(
deployment::UpdateInformationProvider::create( m_xContext ) );
+
+if ( checkForUpdates( aInfo, m_xContext,
aController-getInteractionHandler(), m_xProvider ) )
+{
+aController-setUpdateInfo( aInfo );
+eUIState = aController-getUIState( aInfo );
+}
+else
+CPPUNIT_FAIL(Calling checkForUpdates() failed.);
}
-CPPUNIT_TEST_SUITE(test);
-CPPUNIT_TEST(testUpdateCheck);
+CPPUNIT_TEST_SUITE(Test);
+// FIXME CPPUNIT_TEST(testCheckForUpdates);
CPPUNIT_TEST_SUITE_END();
+
+private:
+static uno::Reference uno::XComponentContext m_xContext;
};
-CPPUNIT_TEST_SUITE_REGISTRATION(testupdate::test);
+uno::Reference uno::XComponentContext Test::m_xContext;
+
+CPPUNIT_TEST_SUITE_REGISTRATION(testupdate::Test);
} // namespace testupdate
CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/CppunitTest_sc_filters_test.mk sw/CppunitTest_sw_filters_test.mk
sc/CppunitTest_sc_filters_test.mk |1 + sw/CppunitTest_sw_filters_test.mk |1 + 2 files changed, 2 insertions(+) New commits: commit 63354873b7e2fb9e51abee45082e415cd438d8b2 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sat Oct 22 00:04:31 2011 +0200 execute filters-test in headless mode diff --git a/sc/CppunitTest_sc_filters_test.mk b/sc/CppunitTest_sc_filters_test.mk index 38f013b..e40ae2e 100644 --- a/sc/CppunitTest_sc_filters_test.mk +++ b/sc/CppunitTest_sc_filters_test.mk @@ -97,6 +97,7 @@ $(eval $(call gb_CppunitTest_add_service_rdbs,sc_filters_test,\ )) $(eval $(call gb_CppunitTest_set_args,sc_filters_test,\ +--headless \ --protector unoexceptionprotector$(gb_Library_DLLEXT) unoexceptionprotector \ -env:OOO_CONFIG_REGISTRY_DIR=$(call gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry) \ )) diff --git a/sw/CppunitTest_sw_filters_test.mk b/sw/CppunitTest_sw_filters_test.mk index 7726115..68087df 100644 --- a/sw/CppunitTest_sw_filters_test.mk +++ b/sw/CppunitTest_sw_filters_test.mk @@ -85,6 +85,7 @@ $(eval $(call gb_CppunitTest_add_service_rdbs,sw_filters_test,\ )) $(eval $(call gb_CppunitTest_set_args,sw_filters_test,\ +--headless \ --protector unoexceptionprotector$(gb_Library_DLLEXT) unoexceptionprotector \ )) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
Interestingly enough there seem to be two definitions for the frac function. Your implementation is the one seemingly used by all programming languages, which implement it. But the correct mathematical definition seems to be y = x - floor(x) (http://mathworld.wolfram.com/FractionalPart.html), which gives different values for positive and negative numbers. Other than that I believe the patch is fine. Greetings eymux On Fri, Oct 21, 2011 at 5:19 AM, August Sodora aug...@gmail.com wrote: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? August Sodora aug...@gmail.com (201) 280-8138 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config register toolbar controller in adddon
Hi why? is it impossible to configure a custom toolbar in addon using controller.xcu ? and how to get it work in my addon? does OOO provides an API to give advanced custom toolbar configuration in a addon. can someone help on this please? you may have a look at the sdk, there are some example of custom toolbar /sdk/examples/cpp/complextoolbarcontrols/ IIRC, Noel did some presentation about it at Paris HTH Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
On 10/21/2011 02:06 AM, Kevin Hunter wrote: At 4:52pm -0400 Thu, 20 Oct 2011, Michael Meeks wrote: http://wiki.documentfoundation.org/Development/LibreOffice4 + getting stuck into Windows / mingw build etc. From the wiki page, one of the concerns is binary incompatibility. I assume this is in reference to extensions? Question: is there merit to moving toward an enforced sub-process model for extensions? My first thought is that this would do a couple of things: [...] 5. That API definition will be a *lot* of work, but hopefully somewhat thought out already through only a mild reengineering of the current binary API. The UNO API is already there. Or what do you mean? [...] The upside is that if we're talking a major version change, /now/ would be the time to do this. A downside is that you would still need to maintain (and build!) the UNO runtime for the MSVC ABI. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Python on Windows
On 10/21/2011 01:20 AM, Miklos Vajna wrote: On Thu, Oct 20, 2011 at 11:21:52PM +0200, Stephan Bergmannsberg...@redhat.com wrote: (c) pyuno as run from an external python process might no longer work. An easy way to test that is to start the interactive python executable from the LibO program directory and execute include uno (and/or include pyuno; not sure right now which one is the more interesting, but if both work I'd guess that's good). You mean import in both cases, not include, right? Yes, sure, sorry. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Python on Windows
On Thu, 2011-10-20 at 23:21 +0200, Stephan Bergmann wrote: I must confess ... Heh :-) seems reasonable enough. Anyway, if anybody less Windows-phobic than me would like to check out whether pyuno still works on Windows, that would be great: In the past I've had similar problems with finding and testing python components, and the python3 work also subtly broke things without people noticing. What would be -really- excellent to nail this permanently would be to have a during-compile unit test that exercises pyuno, clearly getting that working on Linux first would be ideal. Which reminds me - do we not have bridge-test code for each of the bindings already ? I wonder if that is / could be cppunit-test-iszed :-) Thanks for the heads up though, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
Hi Kevin, On Thu, 2011-10-20 at 20:06 -0400, Kevin Hunter wrote: From the wiki page, one of the concerns is binary incompatibility. I assume this is in reference to extensions? Sure; of course we only export a reasonably small ABI, the 'ure' (big chunks of which are in-lined C++ methods that call SAL_CALL C functions that we havn't changed and should cross-compile nicely). The C++ helper classes (it is hoped) due to windows direct linking, and a different ABI anyway shouldn't conflict. My hope was(is) that UNO can shine here (with some tweaks) as a bridging technology between the ABIs - at some fairly minimal performance cost. At least, given Stephan's expertise a little testing, it might just work. That would of course mean shipping some duplicate legacy MSVC++ compiled libraries, but ... surely do-able. Question: is there merit to moving toward an enforced sub-process model for extensions ? It is an interesting idea; of course in theory UNO makes this easy, in reality - I would scream and run away from cross-process component usage. Debugging reference leaks / cycles / etc. is bad enough in-process, never-mind cross-process; or worse between many (external) components. 3. It would allow extensions to still be built with MSVC, regardless of what compiler the LO core project uses. It may well solve this problem of course. My experience with the debuggability and lifecycle management of the Bonobo component model (which was heavily cross-process), was really an extremely negative one, and that on Linux with really fast IPC. Naturally, if people want to write their extensions that way, they can, currently I imagine the only related grief is prolly around deployment. If you're interested in it as a model, it would prolly be worth playing with the deployment of such extensions. But of course, I personally think there is much lower hanging fruit in the calc core ;-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kubuntu Oneiric Qt4 Libraries
Hi Jonathan Em 21-10-2011 03:46, Jonathan Aquilina escreveu: On 20/10/2011 22:31, Olivier Hallot wrote: I am taking a stab in the dark here, but have you tried installing the qt4-dev-tools package? Yes, it is installed. Peeking at configure.in, it seems that the test for Qt4 Libraries is done here: ... qt_test_include=Qt/qobject.h qt_test_library=libQtCore.so kde_test_include=kwindowsystem.h kde_test_library=libsolid.so ... so looking for libQtCore.so, I found it in /usr/lib/x86_64-linux-gnu/libQtCore.so which belongs to package libqt4-dev which is installed... sad... It worked well on Natty... Must be a twaek missing. -- Olivier Hallot Founder, Steering Commitee Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
At 4:39am -0400 Fri, 21 Oct 2011, Michael Meeks wrote: [one /could/ work toward interprocess extensions ... ] But of course, I personally think there is much lower hanging fruit in the calc core ;-) Noted and agreed! I'm just sticking my nose in all things LO, probably stepping on toes as I do (sorry!). I was more posing the question that I wasn't aware had gone by. However, it sounds like y'all've already thought about that, or it's a everyone already knows this answer. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
At 4:11am -0400 Fri, 21 Oct 2011, Stephan Bergmann wrote: On 10/21/2011 02:06 AM, Kevin Hunter wrote: 5. That API definition will be a *lot* of work, but hopefully somewhat thought out already through only a mild reengineering of the current binary API. The UNO API is already there. Or what do you mean? I was talking about an API that is not dependent on an ABI. But I freely admit I know very little about ABIs, so I may have just conflated that term. See below. The upside is that if we're talking a major version change, /now/ would be the time to do this. A downside is that you would still need to maintain (and build!) the UNO runtime for the MSVC ABI. This may be the crux of what I'm not getting, but why? Why can't a protocol be, say, text-based via (local, or other) socket? In my mind, I see two independent programs, from two different compilers, using the OS and something akin to pipes to communicate. I admit it might a smidgen slower to do it that way, but do people actually use LO in HPC scenarios? (And I fully accept that they might, I just haven't seen it yet in my various interactions.) Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodora aug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to get an idea of how the scanner handles certain situations but I tried to make sure I included ones that specifically trigger where the GetBufferAccess was. Ooh ! :-) this is really nice. I was previously fooled by the subject into not noticing that this was some sexy code cleanup + unit testing patch. Lovely work ! I added a doc. header for the new sal/ method, and since I have: (setq-default show-trailing-whitespace t) in my ~/.emacs I see red warnings of trailing whitespace - so removed a bit of that. One thing I tweaked in one place is using sal_Int32 indexes into rtl::OUStrings where previously sal_uInt16 indexes were adequate, one benefit of your cleanup is that we can handler bigger scripts of course. Anyhow - a lovely job :-) I'm really looking forward to see what you touch next :-) Many thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make experts: progress information?
On Thu, 2011-10-20 at 14:20 -0400, Kevin Hunter wrote: That said, I anecdotally note on my limited-in-hardware machine, that a consecutive run of make is almost instantaneous. Would a make -pn really be that expensive? Try running a no-op incremental make in tail_build :-) it's more like 30+ seconds: now that of course also needs some love, and it is some reasonably fun pure comp-sci type problem with no real need to understand any of the LibO code-base; if someone wants an easy hack ;-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make experts: progress information?
At 5:16am -0400 Fri, 21 Oct 2011, Michael Meeks wrote: On Thu, 2011-10-20 at 14:20 -0400, Kevin Hunter wrote: That said, I anecdotally note on my limited-in-hardware machine, that a consecutive run of make is almost instantaneous. Would a make -pn really be that expensive? Try running a no-op incremental make in tail_build :-) it's more like 30+ seconds: now that of course also needs some love, and it is some reasonably fun pure comp-sci type problem with no real need to understand any of the LibO code-base; if someone wants an easy hack ;-) Kevin: 0 Everyone else: 1 Touché, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Unexpected failures (eg. segfaults) using PyUNO and LibreOffice/OpenOffice
On 19/10/11 10:17, Dag Wieers wrote: Hi, During the course of the LibreOffice conference in Paris, we (the unoconv and cloudooo projects) found that some of the issues our users were having while doing document conversions using PyUNO and OpenOffice and LibreOffice were not related to our own project, but have a root-cause in either PyUNO or LibreOffice/OpenOffice. The result of these issues are various and individual: - segfaults - various error codes - PyUNO crashes - memory leaks - xslt problems And while some of them are reproducable (and consistent), others are not, which makes me believe they are related to internal state or timing issues of LibreOffice/OpenOffice or related to import/export filters. Since these issues are very common and can be triggered very quickly, we would like to have developers look at them to see what is the cause and how we can fix them. it is well known that the threading implementation in the OOo applications is rather unreliable. currently for thread safety the implementers of UNO APIs are required to explicitly use low-level synchronization primitives such as mutexes. not doing it correctly (such as locking a mutex while it should not be locked, or forgetting to lock a mutex while it should be locked) lead to very subtle problems that do not show up during ordinary office use, and are extremely difficult to reproduce. basically the only way for developers to find these issues is via the subsequenttests, which currently are mostly implemented in Java and connect to the OOo instance via a UNO remote bridge. and the only issues that are half-way easy do debug are deadlocks; in case of missing locks you may get a memory corruption _somewhere_ which causes some later test to crash, but it is very difficult to track down the root cause. also, most of the developers who work on the applications are not experts in multi-threading issues (those who are tend to work on the lower-level layers like the URE). for example i discovered once that in Writer almost all destructors of UNO objects do not lock a mutex but then call into the Writer core (have partially fixed this for OOo 3.3). so as a result of all of this driving OOo/LO via remote bridges is rather unreliable. some have suggested the best way out of this is to find a way so that implementers of UNO APIs do not have to care about thread safety themselves, but instead there should be a framework that does it automatically. such a framework actually exists for many years now (Kay Ramme's UNO threading framework), but most of OOo/LO does not make use of it (iirc it is used for only some database drivers). of course there may also be problems in PyUNO on top of that; back at Sun we had nothing that depended on PyUNO so i guess nobody spent much time debugging it... The cloudooo project has tested about 100.000 conversions and implemented some techniques to overcome the issues by monitoring the libreoffice process for memory leaks and 'endless loops', and retrying on failure. In the end this brought the failure rate down from about 10% tot 1.1%. (http://git.erp5.org/gitweb/cloudooo.git) yes, there are various ways to minimize the risk of failure, no doubt you are already doing most of these: - monitor the OOo instance and restart it - only connect to an OOo instance from a single thread (should result in fewer problems, but e.g. with a JVM you still effectively get multiple connections, don't know about PyUNO) Both the cloudooo and unoconv presentations will become available and contain some information on both projects and the PyUNO/LO unreliabilities. Below is some example failure output from a single run, LibreOffice does seem a bit more stable than OpenOffice though. there are a lot of XSLT errors; LO (at least in 3.4) ships a different XSLT implementation, perhaps that has helped... regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
Hi August, August Sodora schrieb: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? I'm not sure about it. It seems you are mixing up BASIC functions and CALC interpreter. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Python on Windows
On Fri, 2011-10-21 at 09:25 +0100, Michael Meeks wrote: What would be -really- excellent to nail this permanently would be to have a during-compile unit test that exercises pyuno, clearly getting that working on Linux first would be ideal. Which reminds me - do we not have bridge-test code for each of the bindings already ? IIRC there is indeed a python bridge test, testtools/source/bridgetest/pyuno. IIRC it also disabled because it failed on some platforms back in the day when I last played with it. Would indeed be worth trying to activate it for at least the platforms where it does currently pass. I *think* the failures were under solaris intel and macosx powerpc or something like that. Most immediately useful thing currently using pyuno out of the box is the email merge stuff. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW-3-4] Fix fdo#41995 fallout - recognize .svg in odf container
Hi there,
it seems, though the filter is there, we don't read .svg files from
the Pictures stream inside the odf zip container. Easy fix attached,
could someone please review commit to -3-4?
Cheers,
-- Thorsten
From abc156890a8cb64094f5d668274559203ae188b5 Mon Sep 17 00:00:00 2001
From: Thorsten Behrens tbehr...@novell.com
Date: Fri, 21 Oct 2011 11:14:32 +0200
Subject: [PATCH] Fix fdo#41995 fallout - recognize .svg in odf container
Seems the graphic load code is stupid and not using the path name /
file extension to guess file type, but only magic byte detection.
Giving filter framework the path now, so that .svg actually loads.
---
svx/source/svdraw/svdograf.cxx |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index e51a268..56d0643 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -1299,8 +1299,11 @@ IMPL_LINK( SdrGrafObj, ImpSwapHdl, GraphicObject*, pO )
mbIsPreview = sal_True;
}
-if( !GraphicFilter::GetGraphicFilter()-ImportGraphic( aGraphic, String(), *pStream,
-GRFILTER_FORMAT_DONTKNOW, NULL, 0, pFilterData ) )
+if( !GraphicFilter::GetGraphicFilter()-ImportGraphic( aGraphic,
+ aStreamInfo.maUserData,
+ *pStream,
+ GRFILTER_FORMAT_DONTKNOW,
+ NULL, 0, pFilterData ) )
{
const String aUserData( pGraphic-GetUserData() );
--
1.7.1
pgp5TaEuhCgHe.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make experts: progress information?
Hi all, On Fri, Oct 21, 2011 at 10:16:07AM +0100, Michael Meeks wrote: Try running a no-op incremental make in tail_build :-) it's more like 30+ seconds: Only with gb_CHECKOBJECTOWNER=T otherwise its down to 10 seconds in tail_build, which is likely mostly stat'ing. Anyway: I implemented a make countoutdated proof-of-concept: http://cgit.freedesktop.org/libreoffice/core/commit/?id=05a33692a084f59f2fae0a535131133d2a3f6b72 http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ee4e99a78a7a7f16bafa56e08ef9649cc69dbdb which does not add much complexity to the existing build system by being an extension. Now you can do: make countoutdated make countoutdated check make countoutdated build to quickly check etc. how many files would get rebuild in workdir right now. Of course, that _could_ be easily used to create some progress counters, if one doesnt mind the ten extra seconds. For example it shows that touching sw/inc/doc.hxx causes: $ make countoutdated -W `readlink -f sw/inc/doc.hxx` CxxObject: 393 Module: 39 LinkTarget: 9 RdbTarget: 8 CppunitTest: 9 to be rebuild. It also shows there is still something very wrong about generated headers in oox. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kubuntu Oneiric Qt4 Libraries
On Thu, Oct 20, 2011 at 06:31:23PM -0200, Olivier Hallot wrote: I get stuck with autogen.sh, asking for Qt4 Libraries when I --enable-kde4. I am on a Kubuntu Oneiric machine and it seems I cannot find the right package to install. Must be stupid, but I just don't get it. apt-get build-dep libreoffice should take cae of deps for you. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SolarMutex usage...
is there any authoritative documentation on when exactly the SolarMutex should be locked when coming from the UI? i know that it must be locked on UNO API method entry in the parts of the code that are not otherwise threadsafe, but i have no idea how the UI stuff / VCL works. for example, somebody has put a DBG_TESTSOLARMUTEX() assertion in ImplWindowFrameProc, which can easily be triggered by just creating a new Writer document, entering a letter or whatever and hitting the 'Save' icon. now which frame in that stack should lock the SolarMutex ? #0 0x77d6fdb1 in osl_assertFailedLine () from /data/lo/core/solver/unxlngx6/installation/opt/program/../basis-link/ure-link/lib/libuno_sal.so.3 #1 0x732cfacd in ImplDbgTestSolarMutex () at /data/lo/core/vcl/source/app/dbggui.cxx:1978 #2 0x74457265 in DbgFunc (nAction=15, pParam=0x0) at /data/lo/core/tools/source/debug/debug.cxx:1301 #3 0x734be129 in DbgTestSolarMutex () at /data/lo/core/solver/unxlngx6/inc/tools/debug.hxx:322 #4 0x73782fe0 in ImplWindowFrameProc (pWindow=0x134b490, nEvent=2, pEvent=0x7fff6fd0) at /data/lo/core/vcl/source/window/winproc.cxx:2370 #5 0x7fffe56641d7 in SalFrame::CallCallback (this=0x134b910, nEvent=2, pEvent=0x7fff6fd0) at /data/lo/core/vcl/inc/salframe.hxx:294 #6 0x7fffe568e55e in GtkSalFrame::signalCrossing (pEvent=0x1e3c8e0, frame=0x134b910) at /data/lo/core/vcl/unx/gtk/window/gtkframe.cxx:2866 #7 0x00337114ef33 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #8 0x003363c0ea24 in g_closure_invoke () from /lib64/libgobject-2.0.so.0 #9 0x003363c20d17 in ?? () from /lib64/libgobject-2.0.so.0 #10 0x003363c29f13 in g_signal_emit_valist () from /lib64/libgobject-2.0.so.0 #11 0x003363c2a2e2 in g_signal_emit () from /lib64/libgobject-2.0.so.0 #12 0x003371284141 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #13 0x0033712842fc in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #14 0x00337128858a in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #15 0x00337114b1c5 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #16 0x00337114b2db in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #17 0x0033712974a0 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #18 0x003363c0ea24 in g_closure_invoke () from /lib64/libgobject-2.0.so.0 #19 0x003363c20527 in ?? () from /lib64/libgobject-2.0.so.0 #20 0x003363c2a141 in g_signal_emit_valist () from /lib64/libgobject-2.0.so.0 #21 0x003363c2a2e2 in g_signal_emit () from /lib64/libgobject-2.0.so.0 #22 0x00337128cc86 in gtk_widget_show () from /usr/lib64/libgtk-x11-2.0.so.0 #23 0x0033710c4f13 in gtk_dialog_run () from /usr/lib64/libgtk-x11-2.0.so.0 #24 0x7fffdda123c2 in RunDialog::run() () from /data/lo/core/solver/unxlngx6/installation/opt/program/../program/fps_gnome.uno.so #25 0x7fffdda192b8 in SalGtkFilePicker::execute() () from /data/lo/core/solver/unxlngx6/installation/opt/program/../program/fps_gnome.uno.so #26 0x760f71fa in sfx2::FileDialogHelper_Impl::implDoExecute (this=0x1d986e0) at /data/lo/core/sfx2/source/dialog/filedlghelper.cxx:1306 #27 0x760f7f39 in sfx2::FileDialogHelper_Impl::execute (this=0x1d986e0, rpURLList=@0x7fff7fc0, rpSet=@0x7fff8268, rFilter=) at /data/lo/core/sfx2/source/dialog/filedlghelper.cxx:1481 #28 0x760fd16f in sfx2::FileDialogHelper::Execute (this=0x1d8c2b0, rpSet=@0x7fff8268, rFilter=) at /data/lo/core/sfx2/source/dialog/filedlghelper.cxx:2374 #29 0x762214dc in ModelData_Impl::OutputFileDialog (this=0x7fff8880, nStoreMode=32 ' ', aPreselectedFilterPropsHM=..., bSetStandardName=0 '\000', aSuggestedName=..., bPreselectPassword=0 '\000', aSuggestedDir=..., nDialog=0, rStandardDir=..., rBlackList=...) at /data/lo/core/sfx2/source/doc/guisaveas.cxx:997 #30 0x76225600 in SfxStoringHelper::GUIStoreModel (this=0x7fff9700, xModel=..., aSlotName=..., aArgsSequence=..., bPreselectPassword=0 '\000', aSuggestedName=..., nDocumentSignatureState=0) at /data/lo/core/sfx2/source/doc/guisaveas.cxx:1506 #31 0x76242d53 in SfxObjectShell::ExecFile_Impl (this=0x158c330, rReq=...) at /data/lo/core/sfx2/source/doc/objserv.cxx:631 #32 0x76240d73 in SfxStubSfxObjectShellExecFile_Impl (pShell=0x158c330, rReq=...) at /data/lo/core/workdir/unxlngx6/SdiTarget/sfx2/sdi/sfxslots.hxx:151 #33 0x760acd04 in SfxShell::CallExec (this=0x158c330, pFunc=0x76240d50 SfxStubSfxObjectShellExecFile_Impl(SfxShell*, SfxRequest), rReq=...) at /data/lo/core/sfx2/inc/sfx2/shell.hxx:202 #34 0x760a57fd in SfxDispatcher::Call_Impl (this=0x18e4670, rShell=..., rSlot=..., rReq=..., bRecord=1 '\001') at /data/lo/core/sfx2/source/control/dispatch.cxx:278 #35 0x760a8d15 in SfxDispatcher::PostMsgHandler (this=0x18e4670, pReq=0x1d8cbb0) at /data/lo/core/sfx2/source/control/dispatch.cxx:1373 #36 0x760a8bc3 in SfxDispatcher::LinkStubPostMsgHandler (pThis=0x18e4670,
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
On 21/10/11 04:19, August Sodora wrote: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? seems like a nice patch :-). From the basic side of things , all seems fine, if Kohei is happy with the calc parts then I see no problem to push this. Have you already stated license for the patch (MPL/LGPLv3+) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SolarMutex usage...
On Fri, 2011-10-21 at 12:28 +0200, Michael Stahl wrote: now which frame in that stack should lock the SolarMutex ? Possibly a special case because the file dialog here is the gtk file dialog and its more a miracle it works than something to prod too hard :-) ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [REVIEW-3-4] Fix fdo#41995 fallout - recognize .svg in odf container
On 21/10/11 11:59, Thorsten Behrens wrote: Hi there, it seems, though the filter is there, we don't read .svg files from the Pictures stream inside the odf zip container. Easy fix attached, could someone please review commit to -3-4? Cheers, -- Thorsten have reviewed and pushed to -3-4. regards michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
Hi August, August Sodora schrieb: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? I understand now, that you will do BASIC and CALC at the same time. For CALC there are some problems. A function FRAC is not defined in ODF1.2 [1]. So it has to be written different. For OOo that has been org.openoffice.style (for example). But I'm not sure, whether the same should be done for LO, or whether it should be org.libreoffice, or more general org.documentfoundation. The new function need to be known to the function wizard, see [2] chapter 3. [1] http://docs.oasis-open.org/office/v1.2/ [2] http://wiki.services.openoffice.org/wiki/Calc/Implementation/Spreadsheet_Functions Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Gmane address mangling
hi all, noticed that i just committed thb's patch with a Gmane mangled mail address :( is there a particular reason why this list is using the address mangling? looks like the addresses aren't that well protected in the fd.o web interface anyway e.g. 'mstahl at redhat.com'. and also the other gmane.comp.documentfoundation lists don't seem to have mangling enabled. would anybody object to turning it off? it sure is annoying... and everybody already has spam filters anyway... regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Gmane address mangling
Michael Stahl wrote: would anybody object to turning it off? Nope, go for it. It has bitten a few others before already... Cheers, -- Thorsten pgpU0N867kgyH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config register toolbar controller in adddon
Hi, I looked to this one but these are not flexible enough. i need more complex controls (like XFixedText and progressbar). i also want to dynamically show/hide toolbar controls at runtime. do you know how we can do this? thanks -- View this message in context: http://nabble.documentfoundation.org/config-register-toolbar-controller-in-adddon-tp3438288p3440636.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config register toolbar controller in adddon
HI , I looked to this one but these are not flexible enough. i need more complex controls (like XFixedText and progressbar). i also want to dynamically show/hide toolbar controls at runtime. do you know how we can do this? i'm currently exploring this http://wiki.services.openoffice.org/wiki/Framework/Article/Tool_Panels quite promosing mixing technlogies (java/python + Basic dialogs) it globally works with some tricks i'm actually on writing the factory as python instead of java (the part dealing with layoutmanager is missing, though) i'll probably will write things about it when ok Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Python on Windows
On Thu, 20 Oct 2011, Stephan Bergmann wrote: (c) pyuno as run from an external python process might no longer work. An easy way to test that is to start the interactive python executable from the LibO program directory and execute include uno (and/or include pyuno; not sure right now which one is the more interesting, but if both work I'd guess that's good). The solution we implemented for this for unoconv (a python tool) is to try to load the pyuno.so with the system's python, on failure it looks for an existing LibO python and swaps itself in memory with the LibO python and tries again. That works quite well in practice. -- -- dag wieers, d...@wieers.com, http://dag.wieers.com/ -- dagit linux solutions, i...@dagit.net, http://dagit.net/ [Any errors in spelling, tact or fact are transmission errors] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] comprehensive binfilter tests?
On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote: In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x crashes on all of them under Linux/Windows. I did not try master. 3.3 is OK. master crashes for me alright, http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=86db50edeee1d556f993589da73140582789ef42 fixes it again for those docs anyway. caolanm-sberg: can you have a look at my fix, looks like merge bustage on merging in the fix for #i117310#, though that would indicate that whatever problem exists in 3.4.3 is different. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
Interesting, I'll take a look at those documents. I had actually initially thought that adding something to the BASIC language would be more controversial than adding a calc cell function :) Has there been any discussion on where these types of additions should go in the past? August Sodora aug...@gmail.com (201) 280-8138 On Fri, Oct 21, 2011 at 7:20 AM, Regina Henschel rb.hensc...@t-online.de wrote: Hi August, August Sodora schrieb: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? I understand now, that you will do BASIC and CALC at the same time. For CALC there are some problems. A function FRAC is not defined in ODF1.2 [1]. So it has to be written different. For OOo that has been org.openoffice.style (for example). But I'm not sure, whether the same should be done for LO, or whether it should be org.libreoffice, or more general org.documentfoundation. The new function need to be known to the function wizard, see [2] chapter 3. [1] http://docs.oasis-open.org/office/v1.2/ [2] http://wiki.services.openoffice.org/wiki/Calc/Implementation/Spreadsheet_Functions Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
On 10/21/2011 11:08 AM, Kevin Hunter wrote: At 4:11am -0400 Fri, 21 Oct 2011, Stephan Bergmann wrote: On 10/21/2011 02:06 AM, Kevin Hunter wrote: 5. That API definition will be a *lot* of work, but hopefully somewhat thought out already through only a mild reengineering of the current binary API. The UNO API is already there. Or what do you mean? I was talking about an API that is not dependent on an ABI. But I freely admit I know very little about ABIs, so I may have just conflated that term. See below. The upside is that if we're talking a major version change, /now/ would be the time to do this. A downside is that you would still need to maintain (and build!) the UNO runtime for the MSVC ABI. This may be the crux of what I'm not getting, but why? Why can't a protocol be, say, text-based via (local, or other) socket? In my mind, I see two independent programs, from two different compilers, using the OS and something akin to pipes to communicate. I admit it might a smidgen slower to do it that way, but do people actually use LO in HPC scenarios? (And I fully accept that they might, I just haven't seen it yet in my various interactions.) That's all already there with UNO. Only, for any code to make use of that, it needs to talk with bridge code that handles the (intra- or inter-process) communication. That bridge code (which is necessarily ABI-specific) is also already there. The only thing is that, if you wanted to give up building LibO with MSVC and switch to MinGW, but wanted to retain the MSVC-specific bridge code (so that old extensions can continue to run, in- or out-of-processes), you could not give up building LibO with MSVC completely, because you would still need to build that bridge code with MSVC. Designing a new communication protocol would not buy you anything. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit from eachother?!) in basic? I'm also curious about VBA support and whether there exists a grammar or similar documentation for the StarBASIC language. August Sodora aug...@gmail.com (201) 280-8138 On Fri, Oct 21, 2011 at 5:13 AM, Michael Meeks michael.me...@suse.com wrote: Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodora aug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to get an idea of how the scanner handles certain situations but I tried to make sure I included ones that specifically trigger where the GetBufferAccess was. Ooh ! :-) this is really nice. I was previously fooled by the subject into not noticing that this was some sexy code cleanup + unit testing patch. Lovely work ! I added a doc. header for the new sal/ method, and since I have: (setq-default show-trailing-whitespace t) in my ~/.emacs I see red warnings of trailing whitespace - so removed a bit of that. One thing I tweaked in one place is using sal_Int32 indexes into rtl::OUStrings where previously sal_uInt16 indexes were adequate, one benefit of your cleanup is that we can handler bigger scripts of course. Anyhow - a lovely job :-) I'm really looking forward to see what you touch next :-) Many thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
On 10/21/2011 10:39 AM, Michael Meeks wrote: Hi Kevin, On Thu, 2011-10-20 at 20:06 -0400, Kevin Hunter wrote: From the wiki page, one of the concerns is binary incompatibility. I assume this is in reference to extensions? Sure; of course we only export a reasonably small ABI, the 'ure' (big chunks of which are in-lined C++ methods that call SAL_CALL C functions that we havn't changed and should cross-compile nicely). The C++ helper classes (it is hoped) due to windows direct linking, and a different ABI anyway shouldn't conflict. My hope was(is) that UNO can shine here (with some tweaks) as a bridging technology between the ABIs - at some fairly minimal performance cost. At least, given Stephan's expertise a little testing, it might just work. That would of course mean shipping some duplicate legacy MSVC++ compiled libraries, but ... surely do-able. It would not suffice to ship them, one would also need to build them. Kind of back to square one. Question: is there merit to moving toward an enforced sub-process model for extensions ? It is an interesting idea; of course in theory UNO makes this easy, in reality - I would scream and run away from cross-process component usage. Debugging reference leaks / cycles / etc. is bad enough in-process, never-mind cross-process; or worse between many (external) components. Note that freshly installed extensions *are* routinely loaded off to an external uno process. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] cherry-pick to fix .sdw import in 3-4
I want to cherry-pick the attached commit back to 3-4, the .sdw import
of the binfilter is broken otherwise as timar noted.
May need git am --ignore-whitespace or whatever to apply.
C.
From ac7475b06466404ac23d5352d9226de857d83987 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= caol...@redhat.com
Date: Wed, 13 Apr 2011 13:48:19 +0100
Subject: [PATCH] add these back in to silence the MAXFILTER assert
---
binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx | 13 ++
.../bf_sw/source/filter/basflt/sw_shellio.cxx | 24 +---
binfilter/inc/bf_sw/iodetect.hxx |5 +--
3 files changed, 16 insertions(+), 26 deletions(-)
diff --git a/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx b/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
index 27bfad6..6d90fac 100644
--- a/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
+++ b/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
@@ -89,10 +89,23 @@ inline void _SetFltPtr( USHORT rPos, SwRead pReader, const sal_Char* pNm )
void _InitFilter()
{
+SwRead pRd;
+
USHORT nCnt = 0;
_SetFltPtr( nCnt, (ReadSw3 = new Sw3Reader), FILTER_SW5 );
_SetFltPtr( nCnt, ReadSw3, FILTER_SW4 );
_SetFltPtr( nCnt, ReadSw3, FILTER_SW3 );
+_SetFltPtr( nCnt, (ReadSwg = new SwgReader), FILTER_SWG );
+_SetFltPtr( nCnt, ReadSwg, FILTER_SWGV );
+_SetFltPtr( nCnt, new Sw6Reader, sSwDos );
+_SetFltPtr( nCnt, (ReadAscii = new AsciiReader), FILTER_BAS );
+_SetFltPtr( nCnt, new W4WReader, FILTER_W4W );
+_SetFltPtr( nCnt, ( pRd = new ExcelReader ), sCExcel );
+_SetFltPtr( nCnt, pRd, sExcel );
+_SetFltPtr( nCnt, new LotusReader, sLotusD );
+_SetFltPtr( nCnt, ReadSwg, sSwg1 );
+
+_SetFltPtr( nCnt, ReadAscii, FILTER_TEXT );
OSL_ENSURE( MAXFILTER == nCnt, Anzahl Filter ungleich der Definierten );
}
diff --git a/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx b/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
index 2c5557f..3399f21 100644
--- a/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
+++ b/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
@@ -351,29 +351,7 @@ using namespace ::com::sun::star;
/*?*/ // we cannot create a SwDocShell. We could create a
/*?*/ // SwWebDocShell however, because this exists always
/*?*/ // for the help.
-OSL_ASSERT(ReadXML removed);
-
-// SvtModuleOptions aModuleOptions;
-// if( aModuleOptions.IsWriter() )
-// {
-// SwDocShell *pDocSh =
-// new SwDocShell ( SFX_CREATE_MODE_INTERNAL );
-// SvEmbeddedObjectRef xDocSh = pDocSh;
-// if( pDocSh-DoInitNew( 0 ) )
-// {
-// pTemplate = pDocSh-GetDoc();
-// pTemplate-SetOle2Link( Link() );
-// pTemplate-SetBrowseMode( bTmplBrowseMode );
-// pTemplate-RemoveAllFmtLanguageDependencies();
-//
-// ReadXML-SetOrganizerMode( TRUE );
-// SwReader aRdr( *xStor, aEmptyStr, pTemplate );
-// aRdr.Read( *ReadXML );
-// ReadXML-SetOrganizerMode( FALSE );
-//
-// pTemplate-AddLink();
-// }
-//}
+OSL_ASSERT(ReadXML removed);
/*?*/ }
/*?*/ else
/*?*/ {
diff --git a/binfilter/inc/bf_sw/iodetect.hxx b/binfilter/inc/bf_sw/iodetect.hxx
index e91b371..94199a9 100644
--- a/binfilter/inc/bf_sw/iodetect.hxx
+++ b/binfilter/inc/bf_sw/iodetect.hxx
@@ -105,7 +105,7 @@ struct SwIoDetect
#endif
-const USHORT MAXFILTER = 14;
+const USHORT MAXFILTER = 13;
#define FORAMTNAME_SW4 StarWriter 4.0
#define FORAMTNAME_SW3 StarWriter 3.0
@@ -161,8 +161,7 @@ SwIoDetect aReaderWriter[ MAXFILTER ] = { \
{/* 9*/ SwIoEntry(sExcel, 4,FALSE)}, \
{/*10*/ SwIoEntry(sLotusD,5,TRUE)},\
{/*11*/ SwIoEntry(sSwg1, 4,FALSE)}, \
-{/*12*/ SwIoEntry(FILTER_XML, 4,TRUE)},\
-{/*13*/ SwIoEntry(FILTER_TEXT,4,TRUE)} \
+{/*12*/ SwIoEntry(FILTER_TEXT,4,TRUE)} \
};
// Filter erkennung
--
1.7.6.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] comprehensive binfilter tests?
On 10/21/2011 02:38 PM, Caolán McNamara wrote: On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote: In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x crashes on all of them under Linux/Windows. I did not try master. 3.3 is OK. master crashes for me alright, http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=86db50edeee1d556f993589da73140582789ef42 fixes it again for those docs anyway. caolanm-sberg: can you have a look at my fix, looks like merge bustage on merging in the fix for #i117310#, though that would indicate that whatever problem exists in 3.4.3 is different. http://hg.services.openoffice.org/cws/sb140/rev/85f71dba0516 (referenced from https://issues.apache.org/ooo/show_bug.cgi?id=117310) removes the if( !rPropSetInfo.is() ) rPropSetInfo = rPropSet-getPropertySetInfo(); part only from binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx but not from the corresponding xmloff/source/style/SinglePropertySetInfoCache.cxx. I guess it was a mistake I introduced when manually copying over the changes I made to the latter to the former, and it simply went unnoticed until now. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config register toolbar controller in adddon
Thanks this seems very interesting. So we could include Tool Panels in a toolbar too and not only in a Task Pane is that correct? I'll be very interested to see some snippet code (java or python) on how to make a Tool Panel and add it to a addon toolbar. I can work on this if you give me some guidelines and tips. thanks othman -- View this message in context: http://nabble.documentfoundation.org/config-register-toolbar-controller-in-adddon-tp3438288p3440782.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] maybe clean rebuild needed
Hey, I just enabled the macro's test in calc again and it seems that in some situations we get a deadlock in the first incremental build after the patch. If you observe that in your build, do a make clean and the next make should execute the test without a problem. If you still get problem after a make clean please write me a mail. Sorry for the trouble I might cause. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] libreoffice-3-4 fix l10n of NLPSolver
On Thu, 2011-10-20 at 11:19 +0200, Andras Timar wrote: My latest patch fixes it, I would like to have it in LibreOffice 3.4.4, Now pushed to 3-4 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] config register toolbar controller in adddon
From my humble experience with OOo , i conclude that the designers decided to have a limited functionality for toolbars. I would be happy to know of some people willing to improve OOo toolbars API allowing more power and flexibility to build complex toolbars with rich controls and dynamic events. If i was familiar with OOo API source code i could add this improvement myself..maybe in future if i understand more OOo source code i can work on that. But anyway maybe i'll have a look at the Tool Panel option. thanks for your help othman -- View this message in context: http://nabble.documentfoundation.org/config-register-toolbar-controller-in-adddon-tp3438288p3440839.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] IDL hyper / Java long
Hello, Please, could somebody check this... https://bugs.freedesktop.org/show_bug.cgi?id=42005 Best Regards, Marcin Gutman ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
On Fri, 2011-10-21 at 14:51 +0200, Stephan Bergmann wrote: That would of course mean shipping some duplicate legacy MSVC++ compiled libraries, but ... surely do-able. It would not suffice to ship them, one would also need to build them. Kind of back to square one. For windows - shipping a pre-canned set of compiled compatibility libraries doesn't look too disgusting to me; at least - it seems a lot less disgusting than using MSVC++ and cygwin :-) tar xf ure-bincompat-win32-tgz is not in itself such a horrific outcome from a cross-compiled solution (assuming the build of that is well documented, should you happen to have lots of time and a proprietary system + compiler to do it). Clearly someone needs to build them once. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Frac function in BASIC
On Fri, 2011-10-21 at 08:45 -0400, August Sodora wrote: Interesting, I'll take a look at those documents. I had actually initially thought that adding something to the BASIC language would be more controversial than adding a calc cell function :) Heh :-) well, the direction we're trying to take StarBasic is towards more VBA compatibility; so - if this function is used in VBA and has the same semantics, there is no problem it should get it straight in. Wrt. calc there is a lot more UI documentation work to do there of course; and the 'FRAC' function appears not to exist for me in Excel - so there are a number of interop problems that rear their head when this comes up. ie. if someone uses it in calc, do we try and map this to a combination of other functions when we export to xls/xlsx ? or ... ;-) it gets a bit nastier there. Looking at it, though I don't believe that VBA does have this function ( does it ? ), as such there is no huge problem adding it - but it could impact interoperability in the future. Anyhow - Noel liked it, so I pushed it :-) Could you send a mail confirming your work is under the MPL/LGPLv3+ and add yourself to: http://wiki.documentfoundation.org/Development/Developers Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SolarMutex usage...
Hi Michael, Good catch with this :-) On Fri, 2011-10-21 at 12:28 +0200, Michael Stahl wrote: is there any authoritative documentation on when exactly the SolarMutex should be locked when coming from the UI? So - with the gtk+ backend, it should mirror the GDK_THREADS lock that protects the toolkit. i know that it must be locked on UNO API method entry in the parts of the code that are not otherwise threadsafe, but i have no idea how the UI stuff / VCL works. Luckily I have a pretty good idea of what is going on there :-) I spent a lot of time on this locking integration in the past. for example, somebody has put a DBG_TESTSOLARMUTEX() assertion in ImplWindowFrameProc, which can easily be triggered by just creating a new Writer document, entering a letter or whatever and hitting the 'Save' icon. Sure - that seems reasonable to me - it should be locked there. #0 0x77d6fdb1 in osl_assertFailedLine () from /data/lo/core/solver/unxlngx6/installation/opt/program/../basis-link/ure-link/lib/libuno_sal.so.3 #1 0x732cfacd in ImplDbgTestSolarMutex () at /data/lo/core/vcl/source/app/dbggui.cxx:1978 #2 0x74457265 in DbgFunc (nAction=15, pParam=0x0) at /data/lo/core/tools/source/debug/debug.cxx:1301 #3 0x734be129 in DbgTestSolarMutex () at /data/lo/core/solver/unxlngx6/inc/tools/debug.hxx:322 #4 0x73782fe0 in ImplWindowFrameProc (pWindow=0x134b490, nEvent=2, pEvent=0x7fff6fd0) at /data/lo/core/vcl/source/window/winproc.cxx:2370 #5 0x7fffe56641d7 in SalFrame::CallCallback (this=0x134b910, nEvent=2, pEvent=0x7fff6fd0) at /data/lo/core/vcl/inc/salframe.hxx:294 #6 0x7fffe568e55e in GtkSalFrame::signalCrossing (pEvent=0x1e3c8e0, frame=0x134b910) at /data/lo/core/vcl/unx/gtk/window/gtkframe.cxx:2866 #7 0x00337114ef33 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 .. #21 0x003363c2a2e2 in g_signal_emit () from /lib64/libgobject-2.0.so.0 #22 0x00337128cc86 in gtk_widget_show () from /usr/lib64/libgtk-x11-2.0.so.0 #23 0x0033710c4f13 in gtk_dialog_run () from /usr/lib64/libgtk-x11-2.0.so.0 #24 0x7fffdda123c2 in RunDialog::run() () from /data/lo/core/solver/unxlngx6/installation/opt/program/../program/fps_gnome.uno.so #25 0x7fffdda192b8 in SalGtkFilePicker::execute() () from /data/lo/core/solver/unxlngx6/installation/opt/program/../program/fps_gnome.uno.so it should be locked down this entire call-frame. This looks like an 'easy' case - there is no main-loop running or anything complicated. #46 0x7fffe5083249 in SalDisplay::DispatchInternalEvent (this=0x779ce0) at /data/lo/core/vcl/unx/generic/app/saldisp.cxx:2160 #47 0x7fffe566387a in GtkXLib::userEventFn (data=0x6fcc80) at /data/lo/core/vcl/unx/gtk/app/gtkdata.cxx:900 #48 0x7fffe5663737 in call_userEventFn (data=0x6fcc80) at /data/lo/core/vcl/unx/gtk/app/gtkdata.cxx:865 #49 0x003360c44add in g_main_context_dispatch () from /lib64/libglib-2.0.so.0 #50 0x003360c452d8 in ?? () from /lib64/libglib-2.0.so.0 It is missing here - the call_userEventFn should have it. Good catch; I fixed another three missing instances and committed the patch to feature/gtk3 - it should get merged soon (in the next few days). In the meantime - patience much appreciated, and thanks for the report - well worth leaving that assertion there for the future I think. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
Hi August, On Fri, 2011-10-21 at 08:50 -0400, August Sodora wrote: Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit from eachother?!) in basic? I'm also curious about VBA support and whether there exists a grammar or similar documentation for the StarBASIC language. Well - of course, it'd be nice to have some more complex tests of StarBasic (and VBA) macros, potentially loaded from .bas files inside a unit test. Noel - do you have any really nasty syntax / built-in basic functionality corner cases embedded into xls files that could be extracted and turned into compile-time unit tests in basic/ ? Otherwise digging out some more easy hacks to play with :-) If you love basic then - trying to compile and execute macros that are 64k long (do we have a regression test for that?) might be a good idea - I imagine many limits are still in-place there. Converting more code from the String - OUString types is probably worthwhile. Is that interesting ? Thanks again, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
Hello Michael, August, 2011/10/21 Michael Meeks michael.me...@suse.com: Hi August, On Fri, 2011-10-21 at 08:50 -0400, August Sodora wrote: Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit from eachother?!) in basic? I'm also curious about VBA support and whether there exists a grammar or similar documentation for the StarBASIC language. Well - of course, it'd be nice to have some more complex tests of StarBasic (and VBA) macros, potentially loaded from .bas files inside a unit test. Noel - do you have any really nasty syntax / built-in basic functionality corner cases embedded into xls files that could be extracted and turned into compile-time unit tests in basic/ ? Otherwise digging out some more easy hacks to play with :-) If you love basic then - trying to compile and execute macros that are 64k long (do we have a regression test for that?) might be a good idea - I imagine many limits are still in-place there. Converting more code from the String - OUString types is probably worthwhile. I think we need to seperate basic tests a bit. Unit test like the newly integrated one should and can be in basic but all tests that should execute a macro need to move a bit later in the build, like sc or sw. There we have all needed modules and we have already a concept that should work fine. The advantage of these tests is that all dependency problems we have for executing useful macros are solved. StarBasic tests should already work and I'm working on VBA tests to make them more usefull. If you want you can have a look and maybe add some useful tests there. But keep up your good work. Every added test is a win. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. Great to see that :-) Any chance you could drop a nice screenshot / feature note and your name at: http://wiki.documentfoundation.org/ReleaseNotes/3.5 which saves lots of time later when it comes to building the 3.5 release notes. Thanks again, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] need mentoring on framework module (enabling toolpanels)
Hi Laurent, On Thu, 2011-10-20 at 17:19 +0200, Laurent Godard wrote: before diving in calc large file in november, i have to deal at the moment with XToolPanel Sounds exciting :-) the purpose is to be able to have things in task pane and manipulate them using scripting (macro or python at the moment) Yep - looks lovely. i add some succes with core/testautomation/extensions/optional/input/extension_sources/TaskPaneComponent So - you can get a tool panel presented and working for you ? [ do you get to the green screenshot state ? ]. http://wiki.services.openoffice.org/wiki/Framework/Article/Tool_Panels So, I do not have the skills to do the whole refactoring of the framework module but i would like to try to add the support of toolpanels Of course. I wonder what is not working for you (?) I already looked at some source code and did some rough modification taking example on other UIElements, but no success for the moment. Would love to read the patch. essentially in framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx as using it in scprit, a lot of UIElements are shown but no toolpanels Right; unfortunately there is already quite a bit of bulk duplication in that beast. before going further and wasting a lot of time (well, i could see it at learning), I definitvely need someone that could mentor me and put me in the right directions (what is really misisng, what should i write, which UiElement could I take as example) So - I'm happy to help - do you have a patch I can play with ? also what do you want to put in your panel ? [ I for one would love to have some share-pointy stuff in there, workflows and so on for relevant documents ]. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Frac function in BASIC
Sure all of my work can be licensed MPL/LGPLv3+. Just noticed I forgot to refer to the bug that gave me the idea to try this (https://bugs.freedesktop.org/show_bug.cgi?id=39900) August Sodora aug...@gmail.com (201) 280-8138 On Fri, Oct 21, 2011 at 10:11 AM, Michael Meeks michael.me...@suse.com wrote: On Fri, 2011-10-21 at 08:45 -0400, August Sodora wrote: Interesting, I'll take a look at those documents. I had actually initially thought that adding something to the BASIC language would be more controversial than adding a calc cell function :) Heh :-) well, the direction we're trying to take StarBasic is towards more VBA compatibility; so - if this function is used in VBA and has the same semantics, there is no problem it should get it straight in. Wrt. calc there is a lot more UI documentation work to do there of course; and the 'FRAC' function appears not to exist for me in Excel - so there are a number of interop problems that rear their head when this comes up. ie. if someone uses it in calc, do we try and map this to a combination of other functions when we export to xls/xlsx ? or ... ;-) it gets a bit nastier there. Looking at it, though I don't believe that VBA does have this function ( does it ? ), as such there is no huge problem adding it - but it could impact interoperability in the future. Anyhow - Noel liked it, so I pushed it :-) Could you send a mail confirming your work is under the MPL/LGPLv3+ and add yourself to: http://wiki.documentfoundation.org/Development/Developers Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
On 10/21/2011 11:13 AM, Michael Meeks wrote: Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodoraaug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to get an idea of how the scanner handles certain situations but I tried to make sure I included ones that specifically trigger where the GetBufferAccess was. Ooh ! :-) this is really nice. I was previously fooled by the subject into not noticing that this was some sexy code cleanup + unit testing patch. Lovely work ! I added a doc. header for the new sal/ method, and since I have: (setq-default show-trailing-whitespace t) in my ~/.emacs I see red warnings of trailing whitespace - so removed a bit of that. One thing I tweaked in one place is using sal_Int32 indexes into rtl::OUStrings where previously sal_uInt16 indexes were adequate, one benefit of your cleanup is that we can handler bigger scripts of course. Anyhow - a lovely job :-) I'm really looking forward to see what you touch next :-) Many thanks ! Unfortunately, this breaks the build, as basic now has a (missing) dependency on sfx2, which already depends on basic. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
Hi August, Michael, Michael Meeks píše v Pá 21. 10. 2011 v 10:13 +0100: Ooh ! :-) this is really nice. I was previously fooled by the subject into not noticing that this was some sexy code cleanup + unit testing patch. Michael - thank you a lot for pushing this, and sorry, August, that I did not get to that earlier :-( I did a small follow-up patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=548fc5db7c39f62d99b1c0a9e4348972ff72545e August, can you please check that I actually did not break it? ;-) The first hunk should do the same thing as it was doing before your String - OUString conversion (force copy), just with fewer operations. The second hunk should fix a hidden O(n^2) complexity (OUStringBuffer creation + removal of 1 character for every cSep found). Your unit tests pass fine, but better when more eyes actually look at the code too :-) Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] need mentoring on framework module (enabling toolpanels)
Hi Michael Thanks for your response I have 3 degrees of responses So - you can get a tool panel presented and working for you ? [ do you get to the green screenshot state ? ]. 1- well i went a bit more deeper than the green panel ;) using the java code at core/testautomation/extensions/optional/input/extension_sources/TaskPaneComponent i've been able to load a dialog.xdl file and bind macros (then any scipt code) to the events of the controls (on click for exampke). It is perfect for my use ! one trick though, retrieving the dialog object itself, i manage only using the on-focus event (and store it in a global variable). not beautifull but hey, it works. That what was i was looking for dealing with the LayoutManager, retreiving the panel object to manipulate its components. no more urgent need now (but the lack in core_code remains) 2- The next step i almost finished (but currently not fully working) is rewriting the TaskPaneComponent java code to Python The problem i face here is that all the code is executed, but nothings shows up. probably a stupid mistake somewhere Once all is ok, i'll probbaly take some time to write things on the wiki and provide a sample source code for step 1 and 2 I haven't done pyUNo for years, so it was a bit difficult (but really funny !!) I reactivated a pyUNo tool i wrote in 2004 and with a small polish it worked like a charm. It is a very usefull tool (at least for me) for doing introspection at runtime on pyUNo objects. http://markmail.org/message/kt2va3mc3ggwk4e2 the download link is dead but i'll publish pyXray and offer it to Libreoffice if it can help. At least could be a learning tool ofr pyUno beginers 3- LibreOffice source code once a toolpanel is created, we can not at the moment control it as we control statusbar, toolbars, menubars (especially regarding visibility) this is done using the XLayoutManager interface and as stated in the announce, it is not implemented yet. so i thought that if it was an easy hack, i could perharps do it (but my priority remains calc very large files performances for Libo 3.5 - I'll start working on this in november) regarding my patch, it will be waste of time. it was more or less random modifications, only copying few lines and changing names. i'll try to first finish the point 2. and then see if this XLayoutManager problem is really needed for scripter point of view. i'll come back to you. (but not last week, as i'll be in hollidays with the whole family, so hacking on computers not welcommed ;) ) also what do you want to put in your panel ? [ I for one would love to have some share-pointy stuff in there, workflows and so on for relevant documents ]. my goal is to put any XControl that one can use un Basic dialogs (buttons, labels, treeviews, pictures, combox box aso ...) i'm pretty confident it will work (at least it works with a java factory of the toolpanel) This toolpanel stuff is quite exciting as it offers a lot of possibilities for cool extensions GUI (and what is really cool, is that you can write your events code in the language you want ;) ) I promise officially here to publish a working sample extension and write some guidelines Thanks a lot Michael for your response !! Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Module moz no longer builds on Ubuntu 11.10
Hi all, I recently upgraded from Ubuntu 11.04 to 11.10 and after pulling from master this morning, and making clean, the build no longer completes, failing in the moz module with lots of internal errors of the type : /home/alex/LODEV/core/solver/unxlngi6.pro/lib/libcrmf.a(asn1cmn.o):(.data.rel.ro+0x88): undefined reference to `SEC_IntegerTemplate_Util' /home/alex/LODEV/core/solver/unxlngi6.pro/lib/libcrmf.a(asn1cmn.o):(.data.rel.ro+0xf8): undefined reference to `SEC_AnyTemplate_Util' /home/alex/LODEV/core/solver/unxlngi6.pro/lib/libcrmf.a(asn1cmn.o):(.data.rel.ro+0x138): undefined reference to `SECOID_AlgorithmIDTemplate_Util' collect2: ld returned 1 exit status make[4]: *** [libpipnss.so] Error 1 make[4]: Leaving directory `/home/alex/LODEV/core/moz/unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl/src' make[3]: *** [libs] Error 2 make[3]: Leaving directory `/home/alex/LODEV/core/moz/unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl' make[2]: *** [libs] Error 2 make[2]: Leaving directory `/home/alex/LODEV/core/moz/unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager' make[1]: *** [tier_50] Error 2 make[1]: Leaving directory `/home/alex/LODEV/core/moz/unxlngi6.pro/misc/build/mozilla/I_objdir' make: *** [default] Error 2 dmake: Error code 2, while making './unxlngi6.pro/misc/build/so_built_ooo_mozab' Could this be the result of the recent changes to get rid of the requirement to have moz/nss ? Hints, help, gratefully received. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IDL hyper / Java long
Marcin, hope you don't mind I bring this back to the public mailing list. I'm no expert with Calc add-ins, so we should make sure I'm not telling nonsense: On 10/21/2011 05:42 PM, MarcinGutman wrote: Sorry, not sure what you want to tell me with the above. If you create Java Calc Add-In you have a Java function. There is also an IDL file that reflects definition of Java function. Parameters types are mapped from Java to IDL If Java parameter is int in IDL you put long. If Java parameter is long in IDL you put hyper or unsigned hyper. If you put hyper there is a mentioned problem. If you put unsigned hyper there is no problem. So there are three cases: 1) A comedy: it's only my box. 2) A drama: bug in SDK i.e. only new Calc Add-Ins are affected. 3) A horror: bug in LOo i.e. all existing Calc Add-Ins are affected. Due to 3) somebody should check it. As I wrote at https://bugs.freedesktop.org/show_bug.cgi?id=42005#c1, Calc add-ins do not support functions that take or return UNO type hyper. So I think that explains why an add-in using hyper in the .idl file does not work. Why, however, it should work if the .idl file instead uses unsigned hyper I do not know. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gbuild: use gb_CHECKOBJECTOWNER to check for double linked objects
On 21/04/11 18:33, Bjoern Michaelsen wrote: On Tue, 19 Apr 2011 18:24:57 +0100 Michael Meeksmichael.me...@novell.com wrote: If not, it sounds like we should have it always enabled (?), particularly if we can cleanup the issues it finds :-) Enabled by default on master with: http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=9c028fe3ff8b5db3f367d19d4fc9f99470a0d13d use make -sr gb_CHECKOBJECTOWNER= to explicitly disable. hi all, have replaced this implementation with a new, faster one: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e5eece31d93ed378613991c8a8bbe451aa5c081 this is also always enabled, and there is now no way of disabling it (i.e. gb_CHECKOBJECTOWNER is removed and does nothing) because i could not measure a difference in performance with it enabled/disabled. but perhaps that just means my new machine is too fast; perhaps somebody wants to benchmark it on their netbook/Alpha box/ARM wristwatch; you can disable it temporarily by reverting the commit, or checking out the parent and using gb_CHECKOBJECTOWNER=, which disables the old implementation; then do 'time make -nsrj8 in tail_build. regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fix for Bug fdo#41997 clean VCL enumeration
The following patch fixes bug fdo41997.
https://bugs.freedesktop.org/show_bug.cgi?id=41997
Note: tested only in Linux, not tested in Windows. No
Regards
--
Olivier Hallot
Founder, Steering Commitee Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
From 423326b440f05f5cb137d841600f9aede01aa5a0 Mon Sep 17 00:00:00 2001
From: Olivier Hallot olivier.hal...@alta.org.br
Date: Fri, 21 Oct 2011 16:54:35 -0200
Subject: [PATCH] Fix for bug fdo#41997, cleanup vcl enumeration
---
editeng/source/editeng/editeng.cxx |2 +-
editeng/source/editeng/impedit3.cxx |2 +-
formula/source/ui/dlg/formula.cxx|4 ++--
sc/source/core/tool/chartlis.cxx |2 +-
sc/source/ui/app/scmod.cxx |2 +-
sd/source/ui/tools/IdleDetection.cxx |2 +-
svtools/source/control/inettbc.cxx |2 +-
svtools/source/edit/textview.cxx |2 +-
sw/source/core/layout/paintfrm.cxx |2 +-
sw/source/core/view/viewsh.cxx |2 +-
sw/source/ui/docvw/edtwin.cxx|2 +-
vcl/aqua/source/app/salinst.cxx |4 ++--
vcl/inc/vcl/apptypes.hxx |6 +++---
vcl/unx/generic/app/salinst.cxx |4 ++--
vcl/win/source/app/salinst.cxx |2 +-
15 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx
index 5d745c0..573b30b 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1195,7 +1195,7 @@ sal_Bool EditEngine::PostKeyEvent( const KeyEvent rKeyEvent, EditView* pEditVie
DBG_ASSERT( !bReadOnly, ReadOnly but modified??? );
// Idle-Formatter only when AnyInput.
if ( bAllowIdle pImpEditEngine-GetStatus().UseIdleFormatter()
- Application::AnyInput( INPUT_KEYBOARD) )
+ Application::AnyInput( VCL_INPUT_KEYBOARD) )
pImpEditEngine-IdleFormatAndUpdate( pEditView );
else
pImpEditEngine-FormatAndUpdate( pEditView );
diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx
index b4efe14..8f059a3 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -327,7 +327,7 @@ void ImpEditEngine::UpdateViews( EditView* pCurView )
IMPL_LINK( ImpEditEngine, OnlineSpellHdl, Timer *, EMPTYARG )
{
-if ( !Application::AnyInput( INPUT_KEYBOARD ) GetUpdateMode() IsFormatted() )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) GetUpdateMode() IsFormatted() )
DoOnlineSpelling();
else
aOnlineSpellTimer.Start();
diff --git a/formula/source/ui/dlg/formula.cxx b/formula/source/ui/dlg/formula.cxx
index 97ef663..3b7c2ec 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -592,7 +592,7 @@ sal_Bool FormulaDlg_Impl::CalcValue( const String rStrExp, String rStrResult )
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
bResult = m_pHelper-calculateValue(rStrExp,rStrResult);
}
@@ -630,7 +630,7 @@ sal_Bool FormulaDlg_Impl::CalcStruct( const String rStrExp)
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
pStructPage-ClearStruct();
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 8c52fe4..6f9129d 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -567,7 +567,7 @@ void ScChartListenerCollection::StartTimer()
IMPL_LINK( ScChartListenerCollection, TimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aTimer.Start();
return 0;
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 7932fca..b4284e7 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1877,7 +1877,7 @@ IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aSpellTimer.Start();
return 0; // dann spaeter wieder...
diff --git a/sd/source/ui/tools/IdleDetection.cxx b/sd/source/ui/tools/IdleDetection.cxx
index 4ba6163..e0fba1a 100644
--- a/sd/source/ui/tools/IdleDetection.cxx
+++ b/sd/source/ui/tools/IdleDetection.cxx
@@ -59,7 +59,7 @@ sal_Int32 IdleDetection::GetIdleState (const ::Window* pWindow)
sal_Int32 IdleDetection::CheckInputPending (void)
{
-if (GetpApp()-AnyInput(INPUT_MOUSE | INPUT_KEYBOARD | INPUT_PAINT))
+if
Re: [Libreoffice] minutes of tech. steering call ...
On 10/21/2011 03:57 PM, Michael Meeks wrote: On Fri, 2011-10-21 at 14:51 +0200, Stephan Bergmann wrote: That would of course mean shipping some duplicate legacy MSVC++ compiled libraries, but ... surely do-able. It would not suffice to ship them, one would also need to build them. Kind of back to square one. For windows - shipping a pre-canned set of compiled compatibility libraries doesn't look too disgusting to me; at least - it seems a lot less disgusting than using MSVC++ and cygwin :-) tar xf ure-bincompat-win32-tgz is not in itself such a horrific outcome from a cross-compiled solution (assuming the build of that is well documented, should you happen to have lots of time and a proprietary system + compiler to do it). Clearly someone needs to build them once. There will invariably be situations were things in there will need to get fixed. And if that code is only built once in a year, it will bitrot and no longer build in a year from now. Been there with moz_prebuilt. No thanks. :) -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for Bug fdo#41997 clean VCL enumeration
Hi
The following patch fixes bug fdo41997, clean VCL enumeration.
https://bugs.freedesktop.org/show_bug.cgi?id=41997
Note: tested only in Linux, not tested in Windows (no windows available
for me)
Regards
--
Olivier Hallot
Founder, Steering Commitee Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
From 423326b440f05f5cb137d841600f9aede01aa5a0 Mon Sep 17 00:00:00 2001
From: Olivier Hallot olivier.hal...@alta.org.br
Date: Fri, 21 Oct 2011 16:54:35 -0200
Subject: [PATCH] Fix for bug fdo#41997, cleanup vcl enumeration
---
editeng/source/editeng/editeng.cxx |2 +-
editeng/source/editeng/impedit3.cxx |2 +-
formula/source/ui/dlg/formula.cxx|4 ++--
sc/source/core/tool/chartlis.cxx |2 +-
sc/source/ui/app/scmod.cxx |2 +-
sd/source/ui/tools/IdleDetection.cxx |2 +-
svtools/source/control/inettbc.cxx |2 +-
svtools/source/edit/textview.cxx |2 +-
sw/source/core/layout/paintfrm.cxx |2 +-
sw/source/core/view/viewsh.cxx |2 +-
sw/source/ui/docvw/edtwin.cxx|2 +-
vcl/aqua/source/app/salinst.cxx |4 ++--
vcl/inc/vcl/apptypes.hxx |6 +++---
vcl/unx/generic/app/salinst.cxx |4 ++--
vcl/win/source/app/salinst.cxx |2 +-
15 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx
index 5d745c0..573b30b 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1195,7 +1195,7 @@ sal_Bool EditEngine::PostKeyEvent( const KeyEvent rKeyEvent, EditView* pEditVie
DBG_ASSERT( !bReadOnly, ReadOnly but modified??? );
// Idle-Formatter only when AnyInput.
if ( bAllowIdle pImpEditEngine-GetStatus().UseIdleFormatter()
- Application::AnyInput( INPUT_KEYBOARD) )
+ Application::AnyInput( VCL_INPUT_KEYBOARD) )
pImpEditEngine-IdleFormatAndUpdate( pEditView );
else
pImpEditEngine-FormatAndUpdate( pEditView );
diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx
index b4efe14..8f059a3 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -327,7 +327,7 @@ void ImpEditEngine::UpdateViews( EditView* pCurView )
IMPL_LINK( ImpEditEngine, OnlineSpellHdl, Timer *, EMPTYARG )
{
-if ( !Application::AnyInput( INPUT_KEYBOARD ) GetUpdateMode() IsFormatted() )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) GetUpdateMode() IsFormatted() )
DoOnlineSpelling();
else
aOnlineSpellTimer.Start();
diff --git a/formula/source/ui/dlg/formula.cxx b/formula/source/ui/dlg/formula.cxx
index 97ef663..3b7c2ec 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -592,7 +592,7 @@ sal_Bool FormulaDlg_Impl::CalcValue( const String rStrExp, String rStrResult )
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
bResult = m_pHelper-calculateValue(rStrExp,rStrResult);
}
@@ -630,7 +630,7 @@ sal_Bool FormulaDlg_Impl::CalcStruct( const String rStrExp)
{
// Only calculate the value when there isn't any more keyboard input:
-if ( !Application::AnyInput( INPUT_KEYBOARD ) )
+if ( !Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
pStructPage-ClearStruct();
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 8c52fe4..6f9129d 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -567,7 +567,7 @@ void ScChartListenerCollection::StartTimer()
IMPL_LINK( ScChartListenerCollection, TimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aTimer.Start();
return 0;
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 7932fca..b4284e7 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1877,7 +1877,7 @@ IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_KEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_KEYBOARD ) )
{
aSpellTimer.Start();
return 0; // dann spaeter wieder...
diff --git a/sd/source/ui/tools/IdleDetection.cxx b/sd/source/ui/tools/IdleDetection.cxx
index 4ba6163..e0fba1a 100644
--- a/sd/source/ui/tools/IdleDetection.cxx
+++ b/sd/source/ui/tools/IdleDetection.cxx
@@ -59,7 +59,7 @@ sal_Int32 IdleDetection::GetIdleState (const ::Window* pWindow)
sal_Int32 IdleDetection::CheckInputPending (void)
{
-if
[Libreoffice] [PUSHED] Fix for Bug fdo#41997 clean VCL enumeration
Hi Olivier, On Fri, 2011-10-21 at 17:15 -0200, Olivier Hallot wrote: The following patch fixes bug fdo41997. https://bugs.freedesktop.org/show_bug.cgi?id=41997 Wow - no sooner than I filed it, it got closed :-) great work. I pushed the patch, it looks like you caught all the cases in mac / win32; any chance you can close the bug ? If you had more time, cleaning up the whole enumeration to be VCL_ prefixed would be nice too, and of course it'd be great to have a statement of MPL/LGPLv3+ for your patches linked at: http://wiki.documentfoundation.org/Development/Developers if you have a minute ? Much appreciated though - it should make the Windows compile that bit nicer :-) [ have you tried setting up the MingW build ? it's particularly good for showing off these windows specific warnings - of which there are a large number :-] Oh - and ! really great to see you in Paris, and hope you got back uneventfully ;-) All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gbuild: use gb_CHECKOBJECTOWNER to check for double linked objects
On Fri, 2011-10-21 at 21:02 +0200, Michael Stahl wrote: have replaced this implementation with a new, faster one: Nice work :-) but perhaps that just means my new machine is too fast; perhaps somebody wants to benchmark it on their netbook/Alpha box/ARM wristwatch You know I always knew I wanted that ARM wristwatch for something. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for Bug fdo#41997 clean VCL enumeration
Hi Michael Em 21-10-2011 17:51, Michael Meeks escreveu: Hi Olivier, On Fri, 2011-10-21 at 17:15 -0200, Olivier Hallot wrote: The following patch fixes bug fdo41997. https://bugs.freedesktop.org/show_bug.cgi?id=41997 Wow - no sooner than I filed it, it got closed :-) great work. I pushed the patch, it looks like you caught all the cases in mac / win32; any chance you can close the bug ? Will do... I found bugzilla quite strange these days with big red banner each time I submit something... If you had more time, cleaning up the whole enumeration to be VCL_ prefixed would be nice too, you mean prefix VCL_ to the remaining enumeration? like INPUT_PAINT INPUT_MOUSEANDKEYBOARD etc...? I thought to do it, but did'nt dare to go beyond strict instructions (me quite shy). and of course it'd be great to have a statement of MPL/LGPLv3+ for your patches linked at: http://wiki.documentfoundation.org/Development/Developers if you have a minute ? Done. Let me know if this is enough. Much appreciated though - it should make the Windows compile that bit nicer :-) [ have you tried setting up the MingW build ? it's particularly good for showing off these windows specific warnings - of which there are a large number :-] This is for me to go boldly where no man never went before... but I don't have green blood or sharp ears, so i'll try. Oh - and ! really great to see you in Paris, and hope you got back uneventfully ;-) like any 11 hours flight in economy class... quite chewed. Kind regards -- Olivier Hallot Founder, Steering Commitee Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
On Fri, 2011-10-21 at 18:16 +0200, Stephan Bergmann wrote: Unfortunately, this breaks the build, as basic now has a (missing) dependency on sfx2, which already depends on basic. Fair enough, my mistake. I dropped sfx from the link line, it's not actually required, leaving the link dependencies the same as Library_sb.mk - the beautiful unit test still passes nicely. Thanks for the heads up :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Hi, I have added the feature with screenshot to the ReleaseNotes. Stephan: I'm compiling the code and will test the patch when it is done. M.V.G. Rob Snelders On vr 21 okt 2011 17:53:31 CEST, Michael Meeks wrote: Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. Great to see that :-) Any chance you could drop a nice screenshot / feature note and your name at: http://wiki.documentfoundation.org/ReleaseNotes/3.5 which saves lots of time later when it comes to building the 3.5 release notes. Thanks again, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] IDL hyper / Java long
Calc add-ins do not support functions that take or return UNO type hyper. .. however, it should work if the .idl file instead uses unsigned hyper ... This is why I started this topic. Moreover, NetBeans Wizard for Calc add-ins shows Java int and this is mapped correctly as long in IDL. But there is no Java long. You have to choose double or Object. On the other hand unsigned hyper works fine. So, why there is int in Wizard... use double instead. If you write a code and you want long you use long not double with Math.round(). Am I the first one who wants clean long in Calc add-in? - Marcin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] vcl: Printing UI page range autofocus
When the user selects Pages radio button in the Range section, it is very
reasonable to expect that she would now want to specify the range. Thus moving
the focus automatically to the page range edit box would save the user a mouse
click.
Code is contributed under the LGPLv3+ / MPL.
Signed-off-by: Maxim Iorsh io...@users.sourceforge.net
---
vcl/source/window/printdlg.cxx | 21 +
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 969030c..5a59281 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -2300,6 +2300,27 @@ IMPL_LINK( PrintDialog, UIOption_RadioHdl, RadioButton*, i_pBtn )
sal_Int32 nVal = it-second;
pVal-Value = nVal;
+// when page range option is selected, focus on range input.
+if (pVal-Name.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( PrintContent ) )
+nVal == 1)
+{
+std::map rtl::OUString, std::vector Window* ::const_iterator pit = maPropertyToWindowMap.find( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( PageRange ) ) );
+if( pit != maPropertyToWindowMap.end() )
+{
+const std::vector Window* rWindows( pit-second );
+if( ! rWindows.empty() )
+{
+// we should have an Edit for this one
+Edit* pRange = dynamic_cast Edit* ( rWindows.front() );
+if( pRange )
+{
+pRange-SetSelection( Selection( 0, 0x ) ); // select all
+pRange-GrabFocus();
+}
+}
+}
+}
+
checkOptionalControlDependencies();
// update preview and page settings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Feature branch gtk3 about to be merged - asking for Mac tests
Hi there, currently uploading a Mac testbuild of the feature/gtk3 branch to http://dev-builds.libreoffice.org/daily/Mac_OSX_10.6.0_gcc-4.0.1_x86/feature_gtk3_LibO-Dev_OOO350m1_MacOS_x86_install_en-US.dmg I checked that it starts basic functionality works, but would be cool if people with some spare cycles could give it a go over the weekend - we're especially interested in differences relative to e.g. http://dev-builds.libreoffice.org/daily/Mac_OSX_10.6.0_gcc-4.0.1_x86/master/current/master~2011-10-20_21.36.14_LibO-Dev_OOO350m1_MacOS_x86_install_en-US.dmg Thanks a lot, -- Thorsten pgpsZPRODeGE5.pgp Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 --- Comment #6 from j...@curioussymbols.com 2011-10-20 23:26:06 PDT --- Created attachment 52614 -- https://bugs.freedesktop.org/attachment.cgi?id=52614 Auto-renamed cell -- very hard to spot -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 --- Comment #7 from j...@curioussymbols.com 2011-10-20 23:31:34 PDT --- On my Ubuntu 11.10 machine, the automagically added underscore prefix is very hard to see. I didn't see it until I went looking. LibreOffice is changing my label without telling me, and then when I attempt to use my label in a formula is highlighting it as though it has 'understood' the label, when in fact it is highlighted a cell somewhere way over to the right, off-screen. I think this is more than just an aesthetic problem, at best I'd say its a misleading usability problem. Debugging spreadsheets is hard at the best of times, and the loss of accurate highlighting with named cells makes this much harder when LibreOffice silently renames names... The changes that would personally make me really happy would be, for example * visual warning about cell names being renamed (eg a Comment being added to first-named cell to alert the user that the name is not what was requested) * fix the parser that deals with formula highlighting so that it consults the name list as well as simple cell coordinates. Perhaps this is tricky because you can have a named column, but use of a name refers only to a single cell in the column. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42029] can't access pickers with smaller LO window
https://bugs.freedesktop.org/show_bug.cgi?id=42029 --- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-20 23:38:22 PDT --- @Kevin: You are right, i did a wrong interpretation of the original report in Bug 34725. So this one is a DUP of my misinterpretation, but not of reporter's intention. Thank you for your attention. I will check what activities already have been started for Bug 34725 and then divide these different issues somehow. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41996] EDITING Can't move slides in slide sorter
https://bugs.freedesktop.org/show_bug.cgi?id=41996 --- Comment #3 from Phil Evans p...@star.le.ac.uk 2011-10-20 23:42:08 PDT --- My version are: LO: 3.4.3 OOO340m1 (Build:201) Kubuntu 11.10 x86_64 Linux 3.0.0-12-generic And I can confirm that it DOES work in single line layout, and I think I know why, as the problem is more subtle than I realised. Actually, in any layout of the slide sorter, when I click and hold on a slide I first get the circle with a line, however, if I click on the slide and drag the cursor to the start of the row (i.e. to the left of the first slide in the row) suddenly I get the option to slide it there, and thereafter, I can (as long as I don't release the mouse button) put the slide anywhere. i.e. I *can* move slides in the slide sorter, but only pretending I want to put it at the start of the row, waiting for the slide icon to appear, and then moving it to where I want. Which is somewhat bizarre! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41412] EDITING TABLE: CRASH when using Keyboard cell merging function
https://bugs.freedesktop.org/show_bug.cgi?id=41412 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-21 07:07:54 PDT --- NOT reproducible with parallel installation of Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: 308b7a2-e916bf9-9c6ea62-e1a2fb3)] (daily/MinGW_cross-compilation 2011-10-18_22.56.49) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42092] New: EXPORT PDF with SVG becomes BITMAP
https://bugs.freedesktop.org/show_bug.cgi?id=42092 Bug #: 42092 Summary: EXPORT PDF with SVG becomes BITMAP Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other OS/Version: Mac OS X (All) Status: UNCONFIRMED Severity: major Priority: medium Component: PDF export AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: rk...@yahoo.com Perhaps this is not an error, but it should not be the default behavior. When an SVG picture is exported with the default PDF settings then the resulting PDF file converts the SVG to BITMAP or Raster graphics. The BITMAP PDF file size is 123KB (see PDF_lossless.pdf). When an SVG picture is exported with the A-1a PDF settings then the resulting PDF file maintains the SVG as scalable graphics. However, the A-1a PDF file size is 475KB (see PDF_A-1a.pdf); much too big for a basic scalable PDF file. Of course, a PDF file with A-1a information is useful when desired. Shouldn't the default behavior of an EXPORT to PDF maintain the scalable pictures and have a reduced file size? Of course, when desired the ability to EXPORT a PDF with scalable pictures to raster images is also useful, but we believe that it should not be the default behavior. As an example, we tested the desired functionality in the Master: LibO-dev 3.5.0 Build ID: 1af9425-947bf60-9c6ea62-e1a2fb3 On OSX 10.6.8 Located at: http://dev-builds.libreoffice.org/daily/MacOSX_10.6.7_Intel_no-moz/master/2011-10-21_07.55.40/ with master~2011-10-21_07.55.40_LibO-Dev_OOO350m1_MacOS_x86_install_en-US.dmg Steps to reproduce: 1. Use a Web browser or Graphic Editor to find and save an SVG picture. 2. Open a new WRITER Text Document 3. Select Insert - Picture - From File... (We inserted organick_Chemistry_set.svg) 4. Select File - Export as PDF 5. Keep the default settings then click Export (see the 3 Export as PDF_lossless.png). Expected results: SVG image will remain scalable within WRITER, DRAW, etc. Actual results: SVG image is NOT scalable. See attachment for sample documents and screenshots (including the scalable Export to PDF as A-1a and export warning). Also check the same problems with the blue_folder_1067B.svg file. Thank you. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42092] EXPORT PDF with SVG becomes BITMAP
https://bugs.freedesktop.org/show_bug.cgi?id=42092 --- Comment #1 from rk...@yahoo.com 2011-10-21 07:29:18 PDT --- Created attachment 52616 -- https://bugs.freedesktop.org/attachment.cgi?id=52616 EXPORT PDF with SVG becomes BITMAP Examples and Screenshots When initially submitting this attachment we received the following Bugzilla Error: Bugzilla has suffered an internal error. Please save this page and send it to sitewrangl...@lists.freedesktop.org with details of what you were doing at the time this message appeared. URL: https://bugs.freedesktop.org/post_bug.cgi Traceback: at Bugzilla/Mailer.pm line 186 Bugzilla::Mailer::MessageToMTA(...) called at Bugzilla/BugMail.pm line 591 Bugzilla::BugMail::sendMail(...) called at Bugzilla/BugMail.pm line 431 Bugzilla::BugMail::Send(...) called at /srv/bugs.freedesktop.org/www/post_bug.cgi line 252 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42097] New: match function fails with brackets ()
https://bugs.freedesktop.org/show_bug.cgi?id=42097 Bug #: 42097 Summary: match function fails with brackets () Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ad...@different-perspectives.com If you use the match function and the text strings contain brackets ( or ) then no match will be found. This is with match type=0. If the brackets are converted into, e.g. _, in both search table using convert then the text matches. Other types of brackets not tested. Other types of special characters not tested. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42098] New: help text is invisible
https://bugs.freedesktop.org/show_bug.cgi?id=42098 Bug #: 42098 Summary: help text is invisible Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: Other OS/Version: Mac OS X (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Documentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: s...@kaleberg.com All the other formatting items are present, but the text itself is invisible in the help browser. You can even search the text, and it will draw a little box around the white space where the word you found would appear if there was actually any text visible. Is this a font problem? (Font Doctor says I'm OK in 10.6.8.) Is there a way to specify another text font that might be visible on the screen or printer? What font is being used for the help text? Are there possibly multiple fonts? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42099] New: PRINTING: #10 Envelope Size Misdefined?
https://bugs.freedesktop.org/show_bug.cgi?id=42099 Bug #: 42099 Summary: PRINTING: #10 Envelope Size Misdefined? Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: fli...@gmail.com Using Writer with Windows XP and HP LaserJet 4 with HP accessory envelope feeder to do merge prints. Printing worked fine in OOO 3.2, although I had issue with merge print failing to print final fields. Merge issue is fixed in both current releases of LO (3.3.4 and 3.4.3), but Writer wants to print a blank envelope after each printed one. I tried printing to a file, and the file looks fine, but when you try to print that file, it's the same issue -- blanks between printed envelopes. I took the output file from LibreOffice and opened it in OOO 3.2, and that prints the blank envelopes, too, so it's likely a page-size format problem in whatever output from LibreOffice. I suspect the envelope height may be misdefined at 4.13. The actual height for a #10 envelope is 4.125. Are these parameters accessible anywhere without having to rebuild the app from source? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42100] New: EasyHack: calc sheet tab widget ...
https://bugs.freedesktop.org/show_bug.cgi?id=42100 Bug #: 42100 Summary: EasyHack: calc sheet tab widget ... Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other OS/Version: All Status: UNCONFIRMED Severity: major Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: michael.me...@novell.com The calc sheet-tab widget is normally at the bottom left of the grid and makes it easy to add and remove sheets. Recently we added a nice '+' widget to this to allow adding a sheet. It seems to me that on a very wide screen - we don't do a wonderful job of allocating enough space for tabs; I can easily have only ~10% of the screen containing my tabs, and the rest as a huge scrollbar - which is quite annoying. It'd be nice to tweak that balance, so more tabs are visible as a proportion of the screen space. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42101] New: Base report and form windows drawn distorted
https://bugs.freedesktop.org/show_bug.cgi?id=42101 Bug #: 42101 Summary: Base report and form windows drawn distorted Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: x86 (IA32) OS/Version: Linux (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Database AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: lukas.piet...@freenet.de Created attachment 52620 -- https://bugs.freedesktop.org/attachment.cgi?id=52620 Form design window in LibreOffice base. Position of window border is off by about 4 cm horizontally and 1 cm vertically from position of window contents. This is LibreOffice 3.4.3 on the current release of Xubuntu (11.10 Oneiric). In all daughter windows displaying forms or reports, the window contents are drawn displaced from the window borders by an offset of several centimeters, in random directions. The window contents thus occupy a space that overlaps, and partly obscures, the space occupied by the window border and title bar. Both the window contents and the functional elements of the title bar (dragging, resizing, max/min buttons) remain functional to the extent that they are not obscured, but the effect is so distracting as to make the whole program virtually unuseable. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
