[Libreoffice-commits] .: 2 commits - svx/source
svx/source/fmcomp/fmgridif.cxx | 63 -
1 file changed, 31 insertions(+), 32 deletions(-)
New commits:
commit 3a183d773f837a57671377a22808f66b2ff535ca
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Tue Nov 1 08:04:28 2011 +0100
translate comments
diff --git a/svx/source/fmcomp/fmgridif.cxx b/svx/source/fmcomp/fmgridif.cxx
index 1240562..1367c9f 100644
--- a/svx/source/fmcomp/fmgridif.cxx
+++ b/svx/source/fmcomp/fmgridif.cxx
@@ -527,8 +527,8 @@ void SAL_CALL FmXGridControl::createPeer(const Reference
::com::sun::star::awt:
if (!getPeer().is())
{
mbCreatingPeer = sal_True;
-// mbCreatingPeer is virtually the same as m_nPeerCreationLevel,
but it's the base class' method
-// to prevent recursion.
+// mbCreatingPeer is virtually the same as m_nPeerCreationLevel, but
it's the base class' method
+// to prevent recursion.
Window* pParentWin = NULL;
if (rParentPeer.is())
@@ -542,19 +542,17 @@ void SAL_CALL FmXGridControl::createPeer(const Reference
::com::sun::star::awt:
DBG_ASSERT(pPeer != NULL, FmXGridControl::createPeer : imp_CreatePeer
didn't return a peer !);
setPeer( pPeer );
-// lesen der properties aus dem model
+// reading the properties from the model
// ++m_nPeerCreationLevel;
updateFromModel();
-// folgendes unschoene Szenario : updateFromModel fuehrt zu einem
propertiesChanged am Control,
-// das stellt fest, dass sich eine 'kritische' Property geaendert hat
(zum Beispiel Border) und
-// legt daraufhin eine neue Peer an, was wieder hier im createPeer
landet, wir legen also eine
-// zweite FmXGridPeer an und initialisieren die. Dann kommen wir in
der ersten Inkarnation aus
-// dem updsateFromModel raus und arbeiten dort weiter mit dem pPeer,
das jetzt eigentlich schon
-// veraltet ist (da ja in der zweiten Inkarnation eine andere Peer
angelegt wurde).
-// Deswegen also der Aufwand mit dem PeerCreationLevel, das stellt
sicher, dass wir die in dem
-// tiefsten Level angelegte Peer wirklich verwenden, sie aber erst im
top-level
-// initialisieren.
+// consider the following ugly scenario: updateFromModel leads to a
propertiesChanges on the Control,
+// which determines, dat a critical property has changed (e.g.
Border) and therefore starts a new
+// Peer, which lands again here in createPeerm we also start a second
FmXGridPeer and initialise it.
+// Then we exit from the first incarnation's updateFromModel and
continue working with the pPeer,
+// that is in fact now already obsolete (as another peer is being
started in the second incarnation).
+// Therefore the effort with the PeerCreationLevel, which ensures that
we really use the Peer
+// created at the deepest level, but first initialise it in the
top-level.
// if (--m_nPeerCreationLevel == 0)
{
DBG_ASSERT(getPeer().is(), FmXGridControl::createPeer : something
went wrong ... no top level peer !);
@@ -601,9 +599,9 @@ void SAL_CALL FmXGridControl::createPeer(const Reference
::com::sun::star::awt:
// forward the design mode
sal_Bool bForceAlivePeer = m_bInDraw !maComponentInfos.bVisible;
-// (we force a alive-mode peer if we're in draw, cause in
this case the peer will be used for drawing in
-// foreign devices. We ensure this with the visibility check
as an living peer is assumed to be noncritical
-// only if invisible)
+// (we force an alive-mode peer if we're in draw, cause in this
case the peer will be used for drawing in
+// foreign devices. We ensure this with the visibility check as an
living peer is assumed to be noncritical
+// only if invisible)
Any aOldCursorBookmark;
if (!mbDesignMode || bForceAlivePeer)
{
@@ -1145,7 +1143,7 @@ FmXGridPeer::FmXGridPeer(const Reference
XMultiServiceFactory _rxFactory)
,m_pGridListener(NULL)
,m_xServiceFactory(_rxFactory)
{
-// nach diesem Constructor muss Create gerufen werden !
+// Create must be called after this constructure
m_pGridListener = new GridListenerDelegator( this );
}
@@ -1167,7 +1165,7 @@ void FmXGridPeer::Create(Window* pParent, WinBits nStyle)
// want to hear about row selections
pWin-setGridListener( m_pGridListener );
-// Init muß immer aufgerufen werden
+// Init must always be called
pWin-Init();
pWin-SetComponentInterface(this);
@@ -1392,7 +1390,7 @@ Sequence Any SAL_CALL FmXGridPeer::queryFieldData(
sal_Int32 nRow, const Type
DbGridRowRef xPaintRow = pGrid-GetPaintRow();
ENSURE_OR_THROW( xPaintRow.Is(), invalid paint row );
-// die Columns des Controls brauche ich fuer GetFieldText
+
[Libreoffice-commits] .: filter/source
filter/source/msfilter/svdfppt.cxx |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
New commits:
commit 812aff65ad0661fed9687a429c763dc8f2144a0c
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Tue Oct 25 19:49:34 2011 +0200
Fix fdo#41245 : Auto fit text VIEWING too small in PPT
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index bb1e8b3..fc987b8 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -1073,12 +1073,10 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream rSt,
DffObjData rObjData, voi
}
pTObj-SetMergedItem( SvxFrameDirectionItem( bVerticalText ?
FRMDIR_VERT_TOP_RIGHT : FRMDIR_HORI_LEFT_TOP, EE_PARA_WRITINGDIR ) );
-if (bAutoFit)
+//Autofit text only if there is no auto grow height and width
+//See fdo#41245
+if (bAutoFit !bAutoGrowHeight !bAutoGrowWidth)
{
-// disable both, defeats purpose of autofit
-// otherwise
-bAutoGrowHeight = sal_False;
-bAutoGrowWidth = sal_False;
pTObj-SetMergedItem(
SdrTextFitToSizeTypeItem(SDRTEXTFIT_AUTOFIT) );
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - svtools/source
svtools/source/control/valueset.cxx | 52 +++-
1 file changed, 34 insertions(+), 18 deletions(-)
New commits:
commit 77090e4e2515aefe547618487cdc96fde567e595
Author: David Tardon dtar...@redhat.com
Date: Tue Nov 1 10:10:03 2011 +0100
remove superfluous casts
diff --git a/svtools/source/control/valueset.cxx
b/svtools/source/control/valueset.cxx
index a3d38f0..1a75dd2 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1438,8 +1438,7 @@ void ValueSet::KeyInput( const KeyEvent rKEvt )
else if ( nCalcPos = mnCols ) // we can go up
{
if ( nCalcPos = ( nLineCount * mnCols ) )
-nItemPos = sal::static_int_cast sal_uInt16 (
-nCalcPos - ( nLineCount * mnCols ));
+nItemPos = nCalcPos - ( nLineCount * mnCols );
else
// Go to the first line. This can only happen for
KEY_PAGEUP
nItemPos = nCalcPos % mnCols;
@@ -1482,8 +1481,7 @@ void ValueSet::KeyInput( const KeyEvent rKEvt )
else if ( nCalcPos + mnCols = nLastItem ) // we can go
down
{
if ( nCalcPos + ( nLineCount * mnCols ) = nLastItem )
-nItemPos = sal::static_int_cast sal_uInt16 (
-nCalcPos + ( nLineCount * mnCols ));
+nItemPos = nCalcPos + ( nLineCount * mnCols );
else
// Go to the last line. This can only happen for
KEY_PAGEDOWN
nItemPos = lcl_gotoLastLine(nLastItem, mnCols,
nCalcPos);
commit 3acbdb2dee458cba6904a636733f1777b47e9fc1
Author: David Tardon dtar...@redhat.com
Date: Tue Nov 1 10:07:44 2011 +0100
let PgUp/Down go to the first/last line
diff --git a/svtools/source/control/valueset.cxx
b/svtools/source/control/valueset.cxx
index 5834f59..a3d38f0 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1318,6 +1318,20 @@ void ValueSet::Tracking( const TrackingEvent rTEvt )
// ---
+namespace
+{
+
+size_t
+lcl_gotoLastLine(size_t const nLastPos, size_t const nCols, size_t const
nCurPos)
+{
+size_t nItemPos = nLastPos+1)/nCols)-1)*nCols)+(nCurPos%nCols);
+if ( nItemPos+nCols = nLastPos )
+nItemPos = nItemPos + nCols;
+return nItemPos;
+}
+
+}
+
void ValueSet::KeyInput( const KeyEvent rKEvt )
{
size_t nLastItem = mpImpl-mpItemList-size();
@@ -1419,16 +1433,18 @@ void ValueSet::KeyInput( const KeyEvent rKEvt )
if ( nLastItem+1 = mnCols )
nItemPos = mnCurCol;
else
-{
-nItemPos =
nLastItem+1)/mnCols)-1)*mnCols)+(mnCurCol%mnCols);
-if ( nItemPos+mnCols = nLastItem )
-nItemPos = nItemPos + mnCols;
-}
+nItemPos = lcl_gotoLastLine(nLastItem, mnCols,
mnCurCol);
}
-else if ( nCalcPos = ( nLineCount * mnCols ) )
-nItemPos = sal::static_int_cast sal_uInt16 (
-nCalcPos - ( nLineCount * mnCols ));
-else
+else if ( nCalcPos = mnCols ) // we can go up
+{
+if ( nCalcPos = ( nLineCount * mnCols ) )
+nItemPos = sal::static_int_cast sal_uInt16 (
+nCalcPos - ( nLineCount * mnCols ));
+else
+// Go to the first line. This can only happen for
KEY_PAGEUP
+nItemPos = nCalcPos % mnCols;
+}
+else // wrap around
{
if ( mpNoneItem )
{
@@ -1440,11 +1456,7 @@ void ValueSet::KeyInput( const KeyEvent rKEvt )
if ( nLastItem+1 = mnCols )
nItemPos = nCalcPos;
else
-{
-nItemPos =
nLastItem+1)/mnCols)-1)*mnCols)+(nCalcPos%mnCols);
-if ( nItemPos+mnCols = nLastItem )
-nItemPos = nItemPos + mnCols;
-}
+nItemPos = lcl_gotoLastLine(nLastItem, mnCols,
nCalcPos);
}
}
nCalcPos = nItemPos;
@@ -1467,10 +1479,16 @@ void ValueSet::KeyInput( const KeyEvent rKEvt )
{
[Libreoffice-commits] .: scp2/source solenv/bin
scp2/source/python/module_python.scp | 21 +
solenv/bin/make_installer.pl |3 ++-
2 files changed, 23 insertions(+), 1 deletion(-)
New commits:
commit 055995086474821207313bacabe50bd9b9d7774c
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Nov 1 11:14:16 2011 +0100
Made ooinstall more deterministic, fixed Mac OS X Python module
dependencies.
diff --git a/scp2/source/python/module_python.scp
b/scp2/source/python/module_python.scp
index d80bc16..32f0dc8 100644
--- a/scp2/source/python/module_python.scp
+++ b/scp2/source/python/module_python.scp
@@ -34,7 +34,28 @@ Module gid_Module_Optional_Pyuno
MOD_NAME_DESC ( MODULE_OPTIONAL_PYTHON );
ParentID = gid_Module_Optional;
Sortkey = 750;
+Dirs = (gid_Dir_PythonFramework,
+gid_Dir_PythonFramework_Versions,
+gid_Dir_PythonFramework_Versions_ver,
+gid_Dir_PythonFramework_Versions_ver_bin,
+gid_Dir_PythonFramework_Versions_ver_lib,
+gid_Dir_PythonFramework_Versions_ver_lib_pythonver,
+gid_Dir_PythonFramework_Versions_ver_lib_pythonver_config);
Files =
(gid_File_Pyuno,gid_File_Lib_Pyuno,gid_File_Lib_Pythonloader,gid_File_Py_Unohelper,gid_File_Py_Officehelper,gid_File_Py_Uno,gid_File_Py_Pythonloader,gid_File_Py_Python_Core,gid_File_Py_Python_Bin,gid_File_Lib_Python_So,gid_Shortcut_Lib_Python_So,gid_File_Scripts_Python,gid_File_Share_Registry_Pyuno_Xcd);
+Unixlinks = (gid_Unixlink_Python_Headers,
+ gid_Unixlink_Python_Resources,
+ gid_Unixlink_Python_Versions_Current,
+ gid_Unixlink_Python_Versions_ver_Headers,
+ gid_Unixlink_Python_OOoPython,
+ gid_Unixlink_Python_bin_idle,
+ gid_Unixlink_Python_bin_pydoc,
+ gid_Unixlink_Python_bin_python_real,
+ gid_Unixlink_Python_bin_python,
+ gid_Unixlink_Python_bin_pythonconfig,
+ gid_Unixlink_Python_bin_pythonw_real,
+ gid_Unixlink_Python_bin_pythonw,
+ gid_Unixlink_Python_bin_smtpdpy,
+ gid_Unixlink_Python_libpython);
Minimal = NO;
Default = YES;
Styles = ( );
diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index fd1df27..10dac77 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -1309,7 +1309,8 @@ for ( my $n = 0; $n =
$#installer::globals::languageproducts; $n++ )
my $found_epm = 0;
# shuffle array to reduce parallel packaging process in pool
-installer::worker::shuffle_array($packages);
+installer::worker::shuffle_array($packages)
+unless $installer::globals::simple;
# iterating over all packages
for ( my $k = 0; $k = $#{$packages}; $k++ )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7cac55174385bb278c4ae979bcf31f106072798e Author: Caolán McNamara caol...@redhat.com Date: Tue Nov 1 10:37:18 2011 + case matters diff --git a/configure.in b/configure.in index b1c9e18..6052587 100644 --- a/configure.in +++ b/configure.in @@ -6956,7 +6956,7 @@ AC_MSG_CHECKING([whether to enable GConf support]) if test $_os != WINNT -a $_os != Darwin -a $enable_gconf = yes; then ENABLE_GCONF=TRUE AC_MSG_RESULT([yes]) -PKG_CHECK_MODULES( GCONF, gconf-2.0 orbit-2.0 ) +PKG_CHECK_MODULES( GCONF, gconf-2.0 ORBit-2.0 ) else AC_MSG_RESULT([no]) fi ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sfx2/source
sfx2/source/appl/appmisc.cxx | 26 --
1 file changed, 26 deletions(-)
New commits:
commit 9df6f53a88fb5e6d6c9ea430eb1f6d426ea7f755
Author: Caolán McNamara caol...@redhat.com
Date: Tue Nov 1 12:31:11 2011 +
impl_loadBitmap is now dangling unused
diff --git a/sfx2/source/appl/appmisc.cxx b/sfx2/source/appl/appmisc.cxx
index 119b8a5..6e76d44 100644
--- a/sfx2/source/appl/appmisc.cxx
+++ b/sfx2/source/appl/appmisc.cxx
@@ -280,32 +280,6 @@ sal_Bool SfxApplication::IsDowning() const { return
pAppData_Impl-bDowning; }
SfxDispatcher* SfxApplication::GetAppDispatcher_Impl() { return
pAppData_Impl-pAppDispat; }
SfxSlotPool SfxApplication::GetAppSlotPool_Impl() const { return
*pAppData_Impl-pSlotPool; }
-static bool impl_loadBitmap(
-const rtl::OUString rPath, const rtl::OUString rBmpFileName,
-Image rLogo )
-{
-rtl::OUString uri( rPath );
-rtl::Bootstrap::expandMacros( uri );
-INetURLObject aObj( uri );
-aObj.insertName( rBmpFileName );
-SvFileStream aStrm( aObj.PathToFileName(), STREAM_STD_READ );
-if ( !aStrm.GetError() )
-{
-// Use graphic class to also support more graphic formats (bmp,png,...)
-Graphic aGraphic;
-
-GraphicFilter rGF = GraphicFilter::GetGraphicFilter();
-rGF.ImportGraphic( aGraphic, String(), aStrm, GRFILTER_FORMAT_DONTKNOW
);
-
-// Default case, we load the intro bitmap from a seperate file
-// (e.g. staroffice_intro.bmp or starsuite_intro.bmp)
-BitmapEx aBmp = aGraphic.GetBitmapEx();
-rLogo = Image( aBmp );
-return true;
-}
-return false;
-}
-
/** loads the application logo as used in the about dialog and impress
slideshow pause screen */
Image SfxApplication::GetApplicationLogo()
{
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: svx/source
svx/source/svdraw/svdhdl.cxx | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
New commits:
commit 54c7480a6cdb049a5b0c907fa86af42068dcae16
Author: Michael Meeks michael.me...@suse.com
Date: Tue Nov 1 12:21:49 2011 +
add real alpha to markers
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 62ee66b..14f4289 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -101,18 +101,10 @@ public:
#define INDIVIDUAL_COUNT(4)
SdrHdlBitmapSet::SdrHdlBitmapSet(sal_uInt16 nResId)
-: maMarkersBitmap(),
+: maMarkersBitmap(ResId(nResId, *ImpGetResMgr())),
// 14 kinds (BitmapMarkerKind) use index [0..5], 4 extra
-maRealMarkers((KIND_COUNT * INDEX_COUNT) + INDIVIDUAL_COUNT)
+maRealMarkers((KIND_COUNT * INDEX_COUNT) + INDIVIDUAL_COUNT)
{
-// #101928# change color used for transparent parts to 0x00ff00ff
(ImageList standard)
-const Color aColTransparent(0x00ff00ff);
-const Bitmap aBitmap(ResId(nResId, *ImpGetResMgr()));
-const Bitmap aMask(aBitmap.CreateMask(aColTransparent));
-
-// create a real BitmapEx with an AlphaMask
-maMarkersBitmap = BitmapEx(aBitmap, aMask);
-// maMarkersBitmap = BitmapEx(aBitmap, aColTransparent);
}
SdrHdlBitmapSet::~SdrHdlBitmapSet()
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' - vcl/unx
vcl/unx/kde4/KDEXLib.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9f55aac9e3e8f96249d23d392c553afe56f6411d Author: David Tardon dtar...@redhat.com Date: Fri Jul 22 08:04:07 2011 +0200 this is definitely not present in Qt 4.8.0 beta1 Signed-off-by: Thorsten Behrens tbehr...@suse.com Signed-off-by: Tomáš Chvátal scarab...@gentoo.org Signed-off-by: Petr Mladek pmla...@suse.cz diff --git a/vcl/unx/kde4/KDEXLib.cxx b/vcl/unx/kde4/KDEXLib.cxx index ca435c8..5e03033 100644 --- a/vcl/unx/kde4/KDEXLib.cxx +++ b/vcl/unx/kde4/KDEXLib.cxx @@ -57,7 +57,7 @@ #include stdio.h -#if QT_VERSION = QT_VERSION_CHECK( 4, 8, 0 ) +#if QT_VERSION = QT_VERSION_CHECK( 4, 8, 1 ) #define QT_UNIX_EVENT_LOOP_SUPPORT #ifdef KDE_HAVE_GLIB #define GLIB_EVENT_LOOP_SUPPORT ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' - instsetoo_native/util solenv/inc
instsetoo_native/util/openoffice.lst | 16 solenv/inc/minor.mk |4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) New commits: commit a06eb9bcbf26d31aab014d8aa2476dc4d628bb1a Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 14:09:52 2011 +0100 bump product version to 3.4.4-rc2, release number to 402 diff --git a/instsetoo_native/util/openoffice.lst b/instsetoo_native/util/openoffice.lst index c981a32..7266218 100644 --- a/instsetoo_native/util/openoffice.lst +++ b/instsetoo_native/util/openoffice.lst @@ -57,7 +57,7 @@ LibreOffice PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION rc1 + SHORT_PRODUCTEXTENSION rc2 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.4 @@ -125,7 +125,7 @@ LibreOffice_wJRE PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION rc1 + SHORT_PRODUCTEXTENSION rc2 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.4 @@ -189,7 +189,7 @@ LibreOffice_Dev PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION rc1 + SHORT_PRODUCTEXTENSION rc2 BASISROOTNAME LibO-dev UNIXBASISROOTNAME lo-dev POSTVERSIONEXTENSION @@ -266,7 +266,7 @@ URE PRODUCTEXTENSION BRANDPACKAGEVERSION 3.4 LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION rc1 +SHORT_PRODUCTEXTENSION rc2 LICENSENAME LGPL SETSTATICPATH 1 NOVERSIONINDIRNAME 1 @@ -305,7 +305,7 @@ LibreOffice_SDK PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION rc1 +SHORT_PRODUCTEXTENSION rc2 POSTVERSIONEXTENSION SDK POSTVERSIONEXTENSIONUNIX sdk BRANDPACKAGEVERSION 3.4 @@ -351,7 +351,7 @@ LibreOffice_Dev_SDK PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION -SHORT_PRODUCTEXTENSION rc1 +SHORT_PRODUCTEXTENSION rc2 BASISROOTNAME LibO-dev UNIXBASISROOTNAME lo-dev POSTVERSIONEXTENSION SDK @@ -403,7 +403,7 @@ OxygenOffice PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION rc1 + SHORT_PRODUCTEXTENSION rc2 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.4 @@ -473,7 +473,7 @@ OxygenOffice_wJRE PRODUCTVERSION 3.4 PRODUCTEXTENSION LONG_PRODUCTEXTENSION - SHORT_PRODUCTEXTENSION rc1 + SHORT_PRODUCTEXTENSION rc2 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 3.4 diff --git a/solenv/inc/minor.mk b/solenv/inc/minor.mk index 75772f2..f44858d 100644 --- a/solenv/inc/minor.mk +++ b/solenv/inc/minor.mk @@ -1,5 +1,5 @@ RSCVERSION=340 -RSCREVISION=340m1(Build:401) -BUILD=401 +RSCREVISION=340m1(Build:402) +BUILD=402 LAST_MINOR=m1 SOURCEVERSION=OOO340 ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - setup_native/source
setup_native/source/mac/ooo/DS_Store |binary 1 file changed New commits: commit 4fc80f9a1dcd3a1705a0e4c2b092a3804ca4b554 Author: Thorsten Behrens tbehr...@suse.com Date: Tue Nov 1 14:26:25 2011 +0100 Fix .dmg background image some more. Signed-off-by: Alexander Thurgood alex.thurg...@gmail.com diff --git a/setup_native/source/mac/ooo/DS_Store b/setup_native/source/mac/ooo/DS_Store index 9431578..fec0edc 100644 Binary files a/setup_native/source/mac/ooo/DS_Store and b/setup_native/source/mac/ooo/DS_Store differ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' - setup_native/source
setup_native/source/mac/ooo/DS_Store |binary 1 file changed New commits: commit 70f195ae368055dcb87c29de11f784983314ae20 Author: Thorsten Behrens tbehr...@suse.com Date: Tue Nov 1 14:26:25 2011 +0100 Fix .dmg background image some more. Signed-off-by: Alexander Thurgood alex.thurg...@gmail.com Signed-off-by: Fridrich Strba fst...@suse.com Signed-off-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/setup_native/source/mac/ooo/DS_Store b/setup_native/source/mac/ooo/DS_Store index 9431578..fec0edc 100644 Binary files a/setup_native/source/mac/ooo/DS_Store and b/setup_native/source/mac/ooo/DS_Store differ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' - filter/source
filter/source/msfilter/svdfppt.cxx |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
New commits:
commit a9eec7d971e04974de188e7fc64710428027528d
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Tue Oct 25 19:49:34 2011 +0200
Fix fdo#41245 : Auto fit text VIEWING too small in PPT
Signed-off-by: Thorsten Behrens tbehr...@suse.com
Signed-off-by: Jan Holesovsky ke...@suse.cz
Signed-off-by: Petr Mladek pmla...@suse.cz
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index b773a08..760e726 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -1088,12 +1088,10 @@ SdrObject* SdrEscherImport::ProcessObj( SvStream rSt,
DffObjData rObjData, voi
}
pTObj-SetMergedItem( SvxFrameDirectionItem( bVerticalText ?
FRMDIR_VERT_TOP_RIGHT : FRMDIR_HORI_LEFT_TOP, EE_PARA_WRITINGDIR ) );
-if (bAutoFit)
+//Autofit text only if there is no auto grow height and width
+//See fdo#41245
+if (bAutoFit !bAutoGrowHeight !bAutoGrowWidth)
{
-// disable both, defeats purpose of autofit
-// otherwise
-bAutoGrowHeight = sal_False;
-bAutoGrowWidth = sal_False;
pTObj-SetMergedItem(
SdrTextFitToSizeTypeItem(SDRTEXTFIT_AUTOFIT) );
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/macros-test.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 06899e6b77f5ca878ba7fd8b60bb62f5f97e90a2 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Tue Nov 1 11:02:45 2011 -0400 Re-enabling the macros test. It was due to those pesky .~lock* files preventing the test files from being loaded. Maybe this is also what's breaking the mac os build!? diff --git a/sc/qa/unit/macros-test.cxx b/sc/qa/unit/macros-test.cxx index aff5bc5..22faa26 100644 --- a/sc/qa/unit/macros-test.cxx +++ b/sc/qa/unit/macros-test.cxx @@ -126,7 +126,6 @@ public: void testStarBasic(); void testVba(); CPPUNIT_TEST_SUITE(ScMacrosTest); -#if 0 #ifndef MACOSX //enable this test if you want to play with star basic macros in unit tests //works but does nothing useful yet @@ -135,7 +134,6 @@ public: //does not work, still problems during loading CPPUNIT_TEST(testVba); #endif -#endif CPPUNIT_TEST_SUITE_END(); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhmAAoJEPQ0oe+v7q6jqs4QAIK2GXHZMPaWVSyRpwNUthvA
SYEcJ4DMeBez44GiaZvVbaV8EjJuPT6d+ZUngtWI5vHyu5mMOogv4yMWHJwdHFo+
hoq4asdCt/wIqZm9qCJnwOM734ilYsF5k70qgMf/s80DP+VYUJ3RdMBFwv5SMJZU
8GJ6BB3026R59Slha4kgPgwMi0JbVkx3zDUrROX7snGU1nZVC9IXfer3YhXeJRBl
tun5Gio4UGlCrDURgydWCUnVj4IgblCsW5cK3MX8AuY8b1u2DUV/L/py42oscMOR
6q/MJPXAXhTiMiLE3bV+T3/J8kb/AUjc92h5vM4b+2PndenmZm3sui122FEYFEz/
4+qqlxtz83lbYoIzwmaRaRlDtrMp8k6fXWYD01xt4kFa8lzE3Yb06zCQlnt+KCa/
fOwReiScQBEtlRL6s/rJV5dkV67gq6QtyPobda3EmiGP3sS83W4bmsl4NEZOTmVK
ivL5mrxE7lmmL2//JbNbo5UTsGbhQFMTmygb9ZVjaTqpCf8QOUMdZ9Rhlly2tS0t
9ohz2c5JZYGmL/UkP1f/lQFRGFQubwi1qwuZX7qP61cVuG4k6AMWKbwMQuN9wAY6
ssx21tF/4yBffmD9GUa4KinolITPaPoy8MPpOE10pfwXUNU7Xd3L51mO6P3Kbw5k
kmmT5YG/ltWYMwHtjEp6
=Ielj
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-1:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhnAAoJEPQ0oe+v7q6jzQYP/RLjVJE/iUnr6fDwAMuriDzC
+UwLQGh0ZQ0KOjmpbfgCVy0ri+uHvZxUaZRUfHiXAHwSLIE7jAUm46gv+aHqBI78
KFb3z6ZOg2QarksmZNYeqkVDeyA8LB6Dl/utzGJ7Yeq9tGHnuZeXbo7oWGCh9aJl
/NE+LKrE28Q444K3mMSyeD/B/WwiyyNvtCwastSIBeRtkVvtues9SPnUg585U+qD
E4dcqn6cFUrSXMiYn7nDqClzIm86jovHr/CN/7LNWgV7KDKMUuzQ4xSMSpEs8pOo
urQ6a8t9HydEdt+Oxa2Qdp0uRg4yhKSU311bOBSPBRokE1a7ltNQTHc4x53014hn
bZHyA+rjLxEXbkidaWwgLn8iLF1BZpjmhNSdj9uMTZjSnSoiOMZ46pbqiXf2BrI5
kmQf8GjqorwMwAOu1ygmd0dYJFHLV8DmyKu+c8niP0xwJkYkendb79cgUu3Fzx0k
ru7kEPM/VWHTpxcfM1+B7DpWYcukP3GQ6lZJ2aEm1uOPQGYdX69qfoxChKbU7a2t
KUtpfbP+L7txVOg55gG4PfpcGicgME3ZAvDzxGXIizM7H6QNUTR0OFgjws84Izdg
NitYvE3Zu1AGaSPP/6N6Q/sfXRdI9+s7ZCpAIEBIwyYs48bM/iRQjBxlRVXWLX8t
d9EMgrlUgITezWyMkMzN
=sdT7
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-3:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhnAAoJEPQ0oe+v7q6jSmcQAI0X310bZ3Q6ihHqSn52ohi2
z6fR96ZaeBStQtyNQ3oBcoaV7iLo9lWy6cvRfumsUjyvCycJS1ivLrq1PFksL8wF
UWttuvY08BXWXB+r/n4skBzvQ9naeku0dzIpDF+7/FAqS/gYTnbMyg1votCHmzFS
6V+XPVLwD02K6Ze2GbJBYvqAHr8QywBG54ddBvETmqKwOkHcSq8p3y42+bI17Vcc
GYmxZyHy/YvdERa1wNuydDWHENKsppsMnZMlAmZlcpZHXqTZxEJuUc/x1HFlTCdk
1Yd8d4quMDcxVggFPIhaU6/JVrye1DmHJA4xrYbhctw+fU11xnBkIBTKJEriKtvm
kHWXCyrF+2PDncwtsYmxFwmtm1l5OLicq1a+ObX0/NKEuq+fFeYEqCHS9ZnngXUw
k0dh86CaEd+wYgcVp+t4TN6gbmYfCwluVX4WzvnDcjrjoIWVTa5qBgX/fGp63N/j
BcjA//Ujjp6TzvPctV93AgDCq/NH7Th7Y2deRdY2T8qIl04UJP6qXCWTDFhnnkhX
3I5EO+RN7Kw7sgn45H3IuQjeyVCzAD6EORYG9AOxOulw1Qxy+nVgSn6tBgvf2W7q
o2LzvFbtQAkWPT3f/KmlvE8osuKk3cXjyfuYzWzpv9TY4g/MvX2f+87GLLaUGRFn
MDnQpwPD3IyOW2pKgiR4
=afOl
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-2:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhnAAoJEPQ0oe+v7q6jrcEP/3GimC6HhXAkByGEMWswT5OU
oAGtHI4/O04Aipw/hEpuc7YMnSsvH/aFblwAHkRIFCOzYE4EdbaI6OnsBH5zldOq
R0HklGs6dym9cb8Yf+10uQxPXQaJF7oUgRgTqiPSKSJpzT30SLIYRn4SwUKawGFT
tQM5KvflQ6VvYC8clUyKddj2eTIiItwRDz97JLHiyZ/aNQ9TAeOx7K1Q0Uaq5QNg
xypKV7YFI8nHDIdvGjRPZfDM0TwxbW1/eavY1pQs6FmTQHpDjWCfkhJM0zRa5Haa
qRzfsFW4ch4OvDS37jBGF9B5Ap42aTTLGHuBI/4yJY2wR8/HqRkSRmhQL0U3kpjK
cOGThVXVConpr1v6seeSAihC1NxoxDXfXd+l0tQd5Zlo763paG9Oz+j/ICdXRtGw
QsZ3rC8hiyP7pLd+ziQsdsaEfbShARfozrYZ6MPYPI5GhWqK9+qRgz0HsZ9IMuNh
yMZTZu78AGMAPtA7979XbtlrP3WuLDAopvTgh5YvcmR6VyTovPimNm+PUscwj36X
BxiEW6w4aFX7d3/rtCH2qwdPe2VCZIcoan2u9oIg+we5Wz/JUhYRIvd6AvsfDxAw
hLt3BelslWyDF/25n554+fWXQw4FJtJ3Umg3uIhAmTsiYINpBXeXznP0FSKKf115
T/yn1jUrWw5vKRCmB+2n
=Ebb0
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-1:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhoAAoJEPQ0oe+v7q6jji4P/3ECB5l524T3GQceklVLI3Fh
XLTbmRSIuCFYgJ0pPoYJjBnxfc7oEbVq3CAwjjmhcQDe4v6p4jJING2QHnkJZjcM
vQWPiWJWkfvUfCW4jXb5u70ZLjietcignb/P8PG/SgC/9Vd2sSZWNxyy5l6XhP2v
6/C15fKLT31Ba145JNNlTyHrsJpSs1LIvfvxKfljIWyS5ApRRd7suhc6c/TOUBds
m4MscejPRQaBcLd2dDyK+O70MFCLDae58+ilKruPtMEtSN+jS7VjhQloT/fU6kbb
LMVFvp5tGSoxrJNFhOuQEQJxcNndyQn4HKfb179cOvBGSIyEUG1HZ4n2Of0q1BhX
hNP77hK0tA5YTQH4eYlUdZR+x6fcAhCWtitEu8akwoXmKbWoI866GPIGz0WSz/1O
POQOwfk1ssvaw8agmmzYbHFnklT0lv9388QWzgaXierRAWiIIKzJd2++4V6lTiWU
vpcbxdRRicv1uWs+UA1M/vyYWkmJG5Z3zNqYKAacNbkheGUpDt5ejOGdwgn1vrwq
dMVAYyN+ZX5+EfWAX5pVtlesMqXe405ZFLqCaXdK8u0ItL2RQ6b+iVKM+rc+R94H
fKBfn7dql3ZEMoqOq5KjKqR8rdPd9pITvM8Pq2gRgoZs2aCWRXnlHdHkIA7tMqIq
t/5lzkX6PavJ4n//tSGd
=8uDv
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-3:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhoAAoJEPQ0oe+v7q6j3lkP/iX6PWp8Wh/WYLTeTQFukF6E
jjnvRc7Ng8zJ562keXihvGNxPx4tOSDS8IFu/Y/W3GfPwt3590KTM0XT6kzpmABy
PWoOcurvC4CfCPDwUDfhwMZpIIDNZWh6BcD++5EA+PBUylXe/n3DglrHNxHeSNxb
VJH8I/nJtuMmEQ5A2ub37Odo+7XcdwA/RVm+oo/7Q9nZiEWiN5Xoo67Ir5GPb9qU
gVTqx0soYDWZS0HU2PLzbD294+UZdfgt/vrlh83HR/vajD/KxjxkqAzh+kqlbFld
89l8fZxq1fchsd6OQyNEX0A7yTwLSt8HnKpKobwwHAIhroz/sN0hdhmahgmfpoem
Kk0JtVcQugucjjo0og4XmcHaEf8LkQ/fAEHKarJSH2a8rRiXeaPWcvG0zYtBPrpK
s3cnkkjv/5P5edVyIi16Jx0OMN7SMBy5pPvOhpD92nGD/e+otmmryNyimi+vYxCC
SF1HQ6jtOiyDi2GaHTpn4aZcWZHq4NkksUH8A2FGhQGNtVqfPJGwaBGue5YVAv2C
W6PugUtT6vC0qBnUOMrkFJ0Z5dIsgvkMnbNMt6kvn3XpwwRsSwT4KCuBH+R0U8Xu
U6sxQD2IC0320WbXMC5fs/GVuU+P9KB70O/3He7fEwwmxLnXlUVPuCWjG2F/4c2P
Vthl44ZO7xcwwBrXajLN
=GVKN
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-1:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.4.4.2'
Tag 'libreoffice-3.4.4.2' created by Petr Mladek pmla...@suse.cz at
2011-11-01 17:03 -0700
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJOsBhpAAoJEPQ0oe+v7q6j6UYP/040nxhDw9M8WnhlBMrsWSMZ
SszRu4nTo8NhSIF148dN7hRrlu19VIUElXTVAbHyUX+hRPf9f24/PUR3IvTDDPIM
Rs+PHKCVHS3pA6jKNH7OryWE3S4Nli/eWNR5+Vm0GkjCxuMO3TPJP8IdkRfasjrx
TbO3JweabMY8w5tBy/tDNi6wiJvDf3TNstEzYIb68Hc+e18aRZVF5W1fTDfmkvPv
uIgfIETSN3AqS2/KSfD6fKJt4ZsCZ8lSMVO7yyZ88b09qWOZSqnCOm+qK01i40WU
naROpwaa6eYYvKNIfJe3GfKw/SxHmbRnaXa3H0zVKtxQocfcrOJtd+x56REqUN6U
GTZN4c0IBQWJivWJ2Qf04q615SofMeOnu1kYQfJ4YvmFBra9wzWUCBBGrJDZ7kGX
DDNf7ktX1tPZHBFWGuAHyJE4AzI08k72qSfzx+d85pVP6ygWT4reKXZp1VwwgFzE
vNnO32DFYhBJZYtHi2caXzHkib7uZVis8s/UxoF3GzbKuiM2quKoTwoLDRd1P8//
UEwIoCfUT6jj95qCSOJgrKrfHP6cMpieeiZnUG0joX/Wwwe39xu4DcuNHrrCBsN8
6SBpMA8lVyb9gO/v6h74f9zPt9Fyd++McI3KTnFDOLh/+GC1Ap7d/a441BtiJ+xk
QDgaVnaU47EqfZ1/X290
=zZpl
-END PGP SIGNATURE-
Changes since libreoffice-3.4.4.1-1:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit 40d16076eb4b9f8ff290e86cce97eee5f752ae69 Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:28 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit e4932719656f64deb97b82a857310c32930acceb Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:30 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit a2aab04ac7693dd035c6a34b7cf38756447cb97f Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:31 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit 93f165c6f41a52398c6d489ced7c07ae6b32dceb Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:32 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit 11182e1b3ebceefdf1f9917c5487b458bf83b773 Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:32 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit 1277520c28e73cead1067d5bbff78b482ca6c09f Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:32 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit fab5d49f7014d2974e0dcc2ee2af8169aae8d5a4 Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:32 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4-4' -
0 files changed New commits: commit 43b4d23f6fa1e42c57c2488a03d00d88460320d1 Author: Petr Mladek pmla...@suse.cz Date: Tue Nov 1 17:03:33 2011 +0100 Version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/core/tool/scmatrix.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit cf0dd2113527ba0a601c5c59de7f7f44da161d21
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Nov 1 21:56:10 2011 +0100
prevent access to non existing mdds elements (fdo#41807)
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 6044003..1767fce 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -591,8 +591,10 @@ bool ScMatrixImpl::IsEmpty( SCSIZE nC, SCSIZE nR ) const
bool ScMatrixImpl::IsEmptyPath( SCSIZE nC, SCSIZE nR ) const
{
// 'Empty path' is empty plus non-zero flag.
-ValidColRowReplicated( nC, nR );
-return maMat.get_type(nR, nC) == ::mdds::element_empty
maMat.get_flag(nR, nC) != 0;
+if (ValidColRowReplicated( nC, nR ))
+return maMat.get_type(nR, nC) == ::mdds::element_empty
maMat.get_flag(nR, nC) != 0;
+else
+return true;
}
bool ScMatrixImpl::IsValue( SCSIZE nIndex ) const
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/data/contentCSV/spreadsheet-functions.csv |4 ++-- sc/qa/unit/data/ods/functions.ods|binary 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 0eae161aa3bd0a7abef6f9a5cf6afef171b09704 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Nov 1 23:09:17 2011 +0100 add tests related to fdo#41807 diff --git a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv index da53433..83a33b2 100644 --- a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv +++ b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv @@ -1,4 +1,4 @@ $C$2, $A$1, Sheet.B$2, Sheet!R2C2 -2, 4, 4, 5, 6, 15, 15, 6 +2, 4, 4, 5, 6, 15, 15, 6, 9 1, 3, 4, 4, 2, 2 -2, 4, 7, 8 +2, 4, 7, 8, 4 diff --git a/sc/qa/unit/data/ods/functions.ods b/sc/qa/unit/data/ods/functions.ods index 2317473..cfdd263 100644 Binary files a/sc/qa/unit/data/ods/functions.ods and b/sc/qa/unit/data/ods/functions.ods differ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/data/contentCSV/bugFix_Sheet2.csv |6 ++ sc/qa/unit/data/ods/bug-fixes.ods|binary sc/qa/unit/filters-test.cxx |6 +- 3 files changed, 11 insertions(+), 1 deletion(-) New commits: commit 84ae3c9853b7b90d7b859fd562dabc7b31e8deb8 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Nov 2 00:49:39 2011 +0100 add test cases for fdo#40967 diff --git a/sc/qa/unit/data/contentCSV/bugFix_Sheet2.csv b/sc/qa/unit/data/contentCSV/bugFix_Sheet2.csv new file mode 100644 index 000..c6fbdda --- /dev/null +++ b/sc/qa/unit/data/contentCSV/bugFix_Sheet2.csv @@ -0,0 +1,6 @@ +success +fail +success +fail +success +fail diff --git a/sc/qa/unit/data/ods/bug-fixes.ods b/sc/qa/unit/data/ods/bug-fixes.ods index dcdbd69..6864235 100644 Binary files a/sc/qa/unit/data/ods/bug-fixes.ods and b/sc/qa/unit/data/ods/bug-fixes.ods differ diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx index 059ef17..74a9006 100644 --- a/sc/qa/unit/filters-test.cxx +++ b/sc/qa/unit/filters-test.cxx @@ -599,7 +599,11 @@ void ScFiltersTest::testBugFixesODS() CPPUNIT_ASSERT_MESSAGE(Failed to load bugFixes.ods, xDocSh.Is()); ScDocument* pDoc = xDocSh-GetDocument(); -CPPUNIT_ASSERT_MESSAGE(No Document, pDoc); //remove with first test + +rtl::OUString aCSVFileName; + createCSVPath(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(bugFix_Sheet2.)), aCSVFileName); +testFile(aCSVFileName, pDoc, 1); + xDocSh-DoClose(); } ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - smoketestoo_native/makefile.mk
smoketestoo_native/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0d1b57b3b1c47b3d2348ca6b37ab0074c728896b Merge: 0bcda87... 84ae3c9... Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 1 20:28:21 2011 -0400 Merge ssh://git.freedesktop.org/git/libreoffice/core commit 0bcda87664af59e01f4e1048991e5cf752547556 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 1 20:24:57 2011 -0400 fix smoketest linkage diff --git a/smoketestoo_native/makefile.mk b/smoketestoo_native/makefile.mk index cd80184..8c7d811 100755 --- a/smoketestoo_native/makefile.mk +++ b/smoketestoo_native/makefile.mk @@ -42,7 +42,7 @@ SHL1IMPLIB = i$(SHL1TARGET) SHL1TARGET = smoketest SHL1OBJS = $(SLO)/smoketest.obj SHL1RPATH = NONE -SHL1STDLIBS = $(CPPUHELPERLIB) $(CPPULIB) $(CPPUNITLIB) $(SALLIB) $(TESTLIB) +SHL1STDLIBS = $(CPPUHELPERLIB) $(CPPULIB) $(CPPUNITLIB) $(SALLIB) $(UNOTESTLIB) SHL1USE_EXPORTS = name DEF1NAME = $(SHL1TARGET) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38817, which changed state. Bug 38817 Summary: LibreOffice Base will not hide the record marker https://bugs.freedesktop.org/show_bug.cgi?id=38817 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Status of #39093
Hello all, Could any please anyone please get me up to date on the status of #39093 https://bugs.freedesktop.org/show_bug.cgi?id=39093 Thanks and best regards, Nguyen Vu Hung ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW 3-4] 3.4.4rc1 fails to build in kde4 vcl
On Mon, Oct 31, 2011 at 06:15:55PM +0100, Andreas Radke wrote: Am Mon, 31 Oct 2011 09:50:31 +0100 schrieb David Tardon dtar...@redhat.com: On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote: On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote: On Saturday 29 October 2011 21:30:29 Andreas Radke wrote: Compiling: vcl/unx/source/dtrans/config.cxx /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void KDEXLib::setupEventLoop()': /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error: 'GetUnixSelectFunction' is not a member of 'QInternal' /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error: 'SetUnixSelectFunction' is not a member of 'QInternal' This is probably due to Qt 4.8 and not our bug I guess. Eh, no? If it needs fixes due to Qt 4.8, that should be done here so we compile against newer Qts. It has been done already. That code should only be used if QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be defined if Qt version is at least 4.8.1 . If there is no chance that http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt 4.8.1, we should IMHO bump the check to 4.9.0. D. Any chance you post a fix for 3.4.4 branch? Or I would have to disable the qt vcl for this release. Oops, I thought I did that back in July... Unfortunately, we just missed a deadline for 3.4.4 RC2 and I doubt this will be considered a blocker, so you will have to wait for 3.4.5. Could anyone sign-off commit 887b8ed0655fb59f9208058e811e5373b3928c2c in libs-gui for 3.4? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Fixes fdo#41245
Jan Holesovsky wrote: Thank you very much for the patch! - CCing Thorsten who is I believe familiar with autofit :-) Thorsten - can you please check? Good catch, works like a charm - pushed. -- Thorsten pgpGpWFymbXa7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4] [PATCH] Fixes fdo#41245
Jan Holesovsky wrote: Thank you very much for the patch Indeed, in fact this is useful for -3-4 as well - pushed there, too. Cheers, -- Thorsten pgpTR8RunATg9.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4] [REVIEW 3-4] 3.4.4rc1 fails to build in kde4 vcl
David Tardon wrote: Could anyone sign-off commit 887b8ed0655fb59f9208058e811e5373b3928c2c in libs-gui for 3.4? Done. -- Thorsten pgpGfYk4l9Xhh.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (real) Windows build, needs help.
I am trying this now out on a clean checkout, I will report maybe at the end of the day. F. On 29/10/11 06:03, Bjoern Michaelsen wrote: On Fri, Oct 28, 2011 at 10:19:59PM -0400, Kohei Yoshida wrote: Perhaps I shall attach your patch here for your perusal. :-) see attachment. fixed? Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] updating dictionary repository URL
Lior Kaplan wrote: Although there's a problem with the current dictionary repository URL (see fdo #42408), it's still important to have the address identical though the code. Adding a patch to align the address in cui/source/options/optlingu.cxx Hi Lior, it seems the consensus in the quoted issue is to solve that server-side - I'd kinda like to wait with applying until the admins have hashed it out there, ok? Cheers, -- Thorsten pgp7e8DMsHICN.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Status of #39093
Nguyen Vu Hung (kiei) wrote: Could any please anyone please get me up to date on the status of #39093 https://bugs.freedesktop.org/show_bug.cgi?id=39093 All of the state is readily available in the bug comments. If you have new input, or any questions beyond actual code questions or patches, please put those to the bug. Cheers, -- Thorsten pgpoDJFwdYFYE.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Where to begin for fdo#39182 (Impress changes background to black saving .odp to .ppt)
julien2412 wrote: I'd like to take a look at the fdo#39182 (FILESAVE LO Impress changes background to black saving .odp to .ppt) but I don't know where it could be. I searched on filters/source/powerpoint, but it seems it's not there. Where can I begin ? Hi Julien, great to see you tackling this bug - I'd start looking into sd/source/filter/eppt/epptso.cxx, PPTWriter::ImplWritePage() specifically. HTH, -- Thorsten pgpXcBvHZ6zhI.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing
On Mon, 2011-10-31 at 09:15 +0100, Stephan Bergmann wrote: However, I would also be sceptical that there are that many places that actually need to construct such an (immutable!) string---maybe at least some of the places are misguided attempts at preallocating some buffer of a given length? Those should then be rewritten to use rtl::OUStringBuffer instead. Worth noting that the ByteString Fill and Expand are now removed. So its just String that retains Fill/Expand. I handled the ByteString::Fill generally on a case-by-case basis. e.g. 565587eba10a8c4e01d4346669327bd9065c5dfa where the idea was simply to write 512 0's to disk Generally IIRC StringBuffers were the way to go. You can find padToLength in comphelper/inc/string.hxx which expands a buffer to the desired length and pads it with the requested character, which is pretty much an equivalent to the Expand concept anyway. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bugs 42340 and 42354 filed
Hi Pawan, On 2011-11-01 at 01:40 -0700, Pawan Vemuri wrote: For the bug 42430, I guess the changes to be made have to done in drawingml.cxx's WriteParagraphNumbering method. The final else block on that method adds the buchar where one should not be added. I also know that creation of the ppt model from the powerpoint 2003 ( .ppt) file works fine. The fix for this issue should hence involved using the ppt importer's logic of handling bullet-ed list and using a similar logic for pptx export. Wow - so this is some great progress! Beyond this , I am not sure about how to proceed on this as I am unaware of ppt model that libreoffice uses. Can someone help me on this. Yes - I think the best is to talk to Radek (cc'd). Ideally if you can get to our IRC (irc.freenode.net), channel #libreoffice-dev, and talk to rodo_ - or wait until he answers this mail :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing
On Tue, 2011-11-01 at 11:01 +, Caolán McNamara wrote: Generally IIRC StringBuffers were the way to go. You can find padToLength in comphelper/inc/string.hxx which expands a buffer to the desired length and pads it with the requested character, which is pretty much an equivalent to the Expand concept anyway. Which makes me wonder whether we should be moving comphelper's string.hxx methods into sal/ anyway - they look reasonably sensible seemingly (though the rtl_uString_alloc stuff looks like it should be done with a StringBuffer instead in each instance). Since they're mostly documented - are there some file-able easy hacks there ? Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (no subject)
How are you. I was messing around on the net and found this!! want a NFL Jersey you can pick any team there only giving out!! 84 NFL Jerseys! hurry up and get yours!! heres the link my friend.. http://sayabit.com/dbayoh/HTML ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fixes fdo#41245
Hi Arnaud, On 2011-10-31 at 17:25 +0100, Arnaud Versini wrote: Yes of course, LGPLv3+ and MPL. Thank you for that! Can you please add yourself + link to your mail with the statement to: https://wiki.documentfoundation.org/Development/Developers Thank you a lot, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Replace (Byte|Uni|Xub_)String with O(U)String: Fill() method is missing
On Tue, 2011-11-01 at 11:58 +, Michael Meeks wrote: Which makes me wonder whether we should be moving comphelper's string.hxx methods into sal/ anyway - they look reasonably sensible seemingly case-by-case basis generally. e.g. methinks now that NaturalStringSorter should go into i18nutil or there abouts, definitely not sal anyway. Some of them are just bridges for the old string class, like the pad stuff and getToken so they probably can stay out. matchL and search/replace are possible contenders. (though the rtl_uString_alloc stuff looks like it should be done with a StringBuffer instead in each instance). The foo_alloc stuff is moved in there from a somewhat confused-in-usage family of overlapping stuff found in i18npool/i18nutil. StringBuffer's ctor calls rtl_string_new_WithLength, comment on rtl_string_alloc describes how it differ's from that, e.g. no memset on contents. Using a StringBuffer puts you at something of an extra remove over the private pData in order to tweak its length. Didn't really fancy fighting the i18npool/i18nutil usages. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED][PATCH] eliminate SvUShorts type
On Sat, 2011-10-29 at 19:33 +0200, Daniel Di Marco wrote:
* SvSUhorts.GetData(): I replaced calls of vec.GetData() with
(*vec.begin()), e.g. in editeng/source/rtf/rtfitem.cxx:
I'm kind of a fan of vec[0] over (*vec.begin())
* sorting: qsort - std::sort, e.g. in cui/source/dialogs/iconcdlg.cxx:
-qsort( (void*)aUS.GetData(), aUS.Count(), sizeof(sal_uInt16),
IconcDlgCmpUS_Impl );
+std::sort( aUS.begin(), aUS.end() );
Yeah, seems perfectly sane.
* copying: memcpy - std::copy, e.g. in cui/source/dialogs/iconcdlg.cxx:
-memcpy(pRanges, aUS.GetData(), sizeof(sal_uInt16) * aUS.Count());
+std::copy( aUS.begin(), aUS.end(), pRanges );
Looks alright, these aren't particularly required to be massively
efficient anyway, so no need to over-think it.
Complete patch seems ok to me, though it can get a little tricky to keep
old and new in my head at the same time, so hopefully I didn't cock
anything up. Pushed now, thanks for these.
So, that's finally an end to SvUShorts, gone, dead as a parrot, pretty
cool.
FWIW, in an eye towards being able to blow away additional entire
families of these old-school macros, I think there might only be one or
two users of SvStringsISortDtor in inc/svl/svstdarr.hxx and if not that
specific one, I think at least one of those macro-based String things in
there is only used in one or two places.
C.
As an aside, vector::at checks that the argument is within size() and
throws if it isn't, so when we're in a loop where we know the size of
the vector it's not worth using the slower at() vs unchecked operator[]
IMO e.g.
const sal_uInt16 nCount = rIndexArray.size();
for( sal_uInt16 nIndex = 0; nIndex nCount; nIndex++ )
{
-const sal_uInt16 nElement = rIndexArray.GetObject( nIndex );
+const sal_uInt16 nElement = rIndexArray.at( nIndex );
}
I'd just do...
+const sal_uInt16 nElement = rIndexArray[nIndex];
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4] [REVIEW 3-4] 3.4.4rc1 fails to build in kde4 vcl
Thorsten Behrens píše v Út 01. 11. 2011 v 09:33 +0100: David Tardon wrote: Could anyone sign-off commit 887b8ed0655fb59f9208058e811e5373b3928c2c in libs-gui for 3.4? Tomas and me approved this fix and pushed it into 3-4-4 branch. So it will be in 3.4.4-rc2. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl
Andreas Radke píše v Po 31. 10. 2011 v 18:15 +0100: Am Mon, 31 Oct 2011 09:50:31 +0100 schrieb David Tardon dtar...@redhat.com: It has been done already. That code should only be used if QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be defined if Qt version is at least 4.8.1 . If there is no chance that http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt 4.8.1, we should IMHO bump the check to 4.9.0. We managed to get the proposed fix into 3.4.4-rc2. If the bug is not fixed in qt-4.8.1, we will need to bump the check again. Any chance you post a fix for 3.4.4 branch? Or I would have to disable the qt vcl for this release. You need not wait for official LO-release. You might patch the official sources. See http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?h=libreoffice-3-4-4id=9f55aac9e3e8f96249d23d392c553afe56f6411d for inspiration. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-4][REVIEW 3-4-4] 3.4.4rc1 fails to build in kde4 vcl
Once again with proper subject. I am sorry for the spam Thorsten Behrens píše v Út 01. 11. 2011 v 09:33 +0100: David Tardon wrote: Could anyone sign-off commit 887b8ed0655fb59f9208058e811e5373b3928c2c in libs-gui for 3.4? Tomas and me approved this fix and pushed it into 3-4-4 branch. So it will be in 3.4.4-rc2. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] master eat CPU even when it does nothing [fixed]
On Sat, 2011-10-29 at 07:12 +0200, Jean-Baptiste Faure wrote: In Writer: open a new text document and do nothing else = CPU ~100% of one core Should be fixed in master :-) more testing of course much appreciated. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] apple_remote module issue when building with mac sdk 10.6
Hi Jonathan, On 2011-10-30 at 20:55 +0100, Jonathan Aquilina wrote: This resolves the issue of apple remote crashing. Now it seems that cairo is failing, the output doesnt show anythign useful. How can i get a more useful output to debug. Sorry - this does not resolve the issue, it just moves it to a later time, when something from apple_remote is necessary. So, I don't think we want to push that patch. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED][PATCH] eliminate SvUShorts type
On Tue, 2011-11-01 at 12:30 +, Caolán McNamara wrote: So, that's finally an end to SvUShorts, gone, dead as a parrot, pretty cool. Nice work indeed ! :-) How far are we from killing all of these macro driven nightmares ? :-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] apple_remote module issue when building with mac sdk 10.6
On 11/1/11 2:06 PM, Jan Holesovsky wrote: Hi Jonathan, On 2011-10-30 at 20:55 +0100, Jonathan Aquilina wrote: This resolves the issue of apple remote crashing. Now it seems that cairo is failing, the output doesnt show anythign useful. How can i get a more useful output to debug. Sorry - this does not resolve the issue, it just moves it to a later time, when something from apple_remote is necessary. So, I don't think we want to push that patch. Regards, Kendy No worries kendy is there a way we can disable it via autogen.sh? i forgot which bug number, but it seems like apple remote is quite troublesome for people using older apple remotes. Regards Jonathan Aquilina Get a signature like this. CLICK HERE. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Bug #i89051
Hi, I dug into http://openoffice.org/bugzilla/show_bug.cgi?id=89051 and I've stalled... --Some explanations.-- When inserting a point there is a call to SdrDragView::ImpBegInsObjPoint (svx/source/svdraw/svddrgv.cxx). Inside it: - we remember the number of new point in a polypolygon: mnInsPointNum = pMarkedPath-NbcInsPoint*; - we call AdjustMarkHdl that calls SetMarkHandles. Inside SetMarkHandles we add all handles - including custom ones (anchors in Writer) and then sort handles. So, mnInsPointNum (see previous step) becomes invalid (in Wrtier). - we use [invalid] mnInsPointNum to get handle by its index *in SdrHdlList* (var aHdl) using remembered index *in polygon*: BegDragObj(rPnt, pOut, aHdl.GetHdl(mnInsPointNum), 0); So, we can use mnInsPointNum only if custom (and other) handles had placed *after* point handles in SdrHdlList. --Possible solutions.-- 1. Rearrange the following lines of the SetMarkHandles method (svx/source/svdraw/svdmrkv.cxx#805): // add custom handles (used by other apps, e.g. AnchorPos) AddCustomHdl(); // sort handles aHdl.Sort(); to: // sort handles aHdl.Sort(); // add custom handles (used by other apps, e.g. AnchorPos) AddCustomHdl(); 2. Tweak sorting of handles somehow - method Compare (svx/source/svdraw/svdhdl.cxx#1704) looks ugly... 3. Something else. Can someone provide some comments/tips/decisions? Thanks! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] master eat CPU even when it does nothing [fixed]
Le 01/11/2011 14:02, Michael Meeks a écrit : On Sat, 2011-10-29 at 07:12 +0200, Jean-Baptiste Faure wrote: In Writer: open a new text document and do nothing else = CPU ~100% of one core Should be fixed in master :-) more testing of course much appreciated. Thanks ! Michael. Thanks ! Build in progress. :-) JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED][PATCH] eliminate SvUShorts type
On Tue, Nov 1, 2011 at 8:30 AM, Caolán McNamara caol...@redhat.com wrote: So, that's finally an end to SvUShorts, gone, dead as a parrot, pretty cool. That's very cool indeed! I was dreaming of this day for a long time. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Ubuntu pt-BR carries BrOffice obsolete brand
Ubuntu carries obsolete BrOffice name for the pt-BR locale. That is long time over in branch 3.4 and beyond. Actually an Ubuntu bug, but, heck, too much bugzilla accounts to manage. -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-4] Background image missing in 3.4.4rc1 Mac OSX DMG
Christian Lohmaier wrote: is OK on 10.4/PPC Alexander Thurgood wrote: Your modded version shows up correctly on my 10.6.8 system. Thanks guys, with your approvals the feedback I got on irc, pushed to -3-4-4. Cheers, -- Thorsten pgp03f1GmA8g2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-4] [PATCH] Fixes fdo#41245
Thorsten Behrens píše v Út 01. 11. 2011 v 09:26 +0100: Jan Holesovsky wrote: Thank you very much for the patch Indeed, in fact this is useful for -3-4 as well - pushed there, too. Me and Kendy approved it = I pushed it into 3-4-4 branch for 3.4.4-rc2 as well. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] updating dictionary repository URL
On Tue, Nov 1, 2011 at 12:34 PM, Thorsten Behrens t...@documentfoundation.org wrote: Lior Kaplan wrote: Although there's a problem with the current dictionary repository URL (see fdo #42408), it's still important to have the address identical though the code. Adding a patch to align the address in cui/source/options/optlingu.cxx Hi Lior, it seems the consensus in the quoted issue is to solve that server-side - I'd kinda like to wait with applying until the admins have hashed it out there, ok? I'm part of that consensus, but the address they are going to enable is different from the one of this specific location in the code. The patch aligns this deviation from the regular referral, otherwise, this part of the code will still refer to a wrong URL even *after* the fix for fdo #42408. Kaplan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] updating dictionary repository URL
Lior Kaplan wrote: I'm part of that consensus, but the address they are going to enable is different from the one of this specific location in the code. The patch aligns this deviation from the regular referral, otherwise, this part of the code will still refer to a wrong URL even *after* the fix for fdo #42408. Eh. Got it now. Thanks for the fix, pushed to master - can you confirm this is under our usual LGPLv3+/MPL1.1 license? Cheers, -- Thorsten pgpJC2kVYzBdw.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] updating dictionary repository URL
On Tue, Nov 1, 2011 at 5:14 PM, Thorsten Behrens t...@documentfoundation.org wrote: Lior Kaplan wrote: I'm part of that consensus, but the address they are going to enable is different from the one of this specific location in the code. The patch aligns this deviation from the regular referral, otherwise, this part of the code will still refer to a wrong URL even *after* the fix for fdo #42408. Eh. Got it now. Thanks for the fix, pushed to master - can you confirm this is under our usual LGPLv3+/MPL1.1 license? Confirmed. Kaplan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Ubuntu pt-BR carries BrOffice obsolete brand
On Tue, Nov 01, 2011 at 11:36:56AM -0200, Olivier Hallot wrote: Ubuntu carries obsolete BrOffice name for the pt-BR locale. That is long time over in branch 3.4 and beyond. Actually an Ubuntu bug, but, heck, too much bugzilla accounts to manage. Filed as: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/884786 and targeted for the 3.4.4 SRU for oneiric. You are most cordially invited to test the Ubuntu Beta releases to identify these issues before release next time. ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] calendar
Hi Emile, On Tue, 2011-11-01 at 08:41 -0700, Emile Kempees wrote: To whom it may concern. This is a developers list. It is not a suitable forum for end-user questions. Please re-send your mail to the discuss list: disc...@documentfoundation.org Out of interest, where (on the web / elsewhere) did you find the LibreOffice developer's list address ? Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW 3-4] Fix incorrect mapping of external ranges
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d02007469d84b248bb623196cca95d431f7ed11 backported to the 3-4 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=40110 and IMO this is just a silly mistake, plus it's an entirely safe fix for the stable branch. Reviews sign-off's appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#40967: or and and won't work correctly in array formulas
Hey,
this patch fixes a problem with OR and AND in array formulas. The 3.3
code explicitly allowed boolean values and this patch allows them
again.
I think it is an extremely safe fix and should be included into 3-4.
Markus
From 45dac237294d5a069b32e9da79d5209200512ad0 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue, 1 Nov 2011 17:08:19 +0100
Subject: [PATCH] boolean values are valid for matrix evaluation (fdo#49967)
---
sc/source/core/tool/scmatrix.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index fcdf412..ac1c7a4 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -733,7 +733,7 @@ bool EvalMatrix(const MatrixImplType rMat)
for (size_t j = 0; j nCols; ++j)
{
matrix_element_t eType = rMat.get_type(i, j);
-if (eType != mdds::element_numeric eType == mdds::element_boolean)
+if (eType != mdds::element_numeric eType != mdds::element_boolean)
// assuming a CompareMat this is an error
return CreateDoubleError(errIllegalArgument);
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW 3-4] [PUSHED] Fix incorrect mapping of external ranges
Looks safe and correct to me. I'll push it to the 3-4 branch with my sign-off. 2011/11/1 Kohei Yoshida kohei.yosh...@suse.com: Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d02007469d84b248bb623196cca95d431f7ed11 backported to the 3-4 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=40110 and IMO this is just a silly mistake, plus it's an entirely safe fix for the stable branch. Reviews sign-off's appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Ubuntu pt-BR carries BrOffice obsolete brand
Hi Bjoern will test it as soon as available. Thanks Olivier Em 01-11-2011 13:31, Bjoern Michaelsen escreveu: On Tue, Nov 01, 2011 at 11:36:56AM -0200, Olivier Hallot wrote: Ubuntu carries obsolete BrOffice name for the pt-BR locale. That is long time over in branch 3.4 and beyond. Actually an Ubuntu bug, but, heck, too much bugzilla accounts to manage. Filed as: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/884786 and targeted for the 3.4.4 SRU for oneiric. You are most cordially invited to test the Ubuntu Beta releases to identify these issues before release next time. ;) Best, Bjoern -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#40967: or and and won't work correctly in array formulas
On Tue, Nov 1, 2011 at 12:18 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey, this patch fixes a problem with OR and AND in array formulas. The 3.3 code explicitly allowed boolean values and this patch allows them again. I think it is an extremely safe fix and should be included into 3-4. I concur. Pushed to the 3-4 branch with my sign-off. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.4.4.2 tag created (3.4.4-rc2)
Hi, there have been created the libreoffice-3.4.4.2 tag for 3.4.4-rc2 release. The corresponding official builds will be available by the end of the week. It will be used as final if no blocker is found. See the attached list of changes against 3.4.4-rc1. Now, you might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.4.4.2 libreoffice-3.4.4.2 See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + components + fix handling of SAFEARRAY(s) returned as variant in olebridge (fdo#38441) [Noel Power] + filters + fix : Auto fit text VIEWING too small in PPT (fdo#41245) [Arnaud Versini] + libs-core + fix the drawing of dotted and dashed borders in Calc (fdo#37129) [Tomofumi Yagi] + libs-gui + fix the drawing of dotted and dashed borders in Calc (fdo#37129) [Tomofumi Yagi] + writer + fix fallout - recognize .svg in odt container (fdo#41995) [Thorsten Behrens] + common + branch libreoffice-3-4-4 [Petr Mladek] + version 3.4.4.2, tag libreoffice-3.4.4.2 (3.4.4-rc2) [Petr Mladek] + bootstrap + bump product version to 3.4.4-rc2, release number to 402 [Petr Mladek] + remove a stray leading '+' [Fridrich Štrba] + use short paths, because '(x86)' in the path causes problem [Andras Timar] + components + fix .dmg background image some more. [Thorsten Behrens] + fix handling of SAFEARRAY(s) returned as variant in olebridge (fdo#38441) [Noel Power] + extensions + scottish Gaelic (gd) translation [Andras Timar] + filters + fix : Auto fit text VIEWING too small in PPT (fdo#41245) [Arnaud Versini] + libs-core + fix the drawing of dotted and dashed borders in Calc. (fdo#37129) [Tomofumi Yagi] + libs-extern-sys + moz ldap libraries: don't need LIBDIR to exist [Lionel Elie Mamane] + libs-gui + fix the drawing of dotted and dashed borders in Calc. (fdo#37129) [Tomofumi Yagi] + this is definitely not present in Qt 4.8.0 beta1 [David Tardon] + translations + translation update for LibreOffice 3.4.4 rc2 [Andras Timar] + writer + fix fallout - recognize .svg in odt container (fdo#41995) [Thorsten Behrens] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Ubuntu pt-BR carries BrOffice obsolete brand
Just for information, there are still references to BrOffice in Opengrok : http://opengrok.libreoffice.org/search?q=brofficeproject=coredefs=refs=path=hist= I don't know if these can be removed now or is there something to check or resolve before. -- View this message in context: http://nabble.documentfoundation.org/Ubuntu-pt-BR-carries-BrOffice-obsolete-brand-tp3470692p3471194.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gravity of raised assertions?
On Monday 31 of October 2011, Stephan Bergmann wrote: For me at least, this implies that all occurrences of firing assertions should be tracked and fixed. (For me at least, this also implies that assertions---OSL_ASSERT, OSL_ENSURE, OSL_FAIL, DBG_ASSERT---should only be used to flag illegal program states, not for unexpected but legal ones. I don't think there is objection to this view in general. I've only seen confusion about which macro was designed for which use case, and a sort of indifference a la half of the time, OSL_ASSERT etc. are used with the wrong semantics anyway; shrug.) I think the only feasible way of fixing this is introducing a new set of these macros (let's say LO_WARN, LO_ASSERT), deprecating the old ones and converting their usage to the new ones. Otherwise we'll never know which OSL_ASSERT is really meant to assert and which is just a warning. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gravity of raised assertions?
I know that it comes from Apache but what about http://logging.apache.org/log4cxx/ ? log4j is quite used in Java world, I don't know the state of log4cxx but it could help. -- View this message in context: http://nabble.documentfoundation.org/gravity-of-raised-assertions-tp3467970p3471278.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] some hints needed for fdo 42286 in calc
hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/.. tools/queryparam.cxx dbdata.cxx but it seems that there all is Ok. As I understand it, there the query is just prepared but I am not able to find the code where the actual calculation for displaying it is done. could someone hint me / give me a search criteria ? Just an additional remark: disassembling the bug's attached file, I see that the content.xml ends with some strange empty row definitions... But this still does not justify to appear witin the filter in my opinion. Or does this indicates the file is ill formatted ? (sorry, I do not know the oasis spec) table:table-row table:style-name=ro1 table:number-rows-repeated=1048532 table:table-cell table:number-columns-repeated=1024/ /table:table-row table:table-row table:style-name=ro1 table:visibility=filtertable:table-cell table:number-columns-repeated=1024/ /table:table-row table:table-row table:style-name=ro1 table:table-cell table:number-columns-repeated=1024/ /table:table-row table:table-row table:style-name=ro1 table:visibility=filtertable:table-cell table:number-columns-repeated=1024/ /table:table-row table:table-row table:style-name=ro1 table:table-cell table:number-columns-repeated=1024/ /table:table-row table:table-row table:style-name=ro1 table:visibility=filter table:number-rows-repeated=5 table:table-cell table:number-columns-repeated=1024/ /table:table-row etc all of this kind thanks for a hint regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice Online build
Hi Lucas! Great! Thanks for the tip! It works fine now! :) Best, Gustavo Pacheco. 2011/10/28 xapantu xapa...@gmail.com Hi Gustavo, It seems that you didn't use --with-system-cairo the first time you run autogen.sh, so, you still have a cairo.h/libcairo.so somewhere. Or at least, it is how I got this issue. So, if that is correct, you can restart from a clean git branch, or try to delete manually the non-cairo version, but it might be hard. I don't know if you know a lot of things about git (I don't...), but you can re-clone your local git repo to avoid re-downloading all the repository. Lucas 2011/10/28 Gustavo Pacheco gbpacheco.li...@gmail.com: Hi people! I'm on a long, but exciting, way to get a complete build of LibreOffice Online prototipe. Before start it, I have never built LibreOffice myself, then, I'm glad to increase my knowledge and, in a near future, I hope contribute to the project in some more advanced tasks. At moment, I'm just a newbie. Michael Meeks mentoring me with many great tips (many thanks Michael!). He also suggested to me that I share my steps here. I have finished my build of GTK+ 3.2 with --enable-x11-backend and --enable-broadway-backend. After solve all dependencies and compile it successful, I get run some little compiled gtk+3.2 samples in the browser using GDK_BACKEND=broadway ./myhelloworldfirefox http://127.0.0.1:8080/. On the LibreOffice side, I have finished OK my first builds of LibreOffice 3.5.0. To build the LibreOffice Online prototype, however, I have had problems when I use autogen with --enable-gtk3 and --with-system-cairo. I have stopped on an error inside vcl after 'make'. I tried to isolate the problem with make -sr. The output is at the end of this email. Anyone can help me? Thanks for any help! Gustavo Pacheco. My steps: $ git fetch --all $ git checkout feature/gtk3 $ pkg-config --cflags gtk+-3.0 $ pkg-config --libs gtk+-3.0 $ ./autogen.sh --with-num-cpus=4 --with-max-jobs=4 --without-junit --enable-graphite --without-java --enable-gtk3 --with-system-cairo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] some hints needed for fdo 42286 in calc
Hello, 2011/11/1 Pierre-André Jacquod pjacq...@alumni.ethz.ch: hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/.. tools/queryparam.cxx dbdata.cxx but it seems that there all is Ok. These are only the data structures holding the information for db data and query information. The query is executed in ScDBDocFunc::Query and related functions. I hope that helps you a bit otherwise just ask again or ask in libreoffice-dev. Regards, Markus P.S. Do you know if this is a regression against 3.3? Then it might be much easier to search for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Trinity Desktop Environment (TDE) desktop integraton for LibreOffice
On Monday 31 of October 2011, Timothy Pearson wrote:
And I don't remember any reply to my questions, and I don't see anything
changing since then, so they still stand: What are the reasons this is
done as a huge copypaste s/KDE/TDE/ patch?
Primarily so that we can start hacking on the TDE module without breaking
the KDE3 module, and also if you look at the patch the Qt classnames have
all been altered. The TDE developers are nearing the end of a yearlong
project to convert TDE to use those class names, and as soon as the final
transition is done the KDE3 module will be completely unbuildable, let
alone usable, on TDE.
If it's really only class name changes, then it's nothing that a couple of
typedef's or #define's wouldn't solve.
I have been discussing this with Michael Meeks, and basically if
LibreOffice would rather we hack up the KDE3 module to work with TDE that
is fine, but we will not be able to guarantee that our changes do not
seriously break the module when used under KDE3. I have serious concerns
about the maintainability of such code, including readability,
I picked a file at random, vcl/unx/kde/salnativewidgets-kde.cxx, compared it
with the TDE file from the patch, and if I ignore type name changes, the
differences boil down to the attached a.patch, which is 2 changes of less
than 20 lines in total, for a file that is 70k big. Second random file
picked, just in case, fpicker/source/unx/kde/kdefilepicker.cxx , is pretty
much identical (again minus the type name changes).
In other words, to me it looks like it would have been much less work to
create the TDE version by something like:
foo-tde.cxx:
#define BUILDING_TDE
#define QApplication QTApplication
...
#include foo-kde.cxx
foo-kde.cxx:
...
#ifdef BUILDING_TDE // or possibly even better #if TDE_IS_VERSION( 3,7,0 )
...
#endif
...
speed of patch acceptance (due to offsite KDE3 tests most likely being
mandatory), and how prone the code will be to accidental breakage.
If you start taking care of the KDE3/TDE code, you'll more or less end up
being the maintainer of it. People occassionally do a build fix or similar, I
rarely do a bugfix when I find the time and/or somebody whines a lot, but
that's about it I expect.
I would assume that TDE still maintains some kind of backwards
compatibility[*], so you should generally know whether your changes are safe
or whether it's something new that needs an #ifdef (in which case the
TDE_IS_VERSION check is needed anyway). If something slips through, it can
get fixed when somebody notices.
So I don't know the extent of the changes you plan in the code, but from what
I can see there does not seem to be a good reason to have a special copy of
the sources for TDE.
[*] I still don't see it said anywhere if TDE maintains any API backwards
compatibility with KDE3 or not. The configure checks in the patch search for
KDE3/Qt3 names, so I would assume the answer is yes. If not, then at least
that part of the patch is definitely wrong.
--
Lubos Lunak
l.lu...@suse.cz
--- /home/llunak/build/src/libo/vcl/unx/kde/salnativewidgets-kde.cxx 2011-10-31 13:32:50.598155002 +0100
+++ a.cxx 2011-11-01 17:57:00.640561003 +0100
@@ -392,11 +395,7 @@ WidgetPainter::WidgetPainter( void )
m_pToolBarVert( NULL ),
m_pToolButton( NULL ),
m_pMenuBar( NULL ),
- m_nMenuBarEnabledItem( 0 ),
- m_nMenuBarDisabledItem( 0 ),
m_pPopupMenu( NULL ),
- m_nPopupMenuEnabledItem( 0 ),
- m_nPopupMenuDisabledItem( 0 ),
m_pProgressBar( NULL )
{
}
@@ -1923,7 +1922,17 @@ void KDESalFrame::UpdateSettings( AllSet
aStyleSettings.SetFaceColor( aBack );
aStyleSettings.SetInactiveTabColor( aBack );
aStyleSettings.SetDialogColor( aBack );
-aStyleSettings.SetCheckedColorSpecialCase( );
+if( aBack == COL_LIGHTGRAY )
+aStyleSettings.SetCheckedColor( Color( 0xCC, 0xCC, 0xCC ) );
+else
+{
+Color aColor2 = aStyleSettings.GetLightColor();
+aStyleSettings.
+SetCheckedColor( Color( (BYTE)(((USHORT)aBack.GetRed()+(USHORT)aColor2.GetRed())/2),
+(BYTE)(((USHORT)aBack.GetGreen()+(USHORT)aColor2.GetGreen())/2),
+(BYTE)(((USHORT)aBack.GetBlue()+(USHORT)aColor2.GetBlue())/2)
+) );
+}
// Selection
aStyleSettings.SetHighlightColor( toColor( qColorGroup.highlight() ) );
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] some hints needed for fdo 42286 in calc
hello, and query information. The query is executed in ScDBDocFunc::Query and related functions. thanks I will look there come back if needed P.S. Do you know if this is a regression against 3.3? Then it might be No 3.3 available to test (and a bit short of place on HD). But happens on LibreOffice 3.4.2 OOO340m1 (Build:1206) (OpenSuse 11.4 distribution) and on master, build by myself (also OpenSuse 3.4.2) regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Trinity Desktop Environment (TDE) desktop integraton for LibreOffice
If it's really only class name changes, then it's nothing that a couple of typedef's or #define's wouldn't solve. Agreed. I picked a file at random, vcl/unx/kde/salnativewidgets-kde.cxx, compared it with the TDE file from the patch, and if I ignore type name changes, the differences boil down to the attached a.patch, which is 2 changes of less than 20 lines in total, for a file that is 70k big. Second random file picked, just in case, fpicker/source/unx/kde/kdefilepicker.cxx , is pretty much identical (again minus the type name changes). In other words, to me it looks like it would have been much less work to create the TDE version by something like: foo-tde.cxx: #define BUILDING_TDE #define QApplication QTApplication ... #include foo-kde.cxx foo-kde.cxx: ... #ifdef BUILDING_TDE // or possibly even better #if TDE_IS_VERSION( 3,7,0 ) ... #endif Yes, you are are correct here as well. Now that I have been away from the problem for a little while I am starting to think this approach is best--when it does finally come time for KDE3.5.10 to die the combined integration module can live on, permanently latched into TDE mode. If you start taking care of the KDE3/TDE code, you'll more or less end up being the maintainer of it. People occassionally do a build fix or similar, I rarely do a bugfix when I find the time and/or somebody whines a lot, but that's about it I expect. Yep, quite familiar with this. :-) I would assume that TDE still maintains some kind of backwards compatibility[*], so you should generally know whether your changes are We don't explicitly guarantee it, but the core TDE codebase is large and stable enough that in practice there is a high degree of backwards compatibility. [*] I still don't see it said anywhere if TDE maintains any API backwards compatibility with KDE3 or not. The configure checks in the patch search for KDE3/Qt3 names, so I would assume the answer is yes. If not, then at least that part of the patch is definitely wrong. The include file names themselves have not been changed at this point; this is on a to-do wishlist for the project. Thanks for the input! Tim ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] another build break in 3.4.x
I'm running into another build breaker. This one now also happens with
the last release. So it should be one of our latest rolling
release system updates... (we had gcc 4.6.2, glibc 2.14.1,
openjdk6/openjdk7 and many more).
Any idea?
-Andy
Entering /build/src/build/sal/qa/sal
--
:
LD_LIBRARY_PATH=/build/src/build/sal/unxlngx6.pro/lib:/build/src/build/solver/340/unxlngx6.pro/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
../../../unxlngx6.pro/bin/cppunittester ../../../unxlngx6.pro/li
b/librtl_doublelocking.so
- start unit test #1 on library
../../../unxlngx6.pro/lib/librtl_doublelocking.so
--
Making:all_qa_sal.dpslo
/build/src/build/sal/qa/rtl/alloc/rtl_alloc.cxx:156:1: warning: unused
parameter 'argc' [-Wunused-parameter]
/build/src/build/sal/qa/rtl/alloc/rtl_alloc.cxx:156:1: warning: unused
parameter 'argv' [-Wunused-parameter]
Compiling: sal/unxlngx6.pro/misc/qa_sal_types_version.c
Compiling: sal/qa/sal/test_types.cxx
[javadoc] Standard Doclet version 1.7.0_147-icedtea
[javadoc] Building tree for all the packages and classes...
Making:libosl_Security.so
/build/src/build/sal/qa/sal/test_types.cxx:85:1: warning: unused parameter
'argc' [-Wunused-parameter]
/build/src/build/sal/qa/sal/test_types.cxx:85:1: warning: unused parameter
'argv' [-Wunused-parameter]
OK (2)
--
:
LD_LIBRARY_PATH=/build/src/build/sal/unxlngx6.pro/lib:/build/src/build/solver/340/unxlngx6.pro/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
../../../unxlngx6.pro/bin/cppunittester ../../../unxlngx6.pro/li
b/libosl_Security.so
- start unit test #1 on library ../../../unxlngx6.pro/lib/libosl_Security.so
--
#Initializing ...
#
#logonUser function need root/Administrator account to test.
#You can test by login with root/Administrator, and excute:
#testshl2 -forward username password ../../../wntmsci9/bin/Security.dll
# where username and password are forwarded account info.
#if no text forwarded, this function will be skipped.
#
#Retrived system information is below:
Computer Name: Not retrived
Current User Name: nobody
Current User Home Directory:file:///
Current Config Directory: file:///
Current UserID: 99
Current User is:NOT Administrator.
#
#Initialization Done.
osl_Security.cxx:216:Assertion
Test name: N12osl_Security10getHomeDirE::getHomeDir_001
assertion failed
- Expression: ( sal_True == strHomeDirectory.equals( strHome ) ) ( sal_True
== bRes )
- #test comment#: getHomeDir and compare it with the info we get at the beginni
ng.
Failures !!!
Run: 10 Failure total: 1 Failures: 1 Errors: 0
dmake: Error code 1, while making 'test1'
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Where to begin for fdo#39182 (Impress changes background to black saving .odp to .ppt)
After some tests, I thought a black background was added. But in fact, there are 2 black shapes which are added. I don't know why and where they could be there. Thanks to Eike, I could see that : - in the odp 1 textShape, 9 customshapes - in the ppt 12 shapes Any help appreciated :-) -- View this message in context: http://nabble.documentfoundation.org/Where-to-begin-for-fdo-39182-Impress-changes-background-to-black-saving-odp-to-ppt-tp3469434p3471966.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Integrating EuroOffice Extension Creator into LibreOffice SDK
Hi Michael, 2011-10-26 15:19 keltezéssel, Michael Meeks írta: Hi Kami, On Wed, 2011-10-26 at 10:02 +0200, Kálmán „KAMI” Szalai wrote: EuroOffice Extension Creator is a LGPLv3 licensed Python language framework for easy extension development. Our Barcode extension also uses it. What about to integrate EOEC to LibreOffice SDK? It would be useful for Python extension developers. Sounds rather promising :-) clearly we'd want to get an MPL/LGPLv3+ license on the code, I started a discussion about licenses. I hope we will have dual license. Maybe it takes some time for Multiráció (creator of EOEC) depending on other things. and ensure that it is cleanly integrated and fits into the UI nicely - can you ask about that ? The UI is provided by LibreOffice itself, EOEC uses native dialogs. For integration work I hope I can help. Does your barcode extension use it at run-time, or just for building the extension ? EOEC provides a standard and debug mode. If you use standard mode, the EOEC provides useful functions for extensions for installation, menu registartion, drawing, etc. In debug mode, the developer can change the source code then see his chages real-time. So Barcode uses EOEC at run-time, that provides such functionality also creates the extension. ATB, Michael. Best regards, KAMI signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] building smoketest fails
Hi, Building smoketest fails to make libsmoketest.so (Ubuntu 10.04 x86_64). Error messages are : Making:libsmoketest.so ./unxlngx6.pro/slo/smoketest.o: In function `CppUnit::ConcretTestFixtureFactory(anonymous namespace)::Test::makeFixture()': smoketest.cxx:(.text+0x151): undefined reference to `test::OfficeConnection::OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::~Test()': smoketest.cxx:(.text+0x1c3): undefined reference to `test::OfficeConnection::~OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::~Test()': smoketest.cxx:(.text+0x203): undefined reference to `test::OfficeConnection::~OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::test()': smoketest.cxx:(.text+0xf1d): undefined reference to `test::getTestArgument(rtl::OUString const, rtl::OUString*)' smoketest.cxx:(.text+0x1479): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x14b4): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x1590): undefined reference to `test::toAbsoluteFileUrl(rtl::OUString const)' smoketest.cxx:(.text+0x1809): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x1c7e): undefined reference to `test::OfficeConnection::isStillAlive() const' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::tearDown()': smoketest.cxx:(.text+0x195): undefined reference to `test::OfficeConnection::tearDown()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::setUp()': smoketest.cxx:(.text+0x1a5): undefined reference to `test::OfficeConnection::setUp()' collect2: ld returned 1 exit status dmake: Error code 1, while making './unxlngx6.pro/lib/libsmoketest.so' It is a fresh build (make clean then make then make dev-install -o build ; same result if I do make check) Any clue what goes wrong ? Is there a mean to skip smoketest ? Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas
Hey, http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21 fixes a crash that happens if you use ROW() or COLUMN() in a matrix function. We try to get an entry from an empty mdds container which results in a crash. Even that we are not sure that return true is always correct this patch should be safe since this only matters in the case where a crash would have happened. Review and sign-off appreciated. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #224 from Reto reto.sch...@gmail.com 2011-11-01 15:42:00 PDT --- Nominating Bug 40990. Entering array formulas in LO 3.4.3 with big ranges draw a lot of ressources. With a range around a thousand cells it eventually crashes. This shold be fixed otherwise using array formulas with vast ranges will be obsolete. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building smoketest fails
On Tue, Nov 01, 2011 at 10:34:02PM +0100, Jean-Baptiste Faure wrote: Making:libsmoketest.so ./unxlngx6.pro/slo/smoketest.o: In function `CppUnit::ConcretTestFixtureFactory(anonymous namespace)::Test::makeFixture()': smoketest.cxx:(.text+0x151): undefined reference to `test::OfficeConnection::OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::~Test()': smoketest.cxx:(.text+0x1c3): undefined reference to `test::OfficeConnection::~OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::~Test()': smoketest.cxx:(.text+0x203): undefined reference to `test::OfficeConnection::~OfficeConnection()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::test()': smoketest.cxx:(.text+0xf1d): undefined reference to `test::getTestArgument(rtl::OUString const, rtl::OUString*)' smoketest.cxx:(.text+0x1479): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x14b4): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x1590): undefined reference to `test::toAbsoluteFileUrl(rtl::OUString const)' smoketest.cxx:(.text+0x1809): undefined reference to `test::OfficeConnection::getComponentContext() const' smoketest.cxx:(.text+0x1c7e): undefined reference to `test::OfficeConnection::isStillAlive() const' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::tearDown()': smoketest.cxx:(.text+0x195): undefined reference to `test::OfficeConnection::tearDown()' ./unxlngx6.pro/slo/smoketest.o: In function `(anonymous namespace)::Test::setUp()': smoketest.cxx:(.text+0x1a5): undefined reference to `test::OfficeConnection::setUp()' collect2: ld returned 1 exit status dmake: Error code 1, while making './unxlngx6.pro/lib/libsmoketest.so' Any clue what goes wrong ? I see that here too and it recently worked. A guess into the blue is that: fb6a64d8fc6a93b52a10fad5516918fed9482f22 broke it, as it seems to always use the internal headers, even when building with system cppunit. Try to revert that commit and build again. If that doesnt help add --without-system-cppunit for now. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building smoketest fails
On Tue, Nov 01, 2011 at 07:35:38PM -0400, Bjoern Michaelsen wrote: On Tue, Nov 01, 2011 at 10:34:02PM +0100, Jean-Baptiste Faure wrote: Any clue what goes wrong ? I see that here too and it recently worked. A guess into the blue is that: fb6a64d8fc6a93b52a10fad5516918fed9482f22 broke it, as it seems to always use the internal headers, even when building with system cppunit. Try to revert that commit and build again. If that doesnt help add --without-system-cppunit for now. Nah, that wasnt it, fixed as: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bcda87664af59e01f4e1048991e5cf752547556 instead. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas
On Tue, 2011-11-01 at 22:45 +0100, Markus Mohrhard wrote: Hey, http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21 fixes a crash that happens if you use ROW() or COLUMN() in a matrix function. We try to get an entry from an empty mdds container which results in a crash. Even that we are not sure that return true is always correct this patch should be safe since this only matters in the case where a crash would have happened. Well, I'm still not 100% sure if this is the best way to fix this (as I hinted in my private mail to you), but I will agree that 1) it's much much better than crashing, and 2) the change only affects very rare corner cases that it's a safe change. Pushed to the 3-4 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building smoketest fails
Le 02/11/2011 01:33, Bjoern Michaelsen a écrit : On Tue, Nov 01, 2011 at 07:35:38PM -0400, Bjoern Michaelsen wrote: On Tue, Nov 01, 2011 at 10:34:02PM +0100, Jean-Baptiste Faure wrote: Any clue what goes wrong ? I see that here too and it recently worked. A guess into the blue is that: fb6a64d8fc6a93b52a10fad5516918fed9482f22 broke it, as it seems to always use the internal headers, even when building with system cppunit. Try to revert that commit and build again. If that doesnt help add --without-system-cppunit for now. Nah, that wasnt it, fixed as: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bcda87664af59e01f4e1048991e5cf752547556 instead. I confirm, smoketest build works now. Thank you for this quick fix. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] master eat CPU even when it does nothing [fixed]
Hi Michael, Le 01/11/2011 14:14, Jean-Baptiste Faure a écrit : Le 01/11/2011 14:02, Michael Meeks a écrit : On Sat, 2011-10-29 at 07:12 +0200, Jean-Baptiste Faure wrote: In Writer: open a new text document and do nothing else = CPU ~100% of one core Should be fixed in master :-) more testing of course much appreciated. Thanks ! Michael. Thanks ! Build in progress. :-) With the fix by Bjoern, smoketest does not block anymore my tests. And I confirm that your fix solves the CPU problem for me. Thank you very much Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Word count dialog modeless
Hey everyone,
I've been meaning to do an easy hack ever since LibreOffice announced.
Not to get to political, but recently AOOo and the efforts of it's
backers has riled me up enough to push through the build issues I was
having and put my money (time) where my mouth is.
I've followed Michael Meek's blog over the years via planet GNOME, but
this post struck a chord with me:
http://mail-archives.apache.org/mod_mbox/incubator-ooo-dev/201110.mbox/%3C1319628345.22078.111.camel%40linux-yjtf.site%3E
So here I am with me first contribution.
I was thinking of an easy hack, but I had to submit a brief summary
recently where word count was limited and it was a pain to have to
continuously open the word count dialog.
I couldn't find a LO bug on this, but there is an OOo one from 2005:
http://openoffice.org/bugzilla/show_bug.cgi?id=46785
I thought it would be easier than it turned out to be, and expect some
changes may need to be made, but here it is, a fix for a 6 year old bug.
Patch licensed under LGPLv3+/MPL.
Thanks!
From e55b1ebaf7c21bcf532e571717626be2eebfb8cf Mon Sep 17 00:00:00 2001
From: Matt Pratt mattpratt...@gmail.com
Date: Tue, 1 Nov 2011 22:47:33 -0600
Subject: [PATCH] Word count dialog modeless
---
sw/Library_sw.mk |1 +
sw/inc/swabstdlg.hxx | 12 -
sw/source/ui/app/swmodule.cxx|2 +
sw/source/ui/dialog/swdlgfact.cxx| 45 +++--
sw/source/ui/dialog/swdlgfact.hxx| 15 +--
sw/source/ui/dialog/wordcountdialog.cxx | 56 +-
sw/source/ui/dialog/wordcountdialog.hrc |1 +
sw/source/ui/dialog/wordcountdialog.src | 12 +-
sw/source/ui/dialog/wordcountwrapper.cxx | 64 ++
sw/source/ui/docvw/edtwin.cxx| 16 +++
sw/source/ui/inc/wordcountdialog.hxx | 38 +-
sw/source/ui/shells/annotsh.cxx | 23 ---
sw/source/ui/shells/drawsh.cxx | 22 --
sw/source/ui/shells/drwtxtex.cxx | 22 --
sw/source/ui/shells/frmsh.cxx| 22 --
sw/source/ui/shells/textsh.cxx |1 +
sw/source/ui/shells/textsh1.cxx | 24 ---
17 files changed, 280 insertions(+), 96 deletions(-)
create mode 100644 sw/source/ui/dialog/wordcountwrapper.cxx
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index b2ce776..a8ee383 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -615,6 +615,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
sw/source/ui/frmdlg/frmmgr \
sw/source/ui/globdoc/globdoc \
sw/source/ui/index/idxmrk \
+sw/source/ui/dialog/wordcountwrapper \
sw/source/ui/index/toxmgr \
sw/source/ui/lingu/hhcwrp \
sw/source/ui/lingu/hyp \
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index b928169..a8fc6ef 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -200,10 +200,11 @@ public:
virtual void SetSectionData(SwSectionData const rSect) = 0;
};
-class AbstractSwWordCountDialog : public VclAbstractDialog
+class AbstractSwWordCountFloatDlg : public VclAbstractDialog
{
public:
-virtual voidSetValues(const SwDocStat rCurrent, const SwDocStat rDoc) = 0;
+virtual voidUpdateCounts() = 0;
+virtual Window *GetWindow() = 0; //this method is added for return a Window type pointer
};
class AbstractSwInsertAbstractDlg : public VclAbstractDialog// add for SwInsertAbstractDlg
@@ -353,7 +354,12 @@ public:
const ::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame _rxFrame,
sal_uInt32 nResId
) = 0;
-virtual AbstractSwWordCountDialog* CreateSwWordCountDialog( Window* pWindow ) = 0;
+virtual AbstractSwWordCountFloatDlg* CreateSwWordCountDialog(int nResId,
+SfxBindings* pBindings,
+ SfxChildWindow* pChild,
+ Window *pParent,
+SfxChildWinInfo* pInfo) = 0;
+
virtual AbstractSwInsertAbstractDlg * CreateSwInsertAbstractDlg ( Window* pParent, int nResId) = 0; // add for SwInsertAbstractDlg
virtual AbstractSwAsciiFilterDlg* CreateSwAsciiFilterDlg ( Window* pParent, SwDocShell rDocSh,
SvStream* pStream, int nResId ) = 0;// add for SwAsciiFilterDlg
diff --git a/sw/source/ui/app/swmodule.cxx b/sw/source/ui/app/swmodule.cxx
index 4a66362..e1bdf64 100644
--- a/sw/source/ui/app/swmodule.cxx
+++ b/sw/source/ui/app/swmodule.cxx
@@ -122,6 +122,7 @@
#include sfx2/appuno.hxx
#include swatrset.hxx
#include idxmrk.hxx
+#include wordcountdialog.hxx
[Libreoffice-bugs] [Bug 38817] LibreOffice Base will not hide the record marker
https://bugs.freedesktop.org/show_bug.cgi?id=38817 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Version|unspecified |LibO 3.4.0 release --- Comment #7 from Lionel Elie Mamane lio...@mamane.lu 2011-10-31 23:21:39 PDT --- According to my testing, it is fixed in 3.4.4-rc1. Reopen this bug if you encounter the problem in 3.4.4-rc1 or later. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38817, which changed state. Bug 38817 Summary: LibreOffice Base will not hide the record marker https://bugs.freedesktop.org/show_bug.cgi?id=38817 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32573] Cannot print A5 landscape
https://bugs.freedesktop.org/show_bug.cgi?id=32573 --- Comment #20 from Eugenij Shkrigunov eshk...@gmail.com 2011-11-01 00:42:13 PDT --- Verisons: distr: gentoo (profile: /usr/portage/profiles/default/linux/amd64/10.0) kernel: 3.0.6 sys-devel/gcc-4.5.3-r1 sys-devel/binutils-2.21.1-r1 sys-libs/glibc-2.12.2 dependencies for app-office/libreoffice-3.3.4 app-arch/unzip-6.0-r1 app-arch/zip-3.0 app-dicts/myspell-ru-20060316 app-office/libreoffice-3.3.4 app-text/hunspell-1.3.2-r1 app-text/poppler-0.16.7 dev-java/ant-core-1.8.1 dev-java/bsh-2.0_beta4-r3 dev-java/lucene-2.3.2 dev-java/lucene-analyzers-2.3.2 dev-lang/perl-5.12.4-r1 dev-lang/python-2.7.2-r3 dev-libs/boost-1.46.1-r1 dev-libs/dbus-glib-0.98 dev-libs/expat-2.0.1-r5 dev-libs/glib-2.28.8 dev-libs/icu-4.8.1-r2 dev-libs/libxml2-2.7.8-r3 dev-libs/libxslt-1.1.26-r2 dev-libs/nspr-4.8.9 dev-libs/nss-3.12.11-r1 dev-libs/openssl-1.0.0e dev-libs/redland-1.0.14 dev-perl/Archive-Zip-1.300.0 dev-util/cppunit-1.12.1 dev-util/gperf-3.0.4 dev-util/intltool-0.41.1 dev-util/pkgconfig-0.26 media-libs/fontconfig-2.8.0-r1 media-libs/freetype-2.4.7 media-libs/libpng-1.5.5 media-libs/vigra-1.7.1-r1 net-libs/neon-0.29.6 net-libs/xulrunner-1.9.2.20 net-misc/curl-7.21.4 net-nds/openldap-2.4.24 net-print/cups-1.4.8-r1 sys-apps/coreutils-8.7 sys-apps/findutils-4.4.2 sys-apps/sed-4.2.1 sys-devel/autoconf-2.68 sys-devel/automake-1.9.6-r3 sys-devel/bison-2.4.3 sys-devel/flex-2.5.35_p10 sys-devel/libtool-2.4-r1 sys-libs/db-4.8.30 sys-libs/zlib-1.2.5-r2 x11-libs/cairo-1.10.2-r1 x11-libs/gtk+-2.24.5-r1 x11-libs/libXaw-1.0.9 x11-libs/libXinerama-1.1.1 x11-libs/libXrandr-1.3.2 x11-libs/libXrender-0.9.6 x11-libs/libXtst-1.2.0 x11-proto/printproto-1.0.5 x11-proto/xextproto-7.2.0 x11-proto/xineramaproto-1.2.1 x11-proto/xproto-7.0.22 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40937] FILEOPEN: rtf doc crashing libreoffice
https://bugs.freedesktop.org/show_bug.cgi?id=40937 --- Comment #4 from Cor Nouws c...@nouenoff.nl 2011-11-01 00:54:28 PDT --- @ paolo: no sorry, not at the moment. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41466] Missing notes and moved components after importing .docx file
https://bugs.freedesktop.org/show_bug.cgi?id=41466 --- Comment #8 from an...@volny.cz 2011-11-01 01:57:48 PDT --- Hi, I do not own MS Ofice, so I cannot modify this document using original tool. I can try to delete some parts by LO or OO, and then test if modified version is shown as described in original bug, but I think that after modification some fields from this file will be lost and bug will not be reproducible. Give me few days to try it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34531] can not write with Smartboard while presenting
https://bugs.freedesktop.org/show_bug.cgi?id=34531 --- Comment #2 from mal malc...@whsg.info 2011-11-01 02:32:40 PDT --- I think this is bug 40570 Unfortunately this bug makes LO presenter unusable in schools with smartboards M -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
