[Libreoffice-commits] .: offapi/com
offapi/com/sun/star/sheet/XSelectedSheetsSupplier.idl |2 ++
1 file changed, 2 insertions(+)
New commits:
commit ebdc3ad1ee835212be4eb5fe99d5442c8baff920
Author: Jan Holesovsky ke...@suse.cz
Date: Tue Nov 29 09:40:48 2011 +0100
Fix build in offapi.
diff --git a/offapi/com/sun/star/sheet/XSelectedSheetsSupplier.idl
b/offapi/com/sun/star/sheet/XSelectedSheetsSupplier.idl
index 786dba3..fe49579 100644
--- a/offapi/com/sun/star/sheet/XSelectedSheetsSupplier.idl
+++ b/offapi/com/sun/star/sheet/XSelectedSheetsSupplier.idl
@@ -28,6 +28,8 @@
#ifndef __com_sun_star_sheet_XSelectedSheetsSupplier_idl__
#define __com_sun_star_sheet_XSelectedSheetsSupplier_idl__
+#include com/sun/star/uno/XInterface.idl
+
module com { module sun { module star { module sheet {
interface XSelectedSheetsSupplier: com::sun::star::uno::XInterface
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: default_images/brand
default_images/brand/about.png |binary default_images/brand/intro.png |binary default_images/brand/shell/backing_left.png |binary default_images/brand/shell/backing_rtl_left.png |binary 4 files changed New commits: commit 337eda19a516646752f195d7c2a35cc1af2e9410 Author: Thorsten Behrens tbehr...@suse.com Date: Tue Nov 29 10:29:41 2011 +0100 Switch artwork to LibreOffice-only branding. diff --git a/default_images/brand/about.png b/default_images/brand/about.png index 3520c50..b9e7626 100644 Binary files a/default_images/brand/about.png and b/default_images/brand/about.png differ diff --git a/default_images/brand/intro.png b/default_images/brand/intro.png index a775627..f1bc4d2 100644 Binary files a/default_images/brand/intro.png and b/default_images/brand/intro.png differ diff --git a/default_images/brand/shell/backing_left.png b/default_images/brand/shell/backing_left.png index 4b830ba..a4d5ba2 100644 Binary files a/default_images/brand/shell/backing_left.png and b/default_images/brand/shell/backing_left.png differ diff --git a/default_images/brand/shell/backing_rtl_left.png b/default_images/brand/shell/backing_rtl_left.png index 4b830ba..a4d5ba2 100644 Binary files a/default_images/brand/shell/backing_rtl_left.png and b/default_images/brand/shell/backing_rtl_left.png differ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/source sw/qa
sc/source/ui/inc/namemgrtable.hxx | 13 +++-
sc/source/ui/namedlg/namemgrtable.cxx | 54 ++
sc/source/ui/src/namedefdlg.src |2 -
sw/qa/core/macros-test.cxx| 34 +++--
4 files changed, 67 insertions(+), 36 deletions(-)
New commits:
commit 792fb5b96f1008804ab51dc0ebf4f07a07ad9537
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Nov 29 10:39:01 2011 +0100
ManageNames: only calculate formula for visible range names
diff --git a/sc/source/ui/inc/namemgrtable.hxx
b/sc/source/ui/inc/namemgrtable.hxx
index b95002e..bbbcab6 100644
--- a/sc/source/ui/inc/namemgrtable.hxx
+++ b/sc/source/ui/inc/namemgrtable.hxx
@@ -36,6 +36,7 @@
#include boost/ptr_container/ptr_map.hpp
class ScRangeName;
+class ScRangeData;
struct ScRangeNameLine
{
@@ -64,8 +65,17 @@ private:
HeaderBar maHeaderBar;
rtl::OUString maGlobalString;
+// should be const because we should not modify it here
+const boost::ptr_maprtl::OUString, ScRangeName mrRangeMap;
+// for performance, save which entries already have the formula entry
+// otherwise opening the dialog with a lot of range names is extremelly
slow because
+// we would calculate all formula strings during opening
+std::mapSvLBoxEntry*, bool maCalculatedFormulaEntries;
+
void GetLine(ScRangeNameLine aLine, SvLBoxEntry* pEntry);
-void Init( const boost::ptr_maprtl::OUString, ScRangeName rRangeMap );
+void Init();
+void CheckForFormulaString();
+const ScRangeData* findRangeData(const ScRangeNameLine rLine);
public:
ScRangeManagerTable( Window* pParent, boost::ptr_maprtl::OUString,
ScRangeName aTabRangeNames );
@@ -78,6 +88,7 @@ public:
bool IsMultiSelection();
std::vectorScRangeNameLine GetSelectedEntries();
+DECL_LINK( ScrollHdl, void*);
DECL_LINK( HeaderEndDragHdl, void*);
};
diff --git a/sc/source/ui/namedlg/namemgrtable.cxx
b/sc/source/ui/namedlg/namemgrtable.cxx
index d471c74..de9e386 100644
--- a/sc/source/ui/namedlg/namemgrtable.cxx
+++ b/sc/source/ui/namedlg/namemgrtable.cxx
@@ -60,7 +60,8 @@ String createEntryString(const ScRangeNameLine rLine)
ScRangeManagerTable::ScRangeManagerTable( Window* pWindow,
boost::ptr_maprtl::OUString, ScRangeName rRangeMap ):
SvTabListBox( pWindow, WB_SORT | WB_HSCROLL | WB_CLIPCHILDREN | WB_TABSTOP
),
maHeaderBar( pWindow, WB_BUTTONSTYLE | WB_BOTTOMBORDER ),
-maGlobalString( ScGlobal::GetRscString(STR_GLOBAL_SCOPE))
+maGlobalString( ScGlobal::GetRscString(STR_GLOBAL_SCOPE)),
+mrRangeMap( rRangeMap )
{
Size aBoxSize( pWindow-GetOutputSizePixel() );
@@ -84,12 +85,16 @@ ScRangeManagerTable::ScRangeManagerTable( Window* pWindow,
boost::ptr_maprtl::O
maHeaderBar.SetEndDragHdl( LINK( this, ScRangeManagerTable,
HeaderEndDragHdl ) );
+Init();
Show();
maHeaderBar.Show();
SetSelectionMode(MULTIPLE_SELECTION);
-Init(rRangeMap);
if (GetEntryCount())
+{
SetCurEntry(GetEntryOnPos(0));
+CheckForFormulaString();
+}
+SetScrolledHdl( LINK( this, ScRangeManagerTable, ScrollHdl ) );
}
ScRangeManagerTable::~ScRangeManagerTable()
@@ -116,11 +121,11 @@ void ScRangeManagerTable::GetLine(ScRangeNameLine rLine,
SvLBoxEntry* pEntry)
rLine.aScope = GetEntryText(pEntry, 2);
}
-void ScRangeManagerTable::Init(const boost::ptr_maprtl::OUString,
ScRangeName rRangeMap)
+void ScRangeManagerTable::Init()
{
Clear();
-for (boost::ptr_maprtl::OUString, ScRangeName::const_iterator itr =
rRangeMap.begin();
-itr != rRangeMap.end(); ++itr)
+for (boost::ptr_maprtl::OUString, ScRangeName::const_iterator itr =
mrRangeMap.begin();
+itr != mrRangeMap.end(); ++itr)
{
const ScRangeName* pLocalRangeName = itr-second;
ScRangeNameLine aLine;
@@ -134,13 +139,44 @@ void ScRangeManagerTable::Init(const
boost::ptr_maprtl::OUString, ScRangeName
if (!it-second-HasType(RT_DATABASE)
!it-second-HasType(RT_SHARED))
{
aLine.aName = it-second-GetName();
-it-second-GetSymbol(aLine.aExpression);
addEntry(aLine);
}
}
}
}
+const ScRangeData* ScRangeManagerTable::findRangeData(const ScRangeNameLine
rLine)
+{
+const ScRangeName* pRangeName;
+if (rLine.aScope == maGlobalString)
+pRangeName =
mrRangeMap.find(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(STR_GLOBAL_RANGE_NAME)))-second;
+else
+pRangeName = mrRangeMap.find(rLine.aScope)-second;
+
+return
pRangeName-findByUpperName(ScGlobal::pCharClass-upper(rLine.aName));
+}
+
+
+
+void ScRangeManagerTable::CheckForFormulaString()
+{
+for (SvLBoxEntry* pEntry = GetFirstEntryInView(); pEntry ; pEntry =
GetNextEntryInView(pEntry))
+{
+std::mapSvLBoxEntry*, bool::const_iterator itr =
maCalculatedFormulaEntries.find(pEntry);
+if (itr ==
[Libreoffice-commits] .: configure.in
configure.in |4 1 file changed, 4 insertions(+) New commits: commit a43caa76d9da112f40a973911e779fc42c5af3c3 Author: Tomas Chvatal tchva...@suse.cz Date: Tue Nov 29 11:04:16 2011 +0100 Add checking msg for tarball fetching so we know if it is on/off diff --git a/configure.in b/configure.in index 4bb2f1f..d925ba4 100644 --- a/configure.in +++ b/configure.in @@ -2547,8 +2547,12 @@ if test -z $TARFILE_LOCATION; then fi AC_SUBST(TARFILE_LOCATION) +AC_MSG_CHECKING([whether we want to fetch tarballs]) if test z$enable_fetch_external != zno ; then +AC_MSG_RESULT([yes]) DO_FETCH_TARBALLS=YES +else +AC_MSG_RESULT([no]) fi AC_SUBST(DO_FETCH_TARBALLS) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: libvisio/libvisio-0.0.10.patch libvisio/libvisio-0.0.11.patch libvisio/makefile.mk ooo.lst.in
libvisio/libvisio-0.0.10.patch | 20 libvisio/libvisio-0.0.11.patch | 20 libvisio/makefile.mk |6 +++--- ooo.lst.in |2 +- 4 files changed, 24 insertions(+), 24 deletions(-) New commits: commit 11f91f16cad5dc01a1b6375134c8f5132acf3415 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Tue Nov 29 11:50:52 2011 +0100 Uploading new release of libvisio diff --git a/libvisio/libvisio-0.0.10.patch b/libvisio/libvisio-0.0.10.patch deleted file mode 100644 index 5bd3265..000 --- a/libvisio/libvisio-0.0.10.patch +++ /dev/null @@ -1,20 +0,0 @@ misc/libvisio-0.0.10/src/lib/libvisio_utils.h -+++ misc/build/libvisio-0.0.10/src/lib/libvisio_utils.h -@@ -41,17 +41,8 @@ - - #else - --#ifdef HAVE_CONFIG_H --#include config.h --#endif -- --#ifdef HAVE_STDINT_H - #include stdint.h --#endif -- --#ifdef HAVE_INTTYPES_H - #include inttypes.h --#endif - - #endif - diff --git a/libvisio/libvisio-0.0.11.patch b/libvisio/libvisio-0.0.11.patch new file mode 100644 index 000..91e9700 --- /dev/null +++ b/libvisio/libvisio-0.0.11.patch @@ -0,0 +1,20 @@ +--- misc/libvisio-0.0.11/src/lib/libvisio_utils.h misc/build/libvisio-0.0.11/src/lib/libvisio_utils.h +@@ -41,17 +41,8 @@ + + #else + +-#ifdef HAVE_CONFIG_H +-#include config.h +-#endif +- +-#ifdef HAVE_STDINT_H + #include stdint.h +-#endif +- +-#ifdef HAVE_INTTYPES_H + #include inttypes.h +-#endif + + #endif + diff --git a/libvisio/makefile.mk b/libvisio/makefile.mk index a9b20c2..fa99223 100644 --- a/libvisio/makefile.mk +++ b/libvisio/makefile.mk @@ -54,11 +54,11 @@ INCPRE+=$(WPG_CFLAGS) INCPRE+=$(SOLARVER)$/$(UPD)$/$(INPATH)$/inc$/libwpg .ENDIF -TARFILE_NAME=libvisio-0.0.10 -TARFILE_MD5=8f107ffb3fc9d9b920b7bbd0bc79c7e8 +TARFILE_NAME=libvisio-0.0.11 +TARFILE_MD5=a8b25a0bf696fd126a08319d88998492 PATCH_FILES=\ -libvisio-0.0.10.patch +libvisio-0.0.11.patch BUILD_ACTION=dmake $(MFLAGS) $(CALLMACROS) diff --git a/ooo.lst.in b/ooo.lst.in index ba7676a..51695cf 100644 --- a/ooo.lst.in +++ b/ooo.lst.in @@ -87,7 +87,7 @@ c01351d7db2b205de755d58769288224-libwpd-0.9.4.tar.bz2 f02578f5218f217a9f20e9c30e119c6a-boost_1_44_0.tar.bz2 3121aaf3e13e5d88dfff13fb4a5f1ab8-hunspell-1.3.2.tar.gz 3bf481ca95109b14435125c0dd1f2217-graphite2-1.0.3.tgz -8f107ffb3fc9d9b920b7bbd0bc79c7e8-libvisio-0.0.10.tar.bz2 +a8b25a0bf696fd126a08319d88998492-libvisio-0.0.11.tar.bz2 30c468d0c27ae4784195b53f78bc6f64-LinLibertineG-20110922.zip 7c2549f6b0a8bb604e6c4c729ffdcfe6-libcmis-0.1.0.tar.gz @GOOGLE_DOCS_EXTENSION_PACK@ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in set_soenv.in
configure.in |1 + set_soenv.in |1 + 2 files changed, 2 insertions(+) New commits: commit b8a2970f24872ee1620f3cc2381055b14484dd63 Author: Tomas Chvatal tchva...@suse.cz Date: Tue Nov 29 13:09:06 2011 +0100 Export DO_FETCH_TARBALLS in set_soenv. diff --git a/configure.in b/configure.in index d925ba4..3e3671f 100644 --- a/configure.in +++ b/configure.in @@ -2553,6 +2553,7 @@ if test z$enable_fetch_external != zno ; then DO_FETCH_TARBALLS=YES else AC_MSG_RESULT([no]) +DO_FETCH_TARBALLS=NO fi AC_SUBST(DO_FETCH_TARBALLS) diff --git a/set_soenv.in b/set_soenv.in index b723e14..10a0937 100755 --- a/set_soenv.in +++ b/set_soenv.in @@ -1484,6 +1484,7 @@ ToFile( LIBDIR,@LIBDIR@, e ); ToFile( DATADIR, @DATADIR@,e ); ToFile( MANDIR,@MANDIR@, e ); ToFile( DOCDIR,@DOCDIR@, e ); +ToFile( DO_FETCH_TARBALLS, @DO_FETCH_TARBALLS, e ); ToFile( BUILD_MOZAB, @BUILD_MOZAB@,e ); ToFile( PREBUILD_MOZAB,$PREBUILD_MOZAB,e ); ToFile( MOZILLA_VERSION, $MOZILLA_VERSION, e ); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Makefile.in
Makefile.in |2 -- 1 file changed, 2 deletions(-) New commits: commit 55da6a0907fe3679dd09de4c9f29ad32cb2a5ab5 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 29 13:18:15 2011 +0100 these deps are already handled in gbuild diff --git a/Makefile.in b/Makefile.in index 1375db4..2df1863 100644 --- a/Makefile.in +++ b/Makefile.in @@ -102,6 +102,4 @@ findunusedcode: @grep ::.*\( unusedcode.all | grep -v ^cppu:: unusedcode.easy #as long as we are not completely gbuildified we need to explicitly depend on the build/install -unitcheck: build -subsequentcheck: dev-install #debugrun : dev-install # disabled for now, this dep seems to poison the debugrun !? ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeMinGW.conf distro-configs/LibreOfficeOpenBSD.conf distro-configs/OxygenOfficeLinux.conf README.cross
README.cross |1 - distro-configs/LibreOfficeLinux.conf |1 - distro-configs/LibreOfficeMinGW.conf |1 - distro-configs/LibreOfficeOpenBSD.conf |1 - distro-configs/OxygenOfficeLinux.conf |1 - 5 files changed, 5 deletions(-) New commits: commit 96be3a199abb931068d15893f4bc83a24375d362 Author: Jan Holesovsky ke...@suse.cz Date: Tue Nov 29 13:41:09 2011 +0100 --with-system-libxslt is gone, remove it from the distro-configs. diff --git a/README.cross b/README.cross index 204b86d..cdcb37c 100644 --- a/README.cross +++ b/README.cross @@ -176,7 +176,6 @@ CXX_FOR_BUILD=ccache g++ --with-system-libwpg --with-system-libwps --with-system-libxml ---with-system-libxslt --with-system-lpsolve --with-system-mythes --with-system-neon diff --git a/distro-configs/LibreOfficeLinux.conf b/distro-configs/LibreOfficeLinux.conf index ddf6671..c00e6b9 100644 --- a/distro-configs/LibreOfficeLinux.conf +++ b/distro-configs/LibreOfficeLinux.conf @@ -8,7 +8,6 @@ --without-system-openssl --without-system-mozilla --without-system-mesa-headers ---without-system-libxslt --without-system-libxml --without-system-jpeg --without-system-jars diff --git a/distro-configs/LibreOfficeMinGW.conf b/distro-configs/LibreOfficeMinGW.conf index aad9039..fcca57a 100644 --- a/distro-configs/LibreOfficeMinGW.conf +++ b/distro-configs/LibreOfficeMinGW.conf @@ -13,7 +13,6 @@ --with-system-icu --with-system-libpng --with-system-libxml ---with-system-libxslt --with-system-lpsolve --with-system-mythes --with-system-neon diff --git a/distro-configs/LibreOfficeOpenBSD.conf b/distro-configs/LibreOfficeOpenBSD.conf index 8f94b4b..b17175c 100644 --- a/distro-configs/LibreOfficeOpenBSD.conf +++ b/distro-configs/LibreOfficeOpenBSD.conf @@ -39,7 +39,6 @@ --with-system-jars --with-system-jpeg --with-system-libxml ---with-system-libxslt --with-system-mesa-headers --with-system-neon --with-system-openssl diff --git a/distro-configs/OxygenOfficeLinux.conf b/distro-configs/OxygenOfficeLinux.conf index f000ae6..31b3db4 100644 --- a/distro-configs/OxygenOfficeLinux.conf +++ b/distro-configs/OxygenOfficeLinux.conf @@ -58,7 +58,6 @@ --without-system-openssl --without-system-mozilla --without-system-mesa-headers ---without-system-libxslt --without-system-libxml --without-system-jpeg --without-system-jars ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: libvisio/prj
libvisio/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c17daddf7b51f685da0f7b83951916ba791a315c Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Tue Nov 29 16:55:19 2011 +0100 libvisio should depend on boost now diff --git a/libvisio/prj/build.lst b/libvisio/prj/build.lst index 7ce8628..77fec71 100644 --- a/libvisio/prj/build.lst +++ b/libvisio/prj/build.lst @@ -1,3 +1,3 @@ -vsdlibvisio: LIBWPD:libwpd LIBWPG:libwpg soltools NULL +vsdlibvisio: LIBWPD:libwpd LIBWPG:libwpg BOOST::boost soltools NULL vsdlibvisiousr1- all vsd_mkout NULL vsdlibvisionmake - all vsd_libvisio NULL ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/ui/app/inputwin.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 71e77655660fa719ca0e91c7daa94e045e3006a3
Author: Noel Power noel.po...@novell.com
Date: Tue Nov 29 15:58:48 2011 +
detect TEXTMODIFIED event from EditEngine ( and add missing StopEditEngine )
not sure if the StopEditEngine method ever gets called but we should have
it tunnel to the base class just in case.
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 63265f9..650293a 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -1180,7 +1180,10 @@ IMPL_LINK(ScMultiTextWnd, ModifyHdl, EENotify*, pNotify)
IMPL_LINK(ScMultiTextWnd, NotifyHdl, EENotify*, pNotify)
{
// need to process EE_NOTIFY_TEXTVIEWSCROLLED here
-if ( pNotify pNotify-eNotificationType == EE_NOTIFY_TEXTVIEWSCROLLED )
+// sometimes when pasting we don't seem to get EE_NOTIFY_TEXTVIEWSCROLLED
+// but we always seem to get EE_NOTIFY_TEXTMODIFIED
+if ( pNotify ( pNotify-eNotificationType == EE_NOTIFY_TEXTVIEWSCROLLED
+ || pNotify-eNotificationType == EE_NOTIFY_TEXTMODIFIED ) )
SetScrollBarRange();
return 0;
}
@@ -1362,8 +1365,9 @@ void ScMultiTextWnd::InitEditEngine(SfxObjectShell*
pObjSh)
}
}
-void ScMultiTextWnd::StopEditEngine( sal_Bool /*bAll*/ )
+void ScMultiTextWnd::StopEditEngine( sal_Bool bAll )
{
+ScTextWnd::StopEditEngine( bAll );
}
void ScMultiTextWnd::SetTextString( const String rNewString )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in download ooo.lst.in set_soenv.in
configure.in | 21 + download |6 ++ ooo.lst.in |1 + set_soenv.in | 10 ++ 4 files changed, 34 insertions(+), 4 deletions(-) New commits: commit 8aa73a8f74cfcdc2fffdc16c8094bd257c8ade0d Author: Kalman Szalai - KAMI kami...@gmail.com Date: Tue Nov 29 17:12:02 2011 +0100 Add enable-oxygenoffice configure switch Now only handling brand downloading diff --git a/configure.in b/configure.in index 3e3671f..005a68e 100644 --- a/configure.in +++ b/configure.in @@ -784,6 +784,11 @@ AC_ARG_ENABLE(extra-font, [Add extra font content.]), ,) +AC_ARG_ENABLE(oxygenoffice, +AS_HELP_STRING([--enable-oxygenoffice], +[Download OxygenOffice branding and set custom settings.]), +,) + AC_ARG_ENABLE(lomenubar, AS_HELP_STRING([--enable-lomenubar], [Enable global menu support.]), @@ -8437,6 +8442,22 @@ AC_SUBST(WITH_EXTRA_FONT) AC_SUBST(OOOP_FONTS_PACK) dnl === +dnl Test whether to download OxygenOffice branding and set custom settings +dnl === +AC_MSG_CHECKING([whether to download OxygenOffice branding and set custom settings]) +if test z$enable_oxygenoffice = z -o z$enable_oxygenoffice = zno ; then +AC_MSG_RESULT([no]) +ENABLE_OXYGENOFFICE=NO +else +AC_MSG_RESULT([yes]) +ENABLE_OXYGENOFFICE=YES +OXYGENOFFICE_PACK=18bf204479ff641d99a88cd71f6f25f7-oxygenoffice-001.zip +BUILD_TYPE=$BUILD_TYPE OXYGENOFFICE +fi +AC_SUBST(ENABLE_OXYGENOFFICE) +AC_SUBST(OXYGENOFFICE_PACK) + +dnl === dnl Test whether to build global menu support dnl === AC_MSG_CHECKING([whether to build global menu support]) diff --git a/download b/download index ded21af..716bd53 100755 --- a/download +++ b/download @@ -278,6 +278,12 @@ for pack in $OOOP_FONTS_PACK $OOOP_GALLERY_PACK $OOOP_SAMPLES_PACK $OOOP_TEMPLAT unzip -o -q $TARFILE_LOCATION/$pack -d $SRC_ROOT/extras/source done +if [ $OXYGENOFFICE_PACK = YES ] ; then +check_file $TARFILE_LOCATION/$OXYGENOFFICE_PACK +echo Unpacking OxygenOffice '$OXYGENOFFICE_PACK' ... +unzip -o -q $TARFILE_LOCATION/$OXYGENOFFICE_PACK -d $SRC_ROOT/src +fi + # Extensions copy for pack in $BARCODE_EXTENSION_PACK $DIAGRAM_EXTENSION_PACK $VALIDATOR_EXTENSION_PACK $WATCH_WINDOW_EXTENSION_PACK $NUMBERTEXT_EXTENSION_PACK $HUNART_EXTENSION_PACK $TYPO_EXTENSION_PACK $GOOGLE_DOCS_EXTENSION_PACK $OOOBLOGGER_EXTENSION_PACK $LIGHTPROOF_HU_PACK $LIGHTPROOF_RU_PACK $LIGHTPROOF_EN_US_PACK $SUNTEMPLATES_DE_PACK $SUNTEMPLATES_EN_US_PACK $SUNTEMPLATES_ES_PACK $SUNTEMPLATES_FR_PACK $SUNTEMPLATES_HU_PACK $SUNTEMPLATES_IT_PACK; do check_file $TARFILE_LOCATION/$pack diff --git a/ooo.lst.in b/ooo.lst.in index 51695cf..991bca5 100644 --- a/ooo.lst.in +++ b/ooo.lst.in @@ -98,6 +98,7 @@ http://ooo.itc.hu/oxygenoffice/download/libreoffice/ @OOOP_TEMPLATES_PACK@ @OOOP_FONTS_PACK@ @OOOP_SAMPLES_PACK@ +@OXYGENOFFICE_PACK@ @CT2N_EXTENSION_PACK@ @BARCODE_EXTENSION_PACK@ @DIAGRAM_EXTENSION_PACK@ diff --git a/set_soenv.in b/set_soenv.in index 3011c09..b399531 100755 --- a/set_soenv.in +++ b/set_soenv.in @@ -1942,10 +1942,12 @@ ToFile( USE_FT_EMBOLDEN, @USE_FT_EMBOLDEN@, e ); ToFile( LIBXML_CFLAGS, @LIBXML_CFLAGS@,e ); ToFile( LIBXML_LIBS, @LIBXML_LIBS@, e ); ToFile( SYSTEM_EXPAT, @SYSTEM_EXPAT@, e ); -ToFile( WITH_EXTRA_GALLERY, @WITH_EXTRA_GALLERY@, e ); -ToFile( WITH_EXTRA_TEMPLATE, @WITH_EXTRA_TEMPLATE@, e ); -ToFile( WITH_EXTRA_SAMPLE, @WITH_EXTRA_SAMPLE@, e ); -ToFile( WITH_EXTRA_FONT, @WITH_EXTRA_FONT@, e ); +ToFile( WITH_EXTRA_GALLERY,@WITH_EXTRA_GALLERY@, e ); +ToFile( WITH_EXTRA_TEMPLATE,@WITH_EXTRA_TEMPLATE@, e ); +ToFile( WITH_EXTRA_SAMPLE, @WITH_EXTRA_SAMPLE@, e ); +ToFile( WITH_EXTRA_FONT, @WITH_EXTRA_FONT@, e ); +ToFile( ENABLE_OXYGENOFFICE,@ENABLE_OXYGENOFFICE@,e ); +ToFile( OXYGENOFFICE_PACK,@OXYGENOFFICE_PACK@,e ); ToFile( SYSTEM_DB, @SYSTEM_DB@,e ); ToFile( SYSTEM_DB_CFLAGS, @SYSTEM_DB_CFLAGS@, e ); ToFile( DB_LIB,@DB_LIB@, e ); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: drawinglayer/source oox/inc oox/source sc/source sfx2/source testautomation/writer
drawinglayer/source/processor2d/helperchartrenderer.cxx|2 +-
oox/inc/oox/xls/condformatbuffer.hxx |4 ++--
oox/inc/oox/xls/worksheethelper.hxx|2 +-
oox/source/xls/worksheethelper.cxx |4 ++--
sc/source/filter/inc/xicontent.hxx |4 ++--
sc/source/filter/inc/xiroot.hxx|4 ++--
sfx2/source/doc/doc.src|2 +-
testautomation/writer/optional/includes/number/w_205a_.inc |4 ++--
testautomation/writer/optional/includes/number/w_207_.inc |2 +-
9 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 37f509e15d74e005cbe264dd27106359c4165657
Author: Lior Kaplan kaplanl...@gmail.com
Date: Tue Nov 29 18:17:18 2011 +0200
Replace formattings with formatting
diff --git a/drawinglayer/source/processor2d/helperchartrenderer.cxx
b/drawinglayer/source/processor2d/helperchartrenderer.cxx
index 84e70ec..bf7dec5 100644
--- a/drawinglayer/source/processor2d/helperchartrenderer.cxx
+++ b/drawinglayer/source/processor2d/helperchartrenderer.cxx
@@ -90,7 +90,7 @@ namespace drawinglayer
// needs to be expressed in the MapMode for the
PrettyPainter;
// else it would call
ChartModelHelper::setPageSize(...) with the
// changed size what really will change the chart
model and leads
-// to re-layouts and re-formattings
+// to re-layouts and re-formatting
const MapMode
aOldMapMode(rOutputDevice.GetMapMode());
basegfx::B2DVector aVTScale, aScale, aTranslate;
double fRotate, fShearX;
diff --git a/oox/inc/oox/xls/condformatbuffer.hxx
b/oox/inc/oox/xls/condformatbuffer.hxx
index 3dba25b..4354178 100644
--- a/oox/inc/oox/xls/condformatbuffer.hxx
+++ b/oox/inc/oox/xls/condformatbuffer.hxx
@@ -171,7 +171,7 @@ public:
/** Imports settings from the CFHEADER record. */
voidimportCfHeader( BiffInputStream rStrm );
-/** Creates all conditional formattings in the Calc document. */
+/** Creates all conditional formatting in the Calc document. */
voidfinalizeImport();
/** Converts an OOXML condition operator token to the API constant. */
@@ -182,7 +182,7 @@ private:
private:
typedef RefVector CondFormat CondFormatVec;
-CondFormatVec maCondFormats; /// All conditional formattings in
a sheet.
+CondFormatVec maCondFormats; /// All conditional formatting in
a sheet.
};
//
diff --git a/oox/inc/oox/xls/worksheethelper.hxx
b/oox/inc/oox/xls/worksheethelper.hxx
index c824c4e..33ae0a8 100644
--- a/oox/inc/oox/xls/worksheethelper.hxx
+++ b/oox/inc/oox/xls/worksheethelper.hxx
@@ -255,7 +255,7 @@ public:
/** Returns the buffer for cell contents and cell formatting. */
SheetDataBuffergetSheetData() const;
-/** Returns the conditional formattings in this sheet. */
+/** Returns the conditional formatting in this sheet. */
CondFormatBuffer getCondFormats() const;
/** Returns the buffer for all cell comments in this sheet. */
CommentsBuffer getComments() const;
diff --git a/oox/source/xls/worksheethelper.cxx
b/oox/source/xls/worksheethelper.cxx
index ba5014f..e8a2972 100644
--- a/oox/source/xls/worksheethelper.cxx
+++ b/oox/source/xls/worksheethelper.cxx
@@ -277,7 +277,7 @@ public:
/** Returns the buffer for cell contents and cell formatting. */
inline SheetDataBuffer getSheetData() { return maSheetData; }
-/** Returns the conditional formattings in this sheet. */
+/** Returns the conditional formatting in this sheet. */
inline CondFormatBuffer getCondFormats() { return maCondFormats; }
/** Returns the buffer for all cell comments in this sheet. */
inline CommentsBuffer getComments() { return maComments; }
@@ -396,7 +396,7 @@ private:
ValidationModelList maValidations; /// Cell ranges containing data
validation settings.
ValueRangeSet maManualRowHeights; /// Rows that need manual height
independent from own settings.
SheetDataBuffer maSheetData;/// Buffer for cell contents and
cell formatting.
-CondFormatBuffermaCondFormats; /// Buffer for conditional
formattings.
+CondFormatBuffermaCondFormats; /// Buffer for conditional
formatting.
CommentsBuffer maComments; /// Buffer for all cell comments
in this sheet.
AutoFilterBuffermaAutoFilters; /// Sheet auto filters (not
associated to a table).
QueryTableBuffermaQueryTables; /// Buffer for all web query
tables in this sheet.
diff --git a/sc/source/filter/inc/xicontent.hxx
[Libreoffice-commits] .: 2 commits - sc/source
sc/source/ui/inc/tabcont.hxx |1 -
sc/source/ui/unoobj/docuno.cxx |7 ++-
sc/source/ui/view/tabcont.cxx | 16
sc/source/ui/view/tabview3.cxx |2 +-
4 files changed, 7 insertions(+), 19 deletions(-)
New commits:
commit 36d950fb16d214b7163223fc2b51f0990f96e494
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Tue Nov 29 11:50:03 2011 -0500
Let's not over-activate tab controls unnecessarily.
This interfares with the preview shell passing selected tabs back to
the view shell, by always selecting the first tab unconditionally.
The tabs get painted fine even without this call, so let's remove it.
diff --git a/sc/source/ui/inc/tabcont.hxx b/sc/source/ui/inc/tabcont.hxx
index 6e922fa..5691234 100644
--- a/sc/source/ui/inc/tabcont.hxx
+++ b/sc/source/ui/inc/tabcont.hxx
@@ -79,7 +79,6 @@ public:
voidUpdateInputContext();
voidUpdateStatus();
-voidActivateView(sal_Bool bActivate);
voidSetSheetLayoutRTL( sal_Bool bSheetRTL );
};
diff --git a/sc/source/ui/view/tabcont.cxx b/sc/source/ui/view/tabcont.cxx
index 5666349..230736a 100644
--- a/sc/source/ui/view/tabcont.cxx
+++ b/sc/source/ui/view/tabcont.cxx
@@ -377,22 +377,6 @@ void ScTabControl::UpdateStatus()
}
}
-void ScTabControl::ActivateView(sal_Bool bActivate)
-{
-ScMarkData rMark = pViewData-GetMarkData();
-
-sal_uInt16 nCurId = GetCurPageId();
-if (!nCurId) return;// kann vorkommen, wenn bei Excel-Import
alles versteckt ist
-sal_uInt16 nPage = nCurId - 1;
-
-if (bActivate)
-{
-SelectPage( nPage+1, sal_True );
-rMark.SelectTable( static_castSCTAB(nPage), sal_True );
-}
-Invalidate();
-}
-
void ScTabControl::SetSheetLayoutRTL( sal_Bool bSheetRTL )
{
SetEffectiveRTL( bSheetRTL );
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 8bedb88..556d3bf 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -2291,7 +2291,7 @@ void ScTabView::ActivateView( bool bActivate, bool bFirst
)
pHdl-EnterHandler();
}
}
-pTabControl-ActivateView(bActivate);
+
PaintExtras();
aViewData.Activate(bActivate);
commit 654c4be03c86cf00f0c66f876caa392e9391f8f5
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Tue Nov 29 11:24:27 2011 -0500
Let's check the validity of sheet indices. You never know...
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index b5de718..b9be493 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -899,8 +899,13 @@ bool ScModelObj::FillRenderMarkData( const uno::Any
aSelection,
{
uno::Sequencesal_Int32 aSelected =
xSelectedSheets-getSelectedSheets();
ScMarkData::MarkedTabsType aSelectedTabs;
+SCTAB nMaxTab = pDocShell-GetDocument()-GetTableCount() -1;
for (sal_Int32 i = 0, n = aSelected.getLength(); i n; ++i)
-aSelectedTabs.insert(static_castSCTAB(aSelected[i]));
+{
+SCTAB nSelected = static_castSCTAB(aSelected[i]);
+if (ValidTab(nSelected, nMaxTab))
+aSelectedTabs.insert(static_castSCTAB(aSelected[i]));
+}
rMark.SetSelectedTabs(aSelectedTabs);
}
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: g
g | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
New commits:
commit a7069c2aa24f40b8e47d148b7201f879faa2ff32
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Tue Nov 29 10:59:48 2011 -0600
git rev-parse argument are not files, no need to try to find abs-path
This was causing some error message on Windows
diff --git a/g b/g
index a47f3df..5b39c46 100755
--- a/g
+++ b/g
@@ -220,14 +220,19 @@ while shift ; do
exit 1
}
fi
-
-# make the paths absolute
-FILES[$FILESNUM]=$(perl -e 'use Cwd abs_path; print
abs_path(shift);' $PARAM)
-if [ -z ${FILES[$FILESNUM]} -o ! -e ${FILES[$FILESNUM]} ] ; then
-# it is probably not a file, but a tag name, or something
+if [ $COMMAND == rev-parse ] ; then
+# this is not a file
FILES[$FILESNUM]=$PARAM
-fi
-FILESNUM=$(($FILESNUM+1))
+FILESNUM=$(($FILESNUM+1))
+else
+# make the paths absolute
+FILES[$FILESNUM]=$(perl -e 'use Cwd abs_path; print
abs_path(shift);' $PARAM)
+if [ -z ${FILES[$FILESNUM]} -o ! -e ${FILES[$FILESNUM]} ] ;
then
+# it is probably not a file, but a tag name, or something
+FILES[$FILESNUM]=$PARAM
+fi
+FILESNUM=$(($FILESNUM+1))
+ fi
fi
done
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - automation/packimages automation/source desktop/win32 filter/source i18npool/source solenv/gbuild writerfilter/source
automation/packimages/Makefile |1 + automation/source/testtool/Makefile |2 ++ desktop/win32/source/setup/Makefile |1 + filter/source/svg/Makefile |1 + i18npool/source/breakiterator/Makefile |1 + i18npool/source/indexentry/Makefile |1 + i18npool/source/localedata/Makefile |1 + i18npool/source/textconversion/Makefile |1 + solenv/gbuild/UnoApiTarget.mk |6 +++--- writerfilter/source/Makefile|2 ++ 10 files changed, 14 insertions(+), 3 deletions(-) New commits: commit dd750cf42b308cdbf48ebd54fdd6f4fa0865b91a Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 29 18:10:55 2011 +0100 with announce letters shalt thou count to three, no more, no less diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk index 5511ec5..e5415df 100644 --- a/solenv/gbuild/UnoApiTarget.mk +++ b/solenv/gbuild/UnoApiTarget.mk @@ -158,13 +158,13 @@ endef .PHONY : $(call gb_UnoApiOutTarget_get_clean_target,%) $(call gb_UnoApiOutTarget_get_clean_target,%) : - $(call gb_Output_announce,$*,$(false),UNOAPI,1) + $(call gb_Output_announce,$*,$(false),UNO,1) -$(call gb_Helper_abbreviate_dirs,\ rm -f $(call gb_UnoApiOutTarget_get_target,$*)) .PHONY : $(call gb_UnoApiTarget_get_clean_target,%) $(call gb_UnoApiTarget_get_clean_target,%) : - $(call gb_Output_announce,$*,$(false),UNOAPI,1) + $(call gb_Output_announce,$*,$(false),UNO,1) -$(call gb_Helper_abbreviate_dirs,\ rm -f $(call gb_UnoApiTarget_get_target,$*)) -rm -rf $(call gb_UnoApiTarget_get_header_target,$*)\ @@ -213,7 +213,7 @@ $(call gb_UnoApiTarget_get_target,%): $(if $(gb_UnoApiTarget_IDLFILES_$*),$(call gb_UnoApiTarget__command,$@,$*,$,UCR,$(addprefix $(call gb_UnoApiPartTarget_get_target,),$(patsubst %.idl,%.urd,$(gb_UnoApiTarget_IDLFILES_$*) $(if $(UNOAPI_MERGE),$(call gb_UnoApiTarget__command,$@,$*,$,/,$(UNOAPI_MERGE))) $(if $(UNOAPI_REFERENCE), \ - $(call gb_Output_announce,$*,$(true),RDBCHEK,4) \ + $(call gb_Output_announce,$*,$(true),DBc,4) \ $(gb_UnoApiTarget_REGCOMPARECOMMAND) -f -t -r1 $(call gb_Helper_convert_native,$(UNOAPI_REFERENCE)) -r2 $(call gb_Helper_convert_native,$@)) $(if $(gb_UnoApiTarget_IDLFILES_$*), \ $(call gb_Output_announce,$*,$(true),HPP,4) \ commit b1d20f68474d91d8accafdeb403526b16a636220 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 29 18:04:42 2011 +0100 set gb_PARTIALBUILD in CustomTargets diff --git a/automation/packimages/Makefile b/automation/packimages/Makefile index 69631bb..a26f117 100644 --- a/automation/packimages/Makefile +++ b/automation/packimages/Makefile @@ -23,6 +23,7 @@ # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable # instead of those above. +gb_PARTIALBUILD:=T include $(GBUILDDIR)/gbuild_simple.mk BINDIR := $(dir $(GBUILDDIR))bin diff --git a/automation/source/testtool/Makefile b/automation/source/testtool/Makefile index f0d1d13..9b1e007 100644 --- a/automation/source/testtool/Makefile +++ b/automation/source/testtool/Makefile @@ -23,6 +23,8 @@ # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable # instead of those above. + +gb_PARTIALBUILD:=T include $(GBUILDDIR)/gbuild_simple.mk BASEDIR := $(dir $(firstword $(MAKEFILE_LIST))) diff --git a/desktop/win32/source/setup/Makefile b/desktop/win32/source/setup/Makefile index c5337ee..004f490 100644 --- a/desktop/win32/source/setup/Makefile +++ b/desktop/win32/source/setup/Makefile @@ -23,6 +23,7 @@ # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable # instead of those above. +gb_PARTIALBUILD:=T include $(GBUILDDIR)/gbuild_simple.mk DESTDIR := $(WORKDIR)/CustomTarget/desktop/win32/source/setup diff --git a/filter/source/svg/Makefile b/filter/source/svg/Makefile index 20ed8f8..31a4244 100644 --- a/filter/source/svg/Makefile +++ b/filter/source/svg/Makefile @@ -28,6 +28,7 @@ SRCDIR_FILTER := $(dir $(realpath $(firstword $(MAKEFILE_LIST WORKDIR_FILTER := . +gb_PARTIALBUILD:=T include $(GBUILDDIR)/gbuild.mk filter_SRC_svg_Tokens := $(SRCDIR_FILTER)/tokens.txt diff --git a/i18npool/source/breakiterator/Makefile b/i18npool/source/breakiterator/Makefile index 011dd6f..9f1a6ce 100644 --- a/i18npool/source/breakiterator/Makefile +++ b/i18npool/source/breakiterator/Makefile @@ -28,6 +28,7 @@ all : OpenOffice_dat.c data/dict_ja.cxx data/dict_zh.cxx +gb_PARTIALBUILD:=T include $(GBUILDDIR)/gbuild_simple.mk data: diff --git a/i18npool/source/indexentry/Makefile b/i18npool/source/indexentry/Makefile index c5335dc..cb0212c 100644 --- a/i18npool/source/indexentry/Makefile +++ b/i18npool/source/indexentry/Makefile @@ -28,6 +28,7 @@ all : $(subst .txt,.cxx,$(notdir $(wildcard
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.0.0'
Tag 'libreoffice-3.5.0.0' created by Petr Mladek pmla...@suse.cz at
2011-11-29 16:53 +0100
Tag $lo_version_tag (${vendor_use:+$vendor LO }$lo_version_app-$lo_release_id)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)
iQIcBAABAgAGBQJO1Q35AAoJEPQ0oe+v7q6jQSsQAI9Ca4hSf3uAGLnJHQmMLjHP
UxZQ1LKFlDt8cp3LzkRctd4+7Nk5/C+TNU7tZsrWGGIKMQtgRT+muZygl2wNv2t6
KenWvNLhSLa4uZLds/wOmby1BsXG0Yzb7mn0R3dNMZePzMw8QeQT+2+QYd30beu9
gTXV633xwtyDw0Wiej0Kzdm/SbcfqaMvKuOO5TO2t8gwtNROZiiAkhPuwlyWTkTp
GOtNkC1fu9mrdsUrCzUk25JsGSxmGSF6oRXQdajQQyzf9fykbSRSGm1KUTFQhnX2
vr1s9p4JbrVke41trVrO+jSBLbbDDku7QVtbYpdgiJspTYgAdaqqIP7hQWkXQ4bm
excHMR6hgqLSevxawX7qxKyzAnahvL3DAuquEeN6QxnaNfvRx8Rf1ei+nMLMH5Oz
NDCOEYgeGfLyNe6HKHcZQtaE0i5QJuO3ucMffJ5893SQ83r6+PZKNaR7vGTCHRTU
Bo+atXkmMP5GhqrdhSJa1eJqtgAToYzJQ0Dgdr5RmZiDQa5Mc7VNB5T4kCYhZXAL
CtEy2ayKx79+boqQ3bXV7XYjnFpdWZUjH+J1yBbxoqGq/bBO9VPQ5vbFuyOt8grd
ktPGDkV4LD/PCQ/l+DRGJYiHyqilcqUzIovSY/wItYYjaKtk6gkzqS+J8w9L4L1f
9dNo51OSJwDIEZ6BGtT6
=pz5v
-END PGP SIGNATURE-
Changes since windows_build_successful_2011_11_08-1229:
---
0 files changed
---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - connectivity/source
connectivity/source/drivers/postgresql/pq_array.cxx |6
-
connectivity/source/drivers/postgresql/pq_baseresultset.cxx | 18
+---
connectivity/source/drivers/postgresql/pq_connection.cxx| 42
+-
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 39
++---
connectivity/source/drivers/postgresql/pq_driver.cxx|6
-
connectivity/source/drivers/postgresql/pq_fakedupdateableresultset.cxx | 34
connectivity/source/drivers/postgresql/pq_preparedstatement.cxx | 13
+--
connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx | 13
++-
connectivity/source/drivers/postgresql/pq_sequenceresultsetmetadata.cxx | 17
+---
connectivity/source/drivers/postgresql/pq_statics.cxx |7
-
connectivity/source/drivers/postgresql/pq_updateableresultset.cxx |8
-
connectivity/source/drivers/postgresql/pq_xbase.cxx |2
connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx |2
connectivity/source/drivers/postgresql/pq_xindexes.cxx |1
connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx |2
connectivity/source/drivers/postgresql/pq_xuser.cxx |4
16 files changed, 119 insertions(+), 95 deletions(-)
New commits:
commit 1932529adf3a6f8b8f4785e4412e5f0deb50af45
Author: Michael Meeks michael.me...@suse.com
Date: Tue Nov 29 17:32:05 2011 +
postgresql: work around uninitialized warning.
diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
index 24cc8e0..7bca582 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
@@ -1872,7 +1872,7 @@ static void columnMetaData2DatabaseTypeDescription(
SequenceAnyVector::iterator ii = vec.begin();
OUString lastTableOid;
-sal_Int32 index;
+sal_Int32 index = 0;
Sequence Sequence Any ret( vec.size() );
int elements = 0;
for( ; ii != vec.end() ; ++ ii )
commit 4cc501d8173373e9656ae5e568b43e3cb90587e7
Author: Michael Meeks michael.me...@suse.com
Date: Tue Nov 29 17:18:30 2011 +
WaE: sizeable postgresql warning cleanup
diff --git a/connectivity/source/drivers/postgresql/pq_array.cxx
b/connectivity/source/drivers/postgresql/pq_array.cxx
index dcccd80..5158d9b 100644
--- a/connectivity/source/drivers/postgresql/pq_array.cxx
+++ b/connectivity/source/drivers/postgresql/pq_array.cxx
@@ -88,7 +88,7 @@ sal_Int32 Array::getBaseType( )
}
::com::sun::star::uno::Sequence ::com::sun::star::uno::Any Array::getArray(
-const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess typeMap )
+const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess /* typeMap */ )
throw (::com::sun::star::sdbc::SQLException,
::com::sun::star::uno::RuntimeException)
{
return m_data;
@@ -97,7 +97,7 @@ sal_Int32 Array::getBaseType( )
::com::sun::star::uno::Sequence ::com::sun::star::uno::Any
Array::getArrayAtIndex(
sal_Int32 index,
sal_Int32 count,
-const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess typeMap )
+const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess /* typeMap */ )
throw (::com::sun::star::sdbc::SQLException,
::com::sun::star::uno::RuntimeException)
{
checkRange( index, count );
@@ -114,7 +114,7 @@ sal_Int32 Array::getBaseType( )
::com::sun::star::uno::Reference ::com::sun::star::sdbc::XResultSet
Array::getResultSetAtIndex(
sal_Int32 index,
sal_Int32 count,
-const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess typeMap )
+const ::com::sun::star::uno::Reference
::com::sun::star::container::XNameAccess /* typeMap */ )
throw (::com::sun::star::sdbc::SQLException,
::com::sun::star::uno::RuntimeException)
{
checkRange( index, count );
diff --git a/connectivity/source/drivers/postgresql/pq_baseresultset.cxx
b/connectivity/source/drivers/postgresql/pq_baseresultset.cxx
index 5c5bee5..8318080 100644
--- a/connectivity/source/drivers/postgresql/pq_baseresultset.cxx
+++ b/connectivity/source/drivers/postgresql/pq_baseresultset.cxx
@@ -583,39 +583,39 @@ Sequence sal_Int8 BaseResultSet::getBytes( sal_Int32
columnIndex )
}
// LEM TODO: these look like they are missing an actual implementation
-Reference ::com::sun::star::io::XInputStream
BaseResultSet::getBinaryStream( sal_Int32 columnIndex )
+Reference ::com::sun::star::io::XInputStream
BaseResultSet::getBinaryStream( sal_Int32 /* columnIndex */ )
throw (SQLException, RuntimeException)
{
return 0;
}
-Reference ::com::sun::star::io::XInputStream
[Libreoffice-commits] .: sw/Library_sw.mk sw/source
sw/Library_sw.mk |3
sw/source/core/inc/sortedobjs.hxx|7
sw/source/core/inc/sortedobjsimpl.hxx| 64 --
sw/source/core/layout/sortedobjs.cxx | 240 +++-
sw/source/core/layout/sortedobjsimpl.cxx | 302 ---
5 files changed, 235 insertions(+), 381 deletions(-)
New commits:
commit 1e19c59d51b2184bbc2f7b794fe411946553548f
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Nov 29 21:43:38 2011 +0400
merge SwSortedObjsImpl into SwSortedObjs
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index fe1da1c..40e70f3 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -2,7 +2,7 @@
#*
#
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-#
+#
# Copyright 2000, 2011 Oracle and/or its affiliates.
#
# OpenOffice.org - a multi-platform office productivity suite
@@ -315,7 +315,6 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
sw/source/core/layout/sectfrm \
sw/source/core/layout/softpagebreak \
sw/source/core/layout/sortedobjs \
-sw/source/core/layout/sortedobjsimpl \
sw/source/core/layout/ssfrm \
sw/source/core/layout/swselectionlist \
sw/source/core/layout/tabfrm \
diff --git a/sw/source/core/inc/sortedobjs.hxx
b/sw/source/core/inc/sortedobjs.hxx
index 720ff08..afb770a 100644
--- a/sw/source/core/inc/sortedobjs.hxx
+++ b/sw/source/core/inc/sortedobjs.hxx
@@ -27,10 +27,11 @@
/
#ifndef _SORTEDOBJS_HXX
#define _SORTEDOBJS_HXX
-class SwSortedObjsImpl;
-class SwAnchoredObject;
#include sal/types.h
+#include vector
+
+class SwAnchoredObject;
/** class for collecting anchored objects
@@ -56,7 +57,7 @@ class SwAnchoredObject;
class SwSortedObjs
{
private:
-SwSortedObjsImpl* mpImpl;
+std::vector SwAnchoredObject* maSortedObjLst;
public:
SwSortedObjs();
diff --git a/sw/source/core/inc/sortedobjsimpl.hxx
b/sw/source/core/inc/sortedobjsimpl.hxx
deleted file mode 100644
index 1b23cd1..000
--- a/sw/source/core/inc/sortedobjsimpl.hxx
+++ /dev/null
@@ -1,64 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org. If not, see
- * http://www.openoffice.org/license.html
- * for a copy of the LGPLv3 License.
- *
- /
-#ifndef _SORTEDOBJSIMPL_HXX
-#define _SORTEDOBJSIMPL_HXX
-
-#include vector
-#include sal/types.h
-#include fmtanchr.hxx
-
-class SwAnchoredObject;
-class SwTxtFrm;
-
-class SwSortedObjsImpl
-{
-private:
-std::vector SwAnchoredObject* maSortedObjLst;
-
-public:
-SwSortedObjsImpl();
-~SwSortedObjsImpl();
-
-sal_uInt32 Count() const;
-
-SwAnchoredObject* operator[]( sal_uInt32 _nIndex );
-
-bool Insert( SwAnchoredObject _rAnchoredObj );
-
-bool Remove( SwAnchoredObject _rAnchoredObj );
-
-bool Contains( const SwAnchoredObject _rAnchoredObj ) const;
-
-bool Update( SwAnchoredObject _rAnchoredObj );
-
-sal_uInt32 ListPosOf( const SwAnchoredObject _rAnchoredObj ) const;
-};
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/layout/sortedobjs.cxx
b/sw/source/core/layout/sortedobjs.cxx
index c5eb79f..3d116ca 100644
--- a/sw/source/core/layout/sortedobjs.cxx
+++ b/sw/source/core/layout/sortedobjs.cxx
@@ -27,51 +27,271 @@
/
#include sortedobjs.hxx
-#include sortedobjsimpl.hxx
+
+#include algorithm
+#include anchoredobject.hxx
+#include fmtanchr.hxx
+#include fmtsrnd.hxx
+#include fmtwrapinfluenceonobjpos.hxx
+#include frmfmt.hxx
+#include pam.hxx
+#include svx/svdobj.hxx
+#include IDocumentDrawModelAccess.hxx
+
+
+using namespace ::com::sun::star;
+
[Libreoffice-commits] .: 2 commits - sc/inc sc/source unotools/source
sc/inc/nameuno.hxx |5 +++--
sc/source/ui/unoobj/nameuno.cxx |4 ++--
unotools/source/ucbhelper/ucbhelper.cxx | 15 +++
3 files changed, 12 insertions(+), 12 deletions(-)
New commits:
commit d3c772229cf93ecb1296a67f4ddf5e73afe41b7e
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Nov 29 20:03:10 2011 +0100
Use rtl::Reference.
diff --git a/sc/inc/nameuno.hxx b/sc/inc/nameuno.hxx
index 4872373..a83748c 100644
--- a/sc/inc/nameuno.hxx
+++ b/sc/inc/nameuno.hxx
@@ -49,6 +49,7 @@
#include cppuhelper/implbase3.hxx
#include cppuhelper/implbase5.hxx
#include cppuhelper/implbase6.hxx
+#include rtl/ref.hxx
class ScDocShell;
class ScRangeName;
@@ -67,7 +68,7 @@ class ScNamedRangeObj : public ::cppu::WeakImplHelper6
public SfxListener
{
private:
-com::sun::star::uno::Reference com::sun::star::sheet::XNamedRanges
mxParent;
+rtl::Reference ScNamedRangesObj mxParent;
ScDocShell* pDocShell;
String aName;
com::sun::star::uno::Reference com::sun::star::container::XNamed
mxSheet;
@@ -81,7 +82,7 @@ private:
SCTAB GetTab_Impl();
public:
-ScNamedRangeObj( com::sun::star::uno::Reference
com::sun::star::sheet::XNamedRanges xParent, ScDocShell* pDocSh, const
String rNm,
+ScNamedRangeObj( rtl::Reference ScNamedRangesObj
xParent, ScDocShell* pDocSh, const String rNm,
com::sun::star::uno::Reference
com::sun::star::container::XNamed xSheet = com::sun::star::uno::Reference
com::sun::star::container::XNamed ());
virtual ~ScNamedRangeObj();
diff --git a/sc/source/ui/unoobj/nameuno.cxx b/sc/source/ui/unoobj/nameuno.cxx
index 3facf43..60f3025 100644
--- a/sc/source/ui/unoobj/nameuno.cxx
+++ b/sc/source/ui/unoobj/nameuno.cxx
@@ -97,7 +97,7 @@ bool lcl_UserVisibleName(const ScRangeData rData)
return !rData.HasType(RT_DATABASE) !rData.HasType(RT_SHARED);
}
-ScNamedRangeObj::ScNamedRangeObj( Reference sheet::XNamedRanges xParent,
ScDocShell* pDocSh, const String rNm, Referencecontainer::XNamed xSheet):
+ScNamedRangeObj::ScNamedRangeObj( rtl::Reference ScNamedRangesObj xParent,
ScDocShell* pDocSh, const String rNm, Referencecontainer::XNamed xSheet):
mxParent(xParent),
pDocShell( pDocSh ),
aName( rNm ),
@@ -213,7 +213,7 @@ void ScNamedRangeObj::Modify_Impl( const String* pNewName,
const ScTokenArray* p
if (pNewRanges-insert(pNew))
{
ScDocFunc aFunc(*pDocShell);
-aFunc.SetNewRangeNames(pNewRanges,
dynamic_castScNamedRangesObj*(mxParent.get())-IsModifyAndBroadcast(), nTab);
+aFunc.SetNewRangeNames(pNewRanges, mxParent-IsModifyAndBroadcast(),
nTab);
aName = aInsName; //! broadcast?
}
commit ca6052b9a62596902f901f8fa36680d7abe989f5
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Nov 29 20:02:50 2011 +0100
Special casing can be removed again.
diff --git a/unotools/source/ucbhelper/ucbhelper.cxx
b/unotools/source/ucbhelper/ucbhelper.cxx
index 935620f..8487816 100644
--- a/unotools/source/ucbhelper/ucbhelper.cxx
+++ b/unotools/source/ucbhelper/ucbhelper.cxx
@@ -483,9 +483,6 @@ bool utl::UCBContentHelper::IsSubPath(
bool utl::UCBContentHelper::EqualURLs(
rtl::OUString const url1, rtl::OUString const url2)
{
-if (url1.isEmpty() || url2.isEmpty()) {
-return false;
-}
ucbhelper::ContentBroker * broker = ucbhelper::ContentBroker::get();
if (broker == 0) {
throw css::uno::RuntimeException(
@@ -493,11 +490,13 @@ bool utl::UCBContentHelper::EqualURLs(
RTL_CONSTASCII_USTRINGPARAM(no ucbhelper::ContentBroker)),
css::uno::Referencecss::uno::XInterface());
}
-return 0 == broker-getContentProviderInterface()-compareContentIds(
-(broker-getContentIdentifierFactoryInterface()-
- createContentIdentifier(canonic(url1))),
-(broker-getContentIdentifierFactoryInterface()-
- createContentIdentifier(canonic(url2;
+return
+broker-getContentProviderInterface()-compareContentIds(
+(broker-getContentIdentifierFactoryInterface()-
+ createContentIdentifier(canonic(url1))),
+(broker-getContentIdentifierFactoryInterface()-
+ createContentIdentifier(canonic(url2
+== 0;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: icc/source
icc/source/create_sRGB_profile/create_sRGB_profile.cpp |5 +
1 file changed, 5 insertions(+)
New commits:
commit 2c4537471c932b65e6f72e41881b505c4bbad12c
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date: Tue Nov 29 20:00:55 2011 +0100
dont mindlessly touch the icc-header file on every build
- this little gremlin touches the header file everytime it is run
- as icc is very low level, this causes a lot of pointless rebuild
- everything from vcl up gets relinked
- this slows every empty 'make build' down by more than 40 percent
- would really need to check if the file changed before writing, but as we
rarely change icc itself, I didnt bother with that
diff --git a/icc/source/create_sRGB_profile/create_sRGB_profile.cpp
b/icc/source/create_sRGB_profile/create_sRGB_profile.cpp
index cceb0c5..2d6b52f 100644
--- a/icc/source/create_sRGB_profile/create_sRGB_profile.cpp
+++ b/icc/source/create_sRGB_profile/create_sRGB_profile.cpp
@@ -474,6 +474,11 @@ int main(int argc, char* argv[])
profile.Write(out);
out.Close();
+if(FILE *headerfile_exists = fopen(hxx_file_name,r))
+{
+fclose(headerfile_exists);
+exit(0);
+}
FILE *headerfile = fopen(hxx_file_name,w);
//print OpenOffice standard file header
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/gbuild.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eef80c23ffc790ae30feb5048e978c48e7b76e73 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Nov 29 20:15:24 2011 +0100 use gb_MINISOLARENV for platform check diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk index 57387f1..f6a38af 100644 --- a/solenv/gbuild/gbuild.mk +++ b/solenv/gbuild/gbuild.mk @@ -151,7 +151,7 @@ $(eval $(call gb_Helper_collect_libtargets)) gb_Library_DLLPOSTFIX := lo # Include platform/cpu/compiler specific config/definitions -ifneq ($(strip $(OS)),) +ifeq ($(strip $(gb_MINISOLARENV)),) include $(GBUILDDIR)/platform/$(OS)_$(CPUNAME)_$(COM).mk endif ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/Module_sc.mk
sc/Module_sc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 92440ddb00a4f2bc8c2a8dc726c20bca78d5b916 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Nov 29 13:46:44 2011 +0100 move sc's macros_test to the subsequenttest target diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk index 6a18985..d7d18dd 100644 --- a/sc/Module_sc.mk +++ b/sc/Module_sc.mk @@ -36,11 +36,11 @@ $(eval $(call gb_Module_add_targets,sc,\ $(eval $(call gb_Module_add_check_targets,sc,\ CppunitTest_sc_filters_test \ - CppunitTest_sc_macros_test \ CppunitTest_sc_ucalc \ )) $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\ +CppunitTest_sc_macros_test \ JunitTest_sc_unoapi \ )) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 17 commits - oox/inc oox/source starmath/source
oox/inc/oox/mathml/importutils.hxx | 17 ++
oox/source/mathml/importutils.cxx | 124 +++--
oox/source/token/tokens.pl | 38 ++---
starmath/source/mathtype.cxx |2
starmath/source/ooxmlexport.cxx|2
starmath/source/ooxmlimport.cxx| 257 ++---
starmath/source/ooxmlimport.hxx|8 +
7 files changed, 359 insertions(+), 89 deletions(-)
New commits:
commit a115442064c3c6a2ea398895159b62040d079cbb
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Tue Nov 29 21:18:39 2011 +0100
import docx m:m
diff --git a/starmath/source/ooxmlimport.cxx b/starmath/source/ooxmlimport.cxx
index 530195c..c0d84ab 100644
--- a/starmath/source/ooxmlimport.cxx
+++ b/starmath/source/ooxmlimport.cxx
@@ -122,6 +122,9 @@ OUString SmOoxmlImport::readOMathArg()
case OPENING( M_TOKEN( groupChr )):
ret += handleGroupChr();
break;
+case OPENING( M_TOKEN( m )):
+ret += handleM();
+break;
case OPENING( M_TOKEN( r )):
ret += handleR();
break;
@@ -398,6 +401,29 @@ OUString SmOoxmlImport::handleGroupChr()
return ret;
}
+OUString SmOoxmlImport::handleM()
+{
+stream.ensureOpeningTag( M_TOKEN( m ));
+OUString allrows;
+do // there must be at least one m:mr
+{
+stream.ensureOpeningTag( M_TOKEN( mr ));
+OUString row;
+do // there must be at least one m:e
+{
+if( !row.isEmpty())
+row += STR( # );
+row += handleE();
+} while( !stream.atEnd() stream.currentToken() == OPENING( M_TOKEN(
e )));
+if( !allrows.isEmpty())
+allrows += STR( ## );
+allrows += row;
+stream.ensureClosingTag( M_TOKEN( mr ));
+} while( !stream.atEnd() stream.currentToken() == OPENING( M_TOKEN( mr
)));
+stream.ensureClosingTag( M_TOKEN( m ));
+return STR( matrix { ) + allrows + STR( } );
+}
+
// NOT complete
OUString SmOoxmlImport::handleR()
{
diff --git a/starmath/source/ooxmlimport.hxx b/starmath/source/ooxmlimport.hxx
index c0786bc..05963d6 100644
--- a/starmath/source/ooxmlimport.hxx
+++ b/starmath/source/ooxmlimport.hxx
@@ -54,6 +54,7 @@ private:
enum LimLowUpp_t { LimLow, LimUpp };
rtl::OUString handleLimLowUpp( LimLowUpp_t limlowupp );
rtl::OUString handleGroupChr();
+rtl::OUString handleM();
rtl::OUString handleR();
rtl::OUString readOMathArg();
oox::formulaimport::XmlStream stream;
commit 82c78e8790f341373c84f4b5bae5b3834b7b18ce
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Tue Nov 29 21:09:43 2011 +0100
finish reading in while() also when end of stream, just in case
diff --git a/starmath/source/ooxmlimport.cxx b/starmath/source/ooxmlimport.cxx
index 2a29d0a..530195c 100644
--- a/starmath/source/ooxmlimport.cxx
+++ b/starmath/source/ooxmlimport.cxx
@@ -89,7 +89,7 @@ OUString SmOoxmlImport::handleStream()
OUString SmOoxmlImport::readOMathArg()
{
OUString ret;
-while( stream.currentToken() != CLOSING( stream.currentToken()))
+while( !stream.atEnd() stream.currentToken() != CLOSING(
stream.currentToken()))
{
if( !ret.isEmpty())
ret += STR( );
@@ -409,7 +409,7 @@ OUString SmOoxmlImport::handleR()
stream.ensureClosingTag( OOX_TOKEN( doc, rPr ));
}
OUString text;
-while( stream.currentToken() != CLOSING( stream.currentToken()))
+while( !stream.atEnd() stream.currentToken() != CLOSING(
stream.currentToken()))
{
switch( stream.currentToken())
{
commit ad1a6c6d507f2480efa582ad8b864d65dede1314
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Tue Nov 29 21:06:44 2011 +0100
improve import of docx m:d
diff --git a/starmath/source/ooxmlimport.cxx b/starmath/source/ooxmlimport.cxx
index 6d3e4c9..2a29d0a 100644
--- a/starmath/source/ooxmlimport.cxx
+++ b/starmath/source/ooxmlimport.cxx
@@ -243,9 +243,9 @@ OUString SmOoxmlImport::handleBorderBox()
OUString SmOoxmlImport::handleD()
{
stream.ensureOpeningTag( M_TOKEN( d ));
-sal_Unicode opening = '(';
-sal_Unicode closing = ')';
-sal_Unicode separator = '|';
+OUString opening = STR( ( );
+OUString closing = STR( ) );
+OUString separator = STR( | );
if( XmlStream::Tag dPr = stream.checkOpeningTag( M_TOKEN( dPr )))
{
if( XmlStream::Tag begChr = stream.checkOpeningTag( M_TOKEN( begChr )))
@@ -265,15 +265,40 @@ OUString SmOoxmlImport::handleD()
}
stream.ensureClosingTag( M_TOKEN( dPr ));
}
+if( opening == STR( { ))
+opening = STR( left lbrace );
+if( closing == STR( } ))
+closing = STR( right rbrace );
+if( opening == OUString( sal_Unicode( 0x27e6 )))
+opening = STR( left ldbracket );
+if( closing == OUString( sal_Unicode( 0x27e7 )))
+closing = STR( right rdbracket );
+if( opening == STR( | ))
+
[Libreoffice-commits] .: sc/JunitTest_sc_complex.mk sc/Module_sc.mk sc/qa
sc/JunitTest_sc_complex.mk | 60 +++ sc/Module_sc.mk |1 sc/qa/complex/cellRanges/makefile.mk | 51 - sc/qa/complex/dataPilot/interfaceTests/beans/makefile.mk | 46 sc/qa/complex/dataPilot/interfaceTests/container/makefile.mk | 46 sc/qa/complex/dataPilot/interfaceTests/sheet/makefile.mk | 46 sc/qa/complex/dataPilot/makefile.mk | 59 -- sc/qa/complex/sc/makefile.mk | 51 - 8 files changed, 61 insertions(+), 299 deletions(-) New commits: commit da65218ce1160305e7d60ed6a74f48324f08c83c Author: Stephan Bergmann sberg...@redhat.com Date: Tue Nov 29 21:48:26 2011 +0100 Enabled sc/qa/complex again. sc/qa/complex/calcPreview/ tests do not work automatically and have been left alone. diff --git a/sc/JunitTest_sc_complex.mk b/sc/JunitTest_sc_complex.mk new file mode 100644 index 000..225c44b --- /dev/null +++ b/sc/JunitTest_sc_complex.mk @@ -0,0 +1,60 @@ +## +## Version: MPL 1.1 / GPLv3+ / LGPLv3+ +## +## The contents of this file are subject to the Mozilla Public License Version +## 1.1 (the License); you may not use this file except in compliance with +## the License or as specified alternatively below. You may obtain a copy of +## the License at http://www.mozilla.org/MPL/ +## +## Software distributed under the License is distributed on an AS IS basis, +## WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License +## for the specific language governing rights and limitations under the +## License. +## +## Major Contributor(s): +## [ Copyright (C) 2011 Stephan Bergmann sberg...@redhat.com (initial +## developer) ] +## +## All Rights Reserved. +## +## For minor contributions see the git repository. +## +## Alternatively, the contents of this file may be used under the terms of +## either the GNU General Public License Version 3 or later (the GPLv3+), or +## the GNU Lesser General Public License Version 3 or later (the LGPLv3+), +## in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable +## instead of those above. +## + +$(eval $(call gb_JunitTest_JunitTest,sc_complex,SRCDIR)) + +# sc/qa/complex/calcPreview/ tests do not work autmatically (they request Press +# any key after resizing etc.) + +$(eval $(call gb_JunitTest_add_classes,sc_complex, \ +complex.cellRanges.CheckXCellRangesQuery \ +complex.dataPilot.CheckDataPilot \ +complex.sc.CalcRTL \ +)) + +$(eval $(call gb_JunitTest_add_jars,sc_complex, \ +$(OUTDIR)/bin/OOoRunner.jar \ +$(OUTDIR)/bin/jurt.jar \ +$(OUTDIR)/bin/ridl.jar \ +$(OUTDIR)/bin/test.jar \ +$(OUTDIR)/bin/unoil.jar \ +)) + +$(eval $(call gb_JunitTest_add_sourcefiles,sc_complex, \ +sc/qa/complex/cellRanges/CheckXCellRangesQuery \ +sc/qa/complex/dataPilot/CheckDataPilot \ +sc/qa/complex/dataPilot/_XDataPilotDescriptor \ +sc/qa/complex/dataPilot/_XDataPilotTable \ +sc/qa/complex/dataPilot/_XNamed \ +sc/qa/complex/dataPilot/_XPropertySet \ +sc/qa/complex/sc/CalcRTL \ +)) + +$(eval $(call gb_JunitTest_set_defs,sc_complex, \ +$$(DEFS) \ +)) diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk index d7d18dd..0e15220 100644 --- a/sc/Module_sc.mk +++ b/sc/Module_sc.mk @@ -41,6 +41,7 @@ $(eval $(call gb_Module_add_check_targets,sc,\ $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\ CppunitTest_sc_macros_test \ +JunitTest_sc_complex \ JunitTest_sc_unoapi \ )) diff --git a/sc/qa/complex/cellRanges/makefile.mk b/sc/qa/complex/cellRanges/makefile.mk deleted file mode 100755 index a0beb38..000 --- a/sc/qa/complex/cellRanges/makefile.mk +++ /dev/null @@ -1,51 +0,0 @@ -#* -# -# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# -# Copyright 2000, 2010 Oracle and/or its affiliates. -# -# OpenOffice.org - a multi-platform office productivity suite -# -# This file is part of OpenOffice.org. -# -# OpenOffice.org is free software: you can redistribute it and/or modify -# it under the terms of the GNU Lesser General Public License version 3 -# only, as published by the Free Software Foundation. -# -# OpenOffice.org is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU Lesser General Public License version 3 for more details -# (a copy is included in the LICENSE file that accompanied this code). -# -# You should have received a copy of the GNU Lesser General Public License -# version 3 along with OpenOffice.org. If not, see -# http://www.openoffice.org/license.html -# for a copy of the LGPLv3 License. -# -#* - -.IF $(OOO_SUBSEQUENT_TESTS)
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - reportdesign/inc reportdesign/source
reportdesign/inc/RptObject.hxx |4 ++
reportdesign/source/core/sdr/RptObject.cxx | 58 ++---
2 files changed, 41 insertions(+), 21 deletions(-)
New commits:
commit a34fee81312413f38f7db3facaac643b2c289d19
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 25 20:16:36 2011 +
Resolves: fdo#39950 fix dnd crash from default assignment operators
Signed-off-by: Lionel Elie Mamane lio...@mamane.lu
Signed-off-by: Michael Meeks michael.me...@suse.com
diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx
index d58950b..e24d51f 100644
--- a/reportdesign/inc/RptObject.hxx
+++ b/reportdesign/inc/RptObject.hxx
@@ -224,6 +224,8 @@ public:
virtual OOle2Obj* Clone() const;
virtual void initializeOle();
+OOle2Obj operator=(const OOle2Obj rObj);
+
void initializeChart( const ::com::sun::star::uno::Reference
::com::sun::star::frame::XModel _xModel);
};
@@ -275,6 +277,8 @@ public:
virtual sal_uInt32 GetObjInventor() const;
virtual OUnoObject* Clone() const;
+OUnoObject operator=(const OUnoObject rObj);
+
private:
voidimpl_setReportComponent_nothrow();
voidimpl_initializeModel_nothrow();
diff --git a/reportdesign/source/core/sdr/RptObject.cxx
b/reportdesign/source/core/sdr/RptObject.cxx
index 1f6a01a..80d56cb 100644
--- a/reportdesign/source/core/sdr/RptObject.cxx
+++ b/reportdesign/source/core/sdr/RptObject.cxx
@@ -941,18 +941,24 @@ uno::Reference uno::XInterface
OUnoObject::getUnoShape()
{
return OObjectBase::getUnoShapeOf( *this );
}
-//
-
+
+OUnoObject OUnoObject::operator=(const OUnoObject rObj)
+{
+if( this == rObj )
+return *this;
+SdrUnoObj::operator=(rObj);
+
+ReferenceXPropertySet
xSource(const_castOUnoObject(rObj).getUnoShape(), uno::UNO_QUERY);
+ReferenceXPropertySet xDest(getUnoShape(), uno::UNO_QUERY);
+if ( xSource.is() xDest.is() )
+comphelper::copyProperties(xSource.get(), xDest.get());
+
+return *this;
+}
+
OUnoObject* OUnoObject::Clone() const
{
-OUnoObject* pClone = CloneHelper OUnoObject ();
-if ( pClone )
-{
-ReferenceXPropertySet
xSource(const_castOUnoObject*(this)-getUnoShape(),uno::UNO_QUERY);
-ReferenceXPropertySet xDest(pClone-getUnoShape(),uno::UNO_QUERY);
-if ( xSource.is() xDest.is() )
-comphelper::copyProperties(xSource.get(),xDest.get());
-}
-return pClone;
+return CloneHelper OUnoObject ();
}
//
// OOle2Obj
@@ -1128,22 +1134,32 @@ uno::Reference chart2::data::XDatabaseDataProvider
lcl_getDataProvider(const
}
return xSource;
}
-//
-
-// Clone() soll eine komplette Kopie des Objektes erzeugen.
-OOle2Obj* OOle2Obj::Clone() const
+
+OOle2Obj OOle2Obj::operator=(const OOle2Obj rObj)
{
-OOle2Obj* pObj = CloneHelper OOle2Obj ();
-OReportModel* pRptModel = static_castOReportModel*(GetModel());
-svt::EmbeddedObjectRef::TryRunningState( pObj-GetObjRef() );
-
pObj-impl_createDataProvider_nothrow(pRptModel-getReportDefinition().get());
+if( this == rObj )
+return *this;
+SdrOle2Obj::operator=(rObj);
-uno::Reference chart2::data::XDatabaseDataProvider xSource(
lcl_getDataProvider(GetObjRef()) );
-uno::Reference chart2::data::XDatabaseDataProvider xDest(
lcl_getDataProvider(pObj-GetObjRef()) );
+OReportModel* pRptModel = static_castOReportModel*(rObj.GetModel());
+svt::EmbeddedObjectRef::TryRunningState( GetObjRef() );
+impl_createDataProvider_nothrow(pRptModel-getReportDefinition().get());
+
+uno::Reference chart2::data::XDatabaseDataProvider xSource(
lcl_getDataProvider(rObj.GetObjRef()) );
+uno::Reference chart2::data::XDatabaseDataProvider xDest(
lcl_getDataProvider(GetObjRef()) );
if ( xSource.is() xDest.is() )
comphelper::copyProperties(xSource.get(),xDest.get());
-pObj-initializeChart(pRptModel-getReportDefinition().get());
-return pObj;
+initializeChart(pRptModel-getReportDefinition().get());
+
+return *this;
+}
+
+//
-
+// Clone() soll eine komplette Kopie des Objektes erzeugen.
+OOle2Obj* OOle2Obj::Clone() const
+{
+return CloneHelper OOle2Obj ();
}
//
-
void OOle2Obj::impl_createDataProvider_nothrow(const uno::Reference
frame::XModel _xModel)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - bin/distro-install-desktop-integration solenv/gbuild
bin/distro-install-desktop-integration |2 +- solenv/gbuild/extensions/post_AuxTargets.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit b7b23ac999393c02ec68f19667960183f512bf43 Author: Rene Engelhard r...@debian.org Date: Tue Nov 29 22:28:58 2011 + don't remove Makefile on make distclean, we need it now in all cases... diff --git a/solenv/gbuild/extensions/post_AuxTargets.mk b/solenv/gbuild/extensions/post_AuxTargets.mk index a08d46e..962f275 100644 --- a/solenv/gbuild/extensions/post_AuxTargets.mk +++ b/solenv/gbuild/extensions/post_AuxTargets.mk @@ -71,7 +71,7 @@ clean-build: distclean: clean if [ -f $(SRCDIR)/dmake/Makefile ] ; then $(GNUMAKE) -C $(SRCDIR)/dmake clean; fi - cd $(SRCDIR) rm -rf Env.Host.sh Makefile aclocal.m4 autogen.lastrun autom4te.cache \ + cd $(SRCDIR) rm -rf Env.Host.sh aclocal.m4 autogen.lastrun autom4te.cache \ bin/repo-list build_env config.log config.status configure \ desktop/scripts/soffice.sh ooo.lst post_download post_download.log \ set_soenv set_soenv.last set_soenv.stamp src.downloaded warn commit 7f31dfc4b6265b7115f07bc711c969e0e86e5118 Author: Rene Engelhard r...@debian.org Date: Fri Nov 11 16:46:55 2011 + fix test: s/==/=/ diff --git a/bin/distro-install-desktop-integration b/bin/distro-install-desktop-integration index f988e12..6e45285 100755 --- a/bin/distro-install-desktop-integration +++ b/bin/distro-install-desktop-integration @@ -66,7 +66,7 @@ add_wrapper() # do we want compat oowrapper? oowrapper_name= -if test $WITH_COMPAT_OOWRAPPERS == 'YES' ; then +if test $WITH_COMPAT_OOWRAPPERS = 'YES' ; then oowrapper_name=`echo $lowrapper_name | sed -e s/^lo/oo/` # oo prefix only for wrappers stating with lo prefix test $oowrapper_name = $lowrapper_name oowrapper_name= ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 4 commits - extensions/CppunitTest_extensions_test_update.mk extensions/qa extensions/source
extensions/CppunitTest_extensions_test_update.mk | 25 +
extensions/qa/update/simple.xml | 10 ++
extensions/qa/update/test_update.cxx | 94 ++
extensions/source/update/check/updateprotocol.cxx | 27 +-
extensions/source/update/check/updateprotocol.hxx | 14 +++
extensions/source/update/feed/makefile.mk |1
extensions/source/update/feed/updatefeed.cxx | 68 +++
7 files changed, 164 insertions(+), 75 deletions(-)
New commits:
commit cb937da55c3ab3d238b97d6e0e709ea2a04d2c26
Author: Jan Holesovsky ke...@suse.cz
Date: Wed Nov 30 00:11:01 2011 +0100
online update: Now check even the checkForUpdates().
diff --git a/extensions/qa/update/test_update.cxx
b/extensions/qa/update/test_update.cxx
index 57ff71c..84cbc4f 100644
--- a/extensions/qa/update/test_update.cxx
+++ b/extensions/qa/update/test_update.cxx
@@ -128,14 +128,14 @@ protected:
rtl::Reference UpdateCheck aController( UpdateCheck::get() );
if ( checkForUpdates( aInfo, m_xContext,
aController-getInteractionHandler(), m_xProvider,
-rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( OS ) ),
-rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( Arch ) ),
+rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( Linux ) ),
+rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( x86 ) ),
m_aRepositoryList,
-rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( BuildID ) ),
+rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 100 ) ),
rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( InstallSetID
) ) ) )
{
-//aController-setUpdateInfo( aInfo );
-// TODO check the result
+CPPUNIT_ASSERT( aInfo.Sources.size() == 1 );
+CPPUNIT_ASSERT( aInfo.Sources[0].URL == rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( http://www.libreoffice.org/download/; ) ) );
}
else
CPPUNIT_FAIL( Calling checkForUpdates() failed. );
commit 358ce1e9c1d85ae7590ecc2b2ddee9db81cf8b84
Author: Jan Holesovsky ke...@suse.cz
Date: Tue Nov 29 22:48:29 2011 +0100
online update: Cleanup after UpdateInformationProvider::load() rewrite.
diff --git a/extensions/source/update/feed/updatefeed.cxx
b/extensions/source/update/feed/updatefeed.cxx
index f5caafc..21bfecf 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -210,15 +210,11 @@ private:
uno::Reference ucb::XCommandProcessor const rxCommandProcessor);
UpdateInformationProvider(const uno::Referenceuno::XComponentContext
xContext,
- const uno::Reference
ucb::XContentIdentifierFactory xContentIdFactory,
- const uno::Reference ucb::XContentProvider
xContentProvider,
const uno::Reference xml::dom::XDocumentBuilder
xDocumentBuilder,
const uno::Reference xml::xpath::XXPathAPI
xXPathAPI);
const uno::Reference uno::XComponentContext m_xContext;
-const uno::Reference ucb::XContentIdentifierFactory m_xContentIdFactory;
-const uno::Reference ucb::XContentProvider m_xContentProvider;
const uno::Reference xml::dom::XDocumentBuilder m_xDocumentBuilder;
const uno::Reference xml::xpath::XXPathAPI m_xXPathAPI;
@@ -331,12 +327,10 @@ private:
UpdateInformationProvider::UpdateInformationProvider(
const uno::Referenceuno::XComponentContext xContext,
-const uno::Reference ucb::XContentIdentifierFactory xContentIdFactory,
-const uno::Reference ucb::XContentProvider xContentProvider,
const uno::Reference xml::dom::XDocumentBuilder xDocumentBuilder,
const uno::Reference xml::xpath::XXPathAPI xXPathAPI
-) : m_xContext(xContext), m_xContentIdFactory(xContentIdFactory),
-m_xContentProvider(xContentProvider), m_xDocumentBuilder(xDocumentBuilder),
+) : m_xContext(xContext),
+m_xDocumentBuilder(xDocumentBuilder),
m_xXPathAPI(xXPathAPI), m_aRequestHeaderList(1)
{
uno::Reference lang::XMultiServiceFactory xConfigurationProvider(
@@ -410,12 +404,6 @@ UpdateInformationProvider::createInstance(const
uno::Referenceuno::XComponentCo
UNISTRING( unable to obtain service manager from component
context ),
uno::Reference uno::XInterface ());
-uno::Reference ucb::XContentIdentifierFactory xContentIdFactory(
-xServiceManager-createInstanceWithContext( UNISTRING(
com.sun.star.ucb.UniversalContentBroker ), xContext ),
-uno::UNO_QUERY_THROW);
-
-uno::Reference ucb::XContentProvider
xContentProvider(xContentIdFactory, uno::UNO_QUERY_THROW);
-
uno::Reference xml::dom::XDocumentBuilder xDocumentBuilder(
xServiceManager-createInstanceWithContext( UNISTRING(
com.sun.star.xml.dom.DocumentBuilder ), xContext ),
[Libreoffice-commits] .: 4 commits - chart2/source sax/qa sax/source sc/source sd/source sfx2/source svl/source svtools/source sw/source tools/inc tools/source vcl/source xmloff/source
chart2/source/view/axes/DateHelper.cxx |6 -
sax/qa/cppunit/test_converter.cxx |9 +-
sax/source/tools/converter.cxx | 19 +++-
sc/source/core/tool/interpr2.cxx |2
sd/source/ui/annotations/annotationmanager.cxx |2
sfx2/source/doc/docfile.cxx|2
sfx2/source/doc/oleprops.cxx |2
svl/source/items/dateitem.cxx |2
svtools/source/contnr/templwin.cxx |2
svtools/source/control/calendar.cxx|8 -
sw/source/core/fields/docufld.cxx |2
sw/source/ui/docvw/SidebarWin.cxx |2
tools/inc/tools/date.hxx |6 +
tools/source/datetime/tdate.cxx| 111 +++--
tools/source/inet/inetmsg.cxx |2
vcl/source/control/field2.cxx |2
xmloff/source/core/xmluconv.cxx| 11 ++
17 files changed, 158 insertions(+), 32 deletions(-)
New commits:
commit 7613359985a89a42417a746bcdbb25f072784733
Author: Eike Rathke er...@redhat.com
Date: Wed Nov 30 02:05:25 2011 +0100
handle dates with year 1000
* Read dates with years consisting of less than 4 digits.
ISO 8601 specifies that years are to be written with a minimum of 4
digits.
However, be lenient in what we accept.
* Write years 1000 with leading zeros to comply with ISO 8601 .
diff --git a/sax/qa/cppunit/test_converter.cxx
b/sax/qa/cppunit/test_converter.cxx
index 923c7eb..17d1303 100644
--- a/sax/qa/cppunit/test_converter.cxx
+++ b/sax/qa/cppunit/test_converter.cxx
@@ -215,8 +215,13 @@ void ConverterTest::testDateTime()
doTest( util::DateTime(0, 0, 0, 24, 1, 1, 333)
/*(0, 0, 0, 0, 2, 1, 333)*/,
0333-01-01T24:00:00/*, 0333-01-02T00:00:00*/ );
-doTestDateTimeF( +0001-01-01T00:00:00 ); // invalid: ^+
-doTestDateTimeF( 1-01-01T00:00:00 ); // invalid: 4 Y
+// A leading ^+ is NOT invalid, ISO 8601 specifies this for explicit AD/CE.
+doTest( util::DateTime(0, 0, 0, 0, 1, 1, 1),
++0001-01-01T00:00:00, 0001-01-01T00:00:00 );
+// While ISO 8601 specifies a minimum of 4 year digits we are lenient in
+// what we accept.
+doTest( util::DateTime(0, 0, 0, 0, 1, 1, 1),
+1-01-01T00:00:00, 0001-01-01T00:00:00 );
doTestDateTimeF( 0001-1-01T00:00:00 ); // invalid: 2 M
doTestDateTimeF( 0001-01-1T00:00:00 ); // invalid: 2 D
doTestDateTimeF( 0001-01-01T0:00:00 ); // invalid: 2 H
diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index b1629c8..0c0779b 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -1345,15 +1345,26 @@ bool Converter::convertDateOrDateTime(
const ::rtl::OUString string = rString.trim().toAsciiUpperCase();
sal_Int32 nPos(0);
-if ((string.getLength() nPos) (sal_Unicode('-') == string[nPos]))
+if (string.getLength() nPos)
{
-//Negative Number
-++nPos;
+if (sal_Unicode('-') == string[nPos])
+{
+//Negative Number
+++nPos;
+}
+else if (sal_Unicode('+') == string[nPos])
+{
+//Positive Number, explicit AD/CE
+++nPos;
+}
}
sal_Int32 nYear(0);
{
-bSuccess = readDateTimeComponent(string, nPos, nYear, 4, false);
+// While ISO 8601 specifies years with a minimum of 4 digits, be
+// leninent in what we accept for years 1000. One digit is acceptable
+// if the remainders match.
+bSuccess = readDateTimeComponent(string, nPos, nYear, 1, false);
bSuccess = (0 nYear);
bSuccess = (nPos string.getLength()); // not last token
}
diff --git a/xmloff/source/core/xmluconv.cxx b/xmloff/source/core/xmluconv.cxx
index 5ea85f1..6ceb885 100644
--- a/xmloff/source/core/xmluconv.cxx
+++ b/xmloff/source/core/xmluconv.cxx
@@ -436,9 +436,16 @@ void SvXMLUnitConverter::convertDateTime( OUStringBuffer
rBuffer,
aDate += 1;
}
}
-rBuffer.append( sal_Int32( aDate.GetYear()));
+sal_uInt16 nTemp = aDate.GetYear();
+if (nTemp 1000)
+rBuffer.append( sal_Unicode('0'));
+if (nTemp 100)
+rBuffer.append( sal_Unicode('0'));
+if (nTemp 10)
+rBuffer.append( sal_Unicode('0'));
+rBuffer.append( sal_Int32( nTemp));
rBuffer.append( sal_Unicode('-'));
-sal_uInt16 nTemp = aDate.GetMonth();
+nTemp = aDate.GetMonth();
if (nTemp 10)
rBuffer.append( sal_Unicode('0'));
rBuffer.append( sal_Int32( nTemp));
commit 07a7b2937a9427b2feb3307804ec0f527091bb92
Author: Eike Rathke er...@redhat.com
Date: Wed Nov 30 02:05:24 2011 +0100
fixed fdo#40363 freeze chart wizard with non-gregorian date
Use the newly introduced Date::Normalize() instead of a never ending
while(!date.IsValid())
[Libreoffice-commits] .: binfilter/bf_sc binfilter/bf_sfx2 binfilter/bf_svtools
binfilter/bf_sc/source/core/tool/sc_interpr2.cxx|2 +-
binfilter/bf_sfx2/source/doc/timestamp.cxx |2 +-
binfilter/bf_svtools/source/items1/svt_dateitem.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 1f9150ab1bbb121c59014fba7c7cd229aceeeb66
Author: Eike Rathke er...@redhat.com
Date: Wed Nov 30 02:06:12 2011 +0100
renamed Date::IsValid() to IsValidAndGregorian() to prevent misassumptions
diff --git a/binfilter/bf_sc/source/core/tool/sc_interpr2.cxx
b/binfilter/bf_sc/source/core/tool/sc_interpr2.cxx
index e585be3..edb639f 100644
--- a/binfilter/bf_sc/source/core/tool/sc_interpr2.cxx
+++ b/binfilter/bf_sc/source/core/tool/sc_interpr2.cxx
@@ -75,7 +75,7 @@ namespace binfilter {
/*N*/ }
/*N*/ Date aDate(1, nM, nY);
/*N*/ aDate += nDay - 1;
-/*N*/ if (aDate.IsValid())
+/*N*/ if (aDate.IsValidAndGregorian())
/*N*/ return (double) (aDate - *(pFormatter-GetNullDate()));
/*N*/ else
/*N*/ {
diff --git a/binfilter/bf_sfx2/source/doc/timestamp.cxx
b/binfilter/bf_sfx2/source/doc/timestamp.cxx
index 6c42d1e..233ec59 100644
--- a/binfilter/bf_sfx2/source/doc/timestamp.cxx
+++ b/binfilter/bf_sfx2/source/doc/timestamp.cxx
@@ -186,7 +186,7 @@ BOOL TimeStamp::IsValid () const
// The name can have a defaultvalue!
// And its better to safe this result in a local variable ... for better
debug! (to see value)
BOOL bResult = ( m_aModifiedDateTime != TIMESTAMP_INVALID_DATETIME ) ;
-return bResult m_aModifiedDateTime.IsValid();
+return bResult m_aModifiedDateTime.IsValidAndGregorian();
}
diff --git a/binfilter/bf_svtools/source/items1/svt_dateitem.cxx
b/binfilter/bf_svtools/source/items1/svt_dateitem.cxx
index 61f74b7..38abd6b 100644
--- a/binfilter/bf_svtools/source/items1/svt_dateitem.cxx
+++ b/binfilter/bf_svtools/source/items1/svt_dateitem.cxx
@@ -137,7 +137,7 @@ SfxItemPresentation SfxDateTimeItem::GetPresentation
) const
{
DBG_CHKTHIS(SfxDateTimeItem, 0);
-if (aDateTime.IsValid())
+if (aDateTime.IsValidAndGregorian())
if (pIntlWrapper)
{
rText = pIntlWrapper-getLocaleData()-getDate(aDateTime);
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: tools/inc
tools/inc/tools/date.hxx | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
New commits:
commit 2b2f6abfcc83c4701b42c92c6209a1052324f0a5
Author: Eike Rathke er...@redhat.com
Date: Wed Nov 30 02:46:55 2011 +0100
introduced Date::IsValidDate() and Date::Normalize()
+ IsValidDate() checks only day and month regarding the year, not Gregorian
cut-off date as now does IsValidAndGregorian().
+ Normalize() carries over invalid day and month values to next months and
years.
* All methods that return or internally use a day count now internally
normalize the date values, without modifying the actual Date instance. So,
if the date is not valid you may get unexpected results.
* Previously, a date with month12 would had accessed the days-of-month
array out of bounds on all such methods. So you would had gotten
unexpected results anyway..
* Affected methods are:
GetDayOfYear()
GetWeekOfYear()
GetDaysInMonth()
static DateToDays()
diff --git a/tools/inc/tools/date.hxx b/tools/inc/tools/date.hxx
index a9d0e0d..e0cb2a2 100644
--- a/tools/inc/tools/date.hxx
+++ b/tools/inc/tools/date.hxx
@@ -70,22 +70,48 @@ public:
sal_uInt16 GetMonth() const { return (sal_uInt16)((nDate / 100) %
100); }
sal_uInt16 GetYear() const { return (sal_uInt16)(nDate / 1); }
+/// Internally normalizes a copy of values.
DayOfWeek GetDayOfWeek() const;
+
+/// Internally normalizes a copy of values.
sal_uInt16 GetDayOfYear() const;
+
/** nMinimumNumberOfDaysInWeek: how many days of a week must reside in the
-first week of a year. */
+first week of a year.
+Internally normalizes a copy of values. */
sal_uInt16 GetWeekOfYear( DayOfWeek eStartDay = MONDAY,
sal_Int16 nMinimumNumberOfDaysInWeek = 4 )
const;
+/// Internally normalizes a copy of values.
sal_uInt16 GetDaysInMonth() const;
+
sal_uInt16 GetDaysInYear() const { return (IsLeapYear()) ? 366 :
365; }
sal_BoolIsLeapYear() const;
+
/** If the represented date is valid (1=month=12, 1=day=(28,29,30,31)
depending on month/year) AND is of the Gregorian calendar (1582-10-15
= date) (AND implicitly date = -12-31 due to internal
representation) */
sal_BoolIsValidAndGregorian() const;
+/** If the represented date is valid (1=month=12, 1=day=(28,29,30,31)
+depending on month/year) */
+boolIsValidDate() const;
+
+/** Normalize date, invalid day or month values are adapted such that they
+carry over to the next month or/and year, for example 1999-02-32
+becomes 1999-03-04, 1999-13-01 becomes 2000-01-01, 1999-13-42 becomes
+2000-02-11. Truncates at -12-31, -00-x will yield the
+normalized value of -01-max(1,(x-31))
+
+This may be necessary after Date ctors or if the SetDate(), SetDay(),
+SetMonth(), SetYear() methods set individual non-matching values.
+Adding/subtracting to/from dates never produces invalid dates.
+
+@returns TRUE if the date was normalized, i.e. not valid before.
+ */
+boolNormalize();
+
sal_BoolIsBetween( const Date rFrom, const Date rTo ) const
{ return ((nDate = rFrom.nDate)
(nDate = rTo.nDate)); }
@@ -118,7 +144,12 @@ public:
TOOLS_DLLPUBLIC friend Date operator -( const Date rDate, long nDays
);
TOOLS_DLLPUBLIC friend long operator -( const Date rDate1, const
Date rDate2 );
+/// Internally normalizes values.
static long DateToDays( sal_uInt16 nDay, sal_uInt16 nMonth, sal_uInt16
nYear );
+/// Semantically identical to IsValidDate() member method.
+static bool IsValidDate( sal_uInt16 nDay, sal_uInt16 nMonth, sal_uInt16
nYear );
+/// Semantically identical to Normalize() member method.
+static bool Normalize( sal_uInt16 rDay, sal_uInt16 rMonth, sal_uInt16
rYear );
};
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: binaryurp/qa binaryurp/source bridges/inc bridges/source canvas/source canvas/workben
binaryurp/qa/test-unmarshal.cxx|2 +-
binaryurp/source/bridge.cxx| 10 +-
binaryurp/source/incomingrequest.cxx | 12 ++--
binaryurp/source/proxy.cxx |4 ++--
binaryurp/source/reader.cxx|4 ++--
binaryurp/source/writer.cxx|6 +++---
bridges/inc/bridges/cpp_uno/bridge.hxx |4 ++--
bridges/source/cpp_uno/cc5_solaris_sparc64/uno2cpp.cxx |2 +-
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx |4 ++--
bridges/source/cpp_uno/shared/component.cxx|4 ++--
bridges/source/jni_uno/jni_bridge.cxx | 12 ++--
bridges/source/jni_uno/jni_java2uno.cxx|4 ++--
bridges/source/jni_uno/nativethreadpool.cxx|4 ++--
canvas/source/directx/dx_config.cxx|4 ++--
canvas/source/factory/cf_service.cxx |8
canvas/source/tools/canvastools.cxx|2 +-
canvas/workben/canvasdemo.cxx |2 +-
17 files changed, 44 insertions(+), 44 deletions(-)
New commits:
commit 7113c7152d1ec875e65e97548fa6243fc83fbc53
Author: Takeshi Abe t...@fixedpoint.jp
Date: Wed Nov 30 11:05:16 2011 +0900
catch by constant reference
diff --git a/binaryurp/qa/test-unmarshal.cxx b/binaryurp/qa/test-unmarshal.cxx
index 3e8aac3..aa6c5a9 100644
--- a/binaryurp/qa/test-unmarshal.cxx
+++ b/binaryurp/qa/test-unmarshal.cxx
@@ -108,7 +108,7 @@ void Test::testTypeOfVoidSequence() {
try {
m.readType();
CPPUNIT_FAIL(exception expected);
-} catch (css::io::IOException ) {}
+} catch (const css::io::IOException ) {}
}
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
diff --git a/binaryurp/source/bridge.cxx b/binaryurp/source/bridge.cxx
index 6e97406..b491a2a 100644
--- a/binaryurp/source/bridge.cxx
+++ b/binaryurp/source/bridge.cxx
@@ -259,7 +259,7 @@ void Bridge::terminate() {
}
try {
connection_-close();
-} catch (css::io::IOException e) {
+} catch (const css::io::IOException e) {
SAL_INFO(binaryurp, caught IO exception ' e.Message '\'');
}
assert(w.is());
@@ -289,7 +289,7 @@ void Bridge::terminate() {
(*i)-disposing(
css::lang::EventObject(
static_cast cppu::OWeakObject * (this)));
-} catch (css::uno::RuntimeException e) {
+} catch (const css::uno::RuntimeException e) {
SAL_WARN(
binaryurp, caught runtime exception ' e.Message
'\'');
}
@@ -505,10 +505,10 @@ void Bridge::revokeProxy(Proxy proxy) {
void Bridge::freeProxy(Proxy proxy) {
try {
makeReleaseCall(proxy.getOid(), proxy.getType());
-} catch (css::uno::RuntimeException e) {
+} catch (const css::uno::RuntimeException e) {
SAL_INFO(
binaryurp, caught runtime exception ' e.Message '\'');
-} catch (std::exception e) {
+} catch (const std::exception e) {
SAL_WARN(binaryurp, caught C++ exception ' e.what() '\'');
}
bool unused;
@@ -660,7 +660,7 @@ void Bridge::handleCommitChangeReply(
bool ccMode = true;
try {
throwException(exception, returnValue);
-} catch (css::bridge::InvalidProtocolChangeException ) {
+} catch (const css::bridge::InvalidProtocolChangeException ) {
ccMode = false;
}
if (ccMode) {
diff --git a/binaryurp/source/incomingrequest.cxx
b/binaryurp/source/incomingrequest.cxx
index f869c95..431c885 100644
--- a/binaryurp/source/incomingrequest.cxx
+++ b/binaryurp/source/incomingrequest.cxx
@@ -87,7 +87,7 @@ void IncomingRequest::execute() const {
try {
try {
isExc = !execute_throw(ret, outArgs);
-} catch (std::exception e) {
+} catch (const std::exception e) {
throw css::uno::RuntimeException(
(rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(caught C++ exception: ))
+
@@ -96,7 +96,7 @@ void IncomingRequest::execute() const {
css::uno::Reference css::uno::XInterface ());
// best-effort string conversion
}
-} catch (css::uno::RuntimeException ) {
+} catch (const css::uno::RuntimeException ) {
css::uno::Any exc(cppu::getCaughtException());
ret = bridge_-mapCppToBinaryAny(exc);
isExc = true;
@@ -104,7 +104,7 @@ void IncomingRequest::execute() const {
if (resetCc) {
current_context::set(oldCc);
}
-} catch (css::uno::RuntimeException ) {
+} catch (const css::uno::RuntimeException ) {
css::uno::Any exc(cppu::getCaughtException());
ret = bridge_-mapCppToBinaryAny(exc);
isExc = true;
@@ -115,12 +115,12 @@ void
[Libreoffice-commits] .: sc/source
sc/source/core/data/dociter.cxx|4 +++-
sc/source/core/tool/queryentry.cxx | 16
sc/source/ui/unoobj/cellsuno.cxx |4 +++-
sc/source/ui/unoobj/datauno.cxx| 17 -
4 files changed, 26 insertions(+), 15 deletions(-)
New commits:
commit e4b924df8f9ad02c66549751cb8e123e420e8508
Author: Kohei Yoshida kohei.yosh...@suse.com
Date: Wed Nov 30 01:20:45 2011 -0500
Reduce usage of GetQueryItem() (singular version).
I added that as a convenience method while working on implementing
multi-value filtering. But we need to stick with the plural version
GetQueryItems() from now on for clarity.
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index be05630..0b466c0 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -533,7 +533,9 @@
ScDBQueryDataIterator::DataAccessInternal::DataAccessInternal(const ScDBQueryDat
for (i=0; (inCount) (mpParam-GetEntry(i).bDoQuery); i++)
{
ScQueryEntry rEntry = mpParam-GetEntry(i);
-ScQueryEntry::Item rItem = rEntry.GetQueryItem();
+ScQueryEntry::QueryItemsType rItems = rEntry.GetQueryItems();
+rItems.resize(1);
+ScQueryEntry::Item rItem = rItems.front();
sal_uInt32 nIndex = 0;
bool bNumber = mpDoc-GetFormatTable()-IsNumberFormat(
rItem.maString, nIndex, rItem.mfVal);
diff --git a/sc/source/core/tool/queryentry.cxx
b/sc/source/core/tool/queryentry.cxx
index be107e7..1f9be97 100644
--- a/sc/source/core/tool/queryentry.cxx
+++ b/sc/source/core/tool/queryentry.cxx
@@ -101,7 +101,8 @@ const ScQueryEntry::QueryItemsType
ScQueryEntry::GetQueryItems() const
void ScQueryEntry::SetQueryByEmpty()
{
eOp = SC_EQUAL;
-Item rItem = GetQueryItem();
+maQueryItems.resize(1);
+Item rItem = maQueryItems[0];
rItem.meType = ByEmpty;
rItem.maString = rtl::OUString();
rItem.mfVal = SC_EMPTYFIELDS;
@@ -109,11 +110,10 @@ void ScQueryEntry::SetQueryByEmpty()
bool ScQueryEntry::IsQueryByEmpty() const
{
-if (maQueryItems.size() 1)
-// multi-item query.
+if (maQueryItems.size() != 1)
return false;
-const Item rItem = GetQueryItem();
+const Item rItem = maQueryItems[0];
return eOp == SC_EQUAL
rItem.meType == ByEmpty
rItem.maString.isEmpty()
@@ -123,7 +123,8 @@ bool ScQueryEntry::IsQueryByEmpty() const
void ScQueryEntry::SetQueryByNonEmpty()
{
eOp = SC_EQUAL;
-Item rItem = GetQueryItem();
+maQueryItems.resize(1);
+Item rItem = maQueryItems[0];
rItem.meType = ByEmpty;
rItem.maString = rtl::OUString();
rItem.mfVal = SC_NONEMPTYFIELDS;
@@ -131,11 +132,10 @@ void ScQueryEntry::SetQueryByNonEmpty()
bool ScQueryEntry::IsQueryByNonEmpty() const
{
-if (maQueryItems.size() 1)
-// multi-item query.
+if (maQueryItems.size() != 1)
return false;
-const Item rItem = GetQueryItem();
+const Item rItem = maQueryItems[0];
return eOp == SC_EQUAL
rItem.meType == ByEmpty
rItem.maString.isEmpty()
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index e26ae90..6be0239 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -5683,7 +5683,9 @@ void SAL_CALL ScCellRangeObj::filter( const
uno::Referencesheet::XSheetFilterDe
{
rEntry.nField += nFieldStart;
// Im Dialog wird immer der String angezeigt - muss zum Wert
passen
-ScQueryEntry::Item rItem = rEntry.GetQueryItem();
+ScQueryEntry::QueryItemsType rItems = rEntry.GetQueryItems();
+rItems.resize(1);
+ScQueryEntry::Item rItem = rItems.front();
if (rItem.meType != ScQueryEntry::ByString)
{
pDocSh-GetDocument()-GetFormatTable()-
diff --git a/sc/source/ui/unoobj/datauno.cxx b/sc/source/ui/unoobj/datauno.cxx
index 960ac08..3695f14 100644
--- a/sc/source/ui/unoobj/datauno.cxx
+++ b/sc/source/ui/unoobj/datauno.cxx
@@ -1105,7 +1105,10 @@ uno::Sequencesheet::TableFilterField SAL_CALL
ScFilterDescriptorBase::getFilte
for (SCSIZE i=0; inCount; i++)
{
const ScQueryEntry rEntry = aParam.GetEntry(i);
-const ScQueryEntry::Item rItem = rEntry.GetQueryItem();
+if (rEntry.GetQueryItems().empty())
+continue;
+
+const ScQueryEntry::Item rItem = rEntry.GetQueryItems().front();
aField.Connection= (rEntry.eConnect == SC_AND) ?
sheet::FilterConnection_AND :
sheet::FilterConnection_OR;
@@ -1233,7 +1236,9 @@ void fillQueryParam(
if (pAry[i].Operator != sheet::FilterOperator2::EMPTY
pAry[i].Operator != sheet::FilterOperator2::NOT_EMPTY)
{
-ScQueryEntry::Item rItem = rEntry.GetQueryItem();
+
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/bastypes.cxx |4 ++--
basctl/source/inc/sbxitem.hxx | 24 +++-
2 files changed, 13 insertions(+), 15 deletions(-)
New commits:
commit e007d3f3b93235be8dfd328db6cf38475acb49a7
Author: August Sodora aug...@gmail.com
Date: Wed Nov 30 01:41:45 2011 -0500
String-OUString
diff --git a/basctl/source/basicide/bastypes.cxx
b/basctl/source/basicide/bastypes.cxx
index 91d2576..4dcc710 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -886,7 +886,7 @@ LibInfoItem* LibInfos::GetInfo( const LibInfoKey rKey )
return pItem;
}
-SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument rDocument, const
String aLibName, const String aName, sal_uInt16 nType )
+SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument rDocument, const
::rtl::OUString aLibName, const ::rtl::OUString aName, sal_uInt16 nType )
:SfxPoolItem( nWhich_ )
,m_aDocument(rDocument)
,m_aLibName(aLibName)
@@ -895,7 +895,7 @@ SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument
rDocument, const Stri
{
}
-SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument rDocument, const
String aLibName, const String aName, const String aMethodName, sal_uInt16
nType )
+SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument rDocument, const
::rtl::OUString aLibName, const ::rtl::OUString aName, const ::rtl::OUString
aMethodName, sal_uInt16 nType )
:SfxPoolItem( nWhich_ )
,m_aDocument(rDocument)
,m_aLibName(aLibName)
diff --git a/basctl/source/inc/sbxitem.hxx b/basctl/source/inc/sbxitem.hxx
index d1efe51..94a8b51 100644
--- a/basctl/source/inc/sbxitem.hxx
+++ b/basctl/source/inc/sbxitem.hxx
@@ -38,19 +38,18 @@ const sal_uInt16 BASICIDE_TYPE_MODULE = 3;
const sal_uInt16 BASICIDE_TYPE_DIALOG = 4;
const sal_uInt16 BASICIDE_TYPE_METHOD = 5;
-
class SbxItem : public SfxPoolItem
{
ScriptDocument m_aDocument;
-String m_aLibName;
-String m_aName;
-String m_aMethodName;
+::rtl::OUString m_aLibName;
+::rtl::OUString m_aName;
+::rtl::OUString m_aMethodName;
sal_uInt16 m_nType;
public:
TYPEINFO();
-SbxItem( sal_uInt16 nWhich, const ScriptDocument rDocument, const String
aLibName, const String aName, sal_uInt16 nType );
-SbxItem( sal_uInt16 nWhich, const ScriptDocument rDocument, const String
aLibName, const String aName, const String aMethodName, sal_uInt16 nType );
+SbxItem( sal_uInt16 nWhich, const ScriptDocument rDocument, const
::rtl::OUString aLibName, const ::rtl::OUString aName, sal_uInt16 nType );
+SbxItem( sal_uInt16 nWhich, const ScriptDocument rDocument, const
::rtl::OUString aLibName, const ::rtl::OUString aName, const ::rtl::OUString
aMethodName, sal_uInt16 nType );
SbxItem( const SbxItem );
virtual SfxPoolItem*Clone( SfxItemPool *pPool = 0 ) const;
@@ -60,20 +59,19 @@ public:
GetDocument() const { return m_aDocument; }
voidSetDocument( const ScriptDocument rDocument ) {
m_aDocument = rDocument; }
-const String GetLibName() const { return m_aLibName; }
-voidSetLibName( const String aLibName ) { m_aLibName
= aLibName; }
+const ::rtl::OUString GetLibName() const { return m_aLibName; }
+voidSetLibName( const ::rtl::OUString aLibName ) {
m_aLibName = aLibName; }
-const String GetName() const { return m_aName; }
-voidSetName( const String aName ) { m_aName = aName; }
+const ::rtl::OUString GetName() const { return m_aName; }
+voidSetName( const ::rtl::OUString aName ) { m_aName
= aName; }
-const String GetMethodName() const { return m_aMethodName; }
-voidSetMethodName( const String aMethodName ) {
m_aMethodName = aMethodName; }
+const ::rtl::OUString GetMethodName() const { return m_aMethodName; }
+voidSetMethodName( const ::rtl::OUString aMethodName
) { m_aMethodName = aMethodName; }
sal_uInt16 GetType() const { return m_nType; }
voidSetType( sal_uInt16 nType ) { m_nType = nType; }
};
-
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e57e5b0c7f1a5ec6cd008226f126438d65cbd8d0 Author: Kalman Szalai - KAMI kami...@gmail.com Date: Wed Nov 30 06:58:15 2011 +0100 Use SmART Gallery 0.95 diff --git a/configure.in b/configure.in index b9b3577..4c11c91 100644 --- a/configure.in +++ b/configure.in @@ -8118,7 +8118,7 @@ AC_MSG_CHECKING([for SmART Gallery (Diagram) extension integration]) DIAGRAM_EXTENSION_PACK= if test x$enable_ext_diagram = xyes -a x$enable_extension_integration != xno; then SCPDEFS=$SCPDEFS -DWITH_EXTENSION_DIAGRAM -DIAGRAM_EXTENSION_PACK=4a433efb6d385264ebc1d5513782d51c-SmART_0.9.4.oxt +DIAGRAM_EXTENSION_PACK=8d74685d41f8bffe8c3e71fe8deac09d-SmART_0.9.5.oxt AC_MSG_RESULT([yes]) else AC_MSG_RESULT([no]) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/basides1.cxx | 20 ++--
basctl/source/basicide/basidesh.cxx |6 +++---
basctl/source/basicide/basobj2.cxx |2 +-
basctl/source/basicide/basobj3.cxx |2 +-
basctl/source/basicide/bastype2.hxx |2 +-
basctl/source/basicide/bastype3.cxx | 14 +++---
basctl/source/basicide/bastypes.cxx |4 ++--
basctl/source/basicide/moduldl2.cxx |2 +-
basctl/source/basicide/moduldlg.cxx |4 ++--
basctl/source/inc/basidesh.hxx |2 +-
basctl/source/inc/sbxitem.hxx | 25 ++---
11 files changed, 43 insertions(+), 40 deletions(-)
New commits:
commit 1eb974c1429967ce76db4b16192a9a95b3e8cc6f
Author: August Sodora aug...@gmail.com
Date: Wed Nov 30 02:11:15 2011 -0500
Convert group of consts to enum
diff --git a/basctl/source/basicide/basides1.cxx
b/basctl/source/basicide/basides1.cxx
index 8d184e2..2aff96e 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -615,9 +615,9 @@ void BasicIDEShell::ExecuteGlobal( SfxRequest rReq )
String aName( rSbxItem.GetName() );
if ( !m_aCurLibName.Len() || ( aDocument == m_aCurDocument
aLibName == m_aCurLibName ) )
{
-if ( rSbxItem.GetType() == BASICIDE_TYPE_MODULE )
+if ( rSbxItem.GetType() == BasicIDEType::Module )
FindBasWin( aDocument, aLibName, aName, sal_True );
-else if ( rSbxItem.GetType() == BASICIDE_TYPE_DIALOG )
+else if ( rSbxItem.GetType() == BasicIDEType::Dialog )
FindDlgWin( aDocument, aLibName, aName, sal_True );
}
}
@@ -641,15 +641,15 @@ void BasicIDEShell::ExecuteGlobal( SfxRequest rReq )
String aName( rSbxItem.GetName() );
SetCurLib( aDocument, aLibName );
IDEBaseWindow* pWin = 0;
-if ( rSbxItem.GetType() == BASICIDE_TYPE_DIALOG )
+if ( rSbxItem.GetType() == BasicIDEType::Dialog )
{
pWin = FindDlgWin( aDocument, aLibName, aName, sal_True );
}
-else if ( rSbxItem.GetType() == BASICIDE_TYPE_MODULE )
+else if ( rSbxItem.GetType() == BasicIDEType::Module )
{
pWin = FindBasWin( aDocument, aLibName, aName, sal_True );
}
-else if ( rSbxItem.GetType() == BASICIDE_TYPE_METHOD )
+else if ( rSbxItem.GetType() == BasicIDEType::Method )
{
pWin = FindBasWin( aDocument, aLibName, aName, sal_True );
((ModulWindow*)pWin)-EditMacro( rSbxItem.GetMethodName() );
@@ -1137,7 +1137,7 @@ void BasicIDEShell::SetCurWindow( IDEBaseWindow* pNewWin,
sal_Bool bUpdateTabBar
BasicIDEData* pData = BasicIDEGlobals::GetExtraData();
if ( pData )
{
-sal_uInt16 nCurrentType = pCurWin-IsA( TYPE( ModulWindow
) ) ? BASICIDE_TYPE_MODULE : BASICIDE_TYPE_DIALOG;
+sal_uInt16 nCurrentType = pCurWin-IsA( TYPE( ModulWindow
) ) ? BasicIDEType::Module : BasicIDEType::Dialog;
LibInfoItem* pLibInfoItem = new LibInfoItem(
pCurWin-GetDocument(), pCurWin-GetLibName(), pCurWin-GetName(), nCurrentType
);
pData-GetLibInfos().InsertInfo( pLibInfoItem );
}
@@ -1240,21 +1240,21 @@ IDEBaseWindow* BasicIDEShell::FindApplicationWindow()
return FindWindow( ScriptDocument::getApplicationScriptDocument() );
}
-IDEBaseWindow* BasicIDEShell::FindWindow( const ScriptDocument rDocument,
const String rLibName, const String rName, sal_uInt16 nType, sal_Bool
bFindSuspended )
+IDEBaseWindow* BasicIDEShell::FindWindow( const ScriptDocument rDocument,
const String rLibName, const String rName, BasicIDEType nType, sal_Bool
bFindSuspended )
{
IDEBaseWindow* pWin = aIDEWindowTable.First();
while ( pWin )
{
if ( !pWin-IsSuspended() || bFindSuspended )
{
-if ( !rLibName.Len() || !rName.Len() || nType ==
BASICIDE_TYPE_UNKNOWN )
+if ( !rLibName.Len() || !rName.Len() || nType ==
BasicIDEType::Unknown )
{
// return any non-suspended window
return pWin;
}
else if ( pWin-IsDocument( rDocument ) pWin-GetLibName() ==
rLibName pWin-GetName() == rName
- ( ( pWin-IsA( TYPE( ModulWindow ) ) nType ==
BASICIDE_TYPE_MODULE ) ||
-( pWin-IsA( TYPE( DialogWindow ) ) nType ==
BASICIDE_TYPE_DIALOG ) ) )
+ ( ( pWin-IsA( TYPE( ModulWindow ) ) nType ==
BasicIDEType::Module ) ||
+( pWin-IsA( TYPE( DialogWindow ) ) nType ==
BasicIDEType::Dialog ) ) )
{
return pWin;
}
diff --git a/basctl/source/basicide/basidesh.cxx
b/basctl/source/basicide/basidesh.cxx
index
Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area
Hi Eike
Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to
not include newly appended columns of an area.
half true: the condition is exactly that the newly appended column data
touch by an angle the already defined area (like C3 to B2) and that all
other cells below the area are empty.
All columns right/left of the area are filtered.
Why?
very bad reason: I did not really intended to commit this change yet. I
wanted to ask you about it. But it seems I was too deeply thinking about
it, I oversee my mixing. F**
less bad reason: If you activates the auto-filter, and append a column
as mentioned above, you suddenly have columns filtered without seeing
it, the drop-down at the top of the column not being present.
I will change it (due to point 1), except you oppose :- )
Grounded speculation: if user adds a column or row immediately adjacent
to a data area it is usually related to the already existing data and
she wants that to be included, maybe even doesn't know that earlier the
filter was setup using a selection.
A good point. On the other hand,this makes impossible to filter in the
middle of data. But this case is very special.
Else, I have attached 3 patches for review touching this function:
* the first one make the flag onlyDown working also for shrinking... No
reason that you can just extend down, but shrink on all direction? This
seems to be more coherent with the flag activation.
* the second patch make the shrinking corresponding to the name of the
function: GetDataArea: i.e. shrinks as long as the outer row/column is
empty, and not just delete the last one since empty.
* the 3d one: just minor clean up: variable scope reduction and better
documentation.
Thanks for all
best regards
Pierre-André
From cfd04dda7e441ffa3dcc5a21b6b8f87cbfda05b0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch
Date: Tue, 29 Nov 2011 09:10:26 +0100
Subject: [PATCH 3/3] reduce scope of var and better comment of function GetDataArea
---
sc/source/core/data/table1.cxx | 40 +---
1 files changed, 21 insertions(+), 19 deletions(-)
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index ce2051b..5de641f 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -741,17 +741,19 @@ bool ScTable::GetDataStart( SCCOL rStartCol, SCROW rStartRow ) const
void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, SCROW rEndRow,
bool bIncludeOld, bool bOnlyDown ) const
{
-// bIncludeOld = true ensure that the returned area contains at least the initial area,
-// independently of the case if this area has empty rows / columns at its borders
-// bOnlyDown = true means extend the inputed area only down, i.e increase only rEndRow
+// return the smallest area containing at least all contiguous cells having data. This area
+// is a square containing also empty cells. It may shrink or extend the area given as input
+// Flags as modifiers:
+//
+// bIncludeOld = true ensure that the returned area contains at least the initial area,
+// independently of the emptniess of rows / columns (i.e. does not allow shrinking)
+// bOnlyDown = true means extend / shrink the inputed area only down, i.e modifiy only rEndRow
+
bool bLeft = false;
bool bRight = false;
bool bTop = false;
bool bBottom = false;
-bool bChanged;
-bool bFound;
-SCCOL i;
-SCROW nTest;
+bool bChanged = false;
do
{
@@ -782,12 +784,12 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S
if (rStartRow 0)
{
-nTest = rStartRow-1;
-bFound = false;
-for (i=rStartCol; i=rEndCol !bFound; i++)
+SCROW nTest = rStartRow-1;
+bool needExtend = false;
+for ( SCCOL i = rStartCol; i=rEndCol !needExtend; i++)
if (aCol[i].HasDataAt(nTest))
-bFound = true;
-if (bFound)
+needExtend = true;
+if (needExtend)
{
--rStartRow;
bChanged = true;
@@ -798,12 +800,12 @@ void ScTable::GetDataArea( SCCOL rStartCol, SCROW rStartRow, SCCOL rEndCol, S
if (rEndRow MAXROW)
{
-nTest = rEndRow+1;
-bFound = false;
-for (i=rStartCol; i=rEndCol !bFound; i++)
+SCROW nTest = rEndRow+1;
+bool needExtend = false;
+for ( SCCOL i = rStartCol; i=rEndCol !needExtend; i++)
if (aCol[i].HasDataAt(nTest))
-bFound = true;
-if (bFound)
+needExtend = true;
+if (needExtend)
{
Re: [Libreoffice] [Libreoffice-qa] New Windows tinderbox: Windows 2008R2
Instead of setup.exe /a one should call msiexec.exe /a libreoffice_msi_file where the libreoffice_msi_file is libodev35.msi for the LibreOffice_Dev developer target and libreoffice35.msi for the LibreOffice release target. Cheers Fridrich On 29/11/11 08:19, Rainer Bielefeld wrote: Michael Meeks schrieb: I believe we switched our packaging format from NSIS .exe's to the new .msi installs that you see now. Hi, the problem simply might be missing manual. We have a how to on https://wiki.documentfoundation.org/Installing_in_parallel#Windows for doing a server installation with setup.exe, and as soon as we have a description how to get the same result with the .msi the problem has been solved. Kind regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] EuroOffice Barcode
Dear Jan, thanks for your reply. I'm going to discuss the possibilities with my colleagues on our meeting this afternoon. Thanks again. Have a nice day, Tibor 2011.11.28. 16:55 keltezéssel, Jan Holesovsky írta: Hi Tibor, On 2011-11-23 at 10:29 +0100, Brenner Tibor wrote: I'm Tibor Brenner from MultiRcio Ltd. We are the developer team of EuroOffice software package and extensions. I've written to András Tímár from your team about a request with our Barcode extension, and he suggested to use your mailing list. Terribly sorry for the late answer :-( I'm the one who initially did the wikihelp, please feel free to explicitly CC: me on anything regarding the http://help.libreoffice.org functionality. Since LibreOffice has an online help system, when somebody installs our Barcode extension, he won't have its help page. So, we would like to ask your help to built in our help files into your online help system. I can upload our extension to your extensions webpage, as it's an absolutely free one for everyone. In this case you will have all help files, or I can send you the whole extension, if it's a better way. This is a very good point; so far there is no explicit functionality to handle extensions when the online help is used. Maybe it might be as easy as handling the extensions explicitly, ie. to use their (bundled) help when the extension help is requested. How does the page URL look like when the barcode extension help is issued, please? Maybe tweaking the impl_hasHelpInstalled() from sfx2/source/appl/sfxhelp.cxx:659 could do the trick? Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for dialog Manage Breakpoints crash
In worst case it makes the program crash. This fix, stores
the values. I'm not that experienced with C++ so could someone have
a second look at this there might very well be a cleaner way of
writing it.
Good find!
I think I would do it slightly different, the patch fixes the symptom
correctly by allocating new objects, but the underlying cause to me
seems that the original intention was to transfer the pointers (hence
the method's name) but that somehow got mangled with the transition from
old List to ::std::vector
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -288,7 +288,7 @@ void BreakPointList::transfer(BreakPointList rList)
{
reset();
for (size_t i = 0; i rList.size(); ++i)
-maBreakPoints.push_back( rList.at( i ) );
+maBreakPoints.push_back( new BreakPoint(*rList.at( i )) );
rList.reset();
}
Instead of creating copies I'd do
- rList.reset();
+ rList.clear();
Please check if that fixes the problem.
Eike
That fixes the problem, and definitely looks like a cleaner solution. Do
you create the patch or should I create a new one?
I created and attached a patch for the pass count.
Description:
Example: When entering pass count 2 it is expected that the breakpoint
is passed two times before breaking not to break the second time.
Thanks
Niklas Johansson
From 5a7b0a951cd85f09d3de06e740e521f435d59b4d Mon Sep 17 00:00:00 2001
From: Niklas Johansson sleeping.pil...@gmail.com
Date: Tue, 29 Nov 2011 09:32:14 +0100
Subject: [PATCH] Fixes pass count in Manage Breakpoints
When entering pass count 2 it is expected that the breakpoint is
passed two times before breaking not to break the second time.
---
basctl/source/basicide/baside2.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/basctl/source/basicide/baside2.cxx
b/basctl/source/basicide/baside2.cxx
index fb6ed3a..b826300 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -724,7 +724,7 @@ long ModulWindow::BasicBreakHdl( StarBASIC* pBasic )
if ( pBrk )
{
pBrk-nHitCount++;
-if ( pBrk-nHitCount pBrk-nStopAfter GetBasic()-IsBreak() )
+if ( pBrk-nHitCount = pBrk-nStopAfter GetBasic()-IsBreak() )
return aStatus.nBasicFlags; // go on...
}
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
Hi Lior, On Tue, 2011-11-29 at 02:18 +0200, Lior Kaplan wrote: I've tried 3.5.0-dev and found out a new minor problem, but still an annoying one (so that's a good example for the above) - the arrows for the sub menus always point right, even when the sub menu is on the left. See screen shot attached. Further issues will be reported as usual. :-) Thanks for that. I suspect Matteo would be interested in the report. it most likely relates to his nice symbols cleanup. Regards, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libreoffice sdk 3.4 and SWT Linux issue
Hi Othman, On Mon, 2011-11-28 at 14:35 -0800, othman wrote: Sorry for being late to reply to this thread. but this is an important bug that needs to be fixed. Sure; plenty of time - a release per month etc. ;-) I'm not sure how to attach the soffice.bin process with gdb? in fact i run my OO addon from netbeans IDE. is there a way i can have netbeans OO plugin to output debug info in output console of netbeans. Sure - so when you have an soffice.bin up and running (I assume you have); then do: gdb `pidof soffice.bin` continue and when it fails: thread apply all backtrace and file the output in a bug, and/or do some poking at the code. Of course it -really- helps if you have the latest debuginfo package installed for libreoffice -and- ensure that you have latest libreoffice package that matches that debuginfo too. I really need help fixing this frustrating bug! it took me now a month and yet couldn't figure out what's the problem. If it is a crash, it should be easyish to find. Of course, if you had a small piece of sample code that reproduced it that'd be most ideal - so we can add this to our regression tests. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libreoffice sdk 3.4 and SWT Linux issue
Thank you for your help. i'll try using the soffice debuger.. If it is a crash, it should be easyish to find. Of course, if you had a small piece of sample code that reproduced it that'd be most ideal - so we can add this to our regression tests. I have provided more info about this bug at this thread : http://user.services.openoffice.org/en/forum/viewtopic.php?f=20t=45679 in this thread you will find link to download an oxt extension that demonstrate this SWT /OO/Linux issue. you can run itt on a linux box to test this freezing problem when you close the SWT window. I hope you could help debuging using the oxt i provided in link above :) I also posted the SWT code that i use for SWT Browser if this SWT code could help you spot the problem. I can provide more info if you require. thaks for your support! -- View this message in context: http://nabble.documentfoundation.org/libreoffice-3-4-and-SWT-Linux-issue-tp3407355p3544662.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
Hi all, just a quick reply until I can sit in front of my own pc. As Michael said, I'm (slowly) cleaning up decoview, and I can see two points related to this issue: 1) Wrong direction of arrow: actually, the arrow depicted in Lior's screenshot does not seem to be drawn by decoview's (there's no such a kind of arrow implemented). I currently don't know where this issue should be properly addressed, but I suspect it's an higher-level than decoview itself, which cannot decide what the arrow is needed for and so if it needs to be reversed. 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions are then: should they be mirrored or not, and what does really appear on an RTL environment? I don't know if I have the knowledge to address point 1 (I'm just a beginner in LO codebase, maybe some directions could help), while point 2 could also be something that need to be addressed. related to point 1, I suspect (no proof by now) that some of decoview routine are not called in favor of some themes or platform dependent ones. This could also be considered for example for argumenting on point 2. Hope to provide more details/feedbacks later. Thanks Matteo -- Michael Meeks michael.me...@suse.com wrote: (29/11/2011 10:37) Hi Lior, On Tue, 2011-11-29 at 02:18 +0200, Lior Kaplan wrote: I've tried 3.5.0-dev and found out a new minor problem, but still an annoying one (so that's a good example for the above) - the arrows for the sub menus always point right, even when the sub menu is on the left. See screen shot attached. Further issues will be reported as usual. :-) Thanks for that. I suspect Matteo would be interested in the report. it most likely relates to his nice symbols cleanup. Regards, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list
Hi Olivier, Caolan - after the 'word count' victim dialog, it seems that the extensions dialog has a foul nightmare of manual size calulation all over it ;-) cf. the ~90 lines of: desktop/source/deployment/gui/dp_gui_dialog2.cxx /Resize/ That also happen to do rather a bad job and defeat casual attempts to improve them :-) On Mon, 2011-11-28 at 22:48 -0200, Olivier Hallot wrote: returns 0 instead of 1 - it seems the value is ignored anyway, and 0 might be more ignoreable when read ? :-) Well I did what other event handlers did a couple of lines above and below... They return 1. Do I need to change all of them? Makes sense; fair enough :-) lets just leave them for now OK, back to the math notepad for a better listbox size calculation. Tested with fontsize 13 and 10. Patch attached :-) the TWIPS based positioning should be font-size indeterminate. About the defaults, I set it to be the same as the previous extension manager dialog. Sure - but perhaps the ux-advisors will suggest something better to hide the umpteen built in extensions by default (?) - that might be a reasonable suggestion - I assume your users would prefer that too ? I pushed your 2nd patch (thanks). All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
On Tue, 2011-11-29 at 11:12 +0100, Matteo Casalin wrote: just a quick reply until I can sit in front of my own pc. As Michael said, I'm (slowly) cleaning up decoview, and I can see two points related to this issue: Ah - good point :-) so this looks like a native widget problem instead; as you say, that arrow is anti-aliased rather different from the symbols we draw. I pushed a fix to the gtk+ backend to nail this for you Lior. Thanks ! :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Changes in default artwork - heads-up for 'official' TDF build providers
Hi Thorsten, On Tue, 2011-11-29 at 11:43 +0100, Thorsten Behrens wrote: light on the use of LibreOffice, but puts constraints on the use of the TDF mark, I've just switched our default branding (splash screen, start center background etc.) over to use a version *without the TDF tagline*. Whoot :-) that action item bites the dust finally... Builders providing official tdf builds of course would want the branding *with* the tag line - here's how: - grab http://dev-www.libreoffice.org/src/tdf-branding.tgz (or the version attached, for your convenience) - unpack somewhere - point your release build configure to it - --with-branding=/path/to/tdf-branding Any chance we can hook that into the stock download/configure flow with some: --with-tdf-branding configure switch ? with some scary sounding help-text for it ? or are we trying to make this difficult ? :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote: 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions are then: should they be mirrored or not, and what does really appear on an RTL environment? They should not be mirrored, even in handwriting the check mark is drawn the same RTL or not (the only instance I've seen check mark drawn the other direction was by a left-handed person) Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Will the real creator of EasyHack 38884 please stand up?
Hi all, Will the real creator of EasyHack 38884 please stand up and clarify? Also please CC yourself on the EasyHack you created ;) Thanks, Bjoern Begin forwarded message: Date: Tue, 29 Nov 2011 05:56:58 + From: bugzilla-dae...@freedesktop.org To: bjoern.michael...@canonical.com Subject: [Bug 38884] [EasyHack] Improve Up/Down movement in writer https://bugs.freedesktop.org/show_bug.cgi?id=38884 --- Comment #1 from Forest Johnson johns...@beloit.edu 2011-11-29 06:56:58 CET --- Is this just for normal text in writer? Why is this even an issue? I was under the impression that this was for special equation notation cursors, but It doesn't even look like there is a cursor that moves up and down when you are writing equations. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You reported the bug. -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Changes in default artwork - heads-up for 'official' TDF build providers
Michael Meeks wrote: configure switch ? with some scary sounding help-text for it ? or are we trying to make this difficult ? :-) Yes. :) Cheers, -- Thorsten pgpwq7baDYyw7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Changes in default artwork - heads-up for 'official' TDF build providers
On Tue, 2011-11-29 at 11:43 +0100, Thorsten Behrens wrote: Hi there, since the TDF trademark policy [http://wiki.documentfoundation.org/TradeMark_Policy] is rather light on the use of LibreOffice, but puts constraints on the use of the TDF mark, I've just switched our default branding (splash screen, start center background etc.) over to use a version *without the TDF tagline*. Great, thanks a lot. I felt it was a bit unfair and something of a trap to have constraints on the TDF branding, and then to make it the default branding. Happy to see that resolved. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Assertions and Logging
On Mon, 2011-11-28 at 22:59 +0100, Michael Stahl wrote: tests in sw run for me with this, please try it out: http://cgit.freedesktop.org/libreoffice/core/commit/?id=59e298823019093ee788104c2e95cb0c7b145d05 Works for me(tm). *mumble*, paragraph anchored graphics are a pain anyway. I Would really like do away with paragraph anchored graphics and have them auto-converted to anchored to character. hat would a) shrink the silly amount of anchoring options we have b) allow the paragraph anchored graphic to stick to the anchor character when a paragraph is split into two paragraphs, which would simplify things quite a bit, especially for change tracking and undo. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph
On Mon, 2011-11-28 at 21:26 +0200, Khaled Hosny wrote: Anyway, the font can be obtained from here[1], and I'm attaching a test file that shows this issue. [1] https://sourceforge.net/projects/amiri/files/ Great, thanks. Added it as a test doc as http://cgit.freedesktop.org/libreoffice/core/commit/?id=0dfdf8ed71c53c56c980e5b7117f963834cd32b8 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list
On Tue, 2011-11-29 at 10:31 +, Michael Meeks wrote: Hi Olivier, Caolan - after the 'word count' victim dialog, it seems that the extensions dialog has a foul nightmare of manual size calulation all over it ;-) cf. the ~90 lines of: Bah, just weeping with sadness with my recent discovery that Cancel buttons without am explicit callback set will query their immediate parent if its a Dialog and call EndDialog on it or Close if its not a dialog when pushed :-( C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LoadComponentFromUrl misuse lead to crash
On Mon, 2011-11-28 at 18:22 +0100, Laurent Godard wrote: Hi here is a summary of the bug i encounter, present in all LibO versions (master, 344, 322), but safe in OOo321 inside a macro, i launch a stardesktop.loadComponentFromUrl(firstArg, ...). if firstArg is an URL, starting with file://, no problem if firstArg is a path, /the/path/to/my/file, LibO crashes yes, firstArg has to be an URL, it is specified. But LibO should throw an IllegalArgumentException as OOo does. Never good that LibO crashes Can you attach a demo ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list
Hi Caolan, On Tue, 2011-11-29 at 12:32 +, Caolán McNamara wrote: Caolan - after the 'word count' victim dialog, it seems that the extensions dialog has a foul nightmare of manual size calulation all over it ;-) cf. the ~90 lines of: Bah, just weeping with sadness with my recent discovery that Cancel buttons without am explicit callback set will query their immediate parent if its a Dialog and call EndDialog on it or Close if its not a dialog when pushed :-( Ah - but this is what I added: Window* Window::GetParentDialog() const for - surely ? :-) [ at least to reduce the cut/paste of that code inside cui/ ;-] - it just walks up the hierarchy in a nasty way looking for a dialog parent. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5
Hi Petr, Petr Mladek wrote (29-11-11 11:54) I have added QA and devel mailing lists into CC. We should not cook such an important event in background. Agreed - that is why I started at the list initially of course ;-) Cor Nouws píše v Út 29. 11. 2011 v 00:06 +0100: Is it OK for you if I proceed more or less as outlined below? I have some additional remarks that I'll take into account. I think I'll explain clearly to the people the way to Litmus for if they want to do the structural tests. I saw some work on changed naming. Is that already in place? Heh, we are going to do one more restructuralization in Litmus. Rimas implemented a nice feature yesterday. We are now able to mark some test cases as language and/or OS dependent. This option affects when the test will be marked as done in test run. This way we could get easier structure and optimize the testing efforts. Ah cool. That reads to me as a feature that will prevent more people doing the same test without good reason. Yi Fan is creating documentation at http://wiki.documentfoundation.org/QA/Testing/Test_Cases_Organization Also he is going to update the existing test cases accordingly. He wants to finish this until Dec 6 or so. Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. I saw your note in an earlier mail yes. But did not really think about it, sorry. Is it a good idea if for the next 7/8 weeks we focus on as much testing as possible and that we after that try to encourage people to help with writing tests cases? Cor Nouws wrote (19-11-11 16:56) Goal is (as discussed before) get more people's focus on early testing, rather then with the first RC, and also more people testing :-) I have draft the following schedule with special events: - With the first beta, two day's organised bug-hunting: - Friday 9 and Saturday 10 December - the beta-0, makes sure that reliable builds are there for all - mail all people on l10n lists and ask to spread the news - mail to discuss users - people available on irc for guidance It sounds good. Rainer is just afraid that we do not get enough people attention. He tried to do such events in the past and nobody appeared. Well, I am not sure how Rainer announced it. You might know better channels. I share his experience from years past that it is not easy. On the other hand: - all we get on testing early is important; - we might help l10n people/groups to present it. Announcing the first beta of the next great LibreOffice (- features..) and a bug hunt session, sure will get some media attention. Which is good for the overall project and good for the l10n teams... Of course, needs some preparation, but should not be too difficult. I have some hours available this and next week to help. - during the months, a two day's competition: - Saturday 14 and Sunday 15 January - a prize for the three that post most bug-weight in those two day's - bug weight: points/issue: 1 for normal, 1,5 for major, 2,5 for every blocker issue - severity needs to be confirmed by QA specialists (in max one week) - prizes are e.g. sweater and mug. - QA specialists cannot win a prize (they should just get the sweater and mug without that) I am not sure about this action. I am afraid that we could get too many bug reports and it will be hard to sort them, ... Note that we currently have only very few people doing the bug triage. That is a possible trap, yes. Maybe there are some simple way's to make it better (will think about that later, but of course, hints welcome..) So best is the we start with the first step, and in the mean while think about if a competition can be managed in a pretty fair way. Another problem is who would judge the results :-) I thought you would like to volunteer ;-) - with the first RC, two day's organised bug-hunting - Friday 20 and Saturday 21 January - ... (see above for more) Same as for the first bug hunting session. Same for me ;-) When I think about it, we have a chicken and egg problem. I am afraid that we do not have enough active QA people that would help to organize such event. On the other hand, such action could bring new people or get them from the hiding corner. Agree. So what might help is find some support in organising, I think I can do that. I would try a well announced bug-hunting session. If we get enough people there, I would skip the competition because it is hard to organize. Might be a good choice - as written before, we can decide later. Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to ask them to create them as described at http://wiki.documentfoundation.org/QA/Testing/Test_Case Otherwise, it would end in a chaotic testing. Well, it would be better than nothing. Chaotic tests give great results - if people can write down the results
Re: [Libreoffice] two assertions raised and a failed database query
On Sun, 2011-11-27 at 21:27 +0100, Alex Thurgood wrote: Le 08/08/2011 21:11, Terrence Enger a écrit : Hi all, Seems like someone on Bugzilla is having a similar problem with date/time imports via ODBC : https://bugs.freedesktop.org/show_bug.cgi?id=42658 Thank you for the heads-up, Alex. Discussion is continuing in bugzilla. Short version: I think the problem is different from what I have looked at before, and using different platforms limits my ability to help. whine This is one more time when it would be nice for the project to have a database server to play with. (Now, will somebody please bring some chheeze, so that we can have a party?) /whine Terry. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] errors in idl files
On 11/29/2011 01:20 PM, Michael Stahl wrote: Stephan said he was interested in changing something there, but not using cpp would definitely be a change that breaks backward compatibility of the URE, and could only be done for LO 4, if at all. Another option is to create a new syntax already before LO 4, but keep support for the old syntax for backwards compatibility (maybe via a tool that translates from the old to the new syntax). Not yet decided how to proceed. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
On Tue, 2011-10-25 at 14:02 -0400, Kohei Yoshida wrote: The state what sheets are selected is clearly view related and does not belong to the document. In fact two different views can have different sheets selected. Well, I wouldn't say clearly, since I had the same idea about tab colors being view properties, but apparently the tab colors do belong to the document (as I was told back in the day). The tab colors are stored in ScTable currently. With regard to different views having different sheet selections, I wonder if that is really an intended behavior, or just a side-effect of how we currently store this property. I personally wouldn't mind changing this behavior so that all views would have identical sheet selections. Anyway. In the end, I've decided not to follow my original plan, and fix it differently. The tab selection data stays with ScMarkData, and I worked around it by copying that data from ScTabViewShell to ScPreviewShell during print preview. It should be fixed on master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list
On Tuesday 29 of November 2011, Michael Meeks wrote: Ah - but this is what I added: Window* Window::GetParentDialog() const One 'const' missing (or one too much). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] fdo#42924: needs help with tablehead xml parsing
Hello Jan, On Tue, Nov 29, 2011 at 00:33, Jan Holesovsky ke...@suse.cz wrote: unfortunately you were gone when I returned... Sorry for that too. It's a different-timezone problem :) That it is true, it cannot; but still we in fact have 2 passes in the wikiconv2.py - 1) when it parses the xml, and builds the internal representation, and 2) when it outputs the wiki page. [cut] Thanks very much! I'll have a look. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5
Cor Nouws píše v Út 29. 11. 2011 v 15:34 +0100: Petr Mladek wrote (29-11-11 11:54) Rimas implemented a nice feature yesterday. We are now able to mark some test cases as language and/or OS dependent. This option affects when the test will be marked as done in test run. This way we could get easier structure and optimize the testing efforts. Ah cool. That reads to me as a feature that will prevent more people doing the same test without good reason. Exactly. Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. I saw your note in an earlier mail yes. But did not really think about it, sorry. Is it a good idea if for the next 7/8 weeks we focus on as much testing as possible and that we after that try to encourage people to help with writing tests cases? I would encourage people to do both. Testing is important. On the other hand, the written tests help to avoid duplication. Also they are inspiration for people that have less experience. Note most of the test make sense to duplicate on Windows, Linux, and MAC. I would write it the way that we are looking for testers. Any test make sense. We want to do the existing tests from Litmus. They are also inspiration for people that are in doubts. On the other hand, if anyone does an interesting test that is missing in Litmus, we kindly ask them to document it there. The description need not be perfect, we could always improve it later. I think that people do not need to do this only during the bug-hunting session. They could do it at any time. We should mention links to the documentation, .e.g. http://wiki.documentfoundation.org/QA/Testing/Regression_Tests http://wiki.documentfoundation.org/QA/Testing/Test_Case http://wiki.documentfoundation.org/QA/Testing/Test_Cases_Contribution Cor Nouws wrote (19-11-11 16:56) - With the first beta, two day's organised bug-hunting: - Friday 9 and Saturday 10 December - the beta-0, makes sure that reliable builds are there for all - mail all people on l10n lists and ask to spread the news - mail to discuss users - people available on irc for guidance It sounds good. Rainer is just afraid that we do not get enough people attention. He tried to do such events in the past and nobody appeared. Well, I am not sure how Rainer announced it. You might know better channels. I share his experience from years past that it is not easy. On the other hand: - all we get on testing early is important; - we might help l10n people/groups to present it. Announcing the first beta of the next great LibreOffice (- features..) and a bug hunt session, sure will get some media attention. Which is good for the overall project and good for the l10n teams... Of course, needs some preparation, but should not be too difficult. I have some hours available this and next week to help. Sounds good to me. - during the months, a two day's competition: - Saturday 14 and Sunday 15 January - a prize for the three that post most bug-weight in those two day's - bug weight: points/issue: 1 for normal, 1,5 for major, 2,5 for every blocker issue - severity needs to be confirmed by QA specialists (in max one week) - prizes are e.g. sweater and mug. - QA specialists cannot win a prize (they should just get the sweater and mug without that) I am not sure about this action. I am afraid that we could get too many bug reports and it will be hard to sort them, ... Note that we currently have only very few people doing the bug triage. That is a possible trap, yes. Maybe there are some simple way's to make it better (will think about that later, but of course, hints welcome..) So best is the we start with the first step, and in the mean while think about if a competition can be managed in a pretty fair way. Yup, I like this step by step approach. Another problem is who would judge the results :-) I thought you would like to volunteer ;-) Please not! It would be my nightmare. I would be stressed that I would not be objective :-) Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to ask them to create them as described at http://wiki.documentfoundation.org/QA/Testing/Test_Case Otherwise, it would end in a chaotic testing. Well, it would be better than nothing. Chaotic tests give great results - if people can write down the results in a structure way of course ;-) I can draft a page to get just the people in the bug-hunt sessions on the right track. That would be great if you could draft something. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SWT window locks LOo
Hi,
I have tested your code example. It works fine under Linux if I remove
//display.dispose();
from
public SWTBrowser(String location) {...}
PS
In my own extensions I use Java Swing windows. In Swing there is a
JFrame option:
frm.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
Try to find something like this in SWT and don't call dispose() manually.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
On Tue, Nov 29, 2011 at 1:03 PM, Khaled Hosny khaledho...@eglug.org wrote: On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote: 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions are then: should they be mirrored or not, and what does really appear on an RTL environment? They should not be mirrored, even in handwriting the check mark is drawn the same RTL or not (the only instance I've seen check mark drawn the other direction was by a left-handed person) As Khaled said , check marks looks the same in RTL languages. No need to mirror, but thanks for asking (: Kaplan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Translation of German comments in /svx/source/svdraw
Hi again, I started working on the rest of the files but I am pretty much stuck in svdoedge.cxx. There is a rather long section of case distinctions, much like in a textbook. I assume it is one of the more useful comments, but the original author seems to have used symbols to illustrate his explanations. The meaning of the symbols, however, has seemingly been completely lost (using search and replace they all seem to come up as the same character). The part of the code in question is [2]. Overall, there are three separate comments with case distinctions (one above the example, one below). Looking at the AOOo code, the symbols seem lost there, too. What should I do here, just leave this in? Remove the comments in question completely? Astron. [2] http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdoedge.cxx#1098 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)
Hello,
sorry, I was sure there was more about it...but too early this morning,
I could not sort out all points.
Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to
not include newly appended columns of an area. Why?
by the way, this reflect the comment in
void ScDBData::ExtendDataArea(ScDocument* pDoc)
{
// Extend the DB area to include data rows immediately below.
which comment is from Kohei ( 9f9ff37f ) who toke this from a previous
comment. Hence, the change would make the call be in line with the comment.
This is the original reason why I started to play with it and changed it
like this, since comment and implementation were not coherent.
Regards
Pierre-André
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] New Windows tinderbox: Windows 2008R2
Fridrich Strba schrieb: Instead of setup.exe /a one should call msiexec.exe /a Hello, yes, that will work (and I remember that we already had this proceeding for a while). I added some hints on https://wiki.documentfoundation.org/Installing_in_parallel#Windows Kind regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SWT window locks LOo
if i remove the display.dispose() OO does'nt freeze. but when i close browser window and click toolbar button again to relauch SWT browser it doesn't show the browser window. is that what you get too ? how to solve this? -- View this message in context: http://nabble.documentfoundation.org/Re-SWT-window-locks-LOo-tp3545675p3546091.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Possible little code simplification
2011/11/28 Michael Stahl mst...@redhat.com: On 25/11/11 19:05, Ivan Timofeev wrote: Well, another possible memory optimization is to merge SwSortedObjsImpl into SwSortedObjs. What is the reason to use the pImpl pattern here? usually pImpl is a good idea because it is the only way to get actual encapsulation in C++; but in this case it definitely looks overdone to me... it really does not make any sense to have a separate header and cxx file for the impl class, that should all be moved into swsortedobjs.cxx. hmmm... am not sure about the question should it have a pImpl at all, currently the impl only contains a vector, but on the other hand, perhaps somebody will add other members later... i don't have a strong opinion in this case :) impl here is just wrapper for the vector that only inserts objects in a right place... So, merged after all :-) Ok, there are many SwFrms in a big doc... We don't want to throw away memory. But we would use a shared between the SwFrm instances static variable for an empty list (null object), and return it in GetDrawObjects when our SwSortedObjs is dead. What do you think about it? for this case i don't like it, because this null object would be mutable: it would be possible that somebody mis-uses this to get the pDrawObjs, receiving the static instance, and then adding an element, which is obviously bogus. so the explicit null checks look like the lesser evil :) Ah yes, you are right! ;) I foolishly didn't consider that case. Leaving it as is. what perhaps could be investigated is whether the pDrawObjs really has to be a member of SwFrm, perhaps it could be moved to some sub-class that is less often used... but note i am not familiar with the layout code so that is just a guess. Heh, I'm afraid that I haven't got the guts to do such analysis. :-) Thank you for your attention and tips! All the best, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SWT window locks LOo
after i close SWT browser window. i try oepn a new OO document and then OO crashes! SWT and Libreoffice on linux are very Problematic! they didn't proposed a fix to this bug since a very long time now! -- View this message in context: http://nabble.documentfoundation.org/Re-SWT-window-locks-LOo-tp3545675p3546102.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.5.0.0 tag created (3.5.0-beta0)
Hi, there have been created the libreoffice-3.5.0.0 tag for 3.5.0-beta0 release. The corresponding official builds will be available by the end of the week. The main purpose of this build is to make sure that we are able to create usable builds, with release configuration, from master. The real game will start the following week after the feature freeze. Master is very living branch. I had troubles to build it today. So, I based the tag on snapshot from yesterday, about 16:35UTC. It was the point of last successful Windows build. In addition, I cherry picked several nldsolver-related fixes. At least one of them was necessary for building with more localizations. I have successfully built it on Linux-x86_64. Though, you might need some extra fixes on other platforms or Linux systems. We will get more stable code base after the feature freeze. I hope that beta2 will be buildable almost everywhere out of box (if you commit the fix ;-) The list of changes against 3.4.0-beta1 (branch point for 3.5) is quite large. You might get it at http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-master-release-3.5.0.0.log http://dev-builds.libreoffice.org/pre-releases/src/commit-log-master-release-3.5.0.0.log See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.0 libreoffice-3.5.0.0 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5
Hi Petr, Petr Mladek wrote (29-11-11 16:42) Cor Nouws píše v Út 29. 11. 2011 v 15:34 +0100: Petr Mladek wrote (29-11-11 11:54) Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. I saw your note in an earlier mail yes. But did not really think about it, sorry. Is it a good idea if for the next 7/8 weeks we focus on as much testing as possible and that we after that try to encourage people to help with writing tests cases? I would encourage people to do both. Testing is important. On the other hand, the written tests help to avoid duplication. Also they are inspiration for people that have less experience. Note most of the test make sense to duplicate on Windows, Linux, and MAC. I'm afraid that too much emphasis now on the need to write test cases, distracts people from what is needed most now: testing testing and testing.. I would write it the way that we are looking for testers. Any test make sense. We want to do the existing tests from Litmus. They are also [...] But I agree that some mention, as inspiration, heads up etc. is important. I'll include it in my drafts. Cor Nouws wrote (19-11-11 16:56) - With the first beta, two day's organised bug-hunting: It sounds good. Rainer is just afraid that we do not get enough people I share his experience from years past that it is not easy. On the other hand: - all we get on testing early is important; - we might help l10n people/groups to present it. Announcing the first beta of the next great LibreOffice (- features..) and a bug hunt session, sure will get some media attention. Which is good for the overall project and good for the l10n teams... Of course, needs some preparation, but should not be too difficult. I have some hours available this and next week to help. Sounds good to me. - during the months, a two day's competition: I am not sure about this action. I am afraid that we could get too many That is a possible trap, yes. Maybe there are some simple way's to make it better (will think about that later, but of course, hints welcome..) So best is the we start with the first step, and in the mean while think about if a competition can be managed in a pretty fair way. Yup, I like this step by step approach. OK. I'll put working on ideas for this in a separate thread. Maybe we can use it now, maybe it's smarter to use the competition idea another moment. We can think about that. Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to I can draft a page to get just the people in the bug-hunt sessions on the right track. That would be great if you could draft something. Will post more details soon :-) Cheers! Cor -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] fdo#39950 report builder segfault during copy/paste
On Mon, 2011-11-28 at 17:53 +0100, Lionel Elie Mamane wrote: Attached patch is a backport of commit 538190e0ea142d0a7da244809c66241379d4d91b in master by Caolán McNamara. Lovely - merged it to libreoffice-3-4 - looks sensible, thanks for tracking it down. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
On 11/29/2011 12:03 PM, Khaled Hosny wrote: On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote: 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions are then: should they be mirrored or not, and what does really appear on an RTL environment? They should not be mirrored, even in handwriting the check mark is drawn the same RTL or not (the only instance I've seen check mark drawn the other direction was by a left-handed person) Thanks for the clarification, I'll remove that code with the related comment/bug number. Best regards Matteo Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Translation of German comments in /svx/source/svdraw
Hi Stefan,
On Tuesday, 2011-11-29 18:17:44 +0100, Stefan Knorr (Astron) wrote:
comments, but the original author seems to have used symbols to
illustrate his explanations. The meaning of the symbols, however, has
seemingly been completely lost (using search and replace they all seem
to come up as the same character).
Ah the joy of text encodings and editors shredding them..
I managed to get hold of an intact revision before ooo/DEV300_m101 was
merged and converted it from *gasp* cp437 to utf-8, attached are the
relevant sections.
Eike
--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
---%---snip---%--- ---%---snap---%---
} else if (nMainCase==2) {
// Fall 2:
bForceMeeting=sal_True;
if (bHor1) { // beide waagerecht
/* 9 Moeglichkeiten: ∙ ∙ ∙
*/
/* 2.1 Gegenueber, Ueberschneidung ├ ┤ ∙
*/
/* nur auf der Y-Achse ∙ ∙ ∙
*/
/* 2.2, 2.3 Gegenueber, vertikal versetzt. ├ ∙ ∙ ∙ ∙ ∙
*/
/*Ueberschneidung weder auf der ∙ ┤ ∙ ∙ ┤ ∙
*/
/*X- noch auf der Y-Achse∙ ∙ ∙ ├ ∙ ∙
*/
/* 2.4, 2.5 Untereinander, ∙ ├ ∙ ∙ ∙ ∙
*/
/*Ueberschneidung ∙ ┤ ∙ ∙ ┤ ∙
*/
/*nur auf X-Achse ∙ ∙ ∙ ∙ ├ ∙
*/
/* 2.6, 2.7 Gegeneinander, vertikal versetzt. ∙ ∙ ├ ∙ ∙ ∙
*/
/*Ueberschneidung weder auf der ∙ ┤ ∙ ∙ ┤ ∙
*/
/*X- noch auf der Y-Achse. ∙ ∙ ∙ ∙ ∙ ├
*/
/* 2.8 Gegeneinander. ∙ ∙ ∙
*/
/* Ueberschneidung nur ∙ ┤ ├
*/
/* auf der Y-Achse. ∙ ∙ ∙
*/
/* 2.9 Die BewareRects der Objekte ueberschneiden
*/
/* sich auf X- und Y-Achse.
*/
/* Die Faelle gelten entsprechend umgesetzt auch fuer
*/
/* senkrechte Linienaustritte.
*/
/* Die Faelle 2.1-2.7 werden mit dem Default-Meeting
ausreichend*/
/* gut behandelt. Spezielle MeetingPoints werden hier also nur
*/
/* fuer 2.8 und 2.9 bestimmt.
*/
// Normalisierung. aR1 soll der nach rechts und
// aR2 der nach links austretende sein.
---%---snip---%--- ---%---snap---%---
} else if (nMainCase==3) { // Fall 3: Einer waagerecht und der
andere senkrecht. Sehr viele Fallunterscheidungen
/* Kleine Legende: ∙ · ∙ · ∙ - Ohne Ueberschneidung, maximal
Beruehrung. */
/* · · · · · - Ueberschneidung
*/
/* ∙ · ├ · ∙ - Selbe Hoehe
*/
/* · · · · · - Ueberschneidung
*/
/* ∙ · ∙ · ∙ - Ohne Ueberschneidung, maximal
Beruehrung. */
/* Linienaustritte links ┤, rechts ├, oben ┴ und unten ┬.
*/
/* Insgesamt sind 96 Konstellationen moeglich, wobei einige nicht
einmal*/
/* eindeutig einem Fall und damit einer Behandlungsmethode
zugeordnet werden*/
/* koennen.
*/
/* 3.1: Hierzu moegen alle Konstellationen zaehlen, die durch den
*/
/* Default-MeetingPoint zufriedenstellend abgedeckt sind
(20+12). */
/* ┬ ┬ ┬ · ┴┴ · ┬ ┬ ┬ Diese 12 ∙ · ∙ ┬ ∙∙ · ∙ · ∙∙
┬ ∙ · ∙∙ · ∙ · ∙*/
/* · · · · ┴┴ · · · · Konstel. · · · · ·· · · · ┬·
· · · ·┬ · · · ·*/
/* ∙ · ├ · ∙∙ · ┤ · ∙ jedoch∙ · ├ · ┴∙ · ├ · ┬┴
· ┤ · ∙┬ · ┤ · ∙*/
/* · · · · ┬┬ · · · · nur zum · · · · ┴· · · · ·┴
· · · ·· · · · ·*/
/* ┴ ┴ ┴ · ┬┬ · ┴ ┴ ┴ Teil: ∙ · ∙ ┴ ∙∙ · ∙ · ∙∙
┴ ∙ · ∙∙ · ∙ · ∙*/
/* Letztere 16 Faelle scheiden aus, sobald sich die Objekte offen
*/
/* gegenueberstehen (siehe Fall 3.2).
[Libreoffice] [PATCH] Fix rendering of GTK combobox in RTL
Hi all,
Here is a little patch that fixes a rendering buglet that annoyed me
since ever. Native GTK applications swap the position of the button and
editing area of comboboxes in RTL and themese expect that, but LO does
not.
The same issue happens with spin buttons and other similar widget, I'm
just making sure I'm doing it right before sending other patches.
Also I'm not sure how GTK3 relates to this (is it affected/need to be
fixed separately etc.) since I can't build with it here.
BTW, Application::GetSettings().GetLayoutRTL() is now used in several
places (and may be more will come), would it be more rideable/save a few
microsocends to have a
bool isLayoutRTL = Application::GetSettings().GetLayoutRTL()
(or something like that) on the top of the file?
Regards,
Khaled
From a8fd7c4a5dbf57003339af883ae795eefe093f90 Mon Sep 17 00:00:00 2001
From: Khaled Hosny khaledho...@eglug.org
Date: Wed, 30 Nov 2011 08:57:46 +0200
Subject: [PATCH] gtk: fix RTL combobox rendering
GTK themes expect the button and the editing area to be swapped in RTL.
---
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index 2cdd032..6afba20 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -2185,6 +2185,8 @@ sal_Bool GtkSalGraphics::NWPaintGTKComboBox( GdkDrawable* gdkDrawable,
RectangleaEditBoxRect( pixmapRect );
aEditBoxRect.SetSize( Size( pixmapRect.GetWidth() - buttonRect.GetWidth(), aEditBoxRect.GetHeight() ) );
+if( Application::GetSettings().GetLayoutRTL() )
+aEditBoxRect.SetPos( Point( x + buttonRect.GetWidth() , y ) );
#define ARROW_EXTENT0.7
arrowRect.SetSize( Size( (gint)(MIN_ARROW_SIZE * ARROW_EXTENT),
@@ -2254,8 +2256,11 @@ static Rectangle NWGetComboBoxButtonRect( int nScreen,
if( nPart == PART_BUTTON_DOWN )
{
aButtonRect.SetSize( Size( nButtonWidth, aAreaRect.GetHeight() ) );
-aButtonRect.SetPos( Point( aAreaRect.Left() + aAreaRect.GetWidth() - nButtonWidth,
- aAreaRect.Top() ) );
+if( Application::GetSettings().GetLayoutRTL() )
+aButtonRect.SetPos( Point( aAreaRect.Left(), aAreaRect.Top() ) );
+else
+aButtonRect.SetPos( Point( aAreaRect.Left() + aAreaRect.GetWidth() - nButtonWidth,
+ aAreaRect.Top() ) );
}
else if( nPart == PART_SUB_EDIT )
{
@@ -2271,6 +2276,8 @@ static Rectangle NWGetComboBoxButtonRect( int nScreen,
Point aEditPos = aAreaRect.TopLeft();
aEditPos.X() += adjust_x;
aEditPos.Y() += adjust_y;
+if( Application::GetSettings().GetLayoutRTL() )
+aEditPos.X() += nButtonWidth;
aButtonRect.SetPos( aEditPos );
}
--
1.7.0.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remember the RTL interface
On Tue, Nov 29, 2011 at 02:18:41AM +0200, Lior Kaplan wrote: Hi Guys, As 3.5.0 enters the first beta (ok, ok - beta0), I'd like to remind you on the RTL stuff from the conference last month. This isn't a mail for what about bug X, just taking the opportunity to send a general reminder... (: Is there a list of those issue somewhere for the mere mortals who did not attend the conference? I'd like to give it a try (when I get bored from drawing letters), may be I can find some really simple stuff to work on :) Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [Libreoffice] New Windows tinderbox: Windows 2008R2
Rainer Bielefeld schrieb: GUID) aren't possible with MSI. If what Rainer wants is to have stable version of LibreOffice installed along with a testing version, Or more precisely: I have 10 ... 20 Master versions on my PC so that I can check where a regression came into the code. That could be done with the MinGW builds, but they are new and still lousy buggy, it will still cost some time until they will be in a shape that the can be used for real life tests. CU Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] New Windows tinderbox: Windows 2008R2
Hi Rainer and we should try to waste as few as many time as possible. For me it's annoying to have to check every day various folders whether we have new builds. currently I mostly search in vain, and sometimes I find something I can't use; You can speedup the process by looking into http://tinderbox.libreoffice.org/MASTER/status.html I can see that all tinderboxes are being organized and listed according to this page https://wiki.documentfoundation.org/Development/Tinderbox I think this is a big step forward. Thank you all! ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] QA ideas for 3.5 WAS Re: [Libreoffice] Improving the QA and Release for 3.5
Hi Cor, I have added QA and devel mailing lists into CC. We should not cook such an important event in background. Cor Nouws píše v Út 29. 11. 2011 v 00:06 +0100: Hi Yifan Petr, Is it OK for you if I proceed more or less as outlined below? I have some additional remarks that I'll take into account. I think I'll explain clearly to the people the way to Litmus for if they want to do the structural tests. I saw some work on changed naming. Is that already in place? Heh, we are going to do one more restructuralization in Litmus. Rimas implemented a nice feature yesterday. We are now able to mark some test cases as language and/or OS dependent. This option affects when the test will be marked as done in test run. This way we could get easier structure and optimize the testing efforts. Yi Fan is creating documentation at http://wiki.documentfoundation.org/QA/Testing/Test_Cases_Organization Also he is going to update the existing test cases accordingly. He wants to finish this until Dec 6 or so. Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. Cor Nouws wrote (21-11-11 10:59) Cor Nouws wrote (19-11-11 16:56) Goal is (as discussed before) get more people's focus on early testing, rather then with the first RC, and also more people testing :-) I have draft the following schedule with special events: - With the first beta, two day's organised bug-hunting: - Friday 9 and Saturday 10 December - the beta-0, makes sure that reliable builds are there for all - mail all people on l10n lists and ask to spread the news - mail to discuss users - people available on irc for guidance It sounds good. Rainer is just afraid that we do not get enough people attention. He tried to do such events in the past and nobody appeared. Well, I am not sure how Rainer announced it. You might know better channels. - during the months, a two day's competition: - Saturday 14 and Sunday 15 January - a prize for the three that post most bug-weight in those two day's - bug weight: points/issue: 1 for normal, 1,5 for major, 2,5 for every blocker issue - severity needs to be confirmed by QA specialists (in max one week) - prizes are e.g. sweater and mug. - QA specialists cannot win a prize (they should just get the sweater and mug without that) I am not sure about this action. I am afraid that we could get too many bug reports and it will be hard to sort them, ... Note that we currently have only very few people doing the bug triage. Another problem is who would judge the results :-) - with the first RC, two day's organised bug-hunting - Friday 20 and Saturday 21 January - ... (see above for more) Same as for the first bug hunting session. When I think about it, we have a chicken and egg problem. I am afraid that we do not have enough active QA people that would help to organize such event. On the other hand, such action could bring new people or get them from the hiding corner. I would try a well announced bug-hunting session. If we get enough people there, I would skip the competition because it is hard to organize. Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to ask them to create them as described at http://wiki.documentfoundation.org/QA/Testing/Test_Case Otherwise, it would end in a chaotic testing. Well, it would be better than nothing. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] QA ideas for 3.5 WAS Re: [Libreoffice] Improving the QA and Release for 3.5
Hi Petr, Petr Mladek wrote (29-11-11 11:54) I have added QA and devel mailing lists into CC. We should not cook such an important event in background. Agreed - that is why I started at the list initially of course ;-) Cor Nouws píše v Út 29. 11. 2011 v 00:06 +0100: Is it OK for you if I proceed more or less as outlined below? I have some additional remarks that I'll take into account. I think I'll explain clearly to the people the way to Litmus for if they want to do the structural tests. I saw some work on changed naming. Is that already in place? Heh, we are going to do one more restructuralization in Litmus. Rimas implemented a nice feature yesterday. We are now able to mark some test cases as language and/or OS dependent. This option affects when the test will be marked as done in test run. This way we could get easier structure and optimize the testing efforts. Ah cool. That reads to me as a feature that will prevent more people doing the same test without good reason. Yi Fan is creating documentation at http://wiki.documentfoundation.org/QA/Testing/Test_Cases_Organization Also he is going to update the existing test cases accordingly. He wants to finish this until Dec 6 or so. Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. I saw your note in an earlier mail yes. But did not really think about it, sorry. Is it a good idea if for the next 7/8 weeks we focus on as much testing as possible and that we after that try to encourage people to help with writing tests cases? Cor Nouws wrote (19-11-11 16:56) Goal is (as discussed before) get more people's focus on early testing, rather then with the first RC, and also more people testing :-) I have draft the following schedule with special events: - With the first beta, two day's organised bug-hunting: - Friday 9 and Saturday 10 December - the beta-0, makes sure that reliable builds are there for all - mail all people on l10n lists and ask to spread the news - mail to discuss users - people available on irc for guidance It sounds good. Rainer is just afraid that we do not get enough people attention. He tried to do such events in the past and nobody appeared. Well, I am not sure how Rainer announced it. You might know better channels. I share his experience from years past that it is not easy. On the other hand: - all we get on testing early is important; - we might help l10n people/groups to present it. Announcing the first beta of the next great LibreOffice (- features..) and a bug hunt session, sure will get some media attention. Which is good for the overall project and good for the l10n teams... Of course, needs some preparation, but should not be too difficult. I have some hours available this and next week to help. - during the months, a two day's competition: - Saturday 14 and Sunday 15 January - a prize for the three that post most bug-weight in those two day's - bug weight: points/issue: 1 for normal, 1,5 for major, 2,5 for every blocker issue - severity needs to be confirmed by QA specialists (in max one week) - prizes are e.g. sweater and mug. - QA specialists cannot win a prize (they should just get the sweater and mug without that) I am not sure about this action. I am afraid that we could get too many bug reports and it will be hard to sort them, ... Note that we currently have only very few people doing the bug triage. That is a possible trap, yes. Maybe there are some simple way's to make it better (will think about that later, but of course, hints welcome..) So best is the we start with the first step, and in the mean while think about if a competition can be managed in a pretty fair way. Another problem is who would judge the results :-) I thought you would like to volunteer ;-) - with the first RC, two day's organised bug-hunting - Friday 20 and Saturday 21 January - ... (see above for more) Same as for the first bug hunting session. Same for me ;-) When I think about it, we have a chicken and egg problem. I am afraid that we do not have enough active QA people that would help to organize such event. On the other hand, such action could bring new people or get them from the hiding corner. Agree. So what might help is find some support in organising, I think I can do that. I would try a well announced bug-hunting session. If we get enough people there, I would skip the competition because it is hard to organize. Might be a good choice - as written before, we can decide later. Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to ask them to create them as described at http://wiki.documentfoundation.org/QA/Testing/Test_Case Otherwise, it would end in a chaotic testing. Well, it would be better than nothing. Chaotic tests give great results - if people can write down the results
Re: [Libreoffice-qa] QA ideas for 3.5 WAS Re: [Libreoffice] Improving the QA and Release for 3.5
Cor Nouws píše v Út 29. 11. 2011 v 15:34 +0100: Petr Mladek wrote (29-11-11 11:54) Rimas implemented a nice feature yesterday. We are now able to mark some test cases as language and/or OS dependent. This option affects when the test will be marked as done in test run. This way we could get easier structure and optimize the testing efforts. Ah cool. That reads to me as a feature that will prevent more people doing the same test without good reason. Exactly. Another problem is that we still have only few testcases. We need to create more. We still could do it during the test phase. Any helping hands are welcome. I saw your note in an earlier mail yes. But did not really think about it, sorry. Is it a good idea if for the next 7/8 weeks we focus on as much testing as possible and that we after that try to encourage people to help with writing tests cases? I would encourage people to do both. Testing is important. On the other hand, the written tests help to avoid duplication. Also they are inspiration for people that have less experience. Note most of the test make sense to duplicate on Windows, Linux, and MAC. I would write it the way that we are looking for testers. Any test make sense. We want to do the existing tests from Litmus. They are also inspiration for people that are in doubts. On the other hand, if anyone does an interesting test that is missing in Litmus, we kindly ask them to document it there. The description need not be perfect, we could always improve it later. I think that people do not need to do this only during the bug-hunting session. They could do it at any time. We should mention links to the documentation, .e.g. http://wiki.documentfoundation.org/QA/Testing/Regression_Tests http://wiki.documentfoundation.org/QA/Testing/Test_Case http://wiki.documentfoundation.org/QA/Testing/Test_Cases_Contribution Cor Nouws wrote (19-11-11 16:56) - With the first beta, two day's organised bug-hunting: - Friday 9 and Saturday 10 December - the beta-0, makes sure that reliable builds are there for all - mail all people on l10n lists and ask to spread the news - mail to discuss users - people available on irc for guidance It sounds good. Rainer is just afraid that we do not get enough people attention. He tried to do such events in the past and nobody appeared. Well, I am not sure how Rainer announced it. You might know better channels. I share his experience from years past that it is not easy. On the other hand: - all we get on testing early is important; - we might help l10n people/groups to present it. Announcing the first beta of the next great LibreOffice (- features..) and a bug hunt session, sure will get some media attention. Which is good for the overall project and good for the l10n teams... Of course, needs some preparation, but should not be too difficult. I have some hours available this and next week to help. Sounds good to me. - during the months, a two day's competition: - Saturday 14 and Sunday 15 January - a prize for the three that post most bug-weight in those two day's - bug weight: points/issue: 1 for normal, 1,5 for major, 2,5 for every blocker issue - severity needs to be confirmed by QA specialists (in max one week) - prizes are e.g. sweater and mug. - QA specialists cannot win a prize (they should just get the sweater and mug without that) I am not sure about this action. I am afraid that we could get too many bug reports and it will be hard to sort them, ... Note that we currently have only very few people doing the bug triage. That is a possible trap, yes. Maybe there are some simple way's to make it better (will think about that later, but of course, hints welcome..) So best is the we start with the first step, and in the mean while think about if a competition can be managed in a pretty fair way. Yup, I like this step by step approach. Another problem is who would judge the results :-) I thought you would like to volunteer ;-) Please not! It would be my nightmare. I would be stressed that I would not be objective :-) Another question is how to instruct people during the bug-hunting session. We do not have enough test cases. One possibility would be to ask them to create them as described at http://wiki.documentfoundation.org/QA/Testing/Test_Case Otherwise, it would end in a chaotic testing. Well, it would be better than nothing. Chaotic tests give great results - if people can write down the results in a structure way of course ;-) I can draft a page to get just the people in the bug-hunt sessions on the right track. That would be great if you could draft something. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems?
Re: [Libreoffice-qa] [Libreoffice] New Windows tinderbox: Windows 2008R2
Fridrich Strba schrieb: Instead of setup.exe /a one should call msiexec.exe /a Hello, yes, that will work (and I remember that we already had this proceeding for a while). I added some hints on https://wiki.documentfoundation.org/Installing_in_parallel#Windows Kind regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] [ANNOUNCE] libreoffice-3.5.0.0 tag created (3.5.0-beta0)
Hi, there have been created the libreoffice-3.5.0.0 tag for 3.5.0-beta0 release. The corresponding official builds will be available by the end of the week. The main purpose of this build is to make sure that we are able to create usable builds, with release configuration, from master. The real game will start the following week after the feature freeze. Master is very living branch. I had troubles to build it today. So, I based the tag on snapshot from yesterday, about 16:35UTC. It was the point of last successful Windows build. In addition, I cherry picked several nldsolver-related fixes. At least one of them was necessary for building with more localizations. I have successfully built it on Linux-x86_64. Though, you might need some extra fixes on other platforms or Linux systems. We will get more stable code base after the feature freeze. I hope that beta2 will be buildable almost everywhere out of box (if you commit the fix ;-) The list of changes against 3.4.0-beta1 (branch point for 3.5) is quite large. You might get it at http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-master-release-3.5.0.0.log http://dev-builds.libreoffice.org/pre-releases/src/commit-log-master-release-3.5.0.0.log See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.5_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Now, if you want to switch your clone to the tag, please do: ./g fetch --tags ./g checkout -b tag-libreoffice-3.5.0.0 libreoffice-3.5.0.0 Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 43261] BUGZILLA: Issues with 'Select component' drop-down list
https://bugs.freedesktop.org/show_bug.cgi?id=43261 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Summary|: Issues with 'Select |BUGZILLA: Issues with |component' drop-down list |'Select component' ||drop-down list --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-11-29 00:38:26 PST --- But I should mention that it would not be a big thing to rename components, AFAIK that can be done without causing any e-mail to involved CC -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42851] Calc crashes when 2 cells get the same name
https://bugs.freedesktop.org/show_bug.cgi?id=42851 markus.mohrh...@googlemail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED --- Comment #1 from markus.mohrh...@googlemail.com 2011-11-29 00:45:54 PST --- fixed in 3.4.4 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42910] [Calc] xls export corrupts some formulas with named ranges
https://bugs.freedesktop.org/show_bug.cgi?id=42910 --- Comment #2 from markus.mohrh...@googlemail.com 2011-11-29 00:47:16 PST --- let me have a look at it I suspect another case of named ranges referencing each other -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43326] New: TransferTab mixes RangeName and used formulas
https://bugs.freedesktop.org/show_bug.cgi?id=43326 Bug #: 43326 Summary: TransferTab mixes RangeName and used formulas Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other OS/Version: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: oooc...@free.fr Created attachment 53943 -- https://bugs.freedesktop.org/attachment.cgi?id=53943 first file to import 2 files (file1, file8 attached), defining there own range names, and use them in formulas using a macro, transferttab in an empty document (see below) result : - the sheets are transfered (ok) - the formulas of the sheets coming from file1 are now using wrong formula (see D1_sheet1$A2 - the formula is d8_name1 instead of d1_name1) note also that named ranges are not defined correctly (based on the index of the sheets, and not names) and d1_name1 and d8_name1 points on the same sheet. maybe the source of the problem ? '-- sub problemFormulatranfertTab docDest = thisComponent files = array(/home/lgodard/Bureau/DTEPoc/calc/transfertTab/file1.ods,/home/lgodard/Bureau/DTEPoc/calc/transfertTab/file8.ods) for c = 0 to 1 docSrc = stardesktop.loadComponentFromUrl(convertToUrl(files(c)),_blank,0, array()) for i = 0 to docSrc.sheets.count-1 nomfeuille = docSrc.sheets(i) if not docDest.sheets.hasByName(nomFeuille.name) then docDest.sheets.importSheet(docSrc, nomfeuille.name,docDest.sheets.count) endif next i docSrc.close(true) next c print ok end sub -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43326] TransferTab mixes RangeName and used formulas
https://bugs.freedesktop.org/show_bug.cgi?id=43326 --- Comment #1 from Laurent Godard oooc...@free.fr 2011-11-29 01:45:10 PST --- Created attachment 53944 -- https://bugs.freedesktop.org/attachment.cgi?id=53944 second file to import -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43326] TransferTab mixes RangeName and used formulas
https://bugs.freedesktop.org/show_bug.cgi?id=43326 --- Comment #2 from Laurent Godard oooc...@free.fr 2011-11-29 01:54:17 UTC --- the problem may be due to ill-imported ranegnames, may be first address this point -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43330] New: TransferTab mixes rangeNames
https://bugs.freedesktop.org/show_bug.cgi?id=43330 Bug #: 43330 Summary: TransferTab mixes rangeNames Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other OS/Version: All Status: UNCONFIRMED Severity: major Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: oooc...@free.fr Created attachment 53945 -- https://bugs.freedesktop.org/attachment.cgi?id=53945 the file to import using the following macro, imported rangenames are not correctly defined if targetPos srcPos, seems ok for global range names result = theSheets.importSheet(srcDoc, srcName,3) if targetPos = pos of the source sheet where named raneg are defined -- do not poiint on the ocrrect sheet result = theSheets.importSheet(srcDoc, srcName,0) in fact, named ranges are based on indexes but should refer at sheetname gdb analysis pointed problems on sc/source/core/data/cell.cxx:183 created wrong rangenames ' the macro sub newApi destDoc = thisComponent theSheets = destDoc.sheets SrcUrl = convertToUrl(/home/lgodard/Bureau/DTEPoc/smallGlobal.ods) srcName = autreFeuille srcDoc = StarDesktop.loadComponentFromUrl(SrcUrl, _blank, 1, array() ) result = theSheets.importSheet(srcDoc, srcName,0) srcDoc.close(true) print result end sub -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43330] TransferTab mixes rangeNames
https://bugs.freedesktop.org/show_bug.cgi?id=43330 --- Comment #1 from Laurent Godard oooc...@free.fr 2011-11-29 02:07:26 PST --- Created attachment 53946 -- https://bugs.freedesktop.org/attachment.cgi?id=53946 the target file, the thisComponent in the macro -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43331] New: (Error-) dialog text should be selectable for copying
https://bugs.freedesktop.org/show_bug.cgi?id=43331 Bug #: 43331 Summary: (Error-) dialog text should be selectable for copying Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Installation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: sebast...@sspaeth.de I just had a 30 line error dialog pop up, with no way to copy the text out for ease of bug reporting/googling. At least Error Dialogs (if not all dialogs), should have their text selectable, so it can be copy'n pasted out. I have no clue where to look in the code for that one though, it might even lend itself to an easy hack... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38884] [EasyHack] Improve Up/Down movement in writer
https://bugs.freedesktop.org/show_bug.cgi?id=38884 --- Comment #2 from Noel Grandin noelgran...@gmail.com 2011-11-29 03:38:05 PST --- The only SmCursor::Move method is in the starmath module, here: http://opengrok.libreoffice.org/xref/core/starmath/source/cursor.cxx#36 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43201] : Home screen missing grey areas, becomes transparent
https://bugs.freedesktop.org/show_bug.cgi?id=43201 Paul Littlefield i...@paully.co.uk changed: What|Removed |Added Platform|Other |x86 (IA32) OS/Version|All |Linux (All) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43201] : Home screen missing grey areas, becomes transparent
https://bugs.freedesktop.org/show_bug.cgi?id=43201 --- Comment #1 from Olivier Hallot olivier.hal...@documentfoundation.org 2011-11-29 04:25:56 UTC --- Confirmed in a kubuntu Oneiric. Dell Vostro 3500 with intel chip: 00:02.0 VGA compatible controller: Intel Corporation Core Processor Integrated Graphics Controller (rev 18) (prog-if 00 [VGA controller]) Subsystem: Dell Device 044e Flags: bus master, fast devsel, latency 0, IRQ 46 Memory at fa40 (64-bit, non-prefetchable) [size=4M] Memory at b000 (64-bit, prefetchable) [size=256M] I/O ports at f080 [size=8] Expansion ROM at unassigned [disabled] Capabilities: access denied Kernel driver in use: i915 Kernel modules: i915 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43201] : Home screen missing grey areas, becomes transparent
https://bugs.freedesktop.org/show_bug.cgi?id=43201 --- Comment #2 from Paul Littlefield i...@paully.co.uk 2011-11-29 04:41:02 PST --- Yes, I have an intel chip too for this bug:- thinkpad ~ # lspci -v -s 00:02.0 00:02.0 VGA compatible controller: Intel Corporation Core Processor Integrated Graphics Controller (rev 02) (prog-if 00 [VGA controller]) Subsystem: Lenovo Device 21c8 Flags: bus master, fast devsel, latency 0, IRQ 40 Memory at f000 (64-bit, non-prefetchable) [size=4M] Memory at d000 (64-bit, prefetchable) [size=256M] I/O ports at 1800 [size=8] Expansion ROM at unassigned [disabled] Capabilities: [90] MSI: Enable+ Count=1/1 Maskable- 64bit- Capabilities: [d0] Power Management version 2 Capabilities: [a4] PCI Advanced Features Kernel driver in use: i915 I am using these drivers:- thinkpad ~ # eix -c -I intel [I] x11-drivers/xf86-video-intel (2.17.0@18/11/11): X.Org driver for Intel cards [I] x11-libs/libva-intel-driver (1.0.15@07/11/11): HW video decode support for Intel integrated graphics and this Xorg:- thinkpad ~ # eix -c -I xorg [I] x11-base/xorg-drivers (1.10@20/10/11): Meta package containing deps on all xorg drivers [I] x11-base/xorg-server (1.10.4-r1@27/10/11): X.Org X servers -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43335] New: Editing. Writer responsiveness.
https://bugs.freedesktop.org/show_bug.cgi?id=43335 Bug #: 43335 Summary: Editing. Writer responsiveness. Classification: Unclassified Product: LibreOffice Version: LibO 3.4.4 release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: enhancement Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: drz4...@gmail.com This is more an enhancement than a bug. What I would like to see, is a lot better responsiveness from the program. What I mean is this. When I right-click the mouse on a chosen word (to correct it, for example), sometimes the fly-out menu does not come up instantly, but takes a couple of seconds to appear (sometimes it comes up instantly). Imagine if you have to do multiple right-clicks… It is very annoying and time consuming. For me, it is the main reason I keep on using MS Writer. I tried to get rid of this problem by tweaking the memory settings, but with no result. My OS is UBUNTU amd64, 4 Gb Ram. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39748] [EasyHack] Cleanup extensions list
https://bugs.freedesktop.org/show_bug.cgi?id=39748 Olivier Hallot olivier.hal...@documentfoundation.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39748] [EasyHack] Cleanup extensions list
https://bugs.freedesktop.org/show_bug.cgi?id=39748 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | AssignedTo|libreoffice-b...@lists.free |dtar...@redhat.com |desktop.org | --- Comment #10 from David Tardon dtar...@redhat.com 2011-11-29 05:18:32 PST --- Yeah, the patch(es) looks good, but I thought the main point of this whole excercise was to hide the bundled extensions from user (e.g., do not show them by default)? I will commit it with that one change. Btw, it has not been FIXED yet (i.e., the code is not in git :) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
