Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On Thu, Dec 08, 2011 at 06:45:30PM +0100, Lionel Elie Mamane wrote: > On Thu, Dec 08, 2011 at 04:19:04PM +, Michael Meeks wrote: >> * postgresql fun. non-internal >> + Windows - run-time DLL dependency a pain (Lionel) >> + ship DLL ourselves ? > This is not a question mark, we have to do that, or link statically, > be it only because of Fridrich-mentioned problems. > Note that currently postgresql-sdbc always links statically when > using internal PostgreSQL. I did that because it seemed the easiest thing to do at first sight. However, we are losing the advantage of that, and thus I propose we switch to dynamic linking, and bundling the lib on platforms / situations that need it. I started actually testing the "internal PostgreSQL C client library" build in use, and I realised it is rather crippled: - no SSL/TLS support, for encrypted communication with the DB server and authentication by X.509 certificate. - no Kerberos support: authentication; apparently can be used for windows domain "single signon" from a non-windows machine. - no GSSAPI support: yet another authentication mechanism - no LDAP support: yes, in the client library: this allows to store the connection info in LDAP and thus manage it centrally. Can be really convenient in enterprise environment. Leaving only hardcoded-in-LibreOffice's .odb file connection string with user/password authentication. Of these features I'd expect SSL (encrypted connection) is the most widely used one. I started hacking our internal postgresql to activate all this, but this introduces dependencies on yet other libraries: OpenSSL, MIT Kerberos, com_err, ldap, ... This means that linking statically against libpq is not the easiest anymore, since static linking does not automatically recurse, in the way that dynamic linking does :) More deeply, we don't gain anything/much by linking statically against libpq, but dynamically against these other libs. But linking statically against some of these other libs is significantly harder than dynamic link: - At least on my Debian, libssl is not compiled with -fPIC, so a dynamic library (postgresql-sdbc-impl.so) cannot link statically against it. This could be solved by recompiling OpenSSL ourselves. - MIT kerberos does not support static linking; vaguely discussed how to allow it in 2006, but no progress since then: http://krbdev.mit.edu/rt/Ticket/Display.html?id=3838 That's not something we'll solve simply by recompiling MIT krb5... So, to me it looks like we'll switch to dynamic linking against libpq and shipping the DLL/SO/DYLIB on the platforms/cases that need it. Any platform where this will be harder than what I presume? As an added bonus, this makes it easier for our users to upgrade the libraries we link against (for bugfixes or new features in new versions or ...): just overwrite the DLL/SO/DYLIB file with an upstream-provided one (downloaded from http://www.postgresql.org). What I'm not totally clear about is how we will generate the list of libraries to bundle. I could imagine recursing through the DT_NEEDED fields of the .so files (and the equivalent of that on other platforms), and stopping when hitting a known "system library" (such as libc, libresolv, etc); I imagine this exact same problem must have been solved already elsewhere in LibreOffice and we have a dmake/make recipe we can apply / reuse? Or is it not so? This also means that by our "we have to build everything we ship" rule, we have to internalise, according to my first quick survey: - OpenSSL: I expect all platforms. It is a system lib on most GNU/Linux distributions, but the soname is not stable. - MIT Kerberos: * MacOS X bundles Kerberos since 10.2, which AFAIK is behind our baseline of 10.4; is it binary-compatible across releases? Then we can consider it a system library on MacOS X and not internalise / ship it. * GNU/Linux: What's our baseline there? Has the soname changed since our baseline? Is the soname consistent across distributions? If no&yes, then system lib and don't ship it. Debian seems to have a stable soname since woody (released 19 July 2002), so I expect this will be OK. If we have to internalise it, it depends on: ° libcom_err: built from e2fsprogs sources on my Debian, soname libcom_err.so.2. Google tells me (some?) RPM distributions have a libcom_err.so.3 that is shipped by the MIT Kerberos RPM itself. - Kerberos for Windows: that's not part of the OS -> internalise (http://web.mit.edu/kerberos/dist/index.html#kfw-3.2) - LDAP: We already have OpenLDAP-related stuff in configure.in... So can postgresql-sdbc just use that, or is the existing stuff "too optional"? I mean it seems to be replacing some Mozilla parts, not sure we enable it on our builds or if it just a service to distribution
Re: [Libreoffice] [Libreoffice-qa] Call for LO-3.5.0-beta1 pre-tag testing
2011/12/11 Fridrich Strba : > On 10/12/11 07:34, Petr Mladek wrote: >> >> The 64-bit build for few localizations is being uploaded at >> >> http://dev-builds.libreoffice.org/daily/Linux_x86_64_Release_Configuration/libreoffice-3-5/ >> >> It is built the same way like the 32-bit build, see above. We started >> the regular tinderbox again. >> >> Please, do not get confused that the two Linux builds has the version >> beta0 in the name a no time, ... They were uploaded manually. The builds >> produced by tinderbox will have the right names for dailies again. > > > I have produced the "release like" Windows build too. It is currently > landing at > http://dev-builds.libreoffice.org/daily/Windows_Release_Configuration/libreoffice-3-5/ > It is a result of a checkout from Friday night and it should contain the new > postgresql connector. Would be thus nice to test whether it works. In case > you have a pgsql server to connect to. > > Some packaging issues with our libreoffice-3-5 branch: > 1) Although we produce a LibreOffice_Dev target, the resulting download > packages/msi installer don't have the "Dev" in its name. > 2) I produced an SDK installer (not uploaded though) and it has no mention > of "SDK" in the name either. That is the reason I did not upload it because > it would just confuse people. I fixed both issues with d75885f5190ef3bc12932db281af4ac74f7a0616 in libreoffice-3-5 branch (and in master, too). Script expected "LibO-dev" and it received "LOdev". BTW there are at least two methods implemented for download name creation, it is a bit confusing. :) Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Question about VersionInfo resource of Windows executables
2011/12/11 Andras Timar : > Before I pushed my patch (3fbedc3e8f65c91999dcee42daa8312e387dcf40) I > build from scratch with MSVC successfully. However, I learned a few > hours later that I broke MinGW build. > http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1323606001.25653#21811 > I found it strange, because 1) I didn't see any problems at line 38 in > shlinfo.rc; 2) under MSVC no resource was built for ucbhelper. I think > this is related to the general question I asked above. So, I installed my first MinGW build (it's a shame that I didn't try before ;)) and I fixed this build breaker with f129c4f766c30b174544ec234cbd72c7050a2fc1. Interestingly the .res file is built but it is not linked to the dll, so my original question is still valid. A gbuild expert should take a look at the problem. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Mihkel Tõnnov changed: What|Removed |Added Depends on||41996 --- Comment #237 from Mihkel Tõnnov 2011-12-11 13:14:33 PST --- Nominating Bug 41996 - Can't move slides in slide sorter. Quite annoying. (Seems to not affect everyone, though.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On 11/12/11 15:17, Lionel Elie Mamane wrote: Which suggests --without-system-postgresql is broken, need to check that out. Works, at least on Debian GNU/Linux. Does it mean that the --without-system-postgresql is working now? If not, first thing to check (on other platforms then x86 would be whether the static library is built with PIC. Since it needs to end in a shared object, that might be necessary. Cheers F. -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On 09/12/11 23:10, Thorsten Behrens wrote: And with attached patch, also a plain --enable-ext-postgresql-sdbc builds - Norbert, want to double-check& commit? Sorry, I added that all-static-lib to the target unconditionally, since that is not harming anything. I did not read this e-mail. I would otherwise give you the credits for it. Cheers F. -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)
On Sun, 11 Dec 2011 17:41:22 +0100, Rainer Bielefeld wrote: Tommy schrieb: probably the code in 3.5.x has been cleaned and there's no place for the classic theme yet, but just for the other themes (Tango, Galaxy etc. etc.) Hi, And what's your theory concerning the fact that (at least) tango theme copied from 3.4 to master will not work, too? CU Rainer Hi Reiner, as far as I know, LibO 3.3.x had 6 available themes: Galaxy, Tango, Crystal, Hi-Contrast, Oxygen, Classic the themes were extensively reworked in 3.4.x in order to get rid of duplicate icons. during this process the devs decided to remove the Classic theme, leaving the other 5: Galaxy, Tango, Crystal, Hi-Contrast, Oxygen as I told before something in the code about the Classic theme remained somewhere and allowed us to re-introduce the Classic after reformatting it to be compatible with 3.4.x. Indeed if you use the zipped file from the 3.3.x release you will suffer inconsistencies regarding 3.5 master I'm sorry I can't help... I have never installed that release... so please, try to better explain what's the issue about the Tango theme from 3.4.x ... isn't the Tango theme already available in 3.5 master? did the devs remove it in master as they did in 3.4.x with Classic? have the existing icon themes been reworked again in 3.5? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On Sat, Dec 10, 2011 at 01:53:20AM +0200, Tor Lillqvist wrote: >> Stephan Bergmann wrote: libpq.5.dylib (compatibility version 5.0.0, current version 5.3.0) >>> That way it won't be found at runtime. If it is a lib from the >>> system, it should have an absolute path (like the ones below), if >>> it is part of LO it should be referenced relatively via >>> @loader_path (like the ones above). >> Well, as a system lib I understand it can be installed nearly anywhere > Er... huh? Isn't the very definition of a system library one that is > installed in a fixed known location, as part of the operating > system? With that definition of a "system library", libpq is neither a "lib from the system", nor "part of LO". -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] "random" build failures in sfx2/sdi/sfxitems.sdi
On Sun, Dec 11, 2011 at 05:48:54PM +0100, Christian Lohmaier wrote: > On Sun, Dec 11, 2011 at 10:58 AM, lio...@mamane.lu wrote: >> There seems to be a failure in sfx2/sdi/sfxitems.sdi >> (see attachment and >> http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1323593401.28011#err677 > Any reason why you are using the huge full-log instead of the brief log? > http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1323593401.28011#err677 I thought the brief log was the same as the contents of the "email to committers" and I couldn't make sense of that. That's why I went to http://tinderbox.l.o in the first place. >> BTW, it took about 20 minutes for the full log to arrive at >> http://tinderbox.libreoffice.org/MASTER/status.html; any reason for >> such a significant delay? > The cronjob that regenerates the page Ah, it is a cronjob, I see. > is only run every 15 minutes or so. I don't consider it a > "significant delay" when a build takes 2½-3 hours... >From the POV of a committer that gets the "you broke the build" mail and would like to investigate it, it can feel long (it did for me). Besides, a build takes 2.5-3 hours is not true: Linux-Gentoo-x86_64_2-no-moz_no-binfilter had several successful builds in 17-18 minutes. MacOSX-Intel_1-built_no-moz_on_10.6.8: several at 18-19 minutes, but then an outlier at 105 minutes. In general *failed* builds can be _much_ shorter than successful builds if the error is early... And failed builds is the logs you want to see :) The tinderbox I was interested in (Linux-x86-64_8-SLED11) has a rather high variability in build time: 25, 33, 145, 41, 32, 37, 26, 154, 183, 96, 88, 100, 45, 102, 22, 137, ... -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] "random" build failures in sfx2/sdi/sfxitems.sdi
Hi Lionel, *, On Sun, Dec 11, 2011 at 10:58 AM, lio...@mamane.lu wrote: > > There seems to be a failure in sfx2/sdi/sfxitems.sdi > (see attachment and > http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1323593401.28011#err677 Any reason why you are using the huge full-log instead of the brief log? http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1323593401.28011#err677 > BTW, it took about 20 minutes for the full log to arrive at > http://tinderbox.libreoffice.org/MASTER/status.html; any reason for > such a significant delay? The cronjob that regenerates the page is only run every 15 minutes or so. I don't consider it a "significant delay" when a build takes 2½-3 hours... ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)
Tommy schrieb: probably the code in 3.5.x has been cleaned and there's no place for the classic theme yet, but just for the other themes (Tango, Galaxy etc. etc.) Hi, And what's your theory concerning the fact that (at least) tango theme copied from 3.4 to master will not work, too? CU Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)
On Sun, 11 Dec 2011 15:39:08 +0100, Korrawit Pruegsanusak wrote: Hello all, /me separate this into new thread. :) On Sun, Dec 11, 2011 at 11:47, Korrawit Pruegsanusak wrote: So, do we really support classic and industrial themes? I've found them listed on ooo_custom_images [1], but I'm not sure if it's relevant. [1] http://opengrok.libreoffice.org/xref/core/ooo_custom_images/ [cut] additional infos about this on the bugtracker: https://bugs.freedesktop.org/show_bug.cgi?id=38175 basically, the Classic theme was removed in LibO 3.4.0 but you can manually enable it again downloading a 3.4.x compliant theme ( images_classic.zip ) from the issue tracker and copying it the proper location: \Bin\LibreOffice 3\Basis\share\config (in Windows, don't know if it's the same in Linux and Mac) this works in 3.4.x but doesn't work on 3.5 master my guess is that in LibO 3.4.x the devs just removed physically the images_classic.zip file but the software still has some code somewhere pointing towards that file. indeed if you put a images_classic.zip file under 3.4.x you can enable the classic theme. however if you rename the images_classic.zip with something else (i.e. images_dummy.zip) LibO 3.4.x fails to recognize that theme. probably the code in 3.5.x has been cleaned and there's no place for the classic theme yet, but just for the other themes (Tango, Galaxy etc. etc.) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)
Hello all, /me separate this into new thread. :) On Sun, Dec 11, 2011 at 11:47, Korrawit Pruegsanusak wrote: > Last but not least, I've noticed that there are two themes, classic > and industrial, that described in AS_HELP_STRING (see context in first > patch) but not detected while checking (see context in second patch). > That is, if user pass e.g. --with-theme=classic, it'll fail. So, do we > really support classic and industrial themes? I've found them listed > on ooo_custom_images [1], but I'm not sure if it's relevant. > > [1] http://opengrok.libreoffice.org/xref/core/ooo_custom_images/ I've tried to build [2] on cygwin regarding this, adding "classic" and "industrial" into configure.in [3], and result as follows: --with-theme="classic industrial" - no icons at all, no checkboxes, no theme names in "Tools > Options > View > Icon size and style" (has only "Automatic"). Anyway, overall is somewhat usable, but looks very ugly. --with-theme="default classic industrial" - it opens with default theme, overall was as expected, but has only "Galaxy (default)" in theme option. --with-theme="default hicontrast oxygen classic industrial" - like second one, three theme options, and also none of "classic" nor "industrial". Maybe a clean build needed? I'm on cygwin, so I wouldn't like `make clean` much ;) or maybe configure options related? (I don't think so) [2] incremental build after success build at faa285f2679c842b641ca721141218d826bf7ab7 (Dec 2, 2011) [3] diff as follows: diff --git a/configure.in b/configure.in index f8aed0e..132e022 100644 --- a/configure.in +++ b/configure.in @@ -8034,7 +8034,7 @@ fi WITH_THEMES="" for theme in $with_theme; do case $theme in -default|crystal|hicontrast|oxygen|tango) : ;; +default|crystal|hicontrast|oxygen|tango|classic|industrial) : ;; *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;; esac WITH_THEMES="$WITH_THEMES $theme" Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] End of the line for 3.3 family and regressions
On Fri, 09 Dec 2011 21:34:34 +0100, Pedro Lino wrote: I think this carries (from a QA point of vue) a much heavier responsibility and care than the change from 3.4.4 to 3.5.0 (which is "experimental") The planned release date for 3.4.5 is on January 11, 2012 and apparently there won't be any Beta releases, it will jump directly to RC1. I urge everybody to make sure that EVERY regression detected from 3.3.x to 3.4.x is fixed/added to the 3.4 branch +1. LibO 3.4.5 will be the last release of the 3.4.x branch since there will be no 3.4.6, the bugfixing should be handled with care maybe a 2 more testing weeks before release (planned date jan 11) would help ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On Sun, Dec 11, 2011 at 03:09:41PM +0100, Lionel Elie Mamane wrote: > Which suggests --without-system-postgresql is broken, need to check > that out. Works, at least on Debian GNU/Linux. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Question about VersionInfo resource of Windows executables
Hi, I was hacking on VersionInfo resource of Windows executables and I noticed that DLLs built with dmake always have this resource, they include solenv/inc/shlinfo.rc. But DLLs built with gmake does not have VersionInfo resource by default. Is this normal? Executables are fully functional without VersionInfo resource, but I think it is useful to have it, because it contains file version, copyright notice etc. I would like to ask, if it is by design, or if it is an undesired omission. Before I pushed my patch (3fbedc3e8f65c91999dcee42daa8312e387dcf40) I build from scratch with MSVC successfully. However, I learned a few hours later that I broke MinGW build. http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1323606001.25653#21811 I found it strange, because 1) I didn't see any problems at line 38 in shlinfo.rc; 2) under MSVC no resource was built for ucbhelper. I think this is related to the general question I asked above. Could you please check this. Eventually I wanted to cherry-pick 3fbedc3e8f65c91999dcee42daa8312e387dcf40 to libreoffice-3-5, because it improves VersionInfo a lot (especially regarding branding and file version data). Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On Sat, Dec 10, 2011 at 11:05:02AM +0100, Alexander Thurgood wrote:
> Le 09/12/11 23:10, Thorsten Behrens a écrit :
>> And with attached patch, also a plain --enable-ext-postgresql-sdbc
>> builds - Norbert, want to double-check & commit?
> So I built yesterday using :
> --with-ext-postgresql-sdbc
> --with-system-postgresql
> If I install this connector.oxt on another machine with MacOSX and a
> running pg instance, when I try to connect I get the following error :
> A driver is not registered for the URL
> sdbc:posgresql:dbhost=localhost dbname=demo
I got a similar error on my Debian GNU/Linux, solved by:
cd /libo/build/tree
rm -r solver/INPATH/installation/opt/share/extensions/postgresql-sdbc/
solver/INPATH/inc/postgresql/ solver/INPATH/lib/libpq.*
connectivity/INPATH/lib/postgresql-sdbc*.{so,dylib,dll}
#build && deliver in connectivity
#forcefully install newly generated .oxt file
cd ~/.config/libreoffice/3/user/extensions/*/extensions.db
Replace INPATH by its value on your platform (something like
"unxmaci"); ~/.config/libreoffice/ is LibreOffice's user profile
directory on Unix, I'm not sure what it is on MacOS X.
Basically, the --with-system-postgresql build was still linking
statically against the libpq.a in the solver, so essentially was
behaving as a --without-system-postgresql :-| Which suggests
--without-system-postgresql is broken, need to check that out.
> Does your patch fix this problem of portability, i.e. from build
> machine to user machine ?
I don't think so, we need to work on that. In the current situation,
*maybe* if the user machine also install libpq (postgresql C client
library) at the _same_ location than on the build machine, it might
work, I'm not even sure of that. Given the multiplicity of ways to
install libpq on MacOS X, we don't want to require that, but I'm not
sure how to fix that cleanly. I'm waiting for a LibO/MacOS X dev to
chip in on that.
> I'm just trying to suss out the implications for me as the provider
> of the db connector extensions.
For MacOS X, we are still in the "getting it to work" stage.. We need
your testing for that, thanks for sticking around.
--
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote
On Sun, Dec 11, 2011 at 05:18:36PM +0700, Korrawit Pruegsanusak wrote: > On Sun, Dec 11, 2011 at 14:28, Lionel Elie Mamane wrote: >> Well, IMHO the example is correct _with_ quotation marks, else the >> shell will cut it into several arguments. >> [cut] >> On which platform have you encountered the "it breaks with quotation >> marks, but works without quotation marks" behaviour you mention? > If I run > $ ./autogen.sh --with-some-arguments-here > it should be _with_ quote. > But if I edit autogen.lastrun and just run > $ ./autogen.sh > without any argument, it will read from autogen.lastrun, and it should > be _without_ quote. Yes, this smells right, for all platforms. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Commits in connectivity/inc connectivity/source dbaccess/source
On Sun, Oct 30, 2011 at 06:21:52PM +, Alex Thurgood wrote: > The stuff you just committed looks interesting, Thanks :) -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Does merge modules necessary only for msi installer?
Hello Fridrich, all, On Sun, Dec 11, 2011 at 12:54, Fridrich Strba wrote: > No, not needed to check anything. If you have a compiler, you have them. > They are part of the compiler installation. Thanks, I check my installation and I just didn't install the merge module. Sorry for the noise anyway. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote
Hello Lionel, On Sun, Dec 11, 2011 at 14:28, Lionel Elie Mamane wrote: > Well, IMHO the example is correct _with_ quotation marks, else the > shell will cut it into several arguments. > [cut] > On which platform have you encountered the "it breaks with quotation > marks, but works without quotation marks" behaviour you mention? Aha! Now I know why it fails on me. If I run $ ./autogen.sh --with-some-arguments-here it should be _with_ quote. But if I edit autogen.lastrun and just run $ ./autogen.sh without any argument, it will read from autogen.lastrun, and it should be _without_ quote. I'm on cygwin, but I think this applies to other platform as well ... >> Second patch is just a trivial change: --with-theme is without "s". > > Yes, applied this one. Thanks! Thanks! Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SDK example cherry pick ?
On Sun, Dec 11, 2011 at 09:33:15AM +0100, Laurent Godard wrote: > do you think it would be possible to cherry-pick these SDK example > commits to 3.5. I see no potential negative impact As a general idea, it looks good, but personally I miss the background to evaluate the CSS bits, so I'll leave the cherry-pick to someone else. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] "random" build failures in sfx2/sdi/sfxitems.sdi
Hi, Just to make sure someone that knows that part of the code gets a notice (rather than only unrelated people): There seems to be a failure in sfx2/sdi/sfxitems.sdi (see attachment and http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1323593401.28011#err677 ) which is unrelated to the commits since last success, so maybe a race condition in a parallel build or something like that? BTW, it took about 20 minutes for the full log to arrive at http://tinderbox.libreoffice.org/MASTER/status.html; any reason for such a significant delay? -- Lionel --- Begin Message --- Hi folks, One of you broke the build of LibreOffice with your commit :-( Please commit and push a fix ASAP! Full log available at http://tinderbox.libreoffice.org/MASTER/status.html Tinderbox info: Box name: Linux-x86-64@8-SLED11 Machine: Linux ben 2.6.32.12-0.7-default #1 SMP 2010-05-20 11:14:20 +0200 x86_64 x86_64 x86_64 GNU/Linux Configured with: CC=ccache gcc CXX=ccache g++ --with-num-cpus=4 --with-max-jobs=15 --without-junit --disable-dependency-tracking --enable-binfilter Commits since the last success: core 95a0d27 typo, trailing whitespace cleanup fc0f061 minor around python and SDK binfilter dictionaries help The error is: build failed - error is:: log for /local/home/tinderbox/master/sfx2/prj [ info ALL ] LinkTarget Library/libxml2.so not defined: Assuming headers to be there! [ build DEP ] SRS:sfx/res [ build SDI ] sfx2/sdi/sfxslots /local/home/tinderbox/master/sfx2/sdi/sfxitems.sdi --- error: ( 86, 11 ) may be > at ( 86, 11 ) /local/home/tinderbox/master/sfx2/sdi/sfxitems.sdi --- error: ( 86, 11 ) may be at ( 86, 11 ) /local/home/tinderbox/master/sfx2/sdi/sfxslots.sdi --- error: ( 38, 5 ) svidl terminated with errors [ build PKG ] sfx2_inc [ build PKG ] sfx2_sdi make[2]: *** No rule to make target `/local/home/tinderbox/master/workdir/unxlngx6.pro/SdiTarget/sfx2/sdi/sfxslots', needed by `/local/home/tinderbox/master/workdir/unxlngx6.pro/Headers/Library/libsfxlo.so'. Stop. make[2]: *** Waiting for unfinished jobs dmake: Error code 2, while making 'all' == ERROR: error 65280 occurred while making /local/home/tinderbox/master/sfx2/prj --- End Message --- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SDK example cherry pick ? was Re: [PUSHED] update [PATCH]cosmetic around SDK and python
Hi Lionel thanks a lot do you think it would be possible to cherry-pick these SDK example commits to 3.5. I see no potential negative impact Then, one could put the exemple section online on http://api.libreoffice.org ? the related commits are http://cgit.freedesktop.org/libreoffice/core/commit/?id=07249785a76c356f49540c779d66d65973ed85cc http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac579e29ad046d74331b9066f79f7caa59e2714b http://cgit.freedesktop.org/libreoffice/core/commit/?id=fc0f0610fe42f4e52391cbe61277bcd97f1e8df6 http://cgit.freedesktop.org/libreoffice/core/patch/?id=95a0d27887934ab60af321ce83655238a29df981 Thanks again Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
