Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Rainer Bielefeld

Bjoern Michaelsen schrieb:


here is an urgent request for comments. We still have ~2400 bugs in state NEW


Hi Bjoern,

of course I see the problem, but I have absolutely no problem with that 
fact, because I use a query basing on my experience. You find it here:


The hit quote for bugs needing "maintenance" is neaby 100% vor me.


So here is my proposal: I want to batch change all those old unconfirmed bugs
(without the now obsolete CONFIRMED in whiteboard status) to state NEEDINFO.


If you want to do the bulk change, you should avoid to change hundreds 
of "Really NEW" old bugs to NEEDINFO.


I recommend only to modify bugs what are NEW and fulfill some additional 
criteria (no user with QA-Experience is involved), what leads to this query:



I also added the query link under
 "And this Query 
only shows ..." because mail clients might break that long link.


It's intended that no developers are included because mostly they only 
contribute some useful information, but will not continue "maintenance" 
for those bugs.


And -  may be you will get some indignant comments because of Bugs 
30876, 31022, 31055, 33232  ;-)


Please involve libreoffice...@lists.freedesktop.org into such discussions!

Best regards

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Tor Lillqvist
And +1 from me.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] 让你的产品满地飞!相当于20个业务员的营销能力!(AD)libreoffice@lists.freedesktop.org

2011-12-22 Thread Ubkl






 
libreoffice@lists.freedesktop.org
电话接不停,一定有可能!
精准9邮1件7推6广,相当于20个业务员。
5wJwEwB.4830l630O1n020V09.5ccofmM
(网址不能复制,只能人工输入到浏览器地址栏哦)
QQ:8131H4M312c5Q8O9j8892





20111222183941
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild circular dependencies

2011-12-22 Thread Matúš Kukan
On 23 December 2011 00:42, Peter Foley  wrote:
>
> Hi,
>
> While converting connectivity to gbuild I seem to have created some
> circular dependencies.
>
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libsdbc2lo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libdbpool2lo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libcalclo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbcbaselo.so
>  dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbclo.so
>  dependency dropped.
>
> I haven't been able to figure out what is causing these.
> I've pushed my WIP conversion to feature/gbuild_conversions and would 
> appreciate it if someone took a look.
>
Well, I also don't know why there are circular dependencies but I had
similar issues.
You can try to remove
$(eval $(call gb_Library_add_package_headers,$lib,connectivity_inc))
from makefiles for lib in sdbc2, dbpool2, calc, odbcbase, odbcl;
The dependency stays there indirectly because they all link against dbtools.

It will help.

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] gbuild circular dependencies

2011-12-22 Thread Peter Foley
On Thu, 22 Dec 2011, Peter Foley wrote:

> 
> Hi,
> 
> While converting connectivity to gbuild I seem to have created some
> circular dependencies.
> 
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libsdbc2lo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libdbpool2lo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libcalclo.so
>  <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
> dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbcbaselo.so
>  dependency dropped.
> make[1]: Circular 
> /home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
> /home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbclo.so
>  dependency dropped.
> 
> I haven't been able to figure out what is causing these.
> I've pushed my WIP conversion to feature/gbuild_conversions and would 
> appreciate it if someone took a look.

Nevermind, I figured out the problem.

Thanks,

Peter
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Remove SC_DLLPUBLIC to fix build on msvc 2008

2011-12-22 Thread Matúš Kukan
On 22 December 2011 15:53, Korrawit Pruegsanusak
 wrote:
> [ build MOD ] hwpfilter
> R=/cygdrive/d && S=$R/libo && O=$S/solver/wntmsci12.pro &&
> W=$S/workdir/wntmsci12.pro &&  mkdir -p $W/Module/ && touch
> $W/Module/hwpfilter
> D:/libo/solenv/gbuild/StaticLibrary.mk:49: *** gb_Deliver_deliver:
> file does not exist in solver, and cannot be delivered:
> /cygdrive/d/libo/solver/wntmsci12.pro/lib/iexttextcat.lib.  Stop.

Hmm, strange.. it fails in hwpfilter ? There is no StaticLibrary.
I could understand if it were Library_guesslang from lingucomponent..

I wonder if you are the first one trying to build on windows with
internal libexttextcat after
f9fc46c1ef035516287d09ddca86e1668a79c701 ..

> Seems it doesn't found iexttextcat.lib, which I try finding it in
> libexttextcat\wntmsci12.pro\lib\ and found only ilibexttextcat.lib and
> ilibexttextcat.exp. I tried clean build in both hwpfilter and
> libexttextcat but no avail. Maybe do I need to make clean in
> tail_build? (I don't like this, because it's very time-consuming) or
> git pull -r again?

Well, you can try attached patch. Just run make in tail_build, no need
for clean.
I will test tomorrow for MinGW, if it works we can push..
But I'm a little confused.

Matus
From 60d11a0fe90041afd28d4a8a447a8b89c7c148a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?= 
Date: Fri, 23 Dec 2011 01:16:38 +0100
Subject: [PATCH] Repository: fix Windows name for internal libexttextcat

---
 RepositoryExternal.mk |4 ++--
 RepositoryFixes.mk|2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 11896cd..6b9ebc0 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -224,7 +224,7 @@ else # !SYSTEM_LIBEXTTEXTCAT
 
 ifeq ($(OS),WNT)
 $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO,\
-	exttextcat \
+	libexttextcat \
 ))
 else
 $(eval $(call gb_Helper_register_static_libraries,PLAINLIBS,\
@@ -235,7 +235,7 @@ endif
 define gb_LinkTarget__use_libexttextcat
 ifeq ($(OS),WNT)
 $(call gb_LinkTarget_add_linked_libs,$(1),\
-	exttextcat \
+	libexttextcat \
 )
 else
 $(call gb_LinkTarget_add_linked_static_libs,$(1),\
diff --git a/RepositoryFixes.mk b/RepositoryFixes.mk
index ff1eb34..ac349ea 100644
--- a/RepositoryFixes.mk
+++ b/RepositoryFixes.mk
@@ -56,7 +56,6 @@ gb_Library_DLLFILENAMES := $(patsubst ucpfile:libucpfile%,ucpfile:libucpfile1%,$
 gb_Library_DLLFILENAMES := $(patsubst unsafe_uno:unsafe_uno%,unsafe_uno:unsafe_uno_uno%,$(gb_Library_DLLFILENAMES))
 gb_Library_DLLFILENAMES := $(patsubst z:z%,z:zlib%,$(gb_Library_DLLFILENAMES))
 
-gb_Library_FILENAMES := $(patsubst exttextcat:libexttextcat%,exttextcat:libilibexttextcat%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst sb:isb%,sb:basic%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst sfx:isfx%,sfx:sfx%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst svt:isvt%,svt:svtool%,$(gb_Library_FILENAMES))
@@ -68,6 +67,7 @@ gb_StaticLibrary_FILENAMES := $(patsubst graphite:graphite%,graphite:graphite_dl
 ifeq ($(COM),GCC)
 gb_Library_FILENAMES := $(patsubst crypto:icrypto%,crypto:crypto%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst graphite2_off:%.dll.a,graphite2_off:%.a,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst exttextcat:liblibext%,exttextcat:libilibext%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst rdf:irdf%,rdf:librdf.dll$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst ssl:issl%,ssl:ssl%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst xml2:ixml2%,xml2:libxml2$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Bjoern Michaelsen
On Fri, Dec 23, 2011 at 12:40:28AM +0100, Michael Stahl wrote:
> > Sigh, we had branched off 3-4-5 meanwhile, which needs 3 reviews -
> > Michael, Petr, would you want to approve the revert?
> if it really needs that, +1 from me
+1 from me
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] gbuild circular dependencies

2011-12-22 Thread Peter Foley

Hi,

While converting connectivity to gbuild I seem to have created some
circular dependencies.

make[1]: Circular 
/home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libsdbc2lo.so
 <- 
/home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
dependency dropped.
make[1]: Circular 
/home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libdbpool2lo.so
 <- 
/home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
dependency dropped.
make[1]: Circular 
/home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libcalclo.so
 <- 
/home/peter/libreoffice/workdir/unxlngx6.pro/Headers/Library/libdbtoolslo.so 
dependency dropped.
make[1]: Circular 
/home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
/home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbcbaselo.so
 dependency dropped.
make[1]: Circular 
/home/peter/libreoffice/workdir/unxlngx6.pro/Package/connectivity_inc <- 
/home/peter/libreoffice/workdir/unxlngx6.pro/ExternalHeaders/Library/libodbclo.so
 dependency dropped.

I haven't been able to figure out what is causing these.
I've pushed my WIP conversion to feature/gbuild_conversions and would 
appreciate it if someone took a look.

Thanks,

Peter

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Michael Stahl
On 23/12/11 00:29, Thorsten Behrens wrote:
>>> Michael Meeks wrote:
 can't we just revert the original fix there ?

>>>
>> Reverted with Stephan's review in -3-4.
>>
> Sigh, we had branched off 3-4-5 meanwhile, which needs 3 reviews -
> Michael, Petr, would you want to approve the revert?

i'd say reverting a patch that has demonstrably introduced a regression
shouldn't need 3 reviews.

if it really needs that, +1 from me


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency

2011-12-22 Thread Thorsten Behrens
> > Michael Meeks wrote:
> > > can't we just revert the original fix there ?
> > >
> >
> Reverted with Stephan's review in -3-4.
> 
Sigh, we had branched off 3-4-5 meanwhile, which needs 3 reviews -
Michael, Petr, would you want to approve the revert?

Thanks,

-- Thorsten


pgpNmCCgWUuIa.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 39799, which changed state.

Bug 39799 Summary: CRASH when insert SVG image while EDITING
https://bugs.freedesktop.org/show_bug.cgi?id=39799

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Thorsten Behrens
Niko Rönkkö wrote:
> Shouldn't it be 3.5.0 Beta 2 and not Beta 1?
> 
Yep, though in theory, Beta2 could be a disaster & we don't publish
it (not likely). Plan was I think to wait for feedback on the
pre-release builds & then adapt the messaging ...

Cheers,

-- Thorsten


pgpzDsIG5aG6Z.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Cor Nouws

Hi Niko,

Niko Rönkkö wrote (23-12-11 00:03)


Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1


Shouldn't it be 3.5.0 Beta 2 and not Beta 1?


Both are fine.
I guess the beta 2 will be available when we have the bug-hunting 
session. But testing right now, can be done on beta 1..


( Please note that the ".-1" in the wiki link is referring to the fact 
that there will be a ".-2" bug-hunting event, expected to be done with 
RC1 :-)  )


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Thorsten Behrens
Bjoern Michaelsen wrote:
> So here is my proposal: I want to batch change all those old unconfirmed bugs
> (without the now obsolete CONFIRMED in whiteboard status) to state NEEDINFO.
>
Sounds very worthwhile. Go for it! :)

Cheers,

-- Thorsten


pgpJDdVD4dPvs.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [REVIEW] invalid ODF fdo#37390 fdo#44073 fdo#44082

2011-12-22 Thread Michael Stahl

proposing the following commits for 3.4.5, as they prevent LO from
writing invalid ODF:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1e1ef80e8428514499b061e00801a6a6298d0b0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=59a5c37d0df9b5612552c4b749191385ca0adc80

with the fix for fdo#44073 LO actually still writes a non-standard
attribute in ODF 1.2 extended mode, but without doing that older OOo/LO
versions would lose data because they don't recognize the standard
attribute that LO writes with the fix.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2011-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 43837, which changed state.

Bug 43837 Summary: SLIDESHOW CRASH on custom animation of particular objects
https://bugs.freedesktop.org/show_bug.cgi?id=43837

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Niko Rönkkö

On 22.12.2011 22.33, Bjoern Michaelsen wrote:

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 prerelease.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1


Shouldn't it be 3.5.0 Beta 2 and not Beta 1?

--
RN
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Remove options "Show preview of fonts" and "Show font history"

2011-12-22 Thread Cor Nouws

Hi Pedro,

Pedro wrote (22-12-11 21:53)

I'm not a Dev or UX, but what is the point of removing Options?

If the Option is already there and it works correctly, why remove
it?

Why limit the user's choice?


Well, my oldest joke with OpenOffice.org is, that people always complain 
about the huge amount of config options, yet at many changed features, 
new config options were added. (Same must have happened over here by the 
way.)


Now some guys are brave enough to remove options, that apparently are 
not necessary any more.

(And sometimes find me 'in their way' complaining ;-) )

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] [PATCH] [RFC] COMPRESSMODE_FULL

2011-12-22 Thread Matteo Casalin

Hi Thorsten,
just and after-thought: some of the cleaned-up I/Os regard 
variables of type "long" (Pair, Rectangle...). I was afraid this could 
be platform dependent, but it seems that SvStream casts them to int 
"if(SAL_TYPES_SIZEOFLONG != 4)". The question then becomes: do that data 
really need to be of type long? Rectangle, for example, are widely used, 
and type long doubles their size in 64-bit machines.


On 12/19/2011 10:01 PM, Thorsten Behrens wrote:

Matteo Casalin wrote:

Here are the patches for *completely* removing COMPRESSMODE_FULL
support.


Applied as-is, good work - and the identical commit msg are a
feature, not a bug. Good riddance hand-rolled compression code.
:)

What are you up for next?


I plan to fix some issues I noticed in ValueSet handling (color 
selection in option dialog). I also would like to reduce memory 
footprint of that code (e.g. ValueSetItem: use a union instead of 
allocating multiple data types which are handled in a mutually exclusive 
way. I think that a template with specializations would be overkill in 
this case, but any suggestion regarding this is really welcome: maybe 
unions are not appreciated).


Ciao
Matteo


Cheers,

-- Thorsten



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Tommy
On Thu, 22 Dec 2011 21:33:44 +0100, Bjoern Michaelsen  
 wrote:



Thus, if nobody vetos this, I would do that tommorrow in ~500 bug
batches.

Objections? Vetos? Comments?

Best,

Bjoern




A dirty job but somebody has to do it...
go ahead!!!  :-)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Remove options "Show preview of fonts" and "Show font history"

2011-12-22 Thread Pedro
I'm not a Dev or UX, but what is the point of removing Options?

If the Option is already there and it works correctly, why remove it?

Why limit the user's choice?

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-Remove-options-Show-preview-of-fonts-and-Show-font-history-tp3607488p3607514.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] RFC Operation Spamzilla

2011-12-22 Thread Bjoern Michaelsen
Hi all,

here is an urgent request for comments. We still have ~2400 bugs in state NEW
from the pre-Bugzilla 4.0 days. Back then we had no initial state UNCONFIRMED,
so unfortunately they started with NEW. This is changed now for new bugs, but
the old ones are still in state NEW because we did not want to spam the
subscribers of 2400 bugs just by changing those bugs. This leaves us in the
unfortunate situation to having to check dates etc. to see what the status
really means, which is really bad.

So here is my proposal: I want to batch change all those old unconfirmed bugs
(without the now obsolete CONFIRMED in whiteboard status) to state NEEDINFO.
We can then be sure that a bug in state NEW is actually confirmed. This is
urgent, because I think we have a good opportunity right now.
I want to do the bulk change with this comment:

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 prerelease.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

By doing this, we would:
 a) get our bug data consistent (all NEW bug would have basic confirmation)
 b) lure a lot more people into participating in the beta1 bug hunt
 c) do so without spamming a lot of people in vain.
 d) could get rid of the confusing UNCONFIRMED,CONFIRMED tags in whiteboard 
status

To be effective for the bug hunting session this would have to be done rather
fast. Thus, if nobody vetos this, I would do that tommorrow in ~500 bug
batches.

Objections? Vetos? Comments?

Best,

Bjoern

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Broken patch] Frame dialogue, try to draw the preview at its original size

2011-12-22 Thread Stefan Knorr (Astron)
Hi,

I was the person who removed the dog preview from Writer's Picture
dialogue. In it's place there is now a nice alpine landscape (that I
nabbed from the Writer icon, but whatever). Sadly, it's stretched
larger than its original size which leads to pixelation. This is a
condition I wanted to remedy before closing fdo#43976.
So, I wrote a patch, everything looks fine, but the preview image
can't be mirrored any more (or is maybe drawn mirrored somewhere it
can't be seen). Attaching this patch might be a bit embarrassing, but
I hope people here recognise that I am not really a programmer. Hints
very much appreciated.

Regards,

Astron.

(I know I could probably unify nWidth and nHeight to a const Size...
but I wanted to leave that for later...)
From 3c4321fc9477904f92eb2be70397deac0aee67d8 Mon Sep 17 00:00:00 2001
From: "Stefan Knorr (astron)" 
Date: Mon, 19 Dec 2011 12:37:59 +0100
Subject: [PATCH] FRMDLG: Try to draw replacement preview at original size

---
 sw/source/ui/frmdlg/frmpage.cxx |   14 +++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 288141b..0d6bf7c 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -224,7 +224,7 @@ static FrmMap aHFlyHtmlMap[] =
 {SwFPos::FROMLEFT,  SwFPos::MIR_FROMLEFT,   text::HoriOrientation::NONE,  LB_FLY_REL_PG_FRAME}
 };
 
-// own vertical alignment map for to frame anchored objects
+// own vertical alignment map for objects anchored to frame
 #define VERT_FRAME_REL   (LB_FLY_VERT_FRAME|LB_FLY_VERT_PRTAREA)
 
 static FrmMap aVFrameMap[] =
@@ -1941,7 +1941,7 @@ IMPL_LINK( SwFrmPage, PosHdl, ListBox *, pLB )
 }
 
 /*
-Description:horizonal Pos
+Description:horizontal Pos
  */
 IMPL_LINK( SwFrmPage, RelHdl, ListBox *, pLB )
 {
@@ -2562,7 +2562,15 @@ void BmpWindow::Paint( const Rectangle& )
 if(nRelGrf < nRelWin)
 {
 const long nWidth = aPntSz.Width();
-aPntSz.Width() = aPntSz.Height() * nRelGrf /100;
+const long nHeight = aPntSz.Height();
+// if we use a replacement preview, try to draw at original size
+if ( !bGraphic && ( aGrfSize.Width() <= aPntSz.Width() ) && ( aGrfSize.Height() <= aPntSz.Height() ) ) {
+aPntSz.Width() = aGrfSize.Width();
+aPntSz.Height() = aGrfSize.Height();
+aPntPos.Y() += (nHeight - aPntSz.Height())/2 ;
+}
+
+else aPntSz.Width() = aPntSz.Height() * nRelGrf /100;
 if(!bLeftAlign)
 aPntPos.X() += nWidth - aPntSz.Width() ;
 }
-- 
1.7.5.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Index table: character style 'Index link' instead of 'Internet link'

2011-12-22 Thread Stefan Knorr (Astron)
Hi Alexander,

> When character style is 'Internet Link', all items are underline. In my
> humble opinion, it doesn't look nice.
>
> Is this a mistake or a conscious decision of developers?

There's a discussion on ux-advise about this, see:
http://lists.freedesktop.org/archives/libreoffice-ux-advise/2011-December/000660.html
.

Feel free to weigh in there. In any case, I agree with you on the matter.

Astron.

PS: Note that the developer list is not the best place to discuss this
(unless you want to provide a patch, of course).
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-22 Thread Petr Mladek
Michael Stahl píše v Po 19. 12. 2011 v 19:26 +0100:
> > What are the git tags for v3.4.4, v3.5b0 and v3.5b1?
> 
> i guess 3.4.4 is this: libreoffice-3.4.4.2

I have create the tags libreoffice-3.4.x-final based on the last release
candidates for the give release. It should make it easier to get final
sources.

In this case, you might use libreoffice-3.4.4-final now.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] calc: Re: com.sun.star.container.XNameContainer.removeByName() fails v3.5b0+ (linux)

2011-12-22 Thread Petr Mladek
Jan Holesovsky píše v Út 20. 12. 2011 v 16:26 +0100:
> Hi Tomas,
> 
> On 2011-12-20 at 13:23 +0100, Tomas Hlavaty wrote:
> 
> > > i guess 3.4.4 is this: libreoffice-3.4.4.2
> > > beta0:  libreoffice-3.5.0.0
> > > beta1:  libreoffice-3.4.99.1
> > >
> > > yes, really :)
> > 
> > Is that somewhere documented?  Or wouldn't it be better if it was
> > obvious from the tag names?
> 
> Bugs happen - sorry for that :-(  We should probably re-tag the beta0 as
> libreoffice-3.4.99.0, and dump libreoffice-3.5.0.0 from the
> repositories.

I have created the libreoffice-3.4.99.0 tag today.

I left the tag there libreoffice-3.5.0.0 because it is not easy to get
rid of it. Anyone whoc have it, could push it back easily.

I am sorry for the troubles.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [ANN] LibreOffice 3.5.0 beta2 available

2011-12-22 Thread Thorsten Behrens
Hi *,

for the upcoming new version 3.5.0, we continue with a beta2 build
that is now feature-complete. For further milestones on the way
towards 3.5.0, please refer to our release plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try & report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to beta1 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-release-3.4.99.2.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

-- Thorsten


pgpyAsmhw16Fn.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED][PATCH] c1db721 ScChangeActionTable conversion: Yet another correction.

2011-12-22 Thread Eike Rathke
Hi Marcel,

On Thursday, 2011-12-22 18:52:02 +0100, Marcel Metz wrote:

> after testing the change tracking feature in calc I've found yet
> another bug in the UI. The attached patch fixes the bug in
> question.

Muchas gracias ... pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit/?id=45c2812ebdebdfb41818a8035878cd17d60bec77

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp4OfG9UpZmb.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PATCH] c1db721 ScChangeActionTable conversion: Yet another correction.

2011-12-22 Thread Marcel Metz
Hello Eike,

after testing the change tracking feature in calc I've found yet
another bug in the UI. The attached patch fixes the bug in
question.

regards Marcel

---
 sc/source/ui/miscdlgs/acredlin.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index a35f556..fee43d4 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1218,7 +1218,7 @@ bool ScAcceptChgDlg::InsertContentChildren(ScChangeActionMap* pActionMap,SvLBoxE
 ++itChangeAction;
 }
 
-if( itChangeAction != pActionMap->end() )
+if( itChangeAction == pActionMap->end() )
 return true;
 
 SvLBoxEntry* pOriginal = InsertChangeActionContent(

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] bug in post-commit hook

2011-12-22 Thread Noel Grandin
I've had about a 100 so far today

On Thursday, 22 December 2011, Michael Stahl  wrote:
> On 22/12/11 16:12, Noel Grandin wrote:
>> there is something wrong with the post-commit hook - I'm getting repeats
>> of the message below every few seconds.
>
> are you sure? i guess there should be ~20 of them, one for each
> bootstrap based repo
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] bug in post-commit hook

2011-12-22 Thread Michael Stahl
On 22/12/11 16:12, Noel Grandin wrote:
> there is something wrong with the post-commit hook - I'm getting repeats
> of the message below every few seconds.

are you sure? i guess there should be ~20 of them, one for each
bootstrap based repo

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] bug in post-commit hook

2011-12-22 Thread Noel Grandin
there is something wrong with the post-commit hook - I'm getting repeats of the 
message below every few seconds.


 Original Message 
Subject:[Libreoffice-commits] Changes to 
'refs/tags/libreoffice-3.4.3-final'
Date:   Thu, 22 Dec 2011 07:06:53 -0800 (PST)
From:   pmla...@kemper.freedesktop.org (Petr Mladek)
Reply-To:   libreoffice@lists.freedesktop.org
To: libreoffice-comm...@lists.freedesktop.org



Tag 'libreoffice-3.4.3-final' created by Petr Mladek  at 
2011-12-22 15:05 +0100

Tag libreoffice-3.4.3-final (3.4.3-final)
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)

iQIcBAABAgAGBQJO80dVAAoJEPQ0oe+v7q6jyMkP/3VN41X1EV4XKLEFwgJiCX4A
veacVJnDz0Jeel6CugOumyDU0REfLlN6jL0jVfn4ogLdutMadmMOLhKHuyMLVRjJ
EiZaMjp6bfj4olHvDFJPu29psqwxvI/yRweDjJw5i4i9qHYdUTx6Sg/5jWLMWE/g
YKApm8nTNc4lD7rb/MxGpMTgCZyThoZh0ZR/O3xEs0CJQAVdKe9XuEjaxyYLB0iP
nkvUIDj9/smNq4pf4psOau2CXOJL920+9POc2/RsC9NYQO0+vQG35SQO/pHx2nH/
DWx49nxG3U4uHmLXWuufWerV8BEdKUdkYlsYsIW5aisTMlJiZ0X0jQYHhv67Y7Pa
qSbFo1MKmtr5UY6U3ztGZiZx0k4kZuT9zA51uhhgRCzdqv23JRAnljdI88kEqaVz
t3OHb/bmsBVDYnmLfWlRjF9kLCYLuvH0vRVTip3f6yVHbf8uw/smpGlFdzgPDeXQ
4QaOkUCY0G7HpElf8f9ATzvYylw7PyCiyu/8Gus4RKrvubrpoJNdjEMfYZr4HMfW
kiBne4ui3LrYAKultlPb0+Hd0yxjuo+QwhqXhBkLSnQhoc/AKng9odo7jvQCW1hO
5v3KqpryTQ6ViwLpeXSSBtJ/PvGvWTK/430bfXX2gfdYEHE+hb2f9zX7bf8QOCdK
aFPhnf9yp7h74ehm2nHG
=+ymJ
-END PGP SIGNATURE-

Changes since libreoffice-3.4.3.1-1:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits



Disclaimer: http://www.peralex.com/disclaimer.html


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] Remove SC_DLLPUBLIC to fix build on msvc 2008

2011-12-22 Thread Korrawit Pruegsanusak
Hello Matúš, all,

On Thu, Dec 22, 2011 at 00:00, Matúš Kukan  wrote:
> On 21 December 2011 17:52, Korrawit Pruegsanusak
>  wrote:
>> Anyway, I don't have enough knowledge for why this works, but after
>> reverting, it passed through this point. (but still failed somewhere
>> else)
>
> Where ? Is it related to this problem ?

I don't think it is :) It's in tail_build. Here's the log:

[cut]
[ build MOD ] hwpfilter
R=/cygdrive/d && S=$R/libo && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  mkdir -p $W/Module/ && touch
$W/Module/hwpfilter
D:/libo/solenv/gbuild/StaticLibrary.mk:49: *** gb_Deliver_deliver:
file does not exist in solver, and cannot be delivered:
/cygdrive/d/libo/solver/wntmsci12.pro/lib/iexttextcat.lib.  Stop.

Seems it doesn't found iexttextcat.lib, which I try finding it in
libexttextcat\wntmsci12.pro\lib\ and found only ilibexttextcat.lib and
ilibexttextcat.exp. I tried clean build in both hwpfilter and
libexttextcat but no avail. Maybe do I need to make clean in
tail_build? (I don't like this, because it's very time-consuming) or
git pull -r again?

I'm at d6dc60ab350824bd0dffbf699cac13a3efd1e289 Dec 19 2011 14:51:18.

Last but not least, thanks for pushing my patch! :)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XV getLength() to isEmpty()

2011-12-22 Thread Caolán McNamara
On Wed, 2011-12-21 at 20:01 -0200, Olivier Hallot wrote:
> Please find attached a partial fix for Easy Hack FDO43460

Pushed now, thanks for these.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [REVIEW 3-4-5] untranslated menu items

2011-12-22 Thread David Tardon
Hi all,

commit 7248aaed7aca6c241683f6d83bb6caa00c447b0d reverts earlier commit,
that caused some menu items to be left untranslated. If you are
wondering why it is so, read my comment (I hope it is understandable) in
commit a6511b9d9a3f13835510a9caffc837829b206d14 :-)

How to reproduce:
1. start writer in your favorite locale
2. select View->Data Sources from menu
3. open a table
4. right click on a cell. A popup menu with just one item--Copy--is
   opened. The item is not translated.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [BUG] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread Thorsten Behrens
Tor Lillqvist wrote:
> What we should do, IMHO, is to check in our own configure.in if there
> is a pkg-config in PATH on a system where one is not expected to be
> present (only Mac OS X, I guess?), and in that case emit a warning.
> 
> But wait, we already do that!
> 
Have to agree with Tor here, best way out is to check in configure
and fail fast.

How about poking PATH there for suspicious segments like "/opt/" and
"/usr/local/", and suggesting removal?

Cheers,

-- Thorsten


pgppGT73bSbRz.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [MacOS] Horizontal cursor positioning in justified text

2011-12-22 Thread Christian Lohmaier
Hi James, *,

On Thu, Dec 22, 2011 at 8:56 AM, James C
 wrote:
> [Caret movement in justified text on Mac]
> Questions:
>  - is anybody currently working on this?  (If so, they should
> continue, and I should work on something else.)

This is specific to the Mac, where ATSUI is used for the text
rendering, and indeed there is a difference between the spacing
applied by Mac OSX and what LO internally uses. (basically LO only
expands spaces, ATSUI also between letters)

Apparently it was onced fixed/approximated better, but the problem did
come up again later (already in OOo times, prior to the creation of
LibreOffice)

>  - does anybody have hints, for where I should start reading the code?

https://issues.apache.org/ooo/show_bug.cgi?id=102903
https://issues.apache.org/ooo/show_bug.cgi?id=91183

Too bad EIS is gone, otherwise one could have looked up the ooo301gsl1 cws.

But opengrok does the trick for the code-pointers:
http://opengrok.libreoffice.org/search?project=core&hist=ooo301gsl1_DEV300

So look around vcl/aqua/source/gdi/salatslayout.cxx

>  - if I start working on this, should I record a bug?

No - not really necessary, but of course nice to have to be able to
point to a bugreport in a commit message, this makes it easier for
people to write nicer releasenotes and stuff.
(but there is an old OOo bug, thus that is covered)

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [BUG] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread James C
Yes, we can't protect against an arbitrarily broken system.

I'm not a good systems administrator.  I don't know how to do "please
consider hiding it" without breaking something else.

I think pango is faulty; it needs to depend on how cairo was
configured, but it is testing how the system is configured.

But that's above my pay-grade.  I like this change because it's within
the part of the world that's currently open to me to possibly
(depending on this conversation) change.

On Thu, Dec 22, 2011 at 11:59 PM, Tor Lillqvist  wrote:
>> This is a protection-from-contaminated-system
>
> But in general, a system can be contaminamed in arbitrary ways.
> Should/can we really protect against arbitrary, unknown, ways in which
> a system might have been changed by "helpful" 3rd-party software or
> misguided sysadmins/users to not correspond to a normal installation
> of the OS in question? No, we can't.
>
> What we should do, IMHO, is to check in our own configure.in if there
> is a pkg-config in PATH on a system where one is not expected to be
> present (only Mac OS X, I guess?), and in that case emit a warning.
>
> But wait, we already do that!
>
> if test $_os = Darwin; then
>    AC_MSG_CHECKING([for bogus pkg-config])
>    if test -n "$PKG_CONFIG"; then
>        if test "$PKG_CONFIG" = /usr/bin/pkg-config && ls -l
> /usr/bin/pkg-config | grep -q Mono.framework; then
>            AC_MSG_RESULT([yes, from Mono])
>        else
>            AC_MSG_RESULT([yes, from unknown origin])
>        fi
>        AC_MSG_WARN([This might have unexpected consequences, please
> consider hiding $PKG_CONFIG])
>        echo "Having a $PKG_CONFIG might have unexpected consequences,
> please consider hiding it" >>warn
>    else
>        AC_MSG_RESULT([no])
>    fi
> fi
>
> --tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [BUG] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread Tor Lillqvist
> This is a protection-from-contaminated-system

But in general, a system can be contaminamed in arbitrary ways.
Should/can we really protect against arbitrary, unknown, ways in which
a system might have been changed by "helpful" 3rd-party software or
misguided sysadmins/users to not correspond to a normal installation
of the OS in question? No, we can't.

What we should do, IMHO, is to check in our own configure.in if there
is a pkg-config in PATH on a system where one is not expected to be
present (only Mac OS X, I guess?), and in that case emit a warning.

But wait, we already do that!

if test $_os = Darwin; then
AC_MSG_CHECKING([for bogus pkg-config])
if test -n "$PKG_CONFIG"; then
if test "$PKG_CONFIG" = /usr/bin/pkg-config && ls -l
/usr/bin/pkg-config | grep -q Mono.framework; then
AC_MSG_RESULT([yes, from Mono])
else
AC_MSG_RESULT([yes, from unknown origin])
fi
AC_MSG_WARN([This might have unexpected consequences, please
consider hiding $PKG_CONFIG])
echo "Having a $PKG_CONFIG might have unexpected consequences,
please consider hiding it" >>warn
else
AC_MSG_RESULT([no])
fi
fi

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.99.1 tag created (3.5.0-beta1)

2011-12-22 Thread Petr Mladek
Bjoern Michaelsen píše v St 21. 12. 2011 v 21:31 +0100:
> On Mon, Dec 12, 2011 at 06:34:26PM +0100, Petr Mladek wrote:
> > Note that I used the correct version 3.4.99.1 for this beta. We use
> > (3.3.99.X also for 3.4 betas). I am sorry that I used 3.5.0.0 for
> > beta0. The 3.5.0.x version are reserved for release candidates.
> 
> Can we tag the beta0 as 3.4.99.0 in addition to 3.5.0.0 for now? That shouldnt
> hurt.
>
> If someone asks about the 3.5.0.0 tag, we could tell them to just ignore it
> without lengthy discussions.
> 
> Well, people could still ask why our rcs start at 1, while our minors and
> majors start at 0 and we _could_ answer that with "tradition" as OOo did so
> too. That would not be the whole story as 3.X.X_m0 was the branchoff point at
> OOo (quite a sensible convention), in which case our 3.5.0.0 is slightly of 
> the
> mark.

IMHO, the right explanation is that .0.1 is the first release candidate
for the the initial release and .1.1 is the first release candidate for
the first bug fix release.

> Anyway: Could we at least please double-tag 3.5.0.0 as 3.4.99.0?

done

I am sorry for the troubles.


Best Regards.
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PATCH] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread James C
Sorry; re-doing the manual process with the right label :-)

On Thu, Dec 22, 2011 at 11:52 PM, James C
 wrote:
> Hi All,
>
> This is a protection-from-contaminated-system patch, anticipated in
> the tail of this bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=43917
>
> Depending on what happens to my git send-emal attempt, another copy
> may appear later.
>
> Regards,
> James.
>
> On Thu, Dec 22, 2011 at 11:06 PM, Caolán McNamara  wrote:
>> On Thu, 2011-12-22 at 20:33 +1300, James C wrote:
>>> I submitted a patch with git send-email.  I presume that it
>>> is awaiting moderation.
>>
>> hmm, maybe not, probably worth extracting it with git format-patch and
>> try sending it as a manual attachment. Even if it is in moderation,
>> might be a while over the holiday season before a moderator gets to look
>> at the moderation queue.
>>
>> C.
>>


0001-Hide-system-pkg-config-to-avoid-finding-stray-system.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [BUG] Hide system pkg-config, to avoid finding stray freetype.

2011-12-22 Thread James C
Hi All,

This is a protection-from-contaminated-system patch, anticipated in
the tail of this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=43917

Depending on what happens to my git send-emal attempt, another copy
may appear later.

Regards,
James.

On Thu, Dec 22, 2011 at 11:06 PM, Caolán McNamara  wrote:
> On Thu, 2011-12-22 at 20:33 +1300, James C wrote:
>> I submitted a patch with git send-email.  I presume that it
>> is awaiting moderation.
>
> hmm, maybe not, probably worth extracting it with git format-patch and
> try sending it as a manual attachment. Even if it is in moderation,
> might be a while over the holiday season before a moderator gets to look
> at the moderation queue.
>
> C.
>


0001-Hide-system-pkg-config-to-avoid-finding-stray-system.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-12-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

Petr Mladek  changed:

   What|Removed |Added

 Depends on||41089

--- Comment #241 from Petr Mladek  2011-12-22 02:17:53 PST ---
(In reply to comment #240)
> Nominate "Bug 41089 - FILESAVE: Impossible with password protection"

Yup, I have added it. Well, it might be a duplicated of the bug 43868. I guess
that the fix will be the same for both of them.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW] fdo#40482 sw: view options changed by printing

2011-12-22 Thread Caolán McNamara
On Wed, 2011-12-21 at 17:11 +0100, Michael Stahl wrote:
> i'd like to have the fix for $SUBJECT in 3.4.5, it is a regression
> introduced in 3.4.2 or 3.4.3, am too lazy to check which.
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=89d2733e16ae6233deea6bef3193bd45c89b854c

Bah :-(. Well, this looks better to me anyway. So +1 from me. On the
other hand I cocked up with the "make it not crash" fix so could
definitely do with someone else's approval in addition :-)

I wonder if this is cppunit-testable in sw/qa/core/swdoc-test.cxx ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [MacOS] Starting dev-install is hairy

2011-12-22 Thread Caolán McNamara
On Thu, 2011-12-22 at 20:33 +1300, James C wrote:
> I submitted a patch with git send-email.  I presume that it
> is awaiting moderation.

hmm, maybe not, probably worth extracting it with git format-patch and
try sending it as a manual attachment. Even if it is in moderation,
might be a while over the holiday season before a moderator gets to look
at the moderation queue.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] .: 2 commits - vcl/inc vcl/source writerfilter/inc writerfilter/source

2011-12-22 Thread Caolán McNamara
On Thu, 2011-12-22 at 08:51 +, Michael Meeks wrote:
> On Thu, 2011-12-22 at 01:50 +0100, Miklos Vajna wrote:
> > removed are methods necessary for the XML dump writerfilter
> > creates when built using dbglevel=2.
> 
>   I wonder if Caolan could build with dbglevel=2 with callcatcher so the
> unused methods don't end up in the list ?

Its a hazard alright, though platform dependent code not build under
Linux would remain a problem, so manual inspection is always
required :-(

I'll try
http://cgit.freedesktop.org/libreoffice/core/commit/?id=700d04cf24c2889d0ce9333f47e843e76c367c37

My minor concern is that by building a list of unused code under
dbglevel=2 that we retain a handful of methods only used under that,
which themselves pull in 80megs worth of code only used via dbglevel=2,
but can always revert when list hits 0 when its easier to do more
inspection of a small handful rather than a big list

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] License statement

2011-12-22 Thread Jonas Finnemann Jensen
Hi,

I here by confirm that my contributions to LibreOffice are available
under the terms of the LGPL3+ and/or MPL1.1+.

--
Regards Jonas Finnemann Jensen.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] .: 2 commits - vcl/inc vcl/source writerfilter/inc writerfilter/source

2011-12-22 Thread Michael Meeks

On Thu, 2011-12-22 at 01:50 +0100, Miklos Vajna wrote:
> removed are methods necessary for the XML dump writerfilter
> creates when built using dbglevel=2.

I wonder if Caolan could build with dbglevel=2 with callcatcher so the
unused methods don't end up in the list ?

Anyhow - thanks for the great dead code removal work August :-)

ATB,

Michael.;

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [MacOS] Horizontal cursor positioning in justified text

2011-12-22 Thread Cedric Bosdonnat
Hi James,

On Thu, 2011-12-22 at 20:56 +1300, James C wrote:
> Justified text changes the kerning (space between letters) of words on
> a line.  The cursor positioning in writer seems to assume, falsely,
> that all of the adjustment happens in the spaces between words.  So
> the cursor ends up in the middle of, or on the wrong side of, letters.
>  This matters to me because I write texts for a university which
> requires justified paragraphs

> Questions:
>   - is anybody currently working on this?  (If so, they should
> continue, and I should work on something else.)

I know nobody working on that ATM, feel free to go ahead with that.

>   - does anybody have hints, for where I should start reading the code?
> (I suspect pango, in which case I may end up trying to push
> changes to them; are they receptive?)

You can have a look at this unfinished patch:
http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300/vcl-kerning-fix.diff

It may give you some hints about where to start.

>   - if I start working on this, should I record a bug?

Sure, it's always good to report a bug... who knows what will happen
later to this email ;)

Thanks for pushing the kerning further in Writer :)

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [MacOS] Horizontal cursor positioning in justified text

2011-12-22 Thread Tor Lillqvist
Sorry, I don't know the code related to the problem you describe; just
some other comments here.

> The cursor positioning in writer

Just a nitpick: You mean "caret", not "cursor". (The cursor is the
thing that you move around with your pointing device, the caret is the
"text insertion cursor". But yeah, everybody understand what you mean
anyway because of context.)

> I suspect pango,

I doubt Pango is involved here; as far as I know, Pango is needed and
used only by the librsvg SVG rendering stack.

>  - if I start working on this, should I record a bug?

Sure.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice