date:20120110

On 10 January 2012 22:41, Michael Stahl  wrote:
> argh, there is a SYSTEM_MOZILLA_HEADERS?  completely forgot about that,
> but i guess in that case changing the header isn't such a good idea
> after all :(

Hmm, but does anybody use --with-system-mozilla-headers ?
I can't see any advantage over internal headers. (But I can't see many things.)

I'd say, let's just remove SYSTEM_MOZILLA_HEADERS and change the internal ones.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Change in addition for date handling (intentional change??)

2012-01-10 Thread Andrew Douglas Pitonyak


On 01/09/2012 08:16 AM, Noel Power wrote:

On 06/01/12 21:39, Andrew Douglas Pitonyak wrote:
Off hand, I might be inclined to simply move the code back to its 
original location, which would set the behavior back to letting math 
with dates return dates, rather than just specific operations (which 
is not even supported now).
yeah I agree, I see no reason why the code shouldn't be moved back to 
where it was, seems this did indeed creep in here from the orig patch 
we got for the currency work and appears I didn't spot this when 
reviewing it :-) Thanks for catching and finding this. Changed this on 
master


Noel

Excellent, thanks. Since you made the change, I can now revert my 
changes (in my local copy) and accept what was checked in :-)


--
Andrew Pitonyak
My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
Info:  http://www.pitonyak.org/oo.php

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

On 10/01/12 21:45, Matúš Kukan wrote:
> On 10 January 2012 16:14, Michael Stahl  wrote:
>> well the .def file is only for Windows, we don't have anything in gbuild
>> to convert between a bunch of different map file formats like the old
>> build system could because we're trying for "less insane"...
>>
>> so something like #ifdef UNX SAL_DLLPUBLIC_EXPORT would be needed...
>>
>> on the other hand the npapi.h header is checked into git, does not come
>> from a tarball, and has already been modified; i wonder if editing that
>> to add dll-exports is the easiest way to fix this?
> 
> I think we should add DLLPUBLIC_EXPORT macros ..
> And we don't have to modify npapi.h directly but create different
> npapi.h to be included some ugly way as in:
> i18npool/source/breakiterator/Makefile:37
> 
> Because there is also possibility to use SYSTEM_MOZILLA_HEADERS.
> I don't know if anybody use that but if yes, we would need somehow get
> path to the npapi.h file.
> I guess that could be doable.

argh, there is a SYSTEM_MOZILLA_HEADERS?  completely forgot about that,
but i guess in that case changing the header isn't such a good idea
after all :(

hmm... i guess in that case the least ugly way is to resurrect the .def
file for Windows, and add #ifdef UNX SAL_DLLPUBLIC_EXPORT for the other
platforms.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

2012-01-10 Thread Kohei Yoshida

PUSHED

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] proposed fix for fdo#44283

2012-01-10 Thread julien2412

Hello,

The bug is : "tabulator does not change row in tables"
First, let's have in mind the code of getColumnId
(svtools/source/brwbox/brwbox2.cxx) : 
481 sal_uInt16 BrowseBox::GetColumnId( sal_uInt16 nPos ) const
482 {
483 DBG_CHKTHIS(BrowseBox,BrowseBoxCheckInvariants);
484 
485 if ( nPos >= pCols->size() )
486 return BROWSER_INVALIDID;
487 return (*pCols)[ nPos ]->GetId();
488 }
So if want to go further than max row, it returns BROWSER_INVALIDID (equals
to SAL_MAX_UINT16)

So I think the problem is here  (still in brwbox2.cxx) :
1999 case BROWSER_CURSORRIGHT:
   2000 if ( bColumnCursor )
   2001 {
   2002 sal_uInt16 nNewPos = GetColumnPos( GetCurColumnId()
) + 1;
   2003 sal_uInt16 nNewId = GetColumnId( nNewPos );
   2004 if (nNewId != 0)// Am Zeilenende ?  <-- we
should compare nNewId with BROWSER_INVALIDID not with 0
   2005 bDone = GoToColumnId( nNewId );
   2006 else
   2007 {
   2008 sal_uInt16 nColId = ( GetColumnId(0) == 0 ) ?
GetColumnId(1) : GetColumnId(0);
   2009 if ( GetRowCount() )
   2010 bDone = ( nCurRow < GetRowCount() - 1 ) &&
GoToRowColumnId( nCurRow + 1, nColId );
   2011 else if ( ColCount() )
   2012 GoToColumnId( nColId );
   2013 }
   2014 }
   2015 else
   2016 bDone = ScrollColumns( 1 ) != 0;
   2017 break;

But here is the code of getColumnId (still in brwbox2.cxx) : 
481 sal_uInt16 BrowseBox::GetColumnId( sal_uInt16 nPos ) const
482 {
483 DBG_CHKTHIS(BrowseBox,BrowseBoxCheckInvariants);
484 
485 if ( nPos >= pCols->size() )
486 return BROWSER_INVALIDID;
487 return (*pCols)[ nPos ]->GetId();
488 }
So if want to go further than max row, it returns BROWSER_INVALIDID (equals
to SAL_MAX_UINT16)

I replaced 0 by BROWSER_INVALIDID, it compiles and seems to work.

I propose this patch : 
http://nabble.documentfoundation.org/file/n3648948/patch.txt patch.txt 

Is it ok for you ? If yes I can commit and push on master (3.5 too ?)

Julien

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-proposed-fix-for-fdo-44283-tp3648948p3648948.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

2012-01-10 Thread Kohei Yoshida

On Wed, 2012-01-11 at 02:24 +0900, Takeshi Abe wrote:
> Hi all,
> 
> Let me propose a patch to fix fdo#44616 for master branch by abandoning
> attributes FRAME and RULES of TABLE element in .html.
> I found that .html output is declared as HTML 3.2, though neither of these
> attributes are explicitly defined in [1].
> 
> On the other hand, as mentioned in HTML 4.01 specification [2], just remaining
> BORDER="0" should work in terms of backward compatibility.
> Any suggestion and/or review would be appreciated.

Yup, the patch makes sense.  I've pushed it on the -3-5 branch as well
as on master.

Since the Beta3 is already tagged, the fix will be in the one after
Beta3, which will probably be RC1?

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Updating Italian dictionaries

2012-01-10 Thread Andrea Pescetti


Andras Timar wrote:

I added legacy files to version control and I also updated the README
which I forgot to do last time. But legacy files will not be packaged
and distributed in the product, they will be part of source packages
only.


Thanks! This seems a reasonable trade-off; at least sources are now 
aligned everywhere (LibreOffice and OpenOffice extensions sites, 
LibreOffice and OpenOffice repositories) and this will make future 
updates easier.


Any reasons for renaming README.txt to README_it_IT.txt? I don't have 
any strong preferences on this, I had just renamed the file to simply 
README.txt since it contains information in both Italian and English, 
while README_it_IT.txt could suggest it was in Italian (even though of 
course it_IT is the "Product name" here). If it is convenient to 
continue using README_it_IT.txt I can change it back in future releases, 
to ease integration.



Please note that in LibreOffice git there is a newer version of
it_IT.aff than in svn, please check if it is correct. In svn you have
version 2.4, in git we have version 3.3. BTW both are the same, only
the comment sections at the beginning of the files are different.


Exactly. It is correct to put the old version back, since the previous 
contributors feel it would be more appropriate to leave their unmodified 
file instead of only changing comments. So the 2.4 file should be put 
back in the sources, replacing the 3.3 file.



Also please note that the extension icon, which is the Italian flag,
will not be used in LibreOffice, because we don't use national flags
as icons at all. I understand that probably nobody may be offended by
the Italian flag, but we shall make no exceptions.


Yes I know, no problem; the updates I asked for didn't include restoring 
the flag or reverting any changes LibreOffice had made.


Regards,
  Andrea.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] crasher in writer (footer)

On 10/01/12 18:03, August Sodora wrote:
> When I try to delete a footer, I'm getting a SIGABRT from a failed
> assertion, backtrace below
> 
> soffice.bin: /home/augsod/Sources/libo/sw/source/core/bastyp/index.cxx:237:
> virtual SwIndexReg::~SwIndexReg(): Assertion `!m_pFirst && !m_pLast'
> failed.

this is because there is some navigation toolbar that is implemented in
SwNavigationMgr and which stores its history as SwPositions.
those are not corrected when the node they point to is deleted, hence
the assertion.  a non-dbgutil build would probably crash some time later
when the user clicks the navigation buttons.  apparently kids these days
don't use --enable-dbgutil, so you get bonus points for trying :)  and
i'm happy that i turned this into an assert that aborts and draws attention.

should be fixed now on master and libreoffice-3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e898354fc76339a9a007b30f1ebe123981d0426

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=debb4be8886a4c5fd0a714dfd1b53306b836b800

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

On 10 January 2012 16:14, Michael Stahl  wrote:
> well the .def file is only for Windows, we don't have anything in gbuild
> to convert between a bunch of different map file formats like the old
> build system could because we're trying for "less insane"...
>
> so something like #ifdef UNX SAL_DLLPUBLIC_EXPORT would be needed...
>
> on the other hand the npapi.h header is checked into git, does not come
> from a tarball, and has already been modified; i wonder if editing that
> to add dll-exports is the easiest way to fix this?

I think we should add DLLPUBLIC_EXPORT macros ..
And we don't have to modify npapi.h directly but create different
npapi.h to be included some ugly way as in:
i18npool/source/breakiterator/Makefile:37

Because there is also possibility to use SYSTEM_MOZILLA_HEADERS.
I don't know if anybody use that but if yes, we would need somehow get
path to the npapi.h file.
I guess that could be doable.

I can volunteer for this.

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

2012-01-10 Thread willubuntu

1. Astron, I've just finished compiling latest LibO 3.5 branch. I confirm
the patch has been pushed in master and 3.5 branches. I've no more problem
with French translation. Thanks for having put my name in git log.

By my technical prerequisites, I could have done the required modification
all by myself. But I still need some time to be more familiar with LibO code
organization. For example, what does this hard-coded macro
IMPL_EXTRA_BUTTON_WIDTH?
And how to get an instant view of code modification I did? I've to run make
-rs, which a bit slow. I can't stand waiting. (ccache is installed and work
fine).

2. Michael : As you was insisting : I've updated the LibO 3.5 Release Notes
with a great screenshot. :P

3. Concerning the "Statistics" strings. I think it's really important for
the end-user to get a consistent look and fell in the whole LibO interface.
Indeed, the feature found at File - Properties - Statistics and Tools ->
Statistics are both the same. Both features (and name) are definitely linked
together. If we update the first, this latter have to be renamed too.

My pool goes to "Statistics" because:
- in LibO 3.4 it was called like this;
- we have the same feature called like this in MSO : it could be confusing
for the LibO newbie (Typical student reaction: I have to count the number of
words I used for my homework e.g. writing exercises / redactions. I don't
find the statistics feature like in Word. Pff LibO is crappy... I'm getting
back to MSO.) --> It's the request for help, I'm sure we will have for the
forthcoming version if we rename this small (but essential!) feature.
- French and other translators are continuing to call this feature
"Statistics".

How do you view this?

Regards.

Ps: I'm on exam for now. I won't be back until I haven't finished these.
Tomorrow C# .NET :-(

--
View this message in context:
http://nabble.documentfoundation.org/PATCH-3-5-and-master-Avoid-UI-bugs-in-translations-tp3639058p3648524.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

2012-01-10 Thread Takeshi Abe

Hi all,

Let me propose a patch to fix fdo#44616 for master branch by abandoning
attributes FRAME and RULES of TABLE element in .html.
I found that .html output is declared as HTML 3.2, though neither of these
attributes are explicitly defined in [1].

On the other hand, as mentioned in HTML 4.01 specification [2], just remaining
BORDER="0" should work in terms of backward compatibility.
Any suggestion and/or review would be appreciated.

[1] http://www.w3.org/TR/REC-html32
[2] http://www.w3.org/TR/html401/struct/tables.html#h-11.3.1

Cheers,
-- Takeshi Abe
>From 483ad8744269ec31f6cca773840f5b8f9c53e522 Mon Sep 17 00:00:00 2001
From: Takeshi Abe 
Date: Wed, 11 Jan 2012 01:28:29 +0900
Subject: [PATCH] drop attributes FRAME and RULES of  for HTML 3.2

This fixes fdo#44616.
HTML 3.2 does not have these attributes:
http://www.w3.org/TR/REC-html32
---
 sc/source/filter/html/htmlexp.cxx |   10 --
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/sc/source/filter/html/htmlexp.cxx b/sc/source/filter/html/htmlexp.cxx
index c48c570..ec550e2 100644
--- a/sc/source/filter/html/htmlexp.cxx
+++ b/sc/source/filter/html/htmlexp.cxx
@@ -736,11 +736,6 @@ void ScHTMLExport::WriteTables()
 // 
 rtl::OStringBuffer aByteStrOut(OOO_STRING_SVTOOLS_HTML_table);
 
-// FRAME=VOID, we do the styling of the cells in 
-aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_frame).
-append(RTL_CONSTASCII_STRINGPARAM("=\"")).
-append(OOO_STRING_SVTOOLS_HTML_TF_void).append('"');
-
 bTabHasGraphics = bTabAlignedLeft = false;
 if ( bAll && pDrawLayer )
 PrepareGraphics( pDrawLayer, nTab, nStartCol, nStartRow,
@@ -770,11 +765,6 @@ void ScHTMLExport::WriteTables()
 append(RTL_CONSTASCII_STRINGPARAM("=\"")).
 append(static_cast(nColCnt)).append('"');
 
-// RULES=NONE, we do the styling of the cells in 
-aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_rules).
-append(RTL_CONSTASCII_STRINGPARAM("=\"")).
-append(OOO_STRING_SVTOOLS_HTML_TR_none).append('"');
-
 // BORDER=0, we do the styling of the cells in 
 aByteStrOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_border).
 append(RTL_CONSTASCII_STRINGPARAM("=\"0\""));
-- 
1.7.7.3

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] crasher in writer (footer)

2012-01-10 Thread August Sodora

When I try to delete a footer, I'm getting a SIGABRT from a failed
assertion, backtrace below

soffice.bin: /home/augsod/Sources/libo/sw/source/core/bastyp/index.cxx:237:
virtual SwIndexReg::~SwIndexReg(): Assertion `!m_pFirst && !m_pLast'
failed.

Program received signal SIGABRT, Aborted.
0xb7fdf424 in __kernel_vsyscall ()
(gdb) bt
#0  0xb7fdf424 in __kernel_vsyscall ()
#1  0xb7cfac8f in __GI_raise (sig=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0xb7cfe2b5 in __GI_abort () at abort.c:92
#3  0xb7cf3826 in __GI___assert_fail (assertion=0xaaa36fc9 "!m_pFirst
&& !m_pLast", file=
0xaaa36f44 "/home/augsod/Sources/libo/sw/source/core/bastyp/index.cxx",
line=237, function=0xaaa37320 "virtual SwIndexReg::~SwIndexReg()")
at assert.c:81
#4  0xaa011cbf in SwIndexReg::~SwIndexReg (this=0xa6def43c,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/bastyp/index.cxx:237
#5  0xaa1f27bb in SwCntntNode::~SwCntntNode (this=0xa6def408,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/docnode/node.cxx:994
#6  0xaa4cab8d in SwTxtNode::~SwTxtNode (this=0xa6def408,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/txtnode/ndtxt.cxx:248
#7  0xaa4cac47 in SwTxtNode::~SwTxtNode (this=0xa6def408,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/txtnode/ndtxt.cxx:269
#8  0xaa1ff776 in SwNodes::RemoveNode (this=0xa97e9c40, nDelPos=9,
nSz=4, bDel=1 '\001') at
/home/augsod/Sources/libo/sw/source/core/docnode/nodes.cxx:2409
#9  0xaa1fce1b in SwNodes::DelNodes (this=0xa97e9c40, rStart=...,
nCnt=4) at /home/augsod/Sources/libo/sw/source/core/docnode/nodes.cxx:1541
#10 0xaa0e0c17 in SwDoc::DeleteSection (this=0xa97d0fd0,
pNode=0xa60cf650) at
/home/augsod/Sources/libo/sw/source/core/doc/docedt.cxx:729
#11 0xaa2da583 in DelHFFormat (pToRemove=0xa5f391cc, pFmt=0xa9b3cdc0)
at /home/augsod/Sources/libo/sw/source/core/layout/atrfrm.cxx:238
#12 0xaa2db8a9 in SwFmtFooter::~SwFmtFooter (this=0xa5f391c0,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/layout/atrfrm.cxx:559
#13 0xaa2db92f in SwFmtFooter::~SwFmtFooter (this=0xa5f391c0,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/layout/atrfrm.cxx:560
#14 0xb6f581cf in SfxItemPool::Remove (this=0xa97d21e8, rItem=...) at
/home/augsod/Sources/libo/svl/source/items/itempool.cxx:847
#15 0xb6f6d126 in SfxItemSet::~SfxItemSet (this=0xbfffe2c0,
__in_chrg=) at
/home/augsod/Sources/libo/svl/source/items/itemset.cxx:344
#16 0xaa006bd9 in SwAttrSet::~SwAttrSet (this=0xbfffe2c0,
__in_chrg=) at
/home/augsod/Sources/libo/sw/inc/swatrset.hxx:175
#17 0xaa005481 in SwFmt::~SwFmt (this=0xbfffe2a0, __in_chrg=) at /home/augsod/Sources/libo/sw/source/core/attr/format.cxx:243
#18 0xaa1082b6 in SwFrmFmt::~SwFrmFmt (this=0xbfffe2a0,
__in_chrg=) at
/home/augsod/Sources/libo/sw/inc/frmfmt.hxx:47
#19 0xaa3564cd in SwPageDesc::~SwPageDesc (this=0xbfffe22c,
__in_chrg=) at
/home/augsod/Sources/libo/sw/source/core/layout/pagedesc.cxx:112
#20 0xaaa1b89d in SwWrtShell::ChangeHeaderOrFooter (this=0xa97c6738,
rStyleName="Converted2", bHeader=0 '\000', bOn=0 '\000',
bShowWarning=0 '\000')
at /home/augsod/Sources/libo/sw/source/ui/wrtsh/wrtsh1.cxx:1838
#21 0xaa8852d8 in SwHeaderFooterWin::ExecuteCommand (this=0xa59773c8,
nSlot=22602) at
/home/augsod/Sources/libo/sw/source/ui/docvw/HeaderFooterWin.cxx:488
#22 0xaa885423 in SwHeaderFooterWin::Select (this=0xa59773c8) at
/home/augsod/Sources/libo/sw/source/ui/docvw/HeaderFooterWin.cxx:518
#23 0xb5744e50 in MenuButton::ImplExecuteMenu (this=0xa59773c8) at
/home/augsod/Sources/libo/vcl/source/control/menubtn.cxx:86
#24 0xb5745432 in MenuButton::MouseButtonDown (this=0xa59773c8,
rMEvt=...) at /home/augsod/Sources/libo/vcl/source/control/menubtn.cxx:186
#25 0xaa8853f9 in SwHeaderFooterWin::MouseButtonDown (this=0xa59773c8,
rMEvt=...) at 
/home/augsod/Sources/libo/sw/source/ui/docvw/HeaderFooterWin.cxx:513
#26 0xb5af813d in ImplHandleMouseEvent (pWindow=0xa61b90b0,
nSVEvent=1, bMouseLeave=0 '\000', nX=1017, nY=358, nMsgTime=54664406,
nCode=1, nMode=3)
at /home/augsod/Sources/libo/vcl/source/window/winproc.cxx:804
#27 0xb5afcf5d in ImplHandleSalMouseButtonDown (pWindow=0xa61b90b0,
pEvent=0xbfffe848) at
/home/augsod/Sources/libo/vcl/source/window/winproc.cxx:2074
#28 0xb5afc42c in ImplWindowFrameProc (pWindow=0xa61b90b0, nEvent=3,
pEvent=0xbfffe848) at
/home/augsod/Sources/libo/vcl/source/window/winproc.cxx:2401
#29 0xb11ed48f in SalFrame::CallCallback (this=0xa61b9338, nEvent=3,
pEvent=0xbfffe848) at
/home/augsod/Sources/libo/vcl/inc/salframe.hxx:294
#30 0xb11e9d72 in GtkSalFrame::signalButton (pEvent=0xa5a986e8,
frame=0xa61b9338) at
/home/augsod/Sources/libo/vcl/unx/gtk/window/gtkframe.cxx:2880

August Sodora
aug...@gmail.com
(201) 280-8138
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] REMINDER: Release 3.5.0-beta3 from libreoffice-3-5 branch and hard string and UI freeze

Petr Mladek píše v Pá 06. 01. 2012 v 10:07 +0100:
> Hi,
> 
> please note that the commit deadline for 3.5.0-beta3 is on Monday,
> January 9, 2012.
> 
> IMPORTANT: It is also the hard string and UI freeze. Please, do you
> best to include late features or at least the needed strings.

I have just created the tag for beta3. Please, do not longer modify
strings in the libreoffice-3-5 branch from now on.


> Note that it is the last scheduled beta. The next commit deadline will
> be for rc1, just one week later, on Monday, January 16, 2011.

There are still many bugfixes coming. Developers behave responsibly and
do not create serious regression in last betas. Let's postpone the need
for commit review in the libreoffice-3-5 branch by one week and allow
commits without review until the following Monday, January 16, 2012.

Of course, if you are not sure about a fix, you could always ask for
review on libreoffice@lists.freedesktop.org.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANNOUNCE] libreoffice-3.4.99.3 tag created (3.5.0-beta3)

Hi,

there have been created the libreoffice-3.4.99.3 tag for 3.5.0-beta3 release.
The corresponding official builds will be available within 3 days or so.

See the attached list of changes against 3.5.0-beta2.

See also the schedule at 
http://wiki.documentfoundation.org/ReleasePlan#3.5_release
and release criteria at http://wiki.documentfoundation.org/Release_Criteria


Now, if you want to switch your clone to the tag, please do:

./g fetch --tags
./g checkout -b tag-libreoffice-3.4.99.3 libreoffice-3.4.99.3


Thanks again everyone who helped to make this happen.

Best Regards,
Petr
+ core
+ "*.*" is not "all files" (bnc#738021) [Luboš Luňák]
+ another missing null pointer check in multilinebar, (fdo#44518) [Markus Mohrhard]
+ avoid pointless const_cast, use getConstArray in all cases. (fdo#44533) [Thorsten Behrens]
+ basic function VAL produces bad result (fdo#44172) [August Sodora]
+ cherry pick fix for (fdo#44065) [Julien Nabet]
+ collection of problems causing loss of ole2 previews (fdo#43867) [Caolán McNamara]
+ correctly handle empty paragraphs in slideshow animation (fdo#43684) [Thorsten Behrens]
+ deleting sheets should adjust drawing object pages as well. (fdo#44467) [Kohei Yoshida]
+ don't hide images in menus (fdo#41264, fdo#31471) [Ivan Timofeev]
+ don't set document modified for copy and select all, (fdo#44423) [Markus Mohrhard]
+ fix (bad hyphenation of French words with hyphen and apostrophe) (#43931) [László Németh]
+ fix - don't loop infinitely when using Apple Remote (fdo#33816) [Thorsten Behrens]
+ fix RTF export of date field (fdo#35099) [Miklos Vajna]
+ fix RTF import of images with invalid crop data (fdo#40937) [Miklos Vajna]
+ fix RTF import of implicit horizontal table cell merges (fdo#44053) [Miklos Vajna]
+ fix RTF import of vertically merged table cells (fdo#42151) [Miklos Vajna]
+ fix crash in DomainMapper_Impl::SetFieldFFData (fdo#43380) [Miklos Vajna]
+ fix crash when play particular presentation with sound (fdo#44533) [julien2412]
+ fix for - prevent invalid shape text indices. (fdo#43837) [Thorsten Behrens]
+ fix for Wrong position in Extension Mgr (FDO#44280) [Olivier Hallot]
+ fix for double hyphens (fdo#43931) [László Németh]
+ fix hyphenation attributes: (fdo#44082) [Michael Stahl]
+ fix slideshow text animations (fdo#43837) [Thorsten Behrens]
+ get external references to work with AND and OR. (fdo#36387) [Kohei Yoshida]
+ header/Footer,Page Break: fix bad test for printing mode (fdo#43962) [Cédric Bosdonnat]
+ hopefully correct automatic calculation of y-axis scale. (fdo#44546) [Kohei Yoshida]
+ importing extLst of drawings in diagrams. (bnc#655408) [Muthu Subramanian]
+ make the data validation popup more reliable. (fdo#36851, bnc#737190) [Kohei Yoshida]
+ missing icons in Index Design dialog (fdo#38435) [Andras Timar]
+ missing pointer check in new multiline input code, (fdo#43856) [Markus Mohrhard]
+ oDF export: fix layout grid invalid ODF (fdo#44073) [Michael Stahl]
+ overlapped controls (fdo#44294) [Ivan Timofeev]
+ pack *.default files, too (fdo#43923) [Andras Timar]
+ rHEL-4 buildbox doesn't have FT_Library_SetLcdFilter (fdo#44219) [Caolán McNamara]
+ rTF: update layout (if present) before export (fdo#37161) [Miklos Vajna]
+ refresh the layout after inserting a picture (fdo#36681) [Cédric Bosdonnat]
+ reintroduce fo:margin-* on top of fo:margin for backward compat (fdo#43862) [Cédric Bosdonnat]
+ related: fix parsing of the \cf RTF token (fdo#43380) [Miklos Vajna]
+ related: header styles contain content like document body (fdo#43867) [Caolán McNamara]
+ remove Tahoma from the Hebrew font list (except the UI list) (fdo#32936) [Lior Kaplan]
+ resolved - Date formatting in Spreadsheet is inconsistent (fdo#37978) [Eike Rathke]
+ return earlier from ScInterpreter::GetDBParams on error, (fdo#2) [Markus Mohrhard]
+ revert "aw084: Added code to mimic old behaviour and call user layout link when empty paragraph is rendered" (fdo#43684, fdo#43837, i#108052) [Thorsten Behrens]
+ safer protection check... why using the layout for this? (fdo#40250) [Cédric Bosdonnat]
+ search for index entries in the whole document, not only the body (fdo#32726) [Cédric Bosdonnat]
+ shrink the first column in the open dialog, remove unused flags (fdo#44204) [Ivan Timofeev]
+ skip filtered cells during auto-fill. (fdo#44545) [Kohei Yoshida]
+ sw: temp selection print doc: (fdo#40482, fdo#39159) [Michael Stahl]
+ tools container rework regression fix (for (fdo#41657) [Thorsten Behrens]
+ update readme (fdo#37951) [Andras Timar]
+ common
+ version 3.4.99.3, tag libreoffice-3.4.99.3 (3.5.0-beta3) [Petr Mladek]
+ core
+ "*.*" is not "all files" (bnc#738021) [Luboš Luňák]
+ "Insert" + "Rows" and "Insert" + "Columns" are not OK l10n-wise [Andras Timar]
+ '--' is not allowed inside

Re: [Libreoffice] [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

2012-01-10 Thread Michael Meeks

On Tue, 2012-01-10 at 16:24 +0100, Stefan Knorr (Astron) wrote:
> >Personally, I -love- this feature :-) it finally makes that dialog
> > clear. Any chance whomever did this work (or some other kind volunteer)
> > can add a screenshot and credit to:
> >
> >http://wiki.documentfoundation.org/ReleaseNotes/3.5
> 
> Hm, right, we (that'd be Josh, Christoph, William and me, possibly
> others, too) changed that dialogue twice in the 3.5 cycle. I am
> unsure, though, if the number of people who discussed this really
> merits a mention in 3.6 release notes (as it's not in 3.5, as Andras
> said).

It's not ? I do a 'File' Save->As in 3.5.0b2 and instead of this
hideous "Keep Current Format" nonsense that I (and my spouse) visibly
struggle with each time; I get a comprehensible choice :-)

In my book that is a dialog that ~every one of our users stumbles over,
and having a screenshot of the improvement in the release notes is
pretty useful :-) It'd be great if we could add it ...

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

2012-01-10 Thread Stefan Knorr (Astron)

Hi Michael, Andras,

>> Thanks for taking care of this issue. Pushed to libreoffice-3-5 with
>> changes. I did not see the point in shortening the body text.

Thanks for cherry-picking.
To put it with Joel Spolsky: "Users can't read" (linked to the
corresponding article further up in the thread). So it does make sense
to keep text as short as possible. Anyway, I do understand your
reasoning for not pushing the change in 3.5 (in 3.6, it would be good
to see the change, though).


>        Personally, I -love- this feature :-) it finally makes that dialog
> clear. Any chance whomever did this work (or some other kind volunteer)
> can add a screenshot and credit to:
>
>        http://wiki.documentfoundation.org/ReleaseNotes/3.5

Hm, right, we (that'd be Josh, Christoph, William and me, possibly
others, too) changed that dialogue twice in the 3.5 cycle. I am
unsure, though, if the number of people who discussed this really
merits a mention in 3.6 release notes (as it's not in 3.5, as Andras
said).

Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

On 10/01/12 15:17, Jan Holesovsky wrote:
>> perhaps MSVC complained that the
>> SAL_DLLPUBLIC_EXPORT is just in the wrong position or something, can you
>> investigate?
> 
> Nope, this was about 'different linkage', like:
> 
> d:/master/extensions/source/nsplugin/source/npshell.cxx(446) : error
> C2375: 'NPP_New' : redefinition; different linkage
> D:/master/solver/wntmsci12.pro/inc\npsdk/npapi.h(788) : see
> declaration of 'NPP_New'

that is an error, not a warning?  damn, who wrote that stupid header...

> I am afraid that the .def file is needed for Windows :-( - because to
> get that right, we would need to change the npapi.h header too; or is
> that actually simpler than using the .def file in gbuild?

well the .def file is only for Windows, we don't have anything in gbuild
to convert between a bunch of different map file formats like the old
build system could because we're trying for "less insane"...

so something like #ifdef UNX SAL_DLLPUBLIC_EXPORT would be needed...

on the other hand the npapi.h header is checked into git, does not come
from a tarball, and has already been modified; i wonder if editing that
to add dll-exports is the easiest way to fix this?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

Hi Michael,

On 2012-01-10 at 13:20 +0100, Michael Stahl wrote:

> on Linux with your change i get only 3 symbols from that file exported,
> and the others not.

Does not sound right :-(

> perhaps MSVC complained that the
> SAL_DLLPUBLIC_EXPORT is just in the wrong position or something, can you
> investigate?

Nope, this was about 'different linkage', like:

d:/master/extensions/source/nsplugin/source/npshell.cxx(446) : error
C2375: 'NPP_New' : redefinition; different linkage
D:/master/solver/wntmsci12.pro/inc\npsdk/npapi.h(788) : see
declaration of 'NPP_New'

I am afraid that the .def file is needed for Windows :-( - because to
get that right, we would need to change the npapi.h header too; or is
that actually simpler than using the .def file in gbuild?

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] FOSDEM: LibreOffice dev-toom talks ...

2012-01-10 Thread Michael Meeks

Hi Christophe,

On Tue, 2012-01-10 at 10:58 +0100, Christophe Strobbe wrote:
> Is there another mailing list to find out what 
> the status of the program is, i.e. which talks 
> have been accepted, how long they can be, etc? I 
> have not seen this on the TDF-discuss list.

The plan (I think this was in the last ESC minutes) was to decide the
program & talk selection at this Thursday's ESC call.

> When I put all the submissions in a schedule with 
> just a one-hour lunch break in between, I get a very packed day...:

Always a good sign :-)

> (I just used the order from the wiki; I assume 
> there will be some reshuffling, but that is not up to me.)

I believe we're on the Saturday which is slightly shorter.

> (Apparently, the LibreOffice devroom has not been 
> scheduled yet: .)

Quite :-) we need to get cracking, quite probably we'll have to
select / weed out / shorten / lightning-ize some of the talks to fit
them into the time, and still have the emphasis on recruiting and
exciting new developers that we need at FOSDEM :-)

All the best,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-10 Thread julien2412

Thank you for the cherry picking Jan.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-About-enabling-Icedove-addressbook-connection-for-Base-tp3639069p3647676.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] announcement: --enable-mergelibs now makes a little sense

Hi all, Michael,

So, finally, It's possible to create merged lib, which is little
bigger then the biggest library now: sc (at least for me).
The list of merged libraries is in
solenv/gbuild/extensions/pre_MergedLibsList.mk .

If you want to add more, you could add sfx, sb, fwe, fwi, fwk, the
problem is discussed here:
http://nabble.documentfoundation.org/merging-libraries-problem-with-multiple-definitions-td3617486.html
And as the tail_build is growing there could be more merged.

It builds for me on Linux and also LibreOffice runs, I did not test much.
It should be easily possible to use --enable-mergelibs also on other platforms,
you will just need to add more libraries for linking in ./Library_merged.mk .

I'm not sure how much it's quicker now to start LibreOffice, probably
just a very little.
But Michael is looking forward to use also --enable-lto, which is
probably not possible now because of gcc errors.
We will see.

Thanks all for cooperation,

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] About enabling Icedove addressbook connection for Base

Hi Julien,

On 2012-01-10 at 01:51 -0800, julien2412 wrote:

> I'll be able to push this commit on 3.5 branch only tonight, after my day
> time job.

I've cherry-picked that to libreoffice-3-5 so that it's in in time for
the hard string freeze.

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED][PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-10 Thread Caolán McNamara

On Tue, 2012-01-10 at 13:13 +0100, Chr. Rossmanith wrote:
> Hi,
> 
> some more replacements for reviewing.

Looks good to me, pushed now. Though I decided to just 
replace EqualsIgnoreCaseAscii with equalsIgnoreAsciiCase because those
matchFoo things can be tricky.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED][GBUILD PATCH] merging libraries

On 10 January 2012 12:33, Bjoern Michaelsen
 wrote:
> Hi Matúš,
>
> On Sun, Jan 08, 2012 at 09:27:26PM +0100, Matúš Kukan wrote:
>> And I'm not sure about gb_LINKED_LIBS in LinkTarget.mk.
>> The horrible expression could be correct,
>> but it's probably not nice to have variable used that way there (but it is 
>> now).
>
> It looks to me like it does the right thing, so I'd think we should use it.
> Possibly one could add a $(sort) to prevent "merged" to be added to the linked
> libs multiple times.

Great, thanks.
I just pushed this without modification.
There can't be 'merged' multiple times,
I just need to prevent libraries which are going to be merged to
depend on 'merged' library.

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED-3-5] [PATCH] proposed fix for fdo#44533

2012-01-10 Thread Thorsten Behrens

> Will cherry-pick tomorrow. :)
>
Done.
 
-- Thorsten


pgpaxwYwYpnZs.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

On 10/01/12 09:52, Jan Holesovsky wrote:
> Hi,
> 
> On 2012-01-10 at 04:49 +, nthieb...@gmail.com wrote:
> 
>>   Box name: Win-x86@9-Voreppe Win32
>>   Machine: CYGWIN_NT-6.1-WOW64 VOREPPELIBO 1.7.9(0.237/5/3) 2011-03-29 10:10 
>> i686 Cygwin
> [...]
>> [ build CXX ] extensions/source/nsplugin/source/npshell.cxx
>> d:\master\extensions\source\nsplugin\source\npshell.hxx(81) : error C2143: 
>> syntax error : missing ';' before '*'
>> d:\master\extensions\source\nsplugin\source\npshell.hxx(81) : error C4430: 
>> missing type specifier - int assumed. Note: C++ does not support default-int
> 
> I have fixed this:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=23b1ba968f0e092d78e98bebcfcf662b8442d711
> 
> and restarted the build.
> 
> Probably I broke some visibility-related behavior in there; it built for
> me on Linux, but double-checking that the needed symbols are there on
> your architecture would be appreciated.

i had introduced the DLLPUBLIC in
a12ea5554bcd9ddc7d7f1915ed67f0dd86e062b6 to get rid of some weird .def
file that seemed to export those symbols on windows.

i suppose if these aren't exported then the plugin won't work, since
probably these are all looked up via dlopen or whatever it's Windows
equivalent is.

on Linux with your change i get only 3 symbols from that file exported,
and the others not.  perhaps MSVC complained that the
SAL_DLLPUBLIC_EXPORT is just in the wrong position or something, can you
investigate?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-10 Thread Chr. Rossmanith


Hi,

some more replacements for reviewing.

Christina
>From d3d92037c792cce79595bcae6f216c281303fad0 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith 
Date: Tue, 10 Jan 2012 10:42:55 +0100
Subject: [PATCH] Replace (Byte)String with rtl::O(U)String

---
 vcl/generic/print/genprnpsp.cxx  |   49 -
 vcl/generic/print/genpspgraphics.cxx |   16 ++-
 2 files changed, 33 insertions(+), 32 deletions(-)

diff --git a/vcl/generic/print/genprnpsp.cxx b/vcl/generic/print/genprnpsp.cxx
index 747b0ec..83b3418 100644
--- a/vcl/generic/print/genprnpsp.cxx
+++ b/vcl/generic/print/genprnpsp.cxx
@@ -83,7 +83,7 @@ extern "C"
 {
 typedef int(*setupFunction)(PrinterInfo&);
 static setupFunction pSetupFunction = NULL;
-typedef int(*faxFunction)(String&);
+typedef int(*faxFunction)(OUString&);
 static faxFunction pFaxNrFunction   = NULL;
 }
 
@@ -170,7 +170,7 @@ static void copyJobDataToJobSetup( ImplJobSetup* pJobSetup, JobData& rData )
 
 pJobSetup->mnPaperBin = 0;
 if( rData.m_pParser )
-pKey= rData.m_pParser->getKey( String( RTL_CONSTASCII_USTRINGPARAM( "InputSlot" ) ) );
+pKey= rData.m_pParser->getKey( OUString( RTL_CONSTASCII_USTRINGPARAM( "InputSlot" ) ) );
 if( pKey )
 pValue  = rData.m_aContext.getValue( pKey );
 if( pKey && pValue )
@@ -190,7 +190,7 @@ static void copyJobDataToJobSetup( ImplJobSetup* pJobSetup, JobData& rData )
 
 pJobSetup->meDuplexMode = DUPLEX_UNKNOWN;
 if( rData.m_pParser )
-pKey = rData.m_pParser->getKey( String( RTL_CONSTASCII_USTRINGPARAM( "Duplex" ) ) );
+pKey = rData.m_pParser->getKey( OUString( RTL_CONSTASCII_USTRINGPARAM( "Duplex" ) ) );
 if( pKey )
 pValue = rData.m_aContext.getValue( pKey );
 if( pKey && pValue )
@@ -231,7 +231,7 @@ static void copyJobDataToJobSetup( ImplJobSetup* pJobSetup, JobData& rData )
 
 // Needs a cleaner abstraction ...
 #if defined( UNX )
-static bool passFileToCommandLine( const String& rFilename, const String& rCommandLine, bool bRemoveFile = true )
+static bool passFileToCommandLine( const OUString& rFilename, const OUString& rCommandLine, bool bRemoveFile = true )
 {
 bool bSuccess = false;
 
@@ -315,19 +315,19 @@ static bool passFileToCommandLine( const String& rFilename, const String& rComma
 }
 #endif
 
-static bool sendAFax( const String& rFaxNumber, const String& rFileName, const String& rCommand )
+static bool sendAFax( const OUString& rFaxNumber, const OUString& rFileName, const OUString& rCommand )
 {
 #if defined( UNX )
 std::list< OUString > aFaxNumbers;
 
-if( ! rFaxNumber.Len() )
+if( rFaxNumber.isEmpty() )
 {
 getPaLib();
 if( pFaxNrFunction )
 {
-String aNewNr;
+OUString aNewNr;
 if( pFaxNrFunction( aNewNr ) )
-aFaxNumbers.push_back( OUString( aNewNr ) );
+aFaxNumbers.push_back( aNewNr );
 }
 }
 else
@@ -357,11 +357,10 @@ static bool sendAFax( const String& rFaxNumber, const String& rFileName, const S
 {
 while( aFaxNumbers.begin() != aFaxNumbers.end() && bSuccess )
 {
-String aCmdLine( rCommand );
-String aFaxNumber( aFaxNumbers.front() );
+OUString aCmdLine( rCommand );
+OUString aFaxNumber( aFaxNumbers.front() );
 aFaxNumbers.pop_front();
-while( aCmdLine.SearchAndReplace( String( RTL_CONSTASCII_USTRINGPARAM( "(PHONE)" ) ), aFaxNumber ) != STRING_NOTFOUND )
-;
+aCmdLine = comphelper::string::replace( aCmdLine, OUString( RTL_CONSTASCII_USTRINGPARAM( "(PHONE)" ) ), aFaxNumber );
 #if OSL_DEBUG_LEVEL > 1
 fprintf( stderr, "sending fax to \"%s\"\n", OUStringToOString( aFaxNumber, osl_getThreadTextEncoding() ).getStr() );
 #endif
@@ -381,12 +380,12 @@ static bool sendAFax( const String& rFaxNumber, const String& rFileName, const S
 #endif
 }
 
-static bool createPdf( const String& rToFile, const String& rFromFile, const String& rCommandLine )
+static bool createPdf( const OUString& rToFile, const OUString& rFromFile, const OUString& rCommandLine )
 {
 #if defined( UNX )
-String aCommandLine( rCommandLine );
-while( aCommandLine.SearchAndReplace( String( RTL_CONSTASCII_USTRINGPARAM( "(OUTFILE)" ) ), rToFile ) != STRING_NOTFOUND )
-;
+OUString aCommandLine( rCommandLine );
+aCommandLine = comphelper::string::replace( aCommandLine, OUString( RTL_CONSTASCII_USTRINGPARAM( "(OUTFILE)" ) ), rToFile );
+
 return passFileToCommandLine( rFromFile, aCommandLine );
 #else
 (void)rToFile; (void)rFromFile; (void)rCommandLine;
@@ -537,7 +536,7 @@ void PspSalInfoPrinter::InitPaperFormats( const ImplJobSetup* )
 
 if( m_aJobData.m_pParser )
 {
-const PPDKey* pKey = m_aJobData.m_pParser->getKey( String( RTL_CONSTASCII_USTRINGPARAM( "PageSize" ) ) );
+const PPDK

Re: [Libreoffice] [GBUILD PATCH] merging libraries

2012-01-10 Thread Bjoern Michaelsen

Hi Matúš,

On Sun, Jan 08, 2012 at 09:27:26PM +0100, Matúš Kukan wrote:
> And I'm not sure about gb_LINKED_LIBS in LinkTarget.mk.
> The horrible expression could be correct,
> but it's probably not nice to have variable used that way there (but it is 
> now).

It looks to me like it does the right thing, so I'd think we should use it.
Possibly one could add a $(sort) to prevent "merged" to be added to the linked
libs multiple times.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Translate German comments and fix some English ones

Hi Philipp,

On 2012-01-09 at 14:18 +0100, Philipp Weissenbacher wrote:

> Here are two more patches.

Thank you, pushed! :-)

> Patch #1 contains a few FIXMEs. That's where my creativity failed me
> and I just couldn't figure out what the original author meant.
> Thus, I'd greatly appreciate feedback.
> 
> In addition to translations patch #2 tries to fix some Denglish.
> 
> Also, my git foo failed me with merge conflicts and it's weird
> merge-conflict-syntax. So I did it twice (which improved the
> translation a bit).
> But I missed "MUSS noch optimiert werden"'s 14th birthday. :-( ;-)

Heh :-)

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] development summary: year 2012, week 01

Hi,

this time a brief summary of what happened during the 1st week in 2012
on LibreOffice repositories and the living branches:

+ master:LO-3.5 development
+ libreoffice-3-5:   fixes for LO-3.5.0 release
+ libreoffice-3-4:   fixes for potential LO-3.4.6 bug fix release
+ libreoffice-3-4-5: final stabilization of the LO-3.4.5 release

There are two logs for each branch:

+ bugfixes--week--.txt lists all commits that 
reference a proper
  bug id from a variety of trackers, i.e. #i... referring to the 
OpenOffice
  issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla

+ commit-log--week--.txt lists all relevant commits 
on the actual
  source repositories

Many thanks to all contributors - you make all the difference!


Best Regards,
Petr
+ base
+ missing icons in Index Design dialog (fdo#38435) [Andras Timar]
+ libs-core
+ fix hyphenation attributes: (fdo#44082) [Michael Stahl]
+ impress210: disconnect and reconnect to table style on change model in SdrTableObjImpl (i#117319) [Christian Lippka ORACLE]
+ oDF export: fix layout grid invalid ODF (fdo#44073) [Michael Stahl]
+ writer
+ label PRINTING misplaced on paper sheet (fdo#36874) [Winfried Donkers]
+ sw: temp selection print doc: (fdo#40482, fdo#39159) [Michael Stahl]
+ calc
+ return early on error in ScInterpreter::GetDBParam, (fdo#2) [Markus Mohrhard]
+ libs-core
+ fix (fdo#44065) [Julien Nabet]
+ impress210: disconnect and reconnect to table style on change model in SdrTableObjImpl (i#117319) [Christian Lippka ORACLE]
+ writer
+ label PRINTING misplaced on paper sheet (fdo#36874) [Winfried Donkers]
+ core
+ another missing null pointer check in multilinebar, (fdo#44518) [Markus Mohrhard]
+ basic function VAL produces bad result (fdo#44172) [August Sodora]
+ cherry pick fix for (fdo#44065) [Julien Nabet]
+ collection of problems causing loss of ole2 previews (fdo#43867) [Caolán McNamara]
+ deleting sheets should adjust drawing object pages as well. (fdo#44467) [Kohei Yoshida]
+ don't set document modified for copy and select all, (fdo#44423) [Markus Mohrhard]
+ fix - don't loop infinitely when using Apple Remote (fdo#33816) [Thorsten Behrens]
+ fix RTF import of implicit horizontal table cell merges (fdo#44053) [Miklos Vajna]
+ fix RTF import of vertically merged table cells (fdo#42151) [Miklos Vajna]
+ fix for Wrong position in Extension Mgr (FDO#44280) [Olivier Hallot]
+ fix for double hyphens (fdo#43931) [László Németh]
+ get external references to work with AND and OR. (fdo#36387) [Kohei Yoshida]
+ importing extLst of drawings in diagrams. (bnc#655408) [Muthu Subramanian]
+ make the data validation popup more reliable. (fdo#36851, bnc#737190) [Kohei Yoshida]
+ overlapped controls (fdo#44294) [Ivan Timofeev]
+ pack *.default files, too (fdo#43923) [Andras Timar]
+ rHEL-4 buildbox doesn't have FT_Library_SetLcdFilter (fdo#44219) [Caolán McNamara]
+ rTF: update layout (if present) before export (fdo#37161) [Miklos Vajna]
+ reintroduce fo:margin-* on top of fo:margin for backward compat (fdo#43862) [Cédric Bosdonnat]
+ related: header styles contain content like document body (fdo#43867) [Caolán McNamara]
+ return earlier from ScInterpreter::GetDBParams on error, (fdo#2) [Markus Mohrhard]
+ safer protection check... why using the layout for this? (fdo#40250) [Cédric Bosdonnat]
+ search for index entries in the whole document, not only the body (fdo#32726) [Cédric Bosdonnat]
+ update readme (fdo#37951) [Andras Timar]
+ core
+ add inital part for XDatabaseRange test, related (fdo#44167) [Markus Mohrhard]
+ add some tests related to (fdo#44587, fdo#42624) [Markus Mohrhard]
+ another missing null pointer check in multilinebar, (fdo#44518) [Markus Mohrhard]
+ basic function VAL produces bad result (fdo#44172) [August Sodora]
+ collection of problems causing loss of ole2 previews (fdo#43867) [Caolán McNamara]
+ deleting sheets should adjust drawing object pages as well. (fdo#44467) [Kohei Yoshida]
+ don't set document modified for copy and select all, (fdo#44423) [Markus Mohrhard]
+ don't show generic error message if a better one is available, (fdo#43911) [Markus Mohrhard]
+ easyhack remove SvStrings (fdo#38831) [Brad Sowden]
+ fix (fdo#44065) [Julien Nabet]
+ fix - don't loop infinitely when using Apple Remote (fdo#33816) [Thorsten Behrens]
+ fix RTF import of implicit horizontal table cell merges (fdo#44053) [Miklos Vajna]
+ fix for Wrong position in Extension Mgr (FDO#44280) [Olivier Hallot]
+ fix for bug New Math symbols issues in Windows (fdo#44110) [Olivier Hallot]
+ get external references to work with AND and OR. (fdo#36387) [Kohei Yoshida]
+ make the data validation popup more reliable. (fdo#36851, bnc#737190) [Kohei Yoshida]
+ overlapped controls (fdo#

Re: [Libreoffice] [Libreoffice-ux-advise] [REVIEW 3-5: Late feature][PUSHED-3-5] Improvements in the header / footer behavior

Jan Holesovsky píše v So 07. 01. 2012 v 04:34 +0100:
> Hi Cedric, all,
> 
> On 2012-01-05 at 17:06 +0100, Cedric Bosdonnat wrote:
> 
> > I'm all for it, but the following commits are fixing some side-effects
> > or UI weird things on this thread:
> 
> Thank you! :-)
> 
> > Show the page break tab under the mouse instead of the end of the line.
> > That fixes the UI problems mentioned in this thread.
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5807b07161d84ef105cc1a2292c8c1f09888e39f
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=965e72d64c3e38780a69cace3f1bcc5fb35d6c1e
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0fa723ed5761609d2c31061fdd0282a2f1df6e7
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a326395a48db313b907b4a35392216d7b2e2a11
> > 
> > Fixes for your commits:
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=fef489ad0f1f14bd9f018552c47a93a80e8b353d
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7d6bff10a85986e5e6ebfa961f29fa8b3815b40
> 
> 3 more commits; the most important is bringing back the delay before
> appearing of the controls (500ms instead of 1s):
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6abeafcd6a409c0910b19d1c935fe08431d66ae0
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa3bfbe776bcefd7e7b143e6843315df6b2a5ecb
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=60c968e9a2ef14aa289e677bd7f40d2c4724fd12
> 
> I hope / believe it is perfect now; or at least near to perfection :-)
> It also seems to me that the appearing when you use keyboard to navigate
> is gone too; but testing appreciated, of course.
> 
> So - do we want to get it into 3.5? ;-)

Kendy promised to fix the blinking and other potential issues in next
builds.

Otherwise, many people liked and wanted the feature: Cedric, Michael,
Cor, Astron, Ivan => I have pushed the two original commits and the 9
above mentioned fixes into libreoffice-3-5 branch for 3.5.0-beta3.

See also
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=77ec56689230606281c60b945f3d5edc1e97d7f7
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=cdd2364f23f92a3f63a551aa883b99cadf0bcf28
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=d3ea6fe7473049f421c1f72cde4bbd5c4c6348a9
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=0aff79354dc368e0c0a16070943b63c1ca91259d
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=5fb10a076a9192f8f37f6936231b742bae9ca44a
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a0347a9b94e2dc4ee1906341aa187d6a9f7749af
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=c17724737cc54fbecb32c510c437c4fda045d94b
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=6e3d9d601cf7a9f20a93eb8fc9abf5d8464eec28
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=d5143dba0fa2f6e47088a574cef1b6d626100841
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a5f59c3802199f01dfbce70b01183d4d0166c2f2
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=1e0de54d88a79c99f0671f608f7de096cb721537


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Updating Italian dictionaries

2012-01-10 Thread Andras Timar

Hi Andrea,

2012/1/9 Andrea Pescetti :
> On 05/01/2012 Andrea Pescetti wrote:
>>
>> On 05/01/2012 Andras Timar wrote:
>>>
>>> Why would you like to pack and distribute files from the legacy
>>> folder? Those look useless to end users.
>>
>>
>> Because they allow to see who contributed what and when. They are indeed
>> of little interest for end users (and the contributors' names, just the
>> names, are of course already listed in the README files), but it was a
>> specific request I received from previous contributors and it would be
>> fair to them to respect their wishes.
>>
>> Also, this allows to build a complete genealogy of the project, which is
>> better now that we have to maintain it in multiple repositories.
>
>
> I see that on the same day I wrote this (I didn't check if earlier or later)
> an incomplete update of dictionaries was done.
>
> While data are probably OK, I would prefer that the update it is completed
> according to my original mail, so that users won't be confused (thanks to
> the new CHANGELOG and README) and that anyone wishing to create derivatives
> of the package or its portions can easily find all history in the
> documentation in the "legacy" folder (and the will of earlier contributors
> is respected).
>
> The incomplete update has been ported to the 3.5 branch too, if I see
> correctly, so it would be nice to complete it there too.
>

I added legacy files to version control and I also updated the README
which I forgot to do last time. But legacy files will not be packaged
and distributed in the product, they will be part of source packages
only.

Please note that in LibreOffice git there is a newer version of
it_IT.aff than in svn, please check if it is correct. In svn you have
version 2.4, in git we have version 3.3. BTW both are the same, only
the comment sections at the beginning of the files are different.

Also please note that the extension icon, which is the Italian flag,
will not be used in LibreOffice, because we don't use national flags
as icons at all. I understand that probably nobody may be offended by
the Italian flag, but we shall make no exceptions.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] FOSDEM: LibreOffice dev-toom talks ...

2012-01-10 Thread Christophe Strobbe


Hi Michael, All,

At 14:41 15-11-2011, Michael Meeks wrote:

Hi guys,

The FOSDEM organisers have kindly agreed to dedicate a developer room
to LibreOffice development at the conference ( book now for 4-5 Feb
2012: http://fosdem.org/2012/ :-)

So - that means we're eager to get 
-technical- talks (FOSDEM really is

a true hackers conference), about LibreOffice its development, code
structure, how to get involved with easy hacks, QA tooling, l10n
improvements, etc. (...)

http://wiki.documentfoundation.org/Marketing/Events/Fosdem2012

And the TSC will decide on the program closer to the time. (...)


Is there another mailing list to find out what 
the status of the program is, i.e. which talks 
have been accepted, how long they can be, etc? I 
have not seen this on the TDF-discuss list.


When I put all the submissions in a schedule with 
just a one-hour lunch break in between, I get a very packed day...:
(I just used the order from the wiki; I assume 
there will be some reshuffling, but that is not up to me.)


09.00 - 09.45: Fridrich Strba - 'Import filters 
for LibreOffice: Join the journey'

09.45 - 10.30: Thorsten Behrens - 'Impress Hacking - The What & The Where'
10.30 - 11.15: C�dric Bosdonnat - 'Hacking Writer: what to know to get started'
11.15 - 12.00: Miklos Vajna & C�dric Bosdonnat - 'LPSP'
13.00 - 13.30: Italo Vignoli - 'LibreOffice Development Directions'
13.30 - 14.00: Italo Vignoli - 'Hacking LibreOffice Help for Tech Illiterates'
14.00 - 14.45: Christophe Strobbe - 
'Accessibility in LibreOffice: The Way Forward'
14.45 - 15.30: Markus Mohrhard - 'Test concepts 
for automated Libreoffice testing'

15.30 - 16.00: Jan Holesovsky / Kendy - 'LibreOffice debugging tricks'
16.00 - 16.30: Andreas Mantke - 'Improving 
LibreOffice Extensions- and Template-Center'
16.30 - 17.00: Michael Meeks - 'Easy Hacks - how 
to become a key LibreOffice contributor'
17.00 - 17.45: Stephan Bergmann - 'Analyzing 
LibreOffice through Compiler Plugins'


Lightning talks:
* Christophe Strobbe - 'AccessODF, An 
Accessibility Evaluation and Repair Extension for LibreOffice Writer'


(Apparently, the LibreOffice devroom has not been 
scheduled yet: .)


Best regards,

Christophe Strobbe


--
Christophe Strobbe
K.U.Leuven - Dept. of Electrical Engineering - SCD
Research Group on Document Architectures
Kasteelpark Arenberg 10 bus 2442
B-3001 Leuven-Heverlee
BELGIUM
tel: +32 16 32 85 51
http://www.docarch.be/
Twitter: @RabelaisA11y
---
Open source for accessibility: results from the 
AEGIS project www.aegis-project.eu

---
Please don't invite me to Facebook, Quechup or 
other "social networks". You may have agreed to 
their "privacy policy", but I haven't.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-10 Thread julien2412

I'll be able to push this commit on 3.5 branch only tonight, after my day
time job.
I think it's mainly (only ?) for Debian users :-) Obviously, meanwhile, it's
possible to create a symbolic link :
~/.icedove -> ~/.thunderbird

Anyway, I'll post a message here as soon as it's ok.

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-About-enabling-Icedove-addressbook-connection-for-Base-tp3639069p3647165.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-10 Thread Michael Meeks

Hi there,

On Mon, 2012-01-09 at 14:58 -0800, julien2412 wrote:
> Commited and pushed on master

Cool ! Mending Icedove integration seems more like a bug fix than a
feature to me; if you agree, it is working nicely & you anticipate few
problems :-) could you cherry pick your fixes to libreoffice-3-5 for
RC1 ?

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused DBG_WARNING{4, 5} macros, replaced DBG_WARNINGFILE.

2012-01-10 Thread David Tardon

On Tue, Jan 10, 2012 at 07:35:29AM +0100, David Tardon wrote:
> On Mon, Jan 09, 2012 at 07:01:26PM +0100, Marcel Metz wrote:
> > Hello lo-devs,
> > 
> > this patch removes the unused DBG_WARNING4 and DBG_WARNING5 macros and
> > replaces also the DBG_WARNINGFILE with SAL_INFO as suggested in the
> > tools/debug.hxx headers.
> 
> Pushed, thanks!
> 
> Btw, could you use git format-patch for exporting the patch the next
> time? It simplifies the committer's work a bit, as it already includes
> the author and commit message. We are a lazy bunch here and hate it when
> we have to copy them from email headers :-)

I take that back. One needs to save the whole message, not just the
attachment. Then it works as expected :-)

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]