RE: [Libreoffice] [REVIEW]Bug 34425 - [EasyHack] formatting background color toolbar button

2012-02-05 Thread Winfried Donkers
Stefan Knorr (Astron) wrote (3 februari 2012 21:24)

>Writer has two background colour functions, ... The
>highlighter is already a split button, but "Background Colour" is not.

>By the way, I've actually just discovered even more buttons that would
>be eligible for the split-button treatment...
>* In Writer's Table toolbar, there are buttons for Background Colour
>and Line Colour
>* Impress/Draw's Text Formatting toolbar contains a Font Colour button
>* Impress/Draw's Table toolbar also contains a Line Colour button
>* there are more places but those are probably less used/important,
>like the 3D-Settings toolbar(s)'s 3D Colour/Extrusion Colour
>(If you're feeling overwhelmed now, I'd offer to open bugs for all of
>the functions that I find, in the hope that someone, not necessarily
>you, converts them later.)

Please open bugs for each of these, you can put me as assignee. Should I
not be able to crack (split?) that button, I will remove my name and offer 
the bug to whoever sees opportinities.
But first I want to finish my work on bug 44516.

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-05 Thread Stephan Bergmann

On 02/05/2012 04:28 PM, Dag Wieers wrote:

On Fri, 3 Feb 2012, Stephan Bergmann wrote:

Apart from that, Dag, the only safe solution, in principle, is to use
a version of LO that is specificially built for the machine it is run
on (i.e., use a LO installation provided by the respective distro).


I agree, up to the point that I am mostly interested in RHEL5 and RHEL6
and that would mean... ... OpenOffice 3.1.1 or 3.2.1 :-/

But in general the official RPM packages work fine, and I think there's
a benefit in keeping this working (if practical possible).


Yes, I agree with all of that.  If we don't get --without-system-stdlibs 
into 3.5.0 final, maybe you can manage to get the two libs removed after 
installation (like give your customers a script that does that)?  Not a 
perfect solution, of course.



PS I am at FOSDEM and missed you twice at the booth. Can I offer a free
beer for your help ? :)


Oh what a shame.  But thanks for the kind offer.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED] Some more READMEs

2012-02-05 Thread Josh Heidenreich
Hi,

>        Nice work, pushed :-)

Cool so I've regenerated the docs again:
http://thejosh.info/libreoffice/module_readmes/

I guess this should go onto a cron - I'm waiting until cgit is back
before setting this up.

Cheers,
Josh
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


My contributions - licence

2012-02-05 Thread Josh Heidenreich
Hi All,

So it's clear, I am willing to dual-license all of my past, present
and future contributions to LibreOffice under the MPL/LGPLv3+.

Cheers,
Josh
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Some more READMEs

2012-02-05 Thread Michael Meeks
Hi Josh,

On Mon, 2012-02-06 at 13:25 +1030, Josh Heidenreich wrote:
> Here are some more READMEs for the modules.

Thanks for that :-)

> This covers mostly just URE stuff, copied from:
> http://wiki.documentfoundation.org/Development/Code_Overview

Great.

> It introduces a little bit of syntax (for linking to cgit and urls).

Even better; I'm rather excited about this as a nucleus of goodness for
adding more documentation to make the code easier to grok & follow.

Nice work, pushed :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tail_build is a discouraging PITA

2012-02-05 Thread Michael Meeks

On Sun, 2012-02-05 at 19:14 -0200, Olivier Hallot wrote:
> I missed ccache when I reformatted my partition some months ago..

Heh - glad it's sorted out.

tail_build is actually a huge meta-module that aggregates a lot of
other modules using gnumake - so we can speed up the build by building
massively parallely and processing / statting dependencies just once.

Checkout solenv/gbuild/extensions/pre_MergedLibsList.mk for the list of
libraries merged into one here. We hope to merge more in future - and to
do more aggressive LTO - that will slow down linking, but hopefully
speed up each run & shrink the size.

Hope you got your build going :-)

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Some more READMEs

2012-02-05 Thread Josh Heidenreich
Hi all,

Here are some more READMEs for the modules.

This covers mostly just URE stuff, copied from:
http://wiki.documentfoundation.org/Development/Code_Overview

It introduces a little bit of syntax (for linking to cgit and urls).

Cheers,
Josh


0001-Added-READMEs-for-modules-related-to-URE-with-conten.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Fix for a compile issue I was having in l10ntools (GCC 4.4.3, Ubuntu)

2012-02-05 Thread Josh Heidenreich
Hi,

I had some trouble compiling LibO the other day, a syntax error.
I found someone had had a similar problem in the list archvies, so I
did a fix in the same way they did theirs.

Cheers,
Josh


0001-Single-line-bugfix-in-l10n-tools-to-fix-compile-on-G.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-05 Thread Norbert Thiebaud
HI all,

I have pushed a series of commit that completely remove set_soenv.in
and the creation of Env.Host.sh/Env.Build.sh

The following wiki page give some explanations:
http://wiki.documentfoundation.org/Development/Build_in_3.6

in a nutshell:

For 'user'

Env.Host.sh is no more
All the environment is in config_host.mk. this file is _not_
sourceable, but is included in the appropriate makefiles.

if you do full build, nothing changes. To do partial build there is no
need to cd to the module directory. Now you can (and for dmake module
you must) do:
make 
or
make .clean
from the root directory.

for dmake module you can also do:
make .deliver

If you have the need to run a specific command that is not covered by
the standard target, but need to have all the environment variable
set, you can do:
make cmd cmd=""

in doubt do:
make help

for 'dev'
set_soenv.in is removed. all config forwarding is done in
config_host.mk.in which is _not_ a shell-script but a Makefile part.
please keep config_host.mk.in in alphabetical order

All configuration logic must be in configuration.in

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ANN] LibreOffice 3.5.0 RC3 available

2012-02-05 Thread Thorsten Behrens
Dear Community,

The Document Foundation is happy to announce the third release
candidate of LibreOffice 3.5.0. The upcoming 3.5 will be our third
major release line, packed with many exciting new features. Please be
aware that LibreOffice 3.5.0 RC3 is not ready for production use, you
should continue to use LibreOffice 3.4.5 for that.

The release is available for Windows, Linux and Mac OS X from our QA
builds download page at

  http://www.libreoffice.org/download/pre-releases/

A note for Windows users: this Release Candidate will uninstall your
current stable build and replace it. If you do not wish this to happen
but still would like to test, you should follow the instructions for
installing in parallel:

 http://wiki.documentfoundation.org/Installing_in_parallel

Should you find bugs, please report them to the FreeDesktop Bugzilla:

  https://bugs.freedesktop.org

A good way to assess the RC3 quality is to run some specific manual
tests on it, our TCM wiki page has more details:

 
http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test

 (and the announcement mail: 
http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html)
 
For other ways to get involved with this exciting project - you can
e.g. contribute code:

  https://www.libreoffice.org/get-involved/developers/

translate LibreOffice to your language:

  http://wiki.documentfoundation.org/Translation_for_3.5

or help with funding our operations:

  http://challenge.documentfoundation.org/

A list of known issues with 3.5.0 RC3 is available from our wiki:

  http://wiki.documentfoundation.org/Releases/3.5.0/RC3

Please find the list of changes against LibreOffice 3.5.0 RC2 here:

  
http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-5-0-release-3.5.0.3.log

Let us close again with a BIG Thank You! to all of you having
contributed to the LibreOffice project - this release would not have
been possible without your help.

Yours,

The Document Foundation Board of Directors


pgp28eCw6QqBV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


How far can the LO file's contents be stretched?

2012-02-05 Thread Johannes Sixt
The native file format of LO files is simply a ZIP archive with various
types of files in it.

I intend to do some gymnastics with the ZIP files and the XML in them,
and I would like to know how far it can be stretched ;) In particular, I
want to explode the archive into git tree, mangle its contents in
various ways, and then generate an ODF file from the tree using git-archive.

Specifically:

1. Is the order of the files in the ZIP archive important? For example,
unzip -l lists the following:

   39  02-02-2012 21:28   mimetype
...
  899  02-02-2012 21:28   manifest.rdf
...
 6699  02-02-2012 21:28   Object 44/settings.xml
  457  02-02-2012 21:28   Object 44/content.xml
   711200  02-02-2012 21:28   styles.xml
...
  155  02-02-2012 21:28   Pictures/100B000E248D8E65.png
...
  402  02-02-2012 21:28   ObjectReplacements/Object 44
...
 2572  02-02-2012 21:28   Thumbnails/thumbnail.png
...
 1347  02-02-2012 21:28   meta.xml
23040  02-02-2012 21:28   Object 6
  3094362  02-02-2012 21:28   content.xml
10636  02-02-2012 21:28   settings.xml
...
22302  02-02-2012 21:28   META-INF/manifest.xml

When I package the resulting git tree with git-archive, it will be
sorted by ASCII codes:

META-INF/manifest.xml
Object 44/content.xml
Object 44/settings.xml
Object 6
ObjectReplacements/Object 44
Pictures/100B000E248D8E65.png
Thumbnails/thumbnail.png
content.xml
manifest.rdf
meta.xml
mimetype
settings.xml
styles.xml

Will this be a problem?

2) Another side effect of the detour via git will be that empty folders
will be absent in the package resulting from git-archive:

0  02-02-2012 21:28   Object 7/popupmenu/
 6698  02-02-2012 21:28   Object 7/settings.xml
0  02-02-2012 21:28   Object 7/toolpanel/
  365  02-02-2012 21:28   Object 7/content.xml
0  02-02-2012 21:28   Object 7/statusbar/
0  02-02-2012 21:28   Object 7/progressbar/
0  02-02-2012 21:28   Object 7/toolbar/
0  02-02-2012 21:28   Object 7/floater/
0  02-02-2012 21:28   Object 7/menubar/

will become

  365  02-02-2012 21:28   Object 7/content.xml
 6698  02-02-2012 21:28   Object 7/settings.xml

in the result. Again, is it a problem?

3) Can the styles listed in an  section be
renamed? For example:

 

would be renamed to

 

(All references of "P4" in  and elsewhere would be renamed
accordingly, of course.)

Thanks for your response,
-- Hannes
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: PATCH build errors on Ubuntu 10.04

2012-02-05 Thread Norbert Thiebaud
On Sun, Feb 5, 2012 at 12:05 PM, Gert van Valkenhoef
 wrote:
> Dear LibreOffice developers,
> 2) There is no build-dep on doxygen (ppa libreoffice), but LibreOffice won't
> build without it

it will if you specify --without-doxygen

but sure, it would be nice if the distribution's dep package would
pull it automatically... (and the wiki should prolly be updated too)

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tail_build is a discouraging PITA

2012-02-05 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Ivan...

I want to apologize for the rant on my original message, I should have
turned my tongue 7 times in my mouth before.

I missed ccache when I reformatted my partition some months ago..

Thank you very much inded Ivan, for fixing DBG and for ccache notice.
You are my Hero!

Regards

Olivier

Em 05-02-2012 16:16, Ivan Timofeev escreveu:
> 05.02.2012 15:15, Ivan Timofeev пишет:
>> remove the surrounding ifdef and then the linker should find this
>> function.
> 
> I committed this change. Don't know why I didn't commit it at that time.
> %-|
> 
> By the way...
> 
> 05.02.2012 02:13, Olivier Hallot пишет:
>> All fail in tail_build, a module that takes hours to build.
> 
> Have you ccache installed? It may relieve the pain in such cases.
> 
> All the best,
> Ivan

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPLvE+AAoJEJp3R7nH3vLxeK8IAI8eClBH3qx5XVQLqWJ5Hh/i
wwGBnU2v9io5Ukmree5ldNlMCMQ4Cec6WAdZ6oQ10QRqrftcETF2Zw51gU1xRvUj
k4kSpROSGjsDMOLOOivpQ6JTfp+XxdsWbO2KHtx+DoAsCo8+MN9kfNLgwj1Mflkj
mMBXqX/XJnPJUl83M1cq0MaZFYJ1yjptjJb1L7vE1WLPy16Q5gZH0WWigpLDXCdm
+jJDE/VUnP3ycU51CjNQ3JW5T98hdJ+uJaZJ+tv0RWtnWU1AJVRA9WJg3liDCSfY
e1iXG3SNoJaS0csK/VXlIGobPlngQRFZGOQkPVTzjj01JQV0sebFj+hLh4RvemM=
=RiA2
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith

Am 05.02.2012 20:52, schrieb Ivan Timofeev:

05.02.2012 23:37, Chr. Rossmanith пишет:

I've moved them to a method ResData2Output(). Please review.


Looks nice. All of the differences seem to be handled...


Oh, oh, oh! No, we must pass all the different values as paramerers to 
the function.
I've added a third parameter nType to ResData2Output() (s. reworked 
attached patch) and included the additional modifications (Semikolon 
etc.) as well.


Christina
>From 1c8b5f39b2deb13612b6603e04dc4d02c2cb5c7e Mon Sep 17 00:00:00 2001
From: Christina Rossmanith 
Date: Sun, 5 Feb 2012 15:03:30 +0100
Subject: [PATCH] Reduced duplicate code (simian) / l10ntools

---
 l10ntools/inc/export.hxx|2 +-
 l10ntools/source/export.cxx |  208 ++-
 2 files changed, 67 insertions(+), 143 deletions(-)

diff --git a/l10ntools/inc/export.hxx b/l10ntools/inc/export.hxx
index e0fcf05..750ca68 100644
--- a/l10ntools/inc/export.hxx
+++ b/l10ntools/inc/export.hxx
@@ -354,7 +354,7 @@ private:
 
 sal_Bool PrepareTextToMerge(ByteString &rText, sal_uInt16 nTyp,
 rtl::OString &rLangIndex, ResData *pResData);
-
+void ResData2Output( PFormEntrys *pEntry, ResData *pResData, sal_uInt16 nType );
 void MergeRest( ResData *pResData, sal_uInt16 nMode = MERGE_MODE_NORMAL );
 void ConvertMergeContent( ByteString &rText );
 
diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index 8909a1e..4c8eb98 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -1891,6 +1891,65 @@ sal_Bool Export::PrepareTextToMerge(ByteString &rText, sal_uInt16 nTyp,
 return sal_True;
 }
 
+void Export::ResData2Output( PFormEntrys *pEntry, ResData *pResData, sal_uInt16 nType )
+{
+sal_Bool bAddSemicolon = sal_False;
+sal_Bool bFirst = sal_True;
+ByteString sCur;
+
+for( unsigned int n = 0; n < aLanguages.size(); n++ ){
+sCur = aLanguages[ n ];
+
+ByteString sText;
+sal_Bool bText = pEntry->GetTransex3Text( sText, nType, sCur , sal_True );
+if ( bText && sText.Len() && sText != "-" ) {
+ByteString sOutput;
+if ( bNextMustBeDefineEOL)  {
+if ( bFirst )
+sOutput += "\t\\\n";
+else
+sOutput += ";\t\\\n";
+}
+bFirst=sal_False;
+sOutput += "\t";
+
+if ( pResData->bText )
+sOutput += pResData->sTextTyp;
+else if ( pResData->bQuickHelpText )
+sOutput += "QuickHelpText";
+else if ( pResData->bTitle )
+sOutput += "Title";
+
+if ( ! Export::isSourceLanguage( sCur ) ) {
+sOutput += "[ ";
+sOutput += sCur;
+sOutput += " ] ";
+}
+sOutput += "= ";
+ConvertMergeContent( sText );
+sOutput += sText;
+
+if ( bDefine )
+sOutput += ";\\\n";
+else if ( !bNextMustBeDefineEOL )
+sOutput += ";\n";
+else
+bAddSemicolon = sal_True;
+for ( sal_uInt16 j = 1; j < nLevel; j++ )
+sOutput += "\t";
+WriteToMerged( sOutput , true );
+}
+}
+
+
+if ( bAddSemicolon ) {
+ByteString sOutput( ";" );
+WriteToMerged( sOutput , false );
+}
+
+return;
+}
+
 /*/
 void Export::MergeRest( ResData *pResData, sal_uInt16 nMode )
 /*/
@@ -1909,152 +1968,17 @@ void Export::MergeRest( ResData *pResData, sal_uInt16 nMode )
 case MERGE_MODE_NORMAL : {
 PFormEntrys *pEntry = pMergeDataFile->GetPFormEntrys( pResData );
 
-bool bWriteNoSlash = false;
-if ( pEntry && pResData->bText ) {
-
-sal_Bool bAddSemikolon = sal_False;
-sal_Bool bFirst = sal_True;
-ByteString sCur;
-ByteString sTmp = Export::sLanguages;
+if ( pEntry ) {
+if ( pResData->bText )
+ResData2Output( pEntry, pResData, STRING_TYP_TEXT );
 
-for( unsigned int n = 0; n < aLanguages.size(); n++ ){
-sCur = aLanguages[ n ];
+if ( pResData->bQuickHelpText )
+ResData2Output( pEntry, pResData, STRING_TYP_QUICKHELPTEXT );
 
-ByteString sText;
-sal_Bool bText = pEntry->GetTransex3Text( sText, STRING_TYP_TEXT, sCur , sal_True );
-if ( bText && sText.Len() && sText != "-" ) {
-ByteString sOutput;
-if ( bNextMustBeDefineEOL)  {
-if ( bFirst )
-sOutput += "\t\\\n";
-else
-  

l10ntools: GetXrmFile() nearly equal to GetCfgFile()

2012-02-05 Thread Chr. Rossmanith

Hi,

simian detected 21 duplicate lines in the following files:
l10ntools/source/xrmmerge.cxx
l10ntools/source/cfgmerge.cxx

But as far as I can see the methods GetXrmFile() and GetCfgFile() seem 
to be copy&pasted with minor modifications for ByteString removal and an 
additional exit(-13). It might be enough to have one of them and rename 
it to match both usages in lex files?


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Ivan Timofeev

05.02.2012 23:37, Chr. Rossmanith пишет:

I've moved them to a method ResData2Output(). Please review.


Looks nice. All of the differences seem to be handled...


Oh, oh, oh! No, we must pass all the different values as paramerers to 
the function.


Because it was

if ( pEntry && pResData->bText ) {
...
}
if ( pEntry && pResData->bQuickHelpText ) {
...
}
if ( pEntry && pResData->bTitle ) {
...
}

, but not "if - else if - else if"; and thus nType and sOutput will be 
always the same in these 3 calls to ResData2Output.


I'm sorry...

Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith

Hi,



I've moved them to a method ResData2Output(). Please review.


Looks nice. All of the differences seem to be handled...

> bWriteNoSlash seems to be always false
I'll add this to the patch and wait until I get feed back wrt the test 
question (s. below) before I'll push.


Yes. And ByteString sTmp is unused.

I'll add this as well.



Maybe the spelling of Semikolon should be changed while at it...


Yes, I think.

And this one...



and ByteString->rtl::OString...


I think it should be separated... :)

Of course.


Hmm, interesting, where we can test the "new" code, just in case?
That must be answered by someone else. "make unitcheck" is on its way 
but I don't know if l10ntools has unittests...


Christina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Ivan Timofeev

Hi Christina,

05.02.2012 20:26, Chr. Rossmanith пишет:

there were three blocks of nearly identical code.


Awful! Thanks for working on this task.


I've moved them to a method ResData2Output(). Please review.


Looks nice. All of the differences seem to be handled...

> bWriteNoSlash seems to be always false

Yes. And ByteString sTmp is unused.


Maybe the spelling of Semikolon should be changed while at it...


Yes, I think.


and ByteString->rtl::OString...


I think it should be separated... :)

Hmm, interesting, where we can test the "new" code, just in case?

Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


PATCH build errors on Ubuntu 10.04

2012-02-05 Thread Gert van Valkenhoef

Dear LibreOffice developers,

I've checked out the LibreOffice git repository and followed the build 
instructions. This revealed two problems:


1) Compile error in l10ntools/source/lngex.cxx (see below)
2) There is no build-dep on doxygen (ppa libreoffice), but LibreOffice 
won't build without it


The compile error:

Compiling: l10ntools/source/lngex.cxx
/home/gert/tmp/libreoffice-core/l10ntools/source/lngex.cxx: In function 
'sal_Bool ParseCommandLine(int, char**)':
/home/gert/tmp/libreoffice-core/l10ntools/source/lngex.cxx:77: error: 
parameter may not have variably modified type 'rtl::OString [(((unsigned 
int)(((int)i) + -0x1)) + 1)]'

dmake:  Error code 1, while making '../unxlngi6.pro/obj/lngex.obj'

I've attached a patch that fixes the symptom (it does an explicit type 
cast). You may prefer a different fix. After this the build was successful.


Best wishes,

Gert van Valkenhoef
diff --git a/l10ntools/source/lngex.cxx b/l10ntools/source/lngex.cxx
index e921a74..b4cfb18 100644
--- a/l10ntools/source/lngex.cxx
+++ b/l10ntools/source/lngex.cxx
@@ -74,7 +74,7 @@ sal_Bool ParseCommandLine( int argc, char* argv[])
 
 // parse command line
 for( int i = 1; i < argc; i++ ) {
-rtl::OString sSwitch(rtl::OString(argv[i]).toAsciiUpperCase());
+rtl::OString sSwitch((rtl::OString)rtl::OString(argv[i]).toAsciiUpperCase());
 if (sSwitch.equalsL(RTL_CONSTASCII_STRINGPARAM("-I")))
 nState = STATE_INPUT; // next tokens specifies source files
 else if (sSwitch.equalsL(RTL_CONSTASCII_STRINGPARAM("-O")))
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Remove unused System V oslSemaphore implementation

2012-02-05 Thread Francois Tigeot
sal/osl/unx/semaphor.c contains two separate implementations of the
osl*Semaphore synchronization functions:

- a pthread one (used by default)
- an alternative one based on System V semaphores

The alternative System V implementation is only used if the macro
OSL_USE_SYS_V_SEMAPHORE is defined, which is never the case.

Since it is never used, we may as well remove it. Patch attached.

I thought it would be best to not remove such an important piece of code
without some discussion first.

-- 
Francois Tigeot
>From fb6b17a9e8198d6a81367af7aca48757f2ba2bc1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Tigeot?= 
Date: Sun, 5 Feb 2012 19:04:46 +0100
Subject: [PATCH] OSL_USE_SYS_V_SEMAPHORE is never defined

* Remove the System V semaphore implementation variant

* POSIX thread-local code was always used for synchronization
  primitives anyway
---
 sal/osl/unx/semaphor.c |  181 
 1 files changed, 0 insertions(+), 181 deletions(-)

diff --git a/sal/osl/unx/semaphor.c b/sal/osl/unx/semaphor.c
index 7cb375f..b38113b 100644
--- a/sal/osl/unx/semaphor.c
+++ b/sal/osl/unx/semaphor.c
@@ -32,8 +32,6 @@
 #include 
 #include 
 
-#ifndef OSL_USE_SYS_V_SEMAPHORE
-
 /* This is the (default) POSIX thread-local semaphore variant */
 
 /*
@@ -134,183 +132,4 @@ sal_Bool SAL_CALL osl_releaseSemaphore(oslSemaphore 
Semaphore) {
 return sal_False;
 }
 
-#else /* OSL_USE_SYS_V_SEMAPHORE */
-
-/***/
-
-/* This is the SYS V private semaphore variant */
-
-/*
-Implemetation notes:
-The void* represented by oslSemaphore is used
-as a pointer to an osl_TSemImpl struct
-*/
-
-
-#if defined(NETBSD)
-union semun {
-int val;/* value for SETVAL */
-struct  semid_ds *buf;  /* buffer for IPC_STAT & IPC_SET */
-u_short *array; /* array for GETALL & SETALL */
-};
-#endif
-
-typedef struct _osl_TSemImpl
-{
-  int m_Id;
-
-} osl_TSemImpl;
-
-/*/
-/* osl_createSemaphore  */
-/*/
-oslSemaphore SAL_CALL osl_createSemaphore(sal_uInt32 initialCount)
-{
-union semun arg;
-
-oslSemaphore Semaphore;
-osl_TSemImpl* pSem;
-
-Semaphore= malloc(sizeof(osl_TSemImpl));
-OSL_POSTCOND(Semaphore, "malloc failed\n"); /* ptr valid? */
-
-pSem= (osl_TSemImpl*)Semaphore;
-
-
-/* unnamed (private) semaphore */
-
-   pSem->m_Id= semget(IPC_PRIVATE, 1, 0666 | IPC_CREAT);
-
-
-/* create failed? */
-if (pSem->m_Id < 0)
-{
-OSL_TRACE("osl_createSemaphore failed (semget). Errno: %d; %s\n",
-   errno,
-   strerror(errno));
-
-free(Semaphore);
-return 0;
-}
-
-/* set initial count */
-
-arg.val= initialCount;
-
-if(semctl(pSem->m_Id, 0, SETVAL, arg) < 0)
-{
-OSL_TRACE("osl_createSemaphore failed (semctl(SETVAL)). Errno: %d; 
%s\n",
-   errno,
-   strerror(errno));
-
-if(semctl(pSem->m_Id, 0, IPC_RMID, arg) < 0)
-{
-OSL_TRACE("semctl(IPC_RMID) failed. Errno: %d; %s", errno, 
strerror(errno));
-}
-
-free(Semaphore);
-return 0;
-}
-
-
-return Semaphore;
-}
-
-/*/
-/* osl_destroySemaphore  */
-/*/
-void SAL_CALL osl_destroySemaphore(oslSemaphore Semaphore) {
-
-if(Semaphore)   /* ptr valid? */
-{
-union semun arg;
-
-osl_TSemImpl* pSem= (osl_TSemImpl*)Semaphore;
-
-if(semctl(pSem->m_Id, 0, IPC_RMID, arg) < 0)
-
-{
-OSL_TRACE("osl_destroySemaphore failed. (semctl(IPC_RMID)). Errno: 
%d; %s\n",
-   errno,
-   strerror(errno));
-}
-
-free(Semaphore);
-}
-}
-
-/*/
-/* osl_acquireSemaphore  */
-/*/
-sal_Bool SAL_CALL osl_acquireSemaphore(oslSemaphore Semaphore) {
-
-/* abort in debug mode */
-OSL_PRECOND(Semaphore != 0, "Semaphore not created\n");
-
-
-if (Semaphore != 0) /* be tolerant in release mode */
-{
-struct sembuf op;
-osl_TSemImpl* pSem= (osl_TSemImpl*)Semaphore;
-
-op.sem_num= 0;
-op.sem_op= -1;
-op.sem_flg= SEM_UNDO;
-
-return semop(pSem->m_Id, &op, 1) >= 0;
-
-}
-
-return sal_False;
-}
-
-/*/
-/* osl_tryToAcquireSemaphore  */
-/*/
-sal_Bool SAL_CALL osl_tryToAcquireSemaphore(oslSemaphore Sema

Re: tail_build is a discouraging PITA

2012-02-05 Thread Ivan Timofeev

05.02.2012 15:15, Ivan Timofeev пишет:

remove the surrounding ifdef and then the linker should find this function.


I committed this change. Don't know why I didn't commit it at that time. %-|

By the way...

05.02.2012 02:13, Olivier Hallot пишет:

All fail in tail_build, a module that takes hours to build.


Have you ccache installed? It may relieve the pain in such cases.

All the best,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED][PATCH] Remove unused code (3)

2012-02-05 Thread Ivan Timofeev

pushed this one after all.

SfxMedium::GetHdl() seems to be used for now (in 
tools/inc/tools/ref.hxx), maybe we can remove all of those macro 
definitions...


I also removed 'using SfxControllerItem::GetCoreMetric;' statement from 
sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded.


Thanks,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith

Hi,

there were three blocks of nearly identical code. I've moved them to a 
method ResData2Output(). Please review. Maybe the spelling of Semikolon 
should be changed while at it...and ByteString->rtl::OString...


Christina
>From e2fafab4ecc750377c93fb99c45b0d248e8bc448 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith 
Date: Sun, 5 Feb 2012 15:03:30 +0100
Subject: [PATCH] Reduced duplicate code (simian) / l10ntools

---
 l10ntools/inc/export.hxx|2 +-
 l10ntools/source/export.cxx |  222 ---
 2 files changed, 81 insertions(+), 143 deletions(-)

diff --git a/l10ntools/inc/export.hxx b/l10ntools/inc/export.hxx
index e0fcf05..e427bb8 100644
--- a/l10ntools/inc/export.hxx
+++ b/l10ntools/inc/export.hxx
@@ -354,7 +354,7 @@ private:
 
 sal_Bool PrepareTextToMerge(ByteString &rText, sal_uInt16 nTyp,
 rtl::OString &rLangIndex, ResData *pResData);
-
+void ResData2Output( PFormEntrys *pEntry, ResData *pResData );
 void MergeRest( ResData *pResData, sal_uInt16 nMode = MERGE_MODE_NORMAL );
 void ConvertMergeContent( ByteString &rText );
 
diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index 8909a1e..2df9ab6 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -1891,6 +1891,79 @@ sal_Bool Export::PrepareTextToMerge(ByteString &rText, sal_uInt16 nTyp,
 return sal_True;
 }
 
+void Export::ResData2Output( PFormEntrys *pEntry, ResData *pResData )
+{
+sal_Bool bAddSemikolon = sal_False;
+sal_Bool bFirst = sal_True;
+ByteString sCur;
+ByteString sTmp = Export::sLanguages;
+sal_uInt16 nType;
+bool bWriteNoSlash = false; // could be removed if if-statement below is removed
+
+for( unsigned int n = 0; n < aLanguages.size(); n++ ){
+sCur = aLanguages[ n ];
+
+ByteString sText;
+if ( pResData->bText )
+nType = STRING_TYP_TEXT;
+if ( pResData->bQuickHelpText )
+nType = STRING_TYP_QUICKHELPTEXT;
+if ( pResData->bTitle )
+nType = STRING_TYP_TITLE;
+
+sal_Bool bText = pEntry->GetTransex3Text( sText, nType, sCur , sal_True );
+if ( bText && sText.Len() && sText != "-" ) {
+ByteString sOutput;
+if ( bNextMustBeDefineEOL)  {
+if ( bFirst )
+sOutput += "\t\\\n";
+else
+sOutput += ";\t\\\n";
+}
+bFirst=sal_False;
+sOutput += "\t";
+
+if ( pResData->bText )
+sOutput += pResData->sTextTyp;
+else if ( pResData->bQuickHelpText )
+sOutput += "QuickHelpText";
+else if ( pResData->bTitle )
+sOutput += "Title";
+
+if ( ! Export::isSourceLanguage( sCur ) ) {
+sOutput += "[ ";
+sOutput += sCur;
+sOutput += " ] ";
+}
+sOutput += "= ";
+ConvertMergeContent( sText );
+sOutput += sText;
+
+if ( pResData->bText ) {
+if ( bDefine && bWriteNoSlash ) // bWriteNoSlash seems to be always false
+sOutput += ";\n";
+}
+if ( bDefine )
+sOutput += ";\\\n";
+else if ( !bNextMustBeDefineEOL )
+sOutput += ";\n";
+else
+bAddSemikolon = sal_True;
+for ( sal_uInt16 j = 1; j < nLevel; j++ )
+sOutput += "\t";
+WriteToMerged( sOutput , true );
+}
+}
+
+
+if ( bAddSemikolon ) {
+ByteString sOutput( ";" );
+WriteToMerged( sOutput , false );
+}
+
+return;
+}
+
 /*/
 void Export::MergeRest( ResData *pResData, sal_uInt16 nMode )
 /*/
@@ -1909,152 +1982,17 @@ void Export::MergeRest( ResData *pResData, sal_uInt16 nMode )
 case MERGE_MODE_NORMAL : {
 PFormEntrys *pEntry = pMergeDataFile->GetPFormEntrys( pResData );
 
-bool bWriteNoSlash = false;
-if ( pEntry && pResData->bText ) {
-
-sal_Bool bAddSemikolon = sal_False;
-sal_Bool bFirst = sal_True;
-ByteString sCur;
-ByteString sTmp = Export::sLanguages;
+if ( pEntry ) {
+if ( pResData->bText )
+ResData2Output( pEntry, pResData );
 
-for( unsigned int n = 0; n < aLanguages.size(); n++ ){
-sCur = aLanguages[ n ];
+if ( pResData->bQuickHelpText )
+ResData2Output( pEntry, pResData );
 
-ByteString sText;
-sal_Bool bText = pEntry->GetTransex3Text( sText, STRING_TYP_TEXT, sCur , sal_True );
-if ( bText && sText.Len() && sT

Re: [PUSHED 3-5] fix various overlapped controls in the Options dialog

2012-02-05 Thread Andras Timar
Hi Ivan,

2012/2/5 Ivan Timofeev :
> Hi,
>
> There are some small UI fixes in 1535eed3d40d9741f3cdf68d32bc132e2a39f287 on
> master:
>

Pushed, thanks.
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] LibO 3.5RC2: terminate called after throwing an instance of 'com::sun::star::registry::InvalidRegistryException'

2012-02-05 Thread Dag Wieers

On Fri, 3 Feb 2012, Stephan Bergmann wrote:

The secret is that the LO installation sets available from 
 are built with implicit 
--without-system-stdlibs, so they bring along ure/lib/libgcc_s.so.1 and 
ure/lib/libstdc++.so.6 (which the programs in the LO installation, like 
program/soffice.bin and program/python.bin, pick up at runtime).


For reasons that still escape me, this causes exception-handling trouble for 
LO 3.5 program/python (which happens to set LD_LIBRARY_PATH, maybe that makes 
a difference), but apparently not for LO 3.5 program/soffice, nor reportedly 
for LO 3.4 program/python (as reported by Dag).


Right, loading the uno module using /opt/libreoffice3.5/program/python.bin 
works. (Except it fails in other ways that require LD_LIBRARY_PATH, e.g. 
/opt/libreoffice3.5/program/pyuno.so: undefined symbol: PyUnicodeUCS2_GetSize)



Removing /opt/libreoffice3.5/ure/lib/libgcc_s.so.1 and 
/opt/libreoffice3.5/ure/lib/libstdc++.so.6 made the problem go away for me on 
Fedora 16 x86_64.


Petr, the best approach might be to build the "official" Linux LO 
installation sets with explicit --with-system-stdlibs, so that the 
installation sets do not bring along their own libgcc_s.so.1 and 
libstdc++.so.6.  If the installation sets are built on a sufficiently old 
baseline system, it should be a pretty safe bet that each box on which they 
are installed bring along sufficiently new versions of those libs as part of 
the system.


Would that be possible before the 3.5 release ?


Apart from that, Dag, the only safe solution, in principle, is to use a 
version of LO that is specificially built for the machine it is run on (i.e., 
use a LO installation provided by the respective distro).


I agree, up to the point that I am mostly interested in RHEL5 and RHEL6 
and that would mean...   ... OpenOffice 3.1.1 or 3.2.1 :-/


But in general the official RPM packages work fine, and I think there's a 
benefit in keeping this working (if practical possible).


Thanks for your insights !

PS I am at FOSDEM and missed you twice at the booth. Can I offer a free 
beer for your help ? :)

--
-- dag wieers, d...@wieers.com, http://dag.wieers.com/
-- dagit linux solutions, i...@dagit.net, http://dagit.net/

[Any errors in spelling, tact or fact are transmission errors]
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] Problems with mozilla build-tools on WindowsXP

2012-02-05 Thread Makoto Takizawa
Hi Mat.

sorry for late reply.

I was able to build with that option but
Unfortunately I can not build on windows at the moment.
I got error in someplace and have not solved until now.
I will update that wiki when I can solve.

ps
Windows build is too slow so usually I build on Linux.


(24/01/2012 6:58 a.m.), Mat M wrote:
> Hi Makoto
> 
> Le Thu, 24 Nov 2011 02:46:53 +0100, Makoto Takizawa
>  a écrit:
> 
>> hi
>> I just success build on windows and wrote a note on wiki.
>> https://wiki.documentfoundation.org/User:Foral/Build_Win
>  Glad you succeed ! I ma still a bit surprised by the fact you had no
> issue with (x86) in your paths with default autogen.sh & configure.in.
> 
> I tried from master and need to tweak variables in Env.host.sh to go
> further. could you confirm you had no prob with that ?
> 
> Thanks Mathias
> 
>>
>> around Mozilla, needed to download a lot of stuffs.
>>
>> (2011/11/24 8:10), Rob Snelders wrote:
>>> Hi All,
>>>
>>> I have followed [1] as a guide to build LO on windows. But when I run
>>> autogen it comes with "Mozilla build tooling incomplete".
>>>
>>> I run autogen with the options
>>> --with-mozilla-build='/cygwin/c/mozilla-build and
>>> --disable-build-mozilla.
>>>
>>> I have also downloaded the prebuild mozilla modules and set them in
>>> moz/zipped
>>>
>>> When it failed I downloaded the moztools-static.zip from the
>>> mozilla-buildtools-ftp and put that in the buildtools-directory. But
>>> that also didn't help.
>>>
>>> Does anybody knows why this error is given?
>>>
>>> [1]
>>> http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies
>>>
>>>
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED][PATCH] Remove unused code (2)

2012-02-05 Thread Ivan Timofeev

Pushed, thanks; however I have returned
ScSubTotalDescriptorBase::GetData(ScSubTotalParam&) const
ScSubTotalDescriptorBase::PutData(ScSubTotalParam const&)
back to the header, because these functions are is pure virtual, and the 
implementations in ScSubTotalDescriptorBase is unused, not the all 
implementaions.


Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[REVIEW] fdo#42656 fix RTF export of picture frame shape type

2012-02-05 Thread Miklos Vajna
Hi,

See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=32fa7e9208b2053d2ff7743b88b0c0edacb8a7e7

Could somebody sign-off and push to -3-5, please?

Thanks,

Miklos


pgpQs4hknNu4i.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 42656, which changed state.

Bug 42656 Summary: FILESAVE RTF: some images are not exported
https://bugs.freedesktop.org/show_bug.cgi?id=42656

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED][PATCH] Remove unused code

2012-02-05 Thread Ivan Timofeev

Hi Elton,

thanks for your patch; I tweaked it a bit and then pushed.

Notes:
1. ScVbaWorksheet( const css::uno::Reference< ov::XHelperInterface >& 
xParent,  const css::uno::Reference< css::uno::XComponentContext >& 
xContext );
is *not* unused, we can see it at least in 
sc/source/ui/vba/vbaworkbook.cxx:85.


Caolan, what do you think, why it was listed in unusedcode.easy?

2. ScVbaCommandBarControl ctor, that was removed in the patch, is 
actually used, it seems you mixed up these two overloaded ctors. :) I 
fixed that.


Thanks,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Several lines not executed in a function of MacabDatabaseMetaData.cxx

2012-02-05 Thread Julien Nabet

On 05/02/2012 12:52, Lionel Elie Mamane wrote:

On Sun, Feb 05, 2012 at 01:04:32AM -0800, julien2412 wrote:


Cppcheck reports this :
core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
1044unreachableCode style   Statements following return, break, continue,
goto or throw will never be executed.
Here I hesitate to just remove all the lines after the
return. Perhaps the return is wrong.

Yeah, the code *after* the return looks quite sane, actually. I'd
remove the first return.

Hi Lionel,

I commited and pushed on master (df58753d51c41253f26104d146a73ba74c42e33e).
Thanks for your piece of advice !

Julien.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Several lines not executed in a function of MacabDatabaseMetaData.cxx

2012-02-05 Thread Lionel Elie Mamane
On Sun, Feb 05, 2012 at 01:04:32AM -0800, julien2412 wrote:

> Cppcheck reports this :
> core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
> 1044  unreachableCode style   Statements following return, break, continue,
> goto or throw will never be executed.

> Here I hesitate to just remove all the lines after the
> return. Perhaps the return is wrong.

Yeah, the code *after* the return looks quite sane, actually. I'd
remove the first return.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tail_build is a discouraging PITA

2012-02-05 Thread Ivan Timofeev

Hi Olivier,

05.02.2012 02:13, Olivier Hallot пишет:

it is now 3 days I cannot build master because of tail_build.


editeng/source/editeng/edtspell.cxx:508:

#ifdef DBG_UTIL
sal_Bool WrongList::DbgIsBuggy() const
{
   ...
}
#endif

remove the surrounding ifdef and then the linker should find this function.

But I have got

Error: a unit test failed

in editeng, anyway. :(

Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Remove unused code (3)

2012-02-05 Thread Elton Chung
Hi,
This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+.

Best Regards,
Elton

--
Elton Chung
Administrator, Sponsor of http://mirror.layerjet.com
Language Maintainer, Tester of ReactOS Project | http://reactos.org

Email/ IM : el...@layerjet.com

-


Remove-unused-code-3.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Several lines not executed in a function of MacabDatabaseMetaData.cxx

2012-02-05 Thread julien2412
Hi,

Cppcheck reports this :
core/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
1044unreachableCode style   Statements following return, break, continue,
goto or throw will never be executed.
   1039 Reference< XResultSet > SAL_CALL
MacabDatabaseMetaData::getVersionColumns(
   1040 const Any&, const ::rtl::OUString&, const ::rtl::OUString& table
) throw(SQLException, RuntimeException)
   1041 {
   1042 return new ODatabaseMetaDataResultSet(
ODatabaseMetaDataResultSet::eVersionColumns );
   1043 
   1044 ::connectivity::ODatabaseMetaDataResultSet* pResult = new
::connectivity::ODatabaseMetaDataResultSet(::connectivity::ODatabaseMetaDataResultSet::eVersionColumns);
   1045 Reference< XResultSet > xRef = pResult;
   1046 
   1047 ODatabaseMetaDataResultSet::ORows aRows;
...

I fixed some reports like this but it was just a return after a throw
usually.
Here I hesitate to just remove all the lines after the return. Perhaps the
return is wrong.

Any idea ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Several-lines-not-executed-in-a-function-of-MacabDatabaseMetaData-cxx-tp3716889p3716889.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Remove unused code (2)

2012-02-05 Thread Elton Chung
Hi,
This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+.

Best Regards,
Elton

-- 
Elton Chung
Administrator, Sponsor of http://mirror.layerjet.com
Language Maintainer, Tester of ReactOS Project | http://reactos.org

Email/ IM : el...@layerjet.com

-


Remove-unused-code-2.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice