gnome-vfs not found while ./autogen.sh

[LOH KOK HOE]

I am using Fedora 16, when I issue this command:

./autogen.sh --with-num-cpus=2
>

I hit this error:

configure: error: Package requirements (gnome-vfs-2.0 >= 2.6.0 ) were not
> met:
>
> No package 'gnome-vfs-2.0' found
>
> Consider adjusting the PKG_CONFIG_PATH environment variable if you
> installed software in a non-standard prefix.
>
> Alternatively, you may set the environment variables GNOMEVFS_CFLAGS
> and GNOMEVFS_LIBS to avoid the need to call pkg-config.
> See the pkg-config man page for more details.
>

I have downloaded the gnome-vfs from this source >
http://www.linuxfromscratch.org/blfs/view/svn/gnome/gnome-vfs.html, but I
found out that it was a deprecated package. Before I proceed to install
this package, I would like to check is there any alternative solution on
this issue? If this is the only solution, as according to the installation
guideline of gnome-vfs (I have extract the text below), the sysconfdir is
pointing to /etc/gnome/2.30.2. I don't find this path in my system. May I
know how could I find a valid sysconfdir value?

./configure --prefix=$(pkg-config --variable=prefix ORBit-2.0) \
> --sysconfdir=/etc/gnome/2.30.2 \
> --libexecdir=$(pkg-config \
> --variable=prefix ORBit-2.0)/lib/gnome-vfs-2.0 &&
> make
>
>
THanks @!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

clio  changed:

   What|Removed |Added

 Depends on||46144

--- Comment #189 from clio  2012-02-18 23:09:26 UTC ---
Consider Bug 46144 - "Distributy Columns Evenly" does not work with the 
selected columns.

Also scripting in Java unavailable (regression since 3.4.x) - Bug 46102 - 
script dispatch java extensions are broken

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

R: cygwin 1.7.10 - LO-3-5-0 - build fails - my git problem ?

[walter]

The build fails in module 125.
After re-run inside the module:
=
(1/1) Building module translations
=
Entering /cygdrive/c/LO350/translations

dmake:  Error: -- `/cygdrive/c/LO350/solver/wntmsci12.pro/bin/localize' not 
found, and can't be made
Retrying /cygdrive/c/LO350/translations

dmake:  Error: -- `/cygdrive/c/LO350/solver/wntmsci12.pro/bin/localize' not 
found, and can't be made
___

I don't understand what is wrong in my  build sequence:
___
_LOSITE_="anongit.freedesktop.org"
_LOVERSION_="libreoffice-3-5-0"
_LODIR_="LO350"
cd /cygdrive/c
rm -rf $_LODIR_
rm -rf /tmp/*
git clone -v --progress git://$_LOSITE_/libreoffice/core $_LODIR_
cd /cygdrive/c/$_LODIR_
git checkout -b $_LOVERSION_ origin/$_LOVERSION_
_JOBS_="--with-max-jobs=4"
_CPUS_="--with-num-cpus=4"
_JUNIT_="--without-junit"
_ANT_="--with-ant-home=/cygdrive/c/cygwin/libreoffice/apache-ant-1.8.2"
_MOZ_="--disable-build-mozilla 
--with-mozilla-build=/cygdrive/c/cygwin/libreoffice/mozilla-build"
_JAVA_="--with-java-target-version=1.6 
--with-jdk-home=/cygdrive/c/JavaProgramFiles/x86/Java/jdk1.6.0_30"
_WINSDK_="--with-windows-sdk-home=/cygdrive/c/WinSDKs/Windows/v7.1"
_LANG_="--enable-ext-languagetool --with-lang=it"
_MISC_="--disable-binfilter"
./autogen.sh $_JOBS_ $_CPUS_ $_JUNIT_ $_ANT_ $_MOZ_ $_JAVA_ $_WINSDK_ $_LANG_ 
$_MISC_
make clean
cd /cygdrive/c/$_LODIR_
./g checkout $_LOVERSION_ origin/$_LOVERSION_
./g pull -r
cd /cygdrive/c/$_LODIR_
make 2>&1
_
Regards
waltes

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Unused solenv tools - can I remove these?

[Norbert Thiebaud]

On Sat, Feb 18, 2012 at 3:54 PM, Tim Retout  wrote:
> Could someone help me figure out whether these solenv tools are used
> anywhere?  :)  I'm trying to shrink the LO Perl line count.
>
> Probably unused:
>
> concat-deps.pl   # recently replaced with a C implementation
yes that can go

> convertlinks.pl    # specific to api.openoffice.org
Then better keep it for now, unless there is a better home for it

> gen_userfeedback_VCL_names.pl

prolly obsolete, since it seems to rely on HID and these have change
drastically since 3.4

> licinserter.pl
That may still be useful on occassion...

> mkdir.pl
I can't imagine why we would need that

> oochkpatch        # Never called?
> oochkpatch.pl     # Used only by oochkpatch

That looks like a hamburg build specific thing... indeed prolly not used anymore

> rmdir.pl
Why would we ever need that ?

> touch.pl             # 4nt support was removed in ae0228c
yes that can go

>
> Possibly unused:
>
> cleandiff.pl   # used in 'create_patch' target of
> solenv/inc/tg_ext.mk, but I can't find 'create_patch' in any
> makefiles.  Is this likely to be called manually?

yes, I believe that is a helper to generate patch for external libs.
I never used it myself, but taht should prolly be kept around.

>
> Look unused, but probably aren't:
>
> make_download.pl # looks like it ought to be really important, from the name

I think that is also a remnant of hamburg special build system... I
don;t think that is used by anyone today

> remangle32to64.pl # Committed in Jan 2011, seems relevant to w64 porting.
That one should be ketp, unless Tor says otherwise...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code

[Petr Vorel]

Hi,

I removed a little bit of unused code (unusedcode.easy).

Petr
>From fefa4759000f74d3ca90aa118247abc77cf9363f Mon Sep 17 00:00:00 2001
From: Petr Vorel 
Date: Sat, 18 Feb 2012 23:50:22 +0100
Subject: [PATCH] Remove unused code

---
 l10ntools/source/merge.cxx|   16 
 registry/source/keyimpl.cxx   |8 
 registry/source/keyimpl.hxx   |1 -
 svl/inc/svl/zforlist.hxx  |1 -
 svl/source/numbers/zforlist.cxx   |9 -
 svx/inc/svx/svdetc.hxx|1 -
 svx/source/svdraw/svdetc.cxx  |5 -
 unotools/inc/unotools/numberformatcodewrapper.hxx |1 -
 unotools/source/i18n/numberformatcodewrapper.cxx  |   16 
 unusedcode.easy   |6 --
 vcl/inc/vcl/menu.hxx  |1 -
 vcl/source/window/menu.cxx|9 -
 12 files changed, 0 insertions(+), 74 deletions(-)

diff --git a/l10ntools/source/merge.cxx b/l10ntools/source/merge.cxx
index b9b8d40..55c62d1 100644
--- a/l10ntools/source/merge.cxx
+++ b/l10ntools/source/merge.cxx
@@ -129,22 +129,6 @@ void MergeData::Insert(PFormEntrys* pfEntrys )
 aMap.insert( PFormEntrysHashMap::value_type( rtl::OString(RTL_CONSTASCII_STRINGPARAM("HACK")) , pfEntrys ) );
 }
 
-rtl::OString MergeData::Dump()
-{
-printf("MergeData sTyp = %s , sGid = %s , sLid =%s , sFilename = %s\n",
-sTyp.getStr(), sGID.getStr(), sLID.getStr(), sFilename.getStr());
-
-PFormEntrysHashMap::const_iterator idbg;
-for( idbg = aMap.begin() ; idbg != aMap.end(); ++idbg )
-{
-printf("aMap[ %s ] = " ,idbg->first.getStr());
-( (PFormEntrys*)(idbg->second) )->Dump();
-printf("\n");
-}
-printf("\n");
-return rtl::OString(RTL_CONSTASCII_STRINGPARAM("MergeData\n"));
-}
-
 PFormEntrys* MergeData::GetPFObject( const rtl::OString& rPFO )
 {
 if( aMap.find( rtl::OString(RTL_CONSTASCII_STRINGPARAM("HACK")) ) != aMap.end() )
diff --git a/registry/source/keyimpl.cxx b/registry/source/keyimpl.cxx
index c48ae9c..adbb49e 100644
--- a/registry/source/keyimpl.cxx
+++ b/registry/source/keyimpl.cxx
@@ -61,14 +61,6 @@ ORegKey::~ORegKey()
 }
 
 //*
-//  acquireKey
-//
-RegError ORegKey::acquireKey(RegKeyHandle hKey)
-{
-return m_pRegistry->acquireKey(hKey);
-}
-
-//*
 //  releaseKey
 //
 RegError ORegKey::releaseKey(RegKeyHandle hKey)
diff --git a/registry/source/keyimpl.hxx b/registry/source/keyimpl.hxx
index a384d20..fbd9c4c 100644
--- a/registry/source/keyimpl.hxx
+++ b/registry/source/keyimpl.hxx
@@ -46,7 +46,6 @@ public:
 sal_uInt32  release()
 { return --m_refCount; }
 
-RegErroracquireKey(RegKeyHandle hKey);
 RegErrorreleaseKey(RegKeyHandle hKey);
 
 RegErrorcreateKey(const rtl::OUString& keyName, RegKeyHandle* phNewKey);
diff --git a/svl/inc/svl/zforlist.hxx b/svl/inc/svl/zforlist.hxx
index a8cca86..69645e1 100644
--- a/svl/inc/svl/zforlist.hxx
+++ b/svl/inc/svl/zforlist.hxx
@@ -247,7 +247,6 @@ private:
 
 public:
 
-NfCurrencyEntry();
 NfCurrencyEntry( const LocaleDataWrapper& rLocaleData,
 LanguageType eLang );
 NfCurrencyEntry(
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 2ee058f..ca3ca49 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -3798,15 +3798,6 @@ sal_uInt16 SvNumberFormatter::GetCurrencyFormatStrings( NfWSStringsDtor& rStrArr
 
 //--- NfCurrencyEntry 
 
-NfCurrencyEntry::NfCurrencyEntry()
-:   eLanguage( LANGUAGE_DONTKNOW ),
-nPositiveFormat(3),
-nNegativeFormat(8),
-nDigits(2),
-cZeroChar('0')
-{
-}
-
 
 NfCurrencyEntry::NfCurrencyEntry( const LocaleDataWrapper& rLocaleData, LanguageType eLang )
 {
diff --git a/svx/inc/svx/svdetc.hxx b/svx/inc/svx/svdetc.hxx
index b547289..08ba835 100644
--- a/svx/inc/svx/svdetc.hxx
+++ b/svx/inc/svx/svdetc.hxx
@@ -256,7 +256,6 @@ public:
 OLEObjCache();
 SVX_DLLPUBLIC ~OLEObjCache();
 
-void SetSize(sal_uIntPtr nNewSize);
 void InsertObj(SdrOle2Obj* pObj);
 void RemoveObj(SdrOle2Obj* pObj);
 };
diff --git a/svx/source/svdraw/svdetc.cxx b/svx/source/svdraw/svdetc.cxx
index 2672e82..0cc3c01 100644
--- a/svx/source/svdraw/svdetc.cxx
+++ b/svx/source/svdraw/svdetc.cxx
@@ -174,11 +174,6 @@ void OLEObjCache::UnloadOnDemand()
 }
 }
 
-void OLEObjCache::SetSize(sal_uIntPtr nNewSize)
-{
-nSize = nNewSize;
-}
-
 void OLEObjCache::InsertObj(SdrOle2Obj* pObj)
 {
 if ( Count() )
diff --git a/unotools/inc/unotools/numberformatcodewrapper.hxx b/unotools/inc/u

Re: Disappearing graphics in Write: where to look (bug 33393)

[Andrew Douglas Pitonyak]

On 02/18/2012 04:43 PM, julien2412 wrote:

You may find some guidelines to debug LO here :
http://wiki.documentfoundation.org/Development/How_to_debug

Julien.

Thanks Julien, very helpful.

I am able to cause the problem every time in LO but unable to cause it 
at all in OOo. Have been poking around the LO code today trying to 
decide where I might put break points to help in tracking this. Looks 
like this occurs (for my sample) when auto-save kicks in, so I may place 
a break point in the auto save code and then start stepping through it 
to see if anything obvious looks wrong.


--
Andrew Pitonyak
My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
Info:  http://www.pitonyak.org/oo.php

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fix building dictionaries when PERL_UNICODE environment

[Petr Vorel]

Hi,

I run into troubles while building dictionaries, because I have on my 
system set PERL_UNICODE=SDL (perl script 
clone/dictionaries/dictionaries/util/th_check.pl dies as it's forced to 
use UTF-8, but not all dictionaries are in this encoding).
Not sure whether it's good idea to handle it. If yes, there is a working 
solution (I'm sure, there must be better place to reset the variable).


Petr
>From 6877bd81333f6373fb80d66e6d6479a40e2294f5 Mon Sep 17 00:00:00 2001
From: Petr Vorel 
Date: Sat, 18 Feb 2012 23:19:22 +0100
Subject: [PATCH] fix building dictionaries when PERL_UNICODE environment
 variable is set

---
 Makefile |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index cb99243..7d619e2 100644
--- a/Makefile
+++ b/Makefile
@@ -267,7 +267,7 @@ define dmake_module_rules
 
 $(1): bootstrap fetch
 	cd $(1) && unset MAKEFLAGS && \
-$(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) -- -P$(GMAKE_PARALLELISM)
+PERL_UNICODE=0 $(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) -- -P$(GMAKE_PARALLELISM) # PERL_UNICODE breaks th_check.pl during validating thesaurus files
 
 $(1).all: bootstrap fetch
 	cd $(1) && unset MAKEFLAGS && \
-- 
1.7.9

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Unused solenv tools - can I remove these?

[Tim Retout]

Could someone help me figure out whether these solenv tools are used
anywhere?  :)  I'm trying to shrink the LO Perl line count.

Probably unused:

concat-deps.pl   # recently replaced with a C implementation
convertlinks.pl# specific to api.openoffice.org
gen_userfeedback_VCL_names.pl
licinserter.pl
mkdir.pl
oochkpatch# Never called?
oochkpatch.pl # Used only by oochkpatch
rmdir.pl
touch.pl # 4nt support was removed in ae0228c

Possibly unused:

cleandiff.pl   # used in 'create_patch' target of
solenv/inc/tg_ext.mk, but I can't find 'create_patch' in any
makefiles.  Is this likely to be called manually?

Look unused, but probably aren't:

make_download.pl # looks like it ought to be really important, from the name
remangle32to64.pl # Committed in Jan 2011, seems relevant to w64 porting.

-- 
Tim Retout 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Removed unused code

[Petr Vorel]

This is my first contribution. This and any other is of course made
available under the MPL/LGPLv3+.

Do you think you could link yourself into the developers wiki page
here, so we have a pointer to that:

http://wiki.documentfoundation.org/Development/Developers

Done.


Much appreciated :-) Are you interested in some easy hacks ? or
particularly annoying itches you have yourself ?

Just some easy hacks.

Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Disappearing graphics in Write: where to look (bug 33393)

[julien2412]

You may find some guidelines to debug LO here :
http://wiki.documentfoundation.org/Development/How_to_debug

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Disappearing-graphics-in-Write-where-to-look-bug-33393-tp3755433p3757064.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

About Boost 1.48

[julien2412]

Hi,

I saw that boost package used by LO sources by default was the 1.44 version. 
On debian testing pc x86-64 (with Boost 1.48) and by using
--with-system-boost in the autogen options, it compiled ok. I thought there
would be some things to do in order to compile, did i miss anything ? :-)

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/About-Boost-1-48-tp3757059p3757059.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Disappearing graphics in Write: where to look (bug 33393)

[Andrew Douglas Pitonyak]

On 02/17/2012 08:31 PM, Andrew Douglas Pitonyak wrote:


While updating LO documentation using the latest release of LO, most 
of the embedded graphics just disappeared so I have been looking at this:


https://www.libreoffice.org/bugzilla/show_bug.cgi?id=33393

I spent a few hours poking around the generated files trying to 
understand what happened. My next step is to spend a few more hours 
checking to see if I am able to reproduce. And after that (even if I 
cannot reproduce) I intend to poke through the source code.


I am not familiar with the write code so I am hoping that someone can 
kind of push me towards the code dealing with holding graphics objects 
in Write. I am not looking for a fine grained answer, just broadly 
speaking what code might represent a graphic object or contain a list 
of them (I figure it is as good as any place to look).


I can reproduce the error at will, so now I just need to track it in the 
code to find where things go awry!


--
Andrew Pitonyak
My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
Info:  http://www.pitonyak.org/oo.php

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Remove unused methods from PDFI

[Kate Goss]

Hi,

Quick question - Can anyone point me to list of supported browsers for the
bug submission assistant?

Kate

On 17 February 2012 23:11, Kate Goss  wrote:

>
>
> On 17 February 2012 11:21, Thorsten Behrens 
> wrote:
>
>> Kate Goss wrote:
>> > Yes, he did - thanks Thorsten. Christian - if you are able to set me up
>> > with access, that would be lovely :)
>> >
>> Hi Kate,
>>
>> glad you hear you want to look into this - first step is to clone
>> the git repo
>>
>>  git clone git://anongit.freedesktop.org/libreoffice/website
>>
>> (stay on the master branch)
>>
>> , and then look into the bug/ subdir. Please *do* ask questions! :)
>>
>
> Thanks - I will look at this tomorrow. Expect questions! :)
>
> Kate
>
>>
>> Cheers,
>>
>> -- Thorsten
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Preconfigured Windows Build VM

[Jesús Corrius]

Hi fellow developers,

I have created a preconfigured Windows Build Virtual Box VM with the
following characteristics:

- Windows XP Service Pack 3 (32 bits)
- Microsoft Visual Studio 2008 Professional
- Cygwin version 1.7.10
- Microsoft Windows SDK version 6.0A
- Microsoft  DirectX SDK (June 2010(
- Java SDK 6 Update 31
- Apache ant 1.8.2

The zipped size of the VM is 5,5 Gb (I optimized it as much as I could)

In my desktop computer (i7-2600 @ 3.40 GHz, 6 GB RAM) it takes a bit
less than 4 hours to build LibO 3.5 from scratch. This is slow, but I
wanted to be able to build it in a VM with only 1 Gb of RAM, so I only
use one job. If you use more than one job, the system gets out of
memory quite easily unless you modify the VM to use 4 GB of RAM or
more.

To build your own version of LibreOffice, the only steps you have to
do are the following:

1. Click on the "Cygwin Terminal" icon on the desktop.
2. Type "./g pull -r" to update the sources.
3. Type "sh run.sh" to configure
4. Type "/opt/lo/bin/make"

And that's all. In four hours or less you'll have a full Windows build
of LibreOffice without any pain.

Unfortunately, due to the restrictions in the software licenses, I
can't make the VM available to everybody. But I think I can make it
available to you if you have a current MSDN account. So if you own a
MSDN account feel free to ask me for it and I will send it to you.
Additionally, If you are a business, you make money distributing
LibreOffice, and you want your own VM and you are willing to sponsor
it, feel free to contact me.

Have a good weekend everybody :)

-- 
Jesús Corrius 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] SwDocStub now prints out parameters

[Mihályi Dániel]

Hi,

It sounds cool, count me in. :)

With regards,
Daniel

2012/2/18 Markus Mohrhard :
> Hello Daniel,
>
>> It is, :)
>
> Great!
>
>> but i don't understand something.
>> If it is about creating a child class then why is that we have to have
>> not only virtual methods?
>>
>
> We don't want to create a child class but replace a class with another
> class having exactly the same interface. This would allow us to break
> dependencies during testing and make it possible that we don't need to
> start a whole Libreoffice instance for tests.
>
> There is first the ieda Cedric and I had in Brussels that we should
> create stubs for some central sw classes and monitor the input into
> them during file loading. This idea would make it much more easy to
> test that the content is imported correctly. We have nice concepts for
> such tests in calc and to some degree in impress/draw but we are
> missing one for writer.
>
> And then there is another great opportunity that it would make it
> possible to write real unit tests. I hope that with this script it
> might be possible to break nearly all dependencies and bring a class
> under test control. My idea for this is that every time you need to
> mock a class you create a test class with the same interface but with
> all methods virtual and returning default values. If you now need a
> special value for a class you can easily create a subclass overriding
> just one method.
>
> I know that both concepts are still in an early stage and we don't yet
> know if they work or good but we will not know without trying.
>
> Regards,
> Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Writing patches for git-ignored files

[Christian Lohmaier]

Hi Wei Ming,  *,

On Sat, Feb 18, 2012 at 6:47 PM, Khoo Wei Ming  wrote:
>
>> (with new build system you use something like
>> make cmd="dmake patch"
>> previously you had to source the Environment file, but that was
>> integrated to a config.mk)
>
> Issuing make cmd="dmake patch" seemed to behave similar to make.
>
> ~/libo-git$ make cmd="dmake patch"

Run it from the directory that contains the files responsible to build
the external module. i.e. in your case from the "moz" directory.

> #
> # custum command
> #
> ifneq ( $(MAKECMDGOALS),cmd)
> cmd:
>        echo "custum cmd" && ( $(cmd) )
>
> endif

Sorry for that - indeed you have to use "make cmd cmd='real command''"
http://wiki.documentfoundation.org/Development/Build_in_3.6#What.27s_New

>
> ~/libo-git$ make cmd cmd="dmake patch"
>
> Am I on the right track? How do I target only one module?

yes, you're on the right track - you just did run it from the toplevel
directory instead of the module-directory.
so "make cmd cmd="cd moz ; dmake patch" should definitely work (I'm no
longer sure whether it also words when using cd moz; make cmd
cmd="dmake patch" - but one of the two definitely should .-)

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Writing patches for git-ignored files

[Khoo Wei Ming]

Hi Christian,

Thanks for your reply.

> (with new build system you use something like
> make cmd="dmake patch"
> previously you had to source the Environment file, but that was
> integrated to a config.mk)

Issuing make cmd="dmake patch" seemed to behave similar to make.

~/libo-git$ make cmd="dmake patch"

*
*   Running the post download checks.
*

checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
cd instsetoo_native && unset MAKEFLAGS && \
/home/wmk26/libo-git/solenv/bin/build.pl -P1 --all -- -P1


=
(1/138) Building module solenv
=
...

I looked at Makefile and saw this bit

#
# custum command
#
ifneq ( $(MAKECMDGOALS),cmd)
cmd:
echo "custum cmd" && ( $(cmd) )

endif

So I tried

~/libo-git$ make cmd cmd="dmake patch"
echo "custum cmd" && ( dmake patch )
custum cmd
dmake:  Error: -- Don't know how to make `patch'
make: *** [cmd] Error 255

Am I on the right track? How do I target only one module?

Regards,
--wm
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

[Michael Meeks]

Hi there,

On Sat, 2012-02-18 at 15:08 +0100, Mariusz Dykierek wrote:
> Attached is the "new" patch that replaces and extends the previous one in 
> this thread.

Thanks & sorry for the bike-shedding :-) IMHO we would do better to
allow the compiler / optimiser to get the code right & optimise the
source more for readability / maintainability :-)

Anyhow, pushed; thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] SwDocStub now prints out parameters

[Markus Mohrhard]

Hello Daniel,

> It is, :)

Great!

> but i don't understand something.
> If it is about creating a child class then why is that we have to have
> not only virtual methods?
>

We don't want to create a child class but replace a class with another
class having exactly the same interface. This would allow us to break
dependencies during testing and make it possible that we don't need to
start a whole Libreoffice instance for tests.

There is first the ieda Cedric and I had in Brussels that we should
create stubs for some central sw classes and monitor the input into
them during file loading. This idea would make it much more easy to
test that the content is imported correctly. We have nice concepts for
such tests in calc and to some degree in impress/draw but we are
missing one for writer.

And then there is another great opportunity that it would make it
possible to write real unit tests. I hope that with this script it
might be possible to break nearly all dependencies and bring a class
under test control. My idea for this is that every time you need to
mock a class you create a test class with the same interface but with
all methods virtual and returning default values. If you now need a
special value for a class you can easily create a subclass overriding
just one method.

I know that both concepts are still in an early stage and we don't yet
know if they work or good but we will not know without trying.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] Remove unused code (14)

[Ivan Timofeev]

On 18.02.2012 19:35, Elton Chung wrote:

This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d.


Yeah, nice catch. Thanks, pushed.

Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (14)

[Elton Chung]

Hi,
This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d.

Best Regards,
Elton

-- 
Elton Chung
Administrator, Sponsor of mirror.layerjet.com
Language Maintainer, Tester of ReactOS Project | http://reactos.org

Email : el...@layerjet.com

-


Remove-unused-code-14.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove installer debug logging.

[Michael Meeks]

Hi Tim,

On Sat, 2012-02-18 at 13:47 +, Tim Retout wrote:
> The -debug option to make_installer.pl is not usually called; it logs
> function calls at various points during the installer.  However, it is
> not used consistently within the code, and the same information can be
> obtained via the Perl debugger or profiling tools.

Pushed :-)

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Lo Web version

[Jonathan Aquilina]

On 18/02/2012 15:34, Michael Meeks wrote:

On Sat, 2012-02-18 at 15:16 +0100, Jonathan Aquilina wrote:

Miklos is there a repo one can add to open suse 12 that has the web
version packaged or is compiling from source the only way?

Please checkout the spec. files for whatever version you're looking at;
if it has --enable-gtk3 then it should work.

Otherwise, you'll need to build it yourself.

ATB,

Michael.


:) thanks Micahel sry for the noise I must have misunderstood :)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Lo Web version

[Michael Meeks]

On Sat, 2012-02-18 at 15:16 +0100, Jonathan Aquilina wrote:
> Miklos is there a repo one can add to open suse 12 that has the web 
> version packaged or is compiling from source the only way?

Please checkout the spec. files for whatever version you're looking at;
if it has --enable-gtk3 then it should work.

Otherwise, you'll need to build it yourself.

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

[julien2412]

This subject, switch/if else, reminded me what I read recently on the
Stroustrup book.
1) The fact that "switch allows a better quality machine code".
2) an enumeration used with a switch allows a compiler to detect a case
which has be forgotten.

Now, I'm not a senior C++ dev at all, just a beginner who tries to improve
his knowledge so ... :-)

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-core-vcl-source-window-splitwin-cxx-2047-core-vcl-source-window-splitwin-cxx-2045-style-Found--tp3748733p3756391.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Lo Web version

[Jonathan Aquilina]

On 18/02/2012 14:53, Miklos Vajna wrote:

Hi Jonathan,

On Sat, Feb 18, 2012 at 01:16:27PM +0100, Jonathan 
Aquilina  wrote:

I setup an open suse 12 vm in virtual box and I remember michael
meeks mentioning a repository for it that has a packaged web
version. What is the repository so I am add it so i can install a
web version for testing.

See the wiki:

http://wiki.documentfoundation.org/Using_LibreOffice_in_a_Web_Browser
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Miklos is there a repo one can add to open suse 12 that has the web 
version packaged or is compiling from source the only way?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

[Mariusz Dykierek]

On 2012-02-18 14:41, Ivan Timofeev wrote:
> On 18.02.2012 17:29, Mariusz Dykierek wrote:
>> I have a 'replacement' patch that actually replaces most of if...else 
>> if...else chains with
>> switches.
>
> Great!
>
>> They are more legible and seem natural when choosing branches depending on 
>> the same variable.
>
> On the other hand, the evaluated expression is not visible at the 
> first-look... A lot of
> people - a lot of opinions :)
>
>> Question I have, is how do I submit the patch:
>>   - as a reply to this thread, or
>>   - a new patch in a new thread?
>
> I think, if a patch extends or replaces a current one - submit as a reply, 
> otherwise - start a
> new thread.
>
> Cheers,
> Ivan
>
Attached is the "new" patch that replaces and extends the previous one in this 
thread.
Regards,
Mariusz
>From 66820932b045797e12bd49996fe5f60d5c4ef280 Mon Sep 17 00:00:00 2001
From: Mariusz Dykierek 
Date: Sat, 18 Feb 2012 14:18:19 +0100
Subject: [PATCH] Replaced 'if-elseif-else' chains with 'switches' where they
 seem natural

---
 vcl/source/window/splitwin.cxx |  218 
 1 files changed, 109 insertions(+), 109 deletions(-)

diff --git a/vcl/source/window/splitwin.cxx b/vcl/source/window/splitwin.cxx
index f5da206..dfe66d1 100644
--- a/vcl/source/window/splitwin.cxx
+++ b/vcl/source/window/splitwin.cxx
@@ -135,33 +135,32 @@ static void ImplCalcBorder( WindowAlign eAlign, sal_Bool bNoAlign,
 }
 else
 {
-if ( eAlign == WINDOWALIGN_TOP )
+switch ( eAlign )
 {
+case WINDOWALIGN_TOP:
 rLeft   = 2;
 rTop= 2;
 rRight  = 2;
 rBottom = 0;
-}
-else if ( eAlign == WINDOWALIGN_LEFT )
-{
+break;
+case WINDOWALIGN_LEFT:
 rLeft   = 2;
 rTop= 2;
 rRight  = 0;
 rBottom = 2;
-}
-else if ( eAlign == WINDOWALIGN_BOTTOM )
-{
+break;
+case WINDOWALIGN_BOTTOM:
 rLeft   = 2;
 rTop= 0;
 rRight  = 2;
 rBottom = 2;
-}
-else
-{
+break;
+default:
 rLeft   = 0;
 rTop= 2;
 rRight  = 2;
 rBottom = 2;
+break;
 }
 }
 }
@@ -183,8 +182,9 @@ void SplitWindow::ImplDrawBorder( SplitWindow* pWin )
 }
 else
 {
-if ( pWin->meAlign == WINDOWALIGN_BOTTOM )
+switch ( pWin->meAlign )
 {
+case WINDOWALIGN_BOTTOM:
 pWin->SetLineColor( rStyleSettings.GetShadowColor() );
 pWin->DrawLine( Point( 0, nDY-2 ), Point( nDX-1, nDY-2 ) );
 pWin->DrawLine( Point( 0, 0 ), Point( 0, nDY-1 ) );
@@ -194,9 +194,8 @@ void SplitWindow::ImplDrawBorder( SplitWindow* pWin )
 pWin->DrawLine( Point( 0, nDY-1 ), Point( nDX-1, nDY-1 ) );
 pWin->DrawLine( Point( 1, 1 ), Point( 1, nDY-3 ) );
 pWin->DrawLine( Point( nDX-1, 0 ), Point( nDX-1, nDY-1 ) );
-}
-else if ( pWin->meAlign == WINDOWALIGN_TOP )
-{
+break;
+case WINDOWALIGN_TOP:
 pWin->SetLineColor( rStyleSettings.GetShadowColor() );
 pWin->DrawLine( Point( 0, 0 ), Point( nDX-1, 0 ) );
 pWin->DrawLine( Point( 0, 0 ), Point( 0, nDY-1 ) );
@@ -206,9 +205,8 @@ void SplitWindow::ImplDrawBorder( SplitWindow* pWin )
 pWin->DrawLine( Point( 1, 1 ), Point( nDX-3, 1 ) );
 pWin->DrawLine( Point( 1, 1 ), Point( 1, nDY-1 ) );
 pWin->DrawLine( Point( nDX-1, 1 ), Point( nDX-1, nDY-1 ) );
-}
-else if ( pWin->meAlign == WINDOWALIGN_LEFT )
-{
+break;
+case WINDOWALIGN_LEFT:
 pWin->SetLineColor( rStyleSettings.GetShadowColor() );
 pWin->DrawLine( Point( 0, 0 ), Point( nDX-1, 0 ) );
 pWin->DrawLine( Point( 0, 0 ), Point( 0, nDY-1 ) );
@@ -218,9 +216,8 @@ void SplitWindow::ImplDrawBorder( SplitWindow* pWin )
 pWin->DrawLine( Point( 1, 1 ), Point( nDX-1, 1 ) );
 pWin->DrawLine( Point( 1, 1 ), Point( 1, nDY-3 ) );
 pWin->DrawLine( Point( 1, nDY-1 ), Point( nDX-1, nDY-1 ) );
-}
-else
-{
+break;
+default:
 pWin->SetLineColor( rStyleSettings.GetShadowColor() );
 pWin->DrawLine( Point( 0, 0 ), Point( nDX-2, 0 ) );
 pWin->DrawLine( Point( nDX-2, 0 ), Point( nDX-2, nDY-3 ) );
@@ -230,6 +227,7 @@ void SplitWindow::ImplDrawBorder( SplitWindow* pWin )
 pWin->DrawLine( Point( 0, 1 ), Point( nDX-3, 1 ) );
 pWin->DrawLine( Point( nDX-1, 0 ), Point( nDX-1, nDY-1 ) );
 pWin->DrawLine( Point( 0, nDY-1 ), Point( nDX-1, nDY-1 ) );
+break;
 }
 }
 }
@@ -244,33 +242,32 @@ void SplitWindow::ImplDrawBorderLine( SplitWindow* pWin )
 long   

Re: Lo Web version

[Miklos Vajna]

Hi Jonathan,

On Sat, Feb 18, 2012 at 01:16:27PM +0100, Jonathan Aquilina 
 wrote:
> I setup an open suse 12 vm in virtual box and I remember michael
> meeks mentioning a repository for it that has a packaged web
> version. What is the repository so I am add it so i can install a
> web version for testing.

See the wiki:

http://wiki.documentfoundation.org/Using_LibreOffice_in_a_Web_Browser
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove installer debug logging.

[Tim Retout]

Hi,

The -debug option to make_installer.pl is not usually called; it logs
function calls at various points during the installer.  However, it is
not used consistently within the code, and the same information can be
obtained via the Perl debugger or profiling tools.

Kind regards,

-- 
Tim Retout 
From 68d629a9195a3f54fea313b89f72bbe5ecbe0db6 Mon Sep 17 00:00:00 2001
From: Tim Retout 
Date: Sat, 18 Feb 2012 13:28:08 +
Subject: [PATCH] Remove installer debug logging.

The -debug option to make_installer.pl is not usually called; it logs
function calls at various points during the installer.  However, it is
not used consistently within the code, and the same information can be
obtained via the Perl debugger or profiling tools.
---
 solenv/bin/make_installer.pl |   29 --
 solenv/bin/modules/installer/archivefiles.pm |2 -
 solenv/bin/modules/installer/exiter.pm   |4 --
 solenv/bin/modules/installer/files.pm|   16 --
 solenv/bin/modules/installer/globals.pm  |3 -
 solenv/bin/modules/installer/logger.pm   |   27 -
 solenv/bin/modules/installer/parameter.pm|   19 ---
 solenv/bin/modules/installer/scriptitems.pm  |   74 --
 8 files changed, 0 insertions(+), 174 deletions(-)

diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index a823306..23fea7a 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -120,10 +120,6 @@ installer::environment::set_global_environment_variables($environmentvariablesha
 installer::parameter::saveparameter();
 installer::parameter::getparameter();
 
-# debugging can start after function "getparameter"
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nPart 1: The platform independent part\n"); }
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nPart 1a: The language independent part\n"); }
-
 installer::parameter::control_fundamental_parameter();
 installer::parameter::setglobalvariables();
 installer::parameter::control_required_parameter();
@@ -594,11 +590,6 @@ if (!($installer::globals::is_copy_only_project))
 if ( $installer::globals::globallogging ) { installer::files::save_array_of_hashes($loggingdir . "productdirectories2aa.log", $dirsinproductarrayref); }
 }
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nEnd of part 1a: The language independent part\n"); }
-
-# saving debug info, before staring part 1b
-if ( $installer::globals::debug ) { installer::logger::savedebug($installer::globals::exitlog); }
-
 #
 # Part 1b: The language dependent part
 # (still platform independent)
@@ -612,8 +603,6 @@ if ( $installer::globals::debug ) { installer::logger::savedebug($installer::glo
 # The for iterates over all products, separated by an # in the language list
 ###
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nPart 1b: The language dependent part\n"); }
-
 for ( my $n = 0; $n <= $#installer::globals::languageproducts; $n++ )
 {
 my $languagesarrayref = installer::languages::get_all_languages_for_one_product($installer::globals::languageproducts[$n], $allvariableshashref);
@@ -1217,23 +1206,14 @@ for ( my $n = 0; $n <= $#installer::globals::languageproducts; $n++ )
 installer::packagelist::log_packages_content($packages);
 installer::packagelist::create_module_destination_hash($packages, $allvariableshashref);
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nEnd of part 1b: The language dependent part\n"); }
-
-# saving debug info, before starting part 2
-if ( $installer::globals::debug ) { installer::logger::savedebug($installer::globals::exitlog); }
-
 #
 # Part 2: The platform dependent part
 #
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nPart 2: The platform dependent part\n"); }
-
 #
 # Part 2a: All non-Windows platforms
 #
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nPart 2a: All non-Windows platforms\n"); }
-
 #
 # ... creating epm list file ...
 # Only for non-Windows platforms
@@ -1767,14 +1747,10 @@ for ( my $n = 0; $n <= $#installer::globals::languageproducts; $n++ )
 }
 }   # end of "if (!( $installer::globals::iswindowsbuild ))"
 
-if ( $installer::globals::debug ) { installer::logger::debuginfo("\nEnd of part 2a: All non-Windows platforms\n"); }
-
 #
 # Part 2b: The Windows platform
 #
 
-if ( $installer::gl

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

[Ivan Timofeev]

On 18.02.2012 17:29, Mariusz Dykierek wrote:

I have a 'replacement' patch that actually replaces most of if...else if...else 
chains with
switches.


Great!


They are more legible and seem natural when choosing branches depending on the 
same variable.


On the other hand, the evaluated expression is not visible at the 
first-look... A lot of people - a lot of opinions :)



Question I have, is how do I submit the patch:
  - as a reply to this thread, or
  - a new patch in a new thread?


I think, if a patch extends or replaces a current one - submit as a 
reply, otherwise - start a new thread.


Cheers,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

[Mariusz Dykierek]

I have a 'replacement' patch that actually replaces most of if...else if...else 
chains with
switches.
They are more legible and seem natural when choosing branches depending on the 
same variable.
The performance of a switch should  also be better, but turbo boost should not 
be expected ;).
Two declarations of unused variable removed by-the-way.
Anyway, all started with cppcheck warning about duplicate branches for if-else.

Question I have, is how do I submit the patch:
 - as a reply to this thread, or
 - a new patch in a new thread?

Regards,
Mariusz Dykierek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

cygwin 1.7.10 - LO-3-5-0 - build fails in 'reportbuilder'

[walter]

Please see logs AT  
http://pastebin.com/u/walterLO

 

Regards

Walter

 

 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Lo Web version

[Jonathan Aquilina]

Hey all,

I setup an open suse 12 vm in virtual box and I remember michael meeks 
mentioning a repository for it that has a packaged web version. What is 
the repository so I am add it so i can install a web version for testing.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Unable to attend Monday MC meeting

[Sophie Gautier]

Hi all,

Just to let you know that I won't be able to attend the next MC meeting, 
I'll be traveling until late in the evening, so no way for me to be on 
phone or connected.


@Norbert: Feb 18 12:24:16 sophi sendEmail[2932]: Email was sent 
successfully! :-) I'll try to push a new version of the UserGuide to git 
tonight.

Kind regards
Sophie
--
Founding member of The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Writing patches for git-ignored files

[Christian Lohmaier]

Hi Wei Ming, *,

On Sat, Feb 18, 2012 at 11:36 AM, Khoo Wei Ming  wrote:
> I followed the patching guidelines on
>
> http://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines
>
> What is procedure for git-ignored files? E.g.
>
> ~/libo-git/moz$ git add
> unxlngi6.pro/misc/build/mozilla/xpcom/glue/nsBaseHashtable.h

You really should not add a file from the output trees. What ends up
in unxlngi6.pro is already a processed result, not the actual source.

To create patches for external modules that get build as part of
building LibreOffice, use

* "dmake patch" to unpack the sources and apply already existing patches,
* do your changes to the file
* use "dmake create_patch" to create a patch to be included into the
makefile (rename it to a descriptive name and add it to PATCH_FILES

If it is meant as a correction to an already existing patch, please
use solenv/bin/patch_sanitizer.pl to reduce noise between the old and
new version of the patch.

(with new build system you use something like
make cmd="dmake patch"
previously you had to source the Environment file, but that was
integrated to a config.mk)

> The following paths are ignored by one of your .gitignore files:
> moz/unxlngi6.pro
> Use -f if you really want to add them.
> fatal: no files added
>
> I'm assuming the '-f' option isn't the answer.

Indeed. You don't add the file, but you need to create a patch that
will be applied before building that module as described above.

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Writing patches for git-ignored files

[Khoo Wei Ming]

I followed the patching guidelines on

http://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines

What is procedure for git-ignored files? E.g.

~/libo-git/moz$ git add
unxlngi6.pro/misc/build/mozilla/xpcom/glue/nsBaseHashtable.h
The following paths are ignored by one of your .gitignore files:
moz/unxlngi6.pro
Use -f if you really want to add them.
fatal: no files added

I'm assuming the '-f' option isn't the answer.

Cheers,
Wei Ming
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removed unused code from avmedia module

[Michael Meeks]

Hi there,

On Sat, 2012-02-18 at 01:45 +0100, Bartolomé Sánchez Salado wrote:
> Hi, I removed unused code from avmedia module (unusedcode.easy)

Thanks :-) pushed that. Please can you send an MPL/LGPLv3+ license mail
to the list and link yourself into the wiki here:

http://wiki.documentfoundation.org/Development/Developers

:-)

> avmedia::priv::MediaWindowBaseImpl::getStopTime() const
> avmedia::priv::MediaWindowBaseImpl::setRate(double)
> avmedia::priv::MediaWindowBaseImpl::setStopTime(double)

We still have the virtual methods implementing these inside the
backends; we should prolly remove them from the (unpublished):

offapi/com/sun/star/media/XPlayer.idl

And also the implementations of those from the avmedia backends to be
fully cleaned up.

Any chance you could look at that too ? :-)

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove "::existence" Perl modules.

[Michael Meeks]

Hi Tim,

On Fri, 2012-02-17 at 23:40 +, Tim Retout wrote:
> This patch series removes several versions of Perl modules named
> ::existence - the functions can be reimplemented with the "grep"
> keyword.

Right :-)

> Some error messages may change in patch 9, but the error message logic
> in get_specified_file_by_name was not clear to me, (even checking the
> context of CWS nativefixer6 that introduced it):

That's fine, no one is parsing the error messages from
make_installer.pl - feel free to improve them any way you like.

> Oh, and there should be two new unit tests in there, too - not
> complete code coverage by any means, but they were useful during
> development to prove that I wasn't breaking the tested functions.

Right - I guess we need to do some gnumake research to work out how to
hook them up.

> Now that I've done such a huge patch series, I wonder if there was a
> better way to approach this to make it easier to review... :(

Given that it all looks beautiful & works nicely AFAICS, I wouldn't
worry :-)

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Clang-flagged error typedef for CardPropertyGetter/Setter in connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx

[Khoo Wei Ming]

clang flags this as

/home/wmk26/libo-git/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:91:91:
error: cannot initialize a member subobject of type
'CardPropertyGetter' (aka 'nsresult (nsIAbCard::*)(PRUnichar **)')
with an rvalue of type 'nsresult (nsIAbCard::*)(PRUnichar **)
__attribute__((cdecl))'
{ "FirstName",  "givenname",

I did a grep for NS_STDCALL and chanced upon this comment in
moz/unxlngi6.pro/misc/build/mozilla/xpcom/base/nscore.h

/**
 * Macro for creating typedefs for pointer-to-member types which are
 * declared with stdcall.  It is important to use this for any type which is
 * declared as stdcall (i.e. NS_IMETHOD).  For example, instead of writing:
 *
 *  typedef nsresult (nsIFoo::*someType)(nsISupports* arg);
 *
 *  you should write:
 *
 *  typedef
 *  NS_STDCALL_FUNCPROTO(nsresult, someType, nsIFoo, typeFunc, (nsISupports*));

Hopefully the patch is correct. I didn't try building in with gcc, but
clang seems to be pleased..

Regards,
Wei Ming
From 85fe9121b1a482d8b409ce8e4c9f8536fe1b213d Mon Sep 17 00:00:00 2001
From: Wei Ming Khoo 
Date: Fri, 17 Feb 2012 15:25:25 +
Subject: [PATCH] Clang-flagged error for typedef of CardPropertyGetter/Setter

---
 .../drivers/mozab/mozillasrc/MLdapAttributeMap.cxx |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx b/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx
index e15da07..4fbb10b 100644
--- a/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx
+++ b/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx
@@ -48,8 +48,8 @@ namespace connectivity { namespace mozab {
 //
 namespace
 {
-typedef nsresult (NS_STDCALL nsIAbCard::*CardPropertyGetter)( PRUnichar** aFirstName );
-typedef nsresult (NS_STDCALL nsIAbCard::*CardPropertySetter)( const PRUnichar* aFirstName );
+typedef NS_STDCALL_FUNCPROTO(nsResult, CardPropertyGetter, nsIAbCard, GetFirstName, (PRUnichar**));
+typedef NS_STDCALL_FUNCPROTO(nsResult, CardPropertySetter, nsIAbCard, SetFirstName, (const PRUnichar*));
 struct CardPropertyData
 {
 const sal_Char* pLDAPAttributeList;
-- 
1.7.4.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix typos in comments (2)

[Michael Meeks]

On Sat, 2012-02-18 at 14:35 +0800, Elton Chung wrote:
> This patch fixes some typos in comments.

Whatever the weather ;-) I love it,

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove unused code (13)

[Michael Meeks]

Hi Helton,

On Sat, 2012-02-18 at 14:34 +0800, Elton Chung wrote:
> This patch removes 9 unused methods.

Thanks for that :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Removed all unused code from connectivity module

[Lionel Elie Mamane]

On Fri, Feb 17, 2012 at 03:42:22PM +0100, Dézsi Szabolcs wrote:

> Hi! I removed all of the unused functions of module connectivity

A few of these look like they should be used, or have the potential to
be quite useful, so please don't push that, I'll have a more
fine-grained look at them ASAP.

> connectivity::evoab::OCommonStatement::reset()

This one seems to be the only user of
connectivity::evoab::OCommonStatement::clearMyResultSet, so if we
remove reset, we should also remove clearMyResultSet.

> connectivity::odbc::ODatabaseMetaDataResultSet::openTablesTypes()

This one is used as of a few days ago.

> connectivity::odbc::OPreparedStatement::getDataBuf(int)
> connectivity::odbc::OPreparedStatement::getParamLength(int)
> connectivity::odbc::OPreparedStatement::getPrecision(int)

These have been removed a few days ago.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Building LibreOffice on Windows

[Tor Lillqvist]

>> > Projects like this have to battle the "embrace, extend, extinguish" 
>> > philosophy of commercial
>> > interests.

>> What makes you think only commercial entities have that philosophy?

> What makes you think I thought that?

I misunderstood your use of "battle". I thought you meant that only
"commercial interests" exhibit the philosophy in question and that
"projects like this" have to fight against them; but apparently you
mean that "projects like this" also can exhibit that philosophy but
that behaviour should be recognized and avoided. We are in fact in
agreement then;)

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] EasyHack 42790: get rid of PRODUCT define/build system variable

[jumbo444]

Michael Meeks-2 wrote
> 
>   It looks lovely :-)
Thanks. I worked hard for that ;)

Michael Meeks-2 wrote
> 
>> Preprocessor constant PRODUCT is replaced by !DBG_UTIL
>   Thanks for that; does that complete that easy hack ? or is there more
> to do there ?
Actually all use of PRODUCT was removed from the code (if I correctly
greped). However it may also be necessary to remove the definition of
PRODUCT. I was not able to understand clearly how it is defined. I found
some PRODUCT="" or PRODUCT="full" in core/config, but nowhere DLG_UTIL is
defined. So I preferred changing nothing.


Michael Meeks-2 wrote
> 
>  and what's next :-)
After this tremendous exploit, I think I need more easyhacks before looking
deeper into some interesting feature like improving trendline in chart.

Have a good day.

Laurent BP

-
LibreOffice 3.5.0
--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-fdo-42790-Easyhack-get-rid-of-PRODUCT-define-build-system-variable-tp3749409p3755940.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice