Automatically section update with java

2012-03-04 Thread Toygun

Hello ,

I have a odt document where I inserted 2 sections from other documents.
Changing these sections requires an update in the enclosing document
when using Libre Office or OpenOffice (popup is asking me).

Does anybody know where and how the "update"-button from LibreOffice 
(OpenOffice) is
implemented, so that we might reused this functionality programmatically?

I want this document to be updated automatically using some java-code now.
Is there some functionality inside the ODFToolkit or s.th. like that?

Doing it "by hand" using the ODFToolkit is complicated because I have to
merge most of the xml-files (e.g. styles, ..) of these odt documents.

Has anybody experience with such updates?

Is there any information or java snipplet how to effort this?

Thanks for any help, kind regards
Toygun

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: GSoC & error during make

2012-03-04 Thread Norbert Thiebaud
On Sun, Mar 4, 2012 at 7:08 PM, Mariana Marasoiu
 wrote:
> Hello everyone!
>
>
> I'm Mariana Mărășoiu from Romania and I am a second-year student at
> "Politehnica" University of Bucharest, Automatic Controls and
> Computers Faculty. I would like to participate in Google Summer of
> Code this year and I want to work on a project in LibreOffice.
>
> I wanted to start with an EasyHack, and I tried first of all to build
> LibreOffice. I cloned the git code [1] and installed all dependencies
> that were required before running make. But during make, it stops with
> the following error message:
>
>
> ---
>        Oh dear - something failed during the build - sorry !
>  For more help with debugging build errors, please see the section in:
>            http://wiki.documentfoundation.org/Development
>
>  internal build errors:
>
> ERROR: error 65280 occurred while making
> /home/mariana/Working/git/libo/helpcontent2/source/auxiliary
>
>  it seems that the error is inside 'helpcontent2', please re-run build
>  inside this module to isolate the error and/or test your fix:
> ---
>
> /bin/bash
> cd /home/mariana/Working/git/libo
> source ./Env.Host.sh
> cd helpcontent2
> rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro #
> optional module 'clean'
> build
>

What version are you trying to build ? this message seems to indicate
something more than a month old
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

Mihkel Tõnnov  changed:

   What|Removed |Added

   Platform|x86 (IA32)  |All
 OS/Version|Windows (All)   |All
Version|LibO 3.4.0 Beta2|LibO 3.4.5 release

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

Mihkel Tõnnov  changed:

   What|Removed |Added

   Platform|x86 (IA32)  |All
 OS/Version|Windows (All)   |All

Markus Mohrhard  changed:

   What|Removed |Added

   Priority|high|medium

Mihkel Tõnnov  changed:

   What|Removed |Added

Version|LibO 3.4.0 Beta2|LibO 3.4.5 release

Markus Mohrhard  changed:

   What|Removed |Added

Version|LibO 3.4.5 release  |LibO 3.4.0 Beta2

--- Comment #256 from Markus Mohrhard  
2012-03-04 17:39:16 UTC ---
Please don't change the fields in this bug. It is a meta bug and covers all
platforms.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

bigcdady63  changed:

   What|Removed |Added

   Platform|All |x86 (IA32)
 OS/Version|All |Windows (All)
   Priority|medium  |high

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


GSoC & error during make

2012-03-04 Thread Mariana Marasoiu
Hello everyone!


I'm Mariana Mărășoiu from Romania and I am a second-year student at
"Politehnica" University of Bucharest, Automatic Controls and
Computers Faculty. I would like to participate in Google Summer of
Code this year and I want to work on a project in LibreOffice.

I wanted to start with an EasyHack, and I tried first of all to build
LibreOffice. I cloned the git code [1] and installed all dependencies
that were required before running make. But during make, it stops with
the following error message:


---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making
/home/mariana/Working/git/libo/helpcontent2/source/auxiliary

 it seems that the error is inside 'helpcontent2', please re-run build
 inside this module to isolate the error and/or test your fix:
---

/bin/bash
cd /home/mariana/Working/git/libo
source ./Env.Host.sh
cd helpcontent2
rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro #
optional module 'clean'
build

when the problem is isolated and fixed exit and re-run 'make' from the top-level
make[1]: *** [build] Error 1
make[1]: Leaving directory `/home/mariana/Working/git/libo'
make: *** [source-env-and-recurse] Error 2


I re-ran build inside the module as specified in the message, but all
I got was another error message:


=
(1/1) Building module helpcontent2
=
Entering /home/mariana/Working/git/libo/helpcontent2/source/auxiliary

Processing en-US
../../unxlngi6.pro/misc/en-US/simpress.tree is illformed xml ( on linux)


update_tree.pl
   all languages in WITH_LANG are processed. WITH_LANG=ALL is
   not supported in manual calls.

   Updates the *.tree files.
   At first, the English file is updated based on the English
   help topic titles as read from the help files. Then, the
   localized tree files are written based on the English tree
   file and the localized help topic titles.

   Requires a valid LibreOffice build environment.

dmake:  Error code 255, while making '../../unxlngi6.pro/misc/treefiles.done'

---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making
/home/mariana/Working/git/libo/helpcontent2/source/auxiliary

 it seems that the error is inside 'helpcontent2', please re-run build
 inside this module to isolate the error and/or test your fix:
---

/bin/bash
cd /home/mariana/Working/git/libo
source ./Env.Host.sh
cd helpcontent2
rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro #
optional module 'clean'
build

when the problem is isolated and fixed exit and re-run 'make' from the top-level


I don't know what should I do next. I tried googling the error, but
came up with nothing conclusive. I was hoping you could help me fix
this and finish building LibreOffice so I could start hacking :D.

Thank you,
Mariana Mărășoiu


[1] git://anongit.freedesktop.org/libreoffice/core
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


License statement ...

2012-03-04 Thread Katarina Machalkova
Hullo *, 

I don't really feel the need to write this, as I haven't changed my mind wrt. 
licensing my patches since I became un-affiliated with SUSE, but my 
significant 1/2 says it's necessary, so here we go:

All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ license

Bub.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: using Windows in VM

2012-03-04 Thread Dennis E. Hamilton
For QA purposes, Windows on a VM works well for me, even on a native Windows 
system.  I don't need to be able to build the product in a VM.  

The VM lets me run and test beta level software in VMs without touching my 
production systems and I can do a lot of user-level testing, troubleshooting, 
and bug confirmation.  It is easy to capture screen shots of (portions of) the 
VM displays for documentation and issue-reporting also.

I can also access a lot of material via sharing folders and drives from the 
host to the guest system, making it easy to transfer files around to verify 
interchange or import/export problems.  I do have enough Windows licenses to 
keep several of those VMs erected. I wouldn't consider attempting development 
and building projects as big as LO that way.  

One opportunity for such simple QA is the Windows 8 Community Preview, which 
seems to run in VirtualBox just fine.  It is a way to see what happens with 
installs of OpenOffice-lineage software for Windows and to anticipate any 
adjustments that will be appropriate for future releases of OOo-lineage 
software.  There is no need to purchase licenses for the CP release and 
multiple installs are allowed.

An even easier case for VM use is installing varieties of Unix and Linux that 
run on x64/x86.  The license situation is much easier for those 
open-source/free distributions.  I'm becoming fond of Zorin OS for that 
purpose, although FreeBSD and OpenBSD are good ones for some of my needs as 
well.

I find that VirtualBox is the ideal VM for this variety of cases.

 - Dennis

A case that nags me a bit more is needing to make sure I have retained older 
development tools that will still work when impending Windows SDK and Visual 
Studio versions will no longer support construction for Windows XP and earlier. 
 I may eventually need VMs to run those as well.  That's obviously not going to 
work for complex builds such as LO and Apache OO.

-Original Message-
From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org 
[mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On 
Behalf Of Bjoern Michaelsen
Sent: Sunday, March 04, 2012 04:05
To: libreoffice@lists.freedesktop.org
Subject: Re: using Windows in VM

Hi,

On Sun, Mar 04, 2012 at 11:30:08AM +0100, Cor Nouws wrote:
> I have the idea that it might be useful to consider encouraging devs
> on Linux to use Windows in a VM.
> I know that some of the devs are actively using Windows build
> environments, but also that others haven't even a running Win OS to
> check certain issues.
> Setting up a VM is not a big deal, and if needed the Board could
> step in paying for licences.
> It would make checking / communicating on certain issues much
> easier. Checking yourself is more direct and often not much more
> work than commenting that you cannot, and hope that others will shed
> some light on it etc. Well, I could continue with listing other
> advantages.

While that is all true, I wonder if it really hits the core of the problem. A
developer would usually want to go fixing the bug and for that he would not
only need a LibreOffice install, but instead a whole development environment to
make debug build of effected libraries etc. And even with such a setup the
build times are much longer and the deployment is much more clumsy than on
Windows.

It would only be worth it if we not only have licenses, but a ready-to-use VM
image with a complete windows build environment. That might also help to get
traction with Windows developers new to the project. However, it is also a lot
of work -- not only to create it, but also to keep it up to date.

Getting the resources for that task (setting up a image with a complete build
env) is the tough one here IMHO.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] remove unused code

2012-03-04 Thread Petr Vorel
Another unused code removed.
>From 226fccc7f2fd022ed9d329ac9c6bb373fbeff265 Mon Sep 17 00:00:00 2001
From: Petr Vorel 
Date: Sat, 3 Mar 2012 02:16:31 +0100
Subject: [PATCH] remove unused code

---
 oox/inc/oox/helper/binaryinputstream.hxx   |4 
 oox/inc/oox/helper/modelobjecthelper.hxx   |3 ---
 oox/inc/oox/helper/propertymap.hxx |1 -
 oox/inc/oox/helper/propertyset.hxx |   14 +++---
 oox/source/drawingml/customshapeproperties.cxx |1 -
 oox/source/helper/binaryinputstream.cxx|8 
 oox/source/helper/modelobjecthelper.cxx|   13 -
 oox/source/helper/propertymap.cxx  |5 -
 oox/source/helper/propertyset.cxx  |   24 
 sd/source/filter/eppt/epptooxml.hxx|2 --
 sd/source/filter/eppt/pptx-epptooxml.cxx   |   16 
 unusedcode.easy|6 --
 12 files changed, 3 insertions(+), 94 deletions(-)

diff --git a/oox/inc/oox/helper/binaryinputstream.hxx b/oox/inc/oox/helper/binaryinputstream.hxx
index 5add5f4..6e952a2 100644
--- a/oox/inc/oox/helper/binaryinputstream.hxx
+++ b/oox/inc/oox/helper/binaryinputstream.hxx
@@ -164,10 +164,6 @@ public:
 template< typename Type >
 voidskipArray( sal_Int32 nElemCount );
 
-/** Reads a NUL-terminated byte character array and returns the string.
- */
-::rtl::OString  readNulCharArray();
-
 /** Reads a NUL-terminated Unicode character array and returns the string.
  */
 ::rtl::OUString readNulUnicodeArray();
diff --git a/oox/inc/oox/helper/modelobjecthelper.hxx b/oox/inc/oox/helper/modelobjecthelper.hxx
index 86459ec..10131de 100644
--- a/oox/inc/oox/helper/modelobjecthelper.hxx
+++ b/oox/inc/oox/helper/modelobjecthelper.hxx
@@ -56,9 +56,6 @@ public:
 /** Returns true, if the object with the passed name exists in the container. */
 boolhasObject( const ::rtl::OUString& rObjName ) const;
 
-/** Returns the object with the passed name from the container. */
-::com::sun::star::uno::Any getObject( const ::rtl::OUString& rObjName ) const;
-
 /** Inserts the passed object into the container, returns its final name. */
 ::rtl::OUString insertObject(
 const ::rtl::OUString& rObjName,
diff --git a/oox/inc/oox/helper/propertymap.hxx b/oox/inc/oox/helper/propertymap.hxx
index 2696d49..dabd2e4 100644
--- a/oox/inc/oox/helper/propertymap.hxx
+++ b/oox/inc/oox/helper/propertymap.hxx
@@ -102,7 +102,6 @@ public:
 #if OSL_DEBUG_LEVEL > 0
 #ifdef DBG_UTIL
   static void dump( ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > rXPropSet);
-  void dump();
 #endif
   static void dumpCode( ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > rXPropSet);
   void dumpCode();
diff --git a/oox/inc/oox/helper/propertyset.hxx b/oox/inc/oox/helper/propertyset.hxx
index fd0c1a7..14ca79b 100644
--- a/oox/inc/oox/helper/propertyset.hxx
+++ b/oox/inc/oox/helper/propertyset.hxx
@@ -50,9 +50,9 @@ class PropertyMap;
 com.sun.star.beans.XPropertySet interface then). The reference to the
 property set will be kept as long as the instance of this class is alive.
 
-The functions getProperties() and setProperties() try to handle all passed
-values at once, using the com.sun.star.beans.XMultiPropertySet interface.
-If the implementation does not support the XMultiPropertySet interface, all
+The functions setProperties() tries to handle all passed values at once,
+using the com.sun.star.beans.XMultiPropertySet interface.  If the
+implementation does not support the XMultiPropertySet interface, all
 properties are handled separately in a loop.
  */
 class PropertySet
@@ -103,14 +103,6 @@ public:
 @return  true = property contains true; false = property contains false or error occurred. */
 inline bool getBoolProperty( sal_Int32 nPropId ) const
 { bool bValue = false; return getProperty( bValue, nPropId ) && bValue; }
-
-/** Gets the specified properties from the property set. Tries to use the XMultiPropertySet interface.
-@param orValues  (out-parameter) The related property values.
-@param rPropNames  The property names. MUST be ordered alphabetically. */
-voidgetProperties(
-::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any >& orValues,
-const ::com::sun::star::uno::Sequence< ::rtl::OUString >& rPropNames ) const;
-
 // Set properties -
 
 /** Puts the passed any into the property set. */
diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx
index ab99e82..29844b8 100644
--- a/oox/source/drawingml/customshapeproperties.cxx
+++ b/oox/

Re: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Dészi

Such improvements are often subjective, no matter they are recorded in
bugzilla.

Improvements in the UI must be brought to the UX list

libreoffice-ux-adv...@lists.freedesktop.org

for discussion with other User Interface specialists. There, a consensus
on the improvement shall emerge and the patch modified accordingly.

kind regards

Olivier


Em 04-03-2012 14:01, Dézsi Szabolcs escreveu:
> Hi!
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=33043
> 
> I added a new button to Start Center. It exits LibreOffice. I used the
> attached picture for testing, I'm not a designer :)
> For testing (or if someone makes a new image if this gets pushed) put
> the attached image (or the final image) called application_exit.png into:
>  icon-themes/galaxy/framework/res
>  icon-themes/human/framework/res
>  icon-themes/tango/framework/res
> 
> and 'make' the appropriate modules (I did a 'make debug=true' in root
> (core) because i don't know which specific modules I had to rebuild).
> 
> Szabolcs
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPU9N8AAoJEJp3R7nH3vLxZAQH/0D+SM5sFufwcf2Ik8yhJzu1
0G2Iai2uTEfh4BwIJUht3hu+K9KN4h5O7ZuXwFuJudUlotf3qHfUniUULPIElw1t
tDqlee3B0tszzFpbZzZxsNNp+cV0w3FUHS8OO9WcaX1C/boXw3RB9kL9AnrR/WnS
YJP+mZ4JViyEUzRybeFFYA16tZAoc37F+eTSJ+0Ng0bChFu3w4bqlA5soG9yz11L
ohtokazkCmBEuJbNzHuFmgD4Cw3s9DoyaxBplWL+epx1M/nH8KnZMJra0cI/JgXS
5I48bRnMRAhYfzDtjkxAL8jD8yBAC6tsLP3mokAoJOYWjyIhYGYzUlMfOSbGGBE=
=uBOW
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix for fdp#44832, correctly display axis labels for complex categories

2012-03-04 Thread Markus Mohrhard
Hey,

the attached patch together with [1] fixes the remaining problems when
you try to edit the chart in the document attached to fdo#44832. [1]
was an obvious fix while the attached patch is not obvious and I'm not
sure that it will not introduce another regression. I don't fully
understand why we need to add special handling for labels of second
and following categories.

Maybe someone here has an idea about the code, otherwise I would push
it to master and wait for people to test it carefully in 3-6.

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a769fd1ec076b61c1ce2f84da87283cc637dd5d5
From 1cda150c6d798f8ba30cd3db58d3faa089f905eb Mon Sep 17 00:00:00 2001
From: Markus Mohrhard 
Date: Sun, 4 Mar 2012 20:45:45 +0100
Subject: [PATCH] don't add special handling for second and following
 categories, fdo#44832

---
 chart2/source/view/axes/VCartesianAxis.cxx |   36 +++-
 1 files changed, 9 insertions(+), 27 deletions(-)

diff --git a/chart2/source/view/axes/VCartesianAxis.cxx b/chart2/source/view/axes/VCartesianAxis.cxx
index a6547ef..8291efb 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -1333,20 +1333,15 @@ void VCartesianAxis::doStaggeringOfLabels( const AxisLabelProperties& rAxisLabel
 for( sal_Int32 nTextLevel=0; nTextLevel apTickIter = createLabelTickIterator( nTextLevel );
+::std::auto_ptr< TickIter > apTickIter = createLabelTickIterator( nTextLevel );
 SAL_WNODEPRECATED_DECLARATIONS_POP
-if(apTickIter.get())
-{
-double fRotationAngleDegree = m_aAxisLabelProperties.fRotationAngleDegree;
-if( nTextLevel>0 )
+if(apTickIter.get())
 {
-lcl_shiftLables( *apTickIter.get(), aCummulatedLabelsDistance );
-fRotationAngleDegree = 0.0;
+double fRotationAngleDegree = m_aAxisLabelProperties.fRotationAngleDegree;
+aCummulatedLabelsDistance += lcl_getLabelsDistance( *apTickIter.get()
+, pTickFactory2D->getDistanceAxisTickToText( m_aAxisProperties )
+, fRotationAngleDegree );
 }
-aCummulatedLabelsDistance += lcl_getLabelsDistance( *apTickIter.get()
-, pTickFactory2D->getDistanceAxisTickToText( m_aAxisProperties )
-, fRotationAngleDegree );
-}
 }
 }
 else if( rAxisLabelProperties.getIsStaggered() )
@@ -1408,18 +1403,9 @@ void VCartesianAxis::createLabels()
 AxisLabelProperties aComplexProps(m_aAxisLabelProperties);
 if( m_aAxisProperties.m_bComplexCategories )
 {
-if( nTextLevel==0 )
-{
-aComplexProps.bLineBreakAllowed = true;
-aComplexProps.bOverlapAllowed = !::rtl::math::approxEqual( aComplexProps.fRotationAngleDegree, 0.0 );
-}
-else
-{
-aComplexProps.bOverlapAllowed = true;
-aComplexProps.bRhythmIsFix = true;
-aComplexProps.nRhythm = 1;
-aComplexProps.fRotationAngleDegree = 0.0;
-}
+aComplexProps.bLineBreakAllowed = true;
+aComplexProps.bOverlapAllowed = !::rtl::math::approxEqual( aComplexProps.fRotationAngleDegree, 0.0 );
+
 }
 AxisLabelProperties& rAxisLabelProperties =  m_aAxisProperties.m_bComplexCategories ? aComplexProps : m_aAxisLabelProperties;
 while( !createTextShapes( m_xTextTarget, *apTickIter.get(), rAxisLabelProperties, pTickFactory2D, nScreenDistanceBetweenTicks ) )
@@ -1515,8 +1501,6 @@ void VCartesianAxis::updatePositions()
 ,static_cast(aTickScreenPos2D.getY()));
 
 double fRotationAngleDegree = m_aAxisLabelProperties.fRotationAngleDegree;
-if( nDepth>0 )
-fRotationAngleDegree = 0.0;
 
 // #i78696# use mathematically correct rotation now
 const double fRotationAnglePi(fRotationAngleDegree * (F_PI / -180.0));
@@ -1615,8 +1599,6 @@ void VCartesianAxis::createShapes()
 if( apTickIter.get() )
 {
 double fRotationAngleDegree = m_aAxisLabelProperties.fRotationAngleDegree;
-if( nTextLevel>0 )
-fRotationAngleDegree = 0.0;
 B2DVector aLabelsDistance( lcl_getLabelsDistance( *apTickIter.get(), pTickFactory2D->getDistanceAxisTickToText( m_aAxisProperties, false ), fRotationAngleDegree ) );
 sal_Int32 nCurrentLength = static_cast(aLabelsDistance.getLength());
 aTickmarkP

Base hangs when trying to close it

2012-03-04 Thread julien2412
Hello,

On master only (I don't have the problem on 3.5 branch), Base hangs when I
try to close it. I must select "Tables"/"Queries" or others to have the
problem. If I just open a file and close, i don't have this problem.

I attached the result of "thread apply all bt" made after Ctrl-C during the
hang.
http://nabble.documentfoundation.org/file/n3798832/bt.txt bt.txt 

gcc (Debian 4.6.2-12) 4.6.2
java version "1.6.0_24"
OpenJDK Runtime Environment (IcedTea6 1.11pre) (6b24~pre2-1)

--with-system-boost
--enable-symbols
--enable-ext-barcode
--enable-ext-diagram
--enable-ext-google-docs
--enable-ext-hunart
--enable-ext-nlpsolver
--enable-ext-ct2n
--enable-ext-numbertext
--enable-ext-oooblogger
--enable-ext-pdfimport
--enable-postgresql-sdbc
--enable-ext-presenter-console
--enable-ext-presenter-minimizer
--enable-ext-report-builder
--enable-ext-scripting-beanshell
--enable-ext-scripting-javascript
--enable-ext-typo
--enable-ext-validator
--enable-ext-watch-window
--enable-ext-wiki-publisher
--enable-dbus
--enable-graphite
--enable-evolution2
--enable-werror
--enable-debug
--enable-dbgutil
--enable-crashdump
--enable-kde4
--enable-dependency-tracking
--enable-online-update

Before opening a bug on tracker, I made some research and wonder if it could
be the result of :
2eaa1422a032d6a7ffc72a2abeb3dd3e6248a263 or
81921bec4b81b7e3e87c24a6b4e3cfdd0cced47d but it's just some guess.

Any idea ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/Base-hangs-when-trying-to-close-it-tp3798832p3798832.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Cor Nouws

Cor Nouws wrote (04-03-12 19:56)


( Of coursethat could become easier when a full VM is made
available - IIRC, there were thoughts about that.)


Having read some other mails here, I know I correctly remembered that  ;-)

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on|46961   |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Cor Nouws

Hi Norbert,

Norbert Thiebaud wrote (04-03-12 13:56)

On Sun, Mar 4, 2012 at 4:30 AM, Cor Nouws  wrote:



I have the idea that it might be useful to consider encouraging devs on
Linux to use Windows in a VM.


I've tried a couple of time, without success, to get a build running on Windows.
[...[
anyway... just taking the occasion to vent a bit...


:-)

I was not talking about building in a Windows environment. ( Of course 
that could become easier when a full VM is made available - IIRC, there 
were thoughts about that.)
It was just about having Windows available to run a completed build, to 
be able to check things.


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs






>PS: if the patch is needed, than let me know where to position the button. 
>With the original patch it's positioned right next to the "Get more 
>information about LibreOffice" >button. Maybe it would be better on the right 
>end of the window (between Templates...)

I mean under Templates... ;)
  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs

PS: if the patch is needed, than let me know where to position the button. With 
the original patch it's positioned right next to the "Get more information 
about LibreOffice" button. Maybe it would be better on the right end of the 
window (between Templates...)

Szabolcs
  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs

> 
> what's the purpose of such a button?
> once you are in the start center you already can close everything
> simply hitting the "X" button in the right upper corner.
> 
> please, understand I'm not criticizing your patch, I'm just curious to know
> why users would need it.
> 

Well, i really don't know :) I just saw it in the buglist, and thought it can't 
be too difficult to implement. So I just posted the patch to let the developers 
decide. Btw.: I think too that exiting with the "X" in the corner is very 
comfortable already.

Szabolcs
  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Tommy
On Sun, 04 Mar 2012 18:01:22 +0100, Dézsi Szabolcs  
 wrote:




Hi!

https://bugs.freedesktop.org/show_bug.cgi?id=33043

I added a new button to Start Center. It exits LibreOffice. I used the  
attached picture for testing, I'm not a designer :)



 snip



what's the purpose of such a button?
once you are in the start center you already can close everything
simply hitting the "X" button in the right upper corner.

please, understand I'm not criticizing your patch, I'm just curious to know
why users would need it.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED][PATCH] convert SV_DECL_PTRARR_DEL to boost::ptr_vector in sc/inc/viewuno.hxx

2012-03-04 Thread Ivan Timofeev

Hi Noel,

On 29.02.2012 15:24, Noel Grandin wrote:

New patch with recommended fixes attached.


Great! Pushed, thanks.


I wonder, would it not be better to convert this type of listener-list
thing to boost::ptr_set?
- no chance of accidentally adding duplicates


Objects are created right before push_back, so I think the code is safe 
as it is.



- O(1) deletion


...and not-so-fast insertion. IMHO listeners are inserted more often 
then removed. But you can disagree, of course. :)


Anyway, there is another improvement now - convert these size() to empty():

sal_uInt16 nCount = aMouseClickHandlers.size();
...
if (aMouseClickHandlers.size() == 1 && nCount == 0)


Thanks again,
Ivan


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Kalman Kemenczy  changed:

   What|Removed |Added

 Depends on||46961

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: What's the logic behind that new "footer" in WRITER

2012-03-04 Thread Stefan Knorr (Astron)
(I answered that directly. Just so you know...)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs

Hi!

https://bugs.freedesktop.org/show_bug.cgi?id=33043

I added a new button to Start Center. It exits LibreOffice. I used the attached 
picture for testing, I'm not a designer :)
For testing (or if someone makes a new image if this gets pushed) put the 
attached image (or the final image) called application_exit.png into:
 icon-themes/galaxy/framework/res
 icon-themes/human/framework/res
 icon-themes/tango/framework/res

and 'make' the appropriate modules (I did a 'make debug=true' in root (core) 
because i don't know which specific modules I had to rebuild).

Szabolcs
  From b5e71d6cc1e02947463d0e607b7435a74619b5b1 Mon Sep 17 00:00:00 2001
From: Szabolcs Dezsi 
Date: Sun, 4 Mar 2012 17:52:54 +0100
Subject: [PATCH] Start Center exit button

---
 framework/inc/framework.hrc |2 ++
 framework/source/services/backingwindow.cxx |   10 ++
 framework/source/services/backingwindow.hxx |1 +
 framework/source/services/fwk_services.src  |9 +
 4 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/framework/inc/framework.hrc b/framework/inc/framework.hrc
index e92e50b..43677a8 100644
--- a/framework/inc/framework.hrc
+++ b/framework/inc/framework.hrc
@@ -54,6 +54,7 @@
 #define STR_BACKING_EXTHELP 6
 #define STR_BACKING_INFOHELP7
 #define STR_BACKING_TPLREP  8
+#define STR_BACKING_EXITHELP		9
 
 #define RES_BACKING_IMAGES  (DLG_BACKING+1)
 
@@ -68,6 +69,7 @@
 #define BMP_BACKING_FORMULA 15
 #define BMP_BACKING_OPENFILE16
 #define BMP_BACKING_OPENTEMPLATE17
+#define BMP_BACKING_EXIT		18
 
 // Ids of TabWindow
 #define WIN_TABWINDOW   (RID_FWK_DIALOG_START_CORRECT+101)
diff --git a/framework/source/services/backingwindow.cxx b/framework/source/services/backingwindow.cxx
index 0b89769..ffbe00d 100644
--- a/framework/source/services/backingwindow.cxx
+++ b/framework/source/services/backingwindow.cxx
@@ -191,6 +191,7 @@ BackingWindow::BackingWindow( Window* i_pParent ) :
 String aExtHelpText( FwkResId( STR_BACKING_EXTHELP ) );
 String aInfoHelpText( FwkResId( STR_BACKING_INFOHELP ) );
 String aTplRepHelpText( FwkResId( STR_BACKING_TPLREP ) );
+String aExitHelpText( FwkResId( STR_BACKING_EXITHELP ) );
 
 // clean up resource stack
 FreeResource();
@@ -223,6 +224,11 @@ BackingWindow::BackingWindow( Window* i_pParent ) :
 maToolbox.SetItemCommand( nItemId_Info, String( RTL_CONSTASCII_USTRINGPARAM( ".HelpId:StartCenter:Info" ) ) );
 maToolbox.ShowItem( nItemId_Info );
 
+maToolbox.InsertItem( nItemId_Exit, Image() );
+maToolbox.SetItemText( nItemId_Exit, aExitHelpText );
+maToolbox.SetQuickHelpText( nItemId_Exit, aExitHelpText );
+maToolbox.ShowItem( nItemId_Exit );
+
 // get dispatch provider
 mxDesktop = Reference( comphelper::getProcessServiceFactory()->createInstance(SERVICENAME_DESKTOP ),UNO_QUERY );
 if( mxDesktop.is() )
@@ -437,6 +443,7 @@ void BackingWindow::initBackground()
 maToolbox.SetItemImage( nItemId_Extensions, BitmapEx( FwkResId( BMP_BACKING_EXT ) ) );
 maToolbox.SetItemImage( nItemId_Info, BitmapEx( FwkResId( BMP_BACKING_INFO ) ) );
 maToolbox.SetItemImage( nItemId_TplRep, BitmapEx( FwkResId( BMP_BACKING_TPLREP ) ) );
+maToolbox.SetItemImage( nItemId_Exit, BitmapEx( FwkResId( BMP_BACKING_EXIT ) ) );
 
 maWelcome.SetControlForeground( maWelcomeTextColor );
 maWelcome.SetBackground();
@@ -912,6 +919,9 @@ IMPL_LINK_NOARG(BackingWindow, ToolboxHdl)
 pNodePath = "/org.openoffice.Office.Common/Help/StartCenter";
 pNode = "TemplateRepositoryURL";
 break;
+case nItemId_Exit:
+Application::Quit();
+break;
 default:
 break;
 }
diff --git a/framework/source/services/backingwindow.hxx b/framework/source/services/backingwindow.hxx
index 179a632..c0b03cb 100644
--- a/framework/source/services/backingwindow.hxx
+++ b/framework/source/services/backingwindow.hxx
@@ -137,6 +137,7 @@ namespace framework
 static const int nItemId_Extensions = 1;
 static const int nItemId_Info = 3;
 static const int nItemId_TplRep = 4;
+static const int nItemId_Exit = 5;
 static const int nShadowTop = 32;
 static const int nShadowLeft = 35;
 static const int nShadowRight = 45;
diff --git a/framework/source/services/fwk_services.src b/framework/source/services/fwk_services.src
index 536b3d7..f3ac032 100644
--- a/framework/source/services/fwk_services.src
+++ b/framework/source/services/fwk_services.src
@@ -65,6 +65,11 @@ Window DLG_BACKING
 {
 Text [ en-US ] = "Get more templates for %PRODUCTNAME";
 };
+
+String STR_BACKING_EXITHELP
+{
+	Text [ en-US ] = "Exit %PRODUCTNAME";
+};
 };
 
 Resource RES_BACKING_IMAGES
@@ -81,6 +86,10 @@ Resource RES_BACKING_IMAGES
 {
 File = "addtemplate_32

Re: make version on Windows, cygpath problems, ..

2012-03-04 Thread Tor Lillqvist
> I was once curious why 386161779b55755f145106cd53c5df80967e1c3b
> was necessary, so I tried to install more versions of make and indeed make 
> 3.81
> does not like mixed paths (cygpath -m) and needs unix paths in make's rules.

I use our very own patched make 3.82 on Cygwin...

> Because of this there are many problems, we need
> gb_Helper_convert_native and similar things.

Nah, that is needed because the compiler and other native Windows
tools don't understand Cygwin paths.

> Do you think it's worth a try ?

Anything that can make the makefiles simpler is worth a try

I tried reverting 386161779b55755f145106cd53c5df80967e1c3b and indeed
now I see no problem. If I remove the workdir/wntmsci12*/bootstrap
file, dmake gets rebuilt just fine. Hmm. I don't remember what problem
it was I saw when I did 386161779b55755f145106cd53c5df80967e1c3b.
Maybe it indeed can be reverted. Maybe something else has changed that
now makes it unnecessary.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[REVIEW] fix for fdo#46885, crash with empty data range when creating charts

2012-03-04 Thread Markus Mohrhard
Hey,

[1] fixes a crash when you try to create a chart and have an empty
data range selected. This is a regression between 3.5.0 and 3.5.1
introduced by another fix for crashes in calc charts.

The fix is extremely safe it just checks that the uno interface is not empty.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


make version on Windows, cygpath problems, ..

2012-03-04 Thread Matúš Kukan
Hi all,

I was once curious why 386161779b55755f145106cd53c5df80967e1c3b
was necessary, so I tried to install more versions of make and indeed make 3.81
does not like mixed paths (cygpath -m) and needs unix paths in make's rules.
Because of this there are many problems, we need
gb_Helper_convert_native and similar things.

We already check for our patched make and print warning [1],
so I am wondering, could we force people to use it ?

It's broken for make 3.81 since a75873dea15719b5216cfd0476d30003ffc76e80 anyway
and nobody is complaining so far (but it's +- only a week).

I am optimistic and I think by forcing people to use make 3.82 on cygwin,
we could remove solenv/gbuild/BuildDirs.mk and use ~only mixed paths.
There still will be problems (realpath is producing unix path,
some programs need unix paths [2], ..)
but hopefully it will be better.

Do you think it's worth a try ?

Matus

[1] http://cgit.freedesktop.org/libreoffice/core/tree/configure.in#n11067
[2] 
http://cgit.freedesktop.org/libreoffice/core/tree/clucene/source/Makefile#n32
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[REVIEW 3.5.1] [PUSHED 3-5] Re: [REVIEW] redundantAssignInSwitch in connectivity/source/drivers/postgresql/pq_tools.cxx

2012-03-04 Thread julien2412
Seen with Niko Rönkkö  on IRC, I pushed it on 3.5 branch.

Ok for 3.5.1 too ?

Julien.

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-redundantAssignInSwitch-in-connectivity-source-drivers-postgresql-pq-tools-cxx-tp3796908p3798266.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Improvement to fdo#46565

2012-03-04 Thread Thomas Collerton
2012/3/2 Thomas Collerton 

> Hi, thanks for the tip. This is an improved (hopefully) version of the
> patch =)
> Cheers!
>
>
> 2012/2/29 Michael Meeks 
>
>> Hi there,
>>
>> On Wed, 2012-02-29 at 11:58 +0100, Thomas Collerton wrote:
>> > this patch accomplishes what the EasyHack requests =)
>>
>> Thanks - pushed it :-)
>>
>>Personally, I'd have split out the 'write_args' type functionality
>> below that into a method of it's own, and added a read_args / write_args
>> pair - so that all the I/O is in perl rather than a system forked
>> whatnot but ... ! :-) I'm paranoid too - we should have cp around on all
>> systems that run this.
>>
>>Ta. very much, can you close the bug ?
>>
>>Thanks,
>>
>>Michael.
>>
>> --
>> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>>
>>
>
From 4a7c6aa1efcff881a3552f43c244e4ac0c1240c8 Mon Sep 17 00:00:00 2001
From: Thomas Collerton 
Date: Fri, 2 Mar 2012 20:21:59 +0100
Subject: [PATCH] Improvement to fdo#46565

---
 autogen.sh |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/autogen.sh b/autogen.sh
index 2133d07..2935619 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -146,7 +146,12 @@ if (defined $ENV{NOCONFIGURE}) {
 if (scalar(@cmdline_args) > 0) {
 # if there's already an autogen.lastrun, make a backup first
 if (-e "autogen.lastrun") {
-system("cp autogen.lastrun autogen.lastrun.bak");
+open (my $fh, "autogen.lastrun") || warn "can't open autogen.lastrun. \n";
+open (BAK, ">autogen.lastrun.bak") || warn "can't create backup file. \n";
+while (<$fh>) {
+print BAK;
+}
+close (BAK) && close ($fh);
 }
 # print "writing args to autogen.lastrun\n";
 my $fh;
@@ -159,7 +164,8 @@ if (defined $ENV{NOCONFIGURE}) {
 }
 elsif ( ! -e "autogen.lastrun")
 {
-system("touch autogen.lastrun");
+open (my $fh, ">autogen.lastrun") || die "can't create autogen.lastrun";
+close ($fh);
 }
 print "running ./configure with '" . join ("' '", @args), "'\n";
 system ("./configure", @args) && die "Error running configure";
-- 
1.7.9.2

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


"StarONE" ?

2012-03-04 Thread Tor Lillqvist
If you do an opengrok "full" search for "starone", you will find a
bunch of comments mainly. At first I thought "StarONE" was some
abandoned StarDivision product that StarOffice used to interface to,
and that these comments were indicators of code snippets that aren't
needed. But apparently it was simply the name for the StarOffice SDK
or something like that? So presumably we could add a (very) Easy Hack
to change these comments to simpy say "the SDK" instead?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Jesús Corrius
On Sun, Mar 4, 2012 at 1:58 PM, Norbert Thiebaud  wrote:
> On Sun, Mar 4, 2012 at 6:43 AM, Tor Lillqvist  wrote:
>>> Getting the resources for that task (setting up a image with a complete 
>>> build
>>> env) is the tough one here IMHO.
>>
>> Didn't Jésus announce he made such a virtual machine image just some
>> week ago? Available to anybody who can prove they have licenses for
>> the included proprietary software.
>
> he has, but he has not found yet a way to upload 5.2GB somewhere where
> I could download it...
> (and yes I do have the licenses)

I have already found a place for it. As far as I know, Michael and
Thorsten are already using it ;)

-- 
Jesús Corrius 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Norbert Thiebaud
On Sun, Mar 4, 2012 at 6:43 AM, Tor Lillqvist  wrote:
>> Getting the resources for that task (setting up a image with a complete build
>> env) is the tough one here IMHO.
>
> Didn't Jésus announce he made such a virtual machine image just some
> week ago? Available to anybody who can prove they have licenses for
> the included proprietary software.

he has, but he has not found yet a way to upload 5.2GB somewhere where
I could download it...
(and yes I do have the licenses)

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Norbert Thiebaud
On Sun, Mar 4, 2012 at 4:30 AM, Cor Nouws  wrote:
> Hi devs,
>
> I have the idea that it might be useful to consider encouraging devs on
> Linux to use Windows in a VM.

I've tried a couple of time, without success, to get a build running on Windows.
The instructions are, to say the least, not clear. there is always a
piece missing or not where it wants it...
and it takes minutes at the beginning (when the failure is in autogen)
and hours later to find the brokage...
and then it is usually a mystery (to me) what the problem is and how to fix it.

This Week-end I tried to through a big virtual box at the problem: 24
core, 32GB under kvm (on a host that has 48 core/96GB ram)
the kvm process has consumed 4332 minutes-cpu so far... (yeah, not  a
typo:  3cpu-day) and tail_build is in writerfilter

so I reduced the box to 4 process 4 GB... and it run... faster...
well... less slow.

and after hours and hours I get 'dxsdkver.h No such file or directory ...
so apparently the directx sdk was not found... and only now do i get an error ?

anyway... just taking the occasion to vent a bit...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Tor Lillqvist
> Getting the resources for that task (setting up a image with a complete build
> env) is the tough one here IMHO.

Didn't Jésus announce he made such a virtual machine image just some
week ago? Available to anybody who can prove they have licenses for
the included proprietary software.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [UX advise] Key navigation in ValueSet controls

2012-03-04 Thread Matteo Casalin

Hi Astron,

On 03/03/2012 04:07 PM, Stefan Knorr (Astron) wrote:

Hi Matteo,

so, took me a while to find the courage to read that :) But good
observations these are.


Yeah, I was quite afraid of the length of my email :) Thanks for reading 
it all!



Anyway, ...


Is this behavior the expected/commonly accepted one?
I would like to propose:
* left/right motion should not wrap around from first to last (or last
  to first) item. Moving through lines is fine (behavior similar to
  moving through text), although we can also just stay on the same line
  and stop at its borders.


Makes sense to me. Although, of course the decision depends on whether
we want to make it fast to go to an arbitrary position without much
exactitude or whether we want to make it fast to go to the exact
start/end. Your proposal seemingly aims for goal #2.



Well, in this case my goal is to let the user see the content of 
not-full rows without explicitly looking for it, and to move rapidly 
from an item to another without too much corrections.





* up/down should not wrap around. If pressing up on a middle column of
  the first line, then it moves to the first item. If pressing down, it
  should move to the column below if present, to the last item
  otherwise.


 From my Western perspective that does make sense. However, I fear,
such behaviour might be unexpected in some cultures (that use
top-to-bottom scripts). Any experts?



Good catch. Also speaking from a Western perspective, I find it somewhat 
confusing to be brought at the opposite side of the one I was moving to 
(and columns can be long and involve scrolling, while rows don't 
scroll). My point is that currently left/right let you navigate through 
all the items, while up/down keys can leave a row "hidden".





* page up/down should mimic the behaviour of up/down keys: move in the
  same column when possible (even if the distance is less than a page)
  and, when pressed again and no motion in the current column is
  possible, reach the first/last element. I don't know if disabling
  navigation when key-modifiers are pressed makes sense.


Makes sense. I guess, modifiers should be allowed (but not modify
anything), in all cases where that's possible without unintended
consequences.



I don't know the original goals of that features: currently it seems to 
me that if you use modifiers than nothing happens.





* If "none" item is present, then it could be accessed only from the
  first item by pressing any of left/up (also page up/home ?) keys.
  When selected, it can be exited only by pressing right/down (also
  page down/end?) keys, but always lead to the first item.


Makes sense.


I'm less sure of this, now. If a wrap around for up/down is desired, the 
current behavior of always passing through the "none" item probably 
makes more sense. Unless we find a dedicated key to select that item, 
which could solve the situation. Any idea?





* Return key behavior: at least it should not close the color
  configuration window, but my guess is that's a misconfiguration of
  the specific instance of ValueSet.


Not entirely sure about this one, although probably most people would
want to use Return and Tab the same way (i. e. to get to the next
widget and select a colour).



Wow. Too many things I didn't consider!
Honestly, my plans were to simplify code and provide a more consistent 
behavior than the current one, that I find somehow confusing.
I guess we should wait for some hints on the desired up/down behavior 
and then see how to proceed (if there's need to).


Thanks for your thoughts!
Matteo



Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Remove unused code (22)

2012-03-04 Thread Elton Chung
Hi,
This patch removes 12 unused methods.

Best Regards,
Elton


Remove-unused-code-22.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Bjoern Michaelsen
Hi,

On Sun, Mar 04, 2012 at 11:30:08AM +0100, Cor Nouws wrote:
> I have the idea that it might be useful to consider encouraging devs
> on Linux to use Windows in a VM.
> I know that some of the devs are actively using Windows build
> environments, but also that others haven't even a running Win OS to
> check certain issues.
> Setting up a VM is not a big deal, and if needed the Board could
> step in paying for licences.
> It would make checking / communicating on certain issues much
> easier. Checking yourself is more direct and often not much more
> work than commenting that you cannot, and hope that others will shed
> some light on it etc. Well, I could continue with listing other
> advantages.

While that is all true, I wonder if it really hits the core of the problem. A
developer would usually want to go fixing the bug and for that he would not
only need a LibreOffice install, but instead a whole development environment to
make debug build of effected libraries etc. And even with such a setup the
build times are much longer and the deployment is much more clumsy than on
Windows.

It would only be worth it if we not only have licenses, but a ready-to-use VM
image with a complete windows build environment. That might also help to get
traction with Windows developers new to the project. However, it is also a lot
of work -- not only to create it, but also to keep it up to date.

Getting the resources for that task (setting up a image with a complete build
env) is the tough one here IMHO.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: using Windows in VM

2012-03-04 Thread Jonathan Aquilina

On 04/03/2012 11:30, Cor Nouws wrote:

Hi devs,

I have the idea that it might be useful to consider encouraging devs 
on Linux to use Windows in a VM.
I know that some of the devs are actively using Windows build 
environments, but also that others haven't even a running Win OS to 
check certain issues.
Setting up a VM is not a big deal, and if needed the Board could step 
in paying for licences.
It would make checking / communicating on certain issues much easier. 
Checking yourself is more direct and often not much more work than 
commenting that you cannot, and hope that others will shed some light 
on it etc. Well, I could continue with listing other advantages.


( I installed Win7 in a Virtualbox myself for testing and can confirm 
that it did not ruin my primary OS, nor the HDD and that it's easy to 
close once you're done ;-) )


Cheers,



Don't get me wrong its a great idea, but one thing I have noticed when 
testing development releases of Ubuntu, that bugs surface in the vm that 
don't end up surfacing on a physical install.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


using Windows in VM

2012-03-04 Thread Cor Nouws

Hi devs,

I have the idea that it might be useful to consider encouraging devs on 
Linux to use Windows in a VM.
I know that some of the devs are actively using Windows build 
environments, but also that others haven't even a running Win OS to 
check certain issues.
Setting up a VM is not a big deal, and if needed the Board could step in 
paying for licences.
It would make checking / communicating on certain issues much easier. 
Checking yourself is more direct and often not much more work than 
commenting that you cannot, and hope that others will shed some light on 
it etc. Well, I could continue with listing other advantages.


( I installed Win7 in a Virtualbox myself for testing and can confirm 
that it did not ruin my primary OS, nor the HDD and that it's easy to 
close once you're done ;-) )


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice