[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673

ahmad.khuns...@gmail.com changed:

   What|Removed |Added

   Keywords||patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[REVIEW-3-5] fix for fdo#45679, autofilter needs a lot of time to show-up for large amount of data

2012-03-25 Thread Markus Mohrhard
Hey,

[1] saves us a lot of time initializing the autofilter pop-up by
skipping the O(n^2) algorithm that inserts an entry and updates the
view for each new entry. During initialization we can skip this
algorithm without a problem and save around 96% of the time. [2] does
exactly the same thing for the range name dialogs which use the same
dialog base class.

The patch is simple and brings us nearly back to our old 3.4 performance.

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd20b48795df0e23ac76d516d56366250157515f
[2] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb2c9eb114d3a76096fd404d733f86702246b60e
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Adapt arrowhead to corrected handling of z in path in svg

2012-03-25 Thread Regina Henschel

Hi all,

Thorsten has corrected the handling of z in svg paths. This affects the 
arrowheads in the standard.soe palette too. Here is patch to adapt the m 
commands in the arrowheads to the new handling.


I have no current build in the moment. So please test the patch before 
you commit it.


Kind regards
Regina

From ed7e2baacfcfd1c656961bd9a81bc12af58fb250 Mon Sep 17 00:00:00 2001
From: Regina Henschel 
Date: Sun, 25 Mar 2012 21:12:52 +0200
Subject: [PATCH] Adapt arrowhead pathes to corrected svg path z hangling

---
 extras/source/palettes/standard.soe |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/extras/source/palettes/standard.soe 
b/extras/source/palettes/standard.soe
index 5a8acd9..4b576b1 100644
--- a/extras/source/palettes/standard.soe
+++ b/extras/source/palettes/standard.soe
@@ -13,11 +13,11 @@
   
   
   
-  
-  
+  
+  
   
   
-  
-  
+  
+  
   
 
\ No newline at end of file
-- 
1.7.5.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Added support for gnu-make $(file when available

2012-03-25 Thread Thorsten Behrens
Norbert Thiebaud wrote:
> I've also back-ported the feature in gnu-make 3.82 in contrib/dev-tools
> 
Cool, let me update the tinderboxes! :)

Nice work,

-- Thorsten


pgpNWqdc3RWx9.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] remove unused code (oox)

2012-03-25 Thread Petr Vorel
Hi there,

removed some code from oox.

Regards,
Petr
>From e04049e2554a94ce80dc21dfe390e91c8fd8bc41 Mon Sep 17 00:00:00 2001
From: Petr Vorel 
Date: Thu, 22 Mar 2012 20:14:13 +0100
Subject: [PATCH] remove unused code (oox)

---
 oox/source/ole/vbaprojectfilter.cxx   |   13 -
 sc/source/filter/inc/biffinputstream.hxx  |   27 +---
 sc/source/filter/inc/biffoutputstream.hxx |5 --
 sc/source/filter/inc/drawingmanager.hxx   |4 --
 sc/source/filter/oox/biffdetector.cxx |5 --
 sc/source/filter/oox/biffinputstream.cxx  |   11 -
 sc/source/filter/oox/biffoutputstream.cxx |   16 ---
 sc/source/filter/oox/drawingmanager.cxx   |   71 -
 sc/source/filter/oox/excelfilter.cxx  |   27 ---
 sc/source/filter/oox/ooxformulaparser.cxx |5 --
 unusedcode.easy   |   13 -
 11 files changed, 1 insertions(+), 196 deletions(-)

diff --git a/oox/source/ole/vbaprojectfilter.cxx b/oox/source/ole/vbaprojectfilter.cxx
index e152598..f4698fa 100644
--- a/oox/source/ole/vbaprojectfilter.cxx
+++ b/oox/source/ole/vbaprojectfilter.cxx
@@ -77,19 +77,6 @@ OUString SAL_CALL WordVbaProjectFilter_getImplementationName() throw()
 return CREATE_OUSTRING( "com.sun.star.comp.oox.WordVbaProjectFilter" );
 }
 
-Sequence< OUString > SAL_CALL WordVbaProjectFilter_getSupportedServiceNames() throw()
-{
-Sequence< OUString > aSeq( 1 );
-aSeq[ 0 ] = CREATE_OUSTRING( "com.sun.star.document.ImportFilter" );
-return aSeq;
-}
-
-Reference< XInterface > SAL_CALL WordVbaProjectFilter_createInstance(
-const Reference< XComponentContext >& rxContext ) throw( Exception )
-{
-return static_cast< ::cppu::OWeakObject* >( new WordVbaProjectFilter( rxContext ) );
-}
-
 // 
 
 WordVbaProjectFilter::WordVbaProjectFilter( const Reference< XComponentContext >& rxContext ) throw( RuntimeException ) :
diff --git a/sc/source/filter/inc/biffinputstream.hxx b/sc/source/filter/inc/biffinputstream.hxx
index 9f01b02..47ee2b0 100644
--- a/sc/source/filter/inc/biffinputstream.hxx
+++ b/sc/source/filter/inc/biffinputstream.hxx
@@ -129,16 +129,7 @@ private:
 Trying to read over the record limits results in a stream error. The
 isValid() function indicates that by returning false. From now on the data
 returned by the read functions is undefined. The error state will be reset,
-if the record is reset (with the function resetRecord()), or if the next
-record is started.
-
-To switch off the automatic lookup of CONTINUE records, use resetRecord()
-with false parameter. This is useful e.g. on import of drawing layer data,
-where sometimes solely CONTINUE records will occur. The automatic lookup
-keeps switched off until the method resetRecord() is called with parameter
-true. All other settings done on the stream (e.g. alternative CONTINUE
-record identifier, enabled decryption, NUL substitution character) will be
-reset to default values, if a new record is started.
+if the next record is started.
 
 The import stream supports decrypting the stream data. The contents of a
 record (not the record header) will be encrypted by Excel if the file has
@@ -189,22 +180,6 @@ public:
  */
 boolstartRecordByHandle( sal_Int64 nRecHandle );
 
-/** Sets stream pointer to begin of record content.
-
-@param bContLookup
-Automatic CONTINUE lookup on/off. In difference to other stream
-settings, this setting is persistent until next call of this
-function (because it is wanted to receive the next CONTINUE records
-separately).
-@param nAltContId
-Sets an alternative record identifier for content continuation.
-This value is reset automatically when a new record is started with
-startNextRecord().
- */
-voidresetRecord(
-bool bContLookup,
-sal_uInt16 nAltContId = BIFF_ID_UNKNOWN );
-
 /** Sets stream pointer before current record and invalidates stream.
 
 The next call to startNextRecord() will start again the current record.
diff --git a/sc/source/filter/inc/biffoutputstream.hxx b/sc/source/filter/inc/biffoutputstream.hxx
index a38bfdf..f7a6462 100644
--- a/sc/source/filter/inc/biffoutputstream.hxx
+++ b/sc/source/filter/inc/biffoutputstream.hxx
@@ -110,8 +110,6 @@ public:
 
 /** Returns the absolute position in the wrapped binary stream. */
 sal_Int64   tellBase() const;
-/** Returns the total size of the wrapped binary stream. */
-sal_Int64   sizeBase() const;
 
 // BinaryOutputStream interface (stream write access) -
 
@@ -120,9 +118,6 @@ public:
 /** Writes nBytes bytes from the passed buffer pMem. */
 virtual voidwriteMemory( const void* pMem, s

Added support for gnu-make $(file when available

2012-03-25 Thread Norbert Thiebaud
Recently on gnu-make cvs a new function has been added: $(file
>filename,content)
This allow to put the content on a file natively (without using the
shell, and therefore there is no command line limitation
This can be used to simplify $(var2file, whihc I have long suspected
to be the reason why MacOSX is occasionally failing with 'Too Many
Open Files' errors.

I've pushed 2 patches. one add the detection of that feature in
gnumake during configure, the other use a simplified $(var2file when
that feature is available

I've also back-ported the feature in gnu-make 3.82 in contrib/dev-tools


Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: top level make build is executing unit tests

2012-03-25 Thread Matúš Kukan
Hello Markus, all

On 25 March 2012 16:37, Markus Mohrhard  wrote:
> right now a top level make build is executing unit tests again. Is
> this behavior really expected? It makes it quite hard to execute a
> full rebuild while working on new tests.

Toplevel's make build is different from the modules' make build.
_For me_ it's more like: do only build LibreOffice without installing.
But of course it could also mean without running tests.

For now, I created patch, which allows you to build what you want in
module. (when the make is triggered by build.pl)
Default is: make all slowcheck # all="build unitcheck"
You need to set gb_MAKETARGET like this:
make gb_MAKETARGET=build all
make gb_MAKETARGET="unitcheck slowcheck" # prolly does not make sense
make gb_MAKETARGET=build tools.all
or whatever you want.

Of course we can automatically set gb_MAKETARGET=build when running
toplevel's make build
if people don't use it like it was the same as 'make all' and was
supposed to mean:
build LibreOffice without dev-installing and running subsequent checks.

If there is input from people to tell how we should set targets, .., I
think we can do ~anything.

Best,
Matúš
From 71935f591dfed72ad190f4741fca752194aac1d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?= 
Date: Sun, 25 Mar 2012 18:09:37 +0200
Subject: [PATCH] The return of gb_MAKETARGET: allows us to set build targets

---
 Makefile   |7 +++
 solenv/inc/gbuildbridge.mk |4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4386267..9090c84 100644
--- a/Makefile
+++ b/Makefile
@@ -6,6 +6,13 @@ ifeq ($(MAKECMDGOALS),)
 MAKECMDGOALS:=all
 endif
 
+# gb_MAKETARGET is used in gbuildbridge.mk, to set what we want to build.
+# We communicate this way because the build is still controlled by build.pl.
+# Default is to build everything and run slowchecks together with unitchecks.
+ifeq ($(gb_MAKETARGET),)
+export gb_MAKETARGET:=all slowcheck
+endif
+
 all: build
 
 SHELL=/usr/bin/env bash
diff --git a/solenv/inc/gbuildbridge.mk b/solenv/inc/gbuildbridge.mk
index 529d6e2..b358bdc 100644
--- a/solenv/inc/gbuildbridge.mk
+++ b/solenv/inc/gbuildbridge.mk
@@ -34,8 +34,8 @@ TARGET=prj
 all:
 .ELIF "$(VERBOSE)"!=""
 all:
-	cd $(PRJ) && $(GNUMAKE) -r -j$(GMAKE_MODULE_PARALLELISM) all slowcheck
+	cd $(PRJ) && $(GNUMAKE) -r -j$(GMAKE_MODULE_PARALLELISM) $(gb_MAKETARGET)
 .ELSE
 all:
-	@cd $(PRJ) && $(GNUMAKE) -rs -j$(GMAKE_MODULE_PARALLELISM) all slowcheck
+	@cd $(PRJ) && $(GNUMAKE) -rs -j$(GMAKE_MODULE_PARALLELISM) $(gb_MAKETARGET)
 .END
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Remove unused code (svtools)

2012-03-25 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy
From 08525faa466535c5f10bcd413199351f5d953975 Mon Sep 17 00:00:00 2001
From: Santiago Martinez 
Date: Sun, 25 Mar 2012 18:24:32 +0200
Subject: [PATCH] Remove unused code in svtools.

---
 svtools/source/filter/wmf/winmtf.cxx |   23 ---
 svtools/source/filter/wmf/winmtf.hxx |3 ---
 2 files changed, 0 insertions(+), 26 deletions(-)

diff --git a/svtools/source/filter/wmf/winmtf.cxx b/svtools/source/filter/wmf/winmtf.cxx
index 090886e..d9597ff 100644
--- a/svtools/source/filter/wmf/winmtf.cxx
+++ b/svtools/source/filter/wmf/winmtf.cxx
@@ -658,13 +658,6 @@ void WinMtfOutput::SelectObject( sal_Int32 nIndex )
 
 //---
 
-void WinMtfOutput::SetFont( const Font& rFont )
-{
-maFont = rFont;
-}
-
-//---
-
 const Font& WinMtfOutput::GetFont() const
 {
 return maFont;
@@ -679,13 +672,6 @@ void WinMtfOutput::SetTextLayoutMode( const sal_uInt32 nTextLayoutMode )
 
 //---
 
-sal_uInt32 WinMtfOutput::GetTextLayoutMode() const
-{
-return mnTextLayoutMode;
-}
-
-//---
-
 void WinMtfOutput::SetBkMode( sal_uInt32 nMode )
 {
 mnBkMode = nMode;
@@ -1151,15 +1137,6 @@ void WinMtfOutput::LineTo( const Point& rPoint, sal_Bool bRecordPath )
 
 //---
 
-void WinMtfOutput::DrawLine( const Point& rSource, const Point& rDest )
-{
-UpdateClipRegion();
-UpdateLineStyle();
-mpGDIMetaFile->AddAction( new MetaLineAction( ImplMap( rSource), ImplMap( rDest ), maLineStyle.aLineInfo ) );
-}
-
-//---
-
 void WinMtfOutput::DrawRect( const Rectangle& rRect, sal_Bool bEdge )
 {
 UpdateClipRegion();
diff --git a/svtools/source/filter/wmf/winmtf.hxx b/svtools/source/filter/wmf/winmtf.hxx
index 6f5e778..bf81be5 100644
--- a/svtools/source/filter/wmf/winmtf.hxx
+++ b/svtools/source/filter/wmf/winmtf.hxx
@@ -696,10 +696,8 @@ public:
 voidSelectObject( sal_Int32 nIndex );
 CharSet GetCharSet(){ return maFont.GetCharSet(); };
 WinMtfFillStyle&GetFillStyle () { return maFillStyle; }
-voidSetFont( const Font& rFont );
 const Font& GetFont() const;
 voidSetTextLayoutMode( const sal_uInt32 nLayoutMode );
-sal_uInt32  GetTextLayoutMode() const;
 
 voidClearPath(){ aPathObj.Init(); };
 voidClosePath(){ aPathObj.ClosePath(); };
@@ -708,7 +706,6 @@ public:
 voidMoveTo( const Point& rPoint, sal_Bool bRecordPath = sal_False );
 voidLineTo( const Point& rPoint, sal_Bool bRecordPath = sal_False );
 voidDrawPixel( const Point& rSource, const Color& rColor );
-voidDrawLine( const Point& rSource, const Point& rDest );
 voidDrawRect( const Rectangle& rRect, sal_Bool bEdge = sal_True );
 voidDrawRoundRect( const Rectangle& rRect, const Size& rSize );
 voidDrawEllipse( const Rectangle& rRect );
-- 
1.7.7.6

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


top level make build is executing unit tests

2012-03-25 Thread Markus Mohrhard
Hey,

right now a top level make build is executing unit tests again. Is
this behavior really expected? It makes it quite hard to execute a
full rebuild while working on new tests.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[no subject]

2012-03-25 Thread Pubudu Dissanayake

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [LibreOffice] svg export filter

2012-03-25 Thread Thorsten Behrens
Marco Cecchetti wrote:
> > - as you said, check if/when to use native svg text, instead of
> >   glyh-by-glyph placements
> 
> So we agreed, glyh-by-glyph placement should be used only when
> it is mandatory (e.g. text animations that apply on any single
> character of a text string).
> 
Hi Marco,

yeah, I would hope text rendering yields the ~same result nowadays

Cheers,

-- Thorsten


pgpMasRMVhIU6.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: regression in charts introduced by one of the recent table to std::map commits

2012-03-25 Thread Rafael Dominguez
Also commit d1fcea677a0d814ca92a00717a4ff7090291f6cd is wrong, since both
code blocks are different.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Investigation into bug 35862 - allow "increase/decrease font" for text selection with multiple font sizes

2012-03-25 Thread Jordan Chin

Hi devs,

I began investigating this bug: 
https://bugs.freedesktop.org/show_bug.cgi?id=35862


The bug is that the "Increase Font"/"Decrease Font" button should be 
useable when one

selects text of multiple sizes in Writer.

I tried to find where the button was being used and found that the 
button for, for example,
increasing the font size has an ID referenced as FN_GROW_FONT_SIZE. I 
put print statements
for any references I found and was able to find the code that is 
executed when the button
is clicked, but I don't know what code activates/deactivates the actual 
buttons. I suspect
that since this functionality is available in Impress but not Writer 
(which is what the bug
is about), there could be some clue if we consider where the code 
between Writer/Impress differs.


Currently I suspect the file svx/sdi/svx.sdi might have information, in 
the definition of


SfxVoidItem Grow SID_GROW_FONT_SIZE

but I don't know how this hooks in with the application.

As I am new to LibreOffice, I'm wondering if anyone has any ideas where 
I can look next?


Thanks!
Jordan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Convert SV_PTRARR with std::deque

2012-03-25 Thread Bartosz
Hi

I converted the SV PTRARR to std::deque in sw component.
Could you please check and push this path?
This and later contributions is licensed under MPL 1.1 / GPL v3+ / LGPL v3+.

Best Regards
Bartosz





From a0291c115fa588b7e0d2faeb0df38c7a8f694004 Mon Sep 17 00:00:00 2001
From: Bartosz Kosiorek 
Date: Sat, 24 Mar 2012 23:01:06 +0100
Subject: [PATCH] Convert SV_PTRARRAY to ::std::deque

---
 sw/inc/crsrsh.hxx|1 -
 sw/inc/tblsel.hxx|3 ++-
 sw/source/core/crsr/trvltbl.cxx  |2 +-
 sw/source/core/frmedt/fetab.cxx  |   14 +++---
 sw/source/core/frmedt/tblsel.cxx |   33 +++--
 5 files changed, 25 insertions(+), 28 deletions(-)

diff --git a/sw/inc/crsrsh.hxx b/sw/inc/crsrsh.hxx
index fba2e68..0c07972 100644
--- a/sw/inc/crsrsh.hxx
+++ b/sw/inc/crsrsh.hxx
@@ -69,7 +69,6 @@ class SwTxtINetFmt;
 class SwFmtINetFmt;
 class SwTxtAttr;
 class SwTableBox;
-class SwCellFrms;
 class SwTOXMark;
 class SwRedline;
 class IBlockCursor;
diff --git a/sw/inc/tblsel.hxx b/sw/inc/tblsel.hxx
index 5ecc65b..5725956 100644
--- a/sw/inc/tblsel.hxx
+++ b/sw/inc/tblsel.hxx
@@ -34,6 +34,7 @@
 #include "swdllapi.h"
 
 #include 
+#include 
 
 class SwCrsrShell;
 class SwCursor;
@@ -49,7 +50,7 @@ class SwTable;
 class SwUndoTblMerge;
 class SwCellFrm;
 
-SV_DECL_PTRARR( SwCellFrms, SwCellFrm*, 16 )
+typedef ::std::deque< SwCellFrm* > SwCellFrms;
 
 
 class SwSelBoxes : private std::map
diff --git a/sw/source/core/crsr/trvltbl.cxx b/sw/source/core/crsr/trvltbl.cxx
index cae5aa8..44a2b95 100644
--- a/sw/source/core/crsr/trvltbl.cxx
+++ b/sw/source/core/crsr/trvltbl.cxx
@@ -217,7 +217,7 @@ sal_Bool SwCrsrShell::_SelTblRowOrCol( bool bRow, bool 
bRowSimple )
static_cast(pEndFrm),
aBoxes, bSelectUp ? 0 : &aCells, eType );
 
-if( aBoxes.empty() || ( !bSelectUp && 4 != aCells.Count() ) )
+if( aBoxes.empty() || ( !bSelectUp && 4 != aCells.size() ) )
 return sal_False;
 
 if ( bSelectUp )
diff --git a/sw/source/core/frmedt/fetab.cxx b/sw/source/core/frmedt/fetab.cxx
index 3d3a1ae..9da85cd 100644
--- a/sw/source/core/frmedt/fetab.cxx
+++ b/sw/source/core/frmedt/fetab.cxx
@@ -2345,12 +2345,12 @@ sal_Bool lcl_IsFormulaSelBoxes( const SwTable& rTbl, 
const SwTblBoxFormula& rFml
 for( SwSelBoxes::reverse_iterator it = aBoxes.rbegin(); it != 
aBoxes.rend(); ++it )
 {
 SwTableBox* pBox = it->second;
-sal_uInt16 i;
-for( i = 0; i < rCells.Count(); ++i )
-if( rCells[ i ]->GetTabBox() == pBox )
+SwCellFrms::iterator iC;
+for( iC = rCells.begin(); iC != rCells.end(); ++iC )
+if( (*iC)->GetTabBox() == pBox )
 break;  // found
 
-if( i == rCells.Count() )
+if( iC == rCells.end() )
 return sal_False;
 }
 
@@ -2371,7 +2371,7 @@ sal_Bool SwFEShell::GetAutoSum( String& rFml ) const
 if( ::GetAutoSumSel( *this, aCells ))
 {
 sal_uInt16 nW = 0, nInsPos = 0;
-for( sal_uInt16 n = aCells.Count(); n; )
+for( size_t n = aCells.size(); n; )
 {
 SwCellFrm* pCFrm = aCells[ --n ];
 sal_uInt16 nBoxW = pCFrm->GetTabBox()->IsFormulaOrValueBox();
@@ -2393,7 +2393,7 @@ sal_Bool SwFEShell::GetAutoSum( String& rFml ) const
 {
 nW = RES_BOXATR_VALUE;
 // restore previous spaces!
-for( sal_uInt16 i = aCells.Count(); n+1 < i; )
+for( size_t i = aCells.size(); n+1 < i; )
 {
 String sTmp( String::CreateFromAscii(
 RTL_CONSTASCII_STRINGPARAM( "|<" )) );
@@ -2431,7 +2431,7 @@ sal_Bool SwFEShell::GetAutoSum( String& rFml ) const
 nW = RES_BOXATR_VALUE;
 rFml.Erase( nInsPos );
 // restore previous spaces!
-for( sal_uInt16 i = aCells.Count(); n+1 < i; )
+for( size_t i = aCells.size(); n+1 < i; )
 {
 String sTmp( String::CreateFromAscii(
 RTL_CONSTASCII_STRINGPARAM( "|<" )) );
diff --git a/sw/source/core/frmedt/tblsel.cxx b/sw/source/core/frmedt/tblsel.cxx
index 2a4123e..c6a8b64 100644
--- a/sw/source/core/frmedt/tblsel.cxx
+++ b/sw/source/core/frmedt/tblsel.cxx
@@ -74,9 +74,6 @@
 #undef  DEL_EMPTY_BOXES_AT_START_AND_END
 #define DEL_ALL_EMPTY_BOXES
 
-
-SV_IMPL_PTRARR( SwCellFrms, SwCellFrm* )
-
 struct _CmpLPt
 {
 Point aPos;
@@ -358,7 +355,7 @@ void GetTblSel( const SwLayoutFrm* pStart, const 
SwLayoutFrm* pEnd,
aTopLeft.X() <  aCurrentTopLeft.X() ) )
 {
 aCurrentTopLeft = aTopLeft;
-pCurrentTopLeftFrm = static_cast( pCell

Re: broken chart2_unoapi (was: Tinderbox failure, Linux-RHEL6-x86_64@14-with-check, MASTER, last success: 2012-03-22 05:28:28)

2012-03-25 Thread Noel Grandin
Thanks, I'l work through the patch again and fix the problem.

On Sun, Mar 25, 2012 at 04:46, Markus Mohrhard
 wrote:
> Hey,
>
>>> If somebody into chart and/or calc -- yes Markus, I'm looking at you :) --
>>> could have a look at this failure, that would be highly appreciated.  Noel
>>> said he intends to look into this, too, but would take quite a while and he
>>> wouldn't mind a helping hand; and I would like to see this test go green
>>> again as soon as possible.
>>>
>>
>> Will look at it this afternoon.
>>
>
> Took me a day longer and only fixed by reverting the commits. The
> tinderbox should hopefully become green soon.
>
> Regards,
> Markus
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Base project in GSoC 2012

2012-03-25 Thread Waqas Iftikhar
The IRC channel is dead
Mr. Mutthu the mentor of this project is not replying from his official
email. The IRC channel is dead also.
I am really intrested in this project and i am already doing this stuff in
research center in my university.  I can do it. Please can anybody help me
contacting the mentor is some other way. I need to get in touch with him.

On Fri, Mar 23, 2012 at 11:30 PM, Waqas Iftikhar wrote:

>
> I am writing about the LibreOffice Base project in GSoC 2012. I
> am interested in open source development particularly in all ex-Sun Micro
> systems open source products. I am from Pakistan, currently in my junior
> year of undergraduate studies in computer sciences at FAST-NU Lahore. I
> have extensive experience of working on open source systems at Software
> Engineering Research Centre (SERC) at FAST-NU Lahore under the guidance of
> Dr. Fakhar Lodhi.
>
> At Software Engineering Research Centre in FAST-NU Lahore I have worked
> inside the source code of MySQL. My team and I have worked on the solution
> to various bugs in MySQL namely Bug # 20093, Bug #50675, Bug 54034 and Bug#
> 50507. We have studied the code base of MySQL extensively. Our next project
> due in SERC is embedding MySQL/SQLite as a default in LibreOffice Base
> which happens to be the same thing you want to be implemented in GSoC 2012.
> We have already started scratch work on it (building LibreOffice and SQLite
> and then embedding SQLite under Base).
>
> There are a few queries regarding GSoC 2012. First, my understanding about
> your GSoC requirement is that you want SQLite working as a default in place
> of HSQL database in Base of LibreOffice. The pre requisite written on
> LibreOffice GSoC profile says that you need to solve one of the Easy Hack
> Programming Tasks but one of the easy hack programming task matches up with
> the GSoC 2012 idea of Base. Second, I cannot find out the development
> mailing list for this project. Please clarify these issues to me.
> --
> Regards Waqas
>



-- 
Regards Waqas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


build breaks - icu49 ?

2012-03-25 Thread Andreas Radke
While doing a icu49.1 rebuild I'm running into this build break with
3.5.1:

genbrk: tool completed successfully.
/usr/bin/genbrk -r count_word_fi.txt.p -o count_word_fi.brk
LD_LIBRARY_PATH="/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/lib" 
/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/bin/gencoll_rule 
/build/src/libreoffice-core-3.5.1.2/i18npool/source/collator/data/zh_stroke.txt 
collator_zh_stroke_invis.cxx zh_stroke
genbrk: tool completed successfully.
sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' indexdata_ko_dict_invis.cxx > 
indexdata_ko_dict.cxx
/usr/bin/genbrk -r dict_word_he.txt.p -o dict_word_he.brk
/usr/bin/genbrk -r char.txt.p -o char.brk
sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' zh_zhuyin_invis.cxx > zh_zhuyin.cxx
createRuleBasedBreakIterator: ICU Error "U_BRK_RULE_EMPTY_SET"  at line 19, 
column 16
make[3]: *** [char.brk] Error 11
make[3]: *** Waiting for unfinished jobs

Do we have a fix for this?

-Andy
ArchLinux
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: regression in charts introduced by one of the recent table to std::map commits

2012-03-25 Thread Ivan Timofeev

Hi!


This will immediately crash in chart2uno with a null pointer dereference.


Looking at
http://cgit.freedesktop.org/libreoffice/core/commit/?id=db3786ee3aa0d8911042c9bbcea02cf36d96dfa1
I noticed that at least ScTokenPtrMap can contain "key -> 0" pairs:

  for ( ChartTokenMap::const_iterator it2 = pCols->begin(); it2 != 
pCols->end(); ++it2 )

  {
  ScTokenPtrMap* pCol = it2->second;
  (*pCol)[nKey] = NULL;
  }

but the following change omits the "pToken != 0" condition:


- ScToken* pToken = static_cast(pCol->First());
+ ScTokenPtrMap* pCol = aColIter->second;
+ ScTokenPtrMap::iterator tokenIter = pCol->begin();
  for (SCROW nRow = 0; !bFoundValues && nRow < nSmallestValueRowIndex; ++nRow)
  {
- if (pToken && nRow>=nHeaderRowCount)
+ if (tokenIter != pCol->end() && nRow>=nHeaderRowCount)
  {
+ ScToken* pToken = tokenIter->second;



Also, this change looks *very* suspiciously:


- pCol = static_cast(pCols->First());
- if (pCol)
+ if ( !pCols->empty() )
  {
+ nAllRowCount = static_cast(pCols->begin()->second->size());
  if (mbDummyUpperLeft)
- pCol->Insert(0, NULL); // Dummy fuer Beschriftung
- nAllRowCount = static_cast(pCol->Count());
+ (*pCols)[ 0 ] = NULL; // Dummy fuer Beschriftung
  }


Maybe someone will find more slips. Oh, those tricky conversions...

HTH,
Ivan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice