Re: [Libreoffice-qa] new automated test concept for chart2

[Rainer Bielefeld]

Markus Mohrhard schrieb:

Hey,

finally I was able to finish my work on a chart2 test concept.


Hi,

Great! Unfortunately I'm too busy to help to find and create test charts.

May be some volunteers find the time to review listed test documents and 
to rework them for Markus' needs?


Here [1] is a query showing Chart bugs with .ods attachment, I believe 
most of these attachments will contain a chart.


[2] only shows a similar query listing only Bugs what have not already 
been reviewed.


I added some hints in Bug 47667

Best regards

Rainer



Hyperlinks
[1] 



[2] 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ANN] LibreOffice 3.5.2 RC2 test builds available

[Pedro]

ape wrote
> 
> *Attention! A blocking error Writer (LibreOffice 3.5.2.2; build_ID
> 281b639-6baa1d3-ef66a77-d866f25-f36d45f; Windows_OS):
>  "File" menu, point "Save as": format FlatXML (*. fodt) is not in the list
> of available formats.*
> 

This is not really a Development question. It would have been more
appropriate in the Users or Discuss mailing list ;)

FlatXML is not installed by default, was it ever?

You can go to Control Panel, Add/Remove Programs, select Libreoffice and
then Change your install options, go to Optional Components and select
Previous Filters (or similar wording). This will add FlatXML to the Save
options.

--
View this message in context: 
http://nabble.documentfoundation.org/ANN-LibreOffice-3-5-2-RC2-test-builds-available-tp3865776p3866786.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Small "use of english" mistake on the site

[Pantelis Koukousoulas]

Hi,

I just visited http://www.libreoffice.org/features/templates/
and I saw

Templates can be used for you text documents (Writer), spreadsheets (Calc)
and presentations (Impress), and you'll find

very many of them  --->  several of them?
^^

downloadable from LibreOffice's own repository, and from other sources
on the Internet, too.

Please consider correcting (I hope this is the correct ML for this
type of problems.)

Cheers,
Pantelis
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ANN] LibreOffice 3.5.2 RC2 test builds available

[ape]

*Attention! A blocking error Writer (LibreOffice 3.5.2.2; build_ID
281b639-6baa1d3-ef66a77-d866f25-f36d45f; Windows_OS):
 "File" menu, point "Save as": format FlatXML (*. fodt) is not in the list
of available formats.*

--
View this message in context: 
http://nabble.documentfoundation.org/ANN-LibreOffice-3-5-2-RC2-test-builds-available-tp3865776p3866620.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: initializing extensions in daily from Master slooow

[Norbert Thiebaud]

On Wed, Mar 28, 2012 at 8:24 AM, Michael Meeks  wrote:
>
> On Wed, 2012-03-28 at 10:04 +0200, Cor Nouws wrote:
>> Indeed ;-) See issue fdo#47983
>
>        Which comes down to combination of problems:
>
>        * of not easily being able to push more information into the
>          file ucb to be able to flag that we want to call osl_syncFile
>          at just-this-one-place (saving a document), due to some
>          "shove arguments into a struct into an any" design - or
>          perhaps I'm missing something.
>
>        * the desktop/ migration code heavily using UCB.
>
>        * the desktop/ migration code being write-happy, and
>          re-writing the same couple of files 40 times or so
>          each ;-) [ and this is before the berkely database
>          cruft ]
>
>        So - unclear how to deal with that really. A very quick, very ugly hack
> would be to stop the file ucp doing it's (new) sync if the path is
> in /tmp or in your configuration ( I suppose ). Not at all beautiful,
> but functional.

or you could actually call sync() directly from the save() method once
your done with your writing (*),
that push up some implementation details... but that still would be a
less ugly than the hack above

Norbert

(*) I'm assuming here that this sync really matter only when saving
'documents'... and that we could live without it for other write...
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Post download check fail in oowintool line 290

[Regina Henschel]

Addition: If I create the folder 'C:\Program Files\Common Files\Merge 
Modules' and put the files into it, then post download check will find 
the files and use them for copying.


Kind regards
Regina

Regina Henschel schrieb:

Hi all,

after getting configure to work, I run
/opt/lo/bin/make fetch
It got a lot of files, but post download checks failed with error
Copying /cygdrive/C/Program Files/Common Files/Merge
Modules/Microsoft_VC90_CRT_x86.msm to ./external/msm90
copy failed: No such file or directory at ./oowintool line 290.
post_download: error: oowintool failed to copy merge modules

I have a German XP and there is not such folder 'Program Files/Common
Files/Merge Modules/' but I have got a folder 'C:\Programme\Gemeinsame
Dateien\Merge Modules' and there I see the file Microsoft_VC90_CRT_x86.msm

But why does it try to copy the files at all? I had put them already
into external/msm90 as README_msm90.txt in that folder tells me to do.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About fdo#47865, Crash on Writer when a footnote is inserted

[julien2412]

Updated master sources today and didn't reproduce the problem.
Thank you Caolán !

Julien
(just wonder why this problem wasn't reproduced on every machine, but the
important thing is that's solved now :-))

--
View this message in context: 
http://nabble.documentfoundation.org/About-fdo-47865-Crash-on-Writer-when-a-footnote-is-inserted-tp3862714p3865961.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Post download check fail in oowintool line 290

[Regina Henschel]

Hi all,

after getting configure to work, I run
/opt/lo/bin/make fetch
It got a lot of files, but post download checks failed with error
Copying /cygdrive/C/Program Files/Common Files/Merge 
Modules/Microsoft_VC90_CRT_x86.msm to ./external/msm90

copy failed: No such file or directory at ./oowintool line 290.
post_download: error: oowintool failed to copy merge modules

I have a German XP and there is not such folder 'Program Files/Common 
Files/Merge Modules/' but I have got a folder 'C:\Programme\Gemeinsame 
Dateien\Merge Modules' and there I see the file Microsoft_VC90_CRT_x86.msm


But why does it try to copy the files at all? I had put them already 
into external/msm90 as README_msm90.txt in that folder tells me to do.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] remove unused code (oox, sc)

[Petr Vorel]

> FWIW, if a class has only one constructor and that constructor is unused
> then it indicates that the whole class (except perhaps for any static
> methods it might have) should be possible to be removed.
Sorry, I'll think more next time.
Petr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Windows SDK is not found

[Regina Henschel]

Hi Fridrich,

Fridrich Strba schrieb:

Hello, Regina,

I would suggest as the best option is to install Windows SDK 7.1 that
installs even on Windows XP boxes and register it as a default SDK with
the Visual Studio.

This is what I use here and life is wonderful.


Does it work with the Express version too, here MSVC Express 2008? 
Trying to register Windows SDK 6.1 failed here.


Kind regards
Regina



Cheers

Fridrich

On 27/03/12 13:24, Regina Henschel wrote:

Hi all,

Lubos Lunak schrieb:

On Monday 26 of March 2012, Kohei Yoshida wrote:

On Mon, Mar 26, 2012 at 5:14 PM, Regina Henschel

   wrote:

I have tried also with
--with-windows-sdk-home="/cygdrive/c/Programme/Microsoft
SDKs/Windows/v6.0A"


I believe that configure option has been renamed to
--with-dotnet-framework-home.  E.g. I have

  --with-dotnet-framework-home="/cygdrive/c/Program Files/Microsoft
SDKs/Windows/v7.0A"

in my configure option.


No, that does not solve the problem, neither with
--with-dotnet-framework-home alone nor in combination with
--with-windows-sdk-home


Hmm..  Anyone else have any ideas?


   I think one thing that has changed relatively recently is that the
SDK must
be registered as default with Visual Studio (in the menu: Microsoft
Windows
SDK 7.1 ->   Visual Studio Registration ->   Windows SDK Configuration
Tool).

   You can also have a look at configure.in to see what the check
actually looks
for.



I have examined configure.in and found this:
The automatic detection results in
$WINDOWS_SDK_HOME = /cygdrive/c/Programme/Microsoft SDKs/Windows/v6.0A
There configure is looking for the files
$WINDOWS_SDK_HOME/bin/msiinfo.exe
$WINDOWS_SDK_HOME/bin/msidb.exe
$WINDOWS_SDK_HOME/bin/msitran.exe
$WINDOWS_SDK_HOME/bin/uuidgen.exe

And indeed these files are not there. But I have found these files in
C:\Programme\Microsoft Platform SDK for Windows Server 2003 R2\Bin
and in
C:\Programme\Microsoft SDKs\Windows\v6.1\Bin

So which are the correct ones to use?

Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code (connectivity)

[Santiago Martinez]

This patch removes unused code as listed in unusedcode.easy


0001-Remove-unused-code-in-connectiviy.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ANN] LibreOffice 3.5.2 RC2 test builds available

[Fridrich Strba]

Hi *,

for the upcoming new version 3.5.2, the RC2 builds now start to be
available on pre-releases. This build is slated to be second release
candidate build on the way towards 3.5.2, please refer to our release
plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try & report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to 3.5.2 RC1 is here:


http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-2-release-3.5.2.2.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

Fridrich
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code in sqlnode

[Santiago Martinez]

This patch removes unused code as listed in unusedcode.easy
From 75344c3cb19be787fce45bd06ad93a971e0b5292 Mon Sep 17 00:00:00 2001
From: Santiago Martinez 
Date: Wed, 28 Mar 2012 21:28:07 +0200
Subject: [PATCH] Remove unused code in sqlnode

---
 connectivity/inc/connectivity/sqlnode.hxx |2 -
 connectivity/source/parse/sqlnode.cxx |   41 -
 unusedcode.easy   |3 --
 3 files changed, 0 insertions(+), 46 deletions(-)

diff --git a/connectivity/inc/connectivity/sqlnode.hxx b/connectivity/inc/connectivity/sqlnode.hxx
index 4f8385a..8874ed0 100644
--- a/connectivity/inc/connectivity/sqlnode.hxx
+++ b/connectivity/inc/connectivity/sqlnode.hxx
@@ -278,11 +278,9 @@ namespace connectivity
 void append(OSQLParseNode* pNewSubTree);
 void insert(sal_uInt32 nPos, OSQLParseNode* pNewSubTree);
 
-OSQLParseNode* replaceAt(sal_uInt32 nPos, OSQLParseNode* pNewSubTree);
 OSQLParseNode* replace(OSQLParseNode* pOldSubTree, OSQLParseNode* pNewSubTree);
 
 OSQLParseNode* removeAt(sal_uInt32 nPos);
-OSQLParseNode* remove(OSQLParseNode* pSubTree);
 
 void replaceNodeValue(const ::rtl::OUString& rTableAlias,const ::rtl::OUString& rColumnName);
 
diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx
index 7b4e4dd..5341a26 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -2386,45 +2386,9 @@ OSQLParseNode* OSQLParseNode::removeAt(sal_uInt32 nPos)
 m_aChildren.erase(aPos);
 return pNode;
 }
-//-
-OSQLParseNode* OSQLParseNode::remove(OSQLParseNode* pSubTree)
-{
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "parse", "ocke.jans...@sun.com", "OSQLParseNode::remove" );
-OSL_ENSURE(pSubTree != NULL, "OSQLParseNode: invalid SubTree");
-OSQLParseNodes::iterator aPos = ::std::find(m_aChildren.begin(), m_aChildren.end(), pSubTree);
-if (aPos != m_aChildren.end())
-{
-// Set the getParent of the removed node to NULL
-pSubTree->setParent( NULL );
-m_aChildren.erase(aPos);
-return pSubTree;
-}
-else
-return NULL;
-}
 
 // Replace methods
 //-
-OSQLParseNode* OSQLParseNode::replaceAt(sal_uInt32 nPos, OSQLParseNode* pNewSubNode)
-{
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "parse", "ocke.jans...@sun.com", "OSQLParseNode::replaceAt" );
-OSL_ENSURE(pNewSubNode != NULL, "OSQLParseNode: invalid nodes");
-OSL_ENSURE(pNewSubNode->getParent() == NULL, "OSQLParseNode: node already has getParent");
-OSL_ENSURE(nPos < m_aChildren.size(), "OSQLParseNode: invalid position");
-OSL_ENSURE(::std::find(m_aChildren.begin(), m_aChildren.end(), pNewSubNode) == m_aChildren.end(),
-"OSQLParseNode::Replace() Node already element of parent");
-
-OSQLParseNode* pOldSubNode = m_aChildren[nPos];
-
-// Create connection to getParent
-pNewSubNode->setParent( this );
-pOldSubNode->setParent( NULL );
-
-m_aChildren[nPos] = pNewSubNode;
-return pOldSubNode;
-}
-
-//-
 OSQLParseNode* OSQLParseNode::replace (OSQLParseNode* pOldSubNode, OSQLParseNode* pNewSubNode )
 {
 RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "parse", "ocke.jans...@sun.com", "OSQLParseNode::replace " );
@@ -2791,11 +2755,6 @@ void OSQLParseNodesContainer::erase(OSQLParseNode* _pNode)
 }
 }
 // -
-bool OSQLParseNodesContainer::empty() const
-{
-return m_aNodes.empty();
-}
-// -
 void OSQLParseNodesContainer::clear()
 {
 ::osl::MutexGuard aGuard(m_aMutex);
diff --git a/unusedcode.easy b/unusedcode.easy
index 61a0856..f791255 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -772,9 +772,6 @@ comphelper::findProperty(com::sun::star::beans::Property&, com::sun::star::uno::
 connectivity::OKeyValue::OKeyValue()
 connectivity::ORowSetValue::setFromDouble(double const&, int)
 connectivity::OSQLInternalNode::OSQLInternalNode(unsigned short const*, connectivity::SQLNodeType, unsigned int)
-connectivity::OSQLParseNode::remove(connectivity::OSQLParseNode*)
-connectivity::OSQLParseNode::replaceAt(unsigned int, connectivity::OSQLParseNode*)
-connectivity::OSQLParseNodesContainer::empty() const
 connectivity::OSQLScanner::GetCurrentRule() const
 connectivity::OSortIndex::GetValue(int) const
 connectivity::SQLError::getSQLState(int) const
-- 
1.7.7.6

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Another Dalvik oddity: "bogus byte value: 128" while processing DNDConstants.class

[Tor Lillqvist]

> doesn't
> valueindex = classFile->addIntegerInfo((sal_Int8)fieldValue.m_mvalue.aByte))
> enough ?

That's what I tried first, and for some reason it didn't.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] [PATCH]document idl queryContentCells limitation

[Kohei Yoshida]

On Wed, 2012-03-28 at 17:16 +0200, Laurent Godard wrote:
> Hi all
> 
> a small patch that documents queryContentCells limitation in IDL reference
> 
> thanks to Kohei for explaining me the reason of it ;)

Thanks Laurent.  Pushed to master.

I've changed the wording a bit in my follow-up commit.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Another Dalvik oddity: "bogus byte value: 128" while processing DNDConstants.class

[Norbert Thiebaud]

On Wed, Mar 28, 2012 at 8:12 AM, Tor Lillqvist  wrote:
> The patch below seems to help. OK to commit? I'm looking at you, Stephan;)
>
> --tml
>
> diff --git a/codemaker/source/javamaker/javatype.cxx
> b/codemaker/source/javamaker/javatype.cxx
> index 1453122..f297980 100644
> --- a/codemaker/source/javamaker/javatype.cxx
> +++ b/codemaker/source/javamaker/javatype.cxx
> @@ -2447,7 +2447,10 @@ void addConstant(
>                 rtl::OString(
>                     RTL_CONSTASCII_STRINGPARAM("Bad type
> information"))); //TODO
>         }
> -        valueIndex = classFile->addIntegerInfo(fieldValue.m_value.aByte);
> +        if (fieldValue.m_value.aByte < 0x80)

^^^
doesn't
valueindex = classFile->addIntegerInfo((sal_Int8)fieldValue.m_mvalue.aByte))
enough ?

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] convert tools/table.hxx usage in to std::map in ScChartPosition class in SC module

[Ivan Timofeev]

Hi Noel,

pushed after all (phew!) :) Added some corrections in the subsequent 
commits - see the git log.


But I wonder why in the following code... (chartpos.cxx:548)

RowMap::const_iterator pPosIter = pCol2->begin();
if ( pPosIter != pCol2->end() )
{
if ( nRowAdd )
{
ppColHeader[ nCol ] = pPosIter->second; // 
eigenstaendig

++pPosIter;
}
else
ppColHeader[ nCol ] = pPosIter->second ?
new ScAddress( *pPosIter->second ) : NULL;
}

...pPosIter is not incremented in the else branch. I know - that logic 
was here before the conversion to std::map. But it looks weird...


Anyway, thank you for this work!

Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Experiemental interactive formula editing ...

[Michael Meeks]

On Tue, 2012-03-27 at 17:45 +0400, Ivan Timofeev wrote:
> On 27.03.2012 17:40, Ivan Timofeev wrote:
> > 3. Impossible to write statements like 'cos x' without adding a space
> > between 'cos' and 'x'.
> 
> Sorry, I mean this statement becomes 'cos ~ x' - additional space is added.

Hah - and Regina had a few issues too she shared. It looks to me as if
we need some noble volunteer to collect that little lot in bugzilla
under a tracker bug, and (preferably) Easy-hack-ise it.

:-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Libreoffice] named formatting attributs overwrite automatic formatting attributs (paragraph / character)

[Maxime de Roucy]

Hello,

I am wondering, when I apply an automatic character formatting attribut
on a portion of text (not a whole paragraph) and then apply a named
character formatting attribut on the same portion of text, the attribut
are merged.

When I apply an automatic character formatting attribut to a paragraph
and the apply a named paragraph formatting attribut on the same
paragraph, the named attribut overwrite the automatic one.

For my part I think this should be fixed, I mean that both paragraph and
character attributs should have the same behavior (overwriting or
merging).

What do you think ?
- am I wrong ? (Not my choice…)
- Should the named paragraph formatting attribut be merge with the
automatic one ? (My first choice)
- Should the named character formatting attribut overwrite the automatic
one ? (My second choice)

Regards

Maxime de Roucy

PS : I think I already ask but nobody answers, furthermore I don't find
my previous mail

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0 810 251 251




signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] modify default behaviour of the format paintbrush

[Maxime de Roucy]

Hello,

I am writing this mail trying to prevent this thread from dying…

So, what do you think about changing the default behavior of the format
paintbrush ?

Regards

Maxime de Roucy

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0 810 251 251


Le lundi 19 mars 2012 à 12:15 +0100, Maxime de Roucy a écrit :
> Hello,
> 
> > Is this change based on the idea, that people who use the paintbrush are 
> > not that much looking at styles, and thus that copying those styles 
> > might do more harm then good for them?
> I was showing a modification I made to the format paintbrush in a
> preview patch to a co-worker who work with LO but don't know it that
> much. And he was very surprised that the tool change the format of the
> whole paragraph.
> 
> For him, by default the format paintbrush should just change the
> selected characters (whether using named or auto-style format).
> 
> That's why I thought of changing the default behaviour.
> 
> Currently :
> By default it past the characters and paragraphs formatting ;
> if Ctrl is hold, it only past the character formatting ;
> if Ctrl and Shift are hold, it only past the paragraph formatting.
> 
> With the patch :
> By default it only past the characters formatting ;
> if Ctrl is hold, it past the characters and paragraphs formatting ;
> if Ctrl and Shift are hold, it only past the paragraph formatting.
> 
> Regards
> 
> ___
> Libreoffice-ux-advise mailing list
> libreoffice-ux-adv...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH]document idl queryContentCells limitation

[Laurent Godard]

Hi all

a small patch that documents queryContentCells limitation in IDL reference

thanks to Kohei for explaining me the reason of it ;)

HTH

Laurent
>From 851baad2b8ea7c598a6e377eba28367d97b1a6c7 Mon Sep 17 00:00:00 2001
From: Laurent Godard 
Date: Wed, 28 Mar 2012 17:00:53 +0200
Subject: [PATCH] document queryContentCells limitation

add also a missing  in previous paragraph
---
 offapi/com/sun/star/sheet/XCellRangesQuery.idl |7 ++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/offapi/com/sun/star/sheet/XCellRangesQuery.idl b/offapi/com/sun/star/sheet/XCellRangesQuery.idl
index f35eec7..a44cc70 100644
--- a/offapi/com/sun/star/sheet/XCellRangesQuery.idl
+++ b/offapi/com/sun/star/sheet/XCellRangesQuery.idl
@@ -76,7 +76,12 @@ published interface XCellRangesQuery: com::sun::star::uno::XInterface
 
 Attention: Despite the CellFlags flags are
 long values, this method expects a short
-parameter.
+parameter.
+
+Attention: Empty cells in the range are not analyzed.Some
+CellFlags may not be fully honored. For instance,
+when querying for STYLES, the returned ranges may not include empty
+cells with styles applied.
 
 @returns
 all cells of the current cell range(s) with the specified
-- 
1.7.9.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] [REVIEW:3-5] fdo#47937 UI locks read-only when partial write privilege

[Caolán McNamara]

On Tue, 2012-03-27 at 11:03 +0200, Lionel Elie Mamane wrote:
> Attached patch fixes fdo#47937

pushed to 3-5 now, mostly on the basis that I trust you rather than
cause I know what's going on there :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] remove unused code (oox, sc)

[Caolán McNamara]

On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote:
> Hi there,
> 
> yet another remove unused code patch.

Pushed now, thanks for this.

FWIW, if a class has only one constructor and that constructor is unused
then it indicates that the whole class (except perhaps for any static
methods it might have) should be possible to be removed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] remove unused code (oox, sc)

[Petr Vorel]

Hi there,

yet another remove unused code patch.

Regards,
Petr
>From 38a7f343736f7049d28aae132307eba02a019f27 Mon Sep 17 00:00:00 2001
From: Petr Vorel 
Date: Wed, 28 Mar 2012 11:20:18 +0200
Subject: [PATCH] remove unused code (oox, sc)

---
 oox/inc/oox/drawingml/textparagraphproperties.hxx |4 -
 oox/inc/oox/dump/dffdumper.hxx|2 -
 oox/inc/oox/dump/dumperbase.hxx   |   13 
 oox/source/drawingml/textparagraphproperties.cxx  |   25 
 oox/source/dump/dffdumper.cxx |   11 
 oox/source/dump/dumperbase.cxx|   65 -
 sd/source/filter/eppt/epptooxml.hxx   |1 -
 sd/source/filter/eppt/pptx-epptooxml.cxx  |   14 -
 unusedcode.easy   |   14 -
 9 files changed, 0 insertions(+), 149 deletions(-)

diff --git a/oox/inc/oox/drawingml/textparagraphproperties.hxx b/oox/inc/oox/drawingml/textparagraphproperties.hxx
index b2c5096..e037ff2 100644
--- a/oox/inc/oox/drawingml/textparagraphproperties.hxx
+++ b/oox/inc/oox/drawingml/textparagraphproperties.hxx
@@ -114,10 +114,6 @@ public:
 size can be zero and the default value is returned. */
 float   getCharHeightPoints( float fDefault ) const;
 
-#if OSL_DEBUG_LEVEL > 0
-void dump() const;
-#endif
-
 protected:
 
 TextCharacterProperties maTextCharacterProperties;
diff --git a/oox/inc/oox/dump/dffdumper.hxx b/oox/inc/oox/dump/dffdumper.hxx
index a23d071..10f84f3 100644
--- a/oox/inc/oox/dump/dffdumper.hxx
+++ b/oox/inc/oox/dump/dffdumper.hxx
@@ -49,7 +49,6 @@ protected:
 inline explicit DffStreamObject() {}
 
 using   SequenceRecordObjectBase::construct;
-voidconstruct( const ObjectBase& rParent, const BinaryInputStreamRef& rxStrm, const ::rtl::OUString& rSysFileName );
 voidconstruct( const OutputObjectBase& rParent, const BinaryInputStreamRef& rxStrm );
 
 virtual boolimplReadRecordHeader( BinaryInputStream& rBaseStrm, sal_Int64& ornRecId, sal_Int64& ornRecSize );
@@ -61,7 +60,6 @@ private:
 voidconstructDffObj();
 
 sal_uInt32  dumpDffSimpleColor( const String& rName );
-sal_uInt32  dumpDffColor( const String& rName );
 
 voiddumpDffOpt();
 sal_uInt16  dumpDffOptPropHeader();
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index 5989c1e..68a4848 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -480,26 +480,18 @@ static const String EMPTY_STRING;
 class FormulaStack
 {
 public:
-explicitFormulaStack();
-
 inline const ::rtl::OUString& getFormulaString() const { return getString( maFmlaStack ); }
 inline const ::rtl::OUString& getClassesString() const { return getString( maClassStack ); }
 
 voidpushOperand( const String& rOp, const ::rtl::OUString& rTokClass );
-voidpushOperand( const String& rOp );
-voidpushUnaryOp( const String& rLOp, const String& rROp );
-voidpushBinaryOp( const String& rOp );
-voidpushFuncOp( const String& rFunc, const ::rtl::OUString& rTokClass, sal_uInt8 nParamCount );
 
 inline void setError() { mbError = true; }
-voidreplaceOnTop( const ::rtl::OUString& rOld, const ::rtl::OUString& rNew );
 
 private:
 typedef ::std::stack< ::rtl::OUString > StringStack;
 
 inline bool check( bool bCond ) { return (mbError |= !bCond) == false; }
 
-const ::rtl::OUString& getString( const StringStack& rStack ) const;
 voidpushUnaryOp( StringStack& rStack, const ::rtl::OUString& rLOp, const ::rtl::OUString& rROp );
 voidpushBinaryOp( StringStack& rStack, const ::rtl::OUString& rOp );
 voidpushFuncOp( StringStack& rStack, const ::rtl::OUString& rOp, sal_uInt8 nParamCount );
@@ -612,9 +604,6 @@ private:
 ::rtl::OUString& orKey,
 ::rtl::OUString& orData ) const;
 
-LineTypereadConfigLine(
-TextInputStream& rStrm ) const;
-
 voidprocessConfigItem(
 TextInputStream& rStrm,
 const ::rtl::OUString& rKey,
@@ -1013,7 +1002,6 @@ public:
 template< typename Type >
 boolhasName( const NameListWrapper& rListWrp, Type nKey ) const;
 
-::com::sun::star::uno::Sequence< ::com::sun::star::beans::NamedValue > requestEncryptionData( ::comphelper::IDocPasswordVerifier& rVerifier );
 boolisPasswordCancelled() const;
 
 protected:
@@ -1598,7 +1586,6 @@ protected:
 inline void dumpUnused( sal_Int32 nBytes ) { dumpArray( OOX_DUMP_UNUSED, nBytes ); }
 inline void dumpU

Re: Experiemental interactive formula editing ...

[Jean-Baptiste Faure]

Hi,

Le 27/03/2012 19:08, Regina Henschel a écrit :
> Michael Meeks schrieb:
>> Hi guys,
>>
>> I wondered - are there any serious known issues in this anymore ?
>> and/or is there any reason why it's left as an experimental feature ?

I can't say better than Regina.
From my point of view, an option to choose the editor mode is the best
thing to do.

Best regards.
JBF

> 
> I know that users coming from Word MathType will like it. But I do not
> want to use it and need an option to disable it, when it leaves
> "experimental mode".
> 
> Main reason for me: It does not preserve the StarMath notation.
> 
> In more detail:
> The feature works directly on the MathML code. But that does not know
> all StarMath markup. For example "sum from {i=1} to n {n_i cdot 2^i}" or
> "1 over 22 = nospace{0,0 overline {45}}"
> 
> If you use the new feature, then the formulas are changed. Try it,
> change for example "2" to "3". Without that feature the StarMath markup
> is preserved as annotation inside the MathML code and restored when
> loading.
> 
> If the new feature is enabled, then those working with the command
> window like me loose the ability to mark a part of the formula by
> double-click on it in the rendering. And that is needed for easily
> changing single figures or variables in a complex formula.
> 
> Therefore I want to be able to still use the old kind editing.
> 
> Kind regards
> Regina
> 
>>
>> --- a/starmath/source/view.cxx
>> +++ b/starmath/source/view.cxx
>> @@ -2134,7 +2134,7 @@ void SmViewShell::Notify( SfxBroadcaster&  ,
>> const SfxHint&  rHint )
>>
>>   bool SmViewShell::IsInlineEditEnabled() const
>>   {
>> -return pImpl->aOpts.IsExperimentalMode();
>> +return true;
>>   }
>>
>>   /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
>>
>>
>> Having had Jonas do all the work, it seems a shame not to ship it -
>> right ? :-) Olivier - do you have a view ?
>>
>> All the best,
>>
>> Michael.
>>
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 


-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

where our memory footprint comes from

[Caolán McNamara]

So, if you now run office under valgrind, i.e.

export VALGRIND=memcheck
./swriter

then if you kill -SIGUSR2 pid we get memcheck to dump out the backtraces
of active allocations, so can see where what memory we're using comes
from.

a) should add leak-check=full --show-reachable=yes to the valgrind line
in soffice to get full data, should probably add another option/env to
do that automatically for you)

b) only works if you've got a memcheck.h header that was auto-detected
during configure

My last-trace is available from
http://people.redhat.com/caolanm/trace/memcheck.active.allocs.log
that's just from an empty writer document

Two main things in there strike me. 
a) configuration data seems to occupy a lot of space
b) there are a lot of __static_initialization_and_destruction entries
where we over-use static rtl::OString or static rtl::OUString's which
all have to be initialized when their .so's are loaded and the
destructors for those registered to be called when they are unloaded.
Way too much churn noise for a few occasionally used strings.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About fdo#47865, Crash on Writer when a footnote is inserted

[Caolán McNamara]

On Tue, 2012-03-27 at 13:39 -0700, julien2412 wrote:
> Hello,
> 
> Am i the only one to have the problem described there
> :https://bugs.freedesktop.org/show_bug.cgi?id=47865  
> I still reproduce it with master updated today, last commit : 
> 1e91520e7af29c390c03d05b39992da5aaf6d1c7.

I fixed that last night I think.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: new automated test concept for chart2

[Markus Mohrhard]

Hey Cor,

> Writing to the Dutch Discuss list for people that do some things with
> charts...
> From the text below,is it correct that I can tell them to just make some
> simple example files, which preferably clearly shows one issue, and add them
> to the issue ?
>

Yes, but I would prefer test documents that focus on one single
feature and include one or more charts that focus on one single
feature. I don't think that it is useful to include a big set of
similar test document because this test is already a bit slower.

So if we get some nicely written test documents that would be awesome.

> Markus Mohrhard wrote (28-03-12 05:30)
>
>> All you need to
>> create a new test case is a bit of time.
>> For everyone interested in writing and extending chart tests please
>> have a look at: https://bugs.freedesktop.org/show_bug.cgi?id=47667
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: new automated test concept for chart2

[Eike Rathke]

Hi Markus,

On Wednesday, 2012-03-28 05:30:37 +0200, Markus Mohrhard wrote:

> For everyone interested in writing and extending chart tests please
> have a look at: https://bugs.freedesktop.org/show_bug.cgi?id=47667

Awesome!

> The test is not yet activated but is working already. So if you want
> to play a bit with it just add it into Module_sc.mk. Feedback as
> always highly appreciated. If there are no objections I plan to
> activate the test in sc's subsequentcheck target at the end of the
> week.

I'll have no time to play with it, I'm on leave Thursday/Friday, but
I trust your work :)

> P.S. For calc devs I will add a hidden export filter that exports the
> same content to make debugging chart bugs easier.

Cool. You rock! :-)

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgptuJeMpSIZT.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: initializing extensions in daily from Master slooow

[Michael Meeks]

On Wed, 2012-03-28 at 10:04 +0200, Cor Nouws wrote:
> Indeed ;-) See issue fdo#47983

Which comes down to combination of problems:

* of not easily being able to push more information into the
  file ucb to be able to flag that we want to call osl_syncFile
  at just-this-one-place (saving a document), due to some
  "shove arguments into a struct into an any" design - or
  perhaps I'm missing something.

* the desktop/ migration code heavily using UCB.

* the desktop/ migration code being write-happy, and
  re-writing the same couple of files 40 times or so
  each ;-) [ and this is before the berkely database
  cruft ]

So - unclear how to deal with that really. A very quick, very ugly hack
would be to stop the file ucp doing it's (new) sync if the path is
in /tmp or in your configuration ( I suppose ). Not at all beautiful,
but functional.

Failing that, we could re-open the file, purely in order to 'fsync' it
(conceptually yucky too) in SfxMedium::TransactedTrasferForFS_Impl and
pull the fsync out of the UCB's write (where it belongs). Or - we could
do something nastier ;-)

Thoughts Stephan ?

Hmm,

Michael. 

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Another Dalvik oddity: "bogus byte value: 128" while processing DNDConstants.class

[Tor Lillqvist]

The patch below seems to help. OK to commit? I'm looking at you, Stephan;)

--tml

diff --git a/codemaker/source/javamaker/javatype.cxx
b/codemaker/source/javamaker/javatype.cxx
index 1453122..f297980 100644
--- a/codemaker/source/javamaker/javatype.cxx
+++ b/codemaker/source/javamaker/javatype.cxx
@@ -2447,7 +2447,10 @@ void addConstant(
 rtl::OString(
 RTL_CONSTASCII_STRINGPARAM("Bad type
information"))); //TODO
 }
-valueIndex = classFile->addIntegerInfo(fieldValue.m_value.aByte);
+if (fieldValue.m_value.aByte < 0x80)
+valueIndex = classFile->addIntegerInfo(fieldValue.m_value.aByte);
+else
+valueIndex = classFile->addIntegerInfo(-256 + (int)
fieldValue.m_value.aByte);
 break;

 case codemaker::UnoType::SORT_SHORT:
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Translate German comments in frmcrsr.cxx

[Philipp Weissenbacher]

Hi all,
Kindly asking for a review of my translation of frmcrsr.cxx.

Thanks in advance and cheers,
Philipp


0001-Translate-German-comments-fix-some-English-ones.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Another Dalvik oddity: "bogus byte value: 128" while processing DNDConstants.class

[Tor Lillqvist]

If I add the unoil.jar file to the set of jars to be included in an
Android app, I get this error message when the app build process is
converting the Java bytecode into Dalvik executable (.dex) format:

   [dx] UNEXPECTED TOP-LEVEL EXCEPTION:
   [dx] com.android.dx.util.ExceptionWithContext: bogus byte value: 128
   [dx] at
com.android.dx.util.ExceptionWithContext.withContext(ExceptionWithContext.java:46)
   [dx] at
com.android.dx.dex.cf.CfTranslator.processFields(CfTranslator.java:176)
[...]
   [dx] Caused by: java.lang.IllegalArgumentException: bogus byte value: 128
   [dx] at com.android.dx.rop.cst.CstByte.make(CstByte.java:52)
   [dx] at
com.android.dx.dex.cf.CfTranslator.coerceConstant(CfTranslator.java:201)
   [dx] at
com.android.dx.dex.cf.CfTranslator.processFields(CfTranslator.java:160)
   [dx] ... 14 more
   [dx] ...while processing ACTION_DEFAULT B
   [dx] ...while processing com/sun/star/datatransfer/dnd/DNDConstants.class

Looking in offapi/com/sun/star/datatransfer/dnd/DNDConstants.idl , I see:

const byte ACTION_DEFAULT = 0x80;

Now, "byte" is a *signed* one-byte integer in Java. My trusty old
"Java in a Nutshell (4th Ed.)" claims that its legal values are -128
to 127. So should this ACTION_DEFAULT be defined as -128 instead?
Should javamaker, or whatsitcalled, be modified?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Disabling Temporary Files?

[Marc-André Laverdière]

My colleagues found out that the temp file is password-protected too,
so that part is fine.
But images inside the file are saved as temporary files too! Is there
something we can do about that?

Marc-André LAVERDIÈRE
"Perseverance must finish its work so that you may be mature and complete,
not lacking anything." -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com




2012/3/2 Michael Meeks :
>
> On Fri, 2012-03-02 at 14:31 -0500, Marc-André Laverdière wrote:
>> I will do that investigation. Just a quick question: if the original
>> file was password-protected, will the temp files be similarly be
>> protected?
>
>        Almost certainly not :-) but theoretically they could be of course.
>
>        All the best,
>
>                Michael.
>
> --
> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

[Noel Grandin]

Cool, I'll spin a new patch in a couple of days.

On 2012-03-28 12:11, Stephan Bergmann wrote:

On 03/27/2012 11:03 AM, Noel Grandin wrote:

OK, so I went ahead anyway, at the risk of having to redo stuff :-)
This is the next 4 commits.
It updates the IDL files in the OFFAPI module.


Looking at those 112 converted services, I'm afraid most of them 
should not be converted after all.  :(  I classified the according to 
the below list.


* 30 look good.  :)

* CTORS accessible.AccessBridge:  This service being of interface type 
XInitialization looks strange.  (XInitialization is more of an 
internal interface, so that instances of such a service can obtain 
arguments when being constructed.  Explicit constructors of new-style 
services internally call it.)  Looking at the usage of that service 
(vcl/source/app/svdata.cxx, vcl/source/app/svmain.cxx), it looks more 
sensible change this UNO service to


  service AccessBridge: XComponent {
create([in] XExtendedToolkit toolkit);
  };

(and change the type of mxAccessBridge accordingly).

* MARKER:  These services are not intended to be instantiated via 
their service names.  Rather, they describe characteristics of certain 
UNO objects.  (And there's unfortunately lots of these, needlessly 
obscuring things in many ways.)


* MODULE:  These services are not intended to be instantiated at the 
global component context/service manager, but rather via 
document-specific factories.  (Some that I labelled MODULE might 
actually be MARKER -- I did not look too close.)


* SINGLE util.OfficeInstallationDirectories:  While there is a 
(superfluous) service definition for this, there is also a singleton 
definition (in the same file) that appears to be used exclusively by 
client code.  I would keep the service old-style, mark it as 
deprecated (pointing to the singleton for actual use), move the 
singleton into an .idl file of its own, and convert the singleton to 
new-style.


* UNUSED:  These services look completely unused.  Would probably be 
better to mark them as @deprecated.


Noel, can you adapt your patches?

Thanks again for your patience and good work,
Stephan


awt.MenuBar
awt.PopupMenu
awt.TabController
document.OleEmbeddedServerRegistration
embed.FileSystemStorageFactory
embed.StorageFactory
frame.DispatchHelper
frame.DispatchRecorderSupplier
frame.DocumentTemplates
frame.MediaTypeDetectionHelper
graphic.GraphicProvider
mozilla.MozillaBootstrap
plugin.PluginManager
scanner.ScannerManager
sheet.RecentFunctions
task.JobExecutor
text.DefaultNumberingProvider
ucb.AnyCompareFactory
ucb.CachedContentResultSetFactory
ucb.CachedContentResultSetStubFactory
ucb.CachedDynamicResultSetFactory
ucb.CachedDynamicResultSetStubFactory
ucb.ContentProviderProxyFactory
ucb.PropertiesManager
ucb.SimpleFileAccess
ucb.SortedDynamicResultSetFactory
ucb.Store
util.PathSubstitution
util.TextSearch
util.URLTransformer

CTORS   accessibility.AccessBridge
MARKER  accessibility.Accessible
UNUSED  auth.SSOManagerFactory
UNUSED  auth.SSOPasswordCache
MARKER  chart.ChartData
UNUSED  configuration.backend.HierarchyBrowser
UNUSED  configuration.bootstrap.BootstrapContext
MARKER  document.Events
MARKER  document.ExtendedTypeDetection
UNUSED  document.FilterAdapter
MARKER  document.LinkTargets
MODULE  drawing.BitmapTable
MODULE  drawing.DashTable
MODULE  drawing.GradientTable
MODULE  drawing.HatchTable
MODULE  drawing.MarkerTable
MODULE  drawing.MasterPages
MODULE  drawing.Shapes
MODULE  drawing.TransparencyGradientTable
MARKER  frame.Components
MARKER  frame.ContentHandler
MARKER  frame.FramesContainer
MARKER  i18n.TextConversion
MARKER  mozilla.MenuProxy
MARKER  mozilla.MenuProxyListener
MARKER  packages.PackageFolderEnumeration
MARKER  sdbc.Driver
MODULE  sheet.CellAnnotationsEnumeration
MODULE  sheet.CellAreaLinksEnumeration
MODULE  sheet.CellFormatRangesEnumeration
MODULE  sheet.Cells
MODULE  sheet.CellsEnumeration
MODULE  sheet.ConsolidationDescriptor
MODULE  sheet.DatabaseRangesEnumeration
MODULE  sheet.DataPilotFieldGroupItem
MODULE  sheet.DataPilotFieldsEnumeration
MODULE  sheet.DataPilotSourceDimensions
MODULE  sheet.DataPilotSourceHierarchies
MODULE  sheet.DataPilotSourceLevels
MODULE  sheet.DataPilotSourceMembers
MODULE  sheet.DataPilotTablesEnumeration
MODULE  sheet.DDELinksEnumeration
MODULE  sheet.FunctionDescriptionEnumeration
MODULE  sheet.HeaderFooterContent
MODULE  sheet.LabelRangesEnumeration
MODULE  sheet.LabelRange
MODULE  sheet.NamedRangesEnumeration
MODULE  sheet.ScenariosEnumeration
MODULE  sheet.SheetCellRangesEnumeration
MODULE  sheet.SheetLinksEnumeration
MODULE  sheet.SpreadsheetsEnumeration
MODULE  sheet.SpreadsheetViewPanesEnumeration
MODULE  sheet.SubTotalFieldsEnumeration
MODULE  sheet.SubTotalField
MODULE  sheet.Tab

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

[Tor Lillqvist]

> MARKER: These services are not intended to be instantiated via their service 
> names.

How is it in general with service names, if one browses services.rdb
(either of them), one doesn't have to look long to notice components
that have identical service names (but different implementation
names). What does this mean? That they are not supposed to be
instantiated via service names but via implementation names? Sorry if
this is a very fundamental question, but I guess I never fully have
understood UNO...

Hmm, I now see that the first such duplicated service name I come
across just visually browsing is css.frame.ContentHandler, which you
indeed mark with MARKER in your message.

> (And there's unfortunately lots of these, needlessly obscuring things in many 
> ways.)

Indeed. Is there any point at all in cluttering services.rdb (and
other configuration files?) with these components if they aren't
looked for from there at run-time anyway?

 --tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] format clipboard

[Cedric Bosdonnat]

oops forgot to update title

On Wed, 2012-03-28 at 12:09 +0200, Cedric Bosdonnat wrote:
> Hi Maxime,
> 
> On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote:
> > I hope this clarified a bit my choice to remove the "nSelectionType ==
> > nsSelectionType::SEL_TBL" part from the lcl_CreateEmptyItemSet
> > function.
> 
> Thanks for the details, I pushed the patch and the others that were
> needed (and forgotten).
> 
> Could you please add a statement on this page:
> http://wiki.documentfoundation.org/ReleaseNotes/3.6
> 
> --
> Cedric
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

[Stephan Bergmann]

On 03/27/2012 11:03 AM, Noel Grandin wrote:

OK, so I went ahead anyway, at the risk of having to redo stuff :-)
This is the next 4 commits.
It updates the IDL files in the OFFAPI module.


Looking at those 112 converted services, I'm afraid most of them should 
not be converted after all.  :(  I classified the according to the below 
list.


* 30 look good.  :)

* CTORS accessible.AccessBridge:  This service being of interface type 
XInitialization looks strange.  (XInitialization is more of an internal 
interface, so that instances of such a service can obtain arguments when 
being constructed.  Explicit constructors of new-style services 
internally call it.)  Looking at the usage of that service 
(vcl/source/app/svdata.cxx, vcl/source/app/svmain.cxx), it looks more 
sensible change this UNO service to


  service AccessBridge: XComponent {
create([in] XExtendedToolkit toolkit);
  };

(and change the type of mxAccessBridge accordingly).

* MARKER:  These services are not intended to be instantiated via their 
service names.  Rather, they describe characteristics of certain UNO 
objects.  (And there's unfortunately lots of these, needlessly obscuring 
things in many ways.)


* MODULE:  These services are not intended to be instantiated at the 
global component context/service manager, but rather via 
document-specific factories.  (Some that I labelled MODULE might 
actually be MARKER -- I did not look too close.)


* SINGLE util.OfficeInstallationDirectories:  While there is a 
(superfluous) service definition for this, there is also a singleton 
definition (in the same file) that appears to be used exclusively by 
client code.  I would keep the service old-style, mark it as deprecated 
(pointing to the singleton for actual use), move the singleton into an 
.idl file of its own, and convert the singleton to new-style.


* UNUSED:  These services look completely unused.  Would probably be 
better to mark them as @deprecated.


Noel, can you adapt your patches?

Thanks again for your patience and good work,
Stephan


awt.MenuBar
awt.PopupMenu
awt.TabController
document.OleEmbeddedServerRegistration
embed.FileSystemStorageFactory
embed.StorageFactory
frame.DispatchHelper
frame.DispatchRecorderSupplier
frame.DocumentTemplates
frame.MediaTypeDetectionHelper
graphic.GraphicProvider
mozilla.MozillaBootstrap
plugin.PluginManager
scanner.ScannerManager
sheet.RecentFunctions
task.JobExecutor
text.DefaultNumberingProvider
ucb.AnyCompareFactory
ucb.CachedContentResultSetFactory
ucb.CachedContentResultSetStubFactory
ucb.CachedDynamicResultSetFactory
ucb.CachedDynamicResultSetStubFactory
ucb.ContentProviderProxyFactory
ucb.PropertiesManager
ucb.SimpleFileAccess
ucb.SortedDynamicResultSetFactory
ucb.Store
util.PathSubstitution
util.TextSearch
util.URLTransformer

CTORS   accessibility.AccessBridge
MARKER  accessibility.Accessible
UNUSED  auth.SSOManagerFactory
UNUSED  auth.SSOPasswordCache
MARKER  chart.ChartData
UNUSED  configuration.backend.HierarchyBrowser
UNUSED  configuration.bootstrap.BootstrapContext
MARKER  document.Events
MARKER  document.ExtendedTypeDetection
UNUSED  document.FilterAdapter
MARKER  document.LinkTargets
MODULE  drawing.BitmapTable
MODULE  drawing.DashTable
MODULE  drawing.GradientTable
MODULE  drawing.HatchTable
MODULE  drawing.MarkerTable
MODULE  drawing.MasterPages
MODULE  drawing.Shapes
MODULE  drawing.TransparencyGradientTable
MARKER  frame.Components
MARKER  frame.ContentHandler
MARKER  frame.FramesContainer
MARKER  i18n.TextConversion
MARKER  mozilla.MenuProxy
MARKER  mozilla.MenuProxyListener
MARKER  packages.PackageFolderEnumeration
MARKER  sdbc.Driver
MODULE  sheet.CellAnnotationsEnumeration
MODULE  sheet.CellAreaLinksEnumeration
MODULE  sheet.CellFormatRangesEnumeration
MODULE  sheet.Cells
MODULE  sheet.CellsEnumeration
MODULE  sheet.ConsolidationDescriptor
MODULE  sheet.DatabaseRangesEnumeration
MODULE  sheet.DataPilotFieldGroupItem
MODULE  sheet.DataPilotFieldsEnumeration
MODULE  sheet.DataPilotSourceDimensions
MODULE  sheet.DataPilotSourceHierarchies
MODULE  sheet.DataPilotSourceLevels
MODULE  sheet.DataPilotSourceMembers
MODULE  sheet.DataPilotTablesEnumeration
MODULE  sheet.DDELinksEnumeration
MODULE  sheet.FunctionDescriptionEnumeration
MODULE  sheet.HeaderFooterContent
MODULE  sheet.LabelRangesEnumeration
MODULE  sheet.LabelRange
MODULE  sheet.NamedRangesEnumeration
MODULE  sheet.ScenariosEnumeration
MODULE  sheet.SheetCellRangesEnumeration
MODULE  sheet.SheetLinksEnumeration
MODULE  sheet.SpreadsheetsEnumeration
MODULE  sheet.SpreadsheetViewPanesEnumeration
MODULE  sheet.SubTotalFieldsEnumeration
MODULE  sheet.SubTotalField
MODULE  sheet.TableAutoFormatEnumeration
MODULE  sheet.TableAutoFormatsEnumeration
MODULE  sheet.TableConditionalE

Re: [Libreoffice] [PATCH] format clipboard

[Cedric Bosdonnat]

Hi Maxime,

On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote:
> I hope this clarified a bit my choice to remove the "nSelectionType ==
> nsSelectionType::SEL_TBL" part from the lcl_CreateEmptyItemSet
> function.

Thanks for the details, I pushed the patch and the others that were
needed (and forgotten).

Could you please add a statement on this page:
http://wiki.documentfoundation.org/ReleaseNotes/3.6

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: new automated test concept for chart2

[Michael Meeks]

On Wed, 2012-03-28 at 05:30 +0200, Markus Mohrhard wrote:
> finally I was able to finish my work on a chart2 test concept. I have
> implemented an idea that renders the chart and then dumps the layout
> data into an xml based on the information stored in the

Nice work ! :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: initializing extensions in daily from Master slooow

[Cor Nouws]

Stephan Bergmann wrote (28-03-12 09:17)


On #libreoffice-dev:

Mar 19 16:55:09  hi - initializing extensions for the first
start takes longg (in daily Linux_x86 etc) Known, or should I file an
issue ?
[...]
Mar 19 18:13:14  mmeeks, issue number: no idea, Cor asked here
about an hour ago (and left meanwhile)


Indeed ;-)
See issue fdo#47983

Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build breaks - icu49 ?

[Miklos Vajna]

On Sun, Mar 25, 2012 at 10:08:38AM +0200, Andreas Radke  
wrote:
> genbrk: tool completed successfully.
> /usr/bin/genbrk -r count_word_fi.txt.p -o count_word_fi.brk
> LD_LIBRARY_PATH="/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/lib" 
> /build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/bin/gencoll_rule 
> /build/src/libreoffice-core-3.5.1.2/i18npool/source/collator/data/zh_stroke.txt
>  collator_zh_stroke_invis.cxx zh_stroke
> genbrk: tool completed successfully.
> sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' indexdata_ko_dict_invis.cxx > 
> indexdata_ko_dict.cxx
> /usr/bin/genbrk -r dict_word_he.txt.p -o dict_word_he.brk
> /usr/bin/genbrk -r char.txt.p -o char.brk
> sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' zh_zhuyin_invis.cxx > 
> zh_zhuyin.cxx
> createRuleBasedBreakIterator: ICU Error "U_BRK_RULE_EMPTY_SET"  at line 19, 
> column 16
> make[3]: *** [char.brk] Error 11
> make[3]: *** Waiting for unfinished jobs
> 
> Do we have a fix for this?

I'm not aware of any such fix yet (I build with icu 4.8 and 4.6 on two
different machines, no 4.9 here ATM).
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: initializing extensions in daily from Master slooow

[Stephan Bergmann]

On 03/27/2012 10:30 PM, Cor Nouws wrote:

Experienced with some daily build the last week(s) that initializing
extensions on the first start is verry slow.
Known ? Issue ?


On #libreoffice-dev:

Mar 19 16:55:09  hi - initializing extensions for the first start 
takes longg  (in daily Linux_x86 etc) Known, or should I file an issue ?
Mar 19 17:37:19 mmeeks, looks like Cor's "initializing extensions for the 
first start takes longg [sic]" is due to that sync() in ucb/source/ucp/file/shell.cxx 
(which, btw, I just pushed to -3-5, too)
Mar 19 18:09:42sberg: oh ! :-)
Mar 19 18:10:00sberg: I'd be amazed if a few fsync's take longer 
than starting Java ;-)
Mar 19 18:10:15but possibly we're going sync-crazy ;-) 10ms per 
fsync, do we really do 100 of them ?
Mar 19 18:12:02sberg: is there an issue number ?
Mar 19 18:12:19I get 93 fsync's on 1st-start, seems a bit extreme 
but ...
Mar 19 18:12:24 mmeeks, for my --enable-ext-whatever build I saw 
quite a number of fsyncs on startup (should be much less if you have only the few 
bundled extensions; can be many more if you have lots of shared ones)
Mar 19 18:12:29I lie, 142 ;-)
Mar 19 18:12:44on 2nd start - none in the startup path I think.
Mar 19 18:12:56sberg: is there a bug # ?
Mar 19 18:13:09sberg: [ and thanks for the back-port - you make a 
lot of Ubuntu users happy ;-]
Mar 19 18:13:14 mmeeks, issue number: no idea, Cor asked here about 
an hour ago (and left meanwhile)


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice