date:20120420

 unotools/source/config/historyoptions.cxx |   38 ++
 1 file changed, 28 insertions(+), 10 deletions(-)

New commits:
commit 4ccb4bda483eb548eb6efb5e2f1952f094522320
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Apr 20 09:21:42 2012 +0200

fdo#46074 Ignore corrupted items in Recent Documents

diff --git a/unotools/source/config/historyoptions.cxx 
b/unotools/source/config/historyoptions.cxx
index 2045074..8ee53cc 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -33,6 +33,7 @@
 #include com/sun/star/uno/Any.hxx
 #include com/sun/star/uno/Sequence.hxx
 
+#include cassert
 #include deque
 #include algorithm
 
@@ -391,20 +392,37 @@ Sequence Sequence PropertyValue   
SvtHistoryOptions_Impl::GetList( EHistoryT
 
 const sal_Int32 nLength = 
xOrderList-getElementNames().getLength();
 Sequence Sequence PropertyValue   aRet(nLength);
+sal_Int32 nCount = 0;
 
 for(sal_Int32 nItem=0; nItemnLength; ++nItem)
 {
-::rtl::OUString sUrl;
-xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
-xSet-getPropertyValue(rtl::OUString(s_sHistoryItemRef)) = 
sUrl;
-
-xItemList-getByName(sUrl) = xSet;
-seqProperties[s_nOffsetURL  ].Value = sUrl;
-xSet-getPropertyValue(rtl::OUString(s_sFilter))   = 
seqProperties[s_nOffsetFilter   ].Value;
-xSet-getPropertyValue(rtl::OUString(s_sTitle))= 
seqProperties[s_nOffsetTitle].Value;
-xSet-getPropertyValue(rtl::OUString(s_sPassword)) = 
seqProperties[s_nOffsetPassword ].Value;
-aRet[nItem] = seqProperties;
+try
+{
+::rtl::OUString sUrl;
+xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
+xSet-getPropertyValue(rtl::OUString(s_sHistoryItemRef)) 
= sUrl;
+
+xItemList-getByName(sUrl) = xSet;
+seqProperties[s_nOffsetURL  ].Value = sUrl;
+xSet-getPropertyValue(rtl::OUString(s_sFilter))   = 
seqProperties[s_nOffsetFilter   ].Value;
+xSet-getPropertyValue(rtl::OUString(s_sTitle))= 
seqProperties[s_nOffsetTitle].Value;
+xSet-getPropertyValue(rtl::OUString(s_sPassword)) = 
seqProperties[s_nOffsetPassword ].Value;
+aRet[nCount++] = seqProperties;
+}
+catch(const css::uno::Exception ex)
+{
+// https://bugs.freedesktop.org/show_bug.cgi?id=46074
+// FILEOPEN: No Recent Documents... discusses a problem
+// with corrupted 
/org.openoffice.Office/Histories/Histories
+// configuration items; to work around that problem, simply
+// ignore such corrupted individual items here, so that at
+// least newly added items are successfully reported back
+// from this function:
+LogHelper::logIt(ex);
+}
 }
+assert(nCount = nLength);
+aRet.realloc(nCount);
 seqReturn = aRet;
 }
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - sw/source

 sw/source/core/crsr/callnk.cxx |   63 ++---
 1 file changed, 34 insertions(+), 29 deletions(-)

New commits:
commit e4509eea8fc7c07ddff48edf0d4c015c2663d896
Author: Miklos Vajna vmik...@suse.cz
Date:   Fri Apr 20 09:45:24 2012 +0200

n#751313 SwCallLink: avoid redrawing complete rows without nested tables

diff --git a/sw/source/core/crsr/callnk.cxx b/sw/source/core/crsr/callnk.cxx
index 642b3ea..79aac33 100644
--- a/sw/source/core/crsr/callnk.cxx
+++ b/sw/source/core/crsr/callnk.cxx
@@ -100,8 +100,21 @@ void lcl_notifyRow(const SwCntntNode* pNode, SwCrsrShell 
rShell)
 if ( pRow )
 {
 const SwTableLine* pLine = pRow-GetTabLine( );
-SwFmtFrmSize pSize = pLine-GetFrmFmt( )-GetFrmSize( );
-pRow-ModifyNotification( NULL, pSize );
+// Avoid redrawing the complete row if there are no nested 
tables
+bool bHasTable = false;
+SwFrm *pCell = pRow-GetLower();
+for (; pCell  !bHasTable; pCell = pCell-GetNext())
+{
+SwFrm *pContent = pCell-GetLower();
+for (; pContent  !bHasTable; pContent = 
pContent-GetNext())
+if (pContent-GetType() == FRM_TAB)
+bHasTable = true;
+}
+if (bHasTable)
+{
+SwFmtFrmSize pSize = pLine-GetFrmFmt()-GetFrmSize();
+pRow-ModifyNotification(NULL, pSize);
+}
 }
 }
 }
commit 071c4d56517c43d3160c4c529abc534851066060
Author: Miklos Vajna vmik...@suse.cz
Date:   Thu Apr 19 16:20:46 2012 +0200

n#751313 SwCallLink: avoid copypaste via introducing lcl_notifyRow

diff --git a/sw/source/core/crsr/callnk.cxx b/sw/source/core/crsr/callnk.cxx
index a6373da..642b3ea 100644
--- a/sw/source/core/crsr/callnk.cxx
+++ b/sw/source/core/crsr/callnk.cxx
@@ -87,6 +87,25 @@ SwCallLink::SwCallLink( SwCrsrShell  rSh )
 }
 }
 
+void lcl_notifyRow(const SwCntntNode* pNode, SwCrsrShell rShell)
+{
+if ( pNode != NULL )
+{
+SwFrm *myFrm = pNode-getLayoutFrm( rShell.GetLayout() );
+if (myFrm!=NULL)
+{
+// We need to emulated a change of the row height in order
+// to have the complete row redrawn
+SwRowFrm* pRow = myFrm-FindRowFrm();
+if ( pRow )
+{
+const SwTableLine* pLine = pRow-GetTabLine( );
+SwFmtFrmSize pSize = pLine-GetFrmFmt( )-GetFrmSize( );
+pRow-ModifyNotification( NULL, pSize );
+}
+}
+}
+}
 
 SwCallLink::~SwCallLink()
 {
@@ -100,19 +119,7 @@ SwCallLink::~SwCallLink()
 if( !pCNd )
 return;
 
-SwFrm *myFrm = pCNd-getLayoutFrm( rShell.GetLayout() );
-if (myFrm!=NULL)
-{
-// We need to emulated a change of the row height in order
-// to have the complete row redrawn
-SwRowFrm* pRow = myFrm-FindRowFrm( );
-if ( pRow )
-{
-const SwTableLine* pLine = pRow-GetTabLine( );
-SwFmtFrmSize pSize = pLine-GetFrmFmt( )-GetFrmSize( );
-pRow-ModifyNotification( NULL, pSize );
-}
-}
+lcl_notifyRow(pCNd, rShell);
 
 const SwDoc *pDoc=rShell.GetDoc();
 const SwCntntNode *pNode = NULL;
@@ -120,22 +127,7 @@ SwCallLink::~SwCallLink()
 {
 pNode = pDoc-GetNodes()[nNode]-GetCntntNode();
 }
-if ( pNode != NULL )
-{
-SwFrm *myFrm2 = pNode-getLayoutFrm( rShell.GetLayout() );
-if (myFrm2!=NULL)
-{
-// We need to emulated a change of the row height in order
-// to have the complete row redrawn
-SwRowFrm* pRow = myFrm2-FindRowFrm();
-if ( pRow )
-{
-const SwTableLine* pLine = pRow-GetTabLine( );
-SwFmtFrmSize pSize = pLine-GetFrmFmt( )-GetFrmSize( );
-pRow-ModifyNotification( NULL, pSize );
-}
-}
-}
+lcl_notifyRow(pNode, rShell);
 
 xub_StrLen nCmp, nAktCntnt = pCurCrsr-GetPoint()-nContent.GetIndex();
 sal_uInt16 nNdWhich = pCNd-GetNodeType();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - unotools/source

2012-04-20 Thread Tor Lillqvist

 unotools/source/config/historyoptions.cxx |   38 ++
 1 file changed, 28 insertions(+), 10 deletions(-)

New commits:
commit 488b766836ef41c51670175fc2eeff7c9640e86c
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Apr 20 09:21:42 2012 +0200

fdo#46074 Ignore corrupted items in Recent Documents

Signed-off-by: Tor Lillqvist tlillqv...@suse.com

diff --git a/unotools/source/config/historyoptions.cxx 
b/unotools/source/config/historyoptions.cxx
index 73161be..5ba2045 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -35,6 +35,7 @@
 #include com/sun/star/uno/Any.hxx
 #include com/sun/star/uno/Sequence.hxx
 
+#include cassert
 #include deque
 #include algorithm
 
@@ -440,20 +441,37 @@ Sequence Sequence PropertyValue   
SvtHistoryOptions_Impl::GetList( EHistoryT
 
 const sal_Int32 nLength = 
xOrderList-getElementNames().getLength();
 Sequence Sequence PropertyValue   aRet(nLength);
+sal_Int32 nCount = 0;
 
 for(sal_Int32 nItem=0; nItemnLength; ++nItem)
 {
-::rtl::OUString sUrl;
-xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
-xSet-getPropertyValue(s_sHistoryItemRef) = sUrl;
-
-xItemList-getByName(sUrl) = xSet;
-seqProperties[s_nOffsetURL  ].Value = sUrl;
-xSet-getPropertyValue(s_sFilter)   = 
seqProperties[s_nOffsetFilter   ].Value;
-xSet-getPropertyValue(s_sTitle)= 
seqProperties[s_nOffsetTitle].Value;
-xSet-getPropertyValue(s_sPassword) = 
seqProperties[s_nOffsetPassword ].Value;
-aRet[nItem] = seqProperties;
+try
+{
+::rtl::OUString sUrl;
+xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
+xSet-getPropertyValue(s_sHistoryItemRef) = sUrl;
+
+xItemList-getByName(sUrl) = xSet;
+seqProperties[s_nOffsetURL  ].Value = sUrl;
+xSet-getPropertyValue(s_sFilter)   = 
seqProperties[s_nOffsetFilter   ].Value;
+xSet-getPropertyValue(s_sTitle)= 
seqProperties[s_nOffsetTitle].Value;
+xSet-getPropertyValue(s_sPassword) = 
seqProperties[s_nOffsetPassword ].Value;
+aRet[nCount++] = seqProperties;
+}
+catch(const css::uno::Exception ex)
+{
+// https://bugs.freedesktop.org/show_bug.cgi?id=46074
+// FILEOPEN: No Recent Documents... discusses a problem
+// with corrupted 
/org.openoffice.Office/Histories/Histories
+// configuration items; to work around that problem, simply
+// ignore such corrupted individual items here, so that at
+// least newly added items are successfully reported back
+// from this function:
+LogHelper::logIt(ex);
+}
 }
+assert(nCount = nLength);
+aRet.realloc(nCount);
 seqReturn = aRet;
 }
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: formula/source unusedcode.easy

 formula/source/ui/dlg/ControlHelper.hxx |3 ---
 formula/source/ui/dlg/funcutl.cxx   |   19 ---
 unusedcode.easy |1 -
 3 files changed, 23 deletions(-)

New commits:
commit fe84f6dbab168e9bdc1459c446c4dff0afb17fdc
Author: Jaime Navarro jaime.nava...@alu.umh.es
Date:   Fri Apr 20 10:22:50 2012 +0200

Remove unused method ArgInput::GetArgSelection

diff --git a/formula/source/ui/dlg/ControlHelper.hxx 
b/formula/source/ui/dlg/ControlHelper.hxx
index b1aa636..56f04e9 100644
--- a/formula/source/ui/dlg/ControlHelper.hxx
+++ b/formula/source/ui/dlg/ControlHelper.hxx
@@ -163,9 +163,6 @@ public:
 voidSetArgSelection (const Selection rSel );
 voidReplaceSelOfArg (const String rStr );
 
-Selection   GetArgSelection();
-
-
 ArgEdit*GetArgEdPtr() {return pEdArg;}
 
 
diff --git a/formula/source/ui/dlg/funcutl.cxx 
b/formula/source/ui/dlg/funcutl.cxx
index 36115d0..5673304 100644
--- a/formula/source/ui/dlg/funcutl.cxx
+++ b/formula/source/ui/dlg/funcutl.cxx
@@ -343,25 +343,6 @@ void ArgInput::SetArgSelection  (const Selection rSel )
 if(pEdArg !=NULL) pEdArg -SetSelection(rSel );
 }
 
-/*
-#*  Member: SetArgSelection Date:13.01.97
-#*
-#*
-#*  Class:  ArgInput
-#*
-#*  Function:   Returns the Selection for the EditBox.
-#*
-#*  Input:  String
-#*
-#*  Output: ---
-#*
-#/
-Selection ArgInput::GetArgSelection ()
-{
-Selection   aSel;
-if(pEdArg !=NULL) aSel=pEdArg -GetSelection();
-return aSel;
-}
 
 /*
 #*  Member: SetArgVal   Date:13.01.97
diff --git a/unusedcode.easy b/unusedcode.easy
index cf1e982..ff33e91 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -718,7 +718,6 @@ 
drawinglayer::attribute::SdrFormTextAttribute::getFormTextShdwTransp() const
 drawinglayer::attribute::SdrTextAttribute::getPropertiesVersion() const
 drawinglayer::attribute::SdrTextAttribute::isWrongSpell() const
 
drawinglayer::primitive2d::PolyPolygonStrokePrimitive2D::PolyPolygonStrokePrimitive2D(basegfx::B2DPolyPolygon
 const, drawinglayer::attribute::LineAttribute const)
-formula::ArgInput::GetArgSelection()
 formula::EditBox::EditBox(Window*, long)
 formula::FormulaListBox::FormulaListBox(Window*, long)
 formula::FormulaTokenArray::AddBad(unsigned short const*)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: editeng/source

2012-04-20 Thread Muthu Subramanian

 editeng/source/items/frmitems.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 1489254311e75a379a129bceeab49643ebea04e0
Author: Dezsi Szabolcs dezsisz...@hotmail.com
Date:   Fri Apr 20 14:10:56 2012 +0530

fdo#47436: Fixed crash while opening odt file.

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index efdcadb..d4b876b 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -1951,7 +1951,8 @@ bool SvxBoxItem::PutValue( const uno::Any rVal, 
sal_uInt8 nMemberId )
 for (int n(0); n != SAL_N_ELEMENTS(aBorders); ++n)
 {
 editeng::SvxBorderLine* pLine = const_cast 
editeng::SvxBorderLine* ( GetLine( aBorders[n] ) );
-pLine-SetStyle( eBorderStyle );
+if( pLine )
+pLine-SetStyle( eBorderStyle );
 }
 return sal_True;
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5-3' - unotools/source

 unotools/source/config/historyoptions.cxx |   38 ++
 1 file changed, 28 insertions(+), 10 deletions(-)

New commits:
commit 76abd1abea8b23e843104756f3942c94e5e81d64
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Apr 20 09:21:42 2012 +0200

fdo#46074 Ignore corrupted items in Recent Documents

Signed-off-by: Tor Lillqvist tlillqv...@suse.com
(cherry picked from commit 488b766836ef41c51670175fc2eeff7c9640e86c)

Signed-off-by: Noel Power noel.po...@novell.com
Signed-off-by: Michael Stahl mst...@redhat.com

diff --git a/unotools/source/config/historyoptions.cxx 
b/unotools/source/config/historyoptions.cxx
index 73161be..5ba2045 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -35,6 +35,7 @@
 #include com/sun/star/uno/Any.hxx
 #include com/sun/star/uno/Sequence.hxx
 
+#include cassert
 #include deque
 #include algorithm
 
@@ -440,20 +441,37 @@ Sequence Sequence PropertyValue   
SvtHistoryOptions_Impl::GetList( EHistoryT
 
 const sal_Int32 nLength = 
xOrderList-getElementNames().getLength();
 Sequence Sequence PropertyValue   aRet(nLength);
+sal_Int32 nCount = 0;
 
 for(sal_Int32 nItem=0; nItemnLength; ++nItem)
 {
-::rtl::OUString sUrl;
-xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
-xSet-getPropertyValue(s_sHistoryItemRef) = sUrl;
-
-xItemList-getByName(sUrl) = xSet;
-seqProperties[s_nOffsetURL  ].Value = sUrl;
-xSet-getPropertyValue(s_sFilter)   = 
seqProperties[s_nOffsetFilter   ].Value;
-xSet-getPropertyValue(s_sTitle)= 
seqProperties[s_nOffsetTitle].Value;
-xSet-getPropertyValue(s_sPassword) = 
seqProperties[s_nOffsetPassword ].Value;
-aRet[nItem] = seqProperties;
+try
+{
+::rtl::OUString sUrl;
+xOrderList-getByName(::rtl::OUString::valueOf(nItem)) = 
xSet;
+xSet-getPropertyValue(s_sHistoryItemRef) = sUrl;
+
+xItemList-getByName(sUrl) = xSet;
+seqProperties[s_nOffsetURL  ].Value = sUrl;
+xSet-getPropertyValue(s_sFilter)   = 
seqProperties[s_nOffsetFilter   ].Value;
+xSet-getPropertyValue(s_sTitle)= 
seqProperties[s_nOffsetTitle].Value;
+xSet-getPropertyValue(s_sPassword) = 
seqProperties[s_nOffsetPassword ].Value;
+aRet[nCount++] = seqProperties;
+}
+catch(const css::uno::Exception ex)
+{
+// https://bugs.freedesktop.org/show_bug.cgi?id=46074
+// FILEOPEN: No Recent Documents... discusses a problem
+// with corrupted 
/org.openoffice.Office/Histories/Histories
+// configuration items; to work around that problem, simply
+// ignore such corrupted individual items here, so that at
+// least newly added items are successfully reported back
+// from this function:
+LogHelper::logIt(ex);
+}
 }
+assert(nCount = nLength);
+aRet.realloc(nCount);
 seqReturn = aRet;
 }
 }
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 8 commits - filter/source l10ntools/inc l10ntools/prj l10ntools/source linguistic/source svtools/source unusedcode.easy

 filter/source/graphicfilter/itiff/ccidecom.cxx |   35 
 filter/source/graphicfilter/itiff/itiff.cxx|   17 +---
 l10ntools/inc/l10ntools/HelpIndexer.hxx|4 -
 l10ntools/inc/l10ntools/HelpSearch.hxx |6 --
 l10ntools/inc/l10ntools/LuceneHelper.hxx   |   53 +
 l10ntools/prj/d.lst|1 
 l10ntools/source/help/HelpIndexer.cxx  |2 
 l10ntools/source/help/HelpSearch.cxx   |1 
 l10ntools/source/help/LuceneHelper.cxx |2 
 l10ntools/source/help/LuceneHelper.hxx |   44 
 linguistic/source/hyphdsp.cxx  |4 -
 svtools/source/control/calendar.cxx|8 +--
 svtools/source/control/ruler.cxx   |3 -
 svtools/source/control/valueacc.cxx|9 ++--
 unusedcode.easy|   10 
 15 files changed, 99 insertions(+), 100 deletions(-)

New commits:
commit 1dcab66d5c2579c4637891859736b02745fdf8bb
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Apr 20 11:54:28 2012 +0100

WaE: MSVC2008 suppress warnings in clucene headers

diff --git a/l10ntools/inc/l10ntools/LuceneHelper.hxx 
b/l10ntools/inc/l10ntools/LuceneHelper.hxx
new file mode 100644
index 000..c990647
--- /dev/null
+++ b/l10ntools/inc/l10ntools/LuceneHelper.hxx
@@ -0,0 +1,53 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the License); you may not use this file except in compliance with
+ * the License or as specified alternatively below. You may obtain a copy of
+ * the License at http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an AS IS basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * Major Contributor(s):
+ * Copyright (C) 2012 Gert van Valkenhoef g.h.m.van.valkenh...@rug.nl
+ *  (initial developer)
+ *
+ * All Rights Reserved.
+ *
+ * For minor contributions see the git repository.
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 3 or later (the GPLv3+), or
+ * the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
+ * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+ * instead of those above.
+ */
+
+#ifndef LUCENEHELPER_HXX
+#define LUCENEHELPER_HXX
+
+#if defined _MSC_VER
+#pragma warning(push)
+#pragma warning(disable : 4068 4263 4264 4266)
+#endif
+
+#include CLucene.h
+#include CLucene/analysis/LanguageBasedAnalyzer.h
+
+#if defined _MSC_VER
+#pragma warning(pop)
+#endif
+
+#include rtl/ustring.hxx
+#include vector
+
+std::vectorTCHAR OUStringToTCHARVec(rtl::OUString const rStr);
+rtl::OUString TCHARArrayToOUString(TCHAR const *str);
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 959ab4d0ca1a09dce08a298e41828c377a1474ff
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Apr 20 11:54:01 2012 +0100

WaE: MSVC2008 suppress warnings in clucene headers

diff --git a/l10ntools/inc/l10ntools/HelpIndexer.hxx 
b/l10ntools/inc/l10ntools/HelpIndexer.hxx
index 28c7eb6..df492bb 100644
--- a/l10ntools/inc/l10ntools/HelpIndexer.hxx
+++ b/l10ntools/inc/l10ntools/HelpIndexer.hxx
@@ -31,9 +31,7 @@
 #define HELPINDEXER_HXX
 
 #include l10ntools/dllapi.h
-
-#include CLucene/StdHeader.h
-#include CLucene.h
+#include l10ntools/LuceneHelper.hxx
 
 #include rtl/ustring.hxx
 #include set
diff --git a/l10ntools/inc/l10ntools/HelpSearch.hxx 
b/l10ntools/inc/l10ntools/HelpSearch.hxx
index 63e2807..1a1b3c0 100644
--- a/l10ntools/inc/l10ntools/HelpSearch.hxx
+++ b/l10ntools/inc/l10ntools/HelpSearch.hxx
@@ -31,14 +31,12 @@
 #define HELPSEARCH_HXX
 
 #include l10ntools/dllapi.h
-
-#include CLucene/StdHeader.h
-#include CLucene.h
+#include l10ntools/LuceneHelper.hxx
 
 #include rtl/ustring.hxx
 #include vector
 
-class L10N_DLLPUBLIC HelpSearch {
+class L10N_DLLPUBLIC HelpSearch{
private:
rtl::OUString d_lang;
rtl::OString d_indexDir;
diff --git a/l10ntools/prj/d.lst b/l10ntools/prj/d.lst
index e9329dc..99aac56 100644
--- a/l10ntools/prj/d.lst
+++ b/l10ntools/prj/d.lst
@@ -47,6 +47,7 @@ mkdir: %_DEST%\bin\help\com\sun\star\help
 ..\inc\l10ntools\dllapi.h %_DEST%\inc\l10ntools\dllapi.h
 ..\inc\l10ntools\directory.hxx %_DEST%\inc\l10ntools\directory.hxx
 ..\inc\l10ntools\file.hxx %_DEST%\inc\l10ntools\file.hxx
+..\inc\l10ntools\LuceneHelper.hxx %_DEST%\inc\l10ntools\LuceneHelper.hxx
 ..\inc\l10ntools\HelpIndexer.hxx %_DEST%\inc\l10ntools\HelpIndexer.hxx
 ..\inc\l10ntools\HelpSearch.hxx %_DEST%\inc\l10ntools\HelpSearch.hxx
 ..\source\filter\merge\FCFGMerge.cfg  %_DEST%\inc\l10ntools\FCFGMerge.cfg

[Libreoffice-commits] .: 8 commits - offapi/com sw/source udkapi/com

 offapi/com/sun/star/datatransfer/clipboard/ClipboardEvent.idl |2 
 offapi/com/sun/star/datatransfer/clipboard/XClipboard.idl |4 -
 offapi/com/sun/star/datatransfer/clipboard/XClipboardOwner.idl|2 
 offapi/com/sun/star/datatransfer/dnd/DropTargetDragEnterEvent.idl |2 
 offapi/com/sun/star/deployment/PackageInformationProvider.idl |4 -
 offapi/com/sun/star/deployment/XPackageInformationProvider.idl|4 -
 offapi/com/sun/star/i18n/XExtendedInputSequenceChecker.idl|2 
 offapi/com/sun/star/report/meta/XFormulaParser.idl|2 
 offapi/com/sun/star/text/XSimpleText.idl  |2 
 offapi/com/sun/star/ucb/NumberedSortingInfo.idl   |2 
 offapi/com/sun/star/xml/dom/XAttr.idl |2 
 offapi/com/sun/star/xml/dom/XComment.idl  |2 
 offapi/com/sun/star/xml/xpath/Libxml2ExtensionHandle.idl  |4 -
 offapi/com/sun/star/xsd/WhiteSpaceTreatment.idl   |4 -
 sw/source/core/layout/paintfrm.cxx|   22 
++
 udkapi/com/sun/star/corba/corba.idl   |5 ++
 udkapi/com/sun/star/corba/giop/giop.idl   |   10 ++--
 udkapi/com/sun/star/corba/iiop/iiop.idl   |6 +-
 udkapi/com/sun/star/corba/iop/iop.idl |2 
 udkapi/com/sun/star/reflection/InvalidTypeNameException.idl   |2 
 udkapi/com/sun/star/util/logging/LoggerRemote.idl |4 -
 21 files changed, 51 insertions(+), 38 deletions(-)

New commits:
commit 85ef81f318cbec16fff67e49c9b902dfe16cb7b7
Author: Tomas Hlavaty t...@logand.com
Date:   Fri Apr 20 12:19:58 2012 +0200

idl fix symbol references

diff --git a/offapi/com/sun/star/datatransfer/clipboard/ClipboardEvent.idl 
b/offapi/com/sun/star/datatransfer/clipboard/ClipboardEvent.idl
index e6d81f7..4d116f4 100644
--- a/offapi/com/sun/star/datatransfer/clipboard/ClipboardEvent.idl
+++ b/offapi/com/sun/star/datatransfer/clipboard/ClipboardEvent.idl
@@ -47,7 +47,7 @@ published struct ClipboardEvent: 
com::sun::star::lang::EventObject
 //-
 /** The current content of the clipboard.
 */
-XTransferable Contents;
+com::sun::star::datatransfer::XTransferable Contents;
 };
 
 //=
diff --git a/offapi/com/sun/star/datatransfer/clipboard/XClipboard.idl 
b/offapi/com/sun/star/datatransfer/clipboard/XClipboard.idl
index 1b06c65..11c79b3 100644
--- a/offapi/com/sun/star/datatransfer/clipboard/XClipboard.idl
+++ b/offapi/com/sun/star/datatransfer/clipboard/XClipboard.idl
@@ -54,7 +54,7 @@ published interface XClipboard: 
com::sun::star::uno::XInterface
 
 @see com::sun::star::datatransfer::XTransferable
 */
-XTransferable getContents();
+com::sun::star::datatransfer::XTransferable getContents();
 
 //-
 /** Sets the current contents of the clipboard to the specified
@@ -76,7 +76,7 @@ published interface XClipboard: 
com::sun::star::uno::XInterface
 @see com::sun::star::datatransfer::XTransferable
 @see com::sun::star::datatransfer::clipboard::XClipboardOwner
 */
-[oneway] void setContents( [in] XTransferable xTrans, [in] XClipboardOwner 
xClipboardOwner );
+[oneway] void setContents( [in] 
com::sun::star::datatransfer::XTransferable xTrans, [in] XClipboardOwner 
xClipboardOwner );
 
 //-
 /** To get the name of the clipboard instance.
diff --git a/offapi/com/sun/star/datatransfer/clipboard/XClipboardOwner.idl 
b/offapi/com/sun/star/datatransfer/clipboard/XClipboardOwner.idl
index 6e81c20..66a5fe1 100644
--- a/offapi/com/sun/star/datatransfer/clipboard/XClipboardOwner.idl
+++ b/offapi/com/sun/star/datatransfer/clipboard/XClipboardOwner.idl
@@ -59,7 +59,7 @@ published interface XClipboardOwner: 
com::sun::star::uno::XInterface
 @see com::sun::star::datatransfer::clipboard::XClipboard
 @see com::sun::star::datatransfer::XTransferable
 */
-[oneway] void lostOwnership( [in] XClipboard xClipboard, [in] 
XTransferable xTrans );
+[oneway] void lostOwnership( [in] XClipboard xClipboard, [in] 
com::sun::star::datatransfer::XTransferable xTrans );
 };
 
 //=
diff --git a/offapi/com/sun/star/datatransfer/dnd/DropTargetDragEnterEvent.idl 
b/offapi/com/sun/star/datatransfer/dnd/DropTargetDragEnterEvent.idl
index 98067e5..4dc018a 100644
--- a/offapi/com/sun/star/datatransfer/dnd/DropTargetDragEnterEvent.idl
+++ b/offapi/com/sun/star/datatransfer/dnd/DropTargetDragEnterEvent.idl
@@ -55,7 +55,7 @@ published struct

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 4 commits - drawinglayer/source sw/source

 drawinglayer/source/primitive2d/borderlineprimitive2d.cxx |   22 +
 sw/source/core/layout/paintfrm.cxx|  185 --
 2 files changed, 180 insertions(+), 27 deletions(-)

New commits:
commit e435a78af84f04e1ea8907c70447a87841aa1186
Author: Michael Stahl mst...@redhat.com
Date:   Mon Apr 16 16:12:36 2012 +0200

fdo#38215: merge consecutive border lines:

This re-implements the merging that was done by SwLineRects::AddLineRect,
SwLineRect::MakeUnion with the drawing layer border lines.
This is used to merge borders of paragraphs and of tables that have the
separating border-model, which fixes both the tiny dividing gaps
between successive borders in the second bugdoc and the weird subtly
differently rendered successive borders in the first bugdoc.
(regression from 0f0896c26fb260d1bbf31d7a886df3f61837f0f2)

(cherry-picked from 0868a0155a2b57daf7b862d120aead0458372b17
 and 44092833d3a0f0d6074c64bd0e64bbdf11109afe)

Conflicts:

sw/source/core/layout/paintfrm.cxx

Signed-off-by: CaolÃ¡n McNamara caol...@redhat.com

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 1fd7013..797f3af 100755
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -132,6 +132,9 @@
 
 using namespace ::editeng;
 using namespace ::com::sun::star;
+using ::drawinglayer::primitive2d::BorderLinePrimitive2D;
+using ::std::pair;
+using ::std::make_pair;
 
 #define GETOBJSHELL()   ((SfxObjectShell*)rSh.GetDoc()-GetDocShell())
 
@@ -223,19 +226,21 @@ public:
 
 class BorderLines
 {
-::comphelper::SequenceAsVector
- ::drawinglayer::primitive2d::Primitive2DReference m_Lines;
+typedef ::comphelper::SequenceAsVector
+::rtl::ReferenceBorderLinePrimitive2D  Lines_t;
+Lines_t m_Lines;
 public:
-void AddBorderLine(
-::drawinglayer::primitive2d::Primitive2DReference const xLine)
-{
-m_Lines.push_back(xLine);
-}
+void AddBorderLine(::rtl::ReferenceBorderLinePrimitive2D const xLine);
 drawinglayer::primitive2d::Primitive2DSequence GetBorderLines_Clear()
 {
 ::comphelper::SequenceAsVector
 ::drawinglayer::primitive2d::Primitive2DReference lines;
-::std::swap(m_Lines, lines);
+for (Lines_t::const_iterator it = m_Lines.begin(); it != m_Lines.end();
+++it)
+{
+lines.push_back(it-get());
+}
+m_Lines.clear();
 return lines.getAsConstList();
 }
 };
@@ -442,6 +447,121 @@ SwSavePaintStatics::~SwSavePaintStatics()
 
 SV_IMPL_VARARR( SwLRects, SwLineRect );
 
+static pairbool, pairdouble, double 
+lcl_TryMergeLines(pairdouble, double const mergeA,
+  pairdouble, double const mergeB)
+{
+double const fMergeGap(nPixelSzW + nHalfPixelSzW); // NOT static!
+if (   (mergeA.second + fMergeGap = mergeB.first )
+ (mergeA.first  - fMergeGap = mergeB.second))
+{
+return make_pair(true, make_pair(
+std::min(mergeA.first, mergeB.first),
+std::max(mergeA.second, mergeB.second)));
+}
+return make_pair(false, make_pair(0, 0));
+}
+
+static ::rtl::ReferenceBorderLinePrimitive2D
+lcl_MergeBorderLines(
+BorderLinePrimitive2D const rLine, BorderLinePrimitive2D const rOther,
+basegfx::B2DPoint const rStart, basegfx::B2DPoint const rEnd)
+{
+return new BorderLinePrimitive2D(rStart, rEnd,
+rLine.getLeftWidth(),
+rLine.getDistance(),
+rLine.getRightWidth(),
+rLine.getExtendLeftStart(),
+rOther.getExtendLeftEnd(),
+rLine.getExtendRightStart(),
+rOther.getExtendRightEnd(),
+rLine.getRGBColorLeft(),
+rLine.getRGBColorGap(),
+rLine.getRGBColorRight(),
+rLine.hasGapColor(),
+rLine.getStyle());
+}
+
+static ::rtl::ReferenceBorderLinePrimitive2D
+lcl_TryMergeBorderLine(BorderLinePrimitive2D const rThis,
+   BorderLinePrimitive2D const rOther)
+{
+assert(rThis.getEnd().getX() = rThis.getStart().getX());
+assert(rThis.getEnd().getY() = rThis.getStart().getY());
+assert(rOther.getEnd().getX() = rOther.getStart().getX());
+assert(rOther.getEnd().getY() = rOther.getStart().getY());
+double thisHeight = rThis.getEnd().getY() - rThis.getStart().getY();
+double thisWidth  = rThis.getEnd().getX() - rThis.getStart().getX();
+double otherHeight = rOther.getEnd().getY() -  rOther.getStart().getY();
+double otherWidth  = rOther.getEnd().getX() -  rOther.getStart().getX();
+// check for same orientation, same line width and matching colors
+if (((thisHeight  thisWidth) == (otherHeight  otherWidth))
+  (rThis.getLeftWidth() == rOther.getLeftWidth())
+

[Libreoffice-commits] .: writerperfect/Library_wpftwriter.mk writerperfect/source

 writerperfect/Library_wpftwriter.mk  |1 
 writerperfect/source/writer/MSWorksImportFilter.cxx  |   19 ++--
 writerperfect/source/writer/MSWorksImportFilter.hxx  |   11 +-
 writerperfect/source/writer/WordPerfectImportFilter.cxx  |   47 ---
 writerperfect/source/writer/WordPerfectImportFilter.hxx  |   21 +---
 writerperfect/source/writer/wpftwriter_genericfilter.cxx |   64 ---
 6 files changed, 65 insertions(+), 98 deletions(-)

New commits:
commit 0853a4d868bd2dff171c73cc1e495fa03320f7b1
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Fri Apr 20 15:37:25 2012 +0200

Monkey sberg's work for the other writerperfect library

diff --git a/writerperfect/Library_wpftwriter.mk 
b/writerperfect/Library_wpftwriter.mk
index 6110035..047f2cf 100644
--- a/writerperfect/Library_wpftwriter.mk
+++ b/writerperfect/Library_wpftwriter.mk
@@ -41,6 +41,7 @@ $(eval $(call gb_Library_use_api,wpftwriter,\
 ))
 
 $(eval $(call gb_Library_use_libraries,wpftwriter,\
+   comphelper \
cppu \
cppuhelper \
vcl \
diff --git a/writerperfect/source/writer/MSWorksImportFilter.cxx 
b/writerperfect/source/writer/MSWorksImportFilter.cxx
index 2cca078..5712703 100644
--- a/writerperfect/source/writer/MSWorksImportFilter.cxx
+++ b/writerperfect/source/writer/MSWorksImportFilter.cxx
@@ -32,26 +32,30 @@
 #include osl/diagnose.h
 #include rtl/tencinfo.h
 
-#include com/sun/star/lang/XMultiServiceFactory.hpp
 #include com/sun/star/io/XInputStream.hpp
 #include com/sun/star/xml/sax/XAttributeList.hpp
 #include com/sun/star/xml/sax/XDocumentHandler.hpp
 #include com/sun/star/xml/sax/InputSource.hpp
 #include com/sun/star/xml/sax/XParser.hpp
+#include com/sun/star/io/XSeekable.hpp
+#include com/sun/star/uno/Reference.h
 #include com/sun/star/ucb/XCommandEnvironment.hpp
 
+#include comphelper/componentcontext.hxx
 #include xmloff/attrlist.hxx
 #include ucbhelper/content.hxx
 
+#include libwps/libwps.h
+
 #include filter/FilterInternal.hxx
 #include filter/DocumentHandler.hxx
 #include filter/OdtGenerator.hxx
+#include MSWorksImportFilter.hxx
 #include stream/WPXSvStream.h
 
-#include libwps/WPSDocument.h
-#include MSWorksImportFilter.hxx
+#include iostream
 
-// using namespace ::rtl;
+using namespace ::com::sun::star::uno;
 using rtl::OString;
 using rtl::OUString;
 using com::sun::star::uno::Sequence;
@@ -61,7 +65,6 @@ using com::sun::star::uno::UNO_QUERY;
 using com::sun::star::uno::XInterface;
 using com::sun::star::uno::Exception;
 using com::sun::star::uno::RuntimeException;
-using com::sun::star::lang::XMultiServiceFactory;
 using com::sun::star::beans::PropertyValue;
 using com::sun::star::document::XFilter;
 using com::sun::star::document::XExtendedFilterDetection;
@@ -102,7 +105,7 @@ throw (RuntimeException)
 
 // An XML import service: what we push sax messages to..
 OUString sXMLImportService ( RTL_CONSTASCII_USTRINGPARAM ( 
com.sun.star.comp.Writer.XMLOasisImporter ) );
-Reference  XDocumentHandler  xInternalHandler( mxMSF-createInstance( 
sXMLImportService ), UNO_QUERY );
+Reference  XDocumentHandler  xInternalHandler( 
comphelper::ComponentContext( mxContext ).createComponent( sXMLImportService ), 
UNO_QUERY );
 
 // The XImporter sets up an empty target document for XDocumentHandler to 
write to..
 Reference  XImporter  xImporter(xInternalHandler, UNO_QUERY);
@@ -251,10 +254,10 @@ throw (RuntimeException)
 #undef SERVICE_NAME2
 #undef SERVICE_NAME1
 
-Reference XInterface  SAL_CALL MSWorksImportFilter_createInstance( const 
Reference XMultiServiceFactory   rSMgr)
+Reference XInterface  SAL_CALL MSWorksImportFilter_createInstance( const 
Reference XComponentContext   rContext)
 throw( Exception )
 {
-return (cppu::OWeakObject *) new MSWorksImportFilter( rSMgr );
+return (cppu::OWeakObject *) new MSWorksImportFilter( rContext );
 }
 
 // XServiceInfo
diff --git a/writerperfect/source/writer/MSWorksImportFilter.hxx 
b/writerperfect/source/writer/MSWorksImportFilter.hxx
index 6ef5485..db679eb 100644
--- a/writerperfect/source/writer/MSWorksImportFilter.hxx
+++ b/writerperfect/source/writer/MSWorksImportFilter.hxx
@@ -35,6 +35,7 @@
 #include com/sun/star/document/XExtendedFilterDetection.hpp
 #include com/sun/star/lang/XInitialization.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
+#include com/sun/star/uno/XComponentContext.hpp
 #include com/sun/star/xml/sax/XDocumentHandler.hpp
 #include cppuhelper/implbase5.hxx
 
@@ -51,8 +52,7 @@ class MSWorksImportFilter : public cppu::WeakImplHelper5
 
 {
 protected:
-// oo.org declares
-::com::sun::star::uno::Reference 
::com::sun::star::lang::XMultiServiceFactory  mxMSF;
+::com::sun::star::uno::Reference ::com::sun::star::uno::XComponentContext 
 mxContext;
 ::com::sun::star::uno::Reference ::com::sun::star::lang::XComponent  
mxDoc;
 ::rtl::OUString msFilterName;
 ::com::sun::star::uno::Reference 
::com::sun::star::xml::sax::XDocumentHandler

[Libreoffice-commits] .: writerfilter/source

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit dd1fbdd27d44ac237a36579a8858983d5ab6d637
Author: Miklos Vajna vmik...@suse.cz
Date:   Fri Apr 20 15:29:20 2012 +0200

RTFDocumentImpl::resolvePict: use new-style uno ctor

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 4a0eb27..2527cef 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -27,7 +27,7 @@
 
 #include com/sun/star/beans/PropertyAttribute.hpp
 #include com/sun/star/document/XDocumentPropertiesSupplier.hpp
-#include com/sun/star/graphic/XGraphicProvider.hpp
+#include com/sun/star/graphic/GraphicProvider.hpp
 #include com/sun/star/io/UnexpectedEOFException.hpp
 #include com/sun/star/text/XTextFrame.hpp
 #include com/sun/star/text/SizeType.hpp
@@ -647,8 +647,7 @@ int RTFDocumentImpl::resolvePict(bool bInline)
 beans::PropertyValues aMediaProperties(1);
 aMediaProperties[0].Name = URL;
 aMediaProperties[0].Value = aGraphicUrl;
-uno::Referencegraphic::XGraphicProvider 
xGraphicProvider(m_xContext-getServiceManager()-createInstanceWithContext(com.sun.star.graphic.GraphicProvider,
 m_xContext),
-uno::UNO_QUERY_THROW);
+uno::Referencegraphic::XGraphicProvider 
xGraphicProvider(graphic::GraphicProvider::create(m_xContext));
 uno::Referencegraphic::XGraphic xGraphic = 
xGraphicProvider-queryGraphic(aMediaProperties);
 xPropertySet-setPropertyValue(Graphic, uno::Any(xGraphic));
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - writerfilter/source

2012-04-20 Thread Andras Timar

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 299387dab1b365427cc44d810026facd30e11a31
Author: Miklos Vajna vmik...@suse.cz
Date:   Fri Apr 20 12:42:23 2012 +0200

fdo#48356 fix RTF import of special unicode characters

The \'0d string should not be an exception when ignoring characters
after the \u control word.

Signed-off-by: Andras Timar ati...@suse.com

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 9633176..016943d 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -784,7 +784,7 @@ int RTFDocumentImpl::resolveChars(char ch)
 bool bSkipped = false;
 while(!Strm().IsEof()  ch != '{'  ch != '}'  ch != '\\')
 {
-if (ch != 0x0d  ch != 0x0a)
+if (m_aStates.top().nInternalState == INTERNAL_HEX || (ch != 0x0d  
ch != 0x0a))
 {
 if (m_aStates.top().nCharsToSkip == 0)
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: test/source

 test/source/sheet/xdatabaserange.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 6a018dec6b1abe75464bd510d441ab56d7291e1f
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Apr 20 13:47:32 2012 +0100

WaE: MSVC2008 C2220 unsafe mix of types in operation

diff --git a/test/source/sheet/xdatabaserange.cxx 
b/test/source/sheet/xdatabaserange.cxx
index 381e892..7715305 100644
--- a/test/source/sheet/xdatabaserange.cxx
+++ b/test/source/sheet/xdatabaserange.cxx
@@ -91,15 +91,15 @@ void XDatabaseRange::testGetSortDescriptor()
 
 if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(IsSortColumns)))
 {
-sal_Bool bIsSortColumns = true;
+sal_Bool bIsSortColumns = sal_True;
 xProp.Value = bIsSortColumns;
-CPPUNIT_ASSERT(bIsSortColumns == true);
+CPPUNIT_ASSERT(bIsSortColumns == sal_True);
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(ContainsHeader)))
 {
-sal_Bool bContainsHeader = true;
+sal_Bool bContainsHeader = sal_True;
 xProp.Value = bContainsHeader;
-CPPUNIT_ASSERT(bContainsHeader == true);
+CPPUNIT_ASSERT(bContainsHeader == sal_True);
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(MaxFieldCount)))
 {
@@ -114,15 +114,15 @@ void XDatabaseRange::testGetSortDescriptor()
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(BindFormatsToContent)))
 {
-sal_Bool bBindFormatsToContent = false;
+sal_Bool bBindFormatsToContent = sal_False;
 xProp.Value = bBindFormatsToContent;
-CPPUNIT_ASSERT(bBindFormatsToContent == true);
+CPPUNIT_ASSERT(bBindFormatsToContent == sal_False);
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(CopyOutputData)))
 {
-sal_Bool bCopyOutputData = true;
+sal_Bool bCopyOutputData = sal_True;
 xProp.Value = bCopyOutputData;
-CPPUNIT_ASSERT(bCopyOutputData == false);
+CPPUNIT_ASSERT(bCopyOutputData == sal_False);
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(OutputPosition)))
 {
@@ -130,9 +130,9 @@ void XDatabaseRange::testGetSortDescriptor()
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(IsUserListEnabled)))
 {
-sal_Bool bIsUserListEnabled  = true;
+sal_Bool bIsUserListEnabled  = sal_True;
 xProp.Value = bIsUserListEnabled;
-CPPUNIT_ASSERT(bIsUserListEnabled == false);
+CPPUNIT_ASSERT(bIsUserListEnabled == sal_False);
 
 }
 else if (xProp.Name == 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(UserListIndex)))
@@ -180,7 +180,7 @@ void XDatabaseRange::testRefresh()
 uno::Reference beans::XPropertySet  xPropRow(xRow, UNO_QUERY_THROW);
 Any aAny = xPropRow-getPropertyValue( aHidden );
 
-CPPUNIT_ASSERT( aAny.getsal_Bool() == true);
+CPPUNIT_ASSERT(aAny.getsal_Bool() == sal_True);
 }
 
 xDBRange-refresh();
@@ -194,7 +194,7 @@ void XDatabaseRange::testRefresh()
 uno::Reference beans::XPropertySet  xPropRow(xRow, UNO_QUERY_THROW);
 Any aAny = xPropRow-getPropertyValue( aHidden );
 
-CPPUNIT_ASSERT( aAny.getsal_Bool() == false);
+CPPUNIT_ASSERT(aAny.getsal_Bool() == sal_False);
 }
 
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5-3' - sc/inc sc/source

 sc/inc/compiler.hxx  |9 ++-
 sc/inc/rangenam.hxx  |6 ++--
 sc/source/core/data/table1.cxx   |   10 ---
 sc/source/core/tool/compiler.cxx |   50 +++
 sc/source/core/tool/rangenam.cxx |   10 +++
 5 files changed, 42 insertions(+), 43 deletions(-)

New commits:
commit 51648779ccf76bc7c6b6ff1ed4cd32eb75af9a5a
Author: Eike Rathke er...@redhat.com
Date:   Fri Apr 20 00:20:29 2012 +0200

resolved fdo#48856 update sheet-local named expressions correctly

This combines from master:

44481da569df85aa91455fdc2892a4e0c5818e6c
Author: Markus Mohrhard markus.mohrh...@googlemail.com

update relative local range names, fdo#48856

Signed-off-by: Eike Rathke er...@redhat.com

409f11ae387c859dcf9275c08093649a676e1f9e
Author: Eike Rathke er...@redhat.com

fdo#48856 update sheet-local named expressions correctly

* Named expression must be updated before any formulas that would access 
them.
* Handle all ocName tokens differentiating between global and sheet-local
  names.

Signed-off-by: Markus Mohrhard markus.mohrh...@googlemail.com
Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com
Signed-off-by: Noel Power nopo...@suse.com

diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx
index 371192c..765187e 100644
--- a/sc/inc/compiler.hxx
+++ b/sc/inc/compiler.hxx
@@ -364,6 +364,13 @@ private:
 
 void SetRelNameReference();
 
+/** Obtain range data for ocName token, global or sheet local.
+
+Prerequisite: rToken is a FormulaIndexToken so IsGlobal() and
+GetIndex() can be called on it. We don't check with RTTI.
+ */
+ScRangeData* GetRangeData( const formula::FormulaToken pToken ) const;
+
 static void InitCharClassEnglish();
 
 public:
@@ -442,7 +449,7 @@ public:
 bool UpdateNameReference( UpdateRefMode eUpdateRefMode,
   const ScRange,
   SCsCOL nDx, SCsROW nDy, SCsTAB nDz,
-  bool rChanged, bool bSharedFormula = false);
+  bool rChanged, bool bSharedFormula = false, 
bool bLocal = false);
 
 ScRangeData* UpdateReference( UpdateRefMode eUpdateRefMode,
   const ScAddress rOldPos, const ScRange,
diff --git a/sc/inc/rangenam.hxx b/sc/inc/rangenam.hxx
index 53e9ec8..e2bf10b 100644
--- a/sc/inc/rangenam.hxx
+++ b/sc/inc/rangenam.hxx
@@ -140,7 +140,7 @@ public:
 const formula::FormulaGrammar::Grammar 
eGrammar = formula::FormulaGrammar::GRAM_DEFAULT );
 voidUpdateReference( UpdateRefMode eUpdateRefMode,
  const ScRange r,
- SCsCOL nDx, SCsROW nDy, SCsTAB nDz );
+ SCsCOL nDx, SCsROW nDy, SCsTAB nDz, bool bLocal = 
false );
 boolIsModified() const  { return bModified; }
 
 SC_DLLPUBLIC void   GuessPosition();
@@ -203,9 +203,9 @@ public:
 SC_DLLPUBLIC const ScRangeData* findByRange(const ScRange rRange) const;
 SC_DLLPUBLIC ScRangeData* findByUpperName(const rtl::OUString rName);
 SC_DLLPUBLIC const ScRangeData* findByUpperName(const rtl::OUString 
rName) const;
-SC_DLLPUBLIC ScRangeData* findByIndex(sal_uInt16 i);
+SC_DLLPUBLIC ScRangeData* findByIndex(sal_uInt16 i) const;
 void UpdateReference(UpdateRefMode eUpdateRefMode, const ScRange rRange,
- SCsCOL nDx, SCsROW nDy, SCsTAB nDz);
+ SCsCOL nDx, SCsROW nDy, SCsTAB nDz, bool bLocal = 
false);
 void UpdateTabRef(SCTAB nTable, sal_uInt16 nFlag, SCTAB nNewTable = 0, 
SCTAB nNewSheets = 1);
 void UpdateTranspose(const ScRange rSource, const ScAddress rDest);
 void UpdateGrow(const ScRange rArea, SCCOL nGrowX, SCROW nGrowY);
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 31c3f46..76f371b 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1317,16 +1317,18 @@ void ScTable::UpdateReference( UpdateRefMode 
eUpdateRefMode, SCCOL nCol1, SCROW
 i = 0;
 iMax = MAXCOL;
 }
-for ( ; i=iMax; i++)
-bUpdated |= aCol[i].UpdateReference(
-eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, 
nDy, nDz, pUndoDoc );
 
+// Named expressions need to be updated before formulas acessing them.
 if (mpRangeName)
 {
 ScRange aRange( nCol1, nRow1, nTab1, nCol2, nRow2, nTab2 );;
-mpRangeName-UpdateReference( eUpdateRefMode, aRange, nDx, nDy, nDz );
+mpRangeName-UpdateReference( eUpdateRefMode, aRange, nDx, nDy, nDz, 
true );
 }
 
+for ( ; i=iMax; i++)
+bUpdated |= aCol[i].UpdateReference(
+eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, 
nDy, nDz, pUndoDoc );
+
 if ( bIncludeDraw )

[Libreoffice-commits] .: bug/bug.xhtml

2012-04-20 Thread Jan Holesovsky

 bug/bug.xhtml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ff2462fa7f5a6c95e830c3b71a3d48a5200e77c7
Author: Jan Holesovsky ke...@suse.cz
Date:   Fri Apr 20 16:43:37 2012 +0200

Fix the URL when the user does has JavaScript disabled.

diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index c0f017b..cc780e9 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -40,7 +40,7 @@
   div class=message unsupportedThis browser version is not supported 
and this page cannot be displayed properly./div
   div class=message nojavascriptJavaScript is disabled and this page 
cannot be displayed./div
   div class=message
-pPlease use a 
href=/enter_bug.cgi?product=LibreOffice;bug_status=UNCONFIRMED;version=?bugzilla/a
 instead to report a problem./p
+pPlease use a 
href=http://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice;bug_status=UNCONFIRMED;version=?;bugzilla/a
 instead to report a problem./p
 pIt works on all browsers and when JavaScript is disabled./p
   /div
   div class=eyecandy/div
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 3 commits - oovbaapi/ooo sc/source

2012-04-20 Thread Noel Power

 oovbaapi/ooo/vba/excel/XApplication.idl |5 +
 sc/source/ui/inc/viewutil.hxx   |2 
 sc/source/ui/vba/vbaapplication.cxx |   86 +++-
 sc/source/ui/vba/vbaapplication.hxx |   11 
 4 files changed, 101 insertions(+), 3 deletions(-)

New commits:
commit 101132c28a8f084612106337f4cafe21c535dea8
Author: Noel Power noel.po...@novell.com
Date:   Fri Apr 20 18:25:45 2012 +0100

add stub vba implementation Application methods

added Application.DisplayExcel4Menus, Application.DisplayNoteIndicator, 
Application.ShowWindowsInTaskbar. Althought these attributes of the Application 
object don't do anything they allow setting and retrieval of the state. We 
could make a usable implementation for Application.DisplayNoteIndicator, the 
others though don't really seem to have any useful equivalent in the 
libreoffice world

diff --git a/oovbaapi/ooo/vba/excel/XApplication.idl 
b/oovbaapi/ooo/vba/excel/XApplication.idl
index 866ab21..baf6468 100644
--- a/oovbaapi/ooo/vba/excel/XApplication.idl
+++ b/oovbaapi/ooo/vba/excel/XApplication.idl
@@ -76,6 +76,9 @@ interface XApplication
 [attribute] long EnableCancelKey;
 [attribute] boolean DisplayFullScreen;
 [attribute] boolean DisplayScrollBars;
+[attribute] boolean DisplayExcel4Menus;
+[attribute] boolean DisplayNoteIndicator;
+[attribute] boolean ShowWindowsInTaskbar;
 
 void setDefaultFilePath([in] string DefaultFilePath) 
raises(com::sun::star::script::BasicErrorException);
 
diff --git a/sc/source/ui/vba/vbaapplication.cxx 
b/sc/source/ui/vba/vbaapplication.cxx
index 4963882..bb31732 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -154,14 +154,19 @@ struct ScVbaAppSettings
 sal_Int32 mnCalculation;
 sal_Bool mbDisplayAlerts;
 sal_Bool mbEnableEvents;
-
+sal_Bool mbExcel4Menus;
+sal_Bool mbDisplayNoteIndicator;
+sal_Bool mbShowWindowsInTaskbar;
 explicit ScVbaAppSettings();
 };
 
 ScVbaAppSettings::ScVbaAppSettings() :
 mnCalculation( excel::XlCalculation::xlCalculationAutomatic ),
 mbDisplayAlerts( sal_True ),
-mbEnableEvents( sal_True )
+mbEnableEvents( sal_True ),
+mbExcel4Menus( sal_False ),
+mbDisplayNoteIndicator( sal_True ),
+mbShowWindowsInTaskbar( sal_True )
 {
 }
 
@@ -916,6 +921,42 @@ ScVbaApplication::setDisplayScrollBars( sal_Bool bSet )  
throw (uno::RuntimeExce
 }
 
 sal_Bool SAL_CALL
+ScVbaApplication::getDisplayExcel4Menus() throw (css::uno::RuntimeException)
+{
+return mrAppSettings.mbExcel4Menus;
+}
+
+void SAL_CALL
+ScVbaApplication::setDisplayExcel4Menus( sal_Bool bSet ) throw 
(css::uno::RuntimeException)
+{
+mrAppSettings.mbExcel4Menus = bSet;
+}
+
+sal_Bool SAL_CALL
+ScVbaApplication::getDisplayNoteIndicator() throw (css::uno::RuntimeException)
+{
+return mrAppSettings.mbDisplayNoteIndicator;
+}
+
+void SAL_CALL
+ScVbaApplication::setDisplayNoteIndicator( sal_Bool bSet ) throw 
(css::uno::RuntimeException)
+{
+mrAppSettings.mbDisplayNoteIndicator = bSet;
+}
+
+sal_Bool SAL_CALL
+ScVbaApplication::getShowWindowsInTaskbar() throw (css::uno::RuntimeException)
+{
+return mrAppSettings.mbShowWindowsInTaskbar;
+}
+
+void SAL_CALL
+ScVbaApplication::setShowWindowsInTaskbar( sal_Bool bSet ) throw 
(css::uno::RuntimeException)
+{
+mrAppSettings.mbShowWindowsInTaskbar = bSet;
+}
+
+sal_Bool SAL_CALL
 ScVbaApplication::getVisible() throw (uno::RuntimeException)
 {
 sal_Bool bVisible = sal_True;
diff --git a/sc/source/ui/vba/vbaapplication.hxx 
b/sc/source/ui/vba/vbaapplication.hxx
index 9b1c528..0f72d7b 100644
--- a/sc/source/ui/vba/vbaapplication.hxx
+++ b/sc/source/ui/vba/vbaapplication.hxx
@@ -126,6 +126,13 @@ public:
 virtual void SAL_CALL setDisplayFullScreen( sal_Bool bSet ) throw 
(css::uno::RuntimeException);
 virtual sal_Bool SAL_CALL getDisplayScrollBars() throw 
(css::uno::RuntimeException);
 virtual void SAL_CALL setDisplayScrollBars( sal_Bool bSet ) throw 
(css::uno::RuntimeException);
+virtual sal_Bool SAL_CALL getDisplayExcel4Menus() throw 
(css::uno::RuntimeException);
+virtual void SAL_CALL setDisplayExcel4Menus( sal_Bool bSet ) throw 
(css::uno::RuntimeException);
+
+virtual sal_Bool SAL_CALL getDisplayNoteIndicator() throw 
(css::uno::RuntimeException);
+virtual void SAL_CALL setDisplayNoteIndicator( sal_Bool bSet ) throw 
(css::uno::RuntimeException);
+virtual sal_Bool SAL_CALL getShowWindowsInTaskbar() throw 
(css::uno::RuntimeException);
+virtual void SAL_CALL setShowWindowsInTaskbar( sal_Bool bSet ) throw 
(css::uno::RuntimeException);
 virtual css::uno::Any SAL_CALL Windows( const css::uno::Any aIndex ) 
throw (css::uno::RuntimeException);
 virtual void SAL_CALL wait( double time ) throw 
(css::uno::RuntimeException);
 virtual css::uno::Any SAL_CALL Range( const css::uno::Any Cell1, const 
css::uno::Any Cell2 ) throw (css::uno::RuntimeException);
commit

[Libreoffice-commits] .: 2 commits - configure.in test/Library_test.mk

2012-04-20 Thread Lubos Lunak

 configure.in |2 +-
 test/Library_test.mk |1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 1b62ccdcb5a44effe4f6f9de105d96fbbd18102d
Author: LuboÅ¡ LuÅÃ¡k l.lu...@suse.cz
Date:   Fri Apr 20 20:07:57 2012 +0200

it seems tests runtime-depend on ucpchelp1 too

CppunitTest_sc_databaserangeobj can fail with
'UcbContentProviderProxy::getContentProvider - No provider for 
Â´com.sun.star.help.XMLHelp.'

diff --git a/test/Library_test.mk b/test/Library_test.mk
index 571d26c..b795f8a 100644
--- a/test/Library_test.mk
+++ b/test/Library_test.mk
@@ -56,6 +56,7 @@ ifeq ($(GUIBASE),unx)
 $(call gb_Library_get_target,test) : \
 $(call gb_Library_get_target,desktop_detector) \
 $(call gb_Library_get_target,vclplug_svp) \
+$(call gb_Library_get_target,ucpchelp1) \
 
 endif
 
commit 4be258a2f7aa10b781e2a67545d547cd6cac192a
Author: LuboÅ¡ LuÅÃ¡k l.lu...@suse.cz
Date:   Fri Apr 20 13:34:59 2012 +0200

fix typo

diff --git a/configure.in b/configure.in
index c3847c1..15d8ce6 100644
--- a/configure.in
+++ b/configure.in
@@ -966,7 +966,7 @@ AC_ARG_WITH(vba-package-format,
  means the api component and associated type library are  part of the
  installation set. Specifying extn creates an uno extension that is
  part of the installation set (located in the program directory) that
- MUST be optionly registered using either the unopkg executeable or the
+ MUST be optionally registered using either the unopkg executeable or 
the
  extension manager gui.])
 [
   Note: builtin is the default, extn can cause
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 4 commits - editeng/source sax/qa sax/source xmloff/source

 editeng/source/editeng/editdoc.cxx |4 
 sax/qa/cppunit/test_converter.cxx  |   72 +
 sax/source/tools/converter.cxx |  155 ++---
 xmloff/source/core/xmluconv.cxx|2 
 4 files changed, 219 insertions(+), 14 deletions(-)

New commits:
commit ee376102becc16c0c44d23e5eb2a322aadc45197
Author: Michael Stahl mst...@redhat.com
Date:   Fri Apr 20 18:39:36 2012 +0200

fdo#48969: add unit test for Converter::convertDouble

diff --git a/sax/qa/cppunit/test_converter.cxx 
b/sax/qa/cppunit/test_converter.cxx
index 4a3d364..a8dad87 100644
--- a/sax/qa/cppunit/test_converter.cxx
+++ b/sax/qa/cppunit/test_converter.cxx
@@ -39,11 +39,13 @@
 #include com/sun/star/util/DateTime.hpp
 #include com/sun/star/util/Date.hpp
 #include com/sun/star/util/Duration.hpp
+#include com/sun/star/util/MeasureUnit.hpp
 
 #include sax/tools/converter.hxx
 
 
 using namespace ::com::sun::star;
+using namespace ::com::sun::star::util::MeasureUnit;
 using sax::Converter;
 
 
@@ -58,10 +60,12 @@ public:
 
 void testDuration();
 void testDateTime();
+void testDouble();
 
 CPPUNIT_TEST_SUITE(ConverterTest);
 CPPUNIT_TEST(testDuration);
 CPPUNIT_TEST(testDateTime);
+CPPUNIT_TEST(testDouble);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -249,6 +253,74 @@ void ConverterTest::testDateTime()
 OSL_TRACE(\nSAX CONVERTER TEST END);
 }
 
+void doTestDouble(char const*const pis, double const rd,
+sal_Int16 const nSourceUnit, sal_Int16 const nTargetUnit)
+{
+::rtl::OUString const is(::rtl::OUString::createFromAscii(pis));
+double od;
+bool bSuccess(Converter::convertDouble(od, is, nSourceUnit, nTargetUnit));
+OSL_TRACE(%f, od);
+CPPUNIT_ASSERT(bSuccess);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(rd, od, 0.0001);
+::rtl::OUStringBuffer buf;
+Converter::convertDouble(buf, od, true, nTargetUnit, nSourceUnit);
+OSL_TRACE(%s,
+::rtl::OUStringToOString(buf.getStr(), 
RTL_TEXTENCODING_UTF8).getStr());
+CPPUNIT_ASSERT_EQUAL(is, buf.makeStringAndClear());
+}
+
+void ConverterTest::testDouble()
+{
+doTestDouble(42, 42.0, TWIP, TWIP);
+doTestDouble(42, 42.0, POINT, POINT);
+doTestDouble(42, 42.0, MM_100TH, MM_100TH);
+doTestDouble(42, 42.0, MM_10TH, MM_10TH);
+doTestDouble(42, 42.0, MM, MM); // identity don't seem to add unit?
+doTestDouble(42, 42.0, CM, CM);
+doTestDouble(42, 42.0, INCH, INCH);
+doTestDouble(2pt, 40.0, POINT, TWIP);
+doTestDouble(20pc, 1, TWIP, POINT);
+doTestDouble(4, 2.26771653543307, MM_100TH, TWIP);
+doTestDouble(4, 22.6771653543307, MM_10TH, TWIP);
+doTestDouble(4mm, 226.771653543307, MM, TWIP);
+doTestDouble(4cm, 2267.71653543307, CM, TWIP);
+doTestDouble(4in, 5760.0, INCH, TWIP);
+doTestDouble(1440pc, 1.0, TWIP, INCH);
+doTestDouble(567pc, 1.000125, TWIP, CM);
+doTestDouble(56.7pc, 1.000125, TWIP, MM);
+doTestDouble(5.67pc, 1.000125, TWIP, MM_10TH);
+doTestDouble(0.567pc, 1.000125, TWIP, MM_100TH);
+doTestDouble(42pt, 1.48166, POINT, CM);
+doTestDouble(42pt, 14.8166, POINT, MM);
+doTestDouble(42pt, 148.166, POINT, MM_10TH);
+doTestDouble(42pt, 1481.66, POINT, MM_100TH);
+doTestDouble(72pt, 1.0, POINT, INCH);
+doTestDouble(3.5in, 8.89, INCH, CM);
+doTestDouble(3.5in, 88.9, INCH, MM);
+doTestDouble(3.5in, 889.0, INCH, MM_10TH);
+doTestDouble(3.5in, 8890.0, INCH, MM_100TH);
+doTestDouble(2in, 144, INCH, POINT);
+doTestDouble(5.08cm, 2.0, CM, INCH);
+doTestDouble(3.5cm, 3500.0, CM, MM_100TH);
+doTestDouble(3.5cm, 350.0, CM, MM_10TH);
+doTestDouble(3.5cm, 35.0, CM, MM);
+doTestDouble(10cm, 283.464566929134, CM, POINT);
+doTestDouble(0.5cm, 283.464566929134, CM, TWIP);
+doTestDouble(10mm, 28.3464566929134, MM, POINT);
+doTestDouble(0.5mm, 28.3464566929134, MM, TWIP);
+doTestDouble(10, 2.83464566929134, MM_10TH, POINT);
+doTestDouble(0.5, 2.83464566929134, MM_10TH, TWIP);
+doTestDouble(10, 0.283464566929134, MM_100TH, POINT);
+doTestDouble(0.5, 0.283464566929134, MM_100TH, TWIP);
+doTestDouble(10mm, 1.0, MM, CM);
+doTestDouble(10mm, 100.0, MM, MM_10TH);
+doTestDouble(20mm, 2000.0, MM, MM_100TH);
+doTestDouble(300, 30.0, MM_10TH, MM);
+doTestDouble(400, 4.0, MM_100TH, MM);
+doTestDouble(600, 6000.0, MM_10TH, MM_100TH);
+doTestDouble(700, 70.0, MM_100TH, MM_10TH);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ConverterTest);
 
 }
commit 62a0b2405798a3be6a4e38652f1da7a685c84bfc
Author: Michael Stahl mst...@redhat.com
Date:   Fri Apr 20 18:36:16 2012 +0200

fdo#48969: GetConversionFactor: add inch as source unit

Also, add whole bunch of missing cases while at it.

diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 4fe6d7f..e8fe38e 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -1788,9 +1788,16 @@ double

[Libreoffice-commits] .: 2 commits - basic/inc basic/source toolkit/inc

 basic/inc/basic/sbmod.hxx |6 +++---
 basic/source/classes/sbxmod.cxx   |6 --
 toolkit/inc/toolkit/helper/macros.hxx |2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit b2fdaed46509127ec3ac2fb87404bc1b51d8
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Apr 20 20:01:54 2012 +0100

WaE: MSVC2008 C2220 unsafe mix of types in operation

diff --git a/basic/inc/basic/sbmod.hxx b/basic/inc/basic/sbmod.hxx
index 24700e9..392082b 100644
--- a/basic/inc/basic/sbmod.hxx
+++ b/basic/inc/basic/sbmod.hxx
@@ -73,7 +73,7 @@ protected:
 SbiImage*   pImage;// the Image
 SbiBreakpoints* pBreaks;   // Breakpoints
 SbClassData*pClassData;
-sal_Bool mbVBACompat;
+bool mbVBACompat;
 sal_Int32 mnType;
 SbxObjectRef pDocObject; // an impl object ( used by Document Modules )
 boolbIsProxyModule;
@@ -139,8 +139,8 @@ public:
 sal_Bool ExceedsLegacyModuleSize();
 void fixUpMethodStart( bool bCvtToLegacy, SbiImage* pImg = NULL ) const;
 bool HasExeCode();
-sal_Bool IsVBACompat() const;
-void SetVBACompat( sal_Bool bCompat );
+bool IsVBACompat() const;
+void SetVBACompat( bool bCompat );
 sal_Int32 GetModuleType() { return mnType; }
 void SetModuleType( sal_Int32 nType ) { mnType = nType; }
 bool isProxyModule() { return bIsProxyModule; }
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 9d3a4b9..87928cf 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -1077,15 +1077,17 @@ void ClearUnoObjectsInRTL_Impl( StarBASIC* pBasic )
 if( ((StarBASIC*)p) != pBasic )
 ClearUnoObjectsInRTL_Impl_Rek( (StarBASIC*)p );
 }
-sal_Bool SbModule::IsVBACompat() const
+
+bool SbModule::IsVBACompat() const
 {
 return mbVBACompat;
 }
 
-void SbModule::SetVBACompat( sal_Bool bCompat )
+void SbModule::SetVBACompat( bool bCompat )
 {
 mbVBACompat = bCompat;
 }
+
 // Run a Basic-subprogram
 sal_uInt16 SbModule::Run( SbMethod* pMeth )
 {
commit 6f9971f3b935f669b39d7a53266950ee92955027
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Apr 20 15:16:43 2012 +0100

WaE: MSVC20082 unreferenced argument

diff --git a/toolkit/inc/toolkit/helper/macros.hxx 
b/toolkit/inc/toolkit/helper/macros.hxx
index b2acbf2..3d59e60 100644
--- a/toolkit/inc/toolkit/helper/macros.hxx
+++ b/toolkit/inc/toolkit/helper/macros.hxx
@@ -176,7 +176,7 @@ void ClassName::disposing( const 
::com::sun::star::lang::EventObject ) throw(::
 sMessage += ::rtl::OString( e.Message.getStr(), e.Message.getLength(), 
RTL_TEXTENCODING_ASCII_US ); \
 OSL_FAIL( sMessage.getStr() );
 #else
-#define DISPLAY_EXCEPTION( ClassName, MethodName, e )
+#define DISPLAY_EXCEPTION( ClassName, MethodName, e ) (void)e;
 #endif
 
 #define IMPL_TABLISTENERMULTIPLEXER_LISTENERMETHOD_BODY_2PARAM( ClassName, 
InterfaceName, MethodName, ParamType1, ParamType2 ) \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sax/qa sax/source xmloff/source

 sax/qa/cppunit/test_converter.cxx |   72 +
 sax/source/tools/converter.cxx|  155 +++---
 xmloff/source/core/xmluconv.cxx   |2 
 3 files changed, 217 insertions(+), 12 deletions(-)

New commits:
commit 3186b307260cf4e633c252022b803dcf6f31273c
Author: Michael Stahl mst...@redhat.com
Date:   Fri Apr 20 18:39:36 2012 +0200

fdo#48969: add unit test for Converter::convertDouble

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/sax/qa/cppunit/test_converter.cxx 
b/sax/qa/cppunit/test_converter.cxx
index 4a3d364..a8dad87 100644
--- a/sax/qa/cppunit/test_converter.cxx
+++ b/sax/qa/cppunit/test_converter.cxx
@@ -39,11 +39,13 @@
 #include com/sun/star/util/DateTime.hpp
 #include com/sun/star/util/Date.hpp
 #include com/sun/star/util/Duration.hpp
+#include com/sun/star/util/MeasureUnit.hpp
 
 #include sax/tools/converter.hxx
 
 
 using namespace ::com::sun::star;
+using namespace ::com::sun::star::util::MeasureUnit;
 using sax::Converter;
 
 
@@ -58,10 +60,12 @@ public:
 
 void testDuration();
 void testDateTime();
+void testDouble();
 
 CPPUNIT_TEST_SUITE(ConverterTest);
 CPPUNIT_TEST(testDuration);
 CPPUNIT_TEST(testDateTime);
+CPPUNIT_TEST(testDouble);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -249,6 +253,74 @@ void ConverterTest::testDateTime()
 OSL_TRACE(\nSAX CONVERTER TEST END);
 }
 
+void doTestDouble(char const*const pis, double const rd,
+sal_Int16 const nSourceUnit, sal_Int16 const nTargetUnit)
+{
+::rtl::OUString const is(::rtl::OUString::createFromAscii(pis));
+double od;
+bool bSuccess(Converter::convertDouble(od, is, nSourceUnit, nTargetUnit));
+OSL_TRACE(%f, od);
+CPPUNIT_ASSERT(bSuccess);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(rd, od, 0.0001);
+::rtl::OUStringBuffer buf;
+Converter::convertDouble(buf, od, true, nTargetUnit, nSourceUnit);
+OSL_TRACE(%s,
+::rtl::OUStringToOString(buf.getStr(), 
RTL_TEXTENCODING_UTF8).getStr());
+CPPUNIT_ASSERT_EQUAL(is, buf.makeStringAndClear());
+}
+
+void ConverterTest::testDouble()
+{
+doTestDouble(42, 42.0, TWIP, TWIP);
+doTestDouble(42, 42.0, POINT, POINT);
+doTestDouble(42, 42.0, MM_100TH, MM_100TH);
+doTestDouble(42, 42.0, MM_10TH, MM_10TH);
+doTestDouble(42, 42.0, MM, MM); // identity don't seem to add unit?
+doTestDouble(42, 42.0, CM, CM);
+doTestDouble(42, 42.0, INCH, INCH);
+doTestDouble(2pt, 40.0, POINT, TWIP);
+doTestDouble(20pc, 1, TWIP, POINT);
+doTestDouble(4, 2.26771653543307, MM_100TH, TWIP);
+doTestDouble(4, 22.6771653543307, MM_10TH, TWIP);
+doTestDouble(4mm, 226.771653543307, MM, TWIP);
+doTestDouble(4cm, 2267.71653543307, CM, TWIP);
+doTestDouble(4in, 5760.0, INCH, TWIP);
+doTestDouble(1440pc, 1.0, TWIP, INCH);
+doTestDouble(567pc, 1.000125, TWIP, CM);
+doTestDouble(56.7pc, 1.000125, TWIP, MM);
+doTestDouble(5.67pc, 1.000125, TWIP, MM_10TH);
+doTestDouble(0.567pc, 1.000125, TWIP, MM_100TH);
+doTestDouble(42pt, 1.48166, POINT, CM);
+doTestDouble(42pt, 14.8166, POINT, MM);
+doTestDouble(42pt, 148.166, POINT, MM_10TH);
+doTestDouble(42pt, 1481.66, POINT, MM_100TH);
+doTestDouble(72pt, 1.0, POINT, INCH);
+doTestDouble(3.5in, 8.89, INCH, CM);
+doTestDouble(3.5in, 88.9, INCH, MM);
+doTestDouble(3.5in, 889.0, INCH, MM_10TH);
+doTestDouble(3.5in, 8890.0, INCH, MM_100TH);
+doTestDouble(2in, 144, INCH, POINT);
+doTestDouble(5.08cm, 2.0, CM, INCH);
+doTestDouble(3.5cm, 3500.0, CM, MM_100TH);
+doTestDouble(3.5cm, 350.0, CM, MM_10TH);
+doTestDouble(3.5cm, 35.0, CM, MM);
+doTestDouble(10cm, 283.464566929134, CM, POINT);
+doTestDouble(0.5cm, 283.464566929134, CM, TWIP);
+doTestDouble(10mm, 28.3464566929134, MM, POINT);
+doTestDouble(0.5mm, 28.3464566929134, MM, TWIP);
+doTestDouble(10, 2.83464566929134, MM_10TH, POINT);
+doTestDouble(0.5, 2.83464566929134, MM_10TH, TWIP);
+doTestDouble(10, 0.283464566929134, MM_100TH, POINT);
+doTestDouble(0.5, 0.283464566929134, MM_100TH, TWIP);
+doTestDouble(10mm, 1.0, MM, CM);
+doTestDouble(10mm, 100.0, MM, MM_10TH);
+doTestDouble(20mm, 2000.0, MM, MM_100TH);
+doTestDouble(300, 30.0, MM_10TH, MM);
+doTestDouble(400, 4.0, MM_100TH, MM);
+doTestDouble(600, 6000.0, MM_10TH, MM_100TH);
+doTestDouble(700, 70.0, MM_100TH, MM_10TH);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ConverterTest);
 
 }
commit 124881b16fee79be683507928c06ce54a5a2543e
Author: Michael Stahl mst...@redhat.com
Date:   Fri Apr 20 18:36:16 2012 +0200

fdo#48969: GetConversionFactor: add inch as source unit

Also, add whole bunch of missing cases while at it.

Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch

diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index cf5a5b5..51be183 100644
---

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sax/qa

 sax/qa/cppunit/test_converter.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 580a7f24c373cd8cf068fc92fdb153025e6d0a1d
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Fri Apr 20 22:30:26 2012 +0200

Minor backporting fix

Signed-off-by: Michael Stahl mst...@redhat.com

diff --git a/sax/qa/cppunit/test_converter.cxx 
b/sax/qa/cppunit/test_converter.cxx
index a8dad87..023177f 100644
--- a/sax/qa/cppunit/test_converter.cxx
+++ b/sax/qa/cppunit/test_converter.cxx
@@ -266,7 +266,7 @@ void doTestDouble(char const*const pis, double const rd,
 Converter::convertDouble(buf, od, true, nTargetUnit, nSourceUnit);
 OSL_TRACE(%s,
 ::rtl::OUStringToOString(buf.getStr(), 
RTL_TEXTENCODING_UTF8).getStr());
-CPPUNIT_ASSERT_EQUAL(is, buf.makeStringAndClear());
+CPPUNIT_ASSERT(buf.makeStringAndClear().equals(is));
 }
 
 void ConverterTest::testDouble()
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: cppuhelper/source

 cppuhelper/source/defaultbootstrap.cxx  |6 +++---
 cppuhelper/source/servicefactory.cxx|2 +-
 cppuhelper/source/servicefactory_detail.hxx |1 +
 3 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 18a9e9e844d2f3ebad52e6c45095e3c50422db1a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Apr 20 23:37:14 2012 +0200

Various clean up of previous commit

diff --git a/cppuhelper/source/defaultbootstrap.cxx 
b/cppuhelper/source/defaultbootstrap.cxx
index 8698f25..4921011 100644
--- a/cppuhelper/source/defaultbootstrap.cxx
+++ b/cppuhelper/source/defaultbootstrap.cxx
@@ -1268,7 +1268,7 @@ void ServiceManager::readRdbFile(rtl::OUString const  
uri, bool optional) {
 try {
 Parser(
 uri, css::uno::Reference css::uno::XComponentContext (), data_);
-} catch (css::container::NoSuchElementException SB) {
+} catch (css::container::NoSuchElementException ) {
 if (!optional) {
 throw css::uno::DeploymentException(
 uri + : no such file,
@@ -1279,7 +1279,7 @@ void ServiceManager::readRdbFile(rtl::OUString const  
uri, bool optional) {
 throw css::uno::DeploymentException(
 InvalidRegistryException:  + e.Message,
 static_cast cppu::OWeakObject * (this));
-} catch (css::uno::RuntimeException SB) {
+} catch (css::uno::RuntimeException ) {
 if (!readLegacyRdbFile(uri)) {
 throw;
 }
@@ -1593,7 +1593,7 @@ bool ServiceManager::removeLegacyFactory(
 css::uno::Reference css::lang::XComponent  comp;
 {
 osl::MutexGuard g(rBHelper.rMutex);
-DynamicImplementations::const_iterator i(
+DynamicImplementations::iterator i(
 data_.dynamicImplementations.find(factoryInfo));
 if (i == data_.dynamicImplementations.end()) {
 return isDisposed();
diff --git a/cppuhelper/source/servicefactory.cxx 
b/cppuhelper/source/servicefactory.cxx
index 2b7c9ed..062e7ff 100644
--- a/cppuhelper/source/servicefactory.cxx
+++ b/cppuhelper/source/servicefactory.cxx
@@ -374,7 +374,7 @@ void addFactories(
 
 } // namespace
 
-SAL_DLLPUBLIC_EXPORT Reference lang::XMultiComponentFactory  
bootstrapInitialSF(
+Reference lang::XMultiComponentFactory  bootstrapInitialSF(
 OUString const  rBootstrapPath )
 SAL_THROW( (Exception) )
 {
diff --git a/cppuhelper/source/servicefactory_detail.hxx 
b/cppuhelper/source/servicefactory_detail.hxx
index 89485b5..607bb58 100644
--- a/cppuhelper/source/servicefactory_detail.hxx
+++ b/cppuhelper/source/servicefactory_detail.hxx
@@ -53,6 +53,7 @@ void add_access_control_entries(
 rtl::Bootstrap const  bootstrap)
 SAL_THROW((com::sun::star::uno::Exception));
 
+SAL_DLLPUBLIC_EXPORT
 com::sun::star::uno::Reference com::sun::star::lang::XMultiComponentFactory 
 bootstrapInitialSF(rtl::OUString const  rBootstrapPath)
 SAL_THROW((com::sun::star::uno::Exception));
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: cui/source dbaccess/source fpicker/source framework/inc framework/source scripting/source sfx2/inc svl/source svtools/inc svtools/source svx/source unotools/source

2012-04-20 Thread Thomas Arnhold

 cui/source/inc/acccfg.hxx  |6 -
 cui/source/inc/cfgutil.hxx |4 ---
 dbaccess/source/ui/control/sqledit.cxx |6 -
 fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx |8 
---
 fpicker/source/win32/filepicker/VistaFilePicker.hxx|8 
---
 fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx|8 
---
 fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx|8 
---
 fpicker/source/win32/filepicker/asyncrequests.hxx  |8 
---
 fpicker/source/win32/filepicker/vistatypes.h   |8 
---
 framework/inc/framework/preventduplicateinteraction.hxx|   10 
+
 framework/inc/framework/titlehelper.hxx|   10 
+
 framework/source/inc/accelerators/storageholder.hxx|   10 
+
 framework/source/uielement/statusbarmanager.cxx|4 ---
 scripting/source/inc/util/MiscUtils.hxx|4 +--
 scripting/source/protocolhandler/scripthandler.cxx |3 --
 scripting/source/provider/ActiveMSPList.hxx|4 +--
 scripting/source/provider/BrowseNodeFactoryImpl.hxx|4 +--
 scripting/source/provider/MasterScriptProvider.hxx |4 +--
 scripting/source/provider/MasterScriptProviderFactory.hxx  |4 +--
 scripting/source/provider/ProviderCache.hxx|4 +--
 scripting/source/provider/ScriptImpl.hxx   |5 +---
 scripting/source/provider/ScriptingContext.hxx |5 ++--
 scripting/source/provider/URIHelper.hxx|4 +--
 scripting/source/runtimemgr/ScriptNameResolverImpl.hxx |4 +--
 scripting/source/runtimemgr/ScriptRuntimeManager.hxx   |4 +--
 scripting/source/runtimemgr/StorageBridge.hxx  |4 +--
 scripting/source/runtimemgr/StorageBridgeFactory.hxx   |4 +--
 sfx2/inc/sfx2/sfxbasemodel.hxx |9 
+---
 svl/source/config/itemholder2.hxx  |   11 
--
 svtools/inc/svtools/acceleratorexecute.hxx |8 
---
 svtools/source/config/itemholder2.hxx  |   10 
-
 svx/source/inc/docrecovery.hxx |   10 
+
 unotools/source/config/itemholder1.hxx |6 -
 unotools/source/i18n/instance.hxx  |3 --
 34 files changed, 53 insertions(+), 159 deletions(-)

New commits:
commit 2abba84aa7c639011956721a4922653130dd09a6
Author: Thomas Arnhold tho...@arnhold.org
Date:   Sat Apr 21 01:30:38 2012 +0200

Replace css macro with namespace for nicer namespacing

diff --git a/cui/source/inc/acccfg.hxx b/cui/source/inc/acccfg.hxx
index ec03c4a..1cfdc81 100644
--- a/cui/source/inc/acccfg.hxx
+++ b/cui/source/inc/acccfg.hxx
@@ -56,7 +56,7 @@
 #include sfx2/minarray.hxx
 #include cfgutil.hxx
 
-#define css ::com::sun::star
+namespace css = ::com::sun::star;
 
 class SfxMacroInfoItem;
 class SfxConfigGroupListBox_Impl;
@@ -219,10 +219,6 @@ public:
 virtual ~SvxShortcutAssignDlg();
 };
 
-
-
-#undef css
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/inc/cfgutil.hxx b/cui/source/inc/cfgutil.hxx
index 94c764b..4e0fd27 100644
--- a/cui/source/inc/cfgutil.hxx
+++ b/cui/source/inc/cfgutil.hxx
@@ -51,7 +51,7 @@ class SfxMacroInfoItem;
 struct SfxStyleInfo_Impl;
 struct SfxStylesInfo_Impl;
 
-#define css ::com::sun::star
+namespace css = ::com::sun::star;
 
 struct SfxStyleInfo_Impl
 {
@@ -203,8 +203,6 @@ public:
 voidSetStylesInfo(SfxStylesInfo_Impl* pStyles);
 };
 
-#undef css
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/ui/control/sqledit.cxx 
b/dbaccess/source/ui/control/sqledit.cxx
index 765d6a7..3161879 100644
--- a/dbaccess/source/ui/control/sqledit.cxx
+++ b/dbaccess/source/ui/control/sqledit.cxx
@@ -45,11 +45,7 @@
 
 #include svl/smplhint.hxx
 
-namespace {
-
-namespace css = com::sun::star;
-
-}
+namespace css = ::com::sun::star;
 
 //
 // OSqlEdit
diff --git a/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx 
b/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
index 47909d7..ca1b223 100644
--- a/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
+++ b/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
@@ -45,11 +45,7 @@
 // namespace
 //-
 
-#ifdef css
-#error

Re: Asynchronous use of SwHTMLParser - is this needed

On Thu, Apr 19, 2012 at 05:06:43PM -0400, Kohei Yoshida 
kohei.yosh...@gmail.com wrote:
 My question is, do we need to keep this asynchronicity of
 SwHTMLParser, or is it okay to change it into a synchronous call like
 the rest of SvParser uses?

I would be surprised if this would be really required, all the sw
filters I know of are synchronous ones.

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #291 from Cor Nouws c...@nouenoff.nl 2012-04-20 00:25:44 PDT ---
(In reply to comment #289)
 Should I add more bugs (I can easily add a 100 more).

Yes and no. 

Bugs that belong here, pls do. 
However: I do not believe in doing it 'easily'. 
Since, steps in the correct work flow are:
 - reproduce, 
 - test impact, workarounds,
 - query BugZilla for related and the same or closely related issues 
   which may lead to do some bundling of issues
 - in case of doubt, consult others via the QA list

But any bug that is really a problem, and that is not yet visible here: pls do.
We have had issues in the past, that were in BugZilla for months, turned out to
be very nasty, and were not recognised fast enough, but discovered just because
I (or someone else) was confronted with a similar problem and did the work in
BugZilla.
So finding those bugs, is important and more helpful than adding just a load of
bug numbers to this MAB.
Thanks for your help!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #292 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-20 00:33:53 PDT ---
@dE, Sasha, Cor:
For discussions we have libreoffice@lists.freedesktop.org, please stop
discussion here immediately! Same concerning discussion concerning relevance of
bugs, discuss that in the bugs, not here. Tis Bug is only to be used for
purposes as per Petr's report. All those 28 Users listed in CC do not want to
read any of your thoughts!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW-3-5][REVIEW-3-5-3] Ignore corrupted items in Recent Documents

See https://bugs.freedesktop.org/show_bug.cgi?id=46074#c59 and the 
comments leading up to it for the reason why I would appreciate it if 
the below master commit would be reviewed for inclusion in -3-5 and esp. 
-3-5-3.


(The diff is longer than necessary due to indentation changes due to an 
additional try--catch block; diff -b shows the actual changes more clearly.)


Stephan

On 04/20/2012 09:22 AM, Stephan Bergmann wrote:

  unotools/source/config/historyoptions.cxx |   38 
++
  1 file changed, 28 insertions(+), 10 deletions(-)

New commits:
commit 4ccb4bda483eb548eb6efb5e2f1952f094522320
Author: Stephan Bergmannsberg...@redhat.com
Date:   Fri Apr 20 09:21:42 2012 +0200

 fdo#46074 Ignore corrupted items in Recent Documents

diff --git a/unotools/source/config/historyoptions.cxx 
b/unotools/source/config/historyoptions.cxx
index 2045074..8ee53cc 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -33,6 +33,7 @@
  #includecom/sun/star/uno/Any.hxx
  #includecom/sun/star/uno/Sequence.hxx

+#includecassert
  #includedeque
  #includealgorithm

@@ -391,20 +392,37 @@ Sequence  Sequence  PropertyValue
SvtHistoryOptions_Impl::GetList( EHistoryT

  const sal_Int32 nLength = 
xOrderList-getElementNames().getLength();
  Sequence  Sequence  PropertyValueaRet(nLength);
+sal_Int32 nCount = 0;

  for(sal_Int32 nItem=0; nItemnLength; ++nItem)
  {
-::rtl::OUString sUrl;
-xOrderList-getByName(::rtl::OUString::valueOf(nItem))= xSet;
-xSet-getPropertyValue(rtl::OUString(s_sHistoryItemRef))= 
sUrl;
-
-xItemList-getByName(sUrl)= xSet;
-seqProperties[s_nOffsetURL  ].Value= sUrl;
-xSet-getPropertyValue(rtl::OUString(s_sFilter))= 
seqProperties[s_nOffsetFilter   ].Value;
-xSet-getPropertyValue(rtl::OUString(s_sTitle))= 
seqProperties[s_nOffsetTitle].Value;
-xSet-getPropertyValue(rtl::OUString(s_sPassword))= 
seqProperties[s_nOffsetPassword ].Value;
-aRet[nItem] = seqProperties;
+try
+{
+::rtl::OUString sUrl;
+xOrderList-getByName(::rtl::OUString::valueOf(nItem))= 
xSet;
+
xSet-getPropertyValue(rtl::OUString(s_sHistoryItemRef))= sUrl;
+
+xItemList-getByName(sUrl)= xSet;
+seqProperties[s_nOffsetURL  ].Value= sUrl;
+xSet-getPropertyValue(rtl::OUString(s_sFilter))= 
seqProperties[s_nOffsetFilter   ].Value;
+xSet-getPropertyValue(rtl::OUString(s_sTitle))= 
seqProperties[s_nOffsetTitle].Value;
+xSet-getPropertyValue(rtl::OUString(s_sPassword))= 
seqProperties[s_nOffsetPassword ].Value;
+aRet[nCount++] = seqProperties;
+}
+catch(const css::uno::Exception  ex)
+{
+//https://bugs.freedesktop.org/show_bug.cgi?id=46074
+// FILEOPEN: No Recent Documents... discusses a problem
+// with corrupted 
/org.openoffice.Office/Histories/Histories
+// configuration items; to work around that problem, simply
+// ignore such corrupted individual items here, so that at
+// least newly added items are successfully reported back
+// from this function:
+LogHelper::logIt(ex);
+}
  }
+assert(nCount= nLength);
+aRet.realloc(nCount);
  seqReturn = aRet;
  }
  }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] .: extension libs should have no RPATH


On 04/19/2012 07:34 PM, David Tardon wrote:

commit 9da0670b601c8c186b0bfbd28ea055016db376ad
Author: David Tardondtar...@redhat.com
Date:   Thu Apr 19 19:27:19 2012 +0200

 extension libs should have no RPATH

 At least that is how it seems to work in the old build system:
 LINFLAGSRUNPATH_OXT in solenv/inc/unxmacx.mk is empty, just like for
 other platforms . On the other side, macosx-change-install-names.pl only
 lists OXT in combination with URELIB... Now choose :-)

diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk
index 2ab1336..ab955cf 100644
--- a/solenv/gbuild/platform/macosx.mk
+++ b/solenv/gbuild/platform/macosx.mk
@@ -162,8 +162,7 @@ gb_LinkTarget__RPATHS := \

  # $(call gb_LinkTarget__get_installname,libfilename,soversion,layerprefix)
  define gb_LinkTarget__get_installname
-$(if $(3),-install_name '$(3)$(1)$(if $(2),.$(2))',
-   $(call gb_Output_error,cannot determine -install_name for $(3)))
+$(if $(3),-install_name '$(3)$(1)$(if $(2),.$(2))')
  endef


On Mac OS X, LINKFLAGSRUNPATH_xxx is a misnomer.  It does not specify 
any RPATH, but rather a special install name token (those 
@___...___xxx) that is in turn used by 
solenv/bin/macosx-changes-install-names.pl to determine how other 
libraries and executables reference the given library (and thus is only 
needed for libraries that others can link against).


We apparently have no cases where libraries within one oxt extension 
link against each other, so OXT libraries (at least until now) do not 
need such a special install name token.


(For the record, a related topic is how libraries within oxt extensions 
link against other libraries.  They can legitimately only link against 
published URE libs or against other libs within the same extension, 
where the latter apparently does not happen.  For URE libs, the way this 
is achieved is different on the different platforms:  On Linux, we 
guarantee that the URE libs are already available in the process, so the 
extension lib can mention them as DT_NEEDED without having an RPATH 
through which they could be found.  On Mac OS X, we guarantee that there 
is a symlink urelibs next to the executalbe, so the extension lib can 
reference them via @executable_path/urelibs.  And on Windows, we 
guarantee that the URE libs are available on PATH, anyway.)


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED-3-5] [REVIEW-3-5-3] Ignore corrupted items in Recent Documents

2012-04-20 Thread Tor Lillqvist

Looks fine to me. Cherry-picked to 3-5, more sign-offs needed for 3-5-3

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] unusedcode.easy: Removed unused code

2012-04-20 Thread Xavi Escriche Galindo



  

0001-Remove-unused-code-function-UnoControlModel-UnoContr.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Local instance of Case Conductor

2012-04-20 Thread Yifan Jiang

Hi Sophie,

Thanks for the info, and I've set up a development environment and played a
the CC for a while this week.

Thanks for Petr and Thorsten's help, it could be possible for us to find
somewhere to deploy so that people can play with it. One problem is the
hardware resources, would you kindly help to get rough estimation from the
Mozilla team that about recommended hardwares (memory, cpu, harddisk) for CC,
in a scale of:

- 200 test cases

- 100 users

- 20 users concurrency of running test

The above data are extracted and a bit over estimated from our current Litmus
system. Thanks in advance for your hlep :)

Best wishes,
Yifan

On Thu, Apr 05, 2012 at 06:43:26PM +0200, Sophie Gautier wrote:

 I'm in contact with the Mozilla team developing this application
 since quite some time now, so don't hesitate to ask me directly if
 you need anything from them.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Modify unusedcode.easy

2012-04-20 Thread Muthu Subramanian K


I guess the unusedcode.easy is created by script(s) (?)

On 04/20/2012 03:35 AM, Xavi Escriche Galindo wrote:




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED-3-5] [REVIEW-3-5-3] Ignore corrupted items in Recent Documents

2012-04-20 Thread Noel Power


On 20/04/12 09:03, Tor Lillqvist wrote:

Looks fine to me. Cherry-picked to 3-5, more sign-offs needed for 3-5-3

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


+1 from me
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removed unused code formula::ArgInput::GetArgSelection

On Thu, Apr 19, 2012 at 5:30 PM,  jaime.nava...@alu.umh.es wrote:
 Hi all,

 All of my past, present and future contributions to LibreOffice may be
 licensed under the MPL/LGPLv3+ dual license.


Pushed. Thanks :)

-- 
Jesús Corrius je...@softcatala.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Pushed] [PATCH] fdo#47436: FILEOPEN: Writer crashes when it opens an odt file produced by JasperReport

2012-04-20 Thread Muthu Subramanian K


Pushed. Thank you.

On 04/20/2012 04:21 AM, Dézsi Szabolcs wrote:

Crash while opening odt file


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Automatic using ::rtl::OUString etc.


On 04/16/2012 11:33 AM, Stephan Bergmann wrote:

I am not objecting to the goal of frequently used entities having
reasonably short names. I am objecting to the hacky implementation.


Just so I don't appear too negative, I really do like your recent work 
on strings etc., Lubos.  Even something like SAL_DEBUG, where I was at 
first somewhat sceptical and indifferent -- I use it daily now.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Modify unusedcode.easy

Hola Xavi,

On Fri, Apr 20, 2012 at 12:05 AM, Xavi Escriche Galindo
xescri...@hotmail.com wrote:


 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


El patch aquest està malament. No es tracta només d'esborrar el nom de
la llista, sinó també els mètodes. Mira't l'exemple aquest:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe84f6dbab168e9bdc1459c446c4dff0afb17fdc

S'elimina el mètode del codi i de la llista al mateix temps. Si tens
qualsevol dubte, em pots escriure a mi directament o comentar-ho al
forum.


-- 
Jesús Corrius je...@softcatala.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Modify unusedcode.easy

 I guess the unusedcode.easy is created by script(s) (?)

Yes, please ignore this one. It's just a mistake. He will resubmit it.

-- 
Jesús Corrius je...@softcatala.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Dmesg output on MacOSX and LO - quarantine clearance

2012-04-20 Thread Alexander Thurgood

Hi all,

While attempting to brush up my BSD skills, I was trundling through the
use of dmesg on Mac, and this is what I get as output from the terminal:

reServicesUIAg[8123] Unable to clear quarantine `urelibs': 93
CoreServicesUIAg[8123] Unable to clear quarantine `lib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `acceptor.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `binaryurp.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `bootstrap.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `connector.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`introspection.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `invocadapt.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `invocation.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `javaloader.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `javavm.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `JREProperties.class': 93
CoreServicesUIAg[8123] Unable to clear quarantine `jvmfwk3rc': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libaffine_uno_uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libgcc3_uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjava_uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjava_uno.jnilib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjpipe.jnilib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjuh.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjuhx.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libjvmaccessgcc3.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libjvmfwk.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine `liblog_uno_uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libreg.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libsal_textenc.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libstore.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libuno_cppu.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libuno_cppuhelpergcc3.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libuno_purpenvhelpergcc3.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libuno_sal.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libuno_salhelpergcc3.dylib.3': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`libunsafe_uno_uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `libxmlreader.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`namingservice.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `proxyfac.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `reflection.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`stocservices.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `streams.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `sunjavaplugin.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`textinstream.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine
`textoutstream.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `unorc': 93
CoreServicesUIAg[8123] Unable to clear quarantine `uuresolver.uno.dylib': 93
CoreServicesUIAg[8123] Unable to clear quarantine `share': 93
CoreServicesUIAg[8123] Unable to clear quarantine `java': 93
CoreServicesUIAg[8123] Unable to clear quarantine `java_uno.jar': 93
CoreServicesUIAg[8123] Unable to clear quarantine `juh.jar': 93
CoreServicesUIAg[8123] Unable to clear quarantine `jurt.jar': 93
CoreServicesUIAg[8123] Unable to clear quarantine `ridl.jar': 93
CoreServicesUIAg[8123] Unable to clear quarantine `unoloader.jar': 93
CoreServicesUIAg[8123] Unable to clear quarantine `misc': 93
CoreServicesUIAg[8123] Unable to clear quarantine `javavendors.xml': 93
CoreServicesUIAg[8123] Unable to clear quarantine `services.rdb': 93
CoreServicesUIAg[8123] Unable to clear quarantine `types.rdb': 93


This would indicate that the files do not pass the quarantine xattr
check which I guess OSX 10.6.8 has set on the downloaded DMG package.
Has something changed with the installer, have the permissions been set
differently ? I only noticed this today, and the only difference between
now and yesterday is that I upgraded to LO 3.5.2 from 3.5.1 via the
update link.

TIA,

Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes


On 04/20/2012 12:42 AM, Tomas Hlavaty wrote:

1) Exceptions have message and context fields and there should be a
constructor with arguments (java.lang.String m, java.lang.Object c)
for those fields.  However, this doesn't seem to be applied
consistently.


Where is this not applied consistently?


Also when an exception inherits, it should have a
constructor with all fields for the super classes and itself.
However, the context field is missing in such cases.  Is there some
rule to this or is it arbitrary?


Looking at handleAggregatingType in 
codemaker/source/javamaker/javatype.cxx, for an exception three init 
methods (i.e., constructors) are generated, one with no parameters, one 
with just a String parameter (to be consistent with Java's overall 
Exception design), and one with parameters for all the (inherited and 
direct) members.



2) What is the meaning of 'published' in idl files?  It seems to be
ignored in javamaker, or at least everything gets generated no matter
what.  For example, there are enums or constants which are not marked
as published but other public symbols depend on them.  Shouldn't
those be public too then?


See slide 15 Published Things of the presentation 
http://www.openoffice.org/marketing/ooocon2004/presentations/friday/shinyhappyuno.pdf 
Here Come UNO, All Shiny and New for a short description of 
published (more extensive documentation appears to be lost to the 
Internet).


That a published entity does not use unpublished entities is already 
checked by idlc, so the codemakers can ignore it.



3) What is the meaning of simgleton referring to service referring to
interface?  In the example bellow, the BrowseNodeFactory service
doesn't seem to be generated from idl files.  Should this service be
bypassed and the singleton reffer directly to the interface?


Old-style singleton specifications are indeed somewhat obscure.  The 
need for a service is due to old implementation/design artefacts. 
New-style singleton specifications directly specify the interface they 
support, without going any service detour:


  singleton theBrowseNodeFactory: XBrowseNodeFactory;

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-5-3] fdo#48856 update sheet-local named expressions correctly

2012-04-20 Thread Noel Power


On 19/04/12 23:39, Eike Rathke wrote:

Hi,

Two reviews needed to cherry-pick to 3-5-3
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=9a9121929408e8ffc86b91606355ff5fe9514f7d

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48856


patch looks sane and the test doc works for me +1

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #293 from dE de.tec...@gmail.com 2012-04-20 02:37:39 PDT ---
I suggest removal of - 

Bug 34380
Bug 34436
bug 41261

See my comments in the above bugs for the reason why.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED][3-5-3] Re: [PUSHED-3-5] [REVIEW-3-5-3] Ignore corrupted items in Recent Documents

On 20/04/12 10:23, Noel Power wrote:
 On 20/04/12 09:03, Tor Lillqvist wrote:
 Looks fine to me. Cherry-picked to 3-5, more sign-offs needed for 3-5-3

pushed to libreoffice-3-5-3.

sigh... why again did we need to migrate user directories in a point
release?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] unusedcode.easy: Removed unused code

On Thu, Apr 19, 2012 at 11:52:48PM +0200, Xavi Escriche Galindo 
xescri...@hotmail.com wrote:
 -UnoControlModel::UnoControlModel()
 -:UnoControlModel_Base()
 -,MutexAndBroadcastHelper()
 -,OPropertySetHelper( BrdcstHelper )
 -,maDisposeListeners( *this )
 -,maContext( ::comphelper::getProcessServiceFactory() )
 -{
 -OSL_ENSURE( false, UnoControlModel::UnoControlModel: not implemented. 
 Well, not really. );
 -// just implemented to let the various FooImplInheritanceHelper compile, 
 you should use the
 -// version taking a service factory
 -}
 -

It seems you forgot to remove the according declaration from
toolkit/inc/toolkit/controls/unocontrolmodel.hxx.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Asynchronous use of SwHTMLParser - is this needed

On 20/04/12 09:01, Miklos Vajna wrote:
 On Thu, Apr 19, 2012 at 05:06:43PM -0400, Kohei Yoshida 
 kohei.yosh...@gmail.com wrote:
 My question is, do we need to keep this asynchronicity of
 SwHTMLParser, or is it okay to change it into a synchronous call like
 the rest of SvParser uses?
 
 I would be surprised if this would be really required, all the sw
 filters I know of are synchronous ones.

then you haven't heard of these ones:

 filter/source/config/fragments/filters/HTML.xcu:prop 
 oor:name=FlagsvalueIMPORT EXPORT ASYNCHRON PREFERRED/value/prop
 filter/source/config/fragments/filters/HTML__StarWriter_.xcu:prop 
 oor:name=FlagsvalueIMPORT EXPORT ALIEN ASYNCHRON/value/prop
 filter/source/config/fragments/filters/writer_web_HTML_help.xcu:prop 
 oor:name=FlagsvalueIMPORT INTERNAL NOTINFILEDIALOG NOTINCHOOSER 
 ASYNCHRON READONLY/value/prop
 filter/source/config/fragments/filters/writerglobal8_HTML.xcu:prop 
 oor:name=FlagsvalueEXPORT ALIEN ASYNCHRON NOTINCHOOSER/value/prop

quite what the advantage of that is i don't know; presumably it makes
Writer a better Web browser somehow?

 I'm working on removing SvRefBase from SvParser to make its life cycle
 a little more easier to understand.  I've checked the call sites of
 all of its derived classes, and in most of those call sites, we could
 easily replace it with scoped_ptr.  The only exception is the
 SwHTMLParser, where its use involves asynchronous call to parse HTML
 input.  This makes a bit non-trivial to manage its life cycle.

would wrapping a shared_ptr around it work?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [libreoffice-l10n] [ANNOUNCE] Branch libreoffice-3-5-3 created

On Thu, Apr 19, 2012 at 10:48:25AM +0100, Michael Meeks 
michael.me...@suse.com wrote:
   Interestingly though, I'd expect any regressions to be in import not
 export particularly vs. 3.4.x  - Miklos any ideas there ?

Of course this is an import one as well. I'll update the bugreport with
the details as usual.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ANN] LibreOffice 3.5.3 RC1 test builds available

Hi *,

for the upcoming new version 3.5.3, the RC1 builds now start to be
available on pre-releases. This build is slated to be first release
candidate build on the way towards 3.5.3, please refer to our release
plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to 3.5.2 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-3-release-3.5.3.1.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

Fridrich (following words copyrighted by Thorsten)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: minor idl fixes

On 20/04/12 00:42, Tomas Hlavaty wrote:
 Hi all,
 
 bellow are some patches fixing minor issues with idl files.

thanks for the patches, pushed to master, except:

#6: the usual pattern seems to be to include with full path instead

#5: pushed with a tweak, because this here broke the build

 +#ifndef __com_sun_star_deployment_XPackageInformationProvider_idl__
 +#define __com_sun_star_deployment_XPackageInformationProvider_idl__

funnily the com/sun/star/deployment/PackageInformationProvider.idl
without the X already defined this include guard... (did i already
mention that i hate include guards?)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Asynchronous use of SwHTMLParser - is this needed

2012-04-20 Thread Eike Rathke

Hi Kohei,

On Thursday, 2012-04-19 17:06:43 -0400, Kohei Yoshida wrote:

 My question is, do we need to keep this asynchronicity of
 SwHTMLParser, or is it okay to change it into a synchronous call like
 the rest of SvParser uses?

IIRC the intention was to not make the user wait until timeout if a site
can't be connected or doesn't serve the document. I'd say we should keep
that.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpRZEUp0V3EY.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED-3-5 REVIEW-3-5-3] fdo#46687 fix find toolbar crash ...

On Fri, 2012-04-20 at 00:01 +0200, Bjoern Michaelsen wrote:
 Pushed to -3-5, still needs two signoffs for 3-5-3.

+1, looks safe.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 48356, which changed state.

Bug 48356 Summary: FILESAVE: Save as RTF loses characters before/after special 
Eastern European characters
https://bugs.freedesktop.org/show_bug.cgi?id=48356

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][3-5-3] Re: [PUSHED-3-5] [REVIEW-3-5-3] Ignore corrupted items in Recent Documents


On 04/20/2012 11:44 AM, Michael Stahl wrote:

sigh... why again did we need to migrate user directories in a point
release?


At least, that way we found the bug before LO 4.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Application accepting of GSoC

2012-04-20 Thread Коростіль Данило

Hey folks, it's almost deadline of applications. But neither my mentor 
nor Fridrich didn't reply my mail about accepting. I worry they couldn't 
accept for some reason that doesn't depend on their wishes. Moreover, 
both of them accepted me. But I'm not sure about technical side of 
deciding.


So is there someone who has responsibility of it or can ping that person? :)
Thanks in advance!

Best regards!
Daniel Korostil.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions

On Mon, 2012-04-16 at 17:05 +0200, Michael Stahl wrote:
 i think i've fixed this problem now (and attached your bugdoc,
 slightly enhanced, to fdo#45562 as well), so please consider this for
 libreoffice-3-5, which basically results in painting the borders in
 almost exactly the same places as the old OOo code, and thus looks safe
 to me wrt. layering:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=5913506b2193e93ca2767ab7365ab2e76ed7848f

Hmm, doesn't apply against 3-5. Is there now a specific sequence of
patches required against 3-5, or just the above needing to be tweaked ?

C.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Application accepting of GSoC

On Fri, Apr 20, 2012 at 03:02:00PM +0300, Коростіль Данило 
ted.korosti...@gmail.com wrote:
 Hey folks, it's almost deadline of applications.

Hi,

The deadline was 6th, the accepted applications are announced on 23th.
You don't need to do anything between the two, unless you are asked in
private.

Patience please,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: per library debug builds now possible via ./configure

2012-04-20 Thread Lubos Lunak

On Monday 16 of April 2012, Bjoern Michaelsen wrote:
 On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote:
   Is it possible to do the build also the other way around, i.e. e.g. all
  but sc?

 Not yet, feel free to add it if you think it is essential.
...
  and if I understand the change correctly, I'd have to manually
  find out what all the dependencies actually are. Given that sc/sd/sw are
  the biggest three, it probably even makes the biggest difference to
  disable the two that one does not work on.

  ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e
 's/.mk$//'|grep -v sc |grep -v sw`  ./autogen.sh
 --enable-debug=$ALLBUTSCSW

 should be enough.

 How about this?

-- 
 Lubos Lunak
 l.lu...@suse.cz
From 6987137582e0ac5d5bf642054f008635bfbacfae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= l.lu...@suse.cz
Date: Fri, 20 Apr 2012 12:13:24 +0200
Subject: [PATCH 2/6] fixes for debug flags handling

- move using optimization, symbols (i.e. debug) and environment
cflags/cxxflags into one place
- --enable-dbgutils is independent from --enable-debug, and thus
also --enable-symbols, so it should not set debuglevel
- setting -g flag is controlled by --enable-symbols, not --enable-debug,
so it should be used also for selective -g enabling
- setting debug flags depending on debuglevel being 2 is certainly wrong
- do not let environment cflags/cxxflags disable optimization/symbols flags
  completely, if one wants, it's possible to explicitly specify e.g. -g0,
  but the current way does not make it easily possible to specify e.g.
  -fcolor-diagnostics
- do not set debug flag globally now that it can be done selectively
---
 config_host.mk.in|2 +-
 configure.in |   35 ++-
 solenv/gbuild/LinkTarget.mk  |   34 +++---
 solenv/gbuild/gbuild.mk  |2 --
 solenv/gbuild/platform/unxgcc.mk |5 -
 5 files changed, 34 insertions(+), 44 deletions(-)

diff --git a/config_host.mk.in b/config_host.mk.in
index fe5fc87..a3668d7 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -74,7 +74,6 @@ export DBUS_LIBS=@DBUS_LIBS@
 export DB_CPPLIB=@DB_CPPLIB@
 export DB_LIB=@DB_LIB@
 export debug=@ENABLE_DEBUG@
-export ENABLE_DEBUG_ONLY=@ENABLE_DEBUG_ONLY@
 export DEFAULT_MOZILLA_TOOLKIT=@MOZILLA_TOOLKIT@
 export DEFAULT_TO_ENGLISH_FOR_PACKING=yes
 export DIAGRAM_EXTENSION_PACK=@DIAGRAM_EXTENSION_PACK@
@@ -136,6 +135,7 @@ export ENABLE_SCRIPTING_JAVASCRIPT=@ENABLE_SCRIPTING_JAVASCRIPT@
 export ENABLE_SCRIPTING_PYTHON=@ENABLE_SCRIPTING_PYTHON@
 export ENABLE_SILENT_MSI=@ENABLE_SILENT_MSI@
 export ENABLE_SYMBOLS=@ENABLE_SYMBOLS@
+export ENABLE_SYMBOLS_ONLY=@ENABLE_SYMBOLS_ONLY@
 export ENABLE_SYSTRAY_GTK=@ENABLE_SYSTRAY_GTK@
 export ENABLE_XMLSEC=@ENABLE_XMLSEC@
 export ENABLE_ZENITY=@ENABLE_ZENITY@
diff --git a/configure.in b/configure.in
index c3847c1..054aebb 100644
--- a/configure.in
+++ b/configure.in
@@ -610,7 +610,10 @@ AC_ARG_ENABLE(atl,
 AC_ARG_ENABLE(symbols,
 AS_HELP_STRING([--enable-symbols],
 [Include debugging symbols in output. WARNING - a complete build needs
- 8 Gb of space and takes much longer (enables -g compiler flag).])
+ 8 Gb of space and takes much longer (enables -g compiler flag).
+ You can also use this switch as follows:
+ --enable-symbols=tl svx to enable symbols only for the specified
+ gbuild-build libraries.])
 [
   Enabling symbols disables the stripping of the solver
   (--disable-strip-solver).
@@ -637,9 +640,7 @@ AC_ARG_ENABLE(debug,
 [Include debugging symbols from --enable-symbols plus extra debugging
  code. Extra large build! (enables -g compiler flag and dmake debug=true)
  If you need even more verbose output, build a module with
- build -- debug=true dbglevel=2. You can also use this switch as follows:
- --enable-debug=tl svx to enable debug only for the specified
- gbuild-build libraries.]))
+ build -- debug=true dbglevel=2.]))
 
 AC_ARG_ENABLE(dbgutil,
 AS_HELP_STRING([--enable-dbgutil],
@@ -3426,25 +3427,17 @@ else
 fi
 AC_SUBST(EXTERNAL_WARNINGS_NOT_ERRORS)
 
-dnl Set the ENABLE_DEBUG variable. (Activate --enable-symbols)
+dnl Set the ENABLE_DEBUG variable.
 dnl ===
 AC_MSG_CHECKING([whether to do a debug build])
 if test -n $enable_debug  test $enable_debug != no; then
-if test $enable_debug = y || test $enable_debug = yes; then
-ENABLE_DEBUG=TRUE
-ENABLE_DEBUG_ONLY=
-else
-ENABLE_DEBUG=
-ENABLE_DEBUG_ONLY=$enable_debug
-AC_MSG_RESULT([for $enable_debug])
-fi
+ENABLE_DEBUG=TRUE
+AC_MSG_RESULT([yes])
 else
 ENABLE_DEBUG=
-ENABLE_DEBUG_ONLY=
 AC_MSG_RESULT([no])
 fi
 AC_SUBST(ENABLE_DEBUG)

Re: [REVIEW][3-5] Re: [[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions

On 20/04/12 14:21, Caolán McNamara wrote:
 On Mon, 2012-04-16 at 17:05 +0200, Michael Stahl wrote:
 i think i've fixed this problem now (and attached your bugdoc,
 slightly enhanced, to fdo#45562 as well), so please consider this for
 libreoffice-3-5, which basically results in painting the borders in
 almost exactly the same places as the old OOo code, and thus looks safe
 to me wrt. layering:

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=5913506b2193e93ca2767ab7365ab2e76ed7848f
 
 Hmm, doesn't apply against 3-5. Is there now a specific sequence of
 patches required against 3-5, or just the above needing to be tweaked ?

ah yes, it requires the patch from the grandparent mail as well, i.e.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1024c172a5bfb3d85a86fcf7a046aa2b03950edd

which is also required for the other border line fix to apply (the one
that merges consecutive lines)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW:3-5] fdo#48356 fix RTF import of special unicode characters

Hi,

See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=69259c6

Regression from 3.4; backported patch attached.

Thanks,

Miklos
From 29f455fc582a609b00a8c8143dd6a420913ebe83 Mon Sep 17 00:00:00 2001
From: Miklos Vajna vmik...@suse.cz
Date: Fri, 20 Apr 2012 12:42:23 +0200
Subject: [PATCH] fdo#48356 fix RTF import of special unicode characters

The \'0d string should not be an exception when ignoring characters
after the \u control word.
---
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 9633176..016943d 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -784,7 +784,7 @@ int RTFDocumentImpl::resolveChars(char ch)
 bool bSkipped = false;
 while(!Strm().IsEof()  ch != '{'  ch != '}'  ch != '\\')
 {
-if (ch != 0x0d  ch != 0x0a)
+if (m_aStates.top().nInternalState == INTERNAL_HEX || (ch != 0x0d  ch != 0x0a))
 {
 if (m_aStates.top().nCharsToSkip == 0)
 {
-- 
1.7.7

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW][3-5] fdo#38215: sw: fix consecutive border line gaps regression

On 20/04/12 14:11, Caolán McNamara wrote:
 On Mon, 2012-04-16 at 17:19 +0200, Michael Stahl wrote:
 this fixes a regression in painting border lines in LO 3.4, leading to
 small visible gaps between borders of consecutive paragraphs, and is
 proposed for libreoffice-3-5.

 fixed by re-implementing the merging of border lines that are less than
 1.5 pixel apart that was done in the old paint implementation.
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=0868a0155a2b57daf7b862d120aead0458372b17
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=44092833d3a0f0d6074c64bd0e64bbdf11109afe
 
 So, looks reasonable to me, except it doesn't apply cleanly to 3-5, can
 you tweak it to apply to 3-5 and we can push that then to 3-5.

it requires this one first:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1024c172a5bfb3d85a86fcf7a046aa2b03950edd

but then i still got a trivial conflict, so i've merged the 2 commits
into one that applies on top of the above, see attachment.

 And why
 the change from ::std::swap to a manual push_back of each line to new
 SequenceAsVector followed by clear on the original ?

because the types of the elements are different, the return value has
uno::Reference of XFooPrimitive while the member is changed to contain
rtl::Reference of BorderLinePrimitive so it's not necessary to
dynamic_cast while iterating over it.
From 0919f42d62b658fc39be1be269fdfea0892f8a2c Mon Sep 17 00:00:00 2001
From: Michael Stahl mst...@redhat.com
Date: Mon, 16 Apr 2012 16:12:36 +0200
Subject: [PATCH] fdo#38215: merge consecutive border lines:

This re-implements the merging that was done by SwLineRects::AddLineRect,
SwLineRect::MakeUnion with the drawing layer border lines.
This is used to merge borders of paragraphs and of tables that have the
separating border-model, which fixes both the tiny dividing gaps
between successive borders in the second bugdoc and the weird subtly
differently rendered successive borders in the first bugdoc.
(regression from 0f0896c26fb260d1bbf31d7a886df3f61837f0f2)

(cherry-picked from 0868a0155a2b57daf7b862d120aead0458372b17
 and 44092833d3a0f0d6074c64bd0e64bbdf11109afe)

Conflicts:

	sw/source/core/layout/paintfrm.cxx
---
 sw/source/core/layout/paintfrm.cxx |  144 +---
 1 files changed, 132 insertions(+), 12 deletions(-)

diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx
index 1fd7013..797f3af 100755
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -132,6 +132,9 @@
 
 using namespace ::editeng;
 using namespace ::com::sun::star;
+using ::drawinglayer::primitive2d::BorderLinePrimitive2D;
+using ::std::pair;
+using ::std::make_pair;
 
 #define GETOBJSHELL()   ((SfxObjectShell*)rSh.GetDoc()-GetDocShell())
 
@@ -223,19 +226,21 @@ public:
 
 class BorderLines
 {
-::comphelper::SequenceAsVector
- ::drawinglayer::primitive2d::Primitive2DReference m_Lines;
+typedef ::comphelper::SequenceAsVector
+::rtl::ReferenceBorderLinePrimitive2D  Lines_t;
+Lines_t m_Lines;
 public:
-void AddBorderLine(
-::drawinglayer::primitive2d::Primitive2DReference const xLine)
-{
-m_Lines.push_back(xLine);
-}
+void AddBorderLine(::rtl::ReferenceBorderLinePrimitive2D const xLine);
 drawinglayer::primitive2d::Primitive2DSequence GetBorderLines_Clear()
 {
 ::comphelper::SequenceAsVector
 ::drawinglayer::primitive2d::Primitive2DReference lines;
-::std::swap(m_Lines, lines);
+for (Lines_t::const_iterator it = m_Lines.begin(); it != m_Lines.end();
+++it)
+{
+lines.push_back(it-get());
+}
+m_Lines.clear();
 return lines.getAsConstList();
 }
 };
@@ -442,6 +447,121 @@ SwSavePaintStatics::~SwSavePaintStatics()
 
 SV_IMPL_VARARR( SwLRects, SwLineRect );
 
+static pairbool, pairdouble, double 
+lcl_TryMergeLines(pairdouble, double const mergeA,
+  pairdouble, double const mergeB)
+{
+double const fMergeGap(nPixelSzW + nHalfPixelSzW); // NOT static!
+if (   (mergeA.second + fMergeGap = mergeB.first )
+ (mergeA.first  - fMergeGap = mergeB.second))
+{
+return make_pair(true, make_pair(
+std::min(mergeA.first, mergeB.first),
+std::max(mergeA.second, mergeB.second)));
+}
+return make_pair(false, make_pair(0, 0));
+}
+
+static ::rtl::ReferenceBorderLinePrimitive2D
+lcl_MergeBorderLines(
+BorderLinePrimitive2D const rLine, BorderLinePrimitive2D const rOther,
+basegfx::B2DPoint const rStart, basegfx::B2DPoint const rEnd)
+{
+return new BorderLinePrimitive2D(rStart, rEnd,
+rLine.getLeftWidth(),
+rLine.getDistance(),
+rLine.getRightWidth(),
+rLine.getExtendLeftStart(),
+rOther.getExtendLeftEnd(),
+

Re: [REVIEW][3-5] fdo#38215: sw: fix consecutive border line gaps regression

On Mon, 2012-04-16 at 17:19 +0200, Michael Stahl wrote:
 this fixes a regression in painting border lines in LO 3.4, leading to
 small visible gaps between borders of consecutive paragraphs, and is
 proposed for libreoffice-3-5.
 
 fixed by re-implementing the merging of border lines that are less than
 1.5 pixel apart that was done in the old paint implementation.

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=0868a0155a2b57daf7b862d120aead0458372b17
http://cgit.freedesktop.org/libreoffice/core/commit/?id=44092833d3a0f0d6074c64bd0e64bbdf11109afe

So, looks reasonable to me, except it doesn't apply cleanly to 3-5, can
you tweak it to apply to 3-5 and we can push that then to 3-5. And why
the change from ::std::swap to a manual push_back of each line to new
SequenceAsVector followed by clear on the original ?

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d5e263a129c56e561ce145bad9749027c583a75
this at least got pushed along with fdo#38635: sw: printing border lines
gaps regression

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][REVIEW][3-5] fdo#38215: sw: fix consecutive border line gaps regression

On Fri, 2012-04-20 at 14:56 +0200, Michael Stahl wrote:
 it requires this one first:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=1024c172a5bfb3d85a86fcf7a046aa2b03950edd
 
 but then i still got a trivial conflict, so i've merged the 2 commits
 into one that applies on top of the above, see attachment.

ok, all done. Pushed to 3-5.

 the types of the elements are different, the return value has
 uno::Reference of XFooPrimitive while the member is changed to contain
 rtl::Reference of BorderLinePrimitive 

Righteo.

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-5][REVIEW 3-5] [REVIEW 3-5-3] fdo#47717, fdo#45562 sw: yet more border painting regressions

On Fri, 2012-04-20 at 14:42 +0200, Michael Stahl wrote:
 On 20/04/12 14:21, Caolán McNamara wrote:
  http://cgit.freedesktop.org/libreoffice/core/commit/?id=5913506b2193e93ca2767ab7365ab2e76ed7848f

 ah yes, it requires the patch from the grandparent mail as well, i.e.
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=1024c172a5bfb3d85a86fcf7a046aa2b03950edd

Right, gotcha. Pushed to 3-5. So the open issue is what we want for
3-5-3 given that its neither fish nor foul, i.e.
c7524ab32f801910673da5c9c68669ada7c98769 should either be backed out or
fixed by the addition of the above two commits ?

In the interests of simplicity +1 from me to merge the required changes
now in 3-5 to 3-5-3

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Asynchronous use of SwHTMLParser - is this needed

On Fri, 2012-04-20 at 13:03 +0200, Eike Rathke wrote:
 Hi Kohei,
 
 On Thursday, 2012-04-19 17:06:43 -0400, Kohei Yoshida wrote:
 
  My question is, do we need to keep this asynchronicity of
  SwHTMLParser, or is it okay to change it into a synchronous call like
  the rest of SvParser uses?
 
 IIRC the intention was to not make the user wait until timeout if a site
 can't be connected or doesn't serve the document. I'd say we should keep
 that.

Ok.  That makes sense.

Unfortunately, keeping this behavior makes removal of SvRefBase from
SvParser non-trivial.  I'll put my work on hold for now.  I might come
back to give it another try later.

If someone is interested, here is my work-in-progress patch.

http://people.freedesktop.org/~kohei/my-attempt-to-remove-svrefbase-from-svparser.diff

plus 

e1520a9d6a9f9bcfcaa332d54892040fe54776c2
a4bc804627b8b21506e9b86fa54d2f7d2525e43e

which were committed earlier then reverted due to a crasher these
changes caused.

Best,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED:3-5][REVIEW:3-5-3] fdo#48356 fix RTF import of special unicode characters

2012-04-20 Thread Andras Timar

Hi,

2012/4/20 Miklos Vajna vmik...@suse.cz:
 Hi,

 See
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=69259c6

The fix works. Our importer always imports unicode. It is a good
question however, why exporter emitted \'0d for č instead of something
reasonable. č is 0x010d or decimal 269, maybe this is where the \'0d
comes from. Ancient, non-unicode rtf readers are still in trouble, but
it is an ultra-low priority issue of course. :)

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Asynchronous use of SwHTMLParser - is this needed

On Fri, 2012-04-20 at 12:39 +0200, Michael Stahl wrote:

  I'm working on removing SvRefBase from SvParser to make its life cycle
  a little more easier to understand.  I've checked the call sites of
  all of its derived classes, and in most of those call sites, we could
  easily replace it with scoped_ptr.  The only exception is the
  SwHTMLParser, where its use involves asynchronous call to parse HTML
  input.  This makes a bit non-trivial to manage its life cycle.
 
 would wrapping a shared_ptr around it work?

Well, it might work, but not without untangling the ref-count
manipulation that SvParser does during the anync call.

http://opengrok.libreoffice.org/xref/core/svtools/source/svrtf/svparser.cxx#596

I haven't wrapped my head around the logic behind these ref-count
changes here, so I'm not 100% sure...

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Application accepting of GSoC

2012-04-20 Thread Коростіль Данило


On 04/20/2012 03:28 PM, Miklos Vajna wrote:

You don't need to do anything between the two, unless you are asked in
private.

Really? I haven't know. I just check main page of GSoC 2012. Thank you.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-5-3] [PUSHED 3-5-3] fdo#48856 update sheet-local named expressions correctly

On Fri, 2012-04-20 at 10:11 +0100, Noel Power wrote:
 On 19/04/12 23:39, Eike Rathke wrote:
  Hi,
 
  Two reviews needed to cherry-pick to 3-5-3
  http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=9a9121929408e8ffc86b91606355ff5fe9514f7d
 
  Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48856
 
 patch looks sane and the test doc works for me +1

I'll sign off on this as well.

Pushed to the 3-5-3 branch.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][REVIEW][3-5] fdo#48647 ugly hairline double border drawing regression

On Wed, 2012-04-18 at 22:28 +0200, Michael Stahl wrote:
 hi all,
 
 today's border line regression fix is for fdo#48647, which is simply
 missing usage of the ClipRegion to clip the hairline border lines, fix
 proposed for libreoffice-3-5:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=49bd0e4e6bb0ed0671de72d84700ddcc49828f69

Pushed to 3-5.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: per library debug builds now possible via ./configure

2012-04-20 Thread Lubos Lunak

On Friday 20 of April 2012, Lubos Lunak wrote:
 On Monday 16 of April 2012, Bjoern Michaelsen wrote:
  On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote:
Is it possible to do the build also the other way around, i.e. e.g.
   all but sc?
 
  Not yet, feel free to add it if you think it is essential.

 ...

   and if I understand the change correctly, I'd have to manually
   find out what all the dependencies actually are. Given that sc/sd/sw
   are the biggest three, it probably even makes the biggest difference to
   disable the two that one does not work on.
 
   ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e
  's/.mk$//'|grep -v sc |grep -v sw`  ./autogen.sh
  --enable-debug=$ALLBUTSCSW
 
  should be enough.

  How about this?

 And one more.

-- 
 Lubos Lunak
 l.lu...@suse.cz
From 42ef01bdc3b1e08ef90dc0d05d1d978b2085a088 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= l.lu...@suse.cz
Date: Fri, 20 Apr 2012 17:26:01 +0200
Subject: [PATCH] if debug symbols are enabled indirectly, make sure they are
 actually built

---
 solenv/gbuild/gbuild.mk |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 8e5141b..a37cb8b 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -105,6 +105,11 @@ endif
 endif
 
 ifneq ($(gb_DEBUGLEVEL),0)
+# if symbols are triggered by something else than --enable-symbols,
+# make sure they are actually enabled
+ifneq ($(gb_SYMBOL),$(true))
+ENABLE_SYMBOLS_FOR = all
+endif
 gb_SYMBOL := $(true)
 endif
 
-- 
1.7.7

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Depends on||46805

--- Comment #294 from tommy27 ba...@quipo.it 2012-04-20 12:04:54 PDT ---
Added Bug 46805 - large autocorrect database make LibO freeze when start typing

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Windows build with ActiveX


Hello

I tried to find the activex dll (so_activex.dll  so_activex64.dll) in my  
latest official install (LibreOffice 3.5.2.2 / Version ID :  
281b639-6baa1d3-ef66a77-d866f25-f36d45f) and did not find it.
I did find it in the latest build of Win-x86@15-Prague_Win32 tinderbox  
though (program subfolder).


Is it intentional we do not provide it by default or not ?

Can someone with another stable Windows build check if it is present under  
program folder  ?



Thank you.

--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW] fdo#48969 ODF import measure conversion regression


this is a funny regression in 3.5, the unit parameters to the
unit conversion function were switched, so it went in the wrong
direction, resulting in tiny font sizes when opening ODF documents
produced my MSOffice (they apparently use some obscure inch unit that
needs converting).

the buggy conversion function sax::Converter::convertDouble was buggy
since it was added many years ago, but it was also unused, until
i cleaned up some code duplication and removed its duplicate
(which did it correctly) with commit
3ca2bef76886450058d1667703aeafe4c2e456c3

proposed fix for libreoffice-3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=84aeb737c7c013c8d98d8c40abfca44f6f70cee8

for good measure (?) i've implemented various additional conversions as
well, no idea why they were unimplemented before:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=62a0b2405798a3be6a4e38652f1da7a685c84bfc

to prevent future calamities of that nature i've added a unit test:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee376102becc16c0c44d23e5eb2a322aadc45197

also, apologies to Radek who i've suspected to be the culprit but upon
closer examination he is innocent :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Windows build with ActiveX

2012-04-20 Thread Andras Timar

Hello Mat,

2012/4/20 Mat M m...@gmx.fr:
 Hello

 I tried to find the activex dll (so_activex.dll  so_activex64.dll) in my
 latest official install (LibreOffice 3.5.2.2 / Version ID :
 281b639-6baa1d3-ef66a77-d866f25-f36d45f) and did not find it.
 I did find it in the latest build of Win-x86@15-Prague_Win32 tinderbox
 though (program subfolder).

 Is it intentional we do not provide it by default or not ?


Yes, it is. We disable it in distro-configs/LibreOfficeWin32.conf
(--disable-activex-component). You can enable it in your own build and
play with it. As Tor mentined in the other thread, it does not work as
one can expect, and it has no maintaner, so in order to avoid numerous
bug reports we simply disable it.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED-3-5, REVIEW-3-5-3] fdo#48969 ODF import measure conversion regression

I cherry-picked the commits into 3-5 branch and added

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=580a7f24c373cd8cf068fc92fdb153025e6d0a1d

for fixing backporting issues.

We need 2 more reviewers to get all that bunch of 4 patches to 3.5.3.
Would be nice to have this regression fixed asap.

F.

On 20/04/12 22:01, Michael Stahl wrote:
 this is a funny regression in 3.5, the unit parameters to the
 unit conversion function were switched, so it went in the wrong
 direction, resulting in tiny font sizes when opening ODF documents
 produced my MSOffice (they apparently use some obscure inch unit that
 needs converting).
 
 the buggy conversion function sax::Converter::convertDouble was buggy
 since it was added many years ago, but it was also unused, until
 i cleaned up some code duplication and removed its duplicate
 (which did it correctly) with commit
 3ca2bef76886450058d1667703aeafe4c2e456c3
 
 proposed fix for libreoffice-3-5:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=84aeb737c7c013c8d98d8c40abfca44f6f70cee8
 
 for good measure (?) i've implemented various additional conversions as
 well, no idea why they were unimplemented before:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=62a0b2405798a3be6a4e38652f1da7a685c84bfc
 
 to prevent future calamities of that nature i've added a unit test:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee376102becc16c0c44d23e5eb2a322aadc45197
 
 also, apologies to Radek who i've suspected to be the culprit but upon
 closer examination he is innocent :)
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Windows build with ActiveX

Le Fri, 20 Apr 2012 22:12:46 +0200, Andras Timar tima...@gmail.com a  
écrit:



Hello Mat,

2012/4/20 Mat M m...@gmx.fr:

Hello

I tried to find the activex dll (so_activex.dll  so_activex64.dll) in  
my

latest official install (LibreOffice 3.5.2.2 / Version ID :
281b639-6baa1d3-ef66a77-d866f25-f36d45f) and did not find it.
I did find it in the latest build of Win-x86@15-Prague_Win32 tinderbox
though (program subfolder).

Is it intentional we do not provide it by default or not ?



Yes, it is. We disable it in distro-configs/LibreOfficeWin32.conf
(--disable-activex-component). You can enable it in your own build and
play with it. As Tor mentined in the other thread, it does not work as
one can expect, and it has no maintaner, so in order to avoid numerous
bug reports we simply disable it.


Michael Meeks will be disappointed :)

So, for now, we are missing an experienced Windows dev who will be pleased  
to face evilish Linux ones :D



Best regards,
Andras



--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SDK] Problem with installing on windows 7

2012-04-20 Thread Zegis

Hello, first of all I wanted to apologize if answer for my question is
obvious but I'm new to community and I still got a long way to go.

I wanted to use LibreOffice sdk for making improvement for my C# program
utilising kinect to navigate in presentation mode, and for java program on
studies, but I got some problems configuring SDK.

System is Windows 7 Professional 64 bit with 1st SP.

At first i run setsdkenv_windows.bat script and writed down all paths script
wanted from me. But then i recieve message:

\LibreOffice_3.5_SDK\sdk\lib was unexpected at this time

I tried to build an example from developer guide with javamaker.exe, but
then application throw error that it can't find sal3.dll. I have these
liblaries in LibreOffice folder. Also I tried to run it through makefile
from GNUmake but windows cmd states that '..' is not recognized as an
internal or external command, operable program or batch file. Make: there is
nothing to do in 'Makefile'.

After that I tried to edit manually setsdkenv_windows.template, but I got
another \LibreOffice_3.5_SDK\sdk\lib was unexpected at this time message.
I wonder if it's caused by spaces in Program Files (x86) folder? Also
after running that javamaker still couldn't find sal3.dll. Nor uwinapi.dll
when I copied sal3.dll to directory.

I tried to add LibreOffice to system path variable but it didn't help.

Could someone tell me what I'm doing wrong, please?

--
View this message in context:
http://nabble.documentfoundation.org/SDK-Problem-with-installing-on-windows-7-tp3927106p3927106.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Windows - Embed Server et al.


Le Thu, 19 Apr 2012 22:14:44 +0200, Mat M m...@gmx.fr a écrit:

Le Thu, 19 Apr 2012 10:03:04 +0200, Noel Grandin n...@peralex.com a  
écrit:



ActiveX/OLE is not compiled into LO on platforms other than Windows.



And what about EmbedServ ? It is needed for OLE Object embedding  
featured under *nix  BSD etc, no ?




Else, how the OLE bits are handled under *nix ?

Yes, I am waiting for an answer here :)

--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Dependencies tree


Hello all

Does anyone already have a script (or binary) which is able to output a  
readable dependencies tree from build.lst files ?


Just to not reinvent the wheel

Any tip welcome, I think the task is not that easy.

regards

--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fix fdo#45848

2012-04-20 Thread Korrawit Pruegsanusak

Hello all,

Please find the attached patch to fix fdo#45848.
I've tested the patch at libreoffice-3.5.2.2 tag on Windows XP, but
not tested on master yet.

Of course, please review and push it to appropriate branch(es). :)

Best Regards,
-- 
Korrawit Pruegsanusak


0001-Fix-fdo-45848.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibO-Dev_3.6_Win~2012-04-20 don't running

2012-04-20 Thread ape

master~2012-04-20_23.02.36_LibO-Dev_3.6.0alpha0_Win_x86;
Windows_NT-5.2sp2;-6.1sp1; MS_VCR-2008 and MS_VCR-2008sp1 are installed.
The program stopped running and reports that it can not find the library
MSVCR, which is installed in the operating system.
http://nabble.documentfoundation.org/file/n3927549/capture_001_21042012_080716.png
 
 The previous version of the program
(master~2012-04-19_22.36.21_LibO-Dev_3.6.0alpha0_Win_x86)is run normally.

--
View this message in context: 
http://nabble.documentfoundation.org/LibO-Dev-3-6-Win-2012-04-20-don-t-running-tp3927549p3927549.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

Hi *,

for the upcoming new version 3.5.3, the RC1 builds now start to be
available on pre-releases. This build is slated to be first release
candidate build on the way towards 3.5.3, please refer to our release
plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to 3.5.2 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-3-release-3.5.3.1.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

Fridrich (following words copyrighted by Thorsten)
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] What to do with old OO.oeg bugs?

2012-04-20 Thread Florian Reisinger


Hi!
I just found a bug, which goes back to the latest OO.org version I have 
(2.3.0). (See bug https://bugs.freedesktop.org/show_bug.cgi?id=48968 )

Which version should I take? Should we introduce OO.org versions?
I thought about it and I think it should be
a) 3.4.6 (The oldest LibO version I tested with
b) OO.org 2.3, because it is the oldest version tested with - Not 
avalable - Take the oldest LibO version available (3.3.0 beta 2)


Is this right?
Please tell me what to do in such a case

--
Bye! | Tschüss!

Florian Reisinger

@Windows 7 x64 SP1
LibreOffice 3.5.2.2 Build-ID: 281b639-6baa1d3-ef66a77-d866f25-f36d45f
LibreOffice Portable 3.4.5 OOO340m1 (Build:502)
OpenOffice Portable 3.2.0 OOO320m12 (Build:9483)
OpenOffice Portable 3.0.0 OOO300m9  (Build:9358)
OpenOffice Portable 2.4.1

@Ubuntu 12.04 x64 (VM)
LibreOffice 3.5.2.2 Build-ID: 281b639-6baa1d3-ef66a77-d866f25-f36d45f
LibreOffice 3.4.6 OOO340m1 (Build:602)
OpenOffice.org 3.2.1 OOO320m18 (Build:9502)
-
Skype: reisi.007

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

2012-04-20 Thread MiguelAngel


El 20/04/12 15:35, Pedro escribió:


Fridrich Strba-3 wrote


(following words copyrighted by Thorsten)



In the spirit of LibreOffice shouldn't these words be licensed under CC by
SA? :)

Just updated successfully to LibreOffice 3.5.3.1 under Windows XP Pro x86
Sp3 ;)

A quick note of recognition to the Devs for fixing the mismatched version
number between the About box and the properties of the exe files under
Windows. It was a small step for development but a (well, not a huge leap :)
) great improvement for update checking (and for security minded Windows
users)

Cheers,
Pedro

--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-ANN-LibreOffice-3-5-3-RC1-test-builds-available-tp3925751p3926034.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


Seems the file:
http://dev-builds.libreoffice.org/pre-releases/win/x86/LibO_3.5.3rc1_Win_x86_helppack_en-US.msi
doesn't download, also en-GB and other, they open as text file,

Some download well, for example: Spanish, Italian.

Miguel Ángel.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

2012-04-20 Thread Thorsten Behrens

MiguelAngel wrote:
 Seems the file:
 http://dev-builds.libreoffice.org/pre-releases/win/x86/LibO_3.5.3rc1_Win_x86_helppack_en-US.msi
 doesn't download, also en-GB and other, they open as text file,
 
Can you try again, added explicit mimetype to httpd conf for
msi/msp/msm ?

Cheers,

-- Thorsten


pgp5w0HGcoZmQ.pgp
Description: PGP signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

2012-04-20 Thread MiguelAngel


El 20/04/12 17:32, Thorsten Behrens escribió:

MiguelAngel wrote:

Seems the file:
http://dev-builds.libreoffice.org/pre-releases/win/x86/LibO_3.5.3rc1_Win_x86_helppack_en-US.msi
doesn't download, also en-GB and other, they open as text file,


Can you try again, added explicit mimetype to httpd conf for
msi/msp/msm ?

Cheers,

-- Thorsten.


Now download properly.

Thanks Thorsten.

Miguel Ángel.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 48333] Path changed to home (as defined in the users options) with File Save As, FileTemplateEdit, ...

https://bugs.freedesktop.org/show_bug.cgi?id=48333

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #13 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-19 23:17:52 PDT ---
This one seems to be more or less concerning the same problem  (or at least an
other aspect) of Bug 48494 - CONFIGURATION: Path settings not persistent

I can confirm reported problem with latest WIN Master Builds.

@Bjoern: This is a Master bug related to the completely new file dialog, that
can't be checked with 3.5

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45953] Incorrectly printing of documents when paper size in LO is not the default of the printer

https://bugs.freedesktop.org/show_bug.cgi?id=45953

--- Comment #3 from Matthias Pronk libreoff...@masida.nl 2012-04-19 23:57:54 
PDT ---
@ laur...@gmail.com
Yes, you can select the paper size in the Format/Page menu. However, I think
this information is not send to the printer driver, because the printer
output is clipped.
If the paper size would be correctly recognized by the printer driver I don't
think there would be any problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48597] Calc cell content starting with Thai character is right-aligned by default

https://bugs.freedesktop.org/show_bug.cgi?id=48597

--- Comment #2 from panyaz...@gmail.com 2012-04-20 00:03:42 PDT ---
It is the same as the last part of the original report of Bug 48431. Confirmed
it's a duplicate. Awiting for 3.5.3 to see this bug fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #291 from Cor Nouws c...@nouenoff.nl 2012-04-20 00:25:44 PDT ---
(In reply to comment #289)
 Should I add more bugs (I can easily add a 100 more).

Yes and no. 

Bugs that belong here, pls do. 
However: I do not believe in doing it 'easily'. 
Since, steps in the correct work flow are:
 - reproduce, 
 - test impact, workarounds,
 - query BugZilla for related and the same or closely related issues 
   which may lead to do some bundling of issues
 - in case of doubt, consult others via the QA list

But any bug that is really a problem, and that is not yet visible here: pls do.
We have had issues in the past, that were in BugZilla for months, turned out to
be very nasty, and were not recognised fast enough, but discovered just because
I (or someone else) was confronted with a similar problem and did the work in
BugZilla.
So finding those bugs, is important and more helpful than adding just a load of
bug numbers to this MAB.
Thanks for your help!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48951] New: PRINTING: bulk letter print gives the letter page and a second empty page

https://bugs.freedesktop.org/show_bug.cgi?id=48951

 Bug #: 48951
   Summary: PRINTING: bulk letter print gives the letter page and
a second empty page
Classification: Unclassified
   Product: LibreOffice
   Version: unspecified
  Platform: Other
OS/Version: All
Status: UNCONFIRMED
 Status Whiteboard: BSA
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: klocke...@web.de


Problem description: 

Steps to reproduce:
1. create a bulk letter (with Calc database)
2. print it
3. get 2 pages instead of one. The second one is empty

Current behavior:
bulk letter has two pages instead of one. Second one is empty.
My letter has 13 recipients but the printer produces 25 pages instead of 13. 

Expected behavior:
bulk letter should have only one printed page

Platform (if different from the browser): 

Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101
Firefox/11.0

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #292 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-20 00:33:53 PDT ---
@dE, Sasha, Cor:
For discussions we have libreoff...@lists.freedesktop.org, please stop
discussion here immediately! Same concerning discussion concerning relevance of
bugs, discuss that in the bugs, not here. Tis Bug is only to be used for
purposes as per Petr's report. All those 28 Users listed in CC do not want to
read any of your thoughts!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48692] Writer corrupts large tables

https://bugs.freedesktop.org/show_bug.cgi?id=48692

mike.sy...@acm.org changed:

   What|Removed |Added

Summary|Importing large .doc file   |Writer corrupts large
   |causes loop |tables

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47752] Broken UI components.

https://bugs.freedesktop.org/show_bug.cgi?id=47752

--- Comment #5 from Petr Mladek pmla...@suse.cz 2012-04-20 00:55:58 PDT ---
screenshot usually best describes these type of problems. If is only a few
pixel problem, it is good to create red circle around the problematic location.
You might use gimp to create the circle.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48692] Writer corrupts large tables

https://bugs.freedesktop.org/show_bug.cgi?id=48692

--- Comment #15 from mike.sy...@acm.org 2012-04-20 01:03:32 PDT ---
Title changed to be less misleading.

I can confirm that Roman's experience matched mine very closely.

However, it should be borne in mind that at some size, a background task
becomes uninterruptible besides taking all the CPU it can get. A lot of
pagination has to be done on such a large table; could it be anything to do
with that?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45260] EDITING: Pasted object not same position w.r.t. original object if border thickness greater 0

https://bugs.freedesktop.org/show_bug.cgi?id=45260

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|minor   |major
 CC||LibreOffice@bielefeldundbus
   ||s.de, r...@novell.com
 Ever Confirmed|0   |1
   Keywords||regression

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-20 01:40:23 PDT ---
[Reproducible] with LibreOffice 3.5.2.2 German UI/Locale [Build-ID:
281b639-6baa1d3-ef66a77-d866f25-f36d45f] on German WIN7 Home Premium (64bit):

1. open attached BUGTEST3.odg 
2. Click one of the yellow thick lines
3. control+x for cut
4. control+v for paste
   Expected: now line is at the same place as before
   Actual: for me some mm shifted to left and some mm to top

Same in Current 3.6 Master

Works fine with 3.4.5, so REGRESSION.

[Reproducible] with server-Installation of  LibreOffice 3.5.0 Beta1 - WIN7
Home Premium (64bit) German UI [Build-ID:
7362ca8-b5a8e65-af86909-d471f98-61464c4] Windows_Release_Configuration 
11-Dec-2011 06:51 

Still worked fine with 3.5.0 Beta0


AFAIR in that area we had the fix for Bug 42227. I have a very vague suspect
that the problem might be related to the commit.

For some use this might be a minor problem, but for many others (like mine) it
makes DRAW unusable, for example if you create complex objects by copy 7 paste
/ rotate / flip or if you simply want to get the object into a different layer
and and and ...

@Radek:
Please set Status to ASSIGNED and add yourself to Assigned To if you accept
this Bug

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45260] EDITING: Pasted object not same position w.r.t. original object if border thickness greater 0

https://bugs.freedesktop.org/show_bug.cgi?id=45260

--- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-20 01:41:21 UTC ---
Created attachment 60369
  -- https://bugs.freedesktop.org/attachment.cgi?id=60369
Sample Document

See Comment 2 how to use!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45260] EDITING: Pasted object not same position w.r.t. original object if border thickness greater 0

https://bugs.freedesktop.org/show_bug.cgi?id=45260

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

Version|LibO 3.5.0 RC1  |LibO 3.5.0 Beta1

--- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-04-20 01:42:10 PDT ---
Version due to research results

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48953] New: EDITING: wrong value for pasted date in ambiguous format (e.g. 02-06-2012 becomes 02-06-JJ)

https://bugs.freedesktop.org/show_bug.cgi?id=48953

 Bug #: 48953
   Summary: EDITING: wrong value for pasted date in ambiguous
format (e.g. 02-06-2012 becomes 02-06-JJ)
Classification: Unclassified
   Product: LibreOffice
   Version: LibO 3.5.0 Release
  Platform: x86 (IA32)
OS/Version: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Spreadsheet
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: tis...@gmail.com


Created attachment 60370
  -- https://bugs.freedesktop.org/attachment.cgi?id=60370
Screenshot of pasted 01-02-2012 (February 1, 2012; dd-mm-) in LibreOffice
Calc version 3.5.2 dutch (nl) locale

When pasting a date (e.g. 02-06-2012) with an ambiguous format (dd-mm-),
LibreOffice Calc pastes a value 02-06- (in dutch locale year=jaar, hence
the J) and displays 02-06-JJ.

When pasting a date (e.g. 13-06-2012) with an unambiguous format (again
dd-mm-), LibreOffice Calc pastes the correct value and displays 13-06-12.

First seen this bug in LibreOffice 3.5.0 Release, still a bug in LibreOffice
3.5.2 Release. Always used dutch (nl) locale.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47752] Broken UI components.